| iurygregory | good morning janders and Ironic o/ | 06:09 |
|---|---|---|
| cenne | Good morning iurygregory, janders, ironic 🌄 | 06:22 |
| iurygregory | morning cenne o/ | 06:23 |
| cenne | hey iurygregory o/ | 06:24 |
| arne_wiebalck | Good morning janders iurygregory cenne and Ironic! | 06:37 |
| iurygregory | hey arne_wiebalck o/ | 06:38 |
| cenne | morning arne_wiebalck | 06:38 |
| *** rpittau|afk is now known as rpittau | 07:41 | |
| rpittau | good morning ironic! o/ | 07:41 |
| iurygregory | morning rpittau o/ | 07:42 |
| rpittau | hey iurygregory :) | 07:42 |
| cenne | good morning rpittau. | 07:59 |
| iurygregory | ajya, hey o/ I was looking at http://redfish.dmtf.org/schemas/v1/EventService.v1_5_0.json I have an R640 with iDRAC9 4.40.10.00 (http://paste.openstack.org/show/806812/ ) I don't see some information like SMTP RegistryPrefixes ResourceTypes | 08:06 |
| ajya | hi iurygregory, yes, it's not implemented, version number does not guarantee that it will be implemented, something else from v.1.5 could be. | 08:08 |
| iurygregory | ajya, I see! so using RegistryPrefixes and ResourcesTypes wouldn't be fully supported for creating subscriptions correct? | 08:08 |
| ajya | correct | 08:08 |
| iurygregory | ajya, ack tks! | 08:09 |
| ajya | iurygregory: I've asked firmware team about supporting this, currently no ETA. | 08:10 |
| iurygregory | ajya, no worries =) I was asked to check things in Redfish 1.8.0+ so I think it will work the approach of not using RegistryPrefixes ResourceTypes for subscriptions =) | 08:11 |
| opendevreview | cenne proposed openstack/ironic master: [WIP] Add `boot_mode` and `secure_boot` to node object https://review.opendev.org/c/openstack/ironic/+/797055 | 08:45 |
| cenne | Hey iurygregory, can you help me out? Having some trouble with sqlalchemy (in my latest patch) | 09:00 |
| cenne | Have a few questions | 09:01 |
| opendevreview | Riccardo Pittau proposed openstack/ironic bugfix/18.0: Fix node detail instance_uuid request handling https://review.opendev.org/c/openstack/ironic/+/797211 | 09:03 |
| iurygregory | cenne, sure let me take a look at the patch | 09:03 |
| opendevreview | Riccardo Pittau proposed openstack/ironic stable/wallaby: Fix node detail instance_uuid request handling https://review.opendev.org/c/openstack/ironic/+/797212 | 09:03 |
| rpittau | is it me or gerrit feels particularly slow today? | 09:03 |
| rpittau | well, gerrit ui at least | 09:04 |
| iurygregory | rpittau, for me it's always slow :D | 09:04 |
| iurygregory | is* | 09:04 |
| rpittau | heh, ok slower! :D | 09:04 |
| iurygregory | 30sec is valid =P | 09:04 |
| opendevreview | Riccardo Pittau proposed openstack/ironic stable/victoria: Fix node detail instance_uuid request handling https://review.opendev.org/c/openstack/ironic/+/797253 | 09:04 |
| iurygregory | more than that we should probably ask infra is there is some problem | 09:04 |
| iurygregory | cenne, just wondering are you able to run the local tests in your env? pep8, py36 ? | 09:05 |
| cenne | iurygregory: thanks | 09:05 |
| cenne | I am able to run tests yes. Do you want me to send the logs? | 09:05 |
| iurygregory | cenne, it's ok =) the patch you are talking about is https://review.opendev.org/c/openstack/ironic/+/797055 ? | 09:06 |
| cenne | Yes. That one exactly | 09:06 |
| cenne | iurygregory: the tests run (and fail). it seems the db is not getting updated with a key i am adding | 09:08 |
| iurygregory | cenne, I think you are missing the upgrade to add the new columns to the DB | 09:09 |
| iurygregory | something like https://review.opendev.org/c/openstack/ironic/+/786707/18/ironic/db/sqlalchemy/alembic/versions/2bbd96b6ccb9_add_bios_fields_from_registry.py | 09:10 |
| iurygregory | if I recall this can be done via ironic-db-sync command | 09:11 |
| iurygregory | you need to create a venv locally and run the command | 09:11 |
| iurygregory | rpittau, do you remember the syntax for this? ^ | 09:11 |
| cenne | That's supposed to be utogenerated right? I tried running ./ironic/cmd/dbsync.py (Couldn't get it to work) Am I supposed to run it manually? | 09:12 |
| cenne | *autogenerated | 09:12 |
| cenne | oh ok. thanks, i'll try ironic-db-sync | 09:13 |
| rpittau | it's ironic-dbsync | 09:13 |
| rpittau | for the online data migrations | 09:13 |
| rpittau | you should find something more in the README file under the alembic dir | 09:14 |
| rpittau | cenne, iurygregory: https://opendev.org/openstack/ironic/src/branch/master/ironic/db/sqlalchemy/alembic/README | 09:14 |
| cenne | Thanks. :). I'm running it now. Will look at the readme too. | 09:15 |
| opendevreview | Arne Wiebalck proposed openstack/ironic-python-agent master: Only mount the ESP if not yet mounted https://review.opendev.org/c/openstack/ironic-python-agent/+/796045 | 10:11 |
| janders | hey iurygregory arne_wiebalck cenne ajya rpittau and Ironic o/ | 10:38 |
| iurygregory | janders, o/ | 10:39 |
| ajya | hi, janders | 10:41 |
| rpittau | Hey janders :) | 10:56 |
| cenne | Hi janderz | 10:57 |
| cenne | *hi janders | 10:57 |
| cenne | rpittau, iurygregory: On doing `ironic-dbsync upgrade`: "The database version is not compatible with this release of ironic (17.1.0.dev98)." | 11:02 |
| cenne | I had checked out from master branch which is on v18 i think. Am I supposed to rebase this patch to a previous release? | 11:02 |
| iurygregory | maybe you don't have the latest ironic code.. | 11:03 |
| iurygregory | save the changes you did and try to checkout to master, git pull, git checkout yourbranch, git rebase -i master | 11:03 |
| cenne | okay! on it. thanks :) | 11:04 |
| rpittau | I don't have the docs in front of me as I'm at lunch, but I think you're not supposed to use upgrad in this case | 11:07 |
| cenne | :( same error | 11:09 |
| cenne | The database version is not compatible with this release of ironic (17.1.0.dev98). This can happen if you are attempting to upgrade from a version older than the previous release (skip versions upgrade). This is an unsupported upgrade method. Please run "ironic-dbsync upgrade" using the previous releases for a fast-forward upgrade. | 11:09 |
| cenne | oh. enjoy your lunch rpittau. :) | 11:10 |
| janders | do you know of any support for tuning http client in RedFish BMC? Thinking optimising the http client in the BMC for higher performance on faster links, or trying to optimise it for longer latency for remote deployments. mraineri I was told you may be able to help. Thanks! :) | 11:43 |
| janders | see you tomorrow Ironic o/ | 11:48 |
| rpittau | cenne: I suggest checking this page https://docs.openstack.org/ironic/latest/cli/ironic-dbsync.html, I think the right command is "revision" | 12:12 |
| opendevreview | Dhuldev Valekar proposed openstack/ironic master: Update the clear job id's constant https://review.opendev.org/c/openstack/ironic/+/796432 | 12:13 |
| TheJulia | cenne: perhaps the wrong parent revision in your change? | 13:19 |
| cenne | TheJulia: Do you mean in the revision file? | 13:20 |
| cenne | Even when I do `ironic-dbsync upgrade` in master, it gives me the same error. So I am not sure it's related to any of my changes at all.. | 13:21 |
| cenne | Maybe my environment is wrong? I am using the one made by tox 😬 | 13:23 |
| TheJulia | umm, hmm | 13:23 |
| cenne | - py3 / debug | 13:23 |
| cenne | And Good Morning! TheJulia :) | 13:25 |
| rpittau | cenne: have you seen my message? "upgrade" is not the correct command for what you're doing, you need "revision" | 13:26 |
| cenne | rpittau. Yes. I've done reviosin --message to make the revision file and filled it manually (--autogenerate was erroring out) | 13:27 |
| cenne | *revision | 13:27 |
| arne_wiebalck | Is it normal that automatic TLS throws a CA verify error (or am I missing some config)? http://paste.openstack.org/show/806823/ | 13:28 |
| cenne | also did online_data_migrations | 13:28 |
| cenne | rpittau: even with online_migrations it keeps saying: "The database version is not compatible with this release of ironic (17.1.0.dev98). This can happen if you are attempting to upgrade from a version older than the previous release (skip versions upgrade). This is an unsupported upgrade method. Please run "ironic-dbsync upgrade" using the previous releases for a | 13:29 |
| cenne | fast-forward upgrade." | 13:29 |
| TheJulia | hmmm | 13:31 |
| rpittau | you don't need anything else, just revision plus the message, that should create the new version upgrade file | 13:31 |
| TheJulia | did ironic create your database? | 13:31 |
| * TheJulia needs lots of coffee this morning | 13:34 | |
| ajya | arne_wiebalck: we have seen occasional TLS verification errors, but never got to why they happen, after while they're gone. Was thinking maybe something about setup - mismatch with ironic/IPA versions. | 13:34 |
| arne_wiebalck | ajya: thanks, should be all on Victoria | 13:35 |
| arne_wiebalck | ajya: everything seems to work, so apparently the retry around the command seeems to handle this | 13:36 |
| TheJulia | I wonder if it is a race in the CA infomration hand-off | 13:36 |
| arne_wiebalck | TheJulia: I can understand the IPA cannot verify the cert since it is self-signed :) | 13:37 |
| TheJulia | and I thought the signing ca cert gets handed over as well | 13:37 |
| ajya | in our case it was failing cleaning or deploy, but never got further as couldn't reproduce in other environments, and maybe it was red herring, anyway | 13:37 |
| arne_wiebalck | it is get_clean_steps | 13:38 |
| arne_wiebalck | in our case | 13:38 |
| arne_wiebalck | but everything continues after, which makes me think the surrounding retry catches it | 13:39 |
| arne_wiebalck | having an ERROR line in the logs on every cleaning is not nice, though | 13:39 |
| TheJulia | no, that doesn't seem right | 13:40 |
| cenne | rpittau: when i do `ironic-dbsync revision -m "add boot_mode and secure_boot"` this file is generated : http://paste.openstack.org/show/806825/ | 13:40 |
| rpittau | cenne: I think we're talking about different things, you need to generate a migration script for your change, right? the ironic-dbsync works only if you have an ironic db in place, otherwise you need to use a more manual process | 13:40 |
| cenne | rpittau: as you can see the upgrade fun there is empty. | 13:40 |
| TheJulia | cenne: yeah, you have to write it :\ | 13:41 |
| rpittau | oh ok yeah, that's correct actually | 13:41 |
| cenne | rpittau: yes. generating a migration script for my change. | 13:41 |
| TheJulia | it doesn't recognize the change in the db model and do it for you | 13:41 |
| rpittau | ok cool than as TheJulia said you need now to finish that yourself | 13:41 |
| arne_wiebalck | TheJulia: the cert is stored on the conductor side but not re-used on subsequent cleaning, is it? I mean, it is overwritten by the first heartbeat every time. | 13:42 |
| TheJulia | hmm, unfortunately I'm not 100% sure on that code | 13:43 |
| TheJulia | I'm also just waking up | 13:43 |
| arne_wiebalck | :) | 13:44 |
| cenne | TheJulia, so I did write the migration steps in the revision file ( by looking at previous migrations). Am I supposed to do something else before running the tests? | 13:49 |
| TheJulia | I don't believe so | 13:50 |
| cenne | hmm. | 13:52 |
| TheJulia | Review Jam anyone? Items are on the agenda | 14:00 |
| TheJulia | https://meetpad.opendev.org/ironic | 14:00 |
| TheJulia | Anyone else for review jam? | 14:02 |
| opendevreview | cenne proposed openstack/ironic master: [WIP] Add `boot_mode` and `secure_boot` to node object https://review.opendev.org/c/openstack/ironic/+/797055 | 14:04 |
| iurygregory | I can't join (downstream meeting) | 14:17 |
| opendevreview | Merged openstack/ironic bugfix/18.0: Fix node detail instance_uuid request handling https://review.opendev.org/c/openstack/ironic/+/797211 | 14:18 |
| TheJulia | iurygregory: is there a better day/time to hold review jams? | 14:34 |
| TheJulia | I ask because it feels like the steam got completely let out of the review jam on monday morning and I think that is hurting overall review velocity | 14:35 |
| TheJulia | iurygregory: we need to cut an 18.0.x release ^ | 14:35 |
| TheJulia | rpittau: still up for running the meeting today? | 14:37 |
| rpittau | TheJulia: yes! | 14:37 |
| TheJulia | \o/ | 14:37 |
| rpittau | and sorry for the review jam, the time is ok for me, but sometimes we have confliclting downstream meetings | 14:37 |
| TheJulia | No need to apologize, these things happen :) | 14:38 |
| TheJulia | I'm just wondering if there is a day which avoids these? | 14:40 |
| rpittau | mmm not sure, maybe tuesday at the same time | 14:42 |
| iurygregory | TheJulia, for me it only happens from time to time the meetings hehe | 14:44 |
| iurygregory | yeah tuesday would work better for me also | 14:44 |
| TheJulia | I could do tuesdays as well | 14:47 |
| TheJulia | Added to the meeting agenda for a quick discussion | 14:47 |
| rpittau | ok | 14:57 |
| rpittau | #startmeeting ironic | 15:00 |
| opendevmeet | Meeting started Mon Jun 21 15:00:07 2021 UTC and is due to finish in 60 minutes. The chair is rpittau. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:00 |
| opendevmeet | The meeting name has been set to 'ironic' | 15:00 |
| TheJulia | o/ | 15:00 |
| erbarr | o/ | 15:00 |
| rpioso | \o | 15:00 |
| stendulker | o/ | 15:00 |
| rpittau | Hello everyone! Welcome to our weekly meeting! | 15:00 |
| ajya | o/ | 15:00 |
| cenne | o/ | 15:01 |
| rpittau | I will be your host today :) | 15:01 |
| rpittau | Our agenda can be found on the wiki | 15:01 |
| rpittau | #link https://wiki.openstack.org/wiki/Meetings/Ironic#Agenda_for_next_meeting | 15:01 |
| iurygregory | o/ | 15:01 |
| arne_wiebalck | o/ | 15:01 |
| rpittau | I think we have the quorum, so let's move on! | 15:02 |
| rpittau | #topic Announcements / Reminders | 15:02 |
| rloo | o/ | 15:02 |
| JayF | o/ | 15:02 |
| rpittau | we don't have any announcement or reminder in the agenda this week | 15:02 |
| rpittau | Anyone has anything to announce today? | 15:03 |
| TheJulia | I've got nothing | 15:03 |
| rpittau | yep, doesn't look like we have anything | 15:04 |
| rpittau | onward! | 15:04 |
| rpittau | #topic Review action items from previous meeting | 15:04 |
| rpittau | I don't see any action items from last week, so let's move forward | 15:04 |
| rpittau | #topic Review subteam status reports | 15:04 |
| rpittau | #link https://etherpad.opendev.org/p/IronicWhiteBoard | 15:04 |
| rpittau | around L65 | 15:05 |
| rpittau | docs for anaconda deploy interface have merged \o/ | 15:07 |
| TheJulia | \o/ | 15:07 |
| TheJulia | I guess that just leaves CI for it | 15:08 |
| rpittau | do we want to remove the iscsi removal task? it's completed | 15:08 |
| TheJulia | ++ | 15:08 |
| rpittau | arne_wiebalck: any update on the node error history ? | 15:08 |
| arne_wiebalck | rpittau: nope, sorry | 15:08 |
| rpittau | np :) | 15:08 |
| TheJulia | I suspect it needs to be rebased at this point | 15:08 |
| rpittau | probably | 15:09 |
| TheJulia | we've got a few different efforts seeking to make db changes, we should likely sort them out | 15:09 |
| rpittau | yes, makes sense | 15:09 |
| rpittau | janders: if you see this during your day, any updates on enhancing storage claening (L98) ? | 15:10 |
| rpittau | iurygregory: I guess no updates for privsep | 15:11 |
| iurygregory | rpittau, yeah, I'm wondering if we talked about it last week ( I was sick on monday) | 15:11 |
| rpittau | iurygregory: we didn't | 15:11 |
| rpittau | iurygregory: I see the last comment in the patch is from a week ago | 15:13 |
| iurygregory | yeah I just saw the comment also | 15:14 |
| TheJulia | would discussing it on review jam help things or are things still too early with it? | 15:14 |
| rpittau | maybe we can discuss during this week | 15:14 |
| iurygregory | but I don't quite understand if we can remove privsep out of the picture to call directly | 15:14 |
| rpittau | I don't think we can remove it entirely | 15:14 |
| iurygregory | that would probably work re review jam | 15:15 |
| TheJulia | iurygregory: maybe add to tomorrow's agenda? | 15:15 |
| rpittau | alright | 15:15 |
| iurygregory | yup will do | 15:15 |
| TheJulia | since your up a little later typically | 15:15 |
| TheJulia | s/up/on/ | 15:15 |
| rpittau | I'll try to be there as well | 15:15 |
| iurygregory | yeah =) | 15:16 |
| rpittau | ok, I think we're good with the status update | 15:16 |
| rpittau | moving on! | 15:16 |
| rpittau | #topic Deciding on priorities for the coming week | 15:16 |
| rpittau | #link https://tinyurl.com/ironic-weekly-prio-dash | 15:16 |
| rpittau | we have a couple of patches in merge conflict in the prios | 15:17 |
| TheJulia | I'll revise the db stack this morning | 15:17 |
| TheJulia | was waiting until after meetings for a clear mind | 15:18 |
| rpittau | yep | 15:18 |
| rpittau | I added this https://review.opendev.org/c/openstack/ironic/+/796879 | 15:18 |
| TheJulia | ack | 15:18 |
| TheJulia | sounds good to me | 15:18 |
| TheJulia | Anything else out there, new patches on sushy? ironic-lib? ipa? | 15:19 |
| rpittau | does anyone has anything to add to the priorities for this week ? | 15:19 |
| arne_wiebalck | two small ones: | 15:19 |
| arne_wiebalck | https://review.opendev.org/c/openstack/ironic-python-agent/+/796045 | 15:19 |
| arne_wiebalck | https://review.opendev.org/c/openstack/ironic-python-agent/+/796882 | 15:20 |
| iurygregory | sounds good to me | 15:20 |
| rpittau | arne_wiebalck: feel free to add the ironic-week-prio tag :) | 15:20 |
| TheJulia | added | 15:20 |
| rpittau | thanks | 15:20 |
| arne_wiebalck | thanks | 15:21 |
| rpittau | alright, looks good | 15:21 |
| rpittau | onward! | 15:21 |
| rpittau | #topic Discussion | 15:21 |
| rpittau | TheJulia: I see you have 2 topics to discuss :) | 15:22 |
| TheJulia | Yes! | 15:22 |
| TheJulia | The first item is in regards to Secure RBAC | 15:22 |
| rpittau | reading | 15:23 |
| TheJulia | Specifically, in order to have the tempest suite be able to test aspects, we need to toggle permissions. An enforce scope option can be added, but the question kind of if we want to go beyond the minimal and have specific tests or not. I anticipate we may end up having to update all of the tests, eventually | 15:23 |
| TheJulia | but we're just not there yet as a community. | 15:23 |
| rpittau | so that means having the same job with different permissions? | 15:23 |
| TheJulia | So I guess the question for discussion is how far do we want to go | 15:24 |
| TheJulia | So basically, today jobs get a project admin's permissions. Thats fine for some things, but not all things. | 15:24 |
| TheJulia | When we go to remove legacy policies, it is going to break some of the existing jobs, so the question comes down to do we duplicate those jobs now, or just make it so they are togglable | 15:25 |
| JayF | I'm not sure I fully undesrtand what you mean by toggleable | 15:25 |
| rpittau | ok, so in the long run we won't actually ahve duplicates | 15:25 |
| iurygregory | duplicate jobs doesn't sound like a good plan | 15:25 |
| TheJulia | Dupes has led us down a path of insanity | 15:26 |
| rpittau | well... yeah | 15:26 |
| TheJulia | JayF: basically, switch saying "Jobs run with scope restrictions, so the internal baremetal client gets system admin privs instead | 15:26 |
| TheJulia | " | 15:26 |
| TheJulia | That is kind of the idea being floated in nova as well | 15:26 |
| JayF | I have no opinion as long as we test both scenarios appropriately... it's not OK for our tempest tests to not exercise RBAC | 15:27 |
| rloo | so we want the tests to continue to pass (we aren't testing rbac working or not) | 15:27 |
| rloo | oh, jay disagrees. | 15:27 |
| JayF | If it doesn't run in the gate, it's going to be broken, just a matter of when :) I think TheJulia is onboard with that, it's just a question of implementation IAUI | 15:27 |
| TheJulia | so, it is different user rights that we need to account for, it is not about if we we exercise rbac or not | 15:27 |
| rpittau | I tend to agree with JayF on this | 15:28 |
| rloo | i agree with TheJulia :D | 15:28 |
| rpittau | we have a standoff! | 15:28 |
| JayF | The person actually doing the vote gets a couple dozen extra votes as far as I'm concerned | 15:28 |
| TheJulia | JayF: I am, and I'm trying to figure out how much pain I'm in for :) | 15:28 |
| TheJulia | rpittau: I think we're just using different words | 15:28 |
| JayF | s/vote/work/ | 15:28 |
| rloo | also, if we want to test rbac outside of unit tests, maybe add the 'negative' tests for rbac. those should fail really quickly. (or succeed if the test is that they fail. if you know what i mean.)( | 15:28 |
| TheJulia | rloo: yeah, that is a whole other thing that I'm hoping appears soon() | 15:29 |
| TheJulia | I *think* some of the contractual tests can handle that cleanly with the current state of the plugin | 15:29 |
| rloo | maybe a concrete example. pick a test that will need to be 'toggled' or whatever, to run. | 15:29 |
| TheJulia | Just they won't pass on older versions but we added an API flag to identify when the capability was introduced | 15:29 |
| TheJulia | I think if we could run just basic baremetal ops in either mode, it would have us mostly covered until we move to rip out the older policies | 15:30 |
| TheJulia | actually, we have an indicator, we *could* just make the jobs figure it out | 15:31 |
| TheJulia | at the same time, doing that also means we're going to not be testing one until we rip the old policies out | 15:32 |
| TheJulia | which is a bad idea | 15:32 |
| TheJulia | I guess duplicate scenario jobs is kind of the way to go, or at least one? | 15:32 |
| rpittau | so we should test old AND new until we remove the old policies | 15:32 |
| TheJulia | agreed | 15:32 |
| rpittau | not sure we can avoid duplicates fi we want to do this then :/ | 15:33 |
| TheJulia | Okay, I think I have what I need to orient on that | 15:33 |
| TheJulia | Second topic was a question if we wanted to move the EU friendly review jam to Tuesday at the same time instead of before the weekly project meeting. | 15:33 |
| TheJulia | Any objections? | 15:33 |
| TheJulia | This would put both review jams on Tuesdays | 15:34 |
| iurygregory | +1 from me | 15:34 |
| rpittau | it's good for me, fewer conflicts with downstream stuff | 15:34 |
| TheJulia | Okay, then lazy consensus seems to go with that | 15:35 |
| rpittau | let's give that a try | 15:35 |
| TheJulia | Starting next week :) | 15:35 |
| rpittau | I'll be out lol | 15:35 |
| TheJulia | #agreed Moving EU review jam to Tuesday starting next week. | 15:35 |
| rpittau | thanks! | 15:36 |
| rpittau | we don't have other planned discussions for today | 15:36 |
| rpittau | let's move on | 15:36 |
| rpittau | #topic Baremetal SIG | 15:36 |
| rpittau | #link https://etherpad.opendev.org/p/bare-metal-sig | 15:36 |
| arne_wiebalck | Next meeting on July 13th, planned: an intro to bifrost from TheJulia | 15:37 |
| rpittau | sounds great :) | 15:37 |
| arne_wiebalck | it does :) | 15:37 |
| arne_wiebalck | If you have suggestions for further topics, let me know. | 15:37 |
| TheJulia | what time was that | 15:37 |
| arne_wiebalck | I think that is it. | 15:37 |
| cenne | woo ! | 15:37 |
| arne_wiebalck | 2pm UTC | 15:37 |
| ajya | re EU friendly time - it would conflict with this SIG once a month | 15:38 |
| rpittau | and that conflicts with the review jam! We found a bug :P | 15:38 |
| ajya | skip those weeks? | 15:38 |
| TheJulia | 7am local. \o/ | 15:38 |
| TheJulia | ajya: ugh, yeah, it would :\ | 15:38 |
| TheJulia | I guess we can skip those weeks. We run another jam 2 hours later which should be fine? | 15:38 |
| arne_wiebalck | We can also move the SIG to one hour later if that is too early in general? | 15:38 |
| rpittau | or we can have a shorter review jam ? | 15:39 |
| TheJulia | Possibly | 15:39 |
| TheJulia | I think it is good to give the SIG a little time though | 15:39 |
| rpittau | arne_wiebalck: that wouldn't work for me :/ | 15:39 |
| arne_wiebalck | rpittau: oh, ok | 15:39 |
| TheJulia | I think it just makes sense to skip the EU review jam on mornings where we have the isg | 15:39 |
| TheJulia | s/isg/sig/ | 15:39 |
| rpittau | ok | 15:39 |
| ajya | arne_wiebalck: for me either | 15:39 |
| * arne_wiebalck will not touch the SIG slot :) | 15:39 | |
| rpittau | thanks :) | 15:40 |
| rpittau | alright, let's move forward | 15:40 |
| rpittau | #topic RFE review | 15:40 |
| rpittau | I don't see anything planned, but in case someone has an RFE to discuss ? | 15:41 |
| rpittau | it's not the case it seems | 15:41 |
| rpittau | #topic Open discussion | 15:41 |
| ajya | sushy question - run into case where it would be useful to access other resources outside of Links relation, in this case, access TaskService from unrelated resource. Would it be possible to update sushy so that each resource has access to other resources? E.g., having access to their parent resource and walk there till root, etc., or pass reference to root around similar | 15:41 |
| ajya | way registries are now passed around (even, replace registries with root). | 15:41 |
| TheJulia | would that require loading the other resource? | 15:43 |
| TheJulia | I *suspect* it would, how else would you know it is there | 15:43 |
| TheJulia | Which I think would lead to performance implications | 15:43 |
| ajya | that resource should be already loaded | 15:44 |
| ajya | so would need to ensure that it's not creating new instance, just a reference | 15:44 |
| TheJulia | I think it would come down to implementation details | 15:45 |
| ajya | it's not like loading all possible resources, only the ones already "walked" | 15:45 |
| TheJulia | yeah | 15:45 |
| TheJulia | If it is not walking things automatically that may not be needed and doesn't explicitly require it to be pre-walked, then I guess it could be okay, but use/access model in terms of implementation details would be key | 15:46 |
| ajya | I can propose patch and see how it turns out | 15:47 |
| rpittau | it sounds ok in general, maybe add a story in storyboard with some details? | 15:47 |
| ajya | if idea generally seems ok | 15:47 |
| TheJulia | An example of use would likely help | 15:47 |
| rpittau | yep | 15:47 |
| ajya | ok | 15:48 |
| rpittau | FYI I will be out the entire next week | 15:48 |
| iurygregory | enjoy the PTO rpittau =) | 15:49 |
| rpittau | thanks! | 15:49 |
| rpittau | any more arguments for Open Discussion ? | 15:49 |
| rpittau | seems we're good! | 15:49 |
| rpittau | last but not least | 15:49 |
| rpittau | #topic Who is going to run the next meeting? | 15:50 |
| rpittau | any volunteer? :) | 15:50 |
| rpittau | I would do it again, but I'm on PTO :/ | 15:52 |
| iurygregory | I can | 15:52 |
| rpittau | iurygregory: thanks! | 15:52 |
| iurygregory | np | 15:52 |
| rpittau | alright folks, that's all, have a great week! | 15:53 |
| rpittau | #endmeeting | 15:53 |
| opendevmeet | Meeting ended Mon Jun 21 15:53:29 2021 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:53 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/ironic/2021/ironic.2021-06-21-15.00.html | 15:53 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/ironic/2021/ironic.2021-06-21-15.00.txt | 15:53 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/ironic/2021/ironic.2021-06-21-15.00.log.html | 15:53 |
| arne_wiebalck | thanks rpittau ! | 15:57 |
| rpittau | good night! o/ | 16:00 |
| TheJulia | goodnight | 16:00 |
| *** rpittau is now known as rpittau|afk | 16:00 | |
| arne_wiebalck | TLS issue: the retry in the same seconds works, always: http://paste.openstack.org/show/806832/ It almost seems like the retry resets sth ... | 16:03 |
| arne_wiebalck | s/seconds/second/ | 16:03 |
| opendevreview | cenne proposed openstack/ironic master: [WIP] Add `boot_mode` and `secure_boot` to node object https://review.opendev.org/c/openstack/ironic/+/797055 | 17:04 |
| cenne | JayF can you take a look? ^ | 17:22 |
| cenne | I think at this point it should atleast load (and pass old tests.) But it's not. | 17:27 |
| cenne | Error log : https://paste.centos.org/view/91cd606c | 17:27 |
| JayF | looking, but multitasking it might be a little bit | 17:34 |
| cenne | It's no problem. Whenever you have time. I'm closing for the day anyway | 17:35 |
| cenne | Its | 17:35 |
| cenne | *It's night here :) | 17:36 |
| JayF | Yeah, I'll have to point my brain at this. Not neccessarily my strongest part of the code but I've got it open and will try to find it or suggest debugging steps :) | 17:36 |
| cenne | Thank you. I've done the steps suggested by others and been looking through the alembic wiki myself. Made the migration script manually too but i don't know how to get tests database to update. | 17:40 |
| JayF | That's basically what I suspected the problem would be around; I'll have time this afternoon to dig | 17:49 |
| arne_wiebalck | bye everyone o/ | 17:56 |
| opendevreview | Julia Kreger proposed openstack/ironic master: Only return the requested fields from the DB https://review.opendev.org/c/openstack/ironic/+/792274 | 18:23 |
| opendevreview | Julia Kreger proposed openstack/ironic master: Set stage for objects to handle selected field lists. https://review.opendev.org/c/openstack/ironic/+/792275 | 18:24 |
| opendevreview | Julia Kreger proposed openstack/ironic master: API to pass fields to node object list https://review.opendev.org/c/openstack/ironic/+/792296 | 18:24 |
| opendevreview | Julia Kreger proposed openstack/ironic master: Allow node_sanitize function to be provided overrides https://review.opendev.org/c/openstack/ironic/+/794880 | 18:24 |
| opendevreview | Julia Kreger proposed openstack/ironic master: Use selectinload for all list queries https://review.opendev.org/c/openstack/ironic/+/797337 | 18:24 |
| TheJulia | cenne: basically what is happening is the field is being queried before it is actually in existence in the object model and db | 19:21 |
| JayF | Yeah I'm just looking at this now, trying to find an example of another set of fields being added | 19:26 |
| JayF | to see what's missing | 19:26 |
| JayF | TheJulia: jinx on that review, but I'm way more confident in my answer since we said the same thing mostly | 19:35 |
| JayF | lol | 19:35 |
| TheJulia | \o/ | 19:35 |
| TheJulia | yeah, it is the fake objects because magic :) | 19:35 |
| JayF | cenne: one thing to note is the key approach that both TheJulia and I used was finding an older change that did the same thing (I did a git history on ironic/objects/node.py to find the most recent change we applied there) | 19:36 |
| JayF | cenne: then I plugged that commit SHA into review.opendev.org and it linked me to the original change | 19:36 |
| JayF | cenne: then you can compare what someone else did that worked to what you did, and try to see what they did that you didn't | 19:37 |
| JayF | cenne: if you need more help, feel free to let me know in PM if you wanna 1:1 to knock out the remaining problems; I should be available early morning my time (7am-ish) on Wednesday if you need to :D | 19:38 |
| opendevreview | Julia Kreger proposed openstack/ironic master: Only return the requested fields from the DB https://review.opendev.org/c/openstack/ironic/+/792274 | 22:12 |
| opendevreview | Julia Kreger proposed openstack/ironic master: Set stage for objects to handle selected field lists. https://review.opendev.org/c/openstack/ironic/+/792275 | 22:31 |
| opendevreview | Julia Kreger proposed openstack/ironic master: API to pass fields to node object list https://review.opendev.org/c/openstack/ironic/+/792296 | 22:31 |
| opendevreview | Julia Kreger proposed openstack/ironic master: Allow node_sanitize function to be provided overrides https://review.opendev.org/c/openstack/ironic/+/794880 | 22:31 |
| opendevreview | Julia Kreger proposed openstack/ironic master: Use selectinload for all list queries https://review.opendev.org/c/openstack/ironic/+/797337 | 22:32 |
| janders | good morning Ironic o/ | 23:05 |
| TheJulia | good morning janders | 23:16 |
| janders | hey TheJulia | 23:19 |
| janders | how is it going? | 23:20 |
| janders | TheJulia I made some really good progress with SuperMicro vMedia - if this is of interest I can share the updated test report. | 23:23 |
| janders | ( I've been asking about this earlier, so now that I have some info, I am happy to share back :) ) | 23:23 |
| TheJulia | NobodyCam: when your around tomorrow, if you can give me a little more background on the state of the node had an orphaned cleaning vif, it would be handy since the error handling tears it down. It seems like a compound failure, tbh | 23:40 |
| TheJulia | janders: magic, working, or maybe patch inbound? | 23:40 |
| janders | TheJulia there is definitely some magic, which I expect to materialise into sushy patches at some point | 23:41 |
| janders | (but I do not have any yet) | 23:41 |
| TheJulia | sounds like it may be a plugin instead? | 23:42 |
| janders | yeah that may be the case too | 23:44 |
| janders | rpittau|afk I added an update on cleaning enhancements to https://etherpad.opendev.org/p/IronicWhiteBoard (unfortunately there is no real update yet :( ) | 23:45 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!