Monday, 2021-05-24

*** k_mouza has joined #openstack-ironic01:07
*** k_mouza has quit IRC01:12
*** k_mouza has joined #openstack-ironic01:27
*** gmann_afk is now known as gmann01:30
*** k_mouza has quit IRC01:32
*** Qianbiao has joined #openstack-ironic02:16
openstackgerritMerged openstack/ironic master: Add missing bios_interface to api-ref for validate API  https://review.opendev.org/c/openstack/ironic/+/79221003:42
*** mkrai has joined #openstack-ironic04:23
openstackgerritMerged openstack/ironic-python-agent-builder master: Update requirements for diskimage-builder  https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/79190204:35
*** k_mouza has joined #openstack-ironic04:43
*** k_mouza has quit IRC04:47
*** early has quit IRC04:50
openstackgerritMerged openstack/ironic-lib master: Raise qemu-img memory limit to 2 GiB  https://review.opendev.org/c/openstack/ironic-lib/+/79193204:54
*** k_mouza has joined #openstack-ironic04:55
*** k_mouza has quit IRC04:59
openstackgerritMerged openstack/ironic-lib master: convert_image: add flags required for IPA  https://review.opendev.org/c/openstack/ironic-lib/+/79195705:01
openstackgerritVerification of a change to openstack/ironic-python-agent failed: Enable out-of-order writes when writing whole disk images  https://review.opendev.org/c/openstack/ironic-python-agent/+/79193405:01
openstackgerritVerification of a change to openstack/ironic-python-agent failed: Rewrite write_image.sh in Python  https://review.opendev.org/c/openstack/ironic-python-agent/+/79193505:01
*** k_mouza has joined #openstack-ironic05:03
*** early has joined #openstack-ironic05:05
*** k_mouza has quit IRC05:08
*** mkrai_ has joined #openstack-ironic05:34
*** mkrai has quit IRC05:37
*** k_mouza has joined #openstack-ironic06:16
*** k_mouza has quit IRC06:20
iurygregorygood morning Ironic o/06:55
jandershey iurygregory o/06:55
iurygregoryhey janders o/06:56
*** sshnaidm has joined #openstack-ironic06:58
*** mkrai_ has quit IRC07:09
*** MahnoorAsghar has joined #openstack-ironic07:12
MahnoorAsgharHello all o/07:16
*** tosky has joined #openstack-ironic07:20
iurygregorymorning MahnoorAsghar07:28
MahnoorAsghariurygregory: good morning ^-^07:28
MahnoorAsgharHey dtantsur o/07:29
MahnoorAsghar I had a question wrt your comment https://storyboard.openstack.org/#!/story/2008866#comment-17346907:29
iurygregoryDmitry is probably sleeping at this time =) or doing some exercises07:29
MahnoorAsgharoh really? Alrightie07:30
iurygregoryoh it's holiday in Germany07:30
MahnoorAsgharooooh nice07:30
MahnoorAsgharDo you think you could give me your opinion, though?07:31
MahnoorAsgharAsking permission to shoot my question :P07:31
*** k_mouza has joined #openstack-ironic07:33
iurygregorysure go ahead, I will answer in a few ( I have some meetings)07:33
*** k_mouza has quit IRC07:34
*** k_mouza has joined #openstack-ironic07:34
MahnoorAsghariurygregory: okay thanks! In the comment given above, Dmitry is talking about a Redfish approach. Do you think he mean implementation in the Ironic Redfish module, or sushy itself?07:42
iurygregoryMahnoorAsghar, if redfish supports this you would probably need changes in sushy and in Ironic07:47
MahnoorAsghariurygregory: You mean Redfish supporting the usage of disk integers? It doesn't do that....07:54
*** lucasagomes has joined #openstack-ironic07:58
iurygregoryyeah, if redfish provides a way to get the information about the disks that you want to use (vendor-independent)08:02
*** winircuser-739 has joined #openstack-ironic08:05
*** derekh has joined #openstack-ironic08:05
*** mkrai_ has joined #openstack-ironic08:06
*** winircuser-739 has quit IRC08:10
*** zainub has joined #openstack-ironic08:17
ajyamraineri: question about HttpHeaders in EventDestination. On GET they are empty, but what with POST? Are they set like any other property? There is patch that proposes to take HttpHeaders and POST as actual HTTP headers, not part of Body. What should be done here?08:18
ajyamraineri: the patch - https://review.opendev.org/c/openstack/sushy/+/792053/3/sushy/resources/eventservice/eventdestination.py#11008:18
ajyaiurygregory: ^08:18
iurygregoryajya, tks =)08:20
iurygregoryso far on my tests with HP and DELL if they are part of body things won't work =)08:20
ajyayeah, that could be implementation issue. When passing to actual HTTP headers they might be ignored. Was it checked that these headers are later applied when event occurs? Anyway, I couldn't find anywhere in spec saying that this needs to be done. Need to clarify.08:22
ajyaand ofc, it's hard to see if they are really set, because on GET they're empty :)08:22
iurygregoryno idea =) since Ironic won't handle anything from the Events08:23
iurygregoryajya, yeah08:23
*** ociuhandu has joined #openstack-ironic08:23
iurygregoryit would make sense they are in the body ofc (when a event occurs it could require the headers etc)08:24
*** zainub has quit IRC08:24
*** ociuhandu has quit IRC09:34
*** ociuhandu has joined #openstack-ironic09:35
openstackgerritIury Gregory Melo Ferreira proposed openstack/sushy master: EventService support  https://review.opendev.org/c/openstack/sushy/+/79205309:43
*** ociuhandu has quit IRC09:43
*** zainub has joined #openstack-ironic10:00
*** zainub has quit IRC10:21
cenngood afternoon iurygregory10:21
iurygregorycenn, good afternoon =)10:22
*** MahnoorAsghar has quit IRC10:29
*** pmannidi has joined #openstack-ironic10:43
*** pmannidi has quit IRC10:43
*** ociuhandu has joined #openstack-ironic10:47
*** ociuhandu has quit IRC11:00
*** ociuhandu has joined #openstack-ironic11:03
*** ociuhandu has quit IRC11:15
*** mkrai_ has quit IRC11:19
*** ociuhandu has joined #openstack-ironic11:27
*** ociuhandu has quit IRC11:31
*** ociuhandu has joined #openstack-ironic11:34
*** ociuhandu has quit IRC11:38
*** ociuhandu has joined #openstack-ironic11:38
*** ociuhandu has quit IRC11:39
*** ociuhandu has joined #openstack-ironic11:41
*** ociuhandu has quit IRC11:47
*** ociuhandu has joined #openstack-ironic11:59
*** ociuhandu has quit IRC12:02
*** ociuhandu has joined #openstack-ironic12:03
*** tzumainn has joined #openstack-ironic12:18
*** rh-jelabarre has joined #openstack-ironic12:24
*** akahat|ruck is now known as akahat13:00
*** zainub has joined #openstack-ironic13:10
zainubhello13:12
iurygregoryhi!13:13
TheJuliagood morning13:17
iurygregorygood morning TheJulia =)13:17
iurygregoryreview jam is in 37 min?13:23
iurygregorynot sure if we will have enough people for today (holiday in most of EU)13:24
TheJuliaoh, well... hmm13:28
TheJuliaI didn't think of that13:28
TheJuliaI do have items, but I guess they can be discussed tomorrow13:29
TheJuliaor we could still do it in a half hour13:29
TheJuliashoot, we might not have the critical mass for a full meeting13:29
iurygregoryI can join a bit late ( I need to give update in a meeting)13:29
TheJuliaokay13:29
TheJuliaI'll try to at least start the call on time.13:30
TheJuliaI may be 10 minutes late13:30
iurygregoryack13:30
*** paras333 has joined #openstack-ironic13:32
*** paras333 has quit IRC13:34
*** ociuhandu has quit IRC13:40
*** ociuhandu has joined #openstack-ironic13:54
*** lmcgann has joined #openstack-ironic13:55
*** ociuhandu has quit IRC13:59
*** ociuhandu has joined #openstack-ironic14:01
openstackgerritJulia Kreger proposed openstack/ironic master: Secure RBAC - Efficent node santiziation  https://review.opendev.org/c/openstack/ironic/+/79014214:05
iurygregoryTheJulia, meetpad right?14:09
TheJuliayup14:11
openstackgerritJulia Kreger proposed openstack/bifrost master: Add a benchmark job for ironic  https://review.opendev.org/c/openstack/bifrost/+/79270514:19
*** ociuhandu has quit IRC14:25
*** sdanni has joined #openstack-ironic14:30
mraineriajya: The HttpHeaders property in the POST request will contain any headers the client would like to be provided when receiving event notifications14:38
*** ociuhandu has joined #openstack-ironic14:38
mraineriThe reason it's an empty array in GET responses is one of the use cases is the client might be specifying authentication parameters for the event listenter14:38
mraineriSo, it's an attempt to avoid information leakage14:39
*** ociuhandu has quit IRC14:42
*** ociuhandu has joined #openstack-ironic14:43
ajyamraineri: thanks, so that patch shouldn't have any special treatment for HttpHeaders property. They are used by BMC when notification is sent, not when client creates subscription. And if this does not work, then it could be bug in BMC firmware (will check more on iDRAC)14:49
mraineriPATCH is an odd case; I would not think a client would attempt to modify HttpHeaders14:51
mraineriBut the current schema isn't clear about this; since the definition is very open-ended, there aren't any permissions terms14:52
mraineriFor most things in EventDestination, we tend to not allow PATCH14:52
TheJuliaI think it would be somewhat up to what the user is attempting to achieve in the client library. As if they are authoritative on what should be in place, or if they are reading from the endpoint first to generate a patch document.14:53
*** kaifeng has joined #openstack-ironic14:53
mraineriYeah, and that becomes complicated to accomplish in that type of flow; HttpHeaders won't show any info in GET responses, so it's very difficult to build an accurate PATCH document since you don't know for sure what it is you're changing14:54
TheJuliayup14:55
ajyasorry, I meant patch as pull request/review, not HTTP method, I knew this can be confusing :(14:55
ajyacurrently, the context is Http POST14:55
mraineriOh, whoops :)14:55
ajyabut from the spec it seems, that this field is read-write14:55
mraineriThe schema actually doesn't specify either way14:56
*** stendulker has joined #openstack-ironic14:59
TheJulia#startmeeting ironic15:00
openstackMeeting started Mon May 24 15:00:28 2021 UTC and is due to finish in 60 minutes.  The chair is TheJulia. Information about MeetBot at http://wiki.debian.org/MeetBot.15:00
TheJuliao/15:00
openstackUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.15:00
*** openstack changes topic to " (Meeting topic: ironic)"15:00
iurygregoryo/15:00
openstackThe meeting name has been set to 'ironic'15:00
ajyao/15:00
rpioso\o15:00
kaifengo/15:00
stendulkero/15:00
TheJuliaGood morning! Today's biggest question, do we have quarum15:00
erbarro/15:01
iurygregoryI would say maybe :D15:01
TheJuliaI'm leaning on the side of "not exactly"15:02
iurygregoryyup...15:02
iurygregoryholiday in the US also?15:03
TheJuliaFriday for some15:03
TheJuliaNext monday, but this is when people tend to also start taking time off for the summer.15:03
iurygregoryok, so maybe we should skip15:03
TheJuliaSo lets do this, basic reminders/notes.15:04
iurygregoryyeah15:04
iurygregory++15:04
TheJulia#topic Announcements / Reminders15:04
*** openstack changes topic to "Announcements / Reminders (Meeting topic: ironic)"15:04
TheJulia#info OpenStack Xena-1 is this week.15:04
TheJulia#info Next week we anticipate cutting ironic 18.0. This is considered a major release as the iscsi deploy interface has been removed.15:05
TheJulia#info Please see the openstack-discuss mailing list thread with regards to communication channels for the project.15:06
TheJulia#link http://lists.openstack.org/pipermail/openstack-discuss/2021-May/022670.html15:07
TheJuliaIn particular, I encourage people to do some reading and thinking. We likely want to keep that discussion to the mailing list in particular, but we as a community need to reach consensus.15:07
TheJuliaIs there anything else?15:07
TheJuliaI think for review priorities we can just update what makes sense if there are no objections?15:08
iurygregory++15:08
iurygregoryOne thing I noticed is that HPE CI is reporting a lot of failures15:08
TheJuliaUnrelated to the changes?15:09
iurygregoryyup15:09
TheJuliastendulker: fyi ^15:09
iurygregoryI think they are running bionic..15:09
TheJuliaThat might be...15:09
stendulkeryes its being investigated15:09
TheJuliaOkay, thanks for the update stendulker15:09
iurygregorystendulker, tks!15:09
TheJuliaDo we have anything else to chat about this week?15:09
stendulkerthere is some internet issue, that leads to failure in download of packages15:10
TheJulia#topic Open Discussion15:10
*** openstack changes topic to "Open Discussion (Meeting topic: ironic)"15:10
TheJuliaAnything?!15:10
* TheJulia wonders if we're on track for shortest meeting of the year15:10
iurygregoryI had a topic, but would be better to postpone15:11
TheJuliaOkay15:11
TheJuliaWell, thanks everyone!15:11
TheJuliaHave a wonderful week!15:11
TheJulia#endmeeting15:11
*** openstack changes topic to "Bare Metal Provisioning | Status: http://bit.ly/ironic-whiteboard | Docs: http://docs.openstack.org/ironic/ | Bugs: https://storyboard.openstack.org/#!/project_group/75 | Contributors are generally present between 6 AM and 12 AM UTC, If we do not answer, please feel free to pose questions to openstack-discuss mailing list."15:11
openstackMeeting ended Mon May 24 15:11:58 2021 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)15:12
openstackMinutes:        http://eavesdrop.openstack.org/meetings/ironic/2021/ironic.2021-05-24-15.00.html15:12
openstackMinutes (text): http://eavesdrop.openstack.org/meetings/ironic/2021/ironic.2021-05-24-15.00.txt15:12
openstackLog:            http://eavesdrop.openstack.org/meetings/ironic/2021/ironic.2021-05-24-15.00.log.html15:12
iurygregorywe forgot "Who is going to run the next meeting?" :D15:12
TheJuliadoh!15:13
TheJuliaI can15:13
TheJuliaunless someone else wants to?15:13
TheJuliaiurygregory: I'm going to add review priority tag to the performance fixes15:14
iurygregoryack, if you are not able I can jump in =)15:14
iurygregoryTheJulia, ++15:14
TheJuliaoh!15:14
TheJuliaiurygregory: next monday is a holiday here15:14
iurygregoryhehe I can run the meeting =)15:14
iurygregorymraineri, if possible can you provide some feedback in https://review.opendev.org/c/openstack/sushy/+/792053/5/sushy/resources/eventservice/eventdestination.py delete method 67  and create in line 106? =)15:15
TheJuliaiurygregory: thanks15:18
mraineriiurygregory: all set15:23
iurygregorymraineri, tks!15:23
NobodyCamGood Morning Ironic Folks, Happy Monday!15:32
iurygregorymorning NobodyCam o/15:32
NobodyCam:) would anyone be interested in a patch to the ironic driver that adds updating placement service before releasing a node?15:33
NobodyCamMorning iurygregory :)15:34
*** cp- has quit IRC15:34
*** cp- has joined #openstack-ironic15:34
TheJuliagood morning NobodyCam15:39
TheJuliaNobodyCam: yes please15:40
TheJuliaarne_wiebalck ^^15:40
NobodyCamGood Morning TheJulia15:40
*** bburns_ has quit IRC15:40
NobodyCamits a little hack and slash at this point!15:40
NobodyCambut I have working code (at least in Devstack)15:41
NobodyCamDo to slow paper work I may not be able to submit the patch just yet, but I may be able to get a coworker to put up15:42
*** bburns has joined #openstack-ironic15:42
NobodyCams/do/due/15:42
TheJuliaNobodyCam: ack, we can also amend said patch for appropriate attribution tracking community side wise15:56
TheJuliaNobodyCam: speaking of, has your employer been updated in the appropriate places?15:56
NobodyCamoh course not, I was waiting until I was able to sign the contributor agreement before updating all the things15:57
*** lucasagomes has quit IRC16:02
TheJuliaummm16:03
TheJuliaI don't think you need to for a new employer16:03
TheJuliayou signed it as an individual in the past16:04
JayFI've done a new CCLA at every employer I've had to work on OpenStack16:04
JayFso I didn't have to resign an ICLA, but had to get listed on the company CCLA before I contributed16:04
TheJuliaahh yeah16:04
NobodyCamthe company signed the community stuff just before I joined16:05
* TheJulia remembered that with the hpe->ibm move16:05
NobodyCambut I am not internally authorized yet to put up open source patches16:05
TheJuliayeah16:07
*** ociuhandu has quit IRC16:12
*** rh-jelabarre has quit IRC16:19
*** rh-jelabarre has joined #openstack-ironic16:19
*** rh-jelabarre has quit IRC16:21
*** trandles has joined #openstack-ironic16:22
*** Qianbiao has quit IRC16:26
TheJuliawoot, the ironic benchmark job worked \o/16:26
TheJuliahttps://6ef9c7b9e14ab58a181a-20b98b64cfa6ea87451df6eaddafb782.ssl.cf2.rackcdn.com/792706/1/check/bifrost-benchmark-ironic/17dc667/job-output.txt16:26
TheJuliaof course, it may have also landed on a very performant node.16:27
TheJulia514 nodes/second on a 10k node list.16:30
JayFTheJulia: it'd be neat if we could catch a delta16:33
cennThat sounds great TheJulia. (Although I have little clue what it mean ^^')16:33
JayFe.g. for each ci run; run the perf test against master, then  run against master+patch, and make sure the diff is within certain tolerances?16:33
JayFthat might help limit the impact of performance changes on test nodes16:33
TheJuliaJayF: I'm not sure we will be able to really do so short of the timeout, *but* at least a start is getting some of the tooling in place and starting to capture some data.16:34
TheJuliaThat might also be a workable pattern16:34
JayFah, I would've thought this job would be relatively quick vs tempest tests16:34
TheJuliashouldn't impact the ability to create the fake nodes and all that16:34
TheJuliait did run fairly quick actually16:34
TheJulialike 30 minutes with bifrost16:34
TheJuliawhich is impressive, tbh16:34
TheJuliaoh, you know what....16:35
TheJuliaThat is in noauth mode16:35
TheJuliaerr, well, maybe not16:35
TheJuliabraaains16:35
openstackgerritJulia Kreger proposed openstack/ironic master: Add basic tools for benchmarking  https://review.opendev.org/c/openstack/ironic/+/78833516:36
TheJuliait may be best to go ahead and run both cases16:36
*** stendulker has quit IRC16:38
TheJuliaI guess, at least for ironic itself, since the policy checking code is all involved, and right now it is the biggest painpoint16:39
*** dsneddon has joined #openstack-ironic17:02
*** kaifeng has quit IRC17:21
*** coreycb has joined #openstack-ironic17:24
*** rh-jelabarre has joined #openstack-ironic17:42
*** rh-jelabarre has joined #openstack-ironic17:43
*** zainub has quit IRC17:47
*** sshnaidm is now known as sshnaidm|afk18:02
*** k_mouza has quit IRC18:42
*** k_mouza has joined #openstack-ironic18:42
*** k_mouza has quit IRC18:47
*** gyee has joined #openstack-ironic19:10
*** k_mouza has joined #openstack-ironic19:23
*** k_mouza has quit IRC19:28
*** stevebaker has joined #openstack-ironic19:30
*** rh-jelabarre has quit IRC19:44
*** rh-jelabarre has joined #openstack-ironic19:47
*** stevebaker has quit IRC19:54
*** stevebaker has joined #openstack-ironic19:54
openstackgerritJulia Kreger proposed openstack/ironic stable/wallaby: DNM: Ironic index docs/command check backport  https://review.opendev.org/c/openstack/ironic/+/79287319:55
openstackgerritJulia Kreger proposed openstack/ironic master: Set stage for objects to handle selected field lists.  https://review.opendev.org/c/openstack/ironic/+/79227519:58
openstackgerritJulia Kreger proposed openstack/ironic master: WIP: API to pass fields to node object list  https://review.opendev.org/c/openstack/ironic/+/79229619:59
*** k_mouza has joined #openstack-ironic20:02
*** k_mouza has quit IRC20:07
*** pmannidi has joined #openstack-ironic21:33
*** ayoung has joined #openstack-ironic21:35
*** ayoung has quit IRC21:37
*** kkillsfirst has joined #openstack-ironic22:01
*** k_mouza has joined #openstack-ironic22:03
*** k_mouza has quit IRC22:04
*** k_mouza_ has joined #openstack-ironic22:04
*** openstackgerrit has quit IRC22:05
*** k_mouza_ has quit IRC22:09
*** lmcgann has quit IRC22:44
TheJuliastevebaker: you around?22:55
stevebakerTheJulia: I am indeed22:55
TheJuliawould you be up for a different problem to ponder for a little bit?22:55
TheJulia(I need another set of eyes)22:56
stevebakersure thing22:56
TheJuliaI'm quite literally down to one unit test and I'm really unfortunately scratching my head going "what?!?"22:56
TheJuliaI suspect I need to fully hydrate an object to convert it... but it is also likely a sign I need to call it a day too22:56
* TheJulia uploads changes22:57
*** openstackgerrit has joined #openstack-ironic22:58
openstackgerritJulia Kreger proposed openstack/ironic master: Only return the requested fields  https://review.opendev.org/c/openstack/ironic/+/79227422:58
openstackgerritJulia Kreger proposed openstack/ironic master: Set stage for objects to handle selected field lists.  https://review.opendev.org/c/openstack/ironic/+/79227522:58
openstackgerritJulia Kreger proposed openstack/ironic master: WIP: API to pass fields to node object list  https://review.opendev.org/c/openstack/ironic/+/79229622:58
TheJuliaThe API change specifically22:58
TheJulia79229622:58
stevebakerTheJulia: sure thing. Is it the "AttributeError: 'dict' object has no attribute 'traits'" error?23:01
*** kkillsfirst has quit IRC23:01
TheJuliastevebaker: I think it is that it can't convert it to json23:07
TheJuliaWhich honestly makes me question how it was ever working to begin with23:08
stevebakerhmm23:10
TheJuliagoing to go lay down, migraine from this morning is still around23:13
stevebakerTheJulia: ok. I may change venues to look at this23:13
*** tosky has quit IRC23:18
*** openstack has joined #openstack-ironic23:50
*** ChanServ sets mode: +o openstack23:50
stevebakerTheJulia: reviewed. I think I found the issue23:58

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!