*** k_mouza has joined #openstack-ironic | 01:07 | |
*** k_mouza has quit IRC | 01:12 | |
*** k_mouza has joined #openstack-ironic | 01:27 | |
*** gmann_afk is now known as gmann | 01:30 | |
*** k_mouza has quit IRC | 01:32 | |
*** Qianbiao has joined #openstack-ironic | 02:16 | |
openstackgerrit | Merged openstack/ironic master: Add missing bios_interface to api-ref for validate API https://review.opendev.org/c/openstack/ironic/+/792210 | 03:42 |
---|---|---|
*** mkrai has joined #openstack-ironic | 04:23 | |
openstackgerrit | Merged openstack/ironic-python-agent-builder master: Update requirements for diskimage-builder https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/791902 | 04:35 |
*** k_mouza has joined #openstack-ironic | 04:43 | |
*** k_mouza has quit IRC | 04:47 | |
*** early has quit IRC | 04:50 | |
openstackgerrit | Merged openstack/ironic-lib master: Raise qemu-img memory limit to 2 GiB https://review.opendev.org/c/openstack/ironic-lib/+/791932 | 04:54 |
*** k_mouza has joined #openstack-ironic | 04:55 | |
*** k_mouza has quit IRC | 04:59 | |
openstackgerrit | Merged openstack/ironic-lib master: convert_image: add flags required for IPA https://review.opendev.org/c/openstack/ironic-lib/+/791957 | 05:01 |
openstackgerrit | Verification of a change to openstack/ironic-python-agent failed: Enable out-of-order writes when writing whole disk images https://review.opendev.org/c/openstack/ironic-python-agent/+/791934 | 05:01 |
openstackgerrit | Verification of a change to openstack/ironic-python-agent failed: Rewrite write_image.sh in Python https://review.opendev.org/c/openstack/ironic-python-agent/+/791935 | 05:01 |
*** k_mouza has joined #openstack-ironic | 05:03 | |
*** early has joined #openstack-ironic | 05:05 | |
*** k_mouza has quit IRC | 05:08 | |
*** mkrai_ has joined #openstack-ironic | 05:34 | |
*** mkrai has quit IRC | 05:37 | |
*** k_mouza has joined #openstack-ironic | 06:16 | |
*** k_mouza has quit IRC | 06:20 | |
iurygregory | good morning Ironic o/ | 06:55 |
janders | hey iurygregory o/ | 06:55 |
iurygregory | hey janders o/ | 06:56 |
*** sshnaidm has joined #openstack-ironic | 06:58 | |
*** mkrai_ has quit IRC | 07:09 | |
*** MahnoorAsghar has joined #openstack-ironic | 07:12 | |
MahnoorAsghar | Hello all o/ | 07:16 |
*** tosky has joined #openstack-ironic | 07:20 | |
iurygregory | morning MahnoorAsghar | 07:28 |
MahnoorAsghar | iurygregory: good morning ^-^ | 07:28 |
MahnoorAsghar | Hey dtantsur o/ | 07:29 |
MahnoorAsghar | I had a question wrt your comment https://storyboard.openstack.org/#!/story/2008866#comment-173469 | 07:29 |
iurygregory | Dmitry is probably sleeping at this time =) or doing some exercises | 07:29 |
MahnoorAsghar | oh really? Alrightie | 07:30 |
iurygregory | oh it's holiday in Germany | 07:30 |
MahnoorAsghar | ooooh nice | 07:30 |
MahnoorAsghar | Do you think you could give me your opinion, though? | 07:31 |
MahnoorAsghar | Asking permission to shoot my question :P | 07:31 |
*** k_mouza has joined #openstack-ironic | 07:33 | |
iurygregory | sure go ahead, I will answer in a few ( I have some meetings) | 07:33 |
*** k_mouza has quit IRC | 07:34 | |
*** k_mouza has joined #openstack-ironic | 07:34 | |
MahnoorAsghar | iurygregory: okay thanks! In the comment given above, Dmitry is talking about a Redfish approach. Do you think he mean implementation in the Ironic Redfish module, or sushy itself? | 07:42 |
iurygregory | MahnoorAsghar, if redfish supports this you would probably need changes in sushy and in Ironic | 07:47 |
MahnoorAsghar | iurygregory: You mean Redfish supporting the usage of disk integers? It doesn't do that.... | 07:54 |
*** lucasagomes has joined #openstack-ironic | 07:58 | |
iurygregory | yeah, if redfish provides a way to get the information about the disks that you want to use (vendor-independent) | 08:02 |
*** winircuser-739 has joined #openstack-ironic | 08:05 | |
*** derekh has joined #openstack-ironic | 08:05 | |
*** mkrai_ has joined #openstack-ironic | 08:06 | |
*** winircuser-739 has quit IRC | 08:10 | |
*** zainub has joined #openstack-ironic | 08:17 | |
ajya | mraineri: question about HttpHeaders in EventDestination. On GET they are empty, but what with POST? Are they set like any other property? There is patch that proposes to take HttpHeaders and POST as actual HTTP headers, not part of Body. What should be done here? | 08:18 |
ajya | mraineri: the patch - https://review.opendev.org/c/openstack/sushy/+/792053/3/sushy/resources/eventservice/eventdestination.py#110 | 08:18 |
ajya | iurygregory: ^ | 08:18 |
iurygregory | ajya, tks =) | 08:20 |
iurygregory | so far on my tests with HP and DELL if they are part of body things won't work =) | 08:20 |
ajya | yeah, that could be implementation issue. When passing to actual HTTP headers they might be ignored. Was it checked that these headers are later applied when event occurs? Anyway, I couldn't find anywhere in spec saying that this needs to be done. Need to clarify. | 08:22 |
ajya | and ofc, it's hard to see if they are really set, because on GET they're empty :) | 08:22 |
iurygregory | no idea =) since Ironic won't handle anything from the Events | 08:23 |
iurygregory | ajya, yeah | 08:23 |
*** ociuhandu has joined #openstack-ironic | 08:23 | |
iurygregory | it would make sense they are in the body ofc (when a event occurs it could require the headers etc) | 08:24 |
*** zainub has quit IRC | 08:24 | |
*** ociuhandu has quit IRC | 09:34 | |
*** ociuhandu has joined #openstack-ironic | 09:35 | |
openstackgerrit | Iury Gregory Melo Ferreira proposed openstack/sushy master: EventService support https://review.opendev.org/c/openstack/sushy/+/792053 | 09:43 |
*** ociuhandu has quit IRC | 09:43 | |
*** zainub has joined #openstack-ironic | 10:00 | |
*** zainub has quit IRC | 10:21 | |
cenn | good afternoon iurygregory | 10:21 |
iurygregory | cenn, good afternoon =) | 10:22 |
*** MahnoorAsghar has quit IRC | 10:29 | |
*** pmannidi has joined #openstack-ironic | 10:43 | |
*** pmannidi has quit IRC | 10:43 | |
*** ociuhandu has joined #openstack-ironic | 10:47 | |
*** ociuhandu has quit IRC | 11:00 | |
*** ociuhandu has joined #openstack-ironic | 11:03 | |
*** ociuhandu has quit IRC | 11:15 | |
*** mkrai_ has quit IRC | 11:19 | |
*** ociuhandu has joined #openstack-ironic | 11:27 | |
*** ociuhandu has quit IRC | 11:31 | |
*** ociuhandu has joined #openstack-ironic | 11:34 | |
*** ociuhandu has quit IRC | 11:38 | |
*** ociuhandu has joined #openstack-ironic | 11:38 | |
*** ociuhandu has quit IRC | 11:39 | |
*** ociuhandu has joined #openstack-ironic | 11:41 | |
*** ociuhandu has quit IRC | 11:47 | |
*** ociuhandu has joined #openstack-ironic | 11:59 | |
*** ociuhandu has quit IRC | 12:02 | |
*** ociuhandu has joined #openstack-ironic | 12:03 | |
*** tzumainn has joined #openstack-ironic | 12:18 | |
*** rh-jelabarre has joined #openstack-ironic | 12:24 | |
*** akahat|ruck is now known as akahat | 13:00 | |
*** zainub has joined #openstack-ironic | 13:10 | |
zainub | hello | 13:12 |
iurygregory | hi! | 13:13 |
TheJulia | good morning | 13:17 |
iurygregory | good morning TheJulia =) | 13:17 |
iurygregory | review jam is in 37 min? | 13:23 |
iurygregory | not sure if we will have enough people for today (holiday in most of EU) | 13:24 |
TheJulia | oh, well... hmm | 13:28 |
TheJulia | I didn't think of that | 13:28 |
TheJulia | I do have items, but I guess they can be discussed tomorrow | 13:29 |
TheJulia | or we could still do it in a half hour | 13:29 |
TheJulia | shoot, we might not have the critical mass for a full meeting | 13:29 |
iurygregory | I can join a bit late ( I need to give update in a meeting) | 13:29 |
TheJulia | okay | 13:29 |
TheJulia | I'll try to at least start the call on time. | 13:30 |
TheJulia | I may be 10 minutes late | 13:30 |
iurygregory | ack | 13:30 |
*** paras333 has joined #openstack-ironic | 13:32 | |
*** paras333 has quit IRC | 13:34 | |
*** ociuhandu has quit IRC | 13:40 | |
*** ociuhandu has joined #openstack-ironic | 13:54 | |
*** lmcgann has joined #openstack-ironic | 13:55 | |
*** ociuhandu has quit IRC | 13:59 | |
*** ociuhandu has joined #openstack-ironic | 14:01 | |
openstackgerrit | Julia Kreger proposed openstack/ironic master: Secure RBAC - Efficent node santiziation https://review.opendev.org/c/openstack/ironic/+/790142 | 14:05 |
iurygregory | TheJulia, meetpad right? | 14:09 |
TheJulia | yup | 14:11 |
openstackgerrit | Julia Kreger proposed openstack/bifrost master: Add a benchmark job for ironic https://review.opendev.org/c/openstack/bifrost/+/792705 | 14:19 |
*** ociuhandu has quit IRC | 14:25 | |
*** sdanni has joined #openstack-ironic | 14:30 | |
mraineri | ajya: The HttpHeaders property in the POST request will contain any headers the client would like to be provided when receiving event notifications | 14:38 |
*** ociuhandu has joined #openstack-ironic | 14:38 | |
mraineri | The reason it's an empty array in GET responses is one of the use cases is the client might be specifying authentication parameters for the event listenter | 14:38 |
mraineri | So, it's an attempt to avoid information leakage | 14:39 |
*** ociuhandu has quit IRC | 14:42 | |
*** ociuhandu has joined #openstack-ironic | 14:43 | |
ajya | mraineri: thanks, so that patch shouldn't have any special treatment for HttpHeaders property. They are used by BMC when notification is sent, not when client creates subscription. And if this does not work, then it could be bug in BMC firmware (will check more on iDRAC) | 14:49 |
mraineri | PATCH is an odd case; I would not think a client would attempt to modify HttpHeaders | 14:51 |
mraineri | But the current schema isn't clear about this; since the definition is very open-ended, there aren't any permissions terms | 14:52 |
mraineri | For most things in EventDestination, we tend to not allow PATCH | 14:52 |
TheJulia | I think it would be somewhat up to what the user is attempting to achieve in the client library. As if they are authoritative on what should be in place, or if they are reading from the endpoint first to generate a patch document. | 14:53 |
*** kaifeng has joined #openstack-ironic | 14:53 | |
mraineri | Yeah, and that becomes complicated to accomplish in that type of flow; HttpHeaders won't show any info in GET responses, so it's very difficult to build an accurate PATCH document since you don't know for sure what it is you're changing | 14:54 |
TheJulia | yup | 14:55 |
ajya | sorry, I meant patch as pull request/review, not HTTP method, I knew this can be confusing :( | 14:55 |
ajya | currently, the context is Http POST | 14:55 |
mraineri | Oh, whoops :) | 14:55 |
ajya | but from the spec it seems, that this field is read-write | 14:55 |
mraineri | The schema actually doesn't specify either way | 14:56 |
*** stendulker has joined #openstack-ironic | 14:59 | |
TheJulia | #startmeeting ironic | 15:00 |
openstack | Meeting started Mon May 24 15:00:28 2021 UTC and is due to finish in 60 minutes. The chair is TheJulia. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:00 |
TheJulia | o/ | 15:00 |
openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:00 |
*** openstack changes topic to " (Meeting topic: ironic)" | 15:00 | |
iurygregory | o/ | 15:00 |
openstack | The meeting name has been set to 'ironic' | 15:00 |
ajya | o/ | 15:00 |
rpioso | \o | 15:00 |
kaifeng | o/ | 15:00 |
stendulker | o/ | 15:00 |
TheJulia | Good morning! Today's biggest question, do we have quarum | 15:00 |
erbarr | o/ | 15:01 |
iurygregory | I would say maybe :D | 15:01 |
TheJulia | I'm leaning on the side of "not exactly" | 15:02 |
iurygregory | yup... | 15:02 |
iurygregory | holiday in the US also? | 15:03 |
TheJulia | Friday for some | 15:03 |
TheJulia | Next monday, but this is when people tend to also start taking time off for the summer. | 15:03 |
iurygregory | ok, so maybe we should skip | 15:03 |
TheJulia | So lets do this, basic reminders/notes. | 15:04 |
iurygregory | yeah | 15:04 |
iurygregory | ++ | 15:04 |
TheJulia | #topic Announcements / Reminders | 15:04 |
*** openstack changes topic to "Announcements / Reminders (Meeting topic: ironic)" | 15:04 | |
TheJulia | #info OpenStack Xena-1 is this week. | 15:04 |
TheJulia | #info Next week we anticipate cutting ironic 18.0. This is considered a major release as the iscsi deploy interface has been removed. | 15:05 |
TheJulia | #info Please see the openstack-discuss mailing list thread with regards to communication channels for the project. | 15:06 |
TheJulia | #link http://lists.openstack.org/pipermail/openstack-discuss/2021-May/022670.html | 15:07 |
TheJulia | In particular, I encourage people to do some reading and thinking. We likely want to keep that discussion to the mailing list in particular, but we as a community need to reach consensus. | 15:07 |
TheJulia | Is there anything else? | 15:07 |
TheJulia | I think for review priorities we can just update what makes sense if there are no objections? | 15:08 |
iurygregory | ++ | 15:08 |
iurygregory | One thing I noticed is that HPE CI is reporting a lot of failures | 15:08 |
TheJulia | Unrelated to the changes? | 15:09 |
iurygregory | yup | 15:09 |
TheJulia | stendulker: fyi ^ | 15:09 |
iurygregory | I think they are running bionic.. | 15:09 |
TheJulia | That might be... | 15:09 |
stendulker | yes its being investigated | 15:09 |
TheJulia | Okay, thanks for the update stendulker | 15:09 |
iurygregory | stendulker, tks! | 15:09 |
TheJulia | Do we have anything else to chat about this week? | 15:09 |
stendulker | there is some internet issue, that leads to failure in download of packages | 15:10 |
TheJulia | #topic Open Discussion | 15:10 |
*** openstack changes topic to "Open Discussion (Meeting topic: ironic)" | 15:10 | |
TheJulia | Anything?! | 15:10 |
* TheJulia wonders if we're on track for shortest meeting of the year | 15:10 | |
iurygregory | I had a topic, but would be better to postpone | 15:11 |
TheJulia | Okay | 15:11 |
TheJulia | Well, thanks everyone! | 15:11 |
TheJulia | Have a wonderful week! | 15:11 |
TheJulia | #endmeeting | 15:11 |
*** openstack changes topic to "Bare Metal Provisioning | Status: http://bit.ly/ironic-whiteboard | Docs: http://docs.openstack.org/ironic/ | Bugs: https://storyboard.openstack.org/#!/project_group/75 | Contributors are generally present between 6 AM and 12 AM UTC, If we do not answer, please feel free to pose questions to openstack-discuss mailing list." | 15:11 | |
openstack | Meeting ended Mon May 24 15:11:58 2021 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:12 |
openstack | Minutes: http://eavesdrop.openstack.org/meetings/ironic/2021/ironic.2021-05-24-15.00.html | 15:12 |
openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/ironic/2021/ironic.2021-05-24-15.00.txt | 15:12 |
openstack | Log: http://eavesdrop.openstack.org/meetings/ironic/2021/ironic.2021-05-24-15.00.log.html | 15:12 |
iurygregory | we forgot "Who is going to run the next meeting?" :D | 15:12 |
TheJulia | doh! | 15:13 |
TheJulia | I can | 15:13 |
TheJulia | unless someone else wants to? | 15:13 |
TheJulia | iurygregory: I'm going to add review priority tag to the performance fixes | 15:14 |
iurygregory | ack, if you are not able I can jump in =) | 15:14 |
iurygregory | TheJulia, ++ | 15:14 |
TheJulia | oh! | 15:14 |
TheJulia | iurygregory: next monday is a holiday here | 15:14 |
iurygregory | hehe I can run the meeting =) | 15:14 |
iurygregory | mraineri, if possible can you provide some feedback in https://review.opendev.org/c/openstack/sushy/+/792053/5/sushy/resources/eventservice/eventdestination.py delete method 67 and create in line 106? =) | 15:15 |
TheJulia | iurygregory: thanks | 15:18 |
mraineri | iurygregory: all set | 15:23 |
iurygregory | mraineri, tks! | 15:23 |
NobodyCam | Good Morning Ironic Folks, Happy Monday! | 15:32 |
iurygregory | morning NobodyCam o/ | 15:32 |
NobodyCam | :) would anyone be interested in a patch to the ironic driver that adds updating placement service before releasing a node? | 15:33 |
NobodyCam | Morning iurygregory :) | 15:34 |
*** cp- has quit IRC | 15:34 | |
*** cp- has joined #openstack-ironic | 15:34 | |
TheJulia | good morning NobodyCam | 15:39 |
TheJulia | NobodyCam: yes please | 15:40 |
TheJulia | arne_wiebalck ^^ | 15:40 |
NobodyCam | Good Morning TheJulia | 15:40 |
*** bburns_ has quit IRC | 15:40 | |
NobodyCam | its a little hack and slash at this point! | 15:40 |
NobodyCam | but I have working code (at least in Devstack) | 15:41 |
NobodyCam | Do to slow paper work I may not be able to submit the patch just yet, but I may be able to get a coworker to put up | 15:42 |
*** bburns has joined #openstack-ironic | 15:42 | |
NobodyCam | s/do/due/ | 15:42 |
TheJulia | NobodyCam: ack, we can also amend said patch for appropriate attribution tracking community side wise | 15:56 |
TheJulia | NobodyCam: speaking of, has your employer been updated in the appropriate places? | 15:56 |
NobodyCam | oh course not, I was waiting until I was able to sign the contributor agreement before updating all the things | 15:57 |
*** lucasagomes has quit IRC | 16:02 | |
TheJulia | ummm | 16:03 |
TheJulia | I don't think you need to for a new employer | 16:03 |
TheJulia | you signed it as an individual in the past | 16:04 |
JayF | I've done a new CCLA at every employer I've had to work on OpenStack | 16:04 |
JayF | so I didn't have to resign an ICLA, but had to get listed on the company CCLA before I contributed | 16:04 |
TheJulia | ahh yeah | 16:04 |
NobodyCam | the company signed the community stuff just before I joined | 16:05 |
* TheJulia remembered that with the hpe->ibm move | 16:05 | |
NobodyCam | but I am not internally authorized yet to put up open source patches | 16:05 |
TheJulia | yeah | 16:07 |
*** ociuhandu has quit IRC | 16:12 | |
*** rh-jelabarre has quit IRC | 16:19 | |
*** rh-jelabarre has joined #openstack-ironic | 16:19 | |
*** rh-jelabarre has quit IRC | 16:21 | |
*** trandles has joined #openstack-ironic | 16:22 | |
*** Qianbiao has quit IRC | 16:26 | |
TheJulia | woot, the ironic benchmark job worked \o/ | 16:26 |
TheJulia | https://6ef9c7b9e14ab58a181a-20b98b64cfa6ea87451df6eaddafb782.ssl.cf2.rackcdn.com/792706/1/check/bifrost-benchmark-ironic/17dc667/job-output.txt | 16:26 |
TheJulia | of course, it may have also landed on a very performant node. | 16:27 |
TheJulia | 514 nodes/second on a 10k node list. | 16:30 |
JayF | TheJulia: it'd be neat if we could catch a delta | 16:33 |
cenn | That sounds great TheJulia. (Although I have little clue what it mean ^^') | 16:33 |
JayF | e.g. for each ci run; run the perf test against master, then run against master+patch, and make sure the diff is within certain tolerances? | 16:33 |
JayF | that might help limit the impact of performance changes on test nodes | 16:33 |
TheJulia | JayF: I'm not sure we will be able to really do so short of the timeout, *but* at least a start is getting some of the tooling in place and starting to capture some data. | 16:34 |
TheJulia | That might also be a workable pattern | 16:34 |
JayF | ah, I would've thought this job would be relatively quick vs tempest tests | 16:34 |
TheJulia | shouldn't impact the ability to create the fake nodes and all that | 16:34 |
TheJulia | it did run fairly quick actually | 16:34 |
TheJulia | like 30 minutes with bifrost | 16:34 |
TheJulia | which is impressive, tbh | 16:34 |
TheJulia | oh, you know what.... | 16:35 |
TheJulia | That is in noauth mode | 16:35 |
TheJulia | err, well, maybe not | 16:35 |
TheJulia | braaains | 16:35 |
openstackgerrit | Julia Kreger proposed openstack/ironic master: Add basic tools for benchmarking https://review.opendev.org/c/openstack/ironic/+/788335 | 16:36 |
TheJulia | it may be best to go ahead and run both cases | 16:36 |
*** stendulker has quit IRC | 16:38 | |
TheJulia | I guess, at least for ironic itself, since the policy checking code is all involved, and right now it is the biggest painpoint | 16:39 |
*** dsneddon has joined #openstack-ironic | 17:02 | |
*** kaifeng has quit IRC | 17:21 | |
*** coreycb has joined #openstack-ironic | 17:24 | |
*** rh-jelabarre has joined #openstack-ironic | 17:42 | |
*** rh-jelabarre has joined #openstack-ironic | 17:43 | |
*** zainub has quit IRC | 17:47 | |
*** sshnaidm is now known as sshnaidm|afk | 18:02 | |
*** k_mouza has quit IRC | 18:42 | |
*** k_mouza has joined #openstack-ironic | 18:42 | |
*** k_mouza has quit IRC | 18:47 | |
*** gyee has joined #openstack-ironic | 19:10 | |
*** k_mouza has joined #openstack-ironic | 19:23 | |
*** k_mouza has quit IRC | 19:28 | |
*** stevebaker has joined #openstack-ironic | 19:30 | |
*** rh-jelabarre has quit IRC | 19:44 | |
*** rh-jelabarre has joined #openstack-ironic | 19:47 | |
*** stevebaker has quit IRC | 19:54 | |
*** stevebaker has joined #openstack-ironic | 19:54 | |
openstackgerrit | Julia Kreger proposed openstack/ironic stable/wallaby: DNM: Ironic index docs/command check backport https://review.opendev.org/c/openstack/ironic/+/792873 | 19:55 |
openstackgerrit | Julia Kreger proposed openstack/ironic master: Set stage for objects to handle selected field lists. https://review.opendev.org/c/openstack/ironic/+/792275 | 19:58 |
openstackgerrit | Julia Kreger proposed openstack/ironic master: WIP: API to pass fields to node object list https://review.opendev.org/c/openstack/ironic/+/792296 | 19:59 |
*** k_mouza has joined #openstack-ironic | 20:02 | |
*** k_mouza has quit IRC | 20:07 | |
*** pmannidi has joined #openstack-ironic | 21:33 | |
*** ayoung has joined #openstack-ironic | 21:35 | |
*** ayoung has quit IRC | 21:37 | |
*** kkillsfirst has joined #openstack-ironic | 22:01 | |
*** k_mouza has joined #openstack-ironic | 22:03 | |
*** k_mouza has quit IRC | 22:04 | |
*** k_mouza_ has joined #openstack-ironic | 22:04 | |
*** openstackgerrit has quit IRC | 22:05 | |
*** k_mouza_ has quit IRC | 22:09 | |
*** lmcgann has quit IRC | 22:44 | |
TheJulia | stevebaker: you around? | 22:55 |
stevebaker | TheJulia: I am indeed | 22:55 |
TheJulia | would you be up for a different problem to ponder for a little bit? | 22:55 |
TheJulia | (I need another set of eyes) | 22:56 |
stevebaker | sure thing | 22:56 |
TheJulia | I'm quite literally down to one unit test and I'm really unfortunately scratching my head going "what?!?" | 22:56 |
TheJulia | I suspect I need to fully hydrate an object to convert it... but it is also likely a sign I need to call it a day too | 22:56 |
* TheJulia uploads changes | 22:57 | |
*** openstackgerrit has joined #openstack-ironic | 22:58 | |
openstackgerrit | Julia Kreger proposed openstack/ironic master: Only return the requested fields https://review.opendev.org/c/openstack/ironic/+/792274 | 22:58 |
openstackgerrit | Julia Kreger proposed openstack/ironic master: Set stage for objects to handle selected field lists. https://review.opendev.org/c/openstack/ironic/+/792275 | 22:58 |
openstackgerrit | Julia Kreger proposed openstack/ironic master: WIP: API to pass fields to node object list https://review.opendev.org/c/openstack/ironic/+/792296 | 22:58 |
TheJulia | The API change specifically | 22:58 |
TheJulia | 792296 | 22:58 |
stevebaker | TheJulia: sure thing. Is it the "AttributeError: 'dict' object has no attribute 'traits'" error? | 23:01 |
*** kkillsfirst has quit IRC | 23:01 | |
TheJulia | stevebaker: I think it is that it can't convert it to json | 23:07 |
TheJulia | Which honestly makes me question how it was ever working to begin with | 23:08 |
stevebaker | hmm | 23:10 |
TheJulia | going to go lay down, migraine from this morning is still around | 23:13 |
stevebaker | TheJulia: ok. I may change venues to look at this | 23:13 |
*** tosky has quit IRC | 23:18 | |
*** openstack has joined #openstack-ironic | 23:50 | |
*** ChanServ sets mode: +o openstack | 23:50 | |
stevebaker | TheJulia: reviewed. I think I found the issue | 23:58 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!