Thursday, 2021-04-29

*** ice45 has quit IRC00:04
*** lmcgann has quit IRC00:11
*** k_mouza has joined #openstack-ironic00:27
*** k_mouza has quit IRC00:32
*** gyee has quit IRC00:32
openstackgerritJulia Kreger proposed openstack/ironic master: WIP: Add additional node indexes  https://review.opendev.org/c/openstack/ironic/+/78862500:49
openstackgerritJulia Kreger proposed openstack/ironic master: Add additional node indexes  https://review.opendev.org/c/openstack/ironic/+/78862500:58
*** rcernin has quit IRC02:35
*** rcernin has joined #openstack-ironic02:42
openstackgerritxinliang proposed openstack/ironic-python-agent-builder master: Fix build error on aarch64  https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/78838803:07
*** tzumainn has quit IRC03:12
*** mkrai has joined #openstack-ironic03:36
*** mkrai has quit IRC03:55
*** rcernin has quit IRC03:59
*** rcernin has joined #openstack-ironic04:00
TheJuliaarne_wiebalck: so I think I get what is going on with why the transactions are occuring04:12
TheJuliaand it is rooted in the use of orm. Realistically it is not that bad except it adds another exchange, the conundrum is that the there is python side latency when it converts the response to objects which adds a layer where we basically double the time it takes to download the result cursor from the database server to render it.04:14
TheJuliathe orm code also always runs joins by default which makes sense for objects, but not for things like getting the result set of nodes back out to nova.04:15
TheJuliaunfortunately, nova wants the trait list as well, which is in a separate table.04:15
TheJulia:\04:15
erbarris there an issue with config drive and ussuri? I've stacked twice today and tried to run tempest and it fails very quickly with an error on n-cond-cell1 that has, "Exception: a bytes like object is required, not 'str'\n"04:54
TheJuliasounds like your trying to use python2 ?04:59
TheJuliaerbarr: ^^^04:59
TheJuliaarne_wiebalck: and JayF might care about this as well. So the *list* out of ironic, when fields are defined, actually has a ton of extra work that is done to it which adds to the processing time. it _looks_ like we could base everything on the columns we know we want, get the required extra fields, hydrate that internal object with it (yes, we can actually do that because the way our code is written) (Yes,05:01
TheJuliaI've already done this locally), and let the api code handle that... which I *suspect* would shred the amount of time that the actual object and reconversions take05:01
*** openstackgerrit has quit IRC05:01
TheJuliathe downside, is the traits join for newer version users, and somewhere we do drop the version column but expect it to magically re-appear in the api object handling code05:01
TheJuliaonce I figure that out, it *looks* like I might be able to have the api spit out selected field nodes much faster05:02
erbarrTheJulia: i got USE_PYTHON3=True and PYTHON3_VERSION=3.6 in local.conf, same on train and train is fine05:02
TheJuliaerbarr: but your saying nova is spitting this error out?05:03
erbarryea, on ussuri05:03
erbarrthat's still bionic, right?05:04
* TheJulia shrugs05:04
TheJuliasupport is declared by python version, not distribution05:04
TheJuliawell, distribution version05:05
TheJuliaerbarr: what tempest test is causing this failure?05:05
erbarrbasic ops05:05
TheJuliawhich basic ops05:05
erbarrboth wholedisk and partition boot05:06
TheJuliaBaremetal Basic Ops, or Basic basic ops05:06
TheJuliaahh05:06
erbarrbaremetal05:06
TheJuliaso likely there is an incompatability somewhere in there since tempest tracks master05:06
* TheJulia wonders how this didn't come up ages ago05:07
erbarryea, i guess i'll try to see if i can even just do a deploy and no tempest05:07
TheJuliaerbarr: Unfortuantely  I've been working since like 6 AM, so I need to call it a day. I'd dump as much info as you can into an item on storyboard05:07
erbarrthat's a tomorrow thing tho, is late lol05:07
TheJuliaerbarr: you could also checkout an older tempest plugin most likely05:08
TheJuliasince they are versioned and released05:08
erbarrokay, thanks! have a good night!05:08
TheJuliaiurygregory: fyi ^^^05:08
*** maratg has joined #openstack-ironic05:20
*** maratg has quit IRC05:22
arne_wiebalckGood morning, ironic!06:47
iurygregoryTheJulia, ack I will look in a few06:51
iurygregorygood morning arne_wiebalck and Ironic o/06:51
arne_wiebalckhey, good morning iurygregory o/06:59
iurygregoryo/07:00
*** rcernin has quit IRC07:04
*** ociuhandu has joined #openstack-ironic07:06
*** ociuhandu has quit IRC07:07
*** ociuhandu has joined #openstack-ironic07:07
*** ociuhandu has quit IRC07:21
*** ociuhandu has joined #openstack-ironic07:22
*** ociuhandu has quit IRC07:27
*** rpittau|afk is now known as rpittau07:27
rpittaugood morning ironic! o/07:27
iurygregorymorning rpittau o/07:28
rpittauhey iurygregory :)07:29
iurygregoryerbarr, can you confirm the ironic-tempest-plugin version in train and ussuri? looking at CI both are tracking master... I'm wondering why we don't see the error in our Ci gates .-.07:30
*** ociuhandu has joined #openstack-ironic07:34
*** dtantsur|afk is now known as dtantsur07:40
* dtantsur rubs eyes07:40
dtantsurgood morning07:40
iurygregorymorning dtantsur o/07:41
iurygregoryhow did the meetup go? =)07:41
rpittaugood morning dtantsur :)07:41
dtantsuriurygregory: really well, we talked for 3.5 hrs :)07:41
dtantsurI'll try to summarize the main finding in a blog post once I wake up07:42
iurygregory(I hope 3.5 was the whole time slot - no extra time)07:42
iurygregorytake your time =)07:42
iurygregorygreat job =)07:42
dtantsurit was 3 hrs + extra time :)07:42
*** tosky has joined #openstack-ironic07:44
*** openstackgerrit has joined #openstack-ironic07:44
openstackgerritDmitry Tantsur proposed openstack/ironic-python-agent stable/wallaby: Always fall back to sysrq when power off fails  https://review.opendev.org/c/openstack/ironic-python-agent/+/78860207:44
arne_wiebalckdtantsur: very much looking forward to such a post!07:56
openstackgerritVerification of a change to openstack/ironic failed: Remove a pause before cleaning when fast-tracking  https://review.opendev.org/c/openstack/ironic/+/78845008:02
*** lucasagomes has joined #openstack-ironic08:05
*** ociuhandu has quit IRC08:11
*** ociuhandu has joined #openstack-ironic08:12
*** ociuhandu has quit IRC08:18
*** vmud213 has joined #openstack-ironic08:41
*** ociuhandu has joined #openstack-ironic08:50
*** ociuhandu has quit IRC08:56
*** k_mouza has joined #openstack-ironic09:01
openstackgerritxinliang proposed openstack/ironic-python-agent-builder master: Fix build error on aarch64  https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/78838809:16
*** ociuhandu has joined #openstack-ironic09:19
dtantsurTheJulia: hi! why are https://docs.openstack.org/ironic/latest/admin/node-multitenancy.html and https://docs.openstack.org/ironic/latest/admin/secure-rbac.html two different documents?09:24
*** ociuhandu has quit IRC09:24
*** bnemec has quit IRC09:27
*** ociuhandu has joined #openstack-ironic09:27
*** bnemec has joined #openstack-ironic09:28
*** k_mouza has quit IRC09:32
*** derekh has joined #openstack-ironic09:32
*** ociuhandu has quit IRC09:35
*** ociuhandu_ has joined #openstack-ironic09:35
*** k_mouza has joined #openstack-ironic09:39
*** zzzeek has quit IRC09:42
*** zzzeek has joined #openstack-ironic09:43
*** ociuhandu_ has quit IRC09:44
*** k_mouza has quit IRC09:44
*** k_mouza has joined #openstack-ironic09:47
dtantsurarne_wiebalck: I remember there were a lot of discussions re inventorization and ironic. has it led anywhere?10:09
arne_wiebalckdtantsur: for our deployment, yes :)10:09
arne_wiebalckdtantsur: we send inspection data to S3, extract it from there, and (will) add this into OpenDCIM10:10
arne_wiebalckdtantsur: with manual inspection on active nodes, we should (in theory) be able to also update this information10:11
dtantsurI see10:12
dtantsurthe S3 part, is it done through a hook?10:12
*** ociuhandu has joined #openstack-ironic10:14
*** zzzeek has quit IRC10:33
*** zzzeek has joined #openstack-ironic10:34
*** vmud213 has quit IRC10:44
*** akahat is now known as akahat|ruck10:50
*** iurygregory has quit IRC10:54
*** iurygregory has joined #openstack-ironic10:58
arne_wiebalckdtantsur: no, this the swift backend11:21
arne_wiebalckdtantsur: store_data = swift (but we do not have swift deployed and use Ceph RGW which is swift compliant)11:22
dtantsurI see11:27
*** k_mouza has quit IRC11:29
*** k_mouza has joined #openstack-ironic11:29
openstackgerritMerged openstack/ironic-python-agent stable/wallaby: Always fall back to sysrq when power off fails  https://review.opendev.org/c/openstack/ironic-python-agent/+/78860211:38
*** ociuhandu has quit IRC11:41
*** ociuhandu has joined #openstack-ironic11:42
*** ociuhandu has quit IRC11:47
*** ociuhandu has joined #openstack-ironic11:48
*** rh-jelabarre has joined #openstack-ironic11:52
*** ociuhandu has quit IRC11:53
openstackgerritWenping Song proposed openstack/ironic-specs master: setup.cfg: Replace dashes with underscores  https://review.opendev.org/c/openstack/ironic-specs/+/78871711:56
openstackgerritDmitry Tantsur proposed openstack/ironic master: Do not mask configdrive when executing in-band deploy steps  https://review.opendev.org/c/openstack/ironic/+/78871811:56
*** ociuhandu has joined #openstack-ironic12:14
*** ociuhandu has quit IRC12:20
*** ociuhandu has joined #openstack-ironic12:33
*** k_mouza has quit IRC12:34
TheJuliadtantsur: multitenancy was regarding networking I thought12:36
dtantsurTheJulia: no, this is specifically about ownership12:37
dtantsurwould be good to consolidate these two12:37
TheJuliayeah, in that case likely, one file will still exist and point to the other most likely12:37
dtantsurand good morning12:37
TheJuliagood morning12:37
TheJuliahttps://storyboard.openstack.org/#!/story/200886912:40
* TheJulia tries to wake up12:42
*** k_mouza has joined #openstack-ironic12:43
*** ociuhandu has quit IRC12:44
*** ociuhandu has joined #openstack-ironic12:45
dtantsurI'm still trying, no luck12:48
TheJuliaheh12:48
TheJuliaI have a podcast to jump on and 2 meetings I need to wake up for12:48
dtantsurpodcast, nice!12:48
* dtantsur spend 3.5 hrs on a meetup yersterday12:48
TheJuliaI ended up working like a 16 hour day... sqlalchemy sucked me in12:49
dtantsuryay, sqlalchemy12:49
janderssee you tomorrow Ironic o/12:52
rpittaubye janders o/12:52
iurygregorybye janders o/12:53
*** k_mouza has quit IRC12:53
iurygregorygood morning TheJulia =)12:53
*** mkrai has joined #openstack-ironic12:55
TheJuliadtantsur: i replied to you rindex change comment. You won't like two replies most likely, but I agree with the doc stuffs. Hopefully it will make sense. FWIW, local testing, w/o the maintenance column, it was 0.04 where as with 0.01 seconds for the cursor to return12:55
TheJuliawhich led to "why does sqlalchemy take so long to return results12:55
TheJuliaand then much sadness12:55
TheJuliamuch much much sadness12:55
dtantsurTheJulia: how many nodes did you use when testing maintenance? how many of them had maintenance=True?12:56
TheJuliadtantsur: 115k nodes, It think it was 10% in maintenance randomly12:57
TheJuliaI can go check a little later12:57
dtantsurTheJulia: have you warmed up caches first?12:58
TheJuliathat was with warmed cache12:58
dtantsur"It keeps it in memory instead of spread across the disk." doesn't seem the correct explanation to me12:58
dtantsurthe whole table probably fits in RAM, unless you limited it on purpose12:58
*** ociuhandu_ has joined #openstack-ironic12:58
TheJuliait is the tl;dr because the index maps get consulted before columns and htier contents12:58
dtantsuryeah, but the more indexes we have, the more space they take in memory12:58
TheJuliabecause the query optimization stuff looks for what may be the most restrictive indexes to apply first12:58
dtantsuris it possible to evaluate how much spaces the indexes take for your 115k nodes?12:59
TheJuliadtantsur: should be, but that will be later12:59
dtantsur"the most restrictive index" is actually a very good explanation, I haven't thought about it12:59
dtantsurbut I'd still check the size difference this change introduces12:59
TheJuliamysql and postgres have different names for the logic12:59
TheJuliabut both basically look for the most restrictive and reorder the query to go from most restrictive to leasts to pair down the rows that need manual evaluation13:00
TheJuliasure13:00
TheJuliaeasy to do, just need to get caffinated, ddressed, and ready to podcast13:00
*** ociuhandu has quit IRC13:01
*** k_mouza has joined #openstack-ironic13:01
*** rloo has joined #openstack-ironic13:01
openstackgerritRiccardo Pittau proposed openstack/ironic master: Provide an option to not cache bootable iso ramdisks  https://review.opendev.org/c/openstack/ironic/+/78873413:03
rpittauuh jess forgot the release note....13:04
rpittaublah I forgot another thing... ffff13:11
openstackgerritRiccardo Pittau proposed openstack/ironic master: Provide an option to not cache bootable iso ramdisks  https://review.opendev.org/c/openstack/ironic/+/78873413:23
*** zzzeek has quit IRC13:34
*** zzzeek has joined #openstack-ironic13:37
*** zzzeek has quit IRC13:40
*** zzzeek has joined #openstack-ironic13:41
*** k_mouza has quit IRC13:42
*** zzzeek has quit IRC13:42
*** zzzeek has joined #openstack-ironic13:43
*** tzumainn has joined #openstack-ironic13:44
*** ociuhandu_ has quit IRC13:49
*** ociuhandu has joined #openstack-ironic13:50
openstackgerritZane Bitter proposed openstack/ironic-python-agent master: Fix missing data in log messages  https://review.opendev.org/c/openstack/ironic-python-agent/+/78858613:56
openstackgerritZane Bitter proposed openstack/ironic-python-agent master: unit tests: Capture log output  https://review.opendev.org/c/openstack/ironic-python-agent/+/78858713:56
*** ociuhandu has quit IRC13:59
*** ociuhandu has joined #openstack-ironic14:01
*** ociuhandu has quit IRC14:06
*** mkrai has quit IRC14:07
*** ociuhandu has joined #openstack-ironic14:09
*** ociuhandu has quit IRC14:12
*** ociuhandu has joined #openstack-ironic14:13
*** ociuhandu has quit IRC14:13
*** ociuhandu has joined #openstack-ironic14:14
*** ociuhandu has quit IRC14:19
erbarriurygregory: i know the plugin I'm checking out master and passing the location to local.conf, i don't believe I'm setting any knobs to change tempest version, what's a sure way to check?14:23
*** ociuhandu has joined #openstack-ironic14:33
*** ociuhandu has quit IRC14:38
JayFTheJulia: ack, thanks for the summary. Basically what I expected :( We spent a huge amount of time trying to optimize around/with sqlalchemy at $lastjob14:41
iurygregoryerbarr, there shouldn't be a difference in our plugin itself (since you are using master), I'm wondering if is something in our code train vs ussuri...14:43
iurygregoryyou had a chance to test victoria?14:43
TheJuliaI have this feeling we could likely cut on the selected column queries, like those used by nova... substantially14:43
JayF++14:43
iurygregoryTheJulia, the corgi in the PTG recap was amazing :D14:43
TheJuliait was a huge derailing and it sounds like someone's home alarm is going off too14:44
rpittaummm PTG recap ?14:44
TheJuliaopeninfra live14:44
*** k_mouza has joined #openstack-ironic14:44
rpittauoh14:45
erbarriurygregory, yea from master to train only ussuri had an issue14:45
rpittauI missed it of course :/14:45
TheJuliaThere was a corgi objection14:45
TheJulia"grrrr Woof Woof"14:45
iurygregoryhehe yeah14:45
iurygregoryerbarr, weird, we are probably missing some backport I think =(14:45
rpittau:d14:45
erbarriurygregory, idk, "openstack server create" isn't working either so seems like a nova thing to me but idk that much14:46
iurygregorycan be =)14:48
*** paras333_ has joined #openstack-ironic14:58
openstackgerritRiccardo Pittau proposed openstack/ironic master: Provide an option to not cache bootable iso ramdisks  https://review.opendev.org/c/openstack/ironic/+/78873415:02
openstackgerritRiccardo Pittau proposed openstack/ironic master: Provide an option to not cache bootable iso ramdisks  https://review.opendev.org/c/openstack/ironic/+/78873415:07
*** zzzeek has quit IRC15:09
*** zzzeek has joined #openstack-ironic15:10
*** ociuhandu has joined #openstack-ironic15:21
rpittaudtantsur: I think centos7/python2 compatibility is gone on ipa-builder15:31
dtantsur:(15:32
dtantsurwhy?15:32
rpittauI'm not 100% sure, but looking at recent CI logs I can see the test failing as it can't find pbr>=215:33
rpittaufor python 215:33
rpittauhttps://274c506cda779b308daa-70ebae5b6c1b3c9f5a56fab857f079c1.ssl.cf1.rackcdn.com/788388/3/check/ironic-python-agent-check-image-dib-centos7/2767920/job-output.txt15:33
dtantsurOo15:33
dtantsurrpittau: maybe we need update pip further?15:33
iurygregoryWOOT15:33
rpittaummmm15:33
dtantsurthere have definitely been pbr 2.x releases for python 215:33
rpittausame pip on centos815:34
rpittaualthough python 3 there15:34
rpittauthis is the error distutils.errors.DistutilsError: Could not find suitable distribution for Requirement.parse('pbr>=2.0.0')15:34
dtantsurI seem to recall something about pip not falling back to an older version if the new version is not Python 2 compatible15:34
dtantsurmaybe we need to try explicitly installing 'pbr>=2.0.0,<3.0' first?15:34
rpittauI can give it a try with pip >=2015:34
rpittauor that, yeah15:35
rpittauthat's on ipa side though, not sure if we can change pbr versions there now15:36
dtantsurrpittau: it's not about changing, it's a hack we can insert in IPA-builder15:36
dtantsuractually maybe not <3, maybe <515:37
dtantsurpbr is at 5.6.0 now15:37
rpittauok, so modify upper-constraints on the fly ?15:38
dtantsurI don't think we're getting to upper-constraints at this point15:38
openstackgerritMerged openstack/ironic stable/wallaby: Remove a pause before cleaning when fast-tracking  https://review.opendev.org/c/openstack/ironic/+/78845015:38
dtantsurthis is probably triggered by setup.py15:38
rpittauwe are, the error is triggered by /opt/ironic-python-agent/bin/pip install -c /tmp/requirements/upper-constraints.txt /tmp/ironic-python-agent15:39
dtantsurrpittau: look at the traceback, it's not pip15:39
dtantsurrpittau: we may solve it by installing requirements separately first btw15:40
dtantsurso start with -r /tmo/ironic-python-agent/requirements.txt15:40
rpittauoh ok, I got confused by the command15:40
rpittaurequirements first should work, I'll do a local test first15:44
dtantsurI think we're ready for another ironic wallaby release15:44
rpittauoh the patch merged15:45
rpittaudo we want to wait for https://review.opendev.org/c/openstack/ironic/+/788446 ?15:46
*** gyee has joined #openstack-ironic15:52
*** ociuhandu_ has joined #openstack-ironic15:58
*** ociuhandu has quit IRC16:02
*** lucasagomes has quit IRC16:03
*** ociuhandu_ has quit IRC16:03
*** ociuhandu has joined #openstack-ironic16:23
*** uzumaki has joined #openstack-ironic16:24
*** ociuhandu has quit IRC16:27
*** zzzeek has quit IRC16:37
*** zzzeek has joined #openstack-ironic16:39
dtantsurjust docs, not necessary16:49
*** dtantsur is now known as dtantsur|afk16:49
rpittauack16:49
openstackgerritRiccardo Pittau proposed openstack/ironic-python-agent-builder master: [WIP] fix centos7 job  https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/78880416:49
*** iurygregory has quit IRC16:58
rpittausee ya tomorrow folks! o/16:59
*** rpittau is now known as rpittau|afk16:59
*** derekh has quit IRC17:01
*** k_mouza has quit IRC17:16
*** k_mouza has joined #openstack-ironic17:17
TheJuliadtantsur: so size with no data on the index seems not to even register as really measurable change. I did have about 75k unique owners and 22.5k unique lesses and that did cause the indexes on my data set to be at ~50 MB instead of 39MB, but it didn't even blink otherwise. Of course, there is white space in that from the tables churning (like my db was 53 MB and index 59MB before repacking), but I also had17:19
TheJuliamultiple indexes and a couple test composites as well. I think part of it is the changes seem to be fitting with-in the preallocated space buffer on tables/indexes17:19
*** k_mouza has quit IRC17:22
*** iurygregory has joined #openstack-ironic17:31
*** iurygregory has quit IRC17:31
*** zzzeek has quit IRC17:32
openstackgerritMerged openstack/ironic-python-agent master: Fix missing data in log messages  https://review.opendev.org/c/openstack/ironic-python-agent/+/78858617:36
openstackgerritMerged openstack/ironic stable/wallaby: Docs: dhcp-less works with Glean 1.19.0  https://review.opendev.org/c/openstack/ironic/+/78844617:36
openstackgerritMerged openstack/ironic-python-agent master: unit tests: Capture log output  https://review.opendev.org/c/openstack/ironic-python-agent/+/78858717:36
*** zzzeek has joined #openstack-ironic17:36
*** iurygregory has joined #openstack-ironic17:38
openstackgerritArne Wiebalck proposed openstack/ironic-python-agent master: Burn-in: Add CPU step  https://review.opendev.org/c/openstack/ironic-python-agent/+/78821117:48
arne_wiebalckbye everyone o/17:52
iurygregorybye arne_wiebalck o/17:57
*** MahnoorAsghar has joined #openstack-ironic18:01
arne_wiebalckTheJulia: iurygregory: first burn-in step https://review.opendev.org/c/openstack/ironic-python-agent/+/788211, let me know in case you have major issues with this as I plan to add the others (for mem, disk, net) in a simialr way. TIA!18:07
arne_wiebalckrpittau|afk: and dtantsur|afk had an initial look and did not disapprove :)18:07
* arne_wiebalck really calls it a day now :)18:08
iurygregoryack =)18:08
NobodyCamGood Morning Ironic folks.18:12
*** uzumaki has quit IRC18:25
*** zzzeek has quit IRC18:41
*** zzzeek has joined #openstack-ironic18:42
openstackgerritZane Bitter proposed openstack/ironic-python-agent master: Fix getting memory size in some lshw output  https://review.opendev.org/c/openstack/ironic-python-agent/+/78858818:44
TheJuliagood morning NobodyCam18:44
NobodyCam:) o/ TheJulia18:47
iurygregorymorning NobodyCam o/18:54
NobodyCammorning iurygregory18:55
NobodyCamhow goes the day18:55
iurygregorywaiting for my dinner while looking at terraform logs \o/18:57
iurygregoryand ironic logs :D18:57
NobodyCamoh fun!18:58
iurygregoryyup, trying to make instance_info/capabilities show up when deploying nodes :D18:58
*** k_mouza has joined #openstack-ironic19:17
*** k_mouza has quit IRC19:23
TheJuliashow up where?19:30
iurygregoryTheJulia, terraform wasn't setting the instance_info/capabilities on the node, so I'm trying to fix that =)19:36
*** frigo has joined #openstack-ironic19:39
TheJuliaoh joy19:41
iurygregorythe best part is that terraform doesn't accept nested dicts :D and capabilities is a dict .. *BOOM* :D19:43
*** ociuhandu has joined #openstack-ironic19:47
*** paras333_ has quit IRC19:52
*** ociuhandu has quit IRC19:54
frigohello Ironic! out of curiosity, you are working with the "terraform-provider-ironic" from metal3?19:57
iurygregoryfrigo, at the moment I'm =)19:58
iurygregorynot metal3 but openshift-metal3 =)19:58
iurygregoryhttps://github.com/openshift-metal3/terraform-provider-ironic19:58
frigoyes ok:)  I tried it just a few days ago19:58
frigoif you manage to have a "make install" that works with recent versions of terraform that'd be just great19:59
frigoinstalling custom provider in terraform seems painful19:59
frigo(maybe I should do have done that myself now that I am thinking)20:00
iurygregoryI've never installed directly (either using openshift-installer or dev-scripts) =)20:00
iurygregoryI'm hacking the source code to make the changes hehe20:01
iurygregoryto see the results20:01
*** jobewan has quit IRC20:03
frigo:)  good luck20:05
iurygregorytks =D20:05
*** cenne|out is now known as cenne20:32
cennehello20:34
cenneSorry for the extra delay. Wasn't feeling well after I returned. Am fine now. I should have sent an email sooner. my bad.20:36
cenneI'll try not to let that happen again.20:36
cenneyy20:36
cennehi iurygregory: nice seeing you guys again.20:37
cennegood day everyone!20:37
*** frigo has quit IRC20:51
stevebakermorning20:57
*** rcernin has joined #openstack-ironic21:44
*** rcernin has quit IRC21:56
*** rcernin has joined #openstack-ironic22:02
*** rcernin has quit IRC22:37
jandersgood morning stevebaker22:55
janders(and Ironic)22:55
TheJuliaSo.... I basically tried to rewire so we don't expand the full models on selected column queries. Basically looks like a wash performance change wise. maybe 5% faster, but that seems to vary a lot.23:07
stevebakerTheJulia: Is it possible to express the improvement in terms of reduced query count?23:15
TheJuliaI think we would need a way to do a bulk query that is not restricted to 1000 nodes23:16
TheJuliaThat *should* return in a relatively sane speed23:16
TheJuliabut the existing query to get thousands of nodes keeps rerunning the query just ends up moving the cursor23:17
TheJuliawhich is *not* nice to the DB unless there is an index precisely matching the query pattern23:17
TheJuliaThe way sqlalchemy works with the way we've got everything coded....23:18
TheJuliaThe entire result set gets shipped to the client23:18
*** k_mouza has joined #openstack-ironic23:18
TheJuliathat gets converted to objects23:18
stevebakerright23:18
*** MahnoorAsghar has quit IRC23:18
TheJuliaand you can guess what happens there23:18
*** rcernin has joined #openstack-ironic23:19
stevebakeryep23:19
TheJuliaLikely we need to slim that down to just columns, but it won't make it *much* faster... ~5% when I ran a bulk query (and I've not solved joining traits in so that may be skewing it that 5%)23:19
TheJuliaHmmm... 59k in 624 seconds so far23:20
TheJuliaI'm guessing thermal throttling, the fan is running harder and it is a little warmer in here23:20
stevebakerhow make fake nodes are you doing this against?23:20
TheJulia115k23:21
TheJuliaif we were to take default pagination to 10k nodes, it would cut the query load down subtantially23:22
*** k_mouza has quit IRC23:22
stevebakero_O23:23
TheJuliaYeah, this is going to end up being more like 10% slower on this second run23:23
TheJulia:(23:23
* TheJulia wins at making ironic slower23:23
stevebakerTheJulia: how about a dedicated API call which has an implementation that doesn't use sqlalchemy or rpc object abstractions?23:27
TheJuliaThat would be *much* faster. We wouldn't be able to ensure versioning on the same level we do today23:28
TheJuliaBut we don't have object upgrade code all over the place, so it should be fine and navigable23:28
TheJuliaAnd sqlalchemy really is fine, it is the orm models that bite us23:29
TheJuliaIn theory, a dedicated endpoint could also immediately begin streaming back results23:32
TheJuliaBut that might be a little hard to do with the assembly of the api as is23:32
TheJuliaI should likely dump my hacked code to a change and upload it23:33
TheJuliaSo it is 2C warmer in the office today than it was yesterday....23:37
TheJuliaSo yay thermal throttling.23:37
*** tosky has quit IRC23:40
stevebakeryeah may as well put it up as a review, for a bit more context23:42
*** k_mouza has joined #openstack-ironic23:57

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!