Tuesday, 2021-02-02

openstackgerritJulia Kreger proposed openstack/ironic master: Implement secure RBAC for baremetal nodes  https://review.opendev.org/c/openstack/ironic/+/76325700:04
openstackgerritJulia Kreger proposed openstack/ironic master: Implement secure RBAC for ports  https://review.opendev.org/c/openstack/ironic/+/76326700:04
openstackgerritJulia Kreger proposed openstack/ironic master: Implement secure RBAC for port groups  https://review.opendev.org/c/openstack/ironic/+/76326800:04
openstackgerritJulia Kreger proposed openstack/ironic master: Implement secure RBAC for chassis  https://review.opendev.org/c/openstack/ironic/+/76326900:04
openstackgerritJulia Kreger proposed openstack/ironic master: Implement secure RBAC for baremetal drivers  https://review.opendev.org/c/openstack/ironic/+/76327000:04
openstackgerritJulia Kreger proposed openstack/ironic master: Implement secure RBAC for node and driver passthru  https://review.opendev.org/c/openstack/ironic/+/76327100:04
openstackgerritJulia Kreger proposed openstack/ironic master: Implement secure RBAC for utility APIs  https://review.opendev.org/c/openstack/ironic/+/76327200:04
openstackgerritJulia Kreger proposed openstack/ironic master: WIP: Tea pot response  https://review.opendev.org/c/openstack/ironic/+/77354800:04
*** MentalSiege has quit IRC00:07
*** dsneddon has quit IRC00:35
*** dsneddon has joined #openstack-ironic00:38
*** rloo has quit IRC00:39
-openstackstatus- NOTICE: The Gerrit service on review.opendev.org is being quickly restarted to apply a new security patch00:56
*** k_mouza has joined #openstack-ironic00:59
*** k_mouza has quit IRC01:03
*** gyee has quit IRC01:09
openstackgerritJacob Anders proposed openstack/ironic-python-agent-builder master: Add support for using NVMe specific cleaning  https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/77353801:28
*** rcernin has quit IRC01:44
*** xinliang has joined #openstack-ironic02:00
*** zzzeek has quit IRC02:07
*** lmcgann has quit IRC02:07
*** rcernin has joined #openstack-ironic02:09
*** zzzeek has joined #openstack-ironic02:10
*** zzzeek has quit IRC02:24
*** zzzeek has joined #openstack-ironic02:25
*** tzumainn has quit IRC02:32
*** uzumaki has quit IRC02:32
*** paras333 has quit IRC02:41
*** Qianbiao has joined #openstack-ironic02:45
*** zzzeek has quit IRC02:48
*** zzzeek has joined #openstack-ironic02:52
*** irclogbot_2 has quit IRC03:27
*** uzumaki has joined #openstack-ironic03:28
*** pmannidi has quit IRC03:54
*** mkrai has joined #openstack-ironic04:02
*** stendulker has joined #openstack-ironic04:08
*** ricolin_ has joined #openstack-ironic04:13
*** pmannidi has joined #openstack-ironic04:15
*** xinliang has quit IRC04:26
*** irclogbot_3 has joined #openstack-ironic04:41
*** stendulker has quit IRC04:51
*** irclogbot_3 has quit IRC04:54
*** Qianbiao has quit IRC04:55
*** irclogbot_0 has joined #openstack-ironic04:58
*** stendulker has joined #openstack-ironic04:59
*** mkrai has quit IRC05:06
*** ociuhandu has joined #openstack-ironic05:07
*** ociuhandu has quit IRC05:12
*** k_mouza has joined #openstack-ironic05:21
*** k_mouza has quit IRC05:26
*** mkrai has joined #openstack-ironic05:29
*** ricolin_ has quit IRC05:35
*** ricolin has joined #openstack-ironic05:39
*** priteau has quit IRC05:47
*** lbragstad_ has joined #openstack-ironic06:24
*** lbragstad has quit IRC06:24
*** moshiur has joined #openstack-ironic06:27
*** xinliang has joined #openstack-ironic06:32
*** mkrai_ has joined #openstack-ironic06:54
*** mkrai has quit IRC06:58
*** Qianbiao has joined #openstack-ironic07:02
*** mkrai_ has quit IRC07:16
*** rcernin has quit IRC07:37
openstackgerritankit proposed openstack/sushy stable/victoria: Fixes issue of redfish firmware update  https://review.opendev.org/c/openstack/sushy/+/77160407:40
arne_wiebalckGood morning, ironic!07:43
*** mkrai_ has joined #openstack-ironic07:54
*** dsneddon has quit IRC08:00
*** uzumaki has quit IRC08:09
*** rcernin has joined #openstack-ironic08:14
*** stendulker has quit IRC08:22
*** rpittau|afk is now known as rpittau08:25
rpittaugood morning ironic! o/08:25
*** zaneb has quit IRC08:30
rpittaujanders, TheJulia, I'm afraid if we want nvme-cli on tinycore will have to compile it ourselves :/08:30
openstackgerritRiccardo Pittau proposed openstack/ironic-python-agent-builder master: Update version of tgt to 1.0.80  https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/77360408:31
*** rcernin has quit IRC08:31
*** zaneb has joined #openstack-ironic08:33
*** dtantsur|afk is now known as dtantsur08:36
dtantsurmorning ironic08:37
dtantsurrpittau: not the first time we need to compile something to tinycore08:37
rpittauyeah08:37
rpittaugood morning dtantsur :)08:38
dtantsurJayF, arne_wiebalck, root device hints are, in fact, supported by all 3 real deploy methods we have, although support in the ansible deploy is partial08:39
*** tosin has joined #openstack-ironic08:39
*** dougsz has joined #openstack-ironic08:40
arne_wiebalckhey dtantsur o/08:46
arne_wiebalckthanks08:46
arne_wiebalckdtantsur: any thoughts on: 'was "setting root device hints automatically" already discussed and discarded in the history of Ironic? (before I file a story :))'08:46
arne_wiebalckdtantsur: or, even better, the idea? ;)08:47
dtantsurarne_wiebalck: well, I even wrote something like that for tripleo. let me see if it still exists.08:47
arne_wiebalckdtantsur: uh!08:47
dtantsurarne_wiebalck: https://opendev.org/openstack/tripleo-common/src/branch/master/tripleo_common/actions/baremetal.py#L211-L29908:49
dtantsurI think we could have such a plugin in ironic-inspector instead08:50
* arne_wiebalck is reading ...08:51
*** paras333 has joined #openstack-ironic08:55
*** priteau has joined #openstack-ironic08:57
arne_wiebalckdtantsur: that looks nice ... for disk replacements, I would think the scsi address may be better than the name, no?08:57
dtantsurlikely, but people love using names08:58
arne_wiebalckagree, but that is quite risky08:58
dtantsuryep08:58
arne_wiebalckthanks, dtantsur, I will create a story to add a plugin to the inspector08:59
dtantsur++08:59
*** paras333 has quit IRC08:59
dtantsurif anybody has time, please review https://review.opendev.org/c/openstack/ironic/+/77338208:59
dtantsurand https://review.opendev.org/c/openstack/ironic/+/77149309:00
*** rcernin has joined #openstack-ironic09:00
*** tosky has joined #openstack-ironic09:02
*** lucasagomes has joined #openstack-ironic09:06
arne_wiebalckdtantsur: https://storyboard.openstack.org/#!/story/200857809:12
arne_wiebalckdtantsur: feel free to amend09:12
*** rcernin has quit IRC09:18
*** rcernin has joined #openstack-ironic09:23
*** ociuhandu has joined #openstack-ironic09:29
jandersgood morning arne_wiebalck rpittau dtantsur09:34
janders(and Ironic o/)09:34
rpittauhey janders :)09:34
jandersrpittau dtantsur thank you for the pointers regarding nvme-cli and tinycore. Is this something I really need to sort out, or a minor inconvenience?09:35
rpittauwell, do we need nvme-cli in tinycore ?09:37
rpittauare we going to test nvme tools using tinycore ?09:38
*** derekh has joined #openstack-ironic09:39
*** ociuhandu has quit IRC09:44
*** ociuhandu has joined #openstack-ironic09:44
openstackgerritTianhao Hu proposed openstack/ironic master: Mark the iSCSI deploy as deprecated in the docs  https://review.opendev.org/c/openstack/ironic/+/77362209:52
viks____hi, when i try to create instance with `--config-drive true`, i get the below error:09:53
viks____https://www.irccloud.com/pastebin/L1OL5iFn/09:53
viks____any suggestions?09:54
*** dsneddon has joined #openstack-ironic10:01
dtantsurviks____: we need more context, there should be some output around the failure10:02
*** rcernin has quit IRC10:08
viks____dtantsur:  here  it is: http://paste.openstack.org/show/802225/10:09
viks____baiscally i'm checking by enabling `--config-drive true`, if i can make ssh to baremetal instance work...10:11
*** rcernin has joined #openstack-ironic10:19
jandersrpittau regarding tinycore- is there such thing as the most common OS ised as a base of IPA and if so what is it?10:27
*** xinliang has quit IRC10:28
*** k_mouza has joined #openstack-ironic10:28
*** tosky has quit IRC10:33
*** tosky has joined #openstack-ironic10:34
*** k_mouza has quit IRC10:35
*** k_mouza has joined #openstack-ironic10:35
dtantsurviks____: you seem to have an old blkid10:36
openstackgerritDmitry Tantsur proposed openstack/ironic master: ilo: do not change deploy_boot_mode in instance_info  https://review.opendev.org/c/openstack/ironic/+/77363110:41
iurygregorygood morning rpittau arne_wiebalck dtantsur janders and Ironic o/10:54
arne_wiebalckhey janders and iurygregory o/11:05
openstackgerritDmitry Tantsur proposed openstack/ironic master: Make boot_mode more consistent with other capabilities  https://review.opendev.org/c/openstack/ironic/+/77363611:07
*** rcernin has quit IRC11:13
*** lmcgann has joined #openstack-ironic11:14
viks____dtantsur: i use `CentOS Linux release 7.9` it has default version 2.23. i could not find any newer version in centos 7 repo11:18
*** uzumaki has joined #openstack-ironic11:32
*** rcernin has joined #openstack-ironic11:35
*** hoonetorg has quit IRC11:38
*** sshnaidm|ruck is now known as sshnaidm|afk11:38
*** k_mouza has quit IRC11:46
rpittaujanders: if you see in ipa-builder we build ipa images using different distros as base, like centos, debian, ubuntu, and fedora. These are better shaped for production usage, tinyipa is usually just used in CI for testing purpose11:51
*** mkrai_ has quit IRC11:53
dtantsurThis looks like iSCSI deploy, so the host OS11:59
dtantsurI don't think we support CentOS 7 as a host OS at this point12:00
*** k_mouza has joined #openstack-ironic12:00
*** rcernin has quit IRC12:04
*** k_mouza has quit IRC12:07
*** k_mouza has joined #openstack-ironic12:07
rpittauviks____: the '-p' option in blkid is available in version 2.23 though12:08
*** iurygregory_ has joined #openstack-ironic12:09
*** iurygregory has quit IRC12:09
rpittauviks____: looking at the logs you posted it seems you have a quite older version (1.0.0)12:11
openstackgerritMerged openstack/ironic stable/victoria: Refactor vendor detection and add Redfish implementation  https://review.opendev.org/c/openstack/ironic/+/77338812:25
openstackgerritBob Fournier proposed openstack/ironic stable/victoria: For Supermicro BMCs set enable when changing boot device  https://review.opendev.org/c/openstack/ironic/+/77365612:29
*** sshnaidm|afk is now known as sshnaidm|ruck12:36
openstackgerritVerification of a change to openstack/ironic failed: Apply force_persistent_boot_device to all boot interfaces  https://review.opendev.org/c/openstack/ironic/+/77338212:44
*** anuradha1904 has joined #openstack-ironic12:51
*** hoonetorg has joined #openstack-ironic13:03
*** iurygregory_ is now known as iurygregory13:04
viks____rpittau: srry.. blkid version is 1.0.0 .. actually when checked with yum, blkid is a part of `util-linux-2.23.2-65`..  i just realized that i have 2 systems, where both of the `util-linux`(2.23.2-65) version is same but not the blkid version..13:05
openstackgerritJacob Anders proposed openstack/ironic-python-agent master: Add support for using NVMe specific cleaning  https://review.opendev.org/c/openstack/ironic-python-agent/+/77190413:06
jandersack, thank you rpittau13:07
janderssee you tomorrow Ironic o/13:08
rpittausee ya janders :)13:08
*** moshiur has quit IRC13:10
openstackgerritVerification of a change to openstack/ironic failed: Apply force_persistent_boot_device to all boot interfaces  https://review.opendev.org/c/openstack/ironic/+/77338213:14
iurygregorybye janders o/13:23
*** moshiur has joined #openstack-ironic13:31
rpittaurmrrr the issue with bifrost in ussuri seems due to a bug in ansible.....13:52
*** ociuhandu has quit IRC13:53
dtantsur\o/13:57
openstackgerritRiccardo Pittau proposed openstack/bifrost stable/ussuri: Fix CI issues  https://review.opendev.org/c/openstack/bifrost/+/76674213:59
openstackgerritMudit proposed openstack/ironic master: More GPU support in idrac-wsman inspect interface  https://review.opendev.org/c/openstack/ironic/+/77335913:59
rpittauproblem is we used ansible 2.8 in ussuri, which is an undead version since its maintenance stopped in november 201914:00
rpittauEOL 21 january 202114:00
rpittauoh well, let's see how the CI goes first14:00
*** paras333 has joined #openstack-ironic14:04
*** rloo has joined #openstack-ironic14:06
*** dsneddon has quit IRC14:07
*** ociuhandu has joined #openstack-ironic14:10
TheJuliawell, maybe kill ussuri bifrost jobs at this point?14:11
rpittauheh I wouldn't say no to that, but aren't we suppose to keep supporting ussuri ?14:16
*** tzumainn has joined #openstack-ironic14:26
TheJuliais it realistically to make things work that just will not work?14:27
TheJuliaespecially on a master focused tool14:27
iurygregorycan't we switch to 2.9?14:27
rpittau that's what I'm doing, I switched to 2.914:28
iurygregorywould be a problem because of requirements...14:28
iurygregory?14:28
iurygregoryoh nice!14:28
rpittauit's a requirement, but it's broken, so I'm not sure here to be honest14:29
iurygregoryyep =)14:29
*** ociuhandu has quit IRC14:30
rpittauTheJulia: I understand what you mean and I agree, I don't want to keep it forcefully alive, also considering that we'll have also to switch to centos8-stream, so if we want to abandon it I'm fine with that14:31
*** ociuhandu has joined #openstack-ironic14:31
*** ociuhandu has quit IRC14:36
*** uzumaki has quit IRC14:36
TheJuliawe can only do so much14:37
TheJuliaLooks like monday works best for a review jam... Well, Steve's tuesday.14:45
*** ociuhandu has joined #openstack-ironic14:48
TheJuliatosin: Just fyi, I have a doctor's appointment I need to go to in about an hour, I pushed our call back a half hour, but I may miss it since I will be at the mercy of the doctor's office14:48
* dtantsur approves of this goal https://review.opendev.org/c/openstack/governance/+/77061614:51
dtantsurTheJulia: killing jobs for bifrost for ussuri = EOL ussuri14:51
dtantsurnot impossible, but violates what openstack expects us to14:51
dtantsur(bifrost is different in this regard, you cannot assume it probably still works even if devstack is broken)14:52
dtantsurspeaking of bifrost, https://review.opendev.org/c/openstack/governance/+/770855 may affect us14:52
dtantsur(not literally affect, as in the CI breakage, but spiritually)14:53
rpittauspiritually... yeah... wow....14:54
dtantsurincidentally, opensuse is broken in bifrost right now14:54
dtantsurwhich makes me want to Just Do It14:54
rpittauI (sadly) approve14:54
openstackgerritJulia Kreger proposed openstack/metalsmith master: Change metalsmith to centos8+uefi job by default  https://review.opendev.org/c/openstack/metalsmith/+/77370114:54
tosinTheJulia: oh that's fine! I'll just stay on the call. All the best at the doctor's =)14:55
TheJuliaAm I advocating killing all jobs?14:55
rpittaummmm14:55
rpittauok, I guess it's reasonable to remove centos8 job from ussuri in bifrost considering all the changes?14:55
dtantsurIMO no14:56
TheJuliaIs that the job that is failing?14:56
rpittauyeah14:56
TheJuliahave we identified why it is failing?14:56
dtantsurit means that bifrost ussuri is broken on at least (!) one of the two primary OS14:56
rpittauthe problem is not centos per-se, it's ansible14:56
TheJuliaOSes change and evolve, their packages change14:57
TheJuliaThe stable commitment OSes HAD is gone.14:57
rpittauansible 2.8 to be precise14:57
dtantsur2.9 doesn't fix it?14:57
dtantsurI'm much more open to updating the ansible version than to drop a supported OS14:57
rpittaudtantsur: locally it seems to work, I'm waiting for CI14:57
dtantsur(although I guess CentOS 8 won't gain a lot of popularity. sigh. SIGH)14:58
*** ociuhandu has quit IRC14:58
rpittaummm I think it made it worse :D14:58
dtantsur\o/14:58
dtantsurwell, NOW you can EOL it :D14:58
TheJulia\o/14:58
rpittauoh ok ok14:59
rpittauit's a stupid filter, maybe I can fix it losing a reasonable amount of neurons14:59
openstackgerritJulia Kreger proposed openstack/ironic master: Swap Metalsmith job out for centos8-uefi  https://review.opendev.org/c/openstack/ironic/+/77370215:02
*** MentalSiege has joined #openstack-ironic15:03
*** nam-est has joined #openstack-ironic15:06
nam-estHi all, please give some review to this: https://github.com/metal3-io/ironic-image/pull/230. Thank you15:07
openstackgerritJulia Kreger proposed openstack/ironic master: Remove ironic-tempest-ipa-partition-pxe_ipmitool from gate  https://review.opendev.org/c/openstack/ironic/+/77370515:12
*** MentalSiege has quit IRC15:14
TheJuliaLooks like ironic-tempest-partition-bios-redfish-pxe is redundant, but we use it on sushy instead of the standalone job15:15
*** MentalSiege has joined #openstack-ironic15:15
*** ociuhandu has joined #openstack-ironic15:18
openstackgerritDmitry Tantsur proposed openstack/bifrost master: DNM test CI  https://review.opendev.org/c/openstack/bifrost/+/77370615:19
dtantsurTheJulia: well, that's easy to fix15:19
openstackgerritRiccardo Pittau proposed openstack/bifrost stable/ussuri: Fix CI issues  https://review.opendev.org/c/openstack/bifrost/+/76674215:19
dtantsur(left a comment re pxe_ipmitool job)15:19
TheJuliahmm, I mus thave looked at the line above or something15:21
*** ociuhandu has quit IRC15:22
*** ociuhandu has joined #openstack-ironic15:23
dtantsurI *think* we test cleaning bifrost, but it doesn't cover neutron integration, soo...15:23
*** ociuhandu has quit IRC15:23
dtantsur* in bifrost15:23
dtantsurweekend project: finish bifrost neutron integration :)15:24
TheJuliaThe whole intent of the standalone jobs was to peel back all of single scenario jobs15:24
* TheJulia ponders15:25
*** ociuhandu has joined #openstack-ironic15:25
dtantsurI think if we could sit down with a whiteboard, plenty of time and whiskey, we would solve this problem15:25
TheJuliawould a virtual whiteboard work?15:27
TheJuliayou know, we have an automated clean knob.....15:28
TheJuliawe coul dmove it into tempest15:28
dtantsurnot for me :( I cannot feel thoughts connecting over the wires any more15:28
dtantsursometimes it feels like I'm talking to my laptop the whole day15:28
TheJuliaI know this feeling really well :(15:28
*** ociuhandu has quit IRC15:31
*** ociuhandu has joined #openstack-ironic15:31
openstackgerritDmitry Tantsur proposed openstack/sushy master: Automatically retry HTTP 5xx on GET requests  https://review.opendev.org/c/openstack/sushy/+/77371115:35
*** uzumaki has joined #openstack-ironic15:38
*** ociuhandu has quit IRC15:41
openstackgerritRiccardo Pittau proposed openstack/bifrost stable/ussuri: Fix CI issues  https://review.opendev.org/c/openstack/bifrost/+/76674215:43
*** uzumaki has quit IRC15:55
*** uzumaki has joined #openstack-ironic15:57
openstackgerritMerged openstack/ironic master: Fixes issue of redfish firmware update  https://review.opendev.org/c/openstack/ironic/+/76491415:58
*** rloo has quit IRC16:00
*** rloo has joined #openstack-ironic16:00
openstackgerritAija Jauntēva proposed openstack/sushy master: Fix Bad request error when checking task status  https://review.opendev.org/c/openstack/sushy/+/77372416:15
openstackgerritMerged openstack/ironic master: Pass context objects directly to policy enforcement  https://review.opendev.org/c/openstack/ironic/+/77208616:17
*** lbragstad_ is now known as lbragstad16:21
*** k_mouza has quit IRC16:25
*** Qianbiao has quit IRC16:32
*** ociuhandu has joined #openstack-ironic16:34
*** ociuhandu has quit IRC16:35
*** ociuhandu has joined #openstack-ironic16:35
*** k_mouza has joined #openstack-ironic16:52
TheJuliatosin: just making ocffee, about five minutes17:01
TheJuliacoffee17:01
tosinTheJulie: ok😄17:03
openstackgerritVerification of a change to openstack/ironic failed: Apply force_persistent_boot_device to all boot interfaces  https://review.opendev.org/c/openstack/ironic/+/77338217:04
*** lucasagomes has quit IRC17:04
*** ociuhandu has quit IRC17:06
*** ociuhandu has joined #openstack-ironic17:07
*** ociuhandu has quit IRC17:13
*** rloo has quit IRC17:18
*** rloo has joined #openstack-ironic17:19
*** ociuhandu has joined #openstack-ironic17:19
*** rloo has quit IRC17:22
*** rloo has joined #openstack-ironic17:22
*** ociuhandu has quit IRC17:25
*** dougsz has quit IRC17:33
*** ociuhandu has joined #openstack-ironic17:36
*** ociuhandu has quit IRC17:40
*** ociuhandu has joined #openstack-ironic17:52
*** k_mouza has quit IRC17:53
arne_wiebalckbye everyone o/17:56
*** ociuhandu has quit IRC17:59
*** rcernin has joined #openstack-ironic17:59
*** ociuhandu has joined #openstack-ironic18:02
*** derekh has quit IRC18:04
*** rcernin has quit IRC18:04
openstackgerritVerification of a change to openstack/ironic failed: Apply force_persistent_boot_device to all boot interfaces  https://review.opendev.org/c/openstack/ironic/+/77338218:05
*** rloo has quit IRC18:05
*** rloo has joined #openstack-ironic18:06
*** ociuhandu has quit IRC18:06
*** k_mouza has joined #openstack-ironic18:09
*** ociuhandu has joined #openstack-ironic18:15
*** ociuhandu has quit IRC18:15
*** ociuhandu has joined #openstack-ironic18:15
bfournieHi TheJulia: for the BIOS registry stuff, the response from the bmc for BIOS registry is about 50k compressed. Do we have any concerns with storing this in the database? do we handle caching large entries like this elsewhere?18:16
TheJuliabfournie: storing in the db PER node?!?18:22
TheJuliaWhy would we cache it?18:23
TheJuliaDo we need it?18:23
*** k_mouza has quit IRC18:23
*** ociuhandu has quit IRC18:27
bfournieTheJulia: so if we are going to add api to return the BIOS registry (per mid cycle discussion) I don't think we'd want to do it synchronously, we'd have to cache it, but we wouldn't need to do it per node - all vendors of same type will be using same registry so we'd only have to cache unique ones18:29
*** ociuhandu has joined #openstack-ironic18:30
*** ociuhandu has quit IRC18:30
openstackgerritVerification of a change to openstack/ironic failed: Apply force_persistent_boot_device to all boot interfaces  https://review.opendev.org/c/openstack/ironic/+/77338218:30
*** sshnaidm|ruck is now known as sshnaidm|afk18:34
*** dtantsur is now known as dtantsur|afk18:35
dtantsur|afko/18:35
rpittaugood night! o/18:39
*** rpittau is now known as rpittau|afk18:39
*** moshiur has quit IRC19:30
*** dsneddon has joined #openstack-ironic19:56
*** rcernin has joined #openstack-ironic20:00
iurygregoryajya, hey you around?20:01
*** rcernin has quit IRC20:04
iurygregorythe problem with eHTML5 http://paste.openstack.org/show/802256/ looks like this ? =)20:08
*** tosin has quit IRC20:19
*** rcernin has joined #openstack-ironic20:25
*** hoonetorg has quit IRC20:38
*** hoonetorg has joined #openstack-ironic20:51
*** rcernin has quit IRC21:22
*** rcernin has joined #openstack-ironic21:52
*** ociuhandu has joined #openstack-ironic22:01
*** ociuhandu has quit IRC22:05
*** rcernin has quit IRC22:08
*** rcernin has joined #openstack-ironic22:09
TheJuliastevebaker: you around?22:37
stevebakerTheJulia: yep I'm just talking to alexmcleod22:37
TheJuliaSo I'm trying to figure out how to replace the hard coded project name with a project id. Figured out importlib.reload() for testing, but I'm struggling to grok the policy testing you wrote and why its not working so thinking >1 brains may help22:39
*** hoonetorg has quit IRC22:40
stevebakerTheJulia: ok, where should I look to see the problem?22:44
jandersgood morning Ironic o/22:44
TheJuliastevebaker: let me go ahead and upload the stack at this point, one minute22:45
TheJuliastevebaker: git review is thinking22:47
openstackgerritJulia Kreger proposed openstack/ironic master: Implement secure RBAC for volume APIs  https://review.opendev.org/c/openstack/ironic/+/76327322:47
openstackgerritJulia Kreger proposed openstack/ironic master: Implement secure RBAC for conductor APIs  https://review.opendev.org/c/openstack/ironic/+/76327422:47
openstackgerritJulia Kreger proposed openstack/ironic master: Implement secure RBAC for the allocation APIs  https://review.opendev.org/c/openstack/ironic/+/76327522:47
openstackgerritJulia Kreger proposed openstack/ironic master: Implement secure RBAC for the event APIs  https://review.opendev.org/c/openstack/ironic/+/76327622:47
openstackgerritJulia Kreger proposed openstack/ironic master: Implement secure RBAC for the deploy templates APIs  https://review.opendev.org/c/openstack/ironic/+/76327722:47
openstackgerritJulia Kreger proposed openstack/ironic master: WIP: support specific project id for legacy mode  https://review.opendev.org/c/openstack/ironic/+/77243822:47
TheJuliastevebaker: the test on the wip which should be the very last patch is ironic.tests.unit.common.test_policy.PolicyInCodeTestCase.test_creds_1822:47
stevebakerok22:47
TheJuliaI can see the reload works, the rule changes22:49
TheJuliamaybe I'm missing something22:49
stevebakerTheJulia: using importlib sounds scary22:51
TheJuliawell, there is no real way to test this without refactoring the entire policy structure22:52
TheJuliaMaybe we just change it and leave it be?!22:52
TheJuliaand not actually have tests for the conditional22:52
TheJuliaor maybe I'm over thinking it22:52
stevebakerTheJulia: do you get the reload you need by setting policy._ENFORCER to None then calling policy.get_enforcer()?22:54
TheJuliathe lists are created on module load22:54
TheJuliasince it loads default_policy22:55
TheJuliapolicy.default_policy22:55
*** uzumaki has quit IRC22:58
stevebakerTheJulia: yeah I see. I guess the only alternative would be to wrap those lists in a function, but that seems a lot just for testing22:58
TheJuliayeah22:59
TheJuliait is a conundrum22:59
*** anuradha1904 has quit IRC23:01
stevebakerTheJulia: are policy.RuleDefault objects mutable? If so you could change it in list_policies based on conf, then to the _ENFORCER = None thing from the test23:03
TheJuliaI don't know, not sure it would be right for it to be mutable in the grand scheme of things23:04
TheJuliasecurity wise23:04
stevebakerheh23:04
TheJulialbragstad: oh lance!23:05
stevebakeror you could find it in the list and replace it with a new one23:05
lbragstad?23:05
lbragstadi believe that are mutable23:06
lbragstadat least i'm not aware of any code in oslo.policy that prevents it (for better or worse)23:06
TheJuliahmm23:07
TheJuliaI guess that could work. and just have a unit test to make sure the startup code on module load behaves as expected23:08
*** JayF has quit IRC23:13
*** k_mouza has joined #openstack-ironic23:16
*** JayF has joined #openstack-ironic23:17
*** k_mouza has quit IRC23:20
openstackgerritJacob Anders proposed openstack/ironic master: Add support for using NVMe specific cleaning  https://review.opendev.org/c/openstack/ironic/+/77190523:40
openstackgerritJacob Anders proposed openstack/ironic-python-agent-builder master: Add nvme-cli package to IPA image  https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/77353823:50

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!