Monday, 2021-01-25

*** rajinir has quit IRC00:16
*** arne_wiebalck has quit IRC00:17
*** nandita has quit IRC00:18
*** arne_wiebalck has joined #openstack-ironic00:18
*** rajinir has joined #openstack-ironic00:18
*** vdrok has quit IRC00:18
*** nandita has joined #openstack-ironic00:19
*** vdrok has joined #openstack-ironic00:19
*** k_mouza has joined #openstack-ironic00:37
*** k_mouza has quit IRC00:42
openstackgerritBob Fournier proposed openstack/ironic master: [WIP] For Supermicro BMCs, set the BootSourceOverrideEnable value when changing boot device  https://review.opendev.org/c/openstack/ironic/+/77223901:05
*** xinliang has joined #openstack-ironic01:50
*** rcernin has quit IRC02:22
*** zzzeek has quit IRC02:28
*** zzzeek has joined #openstack-ironic02:30
*** rcernin has joined #openstack-ironic02:48
*** mkrai has joined #openstack-ironic02:55
*** xinliang has quit IRC03:49
*** rnoriega has quit IRC03:58
*** rnoriega has joined #openstack-ironic04:01
*** mkrai has quit IRC04:49
*** mkrai_ has joined #openstack-ironic04:49
openstackgerritArun S A G proposed openstack/ironic master: Add kickstart configuration and template  https://review.opendev.org/c/openstack/ironic/+/77216605:04
*** rcernin has quit IRC05:08
*** rcernin has joined #openstack-ironic05:18
*** viks____ has joined #openstack-ironic05:30
*** ociuhandu has joined #openstack-ironic06:06
*** ociuhandu has quit IRC06:10
*** k_mouza has joined #openstack-ironic06:16
*** k_mouza has quit IRC06:20
*** k_mouza has joined #openstack-ironic06:25
*** k_mouza has quit IRC06:29
*** nandita has quit IRC06:36
*** mkrai_ has quit IRC06:51
*** ociuhandu has joined #openstack-ironic07:03
*** moshiur has joined #openstack-ironic07:05
*** Qianbiao has joined #openstack-ironic07:06
*** ociuhandu has quit IRC07:07
*** mkrai has joined #openstack-ironic07:14
*** ociuhandu has joined #openstack-ironic07:24
*** ociuhandu has quit IRC07:24
*** ociuhandu has joined #openstack-ironic07:25
*** ociuhandu has quit IRC07:30
arne_wiebalck Good morning, ironic!07:38
*** ociuhandu has joined #openstack-ironic07:42
*** ociuhandu has quit IRC07:42
*** ociuhandu has joined #openstack-ironic07:44
*** rcernin has quit IRC07:48
*** ociuhandu has quit IRC07:49
*** ociuhandu has joined #openstack-ironic07:52
*** ociuhandu has quit IRC07:58
*** k_mouza has joined #openstack-ironic07:59
*** k_mouza has quit IRC08:03
*** tosin has joined #openstack-ironic08:06
*** ociuhandu has joined #openstack-ironic08:11
*** rpittau|afk is now known as rpittau08:35
rpittaugood morning ironic! o/08:35
*** ociuhandu has quit IRC08:36
*** ociuhandu has joined #openstack-ironic08:36
*** ociuhandu has quit IRC08:36
*** ociuhandu has joined #openstack-ironic08:38
*** ociuhandu has quit IRC08:42
*** mkrai has quit IRC08:45
*** lucasagomes has joined #openstack-ironic08:56
*** rcernin has joined #openstack-ironic09:04
*** ociuhandu has joined #openstack-ironic09:15
openstackgerritRiccardo Pittau proposed openstack/sushy-tools master: Move some test requirements to tox.ini  https://review.opendev.org/c/openstack/sushy-tools/+/77194509:16
openstackgerritRiccardo Pittau proposed openstack/ironic-prometheus-exporter master: Reconfigure tox.ini  https://review.opendev.org/c/openstack/ironic-prometheus-exporter/+/77216109:18
openstackgerritRiccardo Pittau proposed openstack/ironic-tempest-plugin master: Reconfigure tox.ini  https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/77216209:19
*** alexmcleod has joined #openstack-ironic09:23
*** tosky has joined #openstack-ironic09:23
*** rcernin has quit IRC09:41
*** derekh has joined #openstack-ironic09:45
*** mkrai has joined #openstack-ironic09:46
*** k_mouza has joined #openstack-ironic09:58
*** rcernin has joined #openstack-ironic09:59
*** rcernin has quit IRC10:14
iurygregorygood morning arne_wiebalck rpittau and Ironic o/10:36
rpittauhey iurygregory :)10:39
*** sshnaidm is now known as sshnaidm|ruck10:39
*** rcernin has joined #openstack-ironic10:45
arne_wiebalckhey iurygregory o/10:51
*** dougsz has joined #openstack-ironic10:52
*** dougsz has quit IRC10:53
*** dougsz has joined #openstack-ironic10:53
*** dtantsur|afk is now known as dtantsur11:11
* dtantsur rubs his eyes11:11
iurygregoryhehehe11:14
*** Qianbiao has quit IRC11:27
*** Qianbiao has joined #openstack-ironic11:42
*** mkrai has quit IRC11:56
*** rcernin has quit IRC11:58
*** ianychoi__ has joined #openstack-ironic12:16
*** gudrutis has quit IRC12:17
*** gudrutis has joined #openstack-ironic12:18
*** ianychoi_ has quit IRC12:19
*** early has quit IRC12:19
*** early has joined #openstack-ironic12:20
*** ociuhandu has quit IRC12:48
*** nam-est has joined #openstack-ironic12:50
*** ociuhandu has joined #openstack-ironic12:52
*** ociuhandu has quit IRC12:53
nam-estHi all,12:53
nam-estPlease give some reviews to these PRs12:53
nam-esthttps://github.com/metal3-io/ironic-image/pull/23012:53
nam-esthttps://github.com/metal3-io/ironic-inspector-image/pull/7012:53
nam-estAll comments have been addressed, and also the PRs have passed the CI. Thank you.12:53
*** ociuhandu has joined #openstack-ironic12:53
*** ociuhandu has quit IRC12:58
tosinHi Ironic! I keep getting this error and I'm not sure what it means:13:00
tosinInsecureRequestWarning: Unverified HTTPS request is being made. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.io/en/latest/advanced-usage.html#ssl-warnings13:00
*** Qianbiao has quit IRC13:01
*** anuradha1904 has joined #openstack-ironic13:05
iurygregorytosin, what command gave you this error?13:07
openstackgerritsonali bhausaheb borkar proposed x/sushy-oem-idrac master: Add get pxe port macs for bios mode  https://review.opendev.org/c/x/sushy-oem-idrac/+/77090413:07
tosiniurygregory: I pushed a change and got that report from Zuul13:10
tosinHere's the patch https://review.opendev.org/c/openstack/ansible-collections-openstack/+/770845/6/plugins/modules/baremetal_node_action.py13:10
tosinHere's the full log13:12
tosinhttps://zuul.opendev.org/t/openstack/build/4c28582c648d44c8a3b09fd46ccd523313:12
iurygregorytosin, looking now13:13
tosinthank you13:13
iurygregoryI have the feeling it was a temporary problem in the CI jobs13:15
iurygregoryI will put a recheck13:15
tosinoh ok13:17
*** rh-jelabarre has joined #openstack-ironic13:19
iurygregorylet's see how it goes =)13:19
tosin=)13:21
*** ociuhandu has joined #openstack-ironic13:28
*** jamesdenton has joined #openstack-ironic13:33
*** moshiur has quit IRC13:34
*** ociuhandu has quit IRC13:35
*** moshiur has joined #openstack-ironic13:35
dtantsurnam-est: at least one comment is still outstanding on the ironic-image patch (and I've added one more)13:42
*** Qianbiao has joined #openstack-ironic13:42
iurygregorytosin, you need to run the ansible linters locally to find the real problem tox -e linters-2.9 and tox -e linters13:43
tosinok i'll try this13:45
iurygregorydtantsur, please correct if I'm wrong since I never used ansible-collections hehe ^13:45
*** paras333 has joined #openstack-ironic13:55
*** iurygregory_ has joined #openstack-ironic13:59
*** ociuhandu has joined #openstack-ironic14:00
*** iurygregory has quit IRC14:00
*** iurygregory_ is now known as iurygregory14:00
TheJuliagood morning everyone14:06
*** rloo has joined #openstack-ironic14:10
iurygregorygood morning TheJulia =)14:11
nam-estdtantsur: Oh, sorry I missed that. I will have a fix soon. Thanks for your comments and also for your approval in ironic-inspector-image repo.14:11
*** lbragstad has joined #openstack-ironic14:18
*** ociuhandu has quit IRC14:28
*** ociuhandu has joined #openstack-ironic14:29
dtantsurnam-est: please also see the email I've just sent to metal3-dev re potentially merging ironic-inspector and ironic image repos14:32
*** lbragstad has quit IRC14:34
TheJuliaDoes anyone have any review candidates to propose for the week? https://etherpad.opendev.org/p/IronicWhiteBoard line 19614:35
dtantsurI definitely do, will add in a few14:36
TheJuliaok14:36
*** lbragstad has joined #openstack-ironic14:37
*** tzumainn has joined #openstack-ironic14:37
dtantsurspeaking of which, looking for a 2nd +2 on https://review.opendev.org/c/openstack/ironic/+/77198914:38
iurygregorydtantsur, looking now14:42
TheJuliaJust added a +2 from myself14:45
*** mkrai has joined #openstack-ironic14:52
TheJuliaIronic has been holding meetings for approaching *8* years.... *brainexplodes*14:56
*** MentalSiege has joined #openstack-ironic14:56
dtantsur\o/14:56
TheJuliaMay 3rd, 2013 is when the meetings started14:56
*** kaifeng has joined #openstack-ironic14:57
dtantsurand I'll celebrate 7 years around OpenStack next week14:57
TheJulia\o/14:57
TheJulia#startmeeting ironic15:00
TheJuliao/15:00
openstackMeeting started Mon Jan 25 15:00:08 2021 UTC and is due to finish in 60 minutes.  The chair is TheJulia. Information about MeetBot at http://wiki.debian.org/MeetBot.15:00
openstackUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.15:00
*** openstack changes topic to " (Meeting topic: ironic)"15:00
openstackThe meeting name has been set to 'ironic'15:00
dtantsuro/15:00
rpittauo/15:00
rpioso\o15:00
kaifengo/15:00
Qianbiaoo/15:00
ajyao/15:00
bdoddo/15:00
TheJuliaGood morning everyone, our weekly meeting agenda is on the wiki at https://wiki.openstack.org/wiki/Meetings/Ironic#Agenda_for_next_meeting15:00
TheJuliaI'm hoping our meeting today goes quickly since today is the first of three scheduled "Mid-Cycle" calls15:01
TheJuliaAs well.15:01
TheJulia#topic Announcements / Reminders15:01
*** openstack changes topic to "Announcements / Reminders (Meeting topic: ironic)"15:01
TheJulia#Info Midcycle the next three days15:01
TheJulia#link https://etherpad.opendev.org/p/ironic-wallaby-midcycle15:01
*** stendulker has joined #openstack-ironic15:01
TheJuliaThe first call starts in about two hours. All are welcome to bring topics as long as we respect people's time.15:01
iurygregoryo/15:02
stendulkero/15:02
TheJulia#info this week is R-11 in the OpenStack Wallaby release schedule. R-6 is non-client library freeze. R-5 is client library and requirements freeze.15:02
dtantsurhow long till the next releases? 2 weeks?15:03
TheJulia#info The Ironic team's second sprint is scheduled to end February 8th with our second release of the development cycle.15:03
TheJuliawell, week of February 8th, since CI15:03
TheJuliaDoes anyone have anything they would like to announce or remind us of this week?15:03
TheJuliaI have one item, I have some electrical work being done on my home this week. I'm supposed to get a heads up when they will cut power but I guess we all know how these sorts of things go.15:04
iurygregorygood luck =)15:04
dtantsurheh15:05
TheJuliaThanks15:05
TheJuliaNo announcements or reminders?15:05
rlooo/15:05
TheJuliadtantsur: should I remind myself to announce you've been in the community for 7 years week?15:05
dtantsurwhy not :)15:06
TheJulia\o/15:06
TheJuliaWill do15:06
TheJuliaAnyway, we have no noted action items from last week. I guess we shall proceed on subteam status reports.15:06
TheJulia#topic Review subteam status reports15:06
*** openstack changes topic to "Review subteam status reports (Meeting topic: ironic)"15:06
TheJulia#link https://etherpad.openstack.org/p/IronicWhiteBoard15:06
*** lmcgann has joined #openstack-ironic15:07
TheJuliaStarting at line 266 of that etehrpad15:07
TheJuliaEtherpad15:07
TheJulia\o/ looks like we can review redfish raid15:07
dtantsuryeah, this is great news15:08
bdodd\o/15:09
* iurygregory brb - I've updated status for privsep15:10
dtantsurbdodd: the patch doesn't change the sushy requirement, is it correct?15:10
TheJuliaiurygregory: thanks15:10
*** MentalSiege has quit IRC15:10
bdodddtantsur Actually, it does require a very recent sushy change.15:11
* dtantsur reminds himself to remind everyone about FOSDEM next time15:11
TheJuliaI've updated the community goal json to yaml notes, also added a note to try and delineate it from RBAC which is related, but a whole larger thing. The policy json to yaml is literally one patch for ironic, and one patch for ironic-inspector.15:11
dtantsurbdodd: than please update requirements.txt15:11
TheJulia++15:12
TheJuliaajya: Looks like you've been busy on configuration molds. Can you get together a single list of patches needing to be reviewed since it looks like your touching multiple repositories.15:13
ajyaTheJulia: will post a link15:13
bdodddtantsur Is there a new sushy release version that includes https://review.opendev.org/c/openstack/sushy/+/758874 ? I haven't been able to tell.15:13
dtantsurbdodd: yes, 3.6.015:13
dtantsurreleased last week15:13
ajyaTheJulia: posted in WB15:13
bdoddGreat, thanks! I'll update requirements.txt15:14
dtantsurthx15:14
TheJuliaajya: Thanks15:14
*** sdanni has joined #openstack-ironic15:14
TheJuliaLooks like Arun also posted an anaconda patch over the weekend15:14
TheJulia\o/15:14
dtantsurmuch progress. wow!15:15
TheJuliakaifeng: still working on snapshot support?15:15
* dtantsur has a feeling that node history is something metal3 could benefit from15:15
TheJulia++15:15
kaifengno op on the snapshot,  but squeezing sometime for the node history :)15:16
TheJuliasounds good to me :)15:16
TheJuliaLooks like the security interface needs reviews as well.15:17
arne_wiebalcko/15:18
TheJuliaEveryone good to proceed to priorities for the week?15:18
dtantsuryeah15:18
TheJulia#topic Deciding on priorities for the coming week15:19
*** openstack changes topic to "Deciding on priorities for the coming week (Meeting topic: ironic)"15:19
TheJulia#link https://etherpad.opendev.org/p/IronicWhiteBoard15:19
TheJuliaStarting at line 12815:19
* TheJulia removes merged items15:19
TheJuliaI'm going to drop the minor ironic-lib improvement I've been pondering15:21
TheJuliaNo time right now to update it15:21
TheJuliaJust a couple items to add it looks like15:22
TheJuliaSounds good to me, any objections?15:23
arne_wiebalckshall I add the GPT tiny partitions issue to ironic-lib?15:23
TheJuliaarne_wiebalck: oh yes, please15:23
arne_wiebalckI need to add some tests first15:23
arne_wiebalckTheJulia: ok15:23
*** ociuhandu has quit IRC15:23
*** Qianbiao has quit IRC15:23
TheJuliaLine 174/17515:25
TheJuliaThat has been hanging out for a while and it seems like it is getting zero traction to the question15:25
* TheJulia hears crickets15:27
TheJuliaarne_wiebalck: anything for the baremetal sig this week??15:27
TheJuliaOtherwise I think Open Discussion is next15:27
arne_wiebalckTheJulia: nothing for the SIG15:28
TheJulia#topic Open Discussion15:28
*** openstack changes topic to "Open Discussion (Meeting topic: ironic)"15:28
TheJuliaWell, I hope everyone had a wonderful weekend, but that can also be a topic of discussion during the midcycle call for those who plan on attending15:29
rloocrickets until midcycle...15:30
TheJuliaI guess so....15:31
TheJuliaWell, Thanks everyone!15:31
arne_wiebalckTheJulia: Thanks!15:31
TheJuliaTalk to you all soon15:31
TheJulia#endmeeting15:31
*** openstack changes topic to "Bare Metal Provisioning | Status: http://bit.ly/ironic-whiteboard | Docs: http://docs.openstack.org/ironic/ | Bugs: https://storyboard.openstack.org/#!/project_group/75 | Contributors are generally present between 6 AM and 12 AM UTC, If we do not answer, please feel free to pose questions to openstack-discuss mailing list."15:31
openstackMeeting ended Mon Jan 25 15:31:32 2021 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)15:31
openstackMinutes:        http://eavesdrop.openstack.org/meetings/ironic/2021/ironic.2021-01-25-15.00.html15:31
openstackMinutes (text): http://eavesdrop.openstack.org/meetings/ironic/2021/ironic.2021-01-25-15.00.txt15:31
openstackLog:            http://eavesdrop.openstack.org/meetings/ironic/2021/ironic.2021-01-25-15.00.log.html15:31
*** mkrai has quit IRC15:36
*** ociuhandu has joined #openstack-ironic15:36
openstackgerritMerged openstack/networking-baremetal master: Add doc/requirements  https://review.opendev.org/c/openstack/networking-baremetal/+/76917215:41
nam-estdtansur: Yes, I have got your email. I am discussing it with other people in EST team and we will share our thoughts soon in the mailing list or in the next community meeting.16:01
*** jamesdenton has quit IRC16:03
*** jamesdenton has joined #openstack-ironic16:03
*** moshiur has quit IRC16:11
*** stendulker has quit IRC16:18
dtantsurTheJulia: FYI I've split the event framework into a non-proxying part https://storyboard.openstack.org/#!/story/2008366 and a proxy part https://storyboard.openstack.org/#!/story/200855516:44
dtantsurthe former is something we need for metal3, the latter is cool to have for ironic, but I don't know if any of us will ever have time for it16:44
dtantsur(I've removed needs-spec for a new discussion)16:45
openstackgerritDmitry Tantsur proposed openstack/ironic master: Add centralized secure boot documentation  https://review.opendev.org/c/openstack/ironic/+/77237616:49
openstackgerritDmitry Tantsur proposed openstack/ironic master: [WIP] Redfish secure boot  https://review.opendev.org/c/openstack/ironic/+/77149316:50
openstackgerritRiccardo Pittau proposed openstack/sushy stable/victoria: Raise exception when async operation fails  https://review.opendev.org/c/openstack/sushy/+/77239716:50
*** ociuhandu_ has joined #openstack-ironic16:51
*** ociuhandu has quit IRC16:55
*** ociuhandu_ has quit IRC16:56
*** ociuhandu has joined #openstack-ironic17:10
*** ociuhandu has quit IRC17:15
*** lucasagomes has quit IRC17:17
openstackgerritVerification of a change to openstack/ironic failed: redfish-virtual-media: allow a link to raw configdrive image  https://review.opendev.org/c/openstack/ironic/+/77198917:20
*** dougsz has quit IRC17:22
openstackgerritBill Dodd proposed openstack/ironic master: Add Redfish RAID management to Ironic  https://review.opendev.org/c/openstack/ironic/+/73000017:33
*** MentalSiege has joined #openstack-ironic17:43
*** kaifeng has quit IRC17:46
*** jdandrea has quit IRC17:52
*** jdandrea has joined #openstack-ironic17:54
TheJuliadtantsur: ack, thanks17:56
TheJuliadtantsur: bringing up on meeting next week?17:56
dtantsuryeah17:57
TheJuliasounds good17:57
dtantsurrloo: recollected the context and posting a comment on the deploy-failed-to-active spec17:57
rloothx dtantsur, will look ... after lunch :)17:58
dtantsurenjoy!17:58
*** derekh has quit IRC17:59
openstackgerritArne Wiebalck proposed openstack/ironic-lib master: Handle EBRs and tiny partitions when removing metadata  https://review.opendev.org/c/openstack/ironic-lib/+/77178818:00
* TheJulia looks at her empty coffee mug and thinks it is time for a refill18:01
arne_wiebalckbye everyone o/18:03
rpittaugood night! o/18:10
*** rpittau is now known as rpittau|afk18:10
iurygregoryany core has some time to give a second +2 in https://review.opendev.org/c/openstack/sushy/+/772397 ? =D18:12
*** rnoriega has quit IRC18:19
dtantsurdone18:20
dtantsurI guess we need a release after it merges18:20
*** nam-est has quit IRC18:20
*** rnoriega has joined #openstack-ironic18:21
*** gyee has joined #openstack-ironic18:21
iurygregorydtantsur, yeah I will push one for victoria18:23
*** dsneddon has joined #openstack-ironic18:40
*** irclogbot_1 has quit IRC18:46
*** mgoddard has quit IRC18:48
*** irclogbot_2 has joined #openstack-ironic18:49
*** dtantsur is now known as dtantsur|afk18:50
dtantsur|afko/18:50
*** mgoddard has joined #openstack-ironic18:50
openstackgerritVerification of a change to openstack/ironic failed: redfish-virtual-media: allow a link to raw configdrive image  https://review.opendev.org/c/openstack/ironic/+/77198918:53
*** mgoddard has quit IRC18:58
stevebakermorning19:24
TheJuliaGood morning19:25
openstackgerritMerged openstack/sushy stable/victoria: Raise exception when async operation fails  https://review.opendev.org/c/openstack/sushy/+/77239719:25
iurygregorydo we also want to update ACL for tenks? just wondering19:33
*** mgoddard has joined #openstack-ironic19:35
TheJuliamgoddard: should iury also update the acl for tenks?19:36
iurygregorylol mgoddard appeared after my message hehe19:40
iurygregory*magic*19:40
TheJuliaIt is magic! The magic of IRC!19:42
TheJuliaQueue mystical music19:42
openstackgerritMerged openstack/virtualbmc master: Update minversion of tox  https://review.opendev.org/c/openstack/virtualbmc/+/77195519:43
iurygregoryyeah19:43
*** k_mouza has quit IRC19:55
iurygregoryTheJulia, fyi https://review.opendev.org/c/openstack/project-config/+/772427 let's see what zuul will say20:00
TheJuliaiurygregory: ack20:03
* TheJulia comes to the realization that there is no "clean/easy" way to test major default policy changes20:04
stevebakerhmm20:22
*** anuradha1904 has quit IRC20:25
TheJuliastevebaker: I'm going to upload a wip, and I think you'll get the idea of what I'm trying to do. Bottom line is we create lists upon first interpretation of policy.py20:27
TheJuliabecause they are constants which can be overridden by config20:27
openstackgerritJulia Kreger proposed openstack/ironic master: WIP: support specific project id for legacy mode  https://review.opendev.org/c/openstack/ironic/+/77243820:54
* TheJulia now tries to remember all of the fun test names she was thinking of at 5 AM on saturday morning20:59
*** ociuhandu has joined #openstack-ironic21:20
openstackgerritMerged openstack/ironic master: redfish-virtual-media: allow a link to raw configdrive image  https://review.opendev.org/c/openstack/ironic/+/77198921:22
*** tosky has quit IRC21:35
*** tosky has joined #openstack-ironic21:36
*** TheJulia has quit IRC21:36
*** tosin has quit IRC21:37
*** TheJulia has joined #openstack-ironic21:37
*** rpittau|afk has quit IRC21:37
*** johnsom has quit IRC21:37
*** rpittau|afk_ has joined #openstack-ironic21:37
*** buhman has quit IRC21:37
*** johnsom has joined #openstack-ironic21:37
*** buhman_ has joined #openstack-ironic21:37
*** NobodyCam_ has joined #openstack-ironic21:38
*** vdrok has quit IRC21:38
*** NobodyCam has quit IRC21:38
*** NobodyCam_ is now known as NobodyCam21:38
*** viks____ has quit IRC21:38
*** tosin has joined #openstack-ironic21:38
*** k_mouza has joined #openstack-ironic21:39
*** vdrok has joined #openstack-ironic21:40
*** k_mouza has quit IRC21:44
*** rh-jelabarre has quit IRC22:08
TheJuliastevebaker: so for project, do you think it would be fine to skip some of the redundant checks. say admin's can read a node when the permission is the reader? Trying to think of ways to model it mentally to keep things from getting too out of hand22:17
stevebakerTheJulia: for a start how about skipping endpoints which share the same policy rule?22:18
*** rcernin has joined #openstack-ironic22:18
TheJuliaI was kind of thinking the same, where instead we change the data being tested, headers translating through properly, etc22:18
TheJulialet me paste an example of the direction I'm heading22:19
stevebakeras long as there is one allow and one deny test for each endpoint, the rest of the tests can be targetting the policy itself on a single endpoint22:19
TheJuliastevebaker: http://paste.openstack.org/show/B3kDotPNGJDyALQkmP9Y/22:20
stevebakerTheJulia: then for policies which are allowed for readers, do we really need to test against member and admin? How about just a test with a reader and a no-roles? We have a commitment from keystone that users with admin or member role will explicitly have the reader role too22:23
TheJuliaI was kind of thinking in that same vain22:24
stevebakerthose 2 approaches might save a few hundred tests :)22:25
TheJuliayeah, I'm basically thinking that, but we also need to test things like "oh, well they are just going to get no data back" or whatever22:25
TheJulia"third party"22:26
TheJuliamy third party admin is a admin,member,reader :)22:27
stevebakerthey are third party because its in a different project?22:28
TheJuliaexactly22:31
TheJulialbragstad: does it make sense to create some randomly named freeform role and just hit endpoints with it?22:31
lbragstadjust to make sure the policy is loading the roles we expect?22:32
TheJuliaYeah, I guess22:32
lbragstadyou could - i don't think we take that approach in keystone (not implying you need to follow what we do)22:32
TheJuliaI guess I'm more wondering if there is a larger scope of concern, but I guess not.22:33
lbragstadi think it would just test that nothing in ironic's middleware, api, or policy enforcement is overloading roles with something else22:33
TheJuliaI can't think of anything in there, so I guess that is just a mater of over thinking it22:34
*** ociuhandu has quit IRC22:34
*** jdandrea has quit IRC22:34
*** ociuhandu has joined #openstack-ironic22:35
lbragstadi can see it if you wanted to test policy overrides, in which case you'd need to add a new role (call it foo) and then muck with the policy to make sure you override it so that foo works22:35
*** lmcgann has quit IRC22:35
lbragstadbut that may be out of scope for this (technically that should already work)22:36
stevebakerTheJulia: just a handful of third-party-denied tests should be enough IMO22:36
TheJulialbragstad: ack22:37
TheJuliastevebaker: agreed, additionally many of the endpoints will remain system scoped... possibly forever22:37
TheJuliasince they don't *need* to be exposed as they are purely admin only22:38
stevebakeryep22:38
* TheJulia receives the explicit "it is cold outside, make something warm for dinner" request.22:38
*** ociuhandu has quit IRC22:39
TheJuliait is like 40F out and one of the two nearby mountains is masked by rain/snow22:40
*** tosin has quit IRC22:43
*** ociuhandu has joined #openstack-ironic22:44
*** ociuhandu has quit IRC22:48
*** ociuhandu has joined #openstack-ironic22:48
TheJuliaField patching wise, we're likely going to need to expand upon such testing :\22:50
*** ociuhandu has quit IRC22:53
*** uzumaki has joined #openstack-ironic22:53
openstackgerritJulia Kreger proposed openstack/ironic master: RBAC System Scope: observer -> reader  https://review.opendev.org/c/openstack/ironic/+/77245022:56
openstackgerritJulia Kreger proposed openstack/ironic master: WIP: Project scoped tests  https://review.opendev.org/c/openstack/ironic/+/77245122:56
TheJuliastevebaker: it is a start ^ :)22:57
lbragstad\o/22:58
TheJulialbragstad: well, there is a lot from the system scope tests in that file22:59
TheJuliaand it is not actually tested... and there are just notes of "hey, we should test this"22:59
openstackgerritJulia Kreger proposed openstack/ironic master: WIP: Project scoped tests  https://review.opendev.org/c/openstack/ironic/+/77245123:11
TheJuliaa little more in the way of notes. I'm going to go start dinner, brain demanding it.23:12
TheJuliaAlso, I'm going to have to run down that entire list with the spec in front of me tomorrow23:13
stevebakerTheJulia: thanks, I'll take a look23:30
*** jdandrea has joined #openstack-ironic23:35
* TheJulia goes and exercises23:37
*** jdandrea has quit IRC23:39
*** rcernin has quit IRC23:40
*** tosky has quit IRC23:47
*** k_mouza has joined #openstack-ironic23:56

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!