| *** Goneri has quit IRC | 00:09 | |
| *** Goneri has joined #openstack-ironic | 00:15 | |
| *** Goneri has quit IRC | 00:29 | |
| *** yolanda has quit IRC | 00:38 | |
| *** yolanda has joined #openstack-ironic | 00:39 | |
| openstackgerrit | Xuan Yandong proposed openstack/networking-baremetal master: Remove Six https://review.opendev.org/755148 | 00:54 |
|---|---|---|
| *** gyee has quit IRC | 01:08 | |
| *** damiandabrowski has quit IRC | 01:23 | |
| openstackgerrit | Merged openstack/ironic master: Fix a race condition in the hash ring code https://review.opendev.org/754362 | 01:33 |
| *** QianbiaoNG has joined #openstack-ironic | 01:38 | |
| *** yolanda has quit IRC | 02:06 | |
| *** zzzeek has quit IRC | 02:07 | |
| *** zzzeek has joined #openstack-ironic | 02:10 | |
| *** yolanda has joined #openstack-ironic | 02:13 | |
| *** arne_wiebalck has quit IRC | 02:14 | |
| *** rajinir has quit IRC | 02:14 | |
| *** vkmc has quit IRC | 02:14 | |
| *** phrobb has quit IRC | 02:14 | |
| *** dking has quit IRC | 02:14 | |
| *** tkajinam has quit IRC | 02:14 | |
| *** tkajinam_ has joined #openstack-ironic | 02:15 | |
| *** vkmc has joined #openstack-ironic | 02:15 | |
| *** phrobb has joined #openstack-ironic | 02:15 | |
| *** arne_wiebalck has joined #openstack-ironic | 02:15 | |
| *** QianbiaoNG has quit IRC | 02:18 | |
| *** rajinir has joined #openstack-ironic | 02:20 | |
| *** dking has joined #openstack-ironic | 02:20 | |
| *** QianbiaoNG has joined #openstack-ironic | 02:31 | |
| *** prometheanfire has left #openstack-ironic | 02:34 | |
| *** rcernin has quit IRC | 02:55 | |
| *** rcernin_ has joined #openstack-ironic | 02:56 | |
| openstackgerrit | Steve Baker proposed openstack/ironic master: Utility functions for REST API JSON handling https://review.opendev.org/751160 | 03:00 |
| openstackgerrit | Steve Baker proposed openstack/ironic master: Convert allocations endpoint to plain JSON https://review.opendev.org/743679 | 03:00 |
| openstackgerrit | Steve Baker proposed openstack/ironic master: Convert bios endpoint to plain JSON https://review.opendev.org/745475 | 03:00 |
| openstackgerrit | Steve Baker proposed openstack/ironic master: Convert chassis endpoint to plain JSON https://review.opendev.org/745476 | 03:00 |
| openstackgerrit | Steve Baker proposed openstack/ironic master: Convert conductors endpoint to plain JSON https://review.opendev.org/745779 | 03:00 |
| openstackgerrit | Steve Baker proposed openstack/ironic master: Convert deploy_templates endpoint to plain JSON https://review.opendev.org/745780 | 03:00 |
| openstackgerrit | Steve Baker proposed openstack/ironic master: Convert drivers endpoint to plain JSON https://review.opendev.org/741865 | 03:00 |
| openstackgerrit | Steve Baker proposed openstack/ironic master: Convert event endpoint to plain JSON https://review.opendev.org/746623 | 03:00 |
| openstackgerrit | Steve Baker proposed openstack/ironic master: Convert nodes endpoint to plain JSON https://review.opendev.org/747820 | 03:00 |
| openstackgerrit | Steve Baker proposed openstack/ironic master: Convert ports endpoint to plain JSON https://review.opendev.org/750120 | 03:00 |
| openstackgerrit | Steve Baker proposed openstack/ironic master: Convert portgroups endpoint to plain JSON https://review.opendev.org/750864 | 03:00 |
| openstackgerrit | Steve Baker proposed openstack/ironic master: Convert ramdisk endpoint to plain JSON https://review.opendev.org/750857 | 03:00 |
| openstackgerrit | Steve Baker proposed openstack/ironic master: Convert volume endpoint to plain JSON https://review.opendev.org/750858 | 03:00 |
| openstackgerrit | Steve Baker proposed openstack/ironic master: Convert volume/connectors endpoint to plain JSON https://review.opendev.org/750859 | 03:01 |
| openstackgerrit | Steve Baker proposed openstack/ironic master: Convert volume/targets endpoint to plain JSON https://review.opendev.org/750860 | 03:01 |
| openstackgerrit | Steve Baker proposed openstack/ironic master: Expunge the internal version of WSME https://review.opendev.org/750861 | 03:01 |
| *** rh-jelabarre has quit IRC | 04:10 | |
| *** Lucas_Gray has joined #openstack-ironic | 04:31 | |
| *** abdysn has joined #openstack-ironic | 05:22 | |
| *** Lucas_Gray has quit IRC | 05:32 | |
| *** Lucas_Gray has joined #openstack-ironic | 05:38 | |
| *** jtomasek has joined #openstack-ironic | 05:57 | |
| *** yolanda has quit IRC | 06:10 | |
| *** tzumainn has quit IRC | 06:19 | |
| *** portdirect has quit IRC | 06:20 | |
| *** portdirect has joined #openstack-ironic | 06:20 | |
| openstackgerrit | Ankit Kumar proposed openstack/ironic master: Adds config parameter kernel_append_param for iLO https://review.opendev.org/755189 | 06:34 |
| arne_wiebalck | Good morning, ironic! | 06:38 |
| ftarasenko | Gm, Ironic! dtantsur: https://review.opendev.org/754362 worked for me in Train. | 06:51 |
| patchbot | patch 754362 - ironic - Fix a race condition in the hash ring code (MERGED) - 9 patch sets | 06:51 |
| *** yolanda has joined #openstack-ironic | 07:05 | |
| *** rcernin_ has quit IRC | 07:06 | |
| iurygregory | good morning arne_wiebalck ftarasenko and Ironic | 07:17 |
| *** rcernin_ has joined #openstack-ironic | 07:17 | |
| *** rcernin_ has quit IRC | 07:20 | |
| *** rcernin has joined #openstack-ironic | 07:20 | |
| *** jtomasek has quit IRC | 07:30 | |
| *** tosky has joined #openstack-ironic | 07:30 | |
| *** Lucas_Gray has quit IRC | 07:32 | |
| *** jtomasek has joined #openstack-ironic | 07:33 | |
| *** ociuhandu has joined #openstack-ironic | 07:50 | |
| *** ociuhandu has quit IRC | 07:54 | |
| SuiongNg|ITRI_TW | Hi everyone! I recently stumbled upon a problem that prevents me from entering the rescue mode. And I think wiping the agent token on power_on event can solve it. Unfortunately, I'm not familiar with the opendev workflow. I would be happy if anyone could take a look at https://review.opendev.org/754260/ and help me out. | 08:03 |
| patchbot | patch 754260 - ironic - wipe token on power_on event. - 1 patch set | 08:03 |
| *** ociuhandu has joined #openstack-ironic | 08:09 | |
| *** lucasagomes has joined #openstack-ironic | 08:11 | |
| iurygregory | I'm not 100% sure that by only adding POWER_ON it will work, it may work ofc, but I think it should be checked if it's during rescue.... | 08:12 |
| mgoddard | morning. Seeing an odd issue in kayobe CI on our ussuri -> master upgrade job. We register some nodes with the iscsi deploy interface on ussuri, then after upgrade they have switched to direct. A fresh install on master does not see this. default_deploy_interface is iscsi in all cases | 08:13 |
| mgoddard | dtantsur|afk:, maybe you know? ^ | 08:13 |
| SuiongNg|ITRI_TW | iurygregory: thanks. I second your opinion that this needs to be reviewed by someone familiar with the conductor. I'm not sure if this is the best way to fix the problem or it had been fixed recently. I've only tested it against the victoria pre-release version in ubuntu's cloud archive. It works for me but might not be the case for everyone else. | 08:21 |
| iurygregory | yeah, I have the feeling this may shoot us on the foot (in other scenarios) | 08:23 |
| *** k_mouza has joined #openstack-ironic | 08:28 | |
| QianbiaoNG | Hi ironic. | 08:41 |
| iurygregory | hello QianbiaoNG | 08:41 |
| QianbiaoNG | Good morning, iurygregory | 08:42 |
| QianbiaoNG | morning arne_wiebalck o/ | 08:42 |
| arne_wiebalck | Hey iurygregory and QianbiaoNG o/ | 08:44 |
| iurygregory | arne_wiebalck, o/ | 08:44 |
| *** derekh has joined #openstack-ironic | 08:45 | |
| openstackgerrit | Merged openstack/sushy stable/train: Fix #Bios.ResetBios for HTTP 400 Bad request error https://review.opendev.org/754655 | 08:46 |
| openstackgerrit | Merged openstack/sushy stable/victoria: Fix #Bios.ResetBios for HTTP 400 Bad request error https://review.opendev.org/754443 | 08:46 |
| openstackgerrit | Merged openstack/sushy stable/ussuri: Fix #Bios.ResetBios for HTTP 400 Bad request error https://review.opendev.org/754654 | 08:48 |
| *** rcernin has quit IRC | 08:48 | |
| *** abdysn has quit IRC | 08:59 | |
| openstackgerrit | Merged openstack/ironic master: Fix handling OctetString for pysnmp https://review.opendev.org/750401 | 09:06 |
| openstackgerrit | Merged openstack/ironic master: Minor agent version code cleanup https://review.opendev.org/749552 | 09:06 |
| *** derekh has quit IRC | 09:32 | |
| *** derekh has joined #openstack-ironic | 09:33 | |
| *** mraineri has quit IRC | 09:36 | |
| *** Lucas_Gray has joined #openstack-ironic | 10:31 | |
| *** dansmith has quit IRC | 10:53 | |
| *** dansmith has joined #openstack-ironic | 10:55 | |
| *** Lucas_Gray has quit IRC | 11:03 | |
| *** dtantsur|afk is now known as dtantsur | 11:11 | |
| dtantsur | morning ironic | 11:12 |
| dtantsur | ftarasenko: thanks for confirming, I'll backport it | 11:12 |
| dtantsur | mgoddard: yep, there is an upgrade procedure that does precisely that | 11:12 |
| mgoddard | thanks dtantsur, I managed to find it in the commit history eventually. | 11:27 |
| * dtantsur is glad it works, less glad that it breaks people | 11:27 | |
| mgoddard | dtantsur: it's not ideal in the case where the direct interface is enabled but not correctly configured | 11:27 |
| dtantsur | yeah, I tried having some safeguards, but maybe not enough. any suggestions? | 11:28 |
| mgoddard | you could argue our config is wrong, but we generally rely on the default interface | 11:28 |
| dtantsur | mmm, maybe we should just default_deploy_interface!=iscsi.. | 11:29 |
| dtantsur | I usually recommend people avoid default_* options, but I cannot really claim it's wrong | 11:29 |
| mgoddard | that might help | 11:30 |
| mgoddard | at least in this case | 11:30 |
| dtantsur | mgoddard: wanna propose a patch or should I? it may take me a bit of time | 11:35 |
| dtantsur | janders: re whole disk images: you want to chat right now or may I grab a tea first? | 11:37 |
| dtantsur | I know it's a bit late for you | 11:37 |
| * dtantsur declares tea time | 11:39 | |
| janders | dtantsur go ahead and grab your tea :) | 11:39 |
| janders | I will work on this with iurygregory for another 90mins at least | 11:39 |
| janders | we need to get this done | 11:39 |
| iurygregory | IPE is answering \o/ now I just need to enroll the nodes \o/ | 11:40 |
| iurygregory | fingers crossed | 11:40 |
| * janders is looking | 11:40 | |
| * janders is enrolling the first node | 11:41 | |
| janders | lets see if it starts getting power info | 11:41 |
| *** rcernin has joined #openstack-ironic | 11:50 | |
| *** rh-jelabarre has joined #openstack-ironic | 11:51 | |
| dtantsur | it didn't take 90 mins :) | 11:56 |
| janders | so far we figured that janders can't spell "Administartor" | 11:58 |
| janders | good I never pursued career as a Windows guy | 11:58 |
| janders | I can spell root, this is as far as it goes | 11:58 |
| dtantsur | now we know why they picked "root" | 12:05 |
| dtantsur | also yes, administrator is a difficult word to spell | 12:06 |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic stable/ussuri: Fix a race condition in the hash ring code https://review.opendev.org/755267 | 12:07 |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic stable/train: Fix a race condition in the hash ring code https://review.opendev.org/755268 | 12:07 |
| dtantsur | SuiongNg|ITRI_TW: hi, do you have https://review.opendev.org/#/c/744655/ in your environment? | 12:08 |
| patchbot | patch 744655 - ironic - Wipe agent token and URL on rescue and unrescue (MERGED) - 1 patch set | 12:08 |
| dtantsur | iurygregory: if you could spare a minute: https://review.opendev.org/#/c/755001/ | 12:09 |
| patchbot | patch 755001 - ironic - Trivial: fix formatting in the prelude - 1 patch set | 12:09 |
| iurygregory | dtantsur, sure | 12:09 |
| iurygregory | +W | 12:09 |
| dtantsur | https://review.opendev.org/#/c/754884/ is also trivial | 12:09 |
| patchbot | patch 754884 - ironic - Handle patching node /protected value with None - 2 patch sets | 12:09 |
| dtantsur | I guess I should have asked for a unit test.. maybe stevebaker could follow-up with one | 12:10 |
| iurygregory | I was about to say =) | 12:11 |
| iurygregory | I will +W and ask for the test | 12:11 |
| dtantsur | ++ | 12:12 |
| dtantsur | now, https://review.opendev.org/#/c/726483/ would be awesome to have for the release.. but requires A LOT of brainpower | 12:12 |
| patchbot | patch 726483 - ironic - Guard conductor from consuming all of the ram - 17 patch sets | 12:12 |
| dtantsur | arne_wiebalck: I think you've started reviewing ^^ already, do you think you could check it? | 12:12 |
| mgoddard | dtantsur: I can pick it up. Might be tomorrow | 12:12 |
| iurygregory | I think arne_wiebalck was trying to test | 12:12 |
| iurygregory | I would look a bit more, but my brain power today is for trivial things and my demo XD | 12:13 |
| dtantsur | mgoddard: ack | 12:13 |
| arne_wiebalck | dtantsur: my promised review is to test this with real nodes at scale | 12:13 |
| dtantsur | iurygregory: don't worry then. I may ping you for my minor stuff. | 12:13 |
| dtantsur | arne_wiebalck: the thing is, we should cut stable/victoria ASAP. so if doesn't get merged soon, it's pushed to Wallaby | 12:13 |
| arne_wiebalck | dtantsur: still working on this ... | 12:13 |
| arne_wiebalck | dtantsur: yes | 12:14 |
| arne_wiebalck | dtantsur: do you know if others saw this? | 12:14 |
| arne_wiebalck | dtantsur: this is mostly for iscsi deploy (and direct with http download) | 12:14 |
| dtantsur | arne_wiebalck: I gave a +2, there have been a few other reviews previously | 12:15 |
| dtantsur | yes | 12:15 |
| *** rcernin has quit IRC | 12:16 | |
| arne_wiebalck | dtantsur: my point is, would it be a problem to push it? ASAP does not sound like I am going to make it :) | 12:16 |
| arne_wiebalck | dtantsur: or we merge without testing at scale | 12:16 |
| dtantsur | arne_wiebalck: I don't think so. but we need a 2nd review from someone. | 12:16 |
| arne_wiebalck | dtantsur: yes, but only if we want to have it for V | 12:17 |
| arne_wiebalck | dtantsur: what's the timeline | 12:17 |
| dtantsur | ah, that's what you mean. it's not terrible to push it to W, but TheJulia might be upset | 12:17 |
| arne_wiebalck | ? | 12:17 |
| iurygregory | dtantsur, if things go fast I may have more time | 12:17 |
| iurygregory | \o/ | 12:17 |
| *** Goneri has joined #openstack-ironic | 12:17 | |
| iurygregory | 1 node collecting metrics | 12:18 |
| iurygregory | 1 to go | 12:18 |
| iurygregory | and I can record my demo | 12:18 |
| iurygregory | \o/ | 12:18 |
| arne_wiebalck | dtantsur: yes re TheJulia | 12:18 |
| dtantsur | arne_wiebalck: we should have made stable/victoria by last Friday :) | 12:18 |
| arne_wiebalck | dtantsur: oops | 12:18 |
| dtantsur | so ASAP is pretty literally ASAP | 12:18 |
| dtantsur | meanwhile, does anyone have anything for bifrost victoria? if no, does anyone want to propose the final release? | 12:19 |
| arne_wiebalck | dtantsur: ok, no way I can test it (too much downstream in parallel atm), and there is still the issue that 5-10% of the RAIDs are not created properly | 12:19 |
| dtantsur | arne_wiebalck: okay, let's wait for TheJulia to decide if she's comfortable for it to go in without testing | 12:20 |
| arne_wiebalck | dtantsur: so, we will need to decide to merge without testing (from me) | 12:20 |
| arne_wiebalck | dtantsur: ++ | 12:20 |
| dtantsur | moving on, inspector is blocked by https://review.opendev.org/#/c/753435/. it's not trivial, but not overly complex either. any volunteers for a 2nd review? | 12:21 |
| patchbot | patch 753435 - ironic-inspector - pxe filter - option to always block unknown hosts - 6 patch sets | 12:21 |
| arne_wiebalck | dtantsur: I can have a look. | 12:24 |
| dtantsur | thx | 12:24 |
| dtantsur | iurygregory: do you have plans to update https://review.opendev.org/#/c/752042/ today? | 12:36 |
| patchbot | patch 752042 - bifrost - Add ipe installation to bifrost - 7 patch sets | 12:36 |
| iurygregory | if the demo goes well yes | 12:36 |
| iurygregory | =) | 12:36 |
| dtantsur | :) | 12:36 |
| dtantsur | it's the last item before we can release | 12:36 |
| iurygregory | yeah I'm trying to figure out why it fails to download the ipe repo... | 12:36 |
| iurygregory | on centos8 | 12:37 |
| dtantsur | iurygregory: if you have something messed up around source_install, hold on | 12:39 |
| dtantsur | s/if// | 12:39 |
| iurygregory | hummm | 12:39 |
| dtantsur | iurygregory: yep, commented | 12:40 |
| iurygregory | dtantsur, tks | 12:40 |
| janders | dtantsur sorry for the delay, got bogged in all sorts of BMC issues | 12:43 |
| janders | dtantsur on whole-disk-images... | 12:43 |
| janders | 1) do I still need them for true-baremetals? | 12:43 |
| janders | I used to do it this way but maybe it's a 2018 thing... | 12:43 |
| dtantsur | janders: we still support both types of images | 12:44 |
| dtantsur | different operators have completely different feelings about which image type is better | 12:44 |
| janders | what's the easiest way for ironic/standalone in your opinion? | 12:44 |
| dtantsur | janders: whole disk, I would say | 12:44 |
| janders | okay! | 12:44 |
| janders | whats the easiest way to get a wholedisk image? | 12:44 |
| dtantsur | janders: GenericCloud from https://cloud.centos.org/centos/8/x86_64/images/ may just work, to be honest | 12:45 |
| dtantsur | at least CentOS 7 image worked without modifications | 12:45 |
| dtantsur | if you need any customization, diskimage-builder is your friend (hahaha) | 12:45 |
| dtantsur | I mean, it can be terrible at times, but it works | 12:45 |
| dtantsur | bifrost has an ability to build images for you | 12:45 |
| janders | I hope stock images should be enough for what we need | 12:47 |
| janders | what kind of checksum is best? | 12:47 |
| janders | I see CentOS mirrors use sha256 | 12:47 |
| janders | but Ive seen shorter ones in /httpboot | 12:47 |
| dtantsur | we default to md5 | 12:47 |
| janders | ok | 12:47 |
| dtantsur | you can use sha256, but they go into non-default fields | 12:47 |
| dtantsur | hold on, I'll pull the docs | 12:47 |
| dtantsur | janders: https://docs.openstack.org/ironic/latest/install/standalone.html is a bit messy, but it does have the information | 12:48 |
| dtantsur | see https://docs.openstack.org/ironic/latest/install/standalone.html#populating-instance-info | 12:48 |
| *** ricolin_ has joined #openstack-ironic | 12:48 | |
| janders | great, thank you dtantsur | 12:49 |
| *** rloo has joined #openstack-ironic | 12:49 | |
| janders | I will try CentOS8 generic | 12:49 |
| dtantsur | janders: please put any findings to https://docs.openstack.org/ironic/latest/install/creating-images.html if they're not there | 12:50 |
| janders | ah another thing - the kit we are testing on has heaps of disks | 12:51 |
| janders | are root disk hints a thing in standalone? | 12:51 |
| dtantsur | yep | 12:51 |
| dtantsur | work exactly the same. you can put them to properties (permanent) or instance_info (per instance) | 12:51 |
| janders | got it | 12:51 |
| janders | i think I can see it in the same doco page you linked | 12:51 |
| openstackgerrit | Merged openstack/ironic master: Trivial: fix formatting in the prelude https://review.opendev.org/755001 | 12:53 |
| *** derekh has quit IRC | 13:01 | |
| *** derekh has joined #openstack-ironic | 13:03 | |
| openstackgerrit | Verification of a change to openstack/ironic failed: Handle conductor_affinity earlier in the deployment process https://review.opendev.org/754375 | 13:07 |
| * dtantsur rolls eyes | 13:09 | |
| TheJulia | CI hates everyone | 13:09 |
| dtantsur | morning TheJulia, this is true | 13:09 |
| dtantsur | I'm trying to wrap up releases today | 13:09 |
| dtantsur | we're looking good, but all projects have at least one outstanding patch | 13:10 |
| dtantsur | TheJulia: FYI I'll be out tomorrow and on Friday | 13:10 |
| * dtantsur launching an internal spoon recollection routine | 13:10 | |
| *** ricolin_ has quit IRC | 13:11 | |
| TheJulia | Yeah, I was hoping we would be about there today | 13:11 |
| TheJulia | spoon collection ++ | 13:11 |
| TheJulia | Like Java GC, it is | 13:11 |
| dtantsur | exactly | 13:12 |
| *** tkajinam_ has quit IRC | 13:12 | |
| dtantsur | no mountains any soon, so need to reclaim whatever is possible | 13:12 |
| TheJulia | arne_wiebalck: replied to https://review.opendev.org/#/c/752308 | 13:17 |
| patchbot | patch 752308 - ironic-python-agent - Don't update the grubenv - 5 patch sets | 13:17 |
| TheJulia | arne_wiebalck: I guess the point is there seems to be no fix for grub, even without raid it launches os-prober apparently and then the grub-mkconfig command goes out to lunch | 13:19 |
| arne_wiebalck | TheJulia: But only with --dont-update-grubenv? | 13:20 |
| *** Lucas_Gray has joined #openstack-ironic | 13:20 | |
| arne_wiebalck | TheJulia: The bugzilla was not really clear to me as the even a command with that option took 2 mins to complete. | 13:21 |
| TheJulia | --no-grubenv-update is the option I found in another bug that was bascially the same issue | 13:22 |
| TheJulia | it is of course, undocumented \o/ | 13:22 |
| arne_wiebalck | Yeah, I realised :-D | 13:22 |
| TheJulia | Yeah, there do seem to be lots of reports of issues with newer grubs hanging and taking forever and they all seem to revolve around os-prober firing up | 13:23 |
| arne_wiebalck | So the other bug said using the option fixed the timing? | 13:23 |
| TheJulia | I don't remember seeing that | 13:23 |
| TheJulia | oh you mean executed without a crazy delay | 13:23 |
| arne_wiebalck | yes | 13:24 |
| * arne_wiebalck is looking for the logical connection | 13:24 | |
| TheJulia | yeah, apparently from what I've gathered os-prober is not executed then | 13:24 |
| *** priteau has joined #openstack-ironic | 13:24 | |
| arne_wiebalck | that is what I mean :) | 13:24 |
| TheJulia | no worries | 13:24 |
| * TheJulia goes and gets coffee since words are hard this morning | 13:24 | |
| arne_wiebalck | The referenced bug still has bad timing. | 13:24 |
| arne_wiebalck | WIth the option. | 13:24 |
| TheJulia | I think yeah, 20 seconds as opposed to 20+ minutes from what my brain processed | 13:26 |
| *** Lucas_Gray has quit IRC | 13:30 | |
| *** ricolin_ has joined #openstack-ironic | 13:31 | |
| openstackgerrit | Julia Kreger proposed openstack/ironic stable/ussuri: CI: Additional minor job changes to improve CI reliability https://review.opendev.org/755100 | 13:31 |
| TheJulia | any core reviewers have a chance to look at https://review.opendev.org/#/c/754717/ | 13:34 |
| patchbot | patch 754717 - ironic-python-agent - Software RAID: Get component devices by md UUID - 3 patch sets | 13:34 |
| arne_wiebalck | TheJulia: Hmm ... the 19 mins and the 2 mins are from different users. And the 2 mins is compared with 2 secs depending on what is on the disk, not which options are used: https://bugzilla.redhat.com/show_bug.cgi?id=1744693 | 13:36 |
| openstack | bugzilla.redhat.com bug 1744693 in grub2 "grub2-mkconfig does not work correctly with os-prober" [High,Closed: eol] - Assigned to pjones | 13:36 |
| *** tzumainn has joined #openstack-ironic | 13:37 | |
| openstackgerrit | Merged openstack/ironic master: Update 'idrac' driver requirements for Victoria https://review.opendev.org/754868 | 13:38 |
| TheJulia | arne_wiebalck: I may have copied the wrong bz down since when I was searching originally I think I ran across 8 filings or something that made my had hurt | 13:39 |
| TheJulia | my head | 13:39 |
| arne_wiebalck | TheJulia: ah! | 13:40 |
| TheJulia | Interesting, disabling it in grub.cfg made it run long | 13:40 |
| TheJulia | wtf | 13:40 |
| arne_wiebalck | LOL | 13:40 |
| arne_wiebalck | btw, I checked with our Linux folks here, but we have not run into this yet, it seems | 13:41 |
| arne_wiebalck | TheJulia: the other thing dtantsur and I were discussing earlier is the RAM guard patch | 13:42 |
| arne_wiebalck | TheJulia: I am still working on doing scale tests, but after the cleaning issues, I am now looking into the UEFI RAID creation issue | 13:42 |
| arne_wiebalck | TheJulia: so, it seems unlikely I can reproduce the OOM issue and then test the patch IRL | 13:43 |
| TheJulia | realistically your not the only person who has oomed the conductor though :) | 13:43 |
| arne_wiebalck | TheJulia: we were wondering if you would like the patch to go in for Victoria without these tests, or if you prefer to wait | 13:43 |
| TheJulia | we've actually partially seen it in CI too | 13:43 |
| arne_wiebalck | TheJulia: ok | 13:44 |
| arne_wiebalck | TheJulia: I was missing this bit | 13:44 |
| TheJulia | of course, now that is even worse with only 1gb of swap | 13:44 |
| TheJulia | eh, in ci it just creates a random variable | 13:44 |
| TheJulia | in terms of how long the job may take becuase overall system memory pressure | 13:44 |
| arne_wiebalck | TheJulia: I was wondering if others suffered which would mean it should go in early | 13:44 |
| arne_wiebalck | TheJulia: s/early/now/ | 13:44 |
| arne_wiebalck | TheJulia: for V | 13:44 |
| TheJulia | I can't think of anyone who has been really vocal, I just don't want to have to wait until the end of W | 13:45 |
| arne_wiebalck | TheJulia: ok | 13:45 |
| TheJulia | so after branching seems reasonable to me if we want to take a wait and see approach | 13:45 |
| arne_wiebalck | TheJulia: sorry for not being able to give feedback earlier, but machines arrived later than expected and then I ran into all these other issues ... | 13:46 |
| TheJulia | such is life :) | 13:46 |
| arne_wiebalck | TheJulia: is backporting an option in case we decide to wait? | 13:46 |
| TheJulia | Off hand, I don't see why not | 13:47 |
| dtantsur | mmm, because it's potentially breaking? | 13:47 |
| TheJulia | well, yeah, overall behavior wise but for good reasons | 13:47 |
| dtantsur | we may be missing a case where ironic barely works now but will be broken after this patch | 13:47 |
| dtantsur | can we backport it, but with the check disabled? i.e. required_memory==0? | 13:48 |
| dtantsur | or like 256? | 13:48 |
| TheJulia | but that was likely an already unstable case | 13:48 |
| dtantsur | but don't like unstable cases turning into broken cases :) | 13:48 |
| TheJulia | yeah, I guess we could | 13:48 |
| TheJulia | well, unstable turning into broken at least forces it to be fixed | 13:48 |
| dtantsur | we assume that image conversion takes up to 1G. if their images are tiny (cirros-alike), much less may be needed | 13:49 |
| dtantsur | even worse, they may start hitting retries and not realizing it at first | 13:49 |
| TheJulia | We could at least log a "well, your memory is not in a good state" warning and hope people pickup on it | 13:49 |
| dtantsur | sounds nice. "it will become an error in the Wallaby release" | 13:50 |
| TheJulia | sounds reasonable to me | 13:50 |
| dtantsur | hmm, but we still need a way to opt into a full error with retries | 13:51 |
| TheJulia | that way we can backport it just leave it disabled, cern can enable it and hopefully not kill their ironic-conductor processes :) | 13:51 |
| TheJulia | i think if set to 0, then it just logs a warning if below 1024 | 13:51 |
| TheJulia | if set to any value then it would be enabled and engage the logic | 13:52 |
| TheJulia | we know 1024M makes sense because of the ironic-lib default | 13:52 |
| TheJulia | I could make the patch do that and we could merge it to W, and backport it to V, and then in W just change the default | 13:53 |
| TheJulia | anyone want to review https://review.opendev.org/#/c/745598/ | 13:55 |
| patchbot | patch 745598 - ironic-python-agent - Add basic retries for inspection - 4 patch sets | 13:55 |
| openstackgerrit | Mudit proposed openstack/ironic master: Add GPU reporting to idrac-wsman inspect interface https://review.opendev.org/751006 | 13:57 |
| *** lmcgann_ has joined #openstack-ironic | 13:57 | |
| dtantsur | TheJulia: sounds like a plan | 13:59 |
| *** k_mouza has quit IRC | 13:59 | |
| openstackgerrit | Mark Goddard proposed openstack/ironic master: Don't migrate away from iscsi if it is the default https://review.opendev.org/755295 | 14:06 |
| openstackgerrit | Dmitry Tantsur proposed openstack/sushy-tools master: Handle race conditions when creating a directory for PersistentDict https://review.opendev.org/755297 | 14:10 |
| dtantsur | stbenjam: this ^^ should get you going | 14:10 |
| dtantsur | my comment about this code needing some cleansing fire stands though | 14:12 |
| *** ricolin_ has quit IRC | 14:14 | |
| TheJulia | Would that be cleansing fire with klingon opera playing in the background? | 14:14 |
| dtantsur | likely | 14:15 |
| openstackgerrit | Verification of a change to openstack/ironic failed: Handle patching node /protected value with None https://review.opendev.org/754884 | 14:20 |
| *** bhagyashri|rover is now known as bhagyashri | 14:20 | |
| mgoddard | dtantsur, TheJulia thanks for the fast reviews :) | 14:27 |
| TheJulia | hmmmm the ibmc devstack change looks okay but I'm guessing downstream merge conflicts are tanking all of the 3rd party ci jobs | 14:28 |
| TheJulia | also the failure in our gate seems same old fun issues around rescue | 14:28 |
| *** k_mouza has joined #openstack-ironic | 14:34 | |
| *** cdearborn has joined #openstack-ironic | 14:36 | |
| *** k_mouza has quit IRC | 14:39 | |
| openstackgerrit | Mudit proposed openstack/ironic master: Add GPU reporting to idrac-wsman inspect interface https://review.opendev.org/751006 | 14:41 |
| *** rajinir has quit IRC | 14:45 | |
| *** rajinir has joined #openstack-ironic | 14:46 | |
| janders | see you tomorrow Ironic o/ | 14:48 |
| janders | baremetal node power off janders | 14:48 |
| openstackgerrit | Julia Kreger proposed openstack/ironic stable/ussuri: CI: Additional minor job changes to improve CI reliability https://review.opendev.org/755100 | 14:56 |
| arne_wiebalck | janders: :D | 14:58 |
| * arne_wiebalck thinks that most of the ironic devs are on fasttrack | 14:59 | |
| *** gyee has joined #openstack-ironic | 14:59 | |
| iurygregory | bifrost enroll -- | 15:03 |
| iurygregory | ironic cli enroll ++ | 15:03 |
| openstackgerrit | Ankit Kumar proposed openstack/ironic master: Adds config parameter kernel_append_param for iLO https://review.opendev.org/755189 | 15:06 |
| *** k_mouza has joined #openstack-ironic | 15:17 | |
| openstackgerrit | Manuel Schönlaub proposed openstack/sushy master: Add oem_vendors from manager links https://review.opendev.org/755323 | 15:23 |
| *** QianbiaoNG has quit IRC | 15:26 | |
| openstackgerrit | Merged openstack/ironic-inspector master: pxe filter - option to always block unknown hosts https://review.opendev.org/753435 | 15:32 |
| *** belmoreira has joined #openstack-ironic | 15:33 | |
| dtantsur | TheJulia: a very reasonable complaint from stbenjam: deploying only one node in parallel in the CI does not allow us to catch races | 15:33 |
| dtantsur | I have no idea what to do about it. Ideally we should have at least something with high concurrency | 15:33 |
| TheJulia | dtantsur: multinode jobs have a deploy everything job that runs if memory serves | 15:34 |
| dtantsur | nope, no longer | 15:35 |
| TheJulia | oh really? shoot | 15:35 |
| dtantsur | we disabled that test because it caused too many sporadic failures | 15:35 |
| dtantsur | I don't know how to balance the desire to test things in parallel with the fact that it increases random failures quite substantially | 15:35 |
| TheJulia | We can't... not with our CI resources | 15:36 |
| TheJulia | 8 GB of ram, and the amount of data we have to ship to do even a multinode deployment is just a ton of potential risk for sporatic failures due to underlying infrastucture | 15:36 |
| dtantsur | yep :( | 15:37 |
| dtantsur | maybe one day we'll see a 3rd party CI from OCP | 15:37 |
| dtantsur | meanwhile, I feel like we're ready to release ironic-inspector. anyone wants to add anything or review the renos? | 15:37 |
| * TheJulia goes and looks | 15:38 | |
| TheJulia | LGTM | 15:40 |
| TheJulia | 10.4.0 ? | 15:40 |
| dtantsur | lemme dbl-check | 15:45 |
| dtantsur | TheJulia: yep, a nice and small release | 15:46 |
| dtantsur | wanna propose it? | 15:46 |
| openstackgerrit | Dhuldev Valekar proposed openstack/ironic master: DRAC: Added redfish management clean steps https://review.opendev.org/721593 | 15:46 |
| *** openstackgerrit has quit IRC | 15:46 | |
| TheJulia | dtantsur: sure | 15:47 |
| *** k_mouza_ has joined #openstack-ironic | 16:03 | |
| *** k_mouza has quit IRC | 16:06 | |
| *** lucasagomes has quit IRC | 16:06 | |
| dtantsur | could someone please review https://review.opendev.org/#/c/755297/ to make metal3 folks a bit happier? | 16:10 |
| patchbot | patch 755297 - sushy-tools - Handle race conditions when creating a directory f... - 1 patch set | 16:10 |
| iurygregory | woot | 16:12 |
| iurygregory | funny | 16:13 |
| iurygregory | +2 | 16:13 |
| iurygregory | if no other core show up I will +W after finishing my videos | 16:14 |
| dtantsur | I have interesting feelings every time I dive into sushy-tools code :) | 16:14 |
| dtantsur | thanks! | 16:14 |
| TheJulia | approved | 16:16 |
| dtantsur | \o/ | 16:18 |
| * dtantsur starts talking to people about a 3rd party CI | 16:18 | |
| *** tosky has quit IRC | 16:19 | |
| TheJulia | oooh ahh | 16:24 |
| *** thiagop has joined #openstack-ironic | 16:47 | |
| TheJulia | for ironic, is it just the hash ring patch we're thinking at this point? | 16:48 |
| dtantsur | the hash ring patch has merged to master, I think there was something else.. | 16:49 |
| * dtantsur checks open patches | 16:49 | |
| TheJulia | 754375 ? | 16:50 |
| TheJulia | plus mgoddard's chagne | 16:50 |
| dtantsur | https://review.opendev.org/755295 https://review.opendev.org/754884 | 16:50 |
| patchbot | patch 755295 - ironic - Don't migrate away from iscsi if it is the default - 1 patch set | 16:50 |
| patchbot | patch 754884 - ironic - Handle patching node /protected value with None - 2 patch sets | 16:50 |
| dtantsur | https://review.opendev.org/#/c/754375/ is not blocking | 16:50 |
| patchbot | patch 754375 - ironic - Handle conductor_affinity earlier in the deploymen... - 4 patch sets | 16:50 |
| TheJulia | agreed | 16:50 |
| TheJulia | ok, well if there are no objections and those merge today I can go ahead and tag later today, what about IPA, I think that seems settled since the bugs we can just backport | 16:51 |
| dtantsur | TheJulia: wanna me check the IPA uuid patch quickly? | 16:54 |
| dtantsur | it's the closest to approval | 16:55 |
| * TheJulia pull sup IPA | 16:55 | |
| dtantsur | I've approved it | 16:56 |
| TheJulia | k | 16:56 |
| TheJulia | the other raid patch is also a fix | 16:56 |
| *** ociuhandu has quit IRC | 16:57 | |
| TheJulia | https://review.opendev.org/#/c/755062 looks good to me | 16:57 |
| patchbot | patch 755062 - ironic-python-agent (stable/ussuri) - Software RAID: Don't delete partitions too early - 1 patch set | 16:57 |
| TheJulia | and just pushes back the wipefs until later | 16:57 |
| *** derekh has quit IRC | 17:00 | |
| dtantsur | mm, I suspect we can release ironic-ui if it has anything to release. at least branch it. | 17:11 |
| *** openstackgerrit has joined #openstack-ironic | 17:18 | |
| openstackgerrit | Verification of a change to openstack/sushy-tools failed: Handle race conditions when creating a directory for PersistentDict https://review.opendev.org/755297 | 17:18 |
| * dtantsur rolls eyes | 17:19 | |
| JayF | that's the second DB-related failure in unit tests I've seen | 17:20 |
| dtantsur | oh, interesting, it's a race in related unit tests | 17:20 |
| JayF | is there an infra issue, or actual race? | 17:20 |
| JayF | yeah :D | 17:20 |
| dtantsur | an actual race | 17:20 |
| dtantsur | I won't comment on sushy-tools code and design. I simply refuse. | 17:20 |
| dtantsur | it doesn't help that I cannot reproduce it locally | 17:22 |
| dtantsur | anyway, I'm out for a short PTO. have a great weekend and see you on Monday. | 17:22 |
| *** dtantsur is now known as dtantsur|afk | 17:23 | |
| iurygregory | JayF, DB failures on tests are the best! | 17:32 |
| iurygregory | when you want to merge something very fast they will happen =D | 17:32 |
| *** k_mouza_ has quit IRC | 17:40 | |
| *** thiagop has quit IRC | 17:56 | |
| *** thiagop has joined #openstack-ironic | 18:08 | |
| TheJulia | hmmm... I thought ironic-ui already had been | 18:11 |
| * TheJulia will look after som elunch | 18:11 | |
| openstackgerrit | Merged openstack/ironic master: Don't migrate away from iscsi if it is the default https://review.opendev.org/755295 | 18:20 |
| * TheJulia signs due to ussuri failures | 18:28 | |
| openstackgerrit | Merged openstack/ironic master: Handle patching node /protected value with None https://review.opendev.org/754884 | 18:30 |
| openstackgerrit | Merged openstack/ironic-python-agent master: Software RAID: Get component devices by md UUID https://review.opendev.org/754717 | 18:30 |
| *** thiagop has quit IRC | 18:31 | |
| *** thiagop has joined #openstack-ironic | 18:35 | |
| openstackgerrit | Merged openstack/ironic-ui master: Add npm tox env https://review.opendev.org/754439 | 18:43 |
| *** bdodd has quit IRC | 18:52 | |
| *** priteau has quit IRC | 18:56 | |
| *** ociuhandu has joined #openstack-ironic | 19:02 | |
| *** belmoreira has quit IRC | 19:05 | |
| *** ociuhandu has quit IRC | 19:06 | |
| *** bdodd has joined #openstack-ironic | 19:11 | |
| *** thiagop has quit IRC | 19:30 | |
| openstackgerrit | Merged openstack/sushy-tools master: Handle race conditions when creating a directory for PersistentDict https://review.opendev.org/755297 | 19:31 |
| *** tosky has joined #openstack-ironic | 19:32 | |
| mushrushu | hey! not sure if it's the right place to ask but is there any special procedure to change ip address of an ironic host deployed with bifrost? I've changed the ip in every config that I could find (including OS_ENDPOINT) but am still getting errors like "unable to establish connection to http://OLD_IP:6385/v1/nodes | 19:36 |
| *** bdodd has quit IRC | 19:39 | |
| iurygregory | did you re-run the playbooks (it should just override the new configs and put the services to run again | 19:46 |
| iurygregory | if you have nodes that are trying to talk with the old ironic and you want to update them this will probably be a bit different... | 19:47 |
| *** bdodd has joined #openstack-ironic | 19:51 | |
| mushrushu | @iurygregory you mean like deployed barametal nodes? | 19:53 |
| iurygregory | yeah | 19:53 |
| mushrushu | huh, i had a test one, but i've deleted it in mysql. could it be the cause? | 19:55 |
| iurygregory | you only deleted in mysql? | 19:55 |
| mushrushu | yup, i was not able to perform any openstack baremetal command, so i've deviceded that should be a good idea :) | 19:56 |
| iurygregory | if you do a curl http://new_ip:6385/v1/nodes | 19:58 |
| iurygregory | you get a valid response right? | 19:58 |
| TheJulia | tbh, I'd just re-install wish the ip address in the configuration, the templates will be updated with the new address and it will restart services... It sounds like clouds.yaml might not have been updated though | 19:59 |
| iurygregory | what I understood is that the error messages are on logs even after updating to use the new ip (this shouldn't happen afaik) | 20:02 |
| mushrushu | @iurygregory I haven't tried. the environment is on remote site so i can not check it right now. | 20:02 |
| TheJulia | mushrushu: was one of the files you edited clouds.yaml? | 20:03 |
| mushrushu | @TheJulia no, the thing is i've seen it being mentioned in the docs but couldn't find it on my vm even with find | 20:04 |
| mushrushu | i've definitely edited ironic.conf inspector.conf dnsmasq.conf /httpboot/pxelinux.cfg/default and openrc | 20:07 |
| iurygregory | if you edited manualy and you are trying "baremetal node list" | 20:12 |
| iurygregory | it won't work because the clouds.yaml will point to the old ip | 20:12 |
| openstackgerrit | Merged openstack/ironic-python-agent stable/ussuri: Software RAID: Don't delete partitions too early https://review.opendev.org/755062 | 20:12 |
| mushrushu | where should that file be? Is it like a mandatory one? find / -name "cloud.yaml" gives me nothing | 20:14 |
| *** jtomasek has quit IRC | 20:15 | |
| mushrushu | oh | 20:16 |
| TheJulia | try looking at ~/.config/openstack/clouds.yaml | 20:16 |
| mushrushu | i see a typo, sorry | 20:16 |
| TheJulia | oh, okay | 20:16 |
| mushrushu | i was looking for cloud.yaml the whole time not clouds | 20:17 |
| mushrushu | thanks for your help and patience | 20:19 |
| openstackgerrit | Iury Gregory Melo Ferreira proposed openstack/bifrost master: Add ipe installation to bifrost https://review.opendev.org/752042 | 20:19 |
| stevebaker | morning | 20:20 |
| iurygregory | morning stevebaker o/ | 20:29 |
| openstackgerrit | Merged openstack/ironic master: Handle conductor_affinity earlier in the deployment process https://review.opendev.org/754375 | 20:50 |
| TheJulia | rpioso: rechecking stable/ussuri is not going to help right now | 21:03 |
| rpioso | TheJulia: Ack | 21:04 |
| TheJulia | I've got a patch where I'm trying to wrap everything together to fix CI in general due to the infra changes but I've just not had any luck yet | 21:04 |
| TheJulia | any last calls before I tag releases? | 21:09 |
| * TheJulia makes some fresh coffee | 21:17 | |
| openstackgerrit | Iury Gregory Melo Ferreira proposed openstack/bifrost master: Add ipe installation to bifrost https://review.opendev.org/752042 | 21:21 |
| TheJulia | iurygregory: prometheus exporter release? | 21:47 |
| iurygregory | pushing | 21:47 |
| TheJulia | looks like bifrost still needs to be released | 21:48 |
| iurygregory | we are *waitting* | 21:48 |
| TheJulia | huh? | 21:48 |
| iurygregory | I'm trying to add the support for ipe on bifrost =X | 21:48 |
| iurygregory | works locally but CI seems unhappy | 21:48 |
| TheJulia | hmm | 21:48 |
| iurygregory | we have 2.1 for IPE so 2.2 should be good right? | 21:52 |
| rpioso | TheJulia: We're trying to land https://review.opendev.org/#/c/751006. | 21:52 |
| patchbot | patch 751006 - ironic - Add GPU reporting to idrac-wsman inspect interface - 9 patch sets | 21:52 |
| iurygregory | can be also 2.1.1 since the only addition was a fix for node_name... | 21:52 |
| iurygregory | wdyt? | 21:52 |
| TheJulia | rpioso: the committed/published date of the community was the 28th... | 21:55 |
| TheJulia | iurygregory: can you takea quick look at rpioso's patch | 21:57 |
| rpioso | TheJulia: Understood. I thought you made a last call :-) | 21:57 |
| rpioso | iurygregory, TheJulia: I can quickly make any needed changes. | 21:57 |
| iurygregory | dell ci is testing this or you had some downstream tests rpioso ? | 21:59 |
| iurygregory | jsut me or this would need a bump in requirements? | 22:00 |
| TheJulia | iurygregory: w/r/t bifrost, I _think_ if you try to combine the conditional on one line it should work just fine. There is some funkiness at times around lists of whens and I suspect the bool casting is throwing it since it is really for humans overriding it with a string | 22:00 |
| iurygregory | since you need a new version of the python-dracclient... | 22:01 |
| iurygregory | TheJulia, I will give a try =) | 22:01 |
| rpioso | iurygregory: It's a new feature, so the Dell 3d Party CI is not testing it. However, we have extensively integration tested it. | 22:02 |
| TheJulia | yeah, minimum needs to bumb | 22:02 |
| iurygregory | I would +2 https://review.opendev.org/#/c/751006 but I think it needs to update the driver-requirements.txt | 22:02 |
| patchbot | patch 751006 - ironic - Add GPU reporting to idrac-wsman inspect interface - 9 patch sets | 22:02 |
| iurygregory | =) | 22:02 |
| rpioso | iurygregory, TheJulia: It's been bumped. | 22:03 |
| TheJulia | yeah, minimum needs to be bumped in driver-requirements.txt since there is no handling of attributeerror due to the method call | 22:03 |
| TheJulia | rpioso: not quite | 22:03 |
| iurygregory | rpioso, I don't see driver-requirements.txt updated | 22:03 |
| iurygregory | https://review.opendev.org/#/c/751006/ | 22:03 |
| patchbot | patch 751006 - ironic - Add GPU reporting to idrac-wsman inspect interface - 9 patch sets | 22:03 |
| iurygregory | =) | 22:04 |
| TheJulia | it is defined as >=3.1.0,<6.0.0 | 22:04 |
| TheJulia | but anyone that hits that code with <5.0.0, i.e. 4.0, will have an exception | 22:04 |
| rpioso | iurygregory, TheJulia: Then that lower bound has been broken for a long time. Our impression is that represents the version necessary for the minimum, required ironic support -- power and management. | 22:06 |
| iurygregory | omg | 22:06 |
| rpioso | I communicated with cdearborn earlier this week. He recalls receiving that guidance from dtantsur. | 22:06 |
| TheJulia | not quite, inspection is totally non-functional as it is not handled otherwise, so the minimum should be what is compatible and generally worsk | 22:06 |
| rpioso | TheJulia: Agent inspection, no? | 22:07 |
| TheJulia | so adding the code is going to blow it up if anyone calls inspect today or tomorrow | 22:07 |
| TheJulia | at least, oob inspection | 22:07 |
| rpioso | iurygregory, TheJulia: Should it be >=5.1.0,<6.0.0? If so, I'll make that change, along with any others. | 22:09 |
| TheJulia | rpioso: based on the proposed code, yes | 22:09 |
| iurygregory | yeah | 22:09 |
| * TheJulia takes a quick break and emails winnebago :( | 22:09 | |
| *** rcernin has joined #openstack-ironic | 22:12 | |
| rpioso | iurygregory, TheJulia: The owner of that change had a question about the release note. May we drop the issue subsection from it? | 22:12 |
| * iurygregory looks | 22:12 | |
| TheJulia | I'd prefer it dropped and clarified in documentation | 22:13 |
| TheJulia | but that doesn't need to happen now() | 22:13 |
| TheJulia | but yeah | 22:13 |
| iurygregory | yeah a note in doc/source/admin/drivers/idrac.rst would make more sense | 22:14 |
| rpioso | We need to further analyze the 13G observation. It may be caused by GPU configuration, iDRAC support or lack thereof, or smth else. How about we follow up the change with a bug fix and/or documentation update after we have more info? | 22:15 |
| iurygregory | and docs we can backport without problems | 22:15 |
| TheJulia | rpioso: perfect! | 22:15 |
| * rpioso modifies driver-requirements.txt and removes the issue from the release note | 22:15 | |
| TheJulia | without clarity, I'd prefer it just be in docs once ther eis clarity | 22:15 |
| TheJulia | ++ | 22:15 |
| iurygregory | yeah =) | 22:16 |
| rpioso | iurygregory, TheJulia: <3 | 22:16 |
| iurygregory | TheJulia, I'm pusing IPE 2.1.1 since we only have a bugfix ok? | 22:16 |
| rpioso | iurygregory, TheJulia: Anything else? | 22:16 |
| iurygregory | rpioso, not from my side =) | 22:16 |
| TheJulia | iurygregory: sounds good | 22:16 |
| TheJulia | yeah, that is all from my pov | 22:17 |
| openstackgerrit | Richard G. Pioso proposed openstack/ironic master: Add GPU reporting to idrac-wsman inspect interface https://review.opendev.org/751006 | 22:18 |
| iurygregory | rpioso, I think you forgot git add ... | 22:20 |
| iurygregory | releasenote is the same and no req change =) | 22:20 |
| rpioso | iurygregory: I rebased, because driver-requirements.txt change would conflict. Now making the changes. | 22:21 |
| iurygregory | I see | 22:21 |
| *** rloo has quit IRC | 22:22 | |
| *** k_mouza has joined #openstack-ironic | 22:27 | |
| openstackgerrit | Richard G. Pioso proposed openstack/ironic master: Add GPU reporting to idrac-wsman inspect interface https://review.opendev.org/751006 | 22:34 |
| rpioso | iurygregory: ^^^ | 22:34 |
| iurygregory | I've put my +2 since I don't want to wait almost 3hrs for results hehe | 22:35 |
| TheJulia | heh | 22:51 |
| TheJulia | yeah... I'm going to have to tag it later tonight | 22:51 |
| TheJulia | which I'm fine with | 22:51 |
| TheJulia | +2+A approved | 22:52 |
| TheJulia | I'll check back on it in a couple hours | 22:52 |
| *** tosky has quit IRC | 22:54 | |
| rpioso | iurygregory, TheJulia: Thank you so much! | 22:56 |
| rpioso | iurygregory, TheJulia: I successfully ran the unit tests and built the release notes locally before pushing the new patch set. | 22:59 |
| *** tkajinam has joined #openstack-ironic | 23:00 | |
| *** k_mouza has quit IRC | 23:00 | |
| TheJulia | awesome, thanks | 23:03 |
| *** k_mouza has joined #openstack-ironic | 23:37 | |
| rpioso | TheJulia: :) | 23:43 |
| *** k_mouza has quit IRC | 23:45 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!