Tuesday, 2020-08-25

*** Goneri has quit IRC00:27
*** livelace has quit IRC00:36
*** tkajinam_ is now known as tkajinam01:04
*** rcernin has quit IRC01:14
*** rcernin has joined #openstack-ironic01:15
*** gyee has quit IRC01:48
*** hjensas has quit IRC02:25
*** bfournie has joined #openstack-ironic02:27
*** cdearborn has quit IRC02:55
*** janders has quit IRC02:56
*** janders has joined #openstack-ironic02:57
*** mkrai has joined #openstack-ironic03:02
*** rh-jelabarre has quit IRC03:16
*** dsneddon has quit IRC03:45
*** ijw has quit IRC04:07
*** ijw has joined #openstack-ironic04:08
*** ijw has quit IRC04:10
*** ijw has joined #openstack-ironic04:10
openstackgerritJacob Anders proposed openstack/bifrost master: Explicitly set permissions on /httpboot contents  https://review.opendev.org/74781504:16
*** rcernin has quit IRC04:32
stevebakerspam alert04:55
* stevebaker cranks the klaxon04:55
stevebakeror not, git review is stalled04:59
*** Lucas_Gray has joined #openstack-ironic05:03
*** rcernin has joined #openstack-ironic05:03
openstackgerritSteve Baker proposed openstack/ironic master: New argument validate decorator  https://review.opendev.org/74279505:03
openstackgerritSteve Baker proposed openstack/ironic master: Add status_code argument to @method.expose  https://review.opendev.org/74367705:03
openstackgerritSteve Baker proposed openstack/ironic master: Add @method.body decorator  https://review.opendev.org/74367805:03
openstackgerritSteve Baker proposed openstack/ironic master: Duplicate trait validation with jsonschema  https://review.opendev.org/74577805:03
openstackgerritSteve Baker proposed openstack/ironic master: Convert allocation endpoint to plain JSON  https://review.opendev.org/74367905:03
openstackgerritSteve Baker proposed openstack/ironic master: Convert bios endpoint to plain JSON  https://review.opendev.org/74547505:03
openstackgerritSteve Baker proposed openstack/ironic master: Convert chassis endpoint to plain JSON  https://review.opendev.org/74547605:03
openstackgerritSteve Baker proposed openstack/ironic master: Convert conductor endpoint to plain JSON  https://review.opendev.org/74577905:04
openstackgerritSteve Baker proposed openstack/ironic master: Convert deploy_templates endpoint to plain JSON  https://review.opendev.org/74578005:04
*** tzumainn has quit IRC05:04
openstackgerritSteve Baker proposed openstack/ironic master: Convert drivers endpoint to plain JSON  https://review.opendev.org/74186505:04
openstackgerritSteve Baker proposed openstack/ironic master: Convert event endpoint to plain JSON  https://review.opendev.org/74662305:04
openstackgerritSteve Baker proposed openstack/ironic master: WIP Convert node endpoint to plain JSON  https://review.opendev.org/74782005:04
*** SuiongNg|ITRI_TW has joined #openstack-ironic05:11
*** gudrutis1 has joined #openstack-ironic05:11
*** gudrutis has quit IRC05:14
*** gudrutis1 is now known as gudrutis05:14
*** uzumaki has joined #openstack-ironic05:17
*** gudrutis5 has joined #openstack-ironic05:24
*** gudrutis has quit IRC05:27
*** gudrutis5 is now known as gudrutis05:27
*** rcernin has quit IRC05:41
*** Lucas_Gray has quit IRC05:44
*** ricolin_ has joined #openstack-ironic06:04
*** ricolin_ has quit IRC06:11
arne_wiebalckGood morning, ironic!06:15
uzumakibonjour arne_wiebalck o/ comment vas-tu?06:28
jandersgood morning arne_wiebalck uzumaki06:29
jandershow are we?06:29
arne_wiebalckhey uzumaki janders o/06:30
arne_wiebalckhow are things on the other side of the planet?06:30
*** ijw has quit IRC06:31
*** noama has joined #openstack-ironic06:31
noamahi dtantsur|afk could you backport https://review.opendev.org/#/c/743498/ to ussuri?06:32
patchbotpatch 743498 - ironic-inspector - Relax extra_hardware data validation by default (MERGED) - 2 patch sets06:32
rpittaugood morning ironic! o/06:41
rpittaunoama: you can also propose a backport :)06:42
noamait think it should include 2 patches06:42
rpittaunoama: what's the other one ?06:43
openstackgerritNoam Angel proposed openstack/ironic-inspector stable/ussuri: extra_hardware: stop storing raw data in swift  https://review.opendev.org/74784006:43
arne_wiebalckare these eligible for backporting?06:44
*** ijw has joined #openstack-ironic06:44
rpittauit's what I was checking, one is a fix, but this one looks like a change06:44
rpittauit does change an internal logic though06:45
noamaextra_hardware is missing in ussuri06:48
*** ijw has quit IRC06:49
rpittauyeah, I remember the issue06:50
noamawhat do you suggest rpittau would it be better just to backport https://review.opendev.org/#/c/743498/?06:50
patchbotpatch 743498 - ironic-inspector - Relax extra_hardware data validation by default (MERGED) - 2 patch sets06:50
jandersgood morning rpittau o/06:50
jandersarne_wiebalck things are good, thanks for asking. The days are finally getting a bit longer! :)06:51
rpittaunoama: that looks like the actual fix06:51
rpittauhey janders :)06:51
noamaok06:51
noamaill try that06:51
*** mkrai has quit IRC06:52
*** mkrai_ has joined #openstack-ironic06:52
*** rcernin has joined #openstack-ironic06:56
rpittaujanders: s/retest/recheck :)06:57
*** rcernin has quit IRC07:03
jandersrpittau done! I was swearing at Zuul being "slow", now I see why LOL07:04
jandersoff for a walk, back soon07:04
*** rcernin has joined #openstack-ironic07:05
*** rcernin has quit IRC07:14
*** ijw has joined #openstack-ironic07:15
*** ijw has quit IRC07:20
*** iurygregory has joined #openstack-ironic07:21
iurygregorygood morning Ironic!07:22
*** dtantsur|afk is now known as dtantsur07:26
dtantsurmorning ironic07:26
dtantsurnoama: I agree with rpittau, only the fix should be backported (you'll need to resolve the conflicts manually, unfortunately)07:27
iurygregorymorning dtantsur07:29
dtantsurnoama: if you're struggling with resolving the conflicts, feel free to ping me07:29
*** tosky has joined #openstack-ironic07:36
*** xinliang has joined #openstack-ironic07:36
*** Qianbiao has joined #openstack-ironic07:36
*** dougsz has joined #openstack-ironic07:39
*** Qianbiao has quit IRC07:40
*** Qianbiao has joined #openstack-ironic07:41
dtantsurfolks, could you check https://review.opendev.org/#/c/747413/ please? it demoes nicely that the direct deploy can be used in a low RAM situation without swift07:45
patchbotpatch 747413 - metalsmith - CI: use the direct deploy by default - 3 patch sets07:45
*** ijw has joined #openstack-ironic07:47
iurygregoryI will add to my list07:49
*** ijw has quit IRC07:52
* iurygregory grabs more coffee07:56
openstackgerritMerged openstack/ironic master: Enforce autospec in common tests  https://review.opendev.org/74776708:00
*** xinliang has quit IRC08:03
openstackgerritRiccardo Pittau proposed openstack/metalsmith master: [WIP] Use Centos 8  https://review.opendev.org/73727808:11
*** janders6 has joined #openstack-ironic08:11
openstackgerritMerged openstack/bifrost master: ansible-lint: fix error 204 (Lines should be no longer than 160 chars)  https://review.opendev.org/74769208:13
*** lucasagomes has joined #openstack-ironic08:13
*** janders has quit IRC08:13
*** janders6 is now known as janders08:13
*** ijw has joined #openstack-ironic08:18
*** ijw has quit IRC08:23
iurygregorydtantsur, merge conflict https://review.opendev.org/#/c/747434/ =(08:27
patchbotpatch 747434 - bifrost - Remove support for non-venv deployments - 2 patch sets08:27
rpittauprobably the lint patches08:28
iurygregoryyeah08:28
openstackgerritMerged openstack/bifrost master: ansible-lint: fix errors 303, 305, 306  https://review.opendev.org/74769408:29
noamahi dtantsur https://review.opendev.org/#/c/743498/ seems much to me to backport it to ussuri08:30
patchbotpatch 743498 - ironic-inspector - Relax extra_hardware data validation by default (MERGED) - 2 patch sets08:30
*** uzumaki has quit IRC08:34
*** derekh has joined #openstack-ironic08:41
rpittauif anyone has a moment, this is quite important to prevent future pip-related cataclysms https://review.opendev.org/74721808:44
patchbotpatch 747218 - ironic-python-agent-builder - Pin pip version to install in tinyipa images - 2 patch sets08:44
openstackgerritMerged openstack/ironic bugfix/15.2: Ansible deploy - Ignore invalid devices  https://review.opendev.org/74772908:45
openstackgerritMerged openstack/ironic bugfix/15.1: Ansible deploy - Ignore invalid devices  https://review.opendev.org/74773008:45
SuiongNg|ITRI_TWHi everyone, I encountered a problem while deploying node in UEFI mode. IPA seems to be able to correctly create a vfat partiton (for ESP?) but fails to install grub. By contrast, if the node is deployed in leagcy mode, no vfat partition is created and grub is correctly installed.08:45
SuiongNg|ITRI_TWlast_error says "grub-install: error: install device isn't specified"08:46
rpittauSuiongNg|ITRI_TW: which version of IPA/ironic? do you have ironic-python-agent and ironic-conductor logs maybe ?08:46
SuiongNg|ITRI_TWone minute.08:47
*** ijw has joined #openstack-ironic08:49
jandersrpittau: Zuul: Magic word? janders: recheck :)08:51
SuiongNg|ITRI_TWhttp://paste.openstack.org/show/797110/08:51
rpittau:D08:52
rpittaujanders: you need a rebase, zuul tricked you :)08:52
SuiongNg|ITRI_TWI wasn't able to retrieve IPA log because the node power itself off immediatedly.08:53
*** ijw has quit IRC08:54
*** k_mouza has joined #openstack-ironic08:57
jandersrpittau last time I needed a rebase I got "in merge conflict" message and some details, now it's just "cannot merge" - what made the difference this time?08:57
*** uzumaki has joined #openstack-ironic08:58
rpittauSuiongNg|ITRI_TW: it seems grub is missing the target for the installation for some reason, hard to say why without ipa logs, you could try pausing IPA setting the node to maintenance, also be sure to have debug enabled08:59
rpittaujanders: I believe it's the same, if you pass the mouse cursor on the "Cannot Merge" message you will see the reason09:00
arne_wiebalckSuiongNg|ITRI_TW: is this with software RAID?09:00
dtantsurnoama: sorry, what do you mean? You don't think it should be backported? Or you're struggling with conflicts?09:01
jandersrpittau ACK. I bet I'm in conflict with dtantsur ansible linter work as I patched some horribly long lines indeed.09:01
SuiongNg|ITRI_TWarne_wiebalck: hardware raid (LSI card)09:02
dtantsuryeah, the lint patches conflict with everything.. haven't thought about it, sorry09:02
dtantsurjanders: you get 'in merge conflict' when anything happens with your patch (zuul is running, you post an update, etc)09:03
dtantsurotherwise zuul will or will not let you know explicitly09:03
dtantsurnot sure why exactly09:03
jandersNo worries, I will fix it. It's much nicer to work with the updated code - great work dtantsur :)09:04
openstackgerritMerged openstack/bifrost master: Remove env-vars  https://review.opendev.org/74766809:04
SuiongNg|ITRI_TWrpittau: So I have to first put the node in deployment mode. And set it to maintenance as soon as it enter "deploying" state ?09:04
SuiongNg|ITRI_TWarne_wiebalck: btw, it also fails on another node without any hardware raid card.09:07
openstackgerritDmitry Tantsur proposed openstack/bifrost master: Remove support for non-venv deployments  https://review.opendev.org/74743409:08
dtantsuriurygregory: ^^09:08
dtantsurjanders: btw there is a (currently ignored) lint for missing mode in file operations09:08
dtantsuryou may even take the task of removing it09:08
arne_wiebalckSuiongNg|ITRI_TW: I am little puzzled on why it creates a partition ... shouldn't this come from the image? Or are you using partition images?09:09
dtantsur(although probably in a separate patch because this one has to be backported)09:09
arne_wiebalckDoes the white paper link on openstack.org/baremetal work for anyone? It seems to redirect me to the very same page ..09:11
SuiongNg|ITRI_TWarne_wiebalck: I'm not sure. I didn't specify the ramdisk and kernel. However, the image is generate by disk-image-create with baremetal element. Yet from my understanding, this "baremetal" element only extract the kernel and ramdisk, which means is doesn't alter the qcow partition image.09:13
iurygregoryarne_wiebalck, when you click "Read It Now"?09:14
arne_wiebalckiurygregory: does that work for you?09:14
iurygregoryarne_wiebalck, nope09:14
arne_wiebalckiurygregory: that is what I mean09:14
arne_wiebalckiurygregory: :)09:14
iurygregorytrouble for us =)09:14
arne_wiebalckthe stats on clicking the link will go up as everyone tries twice :-D09:15
janderswill grab some dinner, back in half an hour09:15
iurygregoryouch, in the ironic website we re-direct to openstack.org/baremetal hehe09:16
*** mkrai_ has quit IRC09:18
*** mkrai__ has joined #openstack-ironic09:18
arne_wiebalckI will contact the foundation.09:19
iurygregoryarne_wiebalck, ++09:19
*** ianychoi__ has joined #openstack-ironic09:21
*** SuiongNg|ITRI_TW has quit IRC09:21
*** ijw has joined #openstack-ironic09:21
*** SuiongNg|ITRI_TW has joined #openstack-ironic09:22
*** ianychoi_ has quit IRC09:24
*** belmoreira has joined #openstack-ironic09:25
openstackgerritIury Gregory Melo Ferreira proposed openstack/ironic master: Add tempest default_boot_option and altflavor  https://review.opendev.org/74188609:26
*** ijw has quit IRC09:26
*** hjensas has joined #openstack-ironic09:29
*** k_mouza has quit IRC09:36
*** k_mouza has joined #openstack-ironic09:45
openstackgerritRiccardo Pittau proposed openstack/bifrost master: ansible-lint: fix error 206  https://review.opendev.org/74788309:49
openstackgerritMerged openstack/ironic stable/train: Ansible deploy - Ignore invalid devices  https://review.opendev.org/74757709:49
openstackgerritMerged openstack/metalsmith master: CI: use the direct deploy by default  https://review.opendev.org/74741309:51
*** livelace has joined #openstack-ironic09:53
*** ijw has joined #openstack-ironic09:53
openstackgerritMerged openstack/python-ironic-inspector-client master: Provide a clear error message when trying to access ironic (not inspector)  https://review.opendev.org/74695609:53
*** ijw has quit IRC09:57
dtantsurJayF: started https://storyboard.openstack.org/#!/story/2008057 for client certificates, mostly a copy paste for now09:57
*** uzumaki has quit IRC10:03
*** NobodyCam has quit IRC10:14
*** buhman has quit IRC10:14
jandersdo I need to do anything special in the commit message while finishing the rebase?10:14
jandersor just leave as-is and submit the new revision for review?10:15
*** livelace has quit IRC10:15
iurygregoryjanders, no need =)10:15
iurygregoryjust git rebase -i master10:15
*** johnsom has quit IRC10:16
iurygregoryand git review =D10:16
*** NobodyCam has joined #openstack-ironic10:16
*** buhman has joined #openstack-ironic10:16
openstackgerritMerged openstack/ironic bugfix/15.2: Ensure in-band deploy steps are present in time for fast-track deployments  https://review.opendev.org/74773710:16
openstackgerritJacob Anders proposed openstack/bifrost master: Explicitly set permissions on /httpboot contents  https://review.opendev.org/74781510:17
*** johnsom has joined #openstack-ironic10:17
openstackgerritJacob Anders proposed openstack/bifrost master: Explicitly set permissions on /httpboot contents  https://review.opendev.org/74781510:18
jandersoops I somehow missed the merging markers10:19
janderscleaning up now10:19
openstackgerritJacob Anders proposed openstack/bifrost master: Explicitly set permissions on /httpboot contents  https://review.opendev.org/74781510:21
dtantsurjanders: a release note please!10:21
jandersdtantsur ACK will do10:21
dtantsurbackportable bug fixes need release notes that explain the fix10:21
dtantsur(and features need release notes that introduce the features)10:21
jandersI think I already broke World Record for number of revisions needed for adding a bunch of chmods :) one revision more will make the record stand longer10:22
dtantsurheh10:22
openstackgerritDmitry Tantsur proposed openstack/bifrost master: Remove support for the legacy CSV format  https://review.opendev.org/74789310:22
jandersapologies for the spam10:22
dtantsurjanders: I still remember the review that added IPA support in ironic. It reached 100 revisions, and gerrit started choking on it :D10:23
jandersLOL10:23
dtantsurso another review was created and reached probably 50 revisions more10:23
jandersthat is DDoS in style10:23
dtantsurfun times :)10:23
jandershats off10:23
jandersbreaking stuff for fun and profit as they say10:23
*** ijw has joined #openstack-ironic10:24
openstackgerritMerged openstack/ironic-python-agent-builder master: Pin pip version to install in tinyipa images  https://review.opendev.org/74721810:26
*** k_mouza has quit IRC10:26
openstackgerritVerification of a change to openstack/ironic failed: Ansible deploy - Ignore invalid devices  https://review.opendev.org/74757610:26
openstackgerritDmitry Tantsur proposed openstack/bifrost master: Use packaged iPXE ROMs for openSUSE  https://review.opendev.org/74789410:27
*** k_mouza has joined #openstack-ironic10:28
*** ijw has quit IRC10:29
jandersdtantsur does the release note for the bifrost/get_url/chmod fix only need "fixes" section?10:30
openstackgerritDmitry Tantsur proposed openstack/bifrost master: Use packaged iPXE ROMs for openSUSE  https://review.opendev.org/74789410:31
dtantsurjanders: well, we can also add an upgrade section to highlight the fact that we'll change ownership and ACL10:31
jandersdtantsur thank you10:32
openstackgerritDmitry Tantsur proposed openstack/bifrost master: Use packaged iPXE ROMs for openSUSE  https://review.opendev.org/74789410:35
dtantsurI'm also good at updating a trivial patch too often..10:35
*** livelace has joined #openstack-ironic10:35
openstackgerritDmitry Tantsur proposed openstack/bifrost master: Trivial: stop using deprecated HTTP basic options  https://review.opendev.org/74789710:40
openstackgerritJacob Anders proposed openstack/bifrost master: Explicitly set permissions on /httpboot contents  https://review.opendev.org/74781510:47
jandershopefully I got ^^^ right :)10:48
openstackgerritDmitry Tantsur proposed openstack/bifrost master: Remove support for OpenStack MetaData version 2012-08-10  https://review.opendev.org/74790010:49
dtantsurso nice to remove code10:49
*** pas-ha has quit IRC10:49
*** ildikov has quit IRC10:49
dtantsurjanders: let's also do owner/group ironic:ironic?10:49
dtantsurjanders: and we tend to use present tense in release notes10:50
*** sri_ has quit IRC10:50
dtantsurimagine saying "This version" and adding your note10:50
dtantsurokay, this can be used with past tense as well :) but we tend to use present10:50
*** rpioso has quit IRC10:50
jandersdtantsur adding user/group now (good idea!) - and will fix up the tenses while I'm at it10:52
dtantsurjanders: added a few other comments10:52
jandersdtantsur ACK. Would you like me to switch all the files I'm changing to modern syntax (multi-line and ":" instead of "=") or just the tasks I'm updating?10:54
jandershappy to do both but it feels like that might be better off in a separate change10:54
*** ijw has joined #openstack-ironic10:56
*** Qianbiao has quit IRC10:57
dtantsurjanders: just the tasks you're updating10:57
openstackgerritDmitry Tantsur proposed openstack/bifrost master: Stop supporting storing introspection data in nginx  https://review.opendev.org/74790110:57
*** rcernin has joined #openstack-ironic10:57
dtantsurI'd prefer we update them gradually every time we have to touch a task10:57
jandersdtantsur ACK, on it10:59
*** rpioso has joined #openstack-ironic10:59
*** ijw has quit IRC11:00
*** sri_ has joined #openstack-ironic11:01
*** pas-ha has joined #openstack-ironic11:01
ajyadtantsur: did you get any volunteers for deploy_steps RFE? If not, I could volunteer, though in the next cycle11:03
dtantsurajya: I don't remember.. I think I didn't. Thank you, I'll keep that in mind, although I'd really prefer this to be finished this cycle.11:03
jandersdtantsur are you happy with hardcoding owner:group ironic:ironic or do we need a new var for this? I see it hardcoded a fair bit in the code but I thought I will check in case we want to move away from this.11:04
dtantsurjanders: I'm happy with hardcoding it11:04
jandersdtantsur ACK11:04
dtantsurI personally am against having too many options11:04
dtantsurwhen they don't add a visible benefit for operators11:05
jandersyeah flexibility for the sake of flexibility is an average idea and a reliable source of distractions :)11:05
* dtantsur has spent this morning removing options from bifrost11:06
ajyadtantsur: no time left in this cycle for me, so can't commit to it now. Let's see if anyone volunteers for this cycle :)11:07
dtantsursure, understandable11:08
*** ildikov has joined #openstack-ironic11:10
*** dougsz has quit IRC11:11
dtantsur"File '/lib/systemd/system/uwsgi.service' created with default permissions '600'. The previous default was '666'. Specify 'mode' to avoid this warning."11:13
dtantsurwe're getting tons of these warnings now >_<11:13
openstackgerritJacob Anders proposed openstack/bifrost master: Explicitly set permissions on /httpboot contents  https://review.opendev.org/74781511:14
janders^^^ has a fair bit of syntax tweaking, so will rerun tests on host07, hence -1/WIP11:15
dtantsurjanders: left come comments before you test11:16
openstackgerritDmitry Tantsur proposed openstack/bifrost master: Stop supporting storing introspection data in nginx  https://review.opendev.org/74790111:16
dtantsuryou're obsoleting my previous fixes, so they can be removed11:16
jandersdtantsur got it11:17
dtantsurjanders: and please pay attention to trailing spaces11:17
dtantsurif you use vim, you can make it highlight them11:17
ajyadtantsur: looked again at that flavor-deploy template thing and deploy steps not being picked up from flavor/traits. Could it be because I'm using baremetal API and not nova API to create nodes?11:17
dtantsurjanders: like https://github.com/dtantsur/config/blob/master/vimrc#L72-L7311:17
dtantsurajya: if you're not using nova API, flavors are not used11:18
dtantsurironic is completely unaware of flavors11:18
ajyadtantsur: should docs be updated for this use case?11:18
jandersdtantsur totally stealing this, thanks! :)11:19
janders(it looks I realised half-way breaking up the oldschool long-line calls leaves a ton of whitespaces behind, shame I forgot to go back and clean the previous ones)11:19
janderswell, the new vim config will sort this out for the future11:20
*** mkrai__ has quit IRC11:24
openstackgerritJacob Anders proposed openstack/bifrost master: Explicitly set permissions on /httpboot contents  https://review.opendev.org/74781511:24
*** ijw has joined #openstack-ironic11:27
*** mkrai has joined #openstack-ironic11:28
*** trident has quit IRC11:31
*** ijw has quit IRC11:32
janders^^^ (test running)11:32
openstackgerritMerged openstack/metalsmith master: Move metalsmith_instances from tripleo-ansible  https://review.opendev.org/73788711:38
*** Lucas_Gray has joined #openstack-ironic11:41
dtantsurajya: I think we do cover the standalone case separately?11:43
openstackgerritDmitry Tantsur proposed openstack/bifrost master: Authentication JSON RPC even in no-auth mode  https://review.opendev.org/74789711:48
openstackgerritDmitry Tantsur proposed openstack/bifrost master: Remove support for OpenStack MetaData version 2012-08-10  https://review.opendev.org/74790011:51
openstackgerritJacob Anders proposed openstack/bifrost master: Explicitly set permissions on /httpboot contents  https://review.opendev.org/74781511:56
*** rh-jelabarre has joined #openstack-ironic11:58
*** ijw has joined #openstack-ironic11:59
openstackgerritMerged openstack/ironic master: Move redfish-virtual-media to the back of supported_boot_interfaces  https://review.opendev.org/74743012:00
*** ijw has quit IRC12:03
shadowerre: https://storyboard.openstack.org/#!/story/2008038 -- is the out of bound inspection basically whatever we can get by just asking the BMC?12:06
shadower(trying to undrestand what the difference between out-of-bound and in-bound is)12:06
dtantsurshadower: nit: ouf-of-band. otherwise, yes12:06
shadowerlol yes, sorry12:07
dtantsurshadower: https://docs.openstack.org/ironic/latest/admin/inspection.html may help12:07
shadowerdtantsur: thanks!12:07
* dtantsur dives back into the ansible's TLS support12:07
*** hoonetorg has quit IRC12:08
ajyadtantsur: I would expect this mentioned in this section https://docs.openstack.org/ironic/latest/admin/node-deployment.html#deploy-templates as it contains info how to override default deploy steps. It only has section about Compute service.12:10
*** Goneri has joined #openstack-ironic12:11
dtantsurajya: good point12:11
ajyadtantsur: is it documented somewhere else? Then could link from here.12:12
dtantsurajya: not sure, maybe not12:12
openstackgerritRiccardo Pittau proposed openstack/ironic-python-agent-builder master: Build centos8 on centos8  https://review.opendev.org/74690112:14
ajyadtantsur: I can add that small section if that's the valid solution I'm doing - adding deploy template name to trait and instance info manually12:14
ajyaor maybe that needs to added to https://docs.openstack.org/ironic/latest/install/standalone.html and linked12:16
*** thiagop has joined #openstack-ironic12:18
*** hoonetorg has joined #openstack-ironic12:21
jandersokay, lab testing of https://review.opendev.org/#/c/747815/ succeeded, the instances PXE booted correctly12:21
patchbotpatch 747815 - bifrost - Explicitly set permissions on /httpboot contents - 8 patch sets12:21
openstackgerritRiccardo Pittau proposed openstack/ironic-python-agent-builder master: Move zuul config in zuul.d  https://review.opendev.org/74791412:22
jandersdtantsur would you be happy if I apply rpittau recommendation here: https://review.opendev.org/#/c/747815/8/releasenotes/notes/releasenote-341a5eebe6168aea.yaml and merge the two sections into one "fixes" section?12:23
patchbotpatch 747815 - bifrost - Explicitly set permissions on /httpboot contents - 8 patch sets12:23
dtantsurjanders, rpittau, it IS an upgrade impact if operators rely on the files having specific owners or permissions12:23
dtantsurdunno, no hard feelings either way12:23
rpittaummm12:23
jandersrpittau - should I change it or leave it?12:24
rpittauwouldn't that have impact on the backport then ?12:24
rpittaudtantsur: ^12:25
*** Qianbiao has joined #openstack-ironic12:27
dtantsurnot necessary12:27
rpittauok12:28
dtantsurI mean, release notes themselves don't impact backporting. the change does.12:28
rpittauyes, of course, I guess I'm just being too strict here12:29
rpittaujanders: I removed the -112:29
jandersthank you rpittau dtantsur12:30
*** ijw has joined #openstack-ironic12:30
jandersmy test succeeded as well - let's see what Zuul does, hopefully the tests pass without sacrificing a marshmallow :)12:30
rpittaulol12:31
jandersand with this I will call it a night, thanks for all your help and I shall see you tomorrow o/12:31
jandershave a good day all12:31
rpittaubye janders o/12:31
*** ijw has quit IRC12:35
*** hoonetorg has quit IRC12:41
*** mkrai has quit IRC12:45
*** chenhaw has quit IRC12:45
*** hoonetorg has joined #openstack-ironic12:54
openstackgerritDmitry Tantsur proposed openstack/bifrost master: [WIP] TLS support for API services  https://review.opendev.org/74792112:56
openstackgerritDmitry Tantsur proposed openstack/bifrost master: [WIP] TLS support for API services  https://review.opendev.org/74792112:59
* dtantsur expects a lot of red on ^^^12:59
*** bnemec has joined #openstack-ironic13:00
*** vdrok has quit IRC13:02
*** ijw has joined #openstack-ironic13:02
*** trident has joined #openstack-ironic13:02
*** vdrok has joined #openstack-ironic13:02
*** rloo has joined #openstack-ironic13:03
openstackgerritRiccardo Pittau proposed openstack/bifrost master: ansible-lint: fix error 206  https://review.opendev.org/74792513:04
openstackgerritRiccardo Pittau proposed openstack/bifrost master: ansible-lint: fix error 504  https://review.opendev.org/74792513:05
*** ijw has quit IRC13:07
openstackgerritDmitry Tantsur proposed openstack/bifrost master: [WIP] TLS support for API services  https://review.opendev.org/74792113:17
openstackgerritRiccardo Pittau proposed openstack/networking-baremetal master: Add missing keystoneauth1 to requirements  https://review.opendev.org/74793613:30
openstackgerritRiccardo Pittau proposed openstack/networking-baremetal master: Add missing keystoneauth1 and oslo.service to requirements  https://review.opendev.org/74793613:32
TheJuliagood morning13:33
rpittaugood morning TheJulia :)13:33
* TheJulia tries to weigh up13:34
TheJuliawake13:34
TheJuliajeeze13:34
dtantsurmorning TheJulia13:36
openstackgerritDmitry Tantsur proposed openstack/sushy master: Do not log passwords and auth tokens when using SessionService  https://review.opendev.org/74795113:40
dtantsurTheJulia: lovely, isn't it? ^^^13:40
TheJuliadtantsur: too early to add whiskey into my coffee that I'm waking up to13:40
dtantsurlikely13:41
TheJuliaespecially when I also have a board meeting this morning13:42
* TheJulia takes out the corgi overlord13:43
openstackgerritRiccardo Pittau proposed openstack/ironic-python-agent-builder master: [WIP] Use tinycore 11 to build tinyipa  https://review.opendev.org/71164713:47
*** tzumainn has joined #openstack-ironic13:48
guilhermesphi team, just sharing as i raised up the question yesterday about custom python-agent: users were not exporting the ELEMENTS_PATH and they were using dib vm element to create ramdisk images....  that was the trick13:48
openstackgerritJulia Kreger proposed openstack/sushy stable/ussuri: Do not log passwords and auth tokens when using SessionService  https://review.opendev.org/74795613:52
*** weshay is now known as weshay|interview13:54
openstackgerritDmitry Tantsur proposed openstack/bifrost master: [WIP] TLS support for API services  https://review.opendev.org/74792113:54
dtantsurTheJulia: when you cherry-pick unmerged patches via UI, the cherry-picked line is missing13:56
openstackgerritVerification of a change to openstack/bifrost failed: Explicitly set permissions on /httpboot contents  https://review.opendev.org/74781513:58
*** gyee has joined #openstack-ironic14:03
TheJuliagah :(14:04
TheJuliaI can re-pick them later14:04
dtantsurrpioso: a question for you from both iDRAC and the redfish standard standpoint: is it expected for /redfish/v1/SessionService to be itself authenticated?14:05
iurygregorygood morning TheJulia =)14:05
dtantsurrpioso: in theory, we have to discovery the URL to use to create sessions by GET /redfish/v1/SessionService (this is how the standard is supposed to work)14:06
dtantsurbut I see that this endpoint is authenticated on at least some Dell machines14:06
dtantsursushy works around it by guessing /redfish/v1/SessionService/Sessions, but that's against the spirit of the standard14:06
*** ijw has joined #openstack-ironic14:06
*** ijw has quit IRC14:07
*** ijw has joined #openstack-ironic14:07
openstackgerritDmitry Tantsur proposed openstack/sushy master: Less scary warning when GET /redfish/v1/SessionService fails  https://review.opendev.org/74796014:11
dtantsurpatch related ^^^14:11
*** Lucas_Gray has quit IRC14:13
openstackgerritJay Faulkner proposed openstack/ironic-python-agent master: Eventlet should be monkey patched as early as possible  https://review.opendev.org/74677414:14
JayFIf we can freely change lower-constraints.txt and requirements.txt in IPA repo, what does `requirements-check` check for?14:16
Qianbiaodtantsur i thinks yes. To visit session service, you should be authenticated.14:17
dtantsurQianbiao: yeah, but you're using it for authentication :)14:17
dtantsurhow can you be authenticated before authentication?14:17
Qianbiaodtantsur no.14:17
QianbiaoIn ibmc, https://github.com/IamFive/python-ibmcclient/blob/master/ibmc_client/connector.py#L116-L13314:18
QianbiaoPOST /Sessions with your username and password to get a token.14:18
dtantsurQianbiao: how do you know the '%s/Sessions' bit? why not '%s/MyFancySessions'14:18
dtantsur?14:18
QianbiaoIf user want to know which session is current session.14:18
Qianbiaohe can visit /SessionService/sessions to list all session, and one of session will have a flag identify that is yours14:19
TheJuliaDoes the spec even permit an entirely different Session path?14:19
dtantsurTheJulia: I don't think the spec defines *any* paths14:19
dtantsurit explicitly prefers consumers to walk up from the root14:19
TheJuliaeh, true14:20
TheJuliaand the root endpoint is _supposed_ to enumerate endpoints14:20
TheJuliabut not everyone does14:20
dtantsurhence my question to Qianbiao: how do I know that I need /redfish/v1/SessionService/Sessions not /redfish/v1/SessionService/ImBeingFancy/Sessions?14:20
dtantsurI mean, I hope nobody does THAT, but the standard seems to allow it..14:20
Qianbiaoi see. you want to get path from root element?14:21
dtantsurQianbiao: I don't want that (I actually don't like it), but the standard seems to suggest it14:21
dtantsurso I'm curious what the vendors think. I guess you expect the path to be static?14:21
QianbiaoYes14:22
Qianbiaoit is documented we need to visit it that way :)14:22
Qianbiaoibmc provide a path to sessions.14:22
Qianbiao{14:22
Qianbiao    "@odata.context": "/redfish/v1/$metadata#SessionService",14:22
Qianbiao    "@odata.id": "/redfish/v1/SessionService",14:22
Qianbiao    "@odata.type": "#SessionService.v1_0_2.SessionService",14:22
Qianbiao    "Id": "SessionService",14:22
Qianbiao    "Name": "Session Service",14:22
Qianbiao    "SessionTimeout": 600,14:22
Qianbiao    "Sessions": {14:22
Qianbiao        "@odata.id": "/redfish/v1/SessionService/Sessions"14:23
Qianbiao    },14:23
Qianbiao    "Oem": {14:23
Qianbiao        "Huawei": {14:23
Qianbiao            "WebSessionTimeoutMinutes": 480,14:23
Qianbiao            "WebSessionMode": "Shared"14:23
Qianbiao        }14:23
Qianbiao    }14:23
Qianbiao}14:23
rpittauQianbiao: please don't paste long texts here, use a paste service14:23
Qianbiaook sorry.14:23
dtantsurmmm, sure, but to see this document you need authentication, no?14:24
QianbiaoYes, get a token or basic auth14:24
dtantsurso before authentication I have to just know it from the documentation, right?14:24
QianbiaoYou need to get the auth endpoint. in ibmc is POST /Sessions14:24
rpittauJayF: mainly compatibility with global requirements14:25
JayFrpittau: so what does that mean, exactly? I have a patch that needs to modify requirements/lower-constraints14:26
JayFhttps://review.opendev.org/#/c/746774/14:28
patchbotpatch 746774 - ironic-python-agent - Eventlet should be monkey patched as early as poss... - 9 patch sets14:28
rpiosodtantsur: Yes, it is expected that /redfish/v1/SessionService be authenticated.14:31
dtantsurokay, I wonder if we should update sushy to stop even trying to get there before authentication..14:31
rpiosodtantsur: We should :-)14:33
rpiosodtantsur: What's needed is available from the Service Root. Looking ...14:33
Qianbiaodtantsur if the sessions path is the only thing you want to get.14:34
Qianbiaoyou can get it from /redfish/v1 root14:34
*** thiagop has quit IRC14:34
Qianbiaoit has the path to sessions14:34
*** ijw_ has joined #openstack-ironic14:34
dtantsurcould someone paste an example to paste.openstack.org please?14:35
Qianbiaotrying. its very slow to visit paste.openstack.org here14:35
Qianbiaohttp://paste.openstack.org/show/797131/14:35
rpiosodtantsur: If memory serves, the Links > Sessions property can be used to create a session.14:36
dtantsursweeet! is it a standard feature?14:36
Qianbiaoat least ibmc yes.14:37
Qianbiaonot sure about standard14:37
jrollJayF: it means it makes sure lower-constraints are in global-requirements, don't conflict with blacklisted versions, etc afaik14:37
rpiosodtantsur: https://www.dmtf.org/sites/default/files/standards/documents/DSP0266_1.11.0.pdf, p. 15814:38
JayFjroll: for https://review.opendev.org/#/c/746774/ should I only be modifying lower-constraints.txt, and not requirements.txt?14:38
patchbotpatch 746774 - ironic-python-agent - Eventlet should be monkey patched as early as poss... - 9 patch sets14:38
rpioso"Services shall authenticate all write requests to Redfish resources. For example: • POST, except to the Sessions resource collection for authentication"14:38
*** ijw has quit IRC14:38
JayFjroll: the lwoer-constraints.txt are contained within requirements, but I'm pretty sure IPA wouldn't actually run with the older version, so I changed requirements too14:38
rpiosodtantsur: And p. 159 discusses it.14:39
dtantsurrpioso, Qianbiao, many thanks! I've filed https://storyboard.openstack.org/#!/story/2008059 to track it (I won't have time for it myself soon).14:39
jrollJayF: good question. I think requirements.txt has to match global but I'm not 100%14:40
rpiosodtantsur: You're welcome :-)14:40
jrollJayF: also I misspoke on check-requirements, I believe that just checks requirements.txt and not lower-constraints (but maybe both)14:40
dtantsurjroll, JayF, lower-constraints.txt has to match requirements.txt. global-requirements no longer have low caps.14:40
QianbiaoJayF iurygregory I remember i post a bug about eventlet too.14:40
dtantsurjroll: check-requirements checks both14:40
QianbiaoNot sure where it moved to last.14:40
JayFdtantsur: match, how?14:40
JayFdtantsur: e.g. requirements.txt lower cap has to be the same as the lower cap in lower-constraints.txt?14:41
Qianbiaodtantsur you are welcome.14:41
dtantsurJayF: if requirements.txt has foo>=x.y, lower-constraints.txt must have foo===x.y14:41
rpiosodtantsur: And, yes, it's standard. sushy, not so much ;-)14:41
JayFdtantsur: ack, so changing both was correct? Or am I going to have angry global-requirements problems now?14:41
dtantsurrpioso: exactly, hence the ugly warning (and my confusion)14:41
* JayF doesn't understand why IPA needs to deal with any of this given it never co-installs14:41
* jroll wonders what's the point of lower-constraints if it has to match the bottom of requirements.txt14:42
dtantsurJayF: you have to change both. the tricky part will be figuring it which new versions you're pulling by modifying lower-constraints14:42
JayFdtantsur: I already did that14:42
JayFdtantsur: and reflected those changes in lower-c and requirements14:42
dtantsurjroll: the point is to be able to test with lower constraints. just requirements.txt won't give you that, pip is not that smart.14:42
JayFdtantsur: new oslo.service needed new oslo.utils + eventlet, and that's where the chain stopped14:42
QianbiaoJayF https://storyboard.openstack.org/#!/story/200755314:43
Qianbiaoit's 3rd party lib eventlet issue too.14:43
JayFQianbiao: yeah, that code is completely incompatible with eventlet.14:44
JayFQianbiao: my changes are in IPA though, not Ironic, even though that bug is eventlet related14:44
JayFthat's directly, 100% incompatible with eventlet code14:44
JayFwe probably shouldn't be using pyinotify if it requires select.poll()14:44
JayFah, as dtantsur said in your bug, it's a oslo_log bug/incompatibility, you'll have to file it with them14:45
*** rcernin has quit IRC14:45
Qianbiaoyes14:46
*** mkrai has joined #openstack-ironic14:49
rpittauJayF: AFAICS the patch looks ok for the requirements14:50
JayFrpittau: thanks :D I appreciate the sanity check. Last time I had to touch requirements was when you had to get a committee to approve raising a requirement b/c they were shared across all openstack projects14:51
*** chenhaw has joined #openstack-ironic14:51
*** vmud213 has joined #openstack-ironic14:53
rpittauJayF: to prevent too much sanity loss, you can run the requirements-check locally using the tools in the requirements repo, it's what I usually do :)14:53
JayFrpittau: ah, I was trying to figure that out, didn't realize it was in a separate repo14:54
rpittauJayF: https://opendev.org/openstack/requirements14:54
JayFack14:55
*** Qianbiao is now known as qianbiao|afk14:59
*** qianbiao|afk has quit IRC15:04
openstackgerritDmitry Tantsur proposed openstack/bifrost master: [WIP] TLS support for API services  https://review.opendev.org/74792115:06
openstackgerritDmitry Tantsur proposed openstack/bifrost master: [WIP] TLS support for API services  https://review.opendev.org/74792115:15
openstackgerritMerged openstack/bifrost master: Explicitly set permissions on /httpboot contents  https://review.opendev.org/74781515:21
dtantsurjanders: when you're back, could you backport ^^ to stable/ussuri and bugfix/8.3?15:22
dtantsurthere are merge conflicts, like because of lint changes15:22
*** livelace has quit IRC15:26
*** livelace has joined #openstack-ironic15:26
*** belmoreira has quit IRC15:29
dtantsurSSLError(CertificateError("hostname '192.168.122.1' doesn't match '192.168.122.1'",))15:32
dtantsurtechnology suchs15:32
iurygregorywow15:38
openstackgerritDmitry Tantsur proposed openstack/bifrost master: [WIP] TLS support for API services  https://review.opendev.org/74792115:40
*** jtomasek has joined #openstack-ironic15:41
openstackgerritMerged openstack/sushy master: Do not log passwords and auth tokens when using SessionService  https://review.opendev.org/74795115:44
openstackgerritShivanand Tendulker proposed openstack/ironic master: Enforce autospec in ilo tests  https://review.opendev.org/74798315:53
*** sshnaidm is now known as sshnaidm|afk15:59
*** jtomasek has quit IRC16:03
*** rloo has quit IRC16:04
*** weshay|interview is now known as weshay16:04
*** rloo has joined #openstack-ironic16:04
*** lucasagomes has quit IRC16:06
*** rloo has quit IRC16:07
*** rloo has joined #openstack-ironic16:08
openstackgerritDmitry Tantsur proposed openstack/bifrost master: [WIP] TLS support for API services  https://review.opendev.org/74792116:18
*** dtantsur is now known as dtantsur|afk16:19
dtantsur|afko/16:19
*** rloo has quit IRC16:25
*** rloo has joined #openstack-ironic16:25
*** k_mouza has quit IRC16:26
*** bnemec has quit IRC16:30
*** bnemec has joined #openstack-ironic16:35
*** noama has quit IRC16:35
*** rh-jelabarre has quit IRC16:43
*** rh-jelabarre has joined #openstack-ironic16:43
openstackgerritvinay kumar muddu proposed openstack/ironic master: [WIP]: Adds ilo-uefi-https boot interface to ilo5  https://review.opendev.org/74550116:44
JayFCan anyone offer insight in troubleshooting the metalsmith-integration-ipa-src job?16:46
JayFzuul is indicating a failure but I'm having trouble even seeing where/how it failed in the logs16:47
*** vmud213 has quit IRC16:49
TheJuliaJayF: got a link to a job log?16:51
*** lmcgann has joined #openstack-ironic16:52
JayFhttps://bb909fa5d52a05ca950d-f24a7834eba09db97966c05c7e428413.ssl.cf2.rackcdn.com/746774/9/check/metalsmith-integration-ipa-src/cbdd365/16:52
JayFI think I found something, where ansible said failed to ssh into the instance16:52
TheJuliahmmmm16:53
TheJuliayeah16:53
JayFI don't know what "the instance" is in this case? The actual test node? The BM node deployed into?16:53
TheJuliahttps://bb909fa5d52a05ca950d-f24a7834eba09db97966c05c7e428413.ssl.cf2.rackcdn.com/746774/9/check/metalsmith-integration-ipa-src/cbdd365/controller/ironic-bm-logs/node-0_console.log16:53
TheJuliayeah, the test node16:54
* TheJulia wonders what is causing that16:54
JayFIt's hard to imagine my change could cause that kind of failure, especially when it is succeeding (so far) in the other tests16:55
JayF(only one still running is the inspector tempest tests)16:55
JayFI did notice that metalsmith was flipped to direct deploy for CI yesterday16:56
JayFHard to imagine that happening in such a way to succeed CI for that commit but fail for ipa-src jobs16:56
lmcgannHello, I am an engineer from the red hat research team. I am working to integrate Keylime into ironic. Would anybody be able to point me to any resources where I could begin to look into how this would be done.16:56
JayFI don't know what keylime is, but our API documentation is here https://docs.openstack.org/api-ref/baremetal/16:57
*** thiagop has joined #openstack-ironic16:58
TheJuliathe logs don't seem to jive either16:59
TheJuliahmm16:59
TheJuliao/ lmcgann16:59
JayFYeah; I mean the only way IPA could cause that failure would be if it didn't complete writing the image before returning success to Ironic17:00
JayFwhich seems borderline-impossible17:00
lmcgannmy bad https://keylime.dev/17:00
TheJulialmcgann: define integrate is likely a good start. larsks had a initial proposal of wrap ironic's launch by using keylime to start ironic, but then the downside of that would be is that we would never identify failed boots or failed hardware, things would just hang for operators introducing another reason to have to look at the console17:00
lmcgannI don't quite know either. I am new to both of these projects and am trying to get my bearings right now17:01
TheJulialmcgann: ahh, welcome then!17:01
openstackgerritMerged openstack/sushy stable/ussuri: Do not log passwords and auth tokens when using SessionService  https://review.opendev.org/74795617:02
TheJuliaJayF: was this failing before metalsmith switched to direct?17:02
JayFmetalsmith job succeeded on this patch 8/2217:03
patchbotNo data found for patch 817:03
JayFwhich I think was pre the direct change17:03
TheJuliaJayF: hmmmmmmm17:04
JayF(and 8/23, it seems)17:04
TheJulialmcgann: well, how can we best help provide you bearings ?17:04
lmcgannI don't even know what I don't know yet :) I think I just need a more fundamental understanding of ironic and keylime to begin asking the right questions.17:06
JayFPerhaps starting with reading the OpenStack contributor docs, going through that setup, and getting Ironic setup in devstack may help you learn the moving parts17:06
*** mkrai has quit IRC17:07
lmcgannIs this something that has any work done for it already?17:08
lmcgannI may have jumped the gun and came here a bit early, I apologize17:08
JayFSaying hello is always welcome :)17:10
JayFTheJulia: My hunch is to recheck it for that job failure, would you disagree?17:10
TheJulialmcgann: I wrote a security spec a while back that made not traction that might be an integraiton point, let me find you that link17:11
TheJulialmcgann: no, your fine :)17:11
TheJuliaJayF:  yeah, I'd give that a try17:11
TheJuliaI'm kind of at a loss why the job failed, tbh17:11
TheJuliawell17:11
TheJuliaI know why, but not how it got to that state17:11
TheJulialmcgann: give me a minute to finish cooking a snack and I'll dig up that link and send it on over17:11
JayFthe "why" being "bad OS on disk"?17:11
JayFor did you get something further than that?17:12
lmcgannno rush17:12
*** derekh has quit IRC17:18
TheJuliaJayF: maybe17:21
TheJuliathe incontinuity between the the logs and the results is remarkable though17:21
TheJuliaincongruity17:21
TheJulialmcgann: so, https://review.opendev.org/#/c/576718/17:22
patchbotpatch 576718 - ironic-specs - Add security interface spec - 3 patch sets17:22
TheJuliawhich amazingly enough had +1s17:22
TheJulialmcgann: would it be helpful for me to kind of walk through how ironic sees itself in the universe and how it is leveraged?17:22
TheJuliahmm... new dev vm seems... frozen :(17:23
openstackgerritVishal Manchanda proposed openstack/ironic-ui master: [goal] Migrate testing to ubuntu focal  https://review.opendev.org/74470817:23
lmcgannTheJulia: thank you. I have a meeting right now but I will look at this in a bit17:27
TheJulialmcgann: Okay. I'm in us-pacific if none of your cohorts have mentioned it, and I am meeting free the rest of the day aside from a inspector checking out some electrical work that was done at my place between 1-2 this afternoon17:28
openstackgerritMerged openstack/ironic stable/ussuri: Ansible deploy - Ignore invalid devices  https://review.opendev.org/74757617:32
*** derekh has joined #openstack-ironic17:33
*** dsneddon has joined #openstack-ironic17:36
*** bnemec has quit IRC17:50
*** derekh has quit IRC17:52
*** bnemec has joined #openstack-ironic17:53
*** k_mouza has joined #openstack-ironic17:53
*** k_mouza has quit IRC18:02
TheJulia*sigh*18:11
ajyaTheJulia: a quick question, did you have a chance to look at proposed solution for storing configuration data securely for import/export configuration steps? Would it be possible to get high level OK/NOK?18:14
* TheJulia grumbles about queens branch18:14
TheJuliaajya: I have not had time to get back to that spec. I did see chatter about a translation table to link to files on disk which is worrisome and also doesn't really scale. I guess I don't understand why we're not using other services and storing pointers/references to the files, or maybe the conundrum is where we have the dividing line18:16
openstackgerritAija Jaunteva proposed openstack/ironic-specs master: [WIP] System configuration within whole clean or deploy step  https://review.opendev.org/74072118:20
ajyaTheJulia: storing pointers/references where?18:21
TheJuliajust chatter I saw in irc18:21
TheJuliawell18:22
ajyaidea being that table link are the pointers. The files themselves are stored externally18:22
TheJuliapointers to something in glance that the user supplied18:22
TheJulialocal file storage is not a great idea, and is actually unusable in the metal3 case18:22
TheJuliayeah18:22
openstackgerritRuby Loo proposed openstack/ironic master: driver_internal_info in provision notifications  https://review.opendev.org/74799618:22
ajyaTheJulia: initial version of that was taken from virtual media boot, but, ok, virtual media boot has different requirements and users don't create/touch those files, so this wasn't good fit18:25
ajyaIsn't glance only for images? Not custom files?18:26
* TheJulia the files for virtual media boot get rebuilt18:26
TheJuliaerr18:26
TheJuliathe files for virtual media get/can be rebuilt18:26
TheJuliaconfiguration at a point in time is just that18:26
TheJuliaSo I'm not entirely sure, and we ideally don't want to hardcode something on only using glance, so either in a central database and be accessible/downloadable, or the client's responsibility becomes to handle the push/pull of the file18:28
* TheJulia does a got py2 unit tests working dance 18:28
ajyaTheJulia: is there similar functionality already somewhere that I can take a look at?18:36
openstackgerritJulia Kreger proposed openstack/ironic stable/queens: Fix for failure in cleaning  https://review.opendev.org/74728818:37
TheJuliain which regards?18:37
TheJuliaor what specifically? I ask because that is a very broad question18:38
TheJuliarealistically, how large are the files we're talking about?18:38
ajyato store custom user files securely18:38
ajyafor idrac could be 500KB max, let's say 1MB18:38
ajyato add some buffer18:38
TheJuliawhy don't we just make a database table that stores the file blobs in a field?18:39
TheJuliathat allows the conductor to survive failure conditions18:39
ajyaif that's acceptable, I don't mind :)18:39
TheJuliaif an API user can download the file, then metal3 migh tbe able to support it. Keep in mind in the metal3 case their mysql is ephemeral18:39
TheJuliait is kind of what we do with configdrive18:40
ajyaok, I'll look into it18:40
TheJuliajust as a separate table would be ideal since it keeps things cleanly separated18:40
ajyathen it could be new DB table and API to List, Create, Update, Delete that data?18:40
TheJulialikely, it is fine if there are reasonable restrictions around that18:41
ajyarestrictions based on owner?18:41
TheJuliaowner/project could be a concern, y es18:41
TheJuliayes18:41
TheJuliapossibly, but I was thinking more "does it make sense to permit an API consumer to update it?18:42
TheJuliaor update an etry18:42
TheJuliaor is it upload/download and list only18:42
TheJuliaI guess that comes down to how would an API user use it18:42
openstackgerritJulia Kreger proposed openstack/ironic stable/queens: Retries and timeout for IPA command  https://review.opendev.org/74727118:43
TheJuliaJayF: somehow I lost an underscore, but after fighting a centos7 vm today, I finally have an environment where I can run the unit tests locally \o/18:44
ajyaok, I'll detail this in the spec and then can discuss if some improvements necessary. Thanks TheJulia18:44
TheJuliaajya: awesome, thanks!18:44
TheJuliasorry to be so troublesome, there are just many considerations to keep in mind18:44
ajyano worries, learned something new18:45
*** sri_ has quit IRC18:48
*** sri_ has joined #openstack-ironic18:49
*** pas-ha has quit IRC18:50
*** ildikov has quit IRC18:50
*** ildikov has joined #openstack-ironic18:53
*** pas-ha has joined #openstack-ironic18:53
JayFTheJulia: metalsmith failed in an identical way.18:57
JayFTheJulia: suggestions for next steps? I'm tempted to see if the CI passes on an essentially noop change18:57
* JayF suspects the change-metalsmith-to-direct change is the breaker18:57
* iurygregory hides because he put +2 on the change18:59
openstackgerritJay Faulkner proposed openstack/ironic-python-agent master: DO NOT MERGE: testing metalsmith job  https://review.opendev.org/74801518:59
JayFeh, tbh it's kinda messed up if it's only one-way gated18:59
JayFbut we'll see, my change is eventlet related, and I don't disallow the possibility of crazy crap happening, so I'm just running this to validate19:00
iurygregoryyou could also test the metalsmith on ipa adding a job and updating the config for it19:01
iurygregoryI can provide guidance if you want to set a job to iscsi to see both details19:01
iurygregoryresults*19:01
JayFTheJulia: interesting. in one of the failed metalsmith jobs, it looks like the node is rebooted while it's downloading image: https://zuul.opendev.org/t/openstack/build/cbdd365ed34649b68bce9aa0a9634196/log/controller/ironic-bm-logs/node-0_no_ansi_2020-08-25-15:28:35.log19:10
TheJuliaJayF: that makes more sense :\19:12
JayFbut how is it possible that's happening?19:12
JayFthat itself does not make sesne19:12
JayF*sense19:12
JayFunless a deploy is getitng cancelled halfway or something19:12
JayFI am not familiar with metalsmith at all, I don't even know what it does, but if it was randomly rebooting nodes that seems a little nutty19:13
JayFand bluntly it's hard to imagine my change causing this behavior, and not *also* seeing failures in the other integration jobs19:14
JayFI'm tempted to just completely punt on that until I see if metalsmith fails on my noop change19:18
JayFbut even if it doesn't; I'm not sure I can ID what's different about the metalsmith job to cause it to fail with my changes19:18
TheJuliaYeah, I'm mentally at the same place. Kind of confused why and not sure what exactly is occuring19:24
JayFI mean, changing eventlet things + causing $weirdStuff to happen isn't a  hard set of dots to connect.19:25
JayFI just have no  idea whatsoever what'd be different about the metalsmith job.19:25
JayFI don't even know what metalsmith /does/.19:25
TheJuliasimple scheduling/node matching for deployment basically19:26
jrollmetalsmith is like nova but if it was made for bare metal and ran on the user machine19:26
JayFwell right now my19:26
JayF*their CI is breaking me, so I hate it /s19:26
TheJulialol19:26
JayFlol19:26
iurygregorypoor JayF =(19:27
TheJulialets see what the noop change says19:27
*** ijw_ has quit IRC19:27
JayFiurygregory: tbh I only find it this obnoxious because I didn't realize how dusty my upstream-ci-troubleshooting knowledge had become in 2-3  years away19:27
*** ijw has joined #openstack-ironic19:28
iurygregoryJayF, one advice I can give you... don't look at grenade jobs=)19:28
JayFthat is one thing that has /not/ changed over the years19:29
JayFyou just have to make sure to get really quiet anytime someone talks about upgrade testing, to avoid accidentally volunteering yourself :P19:29
iurygregoryhehehe well grenade works <319:29
iurygregorybut don't ask about multinode =D19:29
jrollTIL page up/down doesn't work on these zuul logs :|19:30
iurygregorythis would be a conversation where you would need some alcohol19:30
* TheJulia looks at clock, and determines it is too early for that...19:31
TheJuliaat least, for me19:31
iurygregoryhehe19:31
JayFI hvae always thought the worst jobs in tech invovled CI, QE, or ops19:31
JayFlittle control, high visibility, high crunch19:31
iurygregoryhehehe19:32
*** ijw has quit IRC19:32
* TheJulia suspects tonight is a margharita night19:32
*** ijw has joined #openstack-ironic19:34
openstackgerritJulia Kreger proposed openstack/ironic-python-agent master: Update the cache if we don't have a root device hint  https://review.opendev.org/74707219:34
*** ijw has quit IRC19:39
clarkbjroll: its a bug with the patternfly 4 upgrade19:40
jrollgotcha19:41
clarkbthere are a couple different hacks to fix it proposed but I think people are struggling with which is the least hacky fix (or maybe one landed and we just have to restart the container /me double checks)19:41
jrollthanks. I'll take reporting that off my list :)19:41
clarkbjroll: it has to do with how the error window fly out thing grabs "focus" and then never gives it back aiui19:41
clarkbhttps://review.opendev.org/#/c/743917/ oh that has some new info in it and it is navbar not drawer related19:43
patchbotpatch 743917 - zuul/zuul - PF4: Use a ref to focus main content on initial pa... - 2 patch sets19:43
larsksTheJulia: do you know who's been working with ironic in the context of the openshift baremetal installer?20:00
*** ijw has joined #openstack-ironic20:06
*** JamesBenson has quit IRC20:10
*** ijw has quit IRC20:11
*** k_mouza has joined #openstack-ironic20:13
*** janders4 has joined #openstack-ironic20:18
*** k_mouza has quit IRC20:18
*** janders has quit IRC20:19
*** janders4 is now known as janders20:19
*** Lucas_Gray has joined #openstack-ironic20:21
*** zaneb has quit IRC20:21
JayFTheJulia: metalsmith job passes on a noop change :C20:24
*** thiagop has quit IRC20:32
*** thiagop has joined #openstack-ironic20:36
*** ijw has joined #openstack-ironic20:37
TheJulialarsks: a number of people, is there a specific area your looking at that I can point you towards?20:38
TheJuliaJayF: got a link to the logs?20:39
larsksTheJulia: maybe! It looks like inspection is running multiple times, resulting in the installer failing ("Port ac:1f:6b:f5:3e:f2 already exists...").20:39
JayFhttps://56506052d281c5f34ae9-d0226936c9cadcaed5032c3f3c093f07.ssl.cf5.rackcdn.com/748015/1/check/metalsmith-integration-ipa-src/0926c27/ is the passing one20:40
larsksWondering who might be familiar with the orchestration of things at this stage of the installer.20:40
JayFI'm digging for differences20:40
JayFthey're both rackcdn, so "CI shenanigans based on datacenter/provider" seems unlikely20:40
JayFit's using tinyipa, as are many other jobs, so "not building ipa the same way" seems unlikely20:40
TheJulialarsks: so that uses a mode called fast track so it can go through discovery and there is explicit introspection in certian cases/versions20:41
JayFI'm afraid it may be actually exposing a bug, but without knowing if the metalsmith job is doing something notably different, I can't really isolate it20:41
JayFhttps://zuul.opendev.org/t/openstack/build/dd4067f4fa5344c6ac0c5c47d4ec6f88 is a failing example; the most recent one20:41
larsksTheJulia: Since it's starting with a an empty database (ironic runs in the "bootstrap vm" which is ephemeral and exists only for the duration of the installer), an error like this seems to be a symptom of something else going wrong earlier in the install.20:42
*** ijw has quit IRC20:42
TheJulialarsks: where exactly are you seeing the error and what are you asking it to do in terms of the deployment?20:43
*** ijw has joined #openstack-ironic20:43
*** lmcgann has quit IRC20:43
larsksTheJulia: the error is cropping up while running a baremetal install. I'm not asking it to do anything :). I'm just trying to figure out if this is something someone has seen before and might know what's causing it. That's why I'm hoping to find someone who's worked on the use of ironic by the installer...20:44
TheJuliaso, your likely best bet is someone on the openshift baremetal installer team20:45
TheJuliadtantsur|afk might be a good person to talk to when he is around tomorrow20:45
larsksAwesome, thanks.20:46
TheJuliai think I've seen it, but there are version specific changes between when we started on that path and now20:46
JayFTheJulia: hmm, AFAICT, the metalsmith job is using a CentOS7 image (for the image), whereas all of our other jobs are using cirros20:50
JayFthat's the only meaningful difference I can identify20:50
TheJuliahmmm20:51
JayFalso IRONIC_VM_COUNT=1 instead of IRONIC_VM_COUNT=2, but I don't believe that should matter20:52
JayFalthough I'm surprised at that difference20:52
TheJulianope... redfish or ipmi?20:52
JayFipmi20:53
JayFI have a hunch I'm going to dig: if the http[] streaming URL for the centos image is https, while the cirros one is http20:53
JayFthat'd be a meaningful difference that could be impacted by my changes20:53
JayFnah, I don't think so, because they're both coming from glance20:54
TheJuliayou know, I did notice the metalsmith job is very much https20:54
JayF> 2020-08-25 18:16:41.411 595 INFO ironic_python_agent.extensions.standby [-] Attempting to download image from http://10.209.64.38:3928/agent_images/052857ee-027c-4eb9-a23e-2407ca75a9f5[00m20:56
JayFso it's not downloading the image http20:56
JayF> ipa-api-url=https://10.209.64.38/baremetal20:56
JayFironic is https though, checking a passing job to see if it's https or http20:57
JayF> ipa-api-url=https://10.176.194.171/baremetal passing job has an https ironic as well20:58
JayF(ipa-tempest-bios-ipmi-direct-src job passing on my change)20:58
*** thiagop has quit IRC21:09
JayFTheJulia: either we're missing logs from the "broken" agent, or it's freezing solid when asked to download the image21:10
JayFI just can't nail down *what is different* to figure out why it's freezing up there21:11
JayF(versus the other jobs)21:11
TheJuliahmmm21:11
TheJuliafreezing solid would explain some of it21:11
JayFI mean, that's the only explanation, and it's a "common" failure mode for eventlet stuff21:12
TheJulia:(21:15
JayFthe size of the image has to be the answer, right?21:15
JayFngl, I'm tempted to throw an `os=False` into the eventlet monkey patch, since that's what's in Ironic21:16
JayFI just wish I had an idea of /why/21:16
openstackgerritSteve Baker proposed openstack/metalsmith master: Capture metalsmith python logging  https://review.opendev.org/74803121:18
TheJuliastevebaker: o/21:18
stevebakerTheJulia: hey21:18
TheJuliaJayF: might work21:18
TheJuliaworth a try!21:18
JayFI mean, don't like making changes without understanding what's going on...21:19
openstackgerritJay Faulkner proposed openstack/ironic-python-agent master: Eventlet should be monkey patched as early as possible  https://review.opendev.org/74677421:23
TheJuliaSame :(21:24
JayFlooking at what eventlet patches, it's all the os.read/fdread etc stuff which would be used in our ImageDownloader class21:25
JayFwhich is where the deadlock appears to happen21:25
JayFso I gave it a shot21:25
openstackgerritMerged openstack/ironic master: Decouple the ISO creation logic from redfish  https://review.opendev.org/73917421:34
openstackgerritSteve Baker proposed openstack/metalsmith master: Capture metalsmith python logging  https://review.opendev.org/74803121:40
openstackgerritSteve Baker proposed openstack/metalsmith master: Document metalsmith_instances  https://review.opendev.org/73813121:40
openstackgerritSteve Baker proposed openstack/metalsmith master: metalsmith_deployment role switch to metalsmith_instances  https://review.opendev.org/73788821:40
*** rcernin has joined #openstack-ironic22:00
*** rcernin has quit IRC22:01
*** rcernin has joined #openstack-ironic22:02
*** JamesBenson has joined #openstack-ironic22:03
*** bnemec has quit IRC22:14
*** JamesBenson has quit IRC22:17
TheJuliaJayF: hmm...22:17
JayFdid you find something compelling?22:18
*** rh-jelabarre has quit IRC22:21
*** rh-jelabarre has joined #openstack-ironic22:21
*** zaneb has joined #openstack-ironic22:22
jandersgood morning Ironic o/22:26
*** livelace has quit IRC22:36
TheJuliaJayF: just interesting that it blows up there22:36
TheJuliaI'm working on yet another uefi bootloader fix22:36
JayF"blows up" would be a better failure case22:52
JayF"goes out for a cheeseburger and never returns" is more what we're dealing with :C22:52
TheJuliathat does sound like eventlet sadly22:52
TheJuliaif only ipa could log "MMMM CHEEZBURGR22:53
TheJulia"22:53
JayFI've never cheered more for a job to fail than when I did the clean test22:53
JayFlol22:53
JayFhmm. You know what, I was about to say, the monkey_patch didn't break it, because it passed before I updated requirements/constraints22:53
JayFBUT that was also simultaneous with the change to it doing direct22:54
JayFso that metalsmith job might have saved us a metric crapton of WTF-troubleshooting when victoria got released22:54
JayFand people started using IPA with real-world sized images22:54
TheJuliayup22:54
JayFI hope I'm about to get to the bottom of it though. Frankly, enabling SSL causing the whole thing to cease up to me is a sign we had some other, preexisting bug in IPA22:55
JayFand hopefully this is making progress to fixing it.22:55
*** JamesBenson has joined #openstack-ironic22:56
TheJuliawell, we're trying to stream through it with the read/write on raw transfers which is what I believe the metalsmith ends up running22:57
JayFwhich is why I'm hoping the os=False has a positive impact22:58
TheJuliathe cirros image might not be, or as you suggested, it just may be the size22:58
JayFit's been about 1:30, and I'm about to turn into a pumpkin, so I'm going to check zuul status to see if there's a result on that job22:58
TheJuliaanything on the current zuul job?22:58
JayFhttps://7a08a3030f2403a359fd-4034ad4bc806fe95a8503cbe82cd73fb.ssl.cf2.rackcdn.com/746774/10/check/metalsmith-integration-ipa-src/894a516/ fao;ire22:58
JayF*failure22:58
JayFappears to still deadlock in the same location22:59
JayFI'm tempted to go the other direction -- test locally to see what `module=True` I need to pass to monkey patch to make SSL work, and just go that way22:59
TheJulia:(22:59
JayFbut I think that's just dodging the bug instead of solving it22:59
TheJuliasocket, realistically22:59
TheJuliaI hope it is not socket that is causing this22:59
JayFsocket is what I'm going to have to patch to make ssl work, almost certainly23:00
TheJuliayeah23:00
*** JamesBenson has quit IRC23:01
clarkbis IPA doing any other work during the image download? could it just be synchronous?23:02
JayFIPA is always running a heartbeater in the background23:02
JayFregardless of what else it's doing, it heartbeats every "n" seconds23:03
JayFto rewind all the way back to the original symptom I'm trying to address: when I enable use_ssl in the oslo.service wsgi server (like is done here: https://review.opendev.org/#/c/747193/ ) the API does not send a response.23:03
patchbotpatch 747193 - ironic-python-agent - If listen_tls is true, enable TLS on wsgi server - 5 patch sets23:03
*** tosky has quit IRC23:04
JayFI found that putting an `eventlet.sleep(0)` deep in the eventlet wsgi server code (I could find exactly what line, if you're interested), fixes that behavior23:04
JayFalso, monkey_patching earlier in IPA, as I do here https://review.opendev.org/#/c/746774/, also resolved that symptom -- but appears to have a giant amount of knock-on effects upon testing.23:04
patchbotpatch 746774 - ironic-python-agent - Eventlet should be monkey patched as early as poss... - 10 patch sets23:04
JayFtl;dr: All I wanted was a little SSL, and I'm in eventlet hell23:05
clarkbI'm mostly asking because download 500MB image isn't going to go any faster because you're using greenthreads and not "real" threads23:05
JayFthe main reason it's streamed is due to memory pressure, not for speed23:05
clarkbbut if other stuff is going on then untangling a synchronous thread from the other stuff could be pain23:06
TheJuliayeah, people have a desire to try and stream gigabytes through megabytes of ram23:06
TheJuliathe heartbeat uses select...  I wonder if that is where thigns are deadlocking23:06
JayFthat's my suspicion, but I'm not sure how else to achieve our goals there without using a select23:07
JayFand honestly, a select.select(timeout) should *not* be deadlocking, should it? with an eventlet-patched select?23:07
JayFI guess I should read that code.23:07
TheJuliayeah, I should have brain cells that I can help look at this tomorrow23:08
JayFMaybe even see how a naive heartbeater (using time-based heartbeats, like we used to) would do under test23:08
TheJuliaI did a bunch of research today on the image elements being used so I should be able to speak authoratively to my other headache tomorrow23:08
JayFthat's obviously not the solution, but it'd be a clear pointer to what is deadlocking23:08
TheJuliayeah23:10
openstackgerritJulia Kreger proposed openstack/ironic-python-agent master: WIP: Support partition image efi contents  https://review.opendev.org/74804923:15
TheJuliaiurygregory: Please take a look at ^^^ tomorrow for me. I basically think we need to be able to support partition images with efi contents embedded23:15
JayFI wonder if the solution to this is more along the lines of, still use a select to trigger heartbeats, but don't have it on such a large timeout, and measure time for the periodic heartbeats some other way23:16
JayFe.g. a secondary thread which feeds a forced_heartbeat in on [interval]23:16
JayFIDK; I'm going to turn into a pumpkin now, maybe the solution will come to me in a dream23:16
TheJuliaJayF: pumpkin++23:16
TheJuliagoodnight!23:16
TheJuliaspeaking of becoming a pumpkin, I think I'm going to do the same23:17
JayFhave a good one o/23:17
TheJuliayou too!23:18
*** JamesBenson has joined #openstack-ironic23:37
*** JamesBenson has quit IRC23:42
*** uzumaki has joined #openstack-ironic23:46

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!