*** yaawang has quit IRC | 00:26 | |
*** yaawang has joined #openstack-ironic | 00:26 | |
*** diurnalist has joined #openstack-ironic | 00:43 | |
*** diurnalist has quit IRC | 00:47 | |
*** ricolin has joined #openstack-ironic | 00:57 | |
*** dsneddon has quit IRC | 01:11 | |
*** dsneddon has joined #openstack-ironic | 01:12 | |
*** yaawang has quit IRC | 01:15 | |
*** yaawang has joined #openstack-ironic | 01:16 | |
*** Lucas_Gray has quit IRC | 01:48 | |
*** yaawang has quit IRC | 02:45 | |
*** yaawang has joined #openstack-ironic | 02:46 | |
*** yaawang has quit IRC | 03:31 | |
*** yaawang has joined #openstack-ironic | 03:32 | |
*** diurnalist has joined #openstack-ironic | 03:43 | |
*** diurnalist has quit IRC | 03:48 | |
*** diurnalist has joined #openstack-ironic | 03:48 | |
*** ociuhandu has joined #openstack-ironic | 04:10 | |
*** ociuhandu has quit IRC | 04:14 | |
*** abdysn has joined #openstack-ironic | 05:11 | |
*** rcernin has quit IRC | 05:14 | |
*** rcernin has joined #openstack-ironic | 05:39 | |
*** diurnalist has quit IRC | 05:41 | |
*** rcernin has quit IRC | 05:47 | |
*** rcernin has joined #openstack-ironic | 05:48 | |
arne_wiebalck | Good morning, ironic! | 06:05 |
---|---|---|
*** sshnaidm|off is now known as sshnaidm|ruck | 06:17 | |
rpittau | good morning ironic! o/ | 07:21 |
*** dtantsur|afk is now known as dtantsur | 07:25 | |
dtantsur | morning ironic | 07:26 |
dtantsur | folks, could I get some reviews on these easy patches https://review.opendev.org/#/c/739216/ https://review.opendev.org/#/c/739192/ https://review.opendev.org/#/c/739005/ | 07:28 |
patchbot | patch 739216 - ironic - Software RAID: don't try to set local_gb to MAX - 2 patch sets | 07:28 |
patchbot | patch 739192 - ironic - Clean up nodes in DELETING on conductor restart - 1 patch set | 07:28 |
patchbot | patch 739005 - ironic-python-agent - Fix serializing ironic-lib exceptions - 1 patch set | 07:28 |
dtantsur | also https://review.opendev.org/#/c/739178/ and https://review.opendev.org/#/c/739120/ | 07:28 |
patchbot | patch 739178 - ironic-python-agent - Switch the inspector job to tinyIPA until DIB is f... - 1 patch set | 07:28 |
patchbot | patch 739120 - ironic-python-agent - Limit Inspection->Lookup->Heartbeat lag - 3 patch sets | 07:28 |
dtantsur | these are all fixes for reported bugs that should likely get into the release | 07:28 |
rpittau | dtantsur: I'nm going through morning patches screen, I'm almost there :) | 07:29 |
dtantsur | sweet, thanks! | 07:29 |
dtantsur | prometheanfire: thank you, I'll take care of it | 07:31 |
openstackgerrit | Riccardo Pittau proposed openstack/ironic master: Use unittest mock instead of 3rd party mock in test_raid https://review.opendev.org/739418 | 07:31 |
rpittau | dtantsur: ^ | 07:31 |
dtantsur | ah | 07:31 |
rpittau | :) | 07:31 |
dtantsur | okay, thanks rpittau | 07:31 |
dtantsur | we need to start aggressively check incoming patches for 'import mock' | 07:32 |
rpittau | yep | 07:32 |
rpittau | if I remember right there should a way to exclude specific imports with flake8 or something like that | 07:32 |
dtantsur | I hope our dependencies will stop pulling mock soon | 07:33 |
dtantsur | I guess that's the case with the jsonpatch update | 07:33 |
rpittau | yeah | 07:33 |
rpittau | checking the other ironic projects to see if we have leftovers | 07:34 |
dtantsur | ++ | 07:40 |
*** Lucas_Gray has joined #openstack-ironic | 07:40 | |
*** dougsz has joined #openstack-ironic | 07:42 | |
prometheanfire | dtantsur: thanks | 07:43 |
dtantsur | FYI folks, the virtual meetup is TODAY, 2pm UTC. Sorry for the late notice. | 07:46 |
rpittau | oh ok | 07:46 |
*** dougsz has quit IRC | 07:47 | |
*** hoonetorg has joined #openstack-ironic | 07:52 | |
*** hjensas has joined #openstack-ironic | 07:53 | |
*** rcernin has quit IRC | 07:57 | |
*** lucasagomes has joined #openstack-ironic | 07:59 | |
*** yaawang has quit IRC | 08:04 | |
*** yaawang has joined #openstack-ironic | 08:05 | |
openstackgerrit | Riccardo Pittau proposed openstack/ironic-lib master: [WIP] Use flake8-tidy-imports to ban specific modules https://review.opendev.org/739425 | 08:08 |
rpittau | dtantsur: something like this might be useful ^ | 08:08 |
dtantsur | neat! I don't think we need it though since this situation should be temporary | 08:14 |
rpittau | ok, it's there just in case :) | 08:15 |
*** ociuhandu has joined #openstack-ironic | 08:30 | |
*** yaawang has quit IRC | 08:34 | |
*** yaawang has joined #openstack-ironic | 08:35 | |
*** livelace has joined #openstack-ironic | 08:37 | |
*** yaawang has quit IRC | 08:40 | |
*** yaawang has joined #openstack-ironic | 08:41 | |
*** k_mouza has joined #openstack-ironic | 08:43 | |
*** bfournie has quit IRC | 08:43 | |
*** persia has quit IRC | 08:44 | |
*** persia has joined #openstack-ironic | 08:45 | |
*** livelace has quit IRC | 08:52 | |
*** derekh has joined #openstack-ironic | 08:55 | |
*** livelace has joined #openstack-ironic | 08:57 | |
*** bfournie has joined #openstack-ironic | 09:01 | |
*** livelace has quit IRC | 09:15 | |
openstackgerrit | Riccardo Pittau proposed openstack/ironic-lib master: Set min version of tox tp 3.2.1 https://review.opendev.org/739436 | 09:15 |
openstackgerrit | Riccardo Pittau proposed openstack/ironic-lib master: Set min version of tox to 3.2.1 https://review.opendev.org/739436 | 09:19 |
openstackgerrit | Merged openstack/ironic master: Fix the error message when reached max number of traits https://review.opendev.org/739299 | 09:25 |
openstackgerrit | Verification of a change to openstack/ironic failed: Software RAID: don't try to set local_gb to MAX https://review.opendev.org/739216 | 09:25 |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic master: Do not put the whole JSON error from the agent in last_error https://review.opendev.org/739439 | 09:31 |
*** ociuhandu has quit IRC | 09:33 | |
*** ociuhandu has joined #openstack-ironic | 09:48 | |
dtantsur | I've found an old bug of mine, and it's some evil magic: https://storyboard.openstack.org/#!/story/2002088 Oo | 09:52 |
rpittau | :D | 09:52 |
*** ociuhandu has quit IRC | 09:52 | |
*** ociuhandu has joined #openstack-ironic | 09:54 | |
openstackgerrit | Riccardo Pittau proposed openstack/ironic master: migrate testing to ubuntu focal https://review.opendev.org/739448 | 09:59 |
openstackgerrit | Riccardo Pittau proposed openstack/ironic master: migrate testing to ubuntu focal https://review.opendev.org/739448 | 10:01 |
dtantsur | mgoddard: hi, do you know if this is done: https://storyboard.openstack.org/#!/story/2003484 ? | 10:07 |
mgoddard | dtantsur: yes, marked complete | 10:08 |
dtantsur | thx | 10:09 |
*** rcernin has joined #openstack-ironic | 10:33 | |
*** tkajinam has quit IRC | 10:37 | |
dtantsur | hi bfournie, have we fixed https://storyboard.openstack.org/#!/story/2005912 in the end? could you update it? | 10:41 |
openstackgerrit | Arne Wiebalck proposed openstack/ironic master: [doc] Describe how to extract an fs UUID from an image https://review.opendev.org/739027 | 10:45 |
*** rcernin has quit IRC | 11:04 | |
dtantsur | TheJulia: hi, do you remember if https://storyboard.openstack.org/#!/story/2005852 is something we've fixed? | 11:05 |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic master: Provide a path to set explicit ipxe bootloaders https://review.opendev.org/728315 | 11:20 |
openstackgerrit | Merged openstack/ironic master: Clean up nodes in DELETING on conductor restart https://review.opendev.org/739192 | 11:30 |
openstackgerrit | Verification of a change to openstack/ironic-inspector failed: Add leader election for periodic sync with ironic https://review.opendev.org/735527 | 11:30 |
openstackgerrit | Merged openstack/ironic master: Use unittest mock instead of 3rd party mock in test_raid https://review.opendev.org/739418 | 11:30 |
dtantsur | TheJulia: also https://storyboard.openstack.org/#!/story/2007699 has a NEEDINFO on you | 11:31 |
*** derekh has quit IRC | 12:03 | |
*** rh-jelabarre has joined #openstack-ironic | 12:06 | |
*** priteau has joined #openstack-ironic | 12:22 | |
*** mrda has quit IRC | 12:26 | |
*** mrda has joined #openstack-ironic | 12:27 | |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic stable/ussuri: Clean up nodes in DELETING on conductor restart https://review.opendev.org/739472 | 12:35 |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic stable/train: Clean up nodes in DELETING on conductor restart https://review.opendev.org/739473 | 12:35 |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic stable/stein: Clean up nodes in DELETING on conductor restart https://review.opendev.org/739474 | 12:36 |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic stable/rocky: Clean up nodes in DELETING on conductor restart https://review.opendev.org/739475 | 12:36 |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic stable/ussuri: Fix the error message when reached max number of traits https://review.opendev.org/739477 | 12:37 |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic stable/train: Fix the error message when reached max number of traits https://review.opendev.org/739478 | 12:37 |
openstackgerrit | Merged openstack/ironic-python-agent master: Switch the inspector job to tinyIPA until DIB is fixed https://review.opendev.org/739178 | 12:43 |
*** Lucas_Gray has quit IRC | 12:43 | |
*** Lucas_Gray has joined #openstack-ironic | 12:47 | |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic master: [WIP] Use native oslo.concurrency execution timeout in ipmitool https://review.opendev.org/738591 | 12:52 |
*** Goneri has joined #openstack-ironic | 12:57 | |
TheJulia | good morning | 12:58 |
rpittau | good morning TheJulia :) | 13:00 |
TheJulia | dtantsur: re 2006852, likely. The conundrum is it is nonstandard of course | 13:00 |
openstackgerrit | Merged openstack/ironic-python-agent-builder master: Build tinyipa on focal https://review.opendev.org/725799 | 13:01 |
TheJulia | dtantsur: ohh, re https://storyboard.openstack.org/#!/story/2007699 I wonder if the rest of the url got stripped | 13:01 |
*** derekh has joined #openstack-ironic | 13:05 | |
TheJulia | dtantsur: out of curiosity, regarding the meetup, was it just the URL you wanted to sync up on? | 13:06 |
dtantsur | TheJulia: yep, URL mostly | 13:06 |
dtantsur | and good mornign | 13:07 |
TheJulia | good morning! | 13:07 |
dtantsur | some ugly fun this Monday: https://github.com/eventlet/eventlet/issues/624 | 13:07 |
dtantsur | (yes, you can guess how fun it is from just the URL) | 13:07 |
TheJulia | https://meetpad.opendev.org/ironic seems like as good as any | 13:08 |
dtantsur | yup, will use it. could you respond to the ML with it? I'm in the middle of eventlet-fighting | 13:08 |
TheJulia | dtantsur: where did you hit this? | 13:09 |
TheJulia | eventlet issue | 13:09 |
TheJulia | sending email in a moment | 13:09 |
dtantsur | TheJulia: everywhere when trying to catch subprocess.TimeoutExpired | 13:09 |
TheJulia | hmm | 13:10 |
TheJulia | in the conductor? | 13:10 |
dtantsur | yup. and oslo.concurrency unit tests.\ | 13:11 |
TheJulia | ugh | 13:11 |
dtantsur | TheJulia: the problem is in https://review.opendev.org/#/c/738591/2/ironic/drivers/modules/ipmitool.py@565 | 13:15 |
patchbot | patch 738591 - ironic - [WIP] Use native oslo.concurrency execution timeou... - 2 patch sets | 13:15 |
dtantsur | this catch does not work :( | 13:15 |
dtantsur | we have the same problem in oslo.concurrency unit tests (I complained on twitter the other day) | 13:15 |
TheJulia | :( | 13:21 |
dtantsur | and this problem seems to only happen in virtual envs \o/ | 13:22 |
TheJulia | fun :( | 13:24 |
openstackgerrit | Merged openstack/ironic master: Software RAID: don't try to set local_gb to MAX https://review.opendev.org/739216 | 13:25 |
TheJulia | Reading the bifrost release notes, looks like we're going to need to release it as bifrost 9 | 13:28 |
rpittau | indeed, there are some major changes | 13:28 |
TheJulia | I approved the release note change | 13:29 |
*** rloo has joined #openstack-ironic | 13:30 | |
TheJulia | rofl, tooz uses hashlib.md5 internally | 13:35 |
TheJulia | dtantsur: I added on to your topic on the call agenda | 13:38 |
openstackgerrit | Merged openstack/bifrost master: Prepare release notes for release 8.2 https://review.opendev.org/739089 | 13:39 |
*** tzumainn has joined #openstack-ironic | 13:40 | |
dtantsur | quite likely | 13:41 |
dtantsur | oh, I need to add bifrost-cli docs.. | 13:41 |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic stable/ussuri: Software RAID: don't try to set local_gb to MAX https://review.opendev.org/739488 | 13:43 |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic stable/train: Software RAID: don't try to set local_gb to MAX https://review.opendev.org/739489 | 13:44 |
dtantsur | TheJulia: could you check https://review.opendev.org/#/c/738408/ please, it clarifies how exactly we release | 13:45 |
patchbot | patch 738408 - ironic-specs - Update to the new release model - 1 patch set | 13:45 |
dtantsur | and https://review.opendev.org/#/c/739081/ is another reno update | 13:46 |
patchbot | patch 739081 - ironic-inspector - Prepare release notes for release 10.2 - 2 patch sets | 13:46 |
openstackgerrit | Riccardo Pittau proposed openstack/ironic master: migrate testing to ubuntu focal https://review.opendev.org/739448 | 13:49 |
TheJulia | approved | 13:51 |
dtantsur | REMINDER: the meetup starts NOW in https://meetpad.opendev.org/ironic | 14:01 |
openstackgerrit | Merged openstack/ironic-specs master: Update to the new release model https://review.opendev.org/738408 | 14:03 |
dtantsur | TheJulia: ^^^ | 14:03 |
*** cdearborn has joined #openstack-ironic | 14:05 | |
*** abdysn has quit IRC | 14:05 | |
dtantsur | cdearborn, mgoddard, you also indicated interest in the meetup ^^ | 14:06 |
cdearborn | dtantsur, thx for the reminder! | 14:08 |
openstackgerrit | Merged openstack/ironic-specs master: New release model: correct the named branches lifetime https://review.opendev.org/738761 | 14:09 |
*** diurnalist has joined #openstack-ironic | 14:14 | |
TheJulia | whee I'm late | 14:17 |
*** bdodd has joined #openstack-ironic | 14:52 | |
*** kaifeng has joined #openstack-ironic | 14:57 | |
*** stendulker has joined #openstack-ironic | 15:00 | |
*** rajinir_ has joined #openstack-ironic | 15:02 | |
*** diurnalist has quit IRC | 15:02 | |
openstackgerrit | Verification of a change to openstack/ironic-inspector failed: Add leader election for periodic sync with ironic https://review.opendev.org/735527 | 15:02 |
*** diurnalist has joined #openstack-ironic | 15:11 | |
*** sshnaidm|ruck is now known as sshnaidm|mtg | 15:24 | |
*** ociuhandu has quit IRC | 15:57 | |
*** lucasagomes has quit IRC | 16:01 | |
openstackgerrit | Riccardo Pittau proposed openstack/ironic-python-agent-builder master: Use tinycore 11 to build tinyipa https://review.opendev.org/711647 | 16:02 |
TheJulia | Anyone else want to take a quick look at https://review.opendev.org/#/c/739120/3 | 16:05 |
patchbot | patch 739120 - ironic-python-agent - Limit Inspection->Lookup->Heartbeat lag - 3 patch sets | 16:05 |
TheJulia | btw dtantsur, I like what you did there! | 16:05 |
dtantsur | cool :) | 16:06 |
dtantsur | would you like to get upset now? I have a bugzilla that upsets me. | 16:06 |
TheJulia | dtantsur: if I can create a doodle before I look at it? | 16:06 |
*** k_mouza has quit IRC | 16:07 | |
dtantsur | you don't even need to look at it :) | 16:07 |
dtantsur | although you'll likely see patches soon | 16:07 |
TheJulia | oh? Now I'm curious! | 16:07 |
dtantsur | https://bugzilla.redhat.com/show_bug.cgi?id=1853302 | 16:08 |
openstack | bugzilla.redhat.com bug 1853302 in Bare Metal Hardware Provisioning "Installation in FIPS mode fails on BareMetal IPI with error: "disabled for FIPS"" [Low,New] - Assigned to dtantsur | 16:08 |
dtantsur | the upset point beings when you think about upgrades and backward compatibility vs backporting | 16:08 |
TheJulia | yup! I already spotted that one | 16:08 |
TheJulia | I mentally hadn't even gotten there though. :( | 16:09 |
dtantsur | I can take care of it, don't worry | 16:09 |
TheJulia | https://doodle.com/poll/kte79im2tz4ape9v | 16:12 |
TheJulia | rpioso: ^^^ | 16:12 |
TheJulia | That is the poll for getting on a call and discussing the matrix. | 16:13 |
*** priteau has quit IRC | 16:14 | |
TheJulia | email sent | 16:15 |
*** Lucas_Gray has quit IRC | 16:20 | |
rpioso | TheJulia: Thank you! Could we loop in fungi? | 16:21 |
*** hjensas has quit IRC | 16:21 | |
TheJulia | fungi: o/ | 16:21 |
dtantsur | TheJulia: I messed with https://review.opendev.org/#/c/728315/ a bit (sorry!) but couldn't make it passing, I think some more options are required (see inline) | 16:21 |
patchbot | patch 728315 - ironic - Provide a path to set explicit ipxe bootloaders - 4 patch sets | 16:21 |
dtantsur | thinking about it, this is something I'd like to see in the release | 16:22 |
* fungi is technically on vacation today, but will take a quick look | 16:22 | |
TheJulia | fungi: tomorrow then, just ping us | 16:22 |
TheJulia | dtantsur: taking a look | 16:22 |
TheJulia | dtantsur: hmm, yeah we do need a separate template | 16:23 |
TheJulia | ugh | 16:23 |
TheJulia | It is all for the better though! I'm not sure it will be able to make the release, then again maybe it might make it if I get it working today | 16:24 |
dtantsur | TheJulia: the separate template thing should be easy to fix though | 16:24 |
*** stendulker has quit IRC | 16:24 | |
fungi | is this "fips mode for openssl" i guess? there's a lot of "fips mode" switches in different software and libraries so i'm missing a bit of context from that bz | 16:25 |
fungi | also fips is far less about security and more about auditability by government agencies, so my familiarity with it is somewhat limited | 16:25 |
dtantsur | fungi: there is a sadness in python: FIPS mode blocks all attempts to use md5 | 16:25 |
dtantsur | even for something that has not relationship to security | 16:25 |
fungi | dtantsur: yeah but "fips mode" in what? does python have a "fips mode"? | 16:26 |
dtantsur | fungi: python uses openssl for crypto primitives, I assume | 16:26 |
fungi | okay, so openssl's "fips mode" got it | 16:26 |
fungi | that's what i was expecting but wasn't 100% sure | 16:26 |
dtantsur | only in Python 3.9 did they introduce a parameter "no, I'm not using it for security" | 16:27 |
*** hjensas has joined #openstack-ironic | 16:27 | |
dtantsur | fungi: (just to be clear) the ping from TheJulia to you was re https://doodle.com/poll/kte79im2tz4ape9v not re FIPS | 16:28 |
stbenjam | Hey all o/ Any chance someone could /lgtm this Metal3 patch to build sushy-tools from git? https://github.com/metal3-io/metal3-dev-env/pull/362 | 16:29 |
dtantsur | stbenjam: I doubt anybody here has ACL | 16:29 |
dtantsur | stbenjam: also 0.11.0 is already out, maybe use it? | 16:29 |
TheJulia | fungi: yeah, I was hoping you'd just ping us tomorrow and go abck to your vacation :) | 16:30 |
fungi | eh, i went down the rabbit hole. looks like you want tooz to have a fips-compliant hash function for its hash ring (it's using md5 right now which is not fips-compliant) | 16:31 |
TheJulia | stbenjam: yeah, steve/doug/russel seem to be your folks you need | 16:31 |
TheJulia | yeah, FIPS itself is a rabbit hole | 16:32 |
dtantsur | fungi: yep. the only problematic thing, any changes I can think of wouldn't be backportable | 16:32 |
fungi | i doubt you're going to be able to flag that you're only using it for non-security purposes because openssl is just going to hard block access to the function calls | 16:32 |
fungi | (in fips mode) | 16:32 |
dtantsur | fungi: https://github.com/python/cpython/commit/7cad53e6b084435a220e6604010f1fa5778bd0b1 | 16:34 |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic master: Use native oslo.concurrency execution timeout in ipmitool https://review.opendev.org/738591 | 16:36 |
dtantsur | bfournie: FYI ^^ | 16:37 |
fungi | this is not encouraging either https://bugs.python.org/issue40479 | 16:40 |
fungi | "OpenSSL 3.0.0-alpha1 was releases about a week ago. OpenSSL 1.1.x APIs are still functional. However some APIs have been deprecated and FIPS (usedforsecurity flag) is no longer functional. | 16:40 |
fungi | " | 16:40 |
stbenjam | TheJulia: dtantsur: Ah lgtm is usually for anyone in the org but looked like Metal3 changed it to explicit reviewers. Is 0.11 in PIP then? I can just not build from git? | 16:41 |
TheJulia | fungi: UGH | 16:41 |
dtantsur | fungi: ouch | 16:42 |
dtantsur | stbenjam: 0.11.0 is in pypi already, yes. there is nothing wrong with git, but a version is a bit nicer (and I think the release also brings support for non-IDE CDROM) | 16:42 |
fungi | https://bugs.python.org/issue9216 also has some info on the ongoing evolution of fips mode support in cpython | 16:43 |
stbenjam | dtantsur: Right, the whole reason I want the new release is virtual media :) | 16:45 |
dtantsur | stbenjam: yeah, 0.11.0 contains the 2 patches you need :) | 16:46 |
dtantsur | fungi: it's a rabbit hole indeed :( | 16:46 |
fungi | dtantsur: the "obvious" solution is to get libs you're using to expose functionality allowing you to choose hash functions so you can use one which will still work regardless of whether the system is in fips mode, though 1. that's probably not in-place upgradeable for systems coordinating with different hash algorithms and 2. the configuration options would likely not be backportable | 16:47 |
openstackgerrit | Merged openstack/ironic-python-agent master: Fix serializing ironic-lib exceptions https://review.opendev.org/739005 | 16:47 |
openstackgerrit | Merged openstack/ironic-inspector master: Prepare release notes for release 10.2 https://review.opendev.org/739081 | 16:48 |
openstackgerrit | Merged openstack/ironic stable/train: Clean up nodes in DELETING on conductor restart https://review.opendev.org/739473 | 16:48 |
openstackgerrit | Merged openstack/python-ironicclient master: Remove pypy https://review.opendev.org/739235 | 16:48 |
fungi | and if tooz, for example, allowed you to pick sha2 for its hash ring, you wouldn't be able to mix systems using that and its md5 default in the same environment | 16:49 |
dtantsur | fungi: exactly. Well, maybe a try..except.. with a fallback to SHA256? | 16:49 |
dtantsur | yup | 16:49 |
dtantsur | or we just accept it and document that changing the hash function requires a cold upgrade | 16:49 |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic-python-agent stable/ussuri: Fix serializing ironic-lib exceptions https://review.opendev.org/739552 | 16:50 |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic-python-agent stable/train: Fix serializing ironic-lib exceptions https://review.opendev.org/739553 | 16:50 |
fungi | i mean, if you can make a lot of assumptions about all the systems which are communicating and that they've been set up consistently then it could be that simple. if you want negotiation or some sort of signalling of the values chosen by each system that gets much more complicated obviously | 16:51 |
dtantsur | I think we're fine with requiring the same value for the whole cluster | 16:52 |
fungi | and yeah, tooz/hashring.py seems to still hard-code calls to hashlib.md5() in master, so it's not at all configurable (yet) | 16:53 |
dtantsur | yup. will work on it tomorrow, I guess. | 16:54 |
*** dtantsur is now known as dtantsur|afk | 16:54 | |
dtantsur|afk | g'night folks! | 16:54 |
fungi | from a performance perspective, sha2 is probably roughly as fast on modern hardware as md5 at least, so this may be best handled as an upgrade path for tooz itself | 16:54 |
fungi | have a good night dtantsur|afk! | 16:54 |
*** derekh has quit IRC | 17:01 | |
openstackgerrit | Merged openstack/ironic stable/train: Fix the error message when reached max number of traits https://review.opendev.org/739478 | 17:03 |
openstackgerrit | Merged openstack/ironic stable/train: Software RAID: don't try to set local_gb to MAX https://review.opendev.org/739489 | 17:13 |
*** dking has joined #openstack-ironic | 17:13 | |
*** hjensas has quit IRC | 17:21 | |
*** priteau has joined #openstack-ironic | 17:22 | |
TheJulia | fungi: good point, I suspect we will want be mindful of cpu overhead since the hash ring generation is one of the most intensive operations :\ | 17:31 |
fungi | i would recommend benchmarking whatever solutions you consider | 17:33 |
TheJulia | I'm not sure anyone has time to do anything formal there :( | 17:35 |
arne_wiebalck | bye everyone o/ | 17:50 |
openstackgerrit | Merged openstack/ironic-inspector master: Add leader election for periodic sync with ironic https://review.opendev.org/735527 | 17:51 |
*** ociuhandu has joined #openstack-ironic | 18:06 | |
*** priteau has quit IRC | 18:07 | |
openstackgerrit | Merged openstack/ironic-python-agent master: Limit Inspection->Lookup->Heartbeat lag https://review.opendev.org/739120 | 18:08 |
*** ociuhandu has quit IRC | 18:11 | |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic-python-agent stable/ussuri: Limit Inspection->Lookup->Heartbeat lag https://review.opendev.org/739569 | 18:21 |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic-python-agent stable/train: Limit Inspection->Lookup->Heartbeat lag https://review.opendev.org/739572 | 18:24 |
*** hjensas has joined #openstack-ironic | 18:28 | |
openstackgerrit | Julia Kreger proposed openstack/ironic master: Provide a path to set explicit ipxe bootloaders https://review.opendev.org/728315 | 18:40 |
TheJulia | ^^^ should pass CI, but I'm going to go work on unit test improvements now | 18:40 |
*** kaifeng has quit IRC | 18:47 | |
*** gregwork has quit IRC | 18:49 | |
TheJulia | oh, heh, more like fix existing tests | 18:57 |
*** sshnaidm|mtg is now known as sshnaidm|ruck | 19:01 | |
TheJulia | and more... :( | 19:12 |
*** tzumainn has quit IRC | 20:35 | |
TheJulia | yay one test left | 21:02 |
NobodyCam | good afternoon Ironic'ers | 21:37 |
*** Goneri has quit IRC | 22:00 | |
TheJulia | good afternoon NobodyCam | 22:00 |
openstackgerrit | Julia Kreger proposed openstack/ironic master: Provide a path to set explicit ipxe bootloaders https://review.opendev.org/728315 | 22:07 |
openstackgerrit | Merged openstack/ironic-python-agent stable/train: Limit Inspection->Lookup->Heartbeat lag https://review.opendev.org/739572 | 22:21 |
*** tkajinam has joined #openstack-ironic | 22:42 | |
*** rcernin has joined #openstack-ironic | 23:01 | |
*** rcernin has quit IRC | 23:07 | |
*** rcernin has joined #openstack-ironic | 23:10 | |
*** rh-jelabarre has quit IRC | 23:25 | |
* NobodyCam waves at TheJulia | 23:48 | |
openstackgerrit | Julia Kreger proposed openstack/ironic master: Guard conductor from consuming all of the ram https://review.opendev.org/726483 | 23:51 |
TheJulia | when did it become nearly 5pm? | 23:52 |
NobodyCam | I know right | 23:52 |
TheJulia | arne_wiebalck: ^^ if you could review that, I would greatly appreciate it. Hopefully the defaults are good enough. I geuss I'm not terribly sure, because memory available should also include all virtual memory... but yeah.. In reality, most likely the conductor is already swapping tons at that point | 23:53 |
TheJulia | NobodyCam: I'm guessing some sort of magic | 23:53 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!