Monday, 2020-06-15

*** Goneri has quit IRC00:09
openstackgerritSteve Baker proposed openstack/ironic master: Document http_basic auth strategy  https://review.opendev.org/73548201:05
*** Qianbiao has joined #openstack-ironic02:20
*** jdandrea has joined #openstack-ironic02:21
*** mkrai has joined #openstack-ironic02:51
*** yaawang has joined #openstack-ironic02:52
*** k_mouza has joined #openstack-ironic03:11
*** k_mouza has quit IRC03:16
*** rh-jelabarre has joined #openstack-ironic03:28
*** rh-jelabarre has quit IRC03:28
*** rh-jelabarre has joined #openstack-ironic03:29
*** mkrai has quit IRC03:33
*** mkrai has joined #openstack-ironic03:35
*** ociuhandu has joined #openstack-ironic03:59
*** ociuhandu has quit IRC04:04
*** Habib-A52 has quit IRC04:10
*** jdandrea has quit IRC04:26
*** zaneb has quit IRC04:28
*** jdandrea has joined #openstack-ironic04:28
*** zaneb has joined #openstack-ironic04:31
*** jdandrea has quit IRC04:33
*** ricolin has joined #openstack-ironic04:42
*** jtomasek has joined #openstack-ironic04:49
*** rh-jelabarre has quit IRC04:57
*** diurnalist has joined #openstack-ironic06:04
*** irclogbot_3 has quit IRC06:05
*** irclogbot_1 has joined #openstack-ironic06:06
*** diurnalist has quit IRC06:08
*** k_mouza has joined #openstack-ironic06:12
arne_wiebalckGood morning, ironic!06:13
*** k_mouza has quit IRC06:16
*** priteau has joined #openstack-ironic06:34
*** iurygregory has joined #openstack-ironic07:11
iurygregorygood morning Ironic o/07:12
*** mkrai has quit IRC07:16
*** mkrai has joined #openstack-ironic07:27
*** yolanda has joined #openstack-ironic07:40
-openstackstatus- NOTICE: uWSGI made a new release that breaks devstack, please refrain from rechecking until a devstack fix is merged.07:43
*** dougsz has joined #openstack-ironic07:44
iurygregoryyay for mondays!07:44
*** eliaswimmer has joined #openstack-ironic07:46
*** dtantsur|afk is now known as dtantsur07:51
dtantsurmorning ironic07:51
dtantsuroh, sweeeet!07:51
iurygregorymorning dtantsur07:52
iurygregoryhehehe07:52
iurygregoryit's just to say "it's monday"07:52
*** mkrai has quit IRC07:57
dtantsurI was bored on Sunday, so I did this https://review.opendev.org/735461 and surprisingly it seems to work \o/07:58
patchbotpatch 735461 - bifrost - Migrate pip_install.yml to a new role bifrost-pip-... - 3 patch sets07:58
arne_wiebalckHey dtantsur, totally agree. In fact, what I did in prod now is to reduce the cleanup_period to 3600. https://usercontent.irccloud-cdn.com/file/97eNrhYy/Screenshot%20from%202020-06-15%2008-54-03.png07:59
dtantsurthat's your mitigation08:00
dtantsur:)08:00
arne_wiebalckThe first reduction (10.06) is pagination, the second (12.06) is the change of cleanup_period.08:00
*** rpittau|afk is now known as rpittau08:00
*** lucasagomes has joined #openstack-ironic08:00
rpittaugood morning ironic! o/08:00
dtantsurand a real fix would probably be two-part: pagination + leader election08:00
arne_wiebalckdtantsur: right08:01
dtantsurluckily, we already have leader election code in inspector, only need to wire that in08:01
arne_wiebalckdtantsur: with 12 inspectors and 3600 the cleanup is around every 10 mins still08:01
dtantsurarne_wiebalck: could you maybe propose your pagination changes? and maybe document the scaling issue and the workaround?08:01
arne_wiebalckdtantsur: the pagination is max_limit in ironic.conf08:02
dtantsurah08:02
arne_wiebalckdtantsur: we had a too high value, the Ironic default is good08:02
arne_wiebalckdtantsur: but we had 12 inspectors asking for all nodes in one chunk every 60 secs08:03
dtantsurthat sounds crazy indeed, sorry for this design :)08:03
arne_wiebalckdtantsur: so, we paginated, then decreased the frequency08:03
dtantsurit was before we had notifications, maybe we should employ them..08:03
arne_wiebalck:-D08:03
dtantsurmaybe we need direct ironic->inspector notifications?08:03
arne_wiebalckit may be crazy to have 12 inspectors08:03
iurygregorygood morning arne_wiebalck and rpittau o/08:04
dtantsurit does sound a bit too much to me :)08:04
rpittauhey iurygregory :)08:04
arne_wiebalckbut so far all my controllers are identical08:04
dtantsurbut we should support all cases. with active node introspection you may actually need some scale.08:04
arne_wiebalckoperationally, it is just easier to have controllers which look all the same08:04
dtantsurarne_wiebalck: as you now realize, you're the first to try ironic-inspector at really high scale :)08:04
dtantsuryeah, I see08:04
arne_wiebalckrather than splitting api, conductor, and inspector08:04
arne_wiebalckwhich I could do, of course08:05
dtantsurI think we need to do the leader election instead08:05
arne_wiebalckdtantsur: re inspector at scale, the fun fact is that this is an idle inspector08:05
arne_wiebalckdtantsur: this is just the regular cleanup bringing our DB down08:06
dtantsurwell, yeah, idle, but with N000 nodes to track :)08:06
arne_wiebalckexactly08:06
dtantsurI certainly don't disagree we should fix that08:06
* arne_wiebalck sent the DB colleqgues on a quest to fix the slowness of the Ironic DB08:06
dtantsurI'm a bit careful about "just disable the task" as a solution08:06
arne_wiebalckI agree08:06
dtantsurI can look into the leader election, but I've been crazily busy recently. Help welcome, it shouldn't be a difficult patch.08:07
arne_wiebalckthis is why I started by reducing the frequency and asked on the review for potential side effects08:07
dtantsurthe side effect: be careful when recreating nodes08:07
arne_wiebalckno urgency, we can put this on our list and maybe gudrutis2 is interested :)08:08
arne_wiebalckrecreating nodes?08:08
dtantsurwell, in TripleO folks used to have a habit of deleting nodes and creating them again on any problem08:09
arne_wiebalckoh, I see08:09
dtantsurthat could cause an issue because ironic-inspector would still assume the MAC address belonging to another node08:09
arne_wiebalckoh, yeah08:10
*** ociuhandu has joined #openstack-ironic08:10
*** Lucas_Gray has joined #openstack-ironic08:11
*** mkrai has joined #openstack-ironic08:27
openstackgerritDmitry Tantsur proposed openstack/ironic-inspector master: [WIP] Leader election for periodic sync with ironic  https://review.opendev.org/73552708:35
dtantsurarne_wiebalck: seems simpler than I thought ^^08:35
dtantsur(completely untested, would be curious to try)08:35
arne_wiebalckwow, nice, we will try to test this, thanks dtantsur !08:38
openstackgerritDmitry Tantsur proposed openstack/ironic-inspector master: [WIP] Leader election for periodic sync with ironic  https://review.opendev.org/73552708:40
dtantsurarne_wiebalck: updated ^^. you'll need to configure a coordination backend if not already.08:40
dtantsurmay I get another +2 on https://review.opendev.org/#/c/733111/ please?08:44
patchbotpatch 733111 - bifrost - Get rid of the shade dependency - 5 patch sets08:44
dtantsurI know it's a bit involved, but shade has been deprecated for a while..08:45
openstackgerritDmitry Tantsur proposed openstack/bifrost master: Migrate pip_install.yml to a new role bifrost-pip-install  https://review.opendev.org/73546108:47
*** Lucas_Gray has quit IRC08:47
openstackgerritRiccardo Pittau proposed openstack/ironic-python-agent-builder master: Disable automatic updates in systemd images  https://review.opendev.org/73533508:50
iurygregorydtantsur, looking now =)08:51
*** uzumaki has joined #openstack-ironic08:54
arne_wiebalckdtantsur: noted, thanks08:54
uzumakihello ironic! o/08:54
dtantsurhi uzumaki, how's your Monday?08:54
uzumakivery very slow.. I think this WFH is going to make me lazier than a snail08:55
uzumakihow about you?08:55
iurygregoryhey uzumaki o/08:55
uzumakihey iurygregory \o/08:55
*** ociuhandu has quit IRC08:58
*** ociuhandu has joined #openstack-ironic08:59
openstackgerritMerged openstack/bifrost stable/ussuri: Install packages all at once instead of looping over them  https://review.opendev.org/73545609:00
*** bonguardo has joined #openstack-ironic09:00
dtantsuruzumaki: also very slow, although not so terrible (yet?). and I'm used to WFH :)09:00
*** k_mouza has joined #openstack-ironic09:02
uzumakiwell, you're lucky09:02
openstackgerritMerged openstack/bifrost master: Allow changing 'update' and 'force' when cloning repos  https://review.opendev.org/73548009:02
dtantsurprobably :)09:02
*** bonguardo has quit IRC09:10
*** priteau has quit IRC09:11
openstackgerritVerification of a change to openstack/ironic-lib failed: Use unittest.mock instead of mock  https://review.opendev.org/73435209:12
*** ociuhandu has quit IRC09:13
openstackgerritMerged openstack/bifrost master: Remove the ansible_pkg_mgr hack  https://review.opendev.org/73547909:15
openstackgerritMerged openstack/bifrost master: Update ansible versions in README of the roles  https://review.opendev.org/73545909:15
openstackgerritMerged openstack/bifrost master: Remove the workaround for PEP517 issues  https://review.opendev.org/73545709:15
*** Lucas_Gray has joined #openstack-ironic09:20
*** priteau has joined #openstack-ironic09:21
*** Wryhder has joined #openstack-ironic09:22
*** Lucas_Gray has quit IRC09:24
*** Wryhder is now known as Lucas_Gray09:24
openstackgerritMerged openstack/bifrost master: Get rid of the shade dependency  https://review.opendev.org/73311109:25
openstackgerritMerged openstack/ironic master: Use assertCountEqual instead of assertItemsEqual  https://review.opendev.org/73512709:28
*** ociuhandu has joined #openstack-ironic09:36
*** ociuhandu has quit IRC09:39
*** uzumaki has quit IRC09:39
*** ociuhandu has joined #openstack-ironic09:39
openstackgerritMerged openstack/bifrost master: Convert with_items to loop  https://review.opendev.org/73384709:40
*** Lucas_Gray has quit IRC09:43
openstackgerritDmitry Tantsur proposed openstack/ironic-inspector master: devstack: Use uwsgi binary from path  https://review.opendev.org/73554709:44
dtantsurThis ^^^ presumably fixes the CI together with https://review.opendev.org/#/c/731159/09:44
patchbotpatch 731159 - ironic - devstack: Use uwsgi binary from path - 1 patch set09:44
iurygregorydtantsur, ack09:45
*** Lucas_Gray has joined #openstack-ironic09:46
dtantsurmay I also get some reviews on https://review.opendev.org/733985 and https://review.opendev.org/#/c/716216/ please? they're blocking the rest of the deploy steps work09:49
patchbotpatch 733985 - ironic - agent: poll long-running commands till completion - 3 patch sets09:49
patchbotpatch 716216 - ironic-python-agent - Add a deploy step for writing an image - 10 patch sets09:49
dtantsurmgoddard: if you have time in the near future ^^09:50
*** uzumaki has joined #openstack-ironic09:51
openstackgerritRiccardo Pittau proposed openstack/ironic-python-agent-builder master: Disable automatic updates in dnf-based systems  https://review.opendev.org/73533509:53
mgoddarddtantsur: time? what's that? :)09:53
iurygregoryit's something relative09:55
uzumakioh, we're discussing time again \o/09:55
uzumaki<enters the microwave>09:55
iurygregorysteins;gate time09:56
*** k_mouza has quit IRC09:59
*** rpittau is now known as rpittau|bbl10:03
dtantsur:D10:06
*** Lucas_Gray has quit IRC10:15
*** Lucas_Gray has joined #openstack-ironic10:17
*** k_mouza has joined #openstack-ironic10:19
*** ociuhandu has quit IRC10:27
*** ociuhandu has joined #openstack-ironic10:29
openstackgerritDmitry Tantsur proposed openstack/ironic-inspector master: devstack: Use uwsgi binary from path  https://review.opendev.org/73554710:31
*** mkrai has quit IRC10:33
*** mkrai_ has joined #openstack-ironic10:33
openstackgerritDmitry Tantsur proposed openstack/bifrost master: Migrate pip_install.yml to a new role bifrost-pip-install  https://review.opendev.org/73546110:35
*** derekh has joined #openstack-ironic10:35
*** ociuhandu has quit IRC10:41
*** rcernin has joined #openstack-ironic10:44
*** rcernin has quit IRC10:54
*** ociuhandu has joined #openstack-ironic10:55
openstackgerritDmitry Tantsur proposed openstack/bifrost master: Only install proliantutils if ilo is enabled; support idrac  https://review.opendev.org/73555410:56
*** rh-jelabarre has joined #openstack-ironic11:03
*** rh-jelabarre has quit IRC11:03
*** rh-jelabarre has joined #openstack-ironic11:13
*** ociuhandu has quit IRC11:14
*** ociuhandu has joined #openstack-ironic11:16
*** ociuhandu has quit IRC11:20
*** derekh has quit IRC11:31
*** derekh has joined #openstack-ironic11:37
openstackgerritDmitry Tantsur proposed openstack/bifrost master: Only install proliantutils if ilo is enabled; support idrac  https://review.opendev.org/73555411:51
*** ociuhandu has joined #openstack-ironic11:58
*** rpittau|bbl is now known as rpittau12:04
*** mkrai_ has quit IRC12:07
rpittauoh wow all ci jobs are actually broken because of uwsgi :/12:09
dtantsuryep12:10
dtantsurand we may need to temp-disable grenade to fix it..12:11
rpittauyeah, I was reading on openstack-qa :/12:11
dtantsuror cap uwsgi on stable branches12:11
dtantsurthis ^^ may be easier12:12
*** dougsz has quit IRC12:13
iurygregorymonday ...12:25
iurygregorythings are crazy today12:25
dtantsurmmm, we cannot cap uwsgi, devstack is switching to installing it from system packages12:26
dtantsurjesus12:26
dtantsurI don't want to play the whole dance around disabling grenade on all branches12:26
* dtantsur wants to switch most of the CI to bifrost now12:27
*** dougsz has joined #openstack-ironic12:28
*** derekh has quit IRC12:28
*** derekh has joined #openstack-ironic12:29
dtantsurokay, if we backport the fix, and start landing it from the oldest branch, it may work12:29
dtantsurI mean, https://review.opendev.org/#/c/731159/12:30
patchbotpatch 731159 - ironic - devstack: Use uwsgi binary from path - 1 patch set12:30
rpittauif it stops failing for other reasons.....12:31
iurygregory^ this12:32
rpittauoh that's actually grenade /facepalm12:32
iurygregorygrenade <312:33
dtantsurrpittau: yep, I'm afraid grenade will not allow us to Just Merge It12:33
rpittauso I guess we'll have to disable grenade at least on master ;/12:33
* dtantsur updates the whiteboard12:33
iurygregory"Red"12:33
dtantsurrpittau: we can try landing the fix from the oldest branch12:33
rpittaummm ok12:34
*** Wryhder has joined #openstack-ironic12:35
dtantsuralthough.. it is blocked by fixing devstack12:36
*** Lucas_Gray has quit IRC12:36
*** Wryhder is now known as Lucas_Gray12:36
dtantsurso if we want to continue landing changes now, we do need to disable grenade12:36
dtantsurmaybe only on master to limit the mess12:36
iurygregory++12:37
rpittaulet's do it, unless we can give the devstack fix some more time12:37
*** adrianc has quit IRC12:37
*** adrianc has joined #openstack-ironic12:38
dtantsurk, updating12:38
openstackgerritDmitry Tantsur proposed openstack/ironic master: devstack: Use uwsgi binary from path; temporary disable grenade  https://review.opendev.org/73115912:39
dtantsurhere goes12:39
*** Lucas_Gray has quit IRC12:41
openstackgerritDmitry Tantsur proposed openstack/ironic master: CI: make grenade voting again  https://review.opendev.org/73557712:43
*** Lucas_Gray has joined #openstack-ironic12:43
openstackgerritDmitry Tantsur proposed openstack/ironic-inspector master: devstack: Use uwsgi binary from path; temporary disable grenade  https://review.opendev.org/73554712:45
openstackgerritDmitry Tantsur proposed openstack/ironic-inspector master: CI: make grenade voting again  https://review.opendev.org/73557912:46
*** Lucas_Gray has quit IRC12:50
openstackgerritDmitry Tantsur proposed openstack/bifrost master: CI: clean up non-votings jobs  https://review.opendev.org/73558112:51
*** Lucas_Gray has joined #openstack-ironic12:52
*** priteau has quit IRC12:54
*** priteau has joined #openstack-ironic12:55
TheJuliagood morning13:07
rpittaugood morning TheJulia :)13:07
dtantsurmorning TheJulia13:08
iurygregorygood morning TheJulia =)13:12
*** rloo has joined #openstack-ironic13:29
openstackgerritDmitry Tantsur proposed openstack/ironic master: [WIP] Agent power interface  https://review.opendev.org/73559113:38
*** tzumainn has joined #openstack-ironic13:39
dtantsurTheJulia: this is how I see it ^^13:39
*** Lucas_Gray has quit IRC13:39
*** kaiokmo has joined #openstack-ironic13:42
*** jdandrea has joined #openstack-ironic13:49
TheJuliaok13:54
TheJuliaI'll look when I'm not on meetings/calls13:54
*** Goneri has joined #openstack-ironic13:57
openstackgerritDmitry Tantsur proposed openstack/ironic-inspector master: Allow setting other fields on discovery  https://review.opendev.org/73559414:07
*** priteau has quit IRC14:12
openstackgerritJames Denton proposed openstack/networking-generic-switch master: VLAN not tagged on every switchs  https://review.opendev.org/55705114:13
TheJuliaChris raised an interesting question on https://review.opendev.org/#/c/733716 re pxe_enabled. Do we have any thoughts on that? I'm hesitant since I know there was the whole initial thing about network interfaces being oem specific and optional in early stuffs14:19
patchbotpatch 733716 - ironic - WIP Add a driver compatability matrix - 5 patch sets14:19
*** Lucas_Gray has joined #openstack-ironic14:29
*** cdearborn has joined #openstack-ironic14:40
rpiosoGood morning, ironic.14:46
rpittauhey rpioso :)14:48
rpiosorpittau: o/14:49
*** diurnalist has joined #openstack-ironic14:50
dtantsurTheJulia: commented. tl;dr it probably needs a separate feature14:52
TheJulialikely14:53
dtantsurfolks, we need https://review.opendev.org/#/c/731159/ to unblock the CI (for now)14:55
patchbotpatch 731159 - ironic - devstack: Use uwsgi binary from path; temporary di... - 2 patch sets14:55
rpittaudtantsur: done, I thought I put the +2 already14:56
TheJuliaapproved14:57
TheJulia*sigh*14:57
dtantsuryeah, le sigh14:57
dtantsursimilarly, https://review.opendev.org/73554714:57
patchbotpatch 735547 - ironic-inspector - devstack: Use uwsgi binary from path; temporary di... - 3 patch sets14:57
*** kaifeng has joined #openstack-ironic14:58
TheJulia#startmeeting ironic15:00
openstackMeeting started Mon Jun 15 15:00:15 2020 UTC and is due to finish in 60 minutes.  The chair is TheJulia. Information about MeetBot at http://wiki.debian.org/MeetBot.15:00
openstackUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.15:00
*** openstack changes topic to " (Meeting topic: ironic)"15:00
openstackThe meeting name has been set to 'ironic'15:00
TheJuliaGood morning everyone!15:00
dtantsuro/15:00
iurygregoryo/15:00
TheJuliaTime for another meeting full of Ironic!15:00
ajya\o15:00
kaifengo/15:00
erbarro/15:00
arne_wiebalcko/15:00
cdearborn\o/15:00
rpittauo/15:00
mgoddard\o15:00
rpiosoo/15:00
Qianbiaoo/15:01
TheJuliaOur agenda this week can be found on the wiki15:01
TheJulia#link https://wiki.openstack.org/wiki/Meetings/Ironic#Agenda_for_next_meeting15:01
TheJulia#topic Announcements / Reminder15:01
*** openstack changes topic to "Announcements / Reminder (Meeting topic: ironic)"15:01
TheJuliaLooks like we have two items on the agenda15:01
TheJuliaThe first is the priorities for the Victoria cycle are up for review. Please review/comment as soon as reasonably possible.15:02
TheJulia#link https://review.opendev.org/#/c/720100/15:02
patchbotpatch 720100 - ironic-specs - Victoria Cycle Priorities - 8 patch sets15:02
TheJuliaThe second item is regarding a meeting for partitioning on Wednesday15:02
TheJuliaLooks like dtantsur is hosting a call at 2 PM UTC on Wednesday15:02
TheJulia#link http://lists.openstack.org/pipermail/openstack-discuss/2020-June/015422.html15:02
dtantsuryep, note the s/July/June/15:03
TheJuliaDoes anyone have anything to announce or remind us of?15:03
TheJuliadtantsur: No time machines available ? :)15:03
dtantsurtwo weeks till our first coordinates intermediate release?15:03
dtantsur* coordinated15:03
dtantsuror do I recall the dates incorrectly?15:03
TheJuliaYeah, roughly15:04
TheJuliaWeek of June 29th15:04
rlooo/15:04
TheJuliaHence why I keep pushing for reviews to occur :)15:04
dtantsuraha, cool. if so, we may want to start slowing down the new feature stream (not that we have many) and concentrate on the sprint goals15:04
dtantsurand I need to make bifrost-based upgrades work..15:05
TheJuliaa good portion of that is basically code review at this point15:05
rajiniro/15:05
TheJuliadtantsur: if that ends up being sprint 2, I don't think that specifically is the end of the world15:06
TheJulia\o rajinir15:06
dtantsuryep. but I like hacking on bifrost =^_^=15:06
TheJuliai think it is largely going to be input data based with maybe a slightly different scenario test. We'll figure it out :)15:07
TheJuliaAnyway, we had no action items from our last meeting, so I believe since we've not ratified the priorites we can proceed to review priorites?15:08
dtantsurit would be good to have status updates on the whiteboard15:08
dtantsureven if there are no formally approved priorities15:08
TheJuliaSeems reasonable15:09
TheJulia#topic Review subteam status reports15:09
*** openstack changes topic to "Review subteam status reports (Meeting topic: ironic)"15:09
TheJulia#link https://etherpad.openstack.org/p/IronicWhiteBoard15:09
TheJuliaStarting around line 25315:09
dtantsuriurygregory: could you update the DHCP-less section?15:10
iurygregorydtantsur, doing now =)15:10
dtantsurgreat :)15:10
TheJuliaarne_wiebalck: question for you on line 28415:10
arne_wiebalckTheJulia: right, there is the OOM issue and the inspector issue15:11
*** zaneb has quit IRC15:11
arne_wiebalck TheJulia both are scaling issues15:11
TheJuliaarne_wiebalck: yeah, we need to work those out15:11
arne_wiebalckTheJulia: shall we keep a "scaling" topic or address these individually?15:11
TheJuliaI think we should scale back the topic15:12
TheJuliaFor next week :)15:12
arne_wiebalck👍15:12
kaifengarne_wiebalck: looks like you are using non-standalone inspector already15:12
TheJuliaLooks like we just need people to do a final review on sig whitepaper15:13
arne_wiebalckkaifeng: what is a non-standalone inspector?15:13
TheJuliaarne_wiebalck: did you have a deadline date in mind?15:13
arne_wiebalckTheJulia: I was thinking end of this week15:13
arne_wiebalckTheJulia: to give everyone a chance to read once more15:13
arne_wiebalckTheJulia: and then file it with the foundation15:14
dtantsurarne_wiebalck: API/conductor split for inspector15:14
arne_wiebalckTheJulia: or is this too long?15:14
TheJuliaarne_wiebalck: maybe thursday?15:14
openstackgerritIury Gregory Melo Ferreira proposed openstack/ironic master: Add L3 boot section to the docs  https://review.opendev.org/68984415:14
arne_wiebalckTheJulia: ok15:14
dtantsurwhich I guess you needed to have multi-node inspector15:14
TheJuliaarne_wiebalck: just thinking that way you can send it on friday :)15:14
arne_wiebalckTheJulia: ok15:14
arne_wiebalckdtantsur: kaifeng : all our controllers run API/conductor/inspector15:14
dtantsurarne_wiebalck: oh, you don't split API/conductor for inspector?15:15
TheJuliaAnd their config doesn't fundimentally need the sync process at all15:15
TheJuliathe tl;dr is the inspector sync pounds ironic's API.15:15
kaifengdtantsur: excelent!15:15
dtantsurwell, we cannot expect everyone who uses inspector with many nodes to disable the sync15:15
TheJuliasince they don't use it a pxe filter15:15
arne_wiebalckdtantsur: you mean running API and conductor on different hosts?15:15
dtantsurit's not about the PXE filter, it's about syncing the node list15:15
TheJuliadtantsur: agreed, but no filter basically means it is entirely redundant as well. So multiple things that should and can be fixed15:16
dtantsurarne_wiebalck: as different processes15:16
dtantsurTheJulia: I remember there was at least one problem with disabling it, cannot fully remember15:16
TheJuliadtantsur: the only downside i see having a knob is not deleting records from the inspector DB :\ since it will do the lookup if memory serves15:16
dtantsuranyway, some people may use the PXE filter, so we need to actually fix it15:16
kaifengcurrently inspector doesn't have hashring to split nodes management15:16
* dtantsur ponders attaching an inspector instance to a conductor group15:16
dtantsurI mean, the biggest problem right now is that all 12 (?) inspector instances try to do the sync for all nodes15:17
dtantsurwith the leader election in place it will be only one15:17
dtantsurwhich is 12x less load on ironic already15:17
arne_wiebalckdtantsur: yes15:17
TheJuliaLets have this discussion during open discussion15:17
arne_wiebalckdtantsur: I think this is a scalable solution15:17
arne_wiebalckok15:18
dtantsuryep15:18
TheJuliaHas anyone looked at neutron event processing recently?15:18
TheJuliahjensas, kaifeng, rpittau ^^^15:18
kaifenghaven't got the time, sorry15:18
rpittaunope15:18
hjensasnope, I want to get back to it. but need to find time.15:19
TheJuliare: v6, I guess we never clicked the backport button?15:19
* dtantsur dunno15:20
openstackgerritJulia Kreger proposed openstack/ironic stable/ussuri: Add IPv6 ci Job  https://review.opendev.org/73561415:20
rpittauno, it was not backported yet15:20
TheJulia#easy15:20
TheJuliaiurygregory: re: grenade, can you elaborate on "related to ngs key"15:21
dtantsurnote that the job seems red on master15:21
iurygregoryTheJulia, yeah going to add a more info there =)15:21
TheJuliaOkay, well seems good then. Everyone ready to proceed to priorities for the week?15:22
dtantsurI am15:22
rpittaulet's15:22
TheJulia#topic Deciding on priorities for the coming week15:23
*** openstack changes topic to "Deciding on priorities for the coming week (Meeting topic: ironic)"15:23
TheJulia#link https://etherpad.opendev.org/p/IronicWhiteBoard15:23
TheJuliaStarting at line 116!15:23
TheJuliaLooks like we got a number of items merged last week. Thanks everyone who helped there!15:23
TheJuliaAs for things to add, dtantsur do you think it would be good to add your inspector leader election patch for at least initial feedback?15:24
* TheJulia deletes merged items15:24
dtantsuryep15:25
iurygregoryTheJulia, added =)15:25
rpittauTheJulia: can we pkease add https://review.opendev.org/73533515:25
patchbotpatch 735335 - ironic-python-agent-builder - Disable automatic updates in dnf-based systems - 3 patch sets15:25
TheJuliarpittau: go ahead :)15:25
rpittauok!15:25
TheJuliaYou guys don't need my permission to add items :)15:26
kaifengdtantsur: i remember not all backend support leader election, maybe we need a more generic way?15:26
* iurygregory added items without asking =X15:26
dtantsurkaifeng: well, I'm not aware of a more generic way15:26
dtantsuranyway, if the backend returns NotImplemented, all nodes run the tasks15:27
rpittauTheJulia: oh it's just to see if there's place, based on priorities :)15:27
kaifengdtantsur: hmm, better than nothing ;)15:28
dtantsurI've added a few things too15:28
dtantsurkaifeng: yeah, at least it does not make things worse :)15:28
dtantsurmemcached and redis backends support leader election, etcd does not15:28
Qianbiaodtantsur why not use amqp to support task schedule15:28
dtantsurQianbiao: we're trying to get rid of amqp :) and anyway, I'm not sure it's related15:29
Qianbiaoany node which get the message will run the task. other nodes will just ignore15:29
dtantsurwe don't have any entity to schedule the task, it's periodic15:29
TheJuliais there anything else people see that should be in the list for this week?15:29
Qianbiaook if amqp will be removed15:29
Qianbiaodtantsur I find you are working on inband deploy steps, i got a question with inband steps: may it support restart bmc during steps?15:30
dtantsurnot sure it will ever be removed, but I'd avoid a new dependency on it15:30
TheJuliawe likely need to look at https://review.opendev.org/#/c/731644/15:30
patchbotpatch 731644 - ironic - Fix Redfish handle no continuous override boot src - 4 patch sets15:30
dtantsurQianbiao: (let's talk later) it can be a deploy step15:30
Qianbiaook.15:30
dtantsurTheJulia: good call15:30
rpiosoTheJulia, dtantur: Please do :-)15:30
rpioso*dtantsur15:31
* dtantsur wonders if next week we should only keep things that are bug fixes and sprint priorities15:31
TheJuliaalso https://review.opendev.org/#/c/730366/15:31
patchbotpatch 730366 - ironic - Allow node lessee to see node's ports - 1 patch set15:31
TheJuliadtantsur: Likely15:31
dtantsurand somebody (me?) needs to talk to the release team on whether we actually need to change the release model15:32
TheJuliaThat looks good, I went through some of the items that got no review traffic it looks like15:32
TheJuliadtantsur: likely and I think we have to if we want to keep our stress level to manageable levels.15:33
dtantsurTheJulia: the wind is changing, we may be able to keep the model and the stress level15:33
dtantsurI'll talk to the folks15:33
TheJuliaokay15:33
* TheJulia doesn't want more stress though15:33
* TheJulia wants less stress15:33
* dtantsur wonders if he has ACL to do #action15:34
TheJulia:)15:34
dtantsurheh15:34
TheJuliadtantsur: I can note one if you want15:34
iurygregoryif you need any help let me know dtantsur =)15:34
dtantsuriurygregory: I will quite likely need help, but not on the talking stage15:34
dtantsur:)15:34
iurygregoryyeah =)15:34
dtantsurthere'll be an awkward moment when we figure out how the CI for new branches will work15:34
dtantsur(remove grenade, add more bifrost or whatever)15:34
iurygregorygotcha15:34
TheJulia#action dtantsur to go talk to release team about model and stuff15:35
rpittaudtantsur: I thought we needed to keep grenade for openstack.... needs15:35
TheJuliadtantsur: inherently broken out of the gate and then fix is likely okay in my book :)15:35
dtantsurrpittau: not for intermediate branches which are explicitly targeting standalone usage15:35
TheJuliasince we can't anticipate everything15:35
dtantsuryep15:35
dtantsurthe problem with grenade is, it expects to know the branches15:35
TheJuliaThat may also mean we need to get them to force merge or squash patches into one change set15:35
rpittauno, of course, I was thinking about major opesntack releases15:35
dtantsurif we have stable/17.0, it won't know what to upgrade from15:36
dtantsurhence the desire to have a bifrost-upgrade CI job15:36
TheJuliadtantsur: override variables likely needed in that case15:36
TheJulia++15:36
iurygregorythis we can override the config ..15:36
dtantsur(which will also need to know the branches, but that's solvable)15:36
dtantsuryeah, all is possible, let's figure it out as we go15:36
TheJuliaAnyway, sounds like everyone is good with the list of priorities15:36
TheJuliaarne_wiebalck: was there anything else besdies the whitepaper which we've already touched upon a few times?15:37
TheJulia(specifically for the SIG)15:37
arne_wiebalckI don't think so.15:37
TheJuliaThen in that case, lets proceed to Open Discussion! :)15:37
dtantsur++15:37
TheJulia#topic Open Discussion15:38
*** openstack changes topic to "Open Discussion (Meeting topic: ironic)"15:38
TheJuliaso, scaling of the ironic-inspector?15:39
arne_wiebalckI think the leader election should do it, no?15:39
TheJuliaif configured properly, likely.15:40
arne_wiebalckOtherwise, we may need sth to describe how to set up services.15:40
dtantsurdo you use memcached or redis already?15:40
TheJuliaI... still think a global "don't do this" knob may be good in some configurations15:40
dtantsuragree with ^^^15:40
arne_wiebalckYes, for Cinder.15:41
dtantsurI just don't think we should call it a fix for this bug15:41
kaifengdo we have sync interval for this?15:41
dtantsurarne_wiebalck: okay, so an easy change for you15:41
arne_wiebalckheh15:41
dtantsurkaifeng: we don't handle interval==0, we should15:41
TheJuliadtantsur: oh yeah, I was never thinking it was a bug fix, more a "well, it doesn't really make sense" in this case change15:41
arne_wiebalckwe only see an effect in prod15:41
dtantsurTheJulia: tss, lemme first lure arne_wiebalck into testing my leader election patch!15:41
arne_wiebalckdue to the scale, but prod is ... prod :)15:41
kaifengthat's sad, it would be a fast solution if we have15:42
TheJuliainterval==0 is not a bad idea, although it would be similar to the patch I already posted15:42
TheJuliadtantsur: hehe15:42
arne_wiebalckdtantsur: but, yeah, true should not be too complicated15:42
dtantsurTheJulia: yep, I commented on your patch that I'd prefer to reuse interval==0 rather than a new option15:42
arne_wiebalckdtantsur: I created an internal ticket to try15:42
TheJuliadtantsur: sounds good to me15:42
dtantsur(esp. since it's consistent with ironic)15:42
arne_wiebalckreducing the frequency to 3600 did the trick for us atm15:43
arne_wiebalckwhich is still <10 mins efeectively15:43
arne_wiebalckeffectively15:43
arne_wiebalckand hence probably good enough15:43
arne_wiebalckdtantsur: don't worry, will still try your patch :-D15:44
TheJuliaAnything else to discuss?15:46
TheJuliaDo we need a "review jam" ?15:46
dtantsurmmm, maybe?15:46
*** rloo has quit IRC15:47
dtantsurnot sure about a call, but maybe half-day to sit together on IRC discussing the same patches?15:47
TheJuliaWould anyone be opposed to something on say ?thursday?15:47
TheJuliathat could also work15:47
dtantsurFriday would be easier15:48
arne_wiebalckI'd prefer a call over IRC only tbh. Clarifying details/context would be quicker.15:49
TheJuliaYeah, just looking at down stream calendars and thinking that it is a lower key day15:49
TheJuliaWe could do a hybrid, both realistically15:50
iurygregoryboth sounds good to me15:50
TheJuliaDo we want to schedule like an hour for such?15:50
TheJuliaor even a half hour?15:51
TheJuliaa half hour may be more than enough for a call if we've all had a chance to kind of get ideas/thoughts together15:51
openstackgerritHarald Jensås proposed openstack/ironic master: Switch Ironic to openstacksdk for Neutron  https://review.opendev.org/73487315:51
*** rloo has joined #openstack-ironic15:52
TheJuliaFriday is also a heavy call day for me right now15:52
rpittauThursday would probably be slightly better for me too15:53
TheJuliawould 4PM UTC work that day?15:53
rpittauThursday? good for me15:54
TheJuliaI could also do before 3 PM UTC on thursday15:54
iurygregorygood for me too15:54
dtantsurI have an API SIG meeting at 4pm, but it's usually silent15:54
dtantsur3pm is our downstream meeting, no?15:54
TheJuliadtantsur: yeah, so after migh tbe besst from an interrupt management standpoint15:55
dtantsurah, *before* 3pm15:55
* dtantsur cannot read15:55
dtantsur2pm UTC would be ideal for me, 4pm works too15:55
TheJuliaarne_wiebalck: does 4pm on next thursday work for you?15:55
arne_wiebalckyes, all fine for me :)15:55
TheJuliaI can also get up for 2pm, I just can't promise full caffination15:56
dtantsurmmm, right, it's early for you. let's go for 4pm15:56
TheJuliasounds good15:56
arne_wiebalck+115:56
TheJuliaI'll send out an email here in a little bit just for mailing list visibility15:56
TheJuliaDo we have anything to discuss in the next 4 minutes?15:57
TheJuliaPreferably centered around taking over the world using bare metal and bears with drum sticks?15:57
arne_wiebalckPlease re-read the instructions aka the white paper!15:57
* dtantsur still wants a sticker with a bear biting a redfish15:58
rpittaudtantsur: https://thumbs.dreamstime.com/b/face-wild-bear-fish-close-up-concept-bears-hunting-salmon-spawning-185089098.jpg15:58
dtantsurexactly15:59
iurygregoryLOL15:59
* TheJulia thinks we need this sticker16:00
iurygregoryi ust noticed that in ironic-lib we do some blackmagic to allow the command to be executed without root =O16:00
* dtantsur waits for iurygregory to realize ironic is made of black magic :)16:01
iurygregoryI knew that hehe16:01
iurygregorybut I was surprised when I saw that we check the config and override run_as_root hehe16:02
TheJuliaMaybe cast it as more "wizardry" or "incantations"16:02
dtantsurI guess we can #endmeeting, then discuss the black magic?16:02
TheJulialol16:02
TheJuliaThanks everyone! Have a wonderful week!16:02
TheJulia#endmeeting16:02
*** openstack changes topic to "Bare Metal Provisioning | Status: http://bit.ly/ironic-whiteboard | Docs: http://docs.openstack.org/ironic/ | Bugs: https://storyboard.openstack.org/#!/project_group/75 | Contributors are generally present between 6 AM and 12 AM UTC, If we do not answer, please feel free to pose questions to openstack-discuss mailing list."16:02
openstackMeeting ended Mon Jun 15 16:02:37 2020 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)16:02
openstackMinutes:        http://eavesdrop.openstack.org/meetings/ironic/2020/ironic.2020-06-15-15.00.html16:02
openstackMinutes (text): http://eavesdrop.openstack.org/meetings/ironic/2020/ironic.2020-06-15-15.00.txt16:02
openstackLog:            http://eavesdrop.openstack.org/meetings/ironic/2020/ironic.2020-06-15-15.00.log.html16:02
arne_wiebalckTheJulia: thanks16:02
dtantsuriurygregory: is it anything you need help with or just "WTF is wrong with us"?16:03
iurygregorybasically even if the command has run_as_root set if the config is not set we override run_as_root https://github.com/openstack/ironic-lib/blob/e4e11ccc7df5cf566211e3b347067ca196691d54/ironic_lib/utils.py#L95  https://github.com/openstack/ironic-lib/blob/e4e11ccc7df5cf566211e3b347067ca196691d54/ironic_lib/disk_utils.py#L142-L14316:03
*** gyee has joined #openstack-ironic16:03
iurygregoryI'm thinking on how to deal with the privsep for this scenarios..16:04
*** Lucas_Gray has quit IRC16:04
dtantsurI think root_helper is pretty much always set?16:04
iurygregorywill try to talk with some oslo people to see if there is something we can use16:04
dtantsurI'd suggest you kill this code with fire?16:04
rpittauthe root_helper is always 'on'16:04
rpittauthat needs to be translated with privsep16:04
iurygregoryhummm I would kill tests only basically..16:04
iurygregorybecause we have some scenarios we want to make sure the commands are run with non-root16:05
*** sshnaidm_ is now known as sshnaidm16:05
dtantsurjust pass run_as_root=False?16:05
rpittauyou can set specific permissions with privsep, not necessarily just root16:05
TheJuliathey are functionally privlegeless commands correct?16:06
rpittauand I'm pretty sure we need partprobe always running as root16:06
TheJuliaAs long as the file permissions are right, accessible?16:06
TheJuliaor are they SUID bit binaries?16:06
iurygregoryfor more context the test Im talking https://github.com/openstack/ironic-lib/blob/e4e11ccc7df5cf566211e3b347067ca196691d54/ironic_lib/tests/test_disk_utils.py#L91716:06
iurygregoryyeah but privsep the idea is that is used by root16:07
iurygregoryso we will have a root and non-root command right?\16:07
iurygregoryI saw nova have the priv command and non priv command in some cases and they use based on the config16:08
rpittauiurygregory: privsep allows running in privileged contexxts, that doesn't mean always as 'root'16:08
*** lucasagomes has quit IRC16:09
TheJuliaI just don't grok why we would try to run that without root privs now...16:10
rpittauit's all about security, you don't need root, just the correct context16:10
TheJulia++16:10
TheJuliaI think the confusion is we have these tests now and that doesn't make that much sense16:10
rpittauyeah16:10
*** dsneddon has joined #openstack-ironic16:11
iurygregoryso so we can just ignore run_as_root in our execs?16:11
iurygregoryand have the command wrapped by privsep16:11
rpittaunow we have root/not-root but we need to think in a more open way, rainbow style :)16:11
iurygregorythat would make sense?16:11
TheJuliaprotip: don't tell me how many people I might need to talk to when emailing me :(16:11
rpittaulet's say that the root part needs to be translated into proper privsep contexts16:12
iurygregoryrpittau, e.g https://review.opendev.org/#/c/728942/4/ironic/privsep/iscsi.py we could remove run_as_root=True in the calls16:12
patchbotpatch 728942 - ironic - Migration from oslo.rootwrap to oslo.privsep - 4 patch sets16:12
rpittauyep16:12
iurygregoryand have the correct privilege16:13
rpittauyes, that's the tricky part :)16:13
iurygregorythat is based on the capabilities we set16:13
iurygregoryok I will go with the path "die run_as_root" XD16:15
TheJuliafyi, I just created https://meetpad.opendev.org/ironic16:15
TheJuliaanyone can use that16:15
iurygregorywill just confirm with the oslo people that is ok =)16:15
rpittaubye everyone! o/16:17
*** rpittau is now known as rpittau|afk16:17
TheJuliagoodnight!16:17
rpittau|afktnx16:17
* TheJulia goes back to emails16:18
*** Qianbiao has quit IRC16:19
iurygregorybye everyone16:22
dtantsurfurniture won't assemble itself, I have to go16:22
*** dtantsur is now known as dtantsur|afk16:22
dtantsur|afko/16:22
* arne_wiebalck is off tmrw16:33
arne_wiebalckbye everyone o/16:33
*** ricolin has quit IRC16:36
TheJuliaheh16:41
*** k_mouza has quit IRC16:53
openstackgerritMerged openstack/ironic master: devstack: Use uwsgi binary from path; temporary disable grenade  https://review.opendev.org/73115916:55
openstackgerritMerged openstack/ironic-inspector master: devstack: Use uwsgi binary from path; temporary disable grenade  https://review.opendev.org/73554716:55
openstackgerritMerged openstack/ironic master: Make redfish boot interface to use `network_data`  https://review.opendev.org/68827217:02
*** dougsz has quit IRC17:02
*** derekh has quit IRC17:08
*** zaneb has joined #openstack-ironic17:12
donnydTheJulia:  I ended up figuring out how to get it all working with no keystone17:19
*** uzumaki has quit IRC17:45
TheJuliadonnyd: what was it specifically? a quick doc patch would be appreciated17:47
TheJuliaAlso, is anyone interested in text for an ironic website?17:47
donnydTheJulia: I will work one up17:49
donnydauth_type needed to be set to noauth in keystone_authtoken17:49
TheJuliathe keystone_authtoken changes all make my head hurt, so it definitely sounds like something to note in docs :\18:10
openstackgerritJames Denton proposed openstack/networking-generic-switch master: VLAN not tagged on every switchs  https://review.opendev.org/55705118:19
jamesdenton^^ would help to know if i'm on the right track with that particular unity test18:19
jamesdenton*unit18:19
TheJuliajamesdenton: sure, I can take a look a little later18:20
jamesdentonsure, whenever it's convenient. thanks!18:20
TheJuliaSo at some point, I guess we dropped autodoc from ironic...18:24
TheJuliareplaced by apidoc18:26
*** kaifeng has quit IRC18:27
TheJuliayay for a typo18:27
openstackgerritJulia Kreger proposed openstack/ironic-python-agent master: Fix apidoc build  https://review.opendev.org/73471218:30
NobodyCamMorning Ironic'er folks 👋19:07
*** dsneddon has quit IRC19:11
TheJuliagood morning NobodyCam19:13
openstackgerritHarald Jensås proposed openstack/ironic master: Switch Ironic to openstacksdk for Neutron  https://review.opendev.org/73487319:20
*** dsneddon has joined #openstack-ironic19:27
*** tzumainn has quit IRC19:32
iurygregoryTheJulia, I'm interested (re text for ironic website) =)19:37
iurygregorymorning NobodyCam19:37
*** tzumainn has joined #openstack-ironic19:46
TheJuliaiurygregory: I'll send you the link20:00
iurygregoryTheJulia, ack =)20:01
TheJuliaSo it looks like someone is not pleased with the python-dracclient docs on the mailing list20:19
TheJuliaWhile... not exactly the way to send commentary or feedback, they raise a valid point that I published at least an internal to the package change.20:20
TheJuliaSee: http://lists.openstack.org/pipermail/openstack-discuss/2020-June/thread.html#1545820:20
TheJuliacdearborn: rpioso: It looks like the docs that are being published are not actually being published but are from >4 years ago.  The opendev infra folks can surely help on removing the old doc site. It looks like there is no documentation publishing job which would likely be helpful for people to be able to see the state of things and comment.20:23
iurygregoryouch20:25
iurygregorythe end of the email is very unpleasant =(20:26
TheJuliaIndeed20:26
TheJuliaI suspect they did not realize they were emailing a mailing list?!20:26
iurygregoryI hope so20:27
iurygregorywe need to try to believe on the good side of people XD20:28
TheJuliaIndeed20:29
*** stevebaker has joined #openstack-ironic20:51
cdearbornHey TheJulia, iurygregory, yes, just saw the email and replied.  I totally understand the frustration.  We haven't been very diligent about keeping the dracclient docs up to date.  Will take a look at the docs publishing.  Thanks!20:53
TheJuliacdearborn: Thanks <320:55
iurygregorycdearborn,++20:55
TheJuliaYeah, I totally get it too and there are a lot of plugins to make super pretty docs20:55
TheJuliaAnd... sometimes we all have things that need to be fixed20:55
TheJuliasuch as https://review.opendev.org/#/c/734712/20:56
patchbotpatch 734712 - ironic-python-agent - Fix apidoc build - 7 patch sets20:56
TheJulia(which is a decent apidoc example)20:56
stevebakermorning20:57
openstackgerritTzu-Mainn Chen proposed openstack/ironic master: Allow node vif attach to specify port_uuid or portgroup_uuid  https://review.opendev.org/73178020:59
openstackgerritJulia Kreger proposed openstack/ironic master: Add a driver compatability matrix  https://review.opendev.org/73371620:59
TheJuliao/ stevebaker20:59
TheJuliastevebaker: any chance I could convince you to make a <5 minute basic authentication demo?20:59
TheJuliavideo that is20:59
TheJulia(bonus points for posting it to youtube or something, btw)21:00
iurygregorymorning stevebaker o/21:01
stevebakerTheJulia: yeah I could do that. Would the audience be folk who want to deploy ironic standalone?21:02
TheJuliacdearborn: great reply to the tread21:02
TheJuliastevebaker: I think so21:03
cdearbornTheJulia, thanks!  Honestly, I'm excited to have a known user of dracclient (hopefully)21:03
stevebakerTheJulia: I might finish off json-rpc support first, so I can include that21:04
stevebakeriurygregory: hi!21:04
TheJuliastevebaker: if you record it with that still in flight, I think that is okay. I'm just thinking something for sprint demos, and posting to youtube would be kickass IMO21:04
cdearbornTheJulia, and thanks for the patch!21:05
TheJuliacdearborn: least I could do :)21:05
* TheJulia goes back to populating the deploy interface matrix21:06
stevebakerTheJulia: ack21:06
openstackgerritJulia Kreger proposed openstack/ironic master: Add a driver compatability matrix  https://review.opendev.org/73371621:13
* TheJulia wonders why her memory limit change hates her21:25
TheJuliaeek Stderr: 'Error setting Chassis Boot Parameter 5\n'21:30
*** threestrands has joined #openstack-ironic21:36
*** gmann is now known as gmann_afk21:39
*** kaiokmo has quit IRC21:42
openstackgerritJulia Kreger proposed openstack/ironic master: Guard conductor from consuming all of the ram  https://review.opendev.org/72648321:59
openstackgerritJulia Kreger proposed openstack/ironic master: Iso booting via redfish virtual media  https://review.opendev.org/72748022:04
openstackgerritJulia Kreger proposed openstack/ironic master: iPXE ISO Ramdisk booting  https://review.opendev.org/72946422:04
openstackgerritJames Denton proposed openstack/networking-generic-switch master: VLAN not tagged on every switchs  https://review.opendev.org/55705122:10
jamesdentonfunny... you actually have to pass data to the test to make it work. smh22:15
TheJuliajamesdenton: heh22:18
TheJuliaso... interestingly enough the item in the old launchpad records for networking-generic-switch doesn't map out to a story in storyboard22:18
TheJuliahttps://storyboard.openstack.org/#!/project/956 <-- Ideally we would map the change to something in that list (or create one)22:19
TheJuliajamesdenton: looks like the only thing your really missing, as far as I can tell is something involving the _is_port_binding method22:23
TheJuliaaside from that, it looks good to me.. I'd stylistically do things a little bit differently but your doing it in the same style of the file so ++22:23
jamesdentoni'm totally open to suggestions, so feel free to offer them if you'd like. And I didn't think that would be enough tests, just wanted to make sure i was on the right track22:31
TheJuliaYour definitely on it22:32
TheJuliathanks!22:32
jamesdentonthanks!22:32
TheJuliaand fwiw, I prefer in-file continuity above most else22:32
TheJuliaWell, it looks like my grocery delivery is going to be here early22:33
TheJuliaWhich makes this a good time to wrap up the day. Have a wonderful day@22:34
TheJulias/@/!/22:34
*** rcernin has joined #openstack-ironic23:16

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!