*** Goneri has quit IRC | 00:08 | |
* TheJulia begins the pre-heatening for the pre-bake of the crust | 00:14 | |
*** cdearborn has quit IRC | 00:30 | |
openstackgerrit | Julia Kreger proposed openstack/ironic-python-agent master: Fix apidoc build https://review.opendev.org/734712 | 00:48 |
---|---|---|
*** Goneri has joined #openstack-ironic | 00:49 | |
*** Goneri has quit IRC | 01:03 | |
*** jawad_axd has joined #openstack-ironic | 01:12 | |
*** threestrands has joined #openstack-ironic | 01:19 | |
openstackgerrit | Julia Kreger proposed openstack/ironic-python-agent master: Fix apidoc build https://review.opendev.org/734712 | 01:27 |
*** Qianbiao has joined #openstack-ironic | 01:28 | |
openstackgerrit | Julia Kreger proposed openstack/ironic master: WIP Add a driver compatability matrix https://review.opendev.org/733716 | 01:35 |
*** jawad_axd has quit IRC | 01:45 | |
openstackgerrit | Julia Kreger proposed openstack/ironic-python-agent master: WIP: Handle odd timeouts https://review.opendev.org/734709 | 01:45 |
openstackgerrit | Julia Kreger proposed openstack/ironic master: WIP Add a driver compatability matrix https://review.opendev.org/733716 | 01:48 |
openstackgerrit | Julia Kreger proposed openstack/ironic-specs master: Clean up specs https://review.opendev.org/733411 | 01:50 |
* TheJulia wonders if I need to put up a sign for https://review.opendev.org/#/c/720100/ | 01:51 | |
patchbot | patch 720100 - ironic-specs - Victoria Cycle Priorities - 7 patch sets | 01:51 |
openstackgerrit | Julia Kreger proposed openstack/ironic-python-agent master: Fix apidoc build https://review.opendev.org/734712 | 01:52 |
*** tzumainn has quit IRC | 01:55 | |
*** rh-jelabarre has quit IRC | 01:58 | |
*** Qianbiao has quit IRC | 02:12 | |
*** Qianbiao has joined #openstack-ironic | 02:13 | |
Qianbiao | Hello TheJulia | 02:14 |
Qianbiao | I am curious what timezone are you at. | 02:15 |
TheJulia | Qianbiao: GMT-7 | 02:16 |
TheJulia | Qianbiao: so I'm looking at 728123 (sorry, finally, things have been chaos recently) | 02:24 |
TheJulia | and I noticed you don't bump requirements. Are the methods already present in your client library? | 02:24 |
Qianbiao | TheJulia yes | 02:24 |
Qianbiao | all feature has been finished. and released with python-ibmcclient lib | 02:25 |
Qianbiao | TheJulia thanks in adavance. I know all core members is very buzy recently. | 02:27 |
TheJulia | Qianbiao: does the minimum version need to be updated in the requirements text? | 02:28 |
TheJulia | requirements.txt ? | 02:28 |
Qianbiao | has been updated. in driver-requirements.txt. | 02:28 |
TheJulia | Qianbiao: ok, I noticed you've got some questions, so I'm leaving some comments, they should be relatively quick | 02:28 |
TheJulia | Qianbiao: awesome | 02:28 |
Qianbiao | TheJulia the review should be pretty simple. To reduce review workloud, i have move all logical implementation to client lib. | 02:32 |
TheJulia | That is much appreciated :) | 02:36 |
*** jdandrea has quit IRC | 02:37 | |
Qianbiao | :) | 02:37 |
TheJulia | Qianbiao: feedback posted, let me know if you have any questions, but also... I'm likely going to bed soon | 02:38 |
Qianbiao | sure, i will reply to them and you may see them when you wake up. :) | 02:38 |
Qianbiao | good night. | 02:39 |
TheJulia | goodnight! Have a wonderful day! | 02:45 |
*** rcernin has quit IRC | 02:53 | |
*** rcernin_ has joined #openstack-ironic | 02:53 | |
openstackgerrit | Verification of a change to openstack/ironic-python-agent failed: Add ffi development lib to bindep https://review.opendev.org/733821 | 03:07 |
*** rcernin_ has quit IRC | 03:07 | |
*** rcernin_ has joined #openstack-ironic | 03:19 | |
openstackgerrit | QianBiao Ng proposed openstack/ironic master: Feature: Add raid configuration support for ibmc driver https://review.opendev.org/728123 | 03:23 |
*** rcernin_ has quit IRC | 03:24 | |
*** rcernin has joined #openstack-ironic | 03:25 | |
*** yaawang has quit IRC | 04:04 | |
*** yaawang has joined #openstack-ironic | 04:04 | |
*** ricolin has joined #openstack-ironic | 04:23 | |
*** Qianbiao has quit IRC | 04:25 | |
*** diurnalist has quit IRC | 04:31 | |
*** yaawang has quit IRC | 04:40 | |
*** yaawang has joined #openstack-ironic | 04:41 | |
*** jawad_axd has joined #openstack-ironic | 04:48 | |
*** jtomasek has joined #openstack-ironic | 04:48 | |
*** yaawang has quit IRC | 05:00 | |
*** yaawang has joined #openstack-ironic | 05:01 | |
*** dking has quit IRC | 05:47 | |
*** zaneb has quit IRC | 06:17 | |
*** zaneb has joined #openstack-ironic | 06:17 | |
*** vesper has quit IRC | 06:18 | |
*** vesper11 has joined #openstack-ironic | 06:18 | |
*** zaneb has quit IRC | 06:19 | |
*** zaneb has joined #openstack-ironic | 06:21 | |
openstackgerrit | Michael Chapman proposed openstack/ironic master: virtualbmc no longer in global requirements https://review.opendev.org/734748 | 06:26 |
*** Qianbiao has joined #openstack-ironic | 06:37 | |
*** rcernin has quit IRC | 06:44 | |
*** rcernin_ has joined #openstack-ironic | 06:44 | |
*** rcernin_ has quit IRC | 06:50 | |
openstackgerrit | QianBiao Ng proposed openstack/ironic master: Feature: Add raid configuration support for ibmc driver https://review.opendev.org/728123 | 06:52 |
*** rcernin_ has joined #openstack-ironic | 06:52 | |
arne_wiebalck | Good morning, ironic! | 06:58 |
*** rcernin_ has quit IRC | 06:59 | |
*** iurygregory has quit IRC | 07:11 | |
*** ricolin_ has joined #openstack-ironic | 07:18 | |
*** ricolin has quit IRC | 07:20 | |
*** ricolin has joined #openstack-ironic | 07:21 | |
Qianbiao | good morning arnewiebalck | 07:21 |
Qianbiao | * arne_wiebalck | 07:21 |
*** rpittau|afk is now known as rpittau | 07:21 | |
rpittau | good morning ironic! o/ | 07:21 |
*** ricolin_ has quit IRC | 07:23 | |
*** rcernin_ has joined #openstack-ironic | 07:23 | |
*** rcernin_ has quit IRC | 07:28 | |
*** ricolin_ has joined #openstack-ironic | 07:30 | |
arne_wiebalck | Hey Qianbiao rpittau o/ | 07:32 |
rpittau | hey arne_wiebalck :) | 07:32 |
*** ricolin has quit IRC | 07:33 | |
Qianbiao | good morning arne_wiebalck and rpittau | 07:33 |
*** iurygregory has joined #openstack-ironic | 07:33 | |
rpittau | hey Qianbiao :) | 07:33 |
iurygregory | good morning arne_wiebalck and Ironic o/ | 07:33 |
iurygregory | hey rpittau and Qianbiao o/ | 07:33 |
*** ricolin_ has quit IRC | 07:34 | |
rpittau | hey iurygregory :) | 07:34 |
Qianbiao | Looks like I am a member of ironic too, o/ | 07:34 |
Qianbiao | Fake member :) | 07:34 |
iurygregory | lol | 07:34 |
*** dustinc has quit IRC | 07:35 | |
Qianbiao | rpittau thanks for the review. checking. | 07:50 |
rpittau | Qianbiao: sure :) | 07:50 |
openstackgerrit | Riccardo Pittau proposed openstack/ironic master: Fix uefi jobs with native ubuntu ovmf package https://review.opendev.org/716889 | 07:55 |
*** alexmcleod has joined #openstack-ironic | 07:56 | |
openstackgerrit | Iury Gregory Melo Ferreira proposed openstack/bifrost master: Add openstack collection https://review.opendev.org/734592 | 07:59 |
openstackgerrit | Riccardo Pittau proposed openstack/ironic master: Convert ironic-tempest-ipa-wholedisk-bios-agent_ipmitool to dib https://review.opendev.org/734759 | 07:59 |
*** rcernin_ has joined #openstack-ironic | 07:59 | |
Qianbiao | rpittau did not understand: ibmc.rst#Line 207: | 08:03 |
Qianbiao | 'to avoid' means | 08:03 |
*** rcernin_ has quit IRC | 08:03 | |
Qianbiao | line 221 nit: add comma ',' | 08:03 |
iurygregory | Qianbiao, on L207 you need to use to avoid instead of avoid | 08:06 |
Qianbiao | This is to avoid instead of "This is avoid" ? | 08:06 |
iurygregory | yes | 08:07 |
Qianbiao | ok | 08:07 |
Qianbiao | this is out of my english acknowleage. :) | 08:08 |
iurygregory | no worries | 08:08 |
Qianbiao | I thought it's used like "To avoid something, xxxx" | 08:08 |
*** lucasagomes has joined #openstack-ironic | 08:14 | |
*** kaiokmo has joined #openstack-ironic | 08:18 | |
openstackgerrit | QianBiao Ng proposed openstack/ironic master: Feature: Add raid configuration support for ibmc driver https://review.opendev.org/728123 | 08:20 |
Qianbiao | ^^ thanks rpittau, patch 13 has been submit according to your review. | 08:20 |
patchbot | No data found for patch 13 | 08:20 |
openstackgerrit | Riccardo Pittau proposed openstack/ironic master: [DNM] Test CI with Ubuntu focal https://review.opendev.org/734763 | 08:23 |
*** ravsingh has joined #openstack-ironic | 08:24 | |
rpittau | anyone with a minute to spare please review https://review.opendev.org/731679 | 08:25 |
patchbot | patch 731679 - virtualbmc - Remove unneded Babel config - 5 patch sets | 08:25 |
iurygregory | rpittau, doing now | 08:26 |
rpittau | thanks :) | 08:26 |
*** ricolin has joined #openstack-ironic | 08:26 | |
*** diurnalist has joined #openstack-ironic | 08:27 | |
Qianbiao | rpittau commit message "unneded" or unneeded | 08:29 |
rpittau | Qianbiao: unneeded | 08:30 |
*** diurnalist has quit IRC | 08:31 | |
*** dtantsur|afk is now known as dtantsur | 08:32 | |
dtantsur | morning ironic | 08:32 |
iurygregory | morning dtantsur | 08:33 |
iurygregory | good news for you, collection works =) | 08:33 |
dtantsur | \o/ | 08:35 |
dtantsur | that's good news indeed | 08:35 |
iurygregory | after 3 more patches.. locally it was working | 08:35 |
iurygregory | but for CI i had to change scripts/test-bifrost also hehe | 08:35 |
openstackgerrit | Iury Gregory Melo Ferreira proposed openstack/ironic master: Add api-ref for indicators API https://review.opendev.org/732149 | 08:41 |
dtantsur | iurygregory: the patch LGTM, only one question: do we need to update the docs to mention ANSIBLE_COLLECTIONS_PATH? | 08:42 |
iurygregory | we probably should | 08:43 |
openstackgerrit | Merged openstack/sushy-cli master: drop mock from lower-constraints https://review.opendev.org/734556 | 08:45 |
iurygregory | at least mention that they should set ANSIBLE_COLLECTIONS_PATHS to the location where they will be installed | 08:46 |
iurygregory | if they are not using venv it should install in the default location and they should face any problems | 08:47 |
iurygregory | rpittau, I just saw your comment, I think we don't need to have the export in the non virtualenv so I will just remove L69 | 08:48 |
rpittau | iurygregory: I added one more after that, how is ANSIBLE_COLLECTIONS_PATHS set when not in venv? (if we care) | 08:50 |
iurygregory | rpittau, it has a default value | 08:50 |
dtantsur | I think the venv is more problematic | 08:51 |
rpittau | iurygregory: ok, maybe add a definition for that as it's done for ANSIBLE_COLLECTION_REQ | 08:51 |
dtantsur | since it's the default, we need to document the right value to set | 08:51 |
rpittau | yeah | 08:51 |
rpittau | also it's really weird that we need to export that in test-bifrost.sh | 08:52 |
dtantsur | rpittau: could you check this backport please: https://review.opendev.org/734594 | 08:55 |
patchbot | patch 734594 - ironic-python-agent (stable/ussuri) - Make the install_bootloader command asynchronous - 1 patch set | 08:55 |
rpittau | done | 08:56 |
dtantsur | thx | 08:57 |
openstackgerrit | Merged openstack/ironic-ui master: Cleanup py27 support https://review.opendev.org/734593 | 09:02 |
dtantsur | TheJulia: could you please add your voice to https://doodle.com/poll/5yg93gv7casu3ate ? | 09:13 |
openstackgerrit | Dmitry Tantsur proposed openstack/bifrost master: Quick start Bifrost CLI https://review.opendev.org/733559 | 09:41 |
openstackgerrit | Merged openstack/sushy master: Make Volume/VolumeCollection operations blocking https://review.opendev.org/730990 | 09:42 |
openstackgerrit | Merged openstack/virtualbmc master: drop mock from lower-constraints https://review.opendev.org/734573 | 09:45 |
openstackgerrit | Merged openstack/virtualbmc master: Remove unneded Babel config https://review.opendev.org/731679 | 09:51 |
*** sshnaidm|afk is now known as sshnaidm | 10:14 | |
*** ociuhandu has joined #openstack-ironic | 10:18 | |
*** rpittau is now known as rpittau|bbl | 10:19 | |
*** ociuhandu has quit IRC | 10:21 | |
*** ociuhandu has joined #openstack-ironic | 10:23 | |
*** rcernin_ has joined #openstack-ironic | 10:29 | |
*** rcernin_ has quit IRC | 10:34 | |
openstackgerrit | Verification of a change to openstack/ironic failed: Add `get_node_network_data` to non-Neutron NetworkInterface https://review.opendev.org/688266 | 10:37 |
*** ociuhandu has quit IRC | 10:41 | |
*** k_mouza has joined #openstack-ironic | 10:47 | |
*** derekh has joined #openstack-ironic | 10:49 | |
*** tkajinam has quit IRC | 10:53 | |
openstackgerrit | Dmitry Tantsur proposed openstack/bifrost master: Quick start Bifrost CLI https://review.opendev.org/733559 | 11:16 |
*** threestrands has quit IRC | 11:16 | |
openstackgerrit | Merged openstack/ironic-python-agent stable/ussuri: Make the install_bootloader command asynchronous https://review.opendev.org/734594 | 11:33 |
iurygregory | dtantsur, I was wondering here if we only want to let the user specify ANSIBLE_COLLECTIONS_PATHS if he is not using the virtualenv | 11:37 |
dtantsur | iurygregory: mm, will it even work without specifying the paths? | 11:41 |
*** zigo has quit IRC | 11:41 | |
iurygregory | dtantsur, well we can make it work | 11:41 |
dtantsur | if we can, let's make it work :) | 11:41 |
iurygregory | if ANSIBLE_COLLECTIONS_PATHS is set we install with -p, if not set install without -p | 11:41 |
iurygregory | so it will be installed in the default given by ansible.cfg | 11:42 |
*** rcernin_ has joined #openstack-ironic | 11:48 | |
*** k_mouza has quit IRC | 11:48 | |
*** k_mouza has joined #openstack-ironic | 11:51 | |
*** rcernin_ has quit IRC | 11:53 | |
dtantsur | mm, so how will it work with a venv? | 11:56 |
*** zigo has joined #openstack-ironic | 11:56 | |
*** rh-jelabarre has joined #openstack-ironic | 11:57 | |
iurygregory | let me do some tests here | 11:58 |
openstackgerrit | Dmitry Tantsur proposed openstack/bifrost master: Quick start Bifrost CLI https://review.opendev.org/733559 | 12:00 |
openstackgerrit | Arne Wiebalck proposed openstack/ironic master: [doc] Fix indentation in admin/troubleshooting https://review.opendev.org/734806 | 12:01 |
Qianbiao | anyone familiar with metal3 may help look at this comment https://github.com/metal3-io/baremetal-operator/issues/529#issuecomment-641870829 | 12:03 |
*** rpittau|bbl is now known as rpittau | 12:05 | |
*** derekh has quit IRC | 12:06 | |
*** derekh has joined #openstack-ironic | 12:06 | |
dtantsur | Qianbiao: not sure, probably ironic-inspector logs could be useful too | 12:11 |
Qianbiao | dtantsur thanks will check | 12:11 |
*** derekh has quit IRC | 12:12 | |
*** derekh has joined #openstack-ironic | 12:12 | |
Qianbiao | dtantsur It says "Introspection data storage is disabled" | 12:16 |
*** ravsingh has quit IRC | 12:20 | |
dtantsur | Qianbiao: did you change any configuration?\ | 12:23 |
*** derekh has quit IRC | 12:24 | |
Qianbiao | no, i did not update my inspector.conf file, because it's very old.. | 12:24 |
*** derekh has joined #openstack-ironic | 12:24 | |
Qianbiao | a template from rocky version | 12:24 |
dtantsur | oh, so you're not using the metal3 provided inspector? | 12:24 |
Qianbiao | i see, it seems i need to update "store_data = database" | 12:24 |
Qianbiao | yes | 12:24 |
dtantsur | yep | 12:25 |
Qianbiao | i use a standalone ironic env | 12:25 |
dtantsur | it wasn't there in rocky though | 12:25 |
Qianbiao | will try thanks dtantsur | 12:25 |
*** rloo has joined #openstack-ironic | 12:29 | |
openstackgerrit | Riccardo Pittau proposed openstack/ironic master: Enforce autospec in test_rpc_api and test_steps https://review.opendev.org/734132 | 12:43 |
openstackgerrit | Riccardo Pittau proposed openstack/ironic master: Enforce autospec in test_base_manager https://review.opendev.org/734811 | 12:43 |
TheJulia | good morning | 12:43 |
kaiokmo | morning! | 12:44 |
rpittau | good morning TheJulia :) | 12:44 |
openstackgerrit | Dmitry Tantsur proposed openstack/bifrost master: Add an option to use pre-built DIB images https://review.opendev.org/734812 | 12:45 |
TheJulia | how is everyone this morning | 12:46 |
openstackgerrit | Riccardo Pittau proposed openstack/ironic master: [DNM] Test CI with Ubuntu focal https://review.opendev.org/734763 | 12:47 |
openstackgerrit | Dmitry Tantsur proposed openstack/bifrost master: Quick start Bifrost CLI https://review.opendev.org/733559 | 12:47 |
rpittau | I choose the other envelope | 12:47 |
dtantsur | morning TheJulia | 12:47 |
dtantsur | TheJulia: sleepy, so sleepy | 12:47 |
*** Goneri has joined #openstack-ironic | 12:48 | |
Qianbiao | dtantsur inspect finished :). thanks. | 12:51 |
Qianbiao | morning TheJulia | 12:51 |
openstackgerrit | Dmitry Tantsur proposed openstack/bifrost master: Install packages all at once instead of looping over them https://review.opendev.org/734826 | 12:53 |
openstackgerrit | Dmitry Tantsur proposed openstack/bifrost master: Add an option to use pre-built DIB images https://review.opendev.org/734812 | 12:54 |
openstackgerrit | Dmitry Tantsur proposed openstack/bifrost master: Quick start Bifrost CLI https://review.opendev.org/733559 | 12:54 |
*** ociuhandu has joined #openstack-ironic | 12:56 | |
openstackgerrit | Arne Wiebalck proposed openstack/ironic master: [doc] Fix indentation in admin/troubleshooting https://review.opendev.org/734806 | 12:56 |
dtantsur | TheJulia: could you check https://review.opendev.org/#/c/733111/ when you have some time? It's a bit non-trivial and could use your expertise | 12:57 |
patchbot | patch 733111 - bifrost - Get rid of the shade dependency - 5 patch sets | 12:57 |
*** rloo has quit IRC | 13:01 | |
*** rajinir has quit IRC | 13:01 | |
*** mkowalski has quit IRC | 13:01 | |
TheJulia | dtantsur: I started looking at it around 7 PM last night and was just like "nope, not tonight!" | 13:01 |
dtantsur | I can imagine :D | 13:02 |
*** ociuhandu has quit IRC | 13:02 | |
openstackgerrit | Dmitry Tantsur proposed openstack/bifrost master: Add an option to use pre-built DIB images https://review.opendev.org/734812 | 13:03 |
openstackgerrit | Dmitry Tantsur proposed openstack/bifrost master: Quick start Bifrost CLI https://review.opendev.org/733559 | 13:03 |
*** rajinir has joined #openstack-ironic | 13:04 | |
openstackgerrit | Riccardo Pittau proposed openstack/ironic master: Convert ironic-tempest-ipa-wholedisk-bios-agent_ipmitool to dib https://review.opendev.org/734759 | 13:06 |
*** jdandrea has joined #openstack-ironic | 13:06 | |
*** rloo has joined #openstack-ironic | 13:07 | |
dtantsur | inc/python:get_from_global_requirements:236 : die 236 'Can'\''t find package virtualbmc in requirements' | 13:07 |
dtantsur | this seems to be breaking metalsmith all of a sudden | 13:07 |
*** ravsingh has joined #openstack-ironic | 13:07 | |
rpittau | dtantsur: virtualbmc was removed by global reqs | 13:07 |
*** mkowalski has joined #openstack-ironic | 13:07 | |
dtantsur | so nice of them | 13:07 |
TheJulia | wtf | 13:08 |
* TheJulia notes the coffee cup only has coffee for it is logically waaaaaaay too early for anything else | 13:09 | |
*** ociuhandu has joined #openstack-ironic | 13:09 | |
dtantsur | I've proposed a revert | 13:09 |
*** ociuhandu has quit IRC | 13:11 | |
TheJulia | ok | 13:11 |
*** ociuhandu has joined #openstack-ironic | 13:12 | |
openstackgerrit | Sean McGinnis proposed openstack/ironic master: Add virtualbmc as an extra dependency https://review.opendev.org/734836 | 13:27 |
derekh | TheJulia: the release of sushy-tools for the reboot fix https://review.opendev.org/#/c/734837/ | 13:28 |
patchbot | patch 734837 - releases - Release sushy-tools 0.10.0 - 1 patch set | 13:28 |
*** cdearborn has joined #openstack-ironic | 13:28 | |
openstackgerrit | Riccardo Pittau proposed openstack/bifrost master: Convert with_items to loop https://review.opendev.org/733847 | 13:28 |
openstackgerrit | Riccardo Pittau proposed openstack/bifrost master: Convert with_items to loop https://review.opendev.org/733847 | 13:30 |
TheJulia | derekh: done | 13:34 |
derekh | TheJulia: ty | 13:35 |
*** ociuhandu has quit IRC | 13:42 | |
TheJulia | derekh: thanks for proposing the release! | 13:45 |
*** jawad_axd has quit IRC | 13:47 | |
*** tzumainn has joined #openstack-ironic | 13:48 | |
*** ociuhandu has joined #openstack-ironic | 13:58 | |
*** ociuhandu has quit IRC | 14:03 | |
*** ociuhandu has joined #openstack-ironic | 14:05 | |
Qianbiao | oh finally, metal3 provisioning test against ibmc finished. | 14:08 |
dtantsur | \o/ | 14:08 |
Qianbiao | But i did not see any metal3 document desc how to set up raid configuration. | 14:08 |
dtantsur | I don't think it's supported (yet) | 14:09 |
Qianbiao | ~~ ok | 14:09 |
dtantsur | Qianbiao: like https://github.com/metal3-io/baremetal-operator/pull/292/ | 14:10 |
openstackgerrit | Merged openstack/ironic master: Add virtualbmc as an extra dependency https://review.opendev.org/734836 | 14:11 |
Qianbiao | dtantsur nice, but it seems metal3 development is not quite active. | 14:12 |
dtantsur | it's active, just everyone has a lot of different priorities | 14:13 |
dtantsur | RAID doesn't seem to be high on the list for people from Red Hat at the moment | 14:13 |
iurygregory | ^ this | 14:13 |
Qianbiao | dtantsur personal feelings, when asking questions, most time, it need a long time to get answer. | 14:14 |
*** bfournie has quit IRC | 14:15 | |
dtantsur | Qianbiao: have you tried their slack or their upstream mailing list? | 14:15 |
Qianbiao | yes, i am on slack channel. | 14:15 |
openstackgerrit | Verification of a change to openstack/bifrost failed: Set default deploy/rescue kernel/ramdisk in ironic.conf https://review.opendev.org/733860 | 14:17 |
Qianbiao | dtantsur btw, when you are convenience, take a look at https://review.opendev.org/#/c/728123/, since TheJulia and rpittau have gave their review, i think it's very close to start merge workflow :) | 14:19 |
patchbot | patch 728123 - ironic - Feature: Add raid configuration support for ibmc d... - 13 patch sets | 14:19 |
*** sshnaidm is now known as sshnaidm|bbl | 14:23 | |
dtantsur | Qianbiao: reviewed. Btw great job writing such detailed docs on *how* things work | 14:28 |
*** rcernin_ has joined #openstack-ironic | 14:28 | |
Qianbiao | dtantsur thanks, checking. | 14:31 |
*** rcernin_ has quit IRC | 14:33 | |
*** bfournie has joined #openstack-ironic | 14:34 | |
NobodyCam | Good Morning Ironic folks, jlvillal sorry I missed you yesterday :) doing okay for being all stay at home, like! :) | 14:40 |
jlvillal | Hi NobodyCam :) I'm about the same. Don't leave the house too often :( | 14:46 |
*** ociuhandu has quit IRC | 14:50 | |
iurygregory | morning NobodyCam happy hump day =) | 14:51 |
*** diurnalist has joined #openstack-ironic | 14:57 | |
*** priteau has joined #openstack-ironic | 14:58 | |
rpittau | hey NobodyCam :) | 15:02 |
*** dking has joined #openstack-ironic | 15:03 | |
rpittau | TheJulia, dtantsur, should we ask for a stable ussuri and train release for ironic-lib? Asking because of this recent fix: https://review.opendev.org/#/q/I82a94e68e1aa1f634c7f0877ccd674574d1c9bb0 | 15:07 |
dtantsur | morning NobodyCam, jlvillal | 15:08 |
dtantsur | rpittau: yep | 15:09 |
rpittau | actually only ussuri | 15:09 |
rpittau | train has it in 2.21.1 | 15:09 |
TheJulia | rpittau: if you want to propose the release, I'll be happy to check it and +1 it | 15:10 |
rpittau | TheJulia: sure :) | 15:10 |
*** dustinc has joined #openstack-ironic | 15:11 | |
openstackgerrit | Harald Jensås proposed openstack/ironic master: Switch Ironic to openstacksdk for Neutron https://review.opendev.org/734873 | 15:11 |
Qianbiao | hi, if a review has got a +2, but there are still something need to patch according to this review. Should i submit new patch after current review merged? or I can just submit a new patch in current review. | 15:14 |
Qianbiao | ~~ a stupid question. ^^ | 15:14 |
dtantsur | Qianbiao: you have options: you can decide to update the patch in question OR you post a new patch on top of that once it is approved | 15:15 |
dtantsur | (you don't strictly need to wait for the 1st patch to be completely merged, just be careful not to rebase it accidentally) | 15:16 |
* jlvillal waves at dtantsur | 15:17 | |
Qianbiao | Sure, I hope I could just submit a new patch upon this review. But if i do so, core members need to redo +2, so i am afraid this will waste their times. | 15:18 |
jlvillal | dtantsur, Dobroye utro | 15:19 |
dtantsur | :) | 15:19 |
dtantsur | Qianbiao: yep, that's why it's recommended to create a new review on top of the old one | 15:19 |
dtantsur | unless you get more important comments later | 15:19 |
Qianbiao | i see. :) | 15:19 |
Qianbiao | got thanks dtantsur | 15:19 |
rpittau | TheJulia, dtantsur: https://review.opendev.org/734875 | 15:20 |
patchbot | patch 734875 - releases - Release ironic-lib 4.2.1 for ussuri - 1 patch set | 15:20 |
dtantsur | thanks! | 15:20 |
rpittau | :) | 15:21 |
jlvillal | dtantsur, Marina wanted me to tell you hello. She said to me, "he's a good guy" :) | 15:21 |
dking | TheJulia: There was some discussion about container images during the PTG. Did that go anywhere? | 15:22 |
rpittau | mmmm ironic-standalone seems to work with minimal change in ubuntu focal with Python 3.8, which is kind of scary -> https://review.opendev.org/734763 | 15:24 |
patchbot | patch 734763 - ironic - [DNM] Test CI with Ubuntu focal - 2 patch sets | 15:24 |
dtantsur | jlvillal: heh, that's sweet of her :) send her my greetings as well | 15:25 |
dtantsur | rpittau: well, we have a bifrost job passing on focal | 15:26 |
rpittau | that's right, I was expecting more shenanigans though :) | 15:26 |
dtantsur | wait until you get to the multinode jobs :D | 15:28 |
rpittau | oh gosh | 15:28 |
rpittau | the uefi jobs is already dominating my nightmares enough, now with the ironic-python-agent that can't find any suitable root devaice | 15:31 |
* dtantsur thinks about UEFI support in Bifrost and blood freezes in his veins | 15:33 | |
* rpittau needs more vanilla ice-cream | 15:36 | |
openstackgerrit | Riccardo Pittau proposed openstack/ironic master: Convert ironic-tempest-ipa-wholedisk-bios-agent_ipmitool to dib https://review.opendev.org/734759 | 15:36 |
openstackgerrit | Riccardo Pittau proposed openstack/ironic master: Convert ironic-tempest-ipa-wholedisk-bios-agent_ipmitool to dib https://review.opendev.org/734759 | 15:36 |
*** Qianbiao is now known as Qianbiao|afk | 15:36 | |
openstackgerrit | Riccardo Pittau proposed openstack/ironic master: Convert ironic-tempest-ipa-wholedisk-bios-agent_ipmitool to dib https://review.opendev.org/734759 | 15:37 |
NobodyCam | morning jlvillal iurygregory rpittau and ofcourse dtantsur :) | 15:44 |
jlvillal | :) | 15:44 |
*** ociuhandu has joined #openstack-ironic | 15:50 | |
*** gyee has joined #openstack-ironic | 15:54 | |
openstackgerrit | Merged openstack/bifrost master: Set default deploy/rescue kernel/ramdisk in ironic.conf https://review.opendev.org/733860 | 15:55 |
TheJulia | dking: There was no real objection besides the natural concern that they take on a "one way to" sort of pattern, which in itself is concerning. So the concept of like Dockerfiles was agreeable, but creating/posting pre-built images not as much, and the hope is to try and make ironic easier to adopt in general. | 15:56 |
TheJulia | I think that sums it up | 15:56 |
dking | Okay. I didn't know if anybody every got with the Kolla group regarding any of that, since they were in a different meeting at the time, and there was some mention about the overlap. | 15:57 |
TheJulia | Yeah, I don't think there has been an opportunity for anyone to really sync up | 15:58 |
TheJulia | mgoddard: ^^^ | 15:58 |
*** lucasagomes has quit IRC | 16:00 | |
rpittau | bye everyone! o/ | 16:07 |
*** rpittau is now known as rpittau|afk | 16:07 | |
mgoddard | TheJulia: yeah, we should talk about this at some point. There are kolla images for ironic on Dockerhub | 16:19 |
*** rloo has quit IRC | 16:33 | |
TheJulia | mgoddard: I don't think that is a bad thing, they are just opinionated in kolla's use case | 16:36 |
TheJulia | ?use cases? | 16:36 |
*** ravsingh has quit IRC | 16:36 | |
TheJulia | tl;dr not a bad thing in my mind, but yes, we should talk because I don't think there is or really can be a single path to use | 16:36 |
TheJulia | (no matter how much we may want one) | 16:36 |
mgoddard | they're kind of opinionated, but you could also just pick them up and run them | 16:37 |
*** gyee has quit IRC | 16:42 | |
*** ociuhandu has quit IRC | 16:46 | |
*** rloo has joined #openstack-ironic | 16:50 | |
*** derekh has quit IRC | 17:00 | |
*** priteau has quit IRC | 17:01 | |
*** gyee has joined #openstack-ironic | 17:08 | |
*** dtantsur is now known as dtantsur|afk | 17:10 | |
TheJulia | mostly yes, we've had a few people come in with issues in the past, but surprisingly few | 17:17 |
*** Lucas_Gray has joined #openstack-ironic | 17:31 | |
*** Lucas_Gray has quit IRC | 17:33 | |
openstackgerrit | Merged openstack/bifrost master: Install packages all at once instead of looping over them https://review.opendev.org/734826 | 17:37 |
*** sshnaidm|bbl is now known as sshnaidm | 17:40 | |
*** ociuhandu has joined #openstack-ironic | 17:43 | |
*** ociuhandu has quit IRC | 17:48 | |
*** rloo has quit IRC | 17:56 | |
*** rloo has joined #openstack-ironic | 17:56 | |
*** k_mouza has quit IRC | 18:14 | |
openstackgerrit | Hervé Beraud proposed openstack/ironic master: Use unittest.mock instead of mock https://review.opendev.org/734350 | 18:18 |
openstackgerrit | Hervé Beraud proposed openstack/ironic-inspector master: Use unittest.mock instead of mock https://review.opendev.org/734351 | 18:21 |
*** rcernin_ has joined #openstack-ironic | 18:30 | |
*** rcernin_ has quit IRC | 18:34 | |
*** ricolin has quit IRC | 18:54 | |
*** sshnaidm is now known as sshnaidm|afk | 19:05 | |
*** eliaswimmer_ has joined #openstack-ironic | 19:24 | |
eliaswimmer_ | Hi, install_bootloader in image.py takes a root_uuid as argument. Where is this coming from? | 19:34 |
TheJulia | eliaswimmer_: it gets collected or determined (depending on the deploy interface) and what is written to disk | 19:56 |
eliaswimmer_ | TheJulia: I'm using software raid with uefi and it chooses the wrong partition as root | 19:57 |
TheJulia | eliaswimmer_: I believe it gets that from glance properties in that case | 19:58 |
TheJulia | how so is it getting the wrong value? | 19:58 |
eliaswimmer_ | I'm using bifrost | 19:58 |
eliaswimmer_ | without glance | 19:59 |
TheJulia | okay | 19:59 |
TheJulia | arne_wiebalck: ^^^ fyi | 19:59 |
eliaswimmer_ | that is what I'm trying to find out | 19:59 |
TheJulia | I'm trying to remember how it determines it at the moment without that property | 20:00 |
TheJulia | what is it trying to send as the root_uuid ? | 20:00 |
eliaswimmer_ | from the code in ipa image.py it has to be set somewhere | 20:00 |
eliaswimmer_ | it sends the second md partition | 20:01 |
TheJulia | interesting | 20:01 |
eliaswimmer_ | I will give it an other try to figure it out | 20:03 |
TheJulia | if you look at the driver_internal_info field, do you see a root uuid value? | 20:03 |
eliaswimmer_ | sorry that will take some time | 20:03 |
TheJulia | this is likely where things are going sideways https://github.com/openstack/ironic/blob/dac810aaf41612d0199cd87f900f5c365bc06b4a/ironic/drivers/modules/agent_base.py#L1153-L1171 | 20:03 |
TheJulia | That is likely a relatively easy change to make it be able to be user definable in the iamge | 20:04 |
TheJulia | wait | 20:04 |
TheJulia | you said second md device, that should be the root filesystem | 20:04 |
TheJulia | where is this actually failing? | 20:05 |
eliaswimmer_ | when mounting the root for updating the grub config | 20:06 |
eliaswimmer_ | in my case that's some other partition | 20:06 |
TheJulia | I guess there are multiple partitions inside your disk image? | 20:07 |
eliaswimmer_ | yes, first is efi, second I have to find out, third is root | 20:07 |
TheJulia | that _shouldnt_ break it, but if you ahve any log entries or examples of output that might help us figure out what is going on and how to fix it | 20:08 |
eliaswimmer_ | One fix for uefi we have to add is https://github.com/openstack/ironic-python-agent/blob/master/ironic_python_agent/extensions/image.py#L630-L634 | 20:11 |
eliaswimmer_ | Where we also need to write /etc/grub2-efi.cfg | 20:11 |
eliaswimmer_ | Ok, bad news. Even it fails node is now in state active | 20:31 |
eliaswimmer_ | no deploy logs for this run in ironic | 20:34 |
eliaswimmer_ | I will now run it with rpdb | 20:34 |
eliaswimmer_ | 'root_uuid_or_disk_id': '0x00000000' | 20:38 |
TheJulia | can you share with us some information about the structure of your disk image, as well as what distribution your trying to deploy since it sounds like your distribution's mechanics require something different than what we've tested or expected based on grub's documentation | 20:43 |
TheJulia | 0x00000000 is basically tl;dr for we don't know | 20:43 |
TheJulia | which happens with whole disk images | 20:44 |
eliaswimmer_ | it's a centos 8 image built wit dib | 20:44 |
eliaswimmer_ | block-device-efi, vm, grub2 | 20:45 |
eliaswimmer_ | uses a config drive | 20:45 |
eliaswimmer_ | I'm using kayobe | 20:46 |
TheJulia | minus kayobe, sounds like what cern uses | 20:46 |
eliaswimmer_ | the use koji | 20:47 |
*** ociuhandu has joined #openstack-ironic | 20:48 | |
eliaswimmer_ | I run ipa with a debugger yesterday and set the root device right, then it worked | 20:49 |
eliaswimmer_ | root_uuid = internal_info.get('root_uuid_or_disk_id') shouldn't it throw a key error if key is not present? | 20:52 |
*** ociuhandu has quit IRC | 20:53 | |
eliaswimmer_ | https://github.com/openstack/ironic/blob/dac810aaf41612d0199cd87f900f5c365bc06b4a/ironic/drivers/modules/agent_base.py#L1199-L1206 | 20:54 |
eliaswimmer_ | That's the reason why I don't get an error | 20:54 |
eliaswimmer_ | Arne told me yesterday that they set the root_uuid in glance! | 20:56 |
eliaswimmer_ | I have to quit for today, tomorrow I will run ipa with a debugger | 21:05 |
eliaswimmer_ | thx you | 21:06 |
*** kaiokmo has quit IRC | 21:35 | |
TheJulia | eliaswimmer_: yeah, I think we could change that so we could look in instance_info if there is a user defined uuid as well | 21:53 |
*** threestrands has joined #openstack-ironic | 21:55 | |
*** rcernin_ has joined #openstack-ironic | 21:59 | |
*** rcernin_ has quit IRC | 22:04 | |
*** rcernin has joined #openstack-ironic | 22:04 | |
*** rcernin is now known as rcernin|brekkie | 22:05 | |
*** rh-jelabarre has quit IRC | 22:10 | |
*** rcernin|brekkie has quit IRC | 22:19 | |
*** k_mouza has joined #openstack-ironic | 22:21 | |
*** k_mouza has quit IRC | 22:33 | |
openstackgerrit | Merged openstack/ironic-python-agent master: Add ffi development lib to bindep https://review.opendev.org/733821 | 22:41 |
*** tkajinam has joined #openstack-ironic | 22:45 | |
*** rloo has quit IRC | 22:56 | |
*** alexmcleod has quit IRC | 23:07 | |
*** rcernin|brekkie has joined #openstack-ironic | 23:09 | |
*** rcernin|brekkie has quit IRC | 23:10 | |
*** rcernin has joined #openstack-ironic | 23:10 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!