Monday, 2020-04-20

*** ociuhandu has joined #openstack-ironic00:21
*** ociuhandu has quit IRC00:25
*** threestrands has joined #openstack-ironic00:35
openstackgerritSteve Baker proposed openstack/ironic master: Centralise imports of wsme types  https://review.opendev.org/70389800:43
openstackgerritSteve Baker proposed openstack/ironic master: Don't use wsme test webapp for patch tests  https://review.opendev.org/70448500:43
openstackgerritSteve Baker proposed openstack/ironic master: Do all serialization in the expose decorator  https://review.opendev.org/70448600:43
openstackgerritSteve Baker proposed openstack/ironic master: Add validate decorator to expose  https://review.opendev.org/70448700:43
openstackgerritSteve Baker proposed openstack/ironic master: Add function definition handling  https://review.opendev.org/70448800:43
openstackgerritSteve Baker proposed openstack/ironic master: WIP Add json parsing to args  https://review.opendev.org/70448900:43
openstackgerritSteve Baker proposed openstack/ironic master: WIP Add wsme core types, remove WSME  https://review.opendev.org/70449000:43
*** Qianbiao has joined #openstack-ironic00:51
*** Qianbiao is now known as Qianbiao|afk00:52
openstackgerritKaifeng Wang proposed openstack/ironic-python-agent-builder master: [Trivial] Doc update on the stable-interface-names  https://review.opendev.org/72087200:54
openstackgerritKaifeng Wang proposed openstack/ironic master: Fixes unusable Guru meditation report  https://review.opendev.org/72087001:03
*** k_mouza has joined #openstack-ironic02:17
*** k_mouza has quit IRC02:22
*** ociuhandu has joined #openstack-ironic02:26
*** k_mouza has joined #openstack-ironic02:26
*** k_mouza has quit IRC02:33
*** ociuhandu has quit IRC02:36
*** Qianbiao|afk has quit IRC02:37
*** ociuhandu has joined #openstack-ironic02:37
*** k_mouza has joined #openstack-ironic02:38
*** ociuhandu has quit IRC02:42
*** k_mouza has quit IRC02:46
*** k_mouza has joined #openstack-ironic02:52
*** ociuhandu has joined #openstack-ironic02:55
*** jhesketh has joined #openstack-ironic02:56
openstackgerritQitao proposed openstack/virtualbmc master: Use unittest.mock instead of third party mock  https://review.opendev.org/72114202:56
*** k_mouza has quit IRC02:57
openstackgerritQitao proposed openstack/ironic-inspector master: Use unittest.mock instead of third party mock  https://review.opendev.org/72114402:59
*** k_mouza has joined #openstack-ironic03:01
openstackgerritQitao proposed openstack/ironic master: Use unittest.mock instead of third party mock  https://review.opendev.org/72115303:04
*** ociuhandu has quit IRC03:05
*** k_mouza has quit IRC03:08
*** k_mouza has joined #openstack-ironic03:15
*** mkrai has joined #openstack-ironic03:15
*** k_mouza has quit IRC03:20
*** k_mouza has joined #openstack-ironic03:22
openstackgerritMerged openstack/bifrost master: Use unittest.mock instead of third party mock  https://review.opendev.org/72090503:22
openstackgerritMerged openstack/sushy master: Use unittest.mock instead of third party mock  https://review.opendev.org/72101703:22
*** k_mouza has quit IRC03:28
*** k_mouza has joined #openstack-ironic03:31
*** k_mouza has quit IRC03:37
openstackgerritKaifeng Wang proposed openstack/virtualbmc master: Restore pep8 checking on import order  https://review.opendev.org/72116203:38
*** k_mouza has joined #openstack-ironic03:40
*** k_mouza has quit IRC03:45
*** ricolin has joined #openstack-ironic03:48
*** ociuhandu has joined #openstack-ironic03:48
*** ociuhandu has quit IRC03:53
*** k_mouza has joined #openstack-ironic04:02
openstackgerritMerged openstack/ironic-inspector master: Use unittest.mock instead of third party mock  https://review.opendev.org/72092104:02
openstackgerritMerged openstack/ironic-lib master: Use unittest.mock instead of third party mock  https://review.opendev.org/72092204:02
*** k_mouza has quit IRC04:10
*** k_mouza has joined #openstack-ironic04:16
*** k_mouza has quit IRC04:20
*** k_mouza has joined #openstack-ironic04:22
*** k_mouza has quit IRC04:27
*** k_mouza has joined #openstack-ironic04:38
*** k_mouza has quit IRC04:43
*** mkrai has quit IRC04:44
*** mkrai has joined #openstack-ironic04:45
*** k_mouza has joined #openstack-ironic04:46
*** k_mouza has quit IRC04:50
*** k_mouza has joined #openstack-ironic04:56
*** k_mouza has quit IRC05:02
*** tkajinam has quit IRC05:12
*** k_mouza has joined #openstack-ironic05:13
*** tkajinam has joined #openstack-ironic05:13
*** k_mouza has quit IRC05:17
*** yaawang_ has quit IRC05:18
*** yaawang_ has joined #openstack-ironic05:20
*** k_mouza has joined #openstack-ironic05:23
*** k_mouza has quit IRC05:28
*** k_mouza has joined #openstack-ironic05:33
*** k_mouza has quit IRC05:38
*** k_mouza has joined #openstack-ironic05:41
*** mkrai has quit IRC05:41
*** mkrai has joined #openstack-ironic05:42
*** k_mouza has quit IRC05:45
*** k_mouza has joined #openstack-ironic05:51
openstackgerritKaifeng Wang proposed openstack/virtualbmc master: Restore pep8 checking on import order  https://review.opendev.org/72116205:54
*** k_mouza has quit IRC05:55
openstackgerritMerged openstack/virtualbmc master: Use unittest.mock instead of third party mock  https://review.opendev.org/72102606:00
*** akahat|rover is now known as akahat|ruck06:02
*** jtomasek has joined #openstack-ironic06:04
*** Qianbiao|afk has joined #openstack-ironic06:06
*** k_mouza has joined #openstack-ironic06:11
*** k_mouza has quit IRC06:16
openstackgerritAndreas Jaeger proposed openstack/ironic-inspector master: Cleanup py27 support  https://review.opendev.org/72055106:18
arne_wiebalckGood morning, ironic!06:51
*** k_mouza has joined #openstack-ironic06:56
iurygregorygood morning arne_wiebalck and Ironic o/06:59
*** ociuhandu has joined #openstack-ironic07:00
arne_wiebalckhey iurygregory o/07:01
*** k_mouza has quit IRC07:01
iurygregoryo/07:01
*** dougsz has joined #openstack-ironic07:05
gudrutis2hi ironic o/07:09
Qianbiao|afkhello, hello, hello.07:10
*** Qianbiao|afk is now known as Qianbiao07:10
openstackgerritPierre Riteau proposed openstack/tenks stable/1.0: Cap openstacksdk for compatibility with Python 2  https://review.opendev.org/72117707:11
*** rpittau|afk is now known as rpittau07:12
QianbiaoI got a problem, when set "automated_clean=true", and there are no clean_steps in "node show", but clean_step still run, and finally, node failed with "clean waiting timeout"07:12
rpittaugood morning ironic! o/07:12
*** hjensas has quit IRC07:13
QianbiaoAnd even if a set a clean step manually, it seems that the clean step is not running(no log), and clean will finally failed(waiting timeout)07:14
Qianbiaoany idea?07:15
QianbiaoFailed error log: Timeout reached while cleaning the node. Please check if the ramdisk responsible for the cleaning is running on the node. Failed on step {}.07:15
*** hjensas has joined #openstack-ironic07:16
*** threestrands_ has joined #openstack-ironic07:18
*** threestrands_ has quit IRC07:18
*** threestrands has quit IRC07:21
*** k_mouza has joined #openstack-ironic07:31
iurygregorymorning rpittau o/07:33
rpittauhey iurygregory :)07:34
*** k_mouza has quit IRC07:36
openstackgerritKaifeng Wang proposed openstack/virtualbmc master: Restore pep8 checking on import order  https://review.opendev.org/72116207:44
openstackgerritIury Gregory Melo Ferreira proposed openstack/ironic-prometheus-exporter master: Stop configuring install_command in tox.  https://review.opendev.org/72079307:51
*** lucasagomes has joined #openstack-ironic07:51
*** alexmcleod has joined #openstack-ironic07:51
openstackgerritIury Gregory Melo Ferreira proposed openstack/ironic-ui master: Stop configuring install_command in tox.  https://review.opendev.org/72081308:03
openstackgerritRiccardo Pittau proposed openstack/python-ironicclient master: Check import order  https://review.opendev.org/72119308:05
*** ociuhandu has quit IRC08:07
openstackgerritIury Gregory Melo Ferreira proposed openstack/networking-generic-switch master: Stop configuring install_command in tox.  https://review.opendev.org/72080808:09
openstackgerritIury Gregory Melo Ferreira proposed openstack/ironic-ui master: Stop configuring install_command in tox.  https://review.opendev.org/72081308:13
*** mkrai has quit IRC08:15
*** mkrai_ has joined #openstack-ironic08:15
openstackgerritIlya Etingof proposed openstack/ironic master: Add `network_data` field to ironic node object  https://review.opendev.org/68791008:27
etingofdtantsur|afk, ^ network data field validation in the api code08:28
openstackgerritMerged openstack/virtualbmc master: Stop configuring install_command in tox.  https://review.opendev.org/72081608:28
openstackgerritMerged openstack/sushy-cli master: Stop configuring install_command in tox.  https://review.opendev.org/72081008:30
openstackgerritIlya Etingof proposed openstack/ironic master: Add `get_node_network_data` method to NetworkInterface  https://review.opendev.org/68818408:31
openstackgerritMerged openstack/bifrost master: Stop configuring install_command in tox.  https://review.opendev.org/72080908:31
openstackgerritIlya Etingof proposed openstack/ironic master: Add `get_node_network_data` to non-Neutron NetworkInterface  https://review.opendev.org/68826608:31
iurygregoryrpittau, did we test ironic-staging-drivers-all with dib?08:34
rpittauiurygregory: we're running that with dib08:36
iurygregoryrpittau, I know, just wondering if we tested before switching08:36
iurygregorybecause it uses ironic-base so maybe we forgot to test08:36
rpittauiurygregory: I'm not sure what you mean, how can we run with dib now without having merged the change, therefore having tested that? :/08:39
iurygregoryrpittau, depends-On?08:40
iurygregoryjust wondering if the failure I got was related that's all =)08:40
*** dsneddon has quit IRC08:41
rpittauiurygregory: ironic-staging-drivers-all was running on tinyipa until 6 days ago, then was converted to dib https://review.opendev.org/#/c/718984/508:41
patchbotpatch 718984 - x/ironic-staging-drivers - Switch to zuulv3 (MERGED) - 5 patch sets08:41
*** dsneddon has joined #openstack-ironic08:41
iurygregoryrpittau, oh cool o/08:41
openstackgerritIlya Etingof proposed openstack/ironic master: Add `network_data` field to ironic node object  https://review.opendev.org/68791008:41
* iurygregory needs more coffee I couldn't find the patch08:42
openstackgerritIlya Etingof proposed openstack/ironic master: Add `get_node_network_data` method to NetworkInterface  https://review.opendev.org/68818408:42
openstackgerritIlya Etingof proposed openstack/ironic master: Add `get_node_network_data` to non-Neutron NetworkInterface  https://review.opendev.org/68826608:43
*** ociuhandu has joined #openstack-ironic08:43
openstackgerritIury Gregory Melo Ferreira proposed openstack/networking-generic-switch master: Stop configuring install_command in tox.  https://review.opendev.org/72080808:44
arne_wiebalckQianbiao: this is happens when the node to clean does not call back, in most cases I have seen the node does not boot08:44
arne_wiebalckQianbiao: get a console on the node to clean and see if it comes up when you initiate the cleaning08:45
Qianbiaoarne_wiebalck " node does not boot" means could not power on?08:46
Qianbiaoi can see the node has power on in KVM.08:46
arne_wiebalckbut does it boot?08:47
QianbiaoHmm, do not know what does the "boot" means, finally, it will boot from drive and show a ubuntu login ui08:47
arne_wiebalckQianbiao: the node could have power, but not boot, or it does not get on the network, or it does get on the network but cannot see the controller08:47
*** ociuhandu has quit IRC08:48
arne_wiebalckQianbiao: aha!08:48
openstackgerritMerged openstack/ironic-python-agent master: Stop configuring install_command in tox.  https://review.opendev.org/72081108:48
arne_wiebalckQianbiao: it should boot from the network into the IPA image08:48
Qianbiao<arne_wiebalck> oh, it does not.08:48
arne_wiebalckQianbiao: not from the  local disk08:49
Qianbiaoshould it auto boot from network when exec clean step? i did nothing.08:49
Qianbiaobtw, if i didnot config clean step, the whole deploy progress runs successfully.08:49
arne_wiebalckQianbiao: not sure about the auto, but if it does not boot from the network, the cleaning will not start08:49
QianbiaoI mean will ironic auto boot from pxe?08:50
QianbiaoIronic should control the node to boot from pxe i think.08:50
arne_wiebalckQianbiao: right, so you need to have a look what it does when you try to clean08:51
Qianbiaook will do now.08:51
arne_wiebalckQianbiao: does it try to boot from the network (and fail) or does it not boot from the network at all08:51
Qianbiaook.08:51
Qianbiao<arne_wiebalck> "get a console on the node to clean"08:52
Qianbiao^^^ do u mean clean by manually08:52
arne_wiebalckQianbiao: right :)08:52
Qianbiaonode clean --clean-steps08:52
Qianbiaook08:52
arne_wiebalckQianbiao: well, doesn't matter08:52
arne_wiebalckQianbiao: you'll need to check what the node does when ironic is instructed to clean it, manually or automatically08:53
Qianbiaoarne_wiebalck thanks, you have helped me on several issues. :)08:53
Qianbiaook, will check now.08:53
arne_wiebalckQianbiao: ok, let us know how it goes08:56
arne_wiebalckQianbiao: :)08:56
*** k_mouza has joined #openstack-ironic09:00
*** ociuhandu has joined #openstack-ironic09:18
*** dtantsur|afk is now known as dtantsur09:21
dtantsurmorning ironic, happy Monday!09:22
arne_wiebalckhey dtantsur o/09:23
*** gregwork has quit IRC09:24
arne_wiebalckironic 101 question: ironic will set the way a node is booting explicitly, right? like, set to network boot for cleaning, to local disk after deployment etc.?09:25
*** rcernin has quit IRC09:26
dtantsurarne_wiebalck: yes09:27
dtantsurunless you're using the noop management interface09:27
iurygregorymorning dtantsur09:27
*** ricolin has quit IRC09:28
*** ociuhandu has quit IRC09:32
*** ociuhandu has joined #openstack-ironic09:33
openstackgerritIury Gregory Melo Ferreira proposed openstack/ironic-ui master: Stop configuring install_command in tox.  https://review.opendev.org/72081309:35
*** ociuhandu has quit IRC09:39
arne_wiebalckdtantsur: thanks09:41
arne_wiebalckdtantsur: I don't, but in our infra all nodes are supposed to boot from the network all the time (and the answer determines how they boot), and this masks what Ironic would do :)09:42
arne_wiebalckdtantsur: hence I didn't know09:42
dtantsurah :)09:42
arne_wiebalckdtantsur: thanks :)09:42
dtantsuroh man, the lower-constraints thing is sooo difficult :(09:46
iurygregorydtantsur, it's09:47
iurygregoryspecially when things locally works and CI does BOOM09:47
dtantsuryeah09:47
iurygregoryand for ironic-ui we need to wait for a new release it seems09:47
dtantsurand apparently I have mislead the team re which dependencies have to be included :(09:48
*** ricolin has joined #openstack-ironic09:48
*** ricolin_ has joined #openstack-ironic09:48
dtantsuron a more positive note, I need reviews on https://review.opendev.org/#/c/718358/ please09:48
patchbotpatch 718358 - ironic - Improve the command status checks in the agent's p... - 3 patch sets09:48
dtantsurand https://review.opendev.org/#/c/698768/ since it mostly lacks unit test updates09:49
patchbotpatch 698768 - ironic - WIP: Support executing in-band deploy steps - 35 patch sets09:49
dtantsurmgoddard: if you could take a quick look today ^^^09:49
mgoddarddtantsur: sure09:50
mgoddardlooks surprisingly small :)09:50
*** rcernin has joined #openstack-ironic09:50
*** mkrai has joined #openstack-ironic10:00
dtantsurikr? :)10:00
dtantsurthere is one more missing bit which I'm working on right now. it will go into the 3rd patch.10:00
*** mkrai_ has quit IRC10:02
*** ricolin_ has quit IRC10:02
openstackgerritIlya Etingof proposed openstack/ironic master: Add missing and remove non-existing parameters.  https://review.opendev.org/72121810:02
openstackgerritDmitry Tantsur proposed openstack/ironic master: WIP: Decompose core deploy step  https://review.opendev.org/69830910:07
openstackgerritDmitry Tantsur proposed openstack/ironic master: WIP: Delay validating deploy templates until we get all steps  https://review.opendev.org/72121910:07
openstackgerritMark Goddard proposed openstack/networking-generic-switch master: Use unittest.mock instead of third party mock  https://review.opendev.org/72095210:08
*** ociuhandu has joined #openstack-ironic10:08
openstackgerritMerged openstack/tenks stable/1.0: Cap openstacksdk for compatibility with Python 2  https://review.opendev.org/72117710:13
*** rpittau is now known as rpittau|bbl10:15
Qianbiaohello, is there any console cmd could change node state from active to manageable again.10:18
dtantsurQianbiao: you need to go through 'node undeploy' first to get to available10:19
dtantsurthen you can do 'node manage'10:19
*** ociuhandu has quit IRC10:22
* arne_wiebalck feels that dtantsur has a deja-vu10:23
Qianbiao<dtantsur> thanks.10:23
dtantsurarne_wiebalck: I do indeed :)10:23
dtantsurmgoddard: could you remind me: when invoking raid.create_configuration via deploy templates, with pass the RAID configuration via step['args']?10:29
dtantsurs/with/we/10:29
dtantsurmmm, seems so, judging by ilo. this needs fixing in IPA, sigh..10:30
mgoddarddtantsur: correct10:34
Qianbiao<arne_wiebalck> thanks, it's because that we got another dhcp server in lan... so, when boot from pxe, it can not load correct ip.10:39
dtantsurarne_wiebalck: it seems that software RAID tests don't pass for me locally.. (in IPA)10:42
openstackgerritDmitry Tantsur proposed openstack/ironic-python-agent master: Add raid.apply_configuration deploy step  https://review.opendev.org/72123610:50
dtantsurmgoddard: then we also need ^^10:50
dtantsurand now I need to check if argsinfo is actually handled on the conductor side (I doubt it)10:50
dtantsursigh10:51
dtantsuroh, it seems to actually, good10:51
* etingof just found out how incredibly stinky the vmedia code has become...10:52
dtantsur:D10:52
* etingof spends half a day trying to untangle it10:53
etingofbut lost hope in the end10:53
dtantsurnext cycle we could use a good refactoring of the vmedia code, software RAID code and deploy/clean steps10:53
etingofhaving spent 5 hours on this mess this morning, I'd rather rollback the ilo commit10:54
*** derekh has joined #openstack-ironic10:54
etingofbut it's probably too late by now10:55
etingofI will try to move pieces around in hope to make it a bit more manageable10:56
etingofbut really, it is not anymore10:56
*** rachit7 has joined #openstack-ironic10:58
*** dougsz has quit IRC11:02
dtantsursigh11:04
dtantsurif it makes you feel better: deploy steps handling is also a huge mess and I'm actively working on making it worse :D11:08
*** rachit7 has quit IRC11:15
etingofwe are all working hard towards making rewriting the whole ironic the only way out11:16
*** dougsz has joined #openstack-ironic11:17
* etingof is being positive11:17
*** tkajinam has quit IRC11:21
openstackgerritIury Gregory Melo Ferreira proposed openstack/networking-baremetal master: Stop configuring install_command in tox.  https://review.opendev.org/72080611:26
*** hjensas has quit IRC11:28
*** dsneddon has quit IRC11:31
*** mkrai has quit IRC11:37
dtantsuretingof: rewriting in go \o/11:45
etingoflet's do it in .NET to be on the same page with BMCs11:46
*** rh-jelabarre has joined #openstack-ironic11:50
openstackgerritIury Gregory Melo Ferreira proposed openstack/ironic master: Stop configuring install_command in tox.  https://review.opendev.org/72079011:53
dtantsurthat's a lovely idea11:54
*** ociuhandu has joined #openstack-ironic11:57
openstackgerritMerged openstack/ironic-python-agent-builder master: [Trivial] Doc update on the stable-interface-names  https://review.opendev.org/72087211:59
*** ociuhandu has quit IRC12:02
*** rpittau|bbl is now known as rpittau12:03
arne_wiebalckdtantsur: oh?12:04
dtantsurarne_wiebalck: on master: http://paste.openstack.org/show/792411/12:06
arne_wiebalckdtantsur: hmm, will try to reproduce12:06
dtantsurfor me it bisects to the initial UEFI patch12:08
arne_wiebalckdtantsur: the tests pass for me12:12
dtantsuryay for insufficient mocking somewhere?12:12
arne_wiebalckoh no12:12
* arne_wiebalck remembers the last time he tried to chase such a bug down12:13
dtantsurI'll look into it since I can reproduce12:15
arne_wiebalckdtantsur: the errors all due to the partition table type12:15
dtantsurright, msdos vs gpt12:15
dtantsurinteresting12:15
arne_wiebalckthe type comes from the node12:19
openstackgerritIury Gregory Melo Ferreira proposed openstack/ironic-inspector master: Stop configuring install_command in tox.  https://review.opendev.org/72079112:20
arne_wiebalckdtantsur: is the node object reused and the boot type set to uefi due to the test which ran just before ... or sth like this?12:22
dtantsuryeah, maybe. will check in a few mins12:22
arne_wiebalckdtantsur: this would explain why the code tried gpt instead of bios12:22
arne_wiebalckdtantsur: ok, let me know if I can help12:23
*** derekh has quit IRC12:24
*** Lucas_Gray has joined #openstack-ironic12:25
* etingof though six is gone in ironic, but apparently not quite -- https://github.com/openstack/ironic/blob/master/ironic/tests/unit/drivers/modules/test_virtual_media_base.py#L2912:29
iurygregoryenr12:31
iurygregorythis shouldn't be there at all ...12:32
rpittauhow is taht there?12:32
iurygregorymagic12:33
rpittauoh it sneaked in in a recent patch12:34
etingofalso interesting, ilo seems to hijack generic redfish tests -- https://github.com/openstack/ironic/blob/master/ironic/tests/unit/drivers/modules/test_virtual_media_base.py#L4212:34
rpittauhttps://review.opendev.org/#/c/677996/12:34
patchbotpatch 677996 - ironic - Generalize ISO building for virtual media driver (MERGED) - 16 patch sets12:34
* etingof is going violent about that ^ patch12:35
openstackgerritIlya Etingof proposed openstack/ironic master: Fix vmedia test methods and remove `six`  https://review.opendev.org/72125612:39
Qianbiaohello, what should raid delete_configuration do? only delete volumes? should we delete spare drives meantime?12:39
rpittauetingof: I can support violence in this case :)12:41
rpittaubut I feel responsible as I didn't review it :/12:41
*** Goneri has joined #openstack-ironic12:42
etingofme too! I did review it and -1'ed it, but then I did not revisit it for some time so the spaghetti monster sneaked in it has taken over ironic12:43
* dtantsur reminds people to review more and more often ;)12:45
dtantsurQianbiao: I'm not sure I understand the difference. What do you mean by delete drives?12:45
Qianbiao<dtantsur> raid configuration contains: 1. volumes(logical disk) config 2. spare drive config(will replace a physical disk of a volume if data is broken)12:47
openstackgerritVerification of a change to openstack/ironic-inspector failed: Cleanup py27 support  https://review.opendev.org/72055112:47
Qianbiaodrive is a physical disk. volume is logical disk. as i know12:47
dtantsurQianbiao: then I'm not sure how you want to "delete spare drives"? they're physical, you cannot delete them.12:49
Qianbiao<dtantsur> delete the spare config.12:49
Qianbiaolet me explain.12:49
dtantsuryeah, I guess I don't understand this concept12:50
*** priteau has joined #openstack-ironic12:50
Qianbiaowe have 10 physical disks. and create a volume with RAID5 with disk 1,2,3.12:50
Qianbiaoand then we set disk4 as a spare disk for this RAID volume.12:50
Qianbiaoif any of disk 1,2,3 is broken(like disk1 we say). then disk 4 will auto replace disk1 and then rebuild data from disk,2,3 .12:51
dtantsurah! nice, thank you12:52
TheJuliagood morning everyone12:52
dtantsurmorning TheJulia12:52
* TheJulia rubs sleep from her eyes12:52
Qianbiaoand this RAID5 volume will still be good.12:52
dtantsurQianbiao: if this configuration can be/is created with create_configuration, I think it should be deleted with delete_configuration12:52
Qianbiaocreate_configuration does support spare drive as i know for now.12:52
Qianbiaobut iBMC API do support create hot-spare drive for RAID volumes.12:53
Qianbiaodo u mean delete_configuration should only delete configurations created by "create_configuration" step12:54
dtantsurno, I don't mean this12:55
dtantsurlet's approach this problem from another angle12:55
dtantsurQianbiao: is there a use case for deleting RAID but leaving spare drive configuration intact?12:55
dtantsurand are there cases where it will end up in breakages?12:56
Qianbiaoyes, a spare drive can be global. for any volume.12:56
Qianbiaono for second. spare drive config can be left as it is.12:57
dtantsuroh, so I can define a spare drive once, and it will be used for every RAID I build later on?12:57
Qianbiaojust the spare drive can not be used then.12:57
Qianbiaoyes.12:57
dtantsurQianbiao: okay, then I think you should keep it intact and provide separate manual clean steps to manage it12:58
Qianbiaoit's a global spare drive. any disk in a volume is broken, it will auto replace it.12:58
Qianbiaook, thanks. dtantsur12:58
* dtantsur likes this feature12:58
dtantsuroh wow, the CI doesn't feel well12:59
*** derekh has joined #openstack-ironic12:59
TheJuliadtantsur: is ci in one of those "just go back to bed" days?12:59
dtantsurTheJulia: it is, yes12:59
TheJulia*sigh*12:59
dtantsurfull red from retry failures and post failures12:59
Qianbiao= =... i like CI.12:59
dtantsurit seems that the infra is on it12:59
* dtantsur double-checks13:00
iurygregoryfor know we can keep trying recheck =)13:02
iurygregorydoesn't seem to be things in our side for RETRY_LIMIT13:02
* Qianbiao bye13:05
Qianbiaooh, i find how to send action :)13:06
* Qianbiao hello13:06
*** Lucas_Gray has quit IRC13:06
*** irclogbot_3 has quit IRC13:06
dtantsur:)13:07
dtantsuriurygregory: seems something with log servers13:07
*** irclogbot_0 has joined #openstack-ironic13:07
iurygregorydtantsur, not the first time I would say =)13:07
dtantsurhappens indeed13:07
iurygregoryyeah13:08
*** rloo has joined #openstack-ironic13:17
Qianbiaohi, how can we simulate running clean steps for a node ?13:22
Qianbiaoconductor.cleaning.do_node_clean(task, clean_steps=clean_steps) ?13:25
* TheJulia tries to wake up13:26
dtantsurQianbiao: what exactly are you trying to do?13:28
*** tzumainn has joined #openstack-ironic13:30
*** ociuhandu has joined #openstack-ironic13:30
*** ociuhandu has quit IRC13:35
Qianbiaodtantsur simulate node cleaning in testcase.13:36
dtantsurQianbiao: unit tests should only test a small region of code. if you're writing clean steps, test only them, not the whole procedure.13:37
Qianbiaocall "task.driver.raid.delete_configuration" directly?13:38
Qianbiaothen how can i know a step like {'step': "delete_configuration"} will call my raid.configuration exactly13:39
*** hoonetorg has quit IRC13:40
QianbiaoOh, i see. ironic team has testcases for this situation.13:41
Qianbiaodtantsur thanks. :)13:41
dtantsuryep :)13:41
openstackgerritRiccardo Pittau proposed openstack/ironic-prometheus-exporter master: Add lower constraints jobs  https://review.opendev.org/71768413:48
*** tkajinam has joined #openstack-ironic13:53
-openstackstatus- NOTICE: Zuul is temporarily offline; service should be restored in about 15 minutes.13:59
*** hoonetorg has joined #openstack-ironic13:59
*** ociuhandu has joined #openstack-ironic14:00
rpittauguess we can go home.... oh wait14:01
iurygregoryhehehe14:02
iurygregoryrecheck all the patches in 15 min14:03
iurygregorythank god no XD since Zuul should run the checks again if I do remember14:03
*** mkrai has joined #openstack-ironic14:03
TheJuliaheh14:07
*** Qianbiao has left #openstack-ironic14:15
*** Qianbiao has joined #openstack-ironic14:16
arne_wiebalckerbarr: you around?14:22
arne_wiebalckerbarr: it's about the UEFI exception you see14:22
erbarryea, what's up?14:22
arne_wiebalckerbarr: could you please post logs around this error? I think this is coming from the surrounding function. What my question was about was the exception the code tries to catch.14:23
arne_wiebalckerbarr: If another exception is raised, the patch is useless :)14:24
openstackgerritIlya Etingof proposed openstack/ironic master: Add missing and remove non-existing parameters.  https://review.opendev.org/72121814:24
erbarrokay, so you want to see the full traceback or the full conductor log?14:25
arne_wiebalcklet's start with the traceback :)14:27
openstackgerritIlya Etingof proposed openstack/ironic master: Fix vmedia test methods and remove `six`  https://review.opendev.org/72125614:27
*** dsneddon has joined #openstack-ironic14:29
*** ociuhandu has quit IRC14:29
*** cdearborn has joined #openstack-ironic14:34
*** ociuhandu has joined #openstack-ironic14:35
dtantsurarne_wiebalck: we have os.path.isdir('/sys/firmware/efi') on the test path :) my laptop uses UEFI, hence the difference.14:39
arne_wiebalckdtantsur: ouch14:39
arne_wiebalckdtantsur: this should be mocked, I guess14:40
*** ociuhandu has quit IRC14:40
dtantsuryeah14:40
openstackgerritDmitry Tantsur proposed openstack/ironic-python-agent master: Mock get_node_boot_mode in software RAID unit tests  https://review.opendev.org/72128014:42
dtantsurarne_wiebalck: here we go ^^^14:42
arne_wiebalckerbarr: is this a partition image you use?14:42
arne_wiebalckdtantsur: thanks! do you think there is value in duplicating these tests for UEFI/gpt?14:44
dtantsurarne_wiebalck: there are such tests, they mock os.path.isdir14:44
arne_wiebalckdtantsur: ah, great!14:44
erbarrarne_wiebalck: mmmmnn, i don't know, how can I find that out?14:46
arne_wiebalckerbarr: erm ... :)14:47
* arne_wiebalck has never used a partition image14:47
arne_wiebalckerbarr: it's just that the error comes from within a if which says not whole disk image14:47
erbarrarne_wiebalck: i'm seeing this IRONIC_AGENT_RAMDISK_URL=https://tarballs.openstack.org/ironic-python-agent/coreos/files/coreos_production_pxe_image-oem-master.cpio.gz14:49
dtantsurerbarr: FYI the coreos images are abandoned and no longer updated. but this is not a user image, it's a deploy ramdisk.14:50
erbarrdtantsur: thanks, yea I need to look into updating them, so what setting is a user image?14:52
dtantsurerbarr: I'm a bit out of context of what you're trying. if you're doing 'nova boot'/'openstack server create', you're passing an image there14:52
arne_wiebalckdtantsur: we established the other day that install_bootloader is called for wdi and uefi, remember?14:53
dtantsuryeah14:53
arne_wiebalckdtantsur: the traceback comes from inside an if which says 'not wdi'14:53
* arne_wiebalck is confused14:53
dtantsurwell, install_bootloader is also always called for partition images14:54
*** stendulker has joined #openstack-ironic14:54
dtantsur(since they are never assumed to have a bootloader)14:54
*** hjensas has joined #openstack-ironic14:54
arne_wiebalckexactly, this is why I was asking whether this a partition image14:54
dtantsur"target_boot_mode == 'uefi' and software_raid" should cover it though14:55
arne_wiebalckthat's true, it is not directly related with the problem, but uefi is not mandatory14:57
arne_wiebalckis it possible we do not get a AgentAPIError, but another exception?14:58
dtantsurI mean, https://review.opendev.org/#/c/720781/ does seem correct to me14:58
patchbotpatch 720781 - ironic - Don't break UEFI install with older IPAs - 1 patch set14:58
*** rh-jelabarre has quit IRC14:58
arne_wiebalckyes, but it does not solve erbarr's issue it seems14:58
dtantsurerbarr: is there another part of the traceback? in python 3 the causing traceback is usually reported before the final one14:58
dtantsuroh, meeting in 2 mins, we'll have to continue later14:58
arne_wiebalckok14:58
* dtantsur considers this one of the best python 3 features14:59
erbarrok, i'll look during meeting and report afterwrds14:59
*** tkajinam has quit IRC14:59
TheJulia#startmeeting ironic15:00
openstackMeeting started Mon Apr 20 15:00:11 2020 UTC and is due to finish in 60 minutes.  The chair is TheJulia. Information about MeetBot at http://wiki.debian.org/MeetBot.15:00
openstackUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.15:00
TheJuliao/15:00
*** openstack changes topic to " (Meeting topic: ironic)"15:00
iurygregoryo/15:00
openstackThe meeting name has been set to 'ironic'15:00
rloohi dtantsur, wrt https://storyboard.openstack.org/#!/story/2006910 -- was it approved? (I saw a PR associated with it and was going to review it but... ? )15:00
etingof\o15:00
dtantsuro/15:00
rlooo/15:00
TheJuliao/15:00
ajyao/15:00
rpioso\o15:00
TheJuliaGreetings everyone!15:00
dtantsurrloo: I think we've become pretty relaxed with approvals. that being said, this work should wait for V to beging.15:00
TheJuliaOur meeting agenda can be found at https://wiki.openstack.org/wiki/Meetings/Ironic#Agenda_for_next_meeting15:00
rajinirhi15:01
TheJulia#link https://wiki.openstack.org/wiki/Meetings/Ironic#Agenda_for_next_meeting15:01
dtantsurrloo: I think it was sort-of-approved-at-least-nobody-objected15:01
rloodtantsur: ok :)15:01
TheJulia#topic Announcements / Reminder15:01
*** openstack changes topic to "Announcements / Reminder (Meeting topic: ironic)"15:01
mgoddard\o15:01
TheJulia#info This is the end of the ussuri cycle as we will likely need to be ready to cut our stable branch this week or MAYBE early next week at the absolute latest.15:02
*** kaifeng has joined #openstack-ironic15:02
arne_wiebalcko/15:02
kaifengo/15:02
cdearborno/15:02
TheJulia#info TheJulia needs to understand who is is intending to attend the virtual PTG, we will discuss this more later in the meeeting15:02
TheJuliaDoes anyone else have anything else to announce or remind us of?15:03
stendulkero/15:03
dtantsurI guess we're in sort of feature freeze now?15:03
dtantsurAt least we'll need to freeze API/RPC at some point to be able to update the release mapping15:03
rpittauo/15:04
TheJuliaEssentially yes, so I'd like to propose we review and maybe merge any outstanding changes that would be good to merge that may impact API/RPC, so we can update the release mappings in the next couple of days15:04
TheJuliaI'm intending to write a prelude later today and revise any confusing release notes15:04
dtantsurI don't think we have API changes that are realistic to merge in Ussuri15:04
* rpittau following from cellphone as my isp decided to die15:04
TheJulialooks like you blocked the one RPC change that I know of off the top of my head that made sense15:05
dtantsurheh :)15:05
dtantsurwell, I see no big point in merging it without everything else15:05
dtantsurand delaying till V will get us a bigger margin of error15:06
TheJuliaI'd love to see https://review.opendev.org/#/c/687910/ in, but *shrugs*15:06
patchbotpatch 687910 - ironic - Add `network_data` field to ironic node object - 30 patch sets15:06
dtantsurI'd apply same argument. We have no chances of finishing the feature in Ussuri.15:06
TheJuliaNo way to know if we would be able to get the rest of the stack merged in time15:06
TheJuliayeah15:06
dtantsurSo landing API that is not backed by anything...15:06
TheJuliayup15:06
dtantsurTraditionally, we have been trying to land API changes *last*15:07
dtantsurso that the backend is in place by the time they're exposed15:07
dtantsuretingof: ^^^15:07
mgoddard+115:07
TheJuliaIndeed, although tradition doesn't make sense in all cases15:07
TheJuliaAnyway, we should move on15:07
dtantsurI should be worried that I'm becoming too conservative? :)15:08
TheJuliaheh15:08
iurygregoryI would say maybe =)15:08
* dtantsur prepares to yell at cloud15:09
TheJuliadtantsur: I'm afraid you've already been doign that15:09
*** dougsz has quit IRC15:09
rpittauConsidering the ci status also I doubt anything new will land in time15:09
TheJuliawe just didn't issue you a cane to shake at the cloud15:09
TheJulialol15:09
*** rh-jelabarre has joined #openstack-ironic15:09
TheJuliaAnyway, moving onward15:09
dtantsuryeah, where's my cane kids?15:09
TheJulia#topic review action items from the prior week15:09
openstackgerritMerged openstack/ironic-ui master: Stop configuring install_command in tox.  https://review.opendev.org/72081315:09
*** openstack changes topic to "review action items from the prior week (Meeting topic: ironic)"15:09
TheJuliaWell, it was more like two weeks ago15:10
* iurygregory joins dtantsur to yell15:10
TheJuliaand iurygregory I believe you sent an email regarding cancelling the meeting, so I think were good!15:10
iurygregoryTheJulia, yup15:10
TheJulia#topic Review subteam status reports15:10
*** openstack changes topic to "Review subteam status reports (Meeting topic: ironic)"15:10
TheJulia#link https://etherpad.openstack.org/p/IronicWhiteBoard15:10
TheJuliaLine 24815:11
TheJuliaso deploy steps work going to next cycle correct?15:11
dtantsurnot fully, I hope15:12
TheJuliaI saw there was an outstanding uefi raid patch, but it seems like its done15:12
dtantsurat least one patch has to land now15:12
dtantsur#link https://review.opendev.org/#/c/721236/ is technically breaking15:12
patchbotpatch 721236 - ironic-python-agent - Add raid.apply_configuration deploy step - 1 patch set15:12
TheJuliaWell, I guess it is a good time to merge that then15:13
* TheJulia adds to list15:14
arne_wiebalckTheJulia: this one? https://review.opendev.org/#/c/72078115:14
patchbotpatch 720781 - ironic - Don't break UEFI install with older IPAs - 1 patch set15:14
TheJuliaseems reasonable15:14
TheJuliainteresting15:15
TheJuliaIs anyone else aware of patches that must merge?15:16
TheJuliatzumainn: all done w/r/t multitenancy?15:16
tzumainnTheJulia, yep! as far as I know :)15:17
TheJuliawe're keeping six for sushy-tools for the time being right?15:17
dtantsurtzumainn: you owe us a demo video ;)15:17
TheJulia+++++15:17
TheJulia+1,000,00015:17
tzumainndtantsur, hahaha, I can do that15:18
dtantsurthat would be amazing (and you can show it on your yearly performance review!)15:18
rpittauTheJulia: re sushy-tools six, yes, for now15:18
iurygregorywe can drop already no? =)15:19
TheJuliaOn a plus side, looks like we got a number of awesome things merged this year15:19
TheJuliawell15:20
TheJuliacycle15:20
dtantsurwe need to make sure we consume sushy-tools from releases on stable branches15:20
dtantsursame change I did for vbmc15:20
rpittauI'd rather wait for the next cycle to be honest15:20
TheJuliaI'm good with proceeding whenever you all are ready.15:20
dtantsurit's low priority either way, let's concentrate on the release for now15:20
rpittauyep15:20
iurygregoryok, I will check the stable branches to make sure we are using sushy-tools from releases15:21
* TheJulia feels like we drifted into priority setting anyway15:21
dtantsuriurygregory: it boils down to removing it from required-projects/$PROJECTS15:21
dtantsurI think. I hope.15:21
iurygregorydtantsur, I hope too =) let's see15:22
*** mkrai has quit IRC15:22
*** mkrai has joined #openstack-ironic15:22
TheJuliaAre we good to proceed?15:23
iurygregoryI think so15:23
TheJulia#topic Priorities for the week15:24
*** openstack changes topic to "Priorities for the week (Meeting topic: ironic)"15:24
TheJuliaSo I believe the priorities are kind of simple. The must land patches, prelude, and release mapping update.15:24
TheJuliaDo we want to change up CI dramatically right before we release?15:25
TheJuliaiurygregory: this is in regards to your job changes15:25
iurygregoryTheJulia, you mean the l-c changes?15:26
dtantsurI guess the standalone job?15:26
iurygregoryoh15:26
TheJuliaiurygregory: standalone chagnes15:26
iurygregorywell we merged the change in ironic-tempest-plugin15:27
iurygregoryif we don't mind not testing that it's fine?15:27
TheJuliaI guess we do release the plugin...15:27
iurygregorybut I'm assuming that since we split we could add a job to check15:27
iurygregoryhttps://review.opendev.org/720675 this adds the job in ironic15:28
patchbotpatch 720675 - ironic-tempest-plugin - Add standalone redfish jobs - 1 patch set15:28
iurygregoryops in tempest-plugin15:28
iurygregoryand https://review.opendev.org/712042 in ironic15:28
patchbotpatch 712042 - ironic - Add ironic-standalone-redfish - 7 patch sets15:28
*** yolanda has joined #openstack-ironic15:28
TheJuliacheck job non-voting and then make it gate/voting after the stable branch is cut?15:28
iurygregory++ sure =)15:29
iurygregorywill update15:29
dtantsur++15:29
rpittauTheJulia: about CI, we should also land the last dib conversion patches15:29
TheJuliarpittau: links?15:29
TheJuliaor topic link I guess :)15:30
rpittauhttps://review.opendev.org/#/q/topic:ironic-convert-dib+(status:open+OR+status:merged)15:30
rpittauthe -1 are because of the recent ci issues15:30
openstackgerritIury Gregory Melo Ferreira proposed openstack/ironic master: Add ironic-standalone-redfish  https://review.opendev.org/71204215:30
TheJuliaokay, I guess we're just going to have to wait and see on those.15:31
rpittauyep15:31
TheJuliaI think it is if they make it awesome, if not it is still okay15:31
TheJuliaAnything else?15:31
openstackgerritIury Gregory Melo Ferreira proposed openstack/ironic-tempest-plugin master: Add standalone redfish jobs  https://review.opendev.org/72067515:32
TheJuliaI guess not, Are we good to proceed to discussion15:34
iurygregory++15:34
TheJulia#topic Discussion15:35
*** openstack changes topic to "Discussion (Meeting topic: ironic)"15:35
TheJuliaFirst topic, is PTG Attendance. I would like to get an idea of those that will be interested in attending and what time zones would be best for themselves.15:35
* dtantsur Central Europe15:36
TheJuliaor that they can cover. I suspect, after all these years, I could kind of guess at least at the later question, but wanted to put it out there for everyone.15:36
rpittauCentral Europe15:36
* arne_wiebalck Central Europe15:36
rlooeastern time zone15:37
mgoddardEurope15:37
* iurygregory Central Europe15:37
cdearborneastern15:38
TheJuliaI guess another question and moderately unrelated is are there any topics that people are interested with regards to the scientific sig, edge working group, etc?15:38
dtantsura status check with the edge group may be useful15:39
dtantsurthere may be some discussions with ansible SIG re our modules15:39
dtantsurnot sure if it's interesting for everyone though15:40
iurygregorynot sure if there will be a discussion about Goals for V...15:40
TheJuliaI've been going back and forth in email with Ilidko and they are hoping to have some ironic discussion around ironic15:40
TheJuliaiurygregory: what do you mean?15:40
*** gyee has joined #openstack-ironic15:40
TheJuliaI mean, aside from https://review.opendev.org/720100 :)15:40
patchbotpatch 720100 - ironic-specs - WIP - Victoria Cycle Priorit(y|ies) - 1 patch set15:40
dtantsuriurygregory: there certainly will, but here's a thing to keep in mind15:40
dtantsurwe no longer have to fit our internal topics into the same week15:41
dtantsurit's pretty expected that teams may set up discussions outside of it15:41
iurygregoryTheJulia, just to *avoid* overlap if possible15:41
dtantsurat least that's the impression I've got15:41
iurygregorydtantsur, yeah15:41
dtantsurthe week should be dedicated to questions requiring a wider audience15:41
dtantsurlike cross-project interactions, reaching out to the ops community, and so on15:42
TheJuliasame, although I have concerns about requirements gathering and the feedback loop being disjointed15:42
dtantsurwe can have something even before AND after15:42
TheJuliaI kind of like that idea, even if it is just an hour sync-up or call to discuss priorities again after opendev15:42
dtantsurI'm just pointing out that we have more flexibility and we should use it15:42
TheJulia Agreed15:43
dtantsurrather than only suffer from downsides :)15:43
TheJulia++15:43
dtantsurthe week of the PTG will be cramped. many teams will meet in the same EU-US timeslot15:43
dtantsurapparently15:43
TheJuliaYeah :\15:43
dtantsur3pm UTC or something like that15:43
* dtantsur returns the mic to Julia15:44
TheJulia:)15:44
TheJuliaOh, I'm about to give it right back :)15:44
dtantsuroh?15:44
TheJuliaWell, that discussion answered the questions I needed input on, I'll see what I can do!15:45
dtantsurah, right. I think we chatted about http://lists.openstack.org/pipermail/openstack-discuss/2020-April/013757.html previously already?15:45
dtantsurwe may talk about potential follow-ups though15:45
TheJuliaYes, and there has been some additional discussion. That being said I think the victoria cycle priorities draft is a good place to continue the discussion amongst the contributors15:46
dtantsur++15:46
*** hoonetorg has quit IRC15:46
-openstackstatus- NOTICE: Gerrit will be restarted to correct a misconfiguration which caused some git mirrors to have outdated references.15:47
dtantsurof immediate follow-ups I see: a potential web site, rethinking release schedule, reducing (hard) dependencies, making the docs less openstack-centric15:47
dtantsurbut we probably should shake off Ussuri first15:47
TheJulia++ There is some additional discussion occuring but I can't comment on it... yet :)15:48
TheJulia++15:48
* dtantsur is intrigued :)15:48
TheJuliadtantsur: attend open board meetings, 'tis all I can say15:48
rloodefinitely docs less openstack-centric. regardless of anything else :)15:48
dtantsurTheJulia: oh nope :D15:49
rlooor more docs about standalone15:49
dtantsur++15:49
dtantsurwe have one page that is not ideally structured15:49
dtantsurwe *may* even use 'baremetal' instead of 'openstack baremetal'15:49
* dtantsur will compose a list of potential actions that don't involve drastic political changes15:50
TheJuliadtantsur: +1,000,00015:50
rlooseems like a reorg of this content: https://docs.openstack.org/ironic/latest/, some things will be common to both openstack & standalone, others won't.15:50
dtantsuryeah15:50
TheJulia++15:50
iurygregory++15:50
TheJuliaAnyway, docs and topic presentation dives deep into perceptions and it is one of those discussions _should_ likely save for a social hour or soemthing15:51
TheJuliaSpeaking of which, we should do another SPUC!15:51
dtantsurtotally15:51
TheJuliaAnyway, I guess we're good to stop over at the Baremetal SIG if arne_wiebalck has anything he wants to talk about, and then move to open discussion.15:52
dtantsur+++15:52
iurygregoryII SPUC \o/15:52
arne_wiebalcknothing from me, please have a look at the white paper and contribute or review :)15:52
TheJulia++15:52
TheJuliaMore text keeps flowing into it, it is kind of awesome!15:52
TheJuliaMoving to open discussion then!15:53
TheJulia#topic Open Discussion15:53
*** openstack changes topic to "Open Discussion (Meeting topic: ironic)"15:53
*** ianychoi_ is now known as ianychoi15:53
TheJuliaI did add some philosopical/whimsical thoughts to the end of the white paper and went through the authorship history15:54
*** hjensas has quit IRC15:54
cdearbornhey folks, we have a patch that we think is going to be important to get in: https://review.opendev.org/69332815:54
patchbotpatch 693328 - ironic - DRAC : idrac-redfish inspect updates pxe port - 11 patch sets15:54
TheJuliaat least, what was visible :( \o/ for anonymous edits15:54
arne_wiebalckTheJulia: thanks15:54
TheJuliacdearborn: I'm a little hesitant to merge features until you guys merge the sushy-oem-idrac changes and cut a release15:54
kaifengi have a quick question wrt the adopt process, does anyone know why it's validating instance_info/image_source ?15:54
dtantsurcdearborn: https://review.opendev.org/#/c/710327/ needs to be merged AND released first15:54
patchbotpatch 710327 - x/sushy-oem-idrac - Export System Configuration - 2 patch sets15:54
TheJuliakaifeng: it doesn't have to15:55
dtantsurkaifeng: to be able to rebuild15:55
cdearbornTheJulia, dtantsur, good point15:55
TheJuliakaifeng: but yes, as dtantsur just pointed out, so rebuild could be supported. If you want to create a knob for it, I think it would be easy to merge that15:55
cdearbornI wanted to point out that the redfish driver doesn't set pxe_enabled on the ports in ironic, which will cause major problems with nova if more than 1 port is enabled on a baremetal server15:56
dtantsurkaifeng: generally, the fewer special cases, the easier it is to reason about a state of a node15:56
TheJuliaand by knob, I mean configuration parameter because I've had the same question asked elsewhere recently but in a more subtle way15:56
TheJuliaRebuild is also not really widely used afaik15:56
dtantsurTheJulia: I'm soft -1 on a new parameter. if we think it's better without the check - let's just remove it.15:56
kaifengoh, we have some case that adopt existing nodes, then perform routine tasks like power control, or even monitoring15:56
dtantsuryeah, we overestimated the importance of rebuild back then15:56
TheJuliadtantsur: I think that is reasonable15:56
TheJuliaso lets remove the requirement \o/15:57
dtantsurcdearborn: good point :( I wonder if etingof has any plans about it15:57
TheJulia3 minute warning :)15:57
* etingof can't read that quickly15:57
cdearborndtantsur, unfortunately, i don't think there is a generic way to get the pxe ports via redfish, so not sure if there's anything that can be done in the redfish driver itself15:58
* arne_wiebalck would love an ironic-aware openstack server rebuild15:58
dtantsurarne_wiebalck: it is ironic-aware Oo15:58
TheJuliaetingof: no worries15:58
dtantsurI mean.. we even tested it in the CI at some point15:58
* etingof has a silly question15:58
arne_wiebalckdtantsur: including s/w RAID15:58
* kaifeng is in the same both with etingof15:58
dtantsurarne_wiebalck: oh. let's discuss afterwards15:58
kaifeng*boat15:58
etingofis it too late to revert anything?15:58
etingofI noticed a patch lately that has quite some issues to follow up. I've worked on it the whole today, but now I think it would be way easier to revert than to follow up....15:59
dtantsuretingof: never too late, depends on what and why15:59
etingofthis patch https://review.opendev.org/#/c/677996/1615:59
patchbotpatch 677996 - ironic - Generalize ISO building for virtual media driver (MERGED) - 16 patch sets15:59
dtantsura storyboard story is a good start15:59
dtantsurlet's make sure we document reasons outside of IRC15:59
etingofhas multiple problems15:59
*** hoonetorg has joined #openstack-ironic16:00
etingofa story on the discovered problems?16:00
TheJuliaNothing is perfect and the intent was in the right direction16:00
dtantsuretingof: yes16:00
TheJulia++ lets detail why16:00
etingoffixing these problems will be quite a time sink16:00
etingofokay16:00
kaifengTheJulia, dtantsur: thanks, will think more about it :)16:01
TheJuliaThanks everyone!16:02
TheJuliaOne last question before I end the meeting16:02
TheJuliaDo we want to have another SPUC this friday?16:02
TheJuliaor the following week?16:02
dtantsurcan be this week16:03
cdearbornSPUC?16:03
dtantsurcdearborn: Sanity Preserving Un-Conference16:03
iurygregory2nd edition16:03
dtantsuri.e. an ironic happy hour16:03
cdearbornahhh - lol - +316:03
* dtantsur hopes he remembered the abbreviation right16:03
TheJuliaclose enough :)16:04
TheJuliaThe idea is get people to talk about things they are interested in and there may be coffee, tea.... or other tasty beverage16:04
iurygregorys/Preserving/Preservation16:04
TheJuliaOh, and we did silly hats16:04
dtantsurwe need something new silly for this round :)16:04
TheJuliaJayF totally won with his video overlay silly hat of silliness16:04
dtantsuroh yeah :D16:04
iurygregory++16:04
iurygregorybest hat16:05
* TheJulia delegates the silliness topic16:05
TheJuliabest hat could work!16:05
TheJuliaMost well dressed?16:05
dtantsuroh, I'm going to lose :D16:05
rpittauheh I lose before even starting16:05
* dtantsur will bet on TheJulia16:05
iurygregory316:06
dtantsurTheJulia: we all know you have awesome dresses!16:06
TheJuliadtantsur: this is true...16:06
TheJuliaWell, you guys decide on something!16:06
TheJuliaand with that, thanks everyone!16:06
TheJuliaHave a wonderful week!16:07
dtantsurthank you TheJulia16:07
TheJulia#endmeeting16:07
*** openstack changes topic to "Bare Metal Provisioning | Status: http://bit.ly/ironic-whiteboard | Docs: http://docs.openstack.org/ironic/ | Bugs: https://storyboard.openstack.org/#!/project_group/75 | Contributors are generally present between 6 AM and 12 AM UTC, If we do not answer, please feel free to pose questions to openstack-discuss mailing list."16:07
openstackMeeting ended Mon Apr 20 16:07:05 2020 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)16:07
openstackMinutes:        http://eavesdrop.openstack.org/meetings/ironic/2020/ironic.2020-04-20-15.00.html16:07
openstackMinutes (text): http://eavesdrop.openstack.org/meetings/ironic/2020/ironic.2020-04-20-15.00.txt16:07
openstackLog:            http://eavesdrop.openstack.org/meetings/ironic/2020/ironic.2020-04-20-15.00.log.html16:07
rpittauthanks!16:07
rpittauand bye! :)16:07
*** rpittau is now known as rpittau|afk16:07
dtantsurarne_wiebalck: software RAID and rebuild, what exactly is wrong about it?16:07
dtantsuryou mean, rebuilding the RAID as well?16:08
arne_wiebalckexactly16:08
dtantsurmmm, I have a feeling it goes against the idea of RAID in ironic.. although I do see a point in it.16:08
dtantsurlike, a user has screwed up their RAID and wants to rebuild?16:08
JayFTheJulia: I mean, that's kinda cheating. Someone with a physical hat has to be the winner lol16:08
arne_wiebalckthe way we handle this now is to delete and recreate the instance16:08
dtantsurarne_wiebalck: deleting doesn't tear down RAID, does it?16:09
iurygregoryJayF, you have a good point I would say lol16:09
iurygregorywe could have virtual and real hat lol16:09
*** lucasagomes has quit IRC16:09
arne_wiebalckdtantsur: deleting removes everything, no?16:09
dtantsurarne_wiebalck: no? I think we explicitly made it so that cleaning doesn't tear down RAID?16:10
TheJuliaraids may not survive with preserve_ephemeral....16:10
TheJuliawith the way it is written16:10
dtantsurTheJulia: preserve_ephemeral is for partition images?16:10
dtantsurwhich aren't really supported with software RAID16:10
TheJuliadtantsur: true16:10
dtantsur(although may just work)16:10
arne_wiebalckdtantsur: ah, true we have this in our local h/w manager16:10
dtantsuryou cheaters! :)16:10
TheJuliaheh16:11
arne_wiebalck:-D16:11
TheJuliafigures16:11
dtantsurarne_wiebalck: so, you tear down RAID on each cleaning?16:11
arne_wiebalckwe have nodes with RAID-0, the moment a disk breaks, the node is gone16:11
arne_wiebalckdtantsur: yes16:11
dtantsurand when do you build it again?16:11
openstackgerritIury Gregory Melo Ferreira proposed openstack/sushy-tools master: Stop configuring install_command in tox.  https://review.opendev.org/72080716:12
arne_wiebalckon provide, with cleaning :)16:12
arne_wiebalckdelete/create16:12
dtantsuraaaahh. oooh16:12
dtantsurthis makes sense.. do you plan to upstream this mode of operation?16:12
arne_wiebalckthis way, the cycle gives me back a node with a re-configured RAID16:12
arne_wiebalckdtantsur: I was suggesting this!16:13
arne_wiebalckdtantsur: was rejected at the time16:13
dtantsurI guess we wanted to get the MVP out first16:13
arne_wiebalckdtantsur: I think the main idea (which I was supporting) was to make it work the same way as h/w RAID.16:14
dtantsurit could be handled the same way as wiping hard drives: via a priority override (0 by default)16:14
dtantsurI'd not mind hardware RAID being able to do the same.. but that's a whole different story16:14
arne_wiebalckdtantsur: what I mean was that the reason to make it not automatic was to make it symmetric with h/w RAID16:15
dtantsurand we'll get a similar mode of operation with deploy templates16:16
arne_wiebalckdtantsur: but even if this is done upon cleaning, it does not fulfill the nova rebuild wish16:16
dtantsur(once the in-band steps are finished... sigh.....)16:16
dtantsurright16:16
arne_wiebalckan in-place heal and redeploy16:16
dtantsurlet me open a huge can of worms on this lovely day:16:16
dtantsurmgoddard, TheJulia, should we re-run any deploy steps on rebuld?16:16
*** yolanda has quit IRC16:17
arne_wiebalckuh!16:17
dtantsuraka how is rebuild going to work when we stop special-case deploy.deploy?16:17
dtantsurhehe16:17
dtantsurI'd expect us to re-run all deploy steps.. which I don't think we do now16:17
* dtantsur brains boiling16:18
arne_wiebalckand with s/w RAID moving to in-band deploy steps ...16:18
dtantsur... you can get your feature for free16:18
arne_wiebalckexactly16:18
dtantsuroh man, I'm going to spend the whole V cycle on deploy steps16:19
* arne_wiebalck calls it a day and lets dtantsur sort out the remaining details16:19
dtantsur\o/16:19
arne_wiebalck:-D16:19
dtantsuris it drinks time already?16:19
arne_wiebalckerbarr: did you manage to get more backtraces by any chance?16:20
arne_wiebalckerbarr: I think we would need to find out which exception agent_client sees ... if that is not AgentAPIError, this would explain a lot16:21
arne_wiebalckerbarr: https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/agent_client.py#L30216:22
TheJuliadtantsur: well, ideally rebuild is just a redeploy to the same machine. rebuild just re-invokes deploy16:23
dtantsurI guess you're right and I don't need more code for that16:23
dtantsurthat's a relief16:23
arne_wiebalckerbarr: this is where the error comes back from the deploy ramdisk and the retry should happen16:23
*** stendulker has quit IRC16:24
arne_wiebalckTheJulia: dtantsur: rebuild is supposed to keep certain aspects constant, while the delete/re-instantiate cycle we do to mimic this in our deployment does not16:25
*** fdegir has joined #openstack-ironic16:25
dtantsurarne_wiebalck: which aspects do you have in mind? you mean, from scheduling perspective?16:26
dtantsuror specifically in ironic?16:26
arne_wiebalckdtantsur: like the exact same physical machine16:26
arne_wiebalckdtantsur: it should conserve IP address16:26
dtantsurright, so from nova perspective. I see.16:26
arne_wiebalckdtantsur: yes16:27
arne_wiebalckdtantsur: anyway, no big deal, we have some machinery in place, but it would be nice none the less16:27
arne_wiebalckdtantsur: to have a "nova rebuild" rebuild the instance from ground up16:28
dtantsurright16:29
dtantsurI guess that's where deploy templates will come handy indeed16:29
arne_wiebalckyes, never thought of them as a solution to this problem16:29
arne_wiebalcks/problem/feature wish/16:29
*** yolanda has joined #openstack-ironic16:29
* TheJulia loves migraine16:29
TheJuliamigraines16:30
erbarrarne_wiebalck: i didn't see any other tracebacks, just the same error on the bootloader in different places16:30
arne_wiebalckTheJulia: get some rest!16:30
dtantsurerbarr: could you at least fetch the preceding logs?16:30
* TheJulia makes a pouty look16:31
dtantsurTheJulia: sorry to hear, I suffered most of yesterday. get some rest indeed!16:31
TheJuliajust started to realize I'm starting to see the visual effects16:31
dtantsurnot good, resting becomes mandatory16:32
arne_wiebalckerbarr: or instrument the line I pointed to above to make sure we get the exception we expect16:32
*** dtantsur is now known as dtantsur|afk16:32
dtantsur|afkg'night folks16:32
arne_wiebalckbye dtantsur|afk16:32
TheJuliao.16:33
TheJuliao/16:33
erbarrdtantsur: sure, i'll look for other logs, have a good night16:33
*** yaawang has joined #openstack-ironic16:33
erbarrarne_wiebalck: let me look at the api log16:33
*** yaawang_ has quit IRC16:33
openstackgerritDerek Higgins proposed openstack/ironic master: WIP ipv6 jobs  https://review.opendev.org/61316916:34
arne_wiebalckbye everyone o/16:35
*** ociuhandu has joined #openstack-ironic16:36
openstackgerritJulia Kreger proposed openstack/ironic master: Add ironic 15.0 release mapping  https://review.opendev.org/72130116:44
* etingof noted a few things on the unhappy patch -- https://storyboard.openstack.org/#!/story/200757616:45
*** k_mouza has quit IRC16:46
TheJuliaetingof: please issue the revert when you have a minute16:47
openstackgerritMerged openstack/networking-generic-switch master: Use unittest.mock instead of third party mock  https://review.opendev.org/72095216:50
etingofTheJulia, just to confirm, are you proposing me pressing that button now?16:51
TheJuliaetingof: yes please16:54
etingofhappily!16:54
TheJuliaetingof: just update hte commit message of the revert to point to the story and provide high lvel details16:54
TheJuliaThanks!16:54
*** ociuhandu has quit IRC16:56
TheJulials16:57
openstackgerritIlya Etingof proposed openstack/ironic master: Revert "Generalize ISO building for virtual media driver"  https://review.opendev.org/72130916:57
etingofdone ^16:58
TheJuliaetingof: left two comments on the commit message17:01
*** derekh has quit IRC17:03
openstackgerritIlya Etingof proposed openstack/ironic master: Revert "Generalize ISO building for virtual media driver"  https://review.opendev.org/72130917:05
openstackgerritAija Jaunteva proposed openstack/ironic master: Fix RAID configuration with idrac-wsman interface  https://review.opendev.org/72070217:06
*** ociuhandu has joined #openstack-ironic17:10
openstackgerritJulia Kreger proposed openstack/ironic master: Ironic 15.0 prelude  https://review.opendev.org/72131517:16
openstackgerritJulia Kreger proposed openstack/ironic master: Prepare release notes/docs for 15.0 release  https://review.opendev.org/72131617:16
*** priteau has quit IRC17:19
*** ociuhandu has quit IRC17:22
*** yolanda has quit IRC17:26
openstackgerritVerification of a change to openstack/ironic-inspector failed: Add BasePhysnetHook  https://review.opendev.org/72001017:26
openstackgerritVerification of a change to openstack/ironic-inspector failed: Port physical network CIDR map hook  https://review.opendev.org/71859417:26
*** ricolin has quit IRC17:29
*** portdirect has quit IRC17:30
*** portdirect has joined #openstack-ironic17:30
openstackgerritMerged openstack/ironic stable/train: Document deploy_boot_mode and boot_option for standalone deployments  https://review.opendev.org/72015617:53
*** ociuhandu has joined #openstack-ironic18:15
*** ociuhandu has quit IRC18:20
*** ociuhandu has joined #openstack-ironic18:20
*** kaifeng has quit IRC18:21
*** mkrai has quit IRC18:24
*** mkrai_ has joined #openstack-ironic18:24
openstackgerritAija Jaunteva proposed openstack/ironic master: Fix SpanLength calculation for DRAC RAID configuration  https://review.opendev.org/72132618:41
*** yolanda has joined #openstack-ironic18:46
*** yolanda has quit IRC18:46
openstackgerritJulia Kreger proposed openstack/ironic stable/train: Fix SpanLength calculation for DRAC RAID configuration  https://review.opendev.org/72132718:47
openstackgerritMerged openstack/ironic master: Update iDRAC doc about soft power off timeout  https://review.opendev.org/71876118:47
*** k_mouza has joined #openstack-ironic18:48
*** k_mouza has quit IRC18:52
*** ociuhandu has quit IRC18:57
*** ociuhandu has joined #openstack-ironic18:58
*** ociuhandu has quit IRC19:03
*** jmccrory has quit IRC19:08
*** jmccrory has joined #openstack-ironic19:09
*** rloo has quit IRC19:09
*** rloo has joined #openstack-ironic19:09
*** rloo has quit IRC19:10
*** rloo has joined #openstack-ironic19:10
*** Lucas_Gray has joined #openstack-ironic19:18
*** Lucas_Gray has quit IRC19:21
*** hjensas has joined #openstack-ironic19:23
*** Lucas_Gray has joined #openstack-ironic19:24
dhellmannAm I right in reading ironic_lib.utils.find_devices_by_hints() that root device hints are applied in a non-deterministic order? It seems to loop over a dictionary at https://opendev.org/openstack/ironic-lib/src/branch/master/ironic_lib/utils.py#L36719:31
dhellmannhmm, though that's inside the loop over devices19:33
dhellmannso maybe it's the first device to match all of the rules?19:33
dhellmanns/rules/hints/19:33
dhellmannwhat I'm trying to work out is the precedence ordering of the hints, and it seems maybe they all have the same precedence.19:34
dhellmannfor example, if you specify an HCTL and a size and the device at that address isn't at least that big, provisioning would fail?19:34
openstackgerritChristopher Dearborn proposed openstack/ironic master: DRAC: Added redfish management interface issue  https://review.opendev.org/72007619:35
*** Lucas_Gray has quit IRC19:41
openstackgerritVerification of a change to openstack/ironic failed: Fixes unusable Guru meditation report  https://review.opendev.org/72087019:42
*** Lucas_Gray has joined #openstack-ironic19:45
*** ociuhandu has joined #openstack-ironic19:50
*** ociuhandu has quit IRC19:57
dhellmannah, yes, there's a note on https://docs.openstack.org/ironic/pike/install/include/root-device-hints.html about needing to match all hints19:59
*** ociuhandu has joined #openstack-ironic20:10
*** k_mouza has joined #openstack-ironic20:15
*** k_mouza has quit IRC20:20
*** ociuhandu has quit IRC20:30
TheJuliamatching and smallest of the matching if memory serves at all.20:34
*** rloo has quit IRC20:46
*** rloo has joined #openstack-ironic20:47
*** rloo has quit IRC20:49
*** rloo has joined #openstack-ironic20:55
*** ociuhandu has joined #openstack-ironic21:03
*** ociuhandu has quit IRC21:08
*** ociuhandu has joined #openstack-ironic22:04
*** rcernin has quit IRC22:05
*** rcernin has joined #openstack-ironic22:06
*** Lucas_Gray has quit IRC22:13
*** ociuhandu has quit IRC22:18
*** ociuhandu has joined #openstack-ironic22:18
*** ociuhandu has quit IRC22:23
*** mrda has quit IRC22:31
*** mrda has joined #openstack-ironic22:33
TheJuliacdearborn: the duplicate you identifed is a different branch target22:35
*** rloo has quit IRC22:41
*** tkajinam has joined #openstack-ironic22:43
*** jtomasek has quit IRC22:43
*** Lucas_Gray has joined #openstack-ironic23:04
*** threestrands has joined #openstack-ironic23:18
openstackgerritDerek Higgins proposed openstack/ironic master: WIP ipv6 jobs  https://review.opendev.org/61316923:33
*** Lucas_Gray has quit IRC23:34
*** bdodd has quit IRC23:34
*** bdodd has joined #openstack-ironic23:37
*** hjensas has quit IRC23:49
*** hjensas has joined #openstack-ironic23:51

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!