Thursday, 2019-08-15

*** absubram has joined #openstack-ironic00:14
*** ociuhandu has joined #openstack-ironic00:16
*** diga has joined #openstack-ironic00:33
*** jcoufal has joined #openstack-ironic00:35
*** gyee has quit IRC00:40
*** jcoufal has quit IRC00:48
*** rloo has quit IRC00:56
*** ociuhandu has quit IRC01:02
*** ricolin has joined #openstack-ironic01:03
*** cp has joined #openstack-ironic01:24
openstackgerritNguyen Van Trung proposed openstack/ironic master: Support firmware upgrade for irmc driver  https://review.opendev.org/59999201:40
openstackgerritMerged openstack/ironic stable/rocky: CI: remove quotation marks from TEMPEST_PLUGINS variable  https://review.opendev.org/67651702:11
*** gregoryo has joined #openstack-ironic02:12
*** absubram has quit IRC02:12
*** verma-varsha has joined #openstack-ironic02:22
*** verma-varsha1 has joined #openstack-ironic02:40
*** verma-varsha has quit IRC02:40
*** verma-varsha1 is now known as verma-varsha02:40
*** verma-varsha has quit IRC02:55
openstackgerritMerged openstack/ironic stable/stein: RAID creation fails with 'ilo5' RAID interface  https://review.opendev.org/67444903:04
*** verma-varsha has joined #openstack-ironic03:16
*** altlogbot_2 has quit IRC03:16
*** altlogbot_1 has joined #openstack-ironic03:17
openstackgerritMerged openstack/ironic master: Add Redfish Virtual Media Boot support  https://review.opendev.org/63845303:30
openstackgerritNguyen Van Trung proposed openstack/ironic master: Support firmware upgrade for irmc driver  https://review.opendev.org/59999203:38
openstackgerritMerged openstack/ironic master: Add set_boot_device hook in `redfish` boot interface  https://review.opendev.org/67212303:55
openstackgerritMerged openstack/ironic master: Add `filename` parameter to Redfish virtual media boot URL  https://review.opendev.org/67105403:59
*** gkadam has joined #openstack-ironic04:07
*** gkadam has quit IRC04:08
*** verma-varsha has quit IRC04:21
*** ociuhandu has joined #openstack-ironic04:30
*** ociuhandu has quit IRC04:35
*** rh-jelabarre has quit IRC04:54
*** kaifeng has joined #openstack-ironic05:25
*** mgoddard has quit IRC05:54
*** mgoddard has joined #openstack-ironic06:01
etingofhurray \o/06:06
*** verma-varsha has joined #openstack-ironic06:23
arne_wiebalckGood morning, ironic!06:26
kaifengmoring etingof arne_wiebalck o/06:34
arne_wiebalckgm kaifeng o/06:34
*** belmoreira has joined #openstack-ironic06:55
*** ricolin_ has joined #openstack-ironic07:03
*** ricolin has quit IRC07:05
*** jtomasek has joined #openstack-ironic07:16
openstackgerritVarsha Verma proposed openstack/sushy-tools master: Add Drive resource support  https://review.opendev.org/67508507:16
*** zhangfei has joined #openstack-ironic07:18
*** jawad_axd has joined #openstack-ironic07:26
*** tssurya has joined #openstack-ironic07:32
*** gregoryo has quit IRC07:32
*** ricolin_ is now known as ricolin07:33
*** verma-varsha has quit IRC07:56
*** lucasagomes has joined #openstack-ironic07:57
*** verma-varsha has joined #openstack-ironic08:10
*** e0ne has joined #openstack-ironic08:15
*** alexmcleod has joined #openstack-ironic08:40
*** derekh has joined #openstack-ironic08:40
*** ricolin has quit IRC09:07
*** jawad_axd has quit IRC09:29
*** verma-varsha has quit IRC09:49
*** hamzy_ has joined #openstack-ironic09:51
*** hamzy has quit IRC09:54
*** belmoreira has quit IRC10:03
openstackgerritVarsha Verma proposed openstack/sushy-tools master: Add Drive resource support  https://review.opendev.org/67508510:08
*** mgoddard_ has joined #openstack-ironic10:14
*** Lucas_Gray has joined #openstack-ironic10:20
TheJuliagood morning10:54
arne_wiebalckgm TheJulia o/11:00
TheJuliaarne_wiebalck: regading the two patches addressing the same basic issue in IPA. I'm thinking your patch may be better in that the bunch of conditionals kind of makes me uncomfortable when sorting through diks11:00
TheJuliadisks11:00
* arne_wiebalck needed to stop listening to music and closed the office door to understand to logic 11:01
arne_wiebalckthe *11:01
TheJuliahmm... today should be a music day11:03
arne_wiebalckTheJulia: the block device listing is already complicated, the extended if does not make it much worse I think11:03
TheJuliaWell... true11:04
*** cdent has joined #openstack-ironic11:04
arne_wiebalckTheJulia: It was actually the place I wanted to add things as well11:04
arne_wiebalckTheJulia: I just couldn't figure out how11:04
TheJuliahmm11:04
arne_wiebalckTheJulia: testing of this takes time11:04
arne_wiebalckTheJulia: with all the cases11:05
TheJuliaIndeed, and for that very reason more conditionals just makes me think your solution is a little better11:05
cdentarne_wiebalck: I've come back with another thought about something to tryto speed up the nova-compute that is managing a bunch of ironic nodes:11:05
TheJuliaGood morning cdent11:05
cdentallow the nova-compute to talk to the database11:05
cdentmorning TheJulia11:05
cdent(instead of the conductor)11:05
cdentrpc overhead is huge11:05
arne_wiebalckTheJulia: how about we wait for Raphael to comment? I just would like to make sure that the cases that were solved already (like a broken RAID-0) remain solved11:06
arne_wiebalckHey cdent o/11:06
TheJuliacdent: we don't rpc our api read requests, they come directly out of the DB, but that API interaction overhead is also huge11:06
TheJuliaarne_wiebalck: absolutely11:07
cdentTheJulia: I mean in the nova-compute itself11:07
cdentfor its db needs11:07
cdentsince the reason the nova-compute isn't allowed to access the db is because of vm breakouts, that's not really a concern in the "managing ironic nodes" scenario11:08
jrollcdent: that is a good idea and way too obvious11:08
TheJuliacdent: I got that :)11:08
cdentjroll: comes out of https://review.opendev.org/#/c/676672/11:08
patchbotpatch 676672 - nova - Add a "Caveats" section to the eventlet profiling ... - 1 patch set11:08
jrollnice11:08
cdentjroll: I was doing that profiling for the vmware scenario and (where the vms are off in another cluster) and thought "instead of trying to optimize this code, maybe we shoudn't run it"11:09
TheJuliacdent: This database access idea is growing on me.....11:09
*** belmoreira has joined #openstack-ironic11:09
arne_wiebalckbelmoreira ^^^11:09
cdentwhere "this code" is "the rpc stuff"11:09
cdentobject serialization may be a factor11:09
jrollif _runs_vms_locally(): cmd_comon.block_db_access('nova-compute')11:10
cdenthowever it is hard to be super sure, because that rpc code is also something the screws up the profiling data11:10
TheJuliaThere is no pagination overhead.... list returns on the database cursor11:10
jrollTheJulia: I believe cdent is referring to nova-compute accessing the nova db, not the ironic db11:11
TheJuliaWe would have to split out our object model unless ironic was installed and not used... that is if the object/db overhead is even acceptable11:11
TheJuliaoh11:11
*** belmoreira has quit IRC11:11
* TheJulia wonders if why not both?11:11
cdentTheJulia: yeah, jroll is right about what i meant, but it "both" is a very good question11:11
cdentan IronicDirect (in the vein of PlacementDirect [1]) might be an interesting experiment:11:12
TheJuliaI mean... we can improve ironic's api to allow a user to say "forget pagination, just give me data now"... which might help other interactions11:12
cdent[1] https://opendev.org/openstack/placement/src/branch/master/placement/direct.py11:12
jrollIronicDirect == nova-baremetal with separate worker processes :D11:13
cdentjroll: yes that would be tidier11:13
*** belmoreira has joined #openstack-ironic11:14
TheJuliacdent: there is a legitimate reason keep rest api for interaction with ironic.... at least in developing scenarios where users want/need multitenancy in ironic. I guess that makes me think the best thing is to keep that surface and interaction relatively consistent and just start addressing the data return performance that folks like jroll see.11:15
* cdent nods11:16
cdentmulti-pronged attack11:16
jrollI really do think the killer performance boost will come from ironic managing its resources in placement.11:17
TheJuliaFWIW, I'm actively pushing someone to get someone else to take some interns code and get it upstream to make multitenant ironic. It was done as a proof of concept this summer, but they didn't want to touch the underlying ironic data model (which is actually a necessary change for performance)11:17
jrollI 100% believe we'll continue to see problems in this area until we do that11:17
jroll(alternate solutions include separating the resource tracker loop into a separate process)11:18
TheJuliajroll: I don't think we will ever get rid of all of the 'problems', there will always be something out there11:18
jrollTheJulia: sorry, the performance problems in the resource tracker when running ironic, specifically11:18
TheJuliajroll: so in this, are you thinking ironic reporting to placement directly?11:18
jrollyes11:19
TheJuliaI think that too is a worthwhile thing11:19
arne_wiebalckIronic managin resources in placement has probably higher chances of being accepted than allowing for direct db access, no?11:19
arne_wiebalckmanaging11:19
TheJuliaarne_wiebalck: I would suspect so....11:19
jrollgoal being to make the RT a noop (though it might still be needed to manage the compute_nodes table? is that ever going away?)11:19
*** zhangfei has quit IRC11:23
*** ijw has joined #openstack-ironic11:27
*** ijw has quit IRC11:31
*** kaifeng has quit IRC11:42
*** Lucas_Gray has quit IRC11:45
*** rh-jelabarre has joined #openstack-ironic12:11
openstackgerritVarsha Verma proposed openstack/sushy-tools master: Add Storage and Storage Controllers resource support  https://review.opendev.org/67433912:30
*** ricolin has joined #openstack-ironic12:37
openstackgerritVarsha Verma proposed openstack/sushy-tools master: Add Drive resource support  https://review.opendev.org/67508512:39
*** rloo has joined #openstack-ironic12:47
*** verma-varsha has joined #openstack-ironic12:53
*** tssurya has quit IRC13:03
*** tssurya has joined #openstack-ironic13:04
openstackgerritJulia Kreger proposed openstack/python-ironicclient master: Remove the ironic command  https://review.opendev.org/67651513:29
*** verma-varsha has quit IRC13:38
*** priteau has joined #openstack-ironic13:38
*** belmoreira has quit IRC13:45
*** belmoreira has joined #openstack-ironic13:50
*** verma-varsha has joined #openstack-ironic14:19
*** diga has quit IRC14:20
*** mkarpiarz has joined #openstack-ironic14:28
*** cdearborn has joined #openstack-ironic14:37
*** gyee has joined #openstack-ironic14:57
openstackgerritJulia Kreger proposed openstack/ironic master: Change [deploy]/default_boot_option to local  https://review.opendev.org/49211414:59
*** kaiokmo has quit IRC15:06
verma-varshaetingof: Why are we checking hasattr() here (https://github.com/openstack/sushy-tools/blob/master/sushy_tools/emulator/resources/indicators/staticdriver.py#L39). Wouldn't it always have the make_permanent attribute?15:12
etingofverma-varsha, o/ I think that's for the sake of unit-testing15:13
verma-varshaetingof: Also, is it possible to use tuple as a key for the PersistantDict?15:15
etingofI think the idea is that in some cases _indicators can be just 'dict'15:15
etingofyes, it's normal dict so anything immutable can serve as a key15:15
verma-varshaThanks! I am thinking of using a tuple as a key for Volumes just as I did for Drives.15:16
etingofsince you are on that, you must have the best judgement!15:24
*** belmoreira has quit IRC15:26
*** belmoreira has joined #openstack-ironic15:28
*** belmoreira has quit IRC15:38
*** sthussey has joined #openstack-ironic15:38
cdearborngood morning ironic15:41
*** verma-varsha has quit IRC15:41
cdearborni'm trying to get a devstack environment working15:41
cdearbornand getting a failure that the sushy library is not installed15:41
cdearbornany thoughts on how to make devstack install it?15:42
TheJuliacdent: hmm15:45
TheJuliaerr15:45
TheJuliacdearborn: hmm15:45
cdent:)15:45
* etingof thinks that fishy stuff gets pulled conditionally - when redfish hw type is being used15:46
*** efried has quit IRC15:46
TheJuliayeah, it is based on what hardware type is set15:46
* etingof would first configure devstack (local.conf), then run the whole thing15:46
etingofso devstack would know what components should be installed15:47
TheJuliawell, it is all about is_*_deployed15:47
TheJuliais_drac_enabled triggers python-dracclient being installed15:47
etingofdoes dracclient invoke sushy?15:48
TheJuliai guess not...15:48
etingofyeah...15:48
cdearbornhrm - i have IRONIC_ENABLED_HARDWARE_TYPE=idrac,redfish,ipmi15:49
etingofhow about IRONIC_IS_HARDWARE?15:50
cdearbornset to True15:50
etingofhmm15:50
* etingof would look into bash output when ironic devstack plugin is running15:52
TheJuliaso we need to revise the logic around 691 in the devstack plugin15:52
cdearbornurgh - found it15:52
TheJuliaspecifically add is_redfish_enabled15:52
cdearbornso, i have IRONIC_DEPLOY_DRIVER=ipmi15:53
*** cdent has quit IRC15:53
cdearborni thought that setting was specifically for the VMs that are created for emulating baremetal?15:53
TheJuliano, it is the default hardware type to use for enrollment15:53
cdearbornah - thx15:54
etingofthe other interesting thing is here -- https://github.com/openstack/ironic/blob/master/devstack/lib/ironic#L103915:54
cdearbornsoooo - i was trying to set up a devstack where i could use either redfish or idrac hardware type15:54
*** verma-varsha has joined #openstack-ironic15:55
cdearbornbut, looking at the code, it appears that it will only install the libraries for whatever you have IRONIC_DEPLOY_DRIVER set to15:55
cdearbornis that right?15:57
etingofshould we rather use IRONIC_ENABLED_HARDWARE_TYPES in is_deployed_by*?15:58
*** lucasagomes has quit IRC15:58
etingofor may be better to call setup_sushy() based on redfish presence in IRONIC_ENABLED_HARDWARE_TYPES, not in IRONIC_DEPLOY_DRIVER?16:00
cdearborni like that idea, but this would have to change... https://github.com/openstack/ironic/blob/master/devstack/lib/ironic#L215016:00
*** dsneddon has joined #openstack-ironic16:02
cdearbornwell, at any rate, i can setup devstack for 1 driver, and if i need to switch, stand up a new devstack vm or redeploy devstack with the other driver16:02
TheJuliait is an easy enough thing to fix16:02
TheJuliaI can change it right now and you can base on top of the patch16:02
etingofperhaps the idea is that you have to respin devstack every time you change IRONIC_DEPLOY_DRIVER so it will reinstall driver requirements16:06
*** verma-varsha has quit IRC16:07
openstackgerritJulia Kreger proposed openstack/ironic master: Install sushy if redfish is a hardware type  https://review.opendev.org/67673216:08
TheJuliaBut for doing something fancy, it might make sense not to really16:10
etingof"fishy" is the new convention16:11
cdearbornTheJulia, etingof: thx!16:11
TheJuliaso fishy things can be fishy?16:12
TheJulia:)16:12
arne_wiebalckTheJulia: I've left reviews on 3 of the 4 open IPA s/w RAID related patches now. Have to leave now, will try to have a look at the last one tmrw.16:15
arne_wiebalckTheJulia: reviews/commens16:15
TheJuliaarne_wiebalck: thanks! :)16:15
arne_wiebalckbye, everyone o/16:15
*** ricolin has quit IRC16:17
*** tssurya has quit IRC16:18
*** verma-varsha has joined #openstack-ironic16:21
*** absubram has joined #openstack-ironic16:26
*** e0ne has quit IRC16:28
*** absubram_ has joined #openstack-ironic16:28
*** absubram has quit IRC16:31
*** absubram_ is now known as absubram16:31
*** alexmcleod has quit IRC16:33
*** absubram has quit IRC16:37
openstackgerritJulia Kreger proposed openstack/ironic master: Change [deploy]/default_boot_option to local  https://review.opendev.org/49211416:39
openstackgerritJulia Kreger proposed openstack/ironic master: update some ci jobs  https://review.opendev.org/67673416:39
*** mgoddard_ has quit IRC17:04
*** derekh has quit IRC17:05
openstackgerritJulia Kreger proposed openstack/ironic master: Support firmware upgrade for irmc driver  https://review.opendev.org/59999217:16
openstackgerritNisha Brahmankar proposed openstack/ironic-python-agent master: Adds CI job that uses DIB build images  https://review.opendev.org/67623917:21
*** verma-varsha has quit IRC17:27
*** priteau has quit IRC17:39
*** e0ne has joined #openstack-ironic17:52
*** verma-varsha has joined #openstack-ironic17:54
*** absubram has joined #openstack-ironic18:13
*** e0ne has quit IRC18:36
*** ociuhandu has joined #openstack-ironic18:56
*** ociuhandu has quit IRC18:58
*** verma-varsha has quit IRC19:12
*** gregwork has quit IRC19:16
*** gregwork has joined #openstack-ironic19:17
*** verma-varsha has joined #openstack-ironic19:26
*** vesper11 has quit IRC19:30
TheJulialooks like we're getting random timeouts on standalone jobs19:34
TheJuliaAnd that is causing an abnormally high failure count19:35
TheJuliaI'm going to take a look after I have some dinner19:35
*** jcoufal has joined #openstack-ironic19:41
*** verma-varsha has quit IRC19:49
*** jcoufal has quit IRC19:49
*** dougsz has joined #openstack-ironic20:10
*** dougsz has quit IRC20:18
*** jtomasek has quit IRC20:27
*** dougsz has joined #openstack-ironic20:33
*** cdearborn has quit IRC20:37
*** jcoufal has joined #openstack-ironic20:43
*** dougsz has quit IRC20:48
*** jcoufal has quit IRC20:49
*** vesper11 has joined #openstack-ironic20:51
*** bdodd has quit IRC20:56
openstackgerritMerged openstack/ironic master: Do not tear down node upon cleaning failure  https://review.opendev.org/65094221:14
openstackgerritSteve Baker proposed openstack/metalsmith master: Allow reserve_node to backfill from existing node  https://review.opendev.org/67652521:43
openstackgerritraphael.glon proposed openstack/ironic-python-agent master: Softraid: partitioning fixes  https://review.opendev.org/67481921:48
openstackgerritraphael.glon proposed openstack/ironic-python-agent master: Software raid: default partition table type change  https://review.opendev.org/67480322:01
*** trident has quit IRC22:03
*** ijw has joined #openstack-ironic22:05
*** trident has joined #openstack-ironic22:10
*** ijw has quit IRC23:29
*** absubram has quit IRC23:33
*** sthussey has quit IRC23:34
openstackgerritDigambar proposed openstack/ironic stable/rocky: DRAC: Fix OOB introspection to use pxe_enabled flag in idrac driver  https://review.opendev.org/64836023:39
*** igordc has joined #openstack-ironic23:46

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!