*** rcernin has quit IRC | 00:06 | |
*** rcernin has joined #openstack-ironic | 00:18 | |
*** johnhaan has quit IRC | 00:51 | |
*** nishagb has quit IRC | 00:51 | |
*** niceplace has quit IRC | 00:52 | |
*** johnhaan has joined #openstack-ironic | 00:52 | |
*** nishagb has joined #openstack-ironic | 00:53 | |
*** niceplace has joined #openstack-ironic | 00:54 | |
*** gregoryo has joined #openstack-ironic | 00:55 | |
*** rcernin has quit IRC | 01:12 | |
*** rcernin has joined #openstack-ironic | 01:17 | |
*** hwoarang has quit IRC | 01:18 | |
*** hwoarang has joined #openstack-ironic | 01:24 | |
*** jhesketh has quit IRC | 02:12 | |
*** jhesketh has joined #openstack-ironic | 02:13 | |
openstackgerrit | Merged openstack/bifrost master: Deprecate the Nginx data store https://review.opendev.org/665961 | 03:20 |
---|---|---|
*** whoami-rajat has joined #openstack-ironic | 03:54 | |
*** ricolin has joined #openstack-ironic | 04:19 | |
openstackgerrit | Merged openstack/ironic master: Software RAID: Add documentation https://review.opendev.org/666884 | 04:30 |
*** rachit7 has joined #openstack-ironic | 05:56 | |
mkrai | good morning ironic o/ | 06:01 |
mkrai | mgoddard: Hi | 06:01 |
mkrai | I am working on the manual deploy step spec | 06:01 |
mkrai | I am not sure whether we should introduce a new API for it or change an existing one. | 06:02 |
mkrai | I am thinking to use the /v1/nodes/{node_ident}/states/provision API with deploy_step parameter | 06:04 |
*** mkowalski has joined #openstack-ironic | 06:06 | |
*** mkowalski has quit IRC | 06:06 | |
*** mkowalski has joined #openstack-ironic | 06:07 | |
*** ildikov_ has joined #openstack-ironic | 06:07 | |
*** aprice_ has joined #openstack-ironic | 06:08 | |
*** mkowalski has quit IRC | 06:08 | |
*** mkowalski has joined #openstack-ironic | 06:08 | |
*** diga has joined #openstack-ironic | 06:09 | |
diga | Good Morning Ironic! | 06:10 |
*** Anticime1 has joined #openstack-ironic | 06:10 | |
rachit7 | diga Good Morning, web UI changed | 06:11 |
diga | :) | 06:11 |
rachit7 | :) | 06:11 |
diga | Yes | 06:11 |
diga | Nice UI | 06:12 |
*** ddurst- has joined #openstack-ironic | 06:14 | |
*** ddurst has quit IRC | 06:15 | |
*** Anticimex has quit IRC | 06:15 | |
*** aprice has quit IRC | 06:15 | |
*** ildikov has quit IRC | 06:15 | |
*** aprice_ is now known as aprice | 06:15 | |
*** ildikov_ is now known as ildikov | 06:15 | |
*** irclogbot_0 has quit IRC | 06:18 | |
*** irclogbot_1 has joined #openstack-ironic | 06:19 | |
*** pcaruana has joined #openstack-ironic | 06:25 | |
*** yedongcan has joined #openstack-ironic | 06:30 | |
arne_wiebalck | good morning, ironic! | 06:40 |
*** rcernin has quit IRC | 06:57 | |
*** jtomasek has joined #openstack-ironic | 06:58 | |
*** e0ne has quit IRC | 06:59 | |
*** iurygregory has joined #openstack-ironic | 07:00 | |
openstackgerrit | Arne Wiebalck proposed openstack/ironic master: [Trivial] Software RAID: Documentation edits https://review.opendev.org/667026 | 07:01 |
iurygregory | morning all | 07:01 |
*** tesseract has joined #openstack-ironic | 07:11 | |
*** diga has quit IRC | 07:15 | |
*** hjensas has quit IRC | 07:25 | |
etingof | cool Monday morning [so far] o/ | 07:28 |
*** yedongcan has quit IRC | 07:38 | |
*** tssurya has joined #openstack-ironic | 07:39 | |
*** trident has quit IRC | 07:40 | |
*** trident has joined #openstack-ironic | 07:41 | |
*** lucasagomes has joined #openstack-ironic | 07:49 | |
*** yedongcan has joined #openstack-ironic | 07:52 | |
openstackgerrit | M V P Nitesh proposed openstack/ironic-lib master: Returns disk_identifier for UEFI boot mode nodes https://review.opendev.org/664852 | 08:00 |
*** yedongcan has quit IRC | 08:07 | |
*** dougsz has joined #openstack-ironic | 08:09 | |
*** gregoryo has quit IRC | 08:21 | |
*** e0ne has joined #openstack-ironic | 08:27 | |
*** rachit7 has quit IRC | 08:29 | |
mgoddard | hi mkrai, do you have a story for that feature? | 08:29 |
mkrai | mgoddard: yes, i am ooo for another 2 hrs | 08:30 |
mkrai | mgoddard: will send it later today | 08:30 |
mgoddard | mkrai: ok, thanks | 08:31 |
*** Emine has joined #openstack-ironic | 08:32 | |
*** rachit7 has joined #openstack-ironic | 08:43 | |
*** yedongcan has joined #openstack-ironic | 08:46 | |
*** whoami-rajat has quit IRC | 08:48 | |
*** bobmel has joined #openstack-ironic | 08:51 | |
*** yedongcan has quit IRC | 09:00 | |
*** yedongcan has joined #openstack-ironic | 09:10 | |
*** yedongcan has quit IRC | 09:17 | |
*** ricolin has quit IRC | 09:22 | |
*** hjensas has joined #openstack-ironic | 09:22 | |
*** yedongcan has joined #openstack-ironic | 09:24 | |
*** yedongcan has quit IRC | 09:35 | |
*** yedongcan has joined #openstack-ironic | 09:44 | |
openstackgerrit | M V P Nitesh proposed openstack/ironic-lib master: Returns disk_identifier for UEFI boot mode nodes https://review.opendev.org/664852 | 09:53 |
*** yedongcan has quit IRC | 09:54 | |
*** yedongcan has joined #openstack-ironic | 09:54 | |
openstackgerrit | Ilya Etingof proposed openstack/ironic master: Collect sensor data in ``redfish`` hardware type https://review.opendev.org/665646 | 09:54 |
*** diga has joined #openstack-ironic | 10:21 | |
diga | arne_wiebalck - Hi | 10:22 |
*** monica_pardhi has joined #openstack-ironic | 10:23 | |
*** rh-jelabarre has quit IRC | 10:33 | |
*** rnoriega- has joined #openstack-ironic | 10:44 | |
*** rnoriega has quit IRC | 10:45 | |
*** jaypipes has joined #openstack-ironic | 10:57 | |
arne_wiebalck | diga o/ | 11:01 |
*** diga has quit IRC | 11:02 | |
*** Lucas_Gray has joined #openstack-ironic | 11:29 | |
mkrai | mgoddard: hi, https://storyboard.openstack.org/#!/story/2005129 | 11:30 |
*** mkrai_ has joined #openstack-ironic | 11:39 | |
mkrai_ | Hi can someone please review https://review.opendev.org/#/c/659550/ | 11:40 |
patchbot | patch 659550 - ironic - Add IntelIPMIHardware - 7 patch sets | 11:40 |
mkrai_ | https://review.opendev.org/#/c/662980/ | 11:40 |
patchbot | patch 662980 - ironic - Add documentation for IntelIPMI hardware - 5 patch sets | 11:40 |
openstackgerrit | Surya Seetharaman proposed openstack/ironic master: Support power state change callbacks to nova https://review.opendev.org/664842 | 11:54 |
*** monica_pardhi has quit IRC | 11:56 | |
*** jcoufal has joined #openstack-ironic | 12:00 | |
*** edleafe has joined #openstack-ironic | 12:08 | |
*** whoami-rajat has joined #openstack-ironic | 12:14 | |
*** rh-jelabarre has joined #openstack-ironic | 12:26 | |
*** jroll has quit IRC | 12:28 | |
*** jroll has joined #openstack-ironic | 12:29 | |
*** nishagb has quit IRC | 12:29 | |
mgoddard | mkrai_: are you still planning to use a nova resize for this? | 12:33 |
mkrai_ | yes | 12:34 |
mkrai_ | mgoddard, yes | 12:34 |
mgoddard | mkrai_: if so, I think it would be a new state transition | 12:34 |
mgoddard | similar to rebuild | 12:34 |
mgoddard | https://docs.openstack.org/ironic/latest/_images/states.svg | 12:34 |
mgoddard | but called resize | 12:34 |
mgoddard | in which case I think it would use https://developer.openstack.org/api-ref/baremetal/?expanded=change-node-provision-state-detail | 12:35 |
mgoddard | with target=resize | 12:35 |
mgoddard | mkrai_: if we are using traits for this then no need for deploy_step argument | 12:36 |
mkrai_ | mgoddard, ok i am +1 for adding a new state | 12:36 |
mkrai_ | but the "resize" name doesn't match what we are doing in Ironic | 12:37 |
mkrai_ | WDYT | 12:37 |
mgoddard | mkrai_: we would just calculate deploy steps from the traits like a normal deploy | 12:37 |
mgoddard | that's true | 12:37 |
mgoddard | reconfigure? | 12:37 |
*** rh-jelabarre has quit IRC | 12:37 | |
mgoddard | the problem is, what if we have a trait for CUSTOM_RAID10, and it changes to CUSTOM_RAID1? | 12:38 |
mgoddard | we can't guarantee that all changes will work on an active node | 12:38 |
mkrai_ | mgoddard, reconfigure still sounds better | 12:39 |
mgoddard | and we don't know which deploy steps were applied previously in order to do a 'diff' | 12:39 |
mgoddard | hmm, I'm not sure this model works actually | 12:39 |
mkrai_ | mgoddard, CUSTOM_RAID1 is a wrong trait? | 12:40 |
mkrai_ | I am sorry don't know much about RAID | 12:40 |
mgoddard | mkrai_: no, but if we change the RAID config we would lose data on the disks | 12:40 |
*** rh-jelabarre has joined #openstack-ironic | 12:40 | |
mkrai_ | mgoddard, is it not okay if the operation is performed by admins? | 12:41 |
mgoddard | mkrai_: the problem is, the traits in a flavor map to deploy templates which give a set of deploy steps suitable to deploy the node | 12:41 |
*** priteau has joined #openstack-ironic | 12:42 | |
mgoddard | mkrai_: if you change one trait you may get a new complete set of deploy steps, not just one that changed | 12:42 |
mkrai_ | mgoddard, right | 12:42 |
mgoddard | so there may be some cases where this does not work (like RAID) | 12:43 |
mkrai_ | mgoddard, will this issue not occur with current deployment? | 12:44 |
mgoddard | mkrai_: no, because we always start from a freshly cleaned node, and don't care about data on the disks | 12:44 |
mkrai_ | mgoddard, I see | 12:45 |
mkrai_ | mgoddard, can we control the deploy_templates on active nodes? | 12:45 |
mkrai_ | mgoddard, like can't apply CUSTOM_RAID1 on `active` nodes? | 12:46 |
mgoddard | the RFE you linked does not include nova or traits or even templates - the operator just specifies a list of steps to execute | 12:46 |
mkrai_ | mgoddard, yes, that's was my initial idea :) I will update the RFE this week | 12:46 |
mgoddard | mkrai_: I will respond on the ML thread with my concerns about this approach | 12:49 |
mkrai_ | mgoddard, Ok thanks | 12:50 |
mkrai_ | mgoddard, I will wait for it. I am working on both nova and ironic spec where this will help :) | 12:51 |
*** beekneemech is now known as bnemec | 12:51 | |
*** mkrai_ has quit IRC | 12:58 | |
*** mkrai__ has joined #openstack-ironic | 12:58 | |
*** sthussey has joined #openstack-ironic | 13:07 | |
*** mbeierl has joined #openstack-ironic | 13:10 | |
*** trident has quit IRC | 13:29 | |
*** trident has joined #openstack-ironic | 13:35 | |
openstackgerrit | Ilya Etingof proposed openstack/sushy master: Handle incomplete message registries https://review.opendev.org/666253 | 13:43 |
etingof | rpittau|afk, the ^ fix appears insufficient, once it's in place the new problem showed up: sushy.exceptions.MissingAttributeError: The attribute RegistryPrefix is missing from the resource /redfish/v1/Systems/System.Embedded.1/Bios/BiosRegistry | 13:50 |
* etingof meant rpioso, not rpittau|afk | 13:50 | |
etingof | once the RegistryPrefix problem is fixed, no more fishy stuff comes up so far | 14:02 |
*** mkowalski has quit IRC | 14:17 | |
*** mkowalski has joined #openstack-ironic | 14:17 | |
*** rajinir has joined #openstack-ironic | 14:41 | |
*** yedongcan has quit IRC | 14:43 | |
*** zhangfei has joined #openstack-ironic | 14:52 | |
*** jaypipes_ has joined #openstack-ironic | 15:01 | |
openstackgerrit | Surya Seetharaman proposed openstack/ironic master: Support power state change callbacks to nova https://review.opendev.org/664842 | 15:01 |
*** mkowalski has quit IRC | 15:02 | |
*** mkowalski has joined #openstack-ironic | 15:02 | |
*** jaypipes has quit IRC | 15:04 | |
openstackgerrit | Ilya Etingof proposed openstack/sushy master: Handle incomplete message registries https://review.opendev.org/666253 | 15:05 |
openstackgerrit | Ilya Etingof proposed openstack/sushy master: Handle incomplete message registries https://review.opendev.org/666253 | 15:07 |
*** yedongcan has joined #openstack-ironic | 15:08 | |
*** priteau has quit IRC | 15:17 | |
*** rachit7 has quit IRC | 15:20 | |
openstackgerrit | Merged openstack/ironic-lib master: Returns disk_identifier for UEFI boot mode nodes https://review.opendev.org/664852 | 15:22 |
*** priteau has joined #openstack-ironic | 15:25 | |
*** mkrai__ has quit IRC | 15:31 | |
*** tesseract has quit IRC | 15:33 | |
*** zhangfei has quit IRC | 15:38 | |
*** mkowalski has quit IRC | 15:45 | |
TheJulia | our tempest tests need work | 15:55 |
*** ddurst- is now known as ddurst | 15:57 | |
rpioso | etingof: lol | 16:04 |
*** Lucas_Gray has quit IRC | 16:05 | |
rpioso | etingof: Are you suggesting that fixing the subject bug uncovers another latent bug? | 16:05 |
*** mkrai__ has joined #openstack-ironic | 16:05 | |
*** priteau has quit IRC | 16:05 | |
*** lucasagomes has quit IRC | 16:06 | |
*** tssurya has quit IRC | 16:11 | |
*** e0ne has quit IRC | 16:12 | |
*** iurygregory has quit IRC | 16:17 | |
etingof | rpioso, exactly, but the second bug seems to be on redfish server... | 16:19 |
rpioso | etingof: Is it this line that causes the fishy stuff -- https://opendev.org/openstack/sushy/src/commit/640c567bae6c11fb4a8f92ec591066ad400e80cb/sushy/main.py#L352? | 16:20 |
etingof | rpioso, I am not sure, it seemed to be that server implementation I am working with misses required RegistryPrefix attribute | 16:21 |
etingof | rpioso, however I did not dig any deeper because the absence of the required attribute kind of explained the problem right away... or not? | 16:22 |
rpioso | etingof: Well, that's the only use of registry_prefix I could find in the library. I agree that the schema states that attribute is required. | 16:24 |
rpioso | etingof: I'm a bit unclear. Is the new bug gating the merge of the fix to the original one? They seem orthogonal. | 16:26 |
* rpioso doesn't yet understand how the fix to the subject bug uncovered the server's bug? | 16:28 | |
*** trident has quit IRC | 16:30 | |
*** dougsz has quit IRC | 16:32 | |
*** trident has joined #openstack-ironic | 16:32 | |
*** yedongcan has left #openstack-ironic | 16:33 | |
rpioso | etingof: Is it perhaps because the fix to the original one "tries to use all potentially suitable language files, not just the first one" and the registry with the missing attribute is described by a MessageRegistryFile that is not the first one? | 16:34 |
rpioso | etingof: Is the new fishy stuff being found in the gate or in your integration testing? | 16:35 |
openstackgerrit | Julia Kreger proposed openstack/ironic master: WIP ipv6 job https://review.opendev.org/613169 | 16:40 |
*** igordc has joined #openstack-ironic | 16:42 | |
*** whoami-rajat has quit IRC | 16:44 | |
etingof | rpioso, I run into this in my devstack while testing virtual media boot deployment | 16:51 |
*** mkrai__ has quit IRC | 16:51 | |
etingof | rpioso, do you think the problem is in the first fix? or is it that the server should not expose incomplete registry? | 16:52 |
*** gfhellma has joined #openstack-ironic | 16:54 | |
*** Emine has quit IRC | 16:57 | |
rpioso | etingof: Trying to use all potentially suitable language files, not just the first one, seems reasonably forgiving to me. And those uris are optional. | 17:00 |
etingof | rpioso, after all, redfish does not mandate the consumer to pick the first language file deemed suitable... | 17:01 |
*** whoami-rajat has joined #openstack-ironic | 17:02 | |
*** Goneri has quit IRC | 17:02 | |
*** e0ne has joined #openstack-ironic | 17:07 | |
*** e0ne has quit IRC | 17:08 | |
rpioso | etingof: That change is to the processing of MessageRegistryFile s, which describe MessageRegistry s. The latent bug occurs when sushy processes the MessageRegistry its selected MessageRegistryFile describes. I don't think sushy should follow the entire trail checking for proper server responses before selecting a MessageRegistryFile. However, it should be robust when a required attribute is missing by at least | 17:08 |
rpioso | emitting an informative error log. | 17:08 |
etingof | rpioso, well, sushy has this 'required' property for each object it receives from the server. that is the `required` flag causing the second failure. the value for the `required` flag comes directly from the redfish schema. sushy does not try to relax these schema requirements so far... | 17:11 |
*** kbaegis has joined #openstack-ironic | 17:15 | |
kbaegis | HI everyone | 17:15 |
rpioso | etingof: What occurs when the new bug is encountered? Is something helpful logged? Is the Sushy session aborted? | 17:16 |
kbaegis | I have a challenge for the conductor service. What's the best way to unpin the conductor caching/validation from an IP address? | 17:16 |
kbaegis | Does anyone here use dns/hostnames in the urls they configure for a node? | 17:17 |
* rpioso wonders if the 'messages' attribute should be required -- https://opendev.org/openstack/sushy/src/commit/640c567bae6c11fb4a8f92ec591066ad400e80cb/sushy/resources/registry/message_registry.py#L80 | 17:17 | |
kbaegis | i.e. deploy_kernel=host.domain:8080/test.qcow2 vs deploy_kernel=1.2.3.4/test/qcow2 | 17:18 |
* rpioso goes to refuel | 17:18 | |
etingof | rpioso, sushy fails the entire workflow with this message logged: sushy.exceptions.MissingAttributeError: The attribute RegistryPrefix is missing from the resource /redfish/v1/Systems/System.Embedded.1/Bios/BiosRegistry | 17:18 |
kbaegis | etingof: Fortunately you can disable the bios interface for sushy. Doesn't work for me either | 17:19 |
rpioso | etingof: I like the error message. It seems extreme to fail the entire workflow over a poorly formed message registry. | 17:19 |
rpioso | *extremely unforgiving | 17:20 |
rpioso | etingof: After all, message registries aren't required :-) | 17:20 |
etingof | rpioso, that's automatic with sushy, if it comes to parsing anything coming from the server, that should compliant | 17:20 |
rpioso | etingof: Oh well :-( | 17:21 |
etingof | kbaegis, proposes to disable bios interface to work around this o/ | 17:21 |
* rpioso has to run. Will be back in a bit. | 17:22 | |
kbaegis | I don't know if bios is a hard requirement for you; I disable it because SMC has no intention of enabling it for my equipment. | 17:22 |
etingof | rpioso, point is that we should better not adjust sushy to something non-compliant because then we could not autogenerate sushy stuff from fishy stuff | 17:22 |
openstackgerrit | Surya Seetharaman proposed openstack/ironic master: Support power state change callbacks to nova https://review.opendev.org/664842 | 17:26 |
*** e0ne has joined #openstack-ironic | 17:27 | |
etingof | kbaegis, I do not need bios per se, thanks for the hint! o/ | 17:28 |
kbaegis | np | 17:31 |
kbaegis | Still could use some help on the other issue. @TheJulia around? | 17:31 |
TheJulia | kbaegis: on a decelerating train deep inside of Europe right now, I am happy to try and answer questions when I get up on the morning. | 17:33 |
kbaegis | Ahh- :D ttyl | 17:33 |
NobodyCam | Good Morning Ironic'ers | 17:45 |
*** kbaegis has quit IRC | 17:50 | |
*** e0ne has quit IRC | 18:02 | |
*** e0ne has joined #openstack-ironic | 18:06 | |
rpioso | NobodyCam: Good mornin’ | 18:09 |
rpioso | etingof: Sounds like sushy doesn’t apply the Robustness Principle — https://en.m.wikipedia.org/wiki/Robustness_principle | 18:18 |
etingof | rpioso, no, it does not! I guess that would be quite complicated in practice because that would require manual adjustments and handling for the missing pieces... | 18:21 |
rpioso | etingof: Doesn't the response comply with the schema pointed to by the response's @odata.context? | 18:48 |
rpioso | etingof: That schema doesn't list RegistryPrefix. | 18:48 |
NobodyCam | Morning rpioso :) | 18:48 |
rpioso | NobodyCam: o/ | 18:49 |
NobodyCam | :) | 18:49 |
openstackgerrit | Corey Bryant proposed openstack/ironic-python-agent master: Add Python 3 Train unit tests https://review.opendev.org/665052 | 18:55 |
etingof | rpioso, I am looking at this schema -- https://redfish.dmtf.org/schemas/v1/MessageRegistry.v1_3_0.json | 18:55 |
openstackgerrit | Corey Bryant proposed openstack/ironic master: Add Python 3 Train unit tests https://review.opendev.org/637258 | 18:56 |
etingof | rpioso, my understanding is that if MessageRegistry is present, it has to have RegistryPrefix | 18:56 |
openstackgerrit | Corey Bryant proposed openstack/bifrost master: Add Python 3 Train unit tests https://review.opendev.org/667181 | 18:58 |
openstackgerrit | Corey Bryant proposed openstack/ironic-inspector master: Add Python 3 Train unit tests https://review.opendev.org/667182 | 18:58 |
openstackgerrit | Corey Bryant proposed openstack/ironic-lib master: Add Python 3 Train unit tests https://review.opendev.org/667183 | 18:59 |
openstackgerrit | Corey Bryant proposed openstack/ironic-ui master: Add Python 3 Train unit tests https://review.opendev.org/667184 | 19:00 |
*** e0ne has quit IRC | 19:00 | |
*** e0ne has joined #openstack-ironic | 19:03 | |
openstackgerrit | Corey Bryant proposed openstack/metalsmith master: Add Python 3 Train unit tests https://review.opendev.org/667186 | 19:03 |
openstackgerrit | Corey Bryant proposed openstack/networking-baremetal master: Add Python 3 Train unit tests https://review.opendev.org/667188 | 19:05 |
openstackgerrit | Corey Bryant proposed openstack/networking-baremetal master: Add Python 3 Train unit tests https://review.opendev.org/652384 | 19:05 |
openstackgerrit | Corey Bryant proposed openstack/networking-generic-switch master: Add Python 3 Train unit tests https://review.opendev.org/652385 | 19:06 |
rpioso | etingof: Does it contain Messages? | 19:07 |
openstackgerrit | Corey Bryant proposed openstack/python-ironicclient master: Add Python 3 Train unit tests https://review.opendev.org/667189 | 19:09 |
openstackgerrit | Corey Bryant proposed openstack/python-ironic-inspector-client master: Add Python 3 Train unit tests https://review.opendev.org/667191 | 19:12 |
*** bobmel has quit IRC | 19:12 | |
openstackgerrit | Corey Bryant proposed openstack/sushy master: Add Python 3 Train unit tests https://review.opendev.org/667192 | 19:13 |
openstackgerrit | Corey Bryant proposed openstack/sushy-tools master: Add Python 3 Train unit tests https://review.opendev.org/667193 | 19:13 |
openstackgerrit | Corey Bryant proposed openstack/tenks master: Add Python 3 Train unit tests https://review.opendev.org/667194 | 19:13 |
openstackgerrit | Corey Bryant proposed openstack/virtualbmc master: Add Python 3 Train unit tests https://review.opendev.org/667195 | 19:14 |
*** e0ne has quit IRC | 19:16 | |
*** e0ne has joined #openstack-ironic | 19:19 | |
*** jtomasek has quit IRC | 19:22 | |
*** whoami-rajat has quit IRC | 19:34 | |
*** e0ne has quit IRC | 19:36 | |
*** jcoufal has quit IRC | 19:37 | |
*** e0ne has joined #openstack-ironic | 19:49 | |
*** bnemec has quit IRC | 20:00 | |
*** bnemec has joined #openstack-ironic | 20:08 | |
*** gfhellma has quit IRC | 20:27 | |
*** e0ne has quit IRC | 20:34 | |
*** pcaruana has quit IRC | 20:44 | |
*** e0ne has joined #openstack-ironic | 20:46 | |
*** e0ne has quit IRC | 20:47 | |
rpioso | etingof: I dug some more and chatted with mraineri. The DMTF overloaded "MessageRegistryFile" to point to any type of registry. Those include "MessageRegistry", "AttributeRegistry", and "PrivilegeRegistry" resources. | 20:54 |
rpioso | etingof: All of them show up in /redfish/v1/Registries. | 20:54 |
rpioso | etingof: The "MessageRegistryFile" 's "Uri", "ArchiveUri", and "PublicationUri" properties are weak strings. | 20:56 |
rpioso | etingof: To determine the type of resource it is, read the referenced registry. If its "'@odata.type'" property is "MessageRegistry", consume it; otherwise, disregard it. | 21:01 |
rpioso | etingof: Point your browser at http://redfish.dmtf.org/schemas/v1/MessageRegistryFile_v1.xml and search for 'Privilege'. | 21:02 |
rpioso | etingof: The "Registry" property's description includes, "This Registry can reference any type of Registry, such as a Message Registry, Privilege Registry, or Attribute Registry." | 21:04 |
rpioso | etingof: A shout out goes to mraineri for explaining the overloading and that it's compliant with the standard. | 21:05 |
etingof | rpioso, are you saying that sushy treats something else as MessageRegistry and that something else is allowed to omit RegistryPrefix? | 21:10 |
*** kbaegis has joined #openstack-ironic | 21:14 | |
*** kbaegis has quit IRC | 21:15 | |
*** ianychoi_ has joined #openstack-ironic | 21:19 | |
*** ianychoi has quit IRC | 21:22 | |
*** ianychoi_ has quit IRC | 21:30 | |
*** ianychoi_ has joined #openstack-ironic | 21:31 | |
*** Emine has joined #openstack-ironic | 21:34 | |
*** rajinir has quit IRC | 21:38 | |
rpioso | etingof: Yep | 21:55 |
rpioso | etingof: 1. "ServiceRoot" has an optional "Registries" property. "Registries" is a "MessageRegistryFileCollection". | 21:57 |
rpioso | *reference to a "MessageRegistryFileCollection" | 22:03 |
rpioso | 2. "MessageRegistryFileCollection" contains an array of "MessageRegistryFile" references. | 22:03 |
rpioso | 3. Each "MessageRegistryFile" may refer to a Message Registry, Privilege Registry, or AttributeRegistry. | 22:12 |
rpioso | etingof: "RegistryPrefix" is a required property of "MessageRegistry". It's not a required property of "PrivilegeRegistry" nor "AttributeRegistry". | 22:18 |
rpioso | etingof: Please see sushy.main.Sushy._get_message_registries() | 22:22 |
rpioso | etingof: https://opendev.org/openstack/sushy/src/commit/640c567bae6c11fb4a8f92ec591066ad400e80cb/sushy/main.py#L340-L362 | 22:22 |
rpioso | etingof: In the "deficient" ;-) message registry, I believe you'll see '"@odata.type":"#AttributeRegistry.v1_1_1.AttributeRegistry"'. | 22:24 |
*** Emine has quit IRC | 22:43 | |
rpioso | etingof: I believe this new bug is unrelated to the fix to https://review.opendev.org/#/c/666253/ | 22:44 |
patchbot | patch 666253 - sushy - Handle incomplete message registries - 4 patch sets | 22:44 |
rpioso | etingof: My read is the one with the fix under review happens first and masks the new one. | 22:47 |
*** rcernin has joined #openstack-ironic | 22:51 | |
*** ianw_pto is now known as ianw | 23:08 | |
*** jaypipes_ has quit IRC | 23:18 | |
*** sthussey has quit IRC | 23:57 | |
*** rcernin has quit IRC | 23:59 | |
*** rcernin has joined #openstack-ironic | 23:59 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!