openstackgerrit | Zane Bitter proposed openstack/ironic-inspector master: Eliminate SQL injection vulnerability in node_cache https://review.opendev.org/660234 | 00:45 |
---|---|---|
*** rh-jelabarre has quit IRC | 01:31 | |
*** gregoryo has joined #openstack-ironic | 01:50 | |
*** whoami-rajat has joined #openstack-ironic | 02:00 | |
*** hwoarang has quit IRC | 02:04 | |
*** hwoarang has joined #openstack-ironic | 02:05 | |
openstackgerrit | Merged openstack/python-ironicclient stable/rocky: Do not try to use /v1/v1 when endpoint_override is used https://review.opendev.org/659737 | 02:31 |
*** yolanda_ has quit IRC | 03:49 | |
*** w14161_1 has quit IRC | 04:24 | |
*** w14161_1 has joined #openstack-ironic | 04:29 | |
*** tzumainn has quit IRC | 04:35 | |
*** itlinux has quit IRC | 04:46 | |
*** pcaruana has joined #openstack-ironic | 05:02 | |
*** pcaruana has quit IRC | 05:11 | |
*** Lucas_Gray has joined #openstack-ironic | 05:23 | |
*** e0ne has joined #openstack-ironic | 05:23 | |
*** e0ne has quit IRC | 05:24 | |
*** rachit7 has joined #openstack-ironic | 05:57 | |
*** Lucas_Gray has quit IRC | 06:18 | |
*** jistr is now known as jistr|mtg | 06:20 | |
openstackgerrit | Dongcan Ye proposed openstack/ironic-inspector stable/rocky: Enable Swift service https://review.opendev.org/660255 | 06:25 |
arne_wiebalck | good morning, ironic! | 06:42 |
*** trident has quit IRC | 07:03 | |
*** trident has joined #openstack-ironic | 07:05 | |
*** tesseract has joined #openstack-ironic | 07:06 | |
*** rcernin has quit IRC | 07:19 | |
*** tssurya has joined #openstack-ironic | 07:20 | |
*** pcaruana has joined #openstack-ironic | 07:21 | |
*** pcaruana has quit IRC | 07:39 | |
*** rpittau|afk is now known as rpittau | 07:41 | |
rpittau | good morning ironic! o/ | 07:41 |
*** e0ne has joined #openstack-ironic | 07:42 | |
*** e0ne has quit IRC | 07:57 | |
*** e0ne has joined #openstack-ironic | 08:01 | |
*** lucasagomes has joined #openstack-ironic | 08:08 | |
openstackgerrit | Merged openstack/bifrost master: Remove openSUSE Leap 42.3 jobs https://review.opendev.org/660123 | 08:16 |
*** dtantsur|afk is now known as dtantsur | 08:20 | |
dtantsur | morning ironic | 08:20 |
*** priteau has joined #openstack-ironic | 08:20 | |
*** brtknr has joined #openstack-ironic | 08:22 | |
*** priteau has quit IRC | 08:24 | |
*** betherly has joined #openstack-ironic | 08:25 | |
*** priteau has joined #openstack-ironic | 08:29 | |
openstackgerrit | Ilya Etingof proposed openstack/sushy master: Fix exposed UpdateService constants https://review.opendev.org/641989 | 08:43 |
*** derekh has joined #openstack-ironic | 08:43 | |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic-inspector master: Eliminate SQL injection vulnerability in node_cache https://review.opendev.org/660234 | 08:45 |
dtantsur | rpittau, arne_wiebalck, folks, this ^^ is a CVE, could you check it asap please? | 08:45 |
*** jistr|mtg is now known as jistr | 08:46 | |
dtantsur | ditto mgoddard if you're here ^^ | 08:47 |
mgoddard | dtantsur: looking | 08:48 |
rpittau | dtantsur: yep, I was looking for the actual CVE | 08:48 |
dtantsur | dunno where it is, probably not made public yet? | 08:48 |
* dtantsur is not familiar with the CVE process at all | 08:48 | |
dtantsur | but there is enough information in the story | 08:48 |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic-inspector stable/stein: Eliminate SQL injection vulnerability in node_cache https://review.opendev.org/660304 | 09:02 |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic-inspector stable/rocky: Eliminate SQL injection vulnerability in node_cache https://review.opendev.org/660305 | 09:03 |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic-inspector stable/queens: Eliminate SQL injection vulnerability in node_cache https://review.opendev.org/660306 | 09:04 |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic-inspector stable/pike: Eliminate SQL injection vulnerability in node_cache https://review.opendev.org/660308 | 09:04 |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic-inspector stable/ocata: Eliminate SQL injection vulnerability in node_cache https://review.opendev.org/660310 | 09:06 |
dtantsur | okay, all backports done | 09:06 |
*** dtantsur is now known as dtantsur|brb | 09:06 | |
*** rachit7 has quit IRC | 09:07 | |
*** jimyeh____ has joined #openstack-ironic | 09:11 | |
*** jimyeh____ has left #openstack-ironic | 09:13 | |
*** openstackstatus has quit IRC | 09:13 | |
*** openstackstatus has joined #openstack-ironic | 09:14 | |
*** ChanServ sets mode: +v openstackstatus | 09:14 | |
*** gregoryo has quit IRC | 09:15 | |
*** BigJim has joined #openstack-ironic | 09:29 | |
BigJim | logout | 09:34 |
*** BigJim has left #openstack-ironic | 09:35 | |
*** BigJim_ has joined #openstack-ironic | 09:36 | |
*** BigJim_ is now known as tw_jim | 09:37 | |
tw_jim | /msg NickServ help | 09:40 |
*** tw_jim has left #openstack-ironic | 09:40 | |
etingof | may be CVE is not filed yet? -- https://cve.mitre.org/cgi-bin/cvekey.cgi?keyword=ironic | 09:46 |
etingof | or still embargoed | 09:53 |
*** tw_jim has joined #openstack-ironic | 09:59 | |
openstackgerrit | Dongcan Ye proposed openstack/ironic-tempest-plugin master: Set introspection data_store default to none https://review.opendev.org/660336 | 10:05 |
*** Lucas_Gray has joined #openstack-ironic | 10:11 | |
*** mmethot has quit IRC | 10:11 | |
openstackgerrit | Dongcan Ye proposed openstack/ironic-inspector stable/rocky: [DNM] Gate test https://review.opendev.org/660255 | 10:13 |
openstackgerrit | Dongcan Ye proposed openstack/ironic-inspector master: [DNM] gate test https://review.opendev.org/660342 | 10:20 |
*** dtantsur|brb is now known as dtantsur | 10:30 | |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic-inspector master: devstack: check if swift is enabled when deciding on the data backend https://review.opendev.org/660347 | 10:43 |
*** mmethot has joined #openstack-ironic | 11:01 | |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic master: Allocation API: backfilling allocations https://review.opendev.org/648178 | 11:05 |
openstackgerrit | Dmitry Tantsur proposed openstack/python-ironicclient master: Allocation API: support allocation backfilling https://review.opendev.org/648406 | 11:08 |
openstackgerrit | Dongcan Ye proposed openstack/ironic-tempest-plugin master: Set introspection data_store default to none https://review.opendev.org/660336 | 11:08 |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic-tempest-plugin master: Allocation API: add tests on backfilling allocations https://review.opendev.org/648403 | 11:09 |
openstackgerrit | Ilya Etingof proposed openstack/sushy master: Fix exposed UpdateService constants https://review.opendev.org/641989 | 11:12 |
openstackgerrit | Dongcan Ye proposed openstack/ironic-tempest-plugin master: Compatible with old Swift service enable https://review.opendev.org/660336 | 11:36 |
jroll | wheeeeeee backports | 11:49 |
jroll | lol embargoed CVE but the patch is in the wild? :facepalm: | 11:49 |
dtantsur | morning jroll. I wasn't there when the decision was made to publish it.. | 11:50 |
jroll | dtantsur: shall I wait for the master change to land before I approve those backports, or just go for it? | 11:50 |
dtantsur | jroll: go for it (rocky and queens CI has unrelated issues) | 11:50 |
jroll | will do | 11:51 |
dtantsur | will hopefully be fixed by https://review.opendev.org/#/c/660336/ (reviews welcome) | 11:51 |
jroll | thanks for putting them up | 11:51 |
patchbot | patch 660336 - ironic-tempest-plugin - Compatible with old Swift service enable - 3 patch sets | 11:51 |
dtantsur | np | 11:51 |
jroll | +W on everything, including the tempest plugin patch | 11:53 |
dtantsur | thx! | 11:54 |
*** bfournie has quit IRC | 12:04 | |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic-tempest-plugin master: Allocation API: add tests on backfilling allocations https://review.opendev.org/648403 | 12:17 |
*** priteau has quit IRC | 12:36 | |
arne_wiebalck | dtantsur: sorry, we had an ironic intervention today and I only see the cve patch now | 12:37 |
*** priteau has joined #openstack-ironic | 12:39 | |
dtantsur | no problem, we've handled it | 12:41 |
*** Goneri has joined #openstack-ironic | 12:43 | |
*** S4ren has joined #openstack-ironic | 12:46 | |
*** priteau has quit IRC | 12:51 | |
*** hwoarang has quit IRC | 13:21 | |
*** hwoarang has joined #openstack-ironic | 13:23 | |
*** goldyfruit has joined #openstack-ironic | 13:23 | |
*** mbeierl has joined #openstack-ironic | 13:27 | |
*** mbeierl has quit IRC | 13:31 | |
*** Lucas_Gray has quit IRC | 13:38 | |
*** Lucas_Gray has joined #openstack-ironic | 13:39 | |
*** itlinux has joined #openstack-ironic | 13:42 | |
*** mbeierl has joined #openstack-ironic | 13:45 | |
*** tzumainn has joined #openstack-ironic | 13:46 | |
*** bfournie has joined #openstack-ironic | 13:53 | |
*** mmethot_ has joined #openstack-ironic | 13:57 | |
*** Wryhder has joined #openstack-ironic | 13:59 | |
*** adrianc_ has joined #openstack-ironic | 13:59 | |
*** rh-jelabarre has joined #openstack-ironic | 14:00 | |
*** goldyfruit has quit IRC | 14:00 | |
*** lifeless_ has joined #openstack-ironic | 14:01 | |
*** Anticime1 has joined #openstack-ironic | 14:01 | |
*** dabadaba_ has joined #openstack-ironic | 14:01 | |
*** early` has joined #openstack-ironic | 14:02 | |
*** quoth_ has joined #openstack-ironic | 14:02 | |
*** goldyfruit has joined #openstack-ironic | 14:03 | |
*** ddurst- has joined #openstack-ironic | 14:05 | |
*** sw3_ has joined #openstack-ironic | 14:05 | |
*** Lucas_Gray has quit IRC | 14:06 | |
*** derekh has quit IRC | 14:06 | |
*** early has quit IRC | 14:06 | |
*** zer0c00l has quit IRC | 14:06 | |
*** SpamapS has quit IRC | 14:06 | |
*** adrianc has quit IRC | 14:06 | |
*** lifeless has quit IRC | 14:06 | |
*** sw3 has quit IRC | 14:06 | |
*** Wryhder is now known as Lucas_Gray | 14:06 | |
*** sw3_ is now known as sw3 | 14:06 | |
*** mmethot has quit IRC | 14:06 | |
*** michchap has quit IRC | 14:06 | |
*** dabadaba has quit IRC | 14:06 | |
*** ddurst has quit IRC | 14:06 | |
*** mjturek has quit IRC | 14:06 | |
*** Anticimex has quit IRC | 14:06 | |
*** strigazi has quit IRC | 14:06 | |
*** problem_v has quit IRC | 14:06 | |
*** dtruong has quit IRC | 14:06 | |
rpittau | need to split, see ya tomorrow folks! | 14:06 |
*** rpittau is now known as rpittau|afk | 14:06 | |
*** problem_v has joined #openstack-ironic | 14:07 | |
*** dtruong has joined #openstack-ironic | 14:08 | |
*** itlinux has quit IRC | 14:13 | |
*** SpamapS has joined #openstack-ironic | 14:13 | |
openstackgerrit | Merged openstack/ironic-inspector master: Eliminate SQL injection vulnerability in node_cache https://review.opendev.org/660234 | 14:35 |
openstackgerrit | Merged openstack/ironic-inspector stable/stein: Eliminate SQL injection vulnerability in node_cache https://review.opendev.org/660304 | 14:35 |
openstackgerrit | Merged openstack/ironic-inspector stable/pike: Eliminate SQL injection vulnerability in node_cache https://review.opendev.org/660308 | 14:35 |
openstackgerrit | Merged openstack/ironic-inspector stable/ocata: Eliminate SQL injection vulnerability in node_cache https://review.opendev.org/660310 | 14:35 |
TheJulia | \o/ | 14:49 |
TheJulia | Also, good morning everyone | 14:49 |
goldyfruit | Morning | 14:50 |
NobodyCam | Good morning ironic’ers | 14:57 |
goldyfruit | Hey NobodyCam o/ | 14:57 |
NobodyCam | Howdy goldyfruit :) | 14:58 |
*** w14161_1 has quit IRC | 15:03 | |
*** hamzy has quit IRC | 15:07 | |
dtantsur | morning TheJulia, goldyfruit, NobodyCam | 15:13 |
NobodyCam | Good morning dtantsur o/ | 15:14 |
goldyfruit | dtantsur o/ | 15:14 |
TheJulia | arne_wiebalck: jroll: mgoddard: I've added a +2 to https://review.opendev.org/#/c/655685, which is now 2x+2. I think it would be really good if one of you can take a quick sanity check look at it. | 15:20 |
patchbot | patch 655685 - ironic-specs - Add spec for indicator management - 7 patch sets | 15:20 |
TheJulia | Thanks! | 15:20 |
mgoddard | TheJulia: will do | 15:20 |
TheJulia | thanks | 15:20 |
TheJulia | rpittau|afk: dtantsur: can I get you two to flip a coin re: virtual media | 15:23 |
*** priteau has joined #openstack-ironic | 15:24 | |
*** mbeierl has quit IRC | 15:24 | |
dtantsur | TheJulia: about what exactly? | 15:25 |
TheJulia | who wants to be listed :) | 15:25 |
TheJulia | Anyone outside of RH interested in the IPv6 Goal? | 15:25 |
dtantsur | TheJulia: I don't mind either way. I can easily let rpittau|afk take it. | 15:26 |
TheJulia | I'm likely going to lean a lot on you the next few months, so maybe rpittau|afk :) | 15:26 |
arne_wiebalck | TheJulia: Will have a look. | 15:26 |
dtantsur | okie | 15:27 |
* dtantsur gets really frustrated with IPv6 really quickly | 15:27 | |
TheJulia | arne_wiebalck: thanks | 15:27 |
* TheJulia wonders if we need to temporarily ship dtantsur to someplace... relaxing... to work on ipv6 | 15:28 | |
dtantsur | TheJulia: we went to the Baltic Sea this weekend, it was fantastic :) I'd love to work from there for a week.. or a month.. or forever? | 15:28 |
dtantsur | python-zeroconf supports IPv4 and IPv6 on both POSIX and Windows, and this is going to drive me mad | 15:29 |
* TheJulia wonders if this is a route to requisition something like https://marvelcinematicuniverse.fandom.com/wiki/Helicarrier or https://agentsofshield.fandom.com/wiki/S.H.I.E.L.D._Globemaster | 15:29 | |
dtantsur | mmmmm, nice! | 15:29 |
*** rloo has joined #openstack-ironic | 15:34 | |
*** hamzy has joined #openstack-ironic | 15:35 | |
openstackgerrit | Ilya Etingof proposed openstack/ironic master: Fix GRUB config path when building EFI ISO https://review.opendev.org/659050 | 15:37 |
openstackgerrit | Ilya Etingof proposed openstack/ironic master: Fix binary file upload to Swift https://review.opendev.org/659061 | 15:38 |
openstackgerrit | Ilya Etingof proposed openstack/ironic master: WIP: Add Redfish Virtual Media support https://review.opendev.org/638453 | 15:39 |
arne_wiebalck | TheJulia: etingof: The spec looks good to me, I left a +2as well now. | 15:44 |
arne_wiebalck | TheJulia: etingof : I've talked to my DC colleagues when I saw this spec being proposed some weeks ago. We currently do not rely on LEDs to identify components, mostly b/c all equipment has barcodes/stickers but also since the LEDs were found to not always work very well ... as we're moving more towards ironic the accessibility of indicators through this new feature may change this , though :) | 15:45 |
arne_wiebalck | TheJulia: For https://review.opendev.org/#/c/660145/, do you want to add software RAID? Given that the patches are already up for review, this wouldn't add too much actual work. Equally, we could also add configuring software RAID via deploy templates as a goal. | 15:50 |
patchbot | patch 660145 - ironic-specs - Add train priorities - 1 patch set | 15:50 |
*** Lucas_Gray has quit IRC | 15:51 | |
TheJulia | arne_wiebalck: That is interesting and it would be good to hear. I feel like this feature is more useful for smaller deployments and or edge-esq deployments where the on-hands staff might no not be intimately familiar with the hardware or the inventory processes surrounding larger sites. | 15:51 |
TheJulia | arne_wiebalck: I feel like software raid is kind of an already agreed upon thing, but I'm okay with adding it. It is a major feature that will benefit many, so I'm super happy to add it | 15:52 |
arne_wiebalck | TheJulia: When I was running a different service some years ago (but also here), we were relying on LEDs ... quite useful when you're under stress ;) | 15:53 |
*** e0ne has quit IRC | 15:55 | |
arne_wiebalck | TheJulia: I'm not insisting :) I was just thinking if that list is pulled out to look at what we plan to add this cycle (or what we added in the end), I think it'd be nice to have it there. | 15:56 |
TheJulia | yeah, LEDs/indicators are super useful when your not 1000% sure about the inventory | 16:08 |
dtantsur | anyone has a Windows machine with Python? | 16:10 |
dtantsur | I need to try a simple (non-destructive) command | 16:10 |
dtantsur | nevermind, JayF saved me (or doomed me?) | 16:12 |
jroll | he does go by jayofdoom | 16:13 |
JayF | doooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooom | 16:14 |
JayF | Hilariously enough, TheJulia is the only person I still know who was around when that inside joke started :) | 16:14 |
JayF | something about pink teddy bears and me giving it a funny voice ;) | 16:14 |
jroll | heh | 16:14 |
*** gyee has joined #openstack-ironic | 16:15 | |
dtantsur | :D | 16:15 |
JayF | dtantsur: anytime you need something like that feel free to drop me a ping; I don't always have IRC up but when I do I'm happy to help | 16:15 |
TheJulia | JayF, that was an epic evening hanging out with friends :) | 16:16 |
dtantsur | thanks a lot! | 16:16 |
* TheJulia wonders if pixie boots should bring doooooooomm.... to other provisioning systems | 16:16 | |
dtantsur | totally ignorant question: does MS distribute any sort of free Windows to mess around? as long as I can put it in a VM and install Python there? | 16:17 |
JayF | dtantsur: very yes! | 16:17 |
JayF | https://developer.microsoft.com/en-us/microsoft-edge/tools/vms/ | 16:17 |
TheJulia | dtantsur: yes, 90 day IE images are available at the link JayF just pasted | 16:17 |
dtantsur | w000000t | 16:17 |
dtantsur | I expected "no, are you crazy", you saved me again :) | 16:17 |
TheJulia | No, your sane. Sorry! | 16:18 |
JayF | FWIW, generally these days you can also just install Windows 10 without any key | 16:18 |
JayF | and it'll limit a few things -- particularly customization -- but will never actually expire, just complain at you | 16:18 |
jroll | the absence of evidence of insanity does not prove sanity | 16:18 |
TheJulia | Yeah, the install media is avaialble for downlaod as well | 16:18 |
jroll | :P | 16:18 |
dtantsur | no KVM version, okay, this is fixable | 16:19 |
TheJulia | I think I used the windows 10 download media last time I needed a machine | 16:20 |
dtantsur | wow, it doesn't even require registration to download. microsoft has changed quite a lot.. | 16:22 |
TheJulia | Indeed | 16:22 |
*** mgoddard has quit IRC | 16:25 | |
*** SpiritHorse has joined #openstack-ironic | 16:26 | |
*** mgoddard has joined #openstack-ironic | 16:28 | |
openstackgerrit | Julia Kreger proposed openstack/ironic-specs master: Add train priorities https://review.opendev.org/660145 | 16:30 |
*** mbeierl has joined #openstack-ironic | 16:32 | |
* etingof has a virtual media concern... | 16:35 | |
etingof | given that 1+ systems can *concurrently* boot from the same CD drive, should ironic care not to eject that shared CD abruptly...? | 16:36 |
dtantsur | can we practically get into situation where >1 system are using the same CD? | 16:39 |
dtantsur | or do you mean one manager managing several systems? | 16:40 |
dtantsur | I think we shouldn't care, we should just document that we cannot support this case because of limitations of the standard | 16:41 |
dtantsur | etingof: ^^ | 16:41 |
*** mgoddard has quit IRC | 16:42 | |
etingof | right, a single manager can have one virtual CD *and* herd 1+ systems | 16:42 |
jroll | don't we hardlink the ISO per-node, so we never eject a disk from multiple machines? | 16:42 |
jroll | oh, redfish | 16:42 |
jroll | ignore me, I know nothing | 16:42 |
etingof | ironic is currently not aware of the above arrangement so it should happily boot as many systems as it can concurrently | 16:43 |
*** S4ren has quit IRC | 16:43 | |
etingof | all from the same CD, which is kind of cool | 16:43 |
etingof | but ironic can also decide to replace media in that CD if one of the nodes being deployed requires some one ISO | 16:44 |
*** mgoddard has joined #openstack-ironic | 16:44 | |
etingof | s/one/other | 16:44 |
dtantsur | etingof: except that we'll have to detect this kind of situation and refuse to operate if there is a conflict | 16:44 |
etingof | so that means that ironic needs to be aware of shared CD somehow | 16:45 |
dtantsur | in any case, I'd think about this after delivering the first version | 16:45 |
dtantsur | we're not even sure if the systems that have N+M manager-system mapping AND virtual media support exist in practice :) | 16:45 |
dtantsur | (and if they do, whether they're standard compliant) | 16:46 |
etingof | yeah.. it's funny to observe ironic booting from CD (first node) and ejecting that CD to boot the second node... | 16:46 |
arne_wiebalck | bye everyone o/ | 16:46 |
dtantsur | etingof: right, we won't probably work correctly with such systems. and I'm not sure if we can at all. | 16:47 |
dtantsur | so I'd ignore the N+M aspect for now | 16:47 |
*** tssurya has quit IRC | 16:47 | |
etingof | right | 16:47 |
*** lucasagomes has quit IRC | 16:48 | |
*** dtantsur is now known as dtantsur|afk | 16:48 | |
dtantsur|afk | o/ | 16:48 |
etingof | I think shared CD could be helpful in mass deployment | 16:48 |
*** whoami-rajat has quit IRC | 16:49 | |
*** itlinux has joined #openstack-ironic | 16:58 | |
*** mbeierl has quit IRC | 17:00 | |
openstackgerrit | Julia Kreger proposed openstack/ironic-specs master: Add a whimsical comment to help thoughts of scale https://review.opendev.org/660457 | 17:04 |
*** mbeierl has joined #openstack-ironic | 17:04 | |
TheJulia | Looking at https://review.opendev.org/#/c/655685, I'm going to approve it. It looks like etingof will need to revise it anyway in follow-up given the commands. | 17:08 |
patchbot | patch 655685 - ironic-specs - Add spec for indicator management - 7 patch sets | 17:08 |
* etingof is \o/ | 17:08 | |
TheJulia | I'm onboard witht he vmedia ignoring n+m aspect now, just documenting our context and what we know it will do. | 17:09 |
*** whoami-rajat has joined #openstack-ironic | 17:15 | |
*** itlinux has quit IRC | 17:22 | |
* TheJulia attaches blinking discotek lights to https://review.opendev.org/#/c/660145/ amd leaves it for reviews | 17:24 | |
patchbot | patch 660145 - ironic-specs - Add train priorities - 2 patch sets | 17:24 |
openstackgerrit | Merged openstack/ironic-specs master: Add spec for indicator management https://review.opendev.org/655685 | 17:34 |
*** priteau has quit IRC | 17:42 | |
*** itlinux has joined #openstack-ironic | 17:44 | |
openstackgerrit | Julia Kreger proposed openstack/ironic master: Fix binary file upload to Swift https://review.opendev.org/659061 | 17:47 |
*** mbeierl has quit IRC | 18:03 | |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic master: Allocation API: backfilling allocations https://review.opendev.org/648178 | 18:09 |
openstackgerrit | Merged openstack/ironic-tempest-plugin master: Compatible with old Swift service enable https://review.opendev.org/660336 | 18:16 |
openstackgerrit | Merged openstack/ironic stable/stein: Do not try to return mock as JSON in unit tests https://review.opendev.org/660133 | 18:16 |
openstackgerrit | Merged openstack/ironic stable/rocky: Do not try to return mock as JSON in unit tests https://review.opendev.org/660134 | 18:16 |
openstackgerrit | Merged openstack/ironic stable/queens: Do not try to return mock as JSON in unit tests https://review.opendev.org/660135 | 18:16 |
*** hwoarang has quit IRC | 18:27 | |
*** hwoarang has joined #openstack-ironic | 18:28 | |
*** mbeierl has joined #openstack-ironic | 18:30 | |
TheJulia | lots... and lots... of code reviews to do | 18:34 |
*** itlinux has quit IRC | 18:40 | |
*** goldyfruit has quit IRC | 18:50 | |
mbeierl | Hey, folks. I wanted to finalize a change to https://review.opendev.org/#/c/633833/, but I have changed email addresses from @dell.com to @vmware.com and it's not letting me update the review. Do I abandon and start a new one, or what is the best approach? | 18:50 |
patchbot | patch 633833 - ironic - Fix potential race condition on node power on and ... - 4 patch sets | 18:50 |
jroll | mbeierl: what's the error? anyone should be able to push a change to an open review | 18:59 |
mbeierl | jroll: In commit cf12aff77b0cf3536c4b91443da8ad9d2d2e6b0f remote: ERROR: committer email address mark.beierl@dell.com does not match your user account. | 19:00 |
jroll | aha | 19:01 |
mbeierl | I had already updated my gerrit info to change my email address to mbeierl@vmware.com, and don't have mark.beierl@dell.com anymore :( | 19:01 |
jroll | sounds like you haven't changed your email in git config. `git config set user.email you@newemail.com` | 19:01 |
jroll | and then you'll have to amend the commit | 19:01 |
jroll | and then try to `git review` again | 19:01 |
jroll | er wait, that git command is wrong | 19:02 |
mbeierl | I had opened the review as mark.beierl@dell.com, but now my identity is mbeierl@vmware.com, so the new ID does not match the one that I opened the review with | 19:02 |
jroll | git config --global user.email mbeierl@vmware.com | 19:02 |
jroll | git commit --amend | 19:02 |
jroll | git review | 19:02 |
jroll | it's complaining because git has your dell.com email on the commit, which the git config command will change, and the git commit command will replace it on that commit | 19:03 |
openstackgerrit | Mark Beierl proposed openstack/ironic master: Fix potential race condition on node power on and reboot https://review.opendev.org/633833 | 19:03 |
mbeierl | jroll: wow. It was git commit --amend --reset-author | 19:03 |
mbeierl | you pointed me to the right place, just missing one thing I guess | 19:04 |
mbeierl | either way, it's up now | 19:04 |
mbeierl | so, thanks! | 19:04 |
openstackgerrit | Julia Kreger proposed openstack/ironic-specs master: Add a whimsical comment to help thoughts of scale https://review.opendev.org/660457 | 19:04 |
jroll | mbeierl: you're welcome, I was close! :) | 19:05 |
mbeierl | jroll: ya, I figured it was something like, that, but just needed the second set of eyes! | 19:05 |
*** gyee has quit IRC | 19:07 | |
*** gyee has joined #openstack-ironic | 19:19 | |
openstackgerrit | Merged openstack/sushy master: Add public resource loading and message parsing https://review.opendev.org/590747 | 19:24 |
*** whoami-rajat has quit IRC | 19:29 | |
openstackgerrit | Merged openstack/ironic-python-agent stable/stein: Do not use metadata checksums with ext4 https://review.opendev.org/658770 | 19:37 |
openstackgerrit | Merged openstack/ironic-python-agent stable/stein: Add more channel number for detecting BMC IP address https://review.opendev.org/657721 | 19:38 |
*** goldyfruit has joined #openstack-ironic | 19:45 | |
*** Goneri has quit IRC | 19:48 | |
*** logan- has quit IRC | 19:55 | |
*** mbeierl has quit IRC | 19:59 | |
*** Goneri has joined #openstack-ironic | 20:02 | |
*** dsneddon has quit IRC | 20:04 | |
*** mbeierl has joined #openstack-ironic | 20:10 | |
openstackgerrit | Mark Beierl proposed openstack/ironic master: Fix potential race condition on node power on and reboot https://review.opendev.org/633833 | 20:15 |
*** e0ne has joined #openstack-ironic | 20:39 | |
*** hamzy has quit IRC | 20:45 | |
*** e0ne has quit IRC | 20:56 | |
openstackgerrit | Christopher Dearborn proposed openstack/ironic master: Remove commit_required in iDRAC hardware type https://review.opendev.org/659880 | 20:59 |
*** trandles has joined #openstack-ironic | 21:11 | |
*** logan- has joined #openstack-ironic | 21:13 | |
*** mbeierl has quit IRC | 21:21 | |
*** Lucas_Gray has joined #openstack-ironic | 21:28 | |
*** bfournie has quit IRC | 21:30 | |
*** mbeierl has joined #openstack-ironic | 21:42 | |
*** mbeierl has quit IRC | 21:46 | |
*** Lucas_Gray has quit IRC | 21:47 | |
openstackgerrit | Merged openstack/ironic-python-agent stable/queens: Bind mount /run into chroot when installing grub https://review.opendev.org/655872 | 21:48 |
openstackgerrit | Merged openstack/ironic-python-agent stable/queens: Ironic python agent does not extract correct available memory https://review.opendev.org/653032 | 21:48 |
openstackgerrit | Merged openstack/ironic-python-agent stable/queens: Fix download upper constraints https://review.opendev.org/655656 | 21:48 |
TheJulia | All the things merge! | 21:49 |
*** Lucas_Gray has joined #openstack-ironic | 21:52 | |
*** rcernin has joined #openstack-ironic | 22:05 | |
*** tesseract has quit IRC | 22:07 | |
*** mbeierl has joined #openstack-ironic | 22:10 | |
*** bfournie has joined #openstack-ironic | 22:10 | |
*** mbeierl has quit IRC | 22:14 | |
*** itlinux has joined #openstack-ironic | 22:26 | |
*** mbeierl has joined #openstack-ironic | 22:28 | |
*** mbeierl has quit IRC | 22:32 | |
*** rcernin has quit IRC | 22:40 | |
*** goldyfruit has quit IRC | 22:41 | |
*** rcernin has joined #openstack-ironic | 22:41 | |
*** itlinux has quit IRC | 22:43 | |
*** mbeierl has joined #openstack-ironic | 22:46 | |
openstackgerrit | Merged openstack/ironic-python-agent stable/pike: Fix download upper constraints https://review.opendev.org/655657 | 22:50 |
*** mbeierl has quit IRC | 22:50 | |
*** goldyfruit has joined #openstack-ironic | 22:54 | |
openstackgerrit | Merged openstack/ironic-python-agent stable/pike: Bind mount /run into chroot when installing grub https://review.opendev.org/655873 | 22:54 |
*** mbeierl has joined #openstack-ironic | 22:55 | |
*** mbeierl has quit IRC | 23:00 | |
*** mbeierl has joined #openstack-ironic | 23:14 | |
*** mbeierl has quit IRC | 23:18 | |
*** Lucas_Gray has quit IRC | 23:20 | |
openstackgerrit | Merged openstack/ironic master: Move devstack emulators configs under /etc/ironic https://review.opendev.org/651212 | 23:25 |
*** mbeierl has joined #openstack-ironic | 23:32 | |
*** mbeierl has quit IRC | 23:36 | |
*** itlinux has joined #openstack-ironic | 23:45 | |
openstackgerrit | Merged openstack/ironic stable/rocky: Ansible module fix: stream_url https://review.opendev.org/652626 | 23:46 |
*** itlinux_ has joined #openstack-ironic | 23:47 | |
*** itlinux has quit IRC | 23:49 | |
*** Goneri has quit IRC | 23:52 | |
rpioso | TheJulia: Please review https://review.opendev.org/#/c/660534 | 23:54 |
patchbot | patch 660534 - x/driverlog - Add openstack/ironic ipmi and redfish drivers - 2 patch sets | 23:54 |
rpioso | It adds the ipmi and redfish h/w types to the OpenStack Marketplace. | 23:54 |
*** itlinux_ has quit IRC | 23:57 | |
*** mbeierl has joined #openstack-ironic | 23:59 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!