Thursday, 2019-03-21

*** gyee has quit IRC00:48
*** dsneddon has quit IRC01:07
*** mbeierl has quit IRC01:31
*** dsneddon has joined #openstack-ironic01:34
*** dsneddon has quit IRC01:39
*** dsneddon has joined #openstack-ironic02:09
*** dsneddon has quit IRC02:14
*** dsneddon has joined #openstack-ironic02:34
*** dsneddon has quit IRC02:40
*** dsneddon has joined #openstack-ironic02:52
*** dsneddon has quit IRC02:59
openstackgerritTony Breeds proposed openstack/ironic-lib stable/stein: Update UPPER_CONSTRAINTS_FILE for stable/stein  https://review.openstack.org/64504703:08
openstackgerritTony Breeds proposed openstack/ironic-lib stable/stein: Update UPPER_CONSTRAINTS_FILE for stable/stein  https://review.openstack.org/64010703:10
*** rh-jelabarre has quit IRC03:21
*** MattMan_ has quit IRC03:26
*** dsneddon has joined #openstack-ironic03:26
*** MattMan_ has joined #openstack-ironic03:26
openstackgerritTony Breeds proposed openstack/sushy stable/stein: Update UPPER_CONSTRAINTS_FILE for stable/stein  https://review.openstack.org/64014603:30
openstackgerritTony Breeds proposed openstack/metalsmith stable/stein: Update UPPER_CONSTRAINTS_FILE for stable/stein  https://review.openstack.org/64010603:32
*** dsneddon has quit IRC03:41
*** Lucas_Gray has joined #openstack-ironic03:54
*** andrein has joined #openstack-ironic03:59
*** dsneddon has joined #openstack-ironic04:07
*** whoami-rajat has joined #openstack-ironic04:10
*** dsneddon has quit IRC04:12
*** betherly has joined #openstack-ironic04:19
*** betherly has quit IRC04:24
*** dsneddon has joined #openstack-ironic04:35
tonybhttps://review.openstack.org/645047 was a tooling failure and I have already abandoned it04:38
patchbotpatch 645047 - ironic-lib (stable/stein) - Update UPPER_CONSTRAINTS_FILE for stable/stein (ABANDONED) - 1 patch set04:38
*** dsneddon has quit IRC04:40
*** yajushiSri has joined #openstack-ironic04:46
*** dsneddon has joined #openstack-ironic05:09
*** dsneddon has quit IRC05:15
*** dsneddon has joined #openstack-ironic05:29
*** dsneddon has quit IRC05:34
*** dsneddon has joined #openstack-ironic06:01
*** dsneddon has quit IRC06:06
*** e0ne has joined #openstack-ironic06:06
*** e0ne has quit IRC06:07
*** pcaruana has joined #openstack-ironic06:11
*** yajushiSri has quit IRC06:17
*** dsneddon has joined #openstack-ironic06:20
*** dsneddon has quit IRC06:25
*** Lucas_Gray has quit IRC06:48
*** dsneddon has joined #openstack-ironic06:57
*** dsneddon has quit IRC07:06
*** rcernin has quit IRC07:24
*** hjensas has quit IRC07:25
*** dsneddon has joined #openstack-ironic07:34
arne_wiebalckgood morning, ironic!07:39
*** e0ne has joined #openstack-ironic07:45
*** dsneddon has quit IRC07:49
arne_wiebalckFor custom hardware managers, it seems that for additional cleaning steps the only choice for 'interface' is 'deploy' ... is that true?07:54
*** hjensas has joined #openstack-ironic08:03
*** tssurya has quit IRC08:12
*** dsneddon has joined #openstack-ironic08:15
*** openstackgerrit has quit IRC08:17
rpittaugood morning ironic! o/08:19
*** dsneddon has quit IRC08:20
*** dtantsur|afk is now known as dtantsur08:24
dtantsurmorning ironic08:24
dtantsurarne_wiebalck: I'm not sure, to be honest. Probably.08:24
*** tssurya has joined #openstack-ironic08:24
*** yajushiSri has joined #openstack-ironic08:26
*** jtomasek has quit IRC08:32
etingofiurygregory, hey, if you prayed to Zuul today, you might consider trying out my patch o/ -- https://review.openstack.org/#/c/644822/08:32
patchbotpatch 644822 - ironic - Add systemd unit for sushy emulator in devstack - 3 patch sets08:32
*** gkadam has joined #openstack-ironic08:33
etingof(it's actually three patches in chain)08:33
*** gkadam has quit IRC08:33
*** sburette has joined #openstack-ironic08:35
* dtantsur <3 these patches08:35
dtantsurrpittau or arne_wiebalck, a trivial patch: https://review.openstack.org/64245708:42
patchbotpatch 642457 - ironic - Add a non-voting metalsmith job for local boot cov... - 1 patch set08:42
rpittaudtantsur, when you have a minute, it's all green and hopefully working as intended xD https://review.openstack.org/64454008:44
patchbotpatch 644540 - ironic - Workaround for postgres job with ubuntu bionic - 9 patch sets08:44
dtantsurLGTM (even though I don't understand it well)08:44
rpittauI would love to have hjensas opinion on that :)08:46
iurygregoryetingof, \o/08:47
iurygregorygood morning everyone08:47
rpittauhey iurygregory :)08:47
*** e0ne has quit IRC08:48
*** e0ne has joined #openstack-ironic08:51
arne_wiebalckdtantsur: Concerning the interface on h/w managers, our docs are not very clear on this.  There is a comment here: https://docs.openstack.org/ironic-python-agent/latest/contributor/hardware_managers.html that sounds like it needs to be 'deploy'.08:51
arne_wiebalckdtantsur: And from experimenting, it seems that if I use sth else, it is not taken into account.08:52
dtantsuryeah, it seems so from https://github.com/openstack/ironic-python-agent/blob/master/ironic_python_agent/hardware.py#L501-L52108:52
dtantsurI wonder how proliantutils deal with it08:52
dtantsurarne_wiebalck: hmmm https://github.com/openstack/proliantutils/blob/master/proliantutils/ipa_hw_manager/hardware_manager.py#L39-L5008:53
arne_wiebalckdtantsur: I was thinking that the lines you quoted actually miss the comment for the interface.08:53
dtantsurit seems that proliantutils use interface: raid, so it should work?08:53
arne_wiebalckyou have a pointer a hand?08:54
dtantsurarne_wiebalck: see above. I'm not sure how exactly it works though.08:54
arne_wiebalckdtantsur: ups, sorry, missed that08:54
dtantsurprobably via AgentRAID08:54
arne_wiebalckBackground is: I try to get the post create_config hook to work, so that the raid_config is updated in a node.08:55
*** dougsz has joined #openstack-ironic08:55
*** dsneddon has joined #openstack-ironic08:55
arne_wiebalckIt looks like this should work more or less automatically, but only when the interface is 'raid'. So far, I used 'deploy'.08:55
arne_wiebalckOK, I'll have a look.08:56
arne_wiebalckThanks!08:56
dtantsurnp08:56
arne_wiebalckAh, yes. This works.08:57
arne_wiebalckBut this is with pririty 0.08:57
arne_wiebalckpriority 0, so this is manual cleaning  only08:57
dtantsurright, because hardware RAID is usually done with manual cleaning08:57
arne_wiebalckI'm trying to make this part of automated cleaning.08:57
arne_wiebalckAnyway, I'll have a look.08:57
rpittaudtantsur, about that non voting metalsmith job, do you think would be worth to run it with Python 3 ?08:59
dtantsurrpittau: not much difference. metalsmith itself has python 3 jobs, just not this one.09:00
dtantsurmaybe we could duplicate it, dunno09:00
*** dsneddon has quit IRC09:00
dtantsurmy biggest point here is to cover partition images + local boot09:00
rpittauyeah, I saw the comments09:00
dtantsurnote that any changes to this job will have to happen after stable/stein created in ironic, since metalsmith already has stable/stein09:02
dtantsur(or we'll have to backport them)09:02
rpittauwell I guess we can wait, it was a thought dictated by the "Python 3 fever"09:05
*** whoami-rajat has quit IRC09:10
*** S4ren has joined #openstack-ironic09:17
*** whoami-rajat has joined #openstack-ironic09:18
*** Chaserjim has quit IRC09:22
dtantsur:D09:28
*** dsneddon has joined #openstack-ironic09:28
dtantsuretingof: hi, do you know what happened to https://review.openstack.org/#/c/636894/ ?\09:32
patchbotpatch 636894 - virtualbmc - Ignore "start" command if instance appears to be r... - 1 patch set09:32
*** dteselkin has quit IRC09:32
etingofmay be I need to rebase, let me see09:32
*** dteselkin has joined #openstack-ironic09:33
*** dsneddon has quit IRC09:33
*** priteau has joined #openstack-ironic09:37
*** Lucas_Gray has joined #openstack-ironic09:40
*** derekh has joined #openstack-ironic09:43
*** pcaruana has quit IRC09:45
*** pcaruana has joined #openstack-ironic09:46
etingoflooks like libvirt wrapper fails to build on bionic09:47
*** dsneddon has joined #openstack-ironic09:57
*** dsneddon has quit IRC10:02
dtantsurrpioso: https://review.openstack.org/#/c/637971/ is the dependency of the Python 3 patch you've just approved10:11
patchbotpatch 637971 - ironic - Add systemd unit for vbmcd in devstack - 10 patch sets10:11
dtantsurdamn, it was for rpittau10:11
dtantsursorry rpioso10:11
*** e0ne has quit IRC10:14
rpittaudtantsur, thanks, I thought I checked that already :/10:15
dtantsurthere are 3 patches there :)10:15
rpittaudtantsur, yeah, I commented on the last one, approved the middle one, and  opened the first one and forgot about it :/10:15
rpittauweird order....10:15
dtantsurheh10:16
etingofopenstackgerrit went south10:16
dtantsuryeah10:17
dtantsuriurygregory: ironicclient stein seems to suffer from a familiar failure: http://logs.openstack.org/52/644152/1/check/ironicclient-dsvm-functional/c4aa16b/job-output.txt.gz#_2019-03-20_14_18_29_56943810:17
dtantsuranything we have to backport there?10:17
iurygregorydtantsur, looking10:17
*** e0ne has joined #openstack-ironic10:17
dtantsurrpittau: another pre-release review request please: https://review.openstack.org/#/c/642534/10:19
patchbotpatch 642534 - sushy-tools - Fix broken Systems listing in dynamic emulator - 1 patch set10:19
iurygregorydtantsur, the fix is only in master10:20
iurygregoryhttps://github.com/openstack/python-ironicclient/blob/stable/stein/ironicclient/tests/functional/osc/v1/test_baremetal_allocation.py#L143 in stein we still have this exception10:21
dtantsurah! so we need a backport?10:21
iurygregorybut in the ironic side is Nodes cannot be found10:21
iurygregorydtantsur, the patche was https://review.openstack.org/#/c/642474/10:21
patchbotpatch 642474 - python-ironicclient - Run jobs under python2 and python3 (MERGED) - 11 patch sets10:21
dtantsuriurygregory: wanna try backporting it?10:22
iurygregorydtantsur, sure10:22
iurygregoryyay merge conflit from the UI \o/10:22
*** S4ren has quit IRC10:23
iurygregorydo you want me to backport only the file that change the tests ?10:23
dtantsuriurygregory: you probably need to backport the parent patch (with zuul v3)10:23
iurygregorylooking at the diff of commits here, so i would prob need to squash the commits right?10:24
dtantsuriurygregory: why?10:25
dtantsurhmmm10:26
dtantsuriurygregory: I guess we'll have to do it in 3 steps: first backport only the tests fix (to unblock the gate), then we can backport the zuul and python 3 stuff (because we need python 3 on stein).10:26
*** S4ren has joined #openstack-ironic10:26
iurygregorydtantsur, but the test fix is together with the change ta enable a job to run under python310:27
dtantsuriurygregory: right, we probably need to split it out and land it first10:27
dtantsurthen proceed with normal backporting10:27
iurygregorydtantsur, ok so i will backport only the test file10:28
iurygregorydoing now10:28
*** yajushiSri has left #openstack-ironic10:28
dtantsurthx10:29
*** dsneddon has joined #openstack-ironic10:35
*** dsneddon has quit IRC10:40
*** openstackgerrit has joined #openstack-ironic10:47
openstackgerritMerged openstack/metalsmith stable/stein: Update UPPER_CONSTRAINTS_FILE for stable/stein  https://review.openstack.org/64010610:47
*** e0ne has quit IRC10:58
*** e0ne has joined #openstack-ironic10:59
*** dsneddon has joined #openstack-ironic11:04
*** dsneddon has quit IRC11:10
dtantsursorry rpittau, one more thing: https://review.openstack.org/#/c/645095/111:12
patchbotpatch 645095 - virtualbmc - Bump lower libvirt-python to 3.7 - 1 patch set11:12
openstackgerritMerged openstack/sushy-tools master: Fix broken Systems listing in dynamic emulator  https://review.openstack.org/64253411:12
rpittaudtantsur, no worries, I saw that, I was waiting for CI to finish :)11:13
dtantsurcool :)11:13
dtantsurI hope to release virtualbmc and sushy-tools today11:14
dtantsur(well, and ironic, but this is waiting for TheJulia)11:14
rpittaufirst time I'm involved in a release process for ironic, or any openstack project :P11:16
*** priteau has quit IRC11:19
openstackgerritMerged openstack/sushy-tools master: Add memoization to expensive emulator calls  https://review.openstack.org/61275811:19
*** whoami-rajat has quit IRC11:30
*** whoami-rajat has joined #openstack-ironic11:34
*** bfournie has quit IRC11:38
*** dsneddon has joined #openstack-ironic11:46
openstackgerritIury Gregory Melo Ferreira proposed openstack/python-ironicclient stable/stein: Fix allocation tests  https://review.openstack.org/64514611:47
iurygregorydtantsur, done, sorry for the delay i went for lunch =)11:47
dtantsurTheJulia, mgoddard, you may love (or hate) this: https://review.openstack.org/#/c/645092/ and https://review.openstack.org/#/c/645093/ :)11:49
patchbotpatch 645092 - bifrost - Move RabbitMQ handling into a separate role and su... - 2 patch sets11:49
patchbotpatch 645093 - bifrost - Disable RabbitMQ by default - 2 patch sets11:49
mgoddarddtantsur: love it with fire11:51
dtantsurhehe11:51
*** dsneddon has quit IRC11:51
rpittaupoor rabbits11:51
*** rh-jelabarre has joined #openstack-ironic11:51
iurygregorypoor rabbits +111:52
dtantsur:D11:52
iurygregorybut since they are virtual im fine lol11:52
dtantsurI wonder if we need a job with rabbitmq still enabled11:53
rpittaudtantsur, I'm pretty sure we need it, and not just because I like rabbits :D11:54
dtantsurokay, I can look into it some time later11:54
openstackgerritRiccardo Pittau proposed openstack/ironic master: Fix capabilities passed as string in agent prepare  https://review.openstack.org/64515111:55
iurygregoryi think is a good a idea to have, if we have feedback from operators saying they dont use in production we are good XD11:56
dtantsurit still uses zuul v2, send help :(11:59
rpittaulol12:00
iurygregorydtantsur, bifrost?12:00
dtantsuriurygregory: yeah12:02
iurygregory=O12:02
iurygregoryi will take a look in my free time XD12:02
dtantsurawesome12:03
dtantsurit may be straightforward to move it, since it doesn't use devstack or tempest12:03
iurygregoryyeah12:03
dtantsurbut now we have a lot of bash calling bash inside ansible, this should be cleaned up12:03
openstackgerritMerged openstack/virtualbmc master: Bump lower libvirt-python to 3.7  https://review.openstack.org/64509512:04
iurygregorygotcha12:04
*** dsneddon has joined #openstack-ironic12:06
openstackgerritMerged openstack/virtualbmc master: Ignore "start" command if instance appears to be running  https://review.openstack.org/63689412:08
*** bfournie has joined #openstack-ironic12:11
*** dsneddon has quit IRC12:12
*** jtomasek has joined #openstack-ironic12:12
*** dsneddon has joined #openstack-ironic12:22
openstackgerritDmitry Tantsur proposed openstack/python-ironicclient stable/stein: Update UPPER_CONSTRAINTS_FILE for stable/stein  https://review.openstack.org/64415212:27
*** dsneddon has quit IRC12:27
*** dsneddon has joined #openstack-ironic12:28
*** trown|outtypewww is now known as trown12:32
*** dsneddon has quit IRC12:32
*** rh-jelabarre has quit IRC12:34
*** Wryhder has joined #openstack-ironic12:35
*** Lucas_Gray has quit IRC12:36
*** Wryhder is now known as Lucas_Gray12:36
*** yolanda has joined #openstack-ironic12:46
openstackgerritDmitry Tantsur proposed openstack/python-ironicclient stable/stein: Update .gitreview for stable/stein  https://review.openstack.org/64415112:47
*** e0ne has quit IRC12:51
*** dtantsur is now known as dtantsur|brb12:52
*** dsneddon has joined #openstack-ironic12:59
iurygregoryyay the cherry pick worked \o/13:02
openstackgerritMerged openstack/bifrost master: Add versions to release notes series  https://review.openstack.org/64508513:06
*** dsneddon has quit IRC13:06
*** irclogbot_3 has quit IRC13:07
*** irclogbot_3 has joined #openstack-ironic13:08
*** yaawang has quit IRC13:11
*** yaawang has joined #openstack-ironic13:12
*** sthussey has joined #openstack-ironic13:14
openstackgerritMerged openstack/ironic master: Workaround for postgres job with ubuntu bionic  https://review.openstack.org/64454013:19
*** altlogbot_3 has quit IRC13:23
TheJuliaI just love waking up with a migraine13:23
*** e0ne has joined #openstack-ironic13:23
*** altlogbot_1 has joined #openstack-ironic13:24
TheJuliadtantsur|brb: comment on 64459013:28
openstackgerritIlya Etingof proposed openstack/sushy-tools master: Ensure non-empty libvirt <loader/> tag  https://review.openstack.org/64272813:29
openstackgerritIlya Etingof proposed openstack/sushy-tools master: Create libvirt boot loader element if needed  https://review.openstack.org/64258113:30
*** e0ne has quit IRC13:37
*** dsneddon has joined #openstack-ironic13:38
hjensasrpittau: hey, the conntrack helper hack is fine with me. :)13:39
*** altlogbot_1 has quit IRC13:39
rpittauhjensas, thanks :)13:39
*** whoami-rajat has quit IRC13:40
*** altlogbot_3 has joined #openstack-ironic13:40
*** baha has joined #openstack-ironic13:41
*** dsneddon has quit IRC13:43
*** irclogbot_3 has quit IRC13:45
*** e0ne has joined #openstack-ironic13:45
*** jaypipes has quit IRC13:46
*** irclogbot_2 has joined #openstack-ironic13:46
*** rh-jelabarre has joined #openstack-ironic13:50
TheJulialooks like the workaround is in the gate13:52
*** jistr is now known as jistr|call13:52
*** hjensas has quit IRC13:52
rpittauI think it's merged already :)13:52
openstackgerritIlya Etingof proposed openstack/sushy-tools master: Add docs on UEFI boot libvirt-based emulation  https://review.openstack.org/64283013:53
TheJuliaIt could have13:59
TheJuliaI woke up with a migraine and the world is slightly fuzzy as a result14:00
*** jistr|call is now known as jistr14:00
* etingof finds the world fuzzy at all times14:02
*** mjturek has joined #openstack-ironic14:02
*** dsneddon has joined #openstack-ironic14:11
openstackgerritRiccardo Pittau proposed openstack/ironic master: Fix capabilities passed as string in agent prepare  https://review.openstack.org/64515114:13
openstackgerritIlya Etingof proposed openstack/sushy-tools master: Rename `drivers` to `systems`  https://review.openstack.org/63849214:13
openstackgerritMerged openstack/ironic master: Set boot_mode in node properties during Redfish introspection  https://review.openstack.org/64135714:14
openstackgerritMerged openstack/ironic master: Add a non-voting metalsmith job for local boot coverage  https://review.openstack.org/64245714:14
openstackgerritMerged openstack/ironic-python-agent master: Add versions to release notes series  https://review.openstack.org/64507614:14
openstackgerritMerged openstack/ironic-inspector master: Add versions to release notes series  https://review.openstack.org/64507714:14
openstackgerritMerged openstack/python-ironicclient stable/stein: Fix allocation tests  https://review.openstack.org/64514614:14
openstackgerritMerged openstack/python-ironicclient stable/stein: Update UPPER_CONSTRAINTS_FILE for stable/stein  https://review.openstack.org/64415214:14
*** dsneddon has quit IRC14:16
openstackgerritIlya Etingof proposed openstack/sushy-tools master: Rename `drivers` to `systems`  https://review.openstack.org/63849214:20
openstackgerritIlya Etingof proposed openstack/sushy-tools master: Add Managers resource support  https://review.openstack.org/63868214:23
*** whoami-rajat has joined #openstack-ironic14:23
*** sburette has quit IRC14:30
*** mjturek has quit IRC14:33
*** altlogbot_3 has quit IRC14:35
*** altlogbot_3 has joined #openstack-ironic14:36
openstackgerritMerged openstack/python-ironicclient stable/stein: Update .gitreview for stable/stein  https://review.openstack.org/64415114:36
*** dtantsur|brb is now known as dtantsur14:37
dtantsurmorning TheJulia. migraine-- :(14:37
*** irclogbot_2 has quit IRC14:38
*** irclogbot_0 has joined #openstack-ironic14:39
*** mjturek has joined #openstack-ironic14:39
*** hjensas has joined #openstack-ironic14:44
*** dsneddon has joined #openstack-ironic14:47
*** dsneddon has quit IRC14:52
openstackgerritIlya Etingof proposed openstack/sushy-tools master: Add docs on UEFI boot libvirt-based emulation  https://review.openstack.org/64283014:55
*** dsneddon has joined #openstack-ironic15:00
*** hjensas has quit IRC15:07
*** baha has quit IRC15:18
w14161_1Hi, all, i create a redfish baremetal node, by validate, the result was "True", but after I run "openstack baremetal node manage", it said something like "node xxx was locked by xxx, retry 6 of 6". I could access the node by https way with redfish, I could see odata reply from chrome. But why ironic can not? Was it a proxy issue? My node has proxy setting, how to add proxy setting to redfish15:25
w14161_1interface of ironic? Or how to check whether the target node support redfish capability? Thx a lot!15:25
*** Lucas_Gray has quit IRC15:31
openstackgerritMerged openstack/ironic master: Add systemd unit for vbmcd in devstack  https://review.openstack.org/63797115:39
*** baha has joined #openstack-ironic15:44
dtantsurTheJulia: what are your plans re ironic release?15:48
*** hwoarang has quit IRC15:49
*** hwoarang has joined #openstack-ironic15:51
arne_wiebalckdtantsur:  clean steps in  custom h/w managers must indeed be for the deploy interface: https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/agent.py#L661-L66315:51
dtantsurarne_wiebalck: this is in AgentDeploy, but what about AgentRAID?15:52
* arne_wiebalck checking15:53
*** gyee has joined #openstack-ironic15:57
*** hjensas has joined #openstack-ironic15:58
* arne_wiebalck is not clear on how this work15:59
arne_wiebalckAgentRAID does not get cleaning steps, it implements {create/delete}_configuration() functions ... when are these actually called/triggered?16:03
arne_wiebalckThe way I have done this so far is by adding create/delete to 'deploy'. That ensures they are triggered during automatic cleaning.16:04
*** hwoarang has quit IRC16:05
*** hwoarang has joined #openstack-ironic16:06
arne_wiebalckAdding them with 'raid' makes them available for *manual* cleaning (and the post create hook is run and add the returned config to 'raid_config' in a node -- which is what'd like for RAID creation during cleaning as well).16:07
*** dsneddon has quit IRC16:08
* arne_wiebalck is trying to avoid to call node_update himself, but leverage existing code :)16:08
*** e0ne has quit IRC16:10
arne_wiebalckFrom what I see it's AgentDeploy doing the cleaning, so it's kind of natural that clean steps  use that interface.16:11
openstackgerritIlya Etingof proposed openstack/sushy-tools master: Add docs on UEFI boot libvirt-based emulation  https://review.openstack.org/64283016:14
*** mjturek has quit IRC16:16
*** dsneddon has joined #openstack-ironic16:17
arne_wiebalckdtantsur: Manual cleaning works differently as the steps are passed directly, so no "filtering" by interface.16:22
dtantsursigh16:22
arne_wiebalckdtantsur:  but probably I don't fully understand how that works16:23
*** dsneddon has quit IRC16:23
*** mjturek has joined #openstack-ironic16:24
*** hjensas has quit IRC16:24
dtantsurarne_wiebalck: get we do a similar thing for the RAID interface? filter "raid" steps?16:24
*** baha has quit IRC16:24
arne_wiebalckdtantsur: you mean 'could we' ?16:25
dtantsuryeah, sorry. typing random words..16:25
arne_wiebalckdtantsur: I'm not clear on how that would be triggered.16:25
dtantsurI don't clearly remember either16:25
dtantsurbut any interface can expose clean steps16:26
arne_wiebalckiyes16:26
arne_wiebalckand they are accessible to manual cleaning16:26
dtantsurso in theory we can copy AgentDeploy.get_clean_steps to AgentRAID, while s/deploy/raid/ in the filter16:26
arne_wiebalckI tried this and it works16:26
arne_wiebalckbut would that get them executed during automatic cleaning?16:27
dtantsurI think automated cleaning also collects steps from all interfaces16:28
dtantsurbut I don't quite get why it doesn't work automatically for your steps..16:28
dtantsurthey have non-zero priority, right?16:28
arne_wiebalckyes16:28
arne_wiebalckmy theory was that the  cleaning steps for *automatic* cleaning need to have 'deploy'16:29
arne_wiebalckthe docs kind of indicate this: https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/agent.py#L661-L66316:30
arne_wiebalckups16:30
arne_wiebalckhttps://docs.openstack.org/ironic-python-agent/latest/contributor/hardware_managers.html16:30
arne_wiebalcksection "Custom HardwareManagers and Cleaning"16:31
arne_wiebalckthe comment in the code box16:31
*** tssurya has quit IRC16:34
dtantsurarne_wiebalck: it should collect steps from all interfaces: https://github.com/openstack/ironic/blob/master/ironic/conductor/steps.py#L84-L11416:35
*** baha has joined #openstack-ironic16:35
arne_wiebalckdtantsur: interesting16:38
arne_wiebalckdtantsur: well, all steps are in the  nodes driver_info, that's true, but are they all considered when it comes to automatic cleaning?16:40
dtantsurarne_wiebalck: this is the function that fetches them16:40
dtantsurI don't know where else we would filter steps16:40
arne_wiebalckwhat about the get_clean_steps in the AgentDeploy (which looks for 'deploy' only): what is that for?16:42
dtantsurarne_wiebalck: I think it ends up being called here when we come to 'deploy': https://github.com/openstack/ironic/blob/master/ironic/conductor/steps.py#L10916:43
arne_wiebalckdtantsur: ok, so all cleaning steps defined in a custom h/w manager end up in the node's driver_internal_info and they are all available to manual cleaning; automatic cleaning seems to only consider  steps with 'deploy' interface16:50
dtantsurarne_wiebalck: right, I *think* it's because AgentRAID does not implement get_clean_steps16:53
arne_wiebalckdtantsur: it only uses create/delete confiuguration16:54
TheJuliaugh, finally just got off a call16:54
dtantsuryep, I think we need to copy get_clean_steps. at least that's the only guess I have16:54
* TheJulia would like to ban calls16:54
TheJuliadtantsur: lets cut the release16:54
rpittaugood night! o/16:54
*** rpittau is now known as rpittau|afk16:55
arne_wiebalckdtantsur: I'm still not clear on what triggers AgentRAID16:55
dtantsurTheJulia: I wonder if we need to wait for https://review.openstack.org/#/c/644622/16:55
patchbotpatch 644622 - ironic - Respect $USE_PYTHON3 settings for gunicorn - 3 patch sets16:55
dtantsuralthough we can backport it soon16:56
TheJuliadtantsur: It is devstack, it can be backported16:56
TheJulia++16:56
dtantsurokay, should I propose the release (and ditto for ironic-tempest-plugin)?16:57
TheJuliaplease16:57
dtantsurk16:57
TheJuliathanks!16:58
* TheJulia goes and gets more migrain meds16:58
*** dsneddon has joined #openstack-ironic17:00
arne_wiebalckdtantsur: I think I get now what you meant: if AgentRAID would do get_clean_steps, it the steps would actually be added to the list of overall steps for automatic cleaning ... correct? Each interface is basically in  charge of adding its steps.17:03
*** dsneddon has quit IRC17:05
dtantsurarne_wiebalck: that's what I expect. mgoddard may know this code much better17:07
* mgoddard exits low power mode17:08
mgoddarddtantsur: arne_wiebalck: I don't think it's quite like that17:10
arne_wiebalckmgoddard: lol17:10
dtantsuroops :)17:10
mgoddardcurrently AgentRAID has two clean steps, both configured with priority 017:10
arne_wiebalckmgoddard:  shed some light!17:10
arne_wiebalckmgoddard: yes17:10
openstackgerritIlya Etingof proposed openstack/sushy-tools master: Rename `drivers` to `systems`  https://review.openstack.org/63849217:11
mgoddarda non-zero priority would make them run automatically17:11
arne_wiebalckmgoddard: what happens if these are overwritten by clean steps in a custome h/w maanger?17:11
arne_wiebalckmgoddard: b/c this is what I tried17:11
arne_wiebalckmgoddard: with non-zero prio17:12
arne_wiebalckmgoddard: and they work fine with manual cleaning17:12
arne_wiebalckmgoddard: and if the interface is 'deploy'17:12
mgoddardarne_wiebalck: the AgentDeploy interface should collect steps from the agent17:12
*** trown is now known as trown|lunch17:12
mgoddardarne_wiebalck: unless you have some interface='raid' tag in the agent?17:13
arne_wiebalckmgoddard: right, but I think it filters only the ones with 'deploy' not all17:13
mgoddardarne_wiebalck: ok17:13
dtantsurmgoddard: well, it must have interface:raid..17:13
dtantsurwhich makes it also weird that we use AgentDeploy to collect non-deploy steps17:13
mgoddardarne_wiebalck: so you're saying we should add get_clean_steps(interface='raid') to AgentRAID?17:13
arne_wiebalckmgoddard: this was an idea dtantsur  had17:13
arne_wiebalckwhat I'd like to profit from is the post create_config hook, in fact17:14
arne_wiebalckthis is the actual goal17:14
mgoddardit sounds sensible, I retract my earlier statement :)17:14
arne_wiebalckwhich requires interface:raid17:14
mgoddardIPA docstring for get_clean_steps is missing 'interface'17:20
mgoddardIt sounds like you're on the right track here17:20
TheJuliamgoddard: I kind of noticed that before but didn't braincell to fix17:21
mgoddardare there other agent interfaces we should be adding get_clean_steps to?17:21
mgoddardarne_wiebalck: noticed that the AgentDeploy get_clean_steps doesn't include decorated controller-side steps, so you'll want to add a super(...).get_clean_steps()17:22
mgoddardTheJulia: let's see if I can muster enough cells17:22
TheJuliaI think I need like a meeting free day17:23
mgoddardTheJulia: just mark an entire week as 'busy' in your calendar17:24
TheJuliaI wish I could17:24
*** dsneddon has joined #openstack-ironic17:24
*** iurygregory has quit IRC17:25
dtantsurTheJulia: when I was at Skype, our team declared 2 fixed days a week meeting-free. worked pretty well.17:25
openstackgerritMark Goddard proposed openstack/ironic-python-agent master: Add 'interface' to get_clean_steps docstring  https://review.openstack.org/64526317:26
TheJuliaThe downside is we have limited time blocks, of course I'm totally willing to get up early17:26
arne_wiebalckmgoddard: FWIU, AgentDeploy actively limits itself to 'deploy' when getting the clean steps.17:27
mgoddardarne_wiebalck: that's correct17:28
arne_wiebalckmgoddard: Should it get all steps. i.e. from other interfaces as well, or should the other interfaces  have a get_clean_steps?17:29
mgoddardarne_wiebalck: but currently, if you added an @clean_step to that interface it would be ignored because get_clean_steps doesn't call the same method on the superclass17:29
mgoddardarne_wiebalck: it makes sense for it to only return steps for the correct interface17:29
mgoddardarne_wiebalck: you could pull out get_clean_steps into a mixin class to be used by all relevant agent interfaces17:30
arne_wiebalckmgoddard: so, other interfaces should also get/return their steps?17:30
*** dtantsur is now known as dtantsur|afk17:30
mgoddardarne_wiebalck: yes, IMO17:30
dtantsur|afksee you tomorrow17:30
arne_wiebalckdtantsur|afk: by, thanks!17:30
TheJuliao/ dtantsur|afk17:30
arne_wiebalckmgoddard: that was dtantsur's suggestion17:30
mgoddardarne_wiebalck: yes, I agree17:31
arne_wiebalckmgoddard: I can give that a try17:31
arne_wiebalckmgoddard: tmrw :)17:31
mgoddardarne_wiebalck: just took me a little time to pick up the context :)17:31
arne_wiebalckmgoddard: was all triggered by stendulker's suggestion to update the raid_config in the node17:32
arne_wiebalckmgoddard: and then I looked and found the post create hook ... and thought I was done ;)17:32
arne_wiebalckmgoddard: thanks for your help, I'll give that a try tmrw and see how far I get17:33
arne_wiebalckbye mgoddard TheJulia, everyone!17:34
mgoddardnight arne_wiebalck17:34
*** S4ren has quit IRC17:41
*** gmann is now known as gmann_afk17:43
openstackgerritIlya Etingof proposed openstack/sushy-tools master: Rename `drivers` to `systems`  https://review.openstack.org/63849217:59
*** derekh has quit IRC18:02
*** e0ne has joined #openstack-ironic18:05
*** e0ne has quit IRC18:12
*** trown|lunch is now known as trown18:22
*** whoami-rajat has quit IRC18:23
*** dougsz has quit IRC18:23
*** iurygregory has joined #openstack-ironic18:29
*** gmann_afk is now known as gmann18:40
*** sthussey has quit IRC19:23
*** whoami-rajat has joined #openstack-ironic19:25
*** hjensas has joined #openstack-ironic19:28
*** e0ne has joined #openstack-ironic19:30
*** e0ne has quit IRC19:49
*** e0ne has joined #openstack-ironic19:52
*** iurygregory has quit IRC20:01
openstackgerritOpenStack Release Bot proposed openstack/ironic stable/stein: Update .gitreview for stable/stein  https://review.openstack.org/64532220:01
openstackgerritOpenStack Release Bot proposed openstack/ironic stable/stein: Update UPPER_CONSTRAINTS_FILE for stable/stein  https://review.openstack.org/64532320:01
openstackgerritOpenStack Release Bot proposed openstack/ironic master: Update master for stable/stein  https://review.openstack.org/64532420:01
*** e0ne has quit IRC20:04
openstackgerritMerged openstack/ironic master: Respect $USE_PYTHON3 settings for gunicorn  https://review.openstack.org/64462220:04
*** e0ne has joined #openstack-ironic20:28
*** trown is now known as trown|outtypewww20:44
*** Lucas_Gray has joined #openstack-ironic20:53
*** jtomasek has quit IRC20:55
*** Lucas_Gray has quit IRC20:55
*** Lucas_Gray has joined #openstack-ironic20:55
*** Lucas_Gray has quit IRC20:57
*** Lucas_Gray has joined #openstack-ironic20:58
*** Lucas_Gray has quit IRC21:00
*** Lucas_Gray has joined #openstack-ironic21:01
*** Lucas_Gray has quit IRC21:02
*** Lucas_Gray has joined #openstack-ironic21:03
*** rh-jelabarre has quit IRC21:04
*** Lucas_Gray has quit IRC21:05
*** Lucas_Gray has joined #openstack-ironic21:05
*** mjturek has quit IRC21:06
*** Lucas_Gray has quit IRC21:06
*** Lucas_Gray has joined #openstack-ironic21:09
*** Lucas_Gray has quit IRC21:11
*** baha has quit IRC21:11
*** Lucas_Gray has joined #openstack-ironic21:12
*** iurygregory has joined #openstack-ironic21:12
iurygregorydtantsur|afk, TheJulia , rpittau|afk , we can have a job with Python3 enable for sushy yay! https://review.openstack.org/591828  Thanks to etingof and the ironic patches =)21:14
patchbotpatch 591828 - sushy - Change sushy devstack job to python3 - 4 patch sets21:14
iurygregoryto have in stable/stein we will need to backport the ironic changes21:15
*** e0ne has quit IRC21:17
*** Lucas_Gray has quit IRC21:17
*** iurygregory has quit IRC21:18
*** Lucas_Gray has joined #openstack-ironic21:23
*** Lucas_Gray has quit IRC21:24
*** S4ren has joined #openstack-ironic21:31
openstackgerritRichard G. Pioso proposed openstack/ironic master: Place upper bound on python-dracclient version  https://review.openstack.org/64536421:33
*** pcaruana has quit IRC21:33
*** S4ren has quit IRC21:33
*** whoami-rajat has quit IRC21:45
TheJuliarpioso: does ^^^ mean that breaking changes are anticipated with 3.0.0 and that we need to release ironic 12.1.1 as a result?21:57
TheJuliaIf yes, I think that is going to require a release note.21:58
TheJuliaAnd us to start on constraining master's maximum version and back Port that change21:59
* rpioso hopes TheJulia is feeling better21:59
TheJuliaOddly getting out of the house helped, even though it was just a run to the bank22:00
* rpioso imagines TheJulia won the lottery and deposited the jackpot, ridding her of the migraine22:02
rpiosoTheJulia: python-dracclient follows semver. At some point, a breaking change will be introduced to dracclient. When that occurs, the major version number will be bumped to 3, 3.0.0.22:02
rpiosoTheJulia: I don't believe such breaking changes should be associated with stable branches, such as stable/steins.22:03
rpiosoTheJulia: If an operator uses python-dracclient's present driver-requirements.txt entry, >= 1.5.0, they will install 3.0.0, breaking ironic.22:05
rpiosoTheJulia: It needs to be bounded to a version that is compatible with that stable branch.22:05
rpiosopysnmp's entry looks reasonable to me.22:05
*** irclogbot_0 has quit IRC22:05
rpiosoTheJulia: pysnmp>=4.3.0,<5.0.022:06
rpiosoTheJulia: There is a shorthand for that ~4.3.022:07
rpiosoTheJulia: See https://www.python.org/dev/peps/pep-0440/#compatible-release22:07
*** mgoddard has quit IRC22:08
rpiosoTheJulia: TL;DR Generally, I believe there have been issues for some time in driver-requirements.txt22:09
*** mgoddard has joined #openstack-ironic22:09
TheJuliarpioso: I somewhat agree, but vendors are also responsible for managing their drivers and while master is also generally expected to be deployable so if necessary and for the sake of CI should also have constraints for upper bounds as necessary in order to prevent breaking changes from hitting. For what its worth, a major change doesn't always break, it could just be breaking for a single API call forcing the22:13
TheJuliaversion change... and ironic may never actually use that call that was changed and broken22:13
gmannTheJulia: ironic-grenade-dsvm-multinode-multitenant job seems failing consistently now on bionic migration patch - https://review.openstack.org/#/c/642315/22:13
patchbotpatch 642315 - ironic - Migrate ironic-grenade-dsvm-multinode-multitenant ... - 2 patch sets22:13
gmannwhich was passing earlier.22:13
gmanndo you know any known issue ?22:13
gmanni have logged the bug with log details-  https://storyboard.openstack.org/#!/story/200528422:14
TheJuliagmann: I do not, someone will need to run it down I guess.22:14
gmannit was passing March 12 and then started failing after that22:15
gmannthat is blocking the Bionic migration patch for ironic22:15
TheJuliabottom line, its not a super high priority at the moment because it is a grenade job22:17
TheJuliainteresting, it is only failing on a general server creation test22:18
gmannyeah22:18
gmanni see these n-cpu log http://logs.openstack.org/15/642315/2/check/ironic-grenade-dsvm-multinode-multitenant/5c25adb/logs/screen-n-cpu.txt.gz#_Mar_21_20_50_23_65166422:18
*** rcernin has joined #openstack-ironic22:19
rpiosoTheJulia: I agree with your latter point that a new major revision doesn't always break ironic. That could be addressed by the entry in driver-requirements.txt if and when it occurs. I feel it's better to be conservative, especially on stable branches.22:20
TheJuliawoot, a single node is timing out22:20
TheJuliarpioso: except that patch needs a release note and will need to merge to the master branch first22:21
* TheJulia loads up all of the console logs22:21
TheJuliagmann: the subnode failed22:22
*** bfournie has quit IRC22:23
rpiosoTheJulia: It seems to me that master doesn't need an upper bound. Breaking changes typically must be deprecated, which gives clients such as ironic time to align themselves. That should be done before the breaking change is released.22:25
* rpioso reprimands the idrac h/w type for having misbehaved22:26
gmannTheJulia: i cannot find any error on ironic logs22:29
TheJuliagmann: it is the libvirt "firmware" loading up on the subnode, its random across nodes due to the has ring and placement, but you can kind of see what is going on curl --limit-rate 30B  http://logs.openstack.org/15/642315/2/check/ironic-grenade-dsvm-multinode-multitenant/1f7ea60/logs/subnode-2/old/ironic-bm-logs/subnode-2_console_2019-03-20-00:31:49.txt.gz22:30
TheJuliathey don't even try to network boot :(22:30
TheJuliarpioso: That implies that the driver operates by the same pattern as openstack in terms of  breaking changes22:31
TheJuliarpioso: I'm suddenly reminded of when we synced openstack/requirements22:31
rpiosoTheJulia: I expect the in-tree idrac h/w type should operate that way. Right?22:33
TheJuliarpioso: doesn't have to as long as the user experience remains un-impacted22:34
rpiosoTheJulia: I'm updating the idrac doc for that patch. A new patch set is coming.22:34
TheJuliak22:34
rpiosoTheJulia: I'll add a comment asking about the compatible release shorthand -- https://www.python.org/dev/peps/pep-0440/#compatible-release22:36
openstackgerritRichard G. Pioso proposed openstack/ironic master: Place upper bound on python-dracclient version  https://review.openstack.org/64536422:42
TheJuliagmann: I think we're going to hunt down a devstack change and backport it to stable/rocky to make that work22:49
gmannTheJulia: ok.22:52
gmannTheJulia: how you want to go on that, wait for backport things or proceed it with making it as n-v job ?22:53
gmannbecause keeping it on xenial can introduce more issue as everything is tested on bionic now22:54
rpiosoTheJulia: It turns out that shorthand doesn't apply.22:55
rpiosoTheJulia: Earlier, I mistakenly thought the version spec was going to be >=1.5.0,<2.0.0, for which it applies. However, the version spec is >=1.5.0,<3.0.0.22:56
* rpioso looks forward to TheJulia's review feedback22:57
*** rpioso is now known as rpioso|afk22:58
rpioso|afko/22:58
TheJuliagmann: backport once found, my brain is not in a state where I can hunt it down right now23:01
gmannTheJulia:  ok, no worry. I will wait on that. as ironic already have cut the rc1(stable/stein) we can backport this bionic patch before final rlease.23:03
TheJuliagmann: ironic has cut its stable release, we don't do rc's. And its just a devstack issue so no need to cut another release23:03
gmannTheJulia: i mean this. I do not think we need to cut the release for that as this is just CI things - https://review.openstack.org/#/c/642315/23:04
patchbotpatch 642315 - ironic - Migrate ironic-grenade-dsvm-multinode-multitenant ... - 2 patch sets23:04
gmannso that when devstack fix is backported then, ironic stable/stein can start tested on bionic23:05
TheJuliagmann: yup23:07
gmannperfect, thanks TheJulia23:08
TheJuliawe already are really, just those jobs had to be pinned to bionic23:08
TheJuliaerr xenial23:11
gmannTheJulia: they are xenial currently  till 64231523:13
TheJuliagmann: xenial for a single node23:14
TheJuliaerr23:14
TheJuliasingle test23:14
gmannhumm. not sure how to do for single tests, nodeset is job level var23:15
*** Lucas_Gray has joined #openstack-ironic23:15
TheJuliaerr23:15
TheJuliasingle job I mean, not all of ironic's jobs23:15
gmannohk23:15
*** Lucas_Gray has quit IRC23:20
gyeeTheJulia, is sushy and proliantutils fall under Ironic's jurisdiction? found a bug there23:32
TheJuliasushy does, proliantutils is hpe's library and is officially outside of our governance23:33
gyeek, let me file fix the sushy one first23:34
gyeeThanks for the info23:34

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!