*** gyee has quit IRC | 00:48 | |
*** dsneddon has quit IRC | 01:07 | |
*** mbeierl has quit IRC | 01:31 | |
*** dsneddon has joined #openstack-ironic | 01:34 | |
*** dsneddon has quit IRC | 01:39 | |
*** dsneddon has joined #openstack-ironic | 02:09 | |
*** dsneddon has quit IRC | 02:14 | |
*** dsneddon has joined #openstack-ironic | 02:34 | |
*** dsneddon has quit IRC | 02:40 | |
*** dsneddon has joined #openstack-ironic | 02:52 | |
*** dsneddon has quit IRC | 02:59 | |
openstackgerrit | Tony Breeds proposed openstack/ironic-lib stable/stein: Update UPPER_CONSTRAINTS_FILE for stable/stein https://review.openstack.org/645047 | 03:08 |
---|---|---|
openstackgerrit | Tony Breeds proposed openstack/ironic-lib stable/stein: Update UPPER_CONSTRAINTS_FILE for stable/stein https://review.openstack.org/640107 | 03:10 |
*** rh-jelabarre has quit IRC | 03:21 | |
*** MattMan_ has quit IRC | 03:26 | |
*** dsneddon has joined #openstack-ironic | 03:26 | |
*** MattMan_ has joined #openstack-ironic | 03:26 | |
openstackgerrit | Tony Breeds proposed openstack/sushy stable/stein: Update UPPER_CONSTRAINTS_FILE for stable/stein https://review.openstack.org/640146 | 03:30 |
openstackgerrit | Tony Breeds proposed openstack/metalsmith stable/stein: Update UPPER_CONSTRAINTS_FILE for stable/stein https://review.openstack.org/640106 | 03:32 |
*** dsneddon has quit IRC | 03:41 | |
*** Lucas_Gray has joined #openstack-ironic | 03:54 | |
*** andrein has joined #openstack-ironic | 03:59 | |
*** dsneddon has joined #openstack-ironic | 04:07 | |
*** whoami-rajat has joined #openstack-ironic | 04:10 | |
*** dsneddon has quit IRC | 04:12 | |
*** betherly has joined #openstack-ironic | 04:19 | |
*** betherly has quit IRC | 04:24 | |
*** dsneddon has joined #openstack-ironic | 04:35 | |
tonyb | https://review.openstack.org/645047 was a tooling failure and I have already abandoned it | 04:38 |
patchbot | patch 645047 - ironic-lib (stable/stein) - Update UPPER_CONSTRAINTS_FILE for stable/stein (ABANDONED) - 1 patch set | 04:38 |
*** dsneddon has quit IRC | 04:40 | |
*** yajushiSri has joined #openstack-ironic | 04:46 | |
*** dsneddon has joined #openstack-ironic | 05:09 | |
*** dsneddon has quit IRC | 05:15 | |
*** dsneddon has joined #openstack-ironic | 05:29 | |
*** dsneddon has quit IRC | 05:34 | |
*** dsneddon has joined #openstack-ironic | 06:01 | |
*** dsneddon has quit IRC | 06:06 | |
*** e0ne has joined #openstack-ironic | 06:06 | |
*** e0ne has quit IRC | 06:07 | |
*** pcaruana has joined #openstack-ironic | 06:11 | |
*** yajushiSri has quit IRC | 06:17 | |
*** dsneddon has joined #openstack-ironic | 06:20 | |
*** dsneddon has quit IRC | 06:25 | |
*** Lucas_Gray has quit IRC | 06:48 | |
*** dsneddon has joined #openstack-ironic | 06:57 | |
*** dsneddon has quit IRC | 07:06 | |
*** rcernin has quit IRC | 07:24 | |
*** hjensas has quit IRC | 07:25 | |
*** dsneddon has joined #openstack-ironic | 07:34 | |
arne_wiebalck | good morning, ironic! | 07:39 |
*** e0ne has joined #openstack-ironic | 07:45 | |
*** dsneddon has quit IRC | 07:49 | |
arne_wiebalck | For custom hardware managers, it seems that for additional cleaning steps the only choice for 'interface' is 'deploy' ... is that true? | 07:54 |
*** hjensas has joined #openstack-ironic | 08:03 | |
*** tssurya has quit IRC | 08:12 | |
*** dsneddon has joined #openstack-ironic | 08:15 | |
*** openstackgerrit has quit IRC | 08:17 | |
rpittau | good morning ironic! o/ | 08:19 |
*** dsneddon has quit IRC | 08:20 | |
*** dtantsur|afk is now known as dtantsur | 08:24 | |
dtantsur | morning ironic | 08:24 |
dtantsur | arne_wiebalck: I'm not sure, to be honest. Probably. | 08:24 |
*** tssurya has joined #openstack-ironic | 08:24 | |
*** yajushiSri has joined #openstack-ironic | 08:26 | |
*** jtomasek has quit IRC | 08:32 | |
etingof | iurygregory, hey, if you prayed to Zuul today, you might consider trying out my patch o/ -- https://review.openstack.org/#/c/644822/ | 08:32 |
patchbot | patch 644822 - ironic - Add systemd unit for sushy emulator in devstack - 3 patch sets | 08:32 |
*** gkadam has joined #openstack-ironic | 08:33 | |
etingof | (it's actually three patches in chain) | 08:33 |
*** gkadam has quit IRC | 08:33 | |
*** sburette has joined #openstack-ironic | 08:35 | |
* dtantsur <3 these patches | 08:35 | |
dtantsur | rpittau or arne_wiebalck, a trivial patch: https://review.openstack.org/642457 | 08:42 |
patchbot | patch 642457 - ironic - Add a non-voting metalsmith job for local boot cov... - 1 patch set | 08:42 |
rpittau | dtantsur, when you have a minute, it's all green and hopefully working as intended xD https://review.openstack.org/644540 | 08:44 |
patchbot | patch 644540 - ironic - Workaround for postgres job with ubuntu bionic - 9 patch sets | 08:44 |
dtantsur | LGTM (even though I don't understand it well) | 08:44 |
rpittau | I would love to have hjensas opinion on that :) | 08:46 |
iurygregory | etingof, \o/ | 08:47 |
iurygregory | good morning everyone | 08:47 |
rpittau | hey iurygregory :) | 08:47 |
*** e0ne has quit IRC | 08:48 | |
*** e0ne has joined #openstack-ironic | 08:51 | |
arne_wiebalck | dtantsur: Concerning the interface on h/w managers, our docs are not very clear on this. There is a comment here: https://docs.openstack.org/ironic-python-agent/latest/contributor/hardware_managers.html that sounds like it needs to be 'deploy'. | 08:51 |
arne_wiebalck | dtantsur: And from experimenting, it seems that if I use sth else, it is not taken into account. | 08:52 |
dtantsur | yeah, it seems so from https://github.com/openstack/ironic-python-agent/blob/master/ironic_python_agent/hardware.py#L501-L521 | 08:52 |
dtantsur | I wonder how proliantutils deal with it | 08:52 |
dtantsur | arne_wiebalck: hmmm https://github.com/openstack/proliantutils/blob/master/proliantutils/ipa_hw_manager/hardware_manager.py#L39-L50 | 08:53 |
arne_wiebalck | dtantsur: I was thinking that the lines you quoted actually miss the comment for the interface. | 08:53 |
dtantsur | it seems that proliantutils use interface: raid, so it should work? | 08:53 |
arne_wiebalck | you have a pointer a hand? | 08:54 |
dtantsur | arne_wiebalck: see above. I'm not sure how exactly it works though. | 08:54 |
arne_wiebalck | dtantsur: ups, sorry, missed that | 08:54 |
dtantsur | probably via AgentRAID | 08:54 |
arne_wiebalck | Background is: I try to get the post create_config hook to work, so that the raid_config is updated in a node. | 08:55 |
*** dougsz has joined #openstack-ironic | 08:55 | |
*** dsneddon has joined #openstack-ironic | 08:55 | |
arne_wiebalck | It looks like this should work more or less automatically, but only when the interface is 'raid'. So far, I used 'deploy'. | 08:55 |
arne_wiebalck | OK, I'll have a look. | 08:56 |
arne_wiebalck | Thanks! | 08:56 |
dtantsur | np | 08:56 |
arne_wiebalck | Ah, yes. This works. | 08:57 |
arne_wiebalck | But this is with pririty 0. | 08:57 |
arne_wiebalck | priority 0, so this is manual cleaning only | 08:57 |
dtantsur | right, because hardware RAID is usually done with manual cleaning | 08:57 |
arne_wiebalck | I'm trying to make this part of automated cleaning. | 08:57 |
arne_wiebalck | Anyway, I'll have a look. | 08:57 |
rpittau | dtantsur, about that non voting metalsmith job, do you think would be worth to run it with Python 3 ? | 08:59 |
dtantsur | rpittau: not much difference. metalsmith itself has python 3 jobs, just not this one. | 09:00 |
dtantsur | maybe we could duplicate it, dunno | 09:00 |
*** dsneddon has quit IRC | 09:00 | |
dtantsur | my biggest point here is to cover partition images + local boot | 09:00 |
rpittau | yeah, I saw the comments | 09:00 |
dtantsur | note that any changes to this job will have to happen after stable/stein created in ironic, since metalsmith already has stable/stein | 09:02 |
dtantsur | (or we'll have to backport them) | 09:02 |
rpittau | well I guess we can wait, it was a thought dictated by the "Python 3 fever" | 09:05 |
*** whoami-rajat has quit IRC | 09:10 | |
*** S4ren has joined #openstack-ironic | 09:17 | |
*** whoami-rajat has joined #openstack-ironic | 09:18 | |
*** Chaserjim has quit IRC | 09:22 | |
dtantsur | :D | 09:28 |
*** dsneddon has joined #openstack-ironic | 09:28 | |
dtantsur | etingof: hi, do you know what happened to https://review.openstack.org/#/c/636894/ ?\ | 09:32 |
patchbot | patch 636894 - virtualbmc - Ignore "start" command if instance appears to be r... - 1 patch set | 09:32 |
*** dteselkin has quit IRC | 09:32 | |
etingof | may be I need to rebase, let me see | 09:32 |
*** dteselkin has joined #openstack-ironic | 09:33 | |
*** dsneddon has quit IRC | 09:33 | |
*** priteau has joined #openstack-ironic | 09:37 | |
*** Lucas_Gray has joined #openstack-ironic | 09:40 | |
*** derekh has joined #openstack-ironic | 09:43 | |
*** pcaruana has quit IRC | 09:45 | |
*** pcaruana has joined #openstack-ironic | 09:46 | |
etingof | looks like libvirt wrapper fails to build on bionic | 09:47 |
*** dsneddon has joined #openstack-ironic | 09:57 | |
*** dsneddon has quit IRC | 10:02 | |
dtantsur | rpioso: https://review.openstack.org/#/c/637971/ is the dependency of the Python 3 patch you've just approved | 10:11 |
patchbot | patch 637971 - ironic - Add systemd unit for vbmcd in devstack - 10 patch sets | 10:11 |
dtantsur | damn, it was for rpittau | 10:11 |
dtantsur | sorry rpioso | 10:11 |
*** e0ne has quit IRC | 10:14 | |
rpittau | dtantsur, thanks, I thought I checked that already :/ | 10:15 |
dtantsur | there are 3 patches there :) | 10:15 |
rpittau | dtantsur, yeah, I commented on the last one, approved the middle one, and opened the first one and forgot about it :/ | 10:15 |
rpittau | weird order.... | 10:15 |
dtantsur | heh | 10:16 |
etingof | openstackgerrit went south | 10:16 |
dtantsur | yeah | 10:17 |
dtantsur | iurygregory: ironicclient stein seems to suffer from a familiar failure: http://logs.openstack.org/52/644152/1/check/ironicclient-dsvm-functional/c4aa16b/job-output.txt.gz#_2019-03-20_14_18_29_569438 | 10:17 |
dtantsur | anything we have to backport there? | 10:17 |
iurygregory | dtantsur, looking | 10:17 |
*** e0ne has joined #openstack-ironic | 10:17 | |
dtantsur | rpittau: another pre-release review request please: https://review.openstack.org/#/c/642534/ | 10:19 |
patchbot | patch 642534 - sushy-tools - Fix broken Systems listing in dynamic emulator - 1 patch set | 10:19 |
iurygregory | dtantsur, the fix is only in master | 10:20 |
iurygregory | https://github.com/openstack/python-ironicclient/blob/stable/stein/ironicclient/tests/functional/osc/v1/test_baremetal_allocation.py#L143 in stein we still have this exception | 10:21 |
dtantsur | ah! so we need a backport? | 10:21 |
iurygregory | but in the ironic side is Nodes cannot be found | 10:21 |
iurygregory | dtantsur, the patche was https://review.openstack.org/#/c/642474/ | 10:21 |
patchbot | patch 642474 - python-ironicclient - Run jobs under python2 and python3 (MERGED) - 11 patch sets | 10:21 |
dtantsur | iurygregory: wanna try backporting it? | 10:22 |
iurygregory | dtantsur, sure | 10:22 |
iurygregory | yay merge conflit from the UI \o/ | 10:22 |
*** S4ren has quit IRC | 10:23 | |
iurygregory | do you want me to backport only the file that change the tests ? | 10:23 |
dtantsur | iurygregory: you probably need to backport the parent patch (with zuul v3) | 10:23 |
iurygregory | looking at the diff of commits here, so i would prob need to squash the commits right? | 10:24 |
dtantsur | iurygregory: why? | 10:25 |
dtantsur | hmmm | 10:26 |
dtantsur | iurygregory: I guess we'll have to do it in 3 steps: first backport only the tests fix (to unblock the gate), then we can backport the zuul and python 3 stuff (because we need python 3 on stein). | 10:26 |
*** S4ren has joined #openstack-ironic | 10:26 | |
iurygregory | dtantsur, but the test fix is together with the change ta enable a job to run under python3 | 10:27 |
dtantsur | iurygregory: right, we probably need to split it out and land it first | 10:27 |
dtantsur | then proceed with normal backporting | 10:27 |
iurygregory | dtantsur, ok so i will backport only the test file | 10:28 |
iurygregory | doing now | 10:28 |
*** yajushiSri has left #openstack-ironic | 10:28 | |
dtantsur | thx | 10:29 |
*** dsneddon has joined #openstack-ironic | 10:35 | |
*** dsneddon has quit IRC | 10:40 | |
*** openstackgerrit has joined #openstack-ironic | 10:47 | |
openstackgerrit | Merged openstack/metalsmith stable/stein: Update UPPER_CONSTRAINTS_FILE for stable/stein https://review.openstack.org/640106 | 10:47 |
*** e0ne has quit IRC | 10:58 | |
*** e0ne has joined #openstack-ironic | 10:59 | |
*** dsneddon has joined #openstack-ironic | 11:04 | |
*** dsneddon has quit IRC | 11:10 | |
dtantsur | sorry rpittau, one more thing: https://review.openstack.org/#/c/645095/1 | 11:12 |
patchbot | patch 645095 - virtualbmc - Bump lower libvirt-python to 3.7 - 1 patch set | 11:12 |
openstackgerrit | Merged openstack/sushy-tools master: Fix broken Systems listing in dynamic emulator https://review.openstack.org/642534 | 11:12 |
rpittau | dtantsur, no worries, I saw that, I was waiting for CI to finish :) | 11:13 |
dtantsur | cool :) | 11:13 |
dtantsur | I hope to release virtualbmc and sushy-tools today | 11:14 |
dtantsur | (well, and ironic, but this is waiting for TheJulia) | 11:14 |
rpittau | first time I'm involved in a release process for ironic, or any openstack project :P | 11:16 |
*** priteau has quit IRC | 11:19 | |
openstackgerrit | Merged openstack/sushy-tools master: Add memoization to expensive emulator calls https://review.openstack.org/612758 | 11:19 |
*** whoami-rajat has quit IRC | 11:30 | |
*** whoami-rajat has joined #openstack-ironic | 11:34 | |
*** bfournie has quit IRC | 11:38 | |
*** dsneddon has joined #openstack-ironic | 11:46 | |
openstackgerrit | Iury Gregory Melo Ferreira proposed openstack/python-ironicclient stable/stein: Fix allocation tests https://review.openstack.org/645146 | 11:47 |
iurygregory | dtantsur, done, sorry for the delay i went for lunch =) | 11:47 |
dtantsur | TheJulia, mgoddard, you may love (or hate) this: https://review.openstack.org/#/c/645092/ and https://review.openstack.org/#/c/645093/ :) | 11:49 |
patchbot | patch 645092 - bifrost - Move RabbitMQ handling into a separate role and su... - 2 patch sets | 11:49 |
patchbot | patch 645093 - bifrost - Disable RabbitMQ by default - 2 patch sets | 11:49 |
mgoddard | dtantsur: love it with fire | 11:51 |
dtantsur | hehe | 11:51 |
*** dsneddon has quit IRC | 11:51 | |
rpittau | poor rabbits | 11:51 |
*** rh-jelabarre has joined #openstack-ironic | 11:51 | |
iurygregory | poor rabbits +1 | 11:52 |
dtantsur | :D | 11:52 |
iurygregory | but since they are virtual im fine lol | 11:52 |
dtantsur | I wonder if we need a job with rabbitmq still enabled | 11:53 |
rpittau | dtantsur, I'm pretty sure we need it, and not just because I like rabbits :D | 11:54 |
dtantsur | okay, I can look into it some time later | 11:54 |
openstackgerrit | Riccardo Pittau proposed openstack/ironic master: Fix capabilities passed as string in agent prepare https://review.openstack.org/645151 | 11:55 |
iurygregory | i think is a good a idea to have, if we have feedback from operators saying they dont use in production we are good XD | 11:56 |
dtantsur | it still uses zuul v2, send help :( | 11:59 |
rpittau | lol | 12:00 |
iurygregory | dtantsur, bifrost? | 12:00 |
dtantsur | iurygregory: yeah | 12:02 |
iurygregory | =O | 12:02 |
iurygregory | i will take a look in my free time XD | 12:02 |
dtantsur | awesome | 12:03 |
dtantsur | it may be straightforward to move it, since it doesn't use devstack or tempest | 12:03 |
iurygregory | yeah | 12:03 |
dtantsur | but now we have a lot of bash calling bash inside ansible, this should be cleaned up | 12:03 |
openstackgerrit | Merged openstack/virtualbmc master: Bump lower libvirt-python to 3.7 https://review.openstack.org/645095 | 12:04 |
iurygregory | gotcha | 12:04 |
*** dsneddon has joined #openstack-ironic | 12:06 | |
openstackgerrit | Merged openstack/virtualbmc master: Ignore "start" command if instance appears to be running https://review.openstack.org/636894 | 12:08 |
*** bfournie has joined #openstack-ironic | 12:11 | |
*** dsneddon has quit IRC | 12:12 | |
*** jtomasek has joined #openstack-ironic | 12:12 | |
*** dsneddon has joined #openstack-ironic | 12:22 | |
openstackgerrit | Dmitry Tantsur proposed openstack/python-ironicclient stable/stein: Update UPPER_CONSTRAINTS_FILE for stable/stein https://review.openstack.org/644152 | 12:27 |
*** dsneddon has quit IRC | 12:27 | |
*** dsneddon has joined #openstack-ironic | 12:28 | |
*** trown|outtypewww is now known as trown | 12:32 | |
*** dsneddon has quit IRC | 12:32 | |
*** rh-jelabarre has quit IRC | 12:34 | |
*** Wryhder has joined #openstack-ironic | 12:35 | |
*** Lucas_Gray has quit IRC | 12:36 | |
*** Wryhder is now known as Lucas_Gray | 12:36 | |
*** yolanda has joined #openstack-ironic | 12:46 | |
openstackgerrit | Dmitry Tantsur proposed openstack/python-ironicclient stable/stein: Update .gitreview for stable/stein https://review.openstack.org/644151 | 12:47 |
*** e0ne has quit IRC | 12:51 | |
*** dtantsur is now known as dtantsur|brb | 12:52 | |
*** dsneddon has joined #openstack-ironic | 12:59 | |
iurygregory | yay the cherry pick worked \o/ | 13:02 |
openstackgerrit | Merged openstack/bifrost master: Add versions to release notes series https://review.openstack.org/645085 | 13:06 |
*** dsneddon has quit IRC | 13:06 | |
*** irclogbot_3 has quit IRC | 13:07 | |
*** irclogbot_3 has joined #openstack-ironic | 13:08 | |
*** yaawang has quit IRC | 13:11 | |
*** yaawang has joined #openstack-ironic | 13:12 | |
*** sthussey has joined #openstack-ironic | 13:14 | |
openstackgerrit | Merged openstack/ironic master: Workaround for postgres job with ubuntu bionic https://review.openstack.org/644540 | 13:19 |
*** altlogbot_3 has quit IRC | 13:23 | |
TheJulia | I just love waking up with a migraine | 13:23 |
*** e0ne has joined #openstack-ironic | 13:23 | |
*** altlogbot_1 has joined #openstack-ironic | 13:24 | |
TheJulia | dtantsur|brb: comment on 644590 | 13:28 |
openstackgerrit | Ilya Etingof proposed openstack/sushy-tools master: Ensure non-empty libvirt <loader/> tag https://review.openstack.org/642728 | 13:29 |
openstackgerrit | Ilya Etingof proposed openstack/sushy-tools master: Create libvirt boot loader element if needed https://review.openstack.org/642581 | 13:30 |
*** e0ne has quit IRC | 13:37 | |
*** dsneddon has joined #openstack-ironic | 13:38 | |
hjensas | rpittau: hey, the conntrack helper hack is fine with me. :) | 13:39 |
*** altlogbot_1 has quit IRC | 13:39 | |
rpittau | hjensas, thanks :) | 13:39 |
*** whoami-rajat has quit IRC | 13:40 | |
*** altlogbot_3 has joined #openstack-ironic | 13:40 | |
*** baha has joined #openstack-ironic | 13:41 | |
*** dsneddon has quit IRC | 13:43 | |
*** irclogbot_3 has quit IRC | 13:45 | |
*** e0ne has joined #openstack-ironic | 13:45 | |
*** jaypipes has quit IRC | 13:46 | |
*** irclogbot_2 has joined #openstack-ironic | 13:46 | |
*** rh-jelabarre has joined #openstack-ironic | 13:50 | |
TheJulia | looks like the workaround is in the gate | 13:52 |
*** jistr is now known as jistr|call | 13:52 | |
*** hjensas has quit IRC | 13:52 | |
rpittau | I think it's merged already :) | 13:52 |
openstackgerrit | Ilya Etingof proposed openstack/sushy-tools master: Add docs on UEFI boot libvirt-based emulation https://review.openstack.org/642830 | 13:53 |
TheJulia | It could have | 13:59 |
TheJulia | I woke up with a migraine and the world is slightly fuzzy as a result | 14:00 |
*** jistr|call is now known as jistr | 14:00 | |
* etingof finds the world fuzzy at all times | 14:02 | |
*** mjturek has joined #openstack-ironic | 14:02 | |
*** dsneddon has joined #openstack-ironic | 14:11 | |
openstackgerrit | Riccardo Pittau proposed openstack/ironic master: Fix capabilities passed as string in agent prepare https://review.openstack.org/645151 | 14:13 |
openstackgerrit | Ilya Etingof proposed openstack/sushy-tools master: Rename `drivers` to `systems` https://review.openstack.org/638492 | 14:13 |
openstackgerrit | Merged openstack/ironic master: Set boot_mode in node properties during Redfish introspection https://review.openstack.org/641357 | 14:14 |
openstackgerrit | Merged openstack/ironic master: Add a non-voting metalsmith job for local boot coverage https://review.openstack.org/642457 | 14:14 |
openstackgerrit | Merged openstack/ironic-python-agent master: Add versions to release notes series https://review.openstack.org/645076 | 14:14 |
openstackgerrit | Merged openstack/ironic-inspector master: Add versions to release notes series https://review.openstack.org/645077 | 14:14 |
openstackgerrit | Merged openstack/python-ironicclient stable/stein: Fix allocation tests https://review.openstack.org/645146 | 14:14 |
openstackgerrit | Merged openstack/python-ironicclient stable/stein: Update UPPER_CONSTRAINTS_FILE for stable/stein https://review.openstack.org/644152 | 14:14 |
*** dsneddon has quit IRC | 14:16 | |
openstackgerrit | Ilya Etingof proposed openstack/sushy-tools master: Rename `drivers` to `systems` https://review.openstack.org/638492 | 14:20 |
openstackgerrit | Ilya Etingof proposed openstack/sushy-tools master: Add Managers resource support https://review.openstack.org/638682 | 14:23 |
*** whoami-rajat has joined #openstack-ironic | 14:23 | |
*** sburette has quit IRC | 14:30 | |
*** mjturek has quit IRC | 14:33 | |
*** altlogbot_3 has quit IRC | 14:35 | |
*** altlogbot_3 has joined #openstack-ironic | 14:36 | |
openstackgerrit | Merged openstack/python-ironicclient stable/stein: Update .gitreview for stable/stein https://review.openstack.org/644151 | 14:36 |
*** dtantsur|brb is now known as dtantsur | 14:37 | |
dtantsur | morning TheJulia. migraine-- :( | 14:37 |
*** irclogbot_2 has quit IRC | 14:38 | |
*** irclogbot_0 has joined #openstack-ironic | 14:39 | |
*** mjturek has joined #openstack-ironic | 14:39 | |
*** hjensas has joined #openstack-ironic | 14:44 | |
*** dsneddon has joined #openstack-ironic | 14:47 | |
*** dsneddon has quit IRC | 14:52 | |
openstackgerrit | Ilya Etingof proposed openstack/sushy-tools master: Add docs on UEFI boot libvirt-based emulation https://review.openstack.org/642830 | 14:55 |
*** dsneddon has joined #openstack-ironic | 15:00 | |
*** hjensas has quit IRC | 15:07 | |
*** baha has quit IRC | 15:18 | |
w14161_1 | Hi, all, i create a redfish baremetal node, by validate, the result was "True", but after I run "openstack baremetal node manage", it said something like "node xxx was locked by xxx, retry 6 of 6". I could access the node by https way with redfish, I could see odata reply from chrome. But why ironic can not? Was it a proxy issue? My node has proxy setting, how to add proxy setting to redfish | 15:25 |
w14161_1 | interface of ironic? Or how to check whether the target node support redfish capability? Thx a lot! | 15:25 |
*** Lucas_Gray has quit IRC | 15:31 | |
openstackgerrit | Merged openstack/ironic master: Add systemd unit for vbmcd in devstack https://review.openstack.org/637971 | 15:39 |
*** baha has joined #openstack-ironic | 15:44 | |
dtantsur | TheJulia: what are your plans re ironic release? | 15:48 |
*** hwoarang has quit IRC | 15:49 | |
*** hwoarang has joined #openstack-ironic | 15:51 | |
arne_wiebalck | dtantsur: clean steps in custom h/w managers must indeed be for the deploy interface: https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/agent.py#L661-L663 | 15:51 |
dtantsur | arne_wiebalck: this is in AgentDeploy, but what about AgentRAID? | 15:52 |
* arne_wiebalck checking | 15:53 | |
*** gyee has joined #openstack-ironic | 15:57 | |
*** hjensas has joined #openstack-ironic | 15:58 | |
* arne_wiebalck is not clear on how this work | 15:59 | |
arne_wiebalck | AgentRAID does not get cleaning steps, it implements {create/delete}_configuration() functions ... when are these actually called/triggered? | 16:03 |
arne_wiebalck | The way I have done this so far is by adding create/delete to 'deploy'. That ensures they are triggered during automatic cleaning. | 16:04 |
*** hwoarang has quit IRC | 16:05 | |
*** hwoarang has joined #openstack-ironic | 16:06 | |
arne_wiebalck | Adding them with 'raid' makes them available for *manual* cleaning (and the post create hook is run and add the returned config to 'raid_config' in a node -- which is what'd like for RAID creation during cleaning as well). | 16:07 |
*** dsneddon has quit IRC | 16:08 | |
* arne_wiebalck is trying to avoid to call node_update himself, but leverage existing code :) | 16:08 | |
*** e0ne has quit IRC | 16:10 | |
arne_wiebalck | From what I see it's AgentDeploy doing the cleaning, so it's kind of natural that clean steps use that interface. | 16:11 |
openstackgerrit | Ilya Etingof proposed openstack/sushy-tools master: Add docs on UEFI boot libvirt-based emulation https://review.openstack.org/642830 | 16:14 |
*** mjturek has quit IRC | 16:16 | |
*** dsneddon has joined #openstack-ironic | 16:17 | |
arne_wiebalck | dtantsur: Manual cleaning works differently as the steps are passed directly, so no "filtering" by interface. | 16:22 |
dtantsur | sigh | 16:22 |
arne_wiebalck | dtantsur: but probably I don't fully understand how that works | 16:23 |
*** dsneddon has quit IRC | 16:23 | |
*** mjturek has joined #openstack-ironic | 16:24 | |
*** hjensas has quit IRC | 16:24 | |
dtantsur | arne_wiebalck: get we do a similar thing for the RAID interface? filter "raid" steps? | 16:24 |
*** baha has quit IRC | 16:24 | |
arne_wiebalck | dtantsur: you mean 'could we' ? | 16:25 |
dtantsur | yeah, sorry. typing random words.. | 16:25 |
arne_wiebalck | dtantsur: I'm not clear on how that would be triggered. | 16:25 |
dtantsur | I don't clearly remember either | 16:25 |
dtantsur | but any interface can expose clean steps | 16:26 |
arne_wiebalck | iyes | 16:26 |
arne_wiebalck | and they are accessible to manual cleaning | 16:26 |
dtantsur | so in theory we can copy AgentDeploy.get_clean_steps to AgentRAID, while s/deploy/raid/ in the filter | 16:26 |
arne_wiebalck | I tried this and it works | 16:26 |
arne_wiebalck | but would that get them executed during automatic cleaning? | 16:27 |
dtantsur | I think automated cleaning also collects steps from all interfaces | 16:28 |
dtantsur | but I don't quite get why it doesn't work automatically for your steps.. | 16:28 |
dtantsur | they have non-zero priority, right? | 16:28 |
arne_wiebalck | yes | 16:28 |
arne_wiebalck | my theory was that the cleaning steps for *automatic* cleaning need to have 'deploy' | 16:29 |
arne_wiebalck | the docs kind of indicate this: https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/agent.py#L661-L663 | 16:30 |
arne_wiebalck | ups | 16:30 |
arne_wiebalck | https://docs.openstack.org/ironic-python-agent/latest/contributor/hardware_managers.html | 16:30 |
arne_wiebalck | section "Custom HardwareManagers and Cleaning" | 16:31 |
arne_wiebalck | the comment in the code box | 16:31 |
*** tssurya has quit IRC | 16:34 | |
dtantsur | arne_wiebalck: it should collect steps from all interfaces: https://github.com/openstack/ironic/blob/master/ironic/conductor/steps.py#L84-L114 | 16:35 |
*** baha has joined #openstack-ironic | 16:35 | |
arne_wiebalck | dtantsur: interesting | 16:38 |
arne_wiebalck | dtantsur: well, all steps are in the nodes driver_info, that's true, but are they all considered when it comes to automatic cleaning? | 16:40 |
dtantsur | arne_wiebalck: this is the function that fetches them | 16:40 |
dtantsur | I don't know where else we would filter steps | 16:40 |
arne_wiebalck | what about the get_clean_steps in the AgentDeploy (which looks for 'deploy' only): what is that for? | 16:42 |
dtantsur | arne_wiebalck: I think it ends up being called here when we come to 'deploy': https://github.com/openstack/ironic/blob/master/ironic/conductor/steps.py#L109 | 16:43 |
arne_wiebalck | dtantsur: ok, so all cleaning steps defined in a custom h/w manager end up in the node's driver_internal_info and they are all available to manual cleaning; automatic cleaning seems to only consider steps with 'deploy' interface | 16:50 |
dtantsur | arne_wiebalck: right, I *think* it's because AgentRAID does not implement get_clean_steps | 16:53 |
arne_wiebalck | dtantsur: it only uses create/delete confiuguration | 16:54 |
TheJulia | ugh, finally just got off a call | 16:54 |
dtantsur | yep, I think we need to copy get_clean_steps. at least that's the only guess I have | 16:54 |
* TheJulia would like to ban calls | 16:54 | |
TheJulia | dtantsur: lets cut the release | 16:54 |
rpittau | good night! o/ | 16:54 |
*** rpittau is now known as rpittau|afk | 16:55 | |
arne_wiebalck | dtantsur: I'm still not clear on what triggers AgentRAID | 16:55 |
dtantsur | TheJulia: I wonder if we need to wait for https://review.openstack.org/#/c/644622/ | 16:55 |
patchbot | patch 644622 - ironic - Respect $USE_PYTHON3 settings for gunicorn - 3 patch sets | 16:55 |
dtantsur | although we can backport it soon | 16:56 |
TheJulia | dtantsur: It is devstack, it can be backported | 16:56 |
TheJulia | ++ | 16:56 |
dtantsur | okay, should I propose the release (and ditto for ironic-tempest-plugin)? | 16:57 |
TheJulia | please | 16:57 |
dtantsur | k | 16:57 |
TheJulia | thanks! | 16:58 |
* TheJulia goes and gets more migrain meds | 16:58 | |
*** dsneddon has joined #openstack-ironic | 17:00 | |
arne_wiebalck | dtantsur: I think I get now what you meant: if AgentRAID would do get_clean_steps, it the steps would actually be added to the list of overall steps for automatic cleaning ... correct? Each interface is basically in charge of adding its steps. | 17:03 |
*** dsneddon has quit IRC | 17:05 | |
dtantsur | arne_wiebalck: that's what I expect. mgoddard may know this code much better | 17:07 |
* mgoddard exits low power mode | 17:08 | |
mgoddard | dtantsur: arne_wiebalck: I don't think it's quite like that | 17:10 |
arne_wiebalck | mgoddard: lol | 17:10 |
dtantsur | oops :) | 17:10 |
mgoddard | currently AgentRAID has two clean steps, both configured with priority 0 | 17:10 |
arne_wiebalck | mgoddard: shed some light! | 17:10 |
arne_wiebalck | mgoddard: yes | 17:10 |
openstackgerrit | Ilya Etingof proposed openstack/sushy-tools master: Rename `drivers` to `systems` https://review.openstack.org/638492 | 17:11 |
mgoddard | a non-zero priority would make them run automatically | 17:11 |
arne_wiebalck | mgoddard: what happens if these are overwritten by clean steps in a custome h/w maanger? | 17:11 |
arne_wiebalck | mgoddard: b/c this is what I tried | 17:11 |
arne_wiebalck | mgoddard: with non-zero prio | 17:12 |
arne_wiebalck | mgoddard: and they work fine with manual cleaning | 17:12 |
arne_wiebalck | mgoddard: and if the interface is 'deploy' | 17:12 |
mgoddard | arne_wiebalck: the AgentDeploy interface should collect steps from the agent | 17:12 |
*** trown is now known as trown|lunch | 17:12 | |
mgoddard | arne_wiebalck: unless you have some interface='raid' tag in the agent? | 17:13 |
arne_wiebalck | mgoddard: right, but I think it filters only the ones with 'deploy' not all | 17:13 |
mgoddard | arne_wiebalck: ok | 17:13 |
dtantsur | mgoddard: well, it must have interface:raid.. | 17:13 |
dtantsur | which makes it also weird that we use AgentDeploy to collect non-deploy steps | 17:13 |
mgoddard | arne_wiebalck: so you're saying we should add get_clean_steps(interface='raid') to AgentRAID? | 17:13 |
arne_wiebalck | mgoddard: this was an idea dtantsur had | 17:13 |
arne_wiebalck | what I'd like to profit from is the post create_config hook, in fact | 17:14 |
arne_wiebalck | this is the actual goal | 17:14 |
mgoddard | it sounds sensible, I retract my earlier statement :) | 17:14 |
arne_wiebalck | which requires interface:raid | 17:14 |
mgoddard | IPA docstring for get_clean_steps is missing 'interface' | 17:20 |
mgoddard | It sounds like you're on the right track here | 17:20 |
TheJulia | mgoddard: I kind of noticed that before but didn't braincell to fix | 17:21 |
mgoddard | are there other agent interfaces we should be adding get_clean_steps to? | 17:21 |
mgoddard | arne_wiebalck: noticed that the AgentDeploy get_clean_steps doesn't include decorated controller-side steps, so you'll want to add a super(...).get_clean_steps() | 17:22 |
mgoddard | TheJulia: let's see if I can muster enough cells | 17:22 |
TheJulia | I think I need like a meeting free day | 17:23 |
mgoddard | TheJulia: just mark an entire week as 'busy' in your calendar | 17:24 |
TheJulia | I wish I could | 17:24 |
*** dsneddon has joined #openstack-ironic | 17:24 | |
*** iurygregory has quit IRC | 17:25 | |
dtantsur | TheJulia: when I was at Skype, our team declared 2 fixed days a week meeting-free. worked pretty well. | 17:25 |
openstackgerrit | Mark Goddard proposed openstack/ironic-python-agent master: Add 'interface' to get_clean_steps docstring https://review.openstack.org/645263 | 17:26 |
TheJulia | The downside is we have limited time blocks, of course I'm totally willing to get up early | 17:26 |
arne_wiebalck | mgoddard: FWIU, AgentDeploy actively limits itself to 'deploy' when getting the clean steps. | 17:27 |
mgoddard | arne_wiebalck: that's correct | 17:28 |
arne_wiebalck | mgoddard: Should it get all steps. i.e. from other interfaces as well, or should the other interfaces have a get_clean_steps? | 17:29 |
mgoddard | arne_wiebalck: but currently, if you added an @clean_step to that interface it would be ignored because get_clean_steps doesn't call the same method on the superclass | 17:29 |
mgoddard | arne_wiebalck: it makes sense for it to only return steps for the correct interface | 17:29 |
mgoddard | arne_wiebalck: you could pull out get_clean_steps into a mixin class to be used by all relevant agent interfaces | 17:30 |
arne_wiebalck | mgoddard: so, other interfaces should also get/return their steps? | 17:30 |
*** dtantsur is now known as dtantsur|afk | 17:30 | |
mgoddard | arne_wiebalck: yes, IMO | 17:30 |
dtantsur|afk | see you tomorrow | 17:30 |
arne_wiebalck | dtantsur|afk: by, thanks! | 17:30 |
TheJulia | o/ dtantsur|afk | 17:30 |
arne_wiebalck | mgoddard: that was dtantsur's suggestion | 17:30 |
mgoddard | arne_wiebalck: yes, I agree | 17:31 |
arne_wiebalck | mgoddard: I can give that a try | 17:31 |
arne_wiebalck | mgoddard: tmrw :) | 17:31 |
mgoddard | arne_wiebalck: just took me a little time to pick up the context :) | 17:31 |
arne_wiebalck | mgoddard: was all triggered by stendulker's suggestion to update the raid_config in the node | 17:32 |
arne_wiebalck | mgoddard: and then I looked and found the post create hook ... and thought I was done ;) | 17:32 |
arne_wiebalck | mgoddard: thanks for your help, I'll give that a try tmrw and see how far I get | 17:33 |
arne_wiebalck | bye mgoddard TheJulia, everyone! | 17:34 |
mgoddard | night arne_wiebalck | 17:34 |
*** S4ren has quit IRC | 17:41 | |
*** gmann is now known as gmann_afk | 17:43 | |
openstackgerrit | Ilya Etingof proposed openstack/sushy-tools master: Rename `drivers` to `systems` https://review.openstack.org/638492 | 17:59 |
*** derekh has quit IRC | 18:02 | |
*** e0ne has joined #openstack-ironic | 18:05 | |
*** e0ne has quit IRC | 18:12 | |
*** trown|lunch is now known as trown | 18:22 | |
*** whoami-rajat has quit IRC | 18:23 | |
*** dougsz has quit IRC | 18:23 | |
*** iurygregory has joined #openstack-ironic | 18:29 | |
*** gmann_afk is now known as gmann | 18:40 | |
*** sthussey has quit IRC | 19:23 | |
*** whoami-rajat has joined #openstack-ironic | 19:25 | |
*** hjensas has joined #openstack-ironic | 19:28 | |
*** e0ne has joined #openstack-ironic | 19:30 | |
*** e0ne has quit IRC | 19:49 | |
*** e0ne has joined #openstack-ironic | 19:52 | |
*** iurygregory has quit IRC | 20:01 | |
openstackgerrit | OpenStack Release Bot proposed openstack/ironic stable/stein: Update .gitreview for stable/stein https://review.openstack.org/645322 | 20:01 |
openstackgerrit | OpenStack Release Bot proposed openstack/ironic stable/stein: Update UPPER_CONSTRAINTS_FILE for stable/stein https://review.openstack.org/645323 | 20:01 |
openstackgerrit | OpenStack Release Bot proposed openstack/ironic master: Update master for stable/stein https://review.openstack.org/645324 | 20:01 |
*** e0ne has quit IRC | 20:04 | |
openstackgerrit | Merged openstack/ironic master: Respect $USE_PYTHON3 settings for gunicorn https://review.openstack.org/644622 | 20:04 |
*** e0ne has joined #openstack-ironic | 20:28 | |
*** trown is now known as trown|outtypewww | 20:44 | |
*** Lucas_Gray has joined #openstack-ironic | 20:53 | |
*** jtomasek has quit IRC | 20:55 | |
*** Lucas_Gray has quit IRC | 20:55 | |
*** Lucas_Gray has joined #openstack-ironic | 20:55 | |
*** Lucas_Gray has quit IRC | 20:57 | |
*** Lucas_Gray has joined #openstack-ironic | 20:58 | |
*** Lucas_Gray has quit IRC | 21:00 | |
*** Lucas_Gray has joined #openstack-ironic | 21:01 | |
*** Lucas_Gray has quit IRC | 21:02 | |
*** Lucas_Gray has joined #openstack-ironic | 21:03 | |
*** rh-jelabarre has quit IRC | 21:04 | |
*** Lucas_Gray has quit IRC | 21:05 | |
*** Lucas_Gray has joined #openstack-ironic | 21:05 | |
*** mjturek has quit IRC | 21:06 | |
*** Lucas_Gray has quit IRC | 21:06 | |
*** Lucas_Gray has joined #openstack-ironic | 21:09 | |
*** Lucas_Gray has quit IRC | 21:11 | |
*** baha has quit IRC | 21:11 | |
*** Lucas_Gray has joined #openstack-ironic | 21:12 | |
*** iurygregory has joined #openstack-ironic | 21:12 | |
iurygregory | dtantsur|afk, TheJulia , rpittau|afk , we can have a job with Python3 enable for sushy yay! https://review.openstack.org/591828 Thanks to etingof and the ironic patches =) | 21:14 |
patchbot | patch 591828 - sushy - Change sushy devstack job to python3 - 4 patch sets | 21:14 |
iurygregory | to have in stable/stein we will need to backport the ironic changes | 21:15 |
*** e0ne has quit IRC | 21:17 | |
*** Lucas_Gray has quit IRC | 21:17 | |
*** iurygregory has quit IRC | 21:18 | |
*** Lucas_Gray has joined #openstack-ironic | 21:23 | |
*** Lucas_Gray has quit IRC | 21:24 | |
*** S4ren has joined #openstack-ironic | 21:31 | |
openstackgerrit | Richard G. Pioso proposed openstack/ironic master: Place upper bound on python-dracclient version https://review.openstack.org/645364 | 21:33 |
*** pcaruana has quit IRC | 21:33 | |
*** S4ren has quit IRC | 21:33 | |
*** whoami-rajat has quit IRC | 21:45 | |
TheJulia | rpioso: does ^^^ mean that breaking changes are anticipated with 3.0.0 and that we need to release ironic 12.1.1 as a result? | 21:57 |
TheJulia | If yes, I think that is going to require a release note. | 21:58 |
TheJulia | And us to start on constraining master's maximum version and back Port that change | 21:59 |
* rpioso hopes TheJulia is feeling better | 21:59 | |
TheJulia | Oddly getting out of the house helped, even though it was just a run to the bank | 22:00 |
* rpioso imagines TheJulia won the lottery and deposited the jackpot, ridding her of the migraine | 22:02 | |
rpioso | TheJulia: python-dracclient follows semver. At some point, a breaking change will be introduced to dracclient. When that occurs, the major version number will be bumped to 3, 3.0.0. | 22:02 |
rpioso | TheJulia: I don't believe such breaking changes should be associated with stable branches, such as stable/steins. | 22:03 |
rpioso | TheJulia: If an operator uses python-dracclient's present driver-requirements.txt entry, >= 1.5.0, they will install 3.0.0, breaking ironic. | 22:05 |
rpioso | TheJulia: It needs to be bounded to a version that is compatible with that stable branch. | 22:05 |
rpioso | pysnmp's entry looks reasonable to me. | 22:05 |
*** irclogbot_0 has quit IRC | 22:05 | |
rpioso | TheJulia: pysnmp>=4.3.0,<5.0.0 | 22:06 |
rpioso | TheJulia: There is a shorthand for that ~4.3.0 | 22:07 |
rpioso | TheJulia: See https://www.python.org/dev/peps/pep-0440/#compatible-release | 22:07 |
*** mgoddard has quit IRC | 22:08 | |
rpioso | TheJulia: TL;DR Generally, I believe there have been issues for some time in driver-requirements.txt | 22:09 |
*** mgoddard has joined #openstack-ironic | 22:09 | |
TheJulia | rpioso: I somewhat agree, but vendors are also responsible for managing their drivers and while master is also generally expected to be deployable so if necessary and for the sake of CI should also have constraints for upper bounds as necessary in order to prevent breaking changes from hitting. For what its worth, a major change doesn't always break, it could just be breaking for a single API call forcing the | 22:13 |
TheJulia | version change... and ironic may never actually use that call that was changed and broken | 22:13 |
gmann | TheJulia: ironic-grenade-dsvm-multinode-multitenant job seems failing consistently now on bionic migration patch - https://review.openstack.org/#/c/642315/ | 22:13 |
patchbot | patch 642315 - ironic - Migrate ironic-grenade-dsvm-multinode-multitenant ... - 2 patch sets | 22:13 |
gmann | which was passing earlier. | 22:13 |
gmann | do you know any known issue ? | 22:13 |
gmann | i have logged the bug with log details- https://storyboard.openstack.org/#!/story/2005284 | 22:14 |
TheJulia | gmann: I do not, someone will need to run it down I guess. | 22:14 |
gmann | it was passing March 12 and then started failing after that | 22:15 |
gmann | that is blocking the Bionic migration patch for ironic | 22:15 |
TheJulia | bottom line, its not a super high priority at the moment because it is a grenade job | 22:17 |
TheJulia | interesting, it is only failing on a general server creation test | 22:18 |
gmann | yeah | 22:18 |
gmann | i see these n-cpu log http://logs.openstack.org/15/642315/2/check/ironic-grenade-dsvm-multinode-multitenant/5c25adb/logs/screen-n-cpu.txt.gz#_Mar_21_20_50_23_651664 | 22:18 |
*** rcernin has joined #openstack-ironic | 22:19 | |
rpioso | TheJulia: I agree with your latter point that a new major revision doesn't always break ironic. That could be addressed by the entry in driver-requirements.txt if and when it occurs. I feel it's better to be conservative, especially on stable branches. | 22:20 |
TheJulia | woot, a single node is timing out | 22:20 |
TheJulia | rpioso: except that patch needs a release note and will need to merge to the master branch first | 22:21 |
* TheJulia loads up all of the console logs | 22:21 | |
TheJulia | gmann: the subnode failed | 22:22 |
*** bfournie has quit IRC | 22:23 | |
rpioso | TheJulia: It seems to me that master doesn't need an upper bound. Breaking changes typically must be deprecated, which gives clients such as ironic time to align themselves. That should be done before the breaking change is released. | 22:25 |
* rpioso reprimands the idrac h/w type for having misbehaved | 22:26 | |
gmann | TheJulia: i cannot find any error on ironic logs | 22:29 |
TheJulia | gmann: it is the libvirt "firmware" loading up on the subnode, its random across nodes due to the has ring and placement, but you can kind of see what is going on curl --limit-rate 30B http://logs.openstack.org/15/642315/2/check/ironic-grenade-dsvm-multinode-multitenant/1f7ea60/logs/subnode-2/old/ironic-bm-logs/subnode-2_console_2019-03-20-00:31:49.txt.gz | 22:30 |
TheJulia | they don't even try to network boot :( | 22:30 |
TheJulia | rpioso: That implies that the driver operates by the same pattern as openstack in terms of breaking changes | 22:31 |
TheJulia | rpioso: I'm suddenly reminded of when we synced openstack/requirements | 22:31 |
rpioso | TheJulia: I expect the in-tree idrac h/w type should operate that way. Right? | 22:33 |
TheJulia | rpioso: doesn't have to as long as the user experience remains un-impacted | 22:34 |
rpioso | TheJulia: I'm updating the idrac doc for that patch. A new patch set is coming. | 22:34 |
TheJulia | k | 22:34 |
rpioso | TheJulia: I'll add a comment asking about the compatible release shorthand -- https://www.python.org/dev/peps/pep-0440/#compatible-release | 22:36 |
openstackgerrit | Richard G. Pioso proposed openstack/ironic master: Place upper bound on python-dracclient version https://review.openstack.org/645364 | 22:42 |
TheJulia | gmann: I think we're going to hunt down a devstack change and backport it to stable/rocky to make that work | 22:49 |
gmann | TheJulia: ok. | 22:52 |
gmann | TheJulia: how you want to go on that, wait for backport things or proceed it with making it as n-v job ? | 22:53 |
gmann | because keeping it on xenial can introduce more issue as everything is tested on bionic now | 22:54 |
rpioso | TheJulia: It turns out that shorthand doesn't apply. | 22:55 |
rpioso | TheJulia: Earlier, I mistakenly thought the version spec was going to be >=1.5.0,<2.0.0, for which it applies. However, the version spec is >=1.5.0,<3.0.0. | 22:56 |
* rpioso looks forward to TheJulia's review feedback | 22:57 | |
*** rpioso is now known as rpioso|afk | 22:58 | |
rpioso|afk | o/ | 22:58 |
TheJulia | gmann: backport once found, my brain is not in a state where I can hunt it down right now | 23:01 |
gmann | TheJulia: ok, no worry. I will wait on that. as ironic already have cut the rc1(stable/stein) we can backport this bionic patch before final rlease. | 23:03 |
TheJulia | gmann: ironic has cut its stable release, we don't do rc's. And its just a devstack issue so no need to cut another release | 23:03 |
gmann | TheJulia: i mean this. I do not think we need to cut the release for that as this is just CI things - https://review.openstack.org/#/c/642315/ | 23:04 |
patchbot | patch 642315 - ironic - Migrate ironic-grenade-dsvm-multinode-multitenant ... - 2 patch sets | 23:04 |
gmann | so that when devstack fix is backported then, ironic stable/stein can start tested on bionic | 23:05 |
TheJulia | gmann: yup | 23:07 |
gmann | perfect, thanks TheJulia | 23:08 |
TheJulia | we already are really, just those jobs had to be pinned to bionic | 23:08 |
TheJulia | err xenial | 23:11 |
gmann | TheJulia: they are xenial currently till 642315 | 23:13 |
TheJulia | gmann: xenial for a single node | 23:14 |
TheJulia | err | 23:14 |
TheJulia | single test | 23:14 |
gmann | humm. not sure how to do for single tests, nodeset is job level var | 23:15 |
*** Lucas_Gray has joined #openstack-ironic | 23:15 | |
TheJulia | err | 23:15 |
TheJulia | single job I mean, not all of ironic's jobs | 23:15 |
gmann | ohk | 23:15 |
*** Lucas_Gray has quit IRC | 23:20 | |
gyee | TheJulia, is sushy and proliantutils fall under Ironic's jurisdiction? found a bug there | 23:32 |
TheJulia | sushy does, proliantutils is hpe's library and is officially outside of our governance | 23:33 |
gyee | k, let me file fix the sushy one first | 23:34 |
gyee | Thanks for the info | 23:34 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!