| *** sthussey has quit IRC | 00:06 | |
| *** gyee has quit IRC | 00:15 | |
| *** ajya[m] has quit IRC | 00:27 | |
| *** ajya[m] has joined #openstack-ironic | 01:20 | |
| *** dustinc has quit IRC | 01:22 | |
| *** trungnv has joined #openstack-ironic | 01:22 | |
| *** whoami-rajat has joined #openstack-ironic | 01:25 | |
| *** absubram has quit IRC | 01:33 | |
| openstackgerrit | Merged openstack/ironic master: Set boot_mode in node properties during OOB Introspection https://review.openstack.org/639698 | 02:36 |
|---|---|---|
| *** rachit7 has joined #openstack-ironic | 02:43 | |
| *** rachit7 has quit IRC | 02:50 | |
| *** zzzeek has quit IRC | 03:10 | |
| *** zzzeek has joined #openstack-ironic | 03:16 | |
| *** MattMan_ has quit IRC | 03:26 | |
| *** MattMan_ has joined #openstack-ironic | 03:26 | |
| *** dsneddon has quit IRC | 03:34 | |
| TheJulia | Looks like we have an issue in one of our unit tests. I'll try to look when I get up in the morning, but it seems like it shouldn't be too difficult to hunt down | 03:41 |
| TheJulia | http://logs.openstack.org/92/599992/13/check/openstack-tox-py36/c7142e7/testr_results.html.gz | 03:41 |
| openstackgerrit | Nisha Brahmankar proposed openstack/python-ironic-inspector-client master: Deprecates "uuid" parameters to Python calls when node is expected https://review.openstack.org/642564 | 03:48 |
| *** dsneddon has joined #openstack-ironic | 04:00 | |
| *** dsneddon has quit IRC | 04:05 | |
| *** dsneddon has joined #openstack-ironic | 04:39 | |
| *** dsneddon has quit IRC | 04:44 | |
| *** dsneddon has joined #openstack-ironic | 05:18 | |
| *** dsneddon has quit IRC | 05:23 | |
| openstackgerrit | Merged openstack/python-ironicclient master: Update master for stable/stein https://review.openstack.org/644153 | 05:55 |
| *** dsneddon has joined #openstack-ironic | 05:57 | |
| *** dsneddon has quit IRC | 06:02 | |
| *** rachit7 has joined #openstack-ironic | 06:12 | |
| *** andrein has joined #openstack-ironic | 06:20 | |
| openstackgerrit | zhufl proposed openstack/ironic master: Pass kwargs to exception to get better formatted error message https://review.openstack.org/644489 | 06:22 |
| rachit7 | Morning Ironic ;) | 06:28 |
| *** dsneddon has joined #openstack-ironic | 06:36 | |
| *** dsneddon has quit IRC | 06:41 | |
| *** boteium has quit IRC | 06:55 | |
| openstackgerrit | caoyuan proposed openstack/python-ironicclient master: Update json module to jsonutils https://review.openstack.org/638980 | 07:04 |
| openstackgerrit | caoyuan proposed openstack/python-ironicclient master: Update json module to jsonutils https://review.openstack.org/638980 | 07:07 |
| *** dsneddon has joined #openstack-ironic | 07:13 | |
| *** pcaruana has joined #openstack-ironic | 07:14 | |
| *** dsneddon has quit IRC | 07:18 | |
| *** pcaruana has quit IRC | 07:33 | |
| *** pcaruana has joined #openstack-ironic | 07:34 | |
| arne_wiebalck | good morning, ironic | 07:35 |
| *** dsneddon has joined #openstack-ironic | 07:50 | |
| *** dsneddon has quit IRC | 07:55 | |
| rpittau|afk | good morning ironic! o/ | 07:56 |
| *** rpittau|afk is now known as rpittau | 07:56 | |
| *** zzzeek has quit IRC | 08:00 | |
| *** jtomasek has joined #openstack-ironic | 08:01 | |
| *** zzzeek has joined #openstack-ironic | 08:02 | |
| openstackgerrit | Nisha Brahmankar proposed openstack/python-ironic-inspector-client master: Deprecates "uuid" parameters to Python calls when node is expected https://review.openstack.org/642564 | 08:11 |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic master: Adds config option to iLO driver to pass IPA params https://review.openstack.org/643848 | 08:12 |
| *** dtantsur|afk is now known as dtantsur | 08:18 | |
| dtantsur | morning ironic | 08:18 |
| rpittau | hi dtantsur :) | 08:19 |
| *** tssurya has joined #openstack-ironic | 08:19 | |
| *** dsneddon has joined #openstack-ironic | 08:23 | |
| *** stendulker has joined #openstack-ironic | 08:23 | |
| *** andrein has quit IRC | 08:25 | |
| *** e0ne has joined #openstack-ironic | 08:25 | |
| *** dsneddon has quit IRC | 08:27 | |
| *** sburette has joined #openstack-ironic | 08:32 | |
| *** priteau has joined #openstack-ironic | 08:38 | |
| openstackgerrit | Merged openstack/python-ironic-inspector-client master: Update master for stable/stein https://review.openstack.org/644150 | 08:50 |
| *** iurygregory has joined #openstack-ironic | 08:52 | |
| iurygregory | good morning | 08:53 |
| rpittau | hi iurygregory :) | 08:55 |
| stendulker | Good morning rpittau, iurygregory :) | 08:56 |
| rpittau | hi stendulker :) | 08:57 |
| *** lucasagomes has joined #openstack-ironic | 08:57 | |
| *** dsneddon has joined #openstack-ironic | 08:57 | |
| iurygregory | morning rpittau and stendulker | 09:00 |
| *** dougsz has joined #openstack-ironic | 09:03 | |
| *** dsneddon has quit IRC | 09:05 | |
| *** andrein has joined #openstack-ironic | 09:09 | |
| *** S4ren has joined #openstack-ironic | 09:13 | |
| *** Lucas_Gray has joined #openstack-ironic | 09:33 | |
| *** dsneddon has joined #openstack-ironic | 09:35 | |
| *** Wryhder has joined #openstack-ironic | 09:37 | |
| *** Lucas_Gray has quit IRC | 09:39 | |
| *** Wryhder is now known as Lucas_Gray | 09:39 | |
| *** dsneddon has quit IRC | 09:40 | |
| *** derekh has joined #openstack-ironic | 09:40 | |
| * etingof is puzzled by the mysteriously failing CI | 09:41 | |
| rpittau | etingof, too generic xD | 09:42 |
| etingof | rpittau, this patch does not seemingly change much, but it breaks half of the jobs -- https://review.openstack.org/#/c/637971/ | 09:44 |
| patchbot | patch 637971 - ironic - Explicitly start `vbmcd` supervisor - 6 patch sets | 09:44 |
| rpittau | TheJulia, I was trying to reproduce the issues on the unit tests in https://review.openstack.org/599992 with py27 and py36 but couldn't :/ | 09:44 |
| patchbot | patch 599992 - ironic - Support firmware upgrade for irmc driver - 13 patch sets | 09:44 |
| etingof | mostly on IPMI timeouts | 09:44 |
| rpittau | etingof, oh wow | 09:44 |
| etingof | in devstack log the changes work as expected, no failures. but eventually the whole thing fails on occasional ipmi timeout | 09:45 |
| etingof | and "it worked in devstack", obviously | 09:46 |
| rpittau | etingof, of course :/ | 09:46 |
| rpittau | I blame bionic | 09:46 |
| openstackgerrit | Nisha Brahmankar proposed openstack/python-ironic-inspector-client master: Deprecates "uuid" parameters to Python calls when node is expected https://review.openstack.org/642564 | 09:46 |
| * etingof if firing up ironic@bionic | 09:47 | |
| openstackgerrit | Merged openstack/python-ironic-inspector-client stable/stein: Update .gitreview for stable/stein https://review.openstack.org/644148 | 09:48 |
| iurygregory | better blame bionic than DevStack | 09:54 |
| *** e0ne has quit IRC | 09:56 | |
| *** diga has joined #openstack-ironic | 09:57 | |
| diga | arne_wiebalck: Hi | 09:58 |
| arne_wiebalck | diga: o/ | 09:59 |
| openstackgerrit | Riccardo Pittau proposed openstack/ironic master: Add release note on postgres job issue on bionic https://review.openstack.org/644529 | 09:59 |
| *** dustinc has joined #openstack-ironic | 10:03 | |
| *** Lucas_Gray has quit IRC | 10:04 | |
| diga | arne_wiebalck: about yesterday's comment | 10:04 |
| openstackgerrit | Merged openstack/ironic master: Pass kwargs to exception to get better formatted error message https://review.openstack.org/644489 | 10:04 |
| diga | arne_wiebalck: https://review.openstack.org/#/c/634903/7/ironic/tests/unit/drivers/modules/drac/test_raid.py | 10:04 |
| patchbot | patch 634903 - ironic - Modify the iDRAC driver to use realtime RAID creation - 7 patch sets | 10:04 |
| diga | arne_wiebalck: do you want me to handle mock_create_virtual_disk() calls in expected call list ? | 10:08 |
| *** Lucas_Gray has joined #openstack-ironic | 10:09 | |
| *** dsneddon has joined #openstack-ironic | 10:12 | |
| arne_wiebalck | diga: We're talking about the test Dao was commenting on? | 10:14 |
| diga | arne_wiebalck: yes | 10:14 |
| diga | arne_wiebalck: what's causing there I am not sure, because it's passing all the test | 10:15 |
| diga | arne_wiebalck: Can you please let me know so that I can fix | 10:15 |
| arne_wiebalck | diga: I think we (or at least I) need to understand what this test is supposed to test. | 10:15 |
| diga | arne_wiebalck: okay | 10:15 |
| arne_wiebalck | diga: I think the worry is that the test is passing since it does not test anything :) | 10:16 |
| arne_wiebalck | diga: So, what is the test supposed to test and where does it do that? | 10:16 |
| diga | arne_wiebalck: okay | 10:16 |
| arne_wiebalck | diga: The test was there before your patch, no? | 10:17 |
| *** dsneddon has quit IRC | 10:17 | |
| diga | arne_wiebalck: controller_cap = create_virtual_disk() | 10:17 |
| diga | arne_wiebalck: here in raid.py, create_virtual_disk() return the controllers | 10:17 |
| diga | arne_wiebalck: so it catches the raid_controllers and its realtime supported value | 10:19 |
| *** andrein has quit IRC | 10:19 | |
| *** andrein has joined #openstack-ironic | 10:20 | |
| arne_wiebalck | diga: create_virtual_disk is a mocked function, so I don't think this is executed | 10:22 |
| diga | arne_wiebalck: okay | 10:23 |
| arne_wiebalck | diga: from my understanding, you use mock to set up a controlled env to test the thing you'd like to test in a specific function | 10:24 |
| diga | okay | 10:24 |
| arne_wiebalck | diga: what the test does is basically check the arguments you have just passed in | 10:25 |
| diga | arne_wiebalck: ohh.. ok | 10:26 |
| diga | I will look at it | 10:27 |
| diga | arne_wiebalck: unit tests are always painful for me :) | 10:28 |
| arne_wiebalck | diga: I think you should think about what the test should test, and then set up the env correspondingly (with mock) | 10:28 |
| arne_wiebalck | diga: they are quite useful they are done :) | 10:28 |
| diga | arne_wiebalck: okay | 10:28 |
| diga | arne_wiebalck: yes | 10:28 |
| arne_wiebalck | diga: the test was there before your patch? | 10:28 |
| arne_wiebalck | diga: and you just extended it (or is this your test)? | 10:29 |
| diga | arne_wiebalck: yes | 10:29 |
| diga | arne_wiebalck: no, it exists there before my patchset | 10:29 |
| arne_wiebalck | diga: hmm, ok | 10:29 |
| diga | arne_wiebalck: I need to look at earlier code for this test | 10:29 |
| * arne_wiebalck is looking at the original test | 10:30 | |
| arne_wiebalck | diga: I don't see what the original test tested either | 10:31 |
| arne_wiebalck | diga: ah, no, wait | 10:32 |
| arne_wiebalck | diga: the original test seems ok: it creates a config and verifies that the code calls create_virtual_disk | 10:33 |
| arne_wiebalck | diga: that seems ok | 10:33 |
| arne_wiebalck | diga: ok, so here's the thing | 10:33 |
| arne_wiebalck | diga: the original test called create_config and verified that it would call create_virtual_disk with the correct parameters | 10:34 |
| arne_wiebalck | diga: your test calls create_config as well, but calls the mocked create_virtual_disk function itself | 10:35 |
| arne_wiebalck | diga: your test should check create_config triggered the corresponding call(s) | 10:35 |
| arne_wiebalck | diga: see what I mean? | 10:36 |
| diga | arne_wiebalck: okay | 10:37 |
| diga | arne_wiebalck: I got your point | 10:38 |
| diga | arne_wiebalck: will go through it old test case and update the changes accordingly | 10:38 |
| arne_wiebalck | diga: Sounds good, thanks! | 10:39 |
| diga | arne_wiebalck: thanks for your help! | 10:39 |
| arne_wiebalck | diga: yw | 10:39 |
| *** derekh has quit IRC | 10:45 | |
| *** hrw has joined #openstack-ironic | 10:45 | |
| hrw | hi bifrost people | 10:45 |
| hrw | or is it a bug in bifrost documentation to go here? | 10:46 |
| *** derekh has joined #openstack-ironic | 10:48 | |
| *** e0ne has joined #openstack-ironic | 10:50 | |
| *** dsneddon has joined #openstack-ironic | 10:52 | |
| dtantsur | hi hrw, this is the channel for bifrost, yes | 10:55 |
| hrw | dtantsur: cool. | 10:56 |
| hrw | trying to understand http://logs.openstack.org/75/642375/12/check/kolla-build-ubuntu-source/fe53e47/logs/build/000_FAILED_bifrost-base.txt.gz failure. | 10:56 |
| hrw | we want to move Kolla images to Python 3 and bifrost is the last issue to fix ;D | 10:57 |
| hrw | (hope) | 10:57 |
| *** diga has quit IRC | 10:57 | |
| dtantsur | mgoddard: any ideas ^^^? | 10:58 |
| *** dsneddon has quit IRC | 10:58 | |
| dtantsur | hrw: it looks like you ended up with a mix of python 2 and 3, and with the venv python used instead of the system one | 10:58 |
| hrw | dtantsur: image has py3, bifrost fetched py2 | 10:59 |
| hrw | so yeah, pyMix | 10:59 |
| dtantsur | it's even funnier, we run 'apt-get' essentially in a venv | 11:00 |
| dtantsur | which is never a good idea | 11:00 |
| hrw | dtantsur: I would say that building bifrost in a (kolla) container looks like wrong idea | 11:02 |
| openstackgerrit | Riccardo Pittau proposed openstack/ironic master: [DNM] Testing postgres job with ubuntu bionic https://review.openstack.org/644540 | 11:03 |
| openstackgerrit | Dmitry Tantsur proposed openstack/bifrost master: Do not install distro packages with a VENV activated https://review.openstack.org/644541 | 11:04 |
| dtantsur | hrw: maybe ^^^ | 11:04 |
| dtantsur | TheJulia: ^^^ | 11:04 |
| hrw | dtantsur: thx | 11:04 |
| dtantsur | hrw: can you try depending on this patch and seeing where it brings you? | 11:04 |
| hrw | sure | 11:04 |
| dtantsur | I think we still end up using Python 2 for VENV, but at least you won't be broken | 11:04 |
| * dtantsur brb | 11:06 | |
| *** stendulker has quit IRC | 11:08 | |
| *** priteau has quit IRC | 11:08 | |
| openstackgerrit | Arne Wiebalck proposed openstack/ironic master: Software RAID: Trigger grub installation on the holder disks https://review.openstack.org/640810 | 11:11 |
| openstackgerrit | Arne Wiebalck proposed openstack/ironic-python-agent master: Software RAID: Add IPA deploy support https://review.openstack.org/639390 | 11:12 |
| hrw | dtantsur: in progress | 11:12 |
| openstackgerrit | Arne Wiebalck proposed openstack/ironic-python-agent master: Software RAID: Create/delete configurations https://review.openstack.org/634681 | 11:14 |
| openstackgerrit | Arne Wiebalck proposed openstack/ironic-python-agent master: Software RAID: Add IPA deploy support https://review.openstack.org/639390 | 11:15 |
| hrw | dtantsur: passed. then failed on UcsSdk as it is py2 only | 11:19 |
| hrw | removed it from file and retrying now | 11:21 |
| *** rcernin has quit IRC | 11:24 | |
| hrw | 127.0.0.1 : ok=42 changed=13 unreachable=0 failed=0 | 11:27 |
| openstackgerrit | Riccardo Pittau proposed openstack/ironic master: [DNM] Testing postgres job with ubuntu bionic https://review.openstack.org/644540 | 11:28 |
| *** dsneddon has joined #openstack-ironic | 11:33 | |
| *** Wryhder has joined #openstack-ironic | 11:34 | |
| *** Lucas_Gray has quit IRC | 11:34 | |
| *** Wryhder is now known as Lucas_Gray | 11:35 | |
| *** dsneddon has quit IRC | 11:37 | |
| *** adrianc has quit IRC | 11:41 | |
| openstackgerrit | Marcin Juszkiewicz proposed openstack/bifrost master: bifrost-ironic-install: drop UcsSdk as it is Python 2 only https://review.openstack.org/644549 | 11:42 |
| hrw | rpittau: thanks :) | 11:43 |
| *** mbeierl has quit IRC | 11:50 | |
| rpittau | hrw: np | 11:56 |
| *** rh-jelabarre has joined #openstack-ironic | 12:05 | |
| *** dsneddon has joined #openstack-ironic | 12:09 | |
| *** adrianc has joined #openstack-ironic | 12:10 | |
| *** bfournie has joined #openstack-ironic | 12:12 | |
| *** dsneddon has quit IRC | 12:14 | |
| S4ren | Good afternoon all, I would like to run ironic-ui locally just to poke around a little bit, what would be the best way of doing that? Devstack? | 12:17 |
| *** dustinc has quit IRC | 12:20 | |
| dtantsur | S4ren: likely yes. I'm not sure if we have docs for it though.. | 12:21 |
| S4ren | I will have a dig around, thanks dtantsur | 12:24 |
| *** adrianc has quit IRC | 12:24 | |
| *** adrianc has joined #openstack-ironic | 12:36 | |
| *** trown|outtypewww is now known as trown | 12:38 | |
| *** dsneddon has joined #openstack-ironic | 12:46 | |
| *** dsneddon has quit IRC | 12:51 | |
| *** adrianc has quit IRC | 12:51 | |
| openstackgerrit | Marcin Juszkiewicz proposed openstack/bifrost master: bifrost-ironic-install: drop UcsSdk as it is Python 2 only https://review.openstack.org/644549 | 12:55 |
| hrw | added releasenote | 12:55 |
| *** baha has joined #openstack-ironic | 12:57 | |
| *** adrianc has joined #openstack-ironic | 12:59 | |
| dtantsur | thnx! | 12:59 |
| dtantsur | TheJulia: FYI ^^^ | 12:59 |
| hrw | getting familiar with random openstack projects due to that py3 work... | 13:01 |
| *** mbeierl has joined #openstack-ironic | 13:05 | |
| dtantsur | profit! :D | 13:09 |
| hrw | dtantsur: so far, to make kolla py3, I patched vmtp, ironic, karbur, kuryr, monasca (twice) and bifrost. | 13:13 |
| hrw | and nova | 13:13 |
| dtantsur | funny life of an integration project :) | 13:14 |
| hrw | yep | 13:14 |
| iurygregory | i bet monasca was funny XD | 13:14 |
| hrw | iurygregory: utf-8 -> us-ascii change. | 13:15 |
| iurygregory | hrw, ahh no headaches XD | 13:15 |
| * dtantsur ponders having a python 3 job for bifrost | 13:15 | |
| *** rachit7 has quit IRC | 13:16 | |
| * rpittau ^^^ +2 | 13:16 | |
| hrw | pep8 requires devs to use utf-8 for source (py3 - us-ascii allowed for py2). but all PKG-INFO etc need to be us-ascii ;( | 13:16 |
| hrw | dtantsur: good! | 13:16 |
| dtantsur | fun | 13:16 |
| iurygregory | hrw, at least is python, i used monasca when was in java... what a pain | 13:17 |
| hrw | dtantsur: remember that Train cycle is more-or-less 'goodbye py2' cycle | 13:17 |
| * rpittau can | 13:17 | |
| dtantsur | hrw: officially, U cycle | 13:17 |
| rpittau | rmrrrr small keyboard.... | 13:17 |
| dtantsur | hrw: btw, if you have a voting job with bifrost on kolla, you may consider adding it as a non-voting (at least for now) job to bifrost | 13:17 |
| hrw | dtantsur: let me rephrase then | 13:18 |
| hrw | dtantsur: Stein for 'maybe py3', Train for 'go py3, may forget py2', Ucycle for 'what is py2' | 13:18 |
| dtantsur | right :D | 13:18 |
| *** tssurya has quit IRC | 13:18 | |
| rpittau | hrw you can add a python version check registering a custom variable based on 'python --version' output for this -> https://review.openstack.org/644549 | 13:19 |
| patchbot | patch 644549 - bifrost - bifrost-ironic-install: drop UcsSdk as it is Pytho... - 2 patch sets | 13:19 |
| hrw | dtantsur: to be honest? when I see CI fail due to bifrost I just move to other task with hope that next day 'recheck' will work better | 13:20 |
| dtantsur | :) | 13:21 |
| hrw | dtantsur: in Kolla we rely on far to many things to work | 13:21 |
| dtantsur | I can imagine. It's the same (or even worse) for TripleO. | 13:21 |
| hrw | dtantsur: recent 'unbreak kolla CI' patch was 6-in-1 if not more | 13:21 |
| hrw | debian/ubuntu changed packaging for qemu, some images needed to get py3, oraclelinux image changed repo config files... and all bcause xenial->bionic CI change ;D | 13:23 |
| dtantsur | oh yeah. we still need to move 3 (?) jobs to bionic. | 13:24 |
| *** dsneddon has joined #openstack-ironic | 13:24 | |
| hrw | dtantsur: check first. freeze for release... | 13:25 |
| *** sthussey has joined #openstack-ironic | 13:26 | |
| openstackgerrit | Merged openstack/ironic master: Update doc for UEFI first https://review.openstack.org/631225 | 13:27 |
| hrw | rpittau: when: skip_install is not defined and ansible_python.version.major|int == 3 | 13:28 |
| hrw | s/3/2 | 13:29 |
| *** dsneddon has quit IRC | 13:29 | |
| TheJulia | good morning everyone | 13:29 |
| rpittau | hrw, yeah something like that should work | 13:29 |
| rpittau | hey TheJulia :) | 13:29 |
| hrw | hi TheJulia | 13:29 |
| rpittau | hrw, if we really feel like we're going to terribly miss ucssdk :) | 13:30 |
| TheJulia | no, not really | 13:30 |
| rpittau | lol exactly | 13:31 |
| hrw | anyway new thing learnt and stored in browser history ;D | 13:31 |
| iurygregory | good morning TheJulia | 13:32 |
| openstackgerrit | Riccardo Pittau proposed openstack/ironic master: [DNM] Testing postgres job with ubuntu bionic https://review.openstack.org/644540 | 13:33 |
| dtantsur | morning TheJulia | 13:35 |
| * TheJulia tries to wipe sleep from eyes | 13:41 | |
| dtantsur | impossible today | 13:46 |
| TheJulia | ugh | 13:47 |
| TheJulia | rpittau: looks like dtantsur and I had the same feedback on https://review.openstack.org/#/c/644529 | 13:47 |
| patchbot | patch 644529 - ironic - Add release note on postgres job issue on bionic - 1 patch set | 13:47 |
| rpittau | TheJulia, dtantsur, yep, I'm rewriting the reno | 13:48 |
| dtantsur | TheJulia: in case you haven't seen spam in your inbox, I've requested releases and stable/stein for set(ironic.projects) - {'ironic'} | 13:49 |
| TheJulia | dtantsur: thanks... lets hold on bifrost, I see an issue with one of the changes | 13:50 |
| TheJulia | or it could always be train | 13:50 |
| dtantsur | TheJulia: yeah, and excluding bifrost as well | 13:51 |
| * TheJulia wonders why her phone is vibrating as if she is being messaged about once a minute | 13:52 | |
| dtantsur | did you try turning it off? | 13:53 |
| dtantsur | :) | 13:53 |
| openstackgerrit | Riccardo Pittau proposed openstack/ironic master: Add release note on postgres job issue on bionic https://review.openstack.org/644529 | 13:54 |
| *** whoami-rajat has quit IRC | 13:55 | |
| openstackgerrit | Julia Kreger proposed openstack/bifrost master: Remove UCS configuration https://review.openstack.org/644577 | 13:55 |
| TheJulia | dtantsur: no, I'm ignoring it at present | 13:55 |
| TheJulia | Did anyone find out why our unit tests seem to be behaving very oddly in https://review.openstack.org/599992 ? | 13:57 |
| patchbot | patch 599992 - ironic - Support firmware upgrade for irmc driver - 13 patch sets | 13:57 |
| rpittau | TheJulia, I was looking at that but can't reproduce :/ | 13:58 |
| openstackgerrit | Julia Kreger proposed openstack/ironic master: Update release-mappings and api version data for Stein release https://review.openstack.org/644233 | 13:59 |
| TheJulia | dtantsur: ^^^ | 13:59 |
| dtantsur | thnx, will check after some exercising | 14:02 |
| *** dsneddon has joined #openstack-ironic | 14:04 | |
| TheJulia | ++ | 14:05 |
| TheJulia | rpittau: I just reproduced it locally | 14:05 |
| rpittau | TheJulia, lol, I tried with py36 and py27 on ubuntu and fedora xD | 14:05 |
| *** mjturek has joined #openstack-ironic | 14:07 | |
| openstackgerrit | Merged openstack/bifrost master: bifrost-ironic-install: drop UcsSdk as it is Python 2 only https://review.openstack.org/644549 | 14:08 |
| *** dsneddon has quit IRC | 14:08 | |
| openstackgerrit | Merged openstack/bifrost master: Do not install distro packages with a VENV activated https://review.openstack.org/644541 | 14:13 |
| openstackgerrit | Riccardo Pittau proposed openstack/ironic master: [DNM] Testing postgres job with ubuntu bionic https://review.openstack.org/644540 | 14:14 |
| TheJulia | rpittau: I think it was pure chance.... I think I see the issue in the mocking, so trying to fix that | 14:15 |
| * rpittau thinks mock mocks him | 14:16 | |
| TheJulia | mock mocks the mocking of mock for us all to mock mock | 14:16 |
| * TheJulia hopes that works | 14:16 | |
| TheJulia | hmm... still got an exception although different I think... | 14:17 |
| * TheJulia awaits | 14:17 | |
| hrw | thanks for fixes! | 14:22 |
| TheJulia | rpittau: I'm hitting it like 50% of the time. I think I've got it though | 14:25 |
| rpittau | I'm very curious now | 14:26 |
| TheJulia | basically we were passing data to exceptions in the test wrong | 14:27 |
| TheJulia | and I think just doing py35, I've managed to hit it enough to fix it. Likely a race in the test class with other uses of the exceptions being returned since that has historically where I think we've seen weirdness in unit testing. | 14:28 |
| *** hrw has left #openstack-ironic | 14:28 | |
| TheJulia | testsing my fix on py27 and 36 now | 14:30 |
| rpittau | ah ok, same issue in test_validate_interface_mismatch I guess ? | 14:31 |
| TheJulia | got a link, because I don't think I've seen that one in this | 14:32 |
| rpittau | http://logs.openstack.org/92/599992/13/check/ironic-tox-unit-with-driver-libs/8b0a5d5/ara-report/result/43f92560-87e5-4cbc-83b5-f0f2d8f441c8/ | 14:33 |
| rpittau | or better http://logs.openstack.org/92/599992/13/check/ironic-tox-unit-with-driver-libs/8b0a5d5/job-output.txt.gz#_2019-03-18_23_27_33_860961 | 14:33 |
| TheJulia | oh yeah, same fix I think | 14:34 |
| *** dustinc has joined #openstack-ironic | 14:36 | |
| *** adrianc has quit IRC | 14:36 | |
| *** adrianc has joined #openstack-ironic | 14:39 | |
| TheJulia | rpittau: I can't reproduce that one _but_ I see the problem | 14:43 |
| *** dsneddon has joined #openstack-ironic | 14:43 | |
| *** dsneddon has quit IRC | 14:48 | |
| openstackgerrit | Julia Kreger proposed openstack/ironic master: Fix exception generation errors https://review.openstack.org/644590 | 14:53 |
| TheJulia | rpittau: ^^^ | 14:53 |
| rpittau | ah interesting | 14:57 |
| TheJulia | found three more instances | 14:59 |
| rpittau | yep, I was going to say most likely there's more | 14:59 |
| *** adrianc has quit IRC | 15:02 | |
| openstackgerrit | Julia Kreger proposed openstack/ironic master: Fix exception generation errors https://review.openstack.org/644590 | 15:07 |
| TheJulia | okay, found and fixed a few more | 15:07 |
| *** adrianc has joined #openstack-ironic | 15:08 | |
| rpittau | I think I have a workaround for postgres on bionic -> https://review.openstack.org/644540 | 15:11 |
| patchbot | patch 644540 - ironic - [DNM] Testing postgres job with ubuntu bionic - 4 patch sets | 15:11 |
| TheJulia | rpittau: that is a solid workaround :) | 15:13 |
| *** rachit7 has joined #openstack-ironic | 15:19 | |
| *** dsneddon has joined #openstack-ironic | 15:21 | |
| *** whoami-rajat has joined #openstack-ironic | 15:22 | |
| openstackgerrit | Riccardo Pittau proposed openstack/ironic master: Workaround for postgres job with ubuntu bionic https://review.openstack.org/644540 | 15:23 |
| rpittau | ehm yeah maybe I should put all the other jobs back? | 15:23 |
| *** adrianc has quit IRC | 15:24 | |
| openstackgerrit | Riccardo Pittau proposed openstack/ironic master: Workaround for postgres job with ubuntu bionic https://review.openstack.org/644540 | 15:25 |
| openstackgerrit | Riccardo Pittau proposed openstack/ironic master: Workaround for postgres job with ubuntu bionic https://review.openstack.org/644540 | 15:26 |
| *** dsneddon has quit IRC | 15:26 | |
| *** adrianc has joined #openstack-ironic | 15:27 | |
| TheJulia | :) | 15:35 |
| TheJulia | easy review for any cores https://review.openstack.org/#/c/644233/ | 15:37 |
| patchbot | patch 644233 - ironic - Update release-mappings and api version data for S... - 3 patch sets | 15:37 |
| *** dsneddon has joined #openstack-ironic | 15:45 | |
| openstackgerrit | Riccardo Pittau proposed openstack/ironic master: Add release note on conntrack issue on bionic https://review.openstack.org/644529 | 15:46 |
| *** hamzy has quit IRC | 15:55 | |
| rpioso | Good morning, ironicers | 15:55 |
| rpittau | hey rpioso :) | 15:56 |
| iurygregory | morning rpioso | 15:56 |
| rpioso | iurygregory, rpittau: o/ | 15:57 |
| NobodyCam | Good Morning Ironic'ers | 16:02 |
| TheJulia | Good morning | 16:04 |
| dtantsur | morning NobodyCam, rpioso | 16:06 |
| rpittau | hey NobodyCam :) | 16:06 |
| NobodyCam | good morning TheJulia dtantsur and rpittau :) | 16:06 |
| rpioso | dtantsur: Hey | 16:07 |
| *** trown is now known as trown|lunch | 16:13 | |
| etingof | iurygregory, speaking of sushy and py3 - do we need gunicorn3 as well? -- http://logs.openstack.org/28/591828/4/check/sushy-tempest-ironic-partition-redfish-src/31f7267/controller/logs/devstacklog.txt.gz#_2019-03-12_09_31_56_137 | 16:15 |
| iurygregory | etingof, maybe XD | 16:16 |
| * etingof is trying it out | 16:16 | |
| iurygregory | if you are saying i belive you are the sushy master \o/ | 16:17 |
| *** hamzy has joined #openstack-ironic | 16:18 | |
| *** Lucas_Gray has quit IRC | 16:22 | |
| *** baha has quit IRC | 16:29 | |
| *** e0ne has quit IRC | 16:32 | |
| openstackgerrit | Richard G. Pioso proposed openstack/ironic master: Advance python-dracclient version requirement https://review.openstack.org/643716 | 16:41 |
| *** dsneddon has quit IRC | 16:48 | |
| kandi | hi :) | 16:53 |
| * rpioso sprints away from driver-requirements.txt | 16:53 | |
| *** rpioso is now known as rpioso|afk | 16:54 | |
| * dtantsur declares beer'o'clock | 16:55 | |
| *** dtantsur is now known as dtantsur|afk | 16:56 | |
| *** baha has joined #openstack-ironic | 17:08 | |
| *** Chaserjim has joined #openstack-ironic | 17:08 | |
| *** sburette has quit IRC | 17:09 | |
| *** mbeierl has quit IRC | 17:10 | |
| rpittau | good night! o/ | 17:10 |
| *** rpittau is now known as rpittau|afk | 17:10 | |
| *** jaypipes has joined #openstack-ironic | 17:16 | |
| *** anupn has joined #openstack-ironic | 17:18 | |
| *** andrein has quit IRC | 17:22 | |
| *** dsneddon has joined #openstack-ironic | 17:23 | |
| *** gyee has joined #openstack-ironic | 17:24 | |
| *** priteau has joined #openstack-ironic | 17:25 | |
| arne_wiebalck | bye everyone! | 17:35 |
| openstackgerrit | Julia Kreger proposed openstack/ironic master: Fix exception generation errors https://review.openstack.org/644590 | 17:38 |
| TheJulia | o/ | 17:39 |
| *** trown|lunch is now known as trown | 17:43 | |
| openstackgerrit | Merged openstack/ironic master: Optimize: HUAWEI iBMC driver utils https://review.openstack.org/643870 | 17:51 |
| *** dougsz has quit IRC | 17:57 | |
| openstackgerrit | Ilya Etingof proposed openstack/ironic master: Respect $USE_PYTHON3 settings for gunicorn https://review.openstack.org/644622 | 17:59 |
| *** andrein has joined #openstack-ironic | 18:00 | |
| *** derekh has quit IRC | 18:00 | |
| *** S4ren has quit IRC | 18:03 | |
| openstackgerrit | Ilya Etingof proposed openstack/ironic master: Respect $USE_PYTHON3 settings for gunicorn https://review.openstack.org/644622 | 18:04 |
| ajya[m] | Hi, etingof dtantsur|afk can you take a final look at https://review.openstack.org/#/c/589837/ and the following 2 patches when you have a chance? They were close to merging but run into merge conflict. Hope they don't end in another conflict again :) | 18:05 |
| patchbot | patch 589837 - sushy - Add support for loading packaged standard registries - 8 patch sets | 18:05 |
| *** priteau has quit IRC | 18:07 | |
| *** andrein has quit IRC | 18:14 | |
| *** anupn has quit IRC | 18:23 | |
| openstackgerrit | Julia Kreger proposed openstack/ironic master: Fix exception generation errors https://review.openstack.org/644590 | 18:54 |
| *** andrein has joined #openstack-ironic | 19:00 | |
| *** mbeierl has joined #openstack-ironic | 19:27 | |
| *** e0ne has joined #openstack-ironic | 19:28 | |
| *** rachit7 has quit IRC | 19:47 | |
| *** e0ne has quit IRC | 19:51 | |
| dustinc | TheJulia, dtantsur: Working with efried on using SDK in nova to talk to Ironic instead of client. I was noticing that the client wrapper in nova retries on pretty much everything and as far as I can tell the SDK does not. | 19:51 |
| dustinc | It is looking like maybe the IronicClientWrapper will need to be replaced with something like IronicSDKWrapper | 19:52 |
| dustinc | Does that make sense, or can anyone thing of an easier/cleaner way to do that? | 19:52 |
| dustinc | or maybe I am just missing something, I am very new to OS so pardon my ignorance :) | 19:54 |
| openstackgerrit | OpenStack Release Bot proposed openstack/networking-generic-switch stable/stein: Update .gitreview for stable/stein https://review.openstack.org/644656 | 20:00 |
| openstackgerrit | OpenStack Release Bot proposed openstack/networking-generic-switch stable/stein: Update UPPER_CONSTRAINTS_FILE for stable/stein https://review.openstack.org/644657 | 20:00 |
| openstackgerrit | OpenStack Release Bot proposed openstack/networking-generic-switch master: Update master for stable/stein https://review.openstack.org/644658 | 20:00 |
| openstackgerrit | OpenStack Release Bot proposed openstack/networking-baremetal stable/stein: Update .gitreview for stable/stein https://review.openstack.org/644659 | 20:02 |
| openstackgerrit | OpenStack Release Bot proposed openstack/networking-baremetal stable/stein: Update UPPER_CONSTRAINTS_FILE for stable/stein https://review.openstack.org/644660 | 20:02 |
| openstackgerrit | OpenStack Release Bot proposed openstack/networking-baremetal master: Update master for stable/stein https://review.openstack.org/644661 | 20:02 |
| *** dustinc is now known as dustinc|afk | 20:09 | |
| *** trown is now known as trown|outtypewww | 20:14 | |
| *** Lucas_Gray has joined #openstack-ironic | 20:15 | |
| *** e0ne has joined #openstack-ironic | 20:41 | |
| *** mjturek has quit IRC | 20:45 | |
| *** e0ne has quit IRC | 20:46 | |
| *** hamzy has quit IRC | 20:46 | |
| *** baha has quit IRC | 21:04 | |
| *** priteau has joined #openstack-ironic | 21:07 | |
| *** dustinc|afk is now known as dustinc | 21:21 | |
| *** rh-jelabarre has quit IRC | 21:31 | |
| *** whoami-rajat has quit IRC | 21:52 | |
| openstackgerrit | Julia Kreger proposed openstack/ironic master: Fix exception generation errors https://review.openstack.org/644590 | 21:53 |
| *** bfournie has quit IRC | 22:02 | |
| *** pcaruana has quit IRC | 22:08 | |
| *** Lucas_Gray has quit IRC | 22:12 | |
| TheJulia | dustinc: retries would largely be because of write ops where we don't allow the data to be updated on the node object with a running lock in the background... and some of those locks are longish things | 22:16 |
| *** rcernin has joined #openstack-ironic | 22:16 | |
| *** etingof has quit IRC | 22:35 | |
| *** bfournie has joined #openstack-ironic | 22:38 | |
| efried | TheJulia: Turns out the SDK is already handling retries for us \o/ | 22:50 |
| *** priteau has quit IRC | 22:54 | |
| *** yaawang has quit IRC | 23:17 | |
| *** yaawang has joined #openstack-ironic | 23:18 | |
| *** andrein has quit IRC | 23:25 | |
| TheJulia | efried: \o/ | 23:29 |
| openstackgerrit | Julia Kreger proposed openstack/ironic master: Fix exception generation errors https://review.openstack.org/644590 | 23:34 |
| *** penick has joined #openstack-ironic | 23:55 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!