Tuesday, 2018-08-14

*** rcernin_ has joined #openstack-ironic00:02
*** rcernin has quit IRC00:03
*** mjturek has quit IRC00:12
*** mbeierl has joined #openstack-ironic00:15
*** namnh has quit IRC00:17
*** rcernin has joined #openstack-ironic00:29
*** rcernin has quit IRC00:29
*** rcernin has joined #openstack-ironic00:30
*** rcernin_ has quit IRC00:32
*** rh-jelabarre has quit IRC00:57
*** marlinc has quit IRC00:57
*** ddurst has quit IRC00:57
*** gmann has quit IRC00:57
*** lennyb has quit IRC00:57
*** rh-jelabarre has joined #openstack-ironic00:59
*** namnh has joined #openstack-ironic00:59
*** marlinc has joined #openstack-ironic01:04
*** ddurst has joined #openstack-ironic01:04
*** gmann has joined #openstack-ironic01:04
*** namnh has quit IRC01:04
*** openstackgerrit has quit IRC01:06
*** openstackgerrit has joined #openstack-ironic01:20
openstackgerritRuby Loo proposed openstack/ironic master: Disable periodic tasks if interval set to 0  https://review.openstack.org/56916601:20
*** phuongnh has joined #openstack-ironic01:23
*** rloo has quit IRC01:31
*** namnh has joined #openstack-ironic01:44
*** jiapei has joined #openstack-ironic01:49
openstackgerrityuan liang proposed openstack/ironic-python-agent master: Parallel erase disk devices  https://review.openstack.org/34672301:54
*** markguz_ has joined #openstack-ironic02:19
*** rh-jelabarre has quit IRC02:30
*** Bhujay has joined #openstack-ironic03:04
*** markguz_ has quit IRC03:05
openstackgerrityuan liang proposed openstack/ironic-python-agent master: Parallel erase disk devices  https://review.openstack.org/34672303:25
*** Bhujay has quit IRC03:40
*** namnh has quit IRC03:40
*** jiapei has quit IRC03:59
*** Bhujay has joined #openstack-ironic04:21
*** gyee has quit IRC05:05
*** yolanda has quit IRC05:25
openstackgerritKaifeng Wang proposed openstack/ironic master: Prevents deletion of ports for active nodes  https://review.openstack.org/47027305:58
*** yolanda has joined #openstack-ironic06:17
*** phuongnh has quit IRC06:29
*** pcaruana has joined #openstack-ironic06:44
openstackgerrityolanda.robla proposed openstack/ironic master: Add functionality for individual cleanup on nodes  https://review.openstack.org/58627706:50
openstackgerritKaifeng Wang proposed openstack/ironic-inspector master: Multiple backends for introspection data: database  https://review.openstack.org/58393006:52
openstackgerritKaifeng Wang proposed openstack/ironic-inspector master: Multiple backends for introspection data: processing  https://review.openstack.org/51455206:59
*** rcernin has quit IRC07:02
*** e0ne has joined #openstack-ironic07:18
yolandahi, silly question, what's the alternative for "ironic node-set-provsion-state deleted", using openstack baremetal api? i try to just delete a node on deploy failed with the openstack baremetal cli, but i can't figure how to move from deploying to deleted state07:31
yolandawhen i try the barmetal node delete there, i just get "cannot delete node while it is in state deploy failed"07:33
*** marlinc has quit IRC07:39
*** olivierbourdon38 has joined #openstack-ironic07:39
etingofyolanda, may be you can try turning it into 'manage' first?07:43
etingofyolanda, no, according to the state diagram you should be able to delete the node from the 'deploy failed' state -- https://docs.openstack.org/ironic/pike/_images/states.svg07:45
etingofyolanda, wait, if you are in 'deploying' state, you probably have to wait till it fails and transitions into 'deploy failed' state from where you should be able to delete the node07:46
*** marlinc has joined #openstack-ironic07:48
*** w-miller has joined #openstack-ironic07:49
yolandait is in deploy failed, but i cannot delete when it's there07:54
*** tssurya has joined #openstack-ironic07:54
yolandamm again it may be because of an old ironic version? i shoud try upgrading to queens07:55
*** Bhujay has quit IRC08:10
*** ajya has joined #openstack-ironic08:11
*** openstackstatus has quit IRC08:12
*** dtantsur|afk is now known as dtantsur08:15
dtantsurmorning ironic08:15
dtantsurTheJulia, rpioso|afk, jroll, my take on this is that's it's a bit risky patch due to its size08:16
dtantsurand while Ocata won't be automatically closed this months, maintaining the CI for it will be increasingly harder08:17
dtantsure.g. I'm not sure devstack will support Ocata after that point08:17
dtantsurso if we screw up now, we may not be able to fix it.08:17
*** serlex has joined #openstack-ironic08:17
*** derekh has joined #openstack-ironic08:29
*** Bhujay has joined #openstack-ironic08:34
dtantsurrpioso|afk: btw, we'll need a rocky release for dracclient. lemme know if you need help with cutting it.08:42
etingofmorning dtantsur \o08:44
*** MattMan_1 has quit IRC08:49
*** MattMan_1 has joined #openstack-ironic08:49
dtantsuro/08:53
*** mgoddard has joined #openstack-ironic09:07
*** etingof is now known as etingof|brb09:11
*** gkadam has joined #openstack-ironic09:18
*** ajya has quit IRC09:29
*** ajya has joined #openstack-ironic09:29
*** openstackstatus has joined #openstack-ironic09:41
*** ChanServ sets mode: +v openstackstatus09:41
*** hoonetorg has quit IRC09:43
dtantsuryolanda: the counterpart of "deleted" is "baremetal node undeploy".09:48
dtantsur("deleted" is a very confusing name indeed)09:48
yolandaundeploy?09:48
yolandafirst time i hear!09:48
yolandadtantsur, i guess documentation needs a refresh09:48
dtantsurprobably? where did you spot the old command?09:49
yolandain queens doc09:49
yolandadtantsur, https://docs.openstack.org/ironic/queens/contributor/states.html09:50
yolandano undeploy there09:50
yolandawhen you reach deploy failed, it mentions to use the deleted verb, but this didn't work for me09:51
yolandait was just a fatal failure, so it was just on deploy failed forever09:52
*** hoonetorg has joined #openstack-ironic09:57
dtantsuryolanda: you're confusing states with CLI commands09:57
dtantsuryolanda: https://docs.openstack.org/python-ironicclient/latest/cli/osc/v1/index.html#baremetal-node-undeploy09:58
yolandamm, it should be useful to mention this on the states doc. The equivalent between verb and the cli command09:59
yolandasome of them are mostly equivalente09:59
yolandaequivalent09:59
yolandabut for this one, for sure i didn't get it09:59
yolandai mean, if you want to set the rebuild verb you have the rebuild cli, same for manage... but in this specific undeploy case it's not as obvious10:01
*** S4ren has joined #openstack-ironic10:03
dtantsurwell, it's downside of having "deleted", which we cannot change without breaking the API10:08
openstackgerritAija Jaunteva proposed openstack/sushy master: Update to use mapped field for Message Severity field  https://review.openstack.org/59161210:09
yolandadtantsur, i mean, a documentation change there could help to understand10:15
dtantsuragreed10:21
yolandai can propose a patch. I was explaining last week about that diagram, and i missed that undeploy action as well, i'm pretty sure lots of people don't know about it. With the previous node-set provision state api, it was more clear10:34
yolandanot that i like, but the command was more obvious for that case10:34
*** ajya has quit IRC10:40
*** ajya has joined #openstack-ironic10:40
dtantsuryeah, but it was obvious if and only if you were familiar with the state machine action10:41
dtantsurotherwise a lot of people confused 'node-set-provision-state deleted' and 'node-delete'10:41
*** etingof|brb is now known as etingof10:53
*** ajya has quit IRC10:59
*** ajya has joined #openstack-ironic11:00
openstackgerritDmitry Tantsur proposed openstack/python-ironicclient master: Minor fixes to README.rst  https://review.openstack.org/59162411:10
jrollmorning11:17
jrolldtantsur: thanks, so the patch is the problem, not us maintaining ocata, right?11:17
jrolland from my POV if our CI hits issues that are difficult to fix, we remove the jobs and it's up to consumers to test11:18
*** serlex has quit IRC11:24
*** ajya3 has joined #openstack-ironic11:31
*** ajya has quit IRC11:31
*** rh-jelabarre has joined #openstack-ironic11:34
openstackgerritAija Jaunteva proposed openstack/sushy master: WIP: Add @Redfish.Settings update status and expose it for BIOS  https://review.openstack.org/59163511:49
*** slagle has joined #openstack-ironic11:53
*** serlex has joined #openstack-ironic12:04
dtantsurjroll: morning. the problem is, if we allow a regression now, it will get into our very last release of ocata.12:05
dtantsurany later fixes will not be released12:05
jrolldtantsur: right12:05
jrollI just wanted to be clear that you were not saying we (upstream ironic people) should not maintain ocata12:05
dtantsurwhich is why I'd personally prefer to stay very conservative until that point, then allow the blocked fixes to land.12:05
jroll++12:05
dtantsurI'm fine with maintaining ocata12:06
jrollI figured. just checking. :)12:06
dtantsurjust noting that if/when devstack drops ocata support, we're only left with unit tests12:06
jrollrpioso|afk: ^ clarity for you12:06
jrollyep12:06
*** bfournie has quit IRC12:15
*** ajya3 has quit IRC12:19
*** ajya has joined #openstack-ironic12:20
*** ajya has quit IRC12:22
*** ajya3 has joined #openstack-ironic12:22
*** S4ren has quit IRC12:24
*** S4ren has joined #openstack-ironic12:29
*** trown|outtypewww is now known as trown12:32
openstackgerritOlivier Bourdon proposed openstack/bifrost master: Fix deployment when improper version of python-openssl is installed  https://review.openstack.org/59164612:33
olivierbourdon38Hello ironicers, could you please have a look at https://gist.github.com/obourdon/104ca78baab77fb5ac753ec3e0a9f105 which states the problem I am trying to solve in https://review.openstack.org/591646 and tell me your thoughts about this ?12:33
patchbotpatch 591646 - bifrost - Fix deployment when improper version of python-ope...12:33
olivierbourdon38I have been testing this patch for the last few days successfully12:34
olivierbourdon38this should also remind you of an issue I reported earlier last month when the pymysql package version was updated in OpenStack requirements which lead to a somewhat but less nasty/imbricated issue which was solved by forcing the use pf using when deploying Bifrost in my case.12:36
olivierbourdon38However this was not sufficient this time12:36
olivierbourdon38many thanks in advance for your time, advices and comments12:37
*** rnoriega has quit IRC12:39
TheJuliaolivierbourdon38: seems like the python-openssl must be pulling in something else and possibly squashing pip since your using a dpkg and the package managers are going to have no clue about additional packages installed via pip, so then you end up in a situation where it looks like pip can't even start up :(12:49
olivierbourdon38@TheJulia from what I experienced installing only python-openssl package in addition to a working platform does not drag any other dependencies12:50
olivierbourdon38however the fact that shade is installed in /usr/local and that the urllib3 is using pyopenssl 18.0.0 version (and not 15.0.0 like in xenial base system) is the issue12:52
*** bfournie has joined #openstack-ironic12:52
olivierbourdon38the patchset I submitted (even if still incomplete if I refer to the current Zuul CI errors) is adressing these12:52
olivierbourdon38currently forging patchset 212:52
arne_wiebalck:q12:53
arne_wiebalck(sorry, wrong window)12:53
TheJuliaolivierbourdon38: so that is a conundrum since shade is needed where the ansible plugins execute :\12:54
TheJuliawell, now openstacksdk12:54
olivierbourdon38conundrum ?12:55
olivierbourdon38git show12:56
TheJuliawell, not a conundrum in the sense that something happened 7 days ago12:56
TheJuliaBut more so the additional python code was required to be present for the module to be able to execute via a local connection because it is performed outside of any venv. :\12:57
TheJuliaor is it the remote install case where that was needed12:58
TheJuliagah, better inline comments12:58
openstackgerritDmitry Tantsur proposed openstack/python-ironic-inspector-client master: CI: stop trying to pull the tempest plugin from ironic-inspector  https://review.openstack.org/59165913:03
openstackgerritDmitry Tantsur proposed openstack/python-ironic-inspector-client master: CI: stop trying to pull the tempest plugin from ironic-inspector  https://review.openstack.org/59165913:04
openstackgerritOlivier Bourdon proposed openstack/bifrost master: Fix deployment when improper version of python-openssl is installed  https://review.openstack.org/59164613:05
openstackgerritDmitry Tantsur proposed openstack/python-ironic-inspector-client stable/queens: CI: stop trying to pull the tempest plugin from ironic-inspector  https://review.openstack.org/59166113:05
dtantsurle sigh ^^^13:05
TheJulia:(13:06
*** Bhujay has quit IRC13:07
*** Bhujay has joined #openstack-ironic13:07
openstackgerritDmitry Tantsur proposed openstack/python-ironic-inspector-client stable/rocky: Update .gitreview for stable/rocky  https://review.openstack.org/58599513:09
openstackgerritDmitry Tantsur proposed openstack/python-ironic-inspector-client master: CI: stop trying to pull the tempest plugin from ironic-inspector  https://review.openstack.org/59165913:10
dtantsuromg, I think this is finally done for master - queens13:10
*** rloo has joined #openstack-ironic13:15
*** jcoufal has joined #openstack-ironic13:23
*** Bhujay has quit IRC13:40
openstackgerritMerged openstack/bifrost master: Add doc/requirements.txt to releasenotes tox environment  https://review.openstack.org/59141613:44
*** cdearborn has joined #openstack-ironic13:53
*** mjturek has joined #openstack-ironic13:54
openstackgerritDerek Higgins proposed openstack/ironic master: Switch ironic-dsvm-functional to zuulv3  https://review.openstack.org/59167513:55
openstackgerritDerek Higgins proposed openstack/ironic master: Switch ironic-tempest-dsvm-parallel to zuulv3  https://review.openstack.org/59167613:55
*** baha has joined #openstack-ironic14:03
*** brtknr has quit IRC14:05
*** baha_ has joined #openstack-ironic14:05
*** baha has quit IRC14:09
*** olivierbourdon38 has quit IRC14:09
openstackgerritJim Rollenhagen proposed openstack/bifrost master: Allow extra packages to be installed with ironic  https://review.openstack.org/59141714:14
mordredTheJulia: reading scrollback14:25
mordredoh, yeah. that14:26
* mordred just slinks out the back14:26
openstackgerritDerek Higgins proposed openstack/ironic master: Switch ironic-tempest-dsvm-parallel to zuulv3  https://review.openstack.org/59167614:27
pabelangermorning, could I get a +3 on refactoring of bifrost tests https://review.openstack.org/591471/ hoping to remove legacy-opensuse-423 nodeset from openstack-infra14:29
patchbotpatch 591471 - bifrost - Refactor bifrost-integration-dhcp jobs - 0h 16m 0s spent in CI14:29
dtantsurin addition to ^^, can I get some reviews on https://review.openstack.org/#/c/591659/ please, it fixes the CI14:33
patchbotpatch 591659 - python-ironic-inspector-client - CI: stop trying to pull the tempest plugin from ir... - 0h 52m 44s spent in CI14:33
S4renHi guys, I am trying to write a script using the ironic-pythonclient. After running 'session.node.list()[0]' I get a node record, but when I try to access the uuid value by using 'session.node.list()[0]['uuid'] I get an exception saying the Node object is not subscriptable. How do I access the values inside this object?14:34
dtantsurS4ren: via dot, i.e. .uuid14:34
S4renThat makes a lot of sense, thanks dtantsur14:35
*** baha_ is now known as baha14:37
*** olivierbourdon38 has joined #openstack-ironic14:40
*** olivierbourdon38 has quit IRC14:43
*** Bhujay has joined #openstack-ironic14:52
*** ajya3 has quit IRC15:06
*** ajya3 has joined #openstack-ironic15:06
*** rpioso|afk is now known as rpioso15:07
rpiosoGood morning15:07
*** ajya3 has quit IRC15:10
*** ajya has joined #openstack-ironic15:11
etingofgood morning rpioso \o15:14
rpiosoetingof: o/15:14
TheJuliagood morning rpioso15:15
*** e0ne has quit IRC15:16
rpiosoTheJulia: Morning :)15:19
*** e0ne has joined #openstack-ironic15:20
* rpioso catches up with the backscroll15:22
S4renPardon dtantsur, I am looking through the documentation but I cant seem to find the appropriate command to change a nodes name15:28
dtantsurmorning rpioso15:28
S4renThere doesnt seem to be anything referring to that in node.py15:28
dtantsurS4ren: via Python or via CLI?15:28
S4renPython15:28
dtantsurall fields are changed via node.update15:29
dtantsurthe format is a bit fancy, it's JSON patch15:29
dtantsurso, something like ironic.node.update(node_id, [{'path': '/name', 'op': 'replace', 'value': <new name>}])15:29
S4renAh I see, and if I needed to add ipmi credentials to driver_info, would it be ironic.node.update(node_id, [{'path': '/name', 'op': 'add', 'value': {u'deploy_kernel':'http;//1.1.1.1:8080', 'ipmi_address':'2.2.2.2'} etc...])?15:32
TheJuliawell path of /driver_info, but I think you can add each value on at a time as /driver_info/deploy_kernel instead of pre-formatting a dictionary15:35
S4renlet me give that a go, thank you TheJulia and dtantsur15:36
dtantsurS4ren: feel free to adapt bits from https://github.com/openstack/metalsmith to your needs. it does not have node enrolling, but does show case deployment and the overall approach.15:39
arne_wiebalckHi Ironic! When looking for a root device, the lsblk command run by the IPA explicitly excludes dependent devices (such as md) ... does anyone know the reason why?15:41
S4renThanks dtantsur, will have a look at that repo now15:41
rpiosodtantsur: :)15:43
dtantsurarne_wiebalck: not sure, but I suspect we're only interested in actual hardware15:44
rpiosodtantsur, jroll: Thank you for the clarification.15:46
arne_wiebalckdtantsur: Hmm. I’d think installing on top of a s/W RAID device is sth that you might be interested in ;)15:48
arne_wiebalckdtantsur: Esp. as the dosc on root devices lists “/dev/md0” as an example for the “name” hint :-D15:48
arne_wiebalcks/dosc/docs/15:49
TheJuliaarne_wiebalck: It might make sense to have an override then...15:49
TheJuliaif a path at least, trust the path maybe...15:49
TheJuliawell, we already have the override in a sense, we're just not honoring it because we're looking for matches15:49
arne_wiebalckTheJulia: With override you mean to explicitly pass the device name?15:50
TheJuliaas the hint, yeah15:50
dtantsurarne_wiebalck: is it about firmware RAID?15:50
dtantsurwe've just had people interested in it downstream, but I'm not sure how exactly it will work with ironic/inspector15:51
arne_wiebalckdtantsur: No, I’m trying to get s/w RAID working.15:51
dtantsurarne_wiebalck: what is configuring software RAID when IPA is running? custom hw manager?15:51
arne_wiebalckdtantsur: yes15:52
*** e0ne has quit IRC15:52
dtantsurah, I see15:52
arne_wiebalckdtantsur: We have a custom manager that creates the RAID, and currently I’m overwriting the get_os_install_device function to define which device to use.15:53
arne_wiebalckdtantsur: Was just traying to understand why the root device hints did not work.15:53
rpiosodtantsur, jroll: Regarding the change in question, I feel the risk is very, very low. The change is to the idrac's management interface, which is used by its classic drivers and h/w type. It's been thoroughly tested with the h/w type. We're actively working on the Dell EMC 3d party CI's tests for stable/ocata so we can demonstrate that it works with the classic drivers. All that said, it's not a biggie either way. It15:53
rpiosowould be nice to provide to operators who are on stable/ocata.15:53
arne_wiebalckdtantsur: Then I saw the lsblk command.15:54
*** tssurya has quit IRC15:54
dtantsurarne_wiebalck: I don't know for sure why we prevent that. maybe jroll knows, IPA came from his former team :)15:54
arne_wiebalckdtantsur: Is overwriting get_os_install_device in our manager a sensible approach to get around this?15:55
dtantsurrpioso: okay, I'm fine with that. but please still make the CI pass.15:55
arne_wiebalckdtantsur: Or will I hit other issues?15:55
dtantsurarne_wiebalck: I think you need to go one level deeper and override list_hardware (or how is it called)15:55
dtantsurso that all parts get the correct view of what you consider to be disks15:56
rpiosodtantsur: Ack. We're working on that :-)15:56
dtantsure.g. if you ever use ironic-inspector15:56
dtantsurrpioso: great :) I'll unblock it when I see it green15:56
arne_wiebalckdtantsur: Right. list_block_devices() it I guess.15:56
dtantsuryeah15:56
arne_wiebalckdtantsur: Yeah … I guess the installation of grub may also get confused otherwise.15:57
arne_wiebalckdtantsur: TheJulia : Thx, I’ll have a look.15:58
TheJuliaarne_wiebalck: i think many people would be interested in software raid if you get something working that is viable15:58
dtantsur++ maybe we should stop blacklisting md devices15:59
dtantsurbut then we should be very careful to not expose their underlying devices15:59
TheJulia++15:59
dtantsure.g. if RAID is build from /dev/sda1 and /dev/sda2, we should hide them and show /dev/md015:59
dtantsurright?15:59
TheJuliaYeah16:00
arne_wiebalckdtantsur: Show where?16:00
dtantsurarne_wiebalck: s/show/return from list_block_devices/16:00
arne_wiebalckdtantsur: why?16:00
dtantsurarne_wiebalck: imagine we return /dev/sda1, /dev/sda2 and /dev/md0 and ironic picks /dev/sda2 for deployment. what will happen to /dev/md0?16:01
TheJuliadtantsur: it wouldn't matter now that I think about it16:01
TheJuliathe deploy will just fail16:01
dtantsurmaybe I misunderstand how the things works16:01
TheJuliabecause /dev/md0 has locked /dev/sdax16:01
dtantsurwell, failed deployment is not an ideal outcome :)16:01
*** gyee has joined #openstack-ironic16:02
TheJuliano, it is not, but it is feedback that something is misconfigured16:02
*** pcaruana has quit IRC16:02
TheJuliaand that some action needs to be taken16:02
dtantsurwe should only consider devices for installation that we can use in practice16:02
TheJuliaagreed, but we likely don't need to block one on the other16:02
dtantsurit may not be entirely obviously from something like "Device /dev/sda2 is locked" that one needs root device hints..16:02
TheJuliayeah...16:02
arne_wiebalckis list_block_devices supposed to return all block devices or only the ones eligible for installation?16:03
jrolliirc we excluded raid devices in upstream because wiping them fails, but I could be wrong16:03
TheJuliajroll: when you guys had firmware raid, how was it displaying in the OS/ as a /dev/md[x] device?16:03
jrollTheJulia: yes, it was displaying as /dev/md$x, I think16:04
TheJuliaahh16:04
TheJuliasee that makes sense then16:04
jrollI have to imagine our hardware manager that did raid things returned it correctly though16:04
jrollor just didn't care what list_block_devices did16:05
TheJuliawas that the one upstreamed?16:05
TheJuliaor a separate one?16:05
jrollyeah, list_block_devices is overridable16:05
jrollI don't believe it was OSS'd16:05
* jroll looking16:05
TheJuliaI remember an example one with a bunch of cleaning stuff...16:05
TheJuliabut that is it16:05
jrollright, this was v1 https://github.com/rackerlabs/onmetal-ironic-hardware-manager16:06
jrollv2 had the raids16:06
jrolland also a ton of proprietary vendor-related junk16:06
jrollI don't think we ever split it16:06
jrollyeah, not seeing it :(16:06
TheJuliayeah, reasons start piling up with vendor stuff16:07
arne_wiebalckjroll: thx16:08
jrollno problem16:09
*** rpittau has quit IRC16:09
*** jrist has quit IRC16:12
dtantsurjroll, TheJulia, this is needed to repair ironic-inspector-client gate: https://review.openstack.org/#/c/591659/ https://review.openstack.org/#/c/591661/ https://review.openstack.org/#/c/585995/16:12
patchbotpatch 591659 - python-ironic-inspector-client - CI: stop trying to pull the tempest plugin from ir... - 0h 52m 44s spent in CI16:12
patchbotpatch 591661 - python-ironic-inspector-client (stable/queens) - CI: stop trying to pull the tempest plugin from ir... - 0h 49m 16s spent in CI16:12
patchbotpatch 585995 - python-ironic-inspector-client (stable/rocky) - Update .gitreview for stable/rocky - 3h 0m 19s spent in CI16:12
* TheJulia looks16:12
JayFjroll: TheJulia: Yeah, we never upstreamed anything from that repo except the basic concept unit tests i upstreamed16:13
TheJuliadtantsur: no rocky backport?16:14
dtantsurTheJulia: that's the .gitreview change16:14
dtantsurI had to squash them because without .gitreview I was not able to correctly submit the patch...16:14
TheJuliaahh, i see16:15
TheJuliak16:15
JayFjroll: TheJulia: arne_wiebalck: onmetal handled this by in one of the super early custom steps, we wiped raid metadata from the disks then rebooted -- then the raid device is gone16:16
TheJuliajroll: rloo: could one of you bless https://review.openstack.org/#/c/585995/ to proceed forth into the gate16:16
patchbotpatch 585995 - python-ironic-inspector-client (stable/rocky) - Update .gitreview for stable/rocky - 3h 0m 19s spent in CI16:16
JayFjroll: TheJulia: arne_wiebalck: I'm fairly certain that's how we prevented erase from blowing up on raid devices ... ensuring those devices were gone by that step16:16
rlooTheJulia: done16:16
TheJuliarloo: thanks!16:16
arne_wiebalckJayF: thx!16:17
JayFarne_wiebalck: no problem, good luck! Can I ask what sorta fun things you're doing?16:18
arne_wiebalckJayF: Sure: we’ve introduced Ironic at CERN earlier this year. We almost exclusively use s/w RAID. For now, deploying nodes with Ironic means a double installation.16:19
arne_wiebalckJayF: That’s why we’re trying to integrate this.16:20
JayFOh, awesome! CERN is always doing cool stuff :) Good luck! I'm not so active with Ironic anymore as my job has changed, but it's nice to see it all getting used :)16:20
jrollJayF: ah, you're right, thanks16:20
*** jaganathan has quit IRC16:21
arne_wiebalckJayF: We’re still learning :) We have 1’200 active nodes, but aim to go to around 10k in the next couple of months … let’s see :)16:23
arne_wiebalckJayF: Why did you need to reboot, i.e. why did the erase blow up after the RAID was stopped?16:25
JayFIn this particular case: rebooting was the most straightforward way to stop the raid after we completely invalidated the block devices they were running on16:25
JayFwhile I'm sure we could've figured out how to make it work sans reboot.... rebooting functionality is built into the hardware manager, and it's the more clean solution... why not?16:26
arne_wiebalckJayF: Ah, wasn’t aware you could reboot inside the h/w manager!16:26
JayFhttps://github.com/rackerlabs/onmetal-ironic-hardware-manager -- linked earlier -- has some examples, although like jroll said it's not the best examples (those are under lock and key at $employer[-1])16:28
JayFeven just reading the steps can help understand what you can do https://github.com/rackerlabs/onmetal-ironic-hardware-manager/blob/master/onmetal_ironic_hardware_manager/__init__.py#L6616:28
JayFand that hardware manager interface in the agent is exceedingly well documented16:28
*** d0ugal has quit IRC16:28
JayFI'd suggest reading up on it + some of the examples. You can do pretty much anything you can get working in a ramdisk during cleaning.16:29
jrollJayF: heh, we were looking for "reboot_required" recently and couldn't find it anywhere :/16:29
JayFdid that never get upstreamed!? oh noooo16:29
jrollnot sure if/when/why it was removed, or that16:30
dtantsurjroll: we were looking for reboot_required, and this is reboot_requested16:30
arne_wiebalckJayF: Excellent, thanks a lot!16:30
dtantsurthis may explain it :D16:30
jrolloh jeez16:30
jrollahaha16:31
jrollyeah, that's it, thanks JayF :P16:31
JayFhttps://github.com/openstack/ironic/blob/d3236ef7dd45ee49edb2c2695c5bba4e77e6432e/ironic/drivers/modules/agent_base_vendor.py#L44116:31
dtantsurI do see some code to back reboot_requested16:31
jrollyep16:31
JayFMan I leave for a year and you all start losing features in the couch cushions :P16:31
dtantsurlol16:31
jrollwe didn't lose features, only our search index apparently16:31
*** jrist has joined #openstack-ironic16:38
JayFarne_wiebalck: one more useful thing -> https://github.com/openstack/ipa-example-hardware-managers was explicitly made to be examples / docs for folks implementing hardware managers. Has some explicit copy-paste ready examples.16:39
*** mmethot has quit IRC16:41
NobodyCamGood Morning Ironic'ers16:53
*** serlex has quit IRC16:56
*** w-miller has quit IRC17:01
*** w-miller has joined #openstack-ironic17:02
*** derekh has quit IRC17:04
*** mgoddard has quit IRC17:05
rpiosoNobodyCam: Good morning-ish :)17:06
*** w-miller has quit IRC17:06
NobodyCam:) good morning rpioso :)17:07
*** S4ren has quit IRC17:07
NobodyCamYea moving slow today :p17:07
openstackgerritMerged openstack/python-ironic-inspector-client master: CI: stop trying to pull the tempest plugin from ironic-inspector  https://review.openstack.org/59165917:07
openstackgerritMerged openstack/python-ironic-inspector-client master: Update reno for stable/rocky  https://review.openstack.org/58599717:07
openstackgerritMerged openstack/python-ironic-inspector-client stable/rocky: Update .gitreview for stable/rocky  https://review.openstack.org/58599517:13
dtantsurmorning NobodyCam17:14
NobodyCamhey hey dtantsur Good Morning :)17:14
*** baha has quit IRC17:18
openstackgerritPaul Belanger proposed openstack/bifrost master: Refactor bifrost-integration-dibipa-debian jobs  https://review.openstack.org/59179517:21
*** Bhujay has quit IRC17:22
dtantsurbfournie: https://review.openstack.org/#/c/591661/ has not merged yet17:22
patchbotpatch 591661 - python-ironic-inspector-client (stable/queens) - CI: stop trying to pull the tempest plugin from ir... - 0h 49m 16s spent in CI17:22
dtantsurrloo: if you have a second ^^17:23
dtantsurbfournie: you can rebase your patch on top of the fix17:23
rloodtantsur: in meeting, give me 30 min or so17:23
TheJuliaI just marked it wf+117:23
TheJuliasince the patch on master merged17:24
bfourniedtantsur: hmm, yeah I saw something else that had merged and thought it was that…17:24
*** gkadam has quit IRC17:53
openstackgerritAija Jaunteva proposed openstack/sushy master: WIP: Add Message parsing support with all registry loading  https://review.openstack.org/59074717:59
jrollshould I expect everything in playbooks/roles/bifrost-ironic-install/defaults/main.yml to be present in a given ironic-install task? https://review.openstack.org/#/c/591417 is making me doubt myself17:59
patchbotpatch 591417 - bifrost - Allow extra packages to be installed with ironic - 0h 21m 51s spent in CI17:59
jrollspecifically I get 2018-08-14 14:23:33.569076 | primary |     "msg": "Unexpected failure in finding the lookup named '{{ ironic_extra_packages|default([]) }}' in the available lookup plugins"18:01
jrollwhen ironic_extra_packages is defined in defaults/main.yml18:01
openstackgerritAija Jaunteva proposed openstack/sushy master: Update to use mapped field for Message Severity field  https://review.openstack.org/59161218:02
openstackgerritAija Jaunteva proposed openstack/sushy master: WIP: Add @Redfish.Settings update status and expose it for BIOS  https://review.openstack.org/59163518:06
dtantsurjroll: that's a weird message, "default" should cover an undefined variable18:06
jrolldtantsur: yep, and it should be found anyway :/18:07
jrollI'm wonder if the include: in tasks/main.yml is what's killing it18:07
dtantsurjroll: I have a gut feeling that maybe "loop" does not behave the way you want18:09
dtantsurwhat if you try the older with_items?18:09
*** trown is now known as trown|lunch18:11
jrolldtantsur: yeah, will try, I thought that was deprecated18:13
dtantsurmaybe? I'm not sure18:13
dtantsurI think with_<anything> is somehow converted into loop+lookup18:13
jroll¯\_(ツ)_/¯18:13
jrollwe'll see, thanks for the tip18:14
* jroll wonders why git-review is so slow on his machine18:14
openstackgerritJim Rollenhagen proposed openstack/bifrost master: Allow extra packages to be installed with ironic  https://review.openstack.org/59141718:14
* dtantsur waves18:15
*** dtantsur is now known as dtantsur|afk18:15
openstackgerritMerged openstack/python-ironic-inspector-client stable/queens: CI: stop trying to pull the tempest plugin from ironic-inspector  https://review.openstack.org/59166118:18
openstackgerritAija Jaunteva proposed openstack/sushy master: WIP: Add @Redfish.Settings update status and expose it for BIOS  https://review.openstack.org/59163518:21
TheJuliajroll: default won't work with nested data structures unless you explicitly define them when the default yaml is parsed18:29
TheJuliajroll: if I'm grokking what your trying to do correctly after my brain context change18:30
*** baha has joined #openstack-ironic18:36
jrollTheJulia: I think you're grokking correctly but I'm not sure what you mean by 'unless you explicitly define them when the default yaml is parsed'18:41
TheJuliajroll: defaults/main.yaml gets loaded out of the gate, so he defaults for nested things need to be present or overriden then18:43
* TheJulia hopes that makes sense18:43
jrollTheJulia: that makes sense, but I have a default in defaults/main18:44
jrollor I'm misunderstanding you, and the fact I have the default doesn't matter :)18:45
TheJuliahmm :\18:45
TheJuliahmmm18:46
TheJuliaso if the yaml parses that into an empty list, I don't think the iterator will run and you don't need the default in the install.yaml file unless it is ever separated from the defaults18:48
jrollright, that's what I thought18:49
jrollbut things blew up, so I added a default18:49
jrolland it still blows up in the same way18:49
TheJuliahmm18:49
TheJuliais value: [] valid for a list in yaml?18:49
jrollaccording to a yaml linter, yes18:49
jrollI should probably try it in python18:49
TheJuliahmm18:49
jrollbut, I'm wondering if include: in tasks/main.yml does not use the vars for some reason18:50
jrollI can't imagine that's right, but it's all I've got18:50
TheJuliait could be default with_items is just not valid on the expansion that occurs for it18:52
TheJuliawhat was the error with an empty list?18:52
TheJuliaugh, ironic-ui job settings were never moved out of infra18:52
*** trown|lunch is now known as trown18:53
jrollTheJulia: same error, see PS218:54
TheJuliabut have you tried with_items: "{{ ironic_extra_packages }}"18:55
jrollno, I can give that a shot18:56
openstackgerritJulia Kreger proposed openstack/virtualbmc master: Change jobs for Python3 effort  https://review.openstack.org/58929518:57
*** ajya has quit IRC18:57
*** ajya has joined #openstack-ironic18:57
openstackgerritJim Rollenhagen proposed openstack/bifrost master: Allow extra packages to be installed with ironic  https://review.openstack.org/59141719:00
openstackgerritJulia Kreger proposed openstack/networking-generic-switch master: Change jobs for Python3 effort  https://review.openstack.org/59182519:01
openstackgerritJulia Kreger proposed openstack/networking-generic-switch master: Switch n-g-s devstack job to python3  https://review.openstack.org/59182619:01
openstackgerritJulia Kreger proposed openstack/sushy master: Change jobs for Python3 effort  https://review.openstack.org/59182719:06
openstackgerritJulia Kreger proposed openstack/sushy master: Change sushy devstack job to python3  https://review.openstack.org/59182819:06
openstackgerritMerged openstack/networking-generic-switch master: Detection of config errors for netmiko drivers  https://review.openstack.org/58996019:12
*** ajya[m] has joined #openstack-ironic19:18
openstackgerritJulia Kreger proposed openstack/sushy-tools master: Change jobs for Python3 effort  https://review.openstack.org/59183019:19
openstackgerritJulia Kreger proposed openstack/sushy-tools master: Switch sushy-tools devstack job to Python3  https://review.openstack.org/59183119:19
openstackgerritJulia Kreger proposed openstack/virtualbmc master: Change py35 to py3 so Python 3.6 can be picked up  https://review.openstack.org/59183319:22
*** e0ne has joined #openstack-ironic19:23
*** bfournie has quit IRC19:26
*** e0ne has quit IRC19:26
*** e0ne has joined #openstack-ironic19:27
openstackgerritJulia Kreger proposed openstack/python-ironicclient master: Change jobs for Python3 effort  https://review.openstack.org/59183419:34
openstackgerritJulia Kreger proposed openstack/python-ironicclient master: Switch ci jobs to Python3  https://review.openstack.org/59183519:34
openstackgerritJulia Kreger proposed openstack/python-ironic-inspector-client master: Change basepython to python3  https://review.openstack.org/59183819:43
openstackgerritJulia Kreger proposed openstack/python-ironic-inspector-client master: Change jobs for Python3 effort  https://review.openstack.org/59183919:43
openstackgerritJulia Kreger proposed openstack/python-ironic-inspector-client master: Switch inspector client dsvm job to use python3  https://review.openstack.org/59184019:43
* TheJulia wonders if "TheJulia is evil" shirts will appear at the PTG19:45
*** ajya has quit IRC19:46
jrollheh19:47
jrollTheJulia: didn't doug's email say those patches will be automated?19:47
TheJuliaI didn't read it that way19:47
TheJuliawell, that he wrote some tools to help too19:47
TheJuliamost of it is really minor changes and mindless is sometimes what the brain needs19:48
jrollfair enough :)19:48
* TheJulia misses the days of fixing datacenter wiring19:49
jrollI'm referring to this, btw: http://lists.openstack.org/pipermail/openstack-dev/2018-August/133232.html19:49
jroll"The goal champions will start by preparing the patches for steps 1-5, and 8"19:49
TheJuliaheh19:50
TheJuliasigh19:50
TheJuliaI started based on the book that was the original goal documentation19:50
TheJuliamaybe an elbow tatoo is less painful19:52
jrolllol20:02
*** jcoufal has quit IRC20:19
*** baha has quit IRC20:22
*** bfournie has joined #openstack-ironic20:28
*** S4ren has joined #openstack-ironic20:56
*** trown is now known as trown|outtypewww21:06
*** S4ren has quit IRC21:18
*** slagle has quit IRC21:23
jrollTheJulia: holy cow, your last suggestion works21:28
TheJulia\o/21:29
*** rh-jelabarre has quit IRC21:37
*** cdearborn has quit IRC22:25
*** mbeierl has quit IRC22:38
*** e0ne has quit IRC22:39
*** mbeierl has joined #openstack-ironic22:43
*** mjturek has quit IRC23:22
*** rpioso is now known as rpioso|afk23:30

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!