Friday, 2018-07-13

rpiosoTheJulia: Simply renaming the remote fixes it -- git remote rename upstream origin00:00
rpiosoTheJulia: Yuck! It took me quite some time to narrow it down to that. I thought I still had issues with my dev environment.00:01
TheJuliaI have no idea what that could possibly be00:01
rpiosoTheJulia: Same here. If you wouldn't mind trying it yourself to see if you get the same result, that would be cool. If not, I would entirely understand. I'd be happy to ask someone else to do that.00:03
* rpioso realizes it's time to call it a day00:10
*** rpioso is now known as rpioso|afk00:10
*** cjloader has joined #openstack-ironic00:12
*** cjloader has quit IRC00:16
TheJuliarpioso|afk: I'm long out of braincells for today, glad to try in the morning00:18
*** phuongnh has joined #openstack-ironic00:34
openstackgerritJulia Kreger proposed openstack/ironic master: Revert "Switch ironic-tempest-dsvm-ipa-partition-redfish-tinyipa"  https://review.openstack.org/58243200:35
openstackgerritJulia Kreger proposed openstack/ironic master: Revert "Switch ironic-dsvm-standalone to zuulv3 native"  https://review.openstack.org/58243300:35
openstackgerritJulia Kreger proposed openstack/ironic master: Revert "Switch ironic-dsvm-standalone to zuulv3 native"  https://review.openstack.org/58243300:36
*** hshiina has joined #openstack-ironic00:42
*** gyee has quit IRC00:49
*** harlowja has quit IRC01:05
*** cjloader has joined #openstack-ironic01:13
*** cjloader has quit IRC01:17
*** tiendc has joined #openstack-ironic01:19
*** cjloader has joined #openstack-ironic01:37
*** cjloader has quit IRC01:50
*** rloo has quit IRC02:02
*** athomas_ has joined #openstack-ironic03:21
*** athomas has quit IRC03:23
*** TxGirlGeek has joined #openstack-ironic03:27
*** boris_42_ has quit IRC03:28
*** jaganathan has joined #openstack-ironic03:56
*** jaganathan has quit IRC03:58
*** jaganathan has joined #openstack-ironic03:58
*** links has joined #openstack-ironic04:02
openstackgerritDao Cong Tien proposed openstack/ironic-tempest-plugin master: Rescue mode tempest tests  https://review.openstack.org/52869904:12
*** harlowja has joined #openstack-ironic04:25
*** vmud213 has joined #openstack-ironic04:36
*** harlowja has quit IRC04:44
*** TxGirlGeek has quit IRC05:03
*** e0ne has joined #openstack-ironic05:10
*** ianychoi_ has joined #openstack-ironic05:27
*** ianychoi has quit IRC05:30
*** e0ne has quit IRC05:50
*** mjura has joined #openstack-ironic05:53
*** e0ne has joined #openstack-ironic05:58
*** e0ne has quit IRC05:59
*** e0ne has joined #openstack-ironic06:01
*** e0ne has quit IRC06:06
*** e0ne has joined #openstack-ironic06:06
*** e0ne has quit IRC06:09
*** e0ne has joined #openstack-ironic06:17
*** e0ne_ has joined #openstack-ironic06:21
*** e0ne has quit IRC06:22
*** e0ne has joined #openstack-ironic06:22
*** e0ne_ has quit IRC06:26
*** tiendc has quit IRC06:28
*** tiendc has joined #openstack-ironic06:28
*** phuongnh has quit IRC06:28
*** phuongnh has joined #openstack-ironic06:29
*** tssurya has joined #openstack-ironic06:29
*** e0ne_ has joined #openstack-ironic06:33
*** e0ne_ has quit IRC06:33
*** e0ne has quit IRC06:35
*** adreznec has quit IRC06:37
*** e0ne has joined #openstack-ironic06:40
*** zhangfei has joined #openstack-ironic06:41
*** e0ne has quit IRC06:48
*** lennyb has quit IRC06:49
*** logan- has quit IRC06:50
*** logan- has joined #openstack-ironic06:50
*** serlex has joined #openstack-ironic06:51
*** lennyb has joined #openstack-ironic06:52
*** tssurya has quit IRC06:58
*** tssurya has joined #openstack-ironic07:00
*** adreznec has joined #openstack-ironic07:00
*** tesseract has joined #openstack-ironic07:12
*** masber has joined #openstack-ironic07:17
*** MrBerns has joined #openstack-ironic07:21
*** tiendc_ has joined #openstack-ironic07:28
*** tiendc has quit IRC07:30
openstackgerritMadhuri Kumari proposed openstack/ironic master: Implement NoGraphicalConsole Interface  https://review.openstack.org/54735607:31
*** phuongnh has quit IRC07:33
*** phuongnh has joined #openstack-ironic07:33
*** zshi has quit IRC07:33
openstackgerritMadhuri Kumari proposed openstack/ironic master: Implement basic interfaces for GraphicalConsole Interface  https://review.openstack.org/54735607:42
openstackgerritMadhuri Kumari proposed openstack/ironic master: Implement basic interfaces for GraphicalConsole Interface  https://review.openstack.org/54735607:46
*** hshiina has quit IRC07:51
*** mgoddard has joined #openstack-ironic07:54
*** racedo has joined #openstack-ironic07:56
*** mgoddard has quit IRC08:03
*** e0ne has joined #openstack-ironic08:07
*** zshi has joined #openstack-ironic08:09
*** ajya has joined #openstack-ironic08:11
*** cjloader has joined #openstack-ironic08:12
*** hwoarang has quit IRC08:15
*** cjloader has quit IRC08:17
*** hwoarang has joined #openstack-ironic08:23
*** hwoarang has quit IRC08:23
*** hwoarang has joined #openstack-ironic08:23
*** alexpilotti has quit IRC08:26
*** alexpilotti has joined #openstack-ironic08:26
*** vabada has quit IRC08:27
*** vabada has joined #openstack-ironic08:27
*** vabada has quit IRC08:29
*** vabada has joined #openstack-ironic08:30
openstackgerritMadhuri Kumari proposed openstack/ironic master: Implement basic interfaces for GraphicalConsole Interface  https://review.openstack.org/54735608:33
*** phuongnh has quit IRC08:36
*** phuongnh has joined #openstack-ironic08:37
*** rcernin has quit IRC08:46
*** milan has joined #openstack-ironic08:49
*** hwoarang has quit IRC08:54
*** hwoarang has joined #openstack-ironic08:55
*** trungnv has quit IRC09:01
*** mgoddard has joined #openstack-ironic09:19
*** pbourke has quit IRC09:26
*** mgoddard has quit IRC09:26
*** pbourke has joined #openstack-ironic09:28
*** dougsz has joined #openstack-ironic09:36
*** MrBerns has quit IRC09:58
*** tiendc_ has quit IRC10:37
*** phuongnh has quit IRC10:50
*** mgoddard has joined #openstack-ironic10:57
*** cjloader has joined #openstack-ironic11:12
*** arxcruz is now known as arxcruz|brb11:13
*** cjloader has quit IRC11:17
*** toabctl has joined #openstack-ironic11:18
*** mgoddard has quit IRC11:21
*** jcoufal has joined #openstack-ironic11:30
*** rh-jelabarre has joined #openstack-ironic11:42
*** MrBerns has joined #openstack-ironic11:43
*** bfournie has quit IRC11:44
MrBernsHi guys, Im getting the following error when running the enrollment playbook for a node: http://paste.openstack.org/show/725814/11:48
MrBernsHas anyone encountered this before? I am using bifrost with keystone deployed11:48
openstackgerrittianhui proposed openstack/ironic master: Fix bug to doc:configdrive  https://review.openstack.org/58251411:52
TheJuliaGood morning everyone11:54
TheJuliaMrBerns: no... sounds like your install has some incompatabilities. could you supply `pip freeze` output ?11:54
* TheJulia goes and gets coffee and breakfast11:56
TheJuliamkrai: thanks for the new graphical patches!11:56
*** jaganathan has quit IRC11:56
MrBernsTheJulia, http://paste.openstack.org/show/725816/11:57
*** MattMan has quit IRC12:05
*** MattMan has joined #openstack-ironic12:06
*** bfournie has joined #openstack-ironic12:22
*** skazi has joined #openstack-ironic12:23
jrollmorning y'all12:31
*** dprince has joined #openstack-ironic12:33
*** jaypipes is now known as leakypipes12:34
TheJuliagood morning!12:35
TheJuliaMrBerns: I would try downgrading keystoneauth1 to something like 3.6.2, although that is just a hunch :\  Credentials are also free-form if memory serves, and I think they removed some parameters in keystoneauth112:38
MrBernsThanks TheJulia, Ill give that a go12:39
*** leakypipes is now known as smokypipes12:42
MrBernsI just tried that, but unfortunately that doesn't seem to work12:42
MrBernsI had a similar problem with the keystoneless install, which complained about 'token'12:42
MrBernsI had to modify loader.py to fix it so Ill try againthere12:43
*** hoonetorg has quit IRC12:43
*** trown|outtypewww is now known as trown12:47
*** jcoufal has quit IRC12:48
TheJuliaMrBerns: :(12:52
TheJuliaI feel like ironic ci is psychic and knows when I want to merge things that random failures should be super prevelent12:52
jrollthe robots are revolting12:53
smokypipesTheJulia, jroll: ok, just a Friday curiosity question. How does Ironic boot-from-volume work, in a couple sentences? does it copy the bootable segment of the volume into memory on the target node and lay the rest of the volume down to local disk? or is there some magic somewhere?12:57
*** smokypipes is now known as leakypipes12:58
*** TheJulia is now known as needssleep12:58
*** vmud213 has quit IRC12:58
needssleepleakypipes: The bootloader (or hardware) reads from the remote volume and inits what is there12:58
needssleepleakypipes: and then continues to use that volume using a software or hardware initiator12:59
needssleepleakypipes: local disk ends up being "ephemeral" :)12:59
leakypipesneedssleep: interesting. does the bootloader just assume a particular address in the volume's bytestream for where the boot instructions lie?12:59
*** links has quit IRC12:59
leakypipesneedssleep: I'm trying to relate to how a "normal" bootloader would look for the boot instructions at a particular address in firmware13:00
leakypipesfirmware/ROM13:00
needssleepleakypipes: ipxe maps the device to the memory address for the endpoint, so for block 0 boot loader booting, it reads it in, the ipxe uefi loader should look for the partition and go from there but I've not tried that. Hardware based should just view it as another disk13:01
*** hoonetorg has joined #openstack-ironic13:01
leakypipesk13:01
leakypipesneedssleep: thank you ma'am! :)13:02
*** milan has quit IRC13:04
*** milan has joined #openstack-ironic13:04
openstackgerritMarc Methot proposed openstack/ironic master: Fixed link to Storyboard instead of launchpad  https://review.openstack.org/58253413:07
openstackgerritJulia Kreger proposed openstack/ironic master: Assert a build timeout for zuul templated CI jobs  https://review.openstack.org/58253513:09
*** rloo has joined #openstack-ironic13:10
needssleepleakypipes: enjoy!13:11
*** rloo is now known as waterloo13:14
needssleepgood morning waterloo!13:17
waterloogood morning needssleep! Happy Friday :)13:17
openstackgerritJulia Kreger proposed openstack/ironic master: Add notes for future job migrations  https://review.openstack.org/58253713:17
needssleepwaterloo: https://review.openstack.org/#/c/582535/ should pass and allow us to start landing code again. :\13:18
patchbotpatch 582535 - ironic - Assert a build timeout for zuul templated CI jobs13:18
*** bnemec has joined #openstack-ironic13:18
waterlooneedssleep: oh geez, thx for that!13:19
jrolloh my13:19
jroll+213:19
jrollmorning waterloo :)13:19
waterloogood morning jroll! how goes conductor groups? (I haven't yet looked to see)13:20
jrollwaterloo: I didn't get to it yesterday - were you going to move the release_mappings thing between patches, or should I go ahead and rebase now?13:21
waterloojroll: oh, needssleep was fine with it being done in the next patch in the series.13:21
jrollokey13:21
waterloojroll: let me know if you want to discuss any of my comments13:21
*** edleafe is now known as figleaf13:21
waterloojroll: we may want to change something...13:21
jrollwaterloo: oh! I just saw that you commented on the later ones :)13:22
* jroll reads13:22
*** baha has joined #openstack-ironic13:22
waterloojroll: i think i am caught up; reviewed them all except unit tests13:22
jrollcool, thank you13:22
waterlooneedssleep: I don't understand https://review.openstack.org/#/c/582537/1/zuul.d/legacy-ironic-jobs.yaml (but i also don't remember how all this works)13:26
patchbotpatch 582537 - ironic - Add notes for future job migrations13:26
waterlooneedssleep: is the NOTE for something to do in the migrated job, when it gets migrated?13:26
needssleepwaterloo: that13:26
needssleepjust a note so we don't forget those parameters when we migrate them13:26
waterlooneedssleep: ok, i'll suggest something else, thx :)13:27
needssleepk13:28
jrollwaterloo: so re building the hash ring key without a ':', there's still room for conflicts. for example group "" with hw type "ipmi" makes "ipmi". so does group "ip" with hw type "mi". not sure how many assumptions we want to make about people not shooting themselves in the foot13:29
waterloojroll: it is ok if we don't do that. ... what about the issue wrt rolling upgrades?13:30
jrollre "I'm good with assuming any conductor, and not making a requirement to have a conductor in the '' conductor group. Just make sure it is random :)" that might be doable, just need some extra code... I'd rather just require some conductors in the default group I think, but will look at what code it takes13:30
jrollright13:30
jrollso I didn't think through the "everything is upgraded and we're rolling through the unpin"13:30
jrollthat is definitely a problem :/13:30
jroll(until you mentioned it that is)13:31
waterloowith the topic needed for drivers. for now, you can assume that there will be a '' conductor-group, but i think we shouldn't assume that there is one or impose it.13:31
waterlooha ha, it is possible that if i didn't mention it, no one would have noticed when using. but it is also possible, that they would :)13:31
waterloohence my suggestion to get rid of the ':' so it would all upgrade seamlessly. I think we're talking about non-tree driver types having possible issues? sec, let me see what hw types we have now...13:32
jrollright, it would be out of tree drivers13:33
needssleepI thought we talked about starting without a delimiter and introducing it later once we figured out how we were going to do antiaffinity13:33
jrollwe did talk about that, but possible conflicts came up in the spec :/13:33
jrollit's somewhat improbable that it will happen, but possible13:34
waterloowell, it was my bright idea that caused the conflict, ':'. but i was thinking of classic drivers, which we no longer have to deal with.13:34
jrollthen again, ':' is a valid character in entrypoints. we just think it's more improbable to have it there :)13:34
* needssleep feels like we will need a small warning in the docs about group naming13:35
jrollwaterloo: your case-sensitivity comments make me realize I also am not validating [a-z0-9] either13:35
waterloothere is a slight possibility with only hwtypes, but that would only be with out-of-tree hw types, AND it would have to be out-of-tree hwtypes WITH some conductor_group value...13:35
jrollwork to dooooo13:35
jrollright13:35
waterlooi think if we are good with the discrepancy/out-of-sync during rolling upgrades, i am good with having the ':'. If we are not good with the time that hash_ring will be out-of-sync, then we need to address that.13:36
waterlooduring current rolling upgrades, the hash table is out of sync anyway, cuz of old conductors -> new conductors etc.13:37
*** med_ has quit IRC13:38
needssleepYeah, it would be rolling, the conundrum is API understanding13:38
needssleepsince it would be addressing the messages13:38
needssleepso really it is a hard break I think13:38
jrollyeah13:39
needssleepno delimiter would be non-breaking topic selection wise13:40
waterlooneedssleep: exactly, which is why i am thinking it might be 'ok' to have no delimiter.13:40
jrollright, it would be worth it to expose the small footgun13:40
waterlooneedssleep: although i guess i need to think of future use of this thing and whether the delimiter would be useful.13:40
needssleepjroll: doc notes, and we can de-footgun it next cycle13:41
jrollhow do we de-footgun?13:41
jrollthat's the issue, adding the delimiter later has the same issue13:41
needssleepplan for the later upgrade13:41
waterloojroll: can we hash-ring both keys?13:41
jrollwaterloo: like two layers of dict keys?13:42
waterloojroll: what happens if we hash-ring key-with-no-group, key-with-group?13:42
jrollhmm13:42
waterloono not even two layers. just double the keys.13:42
waterloothe same conductors will be avail in both keys, right?13:42
jrollright, two sets of hash rings13:42
jrollyes13:42
waterloothen we're good.13:42
jrolljust trying to think through how we decide which to use13:42
waterloojust do that for this one release...?13:42
jrollor do we only use the one with no delimiter now, then cut over next cycle?13:43
waterlooi suspect we can use your existing code as is.13:43
waterloothinking...13:43
needssleepalso thinking13:43
jrollmy mind is wandering to a 2.0 rpc version as we'll need to kill the old ones13:44
* jroll puts that aside for a moment13:44
waterlooi think if we add both keys to the hashring. so eg conductorA handles ipmi. we have keys ':ipmi' and 'ipmi'. the code, based in rpc API version, uses 'ipmi' or ':ipmi'. as long as both have the same values, we're good.13:46
waterlooat some point, we delete the code that adds the 'ipmi' key. i guess the following release cycle.13:46
waterloojroll: wait. why do we need to kill the old ones?13:47
*** mgoddard has joined #openstack-ironic13:48
jrollI think that will work. trying to think through the removal13:48
jrollwaterloo: I need to re-read the pinning code, but it seems to me that someone could pin stein code to queens or something and it would still be using the queens calculation13:49
waterlooafter code is using the new keys, it doesn't matter if the old keys stay in the hashring, we won't use it.13:49
jroll(but, we also get the benefit of cleaning up all the RPC backporting)13:49
*** dougsz has quit IRC13:50
waterloowe're at queens now. going to release rocky. when someone does a rolling upgrade from queens to rocky, they'll pin to queens.13:50
waterlooi think that's what we're talking about now, right? that rolling upgrade?13:51
jrollthis is somewhat a side topic13:51
waterloooh wait, you said 'stein' code to queens.13:51
waterloohonestly, i have no idea what happens if you have stein code and pin to queens.13:51
waterlooalthough -- you can't.13:51
jrollah, we remove them immediately13:51
waterlooif we're talking about a released 'stein', 'queens' will not be a choice for pinning.13:52
jrollyeah, like I said I need to re-read the code :)13:52
jrollneeded to*13:52
waterloojroll: yes, please re-read, in case i got something wrong. but i think the two keys will work :)13:53
jrollright, the two keys thing is separate from the major rpc version thing13:53
waterloojroll: right.13:53
* jroll has quite a bit of work to do13:56
needssleepso, we could just fallback if we can't find the topic in a future version, but if we add the logic now and switch later then that will work13:57
needssleephttps://github.com/openstack/ironic/blob/a38edcebfa09b0c00c1bf3be6189315abf67bfd5/ironic/conductor/rpcapi.py#L13513:57
*** dougsz has joined #openstack-ironic14:00
*** dprince has quit IRC14:00
*** jcoufal has joined #openstack-ironic14:08
*** efried is now known as fried_rice14:11
needssleephmm, we need to double check our excludes for migrated jobs as well14:13
*** dprince has joined #openstack-ironic14:16
*** mbeierl has quit IRC14:17
*** dprince has quit IRC14:21
*** dprince has joined #openstack-ironic14:21
openstackgerritJulia Kreger proposed openstack/ironic master: Add notes for future job migrations  https://review.openstack.org/58253714:23
needssleepFor rocky for networking-generic-switch, https://review.openstack.org/#/c/580904/ could use a quick review14:25
patchbotpatch 580904 - networking-generic-switch - Updating required neutron version14:25
*** cjloader has joined #openstack-ironic14:26
*** cjloader has quit IRC14:26
*** cjloader has joined #openstack-ironic14:27
*** bnemec has quit IRC14:29
*** bnemec has joined #openstack-ironic14:41
*** lbragstad is now known as elbragstad14:43
openstackgerritJulia Kreger proposed openstack/networking-baremetal master: Updating required neutron version  https://review.openstack.org/58090214:47
*** skazi has quit IRC14:48
*** cjloader_ has joined #openstack-ironic14:52
*** cjloader has quit IRC14:52
*** cjloader_ has quit IRC14:54
*** cjloader has joined #openstack-ironic14:54
*** cjloader has quit IRC14:55
*** cjloader has joined #openstack-ironic14:55
needssleephttps://review.openstack.org/#/c/580902/ should be another quick review, hopefully it will fix the jobs for networking-baremetal14:58
patchbotpatch 580902 - networking-baremetal - Updating required neutron version14:58
*** TxGirlGeek has joined #openstack-ironic15:00
needssleepyet another easy review https://review.openstack.org/#/c/581381/15:00
patchbotpatch 581381 - ironic-inspector - Sync up Flask version with global-requirements15:00
*** TxGirlGeek has quit IRC15:04
*** mjura has quit IRC15:08
*** rpittau has quit IRC15:12
*** bnemec has quit IRC15:15
*** zhangfei has quit IRC15:15
*** yolanda__ has joined #openstack-ironic15:16
*** mgoddard has quit IRC15:16
*** bdodd has quit IRC15:17
*** bdodd has joined #openstack-ironic15:18
*** EmilienM is now known as EvilienM15:18
*** yolanda_ has quit IRC15:18
*** bnemec has joined #openstack-ironic15:19
*** serlex has quit IRC15:19
*** tesseract has quit IRC15:21
jrollhm, needssleep makes a good point with the fallback15:24
needssleepseems like the logical place to catch for now, at least at a high-ish level15:24
* jroll plays with it15:24
MrBernsneedssleep, if you have a moment, it seems to me that when I call the enrollment playbook, ansible thinks I am still not using another auth type, when I am in fact using keystone15:25
MrBernsI added some debug tasks to the ironic-enroll-dynamic role15:25
*** rpioso|afk is now known as rpioso15:25
rpiosoGood morning15:25
*** arxcruz|brb is now known as arxcruz15:26
MrBernshttp://paste.openstack.org/show/725835/15:26
MrBernsAm I on the right track here or does that look normal?15:26
needssleepjroll: disclaimer: it has been a long time since I've walked through that code completely in terms of hash ring interaction.  The ring being one of those things we never really change15:28
jrollneedssleep: yeah, I think that goes for all of us :)15:28
*** zhangfei has joined #openstack-ironic15:28
needssleepMrBerns: have you tried updating shade?15:28
*** zhangfei has quit IRC15:28
mordredI didn't do it15:28
jrollnarrator: he did.15:29
needssleeplol15:29
needssleepI've not looked at the module in a while, but I suspect we're doing something wrong now with that or the template with config parameters we're writing out that gets picked up for authentication15:29
* needssleep seems to remember having to change user_domain_name in ironic's code a couple months ago15:30
MrBernsshade is at 1.21.1 which seems to be the latest15:31
needssleephmmmmm15:31
needssleep1.25 I thought15:31
needssleep1.2815:31
needssleepcores: quick pass on python-ironicclient would be appreciated, there are a couple patches sitting out there15:32
needssleepthe clouds must be slow today... nearly 1600 seconds to run the multinode tests :\15:33
NobodyCamGood Morning Ironic'ers ...15:35
NobodyCamand ..15:35
NobodyCamOFC .15:35
NobodyCamTGIF!15:35
needssleepGood morning NobodyCam15:37
NobodyCamGood Morning needssleep ...15:38
needssleepugh, tree is still on the ground back home15:39
NobodyCamLOL :(15:42
needssleepMrBerns: up for sharing your install config parameters? I'll see if I can reproduce it and pin down the issue on my end15:43
MrBernsneedssleep, Yeah can do, what exactly do you need from my end, just the command I used to install bifrost?15:45
needssleepMrBerns: yeah, that would help... and if you set any of the flags by default in one of the settings file15:49
needssleepfiles15:49
needssleepI'm going to run to the store to get some sandwiches, bbiab15:49
MrBernsneedssleep, here are the files from playbooks/inventory/group_vars: http://paste.openstack.org/show/Mq0Q4boCEoRVQPPuUoqq/15:53
*** tssurya has quit IRC15:53
MrBernsneedssleep, and the command I used is: ansible-playbook -vvvv -i inventory/target install.yaml -e enable_keystone=true -e noauth_mode=false15:53
*** e0ne has quit IRC15:54
MrBernsneedssleep, Im off to the gym, but let me know if you need me to provide anything else to aid in the investigation15:54
MrBernsneedssleep, and thank you :)15:54
bfourniehi, doing a simple backport to stable/queens in python-ironic-inspector-client - https://review.openstack.org/#/c/581875/, I get pep8 failures in a file I didn't change - ironic_inspector_client/test/functional.py:33:1: E402 module level import not at top of file15:59
patchbotpatch 581875 - python-ironic-inspector-client (stable/queens) - Provide proper error message if interface name is ...15:59
bfournieis there something different with python-ironic-inspector-client in stable/queens?16:00
*** racedo has quit IRC16:06
*** jcoufal has quit IRC16:06
*** mjturek has joined #openstack-ironic16:07
*** harlowja has joined #openstack-ironic16:08
openstackgerritRuby Loo proposed openstack/networking-baremetal master: Updating required neutron version  https://review.openstack.org/58090216:09
*** mbeierl has joined #openstack-ironic16:10
*** harlowja has quit IRC16:10
*** jcoufal has joined #openstack-ironic16:15
*** racedo has joined #openstack-ironic16:16
*** racedo has quit IRC16:17
needssleepbfournie: oh, we likely didn't backport a hacking pin16:17
*** fried_rice is now known as fried_rolls16:18
needssleepfried_rolls: spring, egg, or other?16:18
needssleepstable cores: https://review.openstack.org/#/c/567567/ to fix bfournie's issue above16:20
patchbotpatch 567567 - python-ironic-inspector-client (stable/queens) - Gate fix: Cap hacking to avoid gate failure16:20
*** baha has quit IRC16:20
bfourniethanks needssleep16:23
*** med_ has joined #openstack-ironic16:24
*** med_ has quit IRC16:24
*** med_ has joined #openstack-ironic16:24
openstackgerritMerged openstack/ironic-python-agent master: Remove testrepository  https://review.openstack.org/58168516:25
openstackgerritMerged openstack/python-ironicclient master: Trivial fix typo of description  https://review.openstack.org/58119116:25
openstackgerritMerged openstack/python-ironicclient master: Remove testrepository  https://review.openstack.org/58166616:25
needssleep\o/ merging16:27
needssleepanother two for ironic16:28
*** cjloader has quit IRC16:32
*** cjloader has joined #openstack-ironic16:37
*** bnemec has quit IRC16:37
*** athomas_ has quit IRC16:39
*** mjturek has quit IRC16:41
*** baha has joined #openstack-ironic16:42
*** bnemec has joined #openstack-ironic16:45
*** markguz has joined #openstack-ironic16:47
*** markguz has quit IRC16:51
*** bnemec has quit IRC16:53
openstackgerritMerged openstack/networking-generic-switch master: Updating required neutron version  https://review.openstack.org/58090416:55
needssleepyay16:56
*** jcoufal has quit IRC17:09
*** med_ has quit IRC17:15
*** milan has quit IRC17:17
*** dougsz has quit IRC17:25
*** bnemec has joined #openstack-ironic17:38
needssleepMrBerns: So... It worked for me on fedora... I did have to fix two minor things but http://paste.openstack.org/show/725842/ is my pip freeze output17:40
openstackgerritJulia Kreger proposed openstack/bifrost master: Make sure we have our folders for uwsgi  https://review.openstack.org/58265317:44
*** bnemec has quit IRC17:47
openstackgerritMerged openstack/ironic master: Assert a build timeout for zuul templated CI jobs  https://review.openstack.org/58253517:49
*** mgoddard has joined #openstack-ironic17:57
*** jaganathan has joined #openstack-ironic18:00
openstackgerritJulia Kreger proposed openstack/bifrost master: Remove syslinux usage  https://review.openstack.org/58265518:03
*** jaganathan has quit IRC18:03
*** trown is now known as trown|lunch18:06
jrollhmm18:10
jrollif we assume that conductor_group isn't set on any conductors, nor set on any nodes18:10
jrolldo we even need to think about rolling upgrades?18:10
jrollthe hash ring is local to the process using it18:11
*** jistr has quit IRC18:11
*** mgoddard_ has joined #openstack-ironic18:11
jrollit doesn't need to match the other end18:11
*** jistr has joined #openstack-ironic18:11
*** mgoddard has quit IRC18:14
*** mgoddard has joined #openstack-ironic18:15
*** fried_rolls is now known as fried_rice18:15
fried_riceneedssleep: In BJJ, we call sparring "rolling". Not actually a food thing at all :)18:15
needssleepjroll: that is an excellent point18:16
jrollok, chances I am crazy have dropped18:16
jrollwaterloo: thoughts?18:16
needssleepas long as we don't have a delimiter, no, but if we want to we have to plan ahead one cycle if we do want to add a delimiter18:16
needssleepjroll: We work on ironic, of course we are crazy18:17
jrollneedssleep: nah, even with a delimiter, I can't think of a case where it breaks18:17
waterloothe hash_ring 'instance' is local to each process (conductor & API) BUT they need to be in sync (read, same)18:17
waterlooif i understand.18:17
jrollI don't believe they do18:18
jrollthe hosts in the ring need to be up to date18:18
*** mgoddard_ has quit IRC18:18
jrollbut, the lookup results in a (list of) host(s), so as long as that host exists, the message can be sent18:18
needssleepin the form of a topic right?18:19
waterloothinking.. is it where it rebalances where it is important to update (or cuz conductors disappear)?18:19
jrollthe topic is the "hostname" of the conductor, but yes18:19
jrolla rebalance is needed when the list of active conductors changes18:20
waterloodo we randomize which conductor we use if there is more than one conductor that can handle a node?18:20
waterlooi've forgotten how this code works :-(18:21
jrollI believe so18:21
jroller18:21
jrollthere's only one conductor that can handle a node18:21
waterlooif you have 2 conductors that can handle ipmi, and a node has ipmi, then both of those conductors can handle the node, right?18:22
jrollor rather, there are N conductors that handle a node, where N is the 'replicas' argument here: https://github.com/openstack/tooz/blob/master/tooz/hashring.py#L11418:22
jrollah we do have replicas config https://github.com/openstack/ironic/blob/master/ironic/conductor/rpcapi.py#L13818:23
waterloounfortunate use of node in that tooz code. where node == our conductor.18:23
jrollyes, but (assuming one replica in that config), they are mapped onto exactly one conductor in the hash ring18:23
waterlooheh, that config is still experimental...18:24
waterlooand set to 118:24
waterlooso, at the end of the day, what we want is for a node to get the same conductor to handle it, during the entire deployment process, if it happens during a rolling upgrade.18:25
jrollin any case, it will be successfully mapped, as long as the calculation in the hash ring initialization and the calculation in the hash ring fetch, are the same18:25
jrolldo we?18:26
jrolltake_over should handle it, if it changes18:26
waterlooright, but we want to minimize take_over, no?18:26
jrollyes18:27
jrollbut it's going to happen18:27
waterloow/o a rolling upgrade, we sort of assume the same conductor will handle a node during deployment18:27
jrolljust a question of if it happens at unpin time or service restart time18:27
jrollOH. damn. that's why conductors and APIs need to be in sync. sigh.18:27
jrolltoo much state.18:27
waterloowe should write it up but we should have written it up cuz now we don't have time18:28
jrollsorry for the interruption, but that was helpful in processing this. so thanks for that. :)18:28
waterlooyeah, so even w/o your change. right now. if we do a rolling upgrade, api & conductor hash rings will be out of sync cuz of restarts etc.18:28
jrollew18:29
jrollI want to say you're wrong there, but you're right :/18:29
waterlooi thought yesterday, that with your change, the interval got longer wrt out-of-sync. but if it isn't longer (if i'm wrong) or not sig. longer, then.. should be ok..?18:29
jrollthat's a fair point18:30
openstackgerritJulia Kreger proposed openstack/ironic master: Ensure we unbind flat network ports and clear BM mac addresses  https://review.openstack.org/53998118:30
waterlooit all depends on when the hashrings get reset in API and conductor, vs when conductors go up/down during upgrade. and API nodes. I *think* the SIGHUP minimizes the hashring sync issue when we unpin.18:30
jrollso maybe using the separator is fine18:30
jrolleven if the HUP doesn't trigger it, there's two things that do:18:31
jroll1) it's calculated in the API on every request18:31
jroll2) it's reset periodically in the conductor, at a fairly small interval IIRC18:31
waterloothere's a config that specifies the reset interval. used in both api & conductor i thought.18:32
jrollAPI is always: https://github.com/openstack/ironic/blob/master/ironic/conductor/rpcapi.py#L12918:32
waterloooh. hash_ring_reset_interval=18018:32
jroll( see also https://github.com/openstack/ironic/commit/d7cc83129966109556df8669aa970ff39fd156ed )18:32
waterlooah, so YOU did it! :D18:33
waterloook, so the config is used by the conductor18:33
jroll:)18:33
waterlooa conductor (pinned) that comes up with new code, will have a reset hash_ring; when it is unpinned via SIGHUP, the hashring won't be reset. it'll only be reset via the config/reset thing.18:34
jrollalso happy to make it reset on SIGHUP, btw18:34
waterloo^ i think we (you) need to think about whether we need it to reset or not.18:35
jroll(if we have a hook)18:35
jrollI don't think it would be a bad thing18:35
jrollit isn't terribly heavy to reset it18:35
waterlooi am leaning towards not now. but i also am not thinking too hard about this problem.18:35
needssleephmmm18:35
waterlooi believe it isn't hard to add hooks wrt sighup, etc, but i don't recall offhand.18:36
jrolloh, we don't really have a good hook there right now18:36
jrollprobably not hard18:36
needssleepwaterloo: so there is code predicated on a conductor owning the node for some tasks, but general things should work afaik18:36
waterlooneedssleep: yeah, i think that's correct.18:37
*** ajya has quit IRC18:37
waterloothere's that node.conductor_affinity thing.18:37
needssleepyeah18:37
openstackgerritMerged openstack/ironic-inspector master: Sync up Flask version with global-requirements  https://review.openstack.org/58138118:37
waterlooi think it is used, to know when to takeover by another conductor18:37
needssleepand is used for periodic tasks18:37
* needssleep has been deep in that code recently18:39
waterlooneedssleep: ah yes, i see, _sync_local_state. this is where the hashring is reset too, i think.18:39
waterlooah, i take that back. a comment led me to believe the ring is reset here but i don't see that it is.18:40
MrBernsThanks needssleep, Ill check my packages again18:41
jrollI don't see any hash ring resets in the conductor O_o18:41
jrollthat isn't good18:41
jrolloh, it does it on fetch, ignore me18:41
needssleepheh18:41
* needssleep feels like it is beer-o-clock18:42
jroll( https://github.com/openstack/ironic/blob/master/ironic/common/hash_ring.py#L40 for the people in the back)18:42
waterloohashringmanager is so smart and independent :)18:42
jrollmaybe I just need to play with running this code18:44
jrollidk18:44
jrollthanks for the discussion, it was helpful :)18:44
*** dprince has quit IRC18:45
openstackgerritChuck Short proposed openstack/ironic-inspector master: Switch to using stestr  https://review.openstack.org/57852418:45
*** mgoddard has quit IRC18:47
waterloogood luck jroll! :)18:48
*** markguz has joined #openstack-ironic18:50
*** zzzeek has quit IRC18:52
*** zzzeek has joined #openstack-ironic18:57
*** MrBerns has quit IRC19:02
*** zshi has quit IRC19:08
*** zshi has joined #openstack-ironic19:09
*** zshi has quit IRC19:20
*** zshi has joined #openstack-ironic19:21
*** tssurya has joined #openstack-ironic19:21
openstackgerritAleksandra Bezborodova proposed openstack/sushy master: Add a virtual media resource  https://review.openstack.org/57081019:36
*** TxGirlGeek has joined #openstack-ironic19:39
*** markguz_ has joined #openstack-ironic19:48
*** trown|lunch is now known as trown19:49
*** mmethot_ has quit IRC19:50
*** markguz has quit IRC19:51
*** mmethot has joined #openstack-ironic19:51
openstackgerritJulia Kreger proposed openstack/ironic-lib master: Fall back to PARTUUID if UUID returns nothing.  https://review.openstack.org/56915820:01
*** TxGirlGeek has quit IRC20:06
*** e0ne has joined #openstack-ironic20:12
needssleepThe second deploy step patch is about to enter the gate, maybe ~15 minutes \o/20:12
*** bfournie has quit IRC20:14
*** jungleboyj has joined #openstack-ironic20:14
*** bfournie has joined #openstack-ironic20:14
*** tssurya has quit IRC20:22
*** markguz_ has quit IRC20:25
*** markguz has joined #openstack-ironic20:26
*** boris_42_ has joined #openstack-ironic20:28
*** markguz_ has joined #openstack-ironic20:29
*** markguz__ has joined #openstack-ironic20:32
*** markguz has quit IRC20:32
*** markguz_ has quit IRC20:36
*** markguz has joined #openstack-ironic20:37
*** markguz__ has quit IRC20:41
*** markguz_ has joined #openstack-ironic20:41
*** baha has quit IRC20:43
*** markguz has quit IRC20:45
*** bfournie has joined #openstack-ironic20:47
*** markguz_ has quit IRC20:48
needssleepI updated the priorities list and added additional details for Monday20:57
needssleepI'm likely going to call it a night shortly20:57
*** trown is now known as trown|outtypewww21:09
*** cjloader has quit IRC21:11
*** gyee has joined #openstack-ironic21:25
needssleepAnyone doing reviews, hold off on approving changes.... static.o.o/logs.o.o is down21:27
JayFI must have missed the snowy weather reports in hell, and/or the flying pigs outside the window!21:41
JayFChange subject: virt/ironic: Implement rescue and unrescue .............................Patch Set 33: Code-Review+2 Workflow+121:41
JayFthanks so much to those who finally got this stuff landed :)21:41
fried_rice:*21:42
*** e0ne_ has joined #openstack-ironic21:42
*** e0ne has quit IRC21:42
*** ElCoyote_ has left #openstack-ironic21:43
*** ddurst- is now known as ddurst21:49
-openstackstatus- NOTICE: logs.openstack.org is offline, causing POST_FAILURE results from Zuul. Cause and resolution timeframe currently unknown.21:50
*** ChanServ changes topic to "logs.openstack.org is offline, causing POST_FAILURE results from Zuul. Cause and resolution timeframe currently unknown."21:50
*** figleaf is now known as edleafe22:05
*** e0ne_ has quit IRC22:12
*** e0ne has joined #openstack-ironic22:13
*** med_ has joined #openstack-ironic22:27
*** med_ has quit IRC22:27
*** med_ has joined #openstack-ironic22:27
*** ptx0 is now known as kash22:29
*** kash is now known as ptx022:29
*** e0ne has quit IRC22:33
*** fried_rice is now known as efried22:36
*** med_ has quit IRC22:39
*** rpioso is now known as rpioso|afk23:14
*** leakypipes is now known as jaypipes23:31
*** ChanServ changes topic to "Bare Metal Provisioning | Status: http://bit.ly/ironic-whiteboard | Docs: http://docs.openstack.org/ironic/ | Bugs: https://storyboard.openstack.org/#!/project_group/75"23:34
-openstackstatus- NOTICE: logs.openstack.org is back on-line. Changes with "POST_FAILURE" job results should be rechecked.23:34
*** TxGirlGeek has joined #openstack-ironic23:37
*** TxGirlGeek has quit IRC23:55

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!