Thursday, 2018-07-05

*** alexpilotti has joined #openstack-ironic00:13
*** cjloader has joined #openstack-ironic00:14
*** cjloader has quit IRC00:17
*** alexpilotti has quit IRC00:17
*** alexpilotti has joined #openstack-ironic00:26
*** alexpilotti has quit IRC00:30
*** yangyapeng has joined #openstack-ironic01:15
openstackgerritTuan Luong-Anh proposed openstack/ironic master: Implement iRMC BIOS configuration  https://review.openstack.org/53459501:27
*** alexpilotti has joined #openstack-ironic01:37
*** tiendc has joined #openstack-ironic01:39
*** alexpilotti has quit IRC01:58
*** jaypipes has quit IRC02:06
*** jaypipes has joined #openstack-ironic02:15
*** zhangfei has joined #openstack-ironic02:26
*** alexpilotti has joined #openstack-ironic02:26
openstackgerritTuan Luong-Anh proposed openstack/ironic master: Implement iRMC BIOS configuration  https://review.openstack.org/53459502:26
*** alexpilotti has quit IRC02:43
*** alexpilotti has joined #openstack-ironic03:11
*** alexpilotti has quit IRC03:16
*** alexpilotti has joined #openstack-ironic03:19
*** alexpilotti has quit IRC03:23
*** alexpilotti has joined #openstack-ironic03:32
*** alexpilotti has quit IRC03:36
openstackgerritPan Xingyu proposed openstack/sushy-tools master: Optimize the link address in docs  https://review.openstack.org/58026603:37
*** alexpilotti has joined #openstack-ironic03:38
*** alexpilotti has quit IRC03:43
*** alexpilotti has joined #openstack-ironic03:45
*** alexpilotti has quit IRC03:50
*** alexpilotti has joined #openstack-ironic03:58
*** alexpilotti has quit IRC04:03
*** alexpilotti has joined #openstack-ironic04:05
*** alexpilotti has quit IRC04:10
*** alexpilotti has joined #openstack-ironic04:18
*** alexpilotti has quit IRC04:23
*** alexpilotti has joined #openstack-ironic04:25
*** alexpilotti has quit IRC04:29
*** alexpilotti has joined #openstack-ironic04:38
*** zzzeek has quit IRC04:40
*** alexpilotti has quit IRC04:42
*** zzzeek has joined #openstack-ironic04:43
*** alexpilotti has joined #openstack-ironic04:45
*** alexpilotti has quit IRC04:49
*** alexpilotti has joined #openstack-ironic04:51
*** alexpilotti has quit IRC04:55
*** alexpilotti has joined #openstack-ironic05:04
*** alexpilotti has quit IRC05:09
*** zzzeek has quit IRC05:10
*** zzzeek has joined #openstack-ironic05:11
*** alexpilotti has joined #openstack-ironic05:11
*** alexpilotti has quit IRC05:15
*** e0ne has joined #openstack-ironic05:18
*** e0ne has quit IRC05:21
*** alexpilotti has joined #openstack-ironic05:24
*** alexpilotti has quit IRC05:28
*** yolanda has joined #openstack-ironic05:30
*** alexpilotti has joined #openstack-ironic05:31
*** quiquell|off is now known as quiquell05:31
*** ianychoi has joined #openstack-ironic05:34
*** alexpilotti has quit IRC05:35
*** alexpilotti has joined #openstack-ironic05:43
*** alexpilotti has quit IRC05:47
*** alexpilotti has joined #openstack-ironic05:50
*** alexpilotti has quit IRC05:54
*** mjura has joined #openstack-ironic06:00
*** mjura has quit IRC06:01
*** mjura has joined #openstack-ironic06:01
*** alexpilotti has joined #openstack-ironic06:03
*** alexpilotti has quit IRC06:07
openstackgerritMadhuri Kumari proposed openstack/ironic master: [DNM][WIP] Implement GraphicalConsole Interface  https://review.openstack.org/54735606:08
*** alexpilotti has joined #openstack-ironic06:09
openstackgerritMadhuri Kumari proposed openstack/ironic master: [DNM][WIP] Implement GraphicalConsole Interface  https://review.openstack.org/54735606:11
*** alexpilotti has quit IRC06:14
*** rbartal has joined #openstack-ironic06:17
*** alexpilotti has joined #openstack-ironic06:22
openstackgerritMerged openstack/bifrost master: Add repository & storyboard link to README  https://review.openstack.org/57948806:26
*** alexpilotti has quit IRC06:26
*** alexpilotti has joined #openstack-ironic06:29
*** cjloader has joined #openstack-ironic06:32
*** alexpilotti has quit IRC06:33
*** quiquell is now known as quiquell|bbl06:35
*** sasha_jitsu has quit IRC06:35
*** sasha_jitsu has joined #openstack-ironic06:36
*** cjloader has quit IRC06:36
*** alexpilotti has joined #openstack-ironic06:41
*** mrunge has quit IRC06:45
*** alexpilotti has quit IRC06:46
*** mrunge has joined #openstack-ironic06:46
*** alexpilotti has joined #openstack-ironic06:48
*** alexpilotti has quit IRC06:52
*** alexpilotti has joined #openstack-ironic07:02
*** kiseok7 has joined #openstack-ironic07:05
*** alexpilotti has quit IRC07:06
*** yangyapeng has quit IRC07:10
*** mgoddard has joined #openstack-ironic07:12
*** arnewiebalck_ has joined #openstack-ironic07:13
*** alexpilotti has joined #openstack-ironic07:16
*** quiquell|bbl is now known as quiquell07:16
*** alexpilotti has quit IRC07:21
*** alexpilotti has joined #openstack-ironic07:29
*** cjloader has joined #openstack-ironic07:32
*** yangyapeng has joined #openstack-ironic07:32
*** alexpilotti has quit IRC07:34
*** yangyapeng has quit IRC07:34
*** cjloader has quit IRC07:36
*** alexpilotti has joined #openstack-ironic07:42
*** jaganathan has joined #openstack-ironic07:44
*** milan_ has joined #openstack-ironic07:46
*** e0ne has joined #openstack-ironic07:46
*** rcernin has quit IRC07:54
*** alexpilotti has quit IRC07:56
*** mgoddard has quit IRC07:56
olivierb-Good morning Ironic and thanks yolanda for the reviews ;-)07:58
*** milan_ has quit IRC08:04
*** alexpilotti has joined #openstack-ironic08:07
*** mrunge has quit IRC08:12
*** ajya has joined #openstack-ironic08:14
*** dougsz has joined #openstack-ironic08:15
*** Goneri has joined #openstack-ironic08:17
*** mrunge has joined #openstack-ironic08:24
*** mgoddard has joined #openstack-ironic08:24
*** alexpilotti has quit IRC08:25
*** alexpilotti has joined #openstack-ironic08:27
*** alexpilotti has quit IRC08:31
*** mgoddard has quit IRC08:32
*** derekh has joined #openstack-ironic08:36
*** alexpilotti has joined #openstack-ironic08:37
*** zhangfei has quit IRC08:41
openstackgerritRabi Mishra proposed openstack/ironic master: Change docs bug link to storyboard  https://review.openstack.org/58032308:54
*** zhangfei has joined #openstack-ironic08:55
*** alexpilotti has quit IRC08:55
*** alexpilotti has joined #openstack-ironic08:59
*** alexpilotti has quit IRC09:04
*** alexpilotti has joined #openstack-ironic09:05
*** mgoddard has joined #openstack-ironic09:07
*** alexpilotti has quit IRC09:09
*** alexpilotti has joined #openstack-ironic09:10
*** pbourke has quit IRC09:13
*** pbourke has joined #openstack-ironic09:15
*** sambetts|afk is now known as sambetts09:19
*** e0ne has quit IRC09:21
*** e0ne has joined #openstack-ironic09:23
*** alexpilotti has quit IRC09:25
openstackgerritDao Cong Tien proposed openstack/ironic-inspector master: Invalid link in doc file  https://review.openstack.org/58032909:28
*** cjloader has joined #openstack-ironic09:32
*** dtantsur|afk is now known as dtantsur09:33
*** alexpilotti has joined #openstack-ironic09:33
dtantsurmorning ironic09:33
openstackgerritDao Cong Tien proposed openstack/ironic-inspector master: Invalid links in doc file  https://review.openstack.org/58032909:36
*** cjloader has quit IRC09:37
*** Goneri has quit IRC09:40
*** Goneri has joined #openstack-ironic09:42
*** alexpilotti has quit IRC09:46
*** sasha_jitsu has quit IRC09:49
*** Goneri has quit IRC09:54
*** Goneri has joined #openstack-ironic09:58
*** rbartal_ has joined #openstack-ironic10:06
* dtantsur sees ironic 11.0.0 approved10:08
*** rbartal has quit IRC10:09
*** rbartal has joined #openstack-ironic10:11
*** rbartal_ has quit IRC10:13
*** alexpilotti has joined #openstack-ironic10:13
*** alexpilotti has quit IRC10:18
*** zshi has quit IRC10:23
*** zshi has joined #openstack-ironic10:23
*** prometheanfire has joined #openstack-ironic10:25
*** arnewiebalck_ has quit IRC10:26
prometheanfireironic has a full finished rocky release? (11.0.0)?10:26
*** e0ne has quit IRC10:28
*** cjloader has joined #openstack-ironic10:32
*** cjloader has quit IRC10:36
*** ajya has quit IRC10:52
*** ajya has joined #openstack-ironic10:52
*** zhangfei has quit IRC10:53
*** serlex has joined #openstack-ironic10:53
*** serlex has quit IRC10:54
jrollmorning y'all10:54
jrollprometheanfire: we follow the cycle-with-intermediary model, we'll have another release before the end of rocky10:56
*** gcb has joined #openstack-ironic10:58
prometheanfirecool10:59
openstackgerritJim Rollenhagen proposed openstack/ironic master: Fix 11.0 prelude formatting  https://review.openstack.org/58034110:59
dtantsurprometheanfire: what jroll said, we're planning on another, hopefully calmer, release10:59
dtantsurmorning jroll10:59
jrolldtantsur: morning, I think we want this format fix ^^10:59
prometheanfiredtantsur: that's fine, just didn't know it was cycle with intermediary, was curious :P11:00
dtantsurjroll: let us see how it renders, given that we've tagged already11:00
jrollyep11:00
jrollrelease notes don't need to be tagged though, right?11:00
dtantsurjroll: no, they do11:00
dtantsurdon't11:00
dtantsurmeh11:00
* jroll wants to wait for the render anyway11:00
* dtantsur brb11:01
*** bfournie has joined #openstack-ironic11:01
dtantsurI have an idea for an API improvement around changing drivers11:02
dtantsurI'll file a story soon(ish)11:02
jroll++11:03
jrollrelatedly, working on conductor affinity makes me want to overhaul our conductor management api (or lack thereof)11:04
jrollI should probably read the spec already proposed for this11:04
*** gcb has quit IRC11:13
*** prometheanfire has left #openstack-ironic11:13
*** serlex has joined #openstack-ironic11:15
*** alexpilotti has joined #openstack-ironic11:16
dtantsurheh11:20
openstackgerritAija Jaunteva proposed openstack/sushy-tools master: Fix ImportError for tox debug environment  https://review.openstack.org/58034811:24
*** dprince has joined #openstack-ironic11:39
*** lifeless has quit IRC11:45
*** alexpilotti has quit IRC11:57
*** MattMan has quit IRC12:03
*** MattMan has joined #openstack-ironic12:03
*** e0ne has joined #openstack-ironic12:07
openstackgerritJim Rollenhagen proposed openstack/ironic master: Fix 11.0 prelude formatting  https://review.openstack.org/58034112:08
*** rbartal_ has joined #openstack-ironic12:09
yolandahi jroll , TheJulia , can you give extra +2 +w to https://review.openstack.org/#/c/579156/ ?12:09
patchbotpatch 579156 - ironic-tempest-plugin - Force deploy_interface for cleaning to be iscsi12:09
jrollyolanda: done, thanks for the ping12:10
*** rbartal has quit IRC12:11
yolandajroll, thx12:17
dtantsurjroll: https://storyboard.openstack.org/#!/story/2002868 wdyt?12:20
*** trown|outtypewww is now known as trown12:20
jrolldtantsur: yeah, I like it12:25
jrollI wonder if --reset-interfaces should just send none for each12:25
dtantsurcool. I'll add it to RFE review for the next meeting, but I won't be there12:25
jrollinstead of dealing with microversions and such12:25
dtantsurjroll: this requires the client to know/learn which interfaces are supported by the server12:25
jrollmmm.12:25
jrollfair point12:26
jrollmention adding a microversion in the description and I'll drop a +1 on the RFE :)12:26
* dtantsur updates12:26
* jroll comments12:27
*** quiquell is now known as quiquell|lunch12:27
dtantsurjroll: updated12:29
*** rbartal has joined #openstack-ironic12:29
jrollthanks!12:29
*** rbartal_ has quit IRC12:30
openstackgerritJim Rollenhagen proposed openstack/ironic master: Add conductor_group field to nodes and conductors tables  https://review.openstack.org/57962612:31
openstackgerritJim Rollenhagen proposed openstack/ironic master: Add conductor_group field to config, node and conductor objects  https://review.openstack.org/57962712:31
openstackgerritJim Rollenhagen proposed openstack/ironic master: WIP: new hash ring calculation with conductor group  https://review.openstack.org/57968412:31
jrollsigh12:33
openstackgerritJim Rollenhagen proposed openstack/ironic master: Fix 11.0 prelude formatting  https://review.openstack.org/58034112:33
*** alexpilotti has joined #openstack-ironic12:34
* dtantsur just confirmed that --reset-XXX-interface does not require server changes, yay12:37
*** alexpilotti has quit IRC12:38
*** efried is now known as efried_off12:38
serlexhi, when creating a port, is the MAC address equals net0 or ILOM(KVM) mac address?12:39
dtantsurserlex: probably net0. this should be a MAC of a NIC in the machine, not its management NIC12:39
serlexawesome, thanks for the quick reply12:40
*** tiendc has quit IRC12:45
*** e0ne has quit IRC12:48
*** quiquell|lunch is now known as quiquell12:52
*** arnewiebalck_ has joined #openstack-ironic12:55
*** rloo has joined #openstack-ironic12:56
*** rbartal has quit IRC13:11
*** mjturek has joined #openstack-ironic13:11
*** rbartal has joined #openstack-ironic13:15
openstackgerritDmitry Tantsur proposed openstack/python-ironicclient master: Support resetting interfaces to their default values  https://review.openstack.org/58037713:16
* dtantsur played around with ^^^ and really likes it13:24
*** mjturek has quit IRC13:24
openstackgerritDmitry Tantsur proposed openstack/ironic master: Add unit tests that "remove" is acceptable on /XXX_interface node fields  https://review.openstack.org/58038313:43
*** rbartal has quit IRC13:44
rloogood morning Ironic'ers!13:45
rloomgoddard: thx for taking over the deploy steps!13:45
mgoddardmorning rloo: no problem! Does the split make sense?13:52
rloomgoddard: starting to look (but I got distracted, will restart soon)13:53
*** quiquell is now known as quiquell|mtg13:53
*** mjura has quit IRC13:56
rloomgoddard: yes, i think the split makes sense. we could split the last one into more patches (the API/notificationo one) but for me (since we know what we are doing), the fewer patches the better :)13:57
mgoddardrloo: yeah, jroll & TheJulia seemed surprised by the split, but I thought it would be good to pick apart the simple parts from the hard13:59
*** e0ne has joined #openstack-ironic13:59
jrollI was only surprised as we discussed not splitting it earlier in the week :)13:59
rloomgoddard: oh, what surprise?13:59
rlooah, i see, not to split it at all.13:59
mgoddardjroll: oops, must have missed that13:59
rloothat would have been fine too -- the first feature-in-one-patch :D14:00
openstackgerritDmitry Tantsur proposed openstack/ironic-tempest-plugin master: Add API tests for setting/resetting hardware interfaces  https://review.openstack.org/58038514:00
dtantsurmorning rloo14:00
mgoddardI think the first two should be ready to go, so would be nice to get those in soon14:00
mgoddardI need more time to get to grips with the conductor & driver changes14:01
rloomgoddard: i ok'd the first, looking at the second.14:01
mgoddardrloo: thanks14:01
jrollmgoddard: no worries, it's fine14:01
*** baha has joined #openstack-ironic14:02
rloomgoddard: yeah, that's the meat of the problem, the conductor & drivers. what i didn't know was whether to break it into two deploy steps, but i figured start with one. i need to think about upgrade/out-of-tree drivers a bit more.14:03
openstackgerritMerged openstack/ironic-tempest-plugin master: Force deploy_interface for cleaning to be iscsi  https://review.openstack.org/57915614:04
openstackgerritMerged openstack/ironic master: Fix 11.0 prelude formatting  https://review.openstack.org/58034114:04
openstackgerritMerged openstack/ironic master: Change docs bug link to storyboard  https://review.openstack.org/58032314:04
openstackgerritMerged openstack/ironic-inspector master: Invalid links in doc file  https://review.openstack.org/58032914:06
mgoddardrloo: if you do have thoughts then send them my way :)14:06
rloomgoddard: i will, once i think of them. going to try to do it today or tomorrow...14:06
rloomgoddard: i'm adding the topic 'story/1753128' to the patches14:08
mgoddardrloo: I'm otherwise engaged today & tomorrow so that works for me14:08
mgoddardrloo: thanks14:08
rloomgoddard: ok14:08
dtantsurrloo: if you have a minute, wdyt about https://storyboard.openstack.org/#!/story/2002868 ?14:13
dtantsurditto mgoddard14:13
rloodtantsur: i haven't read it all but yes, that was my thought before, changing the driver was going to be a pain wrt the interfaces :) I'll look at that later today.14:14
dtantsuryep, I'm trying to lower this pain :)14:14
*** arnewiebalck_ has quit IRC14:15
*** arnewiebalck_ has joined #openstack-ironic14:16
rloodid we release ironic 11?14:18
jrollyep :)14:18
rlooyay!14:18
rloo"I R O N I C turns the dial to 11" feels like a birthday party is in order!14:19
jrollTheJulia: ++ on "I R O N I C" btw :)14:19
rloo(i see a typo but...)14:19
*** ajya has quit IRC14:20
*** cjloader has joined #openstack-ironic14:20
* TheJulia dances while waiting for a replacement part for the air conditioner14:20
*** ajya has joined #openstack-ironic14:21
*** rpittau has joined #openstack-ironic14:21
rloodid these get done? (before releasing & after releasing) https://docs.openstack.org/ironic/latest/contributor/releasing.html#things-to-do-before-releasing14:21
*** markguz has joined #openstack-ironic14:22
TheJuliaDoh!14:23
TheJuliaForgot release mapping :(14:24
TheJuliaI guess fix and we can cut 11.0.1 :(14:25
rlooTheJulia: :-(14:25
dtantsur:(14:26
rloofwiw, based on the description, it isn't as urgent wrt these releases, but it is for the stable branch release.14:26
rloo'urgent' == doing it before cutting the release14:27
dtantsuryeah14:28
TheJuliaYeah, if memory aerves it is a must before the next release14:34
TheJuliaServes... Anyway, going back to pto and hopefully fixing the broken air conditioner14:35
dtantsurjroll: mind taking a quick look, we need to unblock unit tests: https://review.openstack.org/#/c/580208/14:44
patchbotpatch 580208 - sushy-tools - Fix return content-type to be JSON14:44
dtantsurand https://review.openstack.org/#/c/579133/ if you have more time14:45
patchbotpatch 579133 - sushy-tools - Remove Flask mocking from tests14:45
*** dprince has quit IRC14:45
jrollwhat in the14:47
jrolldtantsur: +W on the first14:47
jrollon the second... why are we templating json14:47
jrollthis is completely static, even: https://github.com/openstack/sushy-tools/blob/master/sushy_tools/emulator/templates/root.json14:48
jrollwe should define a dict, manipulate it as needed, dump it to json14:48
sambettsI guess someone didn't know about flask.jsonify ;)14:49
jrollsambetts: they even reimplemented it :) https://github.com/openstack/sushy-tools/blob/master/sushy_tools/emulator/main.py#L7614:50
* jroll finds a match and some gasoline14:50
sambettsle sigh...14:50
dtantsurjroll, sambetts, I suspect the reason was that lucasagomes just took examples from DMTF and inserted Jinja tags in them14:56
jrollsure14:57
*** jiapei has quit IRC14:58
* lucasagomes reads14:58
lucasagomeshey all :D14:58
etingofjroll, I think one reason for using templates there is to be able to extend it w/o touching much of the code14:58
sambettso/ lucasagomes14:58
dtantsurlucasagomes: hey there! how's going?14:58
dtantsurlucasagomes: any chances to see you in Berlin this autumn?14:59
lucasagomesdtantsur, all good man, how r things ?14:59
jrollhey lucasagomes :)14:59
lucasagomesdtantsur, for the OpenStack event ? I think minimal dude, unfortunately14:59
lucasagomesu going ?14:59
lucasagomesjroll, sambetts o/14:59
dtantsurlucasagomes: well, I don't have reasons NOT to :) budget for me is around zero14:59
lucasagomestrue that14:59
jrollparty at dtantsur's home?15:00
dtantsurjroll: as long as you're nice to Mrs Tantsur15:01
jrollof course!15:01
*** namnh has joined #openstack-ironic15:01
lucasagomeshaha15:02
dtantsurand don't invite too many people - it's a European flat, not a typical USA home :D15:02
etingoftherefore some Germans party in city parks15:05
dtantsurin November?15:05
dtantsurgood luck, I'll skip :D15:05
dtantsurlet's just rent BrewDog for an evening15:05
dtantsurJFYI last late autumn we had 2 or 3 major storms15:06
dtantsurmajor = with transport outage15:07
rloooh, so we're moving up. PTG storms -> Summit storms?15:11
dtantsur:)15:11
jrollI would be in for renting brewdog15:15
jrollbut only if I can jump in a fermentation tank15:15
NobodyCamGood Morning Ironic'ers15:18
*** rpioso|afk is now known as rpioso15:20
*** bnemec has quit IRC15:25
*** quiquell|mtg is now known as quiquell|off15:26
*** edleafe- has joined #openstack-ironic15:27
rpiosoGood morning15:27
dtantsurmorning NobodyCam, rpioso15:28
NobodyCamGood Morning dtantsur and rpioso :)15:28
rpiosodtantsur: Did some one say party at dtantsur's?15:28
rpiosoNobodyCam: Hey :)15:29
NobodyCam:)15:29
openstackgerritMerged openstack/sushy-tools master: Fix return content-type to be JSON  https://review.openstack.org/58020815:30
openstackgerritMerged openstack/sushy-tools master: Remove Flask mocking from tests  https://review.openstack.org/57913315:30
*** gyee has joined #openstack-ironic15:31
*** medberry has joined #openstack-ironic15:31
*** medberry has quit IRC15:31
*** medberry has joined #openstack-ironic15:31
*** med_ has quit IRC15:34
*** e0ne has quit IRC15:42
*** ajya has quit IRC15:48
*** ajya has joined #openstack-ironic15:49
rloofolks, you good with approving this rfe? (I am.) https://storyboard.openstack.org/#!/story/175174815:53
dtantsurrloo: +215:53
rloothx dtantsur!15:53
*** dprince has joined #openstack-ironic15:54
*** bnemec has joined #openstack-ironic15:56
*** edleafe- has quit IRC15:58
openstackgerritMerged openstack/ironic master: Add unit tests that "remove" is acceptable on /XXX_interface node fields  https://review.openstack.org/58038316:02
*** cjloader_ has joined #openstack-ironic16:02
*** cjloader has quit IRC16:02
*** cjloader_ has quit IRC16:08
*** yolanda_ has joined #openstack-ironic16:13
*** cjloader has joined #openstack-ironic16:16
*** yolanda has quit IRC16:17
markguzTheJulia: the patch you created in princpal works, however now for either bios or uefi the created pxe boot file is being created without he preceding "01-" and systems are no longer booting to the deploy kernel16:19
TheJuliamarkguz: both preceeding with 01-?16:20
TheJuliaSeems like an easy fix16:20
markguzTheJulia: yes the pxe config files are usually created like /tftpboot/pxelinux.cfg/01-6c-ae-8b-2f-42-9016:21
markguzbut now /tftpboot/pxelinux.cfg/6c-ae-8b-2f-42-9016:21
markguzTheJulia: Yeah, what's weird is i don't really se where you changed that in your patch16:22
markguzTheJulia: But then again. i'm not really a coder so i could have missed it16:23
TheJuliamarkguz: i think i know where, but it is interesting that it magically adds that :/16:24
markguzAFAIK it needs the 01 for the pxe boot to work16:24
markguzTheJulia: see here http://paste.openstack.org/show/725128/16:25
TheJuliamarkguz: yeah, i was worried that was thw case event though the template is just the mac address16:26
openstackgerritRuby Loo proposed openstack/ironic master: Add read&write SNMP community names to `snmp` driver  https://review.openstack.org/57917316:26
TheJuliaSame for a uefi machine?16:27
markguzTheJulia: i don't think so.16:27
TheJuliaOh16:27
TheJuliaFun16:27
*** cjloader_ has joined #openstack-ironic16:27
*** cjloader has quit IRC16:27
markguzTheJulia: I got the uefi to boot, but there needs to be other things configured on the boot side for stuff to work properly16:27
*** gcb has joined #openstack-ironic16:28
TheJuliamarkguz: if you wouldnt mind, create a story on storyboard.openatack.org, send me the link, and ill try to get things sorted for you on monday16:28
* TheJulia needs to go back to PTO16:29
markguzTheJulia: 2284816:33
TheJuliaTask?16:33
rloodtantsur: you still around? wrt https://storyboard.openstack.org/#!/story/2002868. is 'remove' equivalent to None? Or maybe I don't quite understand your RFE16:34
markguzTheJulia: yeah16:34
dtantsurrloo: apparently yes: sending "op": "remove" makes the value end up being None16:34
* jroll mutes TheJulia's mobile notifications16:34
* dtantsur tries locally16:34
rloodtantsur: Oh, you mean internally, in the node. The user isn't explicitly setting an interface to None (which we probably allow?)16:35
TheJuliamarkguz: thanka, i reaume pto befodw everyone geta mad at me16:35
TheJuliaBefore geta16:35
TheJuliaGets16:35
dtantsurrloo: I suspect both will work, but using "remove" seems cleaner to me16:35
* TheJulia puts down the phone16:35
markguzTheJulia: enjoy16:35
rloodtantsur: i just want to make sure the user can do (if it is allowed) some_interface=None vs reset-some-interface16:36
dtantsurrloo: I think they can. the problem is with CLI: None will be treated as string "None"16:36
*** gcb has quit IRC16:36
rloodtantsur: cuz reset will reset to the default value for that interface (based on configs, right?) whereas explicit some_interface=None sets it to None?16:36
dtantsurrloo: if you mean python None, it works the same as reset. if you mean string "None", then no16:38
rloodtantsur: I want to make sure 'reset-x-interface' resets the interface to the default, whatever it may be. vs setting the interface to None (which might not be the default)16:38
dtantsurrloo: it's impossible to set an interface to None after the driver composition reform16:39
dtantsurin the conductor None is converted to the default16:39
rloodtantsur: OH.16:39
dtantsuron create/update16:39
dtantsurthis is not something I'm changing, this has been the case from the beginning :)16:39
dtantsurthis allowed us to get rid of infinite "if task.driver.management is not None: ..."16:40
rloodtantsur: i thought we had some interfaces, eg inspector, that could be None?16:40
jrollthey can be no-inspect, for instance16:40
jrollbut not None16:40
rlooah, that's what we did. thx jroll.16:40
rloook, so dtantsur, you want to change the ironic code to handle None to mean use default interface value. Right?16:41
dtantsurrloo: ironic code does it already16:42
rloodtantsur: I'm just trying to understand that 'Allow None as a valid *_interface value..' part16:42
rloodtantsur: I'm good with the new --reset-x-interface in the client.16:42
dtantsurrloo: yeah, it should be removed. I wrote it before I tested that None already works as the default.16:43
rloodtantsur: ok, if you remove, I"m good with #1. i guess it will work with whatever API version is associated with that x-interface.16:44
dtantsurrloo: reworded. yep.16:44
rloodtantsur: wrt #2. are you going to do 'op': 'remove', 'path': /xxx_interface for all xxx?16:44
rloodtantsur: for --reset-interfaces option16:44
dtantsurrloo: no, because the client might not know all interfaces. so I'm proposing a new API flag.16:45
rloodtantsur: did i miss that? what API flag?16:45
dtantsurrloo: "Add a new boolean API parameter reset_interfaces" I should have mentioned the API though16:45
rloodtantsur: oh, i did miss it. sorry.16:45
dtantsurs/API/endpoint/ (sigh)16:46
*** alexpilotti has joined #openstack-ironic16:46
rloodtantsur: example? an openstack baremetal node set == a PATCH request, right?16:47
openstackgerritJim Rollenhagen proposed openstack/ironic master: Add conductor_group field to nodes and conductors tables  https://review.openstack.org/57962616:48
openstackgerritJim Rollenhagen proposed openstack/ironic master: Add conductor_group field to config, node and conductor objects  https://review.openstack.org/57962716:48
openstackgerritJim Rollenhagen proposed openstack/ironic master: Use conductor group for hash ring calculations  https://review.openstack.org/57968416:48
dtantsurrloo: yep, it's for PATCH /v1/nodes/<NODE>16:49
*** serlex has quit IRC16:49
rlooso would it be 'PATCH /v1/nodes/<NODE>?reset_interfaces' ?16:49
* jroll wishes someone would come along and write the rest API changes for this patch series for him16:49
dtantsurrather PATCH /v1/nodes/<NODE>?reset_interfaces=True16:50
dtantsurbut yeah, that's the idea16:50
*** alexpilotti has quit IRC16:50
rloodtantsur: if you would update the RFE with that ^^, I'm good with approving16:50
*** dougsz has quit IRC16:51
dtantsurrloo: done16:51
*** bnemec has quit IRC16:51
*** cjloader_ has quit IRC16:51
rloodtantsur: and presumably, one could do --reset-interfaces w/o anything else? eg 'openstack baremetal node blah'. i guess not.16:52
openstackgerritSam Betts proposed openstack/ironic master: [DNM] Testing Cisco Third Party CI  https://review.openstack.org/51431216:52
dtantsurrloo: well, I can imagine a use case for that. e.g. you were playing with various interfaces and now just want to reset everything to the defaults.16:52
rloodtantsur: right, i can see a usecase too. but the CLI doesn't allow for it.16:53
*** cjloader has joined #openstack-ironic16:53
*** cjloader has quit IRC16:53
rloodtantsur: same thing with the --reset-deploy-interface. can you specify that w/o 'set --driver'16:53
*** yolanda__ has joined #openstack-ironic16:53
*** cjloader has joined #openstack-ironic16:53
dtantsurrloo: the latter - yes. because it's a part of the PATCH16:53
dtantsurthe former - probably no16:54
rlooso with the latter 'openstack baremetal node set --reset-deploy-interface test' ?16:54
dtantsurrloo: yep, I already tried it locally today16:54
dtantsurit's kind of duplicated with 'baremetal node unset --deploy-interface' I guess16:55
dtantsurthe key point is being able to do it simultaneously with the driver change16:55
rloodtantsur: well, unset is different from reset.16:55
*** mgoddard has quit IRC16:55
openstackgerritvinay kumar muddu proposed openstack/ironic master: iLO BIOS interface implementation  https://review.openstack.org/57680316:55
rloodtantsur: unset would be, eg (I think)with foo_interface values 'no-foo', 'foobar' where 'foobar' is default, unset == no-foo. reset == foobar?16:56
*** rpioso is now known as rpioso|eat16:56
sambettsI think the reason we have the noop interfaces is so we can tell the difference between setting it to noop and setting it to None16:56
*** yolanda_ has quit IRC16:56
sambettspersonally I think setting the interface to None(null) == select me the default16:57
sambettsbecause it basically means I have no preference for this interface16:57
jrollunset is None (use default)16:57
rloosambetts: in that case, unset and reset is the same16:57
dtantsurrloo: I think unset is the same as reset, which we probably overlooked when working on unset..16:57
*** markguz has quit IRC16:57
sambettsrloo: yup unset and reset are the same, disable == explictly set the interface to the no-op version of that interface16:58
rloodtantsur: sorry, i'm going to suggest s/reset/unset/ in your rfe then16:58
jrollhm, do we need --reset-x-interface since we have unset?16:58
dtantsurjroll: we cannot do unset at simultaneously with changing a driver16:59
*** markguz has joined #openstack-ironic16:59
jrolloh right16:59
dtantsurthat's the key driver (pun intended) of this RFE16:59
rloocan we do 'openstack node set --driver ipmi --unset-deploy-interface test' ?16:59
jrollyeah16:59
* jroll does not have a fully functional brain today16:59
dtantsurrloo: it's going to be confusing. in other cases unset sets to None16:59
dtantsurin this case unset will set to something non-None16:59
rloodtantsur: does 'other cases' == interfaces or non-interfaces16:59
dtantsurthat's why I picked reset over it17:00
dtantsurrloo: baremetal node unset --instance-uuid --name17:00
rloocuz you are proposing for only interfaces17:00
jrolldtantsur: side topic, when you have some time, I could use some thoughts here on line 166, though I haven't made a list of what uses it yet: https://review.openstack.org/#/c/579684/5/ironic/conductor/rpcapi.py17:00
patchbotpatch 579684 - ironic - Use conductor group for hash ring calculations17:00
sambettssurely we can make unsetting an interface at the same time as changing the driver work?17:00
dtantsursambetts: that's what my RFE is about17:00
dtantsursambetts: https://storyboard.openstack.org/#!/story/200286817:01
sambettsI mean as it is today as two patch without an API change17:01
sambettssurely thats just bad logic on our backend processing the patch request17:01
rloosambetts: no, it has to do with the CLI: https://docs.openstack.org/python-ironicclient/latest/cli/osc/v1/index.html#baremetal-node-unset17:01
rloosambetts: set & unset are two separate commands17:02
dtantsuryeah, and unset is doing different things...17:02
*** derekh has quit IRC17:02
dtantsuractually, we should not have done 'baremetal node unset --deploy-interface' at all17:02
dtantsurbecause it's not unsetting it: neither setting to None nor removing17:02
rloodtantsur: what is it doing? it is resetting to default, right?17:03
*** e0ne has joined #openstack-ironic17:03
dtantsurrloo: right :(17:03
rloodtantsur: still, what is the ideal CLI then?17:03
sambettsthe user interface for doing it and the API logic are two differnt things, our patch API currently supports passing a add and a remove at the same time so we should use it17:03
dtantsurrloo: I think we should have done what I'm trying to do now in the beginning17:03
sambettswe shouldn't add new APIs because the CLI is bad17:03
*** alexpilotti has joined #openstack-ironic17:03
dtantsursambetts: well, the new API is adding for something CLI cannot easily do17:04
dtantsurthere are two cases in the RFE17:04
rloosambetts: the only new REST API change being added is this new 'reset-interfaces' (to reset all interfaces that aren't explicitly being set)17:04
sambettsright but what I'm saying is that is a duplication of a feature that already exists in our API17:04
rloodtantsur: we can deprecate CLI stuff?17:05
dtantsursambetts: no, it does not17:05
sambettsit does, you state that in your first case in the RFE17:05
dtantsurrloo: yeah, we probably can. /me starts feeling how his small RFE is growing into a spec17:05
dtantsursambetts: yes - if you know the interface.17:05
dtantsurthe case #2 is about resetting all interfaces, and the client side may not know them all17:06
sambettsok so this is two different RFEs17:06
dtantsurI can split them if you will.. but they're behind one story: changing a driver can be hard17:06
rlooyeah, to some extent. there are two changes here. but they are related, and they need to fit with our existing API & CLI.17:07
sambettsok so we need an API that can list all the interfaces17:07
*** trown is now known as trown|lunch17:07
sambettsthen the CLI needs to pass a op remove for all the interfaces17:07
sambettsto clear then17:07
sambettsthem*17:07
dtantsursambetts: I know what you're trying to say, but microversions...17:07
* rloo gets lunch cuz with sambetts on the job, he'll help solve it :)17:07
dtantsurall the interfaces for CLI may not match all the interfaces for the server17:08
dtantsurbecause the CLI may not be using the latest microversion17:08
*** alexpilotti has quit IRC17:08
sambettsan API for listing all the interfaces, should not hide interfaces regardless of microversion17:08
dtantsursambetts: well, then it's going to confuse the users, because they may try to use the interfaces they're not exposed to17:09
dtantsurlike, you see bios_interface in GET /v1/interfaces, but you cannot set it on a node17:09
dtantsuralso, we're talking about adding a new API anyway :)17:10
sambettsI think we already have that API on /v1/drivers right? not sure17:10
sambettsyup /v1/drivers lists all the interface defaults17:11
dtantsursambetts: yeah, but then you have to 1. fetch the node in question, 2. get its driver, 3. use /v1/drivers to get the interfaces, 4. do patch17:11
dtantsurit's 3 requests instead of one17:12
dtantsurand I think we do microversion the output of /v1/drivers17:12
*** mjturek has joined #openstack-ironic17:12
*** yolanda_ has joined #openstack-ironic17:12
dtantsurright, we do https://review.openstack.org/#/c/512579/51/ironic/api/controllers/v1/driver.py@8217:13
patchbotpatch 512579 - ironic - Add Node BIOS support - REST API (MERGED)17:13
dtantsursambetts: we can chat tomorrow re ^^^, a bit late now17:15
sambettsyeah... so much for API discovery, but anyway17:15
*** yolanda__ has quit IRC17:15
* sambetts didn't mean to scare rloo off17:16
dtantsurheh17:16
jrollI agree it's doable by listing the interfaces and iterating over them17:16
jrollbut I think "reset all" is a good user experience17:16
jrolland we should do it17:16
jrollactually, maybe we should do both over the long term :)17:17
sambettsbeing able to discover the interfaces would mean we could stop adding a new microversion everytime we a new interface to a node17:17
dtantsursambetts: well, it's against the microversioning idea17:18
*** bnemec has joined #openstack-ironic17:18
dtantsurif we do microversion the way it's supposed to, we have to version any change that is not a bug fix (and even many bug fixes)17:18
dtantsuradding visible interfaces certainly falls under the feature bucket17:18
dtantsuras you know, I'm not the biggest fan of microversioning, but now that we do it, we should do it correctly IMO :)17:19
*** v12aml has quit IRC17:19
sambettsbut if we add discoverablity and make interfaces a proper sub-resource of a node where the table is (node_id, type, name) then the API is no longer changing when we add a new interfae17:19
dtantsurah, that's what you mean17:20
dtantsuryeah, it's a good idea. but it certainly goes beyond "fix bad UX with changing drivers"17:20
sambettsyeah, its a different story17:20
jrollagree with all of this17:21
*** namnh has quit IRC17:22
*** alexpilotti has joined #openstack-ironic17:22
*** serlex has joined #openstack-ironic17:23
dtantsurokay, I guess I'll leave it here for now. maybe we can converge on something tomorrow :)17:25
rloosambetts didn't scare me off; rather, I felt comfortable leaving cuz the issue was in good hands :)17:25
dtantsurheh17:25
*** v12aml has joined #openstack-ironic17:26
*** dtantsur is now known as dtantsur|afk17:26
sambetts:-P17:26
dtantsur|afksee you17:26
sambettso/ dtantsur|afk17:26
jrollnight dtantsur|afk17:26
rloogood night dtantsur|afk17:28
*** baha has quit IRC17:30
*** e0ne has quit IRC17:36
sambetts:p now all I can think about is how to solve this when I should be fixing the ansible bug I've got downstream... that'll teach me to have IRC open in the background17:38
sambettsnight all o/17:47
*** sambetts is now known as sambetts|afk17:47
*** alexpilotti has quit IRC17:50
*** serlex has quit IRC17:59
*** trown|lunch is now known as trown17:59
*** e0ne has joined #openstack-ironic18:01
*** e0ne_ has joined #openstack-ironic18:03
*** e0ne__ has joined #openstack-ironic18:05
*** e0ne has quit IRC18:06
*** e0ne_ has quit IRC18:08
*** baha has joined #openstack-ironic18:08
*** ajya3 has joined #openstack-ironic18:10
*** ajya has quit IRC18:10
*** yolanda__ has joined #openstack-ironic18:13
*** yolanda_ has quit IRC18:15
*** alexpilotti has joined #openstack-ironic18:23
*** mjturek has quit IRC18:26
*** alexpilotti has quit IRC18:27
*** rpioso|eat is now known as rpioso18:35
*** yolanda_ has joined #openstack-ironic18:35
*** yolanda__ has quit IRC18:39
*** yolanda__ has joined #openstack-ironic18:39
*** yolanda_ has quit IRC18:42
*** ajya3 has quit IRC18:49
*** alexpilotti has joined #openstack-ironic18:57
*** dprince has quit IRC19:00
*** alexpilotti has quit IRC19:04
*** dprince has joined #openstack-ironic19:26
*** lifeless has joined #openstack-ironic19:39
*** medberry is now known as med_19:59
*** Goneri has quit IRC20:03
*** dmellado has quit IRC20:28
*** alexpilotti has joined #openstack-ironic20:30
*** alexpilotti has quit IRC20:31
*** alexpilotti has joined #openstack-ironic20:31
openstackgerritJim Rollenhagen proposed openstack/ironic master: Add conductor_group field to nodes and conductors tables  https://review.openstack.org/57962620:37
openstackgerritJim Rollenhagen proposed openstack/ironic master: Add conductor_group field to config, node and conductor objects  https://review.openstack.org/57962720:37
openstackgerritJim Rollenhagen proposed openstack/ironic master: Use conductor group for hash ring calculations  https://review.openstack.org/57968420:37
*** med_ has quit IRC20:53
*** baha has quit IRC20:54
*** med_ has joined #openstack-ironic20:59
*** med_ has quit IRC20:59
*** med_ has joined #openstack-ironic20:59
*** med_ has quit IRC21:02
*** dprince has quit IRC21:04
*** med_ has joined #openstack-ironic21:13
*** med_ has quit IRC21:13
*** med_ has joined #openstack-ironic21:13
*** cjloader_ has joined #openstack-ironic21:18
*** cjloader has quit IRC21:18
*** cjloader_ has quit IRC21:18
*** cjloader has joined #openstack-ironic21:18
*** cjloader has quit IRC21:33
*** e0ne__ has quit IRC21:41
*** e0ne has joined #openstack-ironic22:00
*** rcernin has joined #openstack-ironic22:00
openstackgerritMerged openstack/ironic master: Add read&write SNMP community names to `snmp` driver  https://review.openstack.org/57917322:06
*** e0ne has quit IRC22:50
*** e0ne has joined #openstack-ironic22:51
*** e0ne has quit IRC22:55
*** rcernin has quit IRC22:58
*** rcernin has joined #openstack-ironic23:01
*** ianychoi_ has joined #openstack-ironic23:01
*** ianychoi has quit IRC23:04
*** yolanda_ has joined #openstack-ironic23:07
*** yolanda__ has quit IRC23:08
*** mrunge has quit IRC23:09
*** mrunge has joined #openstack-ironic23:09
*** yolanda__ has joined #openstack-ironic23:11
*** yolanda_ has quit IRC23:13
*** mrunge_ has joined #openstack-ironic23:18
*** mrunge has quit IRC23:19
*** rloo has quit IRC23:21
*** mrunge_ has quit IRC23:25
*** mrunge has joined #openstack-ironic23:26
*** med_ has quit IRC23:31
*** rpioso is now known as rpioso|afk23:36
*** yolanda_ has joined #openstack-ironic23:40
*** yolanda__ has quit IRC23:42
*** med_ has joined #openstack-ironic23:47
*** med_ has quit IRC23:51
*** med_ has joined #openstack-ironic23:52
*** med_ has quit IRC23:52
*** med_ has joined #openstack-ironic23:52

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!