| *** rloo has quit IRC | 00:06 | |
| *** retr0h has quit IRC | 00:13 | |
| *** mkrai has quit IRC | 00:13 | |
| *** csmart has quit IRC | 00:13 | |
| *** bfournie has joined #openstack-ironic | 00:22 | |
| *** r-daneel has quit IRC | 00:23 | |
| *** ijw has joined #openstack-ironic | 00:24 | |
| *** rpioso is now known as rpioso|afk | 00:29 | |
| *** ijw has quit IRC | 00:29 | |
| openstackgerrit | Merged openstack/ironic master: Rework exception handling on deploy failures in conductor https://review.openstack.org/531120 | 00:44 |
|---|---|---|
| *** hshiina has joined #openstack-ironic | 00:46 | |
| *** mkrai has joined #openstack-ironic | 00:49 | |
| *** hamzy_ has quit IRC | 00:50 | |
| *** Goneri has joined #openstack-ironic | 00:56 | |
| *** tiendc has joined #openstack-ironic | 00:58 | |
| *** phuongnh has joined #openstack-ironic | 01:06 | |
| *** ijw has joined #openstack-ironic | 01:11 | |
| *** hieulq has joined #openstack-ironic | 01:11 | |
| *** rbudden has joined #openstack-ironic | 01:12 | |
| *** Goneri has quit IRC | 01:12 | |
| *** absubram has joined #openstack-ironic | 01:13 | |
| *** hamzy_ has joined #openstack-ironic | 01:13 | |
| *** ijw has quit IRC | 01:17 | |
| *** tuanla____ has joined #openstack-ironic | 01:17 | |
| *** yangyapeng has quit IRC | 01:20 | |
| *** yangyapeng has joined #openstack-ironic | 01:20 | |
| *** links has joined #openstack-ironic | 01:28 | |
| *** retr0h has joined #openstack-ironic | 01:28 | |
| *** csmart has joined #openstack-ironic | 01:28 | |
| *** links has quit IRC | 01:29 | |
| *** rbudden has quit IRC | 01:33 | |
| *** absubram has quit IRC | 01:39 | |
| *** ijw has joined #openstack-ironic | 01:39 | |
| *** ijw has quit IRC | 01:44 | |
| *** ijw has joined #openstack-ironic | 01:47 | |
| openstackgerrit | Merged openstack/ironic master: Zuul: Remove project name https://review.openstack.org/541190 | 01:52 |
| *** ijw has quit IRC | 01:52 | |
| *** masber has quit IRC | 01:59 | |
| *** jlabarre has quit IRC | 02:05 | |
| *** links has joined #openstack-ironic | 02:12 | |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic master: Add validate_rescue() method to boot interface https://review.openstack.org/540954 | 02:20 |
| *** crushil has joined #openstack-ironic | 02:27 | |
| *** nmathew has joined #openstack-ironic | 02:32 | |
| *** nmathew has quit IRC | 02:33 | |
| *** nmathew has joined #openstack-ironic | 02:33 | |
| *** tuanla____ has quit IRC | 02:33 | |
| *** phuongnh has quit IRC | 02:33 | |
| *** tiendc has quit IRC | 02:33 | |
| *** zshi has quit IRC | 02:34 | |
| *** phuongnh has joined #openstack-ironic | 02:34 | |
| *** tiendc has joined #openstack-ironic | 02:34 | |
| *** tuanla____ has joined #openstack-ironic | 02:34 | |
| *** zshi has joined #openstack-ironic | 02:34 | |
| *** nmathew has quit IRC | 02:51 | |
| openstackgerrit | Merged openstack/bifrost master: Fix upper-constraints use https://review.openstack.org/540538 | 02:52 |
| openstackgerrit | Merged openstack/bifrost master: Fix non-venv keystone handling https://review.openstack.org/498910 | 02:54 |
| *** mkrai has quit IRC | 02:54 | |
| *** csmart has quit IRC | 02:55 | |
| *** retr0h has quit IRC | 02:55 | |
| *** zhenguo has joined #openstack-ironic | 03:01 | |
| openstackgerrit | wangdequn proposed openstack/ironic master: Correct grammar, duplicate the found https://review.openstack.org/541525 | 03:08 |
| *** ijw has joined #openstack-ironic | 03:09 | |
| *** ijw has quit IRC | 03:14 | |
| *** namnh has joined #openstack-ironic | 03:18 | |
| openstackgerrit | wangdequn proposed openstack/ironic master: correct grammar, duplicate the found https://review.openstack.org/541530 | 03:24 |
| *** jaganathan has joined #openstack-ironic | 03:39 | |
| *** crushil has quit IRC | 03:49 | |
| *** ianychoi_ has quit IRC | 03:49 | |
| *** ianychoi_ has joined #openstack-ironic | 03:50 | |
| *** tiendc has quit IRC | 03:53 | |
| *** tiendc has joined #openstack-ironic | 03:59 | |
| *** openstackgerrit has quit IRC | 04:04 | |
| *** exodusftw has quit IRC | 04:08 | |
| TheJulia | dtantsur|afk: sambetts|afk: I'm convinced https://review.openstack.org/#/c/541378/ helps, but does not fix the main issue we are started encountering on stable/pike. High level details in the whiteboard with another example. I'm going to crash, I've been staring at this for far too many hours. Whiteboard updated with more details. | 04:13 |
| patchbot | patch 541378 - ironic (stable/pike) - [Devstack] Replace tap with veth | 04:13 |
| *** exodusftw has joined #openstack-ironic | 04:15 | |
| *** zhangfei has joined #openstack-ironic | 04:22 | |
| *** hshiina2 has joined #openstack-ironic | 04:29 | |
| *** harlowja has quit IRC | 04:32 | |
| *** zhangfei_ has joined #openstack-ironic | 04:33 | |
| *** hshiina has quit IRC | 04:33 | |
| *** tuanla____ has quit IRC | 04:40 | |
| *** phuongnh has quit IRC | 04:41 | |
| *** namnh has quit IRC | 04:42 | |
| *** tiendc has quit IRC | 04:44 | |
| *** openstackgerrit has joined #openstack-ironic | 05:07 | |
| openstackgerrit | Merged openstack/ironic master: Modify error quotation marks https://review.openstack.org/541146 | 05:07 |
| openstackgerrit | Merged openstack/ironic master: Correct grammar, duplicate the found https://review.openstack.org/541525 | 05:07 |
| *** zhenguo has quit IRC | 05:10 | |
| *** harlowja has joined #openstack-ironic | 05:37 | |
| *** devananda has quit IRC | 05:40 | |
| *** olivierbourdon38 has joined #openstack-ironic | 05:41 | |
| *** zhangfei_ has quit IRC | 05:52 | |
| *** mkrai has joined #openstack-ironic | 05:57 | |
| *** retr0h has joined #openstack-ironic | 06:02 | |
| *** ccollett has joined #openstack-ironic | 06:07 | |
| openstackgerrit | Olivier Bourdon proposed openstack/bifrost master: Fix for proper deployment when keystone enabled and minimal OS https://review.openstack.org/540713 | 06:07 |
| *** charcol-v2 has quit IRC | 06:09 | |
| *** e0ne has joined #openstack-ironic | 06:11 | |
| *** csmart has joined #openstack-ironic | 06:13 | |
| *** marios has joined #openstack-ironic | 06:13 | |
| *** e0ne has quit IRC | 06:17 | |
| *** ptx0 has quit IRC | 06:20 | |
| *** ptx0 has joined #openstack-ironic | 06:23 | |
| *** olivierbourdon38 has quit IRC | 06:23 | |
| *** ptx0 has quit IRC | 06:42 | |
| *** mjura has joined #openstack-ironic | 06:44 | |
| *** e0ne has joined #openstack-ironic | 06:48 | |
| *** dpawar has joined #openstack-ironic | 06:49 | |
| *** olivierbourdon38 has joined #openstack-ironic | 06:50 | |
| *** ptx0 has joined #openstack-ironic | 06:51 | |
| *** hjensas has quit IRC | 06:52 | |
| *** harlowja has quit IRC | 06:52 | |
| *** e0ne has quit IRC | 06:54 | |
| *** dpawar has quit IRC | 06:57 | |
| *** vsaienk0 has joined #openstack-ironic | 07:02 | |
| openstackgerrit | John L. Villalovos proposed openstack/ironic-python-agent master: When ouputting to /dev/null should open in write mode https://review.openstack.org/541584 | 07:04 |
| *** olivierbourdon38 has quit IRC | 07:16 | |
| *** AlexeyAbashkin has joined #openstack-ironic | 07:22 | |
| *** dpawar has joined #openstack-ironic | 07:23 | |
| *** ccollett has quit IRC | 07:25 | |
| *** jtomasek has joined #openstack-ironic | 07:40 | |
| *** mrunge has joined #openstack-ironic | 07:40 | |
| *** mrunge_ has quit IRC | 07:42 | |
| *** AlexeyAbashkin has quit IRC | 07:42 | |
| *** olivierbourdon38 has joined #openstack-ironic | 07:46 | |
| *** vsaienk0 has quit IRC | 07:48 | |
| *** rcernin has quit IRC | 07:48 | |
| *** weshay has quit IRC | 07:50 | |
| *** hshiina3 has joined #openstack-ironic | 07:50 | |
| *** rnoriega has quit IRC | 07:51 | |
| *** lhinds has quit IRC | 07:51 | |
| *** hjensas has joined #openstack-ironic | 07:51 | |
| *** hjensas has joined #openstack-ironic | 07:51 | |
| *** hshiina3 is now known as hshiina | 07:53 | |
| *** hshiina2 has quit IRC | 07:54 | |
| *** AlexeyAbashkin has joined #openstack-ironic | 07:54 | |
| *** vsaienk0 has joined #openstack-ironic | 07:57 | |
| *** amarao has joined #openstack-ironic | 07:58 | |
| *** rnoriega has joined #openstack-ironic | 08:02 | |
| *** weshay has joined #openstack-ironic | 08:04 | |
| *** lhinds has joined #openstack-ironic | 08:04 | |
| *** ianychoi_ has quit IRC | 08:14 | |
| *** ianychoi_ has joined #openstack-ironic | 08:19 | |
| *** threestrands has quit IRC | 08:22 | |
| *** tesseract has joined #openstack-ironic | 08:24 | |
| *** ianychoi_ has quit IRC | 08:28 | |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic-python-agent master: Add documentation for rescue mode https://review.openstack.org/431622 | 08:28 |
| *** ianychoi_ has joined #openstack-ironic | 08:30 | |
| *** pcaruana has joined #openstack-ironic | 08:38 | |
| *** ianychoi_ has quit IRC | 08:45 | |
| *** ianychoi_ has joined #openstack-ironic | 08:46 | |
| openstackgerrit | Hironori Shiina proposed openstack/ironic master: Update iRMC document for classic driver deprecation https://review.openstack.org/541171 | 09:02 |
| *** athomas has joined #openstack-ironic | 09:03 | |
| openstackgerrit | Merged openstack/bifrost master: Zuul: Remove project name https://review.openstack.org/541015 | 09:08 |
| *** athomas has quit IRC | 09:14 | |
| openstackgerrit | Hironori Shiina proposed openstack/ironic master: Update iRMC document for classic driver deprecation https://review.openstack.org/541171 | 09:16 |
| *** rbartal has joined #openstack-ironic | 09:17 | |
| openstackgerrit | Hironori Shiina proposed openstack/ironic master: Update iRMC document for classic driver deprecation https://review.openstack.org/541171 | 09:20 |
| *** e0ne has joined #openstack-ironic | 09:26 | |
| openstackgerrit | gaofei proposed openstack/bifrost master: Fix unreachable link in document https://review.openstack.org/541634 | 09:27 |
| *** olivierbourdon38 has quit IRC | 09:28 | |
| *** mgoddard_ has joined #openstack-ironic | 09:28 | |
| *** hshiina is now known as hshiina|afk | 09:30 | |
| *** hshiina|afk has quit IRC | 09:33 | |
| *** derekh has joined #openstack-ironic | 09:44 | |
| openstackgerrit | wangdequn proposed openstack/ironic master: correct grammar, duplicate the found https://review.openstack.org/541640 | 09:45 |
| openstackgerrit | Merged openstack/ironic master: correct grammar, duplicate the found https://review.openstack.org/541530 | 09:45 |
| *** hw_wutianwei has quit IRC | 09:54 | |
| *** hw_wutianwei has joined #openstack-ironic | 09:56 | |
| *** pcaruana has quit IRC | 09:57 | |
| *** namnh has joined #openstack-ironic | 09:57 | |
| *** vsaienk0 has quit IRC | 10:09 | |
| *** sambetts|afk is now known as sambetts | 10:10 | |
| *** pcaruana has joined #openstack-ironic | 10:13 | |
| *** strigazi_ has joined #openstack-ironic | 10:16 | |
| *** hw_wutianwei has quit IRC | 10:17 | |
| *** vsaienk0 has joined #openstack-ironic | 10:18 | |
| *** stendulker has joined #openstack-ironic | 10:18 | |
| *** hw_wutianwei has joined #openstack-ironic | 10:18 | |
| *** strigazi has quit IRC | 10:19 | |
| *** strigazi_ is now known as strigazi | 10:19 | |
| *** ianychoi_ has quit IRC | 10:21 | |
| *** ianychoi_ has joined #openstack-ironic | 10:24 | |
| *** dtantsur|afk is now known as dtantsur | 10:26 | |
| dtantsur | morning ironic | 10:26 |
| stendulker | Good morning dtantsur :) | 10:27 |
| pas-ha | morning dtantsur stendulker | 10:28 |
| stendulker | Good morning pas-ha :) | 10:28 |
| *** gcb has quit IRC | 10:29 | |
| *** jaganathan has quit IRC | 10:30 | |
| dtantsur | o/ | 10:31 |
| sambetts | Morning dtantsur, pas-ha, stendulker | 10:31 |
| stendulker | sambetts: Good morning :) | 10:32 |
| stendulker | dtantsur: I went through you comments for https://review.openstack.org/#/c/540954 | 10:32 |
| patchbot | patch 540954 - ironic - Add validate_rescue() method to boot interface | 10:32 |
| stendulker | dtantsur: I think, I'm bit confused... | 10:33 |
| stendulker | dtantsur: Are you suggesting retaining the existing AgentRescue.validate() code as is and add a additional check of boot.validate_rescue() to it ? | 10:33 |
| dtantsur | correct | 10:34 |
| stendulker | But the rescue_ramdisk and rescue_kernel used by PXE are being validated in AgentRescue.validate() | 10:34 |
| dtantsur | stendulker: I guess it should be moved to PXEBoot.validate_rescue as well | 10:36 |
| dtantsur | the rescue interface itself IIRC only uses rescue_password in reality | 10:36 |
| stendulker | dtantsur: yes. | 10:36 |
| stendulker | dtantsur: Currently we do not make call to boot.validate in conductor for rescue operation https://github.com/openstack/ironic/blob/master/ironic/conductor/manager.py#L580-L596. | 10:38 |
| *** athomas has joined #openstack-ironic | 10:38 | |
| stendulker | Also regarding ilo patch. We would need the ilo/rescue.py to implement rescue.get_properties() | 10:39 |
| dtantsur | no, we wouldn't | 10:39 |
| dtantsur | your get_properties does not differ from AgentRescue.get_properties | 10:40 |
| dtantsur | currently your patch incorrectly pulls in ilo_rescue_iso from the boot interface | 10:40 |
| stendulker | so you mean rescue_kernel, rescue_ramdisk or ilo_rescue_iso belongs to boot interface? | 10:40 |
| *** trungnv has joined #openstack-ironic | 10:41 | |
| sambetts | they should yes, they are tied to the method of booting, e.g. rescue_kernel/rescue_ramdisk are pxe things, ilo_rescue_iso is ILOVirtualMedia things | 10:41 |
| stendulker | ok. Currently we have put rescue_kernel/rescue_ramdisk into AgentRescuehttps://github.com/openstack/ironic/blob/master/ironic/drivers/modules/agent.py#L61-L67 | 10:42 |
| stendulker | Then I will have to move this into pxe.py | 10:43 |
| stendulker | Also perform boot interface validation into conductor/manager.py | 10:44 |
| dtantsur | yep | 10:44 |
| *** lucas-afk is now known as lucasagomes | 10:45 | |
| stendulker | Then we would not need common/rescue.py as proposed in the patch. | 10:45 |
| stendulker | Thank you. Will post the patch with the changes. | 10:45 |
| *** trungnv has quit IRC | 10:52 | |
| dtantsur | thanks! | 10:54 |
| *** ianychoi_ has quit IRC | 11:05 | |
| *** ianychoi_ has joined #openstack-ironic | 11:07 | |
| *** stendulker_ has joined #openstack-ironic | 11:07 | |
| *** stendulker has quit IRC | 11:09 | |
| *** pcaruana has quit IRC | 11:09 | |
| *** vsaienk0 has quit IRC | 11:12 | |
| *** stendulker_ has quit IRC | 11:14 | |
| openstackgerrit | Sam Betts proposed openstack/ironic stable/ocata: Use zuul.override_checkout instead of custom branch_override var https://review.openstack.org/540830 | 11:17 |
| *** dmellado has quit IRC | 11:21 | |
| peitolm | Morning all | 11:22 |
| dtantsur | morning peitolm | 11:23 |
| *** dmellado has joined #openstack-ironic | 11:27 | |
| *** vsaienk0 has joined #openstack-ironic | 11:28 | |
| *** namnh has quit IRC | 11:28 | |
| peitolm | dtantsur: I was talking about the issue with mimetypes from yesterday, with a colleague this morning, and i suddenly thought, what happens if a user has two nodes called node and node.json, (this may be an edge case on the edge case), | 11:31 |
| dtantsur | peitolm: funny, I thought about it just today :) | 11:31 |
| dtantsur | well, we have to maintain compatibility in *this* patch | 11:31 |
| dtantsur | meaning, "node.json" will fetch "node" :( | 11:32 |
| dtantsur | my follow-up plan is to create a microversion that reversed the order | 11:32 |
| dtantsur | then deprecate this whole thing and remove it in some other microversion | 11:32 |
| dtantsur | wdyt? | 11:32 |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic master: Do not pass credentials to the ramdisk on cleaning https://review.openstack.org/541683 | 11:33 |
| dtantsur | sambetts, mind reviewing ^^ please? it's security hardening | 11:33 |
| dtantsur | we've been working on it in private, so should be looking good, but it never hurts to get another opinion | 11:33 |
| peitolm | if the mime type wasn't being parsed, what would the user expect? that node and node.json are two different things, can we determine somehow if pecan has done a mimetype match? | 11:34 |
| sambetts | dtantsur: at first glance it looks good | 11:34 |
| peitolm | in fact, is the raw url available to us? could we look at that, and use that in extremis | 11:34 |
| dtantsur | peitolm: the current API contract is for /v1/nodes/test.json means /v1/nodes/test with Content-Type: Application/Json | 11:36 |
| dtantsur | s/means/to mean/ | 11:36 |
| dtantsur | which is sad, but I don't think we can work around the problem without breaking it | 11:36 |
| peitolm | another thought, we know if .json has been stripped correct, could do we something like, if .json stripped, check if node.json exists in preference | 11:36 |
| peitolm | i guess that's your followup microversion | 11:37 |
| dtantsur | I do it, but it cannot solve the problem of "test" vs "test.json" | 11:37 |
| dtantsur | yes, with a microversion I'll change it | 11:37 |
| peitolm | o.k. if stripped, check both, if both exist, return with .json, | 11:37 |
| *** vsaienk0 has quit IRC | 11:38 | |
| dtantsur | yes, that will be the *new* version | 11:38 |
| dtantsur | in the old version we have to do s/with/without/ still :) | 11:38 |
| dtantsur | :) -> :( | 11:38 |
| peitolm | *nods* i need more coffee, i've been an hour and a half without | 11:38 |
| dtantsur | ++ | 11:38 |
| peitolm | so to summarise, the correct behaviour is that node and node.json should both be able to exist, and be accessible, if asked for node.json and it doesn't exist, it should fail, (where at the moment, it returns the result for node) | 11:40 |
| dtantsur | peitolm: https://etherpad.openstack.org/p/ironic-node-mime | 11:44 |
| openstackgerrit | Merged openstack/ironic master: Only set default network interface flat if enabled in config https://review.openstack.org/535830 | 11:45 |
| openstackgerrit | Merged openstack/ironic-inspector master: Remove sample policy and config files https://review.openstack.org/540402 | 11:45 |
| *** charcol has quit IRC | 11:47 | |
| *** dmellado has quit IRC | 11:48 | |
| *** vsaienk0 has joined #openstack-ironic | 11:51 | |
| *** yangyapeng has quit IRC | 11:57 | |
| *** dmellado has joined #openstack-ironic | 11:59 | |
| *** ianychoi_ has quit IRC | 12:00 | |
| peitolm | dtantsur: cool, a new toy :) | 12:01 |
| *** vsaienk0 has quit IRC | 12:01 | |
| *** etingof has quit IRC | 12:04 | |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic master: Stop guessing mime types based on URLs https://review.openstack.org/541289 | 12:07 |
| *** vsaienk0 has joined #openstack-ironic | 12:10 | |
| *** yangyapeng has joined #openstack-ironic | 12:12 | |
| *** pcaruana has joined #openstack-ironic | 12:13 | |
| *** yangyapeng has quit IRC | 12:16 | |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic master: Add 10.1 to the release mapping in preparation for the release https://review.openstack.org/541694 | 12:17 |
| *** etingof has joined #openstack-ironic | 12:17 | |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic master: Add 10.1 and queens to the release mapping https://review.openstack.org/541694 | 12:19 |
| *** dpawar has quit IRC | 12:19 | |
| *** dpawar has joined #openstack-ironic | 12:20 | |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic master: Add 10.1 and queens to the release mapping https://review.openstack.org/541694 | 12:22 |
| openstackgerrit | Olivier Bourdon proposed openstack/bifrost master: Fix extra double-quote https://review.openstack.org/541696 | 12:22 |
| openstackgerrit | Harald Jensås proposed openstack/networking-baremetal master: Fix devstack example https://review.openstack.org/541697 | 12:23 |
| *** dpawar has quit IRC | 12:24 | |
| *** AlexeyAbashkin has quit IRC | 12:25 | |
| *** yangyapeng has joined #openstack-ironic | 12:29 | |
| *** zshi has quit IRC | 12:29 | |
| *** zshi has joined #openstack-ironic | 12:33 | |
| *** AlexeyAbashkin has joined #openstack-ironic | 12:40 | |
| *** hw_wutianwei has quit IRC | 12:43 | |
| *** hw_wutianwei has joined #openstack-ironic | 12:44 | |
| openstackgerrit | Ilya Etingof proposed openstack/sushy-tools master: Abstract away the virtualization management interface https://review.openstack.org/523321 | 12:45 |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic master: Handle case when a glance image contains no data https://review.openstack.org/531180 | 12:46 |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic stable/pike: Do not pass credentials to the ramdisk on cleaning https://review.openstack.org/541703 | 12:47 |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic stable/ocata: Do not pass credentials to the ramdisk on cleaning https://review.openstack.org/541704 | 12:48 |
| openstackgerrit | Harald Jensås proposed openstack/networking-baremetal master: DNM - testing tripleo https://review.openstack.org/541705 | 12:52 |
| openstackgerrit | Harald Jensås proposed openstack/ironic master: DNM - Depends-On to test tripleo gate https://review.openstack.org/541706 | 12:52 |
| openstackgerrit | Harald Jensås proposed openstack/networking-baremetal master: Fix devstack example https://review.openstack.org/541697 | 12:59 |
| *** vsaienk0 has quit IRC | 13:14 | |
| openstackgerrit | Merged openstack/bifrost master: Fix unreachable link in document https://review.openstack.org/541634 | 13:14 |
| *** olivierbourdon38 has joined #openstack-ironic | 13:16 | |
| *** vsaienk0 has joined #openstack-ironic | 13:18 | |
| *** sekharvajjula has joined #openstack-ironic | 13:21 | |
| *** zhangfei has quit IRC | 13:25 | |
| *** jlabarre has joined #openstack-ironic | 13:31 | |
| *** shekarvajjula has joined #openstack-ironic | 13:32 | |
| *** AlexeyAbashkin has quit IRC | 13:34 | |
| *** AlexeyAbashkin has joined #openstack-ironic | 13:35 | |
| *** nicodemos has joined #openstack-ironic | 13:37 | |
| *** hjensas has quit IRC | 13:37 | |
| *** jcoufal has joined #openstack-ironic | 13:39 | |
| *** AlexeyAbashkin has quit IRC | 13:40 | |
| *** zhangfei has joined #openstack-ironic | 13:41 | |
| *** rloo has joined #openstack-ironic | 13:48 | |
| openstackgerrit | Merged openstack/ironic-ui stable/queens: Update .gitreview for stable/queens https://review.openstack.org/541317 | 13:52 |
| *** shekarvajjula has quit IRC | 13:53 | |
| openstackgerrit | Dmitry Tantsur proposed openstack/networking-baremetal master: Make the agent distributed using hashring and notifications https://review.openstack.org/524709 | 13:54 |
| openstackgerrit | Dmitry Tantsur proposed openstack/networking-baremetal master: Add unit tests for member manager https://review.openstack.org/541216 | 13:55 |
| *** AlexeyAbashkin has joined #openstack-ironic | 13:55 | |
| rloo | good morning everyone, dtantsur, sambetts | 13:57 |
| dtantsur | morning rloo | 13:57 |
| dtantsur | rloo: https://review.openstack.org/541683 is ready for approval | 13:57 |
| patchbot | patch 541683 - ironic - Do not pass credentials to the ramdisk on cleaning | 13:57 |
| rloo | sambetts: this doesn't look good, i assume we still want the dependent patches to land? https://review.openstack.org/#/c/540355/ | 13:57 |
| patchbot | patch 540355 - ironic-tempest-plugin - Switch to override-checkout for stable branch jobs | 13:57 |
| rloo | dtantsur: oh, looking... | 13:58 |
| sambetts | rloo: yeah I hit a bug in zuul v3 with my latest stable/ocata dependent patch | 13:58 |
| sambetts | rloo: basically you can't have comments in the job that have quote marks in them | 13:58 |
| sambetts | otherwise it blows us | 13:59 |
| sambetts | up* | 13:59 |
| *** ijw has joined #openstack-ironic | 13:59 | |
| rloo | sambetts: whoa, maybe need a pep8/linter to check that :-( | 13:59 |
| sambetts | I've fixed it I was just waiting for zuul to respond on the dependent before I rechecked that one | 13:59 |
| sambetts | rloo: I've pushed a fix up to zuul | 13:59 |
| rloo | sambetts: thx | 13:59 |
| sambetts | so hopfully that gets reviewed soon | 13:59 |
| TheJulia | Good morning everyone | 14:00 |
| sambetts | rloo: the dependant patches should be good to go now | 14:00 |
| rloo | morning TheJulia | 14:00 |
| dtantsur | morning TheJulia | 14:01 |
| rloo | sambetts: ok, will review those soon | 14:01 |
| *** SerenaFeng has joined #openstack-ironic | 14:01 | |
| dtantsur | rloo, TheJulia, the backports are ready when the master one merges https://review.openstack.org/#/q/topic:bug/1744836 | 14:01 |
| peitolm | Morning rloo, TheJulia | 14:01 |
| rloo | morning peitolm | 14:03 |
| TheJulia | dtantsur: I noticed :) | 14:03 |
| dtantsur | :) | 14:03 |
| *** ijw has quit IRC | 14:03 | |
| TheJulia | has anyone got braincells to help try and figure out what is going on with grenade today? | 14:03 |
| *** r-daneel has joined #openstack-ironic | 14:04 | |
| sambetts | TheJulia: I can try :) | 14:04 |
| *** Goneri has joined #openstack-ironic | 14:04 | |
| TheJulia | I managed to reproduce in an all in one node performing a pull-up | 14:05 |
| TheJulia | just... thinking maybe a patch is needed to keep tempest retrying for... oh... ever. | 14:05 |
| TheJulia | or.... I could shutdown the conductor..... | 14:05 |
| openstackgerrit | Merged openstack/ironic stable/pike: [Devstack] Replace tap with veth https://review.openstack.org/541378 | 14:05 |
| TheJulia | that would at least leave the VMs up with networking and everything else can fail | 14:06 |
| sambetts | TheJulia: so now the veth fix has been backported we're still seeing the issue? | 14:07 |
| TheJulia | yes | 14:07 |
| sambetts | :( | 14:07 |
| TheJulia | I left rough notes of what I found last night on the whiteboard | 14:08 |
| *** links has quit IRC | 14:09 | |
| olivierbourdon38 | I am confused about an error I am having when I try to add the openstack CLI fromhttps://review.openstack.org/#/c/540713/7/playbooks/roles/bifrost-keystone-install/tasks/install.yml line 76 and onwards | 14:10 |
| patchbot | patch 540713 - bifrost - Fix for proper deployment when keystone enabled an... | 14:10 |
| olivierbourdon38 | The error I am getting is: Could not satisfy constraints for 'python-openstackclient': installation from path or url cannot be constrained to a version | 14:11 |
| dtantsur | my guess was that in the CI (at least) zuul can insert requirements in the form of file:///opt/stack/new/python-openstackclient | 14:11 |
| rloo | has anyone looked to see why ironic-tempest-dsvm-pxe_ipmitool-postgres has been failing? http://ci-watch.tintri.com/project?project=ironic&time=7+days | 14:11 |
| dtantsur | which cannot be constrained | 14:11 |
| olivierbourdon38 | which I now understand because I am trying to install from locally cloned repo into path /opt/stack/python-openstackclient | 14:11 |
| dtantsur | rloo: TheJulia (?) mentioned glance problem | 14:11 |
| *** mjturek has joined #openstack-ironic | 14:12 | |
| rloo | dtantsur: ok, so we're good with it failing for now? I can ignore? | 14:12 |
| *** r-daneel has quit IRC | 14:12 | |
| *** rloo has quit IRC | 14:12 | |
| olivierbourdon38 | whereas there is already an entry in /opt/stack/requirements/requirents.txt which states: python-openstackclient===3.14.0 | 14:12 |
| olivierbourdon38 | therefore the error | 14:12 |
| *** rloo has joined #openstack-ironic | 14:12 | |
| dtantsur | rloo: I think we can ignore postgres *for now* | 14:13 |
| olivierbourdon38 | however couldn't this also occur with the keystone git repo code above | 14:13 |
| rloo | dtantsur: ok :) | 14:13 |
| dtantsur | olivierbourdon38: keystone is not in global-requirements (nor are any other services) | 14:13 |
| olivierbourdon38 | currently it succeed because there is no entry for keystone in requirements.txt | 14:13 |
| dtantsur | correct. so the contraints are only applied to keystone dependencies, but not to keystone *itself* | 14:13 |
| *** sekharvajjula has quit IRC | 14:13 | |
| *** shekarvajjula has joined #openstack-ironic | 14:13 | |
| olivierbourdon38 | ok I think I get the idea, thanks | 14:14 |
| dtantsur | you're welcome | 14:14 |
| *** e0ne has quit IRC | 14:17 | |
| *** ianychoi has joined #openstack-ironic | 14:17 | |
| * rloo updated whiteboard with status of postgres job. now on to bigger and better things... | 14:18 | |
| sambetts | TheJulia: I'm sure I've seen an issue with the VIPs like this before, I think if I remember correctly it was an issue with the MTU we had configured on the links (but I thought we fixed that) | 14:23 |
| sambetts | again maybe we forgot the backport :/ | 14:23 |
| *** hjensas has joined #openstack-ironic | 14:23 | |
| TheJulia | It feels very dejavu-ish | 14:23 |
| TheJulia | mtu is 1450 | 14:23 |
| TheJulia | i think | 14:24 |
| mjturek | gm ironic! | 14:25 |
| sambetts | o/ mjturek | 14:25 |
| openstackgerrit | Olivier Bourdon proposed openstack/bifrost master: WIP: Fix for proper deployment when keystone enabled and minimal OS https://review.openstack.org/540713 | 14:31 |
| *** r-daneel has joined #openstack-ironic | 14:31 | |
| sambetts | TheJulia: looking at the logs you linked on the whiteboard, the baremetal boots up and does the deploy OK, then reboots to boot into the guest image and never makes it to the OS | 14:33 |
| sambetts | TheJulia: which would be why it isn't responding to the pings/arps etc from the VIP | 14:34 |
| sambetts | TheJulia: it seems like its trying to boot from PXE into the guest image and is failing | 14:34 |
| *** rbudden has joined #openstack-ironic | 14:35 | |
| sambetts | TheJulia: but thats expected because it its now in the tenant network and we don't support PXE there | 14:35 |
| *** lucasagomes is now known as lucas-hungry | 14:35 | |
| sambetts | TheJulia: looking at the vbmc logs I never see a call to switch the boot device to HDD for the VMs | 14:36 |
| TheJulia | but why now? | 14:37 |
| *** baha has joined #openstack-ironic | 14:39 | |
| sambetts | that is the question, the networking for the VMs on reboot is working though, because they are getting an IP address from the tenant network DHCP | 14:40 |
| *** vsaienk0 has quit IRC | 14:43 | |
| *** vsaienk0 has joined #openstack-ironic | 14:43 | |
| TheJulia | same version of ovs between working/not working | 14:44 |
| sambetts | yeah, I don't think the networking is the issue, that actually seems to be doing what it should be | 14:44 |
| sambetts | but the VM is sat in this state: http://logs.openstack.org/32/540432/2/check/ironic-grenade-dsvm-multinode-multitenant/199b2f4/logs/old/ironic-bm-logs/node-1_no_ansi_2018-02-05-12:50:36.txt.gz | 14:45 |
| sambetts | I wonder if there was a change in libvirt or something where it used to boot from hdd if it failed to PXE | 14:46 |
| sambetts | but now it doesn't | 14:46 |
| TheJulia | same version of libvirt | 14:46 |
| sambetts | hmmm | 14:46 |
| * TheJulia checked last night | 14:46 | |
| TheJulia | always the same three tests... | 14:47 |
| sambetts | have we got a link to logs for this job last time it passed? | 14:47 |
| TheJulia | one moment | 14:47 |
| dtantsur | TheJulia, rloo, https://review.openstack.org/#/c/541694/ | 14:47 |
| patchbot | patch 541694 - ironic - Add 10.1 and queens to the release mapping | 14:47 |
| sambetts | TheJulia: have we changed the type of image used for the job recently? | 14:49 |
| TheJulia | sambetts: http://logs.openstack.org/42/526442/2/check/ironic-grenade-dsvm-multinode-multitenant/7a88329/logs/ this passed on stable/pike about a week ago | 14:49 |
| TheJulia | although we should likely be looking at http://logs.openstack.org/42/526442/2/check/ironic-grenade-dsvm/035fa33/ since that is entirely pike | 14:50 |
| rloo | dtantsur: looking... | 14:50 |
| TheJulia | sambetts: another master job that worked on stable/pike grenade https://review.openstack.org/#/c/537650/ | 14:52 |
| patchbot | patch 537650 - ironic - Be more sane about cleaning (MERGED) | 14:52 |
| *** athomas has quit IRC | 14:52 | |
| *** zhangfei has quit IRC | 14:53 | |
| *** dpawar has joined #openstack-ironic | 14:55 | |
| sambetts | TheJulia: looking at the devstack log, we set the default boot option for ironic to netboot which is wrong for a multi-tenant deployment | 14:56 |
| *** dpawar has quit IRC | 14:56 | |
| *** e0ne has joined #openstack-ironic | 14:56 | |
| sambetts | this might have always been wrong and we might have been relying on the wholedisk image type to force it to boot option local | 14:56 |
| TheJulia | sambetts: well yes however that is also our default operating behvior | 14:56 |
| sambetts | but this is a multi-tenant job, boot option net is never going to work | 14:57 |
| sambetts | shouldn't we be configuring it correctly, and seeing if that fixes the issue? | 14:58 |
| sambetts | either that or we need to make sure that we are setting boot_option=local on the nodes as we enroll them | 14:59 |
| TheJulia | agreed, I noticed none being set. Worth a try at least, a direct patch to stable/pike for now? | 15:00 |
| olivierbourdon38 | anybody could help with finding out what is wrong in http://logs.openstack.org/13/540713/8/check/bifrost-integration-dibipa-debian-centos-7/ef448a2/job-output.txt.gz or is it just a transient failure ? | 15:00 |
| TheJulia | dib dependency failure I guess http://logs.openstack.org/13/540713/8/check/bifrost-integration-dibipa-debian-centos-7/ef448a2/job-output.txt.gz#_2018-02-07_14_43_26_793376 | 15:01 |
| *** marios has quit IRC | 15:02 | |
| sambetts | TheJulia: I think I know whats going on... | 15:03 |
| *** dpawar has joined #openstack-ironic | 15:03 | |
| sambetts | TheJulia: and whats made the change | 15:03 |
| * sambetts just confirming my theory | 15:03 | |
| *** SerenaFeng has quit IRC | 15:05 | |
| openstackgerrit | Julia Kreger proposed openstack/ironic stable/pike: Test switching to local default boot https://review.openstack.org/541741 | 15:05 |
| sambetts | TheJulia: making a change to the job on stable/pike won't work | 15:06 |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic-python-agent master: Add documentation for rescue mode https://review.openstack.org/431622 | 15:06 |
| sambetts | TheJulia: the grenade job runs the master playbook | 15:06 |
| TheJulia | doh, yeah | 15:06 |
| *** vsaienk0 has quit IRC | 15:06 | |
| sambetts | TheJulia: and I think thats whats broken things | 15:06 |
| sambetts | TheJulia: because we've change the grenade job playbook to use hardware types | 15:06 |
| sambetts | but its actually running the pike devstack plugin | 15:07 |
| TheJulia | that would do it | 15:07 |
| sambetts | so master grenade playbook local.conf + pike devstack plugin | 15:07 |
| sambetts | == boom | 15:07 |
| sambetts | TheJulia: https://review.openstack.org/#/c/536875/ | 15:08 |
| patchbot | patch 536875 - ironic - Switch the CI to hardware types (MERGED) | 15:08 |
| sambetts | that patch ^ | 15:08 |
| *** dsneddon has quit IRC | 15:09 | |
| openstackgerrit | Olivier Bourdon proposed openstack/bifrost master: Fix for proper deployment when keystone enabled and minimal OS https://review.openstack.org/540713 | 15:09 |
| dtantsur | so, how many times have I broken things with that patch? :) | 15:09 |
| TheJulia | oh | 15:10 |
| TheJulia | well direct deploy traditionally implied always local boot | 15:10 |
| TheJulia | unless the patch to change that landed... | 15:10 |
| sambetts | yeah I thought that was the case too | 15:11 |
| * rloo thinks we don't land any of dtantsur's features so close to release :) | 15:11 | |
| TheJulia | but the conductor logs are also indicates none set, so it goes to default | 15:11 |
| TheJulia | we must have a bug somewhere in stable/pike that we're hitting | 15:12 |
| sambetts | there is a lot of logic in the stable/pike devstack plugin that regexs on the node driver being agent_* | 15:12 |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic master: Clean up release notes before a release https://review.openstack.org/541744 | 15:14 |
| dtantsur | everyone's (esp. rloo's) favourite part ^^^ | 15:14 |
| sambetts | there is also no logic in the stable/pike driver for reading the value of IRONIC_DEFAULT_DEPLOY_INTERFACE | 15:14 |
| rloo | 'favorite' cuz it means we're going to release soon. the only bright side :) | 15:14 |
| sambetts | so its using the default for the IPMI hardware type | 15:15 |
| sambetts | which I'm guessing isn't direct? | 15:15 |
| sambetts | hence why its no using local | 15:15 |
| dtantsur | yep, the default is iscsi | 15:15 |
| dtantsur | meh | 15:16 |
| sambetts | and the ugly beasty reveals itself | 15:16 |
| * TheJulia adds "change default boot mode" to the list for the cycle | 15:16 | |
| dtantsur | so, do we just need to return this grenade to classic drivers? that should be easy | 15:16 |
| dtantsur | TheJulia++++++++++++++++++++++++++++++++++ | 15:16 |
| sambetts | yeah | 15:16 |
| sambetts | I'll put up a partial revert of your patch to restore the old grenade local.conf | 15:17 |
| sambetts | and we've got to remember that the grenade job is special because the local.conf in there is for the "old" part of the grenade | 15:17 |
| sambetts | run | 15:17 |
| rloo | sambetts: with a note that we can't change it to hw type until Rocky | 15:18 |
| TheJulia | sambetts: if you put a giant warning note in as well, then +++++ | 15:18 |
| rloo | sambetts: the more comments there the better | 15:18 |
| dtantsur | funny enough, I've hit a similar problem with inspector grenade, but I did not link the two events | 15:18 |
| * dtantsur needs a PTO? | 15:19 | |
| rloo | nope, we all need to figure out how to do this w/o trying to cram in sooo much stuff at the end | 15:20 |
| TheJulia | pto +++++ | 15:20 |
| * TheJulia needs PTO too | 15:20 | |
| *** vsaienk0 has joined #openstack-ironic | 15:21 | |
| peitolm | PTO? | 15:21 |
| dtantsur | TheJulia: in very little time you're going to lose the right to have PTOs :D | 15:22 |
| peitolm | Purple thingy objects? | 15:23 |
| dtantsur | LOL | 15:23 |
| dtantsur | paid time off, but I like your idea better | 15:23 |
| *** AlexeyAbashkin has quit IRC | 15:24 | |
| *** AlexeyAbashkin has joined #openstack-ironic | 15:24 | |
| TheJulia | dtantsur: translation, I should take a few days off sooner rather than later | 15:25 |
| peitolm | in some countries a Purple thingy object might be currency | 15:25 |
| *** rbartal has quit IRC | 15:25 | |
| dtantsur | TheJulia: true | 15:25 |
| *** absubram has joined #openstack-ironic | 15:25 | |
| * TheJulia is liking the return of silly to the channel | 15:25 | |
| peitolm | my last PTO got me started with openstack.... | 15:26 |
| dtantsur | wow, how? | 15:26 |
| * peitolm bows | 15:26 | |
| peitolm | I had some time with the kids at school, the wife away and some free time, so i built an openstack lab | 15:26 |
| dtantsur | that's a curious idea how to spend free time :D | 15:27 |
| dtantsur | (says someone who's building an openstack SDK in rust in his spare time) | 15:27 |
| dtantsur | peitolm: anyway, now I'm curious: why an openstack lab? | 15:28 |
| peitolm | well, usually i'm too beat in the evenings to hack around with tech, so end up on the games console, watching mindless TV, or playing Clash of Clans, (or all three) | 15:28 |
| peitolm | why openstack? well, i can build HPC compute clusters, and i've had a play with IBM cloud private, so why not try openstack, seems to be getting a lot of visibilty, so i was curious | 15:30 |
| *** absubram has quit IRC | 15:30 | |
| peitolm | gernally it boils down to, welll, why not | 15:30 |
| dtantsur | that's quite a reason, I agree | 15:30 |
| *** absubram has joined #openstack-ironic | 15:31 | |
| peitolm | i'm considering investigating it further for work, but wanted to play at home first, i wanted to understand how it (mostly) fits together | 15:31 |
| *** lucas-hungry is now known as lucasagomes | 15:32 | |
| dtantsur | and how is it looking so far? | 15:32 |
| dtantsur | cores, if we land https://review.openstack.org/#/c/541584/ and https://review.openstack.org/#/c/537968/ we'll be ready for IPA release (modulo reno?) | 15:32 |
| patchbot | patch 541584 - ironic-python-agent - When ouputting to /dev/null should open in write mode | 15:32 |
| patchbot | patch 537968 - ironic-python-agent - Replace curly quotes with straight quotes | 15:32 |
| peitolm | dtantsur: well, the simple version with vm deployment on a hypervisor worked, | 15:33 |
| peitolm | i'm stuck getting ironic working though, which is why i'm here, TheJulia has been most helpful with where to look, and patient enough with what i'm sure are stupid questions | 15:34 |
| *** dpawar has quit IRC | 15:34 | |
| dtantsur | most of "stupid" questions may in reality be a lack of documentation on our side | 15:35 |
| *** dpawar has joined #openstack-ironic | 15:35 | |
| dtantsur | which is something where contributions are always welcome ;) | 15:35 |
| openstackgerrit | OpenStack Release Bot proposed openstack/ironic-inspector stable/queens: Update .gitreview for stable/queens https://review.openstack.org/541748 | 15:35 |
| openstackgerrit | OpenStack Release Bot proposed openstack/ironic-inspector stable/queens: Update UPPER_CONSTRAINTS_FILE for stable/queens https://review.openstack.org/541749 | 15:35 |
| openstackgerrit | OpenStack Release Bot proposed openstack/ironic-inspector master: Update reno for stable/queens https://review.openstack.org/541750 | 15:35 |
| peitolm | unfortunately, some of that was true, (and some of it is because i'm using the pike release as packaged by ubuntu), so i think i got lost between sets of documentation | 15:35 |
| rloo | dtantsur: wrt release notes, I feel like we should have one features note about rescue, with subpoints is ok. but right now, it is 3 main points | 15:36 |
| rloo | dtantsur: and the three points aren't even together | 15:36 |
| dtantsur | rloo: I'm fine with that. what I did not like is that the list heading was talking about API | 15:36 |
| peitolm | now i'm not sure if i'm stuck because i'm hitting a bug, or some side-affect of the translation from HV&VM setup to ironic | 15:36 |
| rloo | dtantsur: heh, i didn't even look at your changes, am just reading http://logs.openstack.org/44/541744/1/check/build-openstack-releasenotes/adc6973/html/unreleased.html :) | 15:37 |
| dtantsur | rloo: which three btw? do you want the validate_rescue change to be merged into "features"? | 15:37 |
| rloo | dtantsur: also, for prelude, is it worth mentioning traits there. and/or rescue (even though we haven't totally finished)? | 15:38 |
| dtantsur | Not sure. For me prelude is something "omg big and important" | 15:38 |
| dtantsur | rescue is not finished, dunno how important traits are for people right now.. | 15:38 |
| rloo | dtantsur: 'Adds rescue_interface field...', 'Adds version 1.38 of the Bare Metal API...', 'Adds new configuration options for the rescue feature' | 15:38 |
| dtantsur | s/people/consumers/ | 15:38 |
| rloo | dtantsur: can't admin start using traits for scheduling with nova? | 15:39 |
| dtantsur | they totally can, I'm just not sure it's worth a prelude | 15:39 |
| dtantsur | ditto for routed networks support | 15:39 |
| *** dpawar has quit IRC | 15:39 | |
| rloo | dtantsur: here's 9.1.0 prelude: https://docs.openstack.org/releasenotes/ironic/pike.html#id7 | 15:40 |
| dtantsur | ah, of this style. yes, I can do something alike | 15:40 |
| peitolm | q: is pike the current stable, or is that queens? | 15:41 |
| dtantsur | peitolm: pike is | 15:41 |
| dtantsur | we're releasing queens final really soon though | 15:42 |
| rloo | dtantsur: also for prelude, don't know if we want to mention stuff from 10.0, eg ansible deploy interface. | 15:42 |
| peitolm | ok. a followup then, if pike is the current stable, then what is latest? (as far as documentation is concerned) | 15:43 |
| rloo | peitolm: latest == master branch | 15:43 |
| peitolm | o.k. so latest is really "unstable" or "development" | 15:44 |
| rloo | peitolm: no unstable code here, development is acceptable :) | 15:45 |
| peitolm | o.k. | 15:45 |
| *** vsaienk0 has quit IRC | 15:45 | |
| dtantsur | rloo: in Pike we did, so I guess so | 15:46 |
| openstackgerrit | Sam Betts proposed openstack/ironic master: Partial revert of "Switch the CI to hardware types" https://review.openstack.org/541755 | 15:46 |
| sambetts | TheJulia, dtantsur ^ | 15:46 |
| TheJulia | I was just going to ask about that :) | 15:46 |
| TheJulia | sambetts: dtantsur should we keep swift settings... granted nothing else related was backported so maybe not | 15:48 |
| *** snasir has quit IRC | 15:49 | |
| dtantsur | to be honest, I'd prefer we only change what is needed to fix the job | 15:49 |
| dtantsur | but I won't block it based on that | 15:50 |
| TheJulia | works for me | 15:50 |
| *** snasir has joined #openstack-ironic | 15:50 | |
| openstackgerrit | Ilya Etingof proposed openstack/sushy-tools master: Abstract away the virtualization management interface https://review.openstack.org/523321 | 15:50 |
| openstackgerrit | Julia Kreger proposed openstack/ironic master: Return multinode multitenant to voting status https://review.openstack.org/537739 | 15:50 |
| *** devananda has joined #openstack-ironic | 15:50 | |
| dtantsur | sambetts: let's maybe only change the drivers back? I'd prefer a oneline diff, not a revert :) | 15:51 |
| TheJulia | sambetts: jlvillal has asked why on the subject, likely just a slightly more verbose commit message | 15:52 |
| jlvillal | TheJulia, +1 | 15:53 |
| jlvillal | :) | 15:53 |
| *** dsneddon has joined #openstack-ironic | 15:53 | |
| openstackgerrit | Merged openstack/ironic master: Do not pass credentials to the ramdisk on cleaning https://review.openstack.org/541683 | 15:55 |
| sambetts | at some point we've got to convert all this to non-legacy jobs | 15:55 |
| TheJulia | I was actually thinking about that in the shower a little while aog | 15:56 |
| dtantsur | totally, but I'd prefer to keep them clean anyway | 15:56 |
| *** SerenaFeng has joined #openstack-ironic | 15:56 | |
| TheJulia | do we want to merge the vif detach locking change? | 15:57 |
| NobodyCam | Good Morning Ironic'ers | 16:00 |
| openstackgerrit | Sam Betts proposed openstack/ironic master: Revert grenade jobs to classic drivers https://review.openstack.org/541755 | 16:00 |
| sambetts | updated ^ | 16:00 |
| *** SerenaFeng has quit IRC | 16:01 | |
| dtantsur | morning NobodyCam | 16:01 |
| NobodyCam | :) happy hump day dtantsur :) | 16:01 |
| *** ricardoas has joined #openstack-ironic | 16:02 | |
| dtantsur | rloo: do you have more comments on the release notes? if not, I'll post an update | 16:03 |
| rloo | dtantsur: yup, i do. give me a few minutes, i have a few more | 16:03 |
| *** mjura has quit IRC | 16:03 | |
| *** pcaruana has quit IRC | 16:03 | |
| dtantsur | ack | 16:03 |
| *** SerenaFeng has joined #openstack-ironic | 16:06 | |
| openstackgerrit | Merged openstack/networking-baremetal master: Make the agent distributed using hashring and notifications https://review.openstack.org/524709 | 16:11 |
| openstackgerrit | Merged openstack/ironic master: Fix handling of 'timeout' parameter to power methods https://review.openstack.org/540150 | 16:14 |
| openstackgerrit | Merged openstack/ironic master: Use zuul.override_checkout instead of custom branch_override var https://review.openstack.org/540432 | 16:14 |
| openstackgerrit | Merged openstack/ironic-python-agent master: Add documentation for rescue mode https://review.openstack.org/431622 | 16:14 |
| dtantsur | rloo: thanks! to be honest, I don't think I have enough patience to group vendor stuff :) | 16:17 |
| rloo | dtantsur: i know :-( it would be nicer though. but hey, i suppose they could do it themselves... | 16:17 |
| rloo | dtantsur: i have to stop spending brain cells thinking about how to make things nicer for the reader! | 16:18 |
| *** dpawar has joined #openstack-ironic | 16:18 | |
| rloo | sambetts: i didn't +2 cuz I have a question: https://github.com/openstack/ironic/blob/master/doc/source/install/configure-networking.rst | 16:19 |
| rloo | sambetts: i'm blind, i see your comment now | 16:20 |
| openstackgerrit | Merged openstack/networking-baremetal master: Add unit tests for member manager https://review.openstack.org/541216 | 16:21 |
| openstackgerrit | Sam Betts proposed openstack/ironic master: Revert grenade jobs to classic drivers https://review.openstack.org/541755 | 16:22 |
| jlvillal | sambetts, FYI: merge conflict on ^^^ | 16:23 |
| sambetts | yup... fixing :) | 16:23 |
| jlvillal | :) | 16:23 |
| jlvillal | sambetts, I think that merge conflict is that fault of sambetts' zuul.override_checkout patch merging ;) | 16:24 |
| jlvillal | s/that fault/the fault/ | 16:24 |
| sambetts | yup | 16:25 |
| jlvillal | I'll let you complain to him :) | 16:25 |
| sambetts | its my own fault ;) | 16:25 |
| rloo | jlvillal: sigh, that sambetts, always causing trouble | 16:25 |
| rloo | dtantsur: should we update commit msg, or are you OK w/o? https://review.openstack.org/#/c/540830/4/playbooks/legacy/tempest-dsvm-ironic-ipa-partition-bios-pxe_ipmitool-tinyipa/run.yaml | 16:25 |
| patchbot | patch 540830 - ironic (stable/ocata) - Use zuul.override_checkout instead of custom bran... | 16:25 |
| dtantsur | rloo: since it does not touch production code, I'm kinda okay with it | 16:26 |
| dtantsur | or like: I'd update it, but I don't want to wait 2-3 more hours for the check queue | 16:26 |
| rloo | dtantsur: ok, at least there are comments there if anyone is curious. and yeah, if we had lots of time etc | 16:26 |
| *** ijw has joined #openstack-ironic | 16:26 | |
| openstackgerrit | Sam Betts proposed openstack/ironic master: Revert grenade jobs to classic drivers https://review.openstack.org/541755 | 16:27 |
| *** ijw has quit IRC | 16:28 | |
| *** ijw has joined #openstack-ironic | 16:28 | |
| *** jaganathan has joined #openstack-ironic | 16:33 | |
| *** dpawar has quit IRC | 16:34 | |
| *** dpawar has joined #openstack-ironic | 16:36 | |
| *** amarao has quit IRC | 16:37 | |
| *** absubram has quit IRC | 16:37 | |
| openstackgerrit | Julia Kreger proposed openstack/ironic master: Return multinode multitenant to voting status https://review.openstack.org/537739 | 16:37 |
| openstackgerrit | Merged openstack/ironic-inspector stable/ocata: Remove use of construct lib FieldError exception https://review.openstack.org/541271 | 16:39 |
| *** dpawar has quit IRC | 16:40 | |
| *** dprince has joined #openstack-ironic | 16:43 | |
| *** zhangfei has joined #openstack-ironic | 16:43 | |
| *** zhangfei has quit IRC | 16:45 | |
| jroll | good morning | 16:45 |
| sambetts | o/ jroll | 16:45 |
| * jroll sees you all have done everything already this morning | 16:45 | |
| sambetts | its certainly been a busy morning ;) | 16:46 |
| jroll | I'm basically not here today, internal conf thing | 16:46 |
| dtantsur | morning jroll | 16:46 |
| TheJulia | good morning jroll | 16:47 |
| jroll | \o | 16:47 |
| NobodyCam | morning jroll | 16:47 |
| *** baha has quit IRC | 16:48 | |
| rloo | good morning jroll, NobodyCam, jlvillal | 16:49 |
| NobodyCam | Good morning rloo :) | 16:49 |
| *** e0ne has quit IRC | 16:49 | |
| jlvillal | Good morning rloo jroll NobodyCam TheJulia sambetts dtantsur and everyone else | 16:49 |
| NobodyCam | hey hey jlvillal top of the morning to ya | 16:49 |
| jroll | feels like everyone is here today \o/ | 16:50 |
| sambetts | \o/ | 16:51 |
| TheJulia | woot, one +2 on 534441 | 16:55 |
| *** jaganathan has quit IRC | 16:56 | |
| *** dprince has quit IRC | 16:59 | |
| *** absubram has joined #openstack-ironic | 16:59 | |
| jroll | that's the +2 we really needed on it, too :) | 17:00 |
| * jroll reviews now | 17:00 | |
| *** absubram has quit IRC | 17:00 | |
| *** SerenaFeng has quit IRC | 17:01 | |
| openstackgerrit | Ilya Etingof proposed openstack/sushy-tools master: Abstract away the virtualization management interface https://review.openstack.org/523321 | 17:02 |
| TheJulia | indeed | 17:02 |
| *** SerenaFeng has joined #openstack-ironic | 17:05 | |
| rloo | TheJulia: wrt 534441 do we want a reno? | 17:08 |
| *** rpioso|afk is now known as rpioso | 17:08 | |
| *** SerenaFeng has quit IRC | 17:09 | |
| *** harlowja has joined #openstack-ironic | 17:11 | |
| dtantsur | simple patch for approval, I think the last for IPA queens: https://review.openstack.org/#/c/541584/ | 17:12 |
| patchbot | patch 541584 - ironic-python-agent - When ouputting to /dev/null should open in write mode | 17:12 |
| dtantsur | TheJulia: how is bifrost looking? I can leave it up to you to submit the release later today though | 17:13 |
| TheJulia | rloo: I guess we ought to | 17:14 |
| TheJulia | dtantsur: I can release it later, I've not had a chance to look today, but I think I just needed nobodycam to do a review or two | 17:15 |
| dtantsur | pas-ha: wanna release ironic-staging-drivers and create stable/queens? | 17:15 |
| dtantsur | TheJulia: ack | 17:15 |
| TheJulia | rloo: how much detail are you thinking would be good regarding a release note? | 17:16 |
| * NobodyCam opens review queue | 17:16 | |
| TheJulia | NobodyCam: <3 | 17:16 |
| rloo | TheJulia: i hadn't thought about it. | 17:16 |
| TheJulia | NobodyCam: do I owe you coffee now? | 17:16 |
| * rloo thinks which crunching on a carrot... | 17:16 | |
| * TheJulia just started a bagel toasting | 17:16 | |
| NobodyCam | :) | 17:16 |
| dtantsur | anyone wants to try to fit https://review.openstack.org/#/c/541289/ in the release? | 17:17 |
| patchbot | patch 541289 - ironic - Stop guessing mime types based on URLs | 17:17 |
| dtantsur | may not be a trivial addition though :) | 17:17 |
| *** harlowja has quit IRC | 17:17 | |
| rloo | TheJulia: something like 'Fixes an issue where the Compute service failed to delete the instance because the VIF couldn't be deleted? | 17:18 |
| rloo | dtantsur: it is on my list. i was deciding whether to do that or Julia's first. I can still be swayed :) | 17:18 |
| dtantsur | rloo: Julia's goes first IMO | 17:18 |
| rloo | dtantsur: are you trying to do a release today or tomorrow? | 17:18 |
| dtantsur | tomorrow morning (my) is fine | 17:19 |
| rloo | oh, i think staging drivers will break. someone needs to add timeout parameter. | 17:19 |
| dtantsur | *I* will not do a release today anyway, a bit too late. Julia may. if she does not - I will do tomorrow. | 17:19 |
| rloo | pas-ha: ^^ wrt staging drivers. i'll try to push up a patch later today after reviewin | 17:20 |
| rloo | dtantsur, TheJulia: let's do it tomorrow then :) | 17:20 |
| TheJulia | then both I think :) | 17:20 |
| dtantsur | IPA can go in today, I suspect, when everything merges | 17:21 |
| rpioso | Good morning, all | 17:22 |
| *** vsaienk0 has joined #openstack-ironic | 17:24 | |
| *** AlexeyAbashkin has quit IRC | 17:26 | |
| *** tesseract has quit IRC | 17:27 | |
| *** crushil_ has quit IRC | 17:28 | |
| dtantsur | morning rpioso | 17:28 |
| rpioso | Hey dtantsur :) | 17:29 |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic master: Clean up release notes before a release https://review.openstack.org/541744 | 17:31 |
| dtantsur | rloo: let's try this ^^^ | 17:31 |
| dtantsur | can someone please take over this patch and address the comments, if any? | 17:32 |
| * rloo tries to be happy about that | 17:32 | |
| dtantsur | I have to go and we need it landed before branching | 17:32 |
| rloo | dtantsur: yup, two things. the renos and that mimetype patch of yours. don't worry. we'll take care of them. | 17:32 |
| dtantsur | cool, thanks! | 17:33 |
| *** dtantsur is now known as dtantsur|afk | 17:33 | |
| dtantsur|afk | o/ | 17:33 |
| *** absubram has joined #openstack-ironic | 17:33 | |
| rloo | bye dtantsur|afk! | 17:33 |
| *** vsaienk0 has quit IRC | 17:33 | |
| NobodyCam | have a good night dtantsur|afk | 17:36 |
| openstackgerrit | Merged openstack/bifrost master: Fix for proper deployment when keystone enabled and minimal OS https://review.openstack.org/540713 | 17:39 |
| rpioso | Good evening, dtantsur|afk | 17:39 |
| *** baha has joined #openstack-ironic | 17:39 | |
| *** baha1 has joined #openstack-ironic | 17:40 | |
| openstackgerrit | Julia Kreger proposed openstack/ironic master: Don't try to lock for vif detach https://review.openstack.org/534441 | 17:41 |
| TheJulia | rloo: sambetts ^^^ | 17:41 |
| rloo | TheJulia: I'm still working on the previous revision. stuck on the unit tests. (WHICH I HATE) | 17:41 |
| TheJulia | :( | 17:42 |
| *** baha has quit IRC | 17:42 | |
| *** baha1 is now known as baha | 17:42 | |
| rloo | TheJulia: commented, I am not convinced the unit tests are correct :-( | 17:47 |
| TheJulia | ugh | 17:48 |
| rloo | TheJulia: this is why it takes me so long to review. I don't like reviewing unit tests, so i have to force myself to actually look and understand them. | 17:48 |
| TheJulia | yay scope creep | 17:48 |
| *** snasir has quit IRC | 17:49 | |
| *** crushil has joined #openstack-ironic | 17:49 | |
| *** crushil_ has joined #openstack-ironic | 17:49 | |
| TheJulia | makes sense to be very explicit in-line and document it | 17:50 |
| TheJulia | I'm not sure I'm groking your test comments | 17:51 |
| rloo | TheJulia: which ones? all of them? | 17:52 |
| openstackgerrit | Merged openstack/ironic master: Add 10.1 and queens to the release mapping https://review.openstack.org/541694 | 17:52 |
| TheJulia | commented | 17:53 |
| TheJulia | tl;dr is the reservation is present and the test ensures that that the task still executes when the node is locked | 17:54 |
| TheJulia | as it would be during a long running task | 17:54 |
| TheJulia | woot, it looks like the multinode test works, it is actually upgrading | 17:55 |
| sambetts | \o/ | 17:56 |
| rloo | TheJulia: ah, i commented -- maybe rename the test then. and a comment. or maybe it was just me that didn't grok it | 17:56 |
| rloo | TheJulia: YAY wrt multinode test! | 17:56 |
| TheJulia | I can rename it | 17:56 |
| TheJulia | I have a meeting in a couple minutes, will try to push a new version soon | 17:57 |
| rloo | TheJulia: no worries. we have time. | 17:57 |
| rloo | when did grenade start failing in pike? https://review.openstack.org/#/c/541703/ | 17:58 |
| patchbot | patch 541703 - ironic (stable/pike) - Do not pass credentials to the ramdisk on cleaning | 17:58 |
| rloo | multinode grenade. did we just break something? | 17:58 |
| *** derekh has quit IRC | 17:59 | |
| *** olivierbourdon38 has quit IRC | 17:59 | |
| *** e0ne has joined #openstack-ironic | 18:04 | |
| *** crushil_ has quit IRC | 18:06 | |
| TheJulia | welp, looks like no meeting | 18:08 |
| * TheJulia finishes updates | 18:08 | |
| *** mgoddard_ has quit IRC | 18:08 | |
| *** jaganathan has joined #openstack-ironic | 18:09 | |
| TheJulia | rloo: re test name, I would interpret it that the test is trying to obtain an exclusive lock, I'll try to think of something more clear | 18:10 |
| *** devananda has quit IRC | 18:10 | |
| rloo | TheJulia: 'foo' is ok with me, as long as there is a comment :) Long test names aren't that friendly either. | 18:10 |
| *** jaganathan has quit IRC | 18:10 | |
| *** harlowja has joined #openstack-ironic | 18:11 | |
| TheJulia | rloo: heh, yeah :) Call it purple! | 18:13 |
| rloo | TheJulia: :D | 18:13 |
| * TheJulia feels an april fools prank coming on | 18:13 | |
| *** harlowja has quit IRC | 18:18 | |
| TheJulia | rloo: I believe that would be the first instance I've seen of it fail on pike | 18:18 |
| TheJulia | well, recently | 18:18 |
| *** mjturek has quit IRC | 18:18 | |
| TheJulia | rloo: unit tests running..... | 18:18 |
| *** baha has quit IRC | 18:18 | |
| rloo | TheJulia: i am wondering if I should just do a recheck. my other thought is the change we just did to fix the ironic-tempest-plugin issue. but i haven't actually looked into it | 18:19 |
| TheJulia | dmitry already did | 18:19 |
| TheJulia | recheck that is | 18:20 |
| TheJulia | It should still be looked at though | 18:20 |
| rloo | TheJulia: oh good (about the recheck) | 18:20 |
| openstackgerrit | Merged openstack/ironic stable/ocata: Do not pass credentials to the ramdisk on cleaning https://review.openstack.org/541704 | 18:20 |
| rloo | TheJulia: I just looked at dmitry's https://review.openstack.org/#/c/541289/. If you have a chance, would you look. I'm now worried about merging it in w/o more discussion | 18:20 |
| patchbot | patch 541289 - ironic - Stop guessing mime types based on URLs | 18:20 |
| TheJulia | ugh | 18:21 |
| TheJulia | internal server errors now on grenade | 18:21 |
| * TheJulia wonders if we ran out of memory | 18:21 | |
| rloo | TheJulia: :-(((((( | 18:21 |
| *** etingof has quit IRC | 18:21 | |
| TheJulia | segfaulting python is back! | 18:23 |
| TheJulia | http://logs.openstack.org/55/541755/4/check/ironic-grenade-dsvm-multinode-multitenant/9453b6b/logs/syslog.txt.gz#_Feb_07_18_05_52 | 18:23 |
| openstackgerrit | Julia Kreger proposed openstack/ironic master: Don't try to lock for vif detach https://review.openstack.org/534441 | 18:24 |
| TheJulia | rloo: http://logs.openstack.org/03/541703/1/gate/ironic-grenade-dsvm-multinode-multitenant/abbf674/job-output.txt.gz#_2018-02-07_17_29_40_332690 is quite possibly due to something like vifs not being unlocked in time or just performance issues (this was on stable/pike) | 18:26 |
| rloo | TheJulia: we will want to backport your vif change | 18:27 |
| *** r-daneel_ has joined #openstack-ironic | 18:28 | |
| rloo | TheJulia: the segfaulting python is the bigger worry now. | 18:28 |
| TheJulia | I'm going to stack my change to re-work the upgrade on top of the partial grenade revert since segfaulting python | 18:28 |
| TheJulia | oh | 18:28 |
| TheJulia | that required nova to land a patch | 18:29 |
| *** r-daneel has quit IRC | 18:29 | |
| *** r-daneel_ is now known as r-daneel | 18:29 | |
| *** rpioso is now known as rpioso|eat | 18:31 | |
| * rpioso|eat needs to carbo-load for cleaning up today's snowfall. | 18:32 | |
| *** baha has joined #openstack-ironic | 18:32 | |
| jlvillal | TheJulia, Any objection to me +A on https://review.openstack.org/#/c/541755/ ? | 18:38 |
| patchbot | patch 541755 - ironic - Revert grenade jobs to classic drivers | 18:38 |
| *** etingof has joined #openstack-ironic | 18:39 | |
| openstackgerrit | Sam Betts proposed openstack/ironic master: Ensure we unbind flat network ports and clear BM mac addresses https://review.openstack.org/539981 | 18:41 |
| * sambetts ---> home | 18:41 | |
| sambetts | night all o/ | 18:41 |
| sambetts | cya'll tomorrow | 18:41 |
| *** sambetts is now known as sambetts|afk | 18:41 | |
| TheJulia | jlvillal: none | 18:42 |
| openstackgerrit | Julia Kreger proposed openstack/ironic master: Rework upgrade to restart nova https://review.openstack.org/535596 | 18:42 |
| TheJulia | jlvillal: rloo: I have no idea if ^^^^ is going to fix our nova pains. Another thought... we could run a nova-compute and nova-conductor on both nodes... | 18:43 |
| TheJulia | if the primary node's install dies during the upgrade.. *shrug* | 18:43 |
| TheJulia | thoughts? | 18:43 |
| * rloo thinks that rolling upgrades was not worth it | 18:44 | |
| TheJulia | it is actually kind of a good test in that it is hte most possible racey test we could have in the gate where everything could possibly go wrong! | 18:45 |
| rloo | TheJulia: yes, it is a great test. Too bad it fails though :D | 18:46 |
| TheJulia | heh | 18:46 |
| jlvillal | TheJulia, As a note, multinode still fails with: https://review.openstack.org/#/c/541755/ | 18:46 |
| patchbot | patch 541755 - ironic - Revert grenade jobs to classic drivers | 18:46 |
| jlvillal | TheJulia, I noticed your patch on top of it. | 18:46 |
| TheJulia | yup | 18:46 |
| TheJulia | now nova-conductor segfaults! | 18:46 |
| TheJulia | *dance* | 18:47 |
| jlvillal | TheJulia, Ugh | 18:47 |
| *** shekarvajjula has quit IRC | 18:48 | |
| rloo | TheJulia: this is just for the normal grenade, not multinode: https://review.openstack.org/#/c/535596/6/devstack/upgrade/upgrade.sh | 18:48 |
| patchbot | patch 535596 - ironic - Rework upgrade to restart nova | 18:48 |
| *** shekarvajjula has joined #openstack-ironic | 18:48 | |
| openstackgerrit | Harald Jensås proposed openstack/networking-baremetal master: DNM - testing tripleo https://review.openstack.org/541705 | 18:48 |
| rloo | TheJulia: is normal grenade failing too? | 18:49 |
| TheJulia | rloo: no | 18:50 |
| TheJulia | doh | 18:50 |
| TheJulia | ERRTOOMUCHMULTITASKING | 18:50 |
| rloo | TheJulia: oh. ok then, that explains why I'm confused. Yeah, I think it is ok to go a bit slower. i'm good if we release and multinode grenade is still failing. as long as we address in next week or so. | 18:51 |
| rloo | TheJulia: otherwise you're gonna get really burned out and we may make mistakes. NOT that we haven't already... | 18:52 |
| TheJulia | I'm updating the patch now | 18:52 |
| *** mgoddard_ has joined #openstack-ironic | 18:53 | |
| openstackgerrit | Julia Kreger proposed openstack/ironic master: Rework upgrade to restart nova https://review.openstack.org/535596 | 18:54 |
| TheJulia | I'm hoping to take the next two days off, personally | 18:54 |
| rloo | TheJulia: good! | 18:56 |
| *** mjturek has joined #openstack-ironic | 18:58 | |
| rloo | TheJulia: wrt 535596. we haven't upgraded nova, just restarting. there could be a problem if the old nova doesn't work with new packages, right? | 18:58 |
| TheJulia | anyway, crossing my fingers that that finally gets that job working | 18:58 |
| TheJulia | rloo: absolutely | 18:58 |
| *** e0ne has quit IRC | 18:59 | |
| rloo | TheJulia: so they may not have been in a broken state, but could be in a broken state after restarting. Or they could have been in a broken state, and work after restarting :-( | 18:59 |
| rloo | TheJulia: or they could be broken regardless ... | 19:00 |
| TheJulia | yup yup yup | 19:00 |
| TheJulia | grenade: why we can't have nice things | 19:00 |
| rloo | WHO runs all their services on the same node and does an upgrade of them like grenade does it... | 19:00 |
| TheJulia | great question.... | 19:01 |
| rloo | TheJulia: can we go on strike? No rolling upgrade testing if our test framework doesn't make sense? | 19:01 |
| TheJulia | rloo: works for me | 19:01 |
| * TheJulia will bring coffee, and make signs | 19:01 | |
| rloo | TheJulia: ok, two +2, +A. Done. something to discuss at PTG? | 19:01 |
| TheJulia | and tea, lots of tea | 19:01 |
| rloo | TheJulia: how does anyone else test rolling upgrades? | 19:02 |
| rloo | PTG topic i think... | 19:02 |
| TheJulia | yeah... | 19:02 |
| TheJulia | We have tons of duplication too... I feel like we could almost use a "Here I'm running xyz s | 19:02 |
| TheJulia | err, xyz scenarios" and "here is upgrade testing" | 19:03 |
| TheJulia | and have half the jobs | 19:03 |
| rloo | TheJulia: sigh. i'd say a ptg topic but we always talk about it, then it sits in subteam thing and we never raise priority so nothing gets done to try to combine. | 19:04 |
| rloo | TheJulia: i hear you might be the next PTL. Thanks for looking into ^^ :) | 19:04 |
| TheJulia | heh :) | 19:06 |
| *** Goneri has quit IRC | 19:09 | |
| *** e0ne has joined #openstack-ironic | 19:10 | |
| *** Goneri has joined #openstack-ironic | 19:10 | |
| *** mjturek has quit IRC | 19:11 | |
| jroll | TheJulia: ++ on removing duplication | 19:12 |
| jroll | that was part of the intention with standalone - test most things in isolation there, do minimal full stack testign | 19:12 |
| jroll | we did the first half... | 19:13 |
| *** r-daneel_ has joined #openstack-ironic | 19:13 | |
| *** r-daneel has quit IRC | 19:14 | |
| *** r-daneel_ is now known as r-daneel | 19:14 | |
| TheJulia | yeah | 19:19 |
| *** mjturek has joined #openstack-ironic | 19:20 | |
| *** fragatina has joined #openstack-ironic | 19:21 | |
| rloo | jroll: since you reviewed it, I commented. If you have thoughts. https://review.openstack.org/#/c/541289/ | 19:24 |
| patchbot | patch 541289 - ironic - Stop guessing mime types based on URLs | 19:24 |
| jroll | rloo: replied | 19:32 |
| *** lucasagomes is now known as lucas-afk | 19:33 | |
| rloo | jroll: thx :) | 19:33 |
| openstackgerrit | Olivier Bourdon proposed openstack/bifrost master: Fix extra double-quote https://review.openstack.org/541696 | 19:33 |
| openstackgerrit | Merged openstack/ironic stable/pike: Use zuul.override_checkout instead of custom branch_override var https://review.openstack.org/540829 | 19:34 |
| openstackgerrit | Merged openstack/ironic-python-agent master: Replace curly quotes with straight quotes https://review.openstack.org/537968 | 19:34 |
| openstackgerrit | Merged openstack/ironic stable/ocata: Use zuul.override_checkout instead of custom branch_override var https://review.openstack.org/540830 | 19:34 |
| *** mgoddard_ has quit IRC | 19:35 | |
| *** AlexeyAbashkin has joined #openstack-ironic | 19:37 | |
| rloo | oh, need another core to review this. https://review.openstack.org/#/c/534441/ | 19:39 |
| patchbot | patch 534441 - ironic - Don't try to lock for vif detach | 19:39 |
| rloo | jlvillal, vdrok: you feel like reviewing ^^ | 19:40 |
| openstackgerrit | Merged openstack/ironic master: Handle case when a glance image contains no data https://review.openstack.org/531180 | 19:40 |
| openstackgerrit | Merged openstack/ironic master: Update iRMC document for classic driver deprecation https://review.openstack.org/541171 | 19:40 |
| *** mjturek has quit IRC | 19:41 | |
| *** mjturek has joined #openstack-ironic | 19:42 | |
| *** mjturek has quit IRC | 19:42 | |
| *** rpioso|eat is now known as rpioso | 19:42 | |
| vdrok | Will take a look in a bit | 19:47 |
| *** pcaruana has joined #openstack-ironic | 19:52 | |
| TheJulia | rloo: posted a quick reply to one, the spelling mistake in the reno we should just fix before +A'ing, anyway will let vdrok review it | 19:59 |
| rloo | TheJulia: works for me | 20:00 |
| rloo | TheJulia, jlvillal, vdrok: the last 'big' patch for the release (I hope): https://review.openstack.org/#/c/541289/ | 20:03 |
| patchbot | patch 541289 - ironic - Stop guessing mime types based on URLs | 20:03 |
| * rloo found out that eating Ben&Jerry icecream while reviewing made the experience that much better. Until the icecream was finished... | 20:04 | |
| * persia ponders the advantages of remunerating reviewers with endless ice cream conveyors, and how that affects freight charges for PTG attendance | 20:05 | |
| rloo | :D | 20:06 |
| *** pcaruana has quit IRC | 20:07 | |
| openstackgerrit | Merged openstack/ironic-inspector stable/queens: Update .gitreview for stable/queens https://review.openstack.org/541748 | 20:12 |
| TheJulia | rloo: lol | 20:14 |
| TheJulia | persia: It is not a bad idea... as long as we have time to also exercise such that the nonexistant ice cream calories are not counted against us when we visit the doctor | 20:15 |
| openstackgerrit | Ruby Loo proposed openstack/ironic master: Clean up release notes before a release https://review.openstack.org/541744 | 20:19 |
| *** fragatina has quit IRC | 20:20 | |
| persia | TheJulia: Ah, so the ice cream conveyor is powered by a treadmill at a standing desk? | 20:23 |
| TheJulia | persia: Indeed, excess energy can also be leveraged to power CI | 20:24 |
| persia | :) | 20:24 |
| TheJulia | That would actually be something I would exercise for.... faster running CI | 20:24 |
| *** jaganathan has joined #openstack-ironic | 20:26 | |
| openstackgerrit | Ruby Loo proposed openstack/ironic-inspector master: Update reno for stable/queens https://review.openstack.org/541750 | 20:27 |
| *** hw_wutianwei has quit IRC | 20:31 | |
| *** hw_wutianwei has joined #openstack-ironic | 20:32 | |
| *** AlexeyAbashkin has quit IRC | 20:33 | |
| *** mjturek has joined #openstack-ironic | 20:34 | |
| rloo | wow, this.is.an.old.patch: https://review.openstack.org/#/c/128701/ | 20:34 |
| patchbot | patch 128701 - ironic-python-agent - Refactor image writing | 20:34 |
| TheJulia | wow, yeah | 20:37 |
| *** mjturek has quit IRC | 20:38 | |
| *** mjturek has joined #openstack-ironic | 20:39 | |
| rloo | TheJulia: wrt 541289. I'm good with Closes-Bug, cuz I think we'll need an RFE to do the version thing, cuz it needs a version bump. So we coul use the same bug or a new one for that. | 20:41 |
| rloo | TheJulia: so we could edit it to be Partial if you want. I don't really care. It actually does fix the issue. except for that case with test & test.json. | 20:41 |
| rloo | TheJulia: I do think it is worth editing the reno to mention heartbeat endpoint. So i can update, just want to know if you want me to close the bug or not. | 20:43 |
| TheJulia | I think it still falls under a bug, since it an be a bug and force a version to be updated by the very nature of bugs. I was just thinking from a tracking standpoint, but who knows what tomorrow brings so closes is also fine with me | 20:51 |
| rloo | TheJulia: thx, am going to update the reno and then approve. | 20:52 |
| TheJulia | wfm! | 20:52 |
| TheJulia | thanks! | 20:52 |
| openstackgerrit | Merged openstack/ironic master: Revert grenade jobs to classic drivers https://review.openstack.org/541755 | 20:58 |
| openstackgerrit | Ruby Loo proposed openstack/ironic master: Stop guessing mime types based on URLs https://review.openstack.org/541289 | 20:58 |
| *** mrunge_ has joined #openstack-ironic | 21:02 | |
| *** mrunge has quit IRC | 21:03 | |
| *** crushil has quit IRC | 21:12 | |
| openstackgerrit | Vladyslav Drok proposed openstack/ironic master: Remove unnecessary lines from sample local.conf https://review.openstack.org/541900 | 21:12 |
| openstackgerrit | Vladyslav Drok proposed openstack/ironic master: Remove unnecessary lines from sample local.conf https://review.openstack.org/541900 | 21:14 |
| *** mjturek has quit IRC | 21:16 | |
| TheJulia | sigh, the sqlalchemy issue prevents us just restarting | 21:19 |
| TheJulia | I suspect the only viable option is to just run a conductor and compute process on the second node.... and leave them running. We might have to shift some timeouts.... | 21:19 |
| vdrok | TheJulia: left a question on detach patch | 21:20 |
| TheJulia | looking | 21:21 |
| *** crushil has joined #openstack-ironic | 21:22 | |
| *** e0ne has quit IRC | 21:23 | |
| *** e0ne has joined #openstack-ironic | 21:27 | |
| TheJulia | vdrok: replied | 21:27 |
| openstackgerrit | Merged openstack/bifrost master: Fix extra double-quote https://review.openstack.org/541696 | 21:34 |
| rpioso | Please explain the difference between a Code-Review:-1 and Code-Review:-2. | 21:37 |
| *** threestrands has joined #openstack-ironic | 21:39 | |
| jroll | rpioso: -1: should not be merged now, or should not be merged in its current state. -2: this should never be merged, or I'm making it 100% sure that this does not get merged without my knowledge. | 21:39 |
| jroll | that's how I tend to see it anyway | 21:39 |
| jroll | -2 is typically a procedural block, in short | 21:39 |
| rpioso | jroll: Thank you :) | 21:40 |
| jroll | rpioso: no problem. just so you know, -2s persist between patchsets, -1s do not. that's why -2 is often used for procedural things | 21:40 |
| rpioso | jroll: Interesting. I didn't realize that. | 21:41 |
| TheJulia | rpioso: For what it is worth, it is not uncommon for us to forget -2's, so if we need to get one removed just raise visibility | 21:44 |
| rpioso | TheJulia: Thank you | 21:44 |
| jroll | ++ | 21:45 |
| openstackgerrit | Merged openstack/ironic-tempest-plugin master: Switch to override-checkout for stable branch jobs https://review.openstack.org/540355 | 21:45 |
| openstackgerrit | Merged openstack/ironic-python-agent master: When ouputting to /dev/null should open in write mode https://review.openstack.org/541584 | 21:45 |
| rpioso | jroll, TheJulia: Could you give a couple of examples that would cause you to assign -2? | 21:46 |
| jroll | rpioso: the most common is because the spec isn't merged | 21:46 |
| * rpioso is not clear on procedural things | 21:46 | |
| jroll | or rfe isn't approved | 21:46 |
| rpioso | jroll: So, not the quality of the code? | 21:47 |
| TheJulia | rpioso: no, not the quality of the code at all | 21:47 |
| jroll | rpioso: another interesting case is like... a patch is ready to merge, but it makes huge changes and we shouldn't merge it the day before feature freeze | 21:47 |
| jroll | nope | 21:47 |
| rpioso | TheJulia, jroll: That helps. Thanks, again. | 21:48 |
| jroll | you're welcome :) | 21:48 |
| TheJulia | Another case is when there is something breaking that has a +2's already and we need to block something from moving forward until we are able to discuss and resolve the issue. | 21:49 |
| *** ijw has quit IRC | 21:51 | |
| rpioso | TheJulia: That makes sense, too. | 21:54 |
| *** ijw has joined #openstack-ironic | 21:54 | |
| rloo | so I think everything that we wanted to land, has landed or in the process of landing. (and this is probably easier than landing on the moon). the only outstanding thing is fixing multinode grenade. | 21:57 |
| TheJulia | rloo: I'm going to ponder it after running to the store | 21:58 |
| TheJulia | since I think refreshment is needed | 21:58 |
| *** Sukhdev has joined #openstack-ironic | 21:59 | |
| rloo | TheJulia: Enjoy, and don't worry about it. You've gone beyond the call of duty. The rest can wait. (Sez me!) | 21:59 |
| TheJulia | maybe trying to launch something towards a another planetary system in kerbal space program | 21:59 |
| TheJulia | o/ Sukhdev | 22:00 |
| Sukhdev | TheJulia Hi | 22:00 |
| TheJulia | rpioso: So the question comes to mind, have you encountered a -2 that needs attention? | 22:00 |
| rpioso | TheJulia: Yes, but not in ironic. I'm a core in python-dracclient. I was not clear on the difference between the two. | 22:02 |
| rpioso | TheJulia: Now I am :) | 22:02 |
| TheJulia | Ahh ok :) | 22:04 |
| rloo | jroll: is this needed/wanted? https://review.openstack.org/#/c/540359/ | 22:07 |
| patchbot | patch 540359 - ironic - Don't use hardware types on Ocata CI | 22:07 |
| *** r-daneel has quit IRC | 22:08 | |
| *** rbudden has quit IRC | 22:11 | |
| *** devananda has joined #openstack-ironic | 22:16 | |
| *** fragatina has joined #openstack-ironic | 22:19 | |
| openstackgerrit | Merged openstack/bifrost master: Fedora 25-27 support https://review.openstack.org/471750 | 22:20 |
| *** fragatina has quit IRC | 22:20 | |
| *** fragatina has joined #openstack-ironic | 22:20 | |
| *** fragatina has quit IRC | 22:20 | |
| *** fragatina has joined #openstack-ironic | 22:21 | |
| *** fragatina has quit IRC | 22:21 | |
| *** fragatina has joined #openstack-ironic | 22:21 | |
| *** fragatina has quit IRC | 22:21 | |
| *** fragatina has joined #openstack-ironic | 22:22 | |
| *** rcernin has joined #openstack-ironic | 22:25 | |
| *** jlabarre has quit IRC | 22:32 | |
| *** crushil has quit IRC | 22:35 | |
| *** baha has quit IRC | 22:39 | |
| jroll | rloo: good question, I need to check if sam's change fixed that CI | 22:44 |
| *** e0ne has quit IRC | 22:47 | |
| rloo | jroll: it looks useful but sam's changes did fix the ironic-tempest-plugin tests | 22:48 |
| jroll | rloo: ok, it isn't needed then, I'll abandon. thanks | 22:49 |
| *** Goneri has quit IRC | 22:50 | |
| rloo | jroll: ok thx! | 22:50 |
| jroll | :) | 22:50 |
| *** crushil has joined #openstack-ironic | 22:51 | |
| *** pmannidi has joined #openstack-ironic | 22:55 | |
| *** crushil has quit IRC | 23:00 | |
| *** rbudden has joined #openstack-ironic | 23:03 | |
| *** edleafe- has joined #openstack-ironic | 23:06 | |
| *** edleafe has quit IRC | 23:08 | |
| openstackgerrit | Merged openstack/ironic master: Clean up release notes before a release https://review.openstack.org/541744 | 23:09 |
| *** edleafe- is now known as edleafe | 23:10 | |
| *** edleafe has quit IRC | 23:21 | |
| *** Sukhdev has quit IRC | 23:23 | |
| *** edleafe has joined #openstack-ironic | 23:24 | |
| *** masber has joined #openstack-ironic | 23:27 | |
| *** Sukhdev has joined #openstack-ironic | 23:36 | |
| *** MattMan has quit IRC | 23:37 | |
| *** MattMan has joined #openstack-ironic | 23:38 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!