Wednesday, 2018-01-31

*** zhurong has joined #openstack-ironic00:19
*** bfournie has joined #openstack-ironic00:24
*** ianychoi has joined #openstack-ironic00:31
*** yangyapeng has quit IRC00:31
*** zhurong has quit IRC00:37
*** rama_y has quit IRC00:42
*** cjloader has joined #openstack-ironic00:43
*** dyasny has quit IRC00:48
*** hshiina has joined #openstack-ironic00:51
*** cjloader has quit IRC00:57
*** r-daneel has quit IRC01:04
*** rcernin has joined #openstack-ironic01:09
*** hieulq_ has quit IRC01:15
*** yangyapeng has joined #openstack-ironic01:21
*** hieulq_ has joined #openstack-ironic01:27
*** tiendc has joined #openstack-ironic01:29
openstackgerritRuby Loo proposed openstack/ironic master: DO NOT MERGE Testing effects of updating renos  https://review.openstack.org/53934601:47
*** fragatina has quit IRC01:56
*** fragatina has joined #openstack-ironic01:58
*** rloo has quit IRC01:59
*** fragatina has quit IRC02:02
*** harlowja has quit IRC02:15
openstackgerritMerged openstack/ironic-tempest-plugin master: Sort node traits in comparisons  https://review.openstack.org/53865302:26
openstackgerritMerged openstack/ironic master: Mock check_dir in ansible interface tests  https://review.openstack.org/53914402:26
openstackgerritMerged openstack/ironic master: Follow-up for agent rescue implementation  https://review.openstack.org/53825202:26
openstackgerritMerged openstack/ironic-python-agent master: Follow-up patch for rescue extension for CoreOS  https://review.openstack.org/53842902:26
*** zhangfei has joined #openstack-ironic02:30
*** rcernin has quit IRC02:35
*** d0ugal has quit IRC02:50
*** zhangfei has quit IRC02:50
*** Nisha_Agarwal has joined #openstack-ironic03:06
*** zhangfei has joined #openstack-ironic03:07
*** dpawar has joined #openstack-ironic03:10
openstackgerritMerged openstack/ironic master: Zuul: Remove project name  https://review.openstack.org/53875903:13
openstackgerritMerged openstack/ironic-lib stable/pike: Zuul: Remove project name  https://review.openstack.org/53849403:13
openstackgerritMerged openstack/ironic-lib stable/ocata: Zuul: Remove project name  https://review.openstack.org/53849303:13
openstackgerritMerged openstack/ironic-lib master: Replace curly quotes with straight quotes  https://review.openstack.org/53796203:13
*** racedo has joined #openstack-ironic03:15
*** Nisha_Agarwal has quit IRC03:15
*** Nisha_Agarwal has joined #openstack-ironic03:15
*** racedo has quit IRC03:16
*** mgagne has quit IRC03:22
*** melwitt has quit IRC03:23
*** mgagne has joined #openstack-ironic03:24
*** mgagne is now known as Guest8724003:24
*** melwitt has joined #openstack-ironic03:25
*** Nisha_ has joined #openstack-ironic03:34
*** Nisha_Agarwal has quit IRC03:35
*** zhangfei has quit IRC03:46
*** zhangfei has joined #openstack-ironic03:58
openstackgerritShivanand Tendulker proposed openstack/ironic master: Add api-ref and ironic state documentation for rescue  https://review.openstack.org/41960604:01
*** dsneddon has quit IRC04:06
*** fragatina has joined #openstack-ironic04:11
*** fragatina has quit IRC04:16
*** vsaienk0 has joined #openstack-ironic04:18
*** dpawar has quit IRC04:23
*** dpawar has joined #openstack-ironic04:24
*** dpawar has quit IRC04:28
*** vsaienk0 has quit IRC04:28
openstackgerritMerged openstack/ironic-inspector master: Zuul: Remove project name  https://review.openstack.org/53876004:30
openstackgerritMerged openstack/python-ironicclient master: Follow-up of rescue mode  https://review.openstack.org/53881904:30
openstackgerritMerged openstack/ironic master: Switch the CI to hardware types  https://review.openstack.org/53687504:30
openstackgerritMerged openstack/ironic master: Add support for preparing rescue ramdisk in iLO PXE  https://review.openstack.org/53837604:30
openstackgerritNguyen Van Trung proposed openstack/ironic master: [WIP] Implement raid configuration for BM via irmc drive (OOB-1)  https://review.openstack.org/51297904:31
openstackgerritNguyen Van Trung proposed openstack/ironic master: [WIP] Implement raid configuration for BM via irmc drive (OOB-1)  https://review.openstack.org/51297904:37
*** cjloader has joined #openstack-ironic04:48
*** rcernin has joined #openstack-ironic04:50
*** harlowja has joined #openstack-ironic04:51
*** rcernin has quit IRC04:51
*** rcernin has joined #openstack-ironic04:52
*** cjloader has quit IRC04:53
*** links has joined #openstack-ironic05:07
*** fragatina has joined #openstack-ironic05:08
*** fragatina has quit IRC05:09
*** crushil has quit IRC05:11
*** crushil has joined #openstack-ironic05:11
*** crushil has quit IRC05:16
*** Nisha_ has quit IRC05:17
*** Nisha_ has joined #openstack-ironic05:18
*** rbudden has quit IRC05:24
*** dpawar has joined #openstack-ironic05:26
openstackgerritparesh sao proposed openstack/ironic master: [docs] Firmware based boot from volume for iLO drivers  https://review.openstack.org/53915805:32
openstackgerritparesh sao proposed openstack/ironic master: [docs] Firmware based boot from volume for iLO drivers  https://review.openstack.org/53915805:35
*** rama_y has joined #openstack-ironic05:44
*** cjloader has joined #openstack-ironic05:48
TheJuliaQuestion of the day: given variable CI performance, do we consider adding a timeout into nova such that we can explicitly let the build take >10 minutes05:50
*** rama_y has quit IRC05:51
*** threestrands has quit IRC05:51
*** rama_y has joined #openstack-ironic05:52
*** cjloader has quit IRC05:53
*** threestrands has joined #openstack-ironic06:01
*** rama_y has quit IRC06:03
*** Nisha_ has quit IRC06:27
*** liuzz has joined #openstack-ironic06:30
*** marios has joined #openstack-ironic06:30
*** mjura has joined #openstack-ironic06:42
*** cjloader has joined #openstack-ironic06:48
*** cjloader has quit IRC06:53
*** harlowja has quit IRC07:01
*** zhenguo has joined #openstack-ironic07:05
*** rcernin has quit IRC07:08
*** pmannidi has quit IRC07:19
*** vsaienk0 has joined #openstack-ironic07:33
*** e0ne has joined #openstack-ironic07:34
*** charcol-v2 has quit IRC07:39
*** marios has quit IRC07:41
*** marios has joined #openstack-ironic07:46
*** cjloader has joined #openstack-ironic07:48
*** pcaruana has joined #openstack-ironic07:51
*** AlexeyAbashkin has joined #openstack-ironic07:51
*** AlexeyAbashkin has quit IRC07:51
*** AlexeyAbashkin has joined #openstack-ironic07:52
*** cjloader has quit IRC07:52
openstackgerritJohn L. Villalovos proposed openstack/python-ironicclient master: Use 'with' method rather than having to call close  https://review.openstack.org/53944207:53
openstackgerritDao Cong Tien proposed openstack/ironic master: devstack: add support for rescue mode  https://review.openstack.org/52411807:54
*** Nisha_Agarwal has joined #openstack-ironic08:00
*** jtomasek has joined #openstack-ironic08:05
openstackgerritShivanand Tendulker proposed openstack/ironic master: Add api-ref and ironic state documentation for rescue  https://review.openstack.org/41960608:07
openstackgerritDao Cong Tien proposed openstack/ironic-tempest-plugin master: Rescue mode tempest tests  https://review.openstack.org/52869908:09
*** rbartal has joined #openstack-ironic08:09
openstackgerritDao Cong Tien proposed openstack/ironic master: Update a CI job for rescue mode  https://review.openstack.org/52870408:09
openstackgerritDao Cong Tien proposed openstack/ironic-tempest-plugin master: Rescue mode standalone tests  https://review.openstack.org/53811908:09
*** parlos has joined #openstack-ironic08:13
*** rcernin has joined #openstack-ironic08:16
openstackgerritDao Cong Tien proposed openstack/ironic master: Update "standalone" job for supporting rescue mode  https://review.openstack.org/53782108:18
*** ijw has joined #openstack-ironic08:19
*** ijw has quit IRC08:20
*** tesseract has joined #openstack-ironic08:20
*** ijw has joined #openstack-ironic08:20
openstackgerritMerged openstack/ironic-python-agent master: Zuul: Remove project name  https://review.openstack.org/53882608:21
openstackgerritMerged openstack/ironic-python-agent stable/ocata: Zuul: Remove project name  https://review.openstack.org/53883708:21
*** stendulker has joined #openstack-ironic08:24
*** e0ne has quit IRC08:25
openstackgerritDao Cong Tien proposed openstack/ironic-tempest-plugin master: Rescue mode tempest tests  https://review.openstack.org/52869908:25
*** rcernin has quit IRC08:26
*** ijw has quit IRC08:27
*** ijw has joined #openstack-ironic08:29
*** e0ne has joined #openstack-ironic08:30
*** zhurong_ has joined #openstack-ironic08:45
*** amarao has joined #openstack-ironic08:47
*** cjloader has joined #openstack-ironic08:48
*** cjloader has quit IRC08:52
*** namnh has joined #openstack-ironic08:54
*** tuanla____ has joined #openstack-ironic09:01
*** serlex has joined #openstack-ironic09:03
*** d0ugal has joined #openstack-ironic09:05
*** rcernin has joined #openstack-ironic09:05
*** ijw has quit IRC09:06
*** Nisha_Agarwal has quit IRC09:06
*** vsaienk0 has quit IRC09:10
*** e0ne has quit IRC09:12
*** vsaienk0 has joined #openstack-ironic09:16
*** exodusftw has quit IRC09:17
*** e0ne has joined #openstack-ironic09:21
*** Nisha_Agarwal has joined #openstack-ironic09:22
*** hshiina has quit IRC09:22
*** exodusftw has joined #openstack-ironic09:23
*** jaganathan has joined #openstack-ironic09:30
*** MattMan has quit IRC09:30
*** MattMan has joined #openstack-ironic09:31
*** derekh has joined #openstack-ironic09:41
*** e0ne has quit IRC09:42
*** zhangfei has quit IRC09:43
*** cjloader has joined #openstack-ironic09:48
*** cjloader has quit IRC09:53
*** zhenguo has quit IRC09:53
*** Nisha_Agarwal has quit IRC09:57
*** zhangfei has joined #openstack-ironic09:59
*** e0ne has joined #openstack-ironic10:05
*** parlos has quit IRC10:06
*** racedo has joined #openstack-ironic10:12
*** namnh has quit IRC10:15
*** hjensas has quit IRC10:17
*** pc_m has quit IRC10:17
*** priteau has joined #openstack-ironic10:19
*** ijw has joined #openstack-ironic10:23
*** pc_m has joined #openstack-ironic10:24
*** sambetts|afk is now known as sambetts10:27
*** ijw has quit IRC10:30
*** dtantsur|afk is now known as dtantsur10:36
dtantsurmorning all! what did I miss?10:36
etingofo/10:37
openstackgerritDerek Higgins proposed openstack/ironic master: Add option to specifiy mac adress  https://review.openstack.org/53948810:42
*** Nisha_Agarwal has joined #openstack-ironic10:45
*** zhurong_ has quit IRC10:48
*** cjloader has joined #openstack-ironic10:48
*** lucas-afk is now known as lucasagomes10:48
openstackgerritMerged openstack/networking-baremetal master: Add support to bind type vlan networks  https://review.openstack.org/53234910:50
*** cjloader has quit IRC10:53
*** jaganathan has quit IRC10:55
*** stendulker_ has joined #openstack-ironic11:01
*** ijw has joined #openstack-ironic11:02
*** parlos has joined #openstack-ironic11:02
*** vsaienk0 has quit IRC11:04
*** stendulker has quit IRC11:05
*** stendulker_ has quit IRC11:06
*** vsaienk0 has joined #openstack-ironic11:09
*** AlexeyAbashkin has quit IRC11:09
*** andyjones2001 has joined #openstack-ironic11:10
*** tuanla____ has quit IRC11:11
*** AlexeyAbashkin has joined #openstack-ironic11:15
*** hjensas has joined #openstack-ironic11:18
*** zshi has quit IRC11:20
*** amarao1 has joined #openstack-ironic11:27
*** ijw has quit IRC11:29
*** zshi has joined #openstack-ironic11:34
*** racedo has quit IRC11:34
openstackgerritDmitry Tantsur proposed openstack/ironic master: Declare support for Python 3.5 in setup.cfg  https://review.openstack.org/53950011:44
openstackgerritDmitry Tantsur proposed openstack/ironic-inspector master: Declare support for Python 3.5 in setup.cfg  https://review.openstack.org/53950211:46
*** vsaienk0 has quit IRC11:47
dtantsursambetts: hey, if you're around ^^^11:47
sambettsdtantsur: +2 for both :D11:48
*** cjloader has joined #openstack-ironic11:48
*** parlos has quit IRC11:49
*** dpawar has quit IRC11:50
*** cjloader has quit IRC11:52
dtantsursambetts: thanks! also wdyt about https://review.openstack.org/#/c/537415/ ?11:53
patchbotpatch 537415 - ironic-inspector - Switch the CI to hardware types11:53
dtantsurI'm not sure about the grenade bit (see the commit message)11:53
*** watanabe_isao has joined #openstack-ironic11:57
*** vsaienk0 has joined #openstack-ironic11:58
*** zhangfei has quit IRC11:58
*** watanabe_isao has quit IRC11:58
*** nicodemos has joined #openstack-ironic12:00
*** parlos has joined #openstack-ironic12:01
openstackgerritDao Cong Tien proposed openstack/ironic-tempest-plugin master: Rescue mode tempest tests  https://review.openstack.org/52869912:03
*** Nisha_Agarwal has quit IRC12:03
*** Nisha_Agarwal has joined #openstack-ironic12:04
openstackgerritDmitry Tantsur proposed openstack/ironic master: Deprecate classic drivers  https://review.openstack.org/53692812:08
*** threestrands has quit IRC12:08
*** parlos has quit IRC12:10
*** watanabe_isao has joined #openstack-ironic12:15
*** tiendc has quit IRC12:17
*** watanabe_isao has quit IRC12:18
*** Nisha_Agarwal has quit IRC12:22
*** Nisha_Agarwal has joined #openstack-ironic12:22
openstackgerritDmitry Tantsur proposed openstack/ironic master: Deprecate classic drivers  https://review.openstack.org/53692812:27
*** bfournie has quit IRC12:28
*** bfournie has joined #openstack-ironic12:28
*** bfournie has quit IRC12:32
*** Nisha_Agarwal has quit IRC12:39
*** Nisha_Agarwal has joined #openstack-ironic12:40
*** jlabarre has joined #openstack-ironic12:41
*** jcoufal has joined #openstack-ironic12:44
*** Nisha_Agarwal has quit IRC12:46
*** milan_ has joined #openstack-ironic12:47
*** cjloader has joined #openstack-ironic12:48
*** cjloader has quit IRC12:53
*** watanabe_isao_ has joined #openstack-ironic12:53
*** watanabe_isao_ has quit IRC12:53
*** ijw has joined #openstack-ironic12:54
*** rcernin has quit IRC12:58
*** cdearborn has joined #openstack-ironic12:59
*** ijw has quit IRC12:59
*** bfournie has joined #openstack-ironic13:03
*** dpawar has joined #openstack-ironic13:09
*** nicodemos has quit IRC13:10
*** jlabarre has quit IRC13:11
mgoddardthanks for all the nova reviews dtantsur :D13:12
dtantsurnp :)13:13
*** jlabarre has joined #openstack-ironic13:14
*** nicodemos has joined #openstack-ironic13:16
*** jaganathan has joined #openstack-ironic13:20
openstackgerritHugo Nicodemos proposed openstack/ironic master: DNM|WIP Test OneView CI with Hardware Type  https://review.openstack.org/53789613:21
*** trown|outtypewww is now known as trown13:21
*** dprince has joined #openstack-ironic13:22
*** jlabarre has quit IRC13:33
*** alex_xu has quit IRC13:37
*** alex_xu has joined #openstack-ironic13:39
*** racedo has joined #openstack-ironic13:42
*** watanabe_isao_ has joined #openstack-ironic13:45
*** yangyapeng has quit IRC13:45
*** watanabe_isao_ has quit IRC13:47
*** watanabe_isao has joined #openstack-ironic13:47
*** watanabe_isao has quit IRC13:47
*** cjloader has joined #openstack-ironic13:48
*** jlabarre has joined #openstack-ironic13:48
*** hw_wutianwei has joined #openstack-ironic13:49
*** cjloader has quit IRC13:53
*** rloo has joined #openstack-ironic13:54
jrollmorning everyone13:54
jrollwelcome back dtantsur \o/13:54
rloogood morning jroll, dtantsur, and everyone else!13:57
dtantsurmorning jroll, rloo13:57
jroll\o rloo13:58
*** racedo_ has joined #openstack-ironic14:00
*** racedo has quit IRC14:01
*** yolanda has quit IRC14:01
*** yolanda has joined #openstack-ironic14:03
*** pcaruana has quit IRC14:05
*** cdearborn has quit IRC14:07
*** yangyapeng has joined #openstack-ironic14:09
*** Goneri has joined #openstack-ironic14:11
*** rbudden has joined #openstack-ironic14:13
TheJuliagood morning14:16
*** vsaienk0 has quit IRC14:16
TheJuliadtantsur: you missed a lot :)14:16
*** athomas has joined #openstack-ironic14:17
TheJuliadtantsur: at the same time, there has been some fun gate issues over the past week14:18
dtantsurmorning TheJulia, I suspected it :)14:18
rlooMorning TheJulia!14:18
openstackgerritRuby Loo proposed openstack/ironic stable/pike: Be more sane about cleaning  https://review.openstack.org/53954714:20
rlooTheJulia: ^^ cuz I see http://logs.openstack.org/10/520010/2/check/ironic-tempest-dsvm-ipa-wholedisk-agent_ipmitool-tinyipa-multinode/ee22280/logs/devstacklog.txt.gz#_2018-01-29_22_16_38_92514:21
*** pcaruana has joined #openstack-ironic14:21
*** jtomasek_ has joined #openstack-ironic14:22
TheJuliafun \o/14:22
TheJuliaa couple different IPA builds failed yesterday due to them taking just over ten minutes to deploy14:24
*** jtomasek has quit IRC14:24
TheJuliaany failing CI jobs _really_ hurt speed of landing when using a single gate queue14:24
rlooTheJulia: sigh. should we extend the timeout? is everything 'just getting slower' ? :)14:24
TheJuliarloo: for that specifically, we would need a knob in nova14:25
sambettsI think one of the cloud providers is having performance issues14:25
sambettsinfra are trying to resolve it14:25
TheJuliarax dfw was yesterday14:25
rlooTheJulia: we should discuss it then, is a single gate queue worth it? although i suspect there is no clear answer14:25
sambettsTheJulia: did we get the all clear on that/14:26
sambetts?14:26
rloohi sambetts :)14:26
sambettshey rloo14:26
TheJuliasambetts: I don't remember seeing anything about it being resolved yesterday. They did fix the ubuntu-xenial build issues though14:26
* TheJulia finally starts to sip coffee14:27
*** links has quit IRC14:27
sambettsTheJulia: :(14:28
sambettsTheJulia: I keep getting timeout on my UT runs on networking-cisco, the neutron UTs take soo long14:29
TheJuliaBy chance has anyone reconciled the whiteboard?14:29
TheJuliasambetts: varying peformance is why I changed a couple multinode jobs not to clean last week, since we were defaulting to it running on every single job :(14:30
rlooTheJulia: not yet. I could though, you want me to?14:30
TheJuliarloo: I'll do it in a couple minutes14:30
*** lucasagomes is now known as lucas-hungry14:30
rlooTheJulia: thx14:30
*** dyasny has joined #openstack-ironic14:30
*** vsaienk0 has joined #openstack-ironic14:32
*** SerenaFeng has joined #openstack-ironic14:37
openstackgerritJulia Kreger proposed openstack/ironic master: Soft power operations for OneView hardware type  https://review.openstack.org/51068514:42
*** vsaienk0 has quit IRC14:42
TheJuliaPretty good shape all things considered14:45
rlooTheJulia: knock on wood!14:46
TheJulialooks like we're done with traits, but there is still a ways to go with routed networks14:48
*** cjloader has joined #openstack-ironic14:48
*** pcaruana has quit IRC14:48
dtantsuryep, this is the most concerning14:48
openstackgerritIlya Etingof proposed openstack/ironic master: Add boot mode support to ManagementInterface  https://review.openstack.org/52677314:49
dtantsurand then I have to write to_hardware_type for ALL classic drivers >_<14:49
TheJuliadtantsur: oh yeah, I guess you only did a couple of them in the first patch14:52
dtantsuryep, IPMI and fake to try the approach14:52
dtantsurmmm, maybe SNMP too14:52
*** cjloader has quit IRC14:53
TheJuliaYeah14:53
rlooTheJulia: wrt updating renos, looks like we can update for master and releases that do not have a stable branch. Any changes to renos in stable branches do not show up -- my guess is maybe those would have to merge on master & then backport to branch, but dunno and not going to try out :)14:53
TheJulialooks like we're done with ilo, I just approved the patch that we had for that14:53
rlooTheJulia: my test patch: https://review.openstack.org/#/c/539346/14:53
patchbotpatch 539346 - ironic - DO NOT MERGE Testing effects of updating renos14:53
TheJuliarloo: if I remember correctly, it is all built from master14:54
TheJuliait just walks the branches for ordering information14:54
rlooTheJulia, dtantsur: wrt routed network, i thought we only needed to get the 'required to be functional' patches (so two of them left)14:54
jrollrloo: is this what you're trying to test? https://docs.openstack.org/reno/latest/user/usage.html#updating-stable-branch-release-notes14:54
jroll"any updates to these release notes should be proposed directly to the stable branch where they were introduced"14:54
rloojroll: yup, that's it. cuz it used to be broken before and TheJulia said it was fixed. Now we know how it was fixed :)14:55
jrollheh14:55
TheJuliarloo: hjensas has been awesome about updating patches as we go14:56
TheJuliarloo: so I think we may get a few more beyond that taken care of in the next day or so14:56
rloojroll: we had documented a BEWARE thing at : https://docs.openstack.org/ironic/latest/contributor/faq.html#update-a-release-note. i'll update it at some point...14:56
dtantsurTheJulia, rloo, just to double-check my understanding: we're done with rescue and traits for queens (with rescue still ongoing overall)?14:56
rlooTheJulia: good.14:57
dtantsurwe're also done with oneview migration14:57
rloodtantsur: it is in the whiteboard. i am looking now :)14:57
jrollrloo: ah, the first two paragraphs there look good, just need to fix the third I think? though, it may be correct...14:57
rloodtantsur: under weekly priorities, L14114:57
TheJulianicodemos: If you have a minute, https://review.openstack.org/#/c/539237/2/ironic/drivers/modules/oneview/management.py14:57
patchbotpatch 539237 - ironic - Follow-up for Switch OneView driver to hpOneView a...14:57
dtantsuraha, missed it, thanks14:57
TheJuliadtantsur: we can still land the api-ref for rescue since it is in the API, but I think that is the last patch we can land14:58
TheJuliadtantsur: I've updated the list on the whiteboard with current status and marked ones that have merged14:58
rloojroll: yeah. the last para is wrong, i just tested it, it got updated. as long as it hasn't branched yet, even if released.14:59
jrollrloo: gotcha, thanks!14:59
rloojroll: :)14:59
rloodtantsur: so if you add more patches for the classic driver deprecation, please add to that list14:59
dtantsurack14:59
* rloo is worried, dtantsur is adding more possible things...15:01
dtantsurrloo: the CI patches are backportable and don't need an FFE15:02
dtantsurthe only really missing FFE thing is to_hardware_types for everything15:02
dtantsurwell, and the deprecation, which is already on review15:02
openstackgerritHugo Nicodemos proposed openstack/ironic master: Follow-up for Switch OneView driver to hpOneView and ilorest libraries  https://review.openstack.org/53923715:02
* rloo feels so tired... moar reviews... :D15:03
* TheJulia feels the same way as rloo15:03
dtantsurI hear it.. I did not have a weekend at all :)15:03
openstackgerritMerged openstack/ironic-inspector master: Declare support for Python 3.5 in setup.cfg  https://review.openstack.org/53950215:03
openstackgerritMerged openstack/ironic master: Declare support for Python 3.5 in setup.cfg  https://review.openstack.org/53950015:03
dtantsuron Monday we'll start a slow and relaxed fixing of bugs :D (and reviewing docs, w00t!)15:03
* TheJulia goes and gets more coffee, and then back to the review mines15:04
* rloo not feeling that much better after dtantsur's prediction of next week. docs. we. all. love. docs...15:04
TheJuliawhy is the idea of an impromptu vacation sounding awesome15:05
rlooTheJulia: i think that's 'impromptu after dublin ptg' ? :)15:05
*** racedo_ has quit IRC15:06
*** crushil has joined #openstack-ironic15:07
TheJuliaeh, my body is telling me I need to take a few days prior, since we're expecting to close on the new house on the 21st.15:08
*** rbartal has quit IRC15:09
TheJuliaI just realized that is 3 weeks away15:09
*** alex_xu has quit IRC15:11
*** etingof has quit IRC15:12
*** alex_xu has joined #openstack-ironic15:13
*** pcaruana has joined #openstack-ironic15:14
jrollTheJulia: \o/15:14
jrollthat is awful close to dublin15:15
TheJuliaa bit tooooo close15:15
jrollwe're staying in london for a week after ptg, home on the 10th, closing on the 12th :|15:15
TheJuliaoh, that is going to be rough15:15
TheJuliabut fun :)15:15
jrollheh, indeed15:16
jrollseems we're pretty ahead of schedule, so should be ready to go before I leave for ptg15:16
* jroll crosses fingers15:16
TheJuliaYeah, I've already suggested that it would be awesome if we could move the closing up a little15:17
rloooh, congrats to both of you TheJulia, jroll !15:18
jrollrloo: thanks :)15:18
TheJuliarloo: thanks!15:18
*** zshi has quit IRC15:20
*** vsaienk0 has joined #openstack-ironic15:20
*** dpawar has quit IRC15:22
*** Guest87240 is now known as mgagne15:27
*** mgagne has joined #openstack-ironic15:27
*** vsaienk0 has quit IRC15:30
TheJuliahjensas: I left some comments on https://review.openstack.org/#/c/537353/15:30
patchbotpatch 537353 - ironic - Add documentation for baremetal mech15:30
*** lucas-hungry is now known as lucasagomes15:30
*** vsaienk0 has joined #openstack-ironic15:31
hjensasTheJulia: yes, lets pronounce the backup product with a Japanese accent. I'll look into it. :D15:31
*** jaganathan has quit IRC15:31
TheJuliaheh :)15:31
TheJuliahjensas: also looks like some of your ci related patches on openstack/ironic never posted results due to the zuul outage over the weekend. I've issued rechecks for them15:33
rloodtantsur: do you have time to implement the classic_drivers.to_hardware_type() today?15:33
rloodtantsur: or tomorrow morning?15:33
*** zshi has joined #openstack-ironic15:33
rloodtantsur: i think that's the only *code* missing for the deprecation?15:34
rloodocs can still land next week... :)15:34
*** links has joined #openstack-ironic15:35
dtantsurrloo: working on it15:37
hjensasTheJulia: ok, thanks. It would be nice to land 531275, 531637 and 530409. I have a small improvement to the networking-baremetal agent that I don't want to push before we have the CI.15:37
rloodtantsur: thx, i'll keep an eye out for it/them15:37
*** cdearborn has joined #openstack-ironic15:41
dtantsuroh hell, does anyone know if it was a conscious decision by the ilo team to exclude the ilo vendor from the hardware type?15:42
dtantsurTheJulia: ^^^?15:42
TheJuliadtantsur: likely not15:42
TheJuliaconcious that is15:42
dtantsurooook, fixing15:42
TheJuliak15:43
dtantsuryep, nothing in https://github.com/openstack/ironic/commit/317afc8d372bde695390b89312605bc02d6ee640 mentions it15:43
dtantsurI hope they were not planning on deprecating it15:44
TheJuliaI don't remember what it does, but I can go look in a little bit15:45
dtantsurseems like booting from ISO15:47
dtantsurI don't want to step on their shoes, but if we land migration without this vendor interface, it may surprise users..15:47
*** SerenaFeng has quit IRC15:47
*** cjloader has joined #openstack-ironic15:48
dtantsurbecause it will reset it to no-vendor, which will be a regression15:48
openstackgerritDmitry Tantsur proposed openstack/ironic master: Add missing ilo vendor to the ilo hardware types  https://review.openstack.org/53958215:51
*** cjloader has quit IRC15:53
*** vsaienk0 has quit IRC15:53
*** etingof has joined #openstack-ironic15:54
openstackgerritHarald JensÃ¥s proposed openstack/networking-baremetal master: Update docs and generate config file example  https://review.openstack.org/53901015:55
*** bfournie has quit IRC16:05
*** bfournie has joined #openstack-ironic16:05
*** bfournie has quit IRC16:06
*** bfournie has joined #openstack-ironic16:06
*** crushil has quit IRC16:06
*** vsaienk0 has joined #openstack-ironic16:07
*** cjloader has joined #openstack-ironic16:08
*** bfournie has quit IRC16:08
*** bfournie has joined #openstack-ironic16:08
*** bfournie has quit IRC16:08
*** bfournie has joined #openstack-ironic16:08
*** bfournie has quit IRC16:09
*** bfournie has joined #openstack-ironic16:09
TheJuliasambetts: you around to take a quick look at https://review.openstack.org/#/c/536040/ ?16:20
patchbotpatch 536040 - ironic - Flat networks use node.uuid when binding ports.16:20
sambettsTheJulia: yup I'll take a look16:22
TheJuliaThanks!16:22
*** serlex has left #openstack-ironic16:23
*** milan_ has quit IRC16:27
openstackgerritDmitry Tantsur proposed openstack/ironic master: Migrate the remaining classic drivers to hardware types  https://review.openstack.org/53958916:28
dtantsurrloo: here we go ^^^16:28
rloodtantsur: thx16:28
*** r-daneel has joined #openstack-ironic16:29
*** rama_y has joined #openstack-ironic16:30
*** milan_ has joined #openstack-ironic16:31
TheJuliadtantsur: your ilo patch has been +A'ed16:34
dtantsur\o/16:35
*** pcaruana has quit IRC16:39
*** milan_ has quit IRC16:39
openstackgerritHarald JensÃ¥s proposed openstack/ironic master: Flat networks use node.uuid when binding ports.  https://review.openstack.org/53604016:49
openstackgerritHarald JensÃ¥s proposed openstack/ironic master: Add documentation for baremetal mech  https://review.openstack.org/53735316:49
*** amarao has quit IRC16:54
openstackgerritMerged openstack/ironic master: Follow-up for Implementation for UEFI iSCSI boot for ILO  https://review.openstack.org/53886316:54
*** amarao1 has quit IRC16:55
*** SerenaFeng has joined #openstack-ironic16:55
*** devananda has joined #openstack-ironic16:55
TheJuliahjensas: on the doc patch for networking-baremetal, I put a few suggestions on my review, but also put a +2 on it since it does look really good, and the other things are minor that can be fixed later on.16:58
*** e0ne has quit IRC16:58
*** dsneddon has joined #openstack-ironic16:59
TheJuliahjensas: re the ironic doc change you just updated, basically lgtm, i did comment on one thing, but it is likely not a big deal16:59
openstackgerritHarald JensÃ¥s proposed openstack/networking-baremetal master: Node state configuration - add log_agent_heartbeat  https://review.openstack.org/53960017:00
*** mjura has quit IRC17:01
*** harlowja has joined #openstack-ironic17:02
hjensasTheJulia: ok, will go have look. btw, ^^ is new. We get that option generated in the networking-baremetal docs, so I think we can just add it.17:02
TheJuliahjensas: my thought is  "why not debug"?17:07
hjensasTheJulia: the log_agent_heartbeat?17:08
*** dprince has quit IRC17:08
TheJuliayeah17:08
hjensasTheJulia: It is a setting in the node state sent via rpc to neutron, we don't log, neutron logs when it recieves the heartbeat.17:08
hjensasTheJulia:  we have debug level logging when we send heartbeats.17:09
hjensasTheJulia: it triggers this - https://github.com/openstack/neutron/blob/master/neutron/db/agents_db.py#L296-L30417:11
TheJuliaahhh17:12
TheJuliaI looked at it and was kind of confused where it was actualy logging, that makes more sense now17:12
*** cjloader has quit IRC17:17
*** marios has quit IRC17:18
*** cjloader has joined #openstack-ironic17:18
NobodyCamGood Morning Ironic'ers17:21
*** leifmadsen_ is now known as leifmadsen17:21
*** links has quit IRC17:21
dtantsurmorning NobodyCam17:23
NobodyCamGood Morning dtantsur :)17:23
NobodyCamhappy hump day :p :)17:23
*** AlexeyAbashkin has quit IRC17:23
*** etingof has quit IRC17:25
rloomorning NobodyCam!17:28
NobodyCamGood Morning rloo ... Are you keeping warm :)17:28
rlooNobodyCam: yup, working indoors. Although it is beautiful outside with the fresh snow :)17:29
*** dprince has joined #openstack-ironic17:29
NobodyCamBrrr snow is cold.17:29
*** SerenaFeng has quit IRC17:30
* rloo thinks snow is cool17:31
openstackgerritHarald JensÃ¥s proposed openstack/ironic master: Add documentation for baremetal mech  https://review.openstack.org/53735317:31
NobodyCam:)17:32
*** crushil_ has joined #openstack-ironic17:33
NobodyCamweather says it will only be about 70 F here today17:34
NobodyCam:p17:34
TheJuliaNobodyCam: there is also the fire pits if it is too cold17:36
openstackgerritHarald JensÃ¥s proposed openstack/networking-baremetal master: Node state configuration - add log_agent_heartbeat  https://review.openstack.org/53960017:37
NobodyCamohhh :)17:37
*** vsaienk0 has quit IRC17:37
*** andyjones2001 has quit IRC17:38
*** mrunge has quit IRC17:42
*** mrunge has joined #openstack-ironic17:45
*** tesseract has quit IRC17:45
*** jcoufal has quit IRC17:49
*** jcoufal_ has joined #openstack-ironic17:49
pas-hadtantsur: I think as a PTL you can just remove that topic from that spurious policy-in-code patch on review and call it done :)17:51
jrollI thought we finished policy-in-code in newton :P17:53
jrollI can pick up the patch to remove them17:55
jrollpas-ha: ^^17:55
*** baha has joined #openstack-ironic17:56
pas-hain queens we just used some new classes that allow for better docs autogeneration17:56
pas-hathat was a single patch https://review.openstack.org/#/c/502519/17:56
patchbotpatch 502519 - ironic - Use DocumentedRuleDefault instead of RuleDefault (MERGED)17:56
jrollah, I see17:57
jrollI'll pick up https://review.openstack.org/#/c/536349/ , I have some time this afternoon17:57
patchbotpatch 536349 - ironic - Remove sample policy and config files17:57
pas-hayes, please :)17:57
*** trown is now known as trown|lunch18:01
*** vsaienk0 has joined #openstack-ironic18:01
openstackgerritJim Rollenhagen proposed openstack/ironic master: Remove sample policy and config files  https://review.openstack.org/53634918:07
jroll^ that should pass tests, I think18:07
* jroll tested running the api without a policy file18:08
*** rama_y has quit IRC18:11
*** vsaienk0 has quit IRC18:11
*** e0ne has joined #openstack-ironic18:17
*** AlexeyAbashkin has joined #openstack-ironic18:17
*** dsneddon has quit IRC18:19
*** e0ne has quit IRC18:19
pas-hajroll: left a comment there18:29
jrollpas-ha: was kind of thinking that, but, we never allowed a custom policy.json file there, because we always copied the in-repo file to that location18:31
jrollcan add that in though, if we think people might want it18:32
pas-hawell, that was just a nit, still looks good to me. easy fix if someone really needs it. let's practice YAGNI here :)18:32
jrollthat was my thought :)18:32
dtantsurpas-ha: surely :) but I'm trying to understand if it's needed at all18:33
dtantsurpas-ha: btw, see my ML thread re ansible deploy18:34
*** dsneddon has joined #openstack-ironic18:34
pas-hayep, have some thoughts, will write back tomorrow18:35
dtantsurcool!18:36
dtantsursee you tomorrow, everyone18:37
*** dtantsur is now known as dtantsur|afk18:37
jroll\o18:37
*** e0ne has joined #openstack-ironic18:40
rloociao dtantsur|afk18:46
openstackgerritRuby Loo proposed openstack/ironic master: Update FAQ about updates of release notes  https://review.openstack.org/53963718:50
jrolljust had coffee delivered to my desk :o18:50
*** AlexeyAbashkin has quit IRC18:51
TheJuliawoot18:51
*** harlowja has quit IRC18:52
rloojroll: sweet. is that a daily thing now?18:52
jrollrloo: if only!18:53
rloojroll: :D18:53
*** vsaienk0 has joined #openstack-ironic18:54
*** priteau has quit IRC18:57
openstackgerritAnup Navare proposed openstack/ironic-python-agent master: Adds a releasenote for DHCP support for TinyIPA  https://review.openstack.org/53963918:57
*** lucasagomes is now known as lucas-afk19:04
*** aignatov has quit IRC19:06
*** aignatov has joined #openstack-ironic19:07
*** edleafe has quit IRC19:09
*** edleafe has joined #openstack-ironic19:09
*** vsaienk0 has quit IRC19:11
*** sambetts is now known as sambetts|afk19:19
sambetts|afkNight all o/19:19
*** trown|lunch is now known as trown19:24
*** aignatov has quit IRC19:29
*** kwilke has joined #openstack-ironic19:29
*** kwilke has quit IRC19:29
openstackgerritMerged openstack/ironic stable/pike: Be more sane about cleaning  https://review.openstack.org/53954719:32
*** cjloader has quit IRC19:33
*** vsaienk0 has joined #openstack-ironic19:34
*** harlowja has joined #openstack-ironic19:37
*** aignatov has joined #openstack-ironic19:42
*** vsaienk0 has quit IRC19:44
*** athomas has quit IRC19:47
*** vsaienk0 has joined #openstack-ironic19:51
openstackgerritMerged openstack/ironic master: Soft power operations for OneView hardware type  https://review.openstack.org/51068519:54
*** vsaienk0 has quit IRC20:01
*** aignatov has quit IRC20:17
*** aignatov has joined #openstack-ironic20:18
openstackgerritHarald JensÃ¥s proposed openstack/networking-baremetal master: Update docs and generate config file example  https://review.openstack.org/53901020:18
openstackgerritHarald JensÃ¥s proposed openstack/networking-baremetal master: Make the agent distributed using hashring and notifications  https://review.openstack.org/52470920:19
*** aignatov2 has joined #openstack-ironic20:22
*** aignatov has quit IRC20:23
*** aignatov2 is now known as aignatov20:23
*** hw_wutianwei has quit IRC20:31
*** links has joined #openstack-ironic20:36
*** aignatov has quit IRC20:39
*** aignatov has joined #openstack-ironic20:40
*** derekh has quit IRC20:41
openstackgerritHarald JensÃ¥s proposed openstack/networking-baremetal master: Add dsvm job  https://review.openstack.org/53040920:49
openstackgerritHarald JensÃ¥s proposed openstack/networking-baremetal master: Make the agent distributed using hashring and notifications  https://review.openstack.org/52470920:49
openstackgerritRuby Loo proposed openstack/ironic master: [api-ref] clarify what /v1/lookup returns  https://review.openstack.org/53967620:51
TheJuliarloo: if you get a minute, could you take a look at https://review.openstack.org/#/c/534441/20:58
patchbotpatch 534441 - ironic - Don't try to lock upfront for vif removal20:58
rlooTheJulia: yup, sorry, forgot about the bugs. wil look in a few min.20:58
TheJuliano worries! I listed the ilo hw type one under the bugs and rechecked it :(20:59
TheJuliatwo jobs had node timed out and logs were not collected :(20:59
rloough21:02
*** e0ne has quit IRC21:12
*** priteau has joined #openstack-ironic21:19
rlooTheJulia: do you have a few minutes to discuss 534441? i commented, but want to understand what we're trying to do. might be another way to tackle it.21:19
TheJuliapulling it up21:20
priteauIs there a trick to use netboot while using multi-tenancy? Nodes can boot fine in the provisioning network because they have access to the TFTP server, but not in tenant networks. Is it possible by setting static routes?21:20
TheJuliarloo: good catch on base21:21
rlooTheJulia: so you just want to defer the exclusive lock, in case it isn't actually needed, right?21:21
TheJuliapriteau: as long as it is available via the router that is serving the tenant network it is fine21:21
TheJuliarloo: basically yeah, we need a task for to spawn the process forward, but share (i.e. no lock) and only upgrade to have an exclusive lock if the node is running21:22
rloo'if the node is running' ? what does that mean?21:23
TheJuliain active or rescue states, realistically21:23
rloooh, if there is an instance21:23
TheJuliayup21:23
rloois that something that one would want to do on any network interface, or just specific to flat/neutron?21:23
rlooneutron i guess.21:24
rlooi was thinking that the conductor could make a call to see if the VIF was attached, if we had a general interface->vif_attached() call21:25
TheJuliaIf i understand where your going, any. It just so happens that this is mainly a response to try and handle the fact that we can have a node locked for quite a long time causing nodes to be orphaned21:25
rloonodes orphaned by nova?21:25
TheJuliaso basically what is happening, is there are cases where when a node enters cleaning, the node may remain locked for minutes upon minutes21:26
priteauTheJulia: Thanks, will try it21:26
rlooinstances orphaned by nova21:26
TheJuliaorphaned by nova is the wrong way to put what happens, calrifying21:26
TheJuliarloo: what then happens, is nova will only retry to pull the vif off the node for 5 minutes21:27
rloonode enters cleaning when the instance is deleted?21:27
TheJulia(we can see this in a lot of our testing where nova reties a dozen or so times to remove the vif, luckilly the power-on to initial heartbeat doesn't take too long for a VM)21:27
TheJuliarloo: yes21:28
rlooTheJulia: so nova wants to delete instance, node enters cleaning state, while it is still in cleaning state, nova tries to detach the vif but node is locked.21:29
TheJuliaso provision state deleted basically sends the conductor down a long path of waiting. Of course, I also noticed this where we had BMCs that would sometimes hang, and ran into a situation where the vifs would remain on the node, and nova would never be able to redeploy on the node afterwards21:29
rlooTheJulia: node is locked until it goes to clean_wait state I guess21:29
rlooTheJulia: we need a queue of things-to-do to an object (node in our case)21:29
TheJuliarloo: I... think it actually remains locked until the first heartbeat... it actually gets locked like 3-4 times  in that sequence :\21:29
rlooTheJulia: sigh. do we need it locked all those times? Maybe that's the better place to tackle this.21:30
TheJuliarloo: or begin de-serializing the operation of some things to allow nodes to have information only updates to occur21:30
rlooTheJulia: i don't like the Interface implementation code to deal with locking of nodes. unless we have already done that. cuz how does an implementation know that it should be doing that?21:31
TheJuliarloo: with the way the conductor is architected with event handling... we don't really have a choice with all of the locking21:31
* TheJulia looks for instances of lock upgrades21:31
jlvillalTheJulia, off-topic. I see you mention coffee. Do you make your own? If so, do you grind your own beans?21:32
TheJuliarloo: ansible deploy, drac raid, inspector and agent deploy base vendor all upgrade locks21:32
*** links has quit IRC21:32
jlvillalI've been using Starbucks instant which I like. But a tad expensive. So pondering going the grinding route and making it.21:32
rlooTheJulia: ugh. in that case, not a reason to not do this. let me take a look...21:33
TheJuliajlvillal: I grind whole beans every few days... using a sadly low cost blade grinder... but it works and is also light in the limited space we have on the bus21:33
jrollgrinding your own beans >>> ground coffee >>> instant :P21:34
TheJuliajlvillal: I then will either use a french press or my espresso machine from there21:34
jlvillalTheJulia, Cool. Yeah I was considering a cheap burr grinder ($30).21:34
TheJuliaalso, I only grind in small batches, like a half cup at a time21:34
jlvillalTheJulia, Thanks!21:35
jlvillalI've been using the Starbucks Via instant coffee packs which are pretty good. About $0.50 / packet depending if on sale or not.21:35
TheJuliaI've never tried via packets21:35
TheJuliaalthough I think BadCub handed me a couple in Tokyo21:36
jlvillalTheJulia, I recommend :)21:36
jlvillalA packet is 3.3 grams. So a bit expensive...21:36
jlvillalIt is a cup of coffee for a packet.21:36
* BadCub hears the summoning21:36
jrollvia packets saved my life in tokyo21:36
jrollthey aren't bad21:37
jlvillalheh.21:37
* TheJulia wonders if she has to make fresh coffee due to summoning a badcub21:37
jlvillaljroll, I agree. Not bad. Actually better than the coffee at my (former) work's break area.21:37
*** etingof has joined #openstack-ironic21:37
BadCubFresh coffee is always an acceptable summoning sacrifice21:38
jrolljlvillal: heh, yeah21:38
* TheJulia goes to make coffee21:38
jlvillaljroll, FYI: If you didn't know. I quit Intel. Going to take a couple years off and the re-evaluate what to do then.21:38
jrolljlvillal: congrats on the (semi?) retirement :D21:38
jlvillals/and the/and then/21:38
BadCubHowdy folks. How be things and stuff?21:38
jrolla couple years off sounds great21:38
jlvillaljroll, Thanks. It is like the 'gap year' I never took.21:38
jrollheh21:39
jlvillalBadCub, Hey there! Not bad. How about you?21:39
jrollhey BadCub \o21:39
jlvillalBadCub, You keeping NobodyCam in check? Is NobodyCam keeping BadCub in check? ;)21:39
NobodyCamlol21:39
BadCubjlvillal: doing well! Enjoying life in other people’s heads 😈21:40
jlvillalheh :)21:40
BadCubLol NobodyCam gave up trying to keep me in check years ago lol21:40
rlooTheJulia: i took a look. agent_base_vendor & ansible/deploy are doing that due to heartbeat. drac/raid & inspector are doing that due to periodic task running, to update status. none of them are doing it in an exposed driver/interface API.21:40
BadCubHeya jroll21:40
jlvillalBadCub, :D21:40
NobodyCam:p21:41
rloohey BadCub!21:42
BadCubAlthough TheJulia is now stuck with both of us as neighbors for the next month or so lolol21:42
BadCubHeya rloo !21:42
TheJuliarloo: Just to make sure we're on the same page, your objection is act of upgrading the lock in a user exposed way when a huge number of user actions require exclusive locks today?21:46
*** Goneri has quit IRC21:46
openstackgerritHarald JensÃ¥s proposed openstack/networking-baremetal master: Add dsvm job  https://review.openstack.org/53040921:48
openstackgerritHarald JensÃ¥s proposed openstack/networking-baremetal master: Make the agent distributed using hashring and notifications  https://review.openstack.org/52470921:48
rlooTheJulia: the objection is that this is a difference in the way we've (hardware vendors) have coded for the existing driver/interface APIs. I think... let me check one more thing.21:48
rlooTheJulia: I think the assumption is that the interface can update the node, w/o checking/taking out an exclusive lock. but i want to check that...21:49
rlooTheJulia: yeah, the way some interfaces have done it is to put a decorator: @task_manager.require_exclusive_lock21:50
rlooTheJulia: which won't work for you cuz you want finer-grain control21:51
rlooTheJulia: and I think the use of that decorator has fallen by the wayside.21:52
TheJuliawe kind of need it, otherwise we either try to reduce our overall usage of locks which doesn't fix this in the short term, update nova to try for a longer period of time (hey, we already need to make the deploy timeout adjustable....), or build up task queuing21:52
TheJuliaBadCub: french press is outside steeping by the fire pit21:53
rlooTheJulia: I really doubt that there is an out-of-tree network interface too, but ...21:53
rloothis would break them.21:53
* BadCub feels a sudden need to emerge from his cave21:53
rlooTheJulia: there's also a lack of symmetry wrt vif_attach & vif_detach. If we decide that the base NetworkInterface.vif_detach() implementation has to deal with getting an exclusive lock, shouldn't we do that for vif_attach() too? I think we should discuss this with dmitry and anyone else that is interested.21:56
TheJuliarloo: wouldn't really unless they are completely predicated upon the node itself being locked. The task still works21:56
rlooTheJulia: well, anytime you want to change the node, you should make sure you have an exclusive lock on it.21:57
TheJuliarloo: I started down the road of vif_attach as well, there is a lot of db activity there which kind of made me go "eh...... lets see where detach goes"21:57
TheJuliarloo: but we're not chaging the node, were changing task.ports21:57
TheJuliawhich has no locking mechanism21:57
rlooTheJulia: OH. seems like we should be able to solve this some other way then.21:59
*** crushil_ has quit IRC22:00
*** trown is now known as trown|outtypewww22:00
*** priteau has quit IRC22:00
*** priteau has joined #openstack-ironic22:01
TheJuliawhat I'd like to avoid, is major changes that would take a cycle or more to get in-place, where as people are hitting this, our tests are hitting it... Largely because of our locking model of locking the node for anything related to the node, we result in entirely serialized operations... and that transition to cleaning is quite a few steps :(22:01
rlooTheJulia: yup, i hear you. but i don't want to put something in that will help us *now* but that we'll regret later.22:01
TheJuliaour main user however, is not serialized does not, and can not wait.  The other alternative though, is to remove vif attachment records upon tear_down22:01
TheJuliawhich in it's self is a behavior change, and not really great :\22:02
rlooTheJulia: I am not opposed to it, I am just not convinced yet that this is the right way. There are others that can weigh in here to provide their opinions.22:02
*** priteau has quit IRC22:03
*** priteau has joined #openstack-ironic22:03
rlooTheJulia: you only need two cores to agree to it. I just can't in all conscious, agree to it now. I need to understand it more, cuz it doesn't seem right/easy to maintain going forward unless we explicitly understand what we are doing.22:03
rlooTheJulia: everything I've seen so far, describes the task's lock as being a lock on the node. If, as you mention above, the node isn't being changed, the port is, why do you want an exclusive lock at all?22:05
rlooTheJulia: i suspect it is because we've added more objects that are associated with a node, and we want to make sure they are all in sync.22:06
TheJuliarloo: I think it got done out of review habit/task patterns22:06
TheJuliaor we're trying to just use the node's lock as a global lock for everything related to the node :\22:07
rlooTheJulia: so would the code work in your patch if we take out a shared view of things, and the vif_detach does its thing w/o doing the upgrade_lock()?22:07
rlooTheJulia: yeah i think to be safe, we're using the node's lock as a global lock for everything associated with that node (uuid)...22:08
TheJuliarloo: realisticaly yes22:08
jroll"The other alternative though, is to remove vif attachment records upon tear_down" <- this is what I've been thinking, reading this discussion22:12
jrollwe did it with instance_uuid for similar reasons22:12
jrollsambetts|afk may have insight on why we were locking for vif detach btw22:12
*** baha has quit IRC22:12
jrollwith his crazy hardware22:12
TheJuliato which sam is really not happy about because he wants the vif attachments to live past and be explicitly removed by the caller22:13
jrollreally? hm22:13
TheJuliayea22:13
jrollI thought that was about deleting neutron ports, but I'm likely wrong22:13
jrollstruggling to come up with a use case for leaving the vifs there22:14
TheJuliastatic hardware pool management22:14
TheJuliabut the word "pet" might go into that kind of environment22:15
jrollas long as the neutron ports aren't deleted, I don't think it's a problem22:15
TheJuliawhich is not cloudy at all22:15
jrolljust re-attach the same ports when you need them22:15
*** bfournie has quit IRC22:15
TheJuliaa nova user can call for a port to be attached/detached...22:16
TheJuliathrough the virt driver22:16
jrollagree22:17
jrollI'm saying we should be detaching all vifs on tear_down - but not deleting the neutron ports themselves22:17
TheJuliawhich is our original behavior from before vif_attach/vif_detach was added22:18
jrollthe neutron ports are the resource that the user may want to bring between instances on a node, not ironic's vif attachments, right?22:18
jrollafter tear_down the node no longer should belong to the user, though I'm not fully thinking through standalone there22:18
TheJuliayeah and I don't think we do anything aside from detach the vif22:18
TheJuliabut... doesn't it take admin privs to change the mac address?22:18
jrollI feel like we're talking past each other somehow, because I'm not sure how changing the mac is related22:19
TheJuliaI think standalone is where we get into the paradyme of possible pet management22:20
TheJuliajroll: no, we aren't really, I hear what your saying, but the vif has a mac address in neutron that we update with our admin privilges. The user might have trouble re-using that vif unless it is to another baremetal node (that is if, it does indeed require admin privilges).22:20
TheJuliaso ultimately the user might still then need to delete the vif to re-use it22:21
TheJulianot that it really matters, that is outside our scope of the problem, we just want to remove the active attachment22:21
jrollTheJulia: when you say vif there you mean neutron port, right?22:21
devanandaside note: unfortunately, I know of cloud users who want to manage pets with nova+ironic22:22
TheJuliayes, and our actions are just binding attach/detach22:22
devanandaalso hi :)22:22
jrolla wild devananda! hi!22:22
TheJuliadevananda: ditto :|22:22
jrollI've accepted a long time ago pets with nova+ironic will happen22:22
jrollTheJulia: right, so I don't think we create any new problems by detaching all the vifs on tear_down, so that nova doesn't have to fight locks to do that itself22:23
TheJuliaI think we should, upon teardown, remove record of the vif. I believe we already end up with the port detached in that entire sequence22:23
jrollright, though I believe nova is responsible for the detach today22:24
TheJuliaupgrading the lock was just an idea to be kinder to nova22:24
TheJuliajroll: it is...22:24
TheJuliaalthough we already detach in our workflow, we just leave records of them attached that could prevent re-deployment22:24
jrollO_o22:25
TheJuliavif list which prevents a new port being attached22:25
TheJuliaerr22:25
TheJulianot ist, but the vif record is still in our db22:25
TheJuliacan be seen with vif list22:25
jrollthat doesn't sound like we detach it :)22:26
jrolland that's the bug, right, the node is locked so nova can't detach the vif?22:26
TheJuliajroll: yup, but we tell neutron to detach, we don't nuke record of it. (of course, order of operations wise, there is still a minor issue with common/network.py vif_attach, but that is super simple to fix22:27
*** hjensas has quit IRC22:28
TheJuliagoing to a similar problem, we do the same with volume targets, we let nova try to clean up, but we also nuke upon teardown for these very reasons22:29
TheJuliawe should just nuke the vif attachment record.....22:29
jrollok right, there's neutron's "detach from actual networking" too22:29
jrollwords are hard yo.22:30
TheJuliaindeed22:30
jroll22:29:23        TheJulia | we should just nuke the vif attachment record..... <- but yeah, that's what I'm proposing as well22:30
jrollrather than nova doing it by calling vif_detach() or whatever22:30
*** cdearborn has quit IRC22:30
TheJuliayup, I recognize that :)22:31
jrollok :)22:31
TheJuliaI think nova gives up when it finds that it doesn't exist, and would be kind of okay to leave in place....22:31
jrollyeah, or could easily add except 404: pass22:32
jrolland drop it all once nova no longer supports rocky ironic, or whatever version we do that change in22:32
TheJuliajroll: I've also been trying to type quickly which makes things worse because I'm not typing out long descriptions22:32
TheJuliajroll: I think that is what it does22:32
*** rbudden has quit IRC22:32
jrollperfect22:33
jrollTheJulia: no worries, I do the same thing without realizing it22:33
* TheJulia needs to take a brain break22:37
rloothx jroll & TheJulia; glad you worked that out.22:37
jrollrloo: does that mean you agree? :)22:38
rloojroll: that we should detach the vifs at tear down? yup.22:38
jroll\o/22:39
rloojroll: although... i think we need to discuss with sambetts|afk, seems like he might had a reason not to want to do that22:39
jrollyep, don't disagree22:39
rlooI do wonder whether we're taking out a lock too long for cleaning purposes though. i know someone went through the locking stuff awhile ago, but don't know if that was before we had cleaning or after22:41
*** priteau has quit IRC22:45
*** dprince has quit IRC22:52
*** jcoufal_ has quit IRC22:52
JayFrloo: with cleaning, you could even use the abortable:true/false flag to determine if it should be locked the whole time or not (assuming nothing major in that world has changed in 18 months)22:56
JayF(that flag is optional on clean steps, and defaults to true22:56
rlooJayF: hi! that's something to look into. I don't know when/if I'll get around to looking at it, but noted. I am surprised you remember this stuff :)22:57
JayFnot nearly as surprised as I am22:57
rlooJayF: heh22:57
*** bfournie has joined #openstack-ironic23:04
*** bfournie has quit IRC23:04
*** bfournie has joined #openstack-ironic23:05
openstackgerritJim Rollenhagen proposed openstack/ironic master: Remove sample policy and config files  https://review.openstack.org/53634923:07
openstackgerritHarald JensÃ¥s proposed openstack/networking-baremetal master: Update docs and generate config file example  https://review.openstack.org/53901023:11
*** hjensas has joined #openstack-ironic23:15
*** charcol-v2 has joined #openstack-ironic23:15
devanandaI realize I'm a bit rusty because I seem to be missing a piece of the puzzle - trying to hook ironic&neutron into a shiny and relatively new Arista switch ... ovsdb connection between neutron and switch are in place, but neutron isn't sending updates to the switch. anyone have thoughts on what piece I'm missing?23:17
jrolldevananda: the first things I'd check is that 1) you have the neutron plugin installed, and 2) the port (something) type is baremetal, lemme find that23:18
devanandajroll: which neutron plugin?23:18
jrolldevananda: the one that can configure arista switches, I assume?23:18
jrollunless arista has magic23:18
devanandaplanning to use openvswitch / ovsdb23:19
devanandaswitches support openflow and have been "slaved" to the neutron controller23:19
jrollhm, idk much about that, was under the impression you'd need https://github.com/openstack/networking-arista23:19
*** d0ugal has quit IRC23:20
devanandaI love the docs there :)23:20
jrollyeahhhh23:20
jrollwhere's sukhdev when you need him :P23:20
devanandayeah... he's not at Arista any more .. and our support rep didn't know much about this ^ work23:22
jrollright. I'm also rusty on it23:22
devanandasince the switch supports openflow, I've been going down that path instead of vendor-specific neutron drivers23:22
devanandai'll read throgh networking-arista but it's not immediately clear how to make that work either23:22
jrollis there an openflow plugin you need for neutron?23:23
jrollaha, vnic_type is what I was looking for: https://github.com/openstack/neutron-lib/blob/master/neutron_lib/api/definitions/portbindings.py#L11223:25
devanandaopenvswitch ml2 driver exposes an openflow controller23:25
jrollthere's a baremetal vnic type, could be related, though with openflow/ovs I'm not sure you would need it23:25
devanandaooh. lemme try that23:25
devanandai might, to tell openflow to pass this port onto a phys device23:25
jrollthat's part of the port object, binding:vnic_type23:26
jroll(neutron port object)23:26
devanandalooks like that is indeed used in the arista plugin: https://github.com/openstack/networking-arista/blob/master/networking_arista/ml2/mechanism_arista.py#L19623:26
jrollyeah, I know it's often used in the switch plugins, just dunno about the openflow stuff23:27
*** rcernin has joined #openstack-ironic23:28
jrollno clue how nova picks up that it should be a baremetal vnic_type either, at a glance23:29
* jroll knows sambetts|afk could tell you23:30
*** vsaienk0 has joined #openstack-ironic23:30
TheJuliarloo: JayF: I do think we are locking too long, and maybe we should consider making the conductor more aware of conditions surrounding a request to determine if a lock is required at that moment, and then go from there with upgrades as needed. Things like... ramdisk downloads being locked don't make "much" sense... however the way we get there means were presently locked from the recepit of the provision23:31
TheJuliastate change request to deleted23:31
TheJuliarloo: jroll: I'll discuss it with sam in the morning, it won't take long to revise the patch if we have overall consensus.23:31
jrollTheJulia: cool, I should be around too23:32
jrollthat is if I ever stop working tonight23:32
TheJuliaI think vnic_type ends up getting set since it goes through vif_attach and vif_detach23:34
*** rbudden has joined #openstack-ironic23:36
jrollah right, we set it ironic-side23:36
jrollthanks23:36
devanandaah, gotcha. so it's set during deploy/teardown, which is why I don't see it on unprovisioned nodes23:37
TheJuliaexactly23:37
TheJuliaif you had a default vlan that they start out on, I guess you'd have to map that config wise in the switch... at least starting out and then after discovery you could go from there, if that even matters in your scenario23:38
devanandawell, I've got a provider network defined in neutron for cleaning-net, mapped tothe segmentation id of a VLAN23:39
devanandadoesn't seem to bind nodes to it for cleaning yet, though ...23:39
TheJuliaand trunk between ovs and the switch is tagged to carry that vlan?23:40
*** vsaienk0 has quit IRC23:40
devanandabetween the control nodes running ironic? yes23:40
devanandadang, gotta run to a dr's appt -- bbiah23:40
TheJuliadevananda: k, thats a good sign... really wondering what that config/behavior looks like switch side... and I really really really should try to set something like that up in my lab once I rebuild it in socal23:42
jrolldevananda: I think the next thing I'd do is just watch it move a node into cleaning... make sure neutron ports are created on the right network, have the right vlan, etc. then make sure the node has vif attachments for that neutron port, etc23:43
TheJuliaI'd also try changing the ovs config manually to see if that propogates across23:45
jroll++23:45
* TheJulia is unsure we even ship correct information for neutron to correctly act through ovs to control a remote switch....23:46
TheJulialet me rephrase that, using ovs may require different information....23:46
devanandaTry again when I get home, the last time I did it created the vnic but nothing propagated to the switch23:46
TheJuliaenjoy your appointment23:47
* TheJulia realizes that nobody enjoys doctors appointments23:47
devanandaOh yes. Much joy :)23:47
devanandaThanks ;)23:47
TheJuliaoh! question for later, did it show in the ovs config at all?23:47
devanandaCome to think of it... I don't think it did. There were no state changes in ovsdb23:49
*** rcernin has quit IRC23:50
devanandaPerhaps I should just try the Arista plugin, eh...23:50
*** jlabarre has quit IRC23:55

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!