*** sasha2 has joined #openstack-ironic | 00:02 | |
*** hoonetorg has quit IRC | 00:10 | |
*** AlexeyAbashkin has joined #openstack-ironic | 00:11 | |
openstackgerrit | Julia Kreger proposed openstack/ironic master: API: Node Traits API https://review.openstack.org/532269 | 00:11 |
---|---|---|
*** cjloader has quit IRC | 00:12 | |
*** AlexeyAbashkin has quit IRC | 00:15 | |
*** jcoufal has quit IRC | 00:20 | |
*** hoonetorg has joined #openstack-ironic | 00:30 | |
*** akhilaki_ has joined #openstack-ironic | 00:31 | |
*** akhilaki has joined #openstack-ironic | 00:31 | |
TheJulia | jroll: hey, do you have another rev local for https://review.openstack.org/#/c/532622/ | 00:38 |
patchbot | patch 532622 - python-ironicclient - Traits support | 00:38 |
*** pmannidi has joined #openstack-ironic | 00:38 | |
*** liuzz has joined #openstack-ironic | 00:47 | |
TheJulia | hmmmmm things are looking goodish *crosses fingers* | 00:54 |
* TheJulia goes and finds food | 00:54 | |
*** tiendc has joined #openstack-ironic | 00:57 | |
rloo | TheJulia: i am looking through client patches. This one seems easy but not sure if it needs a release note. Anyway, passing to you :) https://review.openstack.org/#/c/532442/ | 00:59 |
patchbot | patch 532442 - python-ironicclient - Accept port and portgroup as volume connector types | 00:59 |
rloo | TheJulia: at this point, I'm good if it doesn't have a release note (I must be tired) | 00:59 |
TheJulia | :) | 01:03 |
*** phuongnh has joined #openstack-ironic | 01:04 | |
TheJulia | we really don't imho | 01:05 |
*** zhurong has joined #openstack-ironic | 01:05 | |
*** mjturek has quit IRC | 01:11 | |
openstackgerrit | Merged openstack/ironic master: Migrate python-oneviewclient validations to oneview hardware type https://review.openstack.org/524599 | 01:14 |
*** phuongnh has quit IRC | 01:16 | |
*** hoonetorg has quit IRC | 01:17 | |
*** phuongnh has joined #openstack-ironic | 01:19 | |
*** hoonetorg has joined #openstack-ironic | 01:21 | |
*** yangyapeng has quit IRC | 01:23 | |
*** yangyapeng has joined #openstack-ironic | 01:24 | |
*** crushil has joined #openstack-ironic | 01:27 | |
openstackgerrit | Julia Kreger proposed openstack/ironic master: Fix persistent information when getting boot device https://review.openstack.org/524616 | 01:30 |
openstackgerrit | Julia Kreger proposed openstack/ironic master: Remove python-oneviewclient from oneview hardware type. https://review.openstack.org/524729 | 01:30 |
openstackgerrit | Julia Kreger proposed openstack/ironic master: Add a timeout for powering on/off a node on oneview https://review.openstack.org/524624 | 01:30 |
*** akhilaki_ has quit IRC | 01:31 | |
*** akhilaki has quit IRC | 01:31 | |
openstackgerrit | Julia Kreger proposed openstack/ironic master: Fix persistent information when getting boot device https://review.openstack.org/524616 | 01:31 |
TheJulia | hmmm gerrit is not happy | 01:32 |
openstackgerrit | Julia Kreger proposed openstack/ironic master: Add a timeout for powering on/off a node on oneview https://review.openstack.org/524624 | 01:33 |
openstackgerrit | Julia Kreger proposed openstack/ironic master: Add node traits to API reference https://review.openstack.org/536384 | 01:36 |
TheJulia | rloo: if the rescue api lands soon, I'll rebase https://review.openstack.org/#/c/350831 *grin* | 01:38 |
patchbot | patch 350831 - ironic - Add API methods for [un]rescue | 01:38 |
rloo | TheJulia: i'm guessing you mean if the traits api lands soon you'll rebase the rescue api? :) | 01:40 |
TheJulia | err, yeah | 01:40 |
TheJulia | brainfail | 01:41 |
openstackgerrit | Merged openstack/python-ironicclient master: Accept port and portgroup as volume connector types https://review.openstack.org/532442 | 01:52 |
TheJulia | eh, it is going to be at least 4 hours :\ | 02:00 |
*** fragatina has quit IRC | 02:01 | |
*** crushil has quit IRC | 02:12 | |
*** zhurong has quit IRC | 02:14 | |
*** fragatina has joined #openstack-ironic | 02:14 | |
openstackgerrit | Merged openstack/ironic master: Fix node update with PostgreSQL https://review.openstack.org/537637 | 02:14 |
*** gcb has joined #openstack-ironic | 02:15 | |
*** fragatina has quit IRC | 02:19 | |
*** yolanda has quit IRC | 02:22 | |
*** bfournie has joined #openstack-ironic | 02:27 | |
*** ianychoi has quit IRC | 02:49 | |
*** ianychoi has joined #openstack-ironic | 02:49 | |
TheJulia | #goodnews traits api is in the gate | 02:52 |
openstackgerrit | Merged openstack/ironic master: Be more sane about cleaning https://review.openstack.org/537650 | 02:55 |
openstackgerrit | John L. Villalovos proposed openstack/ironic-lib master: DNM/WIP: Testing if '_Remote' code is used https://review.openstack.org/537726 | 02:56 |
rloo | TheJulia: yay! | 02:59 |
openstackgerrit | John L. Villalovos proposed openstack/ironic-lib master: WIP/DNM: Initial skeleton support for mypy static type checking https://review.openstack.org/386892 | 03:01 |
*** rbudden has joined #openstack-ironic | 03:04 | |
TheJulia | it could be merged in ~2 hours *gasp* | 03:06 |
*** zhurong has joined #openstack-ironic | 03:08 | |
jroll | TheJulia: ooooops | 03:13 |
openstackgerrit | Jim Rollenhagen proposed openstack/python-ironicclient master: Traits support https://review.openstack.org/532622 | 03:13 |
jroll | thanks for the kicker | 03:13 |
rloo | TheJulia: I have to go, but I just reviewed https://review.openstack.org/#/c/537283/. I think it needs a release note though. | 03:13 |
patchbot | patch 537283 - python-ironicclient - Can not set portgroup mode as a number | 03:13 |
rloo | TheJulia: at this point, I am also good w/o it. Tomorrow I may change my mind. Darn, I'll just +A. | 03:14 |
TheJulia | heh | 03:14 |
rloo | thx jroll! too late for me to review. will look at it tomorrow if it hasn't been +A'd by then. client patches at least, merge faster. | 03:15 |
rloo | TheJulia: thanks for keeping an eye out and pushing things along :) | 03:15 |
jroll | rloo: no problem, I am also crashing out | 03:15 |
TheJulia | rloo: awesome, and thanks | 03:15 |
TheJulia | I'm not far, but likely will still try and rebase rescue api tonight | 03:15 |
rloo | goodnight! | 03:15 |
TheJulia | goodnight | 03:16 |
rloo | TheJulia: i would expect shiv to do the rebase. you can leave him a note/comment. | 03:16 |
*** rloo has quit IRC | 03:16 | |
TheJulia | eh, it is an easy rebase | 03:17 |
*** cjloader has joined #openstack-ironic | 03:17 | |
*** harlowja has quit IRC | 03:21 | |
*** zhangfei has joined #openstack-ironic | 03:27 | |
*** openstackgerrit has quit IRC | 03:33 | |
TheJulia | commented on the rescue patches... wow that was many places, I forgot how fun it was to change api versions | 03:35 |
TheJulia | "fun" | 03:35 |
*** openstackgerrit has joined #openstack-ironic | 03:49 | |
openstackgerrit | Merged openstack/ironic master: Add RPC API and conductor manager for traits https://review.openstack.org/535296 | 03:49 |
TheJulia | \o/ | 03:54 |
openstackgerrit | Julia Kreger proposed openstack/ironic master: Don't try to lock upfront for vif removal https://review.openstack.org/534441 | 03:54 |
openstackgerrit | Julia Kreger proposed openstack/ironic master: Don't lock for vif_attach unless active https://review.openstack.org/537737 | 03:54 |
TheJulia | mgoddard: likely more thought required for the attach one ^^^ | 03:55 |
*** namnh has joined #openstack-ironic | 03:57 | |
openstackgerrit | Julia Kreger proposed openstack/ironic master: DNM Return multinode multitenant to voting status https://review.openstack.org/537739 | 04:05 |
*** links has joined #openstack-ironic | 04:10 | |
TheJulia | ricardoas: looks like one of the oneview patches needs a recheck, I think two other need rebases. it is still tesitng, looks like scheduling... but I'm out of braincells tonight | 04:15 |
* TheJulia goes to bed | 04:15 | |
*** jaganathan has joined #openstack-ironic | 04:26 | |
*** harlowja has joined #openstack-ironic | 04:28 | |
*** fragatina has joined #openstack-ironic | 04:34 | |
*** fragatina has quit IRC | 04:35 | |
*** fragatina has joined #openstack-ironic | 04:35 | |
openstackgerrit | Dao Cong Tien proposed openstack/ironic-tempest-plugin master: Rescue mode tempest tests https://review.openstack.org/528699 | 04:39 |
*** zhenguo has quit IRC | 04:54 | |
*** etingof has quit IRC | 04:55 | |
*** cjloader has quit IRC | 04:58 | |
*** crushil has joined #openstack-ironic | 04:58 | |
*** rbudden has quit IRC | 05:01 | |
*** etingof has joined #openstack-ironic | 05:09 | |
*** sasha2 has quit IRC | 05:11 | |
*** harlowja has quit IRC | 05:17 | |
*** fragatina has quit IRC | 05:20 | |
openstackgerrit | Merged openstack/ironic master: API: Node Traits API https://review.openstack.org/532269 | 05:20 |
openstackgerrit | Merged openstack/ironic master: Add node traits to API reference https://review.openstack.org/536384 | 05:20 |
*** jtomasek has joined #openstack-ironic | 05:23 | |
openstackgerrit | John L. Villalovos proposed openstack/ironic-lib master: WIP/DNM: Initial skeleton support for mypy static type checking https://review.openstack.org/386892 | 05:30 |
openstackgerrit | Merged openstack/python-ironicclient master: Can not set portgroup mode as a number https://review.openstack.org/537283 | 05:33 |
openstackgerrit | Gao Fei proposed openstack/ironic master: Replace curly quotes with straight quotes https://review.openstack.org/537277 | 05:38 |
*** dsneddon has quit IRC | 05:44 | |
*** crushil has quit IRC | 05:54 | |
openstackgerrit | paresh sao proposed openstack/ironic master: Implementation for UEFI iSCSI boot for ILO https://review.openstack.org/468288 | 06:00 |
*** dpawar has joined #openstack-ironic | 06:07 | |
*** ianychoi has quit IRC | 06:08 | |
*** ianychoi has joined #openstack-ironic | 06:09 | |
*** zhurong has quit IRC | 06:13 | |
*** rcernin has quit IRC | 06:14 | |
*** vsaienk0 has joined #openstack-ironic | 06:15 | |
*** AlexeyAbashkin has joined #openstack-ironic | 06:22 | |
*** vsaienk0 has quit IRC | 06:25 | |
*** AlexeyAbashkin has quit IRC | 06:30 | |
openstackgerrit | paresh sao proposed openstack/ironic master: Implementation for UEFI iSCSI boot for ILO https://review.openstack.org/468288 | 06:33 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/ironic-ui master: Imported Translations from Zanata https://review.openstack.org/537761 | 06:45 |
openstackgerrit | Shivanand Tendulker proposed openstack/ironic master: Agent rescue implementation https://review.openstack.org/400437 | 06:52 |
openstackgerrit | Shivanand Tendulker proposed openstack/ironic master: Add API methods for [un]rescue https://review.openstack.org/350831 | 06:52 |
*** threestrands_ has quit IRC | 07:02 | |
*** marios has joined #openstack-ironic | 07:02 | |
*** mjura has joined #openstack-ironic | 07:07 | |
*** phuongnh has quit IRC | 07:11 | |
openstackgerrit | Tapio Tallgren proposed openstack/bifrost master: Rewrite iptables rules with Ansible module https://review.openstack.org/536911 | 07:11 |
*** jaganathan has quit IRC | 07:16 | |
openstackgerrit | Shivanand Tendulker proposed openstack/ironic master: Add API methods for [un]rescue https://review.openstack.org/350831 | 07:16 |
openstackgerrit | Shivanand Tendulker proposed openstack/ironic master: Add rescue interface field to node-related notifications https://review.openstack.org/502889 | 07:16 |
*** hoonetorg has quit IRC | 07:17 | |
*** etingof has quit IRC | 07:23 | |
*** rbartal has joined #openstack-ironic | 07:23 | |
*** jtomasek has quit IRC | 07:26 | |
*** jaganathan has joined #openstack-ironic | 07:29 | |
*** hoonetorg has joined #openstack-ironic | 07:29 | |
*** e0ne has joined #openstack-ironic | 07:30 | |
sapd_ | hi everyone! I'm launching an baremetal instance use multi tenancy feature, But When disk on node attached to conductor, It has an error. 2018-01-25 14:31:53.343 5647 ERROR ironic.drivers.modules.agent_base_vendor InstanceDeployFailure: Deploy failed for instance 367197ff-dc64-43dc-a82f-80adf126eb3c. Error: Disk partitioning failed on device /dev/disk/by-path/ip-192.168.55. | 07:36 |
sapd_ | 201:3260-iscsi-iqn.2008-10.org.openstack:39b8e375-2c31-4828-8f4e-27d4021218b9-lun-1. Fuser exited with "Cannot stat file /proc/9150/fd/12: Stale file handle | 07:36 |
sapd_ | I do not find any information about this error. | 07:36 |
*** etingof has joined #openstack-ironic | 07:36 | |
*** hshiina has joined #openstack-ironic | 07:46 | |
*** pcaruana has joined #openstack-ironic | 07:55 | |
*** e0ne has quit IRC | 07:56 | |
*** vsaienk0 has joined #openstack-ironic | 08:00 | |
*** AlexeyAbashkin has joined #openstack-ironic | 08:04 | |
*** tesseract has joined #openstack-ironic | 08:20 | |
*** pmannidi has quit IRC | 08:23 | |
*** pmannidi has joined #openstack-ironic | 08:24 | |
*** gcb has quit IRC | 08:26 | |
*** pmannidi has quit IRC | 08:29 | |
*** gcb has joined #openstack-ironic | 08:29 | |
openstackgerrit | Kaifeng Wang proposed openstack/ironic master: Update api-ref for port group create https://review.openstack.org/537803 | 08:43 |
openstackgerrit | Dao Cong Tien proposed openstack/python-ironicclient master: Add support for RESCUE and UNRESCUE provision states https://review.openstack.org/408341 | 09:00 |
openstackgerrit | Dao Cong Tien proposed openstack/python-ironicclient master: Add rescue_interface to node and driver https://review.openstack.org/517302 | 09:02 |
*** amarao has joined #openstack-ironic | 09:06 | |
openstackgerrit | Dao Cong Tien proposed openstack/ironic master: devstack: add support for rescue mode https://review.openstack.org/524118 | 09:09 |
*** amarao has quit IRC | 09:12 | |
*** marios has quit IRC | 09:12 | |
*** marios has joined #openstack-ironic | 09:14 | |
openstackgerrit | Dao Cong Tien proposed openstack/ironic master: CI job for rescue mode https://review.openstack.org/528704 | 09:17 |
openstackgerrit | Dao Cong Tien proposed openstack/ironic master: DNM: test rescue mode https://review.openstack.org/533187 | 09:21 |
*** hshiina has quit IRC | 09:29 | |
*** derekh has joined #openstack-ironic | 09:29 | |
*** etingof has quit IRC | 09:30 | |
*** e0ne has joined #openstack-ironic | 09:31 | |
*** MattMan has quit IRC | 09:31 | |
*** MattMan has joined #openstack-ironic | 09:32 | |
openstackgerrit | ya.wang proposed openstack/ironic master: Add timeout for common/image_service module's HTTP request via the requests library. https://review.openstack.org/537311 | 09:35 |
*** etingof has joined #openstack-ironic | 09:41 | |
*** amarao has joined #openstack-ironic | 09:44 | |
*** jtomasek has joined #openstack-ironic | 09:51 | |
openstackgerrit | Dao Cong Tien proposed openstack/ironic master: Update "standalone" job for supporting rescue mode https://review.openstack.org/537821 | 09:51 |
*** jtomasek has quit IRC | 09:54 | |
openstackgerrit | Dao Cong Tien proposed openstack/ironic master: DNM: standalone test rescue mode https://review.openstack.org/534751 | 09:55 |
*** jtomasek has joined #openstack-ironic | 09:55 | |
*** zhurong_ has joined #openstack-ironic | 09:56 | |
*** vabada has quit IRC | 10:05 | |
*** vabada has joined #openstack-ironic | 10:06 | |
*** hoonetorg has quit IRC | 10:09 | |
*** vabada has left #openstack-ironic | 10:11 | |
*** vabada has joined #openstack-ironic | 10:11 | |
*** milan has joined #openstack-ironic | 10:19 | |
*** jtomasek has quit IRC | 10:21 | |
*** hoonetorg has joined #openstack-ironic | 10:22 | |
openstackgerrit | Shivanand Tendulker proposed openstack/ironic master: Update description for config params of 'rescue' interface https://review.openstack.org/517919 | 10:27 |
openstackgerrit | Shivanand Tendulker proposed openstack/ironic master: Add documentation for rescue interface https://review.openstack.org/419606 | 10:27 |
*** liuzz has quit IRC | 10:30 | |
*** lucas-afk is now known as lucasagomes | 10:37 | |
*** zhangfei has quit IRC | 10:39 | |
*** jistr is now known as jistr|mtg | 10:49 | |
*** gcb has quit IRC | 11:17 | |
*** gcb has joined #openstack-ironic | 11:20 | |
*** namnh has quit IRC | 11:31 | |
openstackgerrit | Shivanand Tendulker proposed openstack/ironic master: Add documentation for rescue interface https://review.openstack.org/419606 | 11:33 |
*** tiendc has quit IRC | 11:35 | |
*** sapd_ has quit IRC | 11:45 | |
*** gmonteiro has joined #openstack-ironic | 11:54 | |
openstackgerrit | Merged openstack/ironic master: Allow setting {provisioning,cleaning,rescuing}_network in driver_info https://review.openstack.org/460564 | 11:54 |
gmonteiro | Good Morning Ironic | 11:54 |
*** AlexeyAbashkin has quit IRC | 11:58 | |
*** AlexeyAbashkin has joined #openstack-ironic | 11:58 | |
*** sapd_ has joined #openstack-ironic | 11:58 | |
*** jkilpatr has quit IRC | 12:08 | |
*** tesseract has quit IRC | 12:24 | |
*** nicodemos has joined #openstack-ironic | 12:28 | |
nicodemos | morning. :) | 12:29 |
sambetts|afk | TheJulia, dtantsur|afk: I think we might have introduced a race https://review.openstack.org/#/c/460564/31/ironic/common/neutron.py | 12:32 |
patchbot | patch 460564 - ironic - Allow setting {provisioning,cleaning,rescuing}_net... (MERGED) | 12:32 |
*** sambetts|afk is now known as sambetts | 12:35 | |
*** gmonteiro has quit IRC | 12:36 | |
*** jistr|mtg is now known as jistr | 12:38 | |
*** bfournie has quit IRC | 12:40 | |
*** bfournie has joined #openstack-ironic | 12:40 | |
*** bfournie has quit IRC | 12:44 | |
*** jkilpatr has joined #openstack-ironic | 12:47 | |
*** gmonteiro has joined #openstack-ironic | 12:47 | |
*** jkilpatr has quit IRC | 12:47 | |
*** jkilpatr has joined #openstack-ironic | 12:47 | |
*** jtomasek has joined #openstack-ironic | 12:53 | |
*** makowals has quit IRC | 12:54 | |
*** makowals has joined #openstack-ironic | 12:56 | |
*** jlabarre has joined #openstack-ironic | 12:58 | |
*** dprince has joined #openstack-ironic | 13:05 | |
*** cdearborn has joined #openstack-ironic | 13:06 | |
openstackgerrit | Hugo Nicodemos proposed openstack/ironic master: DNM|WIP Test OneView CI with Hardware Type https://review.openstack.org/537896 | 13:11 |
*** vsaienk0 has quit IRC | 13:14 | |
*** rbartal has quit IRC | 13:14 | |
openstackgerrit | Harald Jensås proposed openstack/ironic master: Flat networks use node.uuid when binding ports. https://review.openstack.org/536040 | 13:15 |
*** bfournie has joined #openstack-ironic | 13:15 | |
*** makowals has quit IRC | 13:19 | |
*** vsaienk0 has joined #openstack-ironic | 13:25 | |
*** makowals has joined #openstack-ironic | 13:26 | |
*** tesseract has joined #openstack-ironic | 13:28 | |
*** yolanda has joined #openstack-ironic | 13:34 | |
*** rloo has joined #openstack-ironic | 13:34 | |
TheJulia | sambetts: would you mind reverting out just the caching bits in that case, to be on the safe side? | 13:36 |
*** tesseract has quit IRC | 13:42 | |
*** tesseract has joined #openstack-ironic | 13:42 | |
*** jcoufal has joined #openstack-ironic | 13:43 | |
TheJulia | Any cores: Please review https://review.openstack.org/#/c/400437/89 | 13:43 |
patchbot | patch 400437 - ironic - Agent rescue implementation | 13:43 |
rloo | Good morning ironic'ers, TheJulia, sambetts | 13:43 |
TheJulia | and https://review.openstack.org/#/c/350831/82 | 13:43 |
patchbot | patch 350831 - ironic - Add API methods for [un]rescue | 13:43 |
TheJulia | good morning rloo | 13:43 |
rloo | TheJulia: will look at rescue stuff now. I just +2'd the client part of trait, the rest of trait can wait I think | 13:44 |
*** zhurong_ has quit IRC | 13:44 | |
rloo | TheJulia: and let me know if there are any client-related patches to review. the release is today, right? | 13:44 |
*** trown|outtypewww is now known as trown|rover | 13:45 | |
*** gmonteiro has left #openstack-ironic | 13:47 | |
TheJulia | rloo: yeah, we just need to cut the client release today, and if we can get those two rescue patches in the gate it would be totally awesome | 13:49 |
TheJulia | yes, today() | 13:50 |
rloo | TheJulia: well, we need the two rescue patches + client rescue (which i haven't looked at) | 13:50 |
TheJulia | exactly | 13:50 |
TheJulia | rescue client shouldn't be a big deal, I'm about to go pull it up now | 13:50 |
TheJulia | first coffee() | 13:51 |
rloo | TheJulia: should be do-able. I've got all day! :) | 13:51 |
*** jjohnson2 has joined #openstack-ironic | 13:53 | |
*** sasha2 has joined #openstack-ironic | 13:58 | |
*** weshay|rover is now known as weshay|ruck | 13:58 | |
*** Goneri has joined #openstack-ironic | 13:59 | |
TheJulia | requirements client change: 10 second review: https://review.openstack.org/#/c/534284/ | 14:00 |
patchbot | patch 534284 - python-ironic-inspector-client - Updated from global requirements | 14:00 |
*** kzaitsev1pi has joined #openstack-ironic | 14:01 | |
*** kzaitsev_pi has quit IRC | 14:03 | |
*** crushil has joined #openstack-ironic | 14:04 | |
*** Goneri has quit IRC | 14:05 | |
*** kzaitsev_pi has joined #openstack-ironic | 14:05 | |
*** Goneri has joined #openstack-ironic | 14:07 | |
TheJulia | I just looked at the rescue client, only thing I see is the reno needs a minor updating | 14:08 |
*** kzaitsev1pi has quit IRC | 14:08 | |
*** sasha2 has left #openstack-ironic | 14:08 | |
*** rbudden has joined #openstack-ironic | 14:11 | |
*** vsaienk0 has quit IRC | 14:15 | |
*** tesseract has quit IRC | 14:17 | |
*** tesseract has joined #openstack-ironic | 14:18 | |
*** vsaienk0 has joined #openstack-ironic | 14:20 | |
*** jjohnson2 has quit IRC | 14:21 | |
*** mgoddard_ has joined #openstack-ironic | 14:24 | |
*** cjloader has joined #openstack-ironic | 14:25 | |
-openstackstatus- NOTICE: We're currently experiencing issues with the logs.openstack.org server which will result in POST_FAILURE for jobs, please stand by and don't needlessly recheck jobs while we troubleshoot the problem. | 14:25 | |
*** lucasagomes is now known as lucas-hungry | 14:27 | |
*** milan has quit IRC | 14:27 | |
*** dpawar has quit IRC | 14:31 | |
TheJulia | oh release day | 14:31 |
*** dmellado has quit IRC | 14:32 | |
*** yangyapeng has quit IRC | 14:32 | |
*** jcoufal has quit IRC | 14:32 | |
*** jcoufal has joined #openstack-ironic | 14:35 | |
*** cjloader has quit IRC | 14:38 | |
*** dmellado has joined #openstack-ironic | 14:39 | |
*** cjloader has joined #openstack-ironic | 14:39 | |
*** dmellado has quit IRC | 14:39 | |
*** dmellado has joined #openstack-ironic | 14:41 | |
*** dmellado has quit IRC | 14:42 | |
*** dmellado has joined #openstack-ironic | 14:43 | |
*** dmellado has quit IRC | 14:44 | |
*** hshiina has joined #openstack-ironic | 14:52 | |
*** dmellado has joined #openstack-ironic | 14:53 | |
*** dmellado has quit IRC | 14:53 | |
openstackgerrit | Sam Betts proposed openstack/ironic-inspector master: [WIP][DNM] Some beginnings towards removing construct from inspector https://review.openstack.org/537472 | 14:53 |
*** yangyapeng has joined #openstack-ironic | 14:59 | |
bfournie | hi sambetts, do we still need to do this ^ as we have a fix for construct lib issue? | 15:00 |
*** dmellado has joined #openstack-ironic | 15:01 | |
*** dmellado has quit IRC | 15:01 | |
sambetts | bfournie: perhaps not, but I have been exploring how easy/hard it would be to do it if we needed too, because the attitude of the construct libraries developer towards not breaking compatibility was a concern | 15:02 |
*** r-daneel has joined #openstack-ironic | 15:02 | |
*** dmellado has joined #openstack-ironic | 15:03 | |
*** dmellado has quit IRC | 15:03 | |
bfournie | sambetts: ok, yeah seems ok now, but agree that developer's lack of concern backwards compatibility is an issue | 15:04 |
jroll | morning y'all | 15:07 |
TheJulia | good morning! | 15:07 |
sambetts | jroll: o/ | 15:07 |
*** vabada has quit IRC | 15:09 | |
*** vabada has joined #openstack-ironic | 15:09 | |
openstackgerrit | Merged openstack/python-ironic-inspector-client master: Updated from global requirements https://review.openstack.org/534284 | 15:13 |
openstackgerrit | Jim Rollenhagen proposed openstack/python-ironicclient master: Check return value in test_baremetal_list_traits https://review.openstack.org/537934 | 15:14 |
jroll | easy follow-up, not urgent ^ | 15:14 |
TheJulia | jroll: thanks, will kick it once CI is running again | 15:15 |
TheJulia | oh nice, a merge completed.... | 15:15 |
* TheJulia wonders if there is free space now | 15:15 | |
jroll | nice | 15:16 |
jroll | thanks | 15:16 |
*** dmellado has joined #openstack-ironic | 15:19 | |
*** pcaruana has quit IRC | 15:20 | |
*** lucas-hungry is now known as lucasagomes | 15:22 | |
*** dmellado has quit IRC | 15:25 | |
*** dmellado has joined #openstack-ironic | 15:26 | |
*** dmellado has quit IRC | 15:27 | |
*** serlex has joined #openstack-ironic | 15:27 | |
openstackgerrit | Hironori Shiina proposed openstack/python-ironicclient master: Add support for RESCUE and UNRESCUE provision states https://review.openstack.org/408341 | 15:27 |
*** dmellado has joined #openstack-ironic | 15:29 | |
*** dmellado has quit IRC | 15:29 | |
*** hjensas has quit IRC | 15:30 | |
*** d0ugal has quit IRC | 15:31 | |
*** nicodemos has quit IRC | 15:32 | |
*** nicodemos has joined #openstack-ironic | 15:33 | |
*** amarao1 has joined #openstack-ironic | 15:35 | |
*** d0ugal has joined #openstack-ironic | 15:40 | |
rloo | morning jroll, sambetts! | 15:41 |
sambetts | hey rloo | 15:41 |
jroll | \o | 15:41 |
rloo | TheJulia: I just +A'd the agent rescue patch. Should I have waited, due to gate issues? (Have they been resolved yet?) | 15:41 |
TheJulia | rloo: please wait if possible | 15:41 |
TheJulia | although | 15:41 |
TheJulia | we might have to rebase | 15:42 |
rloo | TheJulia: WHAT? | 15:42 |
TheJulia | apparently the filesystem is being fscked | 15:42 |
TheJulia | rebase to get it to pickup the job again | 15:42 |
TheJulia | just a button click rebase, its all okay | 15:42 |
TheJulia | i guess you could just keep the +a on it | 15:42 |
TheJulia | it might work | 15:42 |
TheJulia | might.... | 15:42 |
rloo | TheJulia: zuul is starting gate jobs... | 15:43 |
* TheJulia wonders BadCub could bless the CI system or something.... | 15:43 | |
rloo | TheJulia: I'm going to review the next patch... | 15:43 |
TheJulia | rloo: ack | 15:43 |
openstackgerrit | Hironori Shiina proposed openstack/python-ironicclient master: Add rescue_interface to node and driver https://review.openstack.org/517302 | 15:43 |
openstackgerrit | Sam Betts proposed openstack/ironic master: Resolve race in validating neutron networks due to caching https://review.openstack.org/537944 | 15:46 |
sambetts | TheJulia: ^^ | 15:46 |
*** yolanda has quit IRC | 15:47 | |
*** crushil has quit IRC | 15:48 | |
*** amarao has quit IRC | 15:59 | |
*** e0ne has quit IRC | 15:59 | |
*** mjura has quit IRC | 16:00 | |
*** crushil has joined #openstack-ironic | 16:00 | |
NobodyCam | Good Morning Ironic'ers | 16:00 |
*** amarao has joined #openstack-ironic | 16:01 | |
-openstackstatus- NOTICE: logs.openstack.org is stabilized and there should no longer be *new* POST_FAILURE errors. Logs for jobs that ran in the past weeks until earlier today are currently unavailable pending FSCK completion. We're going to temporarily disable *successful* jobs from uploading their logs to reduce strain on our current limited capacity. Thanks for your patience ! | 16:01 | |
TheJulia | sambetts: thanks! | 16:05 |
*** trown|rover is now known as trown|brb | 16:06 | |
openstackgerrit | Julia Kreger proposed openstack/ironic master: Agent rescue implementation https://review.openstack.org/400437 | 16:07 |
TheJulia | rloo: ^^^ rebased since it was already failing in the gate | 16:08 |
TheJulia | NobodyCam: good morning! | 16:08 |
NobodyCam | :) good morning TheJulia :) | 16:08 |
rloo | TheJulia: heh, the tricks of the trade :) | 16:09 |
rloo | good morning NobodyCam | 16:09 |
NobodyCam | Hows the weather over on your side :p | 16:09 |
NobodyCam | Good Morning rloo :) | 16:09 |
rloo | NobodyCam: a crisp (<0 C), sunny day :) | 16:09 |
rloo | NobodyCam: where are you these days? sunny california? | 16:09 |
NobodyCam | ieek | 16:09 |
TheJulia | Sunny southern california.... | 16:10 |
TheJulia | summer says it is cold outside.... | 16:10 |
NobodyCam | yep, looks like it will be about 72 today :p | 16:10 |
TheJulia | NobodyCam: looks like the grass is watered every other day | 16:11 |
rloo | Ohhh yeah, that's ccccccccold. NOT! | 16:11 |
NobodyCam | :p | 16:11 |
NobodyCam | have to dry the chairs out for the nights drinking | 16:11 |
openstackgerrit | Julia Kreger proposed openstack/python-ironicclient master: Traits support https://review.openstack.org/532622 | 16:13 |
*** trown|brb is now known as trown|rover | 16:13 | |
TheJulia | If there are no objections, I'm going to +A https://review.openstack.org/#/c/535772/ | 16:20 |
patchbot | patch 535772 - ironic - Allow data migrations to accept options | 16:20 |
TheJulia | Also, I've updated the whiteboard to reflect what has merged, what is pending, and added new patches in those series | 16:20 |
* TheJulia declares today to be a merge party day | 16:20 | |
rloo | TheJulia: this needs to be rebased too then? https://review.openstack.org/#/c/408341 | 16:22 |
patchbot | patch 408341 - python-ironicclient - Add support for RESCUE and UNRESCUE provision states | 16:22 |
TheJulia | possibly not, depends on when it gets approved | 16:22 |
TheJulia | it is no longer running in the gate | 16:22 |
TheJulia | actually no | 16:23 |
TheJulia | hshinna took care of it and updated it an hour ago, I believe | 16:23 |
rloo | TheJulia: well, it looks like it is based on the traits one, and you rebased the traits one | 16:23 |
TheJulia | which is fine once the traits one merges | 16:23 |
rloo | TheJulia: wrt 535772, yes, ok to +A. | 16:24 |
*** zshi has quit IRC | 16:27 | |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic master: Switch contributor documentation to hardware types https://review.openstack.org/537959 | 16:28 |
TheJulia | hmm... a Dmitry is someplace with a cloaking device | 16:31 |
*** dtantsur|afk is now known as dtantsur | 16:31 | |
dtantsur | morning ironic | 16:31 |
sambetts | hey dtantsur | 16:31 |
dtantsur | well, morning for someone, hopefully :D | 16:32 |
*** SerenaFeng has joined #openstack-ironic | 16:32 | |
dtantsur | sambetts: commented, I don't think there is a race in practice | 16:33 |
TheJulia | Good morning dtantsur | 16:34 |
dtantsur | o/ | 16:34 |
*** hjensas has joined #openstack-ironic | 16:34 | |
dtantsur | anything requiring my attention? I'm quite behind my emails | 16:34 |
TheJulia | dtantsur: I kind of had the same concern as sam when I was looking at it initially, fwiw | 16:34 |
TheJulia | eh... no.... traits api landed, traits client is in route to land | 16:34 |
TheJulia | some ci issues, some minor gate tweaks | 16:35 |
TheJulia | nothing major | 16:35 |
TheJulia | rescue might also land.... if we are super super lucky soon | 16:35 |
dtantsur | cool! | 16:38 |
openstackgerrit | Julia Kreger proposed openstack/python-ironicclient master: Check return value in test_baremetal_list_traits https://review.openstack.org/537934 | 16:38 |
rloo | TheJulia: it should land. working on last client patch for rescue (I hope it is the last...) | 16:38 |
TheJulia | jroll: ^^^ hit ci failures, so I clicked the rebase button. | 16:38 |
TheJulia | \o/ | 16:38 |
TheJulia | well, 201 jobs in the gate, so we should avoid waiting for any ironic things that absolutely need to land today | 16:39 |
hjensas | dtantsur: looks like rpm build is broken. http://logs.openstack.org/30/537830/1/check/tripleo-ci-centos-7-undercloud-oooq/9e56471/logs/delorean_logs/bb/63/bb63ee7569e3be2ae45e1b7e5bfdf61c4613d915_dev/rpmbuild.log.txt.gz | 16:40 |
sambetts | dtantsur: no not two threads using the same task object, the network interfaces are singletons, so two threads deplyoing two separate nodes (with potentially different provisioning networks set on them) will use the same (Flat/Neutron)NetworkInterface object and the caching saves the UUID to the object | 16:40 |
*** zshi has joined #openstack-ironic | 16:40 | |
dtantsur | oh, are they? /me thinks | 16:40 |
openstackgerrit | melissaml proposed openstack/ironic-lib master: Replace curly quotes with straight quotes https://review.openstack.org/537962 | 16:41 |
*** openstackstatus has quit IRC | 16:41 | |
dtantsur | hjensas: I've seen it once, it's transient. ideally, someone has to look into it, but that's some kind of a race.. | 16:42 |
*** openstackstatus has joined #openstack-ironic | 16:43 | |
*** ChanServ sets mode: +v openstackstatus | 16:43 | |
*** linkmark has joined #openstack-ironic | 16:43 | |
hjensas | dtantsur: ah, thanks. Then I'll recheck. But need to check infra status first ... | 16:43 |
dtantsur | sambetts: ugh. you're right, I guess. should we maintain a cache of already validated UUIDs or should we just drop this caching? | 16:44 |
sambetts | dtantsur: IMO most people won't see the benefits of the caching anyway because they'll use names, so I think https://review.openstack.org/#/c/531134/ | 16:45 |
patchbot | patch 531134 - networking-cisco - Autogenerate UCSM configuration guide and sample c... | 16:45 |
sambetts | worng patch... https://review.openstack.org/#/c/537944/ | 16:45 |
patchbot | patch 537944 - ironic - Resolve race in validating neutron networks due to... | 16:45 |
openstackgerrit | Hironori Shiina proposed openstack/ironic-tempest-plugin master: Rescue mode tempest tests https://review.openstack.org/528699 | 16:46 |
dtantsur | thanks sambetts | 16:47 |
TheJulia | looks like infracloud might be having more issues | 16:47 |
TheJulia | err | 16:47 |
TheJulia | s/infracloud/infra/ | 16:47 |
sambetts | :'( | 16:47 |
* dtantsur #sadpanda | 16:47 | |
*** hamzy has quit IRC | 16:49 | |
*** rpioso|afk is now known as rpioso | 16:49 | |
rpioso | Good morning | 16:49 |
TheJulia | good morning | 16:50 |
dtantsur | anyone wants to help unblock the inspector gate? https://review.openstack.org/#/c/537627/ | 16:51 |
patchbot | patch 537627 - ironic-inspector - Remove use of construct lib FieldError exception | 16:51 |
dtantsur | morning rpioso | 16:51 |
rpioso | dtantsur: :) | 16:51 |
openstackgerrit | Julia Kreger proposed openstack/ironic master: Allow data migrations to accept options https://review.openstack.org/535772 | 16:51 |
rloo | TheJulia: I thought you wanted to hold off on ironic patches ^^ ? | 16:52 |
TheJulia | yeah, I wish there was a stop button tbh | 16:53 |
TheJulia | it also doesn't merge conflict with anything | 16:53 |
*** baha has joined #openstack-ironic | 16:54 | |
*** jkilpatr has quit IRC | 16:54 | |
TheJulia | so logs.o.o is still limping..... | 16:55 |
TheJulia | it is going to be a long day | 16:55 |
*** jkilpatr has joined #openstack-ironic | 16:56 | |
*** trown|rover is now known as trown|lunch | 16:56 | |
*** links has quit IRC | 16:57 | |
*** jtomasek has quit IRC | 16:57 | |
*** tesseract has quit IRC | 16:58 | |
openstackgerrit | melissaml proposed openstack/ironic-python-agent master: Replace curly quotes with straight quotes https://review.openstack.org/537968 | 16:59 |
jroll | TheJulia: thanks for that | 17:00 |
TheJulia | no problem | 17:00 |
*** penick has joined #openstack-ironic | 17:01 | |
rpioso | dtantsur: I'm almost done reviewing https://review.openstack.org/#/c/526773/ | 17:02 |
patchbot | patch 526773 - ironic - boot mode support at ManagementInterface | 17:02 |
*** fragatina has joined #openstack-ironic | 17:02 | |
dtantsur | thanks! | 17:02 |
*** marios has quit IRC | 17:03 | |
*** fragatin_ has joined #openstack-ironic | 17:03 | |
rpioso | A question ... Should the base hardware interface class definition of a new, optional method return a value or raise an UnsupportedDriverExtension exception? | 17:04 |
* dtantsur has to go in 10 minutes | 17:04 | |
rpioso | dtantsur: ^^^ | 17:04 |
dtantsur | rpioso: depends on whether the new method is called in some existing place | 17:04 |
dtantsur | if you call it in the middle of the deploy interface, you don't want it to fail by default | 17:04 |
openstackgerrit | John L. Villalovos proposed openstack/ironic-lib master: Use the 'ironic' queue for the gate https://review.openstack.org/537972 | 17:04 |
dtantsur | if it's only invoked by users through API, it should fail | 17:04 |
* dtantsur hopes he's clear enough after 7 hours on a train | 17:05 | |
rpioso | dtantsur: Hrm, It's called by both. | 17:05 |
openstackgerrit | John L. Villalovos proposed openstack/ironic-python-agent master: Use the 'ironic' queue for the gate https://review.openstack.org/537973 | 17:06 |
dtantsur | then I guess no-op is saner. but I haven't seen the recent revisions of the patch | 17:06 |
TheJulia | +1 to sanity | 17:06 |
*** fragatina has quit IRC | 17:07 | |
*** hjensas has quit IRC | 17:07 | |
rpioso | dtantsur: For the middle of the deploy interface case, it could fail in a well known way (raise an UnsupportedDriverExtension exception) and the calling path could proceed to do what it's always done. That would provide backward compatibility for derived classes that haven't implemented the new, optional method. | 17:08 |
openstackgerrit | John L. Villalovos proposed openstack/python-ironicclient master: Use the 'ironic' queue for the gate https://review.openstack.org/537976 | 17:08 |
jlvillal | TheJulia, dtantsur: ^^^^^ Seeing the giant backup in the queue for 'integrated' I figured I would do those. | 17:08 |
dtantsur | rpioso: that's an option as well. hard to tell without looking at the code, sorry | 17:08 |
dtantsur | jlvillal: we're not in the integrated queue anyway, are we? | 17:08 |
openstackgerrit | Merged openstack/ironic master: [docs] mention new nova scheduler option https://review.openstack.org/534401 | 17:08 |
jlvillal | dtantsur, I'm not sure. I know openstack/ironic is in 'ironic' the others I don't know. | 17:09 |
rpioso | dtantsur: Hopefully, you'll see it again soon-ish :) | 17:09 |
jlvillal | dtantsur, So I made it explicit | 17:09 |
dtantsur | jlvillal: well, that's good idea, given the tight dependency between ironic and ironic-lib | 17:09 |
jlvillal | dtantsur, It is currently undefined except for openstack/ironic. So not sure what the default is | 17:09 |
rpioso | dtantsur: ty for vetting my thoughts. | 17:09 |
dtantsur | np | 17:09 |
jlvillal | dtantsur, I just saw this huge list of items in the 'integrated' queue and jobs in there over 19 hours | 17:10 |
jlvillal | http://zuul.openstack.org/ | 17:10 |
dtantsur | yeah, it covers all main projects + requirements | 17:11 |
openstackgerrit | melissaml proposed openstack/python-ironicclient master: Replace curly quotes with straight quotes https://review.openstack.org/537978 | 17:12 |
TheJulia | oh, it gets its own queueu it looks like | 17:12 |
TheJulia | at least for check | 17:12 |
dtantsur | check jobs are not queued in the same way as gate jobs | 17:12 |
dtantsur | only dependant patches are stacked | 17:12 |
*** jistr is now known as jistr|conf | 17:13 | |
dtantsur | while for the gate the patches from one queue all are stacked, even unrelated from different project | 17:13 |
dtantsur | projects | 17:13 |
dtantsur | like, completely unrelated nova and neutron patches won't pass the gate in parallel | 17:13 |
*** sauloaislan has joined #openstack-ironic | 17:13 | |
TheJulia | ugh | 17:14 |
TheJulia | figures gate would be different :( | 17:14 |
TheJulia | 537934 is luckilly not needed to land | 17:14 |
jroll | it's due to shared jobs, btw. anything with a job (name?) shared between projects will be stacked | 17:15 |
dtantsur | sorry folks, have to run | 17:15 |
*** yolanda has joined #openstack-ironic | 17:15 | |
dtantsur | c u tomorrow | 17:15 |
*** dtantsur is now known as dtantsur|afk | 17:15 | |
sauloaislan | morning! | 17:15 |
jroll | bye dtantsur|afk, hi sauloaislan :) | 17:16 |
*** etingof has quit IRC | 17:18 | |
*** mjturek has joined #openstack-ironic | 17:20 | |
sauloaislan | I'm having this error when performing a master deployment. http://paste.openstack.org/raw/653465/ | 17:20 |
TheJulia | wheeeee power outage here :( | 17:35 |
*** hshiina has quit IRC | 17:36 | |
TheJulia | sauloaislan: what version of keystoneauth1 do you have? | 17:36 |
*** nicodemos has quit IRC | 17:38 | |
*** sauloaislan has quit IRC | 17:38 | |
*** penick has quit IRC | 17:38 | |
*** dpawar has joined #openstack-ironic | 17:39 | |
*** akhilaki has joined #openstack-ironic | 17:39 | |
*** akhilaki_ has joined #openstack-ironic | 17:39 | |
*** etingof has joined #openstack-ironic | 17:41 | |
*** penick has joined #openstack-ironic | 17:42 | |
*** nicodemos has joined #openstack-ironic | 17:45 | |
*** jaganathan has quit IRC | 17:49 | |
*** SerenaFeng has quit IRC | 17:51 | |
*** derekh has quit IRC | 17:54 | |
*** serlex has quit IRC | 17:57 | |
*** sauloaislan has joined #openstack-ironic | 17:58 | |
sauloaislan | TheJulia: 3.4.1.dev1 | 17:58 |
*** AlexeyAbashkin has quit IRC | 17:59 | |
*** trown|lunch is now known as trown | 17:59 | |
*** trown is now known as trown|rover | 17:59 | |
*** baha has quit IRC | 18:00 | |
*** cghome has joined #openstack-ironic | 18:00 | |
TheJulia | sauloaislan: https://github.com/openstack/requirements/blob/master/upper-constraints.txt#L478 | 18:01 |
TheJulia | too new, but I guess that means breaking changes are in the pipeline :( | 18:01 |
sauloaislan | TheJulia: Ok thks! | 18:02 |
openstackgerrit | Mark Goddard proposed openstack/ironic master: Add traits field to node notifications https://review.openstack.org/536979 | 18:03 |
openstackgerrit | Mark Goddard proposed openstack/ironic master: Fix nits found in node traits https://review.openstack.org/537386 | 18:03 |
*** weshay|ruck is now known as weshay|ruck|brb | 18:09 | |
*** penick has quit IRC | 18:09 | |
*** mgoddard_ has quit IRC | 18:09 | |
TheJulia | hmm... with the gate, I suspect I may just only be able to get the traits client stuffs in the actual library release... | 18:10 |
rloo | TheJulia: really? sigh. | 18:11 |
TheJulia | yeah... | 18:11 |
rloo | TheJulia: would it help if we killed anything in the gate? I think a -2 would do it. if there is anything we can kill... | 18:11 |
TheJulia | I should go run errands or something to ignore it for an hour or two | 18:12 |
TheJulia | rloo: it wont at this point, just got to wait | 18:12 |
rloo | TheJulia: ok, go run errands. I'm not going to approve anything today, only client ones that we want for the release. has anyone even looking at inspector client stuff? | 18:13 |
*** hamzy has joined #openstack-ironic | 18:13 | |
*** jistr|conf is now known as jistr | 18:14 | |
*** jkilpatr has quit IRC | 18:14 | |
TheJulia | rloo: https://review.openstack.org/#/c/400437/ is our latest ci victim | 18:14 |
patchbot | patch 400437 - ironic - Agent rescue implementation | 18:14 |
TheJulia | rloo: double checking, I think it was in the gate or merged by now | 18:15 |
rloo | TheJulia: shi.... | 18:15 |
rloo | TheJulia: oh, you mean ci winner? | 18:15 |
TheJulia | heh | 18:16 |
TheJulia | looks like i can release ironic-inspector | 18:16 |
*** dpawar has quit IRC | 18:16 | |
*** fragatin_ has quit IRC | 18:16 | |
*** hamzy has quit IRC | 18:18 | |
rloo | TheJulia: not sure if I am seeing correctly but 400437 has unit test failure :-( | 18:18 |
TheJulia | argh | 18:18 |
rloo | TheJulia: not sure how that is possible. it had passed before I +A'd it. i don't see how your rebase could have done it. will try locally | 18:19 |
*** hamzy has joined #openstack-ironic | 18:21 | |
* sambetts ---> home | 18:21 | |
sambetts | night all | 18:21 |
*** sambetts is now known as sambetts|afk | 18:22 | |
rloo | bye sambetts|afk | 18:22 |
*** dsneddon has joined #openstack-ironic | 18:24 | |
rloo | TheJulia: ok, i see the problem. cuz of that ironic patch that was merged. i'll have a fix up in a few. | 18:25 |
openstackgerrit | Ruby Loo proposed openstack/ironic master: Agent rescue implementation https://review.openstack.org/400437 | 18:26 |
*** dsneddon has quit IRC | 18:26 | |
TheJulia | ugh, yeah :( | 18:27 |
*** jkilpatr has joined #openstack-ironic | 18:27 | |
*** vsaienk0 has quit IRC | 18:27 | |
TheJulia | rloo: thanks! | 18:27 |
rloo | TheJulia: so yeah, lets NOT merge any other patches until the ones we want are merged. | 18:27 |
*** weshay|ruck|brb is now known as weshay | 18:27 | |
TheJulia | yeah | 18:27 |
*** cghome has quit IRC | 18:28 | |
TheJulia | i feel like we're needlessly running tempest jobs on python-ironicclient.... | 18:29 |
TheJulia | since tempest is required to have its own api client calls | 18:29 |
rloo | TheJulia: honestly, I hate tests. I mean, great that we have them. But they get in the way! :) | 18:30 |
*** fragatina has joined #openstack-ironic | 18:30 | |
*** baha has joined #openstack-ironic | 18:31 | |
*** baha1 has joined #openstack-ironic | 18:31 | |
TheJulia | https://review.openstack.org/#/c/532622/ should be in the gate shortly | 18:32 |
patchbot | patch 532622 - python-ironicclient - Traits support | 18:32 |
*** amarao has quit IRC | 18:33 | |
TheJulia | functional logs are not handy due to logs.o.o outage | 18:33 |
*** amarao1 has quit IRC | 18:33 | |
TheJulia | but at this point I'd compare it and if we're basically using the command as well against ironic, then there is literally no reason to run tempest | 18:33 |
jroll | TheJulia: tempest jobs verify ironicclient changes don't break nova->ironic | 18:34 |
TheJulia | sigh | 18:34 |
TheJulia | yeah, that is valid | 18:34 |
*** baha has quit IRC | 18:35 | |
* rloo wishes we had docs about our tests and what they're testing and why we want them | 18:35 | |
TheJulia | +10000000000000000 | 18:35 |
jroll | I think we tilted a little heavy into the "have integration tests for literally every code path" thing | 18:35 |
rloo | TheJulia: at this rate, I doubt that rescue will make it. | 18:35 |
jroll | and now every time we add a config we add it to the matrix | 18:36 |
rloo | TheJulia: argh, do we need to rebase the rescue API patch? | 18:36 |
TheJulia | jroll: indeed :( | 18:36 |
TheJulia | rloo: looking | 18:36 |
TheJulia | oh, the underlying one changed, likely. Lets just leave it be though... it is looking unlikely to make it | 18:36 |
jroll | when we say "make it", do we mean land today? | 18:37 |
rloo | TheJulia: yeah, the underlying one is the one i just fixed. | 18:37 |
rloo | jroll: yeah, make it as in, will the client for rescue make it. | 18:37 |
jroll | personally, I think that something missing a freeze due to the gate being f'd is a terrible reasson to push it to next cycle | 18:37 |
rloo | jroll: cuz we had +A'd the ironic ones for rescue. | 18:37 |
TheJulia | jroll: I feel the same way | 18:38 |
rloo | jroll: we're going to get the ironic part of rescue in. the question is the hard deadline for client today. any way it can get extended? | 18:38 |
TheJulia | I'm happy to gate tend late into the evening | 18:38 |
jroll | I can help gate tend, but I don't have +2 powers | 18:38 |
rloo | although honestly, we always get into a gate crunch every release | 18:38 |
jroll | rloo: I tend to think the release team would understand but who knows | 18:38 |
rloo | jroll: i feel like the schedule is REALLY TIGHT this release. | 18:39 |
TheJulia | I think they were cool with a couple days late last cycle.... | 18:39 |
* jroll asks them instead | 18:39 | |
TheJulia | jroll: thanks | 18:39 |
TheJulia | I'm expecting likely laaaateee tonight | 18:39 |
rloo | TheJulia: I was wondering what they meant by Thurs being the deadline. wrt what time zone... | 18:40 |
*** hjensas has joined #openstack-ironic | 18:40 | |
jroll | it's usually a rough deadline, they're reasonable people, not the IRS | 18:41 |
jroll | everyone is playing for the same team after all | 18:41 |
TheJulia | heh | 18:41 |
TheJulia | yeah | 18:41 |
TheJulia | traits client change is in the gate | 18:44 |
jroll | TheJulia: rloo: "we're getting that a lot. I suspect we'll be doing releases up until after the release team meeting tomorrow. Meeting starts at 15:00 UTC, so probably 16:00 would be the cut-off. but we'll see. if the gate it still just terrible, we'll take that into account." | 18:44 |
TheJulia | \o/ | 18:45 |
jroll | anything I can do to move things along? | 18:45 |
rloo | jroll: pray? | 18:45 |
jroll | heh | 18:45 |
rloo | jroll: i think the main patches have all been approved, just need to get them past zuul. | 18:45 |
rloo | I do wonder if we should rebase this, maybe we should just in case: https://review.openstack.org/#/c/350831/ | 18:46 |
patchbot | patch 350831 - ironic - Add API methods for [un]rescue | 18:46 |
jroll | rebase on what? | 18:46 |
rloo | jroll: on its dependent patch | 18:47 |
rloo | jroll: i had to update that one to fix a unit test failure | 18:47 |
jroll | ahhh I see | 18:47 |
rloo | jroll: i can't remember what happens if you don't rebase. and not sure it is worth waiting to see, unless someone knows whether it is ok as is. | 18:49 |
TheJulia | rloo: +2+a'ed the api patch | 18:49 |
TheJulia | rloo: pray to the patch gods, maybe sacrafice a beer? | 18:49 |
*** fragatina has quit IRC | 18:49 | |
TheJulia | err | 18:49 |
TheJulia | that was for jroll | 18:49 |
jroll | :P | 18:49 |
TheJulia | rloo: it won't do anything until after the prior patch merges... we could rebase though | 18:50 |
*** lucasagomes is now known as lucas-afk | 18:50 | |
TheJulia | rloo: actually, hold off because there are some other tests in route in the normal check queue that would get killed | 18:50 |
TheJulia | there his a whole dependency stack | 18:50 |
rloo | TheJulia: sigh. ok. | 18:51 |
* jroll sees it's time to take a shot... of dayquil | 18:51 | |
jroll | rloo: TheJulia: regardless of client freeze, I guess requirements is freezing 23:59:59 UTC on friday | 18:52 |
jroll | so if we want to bump that, we'll have to get the client release a few hours before hand | 18:52 |
TheJulia | rloo: yeah, 3 jobs are running with that patch | 18:53 |
TheJulia | yup | 18:53 |
TheJulia | going to suspend for a little bit, can't run errands since we're starting to run low on electrons | 18:54 |
rloo | jroll: right. we better have the client done way before then. | 18:54 |
* TheJulia should have put solar on the bus by now | 18:54 | |
openstackgerrit | John L. Villalovos proposed openstack/ironic-inspector master: Use the 'ironic' queue for the gate https://review.openstack.org/538001 | 18:55 |
TheJulia | anyway, dropping off for a while | 19:02 |
TheJulia | out of electrons | 19:02 |
jroll | enjoy \o | 19:02 |
*** hoonetorg has quit IRC | 19:07 | |
*** baha1 is now known as baha | 19:08 | |
rloo | jroll: we still need to land the rest of the traits patches and rescue patches (the ones that haven't been approved yet), but not today :) | 19:10 |
jroll | rloo: but hopefully today :D | 19:10 |
rloo | jroll: no, don't think so. i'm not approving anything more until we get the client out. i'm a bit burnt out wrt reviewing too. we still have a few FFEs and then there are bugs etc. For next week... | 19:11 |
jroll | rloo: fair enough, I guess I assumed we'd want thos landing with the corresponding client patches | 19:12 |
rloo | jroll: eg: 2 from here: https://review.openstack.org/#/q/topic:bug/1722194+(status:open+OR+status:merged) | 19:12 |
rloo | jroll: well maybe more than 2. | 19:13 |
jroll | rloo: ah I see. cool. | 19:13 |
rloo | jroll: yes, ideally id' want them to land today. but with the gate the way it is and we've FFE'd them, i'm fine not merging today. other projects probably have stuff they want landing today too. | 19:13 |
rloo | jroll: just wanted minimum to land to get client ones in. | 19:13 |
jroll | rloo: yeah, fair | 19:14 |
*** crushil has quit IRC | 19:15 | |
*** AlexeyAbashkin has joined #openstack-ironic | 19:24 | |
openstackgerrit | Ruby Loo proposed openstack/python-ironicclient master: Add release note for fix to bug 1745099 https://review.openstack.org/538008 | 19:24 |
openstack | bug 1745099 in python-ironicclient "ironic client can not set portgroup mode as integer" [Undecided,Fix released] https://launchpad.net/bugs/1745099 - Assigned to Kaifeng Wang (kaifeng) | 19:24 |
*** AlexeyAbashkin has quit IRC | 19:28 | |
jlvillal | rloo, mriedem was asking questions about client patches over in #openstack-nova | 19:29 |
jlvillal | rloo, Which I don't know the answer too | 19:29 |
rloo | jlvillal: oh. | 19:29 |
jlvillal | rloo, Though I guess the conversation has moved over to #openstack-release with jroll in there too | 19:29 |
rloo | jlvillal: ok, i'll leave it for jroll then. | 19:30 |
*** crushil has joined #openstack-ironic | 19:30 | |
rloo | jlvillal: well, i just joined in case... thx for the ping. | 19:31 |
jlvillal | rloo, Question was: are you waiting for these ironicclient changes to merge before you do the final ironicclient release for queens? | 19:31 |
jlvillal | I think the answer is yes. | 19:31 |
rloo | yup, yes | 19:31 |
jlvillal | i'm asking because i don't want to waste my time on the nova stuff if the deps won't get merged int time | 19:31 |
jlvillal | the ironic client change failed in the gate with a post failure, so it's going to have at least one recheck yet | 19:31 |
jlvillal | plus a release, plus a g-r bump | 19:32 |
*** sauloaislan has quit IRC | 19:32 | |
TheJulia | yeah, I'm leaning more and more to the rescue client stuff landing | 19:35 |
TheJulia | well, it can land, just might not land in time | 19:35 |
rloo | dang. so even though you have a patch dependent on another patch, you have to make sure that the dependent merges before approving or it fails with 'change depends on a change that failed to merge' ? | 19:35 |
*** dsneddon has joined #openstack-ironic | 19:36 | |
*** crushil_ has joined #openstack-ironic | 19:36 | |
TheJulia | rloo: case dependant, but yeah | 19:36 |
*** dsneddon has quit IRC | 19:37 | |
*** dsneddon has joined #openstack-ironic | 19:37 | |
jlvillal | rloo, Well if the patch you depend on fails in the 'gate' and gets a -2 then yeah your patch then gets that error :( | 19:37 |
jlvillal | And the cycle has to start from the beginning. | 19:38 |
rloo | jlvillal: right. but the traits patch merged. the one that the client was dependent on. which is why i am wondering. | 19:38 |
jlvillal | rloo, Hmmm. I'm not sure. | 19:39 |
jlvillal | rloo, Should I add https://review.openstack.org/#/c/532622/ to my recheck script? | 19:39 |
patchbot | patch 532622 - python-ironicclient - Traits support | 19:39 |
jlvillal | Or any others? | 19:39 |
*** fragatina has joined #openstack-ironic | 19:39 | |
rloo | jlvillal: yeah, the rescue ones. sec. | 19:40 |
rloo | jlvillal: https://review.openstack.org/#/c/400437/ | 19:40 |
patchbot | patch 400437 - ironic - Agent rescue implementation | 19:40 |
*** crushil has quit IRC | 19:40 | |
jlvillal | rloo, Added | 19:41 |
rloo | thx jlvillal | 19:41 |
*** harlowja has joined #openstack-ironic | 19:44 | |
*** anupn has joined #openstack-ironic | 19:49 | |
*** e0ne has joined #openstack-ironic | 19:49 | |
*** cghomer has joined #openstack-ironic | 19:51 | |
*** akhilaki has quit IRC | 19:53 | |
*** akhilaki_ has quit IRC | 19:53 | |
TheJulia | oh, the day keeps getting better | 20:03 |
TheJulia | The feeder burned out underground and ETR is 6 to 7 days | 20:03 |
*** dsneddon has quit IRC | 20:07 | |
*** dsneddon has joined #openstack-ironic | 20:07 | |
*** dsneddon has quit IRC | 20:07 | |
*** dsneddon has joined #openstack-ironic | 20:08 | |
rloo | jroll: i just -1'd https://review.openstack.org/#/c/532288/. would you confirm whether i'm right/wrong? | 20:08 |
patchbot | patch 532288 - nova - Implement get_traits() for the ironic virt driver | 20:08 |
*** e0ne has quit IRC | 20:08 | |
rloo | TheJulia: :-( | 20:08 |
jroll | rloo: after this meeting, ya | 20:09 |
jroll | TheJulia: ouch | 20:09 |
*** Goneri has quit IRC | 20:09 | |
*** dsneddon has quit IRC | 20:09 | |
*** dsneddon has joined #openstack-ironic | 20:10 | |
jroll | rloo: you are correct | 20:11 |
rloo | jroll: wrt your comment @827, isn't it ok to remove that later, in a follow up, after the dust settles etc and it is working. it does no harm? | 20:12 |
jroll | rloo: yeah, though it masks any problems like the one you found | 20:12 |
rloo | jroll: heh | 20:12 |
*** hoonetorg has joined #openstack-ironic | 20:14 | |
*** jkilpatr has quit IRC | 20:22 | |
*** hw_wutianwei1 has joined #openstack-ironic | 20:32 | |
*** dprince has quit IRC | 20:33 | |
*** hw_wutianwei has quit IRC | 20:34 | |
*** hw_wutianwei1 is now known as hw_wutianwei | 20:34 | |
*** e0ne has joined #openstack-ironic | 20:36 | |
*** jtomasek has joined #openstack-ironic | 20:36 | |
*** jtomasek has quit IRC | 20:38 | |
*** cghomer has quit IRC | 20:41 | |
rloo | TheJulia: just want to confirm. wrt client, we are waiting only for this trait patch to merge? https://review.openstack.org/#/c/532622/ | 20:42 |
patchbot | patch 532622 - python-ironicclient - Traits support | 20:42 |
rloo | TheJulia: cuz the rescue patches haven't been approved. (I thought they had, can't keep track...) | 20:42 |
*** e0ne has quit IRC | 20:54 | |
*** dsneddon has quit IRC | 20:55 | |
*** dsneddon has joined #openstack-ironic | 20:57 | |
rloo | jlvillal, TheJulia: this release note would be useful in client release. Amazing how long it took just for that check :-( https://review.openstack.org/538008 | 21:02 |
patchbot | patch 538008 - python-ironicclient - Add release note for fix to bug 1745099 | 21:02 |
openstack | bug 1745099 in python-ironicclient "ironic client can not set portgroup mode as integer" [Undecided,Fix released] https://launchpad.net/bugs/1745099 - Assigned to Kaifeng Wang (kaifeng) | 21:02 |
*** akhilaki_ has joined #openstack-ironic | 21:14 | |
*** akhilaki has joined #openstack-ironic | 21:14 | |
TheJulia | ugh, okay.... new campground spot | 21:20 |
TheJulia | rloo: yes, at this point, only traits client | 21:20 |
rloo | TheJulia: hope you enjoy your new home :) | 21:20 |
*** jkilpatr has joined #openstack-ironic | 21:21 | |
TheJulia | rloo: at least until we close on the house | 21:21 |
rloo | TheJulia: are you going to add some prelude patch for the client release? | 21:21 |
TheJulia | rloo: hadn't thought about it, to be honest | 21:22 |
rloo | TheJulia: A New Home. That'll be nice :) | 21:22 |
rloo | TheJulia: i'm afraid to look at the release notes, to see if they need edit'ing. so I'm leaving that for you to do or not to do. | 21:22 |
TheJulia | heh, will look in a few | 21:22 |
TheJulia | rloo: heh, going to have to build them locally :( | 21:27 |
TheJulia | on a plus side, close to re-entering the gate | 21:27 |
rloo | TheJulia: you released python-ironic-inspector-client, right? I don't see anything that needs to go in. | 21:27 |
TheJulia | rloo: I was going to try and get to them at the same time, since it is two separate changes to the same repo | 21:27 |
rloo | TheJulia: sigh. on the bright side, building locally will be faster | 21:27 |
rloo | TheJulia: oh, didn't realize that. ok. | 21:28 |
rloo | jroll: if you have thoughts about notifications and when/if to include node.traits in any of them: https://review.openstack.org/#/c/536979/ | 21:29 |
patchbot | patch 536979 - ironic - Add traits field to node notifications | 21:29 |
jroll | rloo: done, tldr I think always | 21:32 |
rloo | jroll: yeah, thx! | 21:32 |
rloo | jroll: he had that in the previous set, not sure why he changed it. | 21:33 |
jroll | hm, odd | 21:34 |
*** jheroux has joined #openstack-ironic | 21:40 | |
*** jheroux has quit IRC | 21:43 | |
*** hamzy has quit IRC | 21:43 | |
rloo | one step closer... it is in THE gate: https://review.openstack.org/532622 | 21:51 |
patchbot | patch 532622 - python-ironicclient - Traits support | 21:51 |
TheJulia | https://review.openstack.org/#/c/538044/ | 21:56 |
patchbot | patch 538044 - releases - Release python-ironic-inspector-client 3.1.0 (queens) | 21:56 |
TheJulia | fyi | 21:56 |
rloo | TheJulia: thx! | 22:00 |
*** linkmark has quit IRC | 22:00 | |
*** dsneddon has quit IRC | 22:03 | |
*** dsneddon has joined #openstack-ironic | 22:04 | |
*** jlabarre has quit IRC | 22:06 | |
*** dsneddon has quit IRC | 22:08 | |
*** crushil_ has quit IRC | 22:08 | |
*** trown|rover is now known as trown|outtypewww | 22:09 | |
*** dsneddon has joined #openstack-ironic | 22:20 | |
*** baha has quit IRC | 22:26 | |
*** Goneri has joined #openstack-ironic | 22:29 | |
TheJulia | close... getting close... | 22:31 |
jroll | woo | 22:33 |
rloo | TheJulia: ... :) | 22:34 |
openstackgerrit | Merged openstack/ironic master: Allow data migrations to accept options https://review.openstack.org/535772 | 22:50 |
*** jcoufal has quit IRC | 22:54 | |
openstackgerrit | Merged openstack/python-ironicclient master: Traits support https://review.openstack.org/532622 | 22:56 |
rloo | wheee ^^ | 22:57 |
rloo | TheJulia: it would be good to land this release note too (even though you can't see how it is rendered): https://review.openstack.org/538008 | 22:58 |
patchbot | patch 538008 - python-ironicclient - Add release note for fix to bug 1745099 | 22:58 |
openstack | bug 1745099 in python-ironicclient "ironic client can not set portgroup mode as integer" [Undecided,Fix released] https://launchpad.net/bugs/1745099 - Assigned to Kaifeng Wang (kaifeng) | 22:58 |
rloo | jlvillal: ^^ easy one | 22:58 |
TheJulia | rloo: sure, if it lands fast ;) | 23:04 |
rloo | TheJulia: if it gets approved fast first :) | 23:04 |
*** zer0c00l has joined #openstack-ironic | 23:05 | |
openstackgerrit | Merged openstack/ironic master: Implementation for UEFI iSCSI boot for ILO https://review.openstack.org/468288 | 23:06 |
TheJulia | it has a +2, we can always merge to the stable branch and release a minor version for later | 23:11 |
TheJulia | well, rev | 23:11 |
rloo | TheJulia: I decided to approve it. If it doesn't make it, it doesn't make it. but it makes me sad that a simple thing like that doesn't make it and we'd have to do a merge thingy etc later just to do the right thing. oh well. | 23:12 |
TheJulia | c'est la vie | 23:12 |
rloo | who reads the release notes anyway. and who will even encounter that bug or cares. | 23:12 |
jroll | I gotta step away for a bit, will check back later on | 23:17 |
*** cdearborn_ has joined #openstack-ironic | 23:21 | |
*** ianychoi has quit IRC | 23:26 | |
*** ianychoi has joined #openstack-ironic | 23:27 | |
*** bfournie has quit IRC | 23:27 | |
openstackgerrit | Merged openstack/python-ironicclient master: Add release note for fix to bug 1745099 https://review.openstack.org/538008 | 23:28 |
openstack | bug 1745099 in python-ironicclient "ironic client can not set portgroup mode as integer" [Undecided,Fix released] https://launchpad.net/bugs/1745099 - Assigned to Kaifeng Wang (kaifeng) | 23:28 |
*** cjloader has quit IRC | 23:30 | |
*** Goneri has quit IRC | 23:30 | |
*** cdearborn has quit IRC | 23:37 | |
*** rbudden has quit IRC | 23:43 | |
*** r-daneel has quit IRC | 23:57 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!