Tuesday, 2018-01-23

*** r-daneel has quit IRC00:01
*** srart has joined #openstack-ironic00:04
*** gcb has quit IRC00:05
*** robcresswell has quit IRC00:12
*** AlexeyAbashkin has joined #openstack-ironic00:16
*** AlexeyAbashkin has quit IRC00:21
*** yangyapeng has quit IRC00:26
*** jkilpatr has quit IRC00:28
*** rbudden has quit IRC00:43
*** sambetts|afk has quit IRC00:54
*** sambetts_ has joined #openstack-ironic00:54
*** d0ugal has quit IRC00:55
*** lbragstad has quit IRC00:57
*** d0ugal has joined #openstack-ironic00:59
*** crushil has joined #openstack-ironic01:01
*** rloo has quit IRC01:03
*** phuongnh has joined #openstack-ironic01:06
*** yangyapeng has joined #openstack-ironic01:13
*** Goneri has quit IRC01:14
*** tiendc has joined #openstack-ironic01:17
*** cjloader has quit IRC01:26
*** hshiina has joined #openstack-ironic01:46
*** kiseok7_ has quit IRC01:55
*** kiseok7_ has joined #openstack-ironic01:56
*** kiseok7_ has quit IRC01:57
*** kiseok7_ has joined #openstack-ironic01:58
*** kiseok7_ has quit IRC01:59
*** kiseok7_ has joined #openstack-ironic02:01
*** kiseok7_ has quit IRC02:08
*** kiseok7_ has joined #openstack-ironic02:08
*** kiseok7_ has quit IRC02:08
*** yangyapeng has quit IRC02:08
*** yolanda has joined #openstack-ironic02:09
*** kiseok7_ has joined #openstack-ironic02:09
*** robcresswell has joined #openstack-ironic02:09
*** yangyapeng has joined #openstack-ironic02:13
*** lbragstad has joined #openstack-ironic02:14
*** harlowja has quit IRC02:27
*** ijw has quit IRC02:49
*** jaganathan has quit IRC02:57
*** hieulq has joined #openstack-ironic03:09
*** sasha2 has quit IRC03:13
*** jaganathan has joined #openstack-ironic03:14
*** ptx0 has quit IRC03:22
*** fragatina has quit IRC03:25
*** hieulq_ has joined #openstack-ironic03:25
*** ptx0 has joined #openstack-ironic03:26
*** phuongnh has quit IRC03:27
*** tiendc has quit IRC03:27
*** hieulq has quit IRC03:28
*** tiendc has joined #openstack-ironic03:32
*** phuongnh has joined #openstack-ironic03:32
*** wong has joined #openstack-ironic03:34
*** hshiina has quit IRC03:43
*** hshiina has joined #openstack-ironic03:47
*** fragatina has joined #openstack-ironic04:01
*** sapd_ has quit IRC04:02
*** sapd_ has joined #openstack-ironic04:02
*** links has joined #openstack-ironic04:02
*** fragatina has quit IRC04:05
*** links has quit IRC04:07
*** fragatina has joined #openstack-ironic04:10
*** fragatina has quit IRC04:11
*** links has joined #openstack-ironic04:19
*** tiendc has quit IRC04:28
*** tiendc has joined #openstack-ironic04:28
*** yolanda has quit IRC04:32
*** cjloader has joined #openstack-ironic04:34
*** cjloader has quit IRC04:36
*** cjloader has joined #openstack-ironic04:36
*** fragatina has joined #openstack-ironic04:45
*** jaganathan has quit IRC04:48
*** cjloader has quit IRC04:53
*** cjloader_ has joined #openstack-ironic04:55
*** dsneddon has quit IRC04:56
*** cjloader_ has quit IRC04:56
*** stendulker has joined #openstack-ironic04:59
*** dpawar has joined #openstack-ironic05:05
*** links has quit IRC05:06
*** links has joined #openstack-ironic05:08
*** cjloader has joined #openstack-ironic05:11
*** harlowja has joined #openstack-ironic05:12
*** harlowja has quit IRC05:13
*** cjloader has quit IRC05:20
*** cjloader has joined #openstack-ironic05:21
*** crushil has quit IRC05:21
*** pcaruana has joined #openstack-ironic05:24
*** yee379 has quit IRC05:25
*** yee379 has joined #openstack-ironic05:26
*** pcaruana has quit IRC05:36
*** amotoki has quit IRC06:03
*** amotoki has joined #openstack-ironic06:04
*** liuzz has joined #openstack-ironic06:08
*** rbartal has joined #openstack-ironic06:08
*** hshiina has quit IRC06:25
*** jaganathan has joined #openstack-ironic06:25
*** cjloader has quit IRC06:34
*** saop has joined #openstack-ironic06:39
*** jtomasek has joined #openstack-ironic06:40
*** makowals has joined #openstack-ironic06:50
*** etingof has quit IRC06:52
*** ionutbalutoiu has quit IRC06:53
*** ionutbalutoiu has joined #openstack-ironic06:54
*** marios has joined #openstack-ironic07:00
*** tuanla____ has joined #openstack-ironic07:01
*** etingof has joined #openstack-ironic07:05
*** mjura has joined #openstack-ironic07:07
*** rbartal has quit IRC07:07
*** e0ne has joined #openstack-ironic07:13
*** jrist has quit IRC07:15
*** fragatina has quit IRC07:18
openstackgerritparesh sao proposed openstack/ironic master: Implementation for UEFI iSCSI boot for ILO  https://review.openstack.org/46828807:31
*** pcaruana has joined #openstack-ironic07:33
*** e0ne has quit IRC07:34
*** saop_ has joined #openstack-ironic07:41
*** saop has quit IRC07:44
*** jrist has joined #openstack-ironic07:53
*** pcaruana has quit IRC07:58
*** rcernin has quit IRC08:00
*** natorious has quit IRC08:04
*** AlexeyAbashkin has joined #openstack-ironic08:05
*** etingof has quit IRC08:07
*** tesseract has joined #openstack-ironic08:09
*** natorious has joined #openstack-ironic08:09
*** pcaruana has joined #openstack-ironic08:13
*** sapd_ has quit IRC08:16
*** sapd_ has joined #openstack-ironic08:16
openstackgerritHarald Jensås proposed openstack/networking-baremetal master: Add support to bind type vlan networks  https://review.openstack.org/53234908:21
openstackgerritHarald Jensås proposed openstack/networking-baremetal master: Add dsvm job  https://review.openstack.org/53040908:21
openstackgerritHarald Jensås proposed openstack/networking-baremetal master: Docs - Add multi-tenant devstack - n-g-s vlans  https://review.openstack.org/53445908:21
openstackgerritHarald Jensås proposed openstack/networking-baremetal master: Make the agent distributed using hashring and notifications  https://review.openstack.org/52470908:21
*** tiendc has quit IRC08:38
*** tuanla____ has quit IRC08:38
*** phuongnh has quit IRC08:38
*** tiendc has joined #openstack-ironic08:38
*** phuongnh has joined #openstack-ironic08:39
*** tuanla____ has joined #openstack-ironic08:39
openstackgerritvinay kumar muddu proposed openstack/ironic master: Update proliantutils version for Queens release  https://review.openstack.org/53589508:46
*** vmud213 has joined #openstack-ironic08:47
vmud213Morning Ironic!08:48
*** dsneddon has joined #openstack-ironic08:53
*** priteau has joined #openstack-ironic09:02
*** athomas has joined #openstack-ironic09:06
openstackgerritShivanand Tendulker proposed openstack/ironic master: Add rescue related methods to network interface  https://review.openstack.org/50934209:07
openstackgerritShivanand Tendulker proposed openstack/ironic master: Add rescuewait timeout periodic task  https://review.openstack.org/35315609:07
openstackgerritShivanand Tendulker proposed openstack/ironic master: Agent rescue implementation  https://review.openstack.org/40043709:07
openstackgerritShivanand Tendulker proposed openstack/ironic master: Add API methods for [un]rescue  https://review.openstack.org/35083109:07
pas-hamorning ironic :)09:18
*** rbartal has joined #openstack-ironic09:21
*** stendulker has quit IRC09:30
*** tesseract-RH has joined #openstack-ironic09:33
*** tesseract-RH has quit IRC09:34
*** tesseract-RH has joined #openstack-ironic09:35
*** tesseract has quit IRC09:37
*** derekh has joined #openstack-ironic09:39
*** etingof has joined #openstack-ironic09:48
*** e0ne has joined #openstack-ironic09:53
*** tuanla____ has quit IRC09:55
*** phuongnh has quit IRC09:55
*** phuongnh has joined #openstack-ironic09:56
*** tuanla____ has joined #openstack-ironic09:56
*** dtantsur|afk is now known as dtantsur09:58
*** stendulker has joined #openstack-ironic09:59
mgoddardmorning pas-ha & co10:02
stendulkermorning mgoddard, pas-ha10:05
vmud213dtantsur: Thanks for the review on https://review.openstack.org/#/c/535895/. After a rough test, I agree that it won't break the code. So giving workflow -110:10
patchbotpatch 535895 - ironic - Update proliantutils version for Queens release10:10
openstackgerritVasyl Saienko proposed openstack/ironic master: Testing multinode grenade fix  https://review.openstack.org/53674610:11
*** vsaienk0 has joined #openstack-ironic10:12
dtantsurvmud213: cool! thanks for investigating10:12
dtantsurstendulker: hey! I'm looking for a 2nd core to back my "classic drivers deprecations" FFE proposal. will you by chance have time to review it during the FF window?10:13
stendulkerdtantsur: yes, i can do that.10:14
dtantsurstendulker: thanks! I'll put your name there then10:14
stendulkerdtantsur: ok10:14
openstackgerritparesh sao proposed openstack/ironic master: Implementation for UEFI iSCSI boot for ILO  https://review.openstack.org/46828810:18
*** chas has joined #openstack-ironic10:18
*** marios has quit IRC10:30
*** sambetts_ is now known as sambetts10:32
sambettsMorning all10:32
*** marios has joined #openstack-ironic10:32
*** lucas-afk is now known as lucasagomes10:35
dtantsurhey sambetts10:41
*** e0ne has quit IRC10:51
sambettshey dtantsur10:57
*** makowals has quit IRC10:59
*** stendulker has quit IRC11:00
*** AlexeyAbashkin has quit IRC11:06
*** e0ne has joined #openstack-ironic11:06
*** tuanla____ has quit IRC11:12
dtantsursambetts: mind reviewing https://review.openstack.org/#/c/460564/ please? this has been around since April, I'd like to get it in before the FF11:13
patchbotpatch 460564 - ironic - Allow setting {provisioning,cleaning}_network in n...11:13
sambettsdtantsur: sure11:13
hjensassambetts: Hi, if you could also look at topic:bug/1658964 that would be great.11:15
*** saop_ has quit IRC11:16
*** saop_ has joined #openstack-ironic11:16
dtantsurEEEHHHMMMMM.. did the multitenant job just self-heal? Oo I see it passing on https://review.openstack.org/#/c/509342/11:18
patchbotpatch 509342 - ironic - Add rescue related methods to network interface11:18
*** vmud213 has quit IRC11:19
*** saop_ has quit IRC11:20
*** gmonteiro has joined #openstack-ironic11:20
gmonteiroGood Morning Ironic11:20
*** AlexeyAbashkin has joined #openstack-ironic11:23
*** phuongnh has quit IRC11:26
dtantsurmorning gmonteiro11:28
gmonteiroo/ dtantsur11:29
*** tiendc has quit IRC11:31
gmonteirodtantsur: you can review this https://review.openstack.org/#/c/524310/ if you have time :)11:34
patchbotpatch 524310 - ironic - Migrate oneview hardware type to use python-hpOneView11:34
openstackgerritchen jiao proposed openstack/ironic master: remeber spelling error  https://review.openstack.org/53678111:35
gmonteiroI already had a review of julia and shivanand, I need it before the feature freeze on Thursday11:36
*** e0ne has quit IRC11:41
*** e0ne has joined #openstack-ironic11:41
dtantsurgmonteiro: will look today. please consider requesting an FFE just in case, I can support it.11:41
*** e0ne has quit IRC11:42
gmonteirounderstood, thanks dtantsur11:42
dtantsurgmonteiro: commented, this is very close to landing11:49
*** dtantsur is now known as dtantsur|brb11:50
*** tesseract-RH has quit IRC11:52
*** liuzz has quit IRC12:03
*** jkilpatr has joined #openstack-ironic12:13
*** vsaienk0 has left #openstack-ironic12:22
*** vsaienk0 has joined #openstack-ironic12:22
openstackgerritHugo Nicodemos proposed openstack/ironic master: Migrate oneview hardware type to use python-hpOneView  https://review.openstack.org/52431012:22
vsaienk0dtantsur|brb: please review https://review.openstack.org/#/c/536746/ depends-on patches to devstack that will unblock multinode grenade, It failed on schedule to multiple nodes which is not related to nova-cpu stuck, we can fix it later separately12:22
patchbotpatch 536746 - ironic - Testing multinode grenade fix12:22
*** dtantsur|brb is now known as dtantsur12:23
dtantsurvsaienk0: I think there are two parallel efforts to unblock this job, could you please sync with TheJulia?12:24
*** jjohnson2 has joined #openstack-ironic12:25
vsaienk0dtantsur: I see she is working with jroll on microversion negotiation which is good, my patches are a bit different, they will work until negotiation is implemented12:28
dtantsurvsaienk0: well, the negotiation patch is already proposed, we just need nova cores on it12:29
dtantsuranyway, let's wait for either TheJulia or jroll for an up-to-date status12:29
openstackgerritHarald Jensås proposed openstack/networking-baremetal master: Devstack - Add ironic-neutron-agent  https://review.openstack.org/53011712:29
openstackgerritHarald Jensås proposed openstack/networking-baremetal master: Add support to bind type vlan networks  https://review.openstack.org/53234912:29
openstackgerritHarald Jensås proposed openstack/networking-baremetal master: Add dsvm job  https://review.openstack.org/53040912:29
openstackgerritHarald Jensås proposed openstack/networking-baremetal master: Docs - Add multi-tenant devstack - n-g-s vlans  https://review.openstack.org/53445912:29
openstackgerritHarald Jensås proposed openstack/networking-baremetal master: Make the agent distributed using hashring and notifications  https://review.openstack.org/52470912:29
openstackgerritHarald Jensås proposed openstack/networking-baremetal master: Use reporting_interval option from neutron  https://review.openstack.org/53679212:29
vsaienk0dtantsur: ok, np if you think there is no need for that change in devstack I will just abandon them12:29
dtantsurvsaienk0: I'm not sure, that's why I suggest to wait12:42
vsaienk0dtantsur: I will talk with TheJulia when she is around12:43
*** milan_ has joined #openstack-ironic12:46
*** tesseract-RH has joined #openstack-ironic12:47
dtantsurvsaienk0: btw, if you have a minute: https://review.openstack.org/#/c/460564/12:48
patchbotpatch 460564 - ironic - Allow setting {provisioning,cleaning}_network in n...12:48
*** yangyapeng has quit IRC12:50
*** yangyapeng has joined #openstack-ironic12:51
*** jlabarre has joined #openstack-ironic12:54
*** tesseract-RH has quit IRC12:54
openstackgerritMichael Turek proposed openstack/ironic-python-agent master: Use lshw in place of dmidecode for the default hardware manager  https://review.openstack.org/50179912:55
*** yangyapeng has quit IRC12:55
*** tesseract has joined #openstack-ironic12:55
openstackgerritDmitry Tantsur proposed openstack/ironic master: Allow data migrations to accept options  https://review.openstack.org/53577212:56
openstackgerritDmitry Tantsur proposed openstack/ironic master: Automatically migrate nodes to hardware types  https://review.openstack.org/53437312:56
dtantsurhad to rebase ^^^ :(12:56
*** zhurong has joined #openstack-ironic12:57
*** yolanda has joined #openstack-ironic13:05
dtantsuralso looking for a 2nd core review on https://review.openstack.org/535772 this is needed for hardware types migration13:06
patchbotpatch 535772 - ironic - Allow data migrations to accept options13:06
*** zhurong has quit IRC13:14
*** e0ne has joined #openstack-ironic13:14
*** vsaienk0 has quit IRC13:21
*** etingof has quit IRC13:21
*** cdearborn has joined #openstack-ironic13:21
*** vsaienk0 has joined #openstack-ironic13:22
*** dims has quit IRC13:22
*** alex_xu has quit IRC13:24
*** dims has joined #openstack-ironic13:25
*** MattMan has quit IRC13:25
*** MattMan has joined #openstack-ironic13:25
*** yangyapeng has joined #openstack-ironic13:26
*** alex_xu has joined #openstack-ironic13:27
*** jjohnson2 has quit IRC13:27
openstackgerritzhengyong proposed openstack/ironic-python-agent master: get IPv6 address of network interface in function get_interface_info  https://review.openstack.org/53613613:28
*** SerenaFeng has joined #openstack-ironic13:30
*** rloo has joined #openstack-ironic13:32
openstackgerritzhengyong proposed openstack/ironic-python-agent master: get IPv6 address of network interface in function get_interface_info  https://review.openstack.org/53613613:32
*** SerenaFeng has quit IRC13:32
*** jcoufal has joined #openstack-ironic13:32
*** SerenaFeng has joined #openstack-ironic13:34
openstackgerritHarald Jensås proposed openstack/ironic master: Devstack - use neutron segments (routed provider networks)  https://review.openstack.org/53127513:39
openstackgerritHarald Jensås proposed openstack/ironic master: Wait for ironic-neutron-agent to report state  https://review.openstack.org/53163713:39
*** cjloader has joined #openstack-ironic13:43
* TheJulia rubs eyes13:44
*** dprince has joined #openstack-ironic13:46
rlooGood morning everyone13:51
dtantsurmorning rloo, TheJulia13:52
* rloo passes a hot cup of coffee to TheJulia13:52
rloohi dtantsur13:52
rloodtantsur: was there magic last night, to fix the grenade job?13:52
dtantsurI don't know, it seems to pass13:52
rloodtantsur: are you ok if I +A this while we have this window of opportunity: https://review.openstack.org/#/c/353156/7113:53
patchbotpatch 353156 - ironic - Add rescuewait timeout periodic task13:53
rloodtantsur: i'm good with a followup patch13:53
rloodtantsur: normally i'd want them to fix but fixing that could take more than one revision13:53
dtantsurrloo: totally, let's fix it later13:53
rloodtantsur: good13:54
*** sasha2 has joined #openstack-ironic13:54
dtantsurI'll have to rebase https://review.openstack.org/#/c/460564/ sigh...13:54
patchbotpatch 460564 - ironic - Allow setting {provisioning,cleaning}_network in n...13:54
openstackgerritMark Goddard proposed openstack/ironic master: API: Node Traits API  https://review.openstack.org/53226913:54
openstackgerritMark Goddard proposed openstack/ironic master: Add node traits to API reference  https://review.openstack.org/53638413:54
jrollmorning13:56
dtantsurrloo: if you have time after traits and rescue: https://review.openstack.org/535772 (may involve some bikeshedding)13:56
patchbotpatch 535772 - ironic - Allow data migrations to accept options13:56
dtantsurmorning jroll13:56
jrolldtantsur: I didn't think to update the whiteboard, sorry, I have a status13:56
jrollthough now you say it's passing?13:56
rloodtantsur: yup, on my list for today. along with the client patches13:56
*** trown|outtypewww is now known as trown|ruck13:57
dtantsurjroll: seems so! maybe someone else noticed the segfaults?13:57
rloojroll: what is your status?13:57
rlooand good morning jroll :)13:57
jrolldtantsur: talked with dansmith yesterday, he is pretty -2 on changing upgrade order to work around this, him and matt were digging in a bit on the segv but didn't find anything last I checked13:57
*** Goneri has joined #openstack-ironic13:58
rloojroll: so what is wrong with changing the upgrade order? wouldn't we want it to be flexible anyway, and isn't that going to happen with the version negotiation stuff anyway?13:58
*** rbudden has joined #openstack-ironic13:58
*** etingof has joined #openstack-ironic13:59
jrollrloo: making it flexible is fine, making it backwards for this cycle only, and only in some configurations is not. AIUI.13:59
jrollrloo: as this situation is a MUST change the order, not MAY13:59
rloojroll: ha, so no hack/exceptions. i see.13:59
jrollbasically, yes13:59
rloojroll: i wondered about that. ok, so we need to try to get the version negotiation stuff landed, to avoid this problem in the future.14:00
*** cjloader has quit IRC14:00
TheJuliajroll: I commented on the review this morning, at least trying to provide reasoning why this is a good thing and helps us out14:01
jrollrloo: we do need to get that landed, but I don't think that's a good way to avoid the problem in the future (though helps work around it)14:01
jrollfwiw, my latest suspect was an `apt-get install` shortly before the segfaults which upgraded python-libvirt and some related things. so I don't have much of a clue on how to track down if there was an update there14:03
jrollI don't see anything immediately in nova (master or stable/pike) or g-r that look like a fix here14:03
rloojroll: my thinking is that once some libraries are upgraded, you don't know what is going to happen. so each service should really be upgraded in a container14:04
jrollrloo: I 100% believe that people (and the gate) should always isolate python applications with virtualenvs, containers, VMs, etc. but good luck convincing OS-level packagers and the folks in charge of the gate :(14:05
johnthetubaguyIs this multi-node grenade, as I am curious if only running the services that are going to be upgraded on the second node would help?14:05
*** SerenaFeng has quit IRC14:05
jrolllast time I tried to convince an OS packager, he told me to shove pip up my ass14:05
*** links has quit IRC14:05
rloojroll: wow14:05
johnthetubaguythose folks really like following their rules, and I can see why I guess14:06
jrolljohnthetubaguy: we upgrade most everything except nova atm14:06
rloojroll: hey, why don't we put nova on the 2nd node -- the one that doesn't get upgraded?14:07
johnthetubaguyrloo: yeah, that's what I was meaning14:07
jrollright, I think that's more complicated than it seems on the surface, but it's certainly possible14:07
johnthetubaguygrenade only really works if you upgrade the whole thing14:08
rloojohnthetubaguy: good idea! :)14:08
TheJuliajroll: I feel like because it is an external influence, realistically outside of any of our ability to control, that the fix should just get landed because it provides a much better user experience, otherwise it is a hard nova-compute service break for users14:08
johnthetubaguyyeah, its not really modular like that in devstack, but it seems the only way, old node vs new node14:08
rlooyeah, so that's what i don't understand. do we really want a strict ordering of projects when upgrading?14:08
johnthetubaguyso jroll, I am +1 having flexibility, so I could re-apply my +2 on those groups14:08
jrollTheJulia: I'm not the one to convince :)14:08
johnthetubaguys/groups/grounds/14:09
jrollTheJulia: but, it's not about negotiation being the wrong thing to do, it's about using it as a hack and enforcing a strict upgrade order that's different than usual14:09
TheJuliajroll: my perception of their perception is not a great one right now... which might also lead into why openstack struggles discussions, but this is neither the place, time, nor is there beer to discuss this14:09
*** e0ne has quit IRC14:10
rlooptg is coming up soon. question is whether we can wait til then to discuss. guess it depends on if grenade fails again due to this.14:10
johnthetubaguywe did agree a little while ago to fix the order services are upgrade, after some operator requests for an order, I think this is about keeping "the order" the same from release to release, unless you deprecated for a release, I guess?14:10
jrollTheJulia: for sure.14:10
*** e0ne has joined #openstack-ironic14:10
johnthetubaguyIf my memory is right, I think the operators didn't care what the order was, as long as it worked, and stayed the same release to release14:11
johnthetubaguywell, I mean, consensus landed somewhere near that14:11
johnthetubaguysucks though14:12
*** melwitt has quit IRC14:12
jrollso going back, can we talk about this14:13
jroll13:52:44        dtantsur | I don't know, it seems to pass14:13
jrollnobody knows why?14:13
jrollis it still passing?14:13
* TheJulia deletes what she was saying14:14
TheJuliajroll: ci-watch says?14:14
* TheJulia is still on cup #114:14
* jroll is still on scrollback14:14
* jroll looks14:14
*** melwitt has joined #openstack-ironic14:14
jrollci-watch says mostly passing, yes14:14
jrollwtf14:14
*** lucasagomes is now known as lucas-hungry14:15
rloojroll: don't know if coincidence, but this looks like the first patch that it passed in: https://review.openstack.org/#/c/535928/214:16
patchbotpatch 535928 - ironic - DNM testing whether lib/neutron switch breaks this...14:16
TheJuliajohnthetubaguy: Eh, there was also negative feedback on of rocking the boat by trying to break plugins out of the built-ins... and that seemed to reach an impass. Besides, until the work is actually done, and teams are invested enough, or are forced to take it in-tree, we will just end up in the same catch-22 next cycle without the ability to be a little more friendly instead of break hard in some14:16
TheJuliasituations.  :(  Really, in a sense, this all goes back to our hard python api pin14:16
TheJuliajroll: I will toss things at walls in support of the wtf moment, after I've had my second cup of coffee14:16
jrollrloo: innnnteresting. things happening during the neutron upgrade were suspect.14:17
*** etingof has quit IRC14:17
jrollalas, the dependencies did not land, so that isn't it14:17
*** crushil has joined #openstack-ironic14:18
rloojroll: right, which is why i think it might be a coincidence. but maybe there is some other neutron-related/similar patch that fixed it.14:19
jrollcould be, yeah14:19
* jroll is still poking around14:20
openstackgerritparesh sao proposed openstack/ironic master: Implementation for UEFI iSCSI boot for ILO  https://review.openstack.org/46828814:20
jrolltiming is a bit off, but suspect none the less https://github.com/openstack-dev/devstack/commit/614cab33c40159f0bc10d92c9f8dc3f9783708d914:28
rloojroll: you think the mirror was 'bad'?14:29
jrollrloo: more along the lines of some newer package in there that broke things14:29
jrollbut just throwing that out there, more of a note while I search14:31
rloojroll: that mirror has been in use for awhile, since oct or before. if that is true, that a newer package broke us, seems like it might be just a matter of time before that package appears again?14:33
jrollrloo: correct14:33
jrolllike I said, just making a note of it, my confidence isn't high that it's related14:33
rloojroll: thx for looking. i will focus on getting as much code landed as possible while this window of opportunity stays open14:34
jroll++14:35
*** crushil has quit IRC14:38
*** crushil_ has quit IRC14:40
*** baha has joined #openstack-ironic14:44
*** fragatina has joined #openstack-ironic14:47
TheJuliasince it is passing as-is with some frequency, I guess we can go ahead and land rpc items with confidence now14:48
dtantsuraaaand https://review.openstack.org/532268 failed it :(14:49
patchbotpatch 532268 - ironic - Add RPC object for traits14:49
TheJuliaGAH14:49
dtantsurI did not check if it's the same failure though14:49
TheJuliaI'll check in a moment14:49
jrollvsaienk0 mentioned a different failure case, right14:51
openstackgerritMerged openstack/ironic-lib stable/pike: Use dd conv=sparse when writing images to nodes  https://review.openstack.org/53530714:52
jrollso I don't have a large sample size, but...14:52
jrollin pass AND fail cases, we start with libmysqlclient20 5.7.20-0ubuntu0.16.04.1 and libmysqlclient-dev 5.7.20-0ubuntu0.16.04.114:53
jrollin only the fail case, we upgrade to libmysqlclient20 5.7.21-0ubuntu0.16.04.1 and libmysqlclient-dev 5.7.21-0ubuntu0.16.04.114:53
* jroll will check more cases14:53
vsaienk0jroll I was seen many times when default retries in nova are exhausted since we didn't finish upgrading ironic in time for example http://logs.openstack.org/42/536242/1/check/ironic-grenade-dsvm-multinode-multitenant/e6ad982/logs/screen-n-cpu.txt.gz14:54
*** cjloader has joined #openstack-ironic14:54
jrollvsaienk0: ah, got it14:54
jrollthanks14:54
*** crushil_ has joined #openstack-ironic14:55
*** etingof has joined #openstack-ironic14:55
*** yolanda has quit IRC14:56
jrollurgh, found a fail case where we don't upgrade those :/14:56
*** jjohnson2 has joined #openstack-ironic14:57
jrollit could be anything, this feels like a wild goose chase14:59
TheJuliayup15:01
jrollgotta run for an hour+, bbl15:03
*** arnewiebalck has joined #openstack-ironic15:03
*** dpawar has quit IRC15:05
TheJuliadtantsur: completely unrelated to the other failures... 3 nova failures, looks like it goes back to the baremetal nodes being locked, so it could just be timing...  It does have a lot of errors w/r/t vif detach attempts when there is an outstanding lock. :\15:15
*** vabada2 has joined #openstack-ironic15:19
*** vabada has quit IRC15:20
*** lucas-hungry is now known as lucasagomes15:20
dtantsurmoar failures!15:20
*** links has joined #openstack-ironic15:21
rpiosoGood morning :)15:24
*** vabada2 has quit IRC15:32
*** vabada has joined #openstack-ironic15:32
dtantsurmorning rpioso15:33
* dtantsur is not entirely sure about the "good" bit15:33
rpiosodtantsur: I hope your day improves.15:34
dtantsurthanks15:40
TheJuliadtantsur: fwiw, I fired off a recheck of my fix for the vif detachment15:43
dtantsurwhich one, sorry?15:43
rpiosodtantsur: yw15:44
TheJuliathe one that moves the exclusive locking for detach into the actual logic of detachment dependent upon node state, since we only want to block the record being removed in an active (or now rescue) state15:44
TheJuliaso since it is in deleting, the vif record can get ripped out15:45
TheJuliawhich will make nova much happier15:45
TheJuliaand returns to the original pattern it experienced since .extra updates wouldn't be blocked as far as we remember/are aware15:46
rlooTheJulia: thx for looking into the grenade failure for 532268. I did a recheck. the inspector job timed out too :-(15:48
rloogood morning rpioso15:49
dtantsurTheJulia: good point15:49
rpiosorloo: Good morning15:50
TheJuliarloo: ugh15:50
NobodyCamGood Morning Ironic'ers15:56
ricardoasmorning!15:57
NobodyCamMorning ricardoas :)15:58
*** r-daneel has joined #openstack-ironic15:59
openstackgerritMerged openstack/ironic master: Add rescue related methods to network interface  https://review.openstack.org/50934216:00
openstackgerritDmitry Tantsur proposed openstack/ironic master: [WIP] Switch the CI to hardware types  https://review.openstack.org/53687516:01
dtantsurmorning NobodyCam16:01
NobodyCamMorning dtantsur :)16:02
NobodyCamhappy not Monday :)16:02
*** ni291187 has joined #openstack-ironic16:02
*** openstackgerrit has quit IRC16:03
*** etingof has quit IRC16:04
*** rbartal has quit IRC16:05
*** ni291187 has quit IRC16:06
ricardoasmorning NobodyCam :D16:09
*** e0ne has quit IRC16:11
*** trown|ruck is now known as trown|brb16:11
ricardoashey dtantsur, I´ve just catch up with gmonteiro about opening a FFE for python lib change in oneview interfaces... thanks for the suggestion! I´m not sure I´ll be here to keep up with it the next cycle if we postpone it again... :(16:12
gmonteiroo/ NobodyCam16:12
*** openstackgerrit has joined #openstack-ironic16:12
openstackgerritDmitry Tantsur proposed openstack/ironic master: Allow setting {provisioning,cleaning,rescuing}_network in driver_info  https://review.openstack.org/46056416:12
dtantsurvsaienk0, sambetts, had to rebase because of rescue_network ^^^16:12
dtantsurricardoas: I can imagine, it starts taking time16:13
*** mjura has quit IRC16:15
*** SerenaFeng has joined #openstack-ironic16:16
*** trown|brb is now known as trown|ruck16:17
*** pc_m has quit IRC16:20
*** etingof has joined #openstack-ironic16:21
ricardoasTheJulia: would you have any time to review the oneview stuff if we open a ffe? I ´m asking because you have already seen most part of it...16:21
*** pc_m has joined #openstack-ironic16:22
*** tesseract has quit IRC16:22
openstackgerritMerged openstack/ironic master: Add rescuewait timeout periodic task  https://review.openstack.org/35315616:25
TheJuliaricardoas: I kind of do16:29
*** penick has joined #openstack-ironic16:29
*** jaganathan has quit IRC16:32
*** vsaienk0 has quit IRC16:34
dtantsurpas-ha: hey, mind checking if the direction is right here? https://review.openstack.org/#/c/536875/16:39
patchbotpatch 536875 - ironic - [WIP] Switch the CI to hardware types16:39
*** jaganathan has joined #openstack-ironic16:39
dtantsurI think you introduced that devstack variable16:40
ricardoasTheJulia: thank you!16:41
*** pcaruana has quit IRC16:41
pas-hadtantsur: looking16:46
*** chas has quit IRC16:49
*** chas has joined #openstack-ironic16:49
pas-hadtantsur: +1, one nit in comment16:51
dtantsuryeah, good point. will update other jobs now16:51
*** jaganathan has quit IRC16:52
openstackgerritYusef Shaban proposed openstack/sushy master: Restores sushy session functionality.  https://review.openstack.org/53591016:53
*** chas has quit IRC16:54
rpiosoetingof: Are you still working on https://review.openstack.org/#/c/526773/ ?16:56
patchbotpatch 526773 - ironic - boot mode support at ManagementInterface16:56
etingofrpioso, yes, I do16:57
NobodyCamhey hey Morning gmonteiro :)16:57
etingofrpioso, the code is done, I'm fighting the mysterious CI job failure16:57
*** jkilpatr_ has joined #openstack-ironic16:58
*** jkilpatr has quit IRC17:00
rpiosoetingof: Cool! I am reviewing it from the perspective of the drac driver. Also, I am working on adding UEFI support to that driver. Your change may align well with that.17:01
etingofrpioso, \o/17:02
etingofrpioso, I hope to defeat the CI thing next week17:02
etingofrpioso, (got distracted by a local conference)17:02
*** AlexeyAbashkin has quit IRC17:02
openstackgerritDmitry Tantsur proposed openstack/ironic master: Switch the CI to hardware types  https://review.openstack.org/53687517:04
rpiosoetingof: My hope is to complete my review of that patch by tomorrow. No promises, though. I have been distracted by other upstream work, and there is more coming my way.17:04
etingofrpioso, thank you!17:05
rpiosoetingof: Please wait until I submit my comments :)17:06
etingofrpioso, no worries, I can't work on that this week anyway17:06
rpiosoetingof: Thank you for the update. Please stay tuned.17:07
*** jaganathan has joined #openstack-ironic17:10
*** jkilpatr_ has quit IRC17:12
*** yolanda has joined #openstack-ironic17:17
*** gmonteiro has quit IRC17:20
*** cjloader has quit IRC17:20
openstackgerritHarald Jensås proposed openstack/ironic master: Devstack - use neutron segments (routed provider networks)  https://review.openstack.org/53127517:21
openstackgerritHarald Jensås proposed openstack/ironic master: Wait for ironic-neutron-agent to report state  https://review.openstack.org/53163717:21
*** cjloader has joined #openstack-ironic17:21
*** baha has quit IRC17:22
* jroll returns17:27
*** anupn has quit IRC17:29
openstackgerritHarald Jensås proposed openstack/ironic master: Add routed networks support to flat interfaces  https://review.openstack.org/53604017:30
*** amarao has quit IRC17:30
*** penick has quit IRC17:32
openstackgerritTapio Tallgren proposed openstack/bifrost master: Rewrite iptables rules with Ansible module  https://review.openstack.org/53691117:34
*** penick has joined #openstack-ironic17:36
*** akhilaki has joined #openstack-ironic17:39
*** akhilaki_ has joined #openstack-ironic17:39
*** makowals has joined #openstack-ironic17:39
*** yolanda has quit IRC17:47
*** trown|ruck is now known as trown|lunch17:48
*** etingof has quit IRC17:48
*** vsaienk0 has joined #openstack-ironic17:49
*** chas has joined #openstack-ironic17:53
*** vabada has quit IRC17:53
*** etingof has joined #openstack-ironic17:53
*** vabada has joined #openstack-ironic17:53
*** chas has quit IRC17:57
*** vsaienk0 has quit IRC17:58
*** derekh has quit IRC18:01
*** milan_ has quit IRC18:03
*** SerenaFeng has quit IRC18:04
*** ijw has joined #openstack-ironic18:04
*** dpawar has joined #openstack-ironic18:14
*** jkilpatr has joined #openstack-ironic18:20
*** baha has joined #openstack-ironic18:25
*** links has quit IRC18:26
openstackgerritDmitry Tantsur proposed openstack/ironic master: Clean up CI playbooks  https://review.openstack.org/53589618:29
*** yolanda has joined #openstack-ironic18:29
*** AlexeyAbashkin has joined #openstack-ironic18:31
*** vsaienk0 has joined #openstack-ironic18:33
*** lucasagomes is now known as lucas-afk18:35
*** AlexeyAbashkin has quit IRC18:35
*** links has joined #openstack-ironic18:40
openstackgerritDmitry Tantsur proposed openstack/ironic master: Deprecate classic drivers  https://review.openstack.org/53692818:42
dtantsurBOOOOOM18:42
* dtantsur drops this mic and walks out18:42
*** vsaienk0 has quit IRC18:43
jroll\o/18:43
*** vsaienk0 has joined #openstack-ironic18:44
rlooencore, encore dtantsur!18:44
dtantsur:)18:45
mgoddardClassic drivers are dead. Long live classic drivers!18:45
dtantsurrloo: thanks for review on the options thingy. I'll give it a thought tomorrow - no energy left for today18:45
rloodtantsur: no worries. there is room for enhancements, but if need be, we can push out something 'slim' now.18:46
dtantsurnow, time to get some wine and do a premature celebration :D18:47
rloodtantsur: enjoy! :)18:48
*** fragatina has quit IRC18:48
dtantsurthnx18:48
*** makowals has quit IRC18:48
*** dtantsur is now known as dtantsur|afk18:48
*** fragatina has joined #openstack-ironic18:49
*** dpawar has quit IRC18:51
Tenguhello there!18:53
Tenguanyone still up? would like to discuss ipmi in a libvirt env :).18:53
Tengu(and yep, it's kind of related to ironic - I'd like to manage VM for a tripleo lab and still use ironic)18:54
TenguI know redhat has something on their formation laptop for that, but either I'm unable to provide the correct words to google, or it's maybe not really open18:55
mgoddardTengu: tried virtualbmc? https://github.com/openstack/virtualbmc18:57
Tengumgoddard: aaahhh. didn't see that. I think it will be the right one. Reading, thanks!18:58
TheJuliaanyone seen anything like http://logs.openstack.org/68/532268/12/check/ironic-tempest-dsvm-ipa-wholedisk-agent_ipmitool-tinyipa-multinode/e026e4a/logs/screen-n-cond-cell1.txt.gz#_Jan_23_17_58_57_614336 ?18:59
Tengumgoddard: is there a package? probably in delorean?18:59
*** jkilpatr has quit IRC18:59
*** cjloader has quit IRC19:00
mgoddardTengu: at a guess, python-virtualbmc19:00
*** cjloader has joined #openstack-ironic19:00
mgoddardTengu: otherwise, use pip/PyPI?19:01
mgoddardTengu: http://markelov.blogspot.co.uk/2017/05/how-to-configure-openstack-tripleo.html19:01
mgoddardTengu: python2-virtualbmc19:01
Tengumgoddard: will check both in order to get the best of it :).19:02
mgoddardTheJulia: eww, that doesn't look good19:02
TheJuliano, it looks rather bad19:02
Tengumgoddard: aahh, perfect. Will bookmark it and apply it tomorrow :).19:02
NobodyCamalso could easily roll package your own with FPM: https://github.com/jordansissel/fpm19:03
NobodyCamwow that came out all wrong:19:04
NobodyCamyou could also easily roll your own package with FPM :p19:04
mgoddardTheJulia: https://bugs.launchpad.net/nova/+bug/1733933 looks related19:05
openstackLaunchpad bug 1736946 in OpenStack Compute (nova) ocata "duplicate for #1733933 Conductor: fails to clean up networking resources due to _destroy_build_request CantStartEngineError" [High,In progress] - Assigned to Matt Riedemann (mriedem)19:05
mgoddardTheJulia: and the bug that that is a dup of: https://bugs.launchpad.net/nova/+bug/173694619:05
openstackLaunchpad bug 1736946 in OpenStack Compute (nova) ocata "Conductor: fails to clean up networking resources due to _destroy_build_request CantStartEngineError" [High,In progress] - Assigned to Matt Riedemann (mriedem)19:05
TheJuliafun19:10
*** links has quit IRC19:19
*** vsaienk0 has quit IRC19:25
*** vsaienk0 has joined #openstack-ironic19:26
*** penick has quit IRC19:29
*** harlowja has joined #openstack-ironic19:34
TheJuliaugh, more failed jobs19:35
*** marios has quit IRC19:37
*** ricardoas is now known as ricardoas-away19:37
*** fragatina has quit IRC19:38
*** trown|lunch is now known as trown19:40
*** trown is now known as trown|ruck19:40
*** vsaienk0 has quit IRC19:49
*** chas has joined #openstack-ironic19:50
rlooTheJulia: multi-grenade, or other jobs?19:50
TheJuliarloo: on one patch, two other jobs, but looks like network timeouts19:50
openstackgerritMerged openstack/ironic master: remeber spelling error  https://review.openstack.org/53678119:51
rlooTheJulia: network timeouts are better than weird code things... sounds like the usual gate issues :-( not surprising, given the deadlines coming up19:51
*** akhilaki_ has quit IRC19:52
*** akhilaki has quit IRC19:52
*** chas has quit IRC19:54
hjensassambetts: still around? Do you have a bug number for the one you mentioned on the flat driver patch?19:58
*** dsneddon has quit IRC20:00
*** dsneddon has joined #openstack-ironic20:01
sambettshjensas: I'm not sure if there was one created or not, I can't seem to find it, however the bug reveals itself if you run openstack and don't run a neutron-OVS-agent service on the host that is running nova-compute with the ironic virt driver, when we try to bind the port it uses the nova compute host id, and neutron rejects the request with a no host matches that host id error20:03
sambettshjensas: and even with things set up correctly today, if you inspect a neutron flat network ironic port it isn't ever successfuly bound and therefore in state "ACTIVE"20:05
hjensassambetts: ah, yes got it. I'll put something in the fixes part of releasenotes.20:05
sambettshjensas: thats the reason we created the networking-baremetal mech driver in the first place :)20:05
sambettscool thanks :D20:06
* sambetts --> away 20:06
sambettso/ cya'll tomorrow20:06
hjensassambetts: no, thank you! :)20:06
*** sambetts is now known as sambetts|afk20:06
*** penick has joined #openstack-ironic20:08
*** e0ne has joined #openstack-ironic20:13
TheJuliarloo: easy stable core review https://review.openstack.org/#/c/53547420:13
patchbotpatch 535474 - sushy (stable/queens) - Update UPPER_CONSTRAINTS_FILE for stable/queens20:13
rlooTheJulia: ok, easy is nice for a change :)20:13
TheJuliarloo: another https://review.openstack.org/#/c/535453/120:15
*** e0ne_ has joined #openstack-ironic20:15
patchbotpatch 535453 - ironic-lib (stable/queens) - Update UPPER_CONSTRAINTS_FILE for stable/queens20:15
*** vsaienk0 has joined #openstack-ironic20:16
openstackgerritMark Goddard proposed openstack/ironic-tempest-plugin master: Add node trait tests  https://review.openstack.org/53590820:18
*** e0ne has quit IRC20:19
*** e0ne has joined #openstack-ironic20:20
*** e0ne_ has quit IRC20:21
*** e0ne has quit IRC20:21
rlooTheJulia: how many of these patches do we *need* to get merged by Thursday, vs how many do we want? Trying to figure out priority/which to review20:23
rlooTheJulia: https://review.openstack.org/#/c/531029/20:23
patchbotpatch 531029 - python-ironicclient - Facilitate latest Rest API use20:23
openstackgerritMerged openstack/sushy master: Update reno for stable/queens  https://review.openstack.org/53547520:25
TheJuliarloo: I'm basically ready to WF+1 the entire traits stack if I see a multinode job succeed somewhere at or past rpc changes :)20:26
TheJuliaI think... last I looked at rescue, it was not staged such to prevent a merge conflict with traits20:27
rlooTheJulia: heh. that makes sense though.20:27
rlooTheJulia: oh, there is a conflict. i think.both have new Node versions if I recall.20:27
TheJuliabut, I've been so heads down with 5000000 things and house purchase that.... ugh20:27
rlooTheJulia: i will check, can't keep track of what has landed in each of them.20:27
TheJuliarloo: indeed, and they were both claiming 1.37 as their microversion20:27
TheJuliagranted, rescue can be changed fast20:28
TheJuliaif we land traits20:28
rlooTheJulia: oh yeah. that too! but there will be a conflict after one of them lands.20:28
TheJuliahell, we should just land it and sort it later....20:28
TheJuliaif we're going to, we need to start letting the patches land very very very soon like yesterday20:28
rlooTheJulia: which patches? there are too many things to try to land this week20:30
*** hw_wutianwei has quit IRC20:31
*** hw_wutianwei has joined #openstack-ironic20:32
TheJuliatraits rpc I guess20:32
jrollrloo: TheJulia: I can help with whichever doesn't land20:32
TheJuliaYou know... it is under the hood, the important thing is the API. we've got +2's all the way through the traits api at this point20:32
TheJuliawe can fix under the hood next week20:32
rlooTheJulia: well, we can +A and see what happens then.20:33
rlooi don't know if many patches are passing CI now though. i'm guessing issues in infra-land.20:33
TheJulialooks like they are taking one of the clouds out now20:34
rloojroll: you can help with testing the traits stuff. although i need you to update the client patch for traits.20:35
*** penick has quit IRC20:36
*** vsaienk0 has quit IRC20:36
jrollrloo: yep, I saw that and will be doing it. what testing does it need, just general poking the api?20:36
*** penick has joined #openstack-ironic20:36
rloojroll: make sure rolling upgrades doesn't break (although I"m fairly sure it doesn't) and yes, API. cuz changing API behaviour after the fact is a mess wrt being backwards compatible etc.20:37
TheJuliaI think mgoddard already poked at it a couple days ago20:37
TheJuliawell, poked at the api20:37
jrollI poked at it a ton to write the client. not the latest version of the series, but it hasn't changed significantly.20:37
jrollI can do some more and lay a vote on it today20:37
* jroll has been busy with other things today so will be working late20:38
*** akhilaki_ has joined #openstack-ironic20:38
*** akhilaki__ has joined #openstack-ironic20:38
rlooi think we're good then. mark has some simple tempest tests, he just updated that and i'll review today unless i forget to do it.20:38
TheJuliagiven the node object upgrade/downgrade I'm not _as_ worried about about rolling upgrades20:39
TheJuliarloo: lets wf+1, and if it rolling upgrades testings has issues, we can revert or fix in place20:39
*** jkilpatr has joined #openstack-ironic20:39
TheJuliaIt will likely be sometime tomorrow before the api could merge anyway20:39
rlooTheJulia: ok20:39
rlooTheJulia: you want to pull the trigger?20:40
TheJuliasure20:40
TheJuliachecking one thing and will context swifth to that20:40
jrollwoohoo20:40
jrollwill update the client shortly20:40
rlooTheJulia: I checked traits vs rescue, wrt conflicts in versions. Only the REST API version conflicts. Rescue's node & RPC versions have already merged, and traits has rebased on top of those.20:44
TheJulia\o/20:44
TheJuliaWe might need to prod https://review.openstack.org/#/c/532268/12 again20:46
patchbotpatch 532268 - ironic - Add RPC object for traits20:46
TheJuliasince it failed, I rechecked it a little while ago20:46
TheJuliabut it has wf+1 for now, so if the universe aligns and is happy, it will merge20:46
mgoddardwoop, thanks TheJulia & rloo :D20:49
jroll\o/20:50
*** cdearborn_ has joined #openstack-ironic20:50
rloojlvillal: if you are around and have your handy script to recheck ^^ https://review.openstack.org/#/c/532268/20:51
patchbotpatch 532268 - ironic - Add RPC object for traits20:51
jlvillalrloo, Sure!20:51
rloothx jlvillal!20:52
jlvillalrloo, running now in a tmux session.20:52
rloojlvillal: :)20:53
TheJuliaI'm stepping away for a little while and then need to run some city near palm springs to go initiate a wire transfer20:53
TheJuliaI'll check back in periodically20:54
rlooTheJulia: thx20:54
*** dsneddon has quit IRC20:58
*** dsneddon has joined #openstack-ironic20:58
*** vsaienk0 has joined #openstack-ironic20:59
*** cdearborn has quit IRC21:01
*** Goneri has quit IRC21:06
*** penick has quit IRC21:09
*** penick has joined #openstack-ironic21:10
*** dsneddon has quit IRC21:12
*** dsneddon has joined #openstack-ironic21:13
*** vsaienk0 has quit IRC21:13
*** jcoufal has quit IRC21:14
*** saop has joined #openstack-ironic21:14
saopTheJulia, Hello21:14
TheJuliaGreetings saop21:14
saopTheJulia, I want to raise https://review.openstack.org/#/c/468288/ this patch for FFE. Could you be core-reviewer for this?21:15
patchbotpatch 468288 - ironic - Implementation for UEFI iSCSI boot for ILO21:15
*** vsaienk0 has joined #openstack-ironic21:15
TheJuliasaop: happy to21:16
saopTheJulia, Thanks21:16
TheJuliabtw, I comments to it about an hour ago21:16
saopTheJulia, I will soon update your comments :)21:16
TheJuliaThanks21:16
*** penick has quit IRC21:16
*** saop has quit IRC21:17
TheJulianote to self: the cats really don't like it when fighter jets buzz the RV park21:19
*** penick has joined #openstack-ironic21:24
*** penick has quit IRC21:27
*** penick has joined #openstack-ironic21:29
jrollrloo: hey, quick question before I upload the other changes https://review.openstack.org/#/c/532622/5/ironicclient/osc/v1/baremetal_node.py@160221:33
patchbotpatch 532622 - python-ironicclient - Traits support21:33
rloowhich one am i looking at?21:34
rlooL1602?21:34
jrollyes21:35
*** chas has joined #openstack-ironic21:35
rloojroll: damn. it is a 'list'.21:35
jrollheh, both options are a reasonable way to render a list21:36
rloojroll: i wonder if we made things complicated. what does listing tags return? now i need to think about it.21:36
jrollwe allow up to 50, so I think the comma-separated thing could look weird at that point21:37
rloojroll: strictly speaking, i think 'list' means list each one separately.21:37
rloojroll: i need to look at our existing commands and see what we do21:37
jrollrloo: we don't have any other commands that return a list of strings21:37
jrollor even s/commands/api endpoints/21:37
*** dprince has quit IRC21:38
*** MaxPC has quit IRC21:38
jrolltags would, but it isn't done21:38
rloojroll: but we have commands that return lists. i think they all return 'lists', right?21:38
jrollyes, list of objects that have one or more keys21:38
rloojroll: we have commands that return list of drivers. that is a list, right?21:38
jrolle.g. list vifs is [{'id': 'foo'}, ...], so we label the column id21:38
jrolldriver list has two columns21:39
rloojroll: i think the idea with vifs is that at some point, there could be more than just the 'id' as pieces of info about a vif.21:39
*** chas has quit IRC21:39
jrolldriver list: https://gist.github.com/jimrollenhagen/dadf410a44625c1feeb6063a5800265c21:39
rloojroll: with traits, what do we return in the API response? I've already forgotten.21:39
jrollrloo: {'traits': ['foo', 'bar']}21:40
jrollrloo: everything else is a list of dicts, in the API. {'drivers': [{'name': 'foo', 'hosts': []}, ...]}21:41
jrolletc.21:41
rloojroll: ok, we need to look at OSC and see what it returns21:41
jrollrloo: what do you mean? what OSC returns for what?21:41
rloojroll: for lists of things21:41
*** penick has quit IRC21:41
rloojroll: this is the client response that we're discussing right?21:41
jrollrloo: I wrote it in my comment21:41
rloojroll: right, we need to pick one of those two choices, right?21:42
jrollyes.21:42
jrollrloo: I guess you want me to find another service that returns a list of strings from its API, and see what it does in osc?21:42
rloojroll: yup21:43
TheJuliaon a plus side, things are looking a little better for more recent changes. https://review.openstack.org/#/c/536928/ seems to be the last job that is full of red21:43
patchbotpatch 536928 - ironic - Deprecate classic drivers21:43
rloojroll: although i was going to look, so better if you volunteer :)21:43
jrollrloo: okay, I'm gonna go read API docs for a while then21:43
jrolls/read/skim/21:43
jrollor rather, figure out how to make nova tags work21:43
*** penick has joined #openstack-ironic21:43
rloojroll: thx! just add a comment saying you chose option X because it is consistent with whatever.21:43
rlooTheJulia: good news! we can hope :)21:44
openstackgerritMark Goddard proposed openstack/ironic master: Fix traits in Node._convert_to_version when pinned  https://review.openstack.org/53697821:44
openstackgerritMark Goddard proposed openstack/ironic master: Add traits field to node notifications  https://review.openstack.org/53697921:44
openstackgerritMark Goddard proposed openstack/ironic master: Add documentation for node traits  https://review.openstack.org/53698021:44
mgoddardrloo, TheJulia, jroll: Mixed news21:46
mgoddard^^^ new patches for docs & notifications21:46
mgoddardtesting with pinned services has revealed some issues21:46
TheJuliasigh21:47
mgoddardone of which is easily fixed in the first of the three patches21:47
*** fragatina has joined #openstack-ironic21:47
rloomgoddard: that isn't good.21:47
rloomgoddard: just when i thought i was done with reviewing traits patches :)21:47
*** jjohnson2 has quit IRC21:48
mgoddardrloo: never!21:48
* TheJulia goes and removes magical flags21:49
TheJuliaokay, wf flags removed from rpc changes21:49
jroll:(21:51
mgoddardTheJulia: thanks :(21:52
rloomgoddard: is https://review.openstack.org/#/c/536978/ based on top of your other patches?21:52
patchbotpatch 536978 - ironic - Fix traits in Node._convert_to_version when pinned21:52
jrollrloo: sooo, nova instance tags aren't in osc :/21:52
jrollrloo: I don't see any other tags either, except images, which are only listed as part of the image object21:53
jrollthink we're on our own here21:53
mgoddardrloo: yes. Is that going to allow us to avoid a rev of the others?21:53
rloomgoddard: well, we need that change in https://review.openstack.org/#/c/53226821:53
patchbotpatch 532268 - ironic - Add RPC object for traits21:53
*** baha has quit IRC21:53
*** trown|ruck is now known as trown|outtypewww21:54
rloomgoddard: sorry, we shouldn't land 532268 w/o that. given that it hasn't merged yet. if our testing was really robust, it should fail w/o that fix, but i suspect it doesn't.21:55
rloojroll: give me 10? min to think about it21:55
jrollrloo: sure, no problem21:55
jrollrloo: I'm going to upload the rest in case you agree with me :)21:55
rloojroll: sure. it is cheap to do revisions :D21:56
mgoddardrloo: ok, I'll apply it to 53226821:57
TheJuliak21:57
rloothx mgoddard. if you can do it today, we can +2 (maybe +A) and see how it goes.21:58
openstackgerritJim Rollenhagen proposed openstack/python-ironicclient master: Traits support  https://review.openstack.org/53262221:58
*** vsaienk0 has quit IRC22:00
*** Goneri has joined #openstack-ironic22:03
*** priteau has quit IRC22:03
*** crushil_ has quit IRC22:06
TheJuliamgoddard: you indicated that there was a plurality to the issues... beyond the first.22:07
TheJuliaIs it just the one issue?22:08
rloojroll: went with your option #122:09
mgoddardTheJulia: yes, there's a second that I'm currently looking into22:09
jrollrloo: ++, thanks22:09
rloojroll: thank YOU! :)22:10
TheJuliamgoddard: ack, thanks!22:11
*** rcernin has joined #openstack-ironic22:15
mgoddardrloo: my second issue is here: https://review.openstack.org/#/c/532268/12/ironic/objects/node.py@40322:16
patchbotpatch 532268 - ironic - Add RPC object for traits22:16
*** penick has quit IRC22:16
rloomgoddard: so traits was in updates?22:17
mgoddardrloo: when the services are pinned, we can be passed traits to node.save()22:17
rloomgoddard: oh, yes. if we are saving in the new conductor22:17
mgoddardrloo: yes, I think they are added in _convert_to_version22:17
rloomgoddard: thinking.22:18
rloomgoddard: do we check in the API? I think so22:18
rloomgoddard: so we can delete that if statement22:18
rloomgoddard: or change it to check the value of traits in updates.22:19
rloomgoddard: i think there is a similar check in the db layer22:20
*** milan has joined #openstack-ironic22:21
*** penick has joined #openstack-ironic22:21
rloomgoddard: i can't keep track of the changes/ versions. I suppose we can do a similar check to L344 in https://review.openstack.org/#/c/532268/12/ironic/objects/node.py22:24
patchbotpatch 532268 - ironic - Add RPC object for traits22:24
*** akhilaki__ has quit IRC22:24
*** akhilaki_ has quit IRC22:24
rloomgoddard: if you want to raise an exception. i am thinking that if we check at API level, just remove it.22:26
mgoddardrloo: the test was with both services new, and pinned to pike22:28
mgoddardwe do check in the API22:28
mgoddardI don't see a check in the DB layer22:28
mgoddardrelaxing the check to 'is not None' is looking promising22:28
rloomgoddard: yeah, sorry, i thought it was in the db layer but it wasn't. i was thinking of the create() case at the object layer22:29
*** penick has quit IRC22:29
mgoddardrloo: I think I'm going to go with an 'is not None' check. Should have a patch up shortly22:32
mgoddardrloo: then bedtime :)22:32
rloomgoddard: thx!22:33
rloomgoddard: what if it is []22:33
rloomgoddard: you allow empty trait lists in the create()22:34
rloomgoddard: can probably use same code in a helper method22:35
mgoddardrloo: convert_to_version sets it to None. An empty list in the updates dict could be interpreted as the new value22:35
mgoddardI guess None could also22:35
rloomgoddard: we check at the API layer so it shouldn't happen anyway22:35
mgoddardrloo: right22:36
*** fragatina has quit IRC22:50
*** fragatina has joined #openstack-ironic22:50
rpiosojroll: May a dynamic driver have a management interface that is None?22:51
rpiosojroll: My read of the code is that is can't, but I would like to confirm that.22:51
jrollrpioso: I don't believe so, no, but not 100% sure22:52
jrollactually, not sure any interface may be None for a driver22:52
rloorpioso: i think management is a core interface. sec.22:52
jrollrather, they would be no-*  or noop or whatever22:52
rloorpioso: oh, management is not a core, it is a standard interface.22:53
rloorpioso: what jroll sez.22:53
rpiosorloo: Right22:53
jrollI guess fake would be the closest: https://github.com/openstack/ironic/blob/master/setup.cfg#L12022:53
rpiosojroll: https://github.com/openstack/ironic/blob/master/ironic/common/driver_factory.py#L29522:54
rpiosojroll: And https://github.com/openstack/ironic/blob/master/ironic/common/driver_factory.py#L21422:55
jrolloh my, this is lots to page into my brain22:55
jrollrpioso: it feels like there's a higher level question you're trying to answer :)22:56
rpiosojroll: I'm reviewing https://review.openstack.org/#/c/52677322:57
patchbotpatch 526773 - ironic - boot mode support at ManagementInterface22:57
jrollah22:57
rpiosojroll: There's a review comment exchange about whether or not a dynamic driver can have no management interface.22:58
jrollso you're wondering if we need to check task.driver.management22:58
rpiosojroll: Yes, for dynamic drivers.22:58
*** milan has quit IRC22:58
jrollrpioso: yeah, got it. dtantsur|afk says there "with hardware types interfaces cannot be None." I'm pretty sure he's right, and he would know better than anyone23:00
jrollbut there's a chance he's wrong, I guess23:00
jroller, no, he's right, you're right looking at https://github.com/openstack/ironic/blob/master/ironic/common/driver_factory.py#L21423:00
rpiosojroll: So the TODO that etingof added in response to dtantsur|afk's review comment needs to be tweaked.23:01
jrollhttps://youtu.be/pDxoj-tDDIU?t=12723:02
jrollrpioso: yeah, I'd agree23:02
rpiosojroll: Cool. I figured he and you would know :)23:02
rpiosojroll: lol23:03
rpiosojroll: C'mon, admit it. It never left :)23:03
jrollrpioso: oh no, it did. I totally purged my brain of the driver internals.23:04
jroll(with good reason)23:04
rpiosojroll: Thank you for confirming. And my apologies for bringing back those memories.23:04
jrollheh, not a problem23:04
*** cjloader has quit IRC23:05
*** ijw has quit IRC23:06
*** ijw has joined #openstack-ironic23:06
*** masber has quit IRC23:14
openstackgerritMark Goddard proposed openstack/ironic master: Add RPC object for traits  https://review.openstack.org/53226823:17
openstackgerritMark Goddard proposed openstack/ironic master: Add RPC API and conductor manager for traits  https://review.openstack.org/53529623:17
openstackgerritMark Goddard proposed openstack/ironic master: API: Node Traits API  https://review.openstack.org/53226923:17
openstackgerritMark Goddard proposed openstack/ironic master: Add node traits to API reference  https://review.openstack.org/53638423:17
openstackgerritMark Goddard proposed openstack/ironic master: Add traits field to node notifications  https://review.openstack.org/53697923:17
openstackgerritMark Goddard proposed openstack/ironic master: Add documentation for node traits  https://review.openstack.org/53698023:17
mgoddardrloo, TheJulia: let's try that again23:18
mgoddardpinning is looking much happier now23:19
mgoddardrloo, TheJulia: I'm heading to bed now. Thanks for your patience!23:20
mgoddardGood luck little patches...23:20
rloothx mgoddard!23:20
openstackgerritHarald Jensås proposed openstack/ironic master: Flat networks use node.uuid when binding ports.  https://review.openstack.org/53604023:22
*** chas has joined #openstack-ironic23:23
*** chas has quit IRC23:27
rpiosomgoddard: Good nite!23:33
*** rpioso is now known as rpioso|afk23:35
*** cdearborn_ has quit IRC23:42
*** oanson has quit IRC23:42
*** oanson has joined #openstack-ironic23:43
*** UForgotten has quit IRC23:55
*** UForgotten has joined #openstack-ironic23:55

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!