| *** rbudden has quit IRC | 00:13 | |
| *** milan has quit IRC | 00:21 | |
| openstackgerrit | Ian Pilcher proposed openstack/ironic-lib master: Use dd conv=sparse when writing images to nodes https://review.openstack.org/534442 | 00:22 |
|---|---|---|
| *** tzumainn has quit IRC | 00:27 | |
| *** etingof has quit IRC | 00:33 | |
| *** yangyapeng has quit IRC | 00:38 | |
| *** yangyapeng has joined #openstack-ironic | 00:38 | |
| *** cjloader has joined #openstack-ironic | 00:42 | |
| *** yangyapeng has quit IRC | 00:43 | |
| tonyb | So I'm a little confused about the right way to setup introspection (this is in the context of tripleo but I'm not sure that matters) | 00:44 |
| tonyb | if I run 'openstack baremetal node inspect <node_UUID> | 00:45 |
| tonyb | ' the node boots but it seems like nothign has configured PXE to give it a kernel+ramdisk | 00:45 |
| tonyb | If I manually give it one and boot it it completes the introspection | 00:46 |
| tonyb | So my question is who is responsible for setting up introspection? tripleo? me? or ironic? | 00:47 |
| tonyb | sorry to ask such a fundamental question | 00:47 |
| *** etingof has joined #openstack-ironic | 00:50 | |
| tonyb | Oh I think I see, what has happend It looks like despite having disabled ipxe in tripleo it's still configured ironic-inspector to use it | 00:53 |
| * tonyb goes to debug that. | 00:53 | |
| *** phuongnh has joined #openstack-ironic | 01:01 | |
| openstackgerrit | Harald Jensås proposed openstack/networking-baremetal master: Add dsvm job https://review.openstack.org/530409 | 01:03 |
| openstackgerrit | Harald Jensås proposed openstack/networking-baremetal master: Docs - Add multi-tenant devstack - n-g-s vlans https://review.openstack.org/534459 | 01:03 |
| *** jaypipes has quit IRC | 01:06 | |
| *** phuongnh has quit IRC | 01:06 | |
| *** rloo has quit IRC | 01:07 | |
| *** cjloader has quit IRC | 01:09 | |
| *** yangyapeng has joined #openstack-ironic | 01:11 | |
| *** tiendc has joined #openstack-ironic | 01:13 | |
| *** etingof has quit IRC | 01:21 | |
| *** etingof has joined #openstack-ironic | 01:22 | |
| *** phuongnh has joined #openstack-ironic | 01:33 | |
| *** rbudden has joined #openstack-ironic | 01:47 | |
| *** tuanla____ has joined #openstack-ironic | 01:48 | |
| *** dsneddon has quit IRC | 02:01 | |
| *** bfournie has joined #openstack-ironic | 02:02 | |
| openstackgerrit | Harald Jensås proposed openstack/ironic master: Wait for ironic-neutron-agent to report state https://review.openstack.org/531637 | 02:16 |
| *** zhangfei has joined #openstack-ironic | 02:19 | |
| *** cjloader has joined #openstack-ironic | 02:26 | |
| *** cjloader has quit IRC | 02:27 | |
| *** cjloader_ has joined #openstack-ironic | 02:27 | |
| *** jlabarre has quit IRC | 02:43 | |
| *** crushil_ has joined #openstack-ironic | 02:57 | |
| *** crushil has joined #openstack-ironic | 02:57 | |
| *** crushil_ has quit IRC | 03:03 | |
| *** ccollett has joined #openstack-ironic | 03:04 | |
| *** dpawar has joined #openstack-ironic | 03:05 | |
| *** dpawar has quit IRC | 03:06 | |
| *** dpawar has joined #openstack-ironic | 03:06 | |
| *** charcol has quit IRC | 03:06 | |
| openstackgerrit | Tuan Luong-Anh proposed openstack/ironic master: [WIP] Implement iRMC BIOS configuration https://review.openstack.org/534595 | 03:08 |
| *** gcb has quit IRC | 03:14 | |
| *** gcb has joined #openstack-ironic | 03:18 | |
| *** cjloader_ has quit IRC | 03:23 | |
| openstackgerrit | Merged openstack/ironic-python-agent master: Updated from global requirements https://review.openstack.org/529949 | 03:30 |
| *** fragatina has quit IRC | 03:44 | |
| *** rbudden has quit IRC | 03:46 | |
| *** rbudden has joined #openstack-ironic | 03:48 | |
| *** jaianshu has joined #openstack-ironic | 03:57 | |
| *** rbudden has quit IRC | 04:14 | |
| openstackgerrit | Merged openstack/ironic-inspector master: Updated from global requirements https://review.openstack.org/533876 | 04:21 |
| *** sasha2 has quit IRC | 04:33 | |
| openstackgerrit | Merged openstack/ironic master: Add additional context to contribution guide https://review.openstack.org/529681 | 04:37 |
| *** sasha2 has joined #openstack-ironic | 04:39 | |
| *** zer0c00l has quit IRC | 04:46 | |
| *** links has joined #openstack-ironic | 04:49 | |
| *** cjloader has joined #openstack-ironic | 04:54 | |
| *** cjloader has quit IRC | 04:57 | |
| *** mvpnitesh has joined #openstack-ironic | 05:03 | |
| *** zer0c00l has joined #openstack-ironic | 05:06 | |
| *** zer0c00l has quit IRC | 05:12 | |
| *** zer0c00l has joined #openstack-ironic | 05:13 | |
| *** dpawar_ has joined #openstack-ironic | 05:13 | |
| openstackgerrit | Madhuri Kumari proposed openstack/ironic-specs master: Add service management API for ironic https://review.openstack.org/471217 | 05:15 |
| *** dpawar has quit IRC | 05:16 | |
| *** hshiina has joined #openstack-ironic | 05:17 | |
| *** dpawar_ has quit IRC | 05:18 | |
| *** sasha2 has quit IRC | 05:20 | |
| *** zer0c00l has quit IRC | 05:24 | |
| *** crushil_ has joined #openstack-ironic | 05:29 | |
| *** zer0c00l has joined #openstack-ironic | 05:38 | |
| *** zer0c00l has quit IRC | 06:06 | |
| *** absubram has joined #openstack-ironic | 06:06 | |
| *** dpawar has joined #openstack-ironic | 06:06 | |
| *** ccollett has quit IRC | 06:10 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/ironic-inspector master: Imported Translations from Zanata https://review.openstack.org/533100 | 06:10 |
| *** charcol has joined #openstack-ironic | 06:12 | |
| *** pmannidi has quit IRC | 06:16 | |
| *** pmannidi has joined #openstack-ironic | 06:33 | |
| *** pmannidi has quit IRC | 06:38 | |
| *** sapd__ has quit IRC | 06:38 | |
| ameeda | Morning :) | 06:38 |
| *** marios has joined #openstack-ironic | 06:39 | |
| *** sapd__ has joined #openstack-ironic | 06:39 | |
| ameeda | when I try to deploy Overstack on baremetal from VM, I got this "Filter RetryFilter returned 0 hosts" from nova-scheduler.log , any suggestions ? | 06:40 |
| *** hieulq has quit IRC | 06:40 | |
| *** mcarden has quit IRC | 06:48 | |
| ameeda | also this one "Filter ComputeCapabilitiesFilter returned 0 hosts" | 06:49 |
| openstackgerrit | Zhijiang Hu proposed openstack/virtualbmc master: Support power reset command https://review.openstack.org/534646 | 06:49 |
| *** pmannidi has joined #openstack-ironic | 06:50 | |
| *** zhangfei has quit IRC | 06:51 | |
| *** hieulq has joined #openstack-ironic | 06:52 | |
| openstackgerrit | Zhijiang Hu proposed openstack/virtualbmc master: Support power reset command https://review.openstack.org/534646 | 06:52 |
| *** mvpnitesh has quit IRC | 06:56 | |
| openstackgerrit | Zhijiang Hu proposed openstack/virtualbmc master: Support power reset command https://review.openstack.org/534646 | 06:57 |
| *** makowals has joined #openstack-ironic | 07:01 | |
| *** zer0c00l has joined #openstack-ironic | 07:05 | |
| openstackgerrit | Zhijiang Hu proposed openstack/virtualbmc master: Support power reset command https://review.openstack.org/534646 | 07:06 |
| *** zhangfei has joined #openstack-ironic | 07:07 | |
| *** absubram has quit IRC | 07:10 | |
| *** zer0c00l has quit IRC | 07:14 | |
| *** zer0c00l has joined #openstack-ironic | 07:16 | |
| *** threestrands_ has quit IRC | 07:20 | |
| *** jkilpatr has quit IRC | 07:28 | |
| *** crushil has quit IRC | 07:29 | |
| *** zhangfei has quit IRC | 07:32 | |
| pas-ha | morning ironic :) | 07:37 |
| *** rbartal has joined #openstack-ironic | 07:39 | |
| *** jkilpatr has joined #openstack-ironic | 07:39 | |
| *** charcol has quit IRC | 07:41 | |
| *** zhangfei has joined #openstack-ironic | 07:45 | |
| *** crushil has joined #openstack-ironic | 07:47 | |
| *** zer0c00l has quit IRC | 07:48 | |
| *** pcaruana has joined #openstack-ironic | 07:48 | |
| *** zhangfei has quit IRC | 07:50 | |
| *** honza has quit IRC | 07:53 | |
| *** pcaruana has quit IRC | 07:55 | |
| *** pcaruana has joined #openstack-ironic | 07:55 | |
| *** AlexeyAbashkin has joined #openstack-ironic | 07:57 | |
| *** zhangfei has joined #openstack-ironic | 08:03 | |
| *** athomas has joined #openstack-ironic | 08:05 | |
| *** hoonetorg has quit IRC | 08:10 | |
| *** phuongnh has quit IRC | 08:11 | |
| *** phuongnh has joined #openstack-ironic | 08:12 | |
| *** mgoddard_ has joined #openstack-ironic | 08:17 | |
| *** hoonetorg has joined #openstack-ironic | 08:26 | |
| *** crushil has quit IRC | 08:27 | |
| *** tesseract has joined #openstack-ironic | 08:29 | |
| *** milan has joined #openstack-ironic | 08:34 | |
| openstackgerrit | Rushil Chugh proposed openstack/ironic master: Add XClarity Driver https://review.openstack.org/519427 | 08:35 |
| *** zer0c00l has joined #openstack-ironic | 08:36 | |
| *** mgoddard_ has quit IRC | 08:37 | |
| *** crushil has joined #openstack-ironic | 08:37 | |
| *** crushil__ has joined #openstack-ironic | 08:39 | |
| *** crushil_ has quit IRC | 08:41 | |
| *** pmannidi has quit IRC | 08:41 | |
| *** crushil has quit IRC | 08:43 | |
| *** rcernin has quit IRC | 08:45 | |
| *** crushil__ has quit IRC | 08:45 | |
| *** xnox has quit IRC | 08:45 | |
| openstackgerrit | Zhijiang Hu proposed openstack/virtualbmc master: Support power reset command https://review.openstack.org/534646 | 08:46 |
| *** zer0c00l has quit IRC | 08:47 | |
| *** zer0c00l has joined #openstack-ironic | 08:54 | |
| *** liuzz has joined #openstack-ironic | 08:56 | |
| *** xnox has joined #openstack-ironic | 08:57 | |
| *** xnox has quit IRC | 08:57 | |
| *** xnox has joined #openstack-ironic | 08:57 | |
| sapd__ | hi guys, Does ironic support software RAID? | 08:59 |
| openstackgerrit | yuan liang proposed openstack/ironic-python-agent master: Execute error in _detect_cna_card https://review.openstack.org/534690 | 09:00 |
| *** tuanla____ has quit IRC | 09:01 | |
| *** tuanla____ has joined #openstack-ironic | 09:01 | |
| openstackgerrit | yuan liang proposed openstack/ironic-python-agent master: Execute error in _detect_cna_card https://review.openstack.org/534690 | 09:04 |
| *** xnox has quit IRC | 09:05 | |
| openstackgerrit | liumengke proposed openstack/ironic master: fix a typo in ilo.rst: s/fimware/firmware/ https://review.openstack.org/534695 | 09:06 |
| *** xnox has joined #openstack-ironic | 09:08 | |
| *** xnox has quit IRC | 09:08 | |
| *** xnox has joined #openstack-ironic | 09:08 | |
| *** liuzz_ has joined #openstack-ironic | 09:09 | |
| pas-ha | sapd__: the agent-based drivers do not AFAIU (there are plans to support it). You can however write custom Ansible playbooks for ansible deploy interface that can something in this regard. | 09:09 |
| pas-ha | (a really old) blog post on that has some examples https://www.mirantis.com/blog/automate-bare-metal-server-provisioning-using-ironic-bifrost-and-the-ansible-deploy-driver/ | 09:10 |
| *** zer0c00l has quit IRC | 09:10 | |
| *** liuzz has quit IRC | 09:11 | |
| pas-ha | use it just for inspiration, the actual way of writing playbooks and using the driver has changed since | 09:11 |
| *** xnox has quit IRC | 09:13 | |
| sapd__ | pas-ha: thankyou. I will check it. | 09:14 |
| *** xnox has joined #openstack-ironic | 09:16 | |
| *** xnox has quit IRC | 09:16 | |
| *** xnox has joined #openstack-ironic | 09:16 | |
| *** hshiina has quit IRC | 09:18 | |
| *** hw_wutianwei has quit IRC | 09:23 | |
| *** hw_wutianwei has joined #openstack-ironic | 09:23 | |
| *** ejsf has joined #openstack-ironic | 09:35 | |
| *** stendulker has joined #openstack-ironic | 09:39 | |
| *** derekh has joined #openstack-ironic | 09:39 | |
| *** rcernin has joined #openstack-ironic | 09:40 | |
| *** zer0c00l has joined #openstack-ironic | 09:41 | |
| *** liuzz_ has quit IRC | 09:47 | |
| *** e0ne has joined #openstack-ironic | 09:47 | |
| *** vabada has joined #openstack-ironic | 09:52 | |
| *** milan has quit IRC | 09:56 | |
| *** zer0c00l has quit IRC | 09:58 | |
| *** zer0c00l has joined #openstack-ironic | 10:02 | |
| openstackgerrit | wangdequn proposed openstack/ironic master: correct the referenced url int the comment https://review.openstack.org/534710 | 10:07 |
| *** amarao has joined #openstack-ironic | 10:12 | |
| *** amarao has quit IRC | 10:16 | |
| *** amarao has joined #openstack-ironic | 10:16 | |
| *** zer0c00l has quit IRC | 10:18 | |
| openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic master: Add docs for ansible deploy interface https://review.openstack.org/525501 | 10:19 |
| *** zer0c00l has joined #openstack-ironic | 10:21 | |
| *** sambetts|afk is now known as sambetts | 10:28 | |
| openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic master: [docs] mention new nova scheduler option https://review.openstack.org/534401 | 10:35 |
| *** zer0c00l has quit IRC | 10:43 | |
| *** etingof has quit IRC | 10:45 | |
| *** xnox has quit IRC | 10:47 | |
| *** priteau has joined #openstack-ironic | 10:49 | |
| *** xnox has joined #openstack-ironic | 10:51 | |
| *** xnox has quit IRC | 10:51 | |
| *** xnox has joined #openstack-ironic | 10:51 | |
| *** dtantsur|afk is now known as dtantsur | 10:57 | |
| dtantsur | morning ironic | 10:57 |
| *** dims has quit IRC | 10:57 | |
| dtantsur | tonyb: hey, our time difference is unfortunate :( Were you able to solve your problem? | 10:57 |
| *** dims has joined #openstack-ironic | 10:58 | |
| *** dpawar_ has joined #openstack-ironic | 10:59 | |
| *** zer0c00l has joined #openstack-ironic | 11:01 | |
| *** dpawar_ has quit IRC | 11:01 | |
| *** dpawar_ has joined #openstack-ironic | 11:02 | |
| *** dpawar has quit IRC | 11:03 | |
| pas-ha | dtantsur: morning | 11:10 |
| pas-ha | dtantsur: seems we have some problems with docs job | 11:10 |
| dtantsur | oh? | 11:11 |
| *** zer0c00l has quit IRC | 11:11 | |
| pas-ha | it fails complaining about files that are not changed in a patch - https://review.openstack.org/#/c/534401/ and https://review.openstack.org/#/c/525501/ as examples | 11:11 |
| patchbot | patch 534401 - ironic - [docs] mention new nova scheduler option | 11:11 |
| patchbot | patch 525501 - ironic - Add docs for ansible deploy interface | 11:11 |
| pas-ha | although when running locally I can't repro those failures | 11:12 |
| pas-ha | the ansible playbook task that fails has some comments from mordred re disabling pbr autodoc.. | 11:12 |
| *** zer0c00l has joined #openstack-ironic | 11:13 | |
| dtantsur | pas-ha: I guess we have no options other than try to fix it.. | 11:13 |
| pas-ha | yep, will try | 11:13 |
| *** tuanla____ has quit IRC | 11:26 | |
| *** dpawar_ has quit IRC | 11:28 | |
| *** zhangfei has quit IRC | 11:30 | |
| *** phuongnh has quit IRC | 11:34 | |
| *** AlexeyAbashkin has quit IRC | 11:36 | |
| dtantsur | thnx | 11:38 |
| *** etingof has joined #openstack-ironic | 11:40 | |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic master: [WIP] Automatically migrate nodes to hardware types https://review.openstack.org/534373 | 11:44 |
| openstackgerrit | Dao Cong Tien proposed openstack/ironic master: devstack: add support for rescue mode https://review.openstack.org/524118 | 11:44 |
| openstackgerrit | Dao Cong Tien proposed openstack/ironic master: CI job for rescue mode https://review.openstack.org/528704 | 11:44 |
| openstackgerrit | Dao Cong Tien proposed openstack/ironic master: DNM: test rescue mode https://review.openstack.org/533187 | 11:45 |
| *** absubram has joined #openstack-ironic | 11:46 | |
| *** dpawar has joined #openstack-ironic | 12:01 | |
| *** AlexeyAbashkin has joined #openstack-ironic | 12:02 | |
| *** AlexeyAbashkin has quit IRC | 12:06 | |
| *** jkilpatr has quit IRC | 12:07 | |
| pas-ha | dtantsur: sooo, it most likely that the yesterday's bump for sphinx in u-c was the reason.. https://github.com/openstack/requirements/commit/3326377e752231c702b73b0bb71ceda0d06fb834#diff-0bdd949ed8a7fdd4f95240bd951779c8L368 | 12:09 |
| pas-ha | was able to repro locally, and now will test with 1.6.5 | 12:09 |
| dtantsur | aha | 12:09 |
| *** jkilpatr has joined #openstack-ironic | 12:09 | |
| dtantsur | I wonder if the failure is real (then we should fix it) or fake (then they should fix it) | 12:10 |
| pas-ha | also consult our docs team - may be we do do something wrong with refs in includes.. | 12:10 |
| pas-ha | exactly | 12:10 |
| *** AlexeyAbashkin has joined #openstack-ironic | 12:12 | |
| *** rcernin has quit IRC | 12:14 | |
| openstackgerrit | Mark Goddard proposed openstack/networking-generic-switch master: Add a netmiko device driver for Juniper switches https://review.openstack.org/530537 | 12:20 |
| dtantsur | sambetts: hey, around? if you have some time, I'd appreciate a fresh view on https://review.openstack.org/#/c/471942/ please. We need to finish it by tomorrow. | 12:21 |
| patchbot | patch 471942 - sushy - Implement Redfish Sessions | 12:21 |
| dtantsur | TheJulia: ^^^ | 12:21 |
| *** jaypipes has joined #openstack-ironic | 12:24 | |
| *** tiendc has quit IRC | 12:28 | |
| *** yangyapeng has quit IRC | 12:38 | |
| *** dprince has joined #openstack-ironic | 12:40 | |
| jroll | good morning | 12:42 |
| pas-ha | jroll: morning :) | 12:44 |
| *** serlex has joined #openstack-ironic | 12:44 | |
| *** jlabarre has joined #openstack-ironic | 12:45 | |
| *** racedo has joined #openstack-ironic | 12:51 | |
| *** racedo has quit IRC | 12:53 | |
| TheJulia | dtantsur: Once I have coffee :) | 13:00 |
| *** racedo has joined #openstack-ironic | 13:00 | |
| openstackgerrit | Dao Cong Tien proposed openstack/ironic-tempest-plugin master: Rescue mode tempest tests https://review.openstack.org/528699 | 13:04 |
| *** pmannidi has joined #openstack-ironic | 13:04 | |
| openstackgerrit | Dao Cong Tien proposed openstack/ironic master: DNM: standalone test rescue mode https://review.openstack.org/534751 | 13:10 |
| *** yangyapeng has joined #openstack-ironic | 13:11 | |
| *** absubram has quit IRC | 13:12 | |
| *** trown|outtypewww is now known as trown | 13:12 | |
| dtantsur | morning jroll, TheJulia | 13:15 |
| *** milan_ has joined #openstack-ironic | 13:15 | |
| dtantsur | oh, we should start planning the PTG.. I will start an etherpad soon(ish) if nobody beats me to it | 13:16 |
| *** MattMan_1 has quit IRC | 13:21 | |
| *** MattMan_1 has joined #openstack-ironic | 13:21 | |
| rpioso | Good morning | 13:24 |
| *** vabada has quit IRC | 13:25 | |
| *** vabada has joined #openstack-ironic | 13:26 | |
| *** vabada has quit IRC | 13:26 | |
| openstackgerrit | Hugo Nicodemos proposed openstack/ironic master: Migrate oneview hardware type to use python-hpOneView https://review.openstack.org/524310 | 13:26 |
| *** vabada has joined #openstack-ironic | 13:27 | |
| *** vabada has quit IRC | 13:27 | |
| *** vabada has joined #openstack-ironic | 13:28 | |
| dtantsur | TheJulia: https://etherpad.openstack.org/p/ironic-rocky-ptg (please review before I send it out) | 13:30 |
| dtantsur | morning rpioso | 13:30 |
| rpioso | dtantsur: :) | 13:30 |
| *** jaianshu has quit IRC | 13:35 | |
| openstackgerrit | Ilya Etingof proposed openstack/sushy-tools master: Abstract away the virtualization management interface https://review.openstack.org/523321 | 13:40 |
| TheJulia | dtantsur: I'm +2 on the sushy session patch | 13:44 |
| dtantsur | cool | 13:44 |
| dtantsur | TheJulia: wanna merge it or have someone else look at it? | 13:45 |
| TheJulia | at this point, we likely just merge it | 13:45 |
| dtantsur | yep | 13:45 |
| TheJulia | in route | 13:46 |
| *** pmannidi has quit IRC | 13:46 | |
| *** dpawar has quit IRC | 13:47 | |
| TheJulia | dtantsur: Added one item, lgtm | 13:49 |
| *** rbudden has joined #openstack-ironic | 13:51 | |
| *** Goneri has joined #openstack-ironic | 13:56 | |
| *** sasha2 has joined #openstack-ironic | 13:57 | |
| *** tzumainn has joined #openstack-ironic | 14:00 | |
| *** rloo has joined #openstack-ironic | 14:04 | |
| *** rbartal has quit IRC | 14:04 | |
| rloo | good morning ironickers all over the world | 14:16 |
| rloo | johnthetubaguy, mgoddard: what's the status wrt the traits work? the feeling was that if we didn't land the ironic parts this week, there was no way the nova part would land by FF next week | 14:17 |
| hamzy | dtantsur, heya... I'm seeing "[ 363.570582] ironic-python-agent[2729]: "message": "The following failures happened during running pre-processing hooks:\nLook up error: Could not find a node for attributes {'bmc_address': u'9.114.118.155', 'mac': [u'00:90:fa:74:05:52'," | 14:17 |
| hamzy | it looks like it was fixed a couple of times? | 14:17 |
| hamzy | I have the console output... | 14:18 |
| dtantsur | morning rloo | 14:19 |
| openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic master: Fix docs for Sphinx 1.6.6 https://review.openstack.org/534768 | 14:19 |
| mgoddard | hi rloo: I don't know what johnthetubaguy's status is beyond the patches that he's pushed already | 14:19 |
| pas-ha | dtantsur: ^^ | 14:19 |
| mgoddard | rloo: I have some nova patches up for review, which still need some more testing. Just about to do that | 14:19 |
| dtantsur | hamzy: you need to make sure the nodes you're introspecting have correct IPMI addresses and correct MAC addresses (if at all) | 14:19 |
| dtantsur | thanks pas-ha | 14:19 |
| hamzy | dtantsur, I've successfully deployed TripleO in the past, but this morning it stopped working | 14:20 |
| rloo | mgoddard: thx. i've been waiting for updates to review. will see what johnthetubaguy sez. wrt the nova parts, you think they'll be easy to review? (I haven't looked yet) | 14:20 |
| dtantsur | hamzy: I don't think we have changed anything recently.. | 14:21 |
| hamzy | it looks like the node gets an IP address from systemd but then ironic brings the interface down to do its discovery | 14:21 |
| dtantsur | is it completely the same environment with completely the same instackenv.json? | 14:21 |
| dtantsur | which release is it about? | 14:21 |
| hamzy | I should be running master | 14:22 |
| hamzy | openstack-ironic-common-9.2.1-0.20171227184854.bf8cb05.el7.centos.noarch | 14:22 |
| *** crushil__ has joined #openstack-ironic | 14:23 | |
| hamzy | dtantsur, https://hamzy.fedorapeople.org/TripleO-multi-arch/deploy-c365f02u23.fail | 14:23 |
| dtantsur | jlvillal: if by any chance you're around today, could you please check https://review.openstack.org/#/c/534736/ ? I'm afraid it will break ironic | 14:24 |
| patchbot | patch 534736 - oslo.serialization - Revert "When serializing an exception return its '... | 14:24 |
| *** crushil_ has joined #openstack-ironic | 14:24 | |
| dtantsur | hamzy: does IPMI address and at least one MAC match what is in ironic? | 14:24 |
| *** mcarden has joined #openstack-ironic | 14:25 | |
| dtantsur | sambetts: if you remember the context on https://review.openstack.org/#/c/534736/ please check as well | 14:25 |
| patchbot | patch 534736 - oslo.serialization - Revert "When serializing an exception return its '... | 14:25 |
| hamzy | dtantsur, does the MAC show in "openstack baremetal node show"? | 14:27 |
| *** crushil__ has quit IRC | 14:28 | |
| *** mjturek has joined #openstack-ironic | 14:29 | |
| dtantsur | hamzy: openstack baremetal port list --node <uuid> | 14:29 |
| openstackgerrit | Merged openstack/sushy master: Implement Redfish Sessions https://review.openstack.org/471942 | 14:30 |
| hamzy | dtantsur, https://paste.fedoraproject.org/paste/dwMbtIAJE4lFCBT3mBqCzg | 14:31 |
| TheJulia | well this seems wrong http://logs.openstack.org/25/529325/6/check/ironic-lib-tempest-partition-agent_ipmitool/6d871b3/logs/screen-ir-cond.txt.gz?level=ERROR :( | 14:32 |
| mgoddard | rloo: there isn't too much to the nova parts really. They're a little tied up with some other placement work, but hopefully that shouldn't block us as it's also targeted for Queens. | 14:32 |
| mgoddard | rloo: if you feel like reviewing nova code: https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/ironic-driver-traits | 14:33 |
| rloo | mgoddard: don't feel like reviewing *any* code :D | 14:34 |
| dtantsur | hamzy: provision_state = "wait callback" is what preventing introspection | 14:35 |
| mgoddard | rloo: guess you're in the wrong job then :p | 14:35 |
| dtantsur | it looks like your node is half-way through deployment | 14:35 |
| dtantsur | MAC and IPMI address look fine | 14:35 |
| hamzy | it seems to get all the way to the end of IPA detecting everything | 14:36 |
| *** mjturek has quit IRC | 14:36 | |
| rloo | mgoddard: yup, as core anyway ;) | 14:36 |
| mgoddard | rloo: actually I think johnthetubaguy is in Cambridge for at least some of today | 14:36 |
| *** mjturek has joined #openstack-ironic | 14:36 | |
| dtantsur | hamzy: it should not even start inspection in this state.. I dunno why. but that's the cause of your problem, I think | 14:37 |
| rloo | mgoddard: so i'm avail to review the traits code up til tomorrow; after that maybe others will review, dunno. but at this point, i'm not sure it'll make it into queens. | 14:38 |
| hamzy | dtantsur, I only see "2018-01-17 14:08:22.443 3647 ERROR ironic.conductor.utils [req-b5fa24f9-2b66-4cc7-b9ae-19058d6a91fd - - - - -] Timeout reached while waiting for callback for node 82e17bd4-cfbd-4574-b49d-ea03b89861b3" in /var/log/ironic/ironic-conductor.log | 14:38 |
| dtantsur | hamzy: the whole situation is a bit messy. you (or something) managed to start introspection on a node that was deploying OR was about to be deployed at | 14:39 |
| dtantsur | which broke both the deployment and the introspection | 14:40 |
| dtantsur | because the deployment never received a callback, while introspection found the node in a wrong state | 14:40 |
| dtantsur | this is how I see the situation from the information I've got at least | 14:40 |
| openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic master: [docs] mention new nova scheduler option https://review.openstack.org/534401 | 14:40 |
| dtantsur | now the question is how you ended up there :) did you deploy and introspect in parallel? | 14:40 |
| TheJulia | heh, busybox fuser != psmisc fuser :( | 14:41 |
| openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic master: Add docs for ansible deploy interface https://review.openstack.org/525501 | 14:41 |
| hamzy | dtantsur, :( well I run the command "openstack overcloud deploy --templates /home/stack/templates -e /home/stack/templates/environments/network-environment.yaml -e /home/stack/templates/environments/network-isolation-custom.yaml -e /home/stack/templates/environments/override-overcloud-image.yaml --control-scale 1 --compute-scale 1 --control-flavor control --compute-flavor compute" which starts the giant stone ball rolling... | 14:42 |
| *** jcoufal has joined #openstack-ironic | 14:42 | |
| *** dpawar has joined #openstack-ironic | 14:43 | |
| *** baha has joined #openstack-ironic | 14:43 | |
| hamzy | I'll try poking around some more... | 14:43 |
| dtantsur | hamzy: I suggest you abort whatever is running now, make sure node's status is clean, then retry only one action | 14:44 |
| hamzy | tripleo is a complicated beast | 14:46 |
| dtantsur | or did you even start introspection? | 14:46 |
| dtantsur | +100500 | 14:46 |
| hamzy | I will clean up and start from the top... maybe something got bent along the wya | 14:47 |
| hamzy | way | 14:47 |
| *** ianychoi has quit IRC | 14:48 | |
| mgoddard | rloo: yeah it's definitely getting tight, which is a real shame. The client changes seem the limiting factor to me as the deadline is soon and it depends to some extent on everything else. Do you think it's possible? | 14:49 |
| *** fragatina has joined #openstack-ironic | 14:49 | |
| rloo | mgoddard: isn't anything possible? :) if we had people updating the patches and reviewing them frequently, then yes. i probably should have asked yesterday. | 14:50 |
| rloo | mgoddard: if we only care to get the traits in ironic done, i think it is possible; the deadline for that is next week. if we also want the nova part, that is really really tight, cuz we need to get the code in ironic first, before nova will look at that part, and their deadline is next week. | 14:51 |
| mgoddard | rloo: is the ironic support useful without nova? | 14:51 |
| *** ianychoi has joined #openstack-ironic | 14:52 | |
| mgoddard | rloo: we do have an ace up our sleeves - johnthetubaguy is a nova core, and isn't the one writing the nova code | 14:52 |
| *** fragatina has quit IRC | 14:52 | |
| rloo | mgoddard: nope, don't think so. i think we wanted this in due to the nova changes wrt placement. | 14:52 |
| rloo | mgoddard: true, i just don't like asking people to deal with 'exceptions'. | 14:52 |
| *** fragatina has joined #openstack-ironic | 14:52 | |
| rloo | mgoddard: i could also update the ironic patches, but then who'd review them? | 14:53 |
| mgoddard | rloo: right, exceptions should remain exceptional | 14:53 |
| rloo | mgoddard: well, you get the nova ones working as best you can, so folks can just +2 them :) | 14:53 |
| mgoddard | rloo: I'm thinking I could take a look at some ironic changes, but want to make sure I'm not duplicating john's efforts | 14:54 |
| mgoddard | rloo: from your review, there's a patch missing for ironic - RPC API for trait CRUD | 14:54 |
| jroll | I should have the client patches done shortly, fwiw | 14:55 |
| openstackgerrit | Ilya Etingof proposed openstack/sushy-tools master: Abstract away the virtualization management interface https://review.openstack.org/523321 | 14:55 |
| mgoddard | jroll: great | 14:55 |
| jroll | I could also update the ironic stuff if that's helpful | 14:55 |
| rloo | jroll: ++ to updating the ironic stuff | 14:55 |
| jroll | oops, it's way too easy to sign up for work around here | 14:56 |
| mgoddard | jroll: it's unlikely to be unhelpful | 14:56 |
| rloo | jroll: if tubaman isn't going to do it soon | 14:56 |
| jroll | suspect I won't get to the API until this afternoon (nighttime for john) so we shouldn't conflict | 14:56 |
| rloo | jroll: if you were core, i'd volunteer to update :) | 14:56 |
| jroll | heh | 14:57 |
| mgoddard | good spot re remoteable jroll, that will likely save us a patch | 15:04 |
| *** cjloader has joined #openstack-ironic | 15:10 | |
| *** links has quit IRC | 15:11 | |
| *** racedo has quit IRC | 15:12 | |
| dtantsur | rloo: did you have a chance to read my comment on the hw types upgrade patch? | 15:15 |
| rloo | dtantsur: not yet. was trying to look into the oslo.serialization, then went to traits, now your stuff. umm, are you sure that you want to go this route before I look at it? (i'm not saying it is wrong, just don't want to spend time if you're thinking of changing again. i don't really care how we do it, since it is just for one cycle. | 15:16 |
| dtantsur | rloo: the end result seems much simpler now | 15:17 |
| rloo | dtantsur: ok, let me skim it quickly. | 15:17 |
| dtantsur | thnx! | 15:17 |
| *** absubram has joined #openstack-ironic | 15:19 | |
| jlvillal | dtantsur, I left a review of -1 on https://review.openstack.org/#/c/534736/ | 15:22 |
| patchbot | patch 534736 - oslo.serialization - Revert "When serializing an exception return its '... | 15:22 |
| jlvillal | sambetts, Maybe you can also look at ^^^ | 15:22 |
| jlvillal | I forget what this broke of ours | 15:22 |
| dtantsur | jlvillal: thanks! I don't remember why we did it, so your input is very helpful | 15:22 |
| jlvillal | dtantsur, I found the reason why in https://etherpad.openstack.org/p/IronicGateDebugging | 15:23 |
| jlvillal | Search for 508287 | 15:23 |
| jlvillal | dtantsur, I'm glad we keep notes :) | 15:23 |
| dtantsur | ++ | 15:23 |
| dtantsur | jlvillal: thanks, mind summarizing it on the review? | 15:24 |
| sambetts | dtantsur, jlvillal: left a comment, -1 to reverting a fix for a legitamte bug | 15:25 |
| dtantsur | yeah, I wonder if glance tests should be fixed instead.. | 15:25 |
| sambetts | if that change breaks them, then they should definatly be fixed... | 15:27 |
| jlvillal | sambetts, dtantsur: So basically I think we can handle a revert as we did a work-around. Since there has been no oslo.serialization release with that code being used by us. | 15:28 |
| jlvillal | I don't think we will break as sambetts' work-around handles it for us | 15:28 |
| sambetts | yeah, we could handle the revert, but I prefer to revert our workaround post-upper-constrait bump | 15:28 |
| jlvillal | The work-around: https://review.openstack.org/#/c/508225 | 15:28 |
| patchbot | patch 508225 - ironic - Stop passing raw Exceptions as the reasons for iro... (MERGED) | 15:28 |
| *** mjturek has quit IRC | 15:29 | |
| *** serlex has left #openstack-ironic | 15:29 | |
| jlvillal | Well I think we have left enough info for them to figure out what they want to do :) | 15:29 |
| sambetts | yeah... | 15:30 |
| *** mjturek has joined #openstack-ironic | 15:33 | |
| *** mjturek has quit IRC | 15:34 | |
| openstackgerrit | Julia Kreger proposed openstack/ironic-lib master: Add wait_for_disk to destroy_disk_metadata function https://review.openstack.org/529325 | 15:40 |
| *** mjturek has joined #openstack-ironic | 15:41 | |
| TheJulia | rloo: ^^^ ripped out -m | 15:42 |
| rloo | TheJulia: thx | 15:44 |
| dtantsur | rloo: thanks for review! so I see you're not firmly NOPE on the new approach, right? | 15:44 |
| TheJulia | rloo: tl;dr busybox fuser has a completely different behavior | 15:44 |
| rloo | dtantsur: i'm ok on almost any approach that works; this code is not going to be forever, we just need to get it done in some reasonable way :) | 15:44 |
| rloo | TheJulia: :-( and why am I not surprised? | 15:45 |
| rloo | dtantsur: i'm fairly sure that we can land that by end of next week. right now, trying to focus on other priorities... | 15:46 |
| dtantsur | ack, I'll work further on this | 15:47 |
| rloo | dtantsur: since you had +2 this before, it shouldn't take you too long if you have a few min: https://review.openstack.org/#/c/509336/ | 15:48 |
| patchbot | patch 509336 - ironic - Adds RPC calls for rescue interface | 15:48 |
| dtantsur | rloo: will do, after the current meeting(s) | 15:48 |
| rloo | dtantsur: thx | 15:48 |
| *** baha has left #openstack-ironic | 15:53 | |
| openstackgerrit | Ilya Etingof proposed openstack/sushy-tools master: Abstract away the virtualization management interface https://review.openstack.org/523321 | 15:54 |
| *** baha has joined #openstack-ironic | 15:54 | |
| *** chas has joined #openstack-ironic | 15:54 | |
| *** chas has quit IRC | 15:54 | |
| *** makowals has quit IRC | 16:03 | |
| *** makowals has joined #openstack-ironic | 16:04 | |
| *** makowals has quit IRC | 16:04 | |
| *** makowals has joined #openstack-ironic | 16:05 | |
| *** makowals has quit IRC | 16:05 | |
| openstackgerrit | Merged openstack/virtualbmc master: Updated from global requirements https://review.openstack.org/534072 | 16:05 |
| *** makowals has joined #openstack-ironic | 16:05 | |
| *** makowals has quit IRC | 16:06 | |
| *** racedo has joined #openstack-ironic | 16:06 | |
| *** makowals has joined #openstack-ironic | 16:06 | |
| *** makowals has quit IRC | 16:06 | |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic master: Add rescue related methods to network interface https://review.openstack.org/509342 | 16:18 |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic master: Add rescuewait timeout periodic task https://review.openstack.org/353156 | 16:18 |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic master: Agent rescue implementation https://review.openstack.org/400437 | 16:18 |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic master: [WIP] Automatically migrate nodes to hardware types https://review.openstack.org/534373 | 16:18 |
| openstackgerrit | Jim Rollenhagen proposed openstack/python-ironicclient master: Traits support https://review.openstack.org/532622 | 16:19 |
| jroll | ^ this is done except release note, will write that when I'm not in a meeting | 16:19 |
| *** absubram has quit IRC | 16:21 | |
| rloo | jroll: i commented in the rpc traits patch. the remotable stuff doesn't work (for one, it is turned off in api service) | 16:22 |
| dtantsur | rloo: thinking about the migration.. on my undercloud pxe_ipmitool nodes won't migrate, because shellinabox is not enabled | 16:24 |
| dtantsur | and agent RAID | 16:24 |
| dtantsur | I wonder how important it is to migrate optional interfaces.. or whether we should say, okay, these will be no-console and no-raid | 16:25 |
| rloo | dtantsur: oh. pxe_ipmitool is configured to use shellinabox? let me look/think. | 16:27 |
| dtantsur | rloo: well, yes | 16:27 |
| dtantsur | and ditto for RAID | 16:27 |
| dtantsur | in TripleO case we don't care about either.. but we won't be migrated with the current logic :( | 16:28 |
| rloo | dtantsur: so right now, if shellinabox is not enabled (i'm assuming you mean via configs), will console work for node with pxe_ipmitool? | 16:28 |
| dtantsur | rloo: it will. classic drivers don't depend on enabled_XXX_interfaces stuff | 16:29 |
| rloo | dtantsur: i think then, that we should migrate those with a big warning that they need to update their config, cuz we can't update their config values. | 16:29 |
| rloo | dtantsur: either that, or we don't migrate with a big warning that we cannot unless they update their config | 16:30 |
| dtantsur | rloo: the 3rd alternative is to allow broken nodes | 16:30 |
| dtantsur | which is probably even worse, yeah | 16:30 |
| rloo | dtantsur: 'broken' == what? | 16:30 |
| dtantsur | rloo: with disabled interfaces | 16:30 |
| rloo | dtantsur: that is worse. | 16:30 |
| rloo | dtantsur: i think | 16:30 |
| rloo | dtantsur: hmm. so they may not want that enabled, they may never use raid or console. so maybe that isn't worse. | 16:32 |
| dtantsur | well, I don't think we'll work with such nodes at all | 16:32 |
| dtantsur | the 4th option is to allow configuration in ironic.conf specifically for this migration (SIGH) | 16:32 |
| rloo | dtantsur: i don't think we can do that. you mean update their config file? | 16:33 |
| dtantsur | I guess, putting aside crazy options, we have two: 1. skip such nodes, 2. revert optional interfaces to no-XXX with a warning | 16:33 |
| rloo | dtantsur: i think the conservative approach is to skip such nodes | 16:34 |
| dtantsur | yes. I think it's fair to expect no regressions in functionality after data migration | 16:34 |
| rloo | dtantsur: they will have to do something like 1. enable the interface in the config; 2. do migration manually | 16:34 |
| dtantsur | not necessary manually, they can just rerun ironic-dbsync online_data_migrations | 16:35 |
| dtantsur | it will pick nodes skipped the last time | 16:35 |
| rloo | dtantsur: oh yes, if they do 1. I mean, if they don't do 1, onlinedbmigration won't migrate still. | 16:35 |
| dtantsur | yep, I'm leaning towards 1. | 16:36 |
| rloo | dtantsur: so if they don't do 1, they'll have to manually migrate, disable those optional interfaces | 16:36 |
| rloo | dtantsur: which could be a pain, if they have a lot of nodes with pxe_ipmitool and never use eg raid. | 16:36 |
| rloo | dtantsur: well, c'est la vie. i don't want to think that we're so smart we can figure out what to do programmatically and get it correct each time. | 16:37 |
| dtantsur | right, thanks for thinking about it with me :) | 16:37 |
| rloo | dtantsur: another alternative is to add some sort of flag to the online-data-migrations cmd, to indicate wehther to 1. disable interface if not enabled in conf or 2. don't migrate if not enabled in conf, with 2 being the default. | 16:39 |
| *** penick has joined #openstack-ironic | 16:40 | |
| * rloo doesn't have an operator hat | 16:40 | |
| *** marios has quit IRC | 16:40 | |
| dtantsur | yeah, I don't know. we may be overthinking it. | 16:40 |
| dtantsur | then, things like tripleo, where online_data_migrations is buried deep in puppet won't benefit from such option anyway | 16:41 |
| *** AlexeyAbashkin has quit IRC | 16:41 | |
| rloo | dtantsur: right. it is only to provide an option to do 1 for those that want it. eg, you run online_data_migrations and get all these warnings. do you update your conf to enable them, or do you really want them (raid, console) to be set as no-X. If the latter, then this new option is for them. Otherwise, they'll have to manually migrate/set those interfaces. | 16:43 |
| *** penick has quit IRC | 16:43 | |
| dtantsur | I guess we can land this patch without options and then decide if we have time/energy to work on them | 16:45 |
| rloo | dtantsur: yup, that makes sense | 16:45 |
| *** penick has joined #openstack-ironic | 16:46 | |
| rloo | btw, gate is broken w/o this patch: https://review.openstack.org/#/c/534768/ | 16:46 |
| patchbot | patch 534768 - ironic - Fix docs for Sphinx 1.6.6 | 16:46 |
| *** pcaruana has quit IRC | 16:46 | |
| rloo | do I need to update whiteboard? hopefully that will land w/i the hour... | 16:46 |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic master: [WIP] Automatically migrate nodes to hardware types https://review.openstack.org/534373 | 16:46 |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic master: Add rescuewait timeout periodic task https://review.openstack.org/353156 | 16:47 |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic master: Agent rescue implementation https://review.openstack.org/400437 | 16:47 |
| jroll | rloo: boooooo (re remotable) | 16:48 |
| jroll | much more code to write now | 16:48 |
| rloo | jroll: yeah. sorry about that | 16:48 |
| jroll | it happens | 16:49 |
| * jroll runs to lunch and an appt | 16:49 | |
| rloo | jroll: i might be fine just updating from the api. i think we can change/move to conductor doing it later. let me look at that patch again. | 16:49 |
| jroll | rloo: eh, we try to keep writes out of the api, I think partially for rolling upgrades purposes | 16:49 |
| rloo | jroll: exactly. but i doubt that we'll change that trait object any time soon? | 16:50 |
| jroll | rloo: probably not, but not sure it's worth the risk (or the inconsistency) | 16:50 |
| rloo | jroll: it is the object versions that is the tricky part. | 16:50 |
| rloo | jroll: i'm fine if it is coded with the conductor. shouldn't be too hard? | 16:51 |
| rloo | jroll: i can't recall, but i think we already have writes in api. oh yeah. chassis. maybe something else. | 16:51 |
| jroll | rloo: as in, putting methods in conductor/manager.py? yeah, won't be too hard, just more to do | 16:51 |
| rloo | jroll: yup, that. rpc version update, blah blah. but simple code :) | 16:52 |
| *** absubram has joined #openstack-ironic | 16:52 | |
| jroll | indeed | 16:52 |
| jroll | anyway, bbl | 16:52 |
| rloo | enjoy your lunch | 16:52 |
| *** Goneri has quit IRC | 16:53 | |
| *** stendulker has quit IRC | 16:56 | |
| *** mjturek has quit IRC | 16:57 | |
| *** milan_ has quit IRC | 16:57 | |
| *** fragatina has quit IRC | 17:03 | |
| *** e0ne has quit IRC | 17:09 | |
| *** racedo_ has joined #openstack-ironic | 17:11 | |
| *** honza has joined #openstack-ironic | 17:11 | |
| *** racedo has quit IRC | 17:11 | |
| *** mjturek has joined #openstack-ironic | 17:16 | |
| *** dtantsur is now known as dtantsur|afk | 17:18 | |
| dtantsur|afk | o/ | 17:18 |
| mjturek | does anyone have any advice on debugging this? http://logs.openstack.org/99/501799/15/check/ipa-tempest-dsvm-ironic-inspector-src/547314e/logs/ironic-bm-logs/node-0_no_ansi_2018-01-16-15:42:08.txt.gz#_2018-01-16_15_41_25_037 Not sure why execute is failing | 17:20 |
| *** tesseract has quit IRC | 17:21 | |
| TheJulia | mjturek: silly question, are you feeding it 'command', 'arg1', 'arg2' ? | 17:22 |
| sambetts | mjturek: seems like the error log is being eaten by TypeError: not all arguments converted during string formatting | 17:22 |
| TheJulia | mjturek: your feeding a single string in, you need to break it up | 17:24 |
| sambetts | yeah +1, you can only pass a full string in if shell=True | 17:24 |
| mjturek | ahhhh okay, I got rid of shell=True to address a comment is wasn't needed, didn't realize it takes commands like that! Thanks sambetts and TheJulia | 17:25 |
| mjturek | that it wasn't needed* | 17:25 |
| sambetts | np | 17:25 |
| *** amarao has quit IRC | 17:30 | |
| *** r-daneel has joined #openstack-ironic | 17:31 | |
| *** racedo_ has quit IRC | 17:33 | |
| openstackgerrit | Michael Turek proposed openstack/ironic-python-agent master: Use lshw in place of dmidecode for the default hardware manager https://review.openstack.org/501799 | 17:49 |
| openstackgerrit | Merged openstack/sushy master: Updated from global requirements https://review.openstack.org/534057 | 17:49 |
| *** fragatina has joined #openstack-ironic | 17:52 | |
| *** fragatin_ has joined #openstack-ironic | 17:53 | |
| *** fragatina has quit IRC | 17:54 | |
| *** derekh has quit IRC | 18:00 | |
| *** dpawar has quit IRC | 18:01 | |
| TheJulia | I swear half the time I'm running unit tests right now is deprecation warnings being printed to my screen | 18:01 |
| *** mjturek has quit IRC | 18:02 | |
| *** Goneri has joined #openstack-ironic | 18:04 | |
| *** trown has quit IRC | 18:06 | |
| openstackgerrit | Julia Kreger proposed openstack/ironic master: WIP: Don't try to lock upfront for vif removal https://review.openstack.org/534441 | 18:07 |
| TheJulia | sambetts: ^^^ conceptually what might have helped prevent the issue I ran into with orphaned vifs, since it really seems like we shouldn't need to lock unless it is going to actually impact a node operationally | 18:08 |
| *** mjturek has joined #openstack-ironic | 18:09 | |
| sambetts | TheJulia: +1 I was thinking about that, we don't need to lock that during cleaning, we didn't used to care about the lock when nova port.updated the old field from the port.info so I'm good with that | 18:10 |
| TheJulia | sambetts: awesome | 18:11 |
| openstackgerrit | John L. Villalovos proposed openstack/ironic-lib master: Simplify logic in wait_for_disk_to_become_available https://review.openstack.org/534867 | 18:11 |
| sambetts | TheJulia: thanks for following up on that :D | 18:11 |
| jlvillal | TheJulia, ^^^ May be of interest to you | 18:11 |
| TheJulia | sambetts: oh, no problem :) | 18:11 |
| TheJulia | jlvillal: I'll take a look in a few minutes, looking at somehting for crushil_ atm | 18:12 |
| jlvillal | TheJulia, No hurry | 18:12 |
| sambetts | TheJulia: re deprecation warnings ... I know right, I've been working on the networking-cisco project recently and there are so many deprecation warnings coming from the libraries, but its not something I can fix because its in a library so annoy | 18:13 |
| *** ianychoi has quit IRC | 18:14 | |
| *** e0ne has joined #openstack-ironic | 18:15 | |
| *** ianychoi has joined #openstack-ironic | 18:15 | |
| TheJulia | It always gets bad around this time of the cycle :( | 18:17 |
| *** AlexeyAbashkin has joined #openstack-ironic | 18:20 | |
| openstackgerrit | Merged openstack/ironic stable/pike: Do not validate root partition size for whole disk images in iscsi deploy https://review.openstack.org/534251 | 18:25 |
| openstackgerrit | Merged openstack/ironic master: Fix docs for Sphinx 1.6.6 https://review.openstack.org/534768 | 18:25 |
| *** AlexeyAbashkin has quit IRC | 18:25 | |
| rloo | yay, gate is fixed ^^ | 18:26 |
| * sambetts --> home | 18:28 | |
| sambetts | night all o/ | 18:28 |
| openstackgerrit | Merged openstack/ironic-lib master: Use dd conv=sparse when writing images to nodes https://review.openstack.org/534442 | 18:29 |
| *** e0ne has quit IRC | 18:30 | |
| *** sambetts is now known as sambetts|afk | 18:33 | |
| openstackgerrit | Hugo Nicodemos proposed openstack/ironic master: Migrate oneview hardware type to use python-hpOneView https://review.openstack.org/524310 | 18:35 |
| *** mjturek has quit IRC | 18:36 | |
| *** mjturek has joined #openstack-ironic | 18:38 | |
| TheJulia | did the test-runner processing change, seems like all tests now are running when a small subset are defined to run | 18:40 |
| *** openstackstatus has quit IRC | 18:40 | |
| mgoddard | who is doing the rescue work? | 18:41 |
| mgoddard | just hit this: | 18:41 |
| mgoddard | 2018-01-17 18:06:38.840 7 ERROR ironic.conductor.base_manager [req-f2f1c54a-6d00-4e38-b85e-391e514563ef - - - - -] Failed to register hardware types. For hardware type 'fake-hardware', no default value found for rescue interface.: NoValidDefaultForInterface: For hardware type 'fake-hardware', no default value found for rescue interface. | 18:41 |
| * TheJulia sighs | 18:41 | |
| *** openstackstatus has joined #openstack-ironic | 18:41 | |
| *** ChanServ sets mode: +v openstackstatus | 18:41 | |
| TheJulia | mgoddard: they are in india, any specific patches applied to master? | 18:42 |
| mgoddard | TheJulia: I'm here: https://review.openstack.org/#/c/532269/10 | 18:43 |
| patchbot | patch 532269 - ironic - WIP: API: Node Traits API | 18:43 |
| TheJulia | crushil_: so crazy idea, what if you changed your mock so it was not get client, but actually mocking your actual xclarity_client library | 18:45 |
| openstackgerrit | Merged openstack/ironic master: fix a typo in ilo.rst: s/fimware/firmware/ https://review.openstack.org/534695 | 18:45 |
| mgoddard | TheJulia: hmm, this could be a config issue - perhaps I need to enable the fake rescue interface | 18:46 |
| TheJulia | I kind of suspect it is autospec limiting scope because if I reconsruct your power test a little differently, it is spitting an error out that the mock is a function, not an object with methods. | 18:46 |
| *** karthiks has quit IRC | 18:46 | |
| *** AlexeyAbashkin has joined #openstack-ironic | 18:47 | |
| mgoddard | TheJulia: indeed that was the issue - user error... | 18:48 |
| TheJulia | mgoddard: I prefer "silly human tricks" | 18:48 |
| TheJulia | :) | 18:48 |
| crushil_ | TheJulia, Hmmm. Lemme try that | 18:49 |
| rloo | mgoddard: just saw, yes, that is needed. hmm. it means we have to be really careful about landing intermediate patches. | 18:49 |
| TheJulia | crushil_: the more I think about it, the better that is, of course, it means you have to have enough structure mocked in case the library is not present to still run unit tests :\ | 18:50 |
| *** AlexeyAbashkin has quit IRC | 18:52 | |
| *** zer0c00l has quit IRC | 18:52 | |
| TheJulia | crushil_: alternatively https://review.openstack.org/#/c/524310/11/ironic/tests/unit/drivers/modules/oneview/test_power.py line 152 might bring you inspiration | 18:53 |
| patchbot | patch 524310 - ironic - Migrate oneview hardware type to use python-hpOneView | 18:53 |
| TheJulia | since it is very similar | 18:54 |
| openstackgerrit | Julia Kreger proposed openstack/ironic-lib master: Add wait_for_disk to destroy_disk_metadata function https://review.openstack.org/529325 | 18:55 |
| crushil_ | TheJulia, I see. Let me try that first | 18:55 |
| mgoddard | rloo, jroll, johnthetubaguy: good news: I've cobbled together an environment with all the traits patches applied and done an end to end test that worked! | 18:55 |
| mgoddard | rloo, jroll, johnthetubaguy: now all that's left is to polish these turds | 18:55 |
| rloo | mgoddard: yay! | 18:55 |
| rloo | mgoddard: you mean 'polish these gems' ? :) | 18:55 |
| TheJulia | crushil_: yeah, less impactful to the rest of the file :) | 18:56 |
| TheJulia | jlvillal: updated the ironic-lib patch | 18:56 |
| mgoddard | rloo: hard to tell at this point :) | 18:56 |
| openstackgerrit | Julia Kreger proposed openstack/ironic-lib master: Simplify logic in wait_for_disk_to_become_available https://review.openstack.org/534867 | 18:56 |
| *** priteau has quit IRC | 18:58 | |
| TheJulia | sounds like we need an industrial rock tumbler anyway | 18:58 |
| rloo | +1 | 18:59 |
| * TheJulia wonders if Acme sells such a product, although worries about delivery since she has never been able to take delivery of many of their products | 19:00 | |
| jlvillal | TheJulia, Reviewed the patch :) | 19:00 |
| TheJulia | \o/ | 19:00 |
| *** gmonteiro has left #openstack-ironic | 19:06 | |
| openstackgerrit | Merged openstack/sushy master: Update documentation related to 'refresh()' https://review.openstack.org/531341 | 19:07 |
| *** karthiks has joined #openstack-ironic | 19:10 | |
| *** e0ne has joined #openstack-ironic | 19:13 | |
| *** absubram has quit IRC | 19:18 | |
| openstackgerrit | Merged openstack/python-ironicclient master: Updated from global requirements https://review.openstack.org/534023 | 19:18 |
| jroll | TheJulia: an industrial size cocktail tumbler you say? | 19:19 |
| TheJulia | jroll: heh | 19:29 |
| crushil_ | TheJulia, That didn't work. I'm thinking of creating a fake client and providing it as a parameter to the test. | 19:32 |
| *** e0ne has quit IRC | 19:38 | |
| *** trown has joined #openstack-ironic | 19:38 | |
| *** mjturek has quit IRC | 19:38 | |
| *** etingof has quit IRC | 19:42 | |
| openstackgerrit | Jim Rollenhagen proposed openstack/python-ironicclient master: Traits support https://review.openstack.org/532622 | 19:48 |
| jroll | ok this is ready to go afaict ^ | 19:48 |
| jroll | docstrings and all | 19:48 |
| *** e0ne has joined #openstack-ironic | 19:49 | |
| *** athomas has quit IRC | 19:52 | |
| *** mjturek has joined #openstack-ironic | 19:52 | |
| TheJulia | awesome | 19:57 |
| TheJulia | crushil_: :( | 19:57 |
| openstackgerrit | Julia Kreger proposed openstack/ironic master: Don't try to lock upfront for vif removal https://review.openstack.org/534441 | 19:59 |
| *** penick has quit IRC | 20:05 | |
| rloo | TheJulia: wrt https://review.openstack.org/#/c/529325/, do you want to do a followup or fix this to set that config in the unit test? | 20:11 |
| patchbot | patch 529325 - ironic-lib - Add wait_for_disk to destroy_disk_metadata function | 20:11 |
| *** mjturek has quit IRC | 20:12 | |
| *** penick has joined #openstack-ironic | 20:16 | |
| openstackgerrit | Ruby Loo proposed openstack/ironic stable/ocata: Do not validate root partition size for whole disk images in iscsi deploy https://review.openstack.org/534898 | 20:19 |
| TheJulia | I'm getting a bad feeling about our grenade multinode job | 20:20 |
| TheJulia | rloo: I'll update in a minute | 20:23 |
| rloo | TheJulia: thx. I hope your bad feeling is wrong, but honestly, i haven't looked at those failures. | 20:23 |
| TheJulia | actually | 20:23 |
| TheJulia | I'll follow-up, since john has a patch dependent upon that one | 20:24 |
| rloo | TheJulia: ok, i'll +A then. sec. | 20:24 |
| openstackgerrit | Merged openstack/ironic-ui master: Updated from global requirements https://review.openstack.org/533963 | 20:24 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/bifrost master: Updated from global requirements https://review.openstack.org/534905 | 20:28 |
| *** fragatin_ has quit IRC | 20:29 | |
| *** mjturek has joined #openstack-ironic | 20:30 | |
| *** fragatina has joined #openstack-ironic | 20:30 | |
| *** fragatina has quit IRC | 20:31 | |
| *** fragatina has joined #openstack-ironic | 20:31 | |
| *** hw_wutianwei has quit IRC | 20:31 | |
| *** dprince has quit IRC | 20:31 | |
| *** hw_wutianwei has joined #openstack-ironic | 20:32 | |
| TheJulia | http://logs.openstack.org/56/353156/68/check/ironic-grenade-dsvm-multinode-multitenant/0d98473/logs/screen-q-svc.txt.gz#_Jan_17_18_37_17_690717 | 20:33 |
| *** fragatin_ has joined #openstack-ironic | 20:34 | |
| TheJulia | http://logs.openstack.org/18/524118/11/check/ironic-grenade-dsvm-multinode-multitenant/4f27311/logs/screen-q-svc.txt.gz#_Jan_17_13_23_23_850353 | 20:34 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/ironic-inspector master: Updated from global requirements https://review.openstack.org/534931 | 20:35 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/ironic-lib master: Updated from global requirements https://review.openstack.org/534932 | 20:35 |
| *** fragatina has quit IRC | 20:35 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/ironic-tempest-plugin master: Updated from global requirements https://review.openstack.org/534933 | 20:35 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/ironic-python-agent master: Updated from global requirements https://review.openstack.org/534934 | 20:36 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/ironic-ui master: Updated from global requirements https://review.openstack.org/534935 | 20:36 |
| *** fragatina has joined #openstack-ironic | 20:36 | |
| *** fragatina has quit IRC | 20:37 | |
| mgoddard | rloo, jroll: taking a quick look at the RPC layer for traits. There are 4 write operations - add one, add all, remove one, remove all. Thoughts on how to translate these to RPC API methods? | 20:37 |
| *** fragatin_ has quit IRC | 20:37 | |
| TheJulia | http://logs.openstack.org/10/534710/1/check/ironic-grenade-dsvm-multinode-multitenant/079fa3e/logs/screen-q-svc.txt.gz#_Jan_17_11_51_35_241230 | 20:38 |
| * TheJulia declares the multinode job broken | 20:38 | |
| rloo | TheJulia: :-( | 20:38 |
| * rloo looks at mgoddard's question first before facing broken job... | 20:39 | |
| -openstackstatus- NOTICE: Zuul will be offline for a few minutes; existing changes will be re-enqueued; approvals during the downtime will need to be re-added. | 20:39 | |
| jlvillal | TheJulia, Does this look like what you want? http://paste.openstack.org/show/646544/ | 20:39 |
| jlvillal | I was thinking I could add it to my patch | 20:39 |
| TheJulia | jlvillal: that works, I _wonder_ if busyboxy fuser doesn't split output though..... | 20:40 |
| TheJulia | since they seem to be two very different beasts | 20:40 |
| * jlvillal does not know | 20:40 | |
| TheJulia | hmmm | 20:40 |
| TheJulia | give me 30 seconds | 20:41 |
| rloo | mgoddard: might be easier to look at the API part and work backwards. also, i thought jroll was going to do this. i hope you aren't both doing it. | 20:41 |
| jlvillal | TheJulia, Sure. | 20:41 |
| jlvillal | TheJulia, fuser blah > /dev/null; fuser blah 2> /dev/null | 20:41 |
| jlvillal | TheJulia, Is how I have been checking stuff | 20:41 |
| mgoddard | rloo: simple answer is to mirror the DB API methods, but there are 4 of them | 20:41 |
| *** fragatina has joined #openstack-ironic | 20:42 | |
| rloo | mgoddard: in the API there is one PUT and one DELETE. so I'd do one 'update' RPC API, and one 'delete' RPC API. but give me a few mins to think about it | 20:42 |
| TheJulia | jlvillal: ugh, it behaves very diffrently, might be good to leave the tests as-is :\ | 20:43 |
| mgoddard | rloo: each of those is actually two operations - PUT one vs. PUT all | 20:43 |
| TheJulia | just to ensure we're basically covered, at least output/logging wise it is likely acting the same | 20:43 |
| * TheJulia doesn't want to go hunt down busybox source atm | 20:43 | |
| TheJulia | well | 20:44 |
| rloo | mgoddard: yeah, but we can add parameters to the call to indicate which. sec, looking at existing ones to see about consistency | 20:44 |
| TheJulia | now I have a moment, downstream question went away | 20:44 |
| jlvillal | TheJulia, Differently how? | 20:44 |
| jlvillal | TheJulia, As in it doesn't output to stderr? | 20:45 |
| TheJulia | https://git.busybox.net/busybox/tree/procps/fuser.c | 20:46 |
| jlvillal | TheJulia, That makes me thing too much. :( | 20:47 |
| *** fragatina has quit IRC | 20:47 | |
| jlvillal | s/thing/think/ | 20:48 |
| TheJulia | at a glance, without digging too much into the busybox source, it might toss everything to stdout | 20:48 |
| * TheJulia pours glasses of scotch and passes them around | 20:49 | |
| jlvillal | TheJulia, I thought you were running the fuser command from busybox. | 20:49 |
| jlvillal | TheJulia, so could just test it with: fuser foo > /dev/null | 20:49 |
| jlvillal | TheJulia, I didn't realize you were reading the source code to figure it out :) | 20:49 |
| mgoddard | jroll: are you looking at the RPC layer for traits? | 20:51 |
| TheJulia | jlvillal: I fired up busybox, but then I realized it was looking for /proc, so then I pulled the source | 20:52 |
| jlvillal | ln -s /sbin/busybox fuser | 20:52 |
| jlvillal | ./fuser open-file.txt | 20:52 |
| jlvillal | 15526 | 20:52 |
| jlvillal | TheJulia, So in my test it doesn't even show a file name. | 20:52 |
| jlvillal | This is Fedora and installing the busybox package | 20:53 |
| TheJulia | \o/ | 20:53 |
| jlvillal | TheJulia, Does TinyIPA use busybox and CoreOS uses ... | 20:53 |
| TheJulia | I don't think it matters | 20:53 |
| TheJulia | cirros uses ?psmisc?'s fuser, which is what most distributions use | 20:54 |
| rloo | mgoddard, jroll: so at API, we have (per node): 'add/create new trait', 'replace with these traits', 'remove a trait', 'remove all traits' | 20:54 |
| jlvillal | TheJulia, Anyway tests seem to pass :) | 20:54 |
| jlvillal | TheJulia, Kind of sucks with the lack of consistency though | 20:54 |
| mgoddard | rloo: correct | 20:54 |
| TheJulia | jlvillal: inconsistency as a service | 20:55 |
| jlvillal | heh | 20:55 |
| rloo | mgoddard, jroll: wrt remove, rpc calls seem to use 'destroy', but i'm ok if we use something like 'remove_traits(self,context,node, trait=None, topic=None) | 20:55 |
| rloo | mgoddard, jroll: where we remove one trait if trait is not None, and remove all traits if trait is None. | 20:55 |
| TheJulia | +1 to rloo's statement | 20:55 |
| TheJulia | vifs are vif_attach/vif_detach | 20:56 |
| TheJulia | so, I think we are in "whatever works/makes sense" territory too | 20:56 |
| mgoddard | rloo: yes, that seems reasonable | 20:56 |
| rloo | TheJulia: good. attach/detach is odd for traits, and we seem to 'say' add/remove, so... | 20:56 |
| rloo | mgoddard: the add one, replace all is not so easy. thinking... | 20:57 |
| TheJulia | rloo: agreed | 20:57 |
| mgoddard | rloo: maybe we should stick with set/add as separate? | 20:58 |
| rloo | mgoddard: i think it is clearer to have two RPC apis. create (or add)_trait(self, context, node, trait, topic=None) | 20:58 |
| rloo | mgoddard: yeah | 20:58 |
| rloo | mgoddard: if we think we might want to add more than one trait in the future, we could change that to be a list of traits ^^ | 20:59 |
| rloo | mgoddard: and set_traits or replace_traits? (self, context, node, traits, topic=None) | 21:00 |
| rloo | mgoddard: now they look alike wrt arguments. I suppose we could have one set_traits() with a Bool flag 'replace' defaulting to False? | 21:00 |
| mgoddard | rloo: that could work | 21:02 |
| rloo | mgoddard: so set_traits(self, context, node, traits, replace=False, topic=None) ? | 21:03 |
| rloo | mgoddard: i think that is easier than having two somewhat similar apis. | 21:03 |
| rloo | mgoddard: and it makes it clear if it is adding or replacing. | 21:03 |
| jroll | mgoddard: I'm not looking at it (yet) | 21:03 |
| jroll | probably won't get to it this afternoon | 21:04 |
| tonyb | dtantsur|afk: Yeah the non-overlap is like that. I *think* I decided that I (well tripleo) need to setup the tftpboot etc so that when the node boots it all happens. | 21:04 |
| tonyb | dtantsur|afk: unlike when I'm booting the node for deployment when ironic will setup the pxe environment for me | 21:05 |
| rloo | TheJulia: ok, so do we need to look into the multinode job? | 21:08 |
| * rloo hopes that 'no' is the answer | 21:08 | |
| TheJulia | rloo: I think yes :( | 21:09 |
| rloo | darn. i need to learn to darn. socks... | 21:10 |
| openstackgerrit | Julia Kreger proposed openstack/ironic-lib master: Minor follow-up for wait_for_disk tests https://review.openstack.org/534952 | 21:10 |
| TheJulia | heh | 21:10 |
| TheJulia | anyway, multinode grenade... | 21:10 |
| rloo | TheJulia: looks like it was fine last night. http://ci-watch.tintri.com/project?project=ironic | 21:14 |
| rloo | TheJulia: and is it a coincidence that it started failing when sphinx did too. wondering if some library got pulled in... | 21:14 |
| TheJulia | looks like I14e45fd5d2d3c816bb39f8ace56f7be460bac0d6 merged earlier today | 21:15 |
| TheJulia | well, last night, 16 hours ago | 21:15 |
| TheJulia | I suspect this will be a quick networking-generic-switch fix | 21:16 |
| rloo | TheJulia: if it is network related, i won't be much help. | 21:16 |
| rloo | TheJulia: quick for you? :) | 21:16 |
| TheJulia | yes | 21:16 |
| TheJulia | I hope | 21:16 |
| TheJulia | hmmm | 21:16 |
| * rloo takes a deep breath and dives into the logs... | 21:17 | |
| mgoddard | jroll: ok, I moved onto the API, I'll pick up RPC layer tomorrow. If you have any code to share by then it would be appreciated | 21:17 |
| jroll | mgoddard: cool, if I write any I will put it in gerrit | 21:17 |
| jroll | thanks | 21:17 |
| mgoddard | jroll: ty | 21:17 |
| TheJulia | i hope we don't need to release n-g-s | 21:18 |
| rloo | TheJulia: we shouldn't have to. if i understand (which I don't), the callback ability is there, just not in that package, so we need to do something to use it? | 21:21 |
| TheJulia | so the installed n-g-s version that is getting used is 0.4.1dev5.... | 21:23 |
| * TheJulia wonders if that is the stable branch | 21:23 | |
| TheJulia | uhh yup | 21:24 |
| TheJulia | so neutron is starting with old networking-generic-switch | 21:24 |
| TheJulia | $#*!(#!(* | 21:25 |
| rloo | vdrok: are you around? ^^ | 21:26 |
| vdrok | hi, yes, kind of | 21:27 |
| vdrok | hello folks :) | 21:27 |
| rloo | vdrok: our multitenant/grenade job is broken. TheJulia is looking into it. Looks like it has to do with callbacks,eg http://logs.openstack.org/56/353156/68/check/ironic-grenade-dsvm-multinode-multitenant/0d98473/logs/screen-q-svc.txt.gz#_Jan_17_18_37_17_690717 | 21:28 |
| vdrok | so multinode grenad does not update n-g-s? | 21:28 |
| rloo | vdrok: i'm not familiar with this stuff, hoping you would be | 21:28 |
| rloo | vdrok: TheJulia mentioned above, that it seems to coincide with https://review.openstack.org/#/c/529706/ | 21:29 |
| patchbot | patch 529706 - neutron - remove neutron.callbacks package (MERGED) | 21:29 |
| TheJulia | vdrok: neutron before plugins I guess, static upgrade path I believe | 21:29 |
| TheJulia | I suspect the shortest path is ask for the neutron change to be reverted | 21:30 |
| rloo | TheJulia: that change makes it sound like the stuff is available in neutron lib -- can't we use from the lib then? | 21:32 |
| TheJulia | if we backported the change.... | 21:33 |
| *** pmannidi has joined #openstack-ironic | 21:33 | |
| TheJulia | that might be an option | 21:33 |
| vdrok | hrm, we do use it from the neutron-lib in master | 21:33 |
| * TheJulia hasn't looked at the change in n-g-s- yet | 21:33 | |
| vdrok | ah so you mean neutron upgraded before n-g-s and cannot start because callbacks were deleted from neutron and older release n-g-s still uses them | 21:34 |
| rloo | I am thinking TheJulia may have a point about reverting... seems like they need a deprecation period first? | 21:36 |
| vdrok | backport should be easy as well, callbacks in neutron-lib have been around since ocata it seems | 21:38 |
| rloo | vdrok: let's backport then | 21:38 |
| openstackgerrit | Vladyslav Drok proposed openstack/networking-generic-switch stable/pike: use callbacks from neutron-lib https://review.openstack.org/534955 | 21:38 |
| vdrok | https://review.openstack.org/534955 | 21:39 |
| patchbot | patch 534955 - networking-generic-switch (stable/pike) - use callbacks from neutron-lib | 21:39 |
| vdrok | heh, I already forgot there is a bot :) | 21:39 |
| *** baha has quit IRC | 21:39 | |
| rloo | vdrok: no worries, whatever works! | 21:40 |
| TheJulia | it looks like the extent of the deprecation was an inline note last april | 21:40 |
| vdrok | yeah the policy was met i think, this is our fault :( | 21:41 |
| rloo | TheJulia, vdrok: do you know if that will break CI on stable branch? ocata -> pike? | 21:42 |
| vdrok | rloo: should not, callbacks still there in pike | 21:42 |
| rloo | vdrok: good | 21:42 |
| vdrok | so i guess no need to backport to ocata | 21:42 |
| TheJulia | yeah, it shouldn't | 21:43 |
| *** threestrands_ has joined #openstack-ironic | 21:44 | |
| TheJulia | vdrok: there was no other annoucement that I know of, but I've not searched the ML yet | 21:44 |
| TheJulia | in-line note is kind of not great :( | 21:44 |
| *** threestrands_ has quit IRC | 21:45 | |
| vdrok | yeah indeed, some warning would be nice in the logs | 21:45 |
| rloo | wrt stable/pike, this worked today so we're good there: https://review.openstack.org/#/c/534251/ | 21:45 |
| patchbot | patch 534251 - ironic (stable/pike) - Do not validate root partition size for whole disk... (MERGED) | 21:45 |
| *** threestrands_ has joined #openstack-ironic | 21:45 | |
| *** threestrands_ has quit IRC | 21:45 | |
| *** threestrands_ has joined #openstack-ironic | 21:45 | |
| TheJulia | yeah, ml post on 9/19/17 | 21:45 |
| TheJulia | glad it is backportable | 21:46 |
| rloo | yup. Thx TheJulia and vdrok for noticing & fixing | 21:47 |
| vdrok | np, you've already provided all the info :) | 21:47 |
| openstackgerrit | John L. Villalovos proposed openstack/ironic-lib master: Simplify logic in wait_for_disk_to_become_available https://review.openstack.org/534867 | 21:47 |
| jlvillal | TheJulia, ^^ I updated stuff. One unit test no longer takes 2 seconds. And added additional comments, etc... | 21:48 |
| * TheJulia wonders if now is a good time to go make dinner | 21:48 | |
| rloo | TheJulia: should I +A that pike patch before tests are done? | 21:48 |
| TheJulia | jlvillal: awesome | 21:48 |
| TheJulia | rloo: I think it is fine if it passes the jobs | 21:49 |
| jlvillal | TheJulia, And of course I have a pep8 error. Duh | 21:49 |
| openstackgerrit | Mark Goddard proposed openstack/ironic master: WIP: API: Node Traits API https://review.openstack.org/532269 | 21:49 |
| openstackgerrit | John L. Villalovos proposed openstack/ironic-lib master: Simplify logic in wait_for_disk_to_become_available https://review.openstack.org/534867 | 21:50 |
| jlvillal | TheJulia, ^^ all default tox tests pass :) | 21:50 |
| TheJulia | well, if this is our one grenade disaster this cycle, and we have it fixed in under 24 hours, I think we're doing really good | 21:50 |
| rloo | TheJulia: definitely! | 21:53 |
| TheJulia | jlvillal: \o/ | 21:56 |
| openstackgerrit | John L. Villalovos proposed openstack/ironic-lib master: Simplify logic in wait_for_disk_to_become_available https://review.openstack.org/534867 | 21:56 |
| jlvillal | TheJulia, ^^^ Just more unit tests to be thorough :) I think I'm done until someone -1s the patch :) | 21:57 |
| TheJulia | I'm going to plug in my laptop to charge and work on a few things to get ready for dinner since I had to get a stupidly early start this morning. I'll keep an eye and issue rechecks one the n-g-s backport passes (hopefully) | 21:58 |
| jlvillal | TheJulia, You need an automated recheck service? | 21:58 |
| jlvillal | TheJulia, Oh never mind. Not that kind of recheck. | 21:59 |
| rloo | jlvillal: well, it has been approved but we don't know if the tests pass. might want a manual look first before rechecking :) | 21:59 |
| * jlvillal decides to go enjoy his day off work. | 21:59 | |
| jlvillal | rloo, Yep! | 21:59 |
| * rloo thought that jlvillal WAS enjoying his day off. | 21:59 | |
| * rloo wonders what could be more fun that hanging out with us | 22:00 | |
| * jlvillal decides to go enjoy his day off work even more! | 22:00 | |
| rloo | s/that/than/ | 22:00 |
| jlvillal | rloo, :P | 22:00 |
| rloo | jlvillal: thx! ha ha | 22:00 |
| * jlvillal has a new CPU cooler he should install | 22:00 | |
| *** trown is now known as trown|outtypewww | 22:01 | |
| *** rcernin has joined #openstack-ironic | 22:02 | |
| *** milan has joined #openstack-ironic | 22:02 | |
| TheJulia | jlvillal: nah :) | 22:04 |
| TheJulia | \o/ enjoying the day | 22:05 |
| openstackgerrit | Merged openstack/ironic-lib master: Add wait_for_disk to destroy_disk_metadata function https://review.openstack.org/529325 | 22:09 |
| *** e0ne has quit IRC | 22:20 | |
| *** fragatina has joined #openstack-ironic | 22:23 | |
| *** e0ne has joined #openstack-ironic | 22:26 | |
| *** e0ne_ has joined #openstack-ironic | 22:27 | |
| *** e0ne has quit IRC | 22:30 | |
| *** e0ne_ has quit IRC | 22:32 | |
| *** milan has quit IRC | 22:53 | |
| *** jkilpatr has quit IRC | 22:54 | |
| *** PixieBoots has quit IRC | 23:00 | |
| *** cjloader_ has joined #openstack-ironic | 23:01 | |
| *** cjloader has quit IRC | 23:01 | |
| *** penick has quit IRC | 23:01 | |
| *** milan has joined #openstack-ironic | 23:03 | |
| *** cjloader_ has quit IRC | 23:06 | |
| *** crushil has joined #openstack-ironic | 23:10 | |
| *** r-daneel has quit IRC | 23:11 | |
| *** Goneri has quit IRC | 23:16 | |
| *** persia has quit IRC | 23:18 | |
| *** persia has joined #openstack-ironic | 23:18 | |
| *** etingof has joined #openstack-ironic | 23:24 | |
| *** milan has quit IRC | 23:24 | |
| *** mjturek has quit IRC | 23:28 | |
| *** charcol has joined #openstack-ironic | 23:34 | |
| *** etingof has quit IRC | 23:35 | |
| *** rloo has quit IRC | 23:38 | |
| *** cjloader has joined #openstack-ironic | 23:52 | |
| *** pmannidi has joined #openstack-ironic | 23:52 | |
| *** persia has quit IRC | 23:53 | |
| *** etingof has joined #openstack-ironic | 23:54 | |
| *** cjloader has quit IRC | 23:57 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!