*** dsneddon has quit IRC | 00:05 | |
*** hshiina has joined #openstack-ironic | 00:26 | |
openstackgerrit | Harald Jensås proposed openstack/networking-baremetal master: Add dsvm job https://review.openstack.org/530409 | 00:28 |
---|---|---|
*** yangyapeng has quit IRC | 00:30 | |
*** yangyapeng has joined #openstack-ironic | 00:30 | |
*** yangyapeng has quit IRC | 00:34 | |
*** bfournie has joined #openstack-ironic | 00:35 | |
*** bfournie has quit IRC | 00:37 | |
*** rama_y has quit IRC | 00:38 | |
*** bfournie has joined #openstack-ironic | 00:43 | |
*** threestrands has quit IRC | 00:58 | |
*** threestrands has joined #openstack-ironic | 01:02 | |
*** etingof has quit IRC | 01:03 | |
*** threestrands has quit IRC | 01:03 | |
*** threestrands has joined #openstack-ironic | 01:04 | |
*** bfournie has left #openstack-ironic | 01:07 | |
*** phuongnh has joined #openstack-ironic | 01:11 | |
*** threestrands has quit IRC | 01:11 | |
*** jlabarre has quit IRC | 01:13 | |
*** hamzy has joined #openstack-ironic | 01:17 | |
*** dpawar has joined #openstack-ironic | 01:19 | |
*** dpawar has quit IRC | 01:20 | |
*** dpawar has joined #openstack-ironic | 01:20 | |
*** yangyapeng has joined #openstack-ironic | 01:21 | |
*** threestrands has joined #openstack-ironic | 01:24 | |
*** threestrands has quit IRC | 01:24 | |
*** threestrands has joined #openstack-ironic | 01:24 | |
*** threestrands has quit IRC | 01:25 | |
*** threestrands has joined #openstack-ironic | 01:26 | |
openstackgerrit | Merged openstack/ironic-inspector master: Fix Py2/Py3 differences in write locking code https://review.openstack.org/532579 | 01:27 |
tonyb | So I'd like to stash some data about my nodes to help me later map nodes to images. Can I create arbitrary keys under /properties? | 01:27 |
jroll | tonyb: in theory, yeah, though it's recommended to use /extra for that instead. /extra is for operators :) | 01:33 |
tonyb | jroll: Thanks | 01:35 |
jroll | yep, no problem :) | 01:35 |
tonyb | jroll: for the record it's the cpu sub-model to help select 'optimised' (read ones that will work) deploy kernel+initrds | 01:37 |
jroll | tonyb: sure, let me put it this way - we promise not to write anything in node.extra (except one legacy key iirc, that might be gone now). we might write node.properties. proceed with caution :P | 01:38 |
tonyb | :) | 01:38 |
*** etingof has joined #openstack-ironic | 01:43 | |
*** dpawar has quit IRC | 01:53 | |
*** threestrands has quit IRC | 01:54 | |
*** charcol has quit IRC | 01:55 | |
*** threestrands has joined #openstack-ironic | 01:56 | |
*** charcol has joined #openstack-ironic | 01:58 | |
*** bfournie has joined #openstack-ironic | 02:02 | |
*** pmannidi has joined #openstack-ironic | 02:15 | |
TheJulia | jroll: tonyb: we still support reading the vif id out of node.extra, but that is it. | 02:26 |
tonyb | TheJulia: Thanks | 02:27 |
*** ijw has quit IRC | 02:43 | |
phuongnh | hi TheJulia | 02:44 |
phuongnh | I would like to upload another patchset same as as https://review.openstack.org/#/c/511494/ but for CentOS | 02:44 |
patchbot | patch 511494 - diskimage-builder - Add iscsi-boot element | 02:44 |
*** sasha2 has quit IRC | 02:44 | |
phuongnh | shoud I propose a RFE or bug first? | 02:45 |
phuongnh | or use the same bug number #1716794? | 02:45 |
TheJulia | phuongnh: dib is outside our scope, I would say just propose it, but adding on top of the already proposed patch | 02:50 |
phuongnh | so will I propose new RFE with proposed patch on top? | 02:52 |
TheJulia | No RFE, just propose the patch. | 02:55 |
TheJulia | Just explain in the purpose in the commit message, and you should have a review or two and further instructions then. | 02:56 |
phuongnh | I see, I will put more information on commit message | 03:00 |
phuongnh | thanks | 03:00 |
*** ptx0 has quit IRC | 03:11 | |
*** amotoki has joined #openstack-ironic | 03:30 | |
*** fragatina has quit IRC | 03:37 | |
*** ptx0 has joined #openstack-ironic | 03:38 | |
*** rbudden has quit IRC | 03:44 | |
*** tzumainn has joined #openstack-ironic | 04:18 | |
*** rama_y has joined #openstack-ironic | 04:27 | |
*** links has joined #openstack-ironic | 04:31 | |
*** pmannidi has quit IRC | 04:38 | |
*** tzumainn has quit IRC | 04:40 | |
*** mjturek has joined #openstack-ironic | 04:41 | |
*** mjturek has quit IRC | 04:46 | |
*** namnh has joined #openstack-ironic | 04:51 | |
*** ijw has joined #openstack-ironic | 04:57 | |
*** pmannidi has joined #openstack-ironic | 05:00 | |
*** ijw has quit IRC | 05:01 | |
*** dpawar has joined #openstack-ironic | 05:19 | |
*** absubram has joined #openstack-ironic | 05:23 | |
*** absubram has quit IRC | 05:23 | |
*** liuzz has joined #openstack-ironic | 05:42 | |
*** ijw has joined #openstack-ironic | 05:45 | |
*** ijw has quit IRC | 05:49 | |
*** ijw has joined #openstack-ironic | 05:49 | |
*** fragatina has joined #openstack-ironic | 06:00 | |
*** fragatina has quit IRC | 06:04 | |
*** marios has joined #openstack-ironic | 06:25 | |
*** absubram has joined #openstack-ironic | 06:26 | |
*** cjloader has joined #openstack-ironic | 06:30 | |
*** cjloader has quit IRC | 06:33 | |
*** charcol has quit IRC | 06:33 | |
*** cjloader_ has joined #openstack-ironic | 06:34 | |
*** cjloader_ is now known as cjloader | 06:35 | |
*** harlowja has quit IRC | 06:35 | |
*** rama_y has quit IRC | 06:42 | |
*** ijw has quit IRC | 06:46 | |
*** pmannidi has quit IRC | 06:51 | |
*** phuongnh has quit IRC | 06:58 | |
*** hieulq has quit IRC | 06:58 | |
*** hieulq has joined #openstack-ironic | 06:59 | |
*** phuongnh has joined #openstack-ironic | 06:59 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/ironic-inspector master: Imported Translations from Zanata https://review.openstack.org/533100 | 07:04 |
*** harlowja has joined #openstack-ironic | 07:10 | |
*** harlowja has quit IRC | 07:10 | |
*** rcernin has quit IRC | 07:28 | |
*** pcaruana has joined #openstack-ironic | 07:29 | |
*** makowals has quit IRC | 07:42 | |
*** ijw has joined #openstack-ironic | 07:43 | |
*** sapd_ has joined #openstack-ironic | 07:54 | |
*** threestrands has quit IRC | 07:56 | |
*** ptx0 has quit IRC | 07:58 | |
*** ptx0 has joined #openstack-ironic | 08:01 | |
*** tesseract has joined #openstack-ironic | 08:08 | |
*** zhangfei has joined #openstack-ironic | 08:13 | |
*** jtomasek has joined #openstack-ironic | 08:14 | |
*** jtomasek has quit IRC | 08:14 | |
*** jtomasek has joined #openstack-ironic | 08:15 | |
*** makowals has joined #openstack-ironic | 08:16 | |
*** AlexeyAbashkin has joined #openstack-ironic | 08:23 | |
*** amarao has joined #openstack-ironic | 08:38 | |
openstackgerrit | Harald Jensås proposed openstack/networking-baremetal master: Switch from MechanismDriver to SimpleAgentMechanismDriverBase https://review.openstack.org/521838 | 08:52 |
openstackgerrit | Harald Jensås proposed openstack/networking-baremetal master: Devstack - Add ironic-neutron-agent https://review.openstack.org/530117 | 08:52 |
openstackgerrit | Harald Jensås proposed openstack/networking-baremetal master: Add support to bind type vlan networks https://review.openstack.org/532349 | 08:52 |
openstackgerrit | Harald Jensås proposed openstack/networking-baremetal master: Add dsvm job https://review.openstack.org/530409 | 08:52 |
*** dsneddon has joined #openstack-ironic | 09:04 | |
*** dsneddon has quit IRC | 09:05 | |
*** dsneddon has joined #openstack-ironic | 09:07 | |
*** phuongnh has quit IRC | 09:07 | |
*** etingof has quit IRC | 09:17 | |
*** e0ne has joined #openstack-ironic | 09:23 | |
*** stendulker has joined #openstack-ironic | 09:24 | |
*** lucas-afk is now known as lucasagomes | 09:25 | |
*** hshiina has quit IRC | 09:27 | |
openstackgerrit | Shivanand Tendulker proposed openstack/ironic master: Adds RPC calls for rescue interface https://review.openstack.org/509336 | 09:29 |
openstackgerrit | Shivanand Tendulker proposed openstack/ironic master: Add rescue related methods to network interface https://review.openstack.org/509342 | 09:29 |
openstackgerrit | Shivanand Tendulker proposed openstack/ironic master: Add rescuewait timeout periodic task https://review.openstack.org/353156 | 09:29 |
openstackgerrit | Shivanand Tendulker proposed openstack/ironic master: Agent rescue implementation https://review.openstack.org/400437 | 09:29 |
*** derekh has joined #openstack-ironic | 09:39 | |
*** dtantsur|afk is now known as dtantsur | 09:42 | |
dtantsur | morning ironic | 09:42 |
*** gcb has quit IRC | 09:55 | |
*** milan_ has joined #openstack-ironic | 09:56 | |
*** etingof has joined #openstack-ironic | 09:56 | |
openstackgerrit | Ankit Kumar proposed openstack/ironic master: DNM Patch : Testing the HPEProliant CI https://review.openstack.org/533140 | 10:05 |
*** namnh has quit IRC | 10:15 | |
openstackgerrit | Madhuri Kumari proposed openstack/ironic-specs master: Add service management API for ironic https://review.openstack.org/471217 | 10:18 |
*** sambetts|afk is now known as sambetts | 10:23 | |
sambetts | Morning all | 10:23 |
*** MattMan_1 has quit IRC | 10:25 | |
*** MattMan_1 has joined #openstack-ironic | 10:25 | |
dtantsur | morning sambetts | 10:33 |
sambetts | hey dtantsur | 10:33 |
*** stendulker_ has joined #openstack-ironic | 10:36 | |
*** liuzz has quit IRC | 10:38 | |
*** stendulker has quit IRC | 10:40 | |
*** racedo has joined #openstack-ironic | 10:44 | |
*** stendulker_ has quit IRC | 10:44 | |
pas-ha | morning ironic :) TGIF! | 10:45 |
pas-ha | morning sambetts dtantsur | 10:45 |
dtantsur | hi pas-ha, TGIF indeed :) | 10:47 |
*** serlex has joined #openstack-ironic | 10:49 | |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic master: Handle case when a glance image contains no data https://review.openstack.org/531180 | 10:50 |
*** AlexeyAbashkin has quit IRC | 10:57 | |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic master: [WIP] Remove elilo support https://review.openstack.org/533153 | 11:01 |
dtantsur | would appreciate some early reviews ^^^ pas-ha maybe | 11:01 |
*** AlexeyAbashkin has joined #openstack-ironic | 11:12 | |
*** zhangfei has quit IRC | 11:22 | |
*** jaemin has joined #openstack-ironic | 11:27 | |
*** jaemin has quit IRC | 11:27 | |
openstackgerrit | brandon zhao proposed openstack/ironic master: Update links https://review.openstack.org/533159 | 11:30 |
*** zhangfei has joined #openstack-ironic | 11:39 | |
*** jkilpatr has quit IRC | 11:44 | |
*** dtantsur is now known as dtantsur|brb | 11:59 | |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic master: [WIP] Remove elilo support https://review.openstack.org/533153 | 11:59 |
openstackgerrit | Merged openstack/sushy-tools master: add dvsm CI job https://review.openstack.org/524560 | 12:05 |
openstackgerrit | Harald Jensås proposed openstack/networking-baremetal master: Add baremetal neutron agent https://review.openstack.org/456235 | 12:08 |
openstackgerrit | Harald Jensås proposed openstack/networking-baremetal master: Switch from MechanismDriver to SimpleAgentMechanismDriverBase https://review.openstack.org/521838 | 12:08 |
openstackgerrit | Harald Jensås proposed openstack/networking-baremetal master: Devstack - Add ironic-neutron-agent https://review.openstack.org/530117 | 12:08 |
openstackgerrit | Harald Jensås proposed openstack/networking-baremetal master: Add support to bind type vlan networks https://review.openstack.org/532349 | 12:08 |
openstackgerrit | Harald Jensås proposed openstack/networking-baremetal master: Add dsvm job https://review.openstack.org/530409 | 12:08 |
openstackgerrit | Harald Jensås proposed openstack/networking-baremetal master: Switch from MechanismDriver to SimpleAgentMechanismDriverBase https://review.openstack.org/521838 | 12:18 |
openstackgerrit | Harald Jensås proposed openstack/networking-baremetal master: Devstack - Add ironic-neutron-agent https://review.openstack.org/530117 | 12:18 |
openstackgerrit | Harald Jensås proposed openstack/networking-baremetal master: Add support to bind type vlan networks https://review.openstack.org/532349 | 12:18 |
openstackgerrit | Harald Jensås proposed openstack/networking-baremetal master: Add dsvm job https://review.openstack.org/530409 | 12:18 |
*** lucasagomes is now known as lucas-hungry | 12:26 | |
*** jkilpatr has joined #openstack-ironic | 12:26 | |
*** jaganathan has quit IRC | 12:27 | |
openstackgerrit | John Garbutt proposed openstack/ironic master: WIP: API: Node Traits API https://review.openstack.org/532269 | 12:41 |
*** hjensas has quit IRC | 12:51 | |
*** stendulker has joined #openstack-ironic | 12:53 | |
*** stendulker has quit IRC | 12:54 | |
*** stendulker has joined #openstack-ironic | 12:54 | |
*** hjensas has joined #openstack-ironic | 12:55 | |
*** jlabarre has joined #openstack-ironic | 13:01 | |
jroll | morning y'all | 13:04 |
*** Goneri has joined #openstack-ironic | 13:05 | |
*** absubram has quit IRC | 13:11 | |
*** lucas-hungry is now known as lucasagomes | 13:16 | |
*** dprince has joined #openstack-ironic | 13:21 | |
sambetts | o/ jroll | 13:22 |
*** dtantsur|brb is now known as dtantsur | 13:30 | |
dtantsur | morning jroll | 13:30 |
jroll | morning sambetts, dtantsur :) | 13:30 |
openstackgerrit | Merged openstack/ironic master: Node traits: Add DB API & model https://review.openstack.org/528238 | 13:31 |
*** yangyapeng has quit IRC | 13:32 | |
jroll | ! | 13:32 |
jroll | jlvillal: automatic rechecks? O_o | 13:33 |
*** trown|outtypewww is now known as trown | 13:36 | |
openstackgerrit | Dao Cong Tien proposed openstack/ironic master: CI job for rescue mode https://review.openstack.org/528704 | 13:43 |
openstackgerrit | Dao Cong Tien proposed openstack/ironic master: Add API methods for [un]rescue https://review.openstack.org/350831 | 13:44 |
*** sasha2 has joined #openstack-ironic | 13:58 | |
TheJulia | Good morning everyone | 13:59 |
sambetts | o/ TheJulia | 14:00 |
dtantsur | morning TheJulia | 14:00 |
*** yangyapeng has joined #openstack-ironic | 14:02 | |
*** rbudden has joined #openstack-ironic | 14:05 | |
openstackgerrit | Dao Cong Tien proposed openstack/ironic master: DNM: test rescue mode https://review.openstack.org/533187 | 14:05 |
jroll | morning TheJulia \o | 14:05 |
*** edleafe is now known as figleaf | 14:07 | |
TheJulia | dtantsur: the elilo removal looks exactly like what I thought it would be when I put the notes in | 14:09 |
TheJulia | dtantsur: minus a release note :) | 14:09 |
jroll | hm, we have an API to set traits on a node (replace existing, not add to). but we don't have an osc command for it? http://specs.openstack.org/openstack/ironic-specs/specs/not-implemented/node-traits.html#openstack-baremetal-cli | 14:14 |
jroll | seems intentional, but I feel like we should have `openstack baremetal node set --traits foo,bar` or something | 14:15 |
dtantsur | TheJulia: cool :) I'll wait for the CI, then fix tests and write the reno | 14:16 |
*** stendulker has quit IRC | 14:17 | |
TheJulia | awesome | 14:21 |
johnthetubaguy | jroll: good question, went around in circles on the CLI | 14:23 |
jroll | johnthetubaguy: we always do :/ | 14:23 |
johnthetubaguy | I was trying to see what was "normal" for similar things, can't remember what I found now | 14:24 |
jroll | afaik, we don't have any resources with arbitrary numbers of that resource | 14:24 |
jroll | so the semantics are different here | 14:25 |
johnthetubaguy | I was thinking other services, like nova tags, but don't think thats gone into OSC yet | 14:25 |
johnthetubaguy | the API was mostly taken from the API WG tag spec | 14:26 |
jroll | nod, makes sense | 14:26 |
johnthetubaguy | although seems like pecan might make it a touch different :/ seems like put needs a body? | 14:26 |
openstackgerrit | Julia Kreger proposed openstack/ironic master: Add additional context to contribution guide https://review.openstack.org/529681 | 14:26 |
jroll | I'll reserve my feelings on pecan/wsme | 14:27 |
jroll | the body can't be empty? | 14:27 |
*** hwoarang has quit IRC | 14:27 | |
johnthetubaguy | it can be empty, but has to be an empty dict | 14:27 |
johnthetubaguy | at least it seemed that way via the tests | 14:27 |
jroll | I was able to make a put endpoint and send it "" in my testing, I think | 14:27 |
johnthetubaguy | ah, so None certainly failed | 14:27 |
johnthetubaguy | didn't try "" | 14:28 |
jroll | er, no, I lied, I haven't tested that specifically | 14:28 |
johnthetubaguy | jroll: I didn't see a patch from you, but made some progress this morning | 14:28 |
jroll | cool | 14:28 |
jroll | I didn't get around to changing the server side at all yesterday | 14:28 |
johnthetubaguy | ah, no worries | 14:28 |
jroll | I can play with the PUT thing this morning though, so I can finish the cli | 14:28 |
*** hwoarang has joined #openstack-ironic | 14:29 | |
*** dyasny has joined #openstack-ironic | 14:29 | |
openstackgerrit | John Garbutt proposed openstack/ironic master: WIP: API: Node Traits API https://review.openstack.org/532269 | 14:30 |
openstackgerrit | John Garbutt proposed openstack/ironic master: Join nodes with traits https://review.openstack.org/530723 | 14:31 |
openstackgerrit | John Garbutt proposed openstack/ironic master: Add RPC object for traits https://review.openstack.org/532268 | 14:31 |
openstackgerrit | John Garbutt proposed openstack/ironic master: WIP: API: Node Traits API https://review.openstack.org/532269 | 14:32 |
johnthetubaguy | I lost my +W on this one, as I had to rebase, was getting conflicts | 14:32 |
johnthetubaguy | https://review.openstack.org/#/c/530723/4 | 14:32 |
patchbot | patch 530723 - ironic - Join nodes with traits | 14:32 |
TheJulia | johnthetubaguy fixed | 14:34 |
johnthetubaguy | TheJulia: thank you :) | 14:34 |
dtantsur | I don't quite like a few things there, but nothing critical | 14:36 |
*** crushil has joined #openstack-ironic | 14:36 | |
*** hwoarang_ has joined #openstack-ironic | 14:37 | |
TheJulia | dtantsur: simple enought to toss a quick follow-up up | 14:37 |
*** hwoarang has quit IRC | 14:38 | |
dtantsur | ugh, we don't have a job doing UEFI without iPXE? that's.. not great | 14:38 |
openstackgerrit | Mark Goddard proposed openstack/bifrost master: Add metadata version openstack/2015-10-15 https://review.openstack.org/533196 | 14:39 |
TheJulia | dtantsur: we have too many jobs as-is :( | 14:40 |
dtantsur | this is a completely different code path from anything else.. | 14:40 |
dtantsur | I'd better sacrifice something else | 14:40 |
* dtantsur looks at victims | 14:40 | |
*** ricardoas has quit IRC | 14:41 | |
TheJulia | dtantsur: limited to just pxe correct? | 14:41 |
openstackgerrit | Ilya Etingof proposed openstack/sushy-tools master: Abstract away the virtualization management interface https://review.openstack.org/523321 | 14:42 |
openstackgerrit | Ilya Etingof proposed openstack/sushy-tools master: OpenStack cloud driver added https://review.openstack.org/523879 | 14:42 |
openstackgerrit | Ilya Etingof proposed openstack/sushy-tools master: documentation on simulators added https://review.openstack.org/523445 | 14:42 |
TheJulia | dtantsur: or are you talking about local boot uefi | 14:42 |
*** athomas has quit IRC | 14:42 | |
dtantsur | we don't test local boot in the CI (sigh) | 14:42 |
*** athomas has joined #openstack-ironic | 14:43 | |
TheJulia | dtantsur: on a plus side, bifrost does when one of the jobs runs | 14:43 |
openstackgerrit | Madhuri Kumari proposed openstack/ironic-specs master: Add service management API for ironic https://review.openstack.org/471217 | 14:44 |
TheJulia | we likely ought to setup one of the bifrost jobs to be triggered, at least they execute in <20 minutes | 14:47 |
dtantsur | yeah | 14:49 |
* TheJulia fires off a re-test in the background to see if she has some of the more recent issues fixed :( | 14:50 | |
* TheJulia wishes she spent way more time on it back when she was at HPE | 14:51 | |
*** makowals has quit IRC | 15:00 | |
rpioso | Good morning, ironicers | 15:01 |
*** hwoarang_ has quit IRC | 15:07 | |
TheJulia | good morning rpioso | 15:18 |
openstackgerrit | Ilya Etingof proposed openstack/sushy-tools master: Abstract away the virtualization management interface https://review.openstack.org/523321 | 15:18 |
openstackgerrit | Ilya Etingof proposed openstack/sushy-tools master: OpenStack cloud driver added https://review.openstack.org/523879 | 15:18 |
openstackgerrit | Ilya Etingof proposed openstack/sushy-tools master: added system boot mode support https://review.openstack.org/526101 | 15:18 |
openstackgerrit | Ilya Etingof proposed openstack/sushy-tools master: added system boot mode support https://review.openstack.org/526101 | 15:19 |
*** zhangfei has quit IRC | 15:26 | |
*** rama_y has joined #openstack-ironic | 15:28 | |
*** dpawar has quit IRC | 15:30 | |
*** dansmith is now known as superdan | 15:31 | |
openstackgerrit | Julia Kreger proposed openstack/bifrost master: Fedora 25-27 support https://review.openstack.org/471750 | 15:31 |
*** AlexeyAbashkin has quit IRC | 15:34 | |
etingof | where would one report an RDO issue to? | 15:34 |
*** jtomasek has quit IRC | 15:36 | |
*** dpawar has joined #openstack-ironic | 15:37 | |
*** fragatina has joined #openstack-ironic | 15:38 | |
*** ijw has quit IRC | 15:39 | |
TheJulia | etingof: rdoproject.org? | 15:39 |
etingof | yep | 15:39 |
*** ijw has joined #openstack-ironic | 15:39 | |
rpioso | TheJulia: :) | 15:39 |
*** hwoarang has joined #openstack-ironic | 15:40 | |
jroll | is it normal that restarting ironic-api via systemd in devstack takes 30+ seconds? | 15:40 |
*** fragatina has quit IRC | 15:42 | |
*** dpawar has quit IRC | 15:42 | |
*** amarao has quit IRC | 15:43 | |
*** Goneri has quit IRC | 15:44 | |
*** amarao has joined #openstack-ironic | 15:44 | |
sambetts | jroll: :/ I've not seen it take that long before | 15:45 |
jroll | hm, thanks | 15:46 |
TheJulia | I've seen it take that before, but typically systemd was grumpy about something at that point | 15:46 |
TheJulia | crushil: you around? | 15:48 |
crushil | TheJulia, Yup | 15:48 |
TheJulia | crushil: looks like your driver shows merge conflict :( | 15:48 |
*** ricardoas has joined #openstack-ironic | 15:49 | |
*** ijw_ has joined #openstack-ironic | 15:49 | |
crushil | TheJulia, I see. Let me rebase it | 15:50 |
TheJulia | :9 | 15:50 |
TheJulia | err :( | 15:50 |
*** ijw has quit IRC | 15:52 | |
*** amarao has quit IRC | 15:52 | |
openstackgerrit | Rushil Chugh proposed openstack/ironic master: Add XClarity Driver https://review.openstack.org/519427 | 15:58 |
crushil | TheJulia, Rebased. Should be good to go now I think. :) | 15:59 |
NobodyCam | Good Morning Booters | 16:01 |
TheJulia | good morning | 16:01 |
hamzy | is there a way to show the returned information from an ironic introspection? I see a hardware_swift_object. Is there a way to dump that? | 16:01 |
TheJulia | core reviewers: fyi, the xclarity driver had 2x+2 before the rebase above. | 16:01 |
dtantsur | hamzy: openstack baremetal introspection data save <UUID> | 16:04 |
hamzy | dtantsur, thanks... that makes sense :) | 16:05 |
openstackgerrit | Rushil Chugh proposed openstack/ironic master: Add XClarity Driver https://review.openstack.org/519427 | 16:07 |
crushil | TheJulia, I had forgotten to fix the nit from the previous patch. That is fixed now as well | 16:08 |
TheJulia | crushil: awesome | 16:09 |
openstackgerrit | Michael Turek proposed openstack/ironic-python-agent master: Use lshw in place of dmidecode for the default hardware manager https://review.openstack.org/501799 | 16:09 |
*** radez has joined #openstack-ironic | 16:12 | |
jlvillal | jroll, Yeah I have a script where I give it a patch (or list of patches) and it will watch it and do automated rechecks. I use it sometimes. | 16:21 |
*** hoonetorg has quit IRC | 16:22 | |
jroll | jlvillal: pretty cool, though seems like it has the potential to be pretty wasteful of resources :/ | 16:34 |
jroll | and morning :) | 16:34 |
jlvillal | jroll, True and good morning :) | 16:34 |
*** jistr has quit IRC | 16:37 | |
*** dtantsur has quit IRC | 16:37 | |
*** bl0m1 has quit IRC | 16:37 | |
*** sapd_ has quit IRC | 16:37 | |
*** figleaf has quit IRC | 16:37 | |
*** asettle has quit IRC | 16:37 | |
*** bl0m1_ has joined #openstack-ironic | 16:37 | |
*** edleafe has joined #openstack-ironic | 16:37 | |
*** sapd_ has joined #openstack-ironic | 16:37 | |
*** asettle has joined #openstack-ironic | 16:37 | |
*** asettle is now known as Guest31532 | 16:37 | |
*** links has quit IRC | 16:38 | |
*** edleafe is now known as figleaf | 16:39 | |
*** hoonetorg has joined #openstack-ironic | 16:39 | |
*** jistr has joined #openstack-ironic | 16:40 | |
*** serlex has quit IRC | 16:40 | |
*** links has joined #openstack-ironic | 16:43 | |
-openstackstatus- NOTICE: Zuul has been restarted and lost queue information; changes in progress will need to be rechecked. | 16:45 | |
TheJulia | ugh | 16:45 |
jlvillal | :( | 16:45 |
*** milan_ has quit IRC | 16:45 | |
crushil | :( | 16:45 |
*** ijw_ has quit IRC | 16:47 | |
TheJulia | https://imgflip.com/i/22kih4 | 16:48 |
sambetts | TheJulia: :D | 16:49 |
openstackgerrit | Jim Rollenhagen proposed openstack/ironic master: wip add/delete single traits https://review.openstack.org/533241 | 16:51 |
jroll | this is breaking my brain ^ sambetts I'd love your insight if you have any ideas | 16:51 |
jroll | I'm gonna step away for a bit and have lunch and such though | 16:52 |
sambetts | jroll: whats up? | 16:52 |
jroll | sambetts: _lookup shenanigans | 16:52 |
jroll | I really have to step away though, sorry, I'll ping when I'm back | 16:53 |
sambetts | jroll: no problem | 16:53 |
johnthetubaguy | jroll: I did already add single updates a bit in my patch, did that not work? | 16:54 |
*** fragatina has joined #openstack-ironic | 16:54 | |
johnthetubaguy | I did wonder if I needed an extra controller | 16:54 |
johnthetubaguy | doing both puts seems hard :( | 16:54 |
sambetts | whats the API look like we're trying to expose? | 16:56 |
sambetts | PUT /node/<uuid>/traits BODY = {traits: []} and PUT /node/<uuid>/traits BODY = {trait:<trait>} or something?? | 16:57 |
sambetts | johnthetubaguy: ? | 16:58 |
johnthetubaguy | yeah | 16:59 |
johnthetubaguy | oh, wait, no | 16:59 |
johnthetubaguy | PUT /node/<uuid>/traits {traits: [....]} | 16:59 |
johnthetubaguy | PUT /node/<uuid>/traits/<trait-name> (no body) | 16:59 |
johnthetubaguy | one replaces all, the other just adds one | 17:00 |
johnthetubaguy | I got DELETE working OK | 17:00 |
sambetts | johnthetubaguy: so the why to support that is | 17:00 |
johnthetubaguy | API WG says we should, is the initial reason | 17:00 |
sambetts | way to support that in pacan is by using kwargs | 17:00 |
*** absubram has joined #openstack-ironic | 17:00 | |
johnthetubaguy | yeah, did that for DELETE, but it seemed to confuse things for PUT, but I probably just screwed that up somehow | 17:01 |
*** rama_y has quit IRC | 17:02 | |
sambetts | johnthetubaguy: PUT should be for updating an existing record not adding anything though :/ | 17:03 |
johnthetubaguy | right, it is here | 17:03 |
johnthetubaguy | it in place update of existing thing | 17:03 |
*** pcaruana has quit IRC | 17:03 | |
johnthetubaguy | reference is: http://specs.openstack.org/openstack/api-wg/guidelines/tags.html#addressing-individual-tags | 17:03 |
sambetts | but the existing thing is the thing :/ | 17:04 |
*** cjloader has quit IRC | 17:04 | |
sambetts | PUT /node/<uuid>/traits/<key> BODY = value | 17:04 |
johnthetubaguy | there is no key value, just a key | 17:05 |
johnthetubaguy | or just a value I guess | 17:05 |
sambetts | which is why PUT breaks resourceful REST in this case :( | 17:06 |
johnthetubaguy | I guess patch is the other way | 17:06 |
sambetts | johnthetubaguy: I think, you might be about to do def put(self, trait=None, traits=None) to support both in pecan | 17:07 |
*** cjloader has joined #openstack-ironic | 17:07 | |
*** fragatina has quit IRC | 17:07 | |
sambetts | jroll: ^ | 17:07 |
johnthetubaguy | I can try that | 17:07 |
sambetts | when it does URL only it'll populate the fields in order, so <trait> from the url will fill out the trait parameter | 17:07 |
*** fragatina has joined #openstack-ironic | 17:07 | |
johnthetubaguy | I guess we must supply and empty body though | 17:07 |
sambetts | traits will only be populated if "traits:" is in the body so we can check if both are set error | 17:08 |
johnthetubaguy | its just the validation requires {} to be sent I think | 17:09 |
sambetts | if anything other than trait: or traits: is in the body it'll blow up anyway I believe because the keys in the body doesn't match the paramters | 17:09 |
johnthetubaguy | will double check that | 17:09 |
sambetts | an empty json body will be fine I think | 17:09 |
TheJulia | Dmitry asked me to convey to everyone to have a good weekend. He can't seem to reconnect to irc right now | 17:10 |
sambetts | johnthetubaguy: it means we'll also support: PUT /node/<uuid>/traits BODY: {trait: <trait>} though | 17:10 |
*** Goneri has joined #openstack-ironic | 17:10 | |
sambetts | but I don't think thats a bad thing :/ | 17:10 |
*** tesseract has quit IRC | 17:12 | |
*** AlexeyAbashkin has joined #openstack-ironic | 17:12 | |
*** AlexeyAbashkin has quit IRC | 17:17 | |
johnthetubaguy | sambetts: sweet that appears to work, totally didn't think about that option for some reason | 17:19 |
openstackgerrit | John Garbutt proposed openstack/ironic master: WIP: API: Node Traits API https://review.openstack.org/532269 | 17:19 |
johnthetubaguy | jroll: I think that roughly works ^ | 17:19 |
sambetts | johnthetubaguy: no problem :) pecan has some weird behaviours | 17:19 |
johnthetubaguy | I see what people meant about it now | 17:20 |
johnthetubaguy | really liking what cdent has working for placement in nova land | 17:20 |
johnthetubaguy | routing is a dict, pointing to functions | 17:20 |
sambetts | johnthetubaguy: whats he using for that? flask?? | 17:20 |
*** AlexeyAbashkin has joined #openstack-ironic | 17:21 | |
sambetts | flask is nice because you just decorate function with the URL you want that function to be exposed on | 17:21 |
johnthetubaguy | not sure we use ansyhting | 17:21 |
johnthetubaguy | anything | 17:21 |
sambetts | johnthetubaguy: flask: https://github.com/openstack/ironic-inspector/blob/master/ironic_inspector/main.py#L203 | 17:22 |
johnthetubaguy | https://github.com/openstack/nova/blob/master/nova/api/openstack/placement/handler.py#L52 | 17:22 |
sambetts | johnthetubaguy: thats what I was used too when I worked on ruby on rails stuff, one location that defines all the routes IMO is much cleaner to understand: https://github.com/CiscoSystems/curvature/blob/bafa387773a0236ada6bec73fc3e320f408cf1e5/config/routes.rb | 17:24 |
*** links has quit IRC | 17:24 | |
johnthetubaguy | sambetts: yeah, so much neater | 17:24 |
johnthetubaguy | well for REST APIs it seems great | 17:25 |
jroll | sambetts: johnthetubaguy: I'm fairly convinced the way we just did that in one controller will allow /node/<uuid>/traits BODY = {trait:<trait>} | 17:25 |
sambetts | jroll: it will | 17:25 |
jroll | which is why I was trying to do a separate thing | 17:25 |
*** AlexeyAbashkin has quit IRC | 17:25 | |
jroll | yeah, so two ways to do one thing, makes people into sad pandas | 17:26 |
* jroll wonders if he's allowed to rewrite our entire API backend yet | 17:26 | |
johnthetubaguy | yeah, not sure I like the extra bonus features | 17:28 |
johnthetubaguy | but I feel closer to the spec than I was this morning | 17:28 |
sambetts | jroll: personally I'd prefer to expose {trait:<trait>} and not PUT /node/<uuid>/traits/<trait> because the second one isn't actually a valid resourceful API, but what do I know API wg | 17:28 |
sambetts | says the other | 17:28 |
jroll | yerp | 17:28 |
johnthetubaguy | its the pragmatic need to update individual tags I think | 17:29 |
johnthetubaguy | rather than always updating the full list | 17:29 |
johnthetubaguy | nasty races in your scripts if you always update the full list | 17:29 |
jroll | yeah, I tend to think POST for all and PUT for one makes more sense, but that's just me | 17:29 |
sambetts | thats what patch is for though I thought | 17:29 |
jroll | or that | 17:30 |
johnthetubaguy | true, be must people seem to hate patch, not sure why | 17:30 |
johnthetubaguy | s/be/but/ | 17:30 |
sambetts | :/ yeah | 17:30 |
*** marios has quit IRC | 17:30 | |
jroll | anyway, I worry about trait=foo in the body, because you're a single keystroke away from blowing up the rest of your traits | 17:30 |
sambetts | jroll: we could detect if it came from the body or not | 17:31 |
johnthetubaguy | jroll: yeah | 17:31 |
johnthetubaguy | sambetts: ah, good point, request has those details I guess | 17:31 |
sambetts | and manually throw an error if it did | 17:31 |
sambetts | seems the neater solution instead of adding a new controller | 17:31 |
sambetts | or at least seems to use as much of pecan's own logic as possible, and then we just cut out the case | 17:32 |
sambetts | we don't want | 17:32 |
sambetts | well two cases actually: both trait and traits can't be set, and trait can't come from the body | 17:33 |
sambetts | otherwise you could do PUT /node/<uuid>/traits/<trait> {traits: [....]} which doesn't make any sense | 17:33 |
jroll | heh | 17:33 |
jroll | yeah, seems like it's a couple hacks either way | 17:34 |
johnthetubaguy | yeah, I already killed that one | 17:34 |
jroll | I feel like _lookup might be "more right" because it's keeping all the handling in the routing methods | 17:34 |
jroll | but not super opinionated | 17:34 |
*** absubram has quit IRC | 17:34 | |
johnthetubaguy | by the way, it seems very easy to get 500 errors with badly formed requests, or is that just me? | 17:35 |
sambetts | :/ | 17:36 |
jroll | I haven't got much of that with existing code, but getting lots of it messing around with new code here | 17:36 |
rpioso | I'd like to know if any of our projects use anything that is or resembles an enumeration. | 17:36 |
sambetts | rpioso: ironic-inspector has an enum for states | 17:37 |
sambetts | rpioso: we orignally used a library to add it, but then just used a class instead https://github.com/openstack/ironic-inspector/blob/master/ironic_inspector/introspection_state.py#L19 | 17:38 |
sambetts | if thats what you mean | 17:38 |
sambetts | python doesn't have its own built in enum type | 17:38 |
jroll | oh, but it does! | 17:39 |
jroll | https://docs.python.org/3/library/enum.html | 17:39 |
jroll | py3 to the rescue :P | 17:39 |
sambetts | well it does now ;) | 17:39 |
rpioso | sambetts: Thank you. I'll play with that approach to determines if it provides what I'm looking for. | 17:40 |
openstackgerrit | John Garbutt proposed openstack/ironic master: WIP: API: Node Traits API https://review.openstack.org/532269 | 17:40 |
rpioso | jroll, sambetts: The py3 enum does :) | 17:40 |
johnthetubaguy | jroll: sambetts: https://review.openstack.org/#/c/532269/8..9 | 17:41 |
patchbot | patch 532269 - ironic - WIP: API: Node Traits API | 17:41 |
*** AlexeyAbashkin has joined #openstack-ironic | 17:42 | |
rpioso | jroll, sambetts: There's also an enum32 package that has been backported to py2.7. I haven't played with that, yet. | 17:42 |
jroll | johnthetubaguy: yeah, that would do it :) | 17:42 |
sambetts | johnthetubaguy: looks good :) | 17:42 |
* johnthetubaguy bashes pecan with nut cracker | 17:42 | |
sambetts | haha | 17:42 |
TheJulia | lol | 17:43 |
*** AlexeyAbashkin has quit IRC | 17:44 | |
openstackgerrit | Hugo Nicodemos proposed openstack/ironic master: Remove python-oneviewclient from oneview hardware type. https://review.openstack.org/524729 | 17:44 |
rpioso | sambetts: That idiom might just meet the need. Thanks, again. | 17:45 |
sambetts | rpioso: no problem :) | 17:46 |
*** cjloader has quit IRC | 17:49 | |
*** cjloader has joined #openstack-ironic | 17:50 | |
TheJulia | bbiab, need to run to the bank | 17:51 |
*** penick has joined #openstack-ironic | 17:56 | |
*** trown is now known as trown|lunch | 17:56 | |
*** e0ne has quit IRC | 17:56 | |
*** ijw has joined #openstack-ironic | 17:57 | |
*** derekh has quit IRC | 17:58 | |
*** ijw has quit IRC | 18:02 | |
*** lucasagomes is now known as lucas-afk | 18:07 | |
*** cjloader has quit IRC | 18:07 | |
openstackgerrit | Merged openstack/python-ironicclient master: Use StrictVersion to compare versions https://review.openstack.org/532754 | 18:08 |
*** cjloader has joined #openstack-ironic | 18:08 | |
*** ijw has joined #openstack-ironic | 18:12 | |
*** ijw has quit IRC | 18:13 | |
*** athomas has quit IRC | 18:20 | |
*** cjloader has quit IRC | 18:28 | |
*** cjloader has joined #openstack-ironic | 18:29 | |
openstackgerrit | John Garbutt proposed openstack/ironic master: WIP: API: Node Traits API https://review.openstack.org/532269 | 18:34 |
*** mariojv has quit IRC | 18:34 | |
*** ricardoas is now known as ricardoas-away | 18:34 | |
*** mariojv has joined #openstack-ironic | 18:34 | |
*** yee379 has joined #openstack-ironic | 18:36 | |
*** amotoki has quit IRC | 18:37 | |
*** yee37932 has quit IRC | 18:38 | |
*** amotoki has joined #openstack-ironic | 18:39 | |
*** cjloader has quit IRC | 18:48 | |
*** jkilpatr has quit IRC | 18:49 | |
*** dtantsur has joined #openstack-ironic | 18:50 | |
*** cjloader has joined #openstack-ironic | 18:52 | |
*** rmcall has joined #openstack-ironic | 18:54 | |
*** rmcall has quit IRC | 18:59 | |
*** jkilpatr has joined #openstack-ironic | 19:02 | |
*** sambetts is now known as sambetts|afk | 19:09 | |
sambetts|afk | night all | 19:09 |
crushil | night sambetts|afk | 19:12 |
*** dyasny has quit IRC | 19:13 | |
*** penick has quit IRC | 19:14 | |
*** penick has joined #openstack-ironic | 19:20 | |
*** trown|lunch is now known as trown | 19:22 | |
*** baha has joined #openstack-ironic | 19:23 | |
*** AlexeyAbashkin has joined #openstack-ironic | 19:25 | |
*** harlowja has joined #openstack-ironic | 19:27 | |
*** ijw has joined #openstack-ironic | 19:33 | |
*** ijw has quit IRC | 19:34 | |
*** ijw has joined #openstack-ironic | 19:35 | |
*** AlexeyAbashkin has quit IRC | 19:42 | |
*** cjloader has quit IRC | 19:48 | |
*** dsneddon is now known as dsneddon_afk | 19:53 | |
* TheJulia burries her brain back into reviews | 19:54 | |
*** cjloader has joined #openstack-ironic | 19:55 | |
crushil | TheJulia, Around? | 20:00 |
TheJulia | at least 3.35% of my brain is :) | 20:01 |
TheJulia | whats up? | 20:01 |
crushil | haha | 20:02 |
*** harlowja has quit IRC | 20:04 | |
TheJulia | Any core reviewers around? I know crushil would appreciate | 20:05 |
TheJulia | https://review.openstack.org/#/c/519427/ merging :) | 20:05 |
patchbot | patch 519427 - ironic - Add XClarity Driver | 20:05 |
crushil | Thanks TheJulia | 20:09 |
TheJulia | While on the subject of drivers, oneview CI seems to be passing and their client change patches are passing as well. | 20:12 |
TheJulia | I removed my -1 on their first few patches and have changed my vote accordingly | 20:20 |
*** fragatina has quit IRC | 20:38 | |
*** cjloader has quit IRC | 20:38 | |
*** cjloader has joined #openstack-ironic | 20:39 | |
*** openstackstatus has quit IRC | 20:46 | |
*** openstack has joined #openstack-ironic | 20:48 | |
*** ChanServ sets mode: +o openstack | 20:48 | |
*** srart has quit IRC | 20:56 | |
*** srart has joined #openstack-ironic | 21:03 | |
openstackgerrit | Jim Rollenhagen proposed openstack/python-ironicclient master: WIP: traits in client https://review.openstack.org/532622 | 21:06 |
*** dyasny has joined #openstack-ironic | 21:14 | |
*** racedo has quit IRC | 21:20 | |
*** harlowja has joined #openstack-ironic | 21:25 | |
*** harlowja has joined #openstack-ironic | 21:26 | |
*** penick has quit IRC | 21:28 | |
*** rbudden has quit IRC | 21:43 | |
*** r-daneel has joined #openstack-ironic | 21:52 | |
*** cjloader has quit IRC | 21:56 | |
*** racedo has joined #openstack-ironic | 21:58 | |
*** dprince has quit IRC | 22:01 | |
*** baha has quit IRC | 22:04 | |
openstackgerrit | Jim Rollenhagen proposed openstack/python-ironicclient master: Traits support https://review.openstack.org/532622 | 22:07 |
*** trown is now known as trown|outtypewww | 22:07 | |
*** fragatina has joined #openstack-ironic | 22:08 | |
*** etingof has quit IRC | 22:13 | |
openstackgerrit | Julia Kreger proposed openstack/python-ironicclient master: Facilitate latest Rest API use https://review.openstack.org/531029 | 22:13 |
openstackgerrit | Julia Kreger proposed openstack/python-ironicclient master: Allow API user to define list of versions https://review.openstack.org/531271 | 22:13 |
openstackgerrit | Julia Kreger proposed openstack/python-ironicclient master: Raise exception for unsupported microversion https://review.openstack.org/532979 | 22:13 |
*** crushil has quit IRC | 22:17 | |
*** fragatina has quit IRC | 22:28 | |
*** fragatina has joined #openstack-ironic | 22:28 | |
*** weshay is now known as weshay_PTO | 22:29 | |
*** jlabarre has quit IRC | 22:32 | |
*** fragatina has quit IRC | 22:33 | |
*** jkilpatr has joined #openstack-ironic | 22:34 | |
*** fragatina has joined #openstack-ironic | 22:35 | |
*** dsneddon_afk is now known as dsneddon | 22:41 | |
openstackgerrit | Julia Kreger proposed openstack/ironic-lib master: Add wait_for_disk to destroy_disk_metadata function https://review.openstack.org/529325 | 22:50 |
TheJulia | jlvillal: Take a look and see if that works. Something is up with fuser on my machine :\ | 22:51 |
*** AlexeyAbashkin has joined #openstack-ironic | 22:54 | |
*** etingof has joined #openstack-ironic | 22:55 | |
*** AlexeyAbashkin has quit IRC | 22:59 | |
*** racedo has quit IRC | 22:59 | |
*** figleaf is now known as edleafe | 22:59 | |
*** harlowja has quit IRC | 23:01 | |
*** etingof has quit IRC | 23:28 | |
*** etingof has joined #openstack-ironic | 23:29 | |
*** r-daneel has quit IRC | 23:35 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!