Friday, 2018-01-12

*** dsneddon has quit IRC00:05
*** hshiina has joined #openstack-ironic00:26
openstackgerritHarald Jensås proposed openstack/networking-baremetal master: Add dsvm job  https://review.openstack.org/53040900:28
*** yangyapeng has quit IRC00:30
*** yangyapeng has joined #openstack-ironic00:30
*** yangyapeng has quit IRC00:34
*** bfournie has joined #openstack-ironic00:35
*** bfournie has quit IRC00:37
*** rama_y has quit IRC00:38
*** bfournie has joined #openstack-ironic00:43
*** threestrands has quit IRC00:58
*** threestrands has joined #openstack-ironic01:02
*** etingof has quit IRC01:03
*** threestrands has quit IRC01:03
*** threestrands has joined #openstack-ironic01:04
*** bfournie has left #openstack-ironic01:07
*** phuongnh has joined #openstack-ironic01:11
*** threestrands has quit IRC01:11
*** jlabarre has quit IRC01:13
*** hamzy has joined #openstack-ironic01:17
*** dpawar has joined #openstack-ironic01:19
*** dpawar has quit IRC01:20
*** dpawar has joined #openstack-ironic01:20
*** yangyapeng has joined #openstack-ironic01:21
*** threestrands has joined #openstack-ironic01:24
*** threestrands has quit IRC01:24
*** threestrands has joined #openstack-ironic01:24
*** threestrands has quit IRC01:25
*** threestrands has joined #openstack-ironic01:26
openstackgerritMerged openstack/ironic-inspector master: Fix Py2/Py3 differences in write locking code  https://review.openstack.org/53257901:27
tonybSo I'd like to stash some data about my nodes to help me later map nodes to images.  Can I create arbitrary keys under /properties?01:27
jrolltonyb: in theory, yeah, though it's recommended to use /extra for that instead. /extra is for operators :)01:33
tonybjroll: Thanks01:35
jrollyep, no problem :)01:35
tonybjroll: for the record it's the cpu sub-model to help select 'optimised' (read ones that will work) deploy kernel+initrds01:37
jrolltonyb: sure, let me put it this way - we promise not to write anything in node.extra (except one legacy key iirc, that might be gone now). we might write node.properties. proceed with caution :P01:38
tonyb:)01:38
*** etingof has joined #openstack-ironic01:43
*** dpawar has quit IRC01:53
*** threestrands has quit IRC01:54
*** charcol has quit IRC01:55
*** threestrands has joined #openstack-ironic01:56
*** charcol has joined #openstack-ironic01:58
*** bfournie has joined #openstack-ironic02:02
*** pmannidi has joined #openstack-ironic02:15
TheJuliajroll: tonyb: we still support reading the vif id out of node.extra, but that is it.02:26
tonybTheJulia: Thanks02:27
*** ijw has quit IRC02:43
phuongnhhi TheJulia02:44
phuongnhI would like to upload another patchset same as as  https://review.openstack.org/#/c/511494/ but for CentOS02:44
patchbotpatch 511494 - diskimage-builder - Add iscsi-boot element02:44
*** sasha2 has quit IRC02:44
phuongnhshoud I propose a RFE or bug first?02:45
phuongnhor use the same bug number #1716794?02:45
TheJuliaphuongnh: dib is outside our scope, I would say just propose it, but adding on top of the already proposed patch02:50
phuongnhso will I propose new RFE with proposed patch on top?02:52
TheJuliaNo RFE, just propose the patch.02:55
TheJuliaJust explain in the purpose in the commit message, and you should have a review or two and further instructions then.02:56
phuongnhI see, I will put more information on commit message03:00
phuongnhthanks03:00
*** ptx0 has quit IRC03:11
*** amotoki has joined #openstack-ironic03:30
*** fragatina has quit IRC03:37
*** ptx0 has joined #openstack-ironic03:38
*** rbudden has quit IRC03:44
*** tzumainn has joined #openstack-ironic04:18
*** rama_y has joined #openstack-ironic04:27
*** links has joined #openstack-ironic04:31
*** pmannidi has quit IRC04:38
*** tzumainn has quit IRC04:40
*** mjturek has joined #openstack-ironic04:41
*** mjturek has quit IRC04:46
*** namnh has joined #openstack-ironic04:51
*** ijw has joined #openstack-ironic04:57
*** pmannidi has joined #openstack-ironic05:00
*** ijw has quit IRC05:01
*** dpawar has joined #openstack-ironic05:19
*** absubram has joined #openstack-ironic05:23
*** absubram has quit IRC05:23
*** liuzz has joined #openstack-ironic05:42
*** ijw has joined #openstack-ironic05:45
*** ijw has quit IRC05:49
*** ijw has joined #openstack-ironic05:49
*** fragatina has joined #openstack-ironic06:00
*** fragatina has quit IRC06:04
*** marios has joined #openstack-ironic06:25
*** absubram has joined #openstack-ironic06:26
*** cjloader has joined #openstack-ironic06:30
*** cjloader has quit IRC06:33
*** charcol has quit IRC06:33
*** cjloader_ has joined #openstack-ironic06:34
*** cjloader_ is now known as cjloader06:35
*** harlowja has quit IRC06:35
*** rama_y has quit IRC06:42
*** ijw has quit IRC06:46
*** pmannidi has quit IRC06:51
*** phuongnh has quit IRC06:58
*** hieulq has quit IRC06:58
*** hieulq has joined #openstack-ironic06:59
*** phuongnh has joined #openstack-ironic06:59
openstackgerritOpenStack Proposal Bot proposed openstack/ironic-inspector master: Imported Translations from Zanata  https://review.openstack.org/53310007:04
*** harlowja has joined #openstack-ironic07:10
*** harlowja has quit IRC07:10
*** rcernin has quit IRC07:28
*** pcaruana has joined #openstack-ironic07:29
*** makowals has quit IRC07:42
*** ijw has joined #openstack-ironic07:43
*** sapd_ has joined #openstack-ironic07:54
*** threestrands has quit IRC07:56
*** ptx0 has quit IRC07:58
*** ptx0 has joined #openstack-ironic08:01
*** tesseract has joined #openstack-ironic08:08
*** zhangfei has joined #openstack-ironic08:13
*** jtomasek has joined #openstack-ironic08:14
*** jtomasek has quit IRC08:14
*** jtomasek has joined #openstack-ironic08:15
*** makowals has joined #openstack-ironic08:16
*** AlexeyAbashkin has joined #openstack-ironic08:23
*** amarao has joined #openstack-ironic08:38
openstackgerritHarald Jensås proposed openstack/networking-baremetal master: Switch from MechanismDriver to SimpleAgentMechanismDriverBase  https://review.openstack.org/52183808:52
openstackgerritHarald Jensås proposed openstack/networking-baremetal master: Devstack - Add ironic-neutron-agent  https://review.openstack.org/53011708:52
openstackgerritHarald Jensås proposed openstack/networking-baremetal master: Add support to bind type vlan networks  https://review.openstack.org/53234908:52
openstackgerritHarald Jensås proposed openstack/networking-baremetal master: Add dsvm job  https://review.openstack.org/53040908:52
*** dsneddon has joined #openstack-ironic09:04
*** dsneddon has quit IRC09:05
*** dsneddon has joined #openstack-ironic09:07
*** phuongnh has quit IRC09:07
*** etingof has quit IRC09:17
*** e0ne has joined #openstack-ironic09:23
*** stendulker has joined #openstack-ironic09:24
*** lucas-afk is now known as lucasagomes09:25
*** hshiina has quit IRC09:27
openstackgerritShivanand Tendulker proposed openstack/ironic master: Adds RPC calls for rescue interface  https://review.openstack.org/50933609:29
openstackgerritShivanand Tendulker proposed openstack/ironic master: Add rescue related methods to network interface  https://review.openstack.org/50934209:29
openstackgerritShivanand Tendulker proposed openstack/ironic master: Add rescuewait timeout periodic task  https://review.openstack.org/35315609:29
openstackgerritShivanand Tendulker proposed openstack/ironic master: Agent rescue implementation  https://review.openstack.org/40043709:29
*** derekh has joined #openstack-ironic09:39
*** dtantsur|afk is now known as dtantsur09:42
dtantsurmorning ironic09:42
*** gcb has quit IRC09:55
*** milan_ has joined #openstack-ironic09:56
*** etingof has joined #openstack-ironic09:56
openstackgerritAnkit Kumar proposed openstack/ironic master: DNM Patch : Testing the HPEProliant CI  https://review.openstack.org/53314010:05
*** namnh has quit IRC10:15
openstackgerritMadhuri Kumari proposed openstack/ironic-specs master: Add service management API for ironic  https://review.openstack.org/47121710:18
*** sambetts|afk is now known as sambetts10:23
sambettsMorning all10:23
*** MattMan_1 has quit IRC10:25
*** MattMan_1 has joined #openstack-ironic10:25
dtantsurmorning sambetts10:33
sambettshey dtantsur10:33
*** stendulker_ has joined #openstack-ironic10:36
*** liuzz has quit IRC10:38
*** stendulker has quit IRC10:40
*** racedo has joined #openstack-ironic10:44
*** stendulker_ has quit IRC10:44
pas-hamorning ironic :) TGIF!10:45
pas-hamorning sambetts dtantsur10:45
dtantsurhi pas-ha, TGIF indeed :)10:47
*** serlex has joined #openstack-ironic10:49
openstackgerritDmitry Tantsur proposed openstack/ironic master: Handle case when a glance image contains no data  https://review.openstack.org/53118010:50
*** AlexeyAbashkin has quit IRC10:57
openstackgerritDmitry Tantsur proposed openstack/ironic master: [WIP] Remove elilo support  https://review.openstack.org/53315311:01
dtantsurwould appreciate some early reviews ^^^ pas-ha maybe11:01
*** AlexeyAbashkin has joined #openstack-ironic11:12
*** zhangfei has quit IRC11:22
*** jaemin has joined #openstack-ironic11:27
*** jaemin has quit IRC11:27
openstackgerritbrandon zhao proposed openstack/ironic master: Update links  https://review.openstack.org/53315911:30
*** zhangfei has joined #openstack-ironic11:39
*** jkilpatr has quit IRC11:44
*** dtantsur is now known as dtantsur|brb11:59
openstackgerritDmitry Tantsur proposed openstack/ironic master: [WIP] Remove elilo support  https://review.openstack.org/53315311:59
openstackgerritMerged openstack/sushy-tools master: add dvsm CI job  https://review.openstack.org/52456012:05
openstackgerritHarald Jensås proposed openstack/networking-baremetal master: Add baremetal neutron agent  https://review.openstack.org/45623512:08
openstackgerritHarald Jensås proposed openstack/networking-baremetal master: Switch from MechanismDriver to SimpleAgentMechanismDriverBase  https://review.openstack.org/52183812:08
openstackgerritHarald Jensås proposed openstack/networking-baremetal master: Devstack - Add ironic-neutron-agent  https://review.openstack.org/53011712:08
openstackgerritHarald Jensås proposed openstack/networking-baremetal master: Add support to bind type vlan networks  https://review.openstack.org/53234912:08
openstackgerritHarald Jensås proposed openstack/networking-baremetal master: Add dsvm job  https://review.openstack.org/53040912:08
openstackgerritHarald Jensås proposed openstack/networking-baremetal master: Switch from MechanismDriver to SimpleAgentMechanismDriverBase  https://review.openstack.org/52183812:18
openstackgerritHarald Jensås proposed openstack/networking-baremetal master: Devstack - Add ironic-neutron-agent  https://review.openstack.org/53011712:18
openstackgerritHarald Jensås proposed openstack/networking-baremetal master: Add support to bind type vlan networks  https://review.openstack.org/53234912:18
openstackgerritHarald Jensås proposed openstack/networking-baremetal master: Add dsvm job  https://review.openstack.org/53040912:18
*** lucasagomes is now known as lucas-hungry12:26
*** jkilpatr has joined #openstack-ironic12:26
*** jaganathan has quit IRC12:27
openstackgerritJohn Garbutt proposed openstack/ironic master: WIP: API: Node Traits API  https://review.openstack.org/53226912:41
*** hjensas has quit IRC12:51
*** stendulker has joined #openstack-ironic12:53
*** stendulker has quit IRC12:54
*** stendulker has joined #openstack-ironic12:54
*** hjensas has joined #openstack-ironic12:55
*** jlabarre has joined #openstack-ironic13:01
jrollmorning y'all13:04
*** Goneri has joined #openstack-ironic13:05
*** absubram has quit IRC13:11
*** lucas-hungry is now known as lucasagomes13:16
*** dprince has joined #openstack-ironic13:21
sambettso/ jroll13:22
*** dtantsur|brb is now known as dtantsur13:30
dtantsurmorning jroll13:30
jrollmorning sambetts, dtantsur :)13:30
openstackgerritMerged openstack/ironic master: Node traits: Add DB API & model  https://review.openstack.org/52823813:31
*** yangyapeng has quit IRC13:32
jroll!13:32
jrolljlvillal: automatic rechecks? O_o13:33
*** trown|outtypewww is now known as trown13:36
openstackgerritDao Cong Tien proposed openstack/ironic master: CI job for rescue mode  https://review.openstack.org/52870413:43
openstackgerritDao Cong Tien proposed openstack/ironic master: Add API methods for [un]rescue  https://review.openstack.org/35083113:44
*** sasha2 has joined #openstack-ironic13:58
TheJuliaGood morning everyone13:59
sambettso/ TheJulia14:00
dtantsurmorning TheJulia14:00
*** yangyapeng has joined #openstack-ironic14:02
*** rbudden has joined #openstack-ironic14:05
openstackgerritDao Cong Tien proposed openstack/ironic master: DNM: test rescue mode  https://review.openstack.org/53318714:05
jrollmorning TheJulia \o14:05
*** edleafe is now known as figleaf14:07
TheJuliadtantsur: the elilo removal looks exactly like what I thought it would be when I put the notes in14:09
TheJuliadtantsur: minus a release note :)14:09
jrollhm, we have an API to set traits on a node (replace existing, not add to). but we don't have an osc command for it? http://specs.openstack.org/openstack/ironic-specs/specs/not-implemented/node-traits.html#openstack-baremetal-cli14:14
jrollseems intentional, but I feel like we should have `openstack baremetal node set --traits foo,bar` or something14:15
dtantsurTheJulia: cool :) I'll wait for the CI, then fix tests and write the reno14:16
*** stendulker has quit IRC14:17
TheJuliaawesome14:21
johnthetubaguyjroll: good question, went around in circles on the CLI14:23
jrolljohnthetubaguy: we always do :/14:23
johnthetubaguyI was trying to see what was "normal" for similar things, can't remember what I found now14:24
jrollafaik, we don't have any resources with arbitrary numbers of that resource14:24
jrollso the semantics are different here14:25
johnthetubaguyI was thinking other services, like nova tags, but don't think thats gone into OSC yet14:25
johnthetubaguythe API was mostly taken from the API WG tag spec14:26
jrollnod, makes sense14:26
johnthetubaguyalthough seems like pecan might make it a touch different :/ seems like put needs a body?14:26
openstackgerritJulia Kreger proposed openstack/ironic master: Add additional context to contribution guide  https://review.openstack.org/52968114:26
jrollI'll reserve my feelings on pecan/wsme14:27
jrollthe body can't be empty?14:27
*** hwoarang has quit IRC14:27
johnthetubaguyit can be empty, but has to be an empty dict14:27
johnthetubaguyat least it seemed that way via the tests14:27
jrollI was able to make a put endpoint and send it "" in my testing, I think14:27
johnthetubaguyah, so None certainly failed14:27
johnthetubaguydidn't try ""14:28
jroller, no, I lied, I haven't tested that specifically14:28
johnthetubaguyjroll: I didn't see a patch from you, but made some progress this morning14:28
jrollcool14:28
jrollI didn't get around to changing the server side at all yesterday14:28
johnthetubaguyah, no worries14:28
jrollI can play with the PUT thing this morning though, so I can finish the cli14:28
*** hwoarang has joined #openstack-ironic14:29
*** dyasny has joined #openstack-ironic14:29
openstackgerritJohn Garbutt proposed openstack/ironic master: WIP: API: Node Traits API  https://review.openstack.org/53226914:30
openstackgerritJohn Garbutt proposed openstack/ironic master: Join nodes with traits  https://review.openstack.org/53072314:31
openstackgerritJohn Garbutt proposed openstack/ironic master: Add RPC object for traits  https://review.openstack.org/53226814:31
openstackgerritJohn Garbutt proposed openstack/ironic master: WIP: API: Node Traits API  https://review.openstack.org/53226914:32
johnthetubaguyI lost my +W on this one, as I had to rebase, was getting conflicts14:32
johnthetubaguyhttps://review.openstack.org/#/c/530723/414:32
patchbotpatch 530723 - ironic - Join nodes with traits14:32
TheJulia johnthetubaguy fixed14:34
johnthetubaguyTheJulia: thank you :)14:34
dtantsurI don't quite like a few things there, but nothing critical14:36
*** crushil has joined #openstack-ironic14:36
*** hwoarang_ has joined #openstack-ironic14:37
TheJuliadtantsur: simple enought to toss a quick follow-up up14:37
*** hwoarang has quit IRC14:38
dtantsurugh, we don't have a job doing UEFI without iPXE? that's.. not great14:38
openstackgerritMark Goddard proposed openstack/bifrost master: Add metadata version openstack/2015-10-15  https://review.openstack.org/53319614:39
TheJuliadtantsur: we have too many jobs as-is :(14:40
dtantsurthis is a completely different code path from anything else..14:40
dtantsurI'd better sacrifice something else14:40
* dtantsur looks at victims14:40
*** ricardoas has quit IRC14:41
TheJuliadtantsur: limited to just pxe correct?14:41
openstackgerritIlya Etingof proposed openstack/sushy-tools master: Abstract away the virtualization management interface  https://review.openstack.org/52332114:42
openstackgerritIlya Etingof proposed openstack/sushy-tools master: OpenStack cloud driver added  https://review.openstack.org/52387914:42
openstackgerritIlya Etingof proposed openstack/sushy-tools master: documentation on simulators added  https://review.openstack.org/52344514:42
TheJuliadtantsur: or are you talking about local boot uefi14:42
*** athomas has quit IRC14:42
dtantsurwe don't test local boot in the CI (sigh)14:42
*** athomas has joined #openstack-ironic14:43
TheJuliadtantsur: on a plus side, bifrost does when one of the jobs runs14:43
openstackgerritMadhuri Kumari proposed openstack/ironic-specs master: Add service management API for ironic  https://review.openstack.org/47121714:44
TheJuliawe likely ought to setup one of the bifrost jobs to be triggered, at least they execute in <20 minutes14:47
dtantsuryeah14:49
* TheJulia fires off a re-test in the background to see if she has some of the more recent issues fixed :(14:50
* TheJulia wishes she spent way more time on it back when she was at HPE14:51
*** makowals has quit IRC15:00
rpiosoGood morning, ironicers15:01
*** hwoarang_ has quit IRC15:07
TheJuliagood morning rpioso15:18
openstackgerritIlya Etingof proposed openstack/sushy-tools master: Abstract away the virtualization management interface  https://review.openstack.org/52332115:18
openstackgerritIlya Etingof proposed openstack/sushy-tools master: OpenStack cloud driver added  https://review.openstack.org/52387915:18
openstackgerritIlya Etingof proposed openstack/sushy-tools master: added system boot mode support  https://review.openstack.org/52610115:18
openstackgerritIlya Etingof proposed openstack/sushy-tools master: added system boot mode support  https://review.openstack.org/52610115:19
*** zhangfei has quit IRC15:26
*** rama_y has joined #openstack-ironic15:28
*** dpawar has quit IRC15:30
*** dansmith is now known as superdan15:31
openstackgerritJulia Kreger proposed openstack/bifrost master: Fedora 25-27 support  https://review.openstack.org/47175015:31
*** AlexeyAbashkin has quit IRC15:34
etingofwhere would one report an RDO issue to?15:34
*** jtomasek has quit IRC15:36
*** dpawar has joined #openstack-ironic15:37
*** fragatina has joined #openstack-ironic15:38
*** ijw has quit IRC15:39
TheJuliaetingof: rdoproject.org?15:39
etingofyep15:39
*** ijw has joined #openstack-ironic15:39
rpiosoTheJulia: :)15:39
*** hwoarang has joined #openstack-ironic15:40
jrollis it normal that restarting ironic-api via systemd in devstack takes 30+ seconds?15:40
*** fragatina has quit IRC15:42
*** dpawar has quit IRC15:42
*** amarao has quit IRC15:43
*** Goneri has quit IRC15:44
*** amarao has joined #openstack-ironic15:44
sambettsjroll: :/ I've not seen it take that long before15:45
jrollhm, thanks15:46
TheJuliaI've seen it take that before, but typically systemd was grumpy about something at that point15:46
TheJuliacrushil: you around?15:48
crushilTheJulia, Yup15:48
TheJuliacrushil: looks like your driver shows merge conflict :(15:48
*** ricardoas has joined #openstack-ironic15:49
*** ijw_ has joined #openstack-ironic15:49
crushilTheJulia, I see. Let me rebase it15:50
TheJulia:915:50
TheJuliaerr :(15:50
*** ijw has quit IRC15:52
*** amarao has quit IRC15:52
openstackgerritRushil Chugh proposed openstack/ironic master: Add XClarity Driver  https://review.openstack.org/51942715:58
crushilTheJulia, Rebased. Should be good to go now I think. :)15:59
NobodyCamGood Morning Booters16:01
TheJuliagood morning16:01
hamzyis there a way to show the returned information from an ironic introspection?  I see a hardware_swift_object.  Is there a way to dump that?16:01
TheJuliacore reviewers: fyi, the xclarity driver had 2x+2 before the rebase above.16:01
dtantsurhamzy: openstack baremetal introspection data save <UUID>16:04
hamzydtantsur, thanks... that makes sense :)16:05
openstackgerritRushil Chugh proposed openstack/ironic master: Add XClarity Driver  https://review.openstack.org/51942716:07
crushilTheJulia, I had forgotten to fix the nit from the previous patch. That is fixed now as well16:08
TheJuliacrushil: awesome16:09
openstackgerritMichael Turek proposed openstack/ironic-python-agent master: Use lshw in place of dmidecode for the default hardware manager  https://review.openstack.org/50179916:09
*** radez has joined #openstack-ironic16:12
jlvillaljroll, Yeah I have a script where I give it a patch (or list of patches) and it will watch it and do automated rechecks. I use it sometimes.16:21
*** hoonetorg has quit IRC16:22
jrolljlvillal: pretty cool, though seems like it has the potential to be pretty wasteful of resources :/16:34
jrolland morning :)16:34
jlvillaljroll, True and good morning :)16:34
*** jistr has quit IRC16:37
*** dtantsur has quit IRC16:37
*** bl0m1 has quit IRC16:37
*** sapd_ has quit IRC16:37
*** figleaf has quit IRC16:37
*** asettle has quit IRC16:37
*** bl0m1_ has joined #openstack-ironic16:37
*** edleafe has joined #openstack-ironic16:37
*** sapd_ has joined #openstack-ironic16:37
*** asettle has joined #openstack-ironic16:37
*** asettle is now known as Guest3153216:37
*** links has quit IRC16:38
*** edleafe is now known as figleaf16:39
*** hoonetorg has joined #openstack-ironic16:39
*** jistr has joined #openstack-ironic16:40
*** serlex has quit IRC16:40
*** links has joined #openstack-ironic16:43
-openstackstatus- NOTICE: Zuul has been restarted and lost queue information; changes in progress will need to be rechecked.16:45
TheJuliaugh16:45
jlvillal:(16:45
*** milan_ has quit IRC16:45
crushil:(16:45
*** ijw_ has quit IRC16:47
TheJuliahttps://imgflip.com/i/22kih416:48
sambettsTheJulia: :D16:49
openstackgerritJim Rollenhagen proposed openstack/ironic master: wip add/delete single traits  https://review.openstack.org/53324116:51
jrollthis is breaking my brain ^ sambetts I'd love your insight if you have any ideas16:51
jrollI'm gonna step away for a bit and have lunch and such though16:52
sambettsjroll: whats up?16:52
jrollsambetts: _lookup shenanigans16:52
jrollI really have to step away though, sorry, I'll ping when I'm back16:53
sambettsjroll: no problem16:53
johnthetubaguyjroll: I did already add single updates a bit in my patch, did that not work?16:54
*** fragatina has joined #openstack-ironic16:54
johnthetubaguyI did wonder if I needed an extra controller16:54
johnthetubaguydoing both puts seems hard :(16:54
sambettswhats the API look like we're trying to expose?16:56
sambettsPUT /node/<uuid>/traits BODY = {traits: []} and PUT /node/<uuid>/traits BODY = {trait:<trait>} or something??16:57
sambettsjohnthetubaguy: ?16:58
johnthetubaguyyeah16:59
johnthetubaguyoh, wait, no16:59
johnthetubaguy PUT /node/<uuid>/traits {traits: [....]}16:59
johnthetubaguyPUT /node/<uuid>/traits/<trait-name> (no body)16:59
johnthetubaguyone replaces all, the other just adds one17:00
johnthetubaguyI got DELETE working OK17:00
sambettsjohnthetubaguy: so the why to support that is17:00
johnthetubaguyAPI WG says we should, is the initial reason17:00
sambettsway to support that in pacan is by using kwargs17:00
*** absubram has joined #openstack-ironic17:00
johnthetubaguyyeah, did that for DELETE, but it seemed to confuse things for PUT, but I probably just screwed that up somehow17:01
*** rama_y has quit IRC17:02
sambettsjohnthetubaguy: PUT should be for updating an existing record not adding anything though :/17:03
johnthetubaguyright, it is here17:03
johnthetubaguyit in place update of existing thing17:03
*** pcaruana has quit IRC17:03
johnthetubaguyreference is: http://specs.openstack.org/openstack/api-wg/guidelines/tags.html#addressing-individual-tags17:03
sambettsbut the existing thing is the thing :/17:04
*** cjloader has quit IRC17:04
sambettsPUT /node/<uuid>/traits/<key> BODY = value17:04
johnthetubaguythere is no key value, just a key17:05
johnthetubaguyor just a value I guess17:05
sambettswhich is why PUT breaks resourceful REST in this case :(17:06
johnthetubaguyI guess patch is the other way17:06
sambettsjohnthetubaguy: I think, you might be about to do def put(self, trait=None, traits=None) to support both in pecan17:07
*** cjloader has joined #openstack-ironic17:07
*** fragatina has quit IRC17:07
sambettsjroll: ^17:07
johnthetubaguyI can try that17:07
sambettswhen it does URL only it'll populate the fields in order, so <trait> from the url will fill out the trait parameter17:07
*** fragatina has joined #openstack-ironic17:07
johnthetubaguyI guess we must supply and empty body though17:07
sambettstraits will only be populated if "traits:" is in the body so we can check if both are set error17:08
johnthetubaguyits just the validation requires {} to be sent I think17:09
sambettsif anything other than trait: or traits: is in the body it'll blow up anyway I believe because the keys in the body doesn't match the paramters17:09
johnthetubaguywill double check that17:09
sambettsan empty json body will be fine I think17:09
TheJuliaDmitry asked me to convey to everyone to have a good weekend. He can't seem to reconnect to irc right now17:10
sambettsjohnthetubaguy: it means we'll also support: PUT /node/<uuid>/traits BODY: {trait: <trait>} though17:10
*** Goneri has joined #openstack-ironic17:10
sambettsbut I don't think thats a bad thing :/17:10
*** tesseract has quit IRC17:12
*** AlexeyAbashkin has joined #openstack-ironic17:12
*** AlexeyAbashkin has quit IRC17:17
johnthetubaguysambetts: sweet that appears to work, totally didn't think about that option for some reason17:19
openstackgerritJohn Garbutt proposed openstack/ironic master: WIP: API: Node Traits API  https://review.openstack.org/53226917:19
johnthetubaguyjroll: I think that roughly works ^17:19
sambettsjohnthetubaguy: no problem :) pecan has some weird behaviours17:19
johnthetubaguyI see what people meant about it now17:20
johnthetubaguyreally liking what cdent has working for placement in nova land17:20
johnthetubaguyrouting is a dict, pointing to functions17:20
sambettsjohnthetubaguy: whats he using for that? flask??17:20
*** AlexeyAbashkin has joined #openstack-ironic17:21
sambettsflask is nice because you just decorate function with the URL you want that function to be exposed on17:21
johnthetubaguynot sure we use ansyhting17:21
johnthetubaguyanything17:21
sambettsjohnthetubaguy: flask: https://github.com/openstack/ironic-inspector/blob/master/ironic_inspector/main.py#L20317:22
johnthetubaguyhttps://github.com/openstack/nova/blob/master/nova/api/openstack/placement/handler.py#L5217:22
sambettsjohnthetubaguy: thats what I was used too when I worked on ruby on rails stuff, one location that defines all the routes IMO is much cleaner to understand: https://github.com/CiscoSystems/curvature/blob/bafa387773a0236ada6bec73fc3e320f408cf1e5/config/routes.rb17:24
*** links has quit IRC17:24
johnthetubaguysambetts: yeah, so much neater17:24
johnthetubaguywell for REST APIs it seems great17:25
jrollsambetts: johnthetubaguy: I'm fairly convinced the way we just did that in one controller will allow /node/<uuid>/traits BODY = {trait:<trait>}17:25
sambettsjroll: it will17:25
jrollwhich is why I was trying to do a separate thing17:25
*** AlexeyAbashkin has quit IRC17:25
jrollyeah, so two ways to do one thing, makes people into sad pandas17:26
* jroll wonders if he's allowed to rewrite our entire API backend yet17:26
johnthetubaguyyeah, not sure I like the extra bonus features17:28
johnthetubaguybut I feel closer to the spec than I was this morning17:28
sambettsjroll: personally I'd prefer to expose {trait:<trait>} and not PUT /node/<uuid>/traits/<trait> because the second one isn't actually a valid resourceful API, but what do I know API wg17:28
sambettssays the other17:28
jrollyerp17:28
johnthetubaguyits the pragmatic need to update individual tags I think17:29
johnthetubaguyrather than always updating the full list17:29
johnthetubaguynasty races in your scripts if you always update the full list17:29
jrollyeah, I tend to think POST for all and PUT for one makes more sense, but that's just me17:29
sambettsthats what patch is for though I thought17:29
jrollor that17:30
johnthetubaguytrue, be must people seem to hate patch, not sure why17:30
johnthetubaguys/be/but/17:30
sambetts:/ yeah17:30
*** marios has quit IRC17:30
jrollanyway, I worry about trait=foo in the body, because you're a single keystroke away from blowing up the rest of your traits17:30
sambettsjroll: we could detect if it came from the body or not17:31
johnthetubaguyjroll: yeah17:31
johnthetubaguysambetts: ah, good point, request has those details I guess17:31
sambettsand manually throw an error if it did17:31
sambettsseems the neater solution instead of adding a new controller17:31
sambettsor at least seems to use as much of pecan's own logic as possible, and then we just cut out the case17:32
sambettswe don't want17:32
sambettswell two cases actually: both trait and traits can't be set, and trait can't come from the body17:33
sambettsotherwise you could do PUT /node/<uuid>/traits/<trait> {traits: [....]} which doesn't make any sense17:33
jrollheh17:33
jrollyeah, seems like it's a couple hacks either way17:34
johnthetubaguyyeah, I already killed that one17:34
jrollI feel like _lookup might be "more right" because it's keeping all the handling in the routing methods17:34
jrollbut not super opinionated17:34
*** absubram has quit IRC17:34
johnthetubaguyby the way, it seems very easy to get 500 errors with badly formed requests, or is that just me?17:35
sambetts:/17:36
jrollI haven't got much of that with existing code, but getting lots of it messing around with new code here17:36
rpiosoI'd like to know if any of our projects use anything that is or resembles an enumeration.17:36
sambettsrpioso: ironic-inspector has an enum for states17:37
sambettsrpioso: we orignally used a library to add it, but then just used a class instead https://github.com/openstack/ironic-inspector/blob/master/ironic_inspector/introspection_state.py#L1917:38
sambettsif thats what you mean17:38
sambettspython doesn't have its own built in enum type17:38
jrolloh, but it does!17:39
jrollhttps://docs.python.org/3/library/enum.html17:39
jrollpy3 to the rescue :P17:39
sambettswell it does now ;)17:39
rpiososambetts: Thank you. I'll play with that approach to determines if it provides what I'm looking for.17:40
openstackgerritJohn Garbutt proposed openstack/ironic master: WIP: API: Node Traits API  https://review.openstack.org/53226917:40
rpiosojroll, sambetts: The py3 enum does :)17:40
johnthetubaguyjroll: sambetts: https://review.openstack.org/#/c/532269/8..917:41
patchbotpatch 532269 - ironic - WIP: API: Node Traits API17:41
*** AlexeyAbashkin has joined #openstack-ironic17:42
rpiosojroll, sambetts: There's also an enum32 package that has been backported to py2.7. I haven't played with that, yet.17:42
jrolljohnthetubaguy: yeah, that would do it :)17:42
sambettsjohnthetubaguy: looks good :)17:42
* johnthetubaguy bashes pecan with nut cracker17:42
sambettshaha17:42
TheJulialol17:43
*** AlexeyAbashkin has quit IRC17:44
openstackgerritHugo Nicodemos proposed openstack/ironic master: Remove python-oneviewclient from oneview hardware type.  https://review.openstack.org/52472917:44
rpiososambetts: That idiom might just meet the need. Thanks, again.17:45
sambettsrpioso: no problem :)17:46
*** cjloader has quit IRC17:49
*** cjloader has joined #openstack-ironic17:50
TheJuliabbiab, need to run to the bank17:51
*** penick has joined #openstack-ironic17:56
*** trown is now known as trown|lunch17:56
*** e0ne has quit IRC17:56
*** ijw has joined #openstack-ironic17:57
*** derekh has quit IRC17:58
*** ijw has quit IRC18:02
*** lucasagomes is now known as lucas-afk18:07
*** cjloader has quit IRC18:07
openstackgerritMerged openstack/python-ironicclient master: Use StrictVersion to compare versions  https://review.openstack.org/53275418:08
*** cjloader has joined #openstack-ironic18:08
*** ijw has joined #openstack-ironic18:12
*** ijw has quit IRC18:13
*** athomas has quit IRC18:20
*** cjloader has quit IRC18:28
*** cjloader has joined #openstack-ironic18:29
openstackgerritJohn Garbutt proposed openstack/ironic master: WIP: API: Node Traits API  https://review.openstack.org/53226918:34
*** mariojv has quit IRC18:34
*** ricardoas is now known as ricardoas-away18:34
*** mariojv has joined #openstack-ironic18:34
*** yee379 has joined #openstack-ironic18:36
*** amotoki has quit IRC18:37
*** yee37932 has quit IRC18:38
*** amotoki has joined #openstack-ironic18:39
*** cjloader has quit IRC18:48
*** jkilpatr has quit IRC18:49
*** dtantsur has joined #openstack-ironic18:50
*** cjloader has joined #openstack-ironic18:52
*** rmcall has joined #openstack-ironic18:54
*** rmcall has quit IRC18:59
*** jkilpatr has joined #openstack-ironic19:02
*** sambetts is now known as sambetts|afk19:09
sambetts|afknight all19:09
crushilnight sambetts|afk19:12
*** dyasny has quit IRC19:13
*** penick has quit IRC19:14
*** penick has joined #openstack-ironic19:20
*** trown|lunch is now known as trown19:22
*** baha has joined #openstack-ironic19:23
*** AlexeyAbashkin has joined #openstack-ironic19:25
*** harlowja has joined #openstack-ironic19:27
*** ijw has joined #openstack-ironic19:33
*** ijw has quit IRC19:34
*** ijw has joined #openstack-ironic19:35
*** AlexeyAbashkin has quit IRC19:42
*** cjloader has quit IRC19:48
*** dsneddon is now known as dsneddon_afk19:53
* TheJulia burries her brain back into reviews19:54
*** cjloader has joined #openstack-ironic19:55
crushilTheJulia, Around?20:00
TheJuliaat least 3.35% of my brain is :)20:01
TheJuliawhats up?20:01
crushilhaha20:02
*** harlowja has quit IRC20:04
TheJuliaAny core reviewers around? I know crushil would appreciate20:05
TheJuliahttps://review.openstack.org/#/c/519427/ merging :)20:05
patchbotpatch 519427 - ironic - Add XClarity Driver20:05
crushilThanks TheJulia20:09
TheJuliaWhile on the subject of drivers, oneview CI seems to be passing and their client change patches are passing as well.20:12
TheJuliaI removed my -1 on their first few patches and have changed my vote accordingly20:20
*** fragatina has quit IRC20:38
*** cjloader has quit IRC20:38
*** cjloader has joined #openstack-ironic20:39
*** openstackstatus has quit IRC20:46
*** openstack has joined #openstack-ironic20:48
*** ChanServ sets mode: +o openstack20:48
*** srart has quit IRC20:56
*** srart has joined #openstack-ironic21:03
openstackgerritJim Rollenhagen proposed openstack/python-ironicclient master: WIP: traits in client  https://review.openstack.org/53262221:06
*** dyasny has joined #openstack-ironic21:14
*** racedo has quit IRC21:20
*** harlowja has joined #openstack-ironic21:25
*** harlowja has joined #openstack-ironic21:26
*** penick has quit IRC21:28
*** rbudden has quit IRC21:43
*** r-daneel has joined #openstack-ironic21:52
*** cjloader has quit IRC21:56
*** racedo has joined #openstack-ironic21:58
*** dprince has quit IRC22:01
*** baha has quit IRC22:04
openstackgerritJim Rollenhagen proposed openstack/python-ironicclient master: Traits support  https://review.openstack.org/53262222:07
*** trown is now known as trown|outtypewww22:07
*** fragatina has joined #openstack-ironic22:08
*** etingof has quit IRC22:13
openstackgerritJulia Kreger proposed openstack/python-ironicclient master: Facilitate latest Rest API use  https://review.openstack.org/53102922:13
openstackgerritJulia Kreger proposed openstack/python-ironicclient master: Allow API user to define list of versions  https://review.openstack.org/53127122:13
openstackgerritJulia Kreger proposed openstack/python-ironicclient master: Raise exception for unsupported microversion  https://review.openstack.org/53297922:13
*** crushil has quit IRC22:17
*** fragatina has quit IRC22:28
*** fragatina has joined #openstack-ironic22:28
*** weshay is now known as weshay_PTO22:29
*** jlabarre has quit IRC22:32
*** fragatina has quit IRC22:33
*** jkilpatr has joined #openstack-ironic22:34
*** fragatina has joined #openstack-ironic22:35
*** dsneddon_afk is now known as dsneddon22:41
openstackgerritJulia Kreger proposed openstack/ironic-lib master: Add wait_for_disk to destroy_disk_metadata function  https://review.openstack.org/52932522:50
TheJuliajlvillal: Take a look and see if that works. Something is up with fuser on my machine :\22:51
*** AlexeyAbashkin has joined #openstack-ironic22:54
*** etingof has joined #openstack-ironic22:55
*** AlexeyAbashkin has quit IRC22:59
*** racedo has quit IRC22:59
*** figleaf is now known as edleafe22:59
*** harlowja has quit IRC23:01
*** etingof has quit IRC23:28
*** etingof has joined #openstack-ironic23:29
*** r-daneel has quit IRC23:35

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!