openstackgerrit | Ilya Etingof proposed openstack/sushy-tools master: documentation on simulators added https://review.openstack.org/523445 | 00:00 |
---|---|---|
*** rpioso is now known as rpioso|afk | 00:02 | |
*** etingof has quit IRC | 00:25 | |
*** ijw has quit IRC | 00:50 | |
openstackgerrit | Vladyslav Drok proposed openstack/ironic master: [WIP] Refactor deploy interface methods https://review.openstack.org/524433 | 00:55 |
*** threestrands has joined #openstack-ironic | 01:55 | |
openstackgerrit | Kaifeng Wang proposed openstack/ironic-inspector master: Doc update: remove discoverd reference https://review.openstack.org/531051 | 02:04 |
*** sasha2 has quit IRC | 02:23 | |
*** ijw has joined #openstack-ironic | 02:26 | |
*** ijw has quit IRC | 02:30 | |
openstackgerrit | Kaifeng Wang proposed openstack/ironic-inspector master: Doc update: remove discoverd reference https://review.openstack.org/531051 | 02:38 |
*** namnh has joined #openstack-ironic | 02:47 | |
openstackgerrit | Debayan Ray proposed openstack/sushy master: Update method docstring https://review.openstack.org/530872 | 03:04 |
*** ijw has joined #openstack-ironic | 03:14 | |
*** pmannidi has joined #openstack-ironic | 03:35 | |
*** pmannidi has quit IRC | 03:37 | |
*** pmannidi has joined #openstack-ironic | 03:45 | |
*** kiseok7 has quit IRC | 04:26 | |
*** udesale has joined #openstack-ironic | 04:37 | |
*** rbudden has quit IRC | 05:12 | |
*** ijw has quit IRC | 05:13 | |
openstackgerrit | Madhuri Kumari proposed openstack/ironic-specs master: Add service management API for ironic https://review.openstack.org/471217 | 05:45 |
openstackgerrit | Madhuri Kumari proposed openstack/ironic-specs master: Add service management API for ironic https://review.openstack.org/471217 | 05:47 |
*** bcornec has quit IRC | 06:34 | |
*** hieulq has joined #openstack-ironic | 06:58 | |
*** kiseok7 has joined #openstack-ironic | 06:59 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/ironic-ui master: Imported Translations from Zanata https://review.openstack.org/531095 | 07:10 |
*** threestrands has quit IRC | 07:25 | |
*** jrist has quit IRC | 07:29 | |
*** pcaruana has joined #openstack-ironic | 07:32 | |
openstackgerrit | fupingxie proposed openstack/ironic master: Add a provisioning target:adopt https://review.openstack.org/531099 | 07:34 |
*** jaypipes has quit IRC | 07:53 | |
*** rcernin has quit IRC | 08:04 | |
*** dtantsur|afk is now known as dtantsur | 08:49 | |
*** lucas-afk is now known as lucasagomes | 08:49 | |
dtantsur | morning ironic! happy new year :) | 08:50 |
yongiman | Happy new year too :) | 08:50 |
*** amarao has joined #openstack-ironic | 08:59 | |
*** hjensas has joined #openstack-ironic | 08:59 | |
*** e0ne has joined #openstack-ironic | 09:05 | |
openstackgerrit | Madhuri Kumari proposed openstack/ironic-specs master: Add service management API for ironic https://review.openstack.org/471217 | 09:09 |
*** jrist has joined #openstack-ironic | 09:13 | |
*** derekh has joined #openstack-ironic | 09:24 | |
*** milan has joined #openstack-ironic | 09:26 | |
*** mgoddard has joined #openstack-ironic | 09:26 | |
milan | morning Ironic! :) | 09:27 |
*** phuongnh has joined #openstack-ironic | 09:46 | |
*** fragatina has quit IRC | 09:49 | |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic master: Rework exception handling on deploy failures in conductor https://review.openstack.org/531120 | 10:13 |
*** ijw has joined #openstack-ironic | 10:17 | |
openstackgerrit | Merged openstack/sushy master: Update method docstring https://review.openstack.org/530872 | 10:17 |
*** MattMan_1 has quit IRC | 10:20 | |
*** MattMan_1 has joined #openstack-ironic | 10:20 | |
*** ijw has quit IRC | 10:21 | |
openstackgerrit | longfei.zhang proposed openstack/networking-generic-switch master: Fix test with OVS example failed case when exec ovs-vsctl add-port https://review.openstack.org/531121 | 10:25 |
*** namnh has quit IRC | 10:27 | |
openstackgerrit | longfei.zhang proposed openstack/networking-generic-switch master: Fix test with OVS example failed case when exec ovs-vsctl add-port https://review.openstack.org/531121 | 10:30 |
*** stendulker has joined #openstack-ironic | 10:31 | |
*** phuongnh has quit IRC | 10:51 | |
openstackgerrit | Shivanand Tendulker proposed openstack/ironic master: Agent rescue implementation https://review.openstack.org/400437 | 11:13 |
*** stendulker has quit IRC | 11:25 | |
-openstackstatus- NOTICE: zuul seems to have gotten stuck and will probably need a restart, please be patient | 11:27 | |
*** openstackstatus has quit IRC | 11:28 | |
*** openstack has quit IRC | 11:28 | |
*** openstack has joined #openstack-ironic | 13:08 | |
*** ChanServ sets mode: +o openstack | 13:08 | |
*** openstackstatus has joined #openstack-ironic | 13:09 | |
*** ChanServ sets mode: +v openstackstatus | 13:09 | |
*** trown|outtypewww is now known as trown | 13:21 | |
*** lucas-hungry is now known as lucasagomes | 13:32 | |
*** tzumainn has joined #openstack-ironic | 13:41 | |
*** dtantsur is now known as dtantsur|brb | 13:49 | |
*** rpioso|afk is now known as rpioso | 13:54 | |
rpioso | Good morning :) | 13:54 |
TheJulia | good morning everyone | 14:00 |
rpioso | TheJulia: Morning | 14:02 |
openstackgerrit | Ilya Etingof proposed openstack/sushy-tools master: add dvsm CI job https://review.openstack.org/524560 | 14:16 |
*** dtantsur|brb is now known as dtantsur | 14:22 | |
dtantsur | morning TheJulia, rpioso | 14:22 |
rpioso | dtantsur: Happy 2018! | 14:23 |
dtantsur | :) | 14:23 |
*** mrtenio has joined #openstack-ironic | 14:25 | |
*** dansmith has quit IRC | 14:25 | |
*** therve_ is now known as therve | 14:29 | |
*** rbudden has joined #openstack-ironic | 14:37 | |
dtantsur | TheJulia: do you remember why we even have this get_client() indirection? | 14:40 |
TheJulia | because we have a v1, and not yet a v2 | 14:41 |
TheJulia | and consistency :) | 14:41 |
* TheJulia wonders if we are thus professional indirection setters.... | 14:41 | |
*** yolanda has quit IRC | 14:45 | |
*** baha has joined #openstack-ironic | 14:45 | |
-openstackstatus- NOTICE: zuul has been restarted, all queues have been reset. please recheck your patches when appropriate | 14:47 | |
dtantsur | well, I wonder why not just use ironicclient.v1.Client | 14:47 |
dtantsur | and maybe ironicclient.v2.Client one day | 14:47 |
dtantsur | because we anyway require an explicit major version supplied to get_client call | 14:47 |
TheJulia | yeah, which is always "1" :( | 14:56 |
TheJulia | it is a positional arg, we could change it to have a default value..... *looks around innocently* | 14:57 |
openstackgerrit | John L. Villalovos proposed openstack/ironic master: WIP/DNM: Test to get idea of 3rd Party CI status https://review.openstack.org/531167 | 15:04 |
TheJulia | jlvillal: good morning! | 15:11 |
jlvillal | TheJulia, Good morning :) | 15:11 |
* jlvillal still waking up | 15:11 | |
dtantsur | morning jlvillal | 15:16 |
dtantsur | TheJulia: heh, indeed | 15:16 |
jlvillal | :) | 15:17 |
dtantsur | jlvillal: note that ironic-inspector does not have 3rd party CI | 15:17 |
jlvillal | dtantsur, Yeah, I realized that after I copy-pasted my recheck message :) | 15:18 |
NobodyCam | Good Morning Ironic'ers | 15:18 |
dtantsur | morning NobodyCam | 15:18 |
jlvillal | dtantsur, Hopefully we can remove the plugin code soon. I think a fair amount of 3rd Party CI is already broken with or without the plugin code... | 15:18 |
NobodyCam | :) Morning dtantsur :) | 15:18 |
dtantsur | true :( | 15:18 |
TheJulia | They seemed to be in decent shape before the holidays... well... decent for 3rd party ci with the occasional sporadic failure | 15:23 |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic master: [WIP] Handle case when a glance image contains no data https://review.openstack.org/531180 | 15:48 |
openstackgerrit | Ilya Etingof proposed openstack/ironic master: added redfish boot mode management https://review.openstack.org/528314 | 15:56 |
*** udesale has joined #openstack-ironic | 16:01 | |
*** udesale has quit IRC | 16:14 | |
*** mgoddard has quit IRC | 16:21 | |
*** e0ne has quit IRC | 16:36 | |
*** zshi has quit IRC | 16:38 | |
*** dtantsur is now known as dtantsur|afk | 16:41 | |
dtantsur|afk | o/ | 16:41 |
*** rbudden has quit IRC | 16:44 | |
*** ChanServ sets mode: -r | 16:48 | |
*** gcb has quit IRC | 16:49 | |
*** gcb has joined #openstack-ironic | 16:50 | |
*** pcaruana has quit IRC | 16:52 | |
*** milan has quit IRC | 16:56 | |
*** dsneddon has joined #openstack-ironic | 17:01 | |
*** amarao has quit IRC | 17:07 | |
rpioso | jlvillal: FYI, rajinir is out this week. I believe she'll be back in on Monday. | 17:21 |
*** Nisha_Agarwal has joined #openstack-ironic | 17:24 | |
*** rbudden has joined #openstack-ironic | 17:29 | |
*** Nisha_ has joined #openstack-ironic | 17:32 | |
*** Nisha_Agarwal has quit IRC | 17:32 | |
*** Nisha_ has quit IRC | 17:33 | |
*** Nisha_ has joined #openstack-ironic | 17:33 | |
*** mgoddard has joined #openstack-ironic | 17:40 | |
*** Nisha_Agarwal has joined #openstack-ironic | 17:42 | |
*** Nisha_ has quit IRC | 17:42 | |
jlvillal | rpioso: Thanks. Looks like almost all of Dell CI is broken anyway. So I don't think we need to wait for them to update for tempest changes. But that is my opinion :) | 17:44 |
jlvillal | Based on this run: https://review.openstack.org/531167 | 17:45 |
patchbot | patch 531167 - ironic - WIP/DNM: Test to get idea of 3rd Party CI status | 17:45 |
*** lucasagomes is now known as lucas-afk | 17:46 | |
*** Nisha_Agarwal has quit IRC | 17:51 | |
jlvillal | Uhhh. Did something break the unit tests? https://review.openstack.org/#/c/531167/ | 17:56 |
patchbot | patch 531167 - ironic - WIP/DNM: Test to get idea of 3rd Party CI status | 17:56 |
jlvillal | I also reproduced locally | 17:56 |
jlvillal | TheJulia: dtantsur|afk vdrok jroll ^^ | 17:57 |
*** racedo has quit IRC | 17:57 | |
jroll | hey, morning jlvillal | 17:58 |
jlvillal | Morning jroll :) | 17:58 |
jroll | haven't noticed anything, but looking | 17:58 |
jroll | interesting | 17:59 |
jlvillal | I wonder when that happened. Last time anything was merged was back on 27- | 18:00 |
jlvillal | Dec-2017 | 18:00 |
jroll | O_o | 18:00 |
jroll | I had a patch yesterday that passed unit tests fine, fwiw | 18:01 |
jlvillal | jroll: Good data point. | 18:01 |
jroll | ah, it's only the acl middleware tests | 18:01 |
jroll | which depend on keystonemiddleware | 18:02 |
jroll | which.. https://github.com/openstack/requirements/commit/1790ffa06c1b47da2be1b1afee6481f8e6d21e62#diff-0bdd949ed8a7fdd4f95240bd951779c8 | 18:02 |
jlvillal | jroll: Cool. You beat me to finding that :) | 18:03 |
*** derekh has quit IRC | 18:03 | |
jroll | :D | 18:05 |
jroll | I still got it! | 18:05 |
jlvillal | jroll: Maybe they changed the response codes from 403 to 503 or vice-versa | 18:05 |
*** Goneri has joined #openstack-ironic | 18:05 | |
jroll | jlvillal: suspect something is throwing an exception in keystonemiddleware and coming back to the tests as an error | 18:05 |
jroll | you could also be right though | 18:06 |
* jroll is in a meeting so can't put his full brain on this, but is poking around | 18:07 | |
jlvillal | jroll: I'm asking in keystone channel if there is a, "After update you should change X" thingy | 18:07 |
jroll | hopefully something like that isn't intentional in a minor release :) | 18:07 |
jlvillal | hopefully... | 18:09 |
jlvillal | jroll: Didn't seem to break any of the DSVM jobs. But then again they don't really exercise the failure paths like the unit tests do | 18:09 |
jroll | right, this is only the negative acl tests, which tempest doesn't do afaik | 18:10 |
jroll | https://github.com/openstack/ironic/blob/5603a215b726ca465eed2867d830821bb24b1a72/ironic/tests/unit/api/test_acl.py#L51-L52 | 18:17 |
jroll | https://github.com/openstack/keystonemiddleware/compare/4.18.0...4.20.0 | 18:17 |
jroll | specifically https://github.com/openstack/keystonemiddleware/commit/9d8e2836fe7fca186e0380d8a532540ff5cc5215 | 18:18 |
jroll | suspect these are related, but unsure | 18:19 |
jlvillal | jroll: Verified that it is keystonemiddleware 4.20.0. As running with 4.18.0 it works | 18:20 |
* jroll might play with it | 18:20 | |
jlvillal | jroll: lbragstad is helping out in keystone channel now | 18:20 |
jroll | oh cool | 18:20 |
jroll | thanks | 18:20 |
jlvillal | jroll: I can copy those links over there | 18:21 |
jroll | go for it | 18:21 |
* jroll just joined to listen | 18:21 | |
*** lbragstad has joined #openstack-ironic | 18:32 | |
jroll | jlvillal: so fyi it isn't as easy as just making this dogpule compatible: ValueError: Valid values are [oslo_cache.memcache_pool, oslo_cache.dict, oslo_cache.mongo, oslo_cache.etcd3gw, dogpile.cache.memcached, dogpile.cache.pylibmc, dogpile.cache.bmemcached, dogpile.cache.dbm, dogpile.cache.redis, dogpile.cache.memory, dogpile.cache.memory_pickle, dogpile.cache.null], but found 'fake.cache' | 18:48 |
*** jlabarre has joined #openstack-ironic | 18:53 | |
*** ijw has joined #openstack-ironic | 18:55 | |
*** amarao has joined #openstack-ironic | 18:56 | |
*** Goneri has quit IRC | 19:00 | |
jlvillal | jroll: Oh and :( | 19:01 |
jlvillal | jroll: Sorry I had something come up here. I can try to take a look when I get back from lunch. 90+ minutes from now. Depending on when I can leave for lunch :) | 19:02 |
jroll | jlvillal: no worries, I'm sure your office is a mess today :P | 19:02 |
jlvillal | jroll: No comment ;) | 19:03 |
jroll | I'll be looking shortly as well | 19:03 |
*** amarao has quit IRC | 19:05 | |
*** amarao has joined #openstack-ironic | 19:12 | |
rpioso | jlvillal: You're welcome. If memory serves, before the holidays, she and Arkady Kanevsky asked that the tempest changes wait until Dell CI could accommodate them. Does that sound familiar? | 19:16 |
jlvillal | rpioso: Sounds familiar and asked for a three week delay. | 19:16 |
rpioso | jlvillal: Is the time up or ...? | 19:17 |
jlvillal | rpioso: Three weeks is about up. And the CI already seems broken right now. Before the proposed changes have landed. | 19:17 |
jlvillal | rpioso: Since the Dell CI is already broken. I don't see any reason to delay for Dell CI on moving forward. Do you? | 19:18 |
rpioso | jlvillal: Could it wait until rajinir can be consulted? She should be back on Monday. | 19:18 |
jlvillal | rpioso: I am proposing to remove the tempest plugin in the Monday meeting. | 19:19 |
rpioso | jlvillal: Sounds good. I'll try to ensure rajinir is aware of that. Thank you for your patience. | 19:20 |
jlvillal | rpioso: You're welcome | 19:21 |
*** baha has quit IRC | 19:22 | |
rpioso | jroll: Since you still have it, do you understand why the ilo driver management interface's update_boot_mode() does not update the node instance_info's deploy_boot_mode when the capabilities within the properties of the node contain boot_mode? Please see lines 486-501 in https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/ilo/common.py | 19:38 |
jroll | rpioso: no, sorry, I wouldn't know | 19:41 |
rpioso | jroll: No worries. I figured it was worth a try :) | 19:42 |
rpioso | jroll: I'll try stendulker. | 19:44 |
jroll | yep, he should know :) | 19:45 |
*** mgoddard has quit IRC | 19:45 | |
rpioso | I'm adding UEFI support to the drac driver. I'm thinking that it should be broken up into a number of commits as advised by the discussion of "Sending large new features in a single giant commit." on https://wiki.openstack.org/wiki/GitCommitMessages#Structural_split_of_changes | 19:58 |
rpioso | There'll be about 5 commits, +/-. | 19:58 |
rpioso | Is it preferred that all of them be completed before any are submitted for review? Or may they be submitted individually over a stretch of time, as one-by-one they're done? | 20:01 |
rpioso | Perhaps some critical mass of code should be completed before any are uploaded to Gerrit? | 20:03 |
*** Goneri has joined #openstack-ironic | 20:07 | |
jroll | rpioso: work in progress code is always welcome on gerrit, mark it workflow -1 if you don't think it's ready to be reviewed yet | 20:17 |
jroll | we generally don't have a problem with landing the earlier commits before the later ones are done | 20:17 |
rpioso | jroll: Cool! Thank you. | 20:18 |
jroll | yep, no problem :) | 20:18 |
jroll | rpioso: it might be worth putting a general plan in the RFE, just so reviewers can tell that the earlier code is heading in the right direction | 20:19 |
rpioso | jroll: That makes sense. Thanks for that pointer, too :) | 20:20 |
* rpioso needs to create that RFE | 20:20 | |
jroll | sure thing! | 20:20 |
*** amarao has quit IRC | 20:24 | |
*** mgoddard has joined #openstack-ironic | 20:28 | |
jroll | jlvillal: I'm a bit stuck on this. feels like we should be mocking something instead of injecting our own cache, but either way I'm having trouble finding a clean way to access the middleware from those tests :/ | 20:49 |
*** mgoddard has quit IRC | 21:05 | |
*** fragatina has joined #openstack-ironic | 21:11 | |
jlvillal | jroll: Hey. Just got back from lunch. | 21:17 |
jlvillal | jroll: I can take a look now, though I imagine you are further along then me. Going to go re-read the log from the keystone channel | 21:18 |
jroll | jlvillal: I didn't really get anywhere | 21:18 |
jlvillal | jroll: Okay. I'll start looking. I think I have some free time now :) | 21:19 |
jroll | jlvillal: cool, thank you | 21:19 |
*** mdorman has joined #openstack-ironic | 21:19 | |
jlvillal | jroll: And thanks to you too | 21:20 |
mdorman | i keep getting 401s back from swift on validating the tempurl image source on hardware provisioning. i've verified the secret set on the swift account matches swift_temp_url_key in ironic.conf. i am at a loss here. is there something else i need to do on the swift side to turn that on? | 21:25 |
mdorman | i can confirm it's actually not working in swift, b/c i get a 401 when just curling the url as well. | 21:25 |
jroll | mdorman: is the clock accurate in the agent image? | 21:25 |
jroll | or in the ironic box, maybe | 21:26 |
mdorman | running via kolla-ansible, so everything is in docker across two machines. timestamps on each are within a second or two. | 21:27 |
*** fragatina has quit IRC | 21:27 | |
jroll | hm, that's the one thing I remember having issues with, offhand | 21:27 |
jroll | there's no action to take on the swift side, though | 21:28 |
mdorman | kk. yeah just thought i'd check here in case there's something obvious i'm missing | 21:28 |
*** baha has joined #openstack-ironic | 21:29 | |
jroll | mdorman: just to be sure, you set the temp url key for the same user that glance uses to store images in swift, right? | 21:30 |
mdorman | jroll: yeah it's set on the account which has the glance contaier | 21:31 |
mdorman | *container | 21:31 |
jroll | okay | 21:32 |
jroll | the one other thing... there's a way for glance to shard across many containers | 21:32 |
jroll | I assume that isn't in play here? | 21:32 |
jroll | if so, there's an ironic setting to match that | 21:32 |
mdorman | i don't think so. i only have two glance images at this point and i can see the objects for each in the single glance container | 21:32 |
jroll | ok | 21:33 |
jroll | very strange then | 21:33 |
mdorman | is there a glance command to create temp urls? i should probably figure out how to reproduce it manually | 21:34 |
jroll | I think there's a swift command, yeah | 21:34 |
jroll | swift tempurl <method> <seconds> <path> <key> | 21:35 |
mdorman | ah, kk | 21:35 |
jroll | or in python: https://docs.openstack.org/swift/latest/api/temporary_url_middleware.html | 21:35 |
*** threestrands has joined #openstack-ironic | 21:35 | |
*** threestrands has quit IRC | 21:35 | |
*** threestrands has joined #openstack-ironic | 21:35 | |
mdorman | probably should've just googled that myself. thanks jroll ! | 21:37 |
jroll | no problem :) | 21:38 |
jroll | good luck | 21:38 |
*** jcoufal has quit IRC | 21:40 | |
*** dmellado has quit IRC | 21:43 | |
*** dmellado has joined #openstack-ironic | 21:46 | |
*** rcernin has joined #openstack-ironic | 22:12 | |
*** Goneri has quit IRC | 22:21 | |
*** jistr has quit IRC | 22:29 | |
*** rbudden has quit IRC | 22:34 | |
*** rbudden has joined #openstack-ironic | 22:59 | |
*** gutter has joined #openstack-ironic | 23:06 | |
*** ijw has quit IRC | 23:10 | |
*** gutter has quit IRC | 23:14 | |
*** ijw has joined #openstack-ironic | 23:15 | |
*** jistr has joined #openstack-ironic | 23:19 | |
jlvillal | jroll: TheJulia dtantsur|afk vdrok: I updated the whiteboard that the unit tests are broken. And that I don't know yet how to fix it :( | 23:26 |
TheJulia | Thanks :( | 23:26 |
TheJulia | I'm sure I'll see it once I wrap up the patch I'm working on and update my reqs | 23:26 |
jlvillal | TheJulia: Unfortunately yes, you should see the error | 23:27 |
*** mtreinish has quit IRC | 23:39 | |
*** mtreinish has joined #openstack-ironic | 23:42 | |
*** jlabarre has quit IRC | 23:43 | |
*** jistr has quit IRC | 23:54 | |
*** jistr has joined #openstack-ironic | 23:55 | |
*** mdorman has quit IRC | 23:55 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!