Thursday, 2017-11-30

vdrokTheJulia: small question regarding adoption. I see that the prepare method in iscsi deploy calls boot.prepare_instance when adopting, while agent does not. Is there a reason for it? I thought in case of adoption we should not touch the node, while in boot.prepare_instance we eg set boot device00:00
*** yuanying_ has joined #openstack-ironic00:04
*** yuanying has quit IRC00:05
*** Sukhdev has joined #openstack-ironic00:09
*** Sukhdev has quit IRC00:10
*** mjturek has quit IRC00:12
*** akhilaki_ has quit IRC00:16
*** Sukhdev has joined #openstack-ironic00:17
*** ijw has quit IRC00:20
*** Goneri has quit IRC00:21
*** threestrands has quit IRC00:21
*** akhilaki has joined #openstack-ironic00:22
*** yangyapeng has quit IRC00:22
*** ijw has joined #openstack-ironic00:22
NobodyCamwow early morning vdrok :p00:33
NobodyCamand Good Morning00:33
vdrokNobodyCam: heh yeah, half past 4 pm but anyway :)00:33
NobodyCamwhy did I think you where not in pst :p00:34
*** trown is now known as trown|outtypewww00:37
*** Sukhdev has quit IRC00:41
*** bfournie has joined #openstack-ironic00:49
*** bfournie has quit IRC00:50
*** zshi has quit IRC00:51
*** zshi has joined #openstack-ironic00:52
*** Sukhdev has joined #openstack-ironic00:52
*** yangyapeng has joined #openstack-ironic00:55
*** bfournie has joined #openstack-ironic00:57
*** yangyapeng has quit IRC00:59
*** ijw has quit IRC00:59
*** yangyapeng has joined #openstack-ironic01:04
*** akhilaki has quit IRC01:06
*** links has joined #openstack-ironic01:09
vdrokgood night everyone!01:11
TheJuliavdrok: that is it exactly, and the intent/expectation that if a node is set to a pxe driver, then then it is network booting, where if agent driver then it would boot on its own.    We still don't want to touch the boot device01:22
*** crushil has joined #openstack-ironic01:22
TheJuliawell, touch the node.01:22
TheJuliahogepodge: eek :( tcpdump inside the namespace? I wonder if things are getting plumbed properly01:22
*** crushil_ has joined #openstack-ironic01:24
*** crushil has quit IRC01:27
*** yuanying_ has quit IRC01:29
*** yuanying has joined #openstack-ironic01:29
*** priteau has joined #openstack-ironic01:32
*** yuanying_ has joined #openstack-ironic01:33
*** priteau has quit IRC01:37
*** yuanying has quit IRC01:37
*** litao__ has joined #openstack-ironic01:56
*** zhangfei has joined #openstack-ironic02:03
hogepodgeTheJulia: with all the stopping and restarting of my linuxbridge agent, I think I had bad iptables rules on my node02:09
*** namnh has joined #openstack-ironic02:11
*** Gr3nth has joined #openstack-ironic02:20
*** Grenth has quit IRC02:20
*** phuongnh has joined #openstack-ironic02:21
*** rloo has quit IRC02:27
hogepodgeTheJulia: more progress. Turns out it was the set of dangling iptables rules. I'm getting the DHCP ack, now on to figure out how to deliver the ironic boot agent02:40
*** gcb has joined #openstack-ironic02:40
*** threestrands has joined #openstack-ironic02:55
*** trungnv has quit IRC03:03
*** masber has joined #openstack-ironic03:03
*** trungnv has joined #openstack-ironic03:04
*** Sukhdev has quit IRC03:07
*** masuberu has quit IRC03:07
*** fragatina has quit IRC03:09
*** fragatina has joined #openstack-ironic03:09
*** fragatin_ has joined #openstack-ironic03:12
TheJuliahogepodge: Ironic should be sending along enough parameters to point to tftp when it has neutron allocate the dhcp address... but perhaps your falling to non-reserved addresses inside the subnets?03:12
*** fragatina has quit IRC03:14
*** fragatin_ has quit IRC03:16
*** absubram has quit IRC03:17
*** fragatina has joined #openstack-ironic03:19
*** fragatina has quit IRC03:24
*** gcb has quit IRC03:25
*** gcb has joined #openstack-ironic03:26
*** e0ne has joined #openstack-ironic03:28
*** masber has quit IRC03:30
*** e0ne has quit IRC03:32
*** priteau has joined #openstack-ironic03:33
*** masber has joined #openstack-ironic03:34
*** priteau has quit IRC03:38
phuongnhTheJulia: I have updated "Add additional capabilities discovery for iRMC driver" patchset, could you please help me to review it? The link is: https://review.openstack.org/#/c/417347/03:39
patchbotpatch 417347 - ironic - Add additional capabilities discovery for iRMC driver03:39
*** Nisha_Agarwal has joined #openstack-ironic03:41
*** Nisha_Agarwal has quit IRC03:44
*** d0ugal_ has joined #openstack-ironic03:50
*** d0ugal has quit IRC03:52
*** e0ne has joined #openstack-ironic03:55
*** e0ne has quit IRC04:00
*** Nisha_Agarwal has joined #openstack-ironic04:02
*** rbudden has quit IRC04:04
*** gcb has quit IRC04:09
*** e0ne has joined #openstack-ironic04:11
*** AlexeyAbashkin has joined #openstack-ironic04:15
*** crushil_ has quit IRC04:15
*** e0ne has quit IRC04:16
*** AlexeyAbashkin has quit IRC04:20
*** udesale has joined #openstack-ironic04:21
*** e0ne has joined #openstack-ironic04:23
*** e0ne has quit IRC04:28
*** priteau has joined #openstack-ironic04:37
TheJuliaphuongnh: sure04:39
*** e0ne has joined #openstack-ironic04:39
*** crushil_ has joined #openstack-ironic04:39
phuongnhTheJulia: Thank you04:40
*** priteau has quit IRC04:43
*** e0ne has quit IRC04:44
TheJuliaphuongnh: Question, if I have a list of capabilities defined by an operator, will the code delete them?04:48
*** e0ne has joined #openstack-ironic04:50
*** zhangfei has quit IRC04:52
TheJuliaphuongnh: nevermind, re-read the helper code and then the inspection code again04:54
*** tzumainn has quit IRC04:57
*** Sukhdev has joined #openstack-ironic04:57
*** crushil_ has quit IRC05:00
*** e0ne has quit IRC05:03
*** e0ne has joined #openstack-ironic05:07
*** zhangfei has joined #openstack-ironic05:08
TheJuliaphuongnh: The release note needs an upgrade section detailing the bump of the python-scciclient version. I'm 100% okay with it being done as a quick follow-up, and happy to approve the feature to land once a follow-up has been proposed.05:11
*** e0ne has quit IRC05:12
*** e0ne has joined #openstack-ironic05:17
*** e0ne has quit IRC05:22
*** Sukhdev has quit IRC05:25
*** fragatina has joined #openstack-ironic05:26
*** fragatina has quit IRC05:27
*** fragatina has joined #openstack-ironic05:27
*** fragatina has quit IRC05:28
*** fragatina has joined #openstack-ironic05:29
*** e0ne has joined #openstack-ironic05:30
*** e0ne has quit IRC05:35
*** e0ne has joined #openstack-ironic05:38
*** jaganathan has joined #openstack-ironic05:40
*** e0ne has quit IRC05:43
*** e0ne has joined #openstack-ironic05:45
*** mikal has quit IRC05:47
*** absubram has joined #openstack-ironic05:47
phuongnhTheJulia: for your question, the code will delete the list of capabilities that will be inspected. That list is defined in line 93 ironic/drivers/modules/irmc/inspect.py05:48
TheJuliaphuongnh: I noticed that, I just wanted to make sure and had to review the code in common/utils.py to be sure first05:49
TheJuliaphuongnh: Thanks for the reply! :)05:49
phuongnhI got it, thanks05:49
TheJuliaAnyway, I'm going to get some sleep05:50
TheJuliahave a wonderful day!05:50
phuongnhTheJulia: have a nice sleep05:50
phuongnhTheJulia: Thanks05:50
*** absubram_ has joined #openstack-ironic05:50
*** e0ne has quit IRC05:51
*** absubram has quit IRC05:52
*** absubram_ is now known as absubram05:52
*** mikal has joined #openstack-ironic05:55
*** e0ne has joined #openstack-ironic05:57
*** udesale__ has joined #openstack-ironic06:01
*** e0ne has quit IRC06:02
*** e0ne has joined #openstack-ironic06:04
*** udesale has quit IRC06:04
*** pcaruana has joined #openstack-ironic06:05
*** mikal_ has joined #openstack-ironic06:06
*** e0ne has quit IRC06:09
*** mikal has quit IRC06:10
*** e0ne has joined #openstack-ironic06:15
*** pcaruana has quit IRC06:16
*** sasha21 has quit IRC06:18
*** e0ne has quit IRC06:20
*** e0ne has joined #openstack-ironic06:24
*** e0ne has quit IRC06:29
*** zhangfei has quit IRC06:32
*** rwsu has joined #openstack-ironic06:33
*** mcarden has quit IRC06:38
*** masuberu has joined #openstack-ironic06:42
*** zhangfei has joined #openstack-ironic06:45
*** mikal_ has quit IRC06:45
*** masber has quit IRC06:46
*** mikal has joined #openstack-ironic06:47
*** threestrands has quit IRC06:50
*** marios has joined #openstack-ironic06:59
*** hw_wutianwei has joined #openstack-ironic07:06
*** vsaienko has joined #openstack-ironic07:06
*** rbartal has joined #openstack-ironic07:11
*** athomas has joined #openstack-ironic07:16
*** pmannidi has quit IRC07:20
*** rcernin has quit IRC07:20
*** rwsu has quit IRC07:22
*** vsaienko has quit IRC07:27
pas-hamorning ironic07:28
*** ijw has joined #openstack-ironic07:28
*** jtomasek has joined #openstack-ironic07:29
*** Nisha_ has joined #openstack-ironic07:31
*** Nisha_Agarwal has quit IRC07:33
*** rwsu has joined #openstack-ironic07:35
*** udesale has joined #openstack-ironic07:38
*** udesale__ has quit IRC07:39
*** fragatina has quit IRC07:41
*** racedo has joined #openstack-ironic07:54
*** pcaruana has joined #openstack-ironic07:55
*** ijw has quit IRC08:04
*** ijw has joined #openstack-ironic08:05
*** Nisha_away has joined #openstack-ironic08:05
*** AlexeyAbashkin has joined #openstack-ironic08:06
*** TuanLA has joined #openstack-ironic08:07
*** rcernin has joined #openstack-ironic08:07
*** Nisha_ has quit IRC08:09
*** ijw has quit IRC08:09
*** hoonetorg has quit IRC08:11
*** makowals has quit IRC08:16
*** e0ne has joined #openstack-ironic08:18
*** hoonetorg has joined #openstack-ironic08:26
*** hoonetorg has quit IRC08:26
*** hoonetorg has joined #openstack-ironic08:27
*** vsaienko has joined #openstack-ironic08:29
*** makowals has joined #openstack-ironic08:36
*** priteau has joined #openstack-ironic08:40
*** AlexeyAbashkin has quit IRC08:41
*** AlexeyAbashkin has joined #openstack-ironic08:42
*** priteau has quit IRC08:45
*** milan has joined #openstack-ironic08:48
*** ccamacho has joined #openstack-ironic08:52
*** vsaienko has quit IRC08:59
*** vsaienko has joined #openstack-ironic09:01
*** ccamacho has quit IRC09:02
*** ccamacho has joined #openstack-ironic09:05
*** ccamacho has quit IRC09:06
*** ccamacho has joined #openstack-ironic09:06
*** adisky_ has joined #openstack-ironic09:08
*** d0ugal_ has quit IRC09:17
*** d0ugal has joined #openstack-ironic09:18
*** d0ugal has quit IRC09:18
*** d0ugal has joined #openstack-ironic09:18
*** Nisha_away has quit IRC09:19
*** namnh has quit IRC09:21
*** udesale has quit IRC09:31
*** udesale has joined #openstack-ironic09:31
*** zhangfei has quit IRC09:36
*** pester has joined #openstack-ironic09:36
*** asettle_ has joined #openstack-ironic09:38
*** EmilienM_ has joined #openstack-ironic09:39
*** asettle has quit IRC09:39
*** marlinc has quit IRC09:39
*** mkrai has quit IRC09:39
*** EmilienM has quit IRC09:39
*** fxpester has quit IRC09:39
*** dr_gogeta86 has quit IRC09:39
*** andymccr has quit IRC09:39
*** pcaruana has quit IRC09:39
*** dr_gogeta86_ has joined #openstack-ironic09:39
*** lucas-afk is now known as lucasagomes09:40
*** pcaruana has joined #openstack-ironic09:40
*** EmilienM_ is now known as EmilienM09:40
*** andymccr has joined #openstack-ironic09:40
*** e0ne has quit IRC09:40
*** EmilienM has quit IRC09:41
*** EmilienM has joined #openstack-ironic09:41
*** parlos has joined #openstack-ironic09:42
*** mgoddard has joined #openstack-ironic09:42
*** marlinc has joined #openstack-ironic09:44
*** mkrai has joined #openstack-ironic09:44
*** zhangfei has joined #openstack-ironic09:49
*** vsaienko has quit IRC09:54
*** TuanLA has quit IRC09:58
*** hw_wutianwei has quit IRC10:00
*** charcol-v2 has joined #openstack-ironic10:01
*** e0ne has joined #openstack-ironic10:01
openstackgerritDao Cong Tien proposed openstack/ironic master: devstack: add support for setting rescue interface  https://review.openstack.org/52411810:09
*** charcol has quit IRC10:09
*** fyxim has quit IRC10:09
*** zhenguo has quit IRC10:09
*** v12aml has quit IRC10:09
*** dtantsur|afk has quit IRC10:09
*** amarao has joined #openstack-ironic10:10
*** dtantsur has joined #openstack-ironic10:15
*** fyxim has joined #openstack-ironic10:15
*** zhenguo has joined #openstack-ironic10:15
*** v12aml has joined #openstack-ironic10:15
*** dtantsur has quit IRC10:15
*** dtantsur has joined #openstack-ironic10:15
*** trungnv has quit IRC10:15
*** udesale has quit IRC10:16
*** jesusaur has quit IRC10:17
*** jesusaur has joined #openstack-ironic10:22
*** phuongnh has quit IRC10:43
*** phuongnh has joined #openstack-ironic10:44
*** derekh has joined #openstack-ironic10:45
*** vsaienko has joined #openstack-ironic10:46
*** vsaienko has quit IRC10:48
*** masuberu has quit IRC10:49
*** vsaienko has joined #openstack-ironic10:50
*** jlabarre has quit IRC10:50
*** milan has quit IRC10:51
*** jlabarre has joined #openstack-ironic10:55
openstackgerritNguyen Hung Phuong proposed openstack/ironic master: Follow up Add additional capabilities discovery for iRMC driver  https://review.openstack.org/52413710:56
*** vsaienko has quit IRC10:58
*** zhangfei has quit IRC11:03
*** jlabarre has quit IRC11:10
*** efried has quit IRC11:10
*** natorious has quit IRC11:11
*** racedo_ has joined #openstack-ironic11:11
*** phuongnh has quit IRC11:12
*** racedo has quit IRC11:12
*** retr0h has quit IRC11:13
*** csmart has quit IRC11:13
*** natorious has joined #openstack-ironic11:14
*** efried has joined #openstack-ironic11:14
*** mkrai has quit IRC11:14
*** jlabarre has joined #openstack-ironic11:15
*** priteau has joined #openstack-ironic11:23
*** vsaienko has joined #openstack-ironic11:27
*** jesusaur has quit IRC11:30
*** jesusaur has joined #openstack-ironic11:31
*** vsaienko has quit IRC11:32
openstackgerritJohn Garbutt proposed openstack/ironic-specs master: Deploy Templates  https://review.openstack.org/50495211:36
*** jkilpatr has quit IRC11:37
*** vsaienko has joined #openstack-ironic11:40
dtantsurmorning ironic11:43
*** udesale has joined #openstack-ironic11:47
openstackgerritMarkos Chandras (hwoarang) proposed openstack/bifrost master: scripts: install-deps.sh: Add missing e2fsprogs dependency  https://review.openstack.org/52414811:48
*** mat128 has joined #openstack-ironic11:49
*** rcernin has quit IRC11:52
*** jkilpatr has joined #openstack-ironic11:56
*** vsaienko has quit IRC12:05
*** vsaienko has joined #openstack-ironic12:06
*** qsyqian has joined #openstack-ironic12:08
*** qsyqian_ has joined #openstack-ironic12:09
*** amarao1 has joined #openstack-ironic12:09
*** racedo_ has quit IRC12:09
*** etingof has quit IRC12:12
*** jkilpatr has quit IRC12:14
*** jkilpatr has joined #openstack-ironic12:17
*** bfournie has quit IRC12:17
*** bfournie has joined #openstack-ironic12:18
*** bfournie has quit IRC12:22
*** qsyqian has quit IRC12:24
*** retr0h has joined #openstack-ironic12:30
*** lucasagomes is now known as lucas-hungry12:30
*** vsaienko has quit IRC12:34
*** wsl has joined #openstack-ironic12:38
*** wsl has quit IRC12:39
*** early has quit IRC12:44
*** vsaienko has joined #openstack-ironic12:47
*** etingof has joined #openstack-ironic12:50
*** early has joined #openstack-ironic12:51
openstackgerritDmitry Tantsur proposed openstack/ironic master: Switch emphasis to hardware types in the installation guide  https://review.openstack.org/51729012:52
*** bfournie has joined #openstack-ironic12:56
*** etingof has quit IRC12:58
*** qsyqian_ has quit IRC12:58
*** dprince has joined #openstack-ironic12:59
*** MattMan has quit IRC13:03
*** MattMan has joined #openstack-ironic13:04
*** etingof has joined #openstack-ironic13:10
*** trown|outtypewww is now known as trown13:11
*** mkrai has joined #openstack-ironic13:12
*** csmart has joined #openstack-ironic13:12
*** dtantsur is now known as dtantsur|brb13:13
*** mcarden has joined #openstack-ironic13:14
*** vsaienko has joined #openstack-ironic13:16
*** vsaienko has quit IRC13:16
*** tzumainn has joined #openstack-ironic13:19
*** zhangfei has joined #openstack-ironic13:22
*** yangyapeng has quit IRC13:26
*** yangyapeng has joined #openstack-ironic13:27
sambetts|afkdtantsur|brb: I'm not sure what to do with the networking docs, the networking information in the install guide might need some significant changes to incorporate the information about the interfaces in a way that makes sense13:29
*** sambetts|afk is now known as sambetts13:29
*** crushil_ has joined #openstack-ironic13:29
sambettsdtantsur|brb: so the patch will become more that just simply adding the information about the interfaces13:30
sambettss/that/than13:30
*** yangyapeng has quit IRC13:36
*** lucas-hungry is now known as lucasagomes13:39
*** stendulker has joined #openstack-ironic13:41
*** milan_ has joined #openstack-ironic13:51
milan_morning Ironic! :)13:53
*** links has quit IRC13:54
*** sasha21 has joined #openstack-ironic14:02
*** d0ugal has quit IRC14:03
*** Goneri has joined #openstack-ironic14:06
*** mat128 has quit IRC14:08
*** rloo has joined #openstack-ironic14:14
gmonteiroGood morning milan_ and all o/14:16
milan_morning gmonteiro! :)14:17
*** d0ugal has joined #openstack-ironic14:17
*** jaypipes has joined #openstack-ironic14:19
*** rbudden has joined #openstack-ironic14:20
openstackgerritSam Betts proposed openstack/ironic master: Receive and store agent version on heartbeat  https://review.openstack.org/36486114:22
*** racedo_ has joined #openstack-ironic14:24
*** zhangfei has quit IRC14:30
*** jaganathan has quit IRC14:39
*** e0ne has quit IRC14:39
*** e0ne has joined #openstack-ironic14:40
*** dtantsur|brb is now known as dtantsur14:42
dtantsursambetts: yeah, but then folks following the install guide will simply miss this information..14:42
sambettsthat also miss all the information about network interfaces14:43
sambettsthey*14:43
*** mjturek has joined #openstack-ironic14:43
sambettstoday, so thats why I'm saying we need to rewrite the whole doc about networking14:43
sambettsconfiguration14:43
dtantsuryeah, we may use some extensive cross-linking..14:43
dtantsursambetts: approved the patch, but please consider how we could clean it up14:44
sambettsdtantsur: will do :)14:45
*** jaganathan has joined #openstack-ironic14:45
*** stendulker has quit IRC14:49
*** rloo has quit IRC14:50
*** rloo has joined #openstack-ironic14:51
*** jaganathan has quit IRC14:53
TheJuliaGood morning everyone15:06
*** jrist has quit IRC15:08
*** mat128 has joined #openstack-ironic15:09
*** jrist has joined #openstack-ironic15:09
*** actatux has quit IRC15:09
*** udesale has quit IRC15:13
*** udesale has joined #openstack-ironic15:14
*** udesale has quit IRC15:14
dtantsurmorning TheJulia15:15
*** litao__ has quit IRC15:16
dtantsurmilan_, sambetts, aarefiev: could you please review all in https://review.openstack.org/#/q/project:openstack/python-ironic-inspector-client+status:open more or less urgently? we need a release for Queens.15:18
rpiosoGood morning, ironicers!15:18
milan_ack15:18
sambettsdtantsur: looking now15:19
milan_morning rpioso, sambetts, TheJulia!15:19
*** stendulker has joined #openstack-ironic15:19
rpiosomilan_ :)15:19
*** rbartal has quit IRC15:22
*** stendulker_ has joined #openstack-ironic15:24
dtantsursambetts: thanks! more importantly, the 2 breaking changes that require a major bump15:26
dtantsurmorning rpioso15:26
*** stendulker has quit IRC15:26
*** stendulker_ has quit IRC15:26
*** stendulker_ has joined #openstack-ironic15:27
rpiosodtantsur: Hey! :)15:30
stendulker_Good morning all :)15:33
milan_morning stendulker_! :)15:34
stendulker_rloo: Hi15:34
openstackgerritRuby Loo proposed openstack/ironic-specs master: Ironic deployment steps  https://review.openstack.org/41252315:35
stendulker_rloo: Do you have few mins to discuss DB migration for rescue interface15:35
rloostendulker_: hi and good morning15:35
rloostendulker_: oh yeah. sorry, i was heads down on deployment steps ^^. good timing.15:35
rloostendulker_: so... basically, i need to think about it. i'm not convinced it will work15:35
stendulker_milan_: :)15:35
rloostendulker_: sec, let me find a link...15:35
stendulker_rloo: ok :)15:36
rloostendulker_: this is what I meant by online data migrations: https://docs.openstack.org/ironic/latest/contributor/rolling-upgrades.html#online-data-migrations15:36
rloostendulker_: which isn't what you did. i didn't realize that the default rescue interface value had to be no-rescue for hardware types15:36
stendulker_rloo: If busy, we can discuss it later...15:36
rloostendulker_: does it have to be no-rescue, or can it be None too?15:37
stendulker_rloo: Yes, I think we can have default value as 'None'15:37
rloostendulker_: if it is None, then things are easier, cuz that's the default value when that column is added to the DB, right?15:37
-openstackstatus- NOTICE: if you receieved a result of "RETRY_LIMIT" after 14:15 UTC, it was likely due to an error since corrected. please "recheck"15:37
stendulker_Initially logic was different and hence we were setting it as no-rescue. We can have it None now15:37
dtantsurmorning rloo15:38
stendulker_I will change the default value to 'None'.15:38
rloostendulker_: ok, if None, you don't need that patch that upgrades based on the config setting.15:38
stendulker_rloo: yes15:38
rloostendulker_: and i need to think again, but i think we don't need an online data migration either15:38
rloohiya dtantsur15:38
stendulker_But dont we need to provide mechanism to populate based on users default_rescue_interface valuie?15:39
rlooand good morning to everyone else! rpioso, milan_, sambetts, TheJulia15:39
sambettshey rloo15:39
stendulker_like we do it for network interface? https://github.com/openstack/ironic/blob/master/ironic/db/sqlalchemy/alembic/versions/c14cef6dfedf_populate_node_network_interface.py15:40
rpiosoGood morning, rloo :)15:40
rloostendulker_: hmm, i'm not sure. i don't think so...15:40
rloostendulker_: well, for network, we needed to or things would have broken i think15:40
milan_morning rloo! :)15:40
rloostendulker_: for rescue, who knows if they want to use the rescue interface?15:40
rloostendulker_: what did we do for storage interface?15:40
stendulker_rloo: There is no such thing done for storage15:42
rloostendulker_: by the way, i've got a question about rescue. it isn't clear how it is meant to be used (not clear to me). i've never tried to 'rescue' anything. is it the user of the instance that initiates this rescue via nova rescue (or whatever)15:42
stendulker_I think storage interface is a better reference. Then we might not need any migration stuff.15:43
stendulker_rloo: That's right.15:43
stendulker_rloo: User would initiate it using nova rescue15:43
rloostendulker_: so we're letting the user get access to the node, as we assume the user knows what they're doing..15:43
stendulker_yes15:44
stendulker_Good morning dtantsur, sambetts, rpioso, TheJulia :)15:44
rloostendulker_: hmm. i wonder if that is good or not, but i guess it is up to the operator/admin to allow.15:44
dtantsurhi stendulker_15:45
stendulker_rloo: yes, thats understanding15:45
rloodtantsur, sambetts, TheJulia: do you have an opinion on the default value of RescueInterface? Once we introduce it, it will be None for all existing nodes. Are operators going to want us to set that value to something other than none for their nodes, or can we assume they can do that themselves?15:45
stendulker_rloo: To summarise, we would not need any migration things for rescue.15:45
*** stendulker_ has quit IRC15:46
*** stendulker_ has joined #openstack-ironic15:46
TheJuliai think None is fine as long as it maps to no-rescue since that would align with what exists now15:46
rloostendulker_: ^^ just want to get more opinions. Also, is rescue interface avail to existing classic drivers?15:46
rlooTheJulia: good, that's what I think too :)15:46
stendulker_rloo: no, its not going to be available for classic drivers15:47
rloostendulker_: another good, and another reason for folks to migrate to hardware types :)15:47
TheJuliaThat being said, we have allowed for the field to be populated if explicitly set as a default when upgrading, like we have done for many of the interfaces we've added/enabld.15:47
rlooTheJulia: we have? stendulker_ just indicated that we don't for storage interface.15:48
TheJuliawe did for network.... I thought we did for storage as well...15:48
rlooTheJulia: i thought we *had* to for network or things would have broken.15:48
TheJuliawell, yes15:49
* TheJulia looks at storage15:49
stendulker_TheJulia: I did not find any population of storage interface...15:49
TheJulianope we didn't15:49
*** stendulker_ has quit IRC15:51
TheJuliaI pulled up the commit that landed. I guess that is because we mapped None in that case to a noop interface as it was explicitly an opt-in interface15:51
*** stendulker_ has joined #openstack-ironic15:51
stendulker_rloo, TheJulia: I have flaky connection today...15:52
rlooTheJulia: I suspect that is what stendulker_ will do with the rescue interface. (Although I ALWAYS get confused with 'noop' and 'no-X' interface implementation)15:52
rloostendulker_: I think it is OK to have the default value be None, and no data migration / upgrade code needed.15:53
rloostendulker_: i'll comment in the/some patch...15:53
stendulker_rloo, TheJulia: I think storage is a better reference for rescue.15:53
stendulker_rloo: Ok.15:54
*** dprince has quit IRC15:54
stendulker_rloo: Another thing, since we will not have rescue support for classic drivers, adding AgentRescue as a supported interface to fake-hardware15:55
*** UForgotten has quit IRC15:55
rloostendulker_: not sure i understand15:55
stendulker_rloo: One sec, getting link15:55
*** UForgotten has joined #openstack-ironic15:56
stendulker_rloo: https://review.openstack.org/#/c/400437/69/ironic/drivers/fake_hardware.py15:57
patchbotpatch 400437 - ironic - Agent rescue implementation15:57
rlooso why did you add AgentDeploy ?15:57
rloostendulker_: I thought fake hardware did nothing15:58
stendulker_rloo: Ok, I think I will have to re-look I added AgentDeploy15:58
rloostendulker_: same question for AgentRescue15:58
stendulker_I will check and get back to you... I thougt it for AgentREscue15:58
dtantsurmilan_: the last two patches are only waiting for 1x +2 ;) and I can make the release team happy15:59
stendulker_rloo: For AgentRescue it was added for unit testing15:59
rloostendulker_: i don't think that is a good reason for adding it in. can't you mock the call instead?15:59
stendulker_since we do not have this interface supported for classic drivers15:59
milan_dtantsur, lol OK, let's make some people happy :D15:59
TheJuliastendulker_: you can dynamically update on a per test-level so you don't need to do that15:59
stendulker_biut wont mocking wont it be at method level... HOw do I do it  to track the flow within method?16:01
rloostendulker_: i haven't actually looked at the tests yet. but please, remove that stuff from fake hardware.16:02
stendulker_rloo: Ok. I was trying to do like in FakeAgentDriver https://github.com/openstack/ironic/blob/master/ironic/drivers/fake.py#L113-L12016:03
*** mat128 has quit IRC16:04
*** mat128 has joined #openstack-ironic16:04
rloostendulker_: honestly, i would need to look through the tests, etc, to figure out how other stuff was done/tested. you could do a similar thing.16:05
*** mat128 has quit IRC16:05
stendulker_rloo: sure. Thanks a lot.16:05
rloostendulker_: which means, i don't know the solution right now and don't want to look into it :)16:05
stendulker_rloo: No problem. I got lots of my dobts cleared. :)16:06
stendulker_rloo, TheJulia: Thank you.16:06
rloostendulker_: great!16:06
openstackgerritMerged openstack/ironic master: Add missing 'autospec' to unit tests - /unit/objects/  https://review.openstack.org/51716816:07
rpiosoHey stendulker_ :)16:07
*** mat128 has joined #openstack-ironic16:08
stendulker_rpioso: Hi16:08
*** dprince has joined #openstack-ironic16:08
*** stendulker_ has quit IRC16:09
dtantsurTheJulia: we don't have a BFV meeting any more, do we?16:10
TheJulianot really, lots of interest dropped off since we got something minimally viable in place. :(16:10
TheJuliaAlso UI, I'm going to propose to pull the ui meeting16:10
TheJuliathat and I've also been crazy busy16:11
dtantsurI see, yeah..16:12
*** mat128 has quit IRC16:12
* TheJulia doesn't even know what time it really is anymore16:13
TheJuliaAhh, it is breakfast time :)16:13
openstackgerritMerged openstack/ironic master: Fix the format command-line  https://review.openstack.org/52300116:16
*** dyasny has quit IRC16:20
*** phuongnh has joined #openstack-ironic16:27
NobodyCamGood Morning Ironic'ers16:28
rlooMorning NobodyCam16:29
NobodyCamMorning rloo :)16:29
dtantsurmorning NobodyCam16:30
NobodyCamMorning dtantsur :)16:30
rlooyolanda, dtantsur, TheJulia: I've updated the deploy steps spec; please let me know if you wish to be an assignee/contributor (or comment on the spec): https://review.openstack.org/#/c/412523/16:30
patchbotpatch 412523 - ironic-specs - Ironic deployment steps16:30
dtantsurrloo: I can be a contributor, if you need moar of those :)16:31
TheJuliarloo: pulled my -2 at this point since we had the discussion yesterday16:31
rloodtantsur: heh, i haven't even looked at the coding involved; hopefully minimal, but if you will/want to contribute, i'll leave your name there16:32
NobodyCamoh I have to read over that one!16:32
rlooNobodyCam: that'd be greatly appreciated :)16:32
NobodyCamwill be later today!16:32
rlooTheJulia: thx! (and a +2 would be even better, ha ha)16:33
TheJuliaNobodyCam: speaking of the crazy one that we discussed, I might try to write that this weekend if I have nothing going on.16:33
NobodyCamoh :)16:33
phuongnhTheJulia: I have added follow up patchset, https://review.openstack.org/#/c/524137/, it is my first time I create follow up patchset so please help me to review. I can see it is Zuul -1 because of merge conflict.16:34
patchbotpatch 524137 - ironic - Follow up Add additional capabilities discovery fo...16:34
TheJuliaphuongnh: awesome!16:34
phuongnhTheJulia: :)16:34
dtantsurmilan_: any opinion on https://review.openstack.org/#/c/521069/ ?16:35
patchbotpatch 521069 - python-ironic-inspector-client - Drop default URI, make either a session or inspect...16:35
NobodyCammerge conflict prob just needs to be rebased16:35
milan_dtantsur, reading thru right now16:35
dtantsurokay16:35
openstackgerritMarkos Chandras (hwoarang) proposed openstack/bifrost master: Test OPNFV CI verify job. Please ignore.  https://review.openstack.org/36760816:39
phuongnhNobodyCam: should I rebase the patchset 524137 now?16:39
*** charcol-v2 has quit IRC16:40
*** mat128 has joined #openstack-ironic16:43
*** e0ne has quit IRC16:43
* dtantsur has learned about "HTTP 418 I'm a teapot" code and intends to use it in ironic API from now on16:44
TheJulialol16:45
TheJuliaphuongnh: you started a new patch off master instead of the parent patch, you should just rebase on top of it, and edit the files instead of adding new. If that makes sense. Also left feedback in the change.16:46
TheJuliadtantsur: yes please16:46
phuongnhTheJulia: lol, I got it16:48
dtantsurbtw it's good code for UnsupportedVendorExtension. like, "I'm a teapot, what do you want of me?"16:48
openstackgerritNguyen Hung Phuong proposed openstack/ironic master: Follow up Add additional capabilities discovery for iRMC driver  https://review.openstack.org/52413716:49
NobodyCamdtantsur: LOL ++++16:50
NobodyCambut then we would need to implement RFC: 232416:51
NobodyCamhttps://www.ietf.org/rfc/rfc2324.txt16:51
TheJuliaIf only there was a coffee pot driver? ;)16:52
phuongnhTheJulia: look like it is easier for me to start a new patch of the parent patch than fix the current follow up patch16:52
TheJuliaphuongnh: that works, just please preserve the Change-ID16:53
phuongnhTheJulia: is that I1958e18a5b9d933e2aa405b200bac7717f146611 ?16:53
TheJulia"Change-Id: I1ca1e1e02b8c2102e0dbd858c0a51df0dd6b58fb"16:53
TheJuliaThe change-id of the follow-up. You don't need a depends-on in this case16:54
NobodyCamTheJulia: https://github.com/NoBodyCam/ironic16:54
NobodyCamits a little out of date now but....16:54
TheJulia:016:55
TheJuliaerr :)16:55
*** d0ugal has quit IRC16:55
NobodyCam:p16:56
*** fragatina has joined #openstack-ironic16:56
dtantsurLOL16:57
openstackgerritMerged openstack/python-ironic-inspector-client master: Remove support for passing auth_token to ClientV1  https://review.openstack.org/52106316:59
openstackgerritMerged openstack/python-ironic-inspector-client master: Functional tests: pin *inspector* to HEAD  https://review.openstack.org/45355616:59
*** marios has quit IRC17:00
TheJuliaSo anyone want to talk about BFV today?17:00
dtantsurTheJulia: it was 1 hour ago, I think? :) anyway, I don't have anything useful17:01
*** AlexeyAbashkin has quit IRC17:01
TheJuliaawesome!17:01
*** fragatina has quit IRC17:01
TheJuliaoh... daylight savings time hit my calendar17:01
TheJuliaAWESOME!17:02
dtantsurheh17:02
* TheJulia goes back to creating some rfes17:02
dtantsur++17:02
dtantsurand I'll go check out some Glühwein17:02
*** dtantsur is now known as dtantsur|afk17:03
dtantsur|afksee you all17:03
TheJuliaenjoy!17:03
rloodtantsur|afk: tschuss17:04
NobodyCamrloo: +2 for this line alone: `rloo, wow, that seems so easy; is that all there is too it? :D`17:06
rlooNobodyCam: heh, I knew I'd have to update that patch, so threw that in.17:06
NobodyCamwell now I could only give two +1's17:06
rlooNobodyCam: we could change that, if ...17:07
NobodyCam:) +++17:07
NobodyCam:)17:07
*** pcaruana has quit IRC17:08
*** d0ugal has joined #openstack-ironic17:08
phuongnhTheJulia: Thanks for your review.17:09
phuongnhTheJulia: so my next actions are: 1. Remove the depend-on in the follow up patch. 2. Wait for the main patchset are merged and then click on rebase button?17:10
*** akhilaki has joined #openstack-ironic17:14
TheJuliaphuongnh: you can just download the main patchset, then use git review -x follow-up-patch-id-number17:17
TheJuliaerr17:17
TheJuliafollow-up-change-number17:17
TheJuliaedit, and resubmit17:17
phuongnhthanks, very detail and useful instructions17:18
openstackgerritJohn L. Villalovos proposed openstack/ironic master: Detect when log messages are mis-formatted  https://review.openstack.org/23225717:21
*** lucasagomes is now known as lucas-afk17:21
*** d0ugal has quit IRC17:24
TheJuliajlvacation: Hey, you should be on vacation! :)17:25
*** jlvacation is now known as jlvillal17:25
jlvillalTheJulia: I'm back!17:25
jlvillalTheJulia: Or is that.  I'm back :(17:25
TheJulia:(17:25
jlvillalPortugal was fun though. I recommend it.17:26
jlvillalEspecially for lucas-afk since he speaks the language :)17:26
*** fragatina has joined #openstack-ironic17:26
milan_sambetts, hey got a second for https://review.openstack.org/#/c/521069/217:27
patchbotpatch 521069 - python-ironic-inspector-client - Drop default URI, make either a session or inspect...17:27
milan_?17:27
milan_there's a bit of an (unintended?) discrepancy in exceptions in unittest17:27
* milan_ would a+ but probably would be nice to have a follow up17:28
milan_dtantsur|afk seems gone already ;)17:28
milan_sambetts, wdyt?17:28
* milan_ approved never mind :D17:30
*** penick has joined #openstack-ironic17:31
*** dsneddon has joined #openstack-ironic17:32
*** d0ugal has joined #openstack-ironic17:35
*** phuongnh has quit IRC17:36
*** trown is now known as trown|lunch17:36
*** amarao1 has quit IRC17:46
*** yangyapeng has joined #openstack-ironic17:49
*** derekh has quit IRC17:49
*** yangyapeng has quit IRC17:54
*** fragatina has quit IRC17:57
*** fragatina has joined #openstack-ironic18:01
*** absubram has quit IRC18:01
jlvillalSo where do we meet these days? Here?18:02
*** milan_ has quit IRC18:02
jlvillalOh, I forgot it isn't Monday. heh18:03
jlvillalJust because it is my first day back to work doesn't make it Monday :)18:03
NobodyCamWelcome back jlvillal :)18:06
jlvillalThanks NobodyCam :)18:07
*** srart has quit IRC18:09
*** srart has joined #openstack-ironic18:10
NobodyCam:)18:10
*** amarao has quit IRC18:11
openstackgerritMerged openstack/python-ironic-inspector-client master: Drop default URI, make either a session or inspector_url required  https://review.openstack.org/52106918:19
*** actatux has joined #openstack-ironic18:21
openstackgerritMichael Turek proposed openstack/ironic-python-agent master: Use LSHW in place of dmidecode for the default hardware manager  https://review.openstack.org/50179918:22
*** srart has quit IRC18:22
*** jkilpatr has quit IRC18:23
openstackgerritFellype Cavalcante proposed openstack/ironic master: [WIP/DNM] Migrate oneview driver to use python-hpOneView  https://review.openstack.org/52431018:25
vdrokgood morning all, rloo TheJulia NobodyCam and jlvillal18:35
vdrokTheJulia: reported https://bugs.launchpad.net/ironic/+bug/173551718:35
openstackLaunchpad bug 1735517 in Ironic "iscsi deploy interface triggers set boot device in case of adoption" [Medium,New] - Assigned to Vladyslav Drok (vdrok)18:36
NobodyCamGood Morning vdrok :)18:36
TheJuliavdrok: *sigh818:36
TheJuliasigh*18:36
rlooMorning vdrok!18:36
* TheJulia just lacks spoons right now18:36
openstackgerritJohn L. Villalovos proposed openstack/ironic-python-agent master: Fix issue with double mocking of utils.execute functions  https://review.openstack.org/52431218:36
NobodyCamno soup for you :p18:37
jlvillalHi vdrok :)18:37
*** trown|lunch is now known as trown18:37
*** jkilpatr has joined #openstack-ironic18:39
* TheJulia steps away for a little while18:40
*** absubram has joined #openstack-ironic18:43
*** crushil_ has quit IRC18:47
*** openstackgerrit has quit IRC18:48
*** pcaruana has joined #openstack-ironic18:50
*** openstackgerrit has joined #openstack-ironic18:52
openstackgerritJohn L. Villalovos proposed openstack/ironic-python-agent master: Fix issue with double mocking of utils.execute functions  https://review.openstack.org/52431218:53
*** srart has joined #openstack-ironic18:59
*** derekh has joined #openstack-ironic19:04
*** Goneri has quit IRC19:14
*** mat128_ has joined #openstack-ironic19:19
openstackgerritJohn L. Villalovos proposed openstack/ironic master: Fix issue with double mocking of utils.execute functions  https://review.openstack.org/52432119:21
*** mat128 has quit IRC19:22
*** dyasny has joined #openstack-ironic19:23
*** adisky_ has quit IRC19:30
*** serlex has joined #openstack-ironic19:33
*** serlex has quit IRC19:33
*** penick has quit IRC19:36
NobodyCamrloo: that is a awesome spec :) I left a question and comment.19:38
rlooNobodyCam: thx! looking...19:38
*** jkilpatr has quit IRC19:39
rlooNobodyCam: good point about the timeout. i need to see what we did for cleaning.19:39
*** penick has joined #openstack-ironic19:39
NobodyCam:)19:40
rlooNobodyCam: about a deploy_prepare state... I suppose that could be added in follow on work. i'm not quite sure where prepare starts & ends... and would it mean that we'd have a deploy_prepare_wait state too? I guess it depends on what 'prepare' means.19:40
NobodyCamI was just thinking that might be a clean way to identify where in the deploy process things went sideways19:42
*** rwsu has quit IRC19:42
NobodyCamie deploy breaks on deploy_prepare: I would;t have to trouble shoot the whole deploy process19:43
NobodyCamI just right in to the prepare steps and see whats up19:43
NobodyCamjust = jump19:44
NobodyCamwas just a thought I had while reading and in way the reason for the -119:44
NobodyCamin way == in NO way19:45
rlooNobodyCam: so i think when/if we break up the existing deployment process into separate steps, that will help. it'll be clearer at which step a deployment failed.19:45
* NobodyCam needs more ☕️19:45
*** yangyapeng has joined #openstack-ironic19:45
NobodyCam:)19:45
rlooNobodyCam: and i suspect there will be some 'prepare' or 'init', and some 'final' part of the deployment, i haven't actually looked at the code to see how to implement this :)19:46
*** crushil_ has joined #openstack-ironic19:46
NobodyCam:)19:46
rlooNobodyCam: I am hoping it will be obvious once the coding starts, and I think I will be coding it. (volunteers are of course, welcome!)19:47
rlooNobodyCam: i'll comment in the patch19:47
NobodyCam:) +++19:48
NobodyCamI'll do my best to assist19:48
*** yangyapeng has quit IRC19:50
*** akhilaki has quit IRC19:52
*** AlexeyAbashkin has joined #openstack-ironic19:52
*** rwsu has joined #openstack-ironic19:56
openstackgerritJohn L. Villalovos proposed openstack/ironic-lib master: Fix issue with double mocking of utils.execute functions  https://review.openstack.org/52432919:57
*** AlexeyAbashkin has quit IRC19:59
openstackgerritMerged openstack/ironic master: Add additional capabilities discovery for iRMC driver  https://review.openstack.org/41734720:00
openstackgerritMerged openstack/ironic master: Add information about neutron ML2 drivers to multitenancy docs  https://review.openstack.org/52339120:00
openstackgerritMerged openstack/ironic master: Updated from global requirements  https://review.openstack.org/52372920:00
*** crushil__ has joined #openstack-ironic20:00
openstackgerritJohn L. Villalovos proposed openstack/ironic-lib master: Fix issue with double mocking of utils.execute functions  https://review.openstack.org/52432920:03
*** crushil_ has quit IRC20:04
*** affie has joined #openstack-ironic20:05
*** AlexeyAbashkin has joined #openstack-ironic20:12
*** jtomasek has quit IRC20:13
*** AlexeyAbashkin has quit IRC20:17
*** rwsu has quit IRC20:19
*** penick has quit IRC20:24
*** Goneri has joined #openstack-ironic20:30
*** penick has joined #openstack-ironic20:36
*** e0ne has joined #openstack-ironic20:39
*** mgoddard has quit IRC20:43
*** penick has quit IRC20:47
*** penick has joined #openstack-ironic20:47
*** penick has quit IRC20:50
*** derekh has quit IRC20:52
*** pcaruana has quit IRC20:55
*** penick has joined #openstack-ironic20:55
*** e0ne has quit IRC20:58
*** akhilaki has joined #openstack-ironic21:06
*** bfournie has quit IRC21:07
*** jkilpatr has joined #openstack-ironic21:09
*** bfournie has joined #openstack-ironic21:10
*** bfournie has quit IRC21:12
*** threestrands has joined #openstack-ironic21:12
*** ccamacho has quit IRC21:21
*** pcaruana has joined #openstack-ironic21:24
*** pcaruana has quit IRC21:39
*** mat128_ has quit IRC21:39
*** bfournie has joined #openstack-ironic21:51
*** bfournie has quit IRC21:52
*** affie has quit IRC21:54
*** akhilaki has quit IRC22:01
*** affie has joined #openstack-ironic22:02
*** marlinc has quit IRC22:08
*** priteau has quit IRC22:13
*** rcernin has joined #openstack-ironic22:18
*** rcernin has quit IRC22:21
*** rcernin has joined #openstack-ironic22:21
*** marlinc has joined #openstack-ironic22:22
openstackgerritMerged openstack/ironic master: Fix HPE headers for oneview.  https://review.openstack.org/52397522:25
*** vsaienko has joined #openstack-ironic22:30
*** mjturek has quit IRC22:31
*** Goneri has quit IRC22:38
*** dyasny has quit IRC22:47
openstackgerritIlya Etingof proposed openstack/ironic master: devstack to `git pull sushy-tools` if required  https://review.openstack.org/52441722:47
*** rbudden has quit IRC22:49
*** affie has quit IRC22:52
*** affie has joined #openstack-ironic22:53
*** etingof has quit IRC22:53
*** akhilaki has joined #openstack-ironic23:02
*** akhilaki has quit IRC23:07
*** AlexeyAbashkin has joined #openstack-ironic23:12
*** dprince has quit IRC23:16
*** AlexeyAbashkin has quit IRC23:16
*** racedo_ has quit IRC23:19
*** bnemec has quit IRC23:22
*** athomas has quit IRC23:24
*** penick_ has joined #openstack-ironic23:47
*** penick has quit IRC23:49
*** etingof has joined #openstack-ironic23:59

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!