| *** hoonetorg has quit IRC | 00:02 | |
| *** zshi has joined #openstack-ironic | 00:14 | |
| *** hoonetorg has joined #openstack-ironic | 00:19 | |
| *** jlabarre has quit IRC | 00:31 | |
| *** rloo has quit IRC | 00:35 | |
| *** Nisha_Agarwal has quit IRC | 00:44 | |
| *** hw_wutianwei has joined #openstack-ironic | 00:58 | |
| *** zshi has quit IRC | 01:11 | |
| *** sasha2 has quit IRC | 01:13 | |
| *** zhangfei has joined #openstack-ironic | 01:16 | |
| *** zshi has joined #openstack-ironic | 01:25 | |
| *** charcol has joined #openstack-ironic | 02:03 | |
| *** zhangfei has quit IRC | 02:05 | |
| *** fragatina has quit IRC | 02:06 | |
| *** zhangfei has joined #openstack-ironic | 02:18 | |
| *** zshi has quit IRC | 02:19 | |
| *** ChubYann has quit IRC | 02:22 | |
| *** ChubYann has joined #openstack-ironic | 02:23 | |
| *** sai has quit IRC | 02:49 | |
| *** pc_m has quit IRC | 02:50 | |
| *** patchbot has quit IRC | 02:50 | |
| *** pc_m has joined #openstack-ironic | 02:50 | |
| *** fbouliane has quit IRC | 02:50 | |
| *** chihhsin_ has quit IRC | 02:50 | |
| *** etingof has quit IRC | 02:51 | |
| *** patriciadomin has quit IRC | 02:51 | |
| *** ChubYann has quit IRC | 02:51 | |
| *** hoonetorg has quit IRC | 02:51 | |
| *** jaypipes has quit IRC | 02:51 | |
| *** dmellado has quit IRC | 02:51 | |
| *** lifeless has quit IRC | 02:51 | |
| *** leifmadsen has quit IRC | 02:51 | |
| *** sai has joined #openstack-ironic | 02:52 | |
| *** chihhsin has joined #openstack-ironic | 02:52 | |
| *** oanson has quit IRC | 02:53 | |
| *** fbouliane has joined #openstack-ironic | 02:56 | |
| *** patriciadomin has joined #openstack-ironic | 02:56 | |
| *** leifmadsen has joined #openstack-ironic | 02:57 | |
| *** dmellado has joined #openstack-ironic | 02:57 | |
| *** lifeless has joined #openstack-ironic | 02:58 | |
| *** hw_wutianwei has quit IRC | 02:59 | |
| *** hw_wutianwei has joined #openstack-ironic | 03:00 | |
| *** oanson has joined #openstack-ironic | 03:00 | |
| *** hoonetorg has joined #openstack-ironic | 03:04 | |
| *** jaypipes has joined #openstack-ironic | 03:08 | |
| *** charcol-v2 has joined #openstack-ironic | 03:12 | |
| *** zhangfei has quit IRC | 03:13 | |
| *** retr0h has quit IRC | 03:14 | |
| *** charcol has quit IRC | 03:14 | |
| *** trown|outtypewww has quit IRC | 03:14 | |
| openstackgerrit | Vu Cong Tuan proposed openstack/sushy master: Do not use “-y” for package install https://review.openstack.org/518479 | 03:15 |
|---|---|---|
| *** mkrai has quit IRC | 03:16 | |
| *** csmart has quit IRC | 03:16 | |
| *** trown has joined #openstack-ironic | 03:16 | |
| *** zhangfei has joined #openstack-ironic | 03:26 | |
| *** links has joined #openstack-ironic | 03:34 | |
| openstackgerrit | Ruby Loo proposed openstack/ironic master: Pin API version during rolling upgrade https://review.openstack.org/518411 | 03:35 |
| *** rbudden has quit IRC | 03:37 | |
| *** zhangfei has quit IRC | 03:44 | |
| *** srart has quit IRC | 03:49 | |
| *** Nisha_Agarwal has joined #openstack-ironic | 03:53 | |
| *** huats has joined #openstack-ironic | 03:54 | |
| *** huats_ has quit IRC | 03:56 | |
| *** AlexeyAbashkin has joined #openstack-ironic | 03:58 | |
| *** zhangfei has joined #openstack-ironic | 04:00 | |
| openstackgerrit | Ruby Loo proposed openstack/ironic master: Update docs to include API version pinning https://review.openstack.org/518648 | 04:02 |
| *** AlexeyAbashkin has quit IRC | 04:02 | |
| *** srart has joined #openstack-ironic | 04:04 | |
| *** srart has quit IRC | 04:19 | |
| *** jtomasek has joined #openstack-ironic | 04:24 | |
| *** stendulker has joined #openstack-ironic | 04:26 | |
| *** fragatina has joined #openstack-ironic | 04:27 | |
| *** fragatina has quit IRC | 04:30 | |
| *** fragatina has joined #openstack-ironic | 04:30 | |
| *** jtomasek has quit IRC | 04:35 | |
| *** srart has joined #openstack-ironic | 04:35 | |
| *** zshi has joined #openstack-ironic | 04:36 | |
| *** ankkumar has joined #openstack-ironic | 05:00 | |
| *** jaganathan has joined #openstack-ironic | 05:14 | |
| *** fragatina has quit IRC | 05:32 | |
| *** mkrai has joined #openstack-ironic | 05:42 | |
| *** marios has joined #openstack-ironic | 05:46 | |
| *** dsneddon has quit IRC | 05:50 | |
| *** yee379 has joined #openstack-ironic | 06:08 | |
| *** pester has joined #openstack-ironic | 06:09 | |
| *** ckanade has joined #openstack-ironic | 06:11 | |
| *** mcarden_ has joined #openstack-ironic | 06:12 | |
| *** dpawar has joined #openstack-ironic | 06:13 | |
| *** zzzeek_ has joined #openstack-ironic | 06:14 | |
| *** zzzeek has quit IRC | 06:15 | |
| *** ionutbalutoiu has quit IRC | 06:15 | |
| *** fxpester has quit IRC | 06:15 | |
| *** yee37928 has quit IRC | 06:15 | |
| *** mcarden has quit IRC | 06:15 | |
| *** edleafe has quit IRC | 06:15 | |
| *** ionutbalutoiu has joined #openstack-ironic | 06:17 | |
| *** edleafe has joined #openstack-ironic | 06:18 | |
| *** asettle_ has joined #openstack-ironic | 06:21 | |
| *** csmart has joined #openstack-ironic | 06:22 | |
| *** retr0h has joined #openstack-ironic | 06:22 | |
| *** links has quit IRC | 06:22 | |
| *** andymccr has quit IRC | 06:22 | |
| *** asettle has quit IRC | 06:22 | |
| *** andymccr_ has joined #openstack-ironic | 06:22 | |
| *** lukl1 has quit IRC | 06:23 | |
| *** links has joined #openstack-ironic | 06:29 | |
| *** AlexeyAbashkin has joined #openstack-ironic | 06:34 | |
| *** tzumainn has quit IRC | 06:40 | |
| *** rwsu has joined #openstack-ironic | 06:43 | |
| *** mjura has joined #openstack-ironic | 06:46 | |
| *** hoonetorg has quit IRC | 06:48 | |
| *** Nisha_Agarwal has quit IRC | 06:53 | |
| *** dpawar has quit IRC | 06:54 | |
| *** Nisha_Agarwal has joined #openstack-ironic | 06:56 | |
| *** AlexeyAbashkin has quit IRC | 06:58 | |
| *** udesale has joined #openstack-ironic | 07:02 | |
| *** spectr has joined #openstack-ironic | 07:06 | |
| *** hoonetorg has joined #openstack-ironic | 07:07 | |
| *** fxpester has joined #openstack-ironic | 07:07 | |
| *** dr_gogeta86 has quit IRC | 07:09 | |
| *** EmilienM has quit IRC | 07:09 | |
| *** pester has quit IRC | 07:10 | |
| *** dpawar has joined #openstack-ironic | 07:25 | |
| *** rcernin has quit IRC | 07:45 | |
| *** rbartal has joined #openstack-ironic | 07:55 | |
| *** e0ne has joined #openstack-ironic | 07:58 | |
| *** tesseract has joined #openstack-ironic | 08:01 | |
| pas-ha | morning ironic :) | 08:06 |
| *** zhangfei has quit IRC | 08:07 | |
| *** e0ne has quit IRC | 08:07 | |
| *** Nisha_Agarwal has quit IRC | 08:08 | |
| *** mgoddard has joined #openstack-ironic | 08:11 | |
| *** Nisha_Agarwal has joined #openstack-ironic | 08:13 | |
| *** zhangfei has joined #openstack-ironic | 08:20 | |
| *** ralonsoh has joined #openstack-ironic | 08:20 | |
| *** marios has quit IRC | 08:28 | |
| *** d0ugal_ has quit IRC | 08:30 | |
| *** marios has joined #openstack-ironic | 08:30 | |
| *** d0ugal has joined #openstack-ironic | 08:30 | |
| *** d0ugal has quit IRC | 08:30 | |
| *** d0ugal has joined #openstack-ironic | 08:30 | |
| *** rcernin has joined #openstack-ironic | 08:37 | |
| *** jistr is now known as jistr|mtg | 08:48 | |
| *** dtantsur|afk is now known as dtantsur | 08:53 | |
| dtantsur | morning ironic | 08:53 |
| Nisha_Agarwal | morning dtantsur :) | 08:55 |
| dtantsur | any cores around? vdrok? | 08:59 |
| dtantsur | please check https://review.openstack.org/#/c/518570/ | 08:59 |
| *** zshi has quit IRC | 08:59 | |
| *** zshi has joined #openstack-ironic | 09:00 | |
| *** AlexeyAbashkin has joined #openstack-ironic | 09:01 | |
| vdrok | good morning ironic, pas-ha Nisha_Agarwal dtantsur | 09:01 |
| vdrok | will do | 09:01 |
| dtantsur | vdrok: morning, and also https://review.openstack.org/#/c/518557/ please | 09:11 |
| *** racedo has joined #openstack-ironic | 09:14 | |
| vdrok | dtantsur: done with first one | 09:23 |
| *** lucas-afk is now known as lucasagomes | 09:24 | |
| *** early has quit IRC | 09:30 | |
| *** EmilienM has joined #openstack-ironic | 09:31 | |
| *** early has joined #openstack-ironic | 09:31 | |
| *** hjensas has joined #openstack-ironic | 09:34 | |
| *** hjensas has joined #openstack-ironic | 09:34 | |
| *** dr_gogeta86 has joined #openstack-ironic | 09:35 | |
| *** dr_gogeta86 has quit IRC | 09:35 | |
| *** dr_gogeta86 has joined #openstack-ironic | 09:35 | |
| *** ankkumar_ has joined #openstack-ironic | 09:39 | |
| *** ankkumar has quit IRC | 09:39 | |
| *** ankkumar__ has joined #openstack-ironic | 09:40 | |
| dtantsur | thnx | 09:41 |
| *** zhangfei has quit IRC | 09:42 | |
| *** derekh has joined #openstack-ironic | 09:42 | |
| *** ankkumar_ has quit IRC | 09:44 | |
| *** akane has joined #openstack-ironic | 09:50 | |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic master: Clean up release notes from the upcoming release https://review.openstack.org/518570 | 09:56 |
| dtantsur | vdrok: ^^ | 09:56 |
| openstackgerrit | Merged openstack/sushy stable/pike: Add Zuul v3 jobs in tree https://review.openstack.org/518574 | 09:56 |
| *** MattMan_1 has joined #openstack-ironic | 10:05 | |
| *** MattMan has quit IRC | 10:05 | |
| *** Nisha_Agarwal has quit IRC | 10:07 | |
| *** ankkumar__ has quit IRC | 10:11 | |
| *** jistr|mtg is now known as jistr | 10:15 | |
| *** links has quit IRC | 10:15 | |
| *** dpawar has quit IRC | 10:17 | |
| *** ankkumar has joined #openstack-ironic | 10:19 | |
| *** amarao has joined #openstack-ironic | 10:26 | |
| *** amarao1 has joined #openstack-ironic | 10:27 | |
| ankkumar | Hi dtantsur | 10:27 |
| dtantsur | ankkumar: hi | 10:27 |
| ankkumar | dtantsur, regarding comment on https://review.openstack.org/#/c/515036/4/ironic_inspector/test/inspector_tempest_plugin/tests/test_basic.py, didnt get it | 10:28 |
| ankkumar | "this has to be moved somewhere else" this one | 10:28 |
| *** e0ne has joined #openstack-ironic | 10:32 | |
| openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic master: Add ansible deploy interface https://review.openstack.org/510522 | 10:41 |
| dtantsur | ankkumar: this line is not related to introspection data | 10:45 |
| dtantsur | so when you disable testing introspection data on python 3, this line has to be executed still | 10:45 |
| *** dtantsur is now known as dtantsur|bbl | 10:46 | |
| *** AlexeyAbashkin has quit IRC | 11:00 | |
| *** dpawar has joined #openstack-ironic | 11:02 | |
| ankkumar | dtantsur|bbl, thanks | 11:05 |
| *** j_b9d9 has joined #openstack-ironic | 11:07 | |
| j_b9d9 | Hello, guys. I've got a bunch of servers without IPMI modules which I still would like to manage with Ironic. I wander if it's possible at all to send ironic-python-agent commands from WoL driver? I'm still getting familiar with Ironic internals, so, my apologies if this question looks strange. Thanks. | 11:10 |
| *** etingof has joined #openstack-ironic | 11:11 | |
| openstackgerrit | Merged openstack/ironic master: devstack: Clean up some of the devstack code https://review.openstack.org/517063 | 11:12 |
| openstackgerrit | Merged openstack/ironic master: Clean up release notes from the upcoming release https://review.openstack.org/518570 | 11:12 |
| *** AlexeyAbashkin has joined #openstack-ironic | 11:13 | |
| *** zshi has quit IRC | 11:21 | |
| *** ricardoas has joined #openstack-ironic | 11:23 | |
| *** stendulker_ has joined #openstack-ironic | 11:24 | |
| *** dpawar has quit IRC | 11:25 | |
| *** rcernin has quit IRC | 11:26 | |
| *** stendulker has quit IRC | 11:26 | |
| *** stendulker_ has quit IRC | 11:29 | |
| *** jaganathan has quit IRC | 11:33 | |
| *** jkilpatr has quit IRC | 11:47 | |
| *** j_b9d9 has quit IRC | 11:53 | |
| *** karimb has joined #openstack-ironic | 11:55 | |
| *** j_b9d9 has joined #openstack-ironic | 12:06 | |
| *** Arkady has joined #openstack-ironic | 12:11 | |
| karimb | pas-ha would that do https://pastebin.com/ReXv3qeh? | 12:19 |
| karimb | regarding the ovirt review.... | 12:19 |
| *** milan has joined #openstack-ironic | 12:21 | |
| milan | morning Ironic! :) | 12:21 |
| *** jkilpatr has joined #openstack-ironic | 12:23 | |
| *** ankkumar has quit IRC | 12:24 | |
| *** marios has quit IRC | 12:28 | |
| *** marios has joined #openstack-ironic | 12:29 | |
| *** hw_wutianwei has quit IRC | 12:38 | |
| pas-ha | karimb: in the mock_extension_manager replace ipmi with staging-fake-ovirt. But I would also explore dtantsur|bbl 's hint that the general FakeHardware is accepting ANY power/mgmt interface (have not tried it myslef though) | 12:43 |
| pas-ha | morning milan | 12:43 |
| milan | morning pas-ha! :) | 12:44 |
| *** qsyqian has quit IRC | 12:52 | |
| *** racedo has quit IRC | 12:55 | |
| *** jlabarre has joined #openstack-ironic | 12:57 | |
| milan | aarefiev, dtantsur|bbl , morning folks! I have a +1 on dnsmasq thanks to vdrok ++; mind merging? ;) https://review.openstack.org/#/c/466448/ | 13:00 |
| milan | ?? all bots gone fishing ?? | 13:00 |
| milan | #pixiesay ...shroeding... | 13:01 |
| *** dtantsur|bbl is now known as dtantsur | 13:18 | |
| *** racedo has joined #openstack-ironic | 13:19 | |
| dtantsur | j_b9d9: hi! WOL driver should work for you. But did you consider the SNMP driver? You can probably get an SNMP device for your nodes | 13:19 |
| dtantsur | j_b9d9: the WOL driver has a problem: it cannot power off nodes | 13:19 |
| *** tzumainn has joined #openstack-ironic | 13:20 | |
| dtantsur | milan: do we have an ack from tripleo folks that supervisord is ok for them? | 13:20 |
| dtantsur | I did not review the patch solely because of it | 13:20 |
| *** rbartal has quit IRC | 13:20 | |
| milan | dtantsur, we don't have any definitive answer :-/ | 13:21 |
| dtantsur | milan: let's maybe ping e.g. dprince and ask him for an explicit ack | 13:21 |
| milan | dtantsur, do you think this patch makes sense outside of TripleO too? | 13:21 |
| dtantsur | saying, that we're going to commit to some architecture, and after the patch is merged, tripleo input may be ignored ;) | 13:22 |
| milan | I mean as it is with the start/stop thing | 13:22 |
| milan | dtantsur, but it's a driver, we can have a separate one :D | 13:22 |
| dtantsur | milan: I'm worried about tripleo simply because they'll come complaining to me :) | 13:22 |
| milan | yeah | 13:22 |
| * milan asks | 13:23 | |
| dtantsur | ricardoas, hi, around https://review.openstack.org/#/c/518046/ ? | 13:24 |
| * dtantsur looks for oneview folks | 13:24 | |
| dtantsur | milan: be sure to mention that we're not going to change everything, if after a few months they tell us they don't want supervisord :) | 13:26 |
| milan | lol | 13:27 |
| j_b9d9 | dtantsur: Hi and thank you! We don't have budget to buy anything | 13:35 |
| j_b9d9 | | at all. That's why I thought that I could use a WoL driver as base and add | 13:35 |
| j_b9d9 | | poweroff and reboot via ironic python agent somehow. | 13:35 |
| j_b9d9 | Sorry for the broken message, did a copy-paste. | 13:36 |
| dtantsur | j_b9d9: it should work, you just have to be careful about the current state | 13:36 |
| dtantsur | e.g. if you want to tear down a node, you have to power it off manually first, etc | 13:36 |
| *** dpawar has joined #openstack-ironic | 13:37 | |
| *** dpawar has quit IRC | 13:43 | |
| j_b9d9 | So, if I want to add poweroff and reboot via agent to the WoL driver, I'll have to somehow tarck existing AgentClient or spawn a | 13:43 |
| j_b9d9 | ... Spawn a new one from the WakeOnLanPower class? | 13:43 |
| dtantsur | j_b9d9: I don't think this idea will work. how do you reboot something via agent when a user's instance is there? | 13:44 |
| *** rloo has joined #openstack-ironic | 13:44 | |
| j_b9d9 | dtantsur, Should actually work since I need it only for initial deployment. Any time I'll want to rebuild node, I can power it off from the OS, since I and my team are the only users. | 13:46 |
| dtantsur | j_b9d9: for initial deployment WOL should work too, as the reboot happens in-band | 13:47 |
| dtantsur | I mean, it should already work | 13:47 |
| j_b9d9 | So, I don't even need any modifications since reboot and shutdown actions during deployment are initiated by the AgentClient nstead of WoL power driver? | 13:49 |
| dtantsur | j_b9d9: the final reboot - yes | 13:49 |
| j_b9d9 | And what about cleaning steps? | 13:50 |
| dtantsur | j_b9d9: I don't remember from the top of my head, maybe not | 13:50 |
| j_b9d9 | Ok, I'll try it. Many thanks. :) | 13:51 |
| dtantsur | np, let us know how it goes | 13:52 |
| *** rbudden has joined #openstack-ironic | 13:52 | |
| rloo | hello and good morning ironic'ers, dtantsur, j_b9d9, vdrok | 13:56 |
| dtantsur | morning rloo | 13:56 |
| vdrok | good morning rloo | 13:56 |
| j_b9d9 | Morning, rloo! | 13:57 |
| *** sasha2 has joined #openstack-ironic | 14:00 | |
| *** cdearborn has joined #openstack-ironic | 14:00 | |
| *** udesale has quit IRC | 14:02 | |
| *** cdearborn_ has joined #openstack-ironic | 14:02 | |
| *** crushil has joined #openstack-ironic | 14:04 | |
| *** cdearborn has quit IRC | 14:04 | |
| rloo | vdrok, dtantsur: if you have a minute (or two, literally), this can be blessed easily I think: https://review.openstack.org/#/c/518704/ | 14:09 |
| dtantsur | +A | 14:10 |
| rloo | thx dtantsur. we are *almost* done with migrating the legacy* jobs. I see light at the end of this tunnel :) | 14:12 |
| dtantsur | yeah.. | 14:12 |
| milan | morning rloo! :) | 14:13 |
| rloo | hi milan! | 14:13 |
| rloo | dtantsur: do you need me for anything related to release stuff? looks like you're good except for that oneview question? | 14:16 |
| dtantsur | rloo: seems so.. | 14:16 |
| rloo | dtantsur: good, let's get those releases out soon then! | 14:17 |
| dtantsur | nothing on my radar, but I can barely think recently | 14:17 |
| *** j_b9d9 has quit IRC | 14:17 | |
| rloo | dtantsur: ?huh? partying too much? | 14:17 |
| dtantsur | yeah, checking if the release team is around now | 14:17 |
| dtantsur | rloo: I wish so... too much post-relocation non-sense | 14:17 |
| dtantsur | rloo: like, I'm in a flat without furniture (mostly) and a washing machine | 14:17 |
| rloo | dtantsur: ouch, thought you were done that. well, it will be worth it... | 14:18 |
| dtantsur | and I'm doomed to stay in this condition for weeks to come | 14:18 |
| dtantsur | no matter what we do | 14:18 |
| rloo | dtantsur: ah, that rings bells for me. why for weeks? can't you bring in furniture, etc? | 14:18 |
| dtantsur | and then banking system in Germany is garbage | 14:18 |
| dtantsur | rloo: because IKEA delivery was delayed for 2 weeks \o/ | 14:18 |
| rloo | dtantsur: :-( | 14:18 |
| dtantsur | and we already payed for it, of course | 14:18 |
| * dtantsur is drinking whiskey in the middle of the day in frustration | 14:19 | |
| rloo | dtantsur: seriously, when i lived in germany many moons ago, we scrounged around for furniture and bought a 2nd hand washing machine. | 14:19 |
| rloo | dtantsur: i lived out of my suitcase. literally. but then, i was only there for a few months, not like you... | 14:19 |
| dtantsur | we have a washing machine from the landlord. first it was improperly connected, now after fixing that we figured out it's broken | 14:20 |
| rloo | dtantsur: as long as you're ready in a year, when the ironic'ers will descend on you :D | 14:20 |
| rloo | dtantsur: :-( | 14:20 |
| dtantsur | if I don't rage-quit by that time - totally | 14:20 |
| dtantsur | I'm hoping to be set up by x-mas | 14:21 |
| rloo | dtantsur: and a merry christmas present that will be! | 14:21 |
| dtantsur | sure.. if that does happen, and I'll survive this period of non-ending frustration | 14:21 |
| * dtantsur should probably stop complaining and get back to work | 14:22 | |
| dtantsur | or to whiskey. or both. | 14:22 |
| vdrok | dtantsur: woah :( | 14:23 |
| rloo | dtantsur: get back to work now, whiskey tonight :) | 14:23 |
| vdrok | dtantsur: have you tried those small ultrasound things instead of washing machines? :) | 14:24 |
| dtantsur | they're usually quite inefficient | 14:24 |
| *** akane has quit IRC | 14:34 | |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic-python-agent master: Add timeout to all requests made via requests lib https://review.openstack.org/518322 | 14:36 |
| *** asettle_ is now known as asettle | 14:42 | |
| *** andymccr_ is now known as andymccr | 14:42 | |
| *** ralonsoh has quit IRC | 14:44 | |
| *** ralonsoh has joined #openstack-ironic | 14:44 | |
| *** crushil has quit IRC | 14:48 | |
| *** e0ne has quit IRC | 14:59 | |
| *** dtantsur is now known as dtantsur|bbl | 15:02 | |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic-python-agent master: Add timeout to all requests made via requests lib https://review.openstack.org/518322 | 15:03 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic-python-agent master: Use oslo_config.fixture in unit tests https://review.openstack.org/518745 | 15:03 |
| *** j_b9d9 has joined #openstack-ironic | 15:09 | |
| openstackgerrit | John L. Villalovos proposed openstack/ironic-python-agent master: Clean-up zuul.d/ files https://review.openstack.org/518613 | 15:17 |
| *** milan has quit IRC | 15:17 | |
| openstackgerrit | John L. Villalovos proposed openstack/ironic-lib master: zuul: Centralize irrelevant-files in legacy-ironic-lib-dsvm-base https://review.openstack.org/518622 | 15:20 |
| *** trown is now known as trown|brb | 15:25 | |
| *** tzumainn has quit IRC | 15:26 | |
| *** crushil has joined #openstack-ironic | 15:27 | |
| *** trown|brb is now known as trown | 15:35 | |
| *** spectr has quit IRC | 15:35 | |
| *** spectr has joined #openstack-ironic | 15:37 | |
| JayF | dtantsur|bbl: I have extended family in Germany! Glad to hear you got moved over there. Have some of that tasty warm potato salad for me :D | 15:37 |
| *** patriciadomin has quit IRC | 15:38 | |
| openstackgerrit | Ruby Loo proposed openstack/ironic-python-agent master: Fix off-by-one error in warning https://review.openstack.org/516693 | 15:42 |
| openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic master: Rework keystone auth for glance https://review.openstack.org/467728 | 15:45 |
| openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic master: Use adapters for cinderclient https://review.openstack.org/476171 | 15:45 |
| openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic master: Use adapters for inspectorclient https://review.openstack.org/476172 | 15:45 |
| openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic master: Fix swiftclient creation https://review.openstack.org/476173 | 15:45 |
| openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic master: Use adapters for neutronclient https://review.openstack.org/476170 | 15:45 |
| openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic master: Finalize migration to keystoneauth adapters https://review.openstack.org/478825 | 15:45 |
| *** dtantsur|bbl is now known as dtantsur | 15:52 | |
| dtantsur | JayF: totally :) | 15:52 |
| dtantsur | JayF: lemme know if you even pass by Berlin | 15:52 |
| *** patriciadomin has joined #openstack-ironic | 15:55 | |
| JayF | dtantsur: absolutely. Probably years though :P. | 15:58 |
| *** Nisha_Agarwal has joined #openstack-ironic | 15:59 | |
| *** spectr has quit IRC | 16:00 | |
| dtantsur | heh, ok :) | 16:03 |
| *** AlexeyAbashkin has quit IRC | 16:08 | |
| jlvillal | dtantsur, reading back-scroll. Sorry to hear about the flat issues :( I hope it gets resolved soon! | 16:11 |
| *** mjura has quit IRC | 16:12 | |
| dtantsur | thanks! | 16:12 |
| *** j_b9d9 has quit IRC | 16:16 | |
| *** v12aml has joined #openstack-ironic | 16:23 | |
| *** tesseract has quit IRC | 16:27 | |
| dtantsur | I have a feeling that release notes update does not work.. | 16:28 |
| dtantsur | https://docs.openstack.org/releasenotes/ironic/unreleased.html does not include my today's patch, at least | 16:28 |
| *** tzumainn has joined #openstack-ironic | 16:29 | |
| dtantsur | or updating the files does not work, I'm not sure | 16:29 |
| *** Arkady has quit IRC | 16:30 | |
| *** fragatina has joined #openstack-ironic | 16:32 | |
| *** fragatina has quit IRC | 16:33 | |
| *** fragatina has joined #openstack-ironic | 16:33 | |
| *** makowals has quit IRC | 16:34 | |
| *** e0ne has joined #openstack-ironic | 16:34 | |
| ricardoas | hey dtantsur! | 16:34 |
| dtantsur | ricardoas: this is re https://review.openstack.org/#/c/518046/ I think it should go into the release I'm planning on. but it needs figuring out if it's actually a deprecation or a removal | 16:36 |
| ricardoas | dtantsur: we were just talking about this patch a few minutes ago... i think we should not deprecate de parameters | 16:36 |
| dtantsur | ricardoas: so, what do you plan to do? | 16:37 |
| ricardoas | the point is that hpOneView does not support certificates yet... I´d suggest to leave an opened bug explaining that these certificates are not being used and I´ll open a request to python-hpOneView team | 16:38 |
| rloo | dtantsur: wrt the release notes not being updated, i've noticed in the past, that some docs don't get updated right away, not sure if it takes a day or what. but i don't recall now if it was release notes or some of our other docs. | 16:38 |
| dtantsur | rloo: AJaeger suggests that there could be a race between two post jobs | 16:38 |
| *** fragatina has quit IRC | 16:38 | |
| dtantsur | I'm looking for a change to approve to see :) | 16:38 |
| *** marios has quit IRC | 16:38 | |
| rloo | dtantsur: oh, interesting | 16:38 |
| rloo | dtantsur: yeah, best to see first :) | 16:39 |
| dtantsur | ricardoas: so, what to do about these params? we cannot just leave them no-op | 16:39 |
| ricardoas | dtantsur: I´m really sorry for not foreseen this before starting the migration... | 16:40 |
| ricardoas | dtantsur: not sure what are the options... i)delete? ii)deprecate? iii) leave them as they are? | 16:41 |
| dtantsur | ricardoas: happens. now I'm thinking about the best way out. I think we should 1. update their description to mark them as no-op, 2. issue a warning if they are set, 3. create a detailed release note, explaining the change | 16:41 |
| dtantsur | rloo: ^^^: | 16:41 |
| ricardoas | dtantsur: if we remove maybe we will need to add them again once this is implemented at hpOneView | 16:41 |
| TheJulia | O/ | 16:41 |
| TheJulia | Err | 16:41 |
| rloo | dtantsur: argh. i'd open a bug and mention in the release notes that there is a bug. | 16:41 |
| TheJulia | o/ | 16:42 |
| dtantsur | hi TheJulia, how is your travel? | 16:42 |
| TheJulia | Two more flights to get home | 16:42 |
| TheJulia | I’m le tired | 16:42 |
| dtantsur | ricardoas: I don't suggest to remove the options, but we need to indicate very clearly that they don't work | 16:42 |
| TheJulia | Jet lag most likely the next few days :( | 16:42 |
| dtantsur | TheJulia: :( I'm sorry for you. I hope you at least enjoyed the forum | 16:42 |
| rloo | dtantsur: i don't really want/think, at this point in time, that it is worth updating the code, just before a release. it isn't the last/official queens release so i don't want this to be too much work. | 16:42 |
| * rloo regrets that the oneview migration code got merged | 16:43 | |
| TheJulia | dtantsur: It was quite a bit, and we have some useful feedback. I’ve been working on writing it all up. I think I have two more etherpads to go | 16:43 |
| dtantsur | rloo: it's not too much work to issue a warning and change descriptions | 16:43 |
| dtantsur | rloo: and we don't have a timeline for fixing this, so it may slip into the stable branch potentially | 16:43 |
| rloo | dtantsur: i have better things to do than baby sit that, regardless of how much work it is. up to you though. | 16:43 |
| dtantsur | TheJulia: awesome! | 16:43 |
| *** mat128 has joined #openstack-ironic | 16:44 | |
| dtantsur | rloo: I don't see options for me. I cannot accept releasing with several potentially important options *silently* broken. | 16:44 |
| dtantsur | I want them at least to be vocally broken :) | 16:44 |
| TheJulia | dtantsur: We might want to heavily evaluate and use the feedback to be something that guides us, since we actually had operator presence *gasp* | 16:44 |
| rloo | TheJulia: awesome, about operator presence! | 16:45 |
| dtantsur | TheJulia: \o/ | 16:45 |
| TheJulia | dtantsur: so, not fully aware, but there is this revert button that is handy :( | 16:45 |
| TheJulia | dtantsur: actually, instead of the word revert, the word must is the correct word | 16:45 |
| TheJulia | Err | 16:45 |
| TheJulia | Reevaluate | 16:45 |
| TheJulia | Blah! | 16:45 |
| * TheJulia clearly needs sleep/food/etc | 16:45 | |
| dtantsur | TheJulia: it will involve reverting several big patches, but it may be the key | 16:45 |
| TheJulia | I would only ask, what is actually broken, and is it _really_ broken | 16:46 |
| dtantsur | TheJulia: these 3 options became no-op without a prior warning: https://review.openstack.org/#/c/518046/2/ironic/conf/oneview.py | 16:47 |
| ricardoas | dtantsur rloo: I´m against the silently broken think too! | 16:47 |
| rloo | ricardoas: is this going to break your users? | 16:47 |
| rloo | ricardoas: it seems like a security risk | 16:47 |
| dtantsur | I envision breaking people with self-signed certificates | 16:48 |
| rloo | ricardoas: if so, and folks think it is working and it isn't and there's no way to have secure/certificates, then it is broken | 16:48 |
| ricardoas | dtantsur: rloo: afaik it avoids somebody to fake being oneview | 16:48 |
| * rloo thinks we need to revert and go back to using the old libraries | 16:48 | |
| dtantsur | ricardoas: right, but what about self-signed certificates? | 16:48 |
| dtantsur | I see them quite regularly out there | 16:48 |
| rloo | is it 'just' one patch that we can revert, to go back to the old libraries? | 16:48 |
| dtantsur | will folks be able to at least use http (not https)? | 16:49 |
| dtantsur | rloo: 3? something like that | 16:49 |
| TheJulia | dtantsur: The first makes sense, https is mandatory for oneview... the latter is the big eye raiser, but even then, I wouldn’t consider that too horrible of a big deal aside from visibility if someone went way agrainst the grain and setup an insecure http endpoint by hand. :( Not great, | 16:49 |
| rloo | dtantsur: so it is all 3 or none? I thought the patches were done so that the switch wasn't turned on until the last patch. LE BIG SIGH. | 16:49 |
| dtantsur | rloo: no, it was a step-by-step switch, I think | 16:49 |
| TheJulia | Not great, but .... in the grand scheme of the universe, in a world where our velocity is tied to our success, where do we balance the decision point | 16:50 |
| * TheJulia is just off in the corner rambling | 16:50 | |
| rloo | TheJulia: if there is any security risk, we cannot release | 16:50 |
| rloo | TheJulia: 'more' security risk than had been there before... | 16:50 |
| TheJulia | Well | 16:50 |
| dtantsur | I don't think it's a security risk | 16:50 |
| TheJulia | Let’s define what the risks are | 16:50 |
| dtantsur | I think that if somebody used a self-signed certificate, they're going to be hard-broken without a workaround | 16:50 |
| dtantsur | maybe I misunderstand the situation, please correct me then | 16:51 |
| TheJulia | Because, I kind of agree, there is no security risk. It is CA cert management possible changes or operators, retries, and mandatory https usage | 16:51 |
| TheJulia | dtantsur: eh, they can just add their self-signed cert to the CA certificate repository | 16:51 |
| TheJulia | It is sadly, crazy common thing that is done | 16:51 |
| dtantsur | well, it's a crazy thing indeed :) does it use the repository though? | 16:52 |
| TheJulia | Which one?!? | 16:52 |
| dtantsur | I mean, I recall python-requests having some weirdness around where it takes root certificates from | 16:52 |
| TheJulia | I mean, there are what... 3-4 different ones in any Linux install | 16:52 |
| dtantsur | https://stackoverflow.com/questions/10667960/python-requests-throwing-up-sslerror/33717517#33717517 | 16:53 |
| TheJulia | Oh, right, that is a fun one! Is it even using python-requests, or is it using the underlying OpenSSL default locals? | 16:53 |
| TheJulia | I feel like... minor things are going to break, especially with connection parameters. It is not great, we can do our best. I don’t think this is worth reverting, but... UGH. Fun bug in the library not having the same options, and I’ll bet it was a security decision for more strict security. | 16:54 |
| TheJulia | Anyway, I need to go find food. Feel free to blame me for all things | 16:54 |
| dtantsur | sure ;) | 16:54 |
| *** fellypefca has joined #openstack-ironic | 16:55 | |
| rloo | It is TheJulia's fault that I'm hungry | 16:55 |
| TheJulia | rloo:yes | 16:55 |
| dtantsur | I'm on board with "let's not revert", to be honest. but I'd like the 3 things I asked above | 16:55 |
| dtantsur | ++ to hungry | 16:55 |
| TheJulia | Everyone go eat! | 16:55 |
| * TheJulia changes the topic to “Nomming party!” | 16:55 | |
| dtantsur | lol | 16:55 |
| rloo | ricardoas: what do you think/suggest? your team needs to take ownership of this problem | 16:55 |
| ricardoas | dtantsur: not sure about this scenario... we use self-signed (generated by oneview during instalation). But if you shutdown oneview and somebody deploy something else using the same ip there´s no way for ironic to know it is not talking to oneview anymore | 16:56 |
| *** xavier1 has joined #openstack-ironic | 16:56 | |
| dtantsur | ricardoas: how to you specify self-signed certificates, if tls_cacert_file no longer works? | 16:56 |
| ricardoas | rloo: hpOneView does not verify that... it just relies on username password for connectiong to OneView | 16:57 |
| ricardoas | dtantsur: ^ | 16:57 |
| dtantsur | wait please | 16:58 |
| dtantsur | does not verify what? | 16:58 |
| ricardoas | dtantsur: sorry... let me start again | 16:58 |
| * rloo wonders, in future, whether switching drivers should mean 1. deprecation period where both libraries can be used; 2. removal of old libraries after deprecation period... | 16:59 | |
| *** nicodemos has joined #openstack-ironic | 16:59 | |
| * rloo meant s/drivers/libraries/ | 16:59 | |
| dtantsur | and won't https://github.com/HewlettPackard/python-hpOneView/blob/master/hpOneView/connection.py#L94 do the SSL thing? | 17:00 |
| ricardoas | dtantsur: python-hpOneView uses (ip, username, password) to connect do oneview | 17:00 |
| dtantsur | https://github.com/HewlettPackard/python-hpOneView/blob/master/hpOneView/connection.py#L219 oh. my. god. | 17:01 |
| dtantsur | I'm starting to err on the "revert" side :( | 17:01 |
| dtantsur | ricardoas: let me put it simple: unlike oneviewclient, hpOneView does not do proper HTTPs by default | 17:01 |
| ricardoas | dtantsur: agreed | 17:02 |
| dtantsur | in our terms, it defaults to allow_insecure_connections=True | 17:02 |
| *** fragatina has joined #openstack-ironic | 17:02 | |
| ricardoas | dtantsur: agreed too | 17:02 |
| dtantsur | how you put it "if you shutdown oneview and somebody deploy something else using the same ip there´s no way for ironic to know it is not talking to oneview anymore" | 17:03 |
| dtantsur | which is a security regression, rloo is absolutely right | 17:03 |
| *** makowals has joined #openstack-ironic | 17:03 | |
| ricardoas | dtantsur: rloo: I understand... then reverting is our best option now, right? | 17:05 |
| rloo | ricardoas: how do you think your users would feel if they upgraded to this... based on the above, i think we ought to revert | 17:05 |
| dtantsur | mmmmm... I'm afraid yes | 17:06 |
| dtantsur | ricardoas: what was oneviewclient default wrt https? | 17:07 |
| ricardoas | rloo: I´m not sure... current users I know are not using this cert verification | 17:07 |
| rloo | ricardoas: it is too risky. even compromising one of your users would be bad | 17:07 |
| rloo | especially this discussion is out in the open | 17:08 |
| dtantsur | so, oneviewclient uses secure HTTPs by default, and this sounds like a security-related regression | 17:08 |
| dtantsur | hpOneView library defaults are really, really bad | 17:09 |
| ricardoas | rloo: yeah... I agree with you | 17:09 |
| rloo | dtantsur, ricardoas: this is going to be fun, reverting X patches. I think if we do it, we start with the latest... how many patches are we talking about? | 17:10 |
| ricardoas | dtantsur: looking at python-oneviewclient... it uses https with certificate | 17:11 |
| fellypefca | 4 patches I guess | 17:11 |
| rloo | dtantsur: and we modified/deleted some of the release notes i think; wonder how that will affect the revert | 17:11 |
| dtantsur | rloo: it will give conflicts, of course \o/ | 17:11 |
| dtantsur | 3 or 4 patches, yes | 17:11 |
| dtantsur | ricardoas, fellypefca, I don't want to offend anyone, but from a quick glance the code of python-oneviewclient looks better than one of hpOneView | 17:12 |
| dtantsur | I'm sad you have to switch, but I understand it | 17:12 |
| fellypefca | dtantsur we agree with that.. | 17:13 |
| rloo | dtantsur: good thing you noticed this before the release! | 17:13 |
| dtantsur | heh.. only because the guys put up that patch to deprecate the options | 17:14 |
| rloo | ricardoas: do you/your team know how to do reverts? | 17:15 |
| ricardoas | rloo: I´m collecting all patches we need to do this... I haven´t done it before but I can try | 17:16 |
| rloo | ricardoas: thx | 17:16 |
| rloo | dtantsur: how do you want to track this, given that we're in diff time zones, etc. we can note in our whiteboard, or open a bug, or ? | 17:16 |
| openstackgerrit | Ramamani Yeleswarapu proposed openstack/ironic master: Add missing 'autospec' to unit tests - /unit/objects/ https://review.openstack.org/517168 | 17:17 |
| rloo | dtantsur: how about whiteboard, in the Drivers/OneView section? | 17:17 |
| dtantsur | rloo: I think 4 reverts is something we can keep in our heads, but I'm open to ideas. we can use "vendor" section in the priorities | 17:17 |
| dtantsur | or that one, yes | 17:17 |
| ricardoas | dtantsur: rloo: not sure it will be only 4 patches... there are new features using hpOneView | 17:18 |
| rloo | dtantsur: ok. 'we' can keep in our heads, but i think others might want/need to know too :) | 17:18 |
| *** rama_y has joined #openstack-ironic | 17:18 | |
| *** fragatina has quit IRC | 17:18 | |
| ricardoas | dtantsur: will queens release be cut today? | 17:18 |
| rloo | ricardoas: ok, let us know. rather, please update https://etherpad.openstack.org/p/IronicWhiteBoard, L326, with list of patches to revert | 17:19 |
| dtantsur | ricardoas: no, it will be cut when we're done with these reverts | 17:19 |
| dtantsur | preferably, early next week | 17:19 |
| ricardoas | dtantsur: I can try working with python-hpOneView team to launch a new version implementing this cert verification | 17:19 |
| fellypefca | 6 patches actually | 17:19 |
| dtantsur | ricardoas: you mean, in the coming days? | 17:19 |
| dtantsur | 6 patches, oh | 17:20 |
| ricardoas | dtantsur: yes! | 17:21 |
| dtantsur | ricardoas: when do you realistically expect that to happen? | 17:21 |
| ricardoas | dtantsur: we could at least work with them to incorporate the validation python-oneviewclient already does... | 17:21 |
| dtantsur | ricardoas: all I need is 1. HTTPS validation by default, 2. option to provide custom CA, 3. option to disable validation | 17:22 |
| dtantsur | but I'm not sure how fast their processes are | 17:22 |
| rloo | ricardoas: i think this is penance, we should revert. | 17:22 |
| dtantsur | this should be a small change IMO, but dunno | 17:22 |
| ricardoas | dtantsur: I need to talk to somebody from HPE before... it could take a week | 17:23 |
| ricardoas | dtantsur: rloo: but if you guys need this now, we can surely revert and resubmit everything once this is fixed there... | 17:24 |
| *** efried is now known as efried_afk | 17:24 | |
| dtantsur | a week does not sound reassuring, to be honest | 17:24 |
| ricardoas | dtantsur: rloo: reverting it is then... | 17:24 |
| dtantsur | yes. sorry for not catching this issue earlier | 17:24 |
| dtantsur | I do hope we did not release any parts of this chain :) | 17:25 |
| rloo | ricardoas: thanks! something to think about too -- why didn't any (unit) test catch that those configs weren't being used and that the functionality disappeared. if possible, it would be good to add in... | 17:26 |
| ricardoas | dtantsur: rloo: and I´m really sorry for missing this and for all your wasted time | 17:26 |
| *** lucasagomes is now known as lucas-afk | 17:26 | |
| rloo | ricardoas: no worries, that's the way it goes. hopefully, we'll all learn something from this experience :) | 17:26 |
| dtantsur | no worries, let's make it right now | 17:26 |
| dtantsur | as an aside, I'm not pleased with https handling in our drivers | 17:27 |
| openstackgerrit | John L. Villalovos proposed openstack/ironic-python-agent master: Clean-up zuul.d/ files https://review.openstack.org/518613 | 17:27 |
| dtantsur | e.g. self-signed certificates are pain with most of the drivers | 17:27 |
| fellypefca | dtantsur rloo yeah.. really really sorry for this. :/ We will work on that. | 17:27 |
| dtantsur | thanks! | 17:27 |
| openstackgerrit | John L. Villalovos proposed openstack/ironic-lib master: zuul: Centralize irrelevant-files in legacy-ironic-lib-dsvm-base https://review.openstack.org/518622 | 17:33 |
| * jlvillal hopes that makes vsaienk0 happy :) | 17:34 | |
| *** ralonsoh has quit IRC | 17:35 | |
| *** amarao1 has quit IRC | 17:39 | |
| openstackgerrit | Ramamani Yeleswarapu proposed openstack/ironic master: Fail deploy if agent returns >= 400 https://review.openstack.org/269311 | 17:40 |
| *** amarao has quit IRC | 17:44 | |
| *** fragatina has joined #openstack-ironic | 17:44 | |
| *** makowals has quit IRC | 17:48 | |
| *** makowals has joined #openstack-ironic | 17:52 | |
| *** dtantsur is now known as dtantsur|afk | 17:54 | |
| dtantsur|afk | o/ | 17:54 |
| *** racedo has quit IRC | 17:56 | |
| windsn | Hey guys, i'm trying to load a baremetal node, but keep running into "No Valid hosts found (Retry filter fails), and all i can find in nova logs is https://thepasteb.in/p/Elh1x6LZGAwSm. What could this be caused by ? I'm on the Newton release. Thanks | 17:58 |
| openstackgerrit | Hugo Nicodemos proposed openstack/ironic master: Revert "Update python-ilorest-library to hardware type OneView" https://review.openstack.org/518766 | 17:58 |
| *** derekh has quit IRC | 18:02 | |
| ricardoas | rloo: should we open all reverts or is it easier to do it iteratively with you folks? | 18:04 |
| openstackgerrit | Stenio Araujo proposed openstack/ironic master: Revert "Get a new OneView client when needed" https://review.openstack.org/518768 | 18:05 |
| rloo | ricardoas: good question. i think open them all. what i don't know is how it is handled, because the subsequent reverts depend on each other. | 18:05 |
| rloo | ricardoas: it will be a learning experience! | 18:06 |
| ricardoas | rloo: ok! :) | 18:06 |
| openstackgerrit | Hugo Nicodemos proposed openstack/ironic master: Revert "Remove python-oneviewclient from Ironic OneView drivers" https://review.openstack.org/518769 | 18:07 |
| openstackgerrit | Hugo Nicodemos proposed openstack/ironic master: Revert "Migrate python-oneviewclient validations to Ironic OneView drivers" https://review.openstack.org/518770 | 18:07 |
| openstackgerrit | Hugo Nicodemos proposed openstack/ironic master: Revert "Add a timeout for powering on/off a node on HPE OneView Driver" https://review.openstack.org/518771 | 18:07 |
| openstackgerrit | Xavier proposed openstack/ironic master: Revert "Fix persistent information when getting boot device" https://review.openstack.org/518772 | 18:09 |
| openstackgerrit | Xavier proposed openstack/ironic master: Revert "Migrate oneview driver to use python-hpOneView" https://review.openstack.org/518773 | 18:09 |
| openstackgerrit | Stenio Araujo proposed openstack/ironic master: Revert "Introduce hpOneView and ilorest to OneView" https://review.openstack.org/518774 | 18:10 |
| *** trown is now known as trown|lunch | 18:10 | |
| *** AlexeyAbashkin has joined #openstack-ironic | 18:17 | |
| rloo | ricardoas etc: please update the whiteboard, L337, with links to all the revert patches. order them in the order that they should be reverted. | 18:18 |
| rloo | https://etherpad.openstack.org/p/IronicWhiteBoard | 18:18 |
| ricardoas | rloo: oops... I already did on L120... I will update there too | 18:19 |
| rloo | ricardoas: ah, ok that is fine then, no sense copy/pasting. | 18:19 |
| ricardoas | rloo: which place is better for core rev to check? | 18:20 |
| rloo | ricardoas: it doesn't matter, so just leave it where it is | 18:20 |
| ricardoas | rloo: ok | 18:20 |
| rloo | ricardoas: thx! | 18:21 |
| *** j_b9d9 has joined #openstack-ironic | 18:21 | |
| *** AlexeyAbashkin has quit IRC | 18:29 | |
| *** racedo has joined #openstack-ironic | 18:31 | |
| jlvillal | ricardoas: rloo: Can we get a reason listed for why we are reverting in the commit message? | 18:37 |
| jlvillal | I am not a fan of a revert without a reason being put in the commit message. | 18:37 |
| rloo | jlvillal: i don't know how we deal with reverts so whatever... | 18:37 |
| rloo | jlvillal: there aren't any guidelines, are there? | 18:38 |
| jlvillal | rloo: Well if I am reviewing a patch, the commit message should explain why. | 18:38 |
| jlvillal | rloo: A revert isn't that special. It still should have justification listed for why it is doing the revert in the commit message. | 18:38 |
| rloo | jlvillal: if you have time, would you please help out and read the discussion see IRC discussion: http://eavesdrop.openstack.org/irclogs/%23openstack-ironic/%23openstack-ironic.2017-11-09.log.html#t2017-11-09T16:39:34 | 18:39 |
| rloo | jlvillal: and suggest what to put in the commit that would satisfy you. | 18:39 |
| rloo | jlvillal: i'm trying to spread out the work here | 18:39 |
| rloo | jlvillal: and not block those reverts, so let's get the commit msg correct and update them all. | 18:39 |
| jlvillal | rloo: Okay | 18:40 |
| rloo | jlvillal: thx | 18:41 |
| jlvillal | rloo: ricardoas: I'm fine with something simple like: Reverting these changes because they don't work and could cause a possible security issue. | 18:41 |
| ricardoas | jlvillal: also... they´re supposed to be reverted in the order i specified at L121 in https://etherpad.openstack.org/p/IronicWhiteBoard | 18:41 |
| jlvillal | rloo: ricardoas: If that works for you | 18:41 |
| ricardoas | jlvillal: do you think I should warn about this in the commit message too to avoid confusion? | 18:42 |
| rloo | jlvillal: it works for me. | 18:42 |
| jlvillal | ricardoas: That is what I want. In each commit message, the reason why. | 18:42 |
| jlvillal | ricardoas: I was only talking about the commit message. What were you thinking of? | 18:43 |
| ricardoas | jlvillal: cool... I´ll assume that you will merge them in the order on the whiteboad then... | 18:43 |
| jlvillal | ricardoas: Why isn't it a patch chain? I'm confused. | 18:43 |
| rloo | jlvillal: i suspect they click'd on the 'revert' button | 18:43 |
| jlvillal | Oh :( | 18:43 |
| jlvillal | ricardoas: Can you instead use: git revert? | 18:44 |
| rloo | jlvillal: ideally a patch chain would be good, but i don't know how easy it is to do. i've never done it. | 18:44 |
| jlvillal | ricardoas: And create the patch chain. | 18:44 |
| ricardoas | jlvillal: I was wondering if we should explictly leave them as a patch chain... | 18:44 |
| jlvillal | ricardoas: So we don't have to make sure we are so careful and merge them in the correct order. | 18:44 |
| jlvillal | ricardoas: If they are a patch chain, then I can't screw things up. | 18:44 |
| jlvillal | And I like it when I can't screw things up! :) | 18:44 |
| jlvillal | ricardoas: One option would be to "checkout" the 1st patch in the chain. | 18:45 |
| jlvillal | ricardoas: Then cherry-pick each patch in order | 18:45 |
| jlvillal | ricardoas: And then upload the patch chain. | 18:46 |
| jlvillal | ricardoas: Does that make sense? | 18:46 |
| ricardoas | jlvillal: is there a way to edit the reverts we already did? | 18:46 |
| jlvillal | Let me know if you need help doing that. | 18:46 |
| ricardoas | jlvillal: ohh I see... | 18:46 |
| jlvillal | ricardoas: Yes, when you checkout and cherry-pick you can amend the commit message. | 18:46 |
| rloo | jlvillal: hmm, wondering if in the UI, the 'rebase' works for this | 18:46 |
| jlvillal | ricardoas: So this is your first patch: git fetch https://git.openstack.org/openstack/ironic refs/changes/66/518766/1 && git checkout FETCH_HEAD | 18:47 |
| jlvillal | ricardoas: then do a: git commit --amend and edit the commit message | 18:47 |
| jlvillal | ricardoas: Then the next patch would be: git fetch https://git.openstack.org/openstack/ironic refs/changes/68/518768/1 && git cherry-pick FETCH_HEAD | 18:47 |
| ricardoas | jlvillal: I sure need... | 18:47 |
| jlvillal | Which is a cherry-pick | 18:47 |
| jlvillal | Then do the: git commit --amend again to modify the commit message | 18:48 |
| *** racedo has quit IRC | 18:48 | |
| jlvillal | And continue on like that through the patch chain. | 18:48 |
| jlvillal | Then when all don: git review | 18:48 |
| jlvillal | ricardoas: I think that should work. | 18:48 |
| jlvillal | s/all don:/all done:/ | 18:48 |
| ricardoas | jlvillal: ok! We´ll try now | 18:48 |
| jlvillal | ricardoas: If you run into any issues please ping me. | 18:48 |
| nicodemos | jlvillal: that is the same as: 1. git review -d first_patch 2. git commit --amend and edit 3. git review -x next_patch ? | 18:50 |
| jlvillal | nicodemos: Uh, I don't use "git review" so I don't know :( | 18:51 |
| jlvillal | nicodemos: Maybe??? | 18:51 |
| nicodemos | jlvillal: hehehe, ok. | 18:51 |
| jlvillal | Well I do use "git review" but only when I am doing a stable branch push. | 18:51 |
| jlvillal | nicodemos: I should use it I know. But when I first started using gerrit (on a different project) we didn't have "git review" | 18:52 |
| jlvillal | nicodemos: But that looks pretty simple and handy what you showed. | 18:52 |
| ricardoas | jlvillal: ¨Reverting these changes because python-hpOneView does not provide HTTPS secure connection with custom CAcert and could cause a possible security issue.¨ - is that ok? | 18:53 |
| jlvillal | ricardoas: Works for me! | 18:53 |
| ricardoas | jlvillal: cool! nicodemos, can you use this message, please? ^ | 18:54 |
| jlvillal | ricardoas: nicodemos: I'm heading out to lunch now. But I think you know what to do. | 18:55 |
| jlvillal | ricardoas: nicodemos: Feel free to ping me, but might be an hour before I reply. | 18:55 |
| *** makowals has quit IRC | 19:00 | |
| ricardoas | jlvillal: working on them... thank you for helping! | 19:06 |
| *** trown|lunch is now known as trown | 19:14 | |
| openstackgerrit | Hugo Nicodemos proposed openstack/ironic master: Revert "Update python-ilorest-library to hardware type OneView" https://review.openstack.org/518766 | 19:15 |
| openstackgerrit | Hugo Nicodemos proposed openstack/ironic master: Revert "Get a new OneView client when needed" https://review.openstack.org/518768 | 19:15 |
| openstackgerrit | Hugo Nicodemos proposed openstack/ironic master: Revert "Remove python-oneviewclient from Ironic OneView drivers" https://review.openstack.org/518769 | 19:15 |
| openstackgerrit | Hugo Nicodemos proposed openstack/ironic master: Revert "Migrate python-oneviewclient validations to Ironic OneView drivers" https://review.openstack.org/518770 | 19:15 |
| openstackgerrit | Hugo Nicodemos proposed openstack/ironic master: Revert "Add a timeout for powering on/off a node on HPE OneView Driver" https://review.openstack.org/518771 | 19:15 |
| openstackgerrit | Hugo Nicodemos proposed openstack/ironic master: Revert "Fix persistent information when getting boot device" https://review.openstack.org/518772 | 19:15 |
| openstackgerrit | Hugo Nicodemos proposed openstack/ironic master: Revert "Migrate oneview driver to use python-hpOneView" https://review.openstack.org/518773 | 19:15 |
| openstackgerrit | Hugo Nicodemos proposed openstack/ironic master: Revert "Introduce hpOneView and ilorest to OneView" https://review.openstack.org/518774 | 19:15 |
| xavier1 | \o/ | 19:15 |
| nicodemos | rloo, jlvillal ^^^ :) | 19:17 |
| rloo | nicodemos, xavier1: at first glance, looks good. thx! | 19:18 |
| rloo | nicodemos etc. the only thing is that one of the lines in the commit msg is a bit long. I don't know if we have something that checks the length, but we'll find out... and it might just be a recommendation to keep it at < 70 chars, i don't recall. | 19:20 |
| nicodemos | rloo ok. Ill keep that in mind. | 19:25 |
| *** jaypipes has quit IRC | 19:29 | |
| *** jaypipes has joined #openstack-ironic | 19:30 | |
| *** Nisha_Agarwal has quit IRC | 19:31 | |
| TheJulia | Select ‘caffeine’ from iv_supplies where dosage = ‘maximum’; | 19:31 |
| *** Nisha_Agarwal has joined #openstack-ironic | 19:33 | |
| jlvillal | nicodemos, Why doesn't: https://review.openstack.org/#/c/518766/ revert the release notes entry? | 19:33 |
| nicodemos | jlvillal: dtantsur|afk removed in: https://review.openstack.org/#/c/518570/ | 19:34 |
| jlvillal | nicodemos, Ah. A comment might have been nice. But okay. Thanks. | 19:34 |
| jlvillal | nicodemos, I assume there is some patch somewhere which updates the release note based on all these reverts. Or it isn't needed? | 19:35 |
| jlvillal | nicodemos, Never mind. I see removed. as you said. | 19:36 |
| * jlvillal goes back to lunch | 19:37 | |
| nicodemos | :) | 19:37 |
| *** Nisha_Agarwal has quit IRC | 19:40 | |
| *** ChubYann has joined #openstack-ironic | 19:49 | |
| *** tzumainn has quit IRC | 19:59 | |
| honza | what can cause a node to turn on maintenance mode on its own? | 20:01 |
| *** efried_afk is now known as efried | 20:02 | |
| *** fragatina has quit IRC | 20:09 | |
| *** mgoddard has quit IRC | 20:12 | |
| *** makowals has joined #openstack-ironic | 20:14 | |
| *** fellypefca has quit IRC | 20:15 | |
| *** baoli has joined #openstack-ironic | 20:15 | |
| *** mrtenio is now known as mrtenio-afk | 20:15 | |
| *** xavier1 has quit IRC | 20:18 | |
| *** mat128 has quit IRC | 20:23 | |
| *** makowals has quit IRC | 20:25 | |
| *** tzumainn has joined #openstack-ironic | 20:28 | |
| *** mgoddard has joined #openstack-ironic | 20:31 | |
| openstackgerrit | John L. Villalovos proposed openstack/ironic master: Don't run multinode jobs for changes to driver-requirements.txt https://review.openstack.org/518791 | 20:38 |
| *** windsn has quit IRC | 20:40 | |
| *** windsn has joined #openstack-ironic | 20:41 | |
| *** mgoddard has quit IRC | 20:41 | |
| *** makowals has joined #openstack-ironic | 20:46 | |
| *** jkilpatr has quit IRC | 20:56 | |
| *** fragatina has joined #openstack-ironic | 20:59 | |
| *** mat128 has joined #openstack-ironic | 21:03 | |
| *** jkilpatr has joined #openstack-ironic | 21:13 | |
| *** baoli has quit IRC | 21:16 | |
| *** e0ne has quit IRC | 21:24 | |
| *** e0ne has joined #openstack-ironic | 21:26 | |
| *** e0ne has quit IRC | 21:26 | |
| *** e0ne has joined #openstack-ironic | 21:27 | |
| *** e0ne has quit IRC | 21:28 | |
| *** e0ne has joined #openstack-ironic | 21:29 | |
| *** e0ne has quit IRC | 21:29 | |
| *** mat128 has quit IRC | 21:30 | |
| *** e0ne has joined #openstack-ironic | 21:30 | |
| *** e0ne has quit IRC | 21:31 | |
| *** trown is now known as trown|outtypewww | 21:34 | |
| tonyb | I have anode that's decided to go into error/maintenance mode. If I unset maintenance will that poll thre BMC and fix the power state? or am I better to delete, add and introspect the hardware again? | 21:40 |
| *** charcol-v2 has quit IRC | 21:45 | |
| *** rcernin has joined #openstack-ironic | 22:01 | |
| *** ppiela has joined #openstack-ironic | 22:02 | |
| *** crushil has quit IRC | 22:06 | |
| *** cdearborn_ has quit IRC | 22:15 | |
| *** baoli has joined #openstack-ironic | 22:16 | |
| *** makowals has quit IRC | 22:20 | |
| *** baoli has quit IRC | 22:24 | |
| *** etingof has quit IRC | 22:33 | |
| openstackgerrit | John L. Villalovos proposed openstack/ironic-python-agent master: DNM/WIP: Testing https://review.openstack.org/518806 | 22:36 |
| *** mgoddard has joined #openstack-ironic | 22:41 | |
| openstackgerrit | John L. Villalovos proposed openstack/ironic-python-agent master: [Test]DNM Testing if TinyIPA builds with py3 https://review.openstack.org/509652 | 22:46 |
| *** mgoddard has quit IRC | 22:48 | |
| *** tzumainn has quit IRC | 22:50 | |
| *** etingof has joined #openstack-ironic | 22:54 | |
| *** rbudden has quit IRC | 22:57 | |
| rloo | honza: there are some periodic tasks. Am guessing the power state one -- although i thought if the code put a node in maintenance, you'd see something in the node's 'maintenance_reason' field. | 22:58 |
| rloo | tonyb: it might; it depends on why it error'd. | 22:59 |
| *** e0ne has joined #openstack-ironic | 22:59 | |
| tonyb | rloo: vbmc had an issue but ipmitool is working fine now | 22:59 |
| rloo | tonyb: good. i think :) | 23:00 |
| tonyb | rloo: ;P | 23:00 |
| *** rama_y has quit IRC | 23:09 | |
| *** charcol has joined #openstack-ironic | 23:18 | |
| *** baoli has joined #openstack-ironic | 23:21 | |
| *** baoli has quit IRC | 23:25 | |
| rloo | jlvillal: see hugo's comment. i wonder if we should wait for their CI tests to finish... https://review.openstack.org/#/c/518766/ | 23:31 |
| jlvillal | rloo: I'm not sure. I guess I'm kind of thinking yank it out. If any issues come up on their end they can send some patches to fix it. | 23:33 |
| honza | rloo: ah, that's helpful, TIL about maintenance_reason | 23:33 |
| jlvillal | rloo: What happens if there are some issues. Do we wait for patches to fix that and such? | 23:34 |
| jlvillal | rloo: But I don't have strong feelings either way. | 23:34 |
| rloo | jlvillal: honestly, i don't know either. presumably the code worked before so I suspect it is fine to revert them all. but i'm done for the day so ... can leave it for dmitry to deal with :) | 23:36 |
| jlvillal | rloo: +1 :) | 23:36 |
| rloo | honza: hope that helps :) | 23:36 |
| *** j_b9d9 has quit IRC | 23:37 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!