Tuesday, 2017-09-26

*** baoli has joined #openstack-ironic00:01
*** jaypipes has quit IRC00:02
*** rama_y has quit IRC00:04
*** baoli has quit IRC00:06
*** yangyape_ has quit IRC00:09
*** yangyapeng has joined #openstack-ironic00:10
*** yangyapeng has quit IRC00:14
*** jkilpatr has quit IRC00:16
*** srobert has quit IRC00:22
*** mrtenio has quit IRC00:26
*** crushil_ has joined #openstack-ironic00:28
*** mikal_ has quit IRC00:32
*** mikal has joined #openstack-ironic00:34
*** crushil_ has quit IRC00:38
*** litao__ has joined #openstack-ironic00:53
*** hw_wutianwei1 has joined #openstack-ironic00:55
*** ijw has quit IRC01:02
*** ijw has joined #openstack-ironic01:02
*** ijw has quit IRC01:07
*** hw_wutianwei1 has quit IRC01:09
*** hw_wutianwei1 has joined #openstack-ironic01:09
*** yangyapeng has joined #openstack-ironic01:12
*** phuongnh has joined #openstack-ironic01:14
*** phuongnh has quit IRC01:20
*** yangyapeng has quit IRC01:40
*** yangyapeng has joined #openstack-ironic01:40
*** zhangfei has quit IRC01:42
*** crushil has quit IRC01:50
*** yangyapeng has quit IRC01:50
*** yangyapeng has joined #openstack-ironic01:51
*** gcb has joined #openstack-ironic01:52
*** yangyape_ has joined #openstack-ironic01:56
*** yangyapeng has quit IRC01:56
*** rbudden has quit IRC02:05
*** yangyape_ has quit IRC02:12
*** yangyapeng has joined #openstack-ironic02:13
*** racedo has quit IRC02:15
*** yangyapeng has quit IRC02:15
*** yangyapeng has joined #openstack-ironic02:15
*** yangyapeng has quit IRC02:20
*** rwsu has joined #openstack-ironic02:20
*** rbudden has joined #openstack-ironic02:45
*** sasha2 has quit IRC02:45
*** rbudden has quit IRC02:51
*** Dinesh_Bhor has joined #openstack-ironic02:54
*** Dinesh_Bhor has quit IRC02:57
*** Dinesh_Bhor has joined #openstack-ironic02:57
*** mikal has quit IRC02:59
*** yangyapeng has joined #openstack-ironic03:01
*** mikal has joined #openstack-ironic03:02
*** yangyape_ has joined #openstack-ironic03:03
*** yangyapeng has quit IRC03:07
*** crushil has joined #openstack-ironic03:14
*** crushil has quit IRC03:17
*** jlabarre has quit IRC03:21
*** Dinesh_Bhor has quit IRC03:24
*** Dinesh_Bhor has joined #openstack-ironic03:28
*** rwsu has quit IRC03:30
*** Dinesh_Bhor has quit IRC03:34
*** rwsu has joined #openstack-ironic03:37
*** Dinesh_Bhor has joined #openstack-ironic03:46
*** udesale has joined #openstack-ironic03:59
*** rwsu has quit IRC04:02
*** aparnav has joined #openstack-ironic04:10
*** livelace2 has quit IRC04:10
*** Nisha_Agarwal has joined #openstack-ironic04:12
*** rwsu has joined #openstack-ironic04:15
*** mtreinish has quit IRC04:24
*** mtreinish has joined #openstack-ironic04:34
*** crushil has joined #openstack-ironic04:38
*** trungnv has joined #openstack-ironic04:42
*** gcb has quit IRC04:48
*** etingof has quit IRC04:55
*** yangyape_ has quit IRC05:09
*** yangyapeng has joined #openstack-ironic05:09
*** etingof has joined #openstack-ironic05:13
*** adreznec has quit IRC05:13
*** bnemec has quit IRC05:14
*** yangyapeng has quit IRC05:14
*** livelace has joined #openstack-ironic05:15
*** livelace2 has joined #openstack-ironic05:17
*** Nisha_ has joined #openstack-ironic05:18
*** Nisha_Agarwal has quit IRC05:18
*** Nisha_away has joined #openstack-ironic05:19
*** Nisha_ has quit IRC05:19
*** livelace has quit IRC05:21
*** etingof has quit IRC05:21
*** Nisha_Agarwal has joined #openstack-ironic05:23
*** Nisha_away has quit IRC05:23
*** gcb has joined #openstack-ironic05:24
*** Nisha_Agarwal has quit IRC05:24
*** Nisha_Agarwal has joined #openstack-ironic05:25
*** crushil_ has joined #openstack-ironic05:27
*** crushil has quit IRC05:29
*** mat128 has joined #openstack-ironic05:38
*** mat128 has quit IRC05:41
*** mat128 has joined #openstack-ironic05:43
*** mat128 has quit IRC05:46
*** livelace has joined #openstack-ironic05:46
*** mat128 has joined #openstack-ironic05:47
*** Nisha_Agarwal has quit IRC05:49
openstackgerritVasyl Saienko proposed openstack/ironic master: Add uWSGI support  https://review.openstack.org/50701105:49
openstackgerritVasyl Saienko proposed openstack/ironic master: [devstack] Switch ironic to uWSGI  https://review.openstack.org/50706705:49
*** livelace has quit IRC05:51
*** ChubYann has quit IRC05:55
*** adreznec has joined #openstack-ironic06:01
*** dpawar has joined #openstack-ironic06:01
*** livelace has joined #openstack-ironic06:04
*** marios has joined #openstack-ironic06:05
*** mat128 has quit IRC06:09
openstackgerritVasyl Saienko proposed openstack/ironic master: Add uWSGI support  https://review.openstack.org/50701106:17
openstackgerritVasyl Saienko proposed openstack/ironic master: [devstack] Switch ironic to uWSGI  https://review.openstack.org/50706706:17
*** jaianshu has joined #openstack-ironic06:19
*** pcaruana has joined #openstack-ironic06:20
*** jaganathan has joined #openstack-ironic06:20
*** zshi__ has joined #openstack-ironic06:23
*** mjura has joined #openstack-ironic06:25
*** hjensas has joined #openstack-ironic06:26
*** hjensas has quit IRC06:26
*** hjensas has joined #openstack-ironic06:26
*** etingof has joined #openstack-ironic06:27
*** makowals has joined #openstack-ironic06:33
openstackgerritVasyl Saienko proposed openstack/ironic stable/pike: Adds more exception handling for ironic-conductor heartbeat  https://review.openstack.org/50737306:45
*** stendulker has joined #openstack-ironic06:45
*** crushil_ has quit IRC06:45
*** rcernin has joined #openstack-ironic06:47
*** dpawar has quit IRC07:02
*** karthiks has quit IRC07:03
*** karthiks has joined #openstack-ironic07:03
*** makowals has quit IRC07:11
*** dtantsur|afk is now known as dtantsur07:11
dtantsurmorning ironic07:11
*** tesseract has joined #openstack-ironic07:14
openstackgerritAnshul Jain proposed openstack/sushy master: Add PUT method to connector  https://review.openstack.org/50738507:15
*** dpawar has joined #openstack-ironic07:19
*** e0ne has joined #openstack-ironic07:22
*** jtomasek has joined #openstack-ironic07:22
etingofo/07:23
*** hw_wutianwei1 has quit IRC07:24
*** racedo has joined #openstack-ironic07:30
etingofhow could one figure out MACs of rdocloud instances?07:31
dtantsuretingof: 'openstack port list'? :)07:32
dtantsuror port show. I think one of these has to show MACs for bound ports07:32
etingof$ openstack --os-cloud rdo-cloud  port list07:34
etingofopenstack: 'port' is not an openstack command.07:34
*** mrch has joined #openstack-ironic07:35
dtantsuretingof: you have ancient python-openstackclient package, I bet (complain to number80 on #rdo ;)07:35
dtantsurtry neutron port-list / port-show07:35
etingofthat worked, thanks!07:36
*** rbartal has joined #openstack-ironic07:37
*** phuongnh has joined #openstack-ironic07:39
etingofdtantsur, btw, -1 is resolved on this patch if you have time for a look -- https://review.openstack.org/#/c/498489/07:45
patchbotpatch 498489 - ironic-python-agent - Report /dev/disk/by-path on inspection07:45
dtantsurk07:46
*** tiendc has joined #openstack-ironic07:59
*** ccamacho has joined #openstack-ironic07:59
pas-haetingof: it is in current openstack client, check your version08:18
* pas-ha slowpokes08:18
etingofit's 2.2.0, but it worked out through neutron08:18
dtantsuretingof: my F26 has 3.2.0, it's much better08:19
dtantsuralso approved the by-disk patches08:19
* etingof needs to upgrade08:19
etingof\o/08:20
etingofit's time for a followup patch then08:20
dtantsuryep :)08:29
*** ralonsoh has joined #openstack-ironic08:31
*** TuanLA has joined #openstack-ironic08:35
pas-haetingof: on DevStack 'openstack --version' is 3.12.0 (and this is specified as lower bound for ironicclient currently)08:38
pas-haand indeed, some time ago I remember openstackclient was lacking port operations, while neutronclient already declared itself deprecated o_O08:38
*** vmud213 has joined #openstack-ironic08:40
etingofyeah, I just needed to talk to rdocloud, I am at 3.12.0 at devstack as well08:40
*** udesale has quit IRC08:45
*** noam_ has joined #openstack-ironic08:48
noam_hi08:48
noam_I have some time issues during cleaning for ironic nodes server gets Kernel panic - not syncing: VFS: Unable to mount root fs on unknown-block(0,0)08:48
noam_someone know how can i work around it?08:49
noam_http://paste.openstack.org/show/621909/08:51
*** udesale has joined #openstack-ironic08:51
*** Nisha_Agarwal has joined #openstack-ironic08:56
openstackgerritMerged openstack/ironic-inspector master: Replace the usage of 'admin_manager' with 'os_admin'  https://review.openstack.org/50701208:57
openstackgerritMerged openstack/ironic-lib master: Added `by_path` root device hint  https://review.openstack.org/50052408:58
dtantsurnoam_: are you sure it boots IPA, not the OS from a local disk? if there are random DHCP failures, that may be the case09:00
*** derekh has joined #openstack-ironic09:00
noam_It boot the deploy image09:01
*** amarao has joined #openstack-ironic09:03
noam_Repating the cleaning result the same09:04
*** yangyapeng has joined #openstack-ironic09:10
*** udesale has quit IRC09:11
*** phuongnh has quit IRC09:11
*** udesale has joined #openstack-ironic09:11
*** yangyapeng has quit IRC09:12
*** yangyapeng has joined #openstack-ironic09:13
openstackgerritMerged openstack/ironic-python-agent master: Report /dev/disk/by-path on inspection  https://review.openstack.org/49848909:15
openstackgerritMerged openstack/ironic-python-agent master: Remove hard-coded path to grub binaries  https://review.openstack.org/50405109:16
*** Nisha_ has joined #openstack-ironic09:19
*** Nisha_Agarwal has quit IRC09:19
*** dtantsur is now known as dtantsur|lunch09:21
*** yangyapeng has quit IRC09:30
*** yangyapeng has joined #openstack-ironic09:31
*** yangyapeng has quit IRC09:34
*** yangyapeng has joined #openstack-ironic09:35
*** Nisha_ has quit IRC09:37
*** Nisha_ has joined #openstack-ironic09:37
*** yangyapeng has quit IRC09:39
vdroklate morning ironic!09:41
*** milan has joined #openstack-ironic09:43
*** vmud213 has quit IRC09:49
*** vmud213 has joined #openstack-ironic09:50
*** Nisha_away has joined #openstack-ironic09:53
*** Nisha_ has quit IRC09:53
*** etingof has quit IRC10:00
*** ijw has joined #openstack-ironic10:08
openstackgerrityfzhao proposed openstack/ironic master: Fix wrong links  https://review.openstack.org/49287610:10
*** hjensas has quit IRC10:11
*** etingof has joined #openstack-ironic10:12
*** ijw has quit IRC10:13
*** Nisha_away has quit IRC10:18
*** etingof has quit IRC10:19
*** yangyapeng has joined #openstack-ironic10:22
openstackgerritVasyl Saienko proposed openstack/ironic-python-agent stable/pike: Remove hard-coded path to grub binaries  https://review.openstack.org/50746810:25
openstackgerritVasyl Saienko proposed openstack/ironic-python-agent stable/ocata: Remove hard-coded path to grub binaries  https://review.openstack.org/50746910:25
*** yangyapeng has quit IRC10:26
*** vmud213 has quit IRC10:29
*** jaganathan has quit IRC10:31
*** etingof has joined #openstack-ironic10:33
*** aparnav has quit IRC10:34
pas-hamorning vdrok :)10:35
*** dsneddon has quit IRC10:35
*** udesale has quit IRC10:37
*** athomas has quit IRC10:43
*** udesale has joined #openstack-ironic10:53
openstackgerritVasyl Saienko proposed openstack/ironic master: [devstack] Switch ironic to uWSGI  https://review.openstack.org/50706710:54
*** jkilpatr has joined #openstack-ironic10:54
*** hjensas has joined #openstack-ironic10:59
*** hjensas has joined #openstack-ironic10:59
*** jkilpatr has quit IRC10:59
*** athomas has joined #openstack-ironic11:04
openstackgerritzenghui.shi proposed openstack/ironic-specs master: New hardware interface for BIOS configuration  https://review.openstack.org/49648111:07
*** vsaienk0 has quit IRC11:08
*** livelace2 has quit IRC11:13
*** jkilpatr has joined #openstack-ironic11:15
*** ralonsoh_ has joined #openstack-ironic11:21
*** e0ne has quit IRC11:21
*** fellypefca-afk is now known as fellypefca11:24
*** stendulker_ has joined #openstack-ironic11:24
fellypefcaGood morning :)11:24
*** ralonsoh has quit IRC11:24
vdrokmorning pas-ha , fellypefca11:25
*** stendulker has quit IRC11:27
fellypefcaHi vdrok11:28
*** e0ne has joined #openstack-ironic11:28
*** TuanLA has quit IRC11:29
*** stendulker_ has quit IRC11:29
*** rbudden has joined #openstack-ironic11:29
*** yangyapeng has joined #openstack-ironic11:38
*** zshi__ has quit IRC11:41
*** bfournie has quit IRC11:44
*** bfournie has joined #openstack-ironic11:44
*** bfournie has quit IRC11:48
*** dprince has joined #openstack-ironic11:57
*** rbudden has quit IRC11:59
*** jlabarre has joined #openstack-ironic12:02
*** jaianshu has quit IRC12:03
*** tiendc has quit IRC12:04
*** livelace2 has joined #openstack-ironic12:07
*** mat128 has joined #openstack-ironic12:08
*** dtantsur|lunch is now known as dtantsur12:15
*** litao__ has quit IRC12:16
openstackgerritFellype Cavalcante proposed openstack/ironic master: Documentation for 'oneview' hardware type  https://review.openstack.org/50207212:28
*** udesale has quit IRC12:29
dtantsurmorning fellypefca, vdrok, TheJulia12:31
TheJuliaGood morning!12:32
*** vsaienk0 has joined #openstack-ironic12:33
*** athomas has quit IRC12:33
fellypefcaGood morning dtantsur and TheJulia :)12:34
*** bfournie has joined #openstack-ironic12:34
*** zshi__ has joined #openstack-ironic12:36
pas-hamorning TheJulia fellypefca12:43
fellypefcaHey pas-ha :)12:44
vdrokmorning dtantsur and TheJulia12:45
*** trown|outtypewww is now known as trown12:45
*** vsaienk0 has quit IRC12:47
*** rloo has joined #openstack-ironic12:47
*** vsaienk0 has joined #openstack-ironic12:47
*** jaypipes has joined #openstack-ironic12:49
*** athomas has joined #openstack-ironic12:50
*** mat128 has quit IRC12:52
*** bnemec has joined #openstack-ironic12:52
*** srobert has joined #openstack-ironic12:54
*** sasha2 has joined #openstack-ironic12:55
*** mat128 has joined #openstack-ironic12:55
*** mat128 has quit IRC12:57
*** rbudden has joined #openstack-ironic12:58
*** Dinesh_Bhor has quit IRC12:59
*** jcoufal has joined #openstack-ironic13:04
*** mat128 has joined #openstack-ironic13:07
*** Dinesh_Bhor has joined #openstack-ironic13:08
*** mat128 has quit IRC13:10
*** mat128 has joined #openstack-ironic13:12
*** Goneri has joined #openstack-ironic13:14
*** mat128 has quit IRC13:15
*** dpawar has quit IRC13:18
*** mat128 has joined #openstack-ironic13:22
*** baoli has joined #openstack-ironic13:23
*** udesale has joined #openstack-ironic13:27
*** mat128 has quit IRC13:33
*** mat128 has joined #openstack-ironic13:40
*** mat128 has quit IRC13:41
*** mat128 has joined #openstack-ironic13:42
*** srobert has quit IRC13:46
*** srobert has joined #openstack-ironic13:46
*** cdearborn_ has joined #openstack-ironic13:47
dtantsurfellypefca or someone from oneview, up for a quick chat re https://bugs.launchpad.net/ironic/+bug/1716023 ?13:51
openstackLaunchpad bug 1716023 in Ironic "OneView drivers doesn't support multitenancy in ocata" [Undecided,Triaged]13:51
fellypefcaHey dtantsur13:51
ricardoassure, dtantsur13:52
dtantsurcool! do you think it's going to be easier to just add missing lines to your mixin?13:52
dtantsurif it's really one-two lines, it may be much less invasive13:52
dtantsurthat's going to be an ocata-only patch, obviously13:52
ricardoasfor sure... we thought we weren´t allowed to commit directly to stable branches13:53
dtantsurricardoas: it's an exceptional situation, up to the stable team (for ironic, TheJulia, rloo and me) to accept or not13:53
dtantsurbut if it's 5 lines of a clean stable-only fix vs hundreds of lines of a complex backport - I'd prefer it13:54
dtantsurplease let me know what you think (ditto TheJulia and rloo)13:54
rloodtantsur, fellypefca: hundreds of lines is a no unless it is urgent13:54
rloodtantsur, fellypefca: is it a bug, was it meant to support multitenancy in ocata?13:55
dtantsurmorning rloo. I think we expect all drivers that can support multitenancy to support it13:55
rloomorning dtantsur and fellypefca!13:56
TheJuliadtantsur: I'm all for minimalist, so a ocata-only patch is fine with me since this is an extenuating circumstance.13:57
ricardoasdtantsur rloo fellypefca: oneview mixin is missing lines 594, 595 from https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/agent_base_vendor.py#L59413:57
dtantsurtwo lines are acceptable, assuming you do test the resulting patch manually ;)13:58
ricardoasdtantsur: sure... in fact we´ve been adding them manually for the past couple of months :(13:58
dtantsurwow13:59
dtantsurthen please make a patch. if it's small indeed, let's go with it.13:59
dtantsurand sorry for all this back-and-forth with this issue :(13:59
fellypefcaWe will work on that right now :) thanks dtantsur13:59
ricardoasdtantsur: still in this matter, stable/newton suffers from a similar issue (that´s why agent_pxe_oneview is not working in the ci)... but I guess we should not insist on stable/newton anymore, right?14:00
dtantsurlemme check14:00
dtantsurricardoas: newtone is still phase II (https://releases.openstack.org/) so we may consider a patch, if it's critical enough (and assuming your CI passes)14:01
*** crushil has joined #openstack-ironic14:02
ricardoasdtantsur: cool! We´ll check if it is also a case of few likes before submitting anything... :D14:02
ricardoasfellypefca: ^14:02
ricardoaslines*14:02
fellypefcanice :)14:03
dtantsursure :)14:03
*** rloo has quit IRC14:04
*** rloo has joined #openstack-ironic14:04
*** rloo has quit IRC14:04
*** vsaienk0 has quit IRC14:04
*** rloo has joined #openstack-ironic14:04
*** vsaienk0 has joined #openstack-ironic14:05
dtantsurfolks, the first part of my PTG summary: http://dtantsur.github.io/posts/ironic-ptg-denver-2017-1.html14:07
ricardoasrloo: morning! I´ve seen you added comments on oneview docs for hardware type patch for other sections... in fact we have some updates for all sections under internal review. Is is the case for a follow up or you folks prefer us to update it all in a single step?14:08
*** mrch has quit IRC14:08
*** jaganathan has joined #openstack-ironic14:15
*** baoli has quit IRC14:17
*** baoli has joined #openstack-ironic14:17
openstackgerritMilan Kováčik proposed openstack/ironic-inspector master: Generate version_id upon add_node  https://review.openstack.org/50755914:27
fellypefcadtantsur Do we need a release note for this Ocata backport?14:29
dtantsurfellypefca: yep14:29
fellypefcadtantsur thanks14:30
*** dsneddon has joined #openstack-ironic14:31
*** makowals has joined #openstack-ironic14:34
*** rbartal has quit IRC14:44
*** srobert has quit IRC14:46
openstackgerritMerged openstack/ironic-ui master: Set target raid configuration on a node  https://review.openstack.org/48320514:48
*** zshi__ has quit IRC14:49
*** trown is now known as trown|brb14:50
*** ralonsoh_ is now known as ralonsoh14:52
*** rpioso has joined #openstack-ironic14:54
openstackgerritMerged openstack/sushy master: Add PUT method to connector  https://review.openstack.org/50738514:54
TheJuliaanupn: You are now a member of ironic-ui-core. Congrats!15:00
*** vsaienk0 has quit IRC15:06
dtantsurcongrats anupn :)15:09
dtantsuryuriyz: hi! your vote is missing on https://review.openstack.org/#/c/505173/15:12
patchbotpatch 505173 - ironic-specs - Proposal for Queens cycle priorities15:12
dtantsuralso vsaienk0, but I guess he's out..15:12
yuriyzhi dtantsur will look15:12
rpiosoGood morning, ironicers.15:13
dtantsurpas-ha: do you know where vsaienk0 is?15:13
dtantsurmore importantly, when he comes back?15:13
dtantsurmorning rpioso15:13
*** stendulker has joined #openstack-ironic15:13
rpiosodtantsur: :)  Thank you for approving and merging that python-dracclient change.  It should increase the stability/correctness of the Dell 3d party CI.15:14
*** mjura has quit IRC15:14
*** penick has joined #openstack-ironic15:15
*** causten has joined #openstack-ironic15:15
NobodyCamGood Morning Ironic'ers15:16
*** rnoriega_ is now known as rnoriega15:16
*** srobert has joined #openstack-ironic15:17
dtantsurrpioso: I hope so! still, 8 minutes of wait scare me a bit :)15:18
*** trown|brb is now known as trown15:18
*** livelace2 has quit IRC15:21
*** rama_y has joined #openstack-ironic15:22
*** tonyb has quit IRC15:22
vdrokgood morning rloo rpioso and NobodyCam !15:22
*** rama_y has quit IRC15:23
*** vsaienk0 has joined #openstack-ironic15:24
*** tonyb has joined #openstack-ironic15:24
stendulkerGood morning rloo, rpioso, NobodyCam, vdrok, dtantsur :)15:24
TheJuliagood morning stendulker15:24
stendulkerTheJulia: Good Morning :)15:24
vdrokmorning stendulker15:25
stendulkerOne question regarding rescue interface, should it be supported _only_ as a dynamic interface or shouls also be supported as a  classic driver interface?15:25
stendulkerSpec do not mention anything related to it https://specs.openstack.org/openstack/ironic-specs/specs/not-implemented/implement-rescue-mode.html15:26
stendulkerMay be we should support on classic driver as well as this interface was defined in base class for a quiet a while, though we never had the implemention for the same.15:27
NobodyCamGood Morning vdrok, stendulker, TheJulia, dtantsur :)15:27
*** e0ne has quit IRC15:28
*** dsneddon has quit IRC15:29
dtantsurmorning stendulker, NobodyCam15:30
dtantsurstendulker: I'd avoid touching classic drivers, if it's not technically challenging15:30
stendulkerdtantsur: It should not be though the patches in review currently, implements it for classic drivers as well.15:31
NobodyCam:)15:31
dtantsurstendulker: we want to motivate people to move off the classic drivers ;)15:32
stendulkerdtantsur: Will rework it to make it for dynamic drivers only15:32
dtantsurthanks!15:32
TheJuliaso15:32
TheJuliaI'm not sure that is really feasible, short of just not defining it on the older drivers, the interface still needs to exist, it is all rooted in the same loader15:32
TheJuliaactually, that may be the only way, just not have it as an option on any classic driver, only have it as an interface with driver comp types15:33
TheJuliainterface would still be defined, it would map to to what? no-rescue under the hood?15:33
*** vsaienk0 has quit IRC15:33
stendulkerI mean we will not define them in classic drivers defined in /drivers directory15:33
stendulkerIts 'None' currently15:34
TheJuliabut... then None.rescue() gets called..15:35
stendulkerActually, one cannot call tht.15:35
dtantsurTheJulia: we have this situation with inspect15:35
dtantsurit can be None for classic drivers. and I think RAID too15:35
TheJuliaI think classic drivers just need to map to no-rescue and call it a day15:35
stendulkerSo we would need to change that to no-rescue.15:35
dtantsurTheJulia: that's an option too15:36
stendulkerAgree.15:36
stendulkerIt would be cleaner.15:36
TheJuliano-rescue should raise a nice error for us if users try to use it with classic drivers15:36
stendulkerTheJulia: yes15:36
TheJuliastendulker: btw, thank you for updating that patchset. I didn't see if you saw/replied to my comment about landing the coreos patchset in ipa first15:37
TheJuliabut I finally got a chance to review that patch last night.15:37
stendulkerTheJulia: Have added IPA CoreOS patch as a dependency to Ironic patch15:38
stendulkerTheJulia: Anything else needed on that. Have not seen your last night comments as yet.15:39
*** dsneddon has joined #openstack-ironic15:39
TheJuliastendulker: on the IPA rev, it was just release notes related15:40
stendulkerTheJulia: Ok. Will update tht patch shortly.15:41
stendulkerTheJulia: Thank you for review15:41
stendulkerTheJulia: Also had updated your patch related to capabilities https://review.openstack.org/#/c/492114/15:41
patchbotpatch 492114 - ironic - Change [deploy]/default_boot_option to local15:42
stendulkerTheJulia: Hope tht is ok with you.15:42
*** rbudden has quit IRC15:44
TheJuliastendulker: that is awesome, I've been crazy busy recently :)15:44
TheJuliaanyway, speaking of busy, I need to step away for a couple hours15:45
stendulkerTheJulia: :)15:45
*** jcoufal has quit IRC15:48
*** jcoufal_ has joined #openstack-ironic15:48
*** amarao has quit IRC15:48
*** ccamacho has quit IRC15:51
*** srobert has quit IRC15:58
*** srobert has joined #openstack-ironic15:59
*** jistr is now known as jistr|mtg16:01
*** dprince has quit IRC16:02
*** dprince has joined #openstack-ironic16:05
*** rcernin has quit IRC16:05
*** udesale has quit IRC16:08
*** jistr|mtg is now known as jistr16:18
*** jaganathan has quit IRC16:20
openstackgerritJohn L. Villalovos proposed openstack/ironic-lib master: Migrate to stestr as unit tests runner  https://review.openstack.org/50727216:22
*** trown is now known as trown|lunch16:23
openstackgerritJohn L. Villalovos proposed openstack/ironic-python-agent master: Migrate to stestr as unit tests runner  https://review.openstack.org/50727016:25
*** yufei has joined #openstack-ironic16:27
*** r-daneel has joined #openstack-ironic16:27
*** amarao has joined #openstack-ironic16:27
*** yufei has left #openstack-ironic16:28
*** stendulker has quit IRC16:31
*** marios has quit IRC16:33
jlvillalrloo: Would you have time to discuss: https://review.openstack.org/#/c/507297/3/ironic/drivers/modules/ipmitool.py ?16:34
patchbotpatch 507297 - ironic - Don't fail when ipmitool command fails if power st...16:34
*** causten has quit IRC16:34
*** causten has joined #openstack-ironic16:34
*** rbudden has joined #openstack-ironic16:41
* dtantsur -> beers16:42
dtantsursee you tomorrow16:42
*** dtantsur is now known as dtantsur|afk16:42
*** milan has quit IRC16:44
fellypefcaenjoy :) dtantsur|afk16:46
*** mrtenio has joined #openstack-ironic16:47
*** yufei has joined #openstack-ironic16:50
*** yufei has quit IRC16:51
*** derekh has quit IRC16:54
*** baoli has quit IRC17:01
*** baoli has joined #openstack-ironic17:02
rloohey jlvillal: should i read the comments etc first wrt 507297?17:08
jlvillalrloo: Sure. I think I figured out a better way. In a meeting at the moment.17:09
rloojlvillal: ok, ping me when you're avail17:09
*** rama_y has joined #openstack-ironic17:10
*** rcernin has joined #openstack-ironic17:11
*** racedo has joined #openstack-ironic17:14
*** amarao has quit IRC17:15
*** trown|lunch is now known as trown17:24
openstackgerritFellype Cavalcante proposed openstack/ironic stable/ocata: Fix multitenancy scenario on OneView Driver  https://review.openstack.org/50763217:24
*** crushil has quit IRC17:27
*** crushil has joined #openstack-ironic17:27
*** rbudden has quit IRC17:27
*** etingof has quit IRC17:28
openstackgerritRushil Chugh proposed openstack/ironic-specs master: Add spec for XClarity Driver  https://review.openstack.org/47692217:36
*** noam_ has quit IRC17:36
openstackgerritJohn L. Villalovos proposed openstack/ironic master: ipmitool: reboot: Don't power off node if already off  https://review.openstack.org/50729717:37
*** tesseract has quit IRC17:37
jlvillalrloo: ^^^  I think that is a cleaner approach. I took your suggestions into account.17:38
rloojlvillal: ok17:38
* vdrok goes for a walk17:39
vdrokgood night!17:39
jlvillalvdrok: Good plan :)17:39
vdrok:) morning jlvillal17:39
jlvillalvdrok: Good night :)17:39
rloobye vdrok!17:40
*** vsaienk0 has joined #openstack-ironic17:42
pas-hadtantsur|afk: Vasyl is out for evening, but will come back tomorrow. pinged him by internal means anyway.17:44
* pas-ha --> home17:45
openstackgerritJohn L. Villalovos proposed openstack/ironic master: ipmitool: reboot: Don't power off node if already off  https://review.openstack.org/50729717:45
*** [1]rpioso has joined #openstack-ironic17:50
*** ralonsoh has quit IRC17:51
*** rpioso has quit IRC17:52
*** ijw has joined #openstack-ironic17:53
*** cdearborn_ is now known as cdearborn17:53
*** vsaienk0 has quit IRC17:53
*** ijw has quit IRC17:55
*** [1]rpioso has quit IRC17:57
*** ijw has joined #openstack-ironic17:58
*** ijw has quit IRC17:58
*** ijw has joined #openstack-ironic17:58
*** baoli has quit IRC18:00
*** baoli has joined #openstack-ironic18:01
*** jkilpatr has quit IRC18:03
*** jkilpatr has joined #openstack-ironic18:04
openstackgerritFellype Cavalcante proposed openstack/ironic master: Documentation for 'oneview' hardware type  https://review.openstack.org/50207218:08
*** srobert_ has joined #openstack-ironic18:08
openstackgerritFellype Cavalcante proposed openstack/ironic master: Documentation for 'oneview' hardware type  https://review.openstack.org/50207218:09
jlvillalrloo: How about18:11
jlvillalFixes a problem when using ipmitool and rebooting a node which would cause18:11
jlvillal    a deploy to fail. Now when rebooting a node we check if the node is already18:11
jlvillal    powered off, if it is we don't attempt to power off the node. This is18:11
jlvillal    because some BMCs will error if the node is already powered off and an18:11
jlvillal    ipmitool request is made to power them off. See18:11
*** [1]rpioso has joined #openstack-ironic18:11
jlvillal    https://bugs.launchpad.net/ironic/+bug/1718794 for details.18:11
openstackLaunchpad bug 1718794 in Ironic "Some BMC/IPMI will error if currently off and told to turn off" [High,In progress] - Assigned to John L. Villalovos (happycamp)18:11
rloojlvillal: ok. s/them/it/ (in 'made to power them off')18:12
jlvillalrloo: thanks, will do18:12
rloojlvillal: did i mention how much i hate documentation and release notes?18:12
jlvillalheh :)18:12
*** srobert has quit IRC18:12
jlvillalrloo: I did comment about why I used the lambda. Basically I think they are cleaner/nicer.18:13
rloojlvillal: alternative is to add a new optional parameter to the reboot() call, but that affects out of tree drivers too18:13
jlvillalrloo: yeah, that seemed much uglier. I saw what they did for the 'timeout' parameter18:14
rloojlvillal: i must have missed the lambda comment. but am i correct, it is inconsistent wrt the other mocks being used?18:14
rloojlvillal: uglier, but more efficient (no need to make the power-status call again)18:14
jlvillalrloo: Yes it is different. But I think the better way is worth the less consistency18:14
rloojlvillal: i have no idea how expensive it is to make the power-status call18:14
rloojlvillal: i'd make it consistent/ugly, then submit a new patch to clean it all up18:15
rloojlvillal: personally18:15
rloojlvillal: makes it easier to review (for me)18:15
rloojlvillal: but not going to -1 you on that18:15
jlvillalhmmm....18:15
rloojlvillal: but you better make it consistent later cuz if you don't, it will make it more confusing for new people/others when looking at those tests18:15
jlvillalrloo: I guess I find it somewhat consistent. For things we don't need to check if they are called or not, then use a lambda18:16
rloojlvillal: oh, i see your comment now18:16
rloojlvillal: so, why don't you want to check if it is called or not?18:16
jlvillalrloo: For things where we do care if they are called or not, or we need to setup side_effects then don't use the lambda18:16
jlvillalrloo: I guess it is always called. Not a thing where it could be or could not be.18:17
rloojlvillal: i mean, i do want to know if it is being called. why don't you?18:17
rloojlvillal: you could say that about any method that doesn't have any 'if's in it :) the code will be called... dunno.18:17
rloojlvillal: isn't the power-on call always called too then? (based on my memory, i didn't look at code)18:18
*** vsaienk0 has joined #openstack-ironic18:18
jlvillalrloo: I guess it depends how much we want to test the implementation versus the desired result.18:19
rloojlvillal: just put yourself in the shoes of someone new learning about ironic and seeing those tests.18:19
jlvillalrloo: I was considering having one of the tests check to see if it is called.18:19
jlvillalrloo: And have the rest as lambdas18:19
rloojlvillal: did i also mention how much i hate tests? now I wonder what the order is, tests, docs, renos, ...?18:20
jlvillal:)18:20
rloojlvillal: anyway, not going to comment any more about that, do what you think is best, easy to understand for future ironic'ers.18:20
jlvillalrloo: Thanks. I notice we don't actually mock_on, mock_off is called in at least some of the tests.18:21
rlooit looks to me like the gate is broken, i see a bunch of tests failing for several patches18:21
rloobut i *need* to get back to something so going to stick my head in the sand until I am done18:22
jlvillalOh :(18:22
*** dprince has quit IRC18:23
*** rbudden has joined #openstack-ironic18:23
-openstackstatus- NOTICE: The infra team is continuing work to bring Zuul v3 online; expect service disruptions and please see https://docs.openstack.org/infra/manual/zuulv3.html for more information.18:24
*** rbudden has quit IRC18:26
openstackgerritRushil Chugh proposed openstack/ironic-specs master: Add spec for XClarity Driver  https://review.openstack.org/47692218:27
openstackgerritJohn L. Villalovos proposed openstack/ironic master: ipmitool: reboot: Don't power off node if already off  https://review.openstack.org/50729718:27
*** vsaienk0 has quit IRC18:28
*** e0ne has joined #openstack-ironic18:28
openstackgerritJohn L. Villalovos proposed openstack/ironic master: ipmitool: reboot: Don't power off node if already off  https://review.openstack.org/50729718:29
*** dpawar has joined #openstack-ironic18:32
*** dpawar has quit IRC18:33
*** livelace has quit IRC18:35
*** rbudden has joined #openstack-ironic18:36
*** e0ne has quit IRC18:36
*** srobert_ has quit IRC18:37
*** rbudden has quit IRC18:38
openstackgerritFellype Cavalcante proposed openstack/ironic stable/ocata: Fix multitenancy scenario on OneView Driver  https://review.openstack.org/50763218:38
*** fellypefca is now known as fellypefca-afk18:39
anupnHi jlvillal: so in my tinycore image with py3.3 i am getting the "no module named udev" with root user as well.18:44
anupnjlvillal, i think so now my env and gate env is in same state and need to figure why root user is able to find the library with py2.7 and not with py3.3?18:45
*** dprince has joined #openstack-ironic18:53
*** baoli has quit IRC18:57
*** MattMan has quit IRC18:58
*** MattMan has joined #openstack-ironic18:59
*** baoli has joined #openstack-ironic18:59
*** ianw|pto is now known as ianw19:01
*** livelace has joined #openstack-ironic19:03
*** Goneri has quit IRC19:03
*** amarao has joined #openstack-ironic19:03
*** ijw has quit IRC19:03
*** ChubYann has joined #openstack-ironic19:09
*** srobert has joined #openstack-ironic19:22
*** srobert has quit IRC19:22
*** srobert has joined #openstack-ironic19:23
*** ijw has joined #openstack-ironic19:28
*** etingof has joined #openstack-ironic19:29
*** ijw has quit IRC19:33
*** rcernin has quit IRC19:34
*** ijw has joined #openstack-ironic19:35
*** ijw has quit IRC19:40
*** d0ugal has joined #openstack-ironic19:41
*** d0ugal has quit IRC19:41
*** d0ugal has joined #openstack-ironic19:41
*** jkilpatr has quit IRC19:50
*** baoli has quit IRC20:00
*** baoli has joined #openstack-ironic20:04
*** pcaruana has quit IRC20:05
openstackgerritRuby Loo proposed openstack/ironic master: Rolling upgrades related dev documentation  https://review.openstack.org/41943920:06
*** amarao has quit IRC20:08
*** amarao has joined #openstack-ironic20:09
openstackgerritJohn L. Villalovos proposed openstack/ironic master: Reduce complexity of node_power_action() function  https://review.openstack.org/50766820:21
openstackgerritJohn L. Villalovos proposed openstack/ironic master: Reduce complexity of node_power_action() function  https://review.openstack.org/50766820:21
*** mat128 has quit IRC20:23
*** jkilpatr has joined #openstack-ironic20:26
*** radez has quit IRC20:32
*** Goneri has joined #openstack-ironic20:32
openstackgerritJohn L. Villalovos proposed openstack/ironic master: ipmitool: reboot: Don't power off node if already off  https://review.openstack.org/50729720:35
*** baoli_ has joined #openstack-ironic20:35
*** radez has joined #openstack-ironic20:35
*** ijw has joined #openstack-ironic20:36
*** baoli has quit IRC20:36
*** penick has quit IRC20:39
*** crushil has quit IRC20:42
*** ijw has quit IRC20:43
*** rbudden has joined #openstack-ironic20:43
openstackgerritJohn L. Villalovos proposed openstack/ironic master: Reduce complexity of node_power_action() function  https://review.openstack.org/50766820:44
openstackgerritJohn L. Villalovos proposed openstack/ironic master: ipmitool: reboot: Don't power off node if already off  https://review.openstack.org/50729720:44
*** penick has joined #openstack-ironic20:44
* jlvillal hopes he is done :)20:46
* jlvillal discovers he is not :(20:48
*** jcoufal_ has quit IRC20:49
openstackgerritJohn L. Villalovos proposed openstack/ironic master: Reduce complexity of node_power_action() function  https://review.openstack.org/50766820:52
openstackgerritJohn L. Villalovos proposed openstack/ironic master: ipmitool: reboot: Don't power off node if already off  https://review.openstack.org/50729720:52
jlvillalOkay, all unit tests passed :)20:52
rloojlvillal: i had a thought that your change won't work. guess i should actually look at it.20:53
jlvillalrloo: Which change is that?20:53
rloojlvillal: ^^20:53
jlvillalrloo: The reduce complexity?20:53
jlvillalrloo: The don't power off?20:53
*** ijw has joined #openstack-ironic20:54
rloojlvillal: dunno, i didn't look but i saw some comment where you say you are moving the power-status check into the reboot() method. or something like that. or i interpreted it as that.20:54
rloojlvillal: well, maybe it will work now that i think of it a bit more. but i haven't actually looked at your change.20:54
jlvillalrloo: Right. Yeah, I did move it into the reboot method. And have also made the node_power_action() function smarter so it only gets the power status if it can actually use that info.20:55
rloojlvillal: thinking i'll maybe look tomorrow. i can't deal with too many changes to one patch.20:55
jlvillalrloo: No worries :)20:55
jlvillalI'd like to see what the CI says.20:55
*** trown is now known as trown|outtypewww20:55
rloojlvillal: is it ok to move into the reboot? what about reboot for other drivers.20:55
jlvillaland check if the CI is broken for everyone20:55
rloojlvillal: i think it might be ok, just not sure cuz you've moved functionality from conductor down to drivers20:56
rloojlvillal: and clearly, i'm not thinking that straight now :)20:56
jlvillalrloo: This is an ipmitool issue. I added getting the power state in ipmitool.py. I didn't remove it from the conductor though.20:56
rloojlvillal: ahhh. best that i look at the code first.20:57
jlvillalrloo: Thanks for the input though! I think it is much better from my starting point.20:57
jlvillalrloo: The power of good reviews :)20:58
rloojlvillal: :)21:00
*** dprince has quit IRC21:06
*** baoli_ has quit IRC21:07
jlvillalWe're sorry -- the Sourceforge site is currently in Disaster Recovery mode, and currently requires21:09
jlvillalthe use of javascript to function.  Please check back later.21:09
jlvillalOuch, I think this is the reason our builds are failing :(21:09
jlvillalrloo: TheJulia: Why I think our gate is broken ^^^21:11
rloojlvillal: wow21:11
jlvillalYeah :(21:11
rloojlvillal: maybe update our whiteboard21:12
jlvillalrloo: will do21:12
*** srobert has quit IRC21:12
rloojlvillal: thx!21:12
*** amarao has quit IRC21:23
jlvillalSo sourceforge has problems: https://twitter.com/sfnet_ops21:25
*** zhangfei has joined #openstack-ironic21:27
* TheJulia takes a look21:29
jlvillalSourceforge does have a problem: https://twitter.com/sfnet_ops/status/91276440864394035521:29
jlvillalI guess we just need to be patient21:29
jlvillalAs an FYI, our failure getting ipmitool tarball: http://logs.openstack.org/72/507272/3/check/gate-tempest-dsvm-ironic-lib-wholedisk-agent_ipmitool-ubuntu-xenial/6d8f17d/logs/devstacklog.txt.gz#_2017-09-26_18_01_22_73821:30
TheJuliafun21:31
TheJulia:(21:31
NobodyCam:(21:33
*** zhangfei has quit IRC21:42
*** r-daneel has quit IRC21:43
openstackgerritYusef Shaban proposed openstack/sushy master: Implement Redfish Sessions  https://review.openstack.org/47194221:43
openstackgerritYusef Shaban proposed openstack/sushy master: Implement Redfish Sessions  https://review.openstack.org/47194221:44
*** d0ugal has quit IRC21:44
*** ijw has quit IRC21:49
*** cdearborn has quit IRC21:49
*** ijw has joined #openstack-ironic21:50
*** amarao has joined #openstack-ironic21:51
*** bfournie has quit IRC21:54
*** Goneri has quit IRC21:58
*** penick has quit IRC22:01
*** hjensas has quit IRC22:11
*** amarao has quit IRC22:12
*** jaypipes has quit IRC22:16
*** mat128 has joined #openstack-ironic22:24
*** Sukhdev has joined #openstack-ironic22:24
*** rbudden has quit IRC22:26
*** mat128 has quit IRC22:29
*** rloo has quit IRC22:33
*** jlabarre has quit IRC22:39
jlvillalTheJulia: As a note, I think it is only the IPA gate that is broken. I updated the whiteboard.22:40
*** causten has quit IRC22:41
*** causten has joined #openstack-ironic22:41
TheJuliajlvillal: thanks!22:42
*** causten has quit IRC22:46
*** jcoufal has joined #openstack-ironic23:31
*** jcoufal has quit IRC23:40
*** penick has joined #openstack-ironic23:48
*** penick has quit IRC23:53
*** penick has joined #openstack-ironic23:55

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!