openstackgerrit | Anup Navare proposed openstack/ironic-inspector master: Improves documentation for discovery https://review.openstack.org/477640 | 00:26 |
---|---|---|
*** dyasny_ has quit IRC | 00:26 | |
*** ijw has joined #openstack-ironic | 00:26 | |
*** ijw has quit IRC | 00:31 | |
*** ijw has joined #openstack-ironic | 00:32 | |
*** zshi_ has joined #openstack-ironic | 00:34 | |
*** karimb has quit IRC | 00:35 | |
*** baoli has joined #openstack-ironic | 00:53 | |
*** baoli has quit IRC | 00:54 | |
*** baoli has joined #openstack-ironic | 00:55 | |
*** hw_wutianwei has joined #openstack-ironic | 00:55 | |
*** wong has joined #openstack-ironic | 00:56 | |
*** stendulker has joined #openstack-ironic | 00:59 | |
*** phuongnh has joined #openstack-ironic | 01:01 | |
*** sasha2 has quit IRC | 01:04 | |
*** mat128 has joined #openstack-ironic | 01:04 | |
*** sasha2 has joined #openstack-ironic | 01:04 | |
wong | aha!morning | 01:04 |
*** litao__ has joined #openstack-ironic | 01:05 | |
*** ijw has quit IRC | 01:08 | |
*** rbudden has quit IRC | 01:08 | |
*** yangyapeng has joined #openstack-ironic | 01:10 | |
*** zhangfei has joined #openstack-ironic | 01:27 | |
*** trungnv has quit IRC | 01:40 | |
*** rama_y has joined #openstack-ironic | 01:46 | |
*** rama_y has quit IRC | 01:47 | |
*** rama_y has joined #openstack-ironic | 01:47 | |
*** zshi_ has quit IRC | 01:47 | |
*** priteau has joined #openstack-ironic | 01:50 | |
*** mguz__ has quit IRC | 01:53 | |
*** priteau has quit IRC | 01:55 | |
*** mguz__ has joined #openstack-ironic | 01:56 | |
TheJulia | crushil: no worries, I was just waving through the internet | 01:57 |
TheJulia | wong: good morning! | 01:57 |
*** stendulker has quit IRC | 02:01 | |
*** rbudden has joined #openstack-ironic | 02:02 | |
*** rbudden has quit IRC | 02:02 | |
openstackgerrit | ShangXiao proposed openstack/ironic-inspector master: i[Trivialfix]Fix typos in ironic-inspector https://review.openstack.org/499866 | 02:05 |
*** pmannidi has joined #openstack-ironic | 02:08 | |
openstackgerrit | ShangXiao proposed openstack/ironic-inspector master: Replace http with https for doc links in ironic-inspector https://review.openstack.org/499868 | 02:14 |
crushil | TheJulia, Haha. \o/ | 02:15 |
*** rama_y has quit IRC | 02:20 | |
wong | :) | 02:21 |
*** TuanLA has joined #openstack-ironic | 02:21 | |
wong | hi, how to monitor the node? | 02:23 |
*** thegreenhundred has joined #openstack-ironic | 02:31 | |
*** jlabarre has quit IRC | 02:31 | |
*** mguz__ has quit IRC | 02:49 | |
*** mguz__ has joined #openstack-ironic | 02:52 | |
*** zshi_ has joined #openstack-ironic | 03:22 | |
*** stendulker has joined #openstack-ironic | 03:26 | |
*** baoli has quit IRC | 03:26 | |
*** baoli has joined #openstack-ironic | 03:27 | |
*** baoli has quit IRC | 03:31 | |
*** links has joined #openstack-ironic | 03:32 | |
*** udesale has joined #openstack-ironic | 03:37 | |
*** mguz__ has quit IRC | 03:40 | |
*** Nisha_Agarwal has joined #openstack-ironic | 03:43 | |
Nisha_Agarwal | morning Ironic!!! | 03:46 |
wong | morning | 03:47 |
Nisha_Agarwal | wong, o/ | 03:47 |
*** sasha2 has quit IRC | 03:47 | |
*** sasha2 has joined #openstack-ironic | 03:48 | |
*** sasha2 has joined #openstack-ironic | 03:48 | |
wong | are there any projects to monitor nodes? | 03:48 |
*** baoli has joined #openstack-ironic | 03:51 | |
*** priteau has joined #openstack-ironic | 03:51 | |
*** crushil has quit IRC | 03:52 | |
*** priteau has quit IRC | 03:56 | |
*** mguz has joined #openstack-ironic | 03:57 | |
*** sasha2 has quit IRC | 04:09 | |
*** baoli has quit IRC | 04:34 | |
*** mguz has quit IRC | 04:34 | |
*** yangyapeng has quit IRC | 04:41 | |
*** MattMan_1 has quit IRC | 04:50 | |
*** MattMan_1 has joined #openstack-ironic | 04:50 | |
*** jaianshu has joined #openstack-ironic | 04:55 | |
*** yangyapeng has joined #openstack-ironic | 04:57 | |
*** pmannidi has quit IRC | 04:59 | |
*** mguz has joined #openstack-ironic | 05:03 | |
*** hoonetorg has quit IRC | 05:05 | |
*** mat128 has quit IRC | 05:07 | |
*** hoonetorg has joined #openstack-ironic | 05:22 | |
*** marios has joined #openstack-ironic | 05:44 | |
*** marios_ has joined #openstack-ironic | 05:45 | |
*** rivers has quit IRC | 05:45 | |
*** rivers has joined #openstack-ironic | 05:47 | |
*** mjura has joined #openstack-ironic | 05:48 | |
*** mjura has quit IRC | 05:49 | |
*** mjura has joined #openstack-ironic | 05:49 | |
*** links has quit IRC | 05:50 | |
*** priteau has joined #openstack-ironic | 05:52 | |
*** priteau has quit IRC | 05:57 | |
*** yangyapeng has quit IRC | 05:57 | |
*** mguz has quit IRC | 05:59 | |
*** links has joined #openstack-ironic | 06:02 | |
*** yangyapeng has joined #openstack-ironic | 06:04 | |
*** parlos has joined #openstack-ironic | 06:15 | |
*** pcaruana has joined #openstack-ironic | 06:17 | |
openstackgerrit | Dao Cong Tien proposed openstack/ironic master: WIP: Implement console log support for Socat console https://review.openstack.org/499909 | 06:20 |
*** jtomasek has joined #openstack-ironic | 06:20 | |
*** parlos has quit IRC | 06:22 | |
*** parlos has joined #openstack-ironic | 06:22 | |
*** parlos has quit IRC | 06:23 | |
*** parlos has joined #openstack-ironic | 06:23 | |
*** parlos has quit IRC | 06:24 | |
*** parlos has joined #openstack-ironic | 06:24 | |
*** parlos has quit IRC | 06:25 | |
*** parlos has joined #openstack-ironic | 06:25 | |
*** parlos has quit IRC | 06:26 | |
*** parlos has joined #openstack-ironic | 06:26 | |
*** parlos has joined #openstack-ironic | 06:27 | |
*** parlos has quit IRC | 06:28 | |
*** mguz has joined #openstack-ironic | 06:29 | |
*** jaganathan has joined #openstack-ironic | 06:32 | |
*** phuongnh has quit IRC | 06:32 | |
*** rcernin has joined #openstack-ironic | 06:33 | |
*** phuongnh has joined #openstack-ironic | 06:33 | |
*** Nisha_Agarwal has quit IRC | 06:44 | |
openstackgerrit | Shivanand Tendulker proposed openstack/ironic stable/pike: Boot from volume fails with 'iscsi' deploy interface https://review.openstack.org/499911 | 06:44 |
*** jaganathan has quit IRC | 06:46 | |
*** charcol has quit IRC | 06:47 | |
*** jaganathan has joined #openstack-ironic | 06:49 | |
openstackgerrit | Merged openstack/bifrost master: Fix the dhcp checks on centos https://review.openstack.org/499498 | 07:03 |
*** hjensas has joined #openstack-ironic | 07:07 | |
pas-ha | wong, AFAIK ceilometer can be configured to collect some info from nodes over SNMP | 07:08 |
pas-ha | and good morning ironic :) | 07:08 |
wong | but if we put it in tenant network, we can't connect it | 07:11 |
*** tesseract has joined #openstack-ironic | 07:12 | |
*** mgoddard has joined #openstack-ironic | 07:17 | |
*** d0ugal has quit IRC | 07:20 | |
*** karimb has joined #openstack-ironic | 07:33 | |
karimb | dtantsur|afk anything more needed for https://review.openstack.org/#/c/301226/ | 07:38 |
patchbot | patch 301226 - ironic-staging-drivers - Ovirt support | 07:38 |
karimb | ? | 07:38 |
openstackgerrit | Merged openstack/ironic-inspector master: i[Trivialfix]Fix typos in ironic-inspector https://review.openstack.org/499866 | 07:38 |
*** racedo has joined #openstack-ironic | 07:38 | |
*** Nisha_Agarwal has joined #openstack-ironic | 07:39 | |
*** lifeless_ is now known as lifeless | 07:39 | |
*** ralonsoh has joined #openstack-ironic | 07:49 | |
*** livelace has joined #openstack-ironic | 07:49 | |
*** TuanLA has quit IRC | 07:50 | |
*** TuanLA has joined #openstack-ironic | 07:51 | |
*** priteau has joined #openstack-ironic | 07:53 | |
*** priteau has quit IRC | 07:58 | |
*** yangyapeng has quit IRC | 08:01 | |
*** lucas-hungry is now known as lucasagomes | 08:04 | |
*** yangyapeng has joined #openstack-ironic | 08:05 | |
vdrok | good morning ironic! | 08:05 |
openstackgerrit | paresh sao proposed openstack/ironic master: Add change in 'iscsi' deploy interface to call boot interface https://review.openstack.org/499926 | 08:12 |
wong | morning/afternoon :) | 08:14 |
*** jaianshu_ has joined #openstack-ironic | 08:14 | |
*** jaianshu has quit IRC | 08:18 | |
vdrok | hi wong :) | 08:18 |
*** yangyapeng has quit IRC | 08:31 | |
*** yangyapeng has joined #openstack-ironic | 08:32 | |
*** yangyapeng has quit IRC | 08:36 | |
*** adisky__ has quit IRC | 08:49 | |
*** syqian__ has quit IRC | 08:50 | |
*** syqian__ has joined #openstack-ironic | 08:50 | |
*** yangyapeng has joined #openstack-ironic | 08:50 | |
*** yangyapeng has quit IRC | 08:51 | |
*** syqian__ has quit IRC | 08:53 | |
stendulker | morning vdrok, wong | 08:55 |
wong | morning :) | 08:56 |
vdrok | good morning stendulker | 08:59 |
*** yangyapeng has joined #openstack-ironic | 09:00 | |
*** priteau has joined #openstack-ironic | 09:02 | |
*** e0ne has joined #openstack-ironic | 09:09 | |
*** milan has joined #openstack-ironic | 09:11 | |
milan | morning Ironic! :) | 09:11 |
*** sambetts|afk is now known as sambetts | 09:11 | |
milan | #pixiesay -mflexing rainy weather --- sleepy Friday | 09:12 |
PixieBoots | ᕙʕ⇀ᴥ⇀ʔᕗ: rainy weather | 09:12 |
milan | morning aarefiev sambetts! :) | 09:12 |
aarefiev | morning! | 09:12 |
sambetts | Morning milan o/ | 09:12 |
milan | aarefiev, I guess you're right about the lock release | 09:13 |
milan | aarefiev, and I've just realised the self.app isn't shut-down | 09:13 |
aarefiev | milan: hmm, we don't shutdown app? | 09:14 |
milan | aarefiev, I don't think so | 09:15 |
milan | aarefiev, this is how it's supposed to be done for the simple server (werkzeug): http://flask.pocoo.org/snippets/67/ | 09:15 |
*** Nisha_Agarwal has quit IRC | 09:15 | |
milan | modulo the api part | 09:15 |
* milan double checks | 09:16 | |
milan | aarefiev, no git grep match | 09:17 |
*** etingof has quit IRC | 09:18 | |
milan | aarefiev, sambetts guys, how do you feel about it missing? should I put it in https://review.openstack.org/#/c/487909 or rather a separate patch? | 09:18 |
patchbot | patch 487909 - ironic-inspector - Allow periodics to terminate inspector | 09:18 |
*** hshiina has joined #openstack-ironic | 09:19 | |
aarefiev | I'd do it in separate one | 09:19 |
milan | ack, if sambetts acks ;) | 09:21 |
aarefiev | milan: I'm also wondering if sys.exit may trigger it | 09:24 |
milan | hmmm maybe | 09:25 |
* milan looks | 09:26 | |
*** udesale__ has joined #openstack-ironic | 09:27 | |
*** udesale has quit IRC | 09:27 | |
sambetts | hmm, it does make me wonder because we have multiple threads running, if one thread calls sys.exit does it kill the other threads | 09:27 |
vdrok | morning aarefiev milan and sambetts | 09:28 |
*** udesale has joined #openstack-ironic | 09:29 | |
milan | morning vdrok! :) | 09:29 |
aarefiev | vdrok o/ :) | 09:29 |
*** etingof has joined #openstack-ironic | 09:30 | |
*** udesale__ has quit IRC | 09:31 | |
milan | sambetts, https://stackoverflow.com/questions/905189/why-does-sys-exit-not-exit-when-called-inside-a-thread-in-python | 09:31 |
milan | but we're joining all, save from any threads that the simple server might have spun | 09:32 |
sambetts | milan: what I mean is that periodic worker that is running the perodic tasks is one thread, and the run() function that is running self.app.run is another thread, so does the sys.exit in shutdown run in the periodic thread or in the main thread running self.app.run>?># | 09:35 |
sambetts | ? | 09:35 |
milan | sambetts, ah, I see... /me checks | 09:37 |
*** amarao has joined #openstack-ironic | 09:38 | |
*** e0ne has quit IRC | 09:38 | |
*** amarao1 has joined #openstack-ironic | 09:38 | |
*** amarao has quit IRC | 09:38 | |
*** e0ne has joined #openstack-ironic | 09:38 | |
milan | sambetts, it may be any thread because of the watchdog method | 09:38 |
*** amarao1 has quit IRC | 09:39 | |
*** amarao has joined #openstack-ironic | 09:39 | |
sambetts | milan: yeah... self.shutdown is called in a new thread, which means that sys.exit is called inside a thread which won't shutdown the whole app correctly | 09:40 |
milan | yup but the code performs the shutting down of the periodics and executor, waiting for it to finish | 09:40 |
*** udesale has quit IRC | 09:40 | |
sambetts | milan: I think we need to call self.app.shutdown to something too right?? | 09:41 |
*** udesale has joined #openstack-ironic | 09:41 | |
sambetts | or something* | 09:41 |
milan | sambetts, yeah seems like that | 09:41 |
milan | I guess I better put it in this patch so we don't introduce a hanging inspector? | 09:41 |
*** e0ne has quit IRC | 09:42 | |
*** e0ne has joined #openstack-ironic | 09:42 | |
sambetts | yeah thats what I'm thinking, because before this patch shutdown() can only be called when self.app stops for whatever reason | 09:43 |
sambetts | so there is no reason to worry about it | 09:43 |
sambetts | but with your patch self.app will be left running | 09:43 |
sambetts | if shutdown is called by the periodic | 09:43 |
milan | right | 09:43 |
*** udesale has quit IRC | 09:44 | |
* milan amends, shouldn't be a big addition | 09:45 | |
sambetts | thanks :) | 09:45 |
milan | aarefiev, sambetts thanks for the discussion! :) | 09:46 |
aarefiev | hmm, does sys.exit shutdowns only green thread? | 09:46 |
sambetts | aarefiev: if sys.exit is called inside a thread it acts just like thread.exit() | 09:48 |
sambetts | although green threads might change the behaviour | 09:49 |
sambetts | unsure on that | 09:49 |
aarefiev | I'm wondering how it works now | 09:49 |
aarefiev | with milan' patch | 09:50 |
sambetts | :/ we don't have a CI test that tests shutting down the service do we? I guess if we added grenade it would test that | 09:51 |
milan | aarefiev, so my take on it is any periodic can trigger now the wsgi.shutdown | 09:51 |
milan | so we'd better explicitly stop the app in case it has spun any threads | 09:52 |
*** yangyapeng has quit IRC | 09:52 | |
milan | aarefiev, sambetts, devstack now isntead of sigabrt sends sigterm and we not handling it, the default is process terminates | 09:53 |
milan | so this shutdown is never called in CI | 09:53 |
milan | since devstack switched away from screen to systemd | 09:53 |
milan | is still devstack branching a thing? ;) | 09:54 |
milan | so that's going to be another patch: allow handling of the sigterm -> shutdown | 09:54 |
aarefiev | milan, yeah, but did you try your patch in negative scenario | 09:54 |
sambetts | +1 to another patch | 09:54 |
aarefiev | did it shutdown service? | 09:54 |
milan | aarefiev, yeah I was able to test it manually, couple of revisions ago | 09:55 |
*** yangyapeng has joined #openstack-ironic | 09:55 | |
milan | have to do it again though | 09:55 |
milan | to be on the safe side | 09:55 |
aarefiev | so I'm wondering if eventlet patches exit method | 09:55 |
* milan tried custom exceptions on custom places | 09:55 | |
aarefiev | or exception goes up to native thread | 09:56 |
milan | dunno, it's all monkey patched, but the exceptions propagate to anyone that waits | 09:56 |
milan | iirc it's implemented through event.Event | 09:57 |
milan | so what ever exception happens in a greenlet, you won't see unless you wait | 09:57 |
* milan checks if it applies to SystemExit too | 09:58 | |
*** karthiks is now known as karthiks_afk | 09:58 | |
sambetts | blah /me hates eventlet, green threads and all the monkey patching | 09:58 |
aarefiev | eventlet thread may catch SystemExit exception and shutdown or it may raise it up to native thread | 09:58 |
aarefiev | I'm not sure now :) | 09:58 |
milan | aarefiev, https://github.com/eventlet/eventlet/blob/4d2cdca17a44b19405d4cdeafc898a500fe2485c/eventlet/greenthread.py#L175 | 10:09 |
milan | that's the waiting | 10:09 |
milan | it polls the event object that holds either exception or return value | 10:10 |
aarefiev | does it reraise exception | 10:12 |
aarefiev | after sending the event | 10:12 |
milan | yup | 10:14 |
milan | once you wait on it I mean | 10:14 |
milan | but what really stops the whole thing is the hub | 10:14 |
milan | hub.abort() | 10:14 |
* milan can't find how the SystemExit is handled right now | 10:17 | |
milan | but https://github.com/eventlet/eventlet/blob/4d2cdca17a44b19405d4cdeafc898a500fe2485c/eventlet/greenthread.py doesn't seem to have special handling for SystemExit | 10:17 |
milan | so I guess it's the same as any other exc | 10:18 |
*** d0ugal has joined #openstack-ironic | 10:18 | |
* milan -> lunch bbl, but going to add: | 10:19 | |
milan | * the semaphore.release before sys.exit() | 10:19 |
milan | * the app shut down call before periodics call | 10:19 |
*** yangyapeng has quit IRC | 10:21 | |
*** hw_wutianwei has quit IRC | 10:21 | |
*** TuanLA has quit IRC | 10:30 | |
*** wong has quit IRC | 10:31 | |
*** amarao has quit IRC | 10:33 | |
*** hw_wutianwei has joined #openstack-ironic | 10:34 | |
*** jaianshu_ has quit IRC | 10:37 | |
*** ricardoas has quit IRC | 10:43 | |
*** mgoddard has quit IRC | 10:44 | |
*** parlos has joined #openstack-ironic | 10:59 | |
*** mrch has joined #openstack-ironic | 11:00 | |
*** lucasagomes is now known as lucas-afk | 11:06 | |
*** fxpester has quit IRC | 11:10 | |
*** stendulker_ has joined #openstack-ironic | 11:11 | |
*** fxpester has joined #openstack-ironic | 11:12 | |
*** mgoddard has joined #openstack-ironic | 11:13 | |
*** stendulker has quit IRC | 11:14 | |
*** stendulker_ has quit IRC | 11:15 | |
*** fellypefca has joined #openstack-ironic | 11:26 | |
fellypefca | Good Morning, Ironic :D TGIF | 11:29 |
fellypefca | milan hey, yesterday I revived an all-green-beuty too 8) heh my 468129 has passed in all CI's | 11:31 |
*** mat128 has joined #openstack-ironic | 11:35 | |
*** hw_wutianwei has quit IRC | 11:39 | |
*** zhangfei has quit IRC | 11:51 | |
*** dprince has joined #openstack-ironic | 11:53 | |
*** srobert has joined #openstack-ironic | 11:56 | |
*** srobert has quit IRC | 11:56 | |
*** srobert has joined #openstack-ironic | 11:57 | |
*** rbudden has joined #openstack-ironic | 11:57 | |
milan | morning fellypefca! Oh yeah, happens once in fool moon doesn't it ;) | 12:03 |
milan | TGIF indeed! :D | 12:03 |
fellypefca | milan yeah haha :) | 12:04 |
*** litao__ has quit IRC | 12:07 | |
*** trown|outtypewww is now known as trown | 12:08 | |
openstackgerrit | paresh sao proposed openstack/ironic master: Boot from volume fails with 'iscsi' deploy interface https://review.openstack.org/499926 | 12:20 |
milan | aarefiev, sambetts, so turns out app runs in the "main" thread, you can try yourself: app = flask.Flask('Foo'). Moreover, http://flask.pocoo.org/snippets/67/ works only in a request context so not going to work (actually raises a RuntimeError) | 12:21 |
sambetts | milan: right, but does the sys.exit in the eventlet thread actually successfully kill the main thread and any child threads it might have started? | 12:22 |
milan | sambetts, exactly what I'm trying to figure out right now | 12:23 |
openstackgerrit | paresh sao proposed openstack/ironic master: Boot from volume fails with 'iscsi' deploy interface https://review.openstack.org/499926 | 12:23 |
sambetts | milan: hmmm we could add the /shutdown endpoint that they are going on about in that snippet, and lock it down so its not accessible as a useable endpoint, and then make a request from def shutdown() to that endpoint | 12:26 |
milan | yeah as a separate patch :D | 12:27 |
sambetts | I can't believe there is no self.app.stop... thats so dumb... | 12:27 |
milan | sambetts, cause flask is expected to be run from a real server | 12:27 |
sambetts | unicorn or something? | 12:27 |
milan | the app is the debugging werkzeug thing but yeah, it is stupid indeed | 12:27 |
milan | sambetts, or uwsgi or whatever | 12:28 |
*** jlabarre has joined #openstack-ironic | 12:29 | |
*** udesale has joined #openstack-ironic | 12:29 | |
*** phuongnh has quit IRC | 12:33 | |
*** krtaylor has joined #openstack-ironic | 12:40 | |
fellypefca | sambetts Could you take a look when you have some free time?:) https://review.openstack.org/#/c/468129 | 12:41 |
patchbot | patch 468129 - ironic - Introduce hpOneView and ilorest to OneView | 12:41 |
milan | sambetts, http://paste.openstack.org/show/620207/ | 12:49 |
*** jcoufal has joined #openstack-ironic | 12:51 | |
milan | and aarefiev too :P ^ | 12:51 |
aarefiev | milan: and what is the result :) | 12:52 |
* milan guess should save just to release the semaphore and don't care about the app | 12:52 | |
*** zhangfei has joined #openstack-ironic | 12:53 | |
milan | the SystemExit kills the app | 12:53 |
milan | somehow | 12:53 |
milan | :D | 12:53 |
sambetts | milan: are you running that in python3? I'm getting syntax errors running that paste | 12:53 |
milan | yup python3 | 12:53 |
* aarefiev too lazy to copy-paste script | 12:53 | |
aarefiev | That's what I expect | 12:54 |
sambetts | I wonder if its because its a greenthread | 12:55 |
sambetts | :/ | 12:55 |
milan | can well be | 12:55 |
milan | let's blame the monkey patch for it :D | 12:55 |
*** edleafe is now known as figleaf | 12:57 | |
milan | or let's merge it and I'll follow-up with an explicit semaphore.release() ;) | 12:57 |
milan | aarefiev, sambetts ^ :P | 12:57 |
*** sasha2 has joined #openstack-ironic | 12:59 | |
sambetts | milan: just tested with a real thread instead of eventlet and it didn't exit the main thread | 12:59 |
sambetts | I didn't remove the monkey patch though | 12:59 |
milan | wow | 12:59 |
sambetts | so there must be some wizardry in eventlet itself that handles it | 12:59 |
*** thegreenhundred has quit IRC | 13:02 | |
*** SerenaFeng has joined #openstack-ironic | 13:04 | |
sambetts | i wonder if its because eventlet isn't using real threads, so everything is running in the native thread therefore sys.exit is in the native thread | 13:08 |
*** exodusftw has quit IRC | 13:11 | |
milan | sambetts, can be | 13:12 |
milan | I've found just this https://github.com/eventlet/eventlet/blob/4d2cdca17a44b19405d4cdeafc898a500fe2485c/eventlet/hubs/pyevent.py | 13:12 |
milan | the pyevent hub seems to care about the SystemExit | 13:12 |
*** crushil has joined #openstack-ironic | 13:13 | |
aarefiev | It's seems reasonable to me | 13:13 |
*** baoli has joined #openstack-ironic | 13:14 | |
sambetts | so as long as we don't move away from eventlet then it should be ok I guess | 13:14 |
milan | ack | 13:17 |
*** exodusftw has joined #openstack-ironic | 13:17 | |
aarefiev | I guess python coroutines work in same way | 13:18 |
milan | or someone will file a very urgent bug O:-) | 13:20 |
milan | * one day | 13:20 |
*** efried is now known as fried_rice | 13:20 | |
*** Goneri has joined #openstack-ironic | 13:24 | |
*** rivers has quit IRC | 13:26 | |
*** sasha2 has quit IRC | 13:26 | |
*** hshiina has quit IRC | 13:26 | |
*** rivers has joined #openstack-ironic | 13:26 | |
*** sasha2 has joined #openstack-ironic | 13:32 | |
TheJulia | good morning everyone | 13:35 |
fellypefca | Good morning TheJulia :) | 13:35 |
*** zshi_ has quit IRC | 13:36 | |
*** dyasny has joined #openstack-ironic | 13:36 | |
milan | morning TheJulia! :) | 13:38 |
*** e0ne has quit IRC | 13:40 | |
*** e0ne has joined #openstack-ironic | 13:41 | |
*** udesale has quit IRC | 13:42 | |
openstackgerrit | Milan Kováčik proposed openstack/ironic-inspector master: Refactoring the firewall https://review.openstack.org/471831 | 13:42 |
openstackgerrit | Milan Kováčik proposed openstack/ironic-inspector master: Allow periodics to terminate inspector https://review.openstack.org/487909 | 13:42 |
openstackgerrit | Milan Kováčik proposed openstack/ironic-inspector master: Introducing a dnsmasq PXE filter driver https://review.openstack.org/466448 | 13:42 |
openstackgerrit | Milan Kováčik proposed openstack/ironic-inspector master: TEST check dnsmasq PXE filter in devstack https://review.openstack.org/468712 | 13:42 |
milan | aarefiev, sambetts, thanks for the reviews&discussion | 13:43 |
milan | btw let's make Friday the Inspector day? ;) | 13:43 |
* milan -> more coffee :) | 13:44 | |
*** links has quit IRC | 13:44 | |
*** jaganathan has quit IRC | 13:49 | |
*** baoli has quit IRC | 13:59 | |
*** rivers has quit IRC | 14:03 | |
*** SerenaFe_ has joined #openstack-ironic | 14:04 | |
*** mrch has quit IRC | 14:04 | |
*** rivers has joined #openstack-ironic | 14:04 | |
*** SerenaFeng has quit IRC | 14:05 | |
*** sasha2 has quit IRC | 14:06 | |
openstackgerrit | Bob Fournier proposed openstack/ironic-inspector master: Change example dnsmasq.conf in install doc for uefi https://review.openstack.org/500063 | 14:08 |
*** mjura has quit IRC | 14:11 | |
*** zhangfei has quit IRC | 14:14 | |
rivers | Hi, if Im not using "whole disk image" to boot baremetal, should i set "local boot" option for ironic node & flavor ? Or is that setting just for Whole disk image ? Thanks | 14:18 |
*** srobert has quit IRC | 14:18 | |
*** sasha2 has joined #openstack-ironic | 14:22 | |
*** fellypefca has quit IRC | 14:26 | |
*** SerenaFe_ has quit IRC | 14:29 | |
*** tcrowe has quit IRC | 14:34 | |
vdrok | rivers: if the image is whole disk or not determined by it having kernel and ramdisk properties in glance. if your image does not have those, you don't need to set the local boot | 14:35 |
*** baoli has joined #openstack-ironic | 14:39 | |
openstackgerrit | Bob Fournier proposed openstack/ironic-inspector master: Change example dnsmasq.conf in install doc for uefi https://review.openstack.org/500063 | 14:39 |
openstackgerrit | melissaml proposed openstack/python-ironicclient master: Fix to use "." to source script files https://review.openstack.org/500079 | 14:43 |
rivers | vdrok: Ok, cause i set local boot, and the image is not whole disk... What im seeing is that upon deploy, Im taken to the login screen for CoreOs deploy image... I thought the baremetal node is supposed to reboot itself, aftern loading the user image ? Is that correct ? | 14:44 |
vdrok | rivers: so is the image_source whole disk or not? first you do deployment with coreos deploy ramdisk, then the node should reboot into the image_source image | 14:45 |
*** skazi_ has joined #openstack-ironic | 14:45 | |
rivers | rivers: No the image is not a whole disk .... I see the ironic node provision state go from "deploying" to "wait-call-back" , and on the bare-metal host, Im taken to the login screen....I dont see it rebooting itself, | 14:47 |
rivers | vdlok: No the image is not a whole disk .... I see the ironic node provision state go from "deploying" to "wait-call-back" , and on the bare-metal host, Im taken to the login screen....I dont see it rebooting itself, | 14:47 |
sambetts | rivers: wait call back means the node is deploying, it is not complete until the node is active | 14:48 |
sambetts | the deploy ramdisk you using is coreos based, which is why you see coreos booted on the server during deployment | 14:49 |
rivers | Yeah but it never reboots, and never goes to "active" state ... after a while i just see the nova instance fail with the generic message "No Valid host' found, even though a host was found and deployed | 14:50 |
sambetts | rivers: if the deployment fails you need to look at ironic and see what error its seen | 14:50 |
*** skazi_ has quit IRC | 14:50 | |
sambetts | rivers: or if it is stuck in wait call back then it probably means the ramdisk was never able to call back to the ironic API service | 14:50 |
sambetts | and will timeout | 14:51 |
sambetts | eventually | 14:51 |
rivers | The only error i see or warning in ironic-conductor.log, is "Timed out waiting for RPC response: Timeout while waiting on RPC response - topic: "<unknown>", RPC method: "<unknown>" info: "<unknown>" _raise_timeout" | 14:51 |
sambetts | rivers: my guess is that the baremetal node is never able to call back to ironic and heartbeat to continue deployment | 14:52 |
sambetts | rivers: is the baremetal node able to reach the ironic API IP address from its IP address? | 14:53 |
rivers | sambetts: how do i verify that ? Will that info be in the logs somewhere / | 14:54 |
sambetts | rivers: if the ironic node was able to heartbeat successfully you should see agent_url populated in the driver_internal_info field on the node that is deploying | 14:55 |
sambetts | if you do a ironic node show <node> | 14:55 |
*** crushil has quit IRC | 14:56 | |
sambetts | as a operator you should know if there is a route configured between your provisioning network and your ironic API IP addres | 14:56 |
rivers | sambetts: No, so the only info i see in driver_internal_info is "driver_internal_info | {u'is_whole_disk_image': False}" , thats all | 14:56 |
sambetts | then I expect this is a networking issue | 14:57 |
rivers | Ok, yeah i think i see the issue, the "ironic user " is configured as the external OAM network, while i launched the baremetal host on a private internal network | 15:01 |
rivers | Thanks, I'll dig deeper | 15:02 |
sambetts | the provisioning network should be a network that is routable from the control plane (where ironic is running) and can route to the control plane, this allows the baremetal nodes to talk to ironic, and ironic to talk to the baremetal nodes | 15:03 |
sambetts | the normal way to do this is to make the provisioning network (flat network) a provider network, with a real world gateway router and subnet | 15:04 |
sambetts | that is routable from the outside world | 15:04 |
sambetts | and can route to the outside world | 15:04 |
sambetts | similar to how the public network (floating ip) network in neutron is traditionally configured | 15:05 |
*** crushil has joined #openstack-ironic | 15:05 | |
*** EmilienM has quit IRC | 15:12 | |
*** EmilienM has joined #openstack-ironic | 15:12 | |
*** fxpester has quit IRC | 15:16 | |
*** rpioso has joined #openstack-ironic | 15:18 | |
*** links has joined #openstack-ironic | 15:19 | |
*** parlos has quit IRC | 15:19 | |
NobodyCam | Good Morning Ironic'ers... and... | 15:20 |
NobodyCam | TGIF | 15:20 |
NobodyCam | :) | 15:20 |
*** rama_y has joined #openstack-ironic | 15:21 | |
*** thegreenhundred has joined #openstack-ironic | 15:22 | |
*** yangyapeng has joined #openstack-ironic | 15:22 | |
*** yangyapeng has quit IRC | 15:26 | |
pas-ha | NobodyCam: yes indeed it is :) and good morning | 15:27 |
NobodyCam | hey hey Good morning pas-ha :) | 15:27 |
*** rcernin has quit IRC | 15:29 | |
*** pcaruana has quit IRC | 15:30 | |
*** rama_y has quit IRC | 15:42 | |
vdrok | good morning NobodyCam | 15:56 |
NobodyCam | Hey hey Good Morning vdrok :) | 15:57 |
NobodyCam | it's Friday! | 15:58 |
*** livelace has quit IRC | 15:58 | |
*** ralonsoh has quit IRC | 16:02 | |
*** baoli_ has joined #openstack-ironic | 16:06 | |
*** baoli has quit IRC | 16:08 | |
*** marios has quit IRC | 16:08 | |
*** rama_y has joined #openstack-ironic | 16:14 | |
rpioso | Are DeployInterface.prepare() and BootInterface.prepare_instance() guaranteed to be called before ManagementInterface.set_boot_device()? | 16:20 |
sambetts | rivers: bootinterface.prepare_instance should be the one calling set_boot_device | 16:20 |
*** parlos has joined #openstack-ironic | 16:21 | |
rpioso | sambetts: So the answer is an emphatic "Yes!" :) | 16:22 |
sambetts | rpioso: in some cases, (like in the agent deploy interface with whole disk images) it might not be the case because of legacy reasons, but there is a patch up to fix that | 16:23 |
rpioso | sambetts: I see what you described in PXEBoot.prepare_instance(). | 16:25 |
rpioso | sambetts: Cool! I'll take a look at the agent deploy interface. | 16:25 |
rpioso | sambetts: May BootInterface.prepare_instance() take an extended amount of time to return to the caller, say a few minutes? | 16:27 |
rpioso | sambetts: That would allow the BMC time to affect the change to the boot mode and boot device. | 16:27 |
*** srobert has joined #openstack-ironic | 16:29 | |
*** aarefiev is now known as aarefiev_afk | 16:29 | |
sambetts | rpioso: that should be fine, there isn't a timeout applied to specific actions like that | 16:29 |
*** e0ne has quit IRC | 16:29 | |
rpioso | sambetts: And it may be done synchronously? | 16:30 |
*** links has quit IRC | 16:31 | |
sambetts | if thats what your hardware requires | 16:33 |
*** dyasny_ has joined #openstack-ironic | 16:35 | |
rpioso | sambetts: What about the set boot device API? What are the expectations regarding its interactions with or dependency on a node's boot mode setting? | 16:36 |
rpioso | sambetts: Is it expected to set the boot device for the boot mode that the hardware is already configured to use? | 16:37 |
rpioso | sambetts: Even if the h/w's boot mode does not match the ironic node config? | 16:38 |
*** dyasny has quit IRC | 16:38 | |
sambetts | rpioso: the boot device API will directly call ManagementInterface.set_boot_device regardless of the state the node is in | 16:39 |
sambetts | and ironic doesn't keep track of the expected boot device state, and even if it did that ^ would override it, exactly like setting the power state | 16:39 |
rpioso | sambetts: Yep, I see that. I'm not clear on what's expected of ManagementInterface.set_boot_device(). | 16:40 |
sambetts | set_boot_device is expected to set the boot device on the node, that is all | 16:40 |
sambetts | nothing smart about it, just an abstraction layer for different hardware | 16:41 |
rpioso | sambetts: Should it set the boot device for the boot mode that's configured in ironic, or just set it for whatever boot mode the server is set to use? | 16:41 |
rpioso | sambetts: The server's boot mode config may not match ironic's. | 16:42 |
sambetts | rpioso: i'm not sure I understand, set_boot_device takes in a parameter which is the boot device to set, and thats the device it should set | 16:42 |
rpioso | sambetts: I'm hoping it should simply set the boot device for whatever boot mode the hardware is set to use. | 16:43 |
sambetts | it sets the boot device to what ever its told to set the boot device too | 16:43 |
sambetts | its just a wrapper around the hardware specific method for setting the boot device | 16:43 |
sambetts | it shouldn't be aware about any ironic node state | 16:44 |
sambetts | set_boot_device("pxe") sets the primary boot device on the baremetal server to PXE boot | 16:44 |
sambetts | set_boot_device("cdrom") sets the primary boot device on the baremetal server to the CDROM drive | 16:45 |
*** milan has quit IRC | 16:45 | |
rpioso | Some BMC's have separate boot device lists for each boot mode. E.g., legacy BIOS (IPL)'s list can be different from UEFI's. | 16:46 |
rpioso | And to change the specific list, sometimes the associated mode must be active. | 16:47 |
anupn | Good morning Ironic'ers | 16:47 |
rpioso | Good morning, anupn | 16:48 |
anupn | rpioso, Good morning :) | 16:48 |
rpioso | :) | 16:48 |
openstackgerrit | Vladyslav Drok proposed openstack/ironic-specs master: Owner-aware baremetal nodes https://review.openstack.org/415512 | 16:49 |
sambetts | rpioso: if capabilties=boot_mode:<boot_mode> is set then it is assumed that the operator wants the node to always boot in that mode, therefore I would expect that you only need to set the boot device for that boot mode | 16:50 |
*** dprince has quit IRC | 16:50 | |
*** etingof has quit IRC | 16:50 | |
yusef | Hello, is anyone available from the core-ironic team to review my changes for the Ironic-Sushy project? The change is in regards to sessions and is available for review at https://review.openstack.org/#/c/471942/. Thank you. | 16:55 |
patchbot | patch 471942 - sushy - Implement Redfish Sessions | 16:55 |
*** Goneri has quit IRC | 16:55 | |
*** marios_ has quit IRC | 16:56 | |
rpioso | sambetts: That sounds reasonable. However, looking at the ilo example, I don't see that being done. | 16:56 |
sambetts | rpioso: likely that was implemented before boot_mode was introduce | 16:56 |
rpioso | sambetts: I may be missing something. | 16:57 |
*** penick has joined #openstack-ironic | 16:57 | |
rpioso | sambetts: Is the expectation you described documented somewhere? | 16:58 |
sambetts | rpioso: https://docs.openstack.org/ironic/latest/install/include/boot-mode.html | 16:58 |
sambetts | rpioso: 3rd bullet point down | 16:58 |
rpioso | sambetts: Hrm. That's discussing boot mode, instead of boot device. | 17:00 |
sambetts | rpioso: right, but that says that boot mode is static, so then you only need to care about setting the boot device for the active boot mode | 17:01 |
*** penick has quit IRC | 17:02 | |
rpioso | sambetts: Understand. | 17:03 |
rpioso | I believe the boot mode biz was added as part of the UEFI effort, so yes, it came after boot device. | 17:04 |
*** Goneri has joined #openstack-ironic | 17:05 | |
rpioso | sambetts: I have another question, if you have a few more minutes. It's about deprecating a hardware type's supported interface implementation. | 17:05 |
rpioso | sambetts: If a new interface implementation is a superset of the old one, should the old one be deprecated? And, if so, how is that done? | 17:06 |
*** mgoddard has quit IRC | 17:08 | |
sambetts | if its a superset of the old one, and there is no reason to use the old one, then it can/should be deprecated, the interface will need to be deprecated for one cycle, and publish a deprecation warning when it is loaded, and then can be removed in the next cycle | 17:08 |
rpioso | sambetts: Thank you! | 17:11 |
rpioso | sambetts: And a belated thank you for your assistance a couple of weeks ago. I had momentarily walked afk, and when I returned, you were afk :) | 17:12 |
sambetts | no problem :) | 17:12 |
anupn | Hi sambetts, figured that inside tinycore it should look for /usr/local/lib/python3.3 | 17:13 |
rpioso | sambetts: Hope you have a great weekend. | 17:13 |
sambetts | rpioso: you too | 17:13 |
* rpioso is hungry | 17:13 | |
*** rpioso is now known as rpioso|eat | 17:13 | |
*** e0ne has joined #openstack-ironic | 17:15 | |
*** Goneri has quit IRC | 17:17 | |
* sambetts --> home | 17:19 | |
sambetts | night all | 17:19 |
*** sambetts is now known as sambetts|afk | 17:19 | |
*** thegreenhundred has quit IRC | 17:24 | |
*** trown is now known as trown|lunch | 17:27 | |
*** harlowja has quit IRC | 17:30 | |
*** yangyapeng has joined #openstack-ironic | 17:37 | |
*** yangyapeng has quit IRC | 17:42 | |
*** mgoddard has joined #openstack-ironic | 17:49 | |
*** parlos has quit IRC | 17:50 | |
*** racedo has quit IRC | 17:51 | |
*** bnemec is now known as beekneemech | 17:56 | |
*** rpioso|eat is now known as rpioso | 18:11 | |
*** harlowja has joined #openstack-ironic | 18:12 | |
NobodyCam | Night sambetts|afk | 18:20 |
NobodyCam | have a good weekend | 18:20 |
*** trown|lunch is now known as trown | 18:29 | |
*** mgoddard has quit IRC | 18:38 | |
*** e0ne has quit IRC | 18:38 | |
*** Goneri has joined #openstack-ironic | 18:50 | |
*** ijw has joined #openstack-ironic | 19:03 | |
*** penick has joined #openstack-ironic | 19:23 | |
*** mgoddard has joined #openstack-ironic | 19:24 | |
*** etingof has joined #openstack-ironic | 19:25 | |
rama_y | Hi TheJulia, question regarding boot-from-volume | 19:26 |
rama_y | I am using Ubuntu to boot from volume and it is unable to find root device | 19:27 |
rama_y | TheJulia, any ideas? | 19:27 |
TheJulia | rama_y: none right now | 19:30 |
rama_y | TheJulia, here is the paste of the output: http://paste.openstack.org/show/620231/ | 19:31 |
*** rpioso has quit IRC | 19:34 | |
rama_y | TheJulia: did you try booting from Ubuntu volume? I am able to boot from the same image (used for create the volume). | 19:35 |
TheJulia | no, I personally have not. It is likely looking for something specific in the data structure | 19:36 |
TheJulia | you can see, it things its root is different, but it doesn't find it. | 19:36 |
rama_y | Yes | 19:37 |
openstackgerrit | Peter Piela proposed openstack/ironic-ui master: Cleanup ironic-ui REST API https://review.openstack.org/500181 | 19:44 |
*** yangyapeng has joined #openstack-ironic | 19:54 | |
*** ppiela_ has joined #openstack-ironic | 19:56 | |
*** yangyapeng has quit IRC | 19:58 | |
*** ppiela has quit IRC | 19:58 | |
*** baoli_ has quit IRC | 20:04 | |
*** mat128 has quit IRC | 20:06 | |
*** mat128 has joined #openstack-ironic | 20:06 | |
*** yangyapeng has joined #openstack-ironic | 20:07 | |
*** mat128 has quit IRC | 20:10 | |
*** yangyapeng has quit IRC | 20:11 | |
*** penick has quit IRC | 20:13 | |
*** rpioso has joined #openstack-ironic | 20:16 | |
*** rama_y has quit IRC | 20:28 | |
*** rama_y_ has joined #openstack-ironic | 20:28 | |
*** rcernin has joined #openstack-ironic | 20:31 | |
*** Goneri has quit IRC | 20:34 | |
*** mgoddard has quit IRC | 20:38 | |
*** ijw has quit IRC | 20:50 | |
*** ijw has joined #openstack-ironic | 20:52 | |
*** jcoufal has quit IRC | 20:53 | |
*** rcernin has quit IRC | 20:55 | |
*** ijw has quit IRC | 20:56 | |
*** ijw has joined #openstack-ironic | 20:56 | |
*** srobert has quit IRC | 21:01 | |
*** ijw has quit IRC | 21:05 | |
rivers | sambetts: A quick question, does the deploy image start IPA process on the baremetal node, or is it the user image that does so ? | 21:11 |
rivers | does the deploy image start IPA process on the baremetal node, or is it the user image that does so ? | 21:11 |
*** jtomasek has quit IRC | 21:32 | |
*** ijw has joined #openstack-ironic | 21:36 | |
*** rivers has quit IRC | 21:37 | |
*** rivers has joined #openstack-ironic | 21:38 | |
*** priteau has quit IRC | 21:39 | |
*** rivers has quit IRC | 21:58 | |
*** rivers has joined #openstack-ironic | 22:02 | |
*** tesseract has quit IRC | 22:09 | |
jlvillal | rivers: The deploy image is what is running IPA. | 22:11 |
jlvillal | rivers: IPA is used to 'deploy' the user image onto the node. | 22:11 |
*** baoli has joined #openstack-ironic | 22:22 | |
*** baoli has quit IRC | 22:26 | |
*** figleaf is now known as edleafe | 22:31 | |
*** ijw has quit IRC | 22:33 | |
*** ijw has joined #openstack-ironic | 22:36 | |
*** karimb has quit IRC | 22:41 | |
*** karimb has joined #openstack-ironic | 22:43 | |
*** karimb has quit IRC | 22:44 | |
JayF | rivers: IPA is a rest API for *imaging servers*. Never ever run or install it on user-facing operating systems -- only the deploy image (ramdisk). | 22:50 |
*** rama_y_ has quit IRC | 23:02 | |
*** thegreenhundred has joined #openstack-ironic | 23:16 | |
*** rwsu has quit IRC | 23:20 | |
*** thegreenhundred has quit IRC | 23:24 | |
jlvillal | JayF: Hey! Good to see you here :) | 23:24 |
*** rama_y has joined #openstack-ironic | 23:25 | |
*** jlabarre has quit IRC | 23:38 | |
*** jlabarre has joined #openstack-ironic | 23:41 | |
NobodyCam | hey hey JayF :) here for the long weekend :p | 23:57 |
NobodyCam | speaking of I think its time for me it head out, so I can start enjoying said long weekend! | 23:58 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!