Tuesday, 2017-06-20

*** ijw__ has quit IRC00:01
*** MattMan has quit IRC00:05
*** MattMan has joined #openstack-ironic00:05
*** yee37922 has joined #openstack-ironic00:09
*** openstack has joined #openstack-ironic00:17
*** sambetts_ has quit IRC00:17
*** patriciadomin_ has quit IRC00:17
*** aignatov has quit IRC00:17
*** jralph has joined #openstack-ironic00:19
*** cvstealth has joined #openstack-ironic00:19
*** sambetts_ has joined #openstack-ironic00:19
*** aignatov has joined #openstack-ironic00:20
*** patriciadomin has joined #openstack-ironic00:20
*** igordcard has joined #openstack-ironic00:20
*** early has quit IRC00:23
*** strigazi has joined #openstack-ironic00:24
*** zigo has joined #openstack-ironic00:24
*** rloo has joined #openstack-ironic00:24
*** early has joined #openstack-ironic00:30
*** yuanying has quit IRC00:36
*** dsneddon has quit IRC00:37
*** jaosorior has joined #openstack-ironic00:39
*** dsneddon has joined #openstack-ironic00:40
*** ijw has joined #openstack-ironic00:41
*** amotoki_away is now known as amotoki00:41
*** ijw has quit IRC00:43
*** ijw has joined #openstack-ironic00:43
*** bfournie has joined #openstack-ironic00:49
*** bfournie has quit IRC00:50
*** hoonetorg has quit IRC00:54
*** amotoki is now known as amotoki_away00:55
*** jkilpatr has joined #openstack-ironic00:59
openstackgerritMerged openstack/ironic-inspector master: Updated from global requirements  https://review.openstack.org/47554401:00
*** ijw has quit IRC01:02
*** SerenaFeng has joined #openstack-ironic01:03
*** harlowja has joined #openstack-ironic01:04
*** rama_y_ has quit IRC01:08
*** ijw has joined #openstack-ironic01:09
*** hoonetorg has joined #openstack-ironic01:11
*** ijw has quit IRC01:15
*** bfournie has joined #openstack-ironic01:18
*** zzzeek has quit IRC01:18
*** zzzeek has joined #openstack-ironic01:18
*** ijw has joined #openstack-ironic01:21
*** ijw has quit IRC01:26
*** hoonetorg has quit IRC01:30
*** ijw has joined #openstack-ironic01:40
*** Goneri has joined #openstack-ironic01:45
*** ijw has quit IRC01:48
*** shuyingya has joined #openstack-ironic01:48
*** hoonetorg has joined #openstack-ironic01:52
*** litao__ has joined #openstack-ironic01:55
litao__hi, guys,  I used devstack and found a issue. When I set node power state, the CLI returned ‘SSH connection cannot be established: Failed to establish SSH connection to host 192.168.2.71. (HTTP 400)’01:56
litao__Can anyone help me?01:56
litao__I had regenerate the ssh key01:57
*** hoonetorg has quit IRC01:58
*** amotoki_away is now known as amotoki02:01
*** tiendc has joined #openstack-ironic02:05
*** mpotdar has joined #openstack-ironic02:05
*** Lambert has joined #openstack-ironic02:06
*** amotoki is now known as amotoki_away02:11
*** hoonetorg has joined #openstack-ironic02:12
*** SerenaFeng has quit IRC02:16
*** SerenaFeng has joined #openstack-ironic02:16
*** Goneri has quit IRC02:23
*** Nisha_Agarwal has joined #openstack-ironic02:24
*** Lambert has quit IRC02:25
*** Guest8722 is now known as sdake02:29
*** sdake has joined #openstack-ironic02:29
*** rloo has quit IRC02:31
*** Lambert has joined #openstack-ironic02:32
*** raginbajin has quit IRC02:33
*** yuanying has joined #openstack-ironic02:35
*** amotoki_away is now known as amotoki02:36
*** raginbajin has joined #openstack-ironic02:39
*** sasha2 has quit IRC02:40
*** zhugaoxiao has joined #openstack-ironic02:51
*** yuanying has quit IRC03:04
*** yuanying has joined #openstack-ironic03:04
*** yuanying has quit IRC03:09
openstackgerritMerged openstack/ironic stable/newton: [devstack] Use global requirements for virtualbmc  https://review.openstack.org/44863103:14
*** amotoki is now known as amotoki_away03:24
*** Nisha_Agarwal has quit IRC03:26
*** Nisha_Agarwal has joined #openstack-ironic03:47
*** links has joined #openstack-ironic03:58
*** SerenaFeng has quit IRC03:59
openstackgerritAparna proposed openstack/proliantutils master: Support to perform erase on all the disks(volumes and drives)  https://review.openstack.org/43645004:20
*** adisky__ has joined #openstack-ironic04:34
*** jerrygb has joined #openstack-ironic04:36
*** aparnav has joined #openstack-ironic04:38
*** amotoki_away is now known as amotoki04:48
*** makowals has quit IRC04:56
openstackgerritNisha Agarwal proposed openstack/ironic-specs master: Adds PCI device inspection to ironic  https://review.openstack.org/47564804:59
*** amotoki is now known as amotoki_away05:00
*** jerrygb_ has joined #openstack-ironic05:01
*** jerrygb has quit IRC05:03
*** yuanying has joined #openstack-ironic05:11
*** makowals has joined #openstack-ironic05:13
*** pcaruana has joined #openstack-ironic05:14
*** Lambert has quit IRC05:22
*** Lambert has joined #openstack-ironic05:23
*** SerenaFeng has joined #openstack-ironic05:29
openstackgerritNisha Agarwal proposed openstack/sushy master: Add local_gb discovery to sushy  https://review.openstack.org/45511405:30
*** pcaruana has quit IRC05:30
*** e0ne has joined #openstack-ironic05:44
*** e0ne has quit IRC05:49
*** SerenaFeng has quit IRC05:53
*** mjura has joined #openstack-ironic05:54
*** SerenaFeng has joined #openstack-ironic05:56
*** vmud213 has joined #openstack-ironic06:05
*** mjura has quit IRC06:06
*** yolanda has joined #openstack-ironic06:06
*** Nisha_Agarwal has quit IRC06:07
*** mjura has joined #openstack-ironic06:18
*** Nisha_Agarwal has joined #openstack-ironic06:18
*** udesale has joined #openstack-ironic06:31
*** udesale has quit IRC06:31
*** amotoki_away is now known as amotoki06:31
*** jaganathan has joined #openstack-ironic06:32
*** udesale has joined #openstack-ironic06:32
*** tesseract has joined #openstack-ironic06:40
*** amotoki is now known as amotoki_away06:49
*** links has quit IRC06:49
*** pcaruana has joined #openstack-ironic06:49
*** rcernin_ has joined #openstack-ironic06:53
*** e0ne has joined #openstack-ironic07:04
*** links has joined #openstack-ironic07:05
*** amotoki_away is now known as amotoki07:06
*** Nisha_Agarwal has quit IRC07:08
*** Nisha_Agarwal has joined #openstack-ironic07:11
*** e0ne has quit IRC07:16
*** fxpester has joined #openstack-ironic07:17
*** ijw has joined #openstack-ironic07:21
*** amotoki is now known as amotoki_away07:22
*** ijw has quit IRC07:25
*** amotoki_away is now known as amotoki07:29
*** dtantsur|afk is now known as dtantsur07:30
dtantsurmorning ironic07:30
*** Lambert has quit IRC07:31
*** paramite has joined #openstack-ironic07:32
*** pcaruana|afk| has joined #openstack-ironic07:35
*** pcaruana|afk| has quit IRC07:35
*** pcaruana has quit IRC07:36
*** amotoki is now known as amotoki_away07:39
*** pcaruana has joined #openstack-ironic07:40
*** Lambert has joined #openstack-ironic07:43
*** ralonsoh has joined #openstack-ironic07:50
*** amotoki_away is now known as amotoki07:53
openstackgerritparesh sao proposed openstack/proliantutils master: [WIP]Adds 'set_one_time_boot' in ILO redfish  https://review.openstack.org/47529507:54
openstackgerritparesh sao proposed openstack/proliantutils master: [WIP]Adds 'update_persistent_boot' in ILO redfish  https://review.openstack.org/47529307:54
*** links has quit IRC07:55
*** fxpester has quit IRC07:55
*** SpamapS has quit IRC07:56
*** zzzeek has quit IRC08:00
*** zzzeek has joined #openstack-ironic08:00
*** fxpester has joined #openstack-ironic08:00
*** cvstealt1 has joined #openstack-ironic08:03
*** cvstealth has quit IRC08:05
*** oomichi has quit IRC08:05
*** oomichi has joined #openstack-ironic08:07
*** links has joined #openstack-ironic08:08
*** udesale has quit IRC08:08
*** Administrator_ has joined #openstack-ironic08:17
*** zhugaoxiao has quit IRC08:20
*** mgoddard has joined #openstack-ironic08:20
*** Nisha_Agarwal has quit IRC08:24
*** milan has joined #openstack-ironic08:25
milanmorning Ironic! :)08:26
*** priteau has joined #openstack-ironic08:27
*** Nisha_Agarwal has joined #openstack-ironic08:28
*** David_Orange has joined #openstack-ironic08:29
*** derekh has joined #openstack-ironic08:32
*** lucas-afk is now known as lucasagomes08:34
dtantsurhey milan08:37
*** racedo has joined #openstack-ironic08:38
openstackgerritMark Goddard proposed openstack/ironic master: Unit test consistency: DB base and utils prefix  https://review.openstack.org/47491808:40
*** udesale has joined #openstack-ironic08:41
openstackgerritNisha Agarwal proposed openstack/ironic master: py3.5:Workaround fix for forcing virtualbmc installation with pip2  https://review.openstack.org/47391308:43
Lamberthello Ironic08:44
Lambertanybody had built coreos-ipa recently?08:45
*** openstackgerrit has quit IRC08:48
*** openstackgerrit has joined #openstack-ironic08:50
openstackgerritDao Cong Tien proposed openstack/ironic master: Tempest scenario test for boot-from-volume  https://review.openstack.org/47274008:50
*** SpamapS has joined #openstack-ironic08:56
openstackgerritparesh sao proposed openstack/proliantutils master: Adding 'get_one_time_boot' method using redfish  https://review.openstack.org/47409308:57
openstackgerritparesh sao proposed openstack/proliantutils master: Adding 'get_one_time_boot' method using redfish  https://review.openstack.org/47409308:58
openstackgerritparesh sao proposed openstack/proliantutils master: Adding 'get_one_time_boot' method using redfish  https://review.openstack.org/47409309:00
*** Nisha_Agarwal has quit IRC09:11
*** udesale has quit IRC09:13
milanmorning dtantsur Lambert! :)09:14
*** udesale has joined #openstack-ironic09:16
*** mrchao has joined #openstack-ironic09:17
*** sambetts_ is now known as sambetts09:19
sambettsmorning all09:21
dtantsurmorning sambetts09:21
dtantsurLambert: I did not, but the CI seems to build it after each commit (unless it's broken)09:22
*** SerenaFeng has quit IRC09:22
openstackgerritparesh sao proposed openstack/proliantutils master: Adding 'get_one_time_boot' method using redfish  https://review.openstack.org/47409309:23
*** David_Orange has quit IRC09:26
*** SerenaFeng has joined #openstack-ironic09:32
*** openstackgerrit has quit IRC09:33
*** ijw has joined #openstack-ironic09:44
*** openstackgerrit has joined #openstack-ironic09:48
openstackgerritparesh sao proposed openstack/proliantutils master: Redfish: Adding the ability to get one time boot  https://review.openstack.org/47409309:48
*** ijw has quit IRC09:49
*** dtantsur is now known as dtantsur|bbl09:55
*** amarao has joined #openstack-ironic09:58
*** Lambert has quit IRC09:58
*** udesale has quit IRC10:02
*** jerrygb_ has quit IRC10:03
*** udesale has joined #openstack-ironic10:03
*** bfournie has quit IRC10:09
*** Nisha_Agarwal has joined #openstack-ironic10:09
*** bfournie has joined #openstack-ironic10:09
*** SerenaFeng has quit IRC10:13
*** Nisha_Agarwal has quit IRC10:16
*** dims has quit IRC10:16
*** SerenaFeng has joined #openstack-ironic10:17
*** SerenaFeng has quit IRC10:18
*** dims has joined #openstack-ironic10:21
*** SerenaFeng has joined #openstack-ironic10:22
*** SerenaFeng has quit IRC10:24
*** SerenaFeng has joined #openstack-ironic10:27
mkraiHi Ironic team. I am trying to enable serial console for a node created in my devstack setup10:39
mkraiI am following https://docs.openstack.org/developer/ironic/deploy/console.html10:39
mkraiCan anyone tell me what is the port in "ironic node-update <node-uuid> add driver_info/ipmi_terminal_port=<port>" command?10:39
*** aparnav has quit IRC10:42
*** aparnav has joined #openstack-ironic10:42
*** SerenaFeng has quit IRC10:43
*** dtantsur|bbl is now known as dtantsur10:45
*** jkilpatr has quit IRC10:47
openstackgerritMark Goddard proposed openstack/ironic master: Physical network aware VIF attachment  https://review.openstack.org/47040610:51
*** mvpnitesh has joined #openstack-ironic10:57
*** SerenaFeng has joined #openstack-ironic11:01
openstackgerritOpenStack Proposal Bot proposed openstack/ironic-ui master: Imported Translations from Zanata  https://review.openstack.org/47573911:04
*** SerenaFeng has quit IRC11:15
*** jkilpatr has joined #openstack-ironic11:24
*** lucasagomes is now known as lucas-hungry11:24
*** SerenaFeng has joined #openstack-ironic11:28
*** SerenaFeng has quit IRC11:30
*** ijw has joined #openstack-ironic11:37
*** e0ne has joined #openstack-ironic11:38
openstackgerritMerged openstack/proliantutils master: Support to perform erase on all the disks(volumes and drives)  https://review.openstack.org/43645011:40
*** ijw has quit IRC11:42
*** vmud213 has quit IRC11:42
*** e0ne has quit IRC11:46
sambettshey dtantsur11:46
*** phuongnh has joined #openstack-ironic11:49
sambettsmkrai: my understanding is that it is a unique port number of your choice, but it must not conflict with any service bound on the host where ironic is running11:50
*** dnikishov has joined #openstack-ironic11:52
*** fellypefca has joined #openstack-ironic11:52
*** mvpnitesh has quit IRC11:54
*** sasha2 has joined #openstack-ironic11:55
*** udesale has quit IRC11:55
*** udesale has joined #openstack-ironic11:55
*** mjura has quit IRC11:59
*** mjura has joined #openstack-ironic11:59
openstackgerritMerged openstack/ironic master: Updated from global requirements  https://review.openstack.org/47554312:00
openstackgerritparesh sao proposed openstack/ironic master: Added a condition for ILO for pxe hardware type  https://review.openstack.org/47534212:02
*** chlong has joined #openstack-ironic12:10
milandtantsur, https://review.openstack.org/#/c/439603/22/ironic_inspector/pxe_filter/base.py thx! :)12:15
patchbotpatch 439603 - ironic-inspector - PXE boot filtering drivers12:15
*** SerenaFeng has joined #openstack-ironic12:21
*** SerenaFeng has quit IRC12:21
*** jaypipes has joined #openstack-ironic12:30
*** lucas-hungry is now known as lucasagomes12:32
*** racedo has quit IRC12:33
*** tiendc has quit IRC12:34
*** racedo has joined #openstack-ironic12:35
*** phuongnh has quit IRC12:37
TheJuliaGood morninge veryone12:38
*** mjura has quit IRC12:38
dtantsurmorning TheJulia12:39
*** trown|outtypewww is now known as trown12:40
*** aparnav has quit IRC12:42
fellypefcaMorning, everyone :)12:43
fellypefcadtantsur, vdrok thanks for the reviews on onetime boot patch :) I'll discuss with my team right now.12:44
*** mjura has joined #openstack-ironic12:45
*** mvpnitesh has joined #openstack-ironic12:45
dtantsurthanks!12:50
milandtantsur, I'm afraid I don't follow the last comment :-/ https://review.openstack.org/#/c/439603/22/ironic_inspector/pxe_filter/base.py12:53
dtantsurmilan: tl;dr let's just catch exceptions on the top level..12:53
patchbotNo data found for patch 43960312:53
milandtantsur, like no special treatment for an already reset driver?12:54
milan* possibly already reset12:55
dtantsurmilan: I'm not overly worried about this case, as reset driver means that we're shutting down12:55
-openstackstatus- NOTICE: restarting gerrit to address slowdown issues12:56
milandtantsur, so let's just have the block except Exception that calls the driver.reset() all the time?12:57
dtantsurmilan: this is how I see it here, yes. We can catch InvalidState in reset() call itself btw, if you don't want it to bubble up12:58
milandtantsur, reset is always possible that wouldn't make too much sense12:59
dtantsureven better12:59
milanheh actually cool :D12:59
*** dprince has joined #openstack-ironic12:59
* dtantsur gets tracebacks from nova-api, and slowly turns into a sad panda13:00
* milan updates patches13:00
*** rloo has joined #openstack-ironic13:15
*** jerrygb has joined #openstack-ironic13:15
*** links has quit IRC13:18
*** yolanda has quit IRC13:19
openstackgerritAnkit Kumar proposed openstack/proliantutils master: Adds 'reset_bios_to_default' for redfish systems  https://review.openstack.org/47578513:19
*** jerrygb_ has joined #openstack-ironic13:20
*** rbudden has joined #openstack-ironic13:20
*** baoli has joined #openstack-ironic13:20
*** jerrygb has quit IRC13:20
*** mvpnitesh has quit IRC13:20
*** yolanda has joined #openstack-ironic13:24
*** jcoufal has joined #openstack-ironic13:26
*** jrist_ is now known as jrist13:31
*** jrist has quit IRC13:31
*** jrist has joined #openstack-ironic13:31
*** Goneri has joined #openstack-ironic13:33
*** mjturek has joined #openstack-ironic13:34
strigaziHi there, I'm from the magnum team. We have a cluster type in magnum which creates baremetal instances with ironic and heat. A contributor verified in his environment that it works fine from the master branch in a real deployment not on devstack. We need some help with our CI. Can someone have a look with me in http://logs.openstack.org/93/475393/1/check/gate-functional-dsvm-magnum-k8s-ironic-ub13:39
strigaziuntu-xenial-nv/82b8cd6/logs/ironic-bm-logs/node-1_console_2017-06-19-15:43:42.txt.gz13:39
strigazihttp://logs.openstack.org/93/475393/1/check/gate-functional-dsvm-magnum-k8s-ironic-ubuntu-xenial-nv/82b8cd6/logs/ironic-bm-logs/node-1_console_2017-06-19-15:43:42.txt.gz13:39
*** bigbigbang has quit IRC13:39
strigazisomething is wrong with the network configuration, I see  "listen tcp 10.1.0.10:2380: bind: cannot assign requested address"13:41
strigaziCan you have a quick look, if it is something obvious that i miss13:42
dtantsurport 2380? this is something new to me13:42
strigazidtantsur it is etcd13:42
strigaziwe have a security group for it13:43
strigaziwe have a security group rule for it13:43
sambettsstrigazi: where are you seeing this error? on the deployed baremetal node or on the host??13:44
strigazisambetts on the deployed "baremetal"13:44
sambettsstrigazi: what image are you deploying?13:45
strigazifedora 2513:45
strigazisambetts created yesterday with:13:45
strigazihttp://git.openstack.org/cgit/openstack/magnum/tree/magnum/drivers/k8s_fedora_ironic_v1/image/kubernetes13:46
sambettsis 10.1.0.10 the ip address that this server has been given by neutron??13:47
*** shuyingya has quit IRC13:47
*** shuyingya has joined #openstack-ironic13:48
mgoddardcloud-init suggests the host has no IP13:48
strigaziYes, it is in the network "private"13:48
mgoddardseems like dhcp is broken somewhere13:49
sambettsyeah... either host side, I'm wondering if you require the dhcp-all-interfaces element, or neutron side which you can check of your subnet has dhcp enabled13:49
mgoddardthere are 2 network interfaces, eth0 and eth1. eth0 is up with no IP, eth1 is down13:49
mgoddard++ for dhcp-all-interfaces13:50
mgoddardstrigazi: here's the script I use to build k8s images for magnum on baremetal: https://github.com/markgoddard/magnum-tools/blob/master/build-k8s-image.sh13:50
mgoddardI use dhcp-all-interfaces, grub2 and dracut-regenerate13:51
*** crushil has joined #openstack-ironic13:51
*** shuyingya has quit IRC13:52
strigazimgoddard Have you also tried with fedora-atomic?13:53
sambettsmgoddard: what does dracut regen do??13:53
mgoddardstrigazi: nope, just fedora13:54
mgoddardsambetts: it regenerates the dracut ramdisk supplied with the image. The fedora image seems to be particularly stingy in terms of the drivers supported in its ramdisk. I guess it's typically for a VM which shouldn't need many drivers13:55
strigazimgoddard Can you give it a go? if you have resources13:55
mgoddardsambetts: I think the RAID controller in our compute nodes was tripping it up and dracut was hanging on boot13:56
sambettsah right! thats a good thing to know about!13:56
mgoddardsambetts: right. I probably should have shared13:56
*** udesale has quit IRC13:56
mgoddardsambetts: perhaps there ought to be a page somewhere for assorted ironic knowledge nuggets? I suggested this on the ML but had no response13:57
sambettsmgoddard: yeah... its a difficult one because its hard to organise, and an unorgansied info dump isn't particularly useful unless you read it all13:58
mgoddardsambetts: as long as it's searchable13:58
sambetts+113:59
rloomgoddard, sambetts: we have the FAQ page, throw it there for now?13:59
sambettsyeah, or in trouble shooting  maybe add a "I built my image with DIB and my drivers are missing" section14:00
rloooh, it might not be a F(requently) A(sked) Q.14:00
rloosambetts: yeah, maybe troubleshooting might be better14:01
*** Administrator_ has quit IRC14:01
mgoddardrloo, sambetts: I'll take a look at those pages and see where it fits14:01
rloohttps://docs.openstack.org/developer/ironic/deploy/troubleshooting.html14:01
*** Administrator_ has joined #openstack-ironic14:02
mgoddardrloo: ta14:02
*** mrchao has quit IRC14:02
rloothank you mgoddard!14:02
*** cdearborn_ has joined #openstack-ironic14:02
rlooHi and good morning all, mgoddard, sambetts, dtantsur, strigazi :-)14:03
mgoddardmy original question was about best practices. I expect there is a lot of unwritten knowledge within the ironic team about iPXE > PXE, Swift > iSCSI etc. but unless IIRC these are presented as equal options in the docs14:03
rloomgoddard: oh. any idea how other companies/products document this stuff?14:04
rloomgoddard: i think under an 'admin' guide that we don't quite have yet, but we have admin pages...14:04
rloomgoddard: so a new 'best practises' page under https://docs.openstack.org/developer/ironic/#administrator-s-guide?14:05
mgoddardrloo: I guess it needs to move from 'here are all the things you can do' to 'here are the decisions you need to make to 1. get anything out of the system, 2. get the best out of the system'14:05
rloomgoddard: right. i just don't know where to put that info. wondering where other products put that.14:06
mgoddardrloo: that would be nice14:06
rloomgoddard: don't forget, you're talking to a developer :-)14:06
TheJuliamgoddard: I think part of it is we (the core team) have a better architectural understanding of mechanisms under the hood, and we've done poorly conveying the impact of some of those things, or we just expect others to pick up on it.14:06
rloogood morning TheJulia!14:07
TheJuliagood morning rloo14:07
mgoddardrloo: don't forget, I am a developer also :-) (at least I was, although these days I write more ansible and bash than anything...)14:07
mjturekmorning TheJulia rloo mgoddard sambetts :)14:07
TheJuliaI think some things we've also tried to put notes in why one, but your right about the presentation as equals when they really are not since they have trade offs14:08
rloomgoddard: 'I was' ... :-)14:08
rlooseems like the best/easiest thing is to have a wikipedia-like thing where folks can dump what they know but I know, we need to monitor-or-sanitize-or-vet-or-whatever the stuff.14:09
mgoddardTheJulia: that's always the way. There is about a 2 week window when a developer has the right balance of understanding and non-understanding that they can write docs effectively14:10
rloomgoddard: i don't think it isn't 'the way'. just that there are always other things todo that are (seem) higher priority.14:10
mgoddardmorning all, by the way :)14:10
rloomgoddard: and i would guess, submitting patches, etc, makes it not-that-fast or easy.14:11
rlooTheJulia, jlvillal and dtantsur. Your thoughts on my proposal to change the DB version column from String to Integer? L1144 @ https://review.openstack.org/#/c/408556/52/ironic/db/sqlalchemy/api.py?14:12
patchbotpatch 408556 - ironic - Add new dbsync command with first online data migr...14:12
mgoddardrloo: I meant more that as you pick up more knowledge it becomes harder to put yourself into the shoes of someone without that knowledge14:12
rloomgoddard: ++14:12
TheJuliarloo: for some reason in the back of my head, I thought string was decided upon for named releases14:13
rlooTheJulia: these are versioned objects, they are separate from release versions (which can be named or sem-versioned)14:14
mgoddardstrigazi: sorry I've ignored your question until now. I'll try out fedora-atomic with k8s on baremetal and let you know how it goes14:14
rlooTheJulia: and for versioned objects, the 'version' is a string of the form a.b.c.d (I couldn't find any doc restricting the number of dots)14:15
TheJuliawhich makes sense... :\14:15
rlooTheJulia: so in the previous patch, we added a 'version' column to all the object-related tables. and the value of that column is the version of the object that is saved in the db.14:16
strigazimgoddard thanks14:16
rlooTheJulia: which is that version string14:16
rlooTheJulia: which is what is causing me grief right now14:17
TheJuliarloo: pondering, I am looking for some way I handled something kind of like this14:17
TheJuliarloo: did you look at distutils.version?14:21
rlooTheJulia: nope, let me see...14:21
TheJuliagrabbing link14:21
TheJuliarloo: http://epydoc.sourceforge.net/stdlib/distutils.version-module.html14:21
rlooTheJulia: so the problem if I understand it, is that i wanted to generate an sql query/filter to grab the objects/records of interest.14:22
TheJuliaoh... hmm14:23
rlooTheJulia: i can't use any old function in that filter. it operates on the sql representation of the field.14:23
TheJuliaIt makes sense to make the database do the work I guess...14:23
rlooi think.14:23
rlooi tried to do something with the version string in sql, but if i didn't use an sql function, it didn't work.14:24
TheJuliaThen again, this is a rolling background thing, so I don't see why we couldn't select the id, version columns, and just hunt from there client side....14:24
rlooTheJulia: right, that's the alternative. i'd have to get every id/version column and do the check.14:24
rlooTheJulia: i have no idea how performant that is, vs sql-query-filtering14:24
TheJulianaturally less performant, but I wonder if it is an area that it is perfectly okay.14:25
* TheJulia looks at the code again and ponders14:25
TheJuliarloo: what if the query generates a list that does not match the expected target value?14:28
rlooTheJulia: I'm not sure what you mean14:29
rlooTheJulia: the query/filter should return what you asked for?14:29
TheJuliaI'm wondering if change query = model_query(model).filter(14:33
TheJulia                    sql.cast(model.version, Numeric(9, 2)) != supported_version) ?  Although I'm not sure what Numeric(9, 2) is doing in there.14:33
*** JasonF is now known as JayF14:33
TheJuliaIt is just returning a True/False...14:33
*** udesale has joined #openstack-ironic14:34
rlooTheJulia: the Numeric() is converting it from a string to a number.14:35
rlooTheJulia: but if the version becomes "1.2.3" that won't work. which is fine, we could say versions are only A.B.14:35
TheJulia"hi, db, can you do string compare against your index?"14:35
rlooTheJulia: let me think about the == thing (in that case, just compare the strings). i think there may be some corner cases where that is a problem but not totally sure.14:36
TheJulialess efficient than integers though.  I guess we would end up having to use a longint as well, so I have this feeling memory wise it is a wash14:37
rlooTheJulia: db can definitely do string compares. we are using that already.14:37
TheJulia== to supported version would result in more data getting shipped over the wire, fwiw14:38
TheJulia!= supported_version should just return the result set that we know is not current14:38
openstackTheJulia: Error: "=" is not a valid command.14:38
* TheJulia gives the bot candy14:38
dtantsurlol14:39
*** jdwidari has quit IRC14:39
rlooTheJulia: you know, i think that would work. Thanks!!!14:39
*** cdearborn_ has quit IRC14:39
TheJulia:)14:40
*** udesale has quit IRC14:46
*** rcernin_ has quit IRC14:47
*** milan has quit IRC14:48
* dtantsur raises his head from debugging nova14:57
TheJuliaIs this where we need a coffee bot?14:58
dtantsurI need a beer bot now14:58
rlooTheJulia: sigh, that doesn't really work. It will result in worst case, returning all the objects, because i just remembered (cuz I forgot what this code is doing), it is checking for objects that are older than base release, not latest release. so if you are doing eg 'db online-data-migration', that'll update those objects to the latest version which will most likely be > base (supported) version. we are only looking for objects < base versi14:58
rlooon :-(14:58
TheJulia:(14:59
rlooTheJulia: I suppose i could generate (ugh) the list of supported versions and do that in sql, eg obj.version != v1 and !=v2 and !=v3...15:00
rlooTheJulia: I think I'll do that ^^15:00
rlooTheJulia: thx for the chat :-)15:00
rloohowdy dtantsur, welcome back to wonderful ironic-land :-)15:01
*** mjura has quit IRC15:02
*** jaganathan has quit IRC15:02
dtantsur:D15:03
anupnGood morning Ironic'ers :)15:06
*** rama_y has joined #openstack-ironic15:10
*** causten has joined #openstack-ironic15:13
*** rpioso has joined #openstack-ironic15:15
*** fellypefca has quit IRC15:18
*** jerrygb_ has quit IRC15:20
*** jerrygb has joined #openstack-ironic15:21
openstackgerritMerged openstack/ironic master: Unit test consistency: DB base and utils prefix  https://review.openstack.org/47491815:24
*** jerrygb_ has joined #openstack-ironic15:27
*** jerrygb has quit IRC15:29
NobodyCamGood Morning Ironic'ers15:30
dtantsurmorning NobodyCam15:30
NobodyCam:)15:30
*** jerrygb has joined #openstack-ironic15:31
NobodyCamhey hey dtantsur I'll try and make time later on today to update that inspector patch :)15:31
dtantsurcool15:31
*** jerrygb_ has quit IRC15:32
*** jerrygb_ has joined #openstack-ironic15:36
*** jerrygb has quit IRC15:37
*** crushil has quit IRC15:42
*** jerrygb_ has quit IRC15:42
*** jerrygb has joined #openstack-ironic15:43
*** jcoufal has quit IRC15:45
*** amarao has quit IRC15:56
*** Nisha_Agarwal has joined #openstack-ironic15:57
*** ElCoyote_ has quit IRC15:58
*** jcoufal has joined #openstack-ironic15:59
*** paramite has quit IRC15:59
*** makowals has quit IRC16:05
dtantsurbeer'o'clock, have a nice evening16:07
*** dtantsur is now known as dtantsur|afk16:08
openstackgerritVladyslav Drok proposed openstack/ironic master: Allow to load a subset of object fields from DB  https://review.openstack.org/47585616:12
*** shvepsy has quit IRC16:17
ricardoasmorning, ironic!16:18
*** pcaruana has quit IRC16:19
*** ElCoyote_ has joined #openstack-ironic16:20
*** fellypefca has joined #openstack-ironic16:22
NobodyCammorning ricardoas16:23
*** rama_y has quit IRC16:25
ricardoasmorning, NobodyCam!16:31
jlvillalrloo, On the dbsync and version numbers. Maybe it could have an integer major version and an integer minor version field?16:35
rloojlvillal: that is another was to do it but i don't like using two fields to represent that value.16:35
jlvillalrloo, I think that is how we treat the API versions. We split the string and then convert to int. I think, but I would need to check to be sure.16:36
rloojlvillal: i'm going to try doing a sql filter: version!=supported_version1 and version != supported_version2...16:36
rloojlvillal: yes, that is how we treat it, but we don't save the API version in the DB16:36
jlvillalrloo, This is what I was thinking of: https://github.com/openstack/ironic/blob/master/ironic/api/controllers/base.py#L5516:38
rloojlvillal: right, but what exactly, what part of that would be useful?16:38
jlvillalrloo, No idea on the SQL query. I don't know much about SQL :(16:38
rloojlvillal: there aren't any? many? sql functions to manipulate strings16:39
jlvillalrloo, My initial thought was to do a query and get all the versions, and then iterate through them in Python checking the values.16:39
rloojlvillal: yes, i noted that. my question was whether it was performant.16:39
jlvillalrloo, No idea how many thousands, millions of objects there are???16:39
rloojlvillal: it seems like we should leverage sql to do the filtering for us.16:39
rloojlvillal: i'm guessing the number of nodes is the thing, or maybe after node-tags, someone goes crazy with those. so 10s of thousands?16:40
jlvillalrloo, That seems fairly small for Python. In my rough guess.16:41
rloojlvillal: it is python and DB access to get all those records16:42
rloojlvillal: and I don't know much about dbs16:42
jlvillalrloo, Me either :(16:42
jlvillalSo much to learn, so little time!16:42
rloojlvillal: which is why i'm trying to do the filtering in sql :-)16:42
openstackgerritVladyslav Drok proposed openstack/ironic master: Add nodes tagging support - RPC objects  https://review.openstack.org/23335716:42
openstackgerritVladyslav Drok proposed openstack/ironic master: Allow to load a subset of object fields from DB  https://review.openstack.org/47585616:42
ricardoasvdrok: not sure i understood your concern wrt https://review.openstack.org/#/c/436469 got a second to talk about it?16:45
patchbotpatch 436469 - ironic - Adds onetime boot in oneview drivers16:45
* sambetts -> home16:45
*** sambetts is now known as sambetts|afk16:45
sambetts|afknight all16:45
vdrokricardoas: in 5 mins, if it can wait :)16:46
ricardoascool!16:46
TheJuliaIt is generally best to put _as much work_ as possible into the DB, because depending on the query your shipping all of the data across the wire to the app to do logic, and that is not the best idea for performance16:46
TheJuliaespecially if there is say 10ms of network latency in between the conductor and the database server.16:47
openstackgerritVladyslav Drok proposed openstack/ironic master: Add nodes tagging support - RPC objects  https://review.openstack.org/23335716:48
TheJuliaIf we were just returning two indexed columns, that could be relatively performant for us to build lists to then act upon, but that is not something we would just want to return a true or false on. We would want to wrap all of our logic into that so we are efficiently using our database cursor.16:49
* TheJulia knows too much about databases16:50
*** Nisha_ has joined #openstack-ironic16:50
*** Nisha_Agarwal has quit IRC16:50
* rloo glad that someone knows about databases :-)16:50
vdrokricardoas: hey, here16:51
vdrokricardoas: so my concern is, you do set the attribute driver_internal_info['pxe_onetime_boot'] to true, if not overriden by driver_info['no_pxe_onetime_boot'] on the deploy prepare stage16:52
vdrokthen deployment finishes, you switch to disk16:52
vdrokand the driver_internal_info['pxe_onetime_boot'] is still there, so when set_boot_device(DISK, persistent=True) is called, it gets overriden to False here https://review.openstack.org/#/c/436469/17/ironic/drivers/modules/oneview/management.py@134, if i read the code correctly16:53
patchbotpatch 436469 - ironic - Adds onetime boot in oneview drivers16:53
*** crushil has joined #openstack-ironic16:54
*** marlinc has quit IRC16:54
ricardoasvdrok: but in management interface we set it to false right after using the value...16:54
*** zzzeek has quit IRC16:55
vdrokricardoas: ugh, it seems I'm blind :(16:55
vdrokok, lemme look once again16:55
ricardoasvdrok: the path is: admin creates a node, at prepare stage we set driver_internal_info flag, use at managent interface and unset it there...16:55
openstackgerritPeter Piela proposed openstack/ironic-ui master: This commit is a first step in the development of a unit test framework for the Ironic-UI API service. The approach being used is to provide an emulation of the Ironic backend using a mock that utilizes Angular $httpbackend handlers to intercept requests   https://review.openstack.org/46945916:56
*** derekh has quit IRC16:56
ricardoasvdrok: lol, take a look when you can... :)16:57
*** makowals has joined #openstack-ironic16:57
*** ralonsoh has quit IRC16:58
*** thaj has quit IRC16:59
*** racedo has quit IRC16:59
*** tesseract has quit IRC17:00
*** Nisha_ has quit IRC17:02
*** lucasagomes is now known as lucas-afk17:03
TheJuliappiela: uhhh... runtogyther commit message ^^^ ???17:03
jlvillalI think ppiela has a very very long subject line for his patch17:04
TheJuliaI suspect that is the case17:04
ppielaTheJulia: yeah, title seems to have concatenated with description17:05
* TheJulia hears a homer simpson "Doh!"17:06
*** makowals has quit IRC17:06
openstackgerritPeter Piela proposed openstack/ironic-ui master: Unit test framework for Ironic-UI API service  https://review.openstack.org/46945917:09
ppielaTheJulia: looks better17:09
*** mgoddard has quit IRC17:09
TheJulia\o/17:11
openstackgerritJohn L. Villalovos proposed openstack/ironic master: Put tests in correct location for ironic/api/controllers/v1/  https://review.openstack.org/46265817:12
*** jkilpatr has quit IRC17:14
fellypefcavdrok thanks for your +2 on Onetime boot patch :) About your last comment, on the method name, I think the "set" is for when you know the value that you will pass, and "change" when that value is unknown. Do you agree with that?17:15
vdrokfellypefca: it's a nit :) when I see set some flag, I think about setting it to true :)17:16
*** yolanda_ has joined #openstack-ironic17:16
*** jkilpatr has joined #openstack-ironic17:17
*** makowals has joined #openstack-ironic17:19
fellypefcavdrok oh, it makes more sense now. Thanks :)17:20
*** yolanda_ has quit IRC17:21
vdrokfellypefca: thank YOU17:21
*** amotoki is now known as amotoki_away17:23
openstackgerritJarrod Johnson proposed openstack/pyghmi master: Implement support for ThinkSystem servers  https://review.openstack.org/47588017:24
*** marlinc has joined #openstack-ironic17:26
*** rama_y has joined #openstack-ironic17:26
openstackgerritVladyslav Drok proposed openstack/ironic master: Move _abort_attach_volumes functionality to detach_volumes  https://review.openstack.org/46776617:27
openstackgerritJarrod Johnson proposed openstack/pyghmi master: Implement support for ThinkSystem servers  https://review.openstack.org/47588017:30
*** e0ne has joined #openstack-ironic17:35
*** jaganathan has joined #openstack-ironic17:35
*** priteau has quit IRC17:42
*** priteau has joined #openstack-ironic17:42
*** racedo has joined #openstack-ironic17:43
*** priteau has quit IRC17:47
*** zzzeek has joined #openstack-ironic17:47
*** mjturek has quit IRC17:49
*** priteau has joined #openstack-ironic17:49
*** e0ne has quit IRC17:51
*** priteau has quit IRC17:53
*** priteau has joined #openstack-ironic17:54
*** priteau has quit IRC17:54
*** priteau has joined #openstack-ironic17:54
*** zzzeek has quit IRC17:57
*** trown is now known as trown|lunch17:58
*** priteau has quit IRC17:59
*** athomas has quit IRC17:59
*** priteau has joined #openstack-ironic18:02
*** zzzeek has joined #openstack-ironic18:03
openstackgerritVladyslav Drok proposed openstack/ironic master: Add nodes tagging support - RPC objects  https://review.openstack.org/23335718:07
vdrokgood night everyone!18:08
TheJuliagoodnight vdrok18:09
*** mjturek has joined #openstack-ironic18:10
vdrokrloo: oh and by the way vsaienk0 should be able to attend the network meetings, supposedly at any time in our TZ working hours18:11
rloovdrok: ok thx!18:11
rloodtantsur|afk, sambetts|afk, wrt meeting for networking: ^^18:11
*** causten has quit IRC18:13
*** causten has joined #openstack-ironic18:13
TheJuliaanupn: rama_y: Are you two around for the ironic-ui meeting?18:16
rama_yHi TheJulia, yes18:16
TheJulia#openstack-meeting-3 :)18:17
rama_yok, thanks.18:17
*** causten has quit IRC18:17
anupnTheJulia, hi yes18:17
anupnTheJulia: It completely slipped off my head18:18
TheJuliano worries!18:21
*** goldyfruit has joined #openstack-ironic18:21
goldyfruitdevananda: o/18:21
devanandaohai!18:21
devanandadavidlenwell: meet goldyfruit :)18:21
goldyfruitHey davidlenwell !!18:22
davidlenwellhey goldyfruit18:22
openstackgerritMerged openstack/ironic-ui master: Unit test framework for Ironic-UI API service  https://review.openstack.org/46945918:22
davidlenwellnice to meet you!18:22
goldyfruitSame here !18:22
devanandahe's developed a little ansible role that prepares iLOs for use with Bifrost18:22
davidlenwellthat is very much the kind of thing I am looking for :)18:22
goldyfruitHope you will like it ^^18:23
*** priteau has quit IRC18:23
davidlenwelleither way .. maybe we can collaborate on making it a tool that can be more broadly used.18:23
goldyfruityep, would be great18:23
*** priteau has joined #openstack-ironic18:23
davidlenwellcool.. ping me when you get it in a repo I can pull / contribute to18:24
goldyfruitdavidlenwell: will do !18:24
*** priteau has quit IRC18:28
*** ricardoas has quit IRC18:31
*** racedo has quit IRC18:32
*** jcoufal has quit IRC18:35
openstackgerritFellype Cavalcante proposed openstack/ironic master: Adds onetime boot in oneview drivers  https://review.openstack.org/43646918:38
*** makowals has quit IRC18:44
fellypefcavdrok, TheJulia I think I've finished all reviews you make on Onetime Boot patch :) If you could take a look, I would be very grateful haha :D18:47
TheJuliafellypefca: I'll look after the UI meeting18:48
fellypefcaOk :) thank you again.18:48
*** e0ne has joined #openstack-ironic18:51
*** jkilpatr_ has joined #openstack-ironic18:52
openstackgerritMerged openstack/pyghmi master: Implement support for ThinkSystem servers  https://review.openstack.org/47588018:52
*** jkilpatr has quit IRC18:53
*** trown|lunch is now known as trown18:56
*** jaganathan has quit IRC18:56
*** causten has joined #openstack-ironic19:06
*** e0ne has quit IRC19:08
*** e0ne has joined #openstack-ironic19:14
*** e0ne has quit IRC19:19
*** makowals has joined #openstack-ironic19:20
*** priteau has joined #openstack-ironic19:25
*** priteau has quit IRC19:25
*** priteau has joined #openstack-ironic19:26
openstackgerritJohn L. Villalovos proposed openstack/ironic master: Fix missing 's' specifier in log message  https://review.openstack.org/47590519:26
jlvillalTheJulia: ^^^19:26
jlvillalIt is a very simple review :)19:26
TheJuliadoh19:27
*** e0ne has joined #openstack-ironic19:29
openstackgerritMichael Turek proposed openstack/ironic master: iPXE template support for iSCSI  https://review.openstack.org/41332419:30
*** hoonetorg has quit IRC19:34
jlvillalmjturek: Do any of the unit tests test for the case when it is a list?19:35
jlvillalmjturek: For the updated tests19:35
*** mjturek has quit IRC19:36
*** e0ne_ has joined #openstack-ironic19:37
*** e0ne has quit IRC19:39
*** e0ne has joined #openstack-ironic19:40
*** e0ne_ has quit IRC19:44
*** mgkwill_ is now known as mgkwill19:46
*** hoonetorg has joined #openstack-ironic19:50
*** fellypefca has quit IRC19:52
*** zzzeek has quit IRC19:53
*** e0ne has quit IRC19:57
*** ricardoas has joined #openstack-ironic20:02
*** jkilpatr_ has quit IRC20:10
*** hoonetorg has quit IRC20:15
*** causten has quit IRC20:17
*** causten has joined #openstack-ironic20:18
*** jerrygb has quit IRC20:19
*** e0ne has joined #openstack-ironic20:19
*** causten has quit IRC20:22
*** amotoki_away is now known as amotoki20:24
*** mjturek has joined #openstack-ironic20:27
*** paramite has joined #openstack-ironic20:31
*** amotoki is now known as amotoki_away20:33
*** hoonetorg has joined #openstack-ironic20:36
*** Goneri has quit IRC20:40
*** Nisha_Agarwal has joined #openstack-ironic20:41
*** zzzeek has joined #openstack-ironic20:42
*** goldyfruit has quit IRC20:43
*** ijw has joined #openstack-ironic20:45
*** Nisha_Agarwal has quit IRC20:46
*** causten has joined #openstack-ironic20:46
*** causten has quit IRC20:48
*** causten has joined #openstack-ironic20:49
*** makowals has quit IRC20:52
*** causten has quit IRC20:53
*** e0ne has quit IRC20:55
*** Nisha_Agarwal has joined #openstack-ironic20:59
openstackgerritPeter Piela proposed openstack/ironic-ui master: Extend backend mock with port operations  https://review.openstack.org/47353921:04
*** trown is now known as trown|outtypewww21:09
*** paramite has quit IRC21:10
*** makowals has joined #openstack-ironic21:13
*** dprince has quit IRC21:14
*** jkilpatr_ has joined #openstack-ironic21:16
*** causten has joined #openstack-ironic21:17
*** causten has quit IRC21:18
*** causten has joined #openstack-ironic21:18
*** mjturek has quit IRC21:20
*** crushil has quit IRC21:22
*** crushil has joined #openstack-ironic21:22
*** causten has quit IRC21:23
*** crushil has quit IRC21:27
*** mvpnitesh has joined #openstack-ironic21:29
*** jkilpatr_ has quit IRC21:31
*** jkilpatr has joined #openstack-ironic21:31
openstackgerritRuby Loo proposed openstack/ironic master: Add new dbsync command with first online data migration  https://review.openstack.org/40855621:36
*** mvpnitesh has quit IRC21:37
*** baoli has quit IRC21:40
openstackgerritRuby Loo proposed openstack/ironic master: Add new dbsync command with first online data migration  https://review.openstack.org/40855621:45
*** priteau has quit IRC22:00
*** causten has joined #openstack-ironic22:06
*** causten has quit IRC22:07
*** causten has joined #openstack-ironic22:07
*** yee37923 has joined #openstack-ironic22:10
*** yee37923 has quit IRC22:10
*** openstack has joined #openstack-ironic22:17
*** sasha2 has quit IRC22:17
*** dansmith_ is now known as dansmith22:17
*** oomichi has quit IRC22:17
*** dansmith is now known as Guest9625922:17
*** jrist has quit IRC22:18
*** oomichi has joined #openstack-ironic22:19
*** chihhsin has joined #openstack-ironic22:19
*** yee379 has quit IRC22:20
*** yee379 has joined #openstack-ironic22:20
*** goldyfruit has joined #openstack-ironic22:23
*** ptx0 has joined #openstack-ironic22:25
*** goldyfruit has quit IRC22:27
openstackgerritJohn L. Villalovos proposed openstack/ironic-lib master: Add local 'hacking' check to require 'autospec' in mock.patch  https://review.openstack.org/44731022:39
*** Nisha_ has joined #openstack-ironic22:43
*** Nisha_Agarwal has quit IRC22:43
*** Nisha_brb has joined #openstack-ironic22:46
*** Nisha_ has quit IRC22:46
*** Nisha_ has joined #openstack-ironic22:47
*** Nisha_brb has quit IRC22:47
*** Nisha_brb has joined #openstack-ironic22:51
*** Nisha_ has quit IRC22:51
*** goldyfruit has joined #openstack-ironic22:55
*** Guest96259 is now known as dansmith22:56
*** Nisha_ has joined #openstack-ironic22:58
*** Nisha_brb has quit IRC22:58
*** goldyfruit has quit IRC22:58
*** Nisha_brb has joined #openstack-ironic22:58
*** Nisha_ has quit IRC22:58
*** Nisha_ has joined #openstack-ironic23:09
*** Nisha_brb has quit IRC23:09
*** Nisha_brb has joined #openstack-ironic23:13
*** Nisha_ has quit IRC23:13
*** Nisha_ has joined #openstack-ironic23:14
*** Nisha_brb has quit IRC23:14
*** Nisha_Agarwal has joined #openstack-ironic23:17
*** Nisha_ has quit IRC23:17
*** makowals has joined #openstack-ironic23:17
*** harlowja has quit IRC23:19
*** rpioso has quit IRC23:31
*** ijw has quit IRC23:33
*** Nisha_Agarwal has quit IRC23:37
*** jrist has joined #openstack-ironic23:37
*** Nisha_Agarwal has joined #openstack-ironic23:39

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!