Monday, 2017-05-15

*** openstack has joined #openstack-ironic06:59
openstackgerritDebayan Ray proposed openstack/sushy master: [WIP] Add foundation for redfish OEM extensions  https://review.openstack.org/46382907:06
*** shuyingya has joined #openstack-ironic07:08
*** hw_wutianwei has joined #openstack-ironic07:22
*** ralonsoh has joined #openstack-ironic07:32
*** rbartal has quit IRC07:32
*** rbartal has joined #openstack-ironic07:44
*** rcernin has joined #openstack-ironic07:47
*** pcaruana has joined #openstack-ironic07:47
WeiAhi, how to delete node with provisioning state error?07:48
WeiAI want to delete it by using node-delete, however it notifies me can not delete node while it is in error07:51
WeiAhowever it can not be modified to other states using node-set-provision-state07:52
*** yuanying_ has quit IRC07:53
*** yuanying has joined #openstack-ironic07:53
*** e0ne has joined #openstack-ironic07:56
*** zzzeek has quit IRC08:00
*** zzzeek has joined #openstack-ironic08:00
fdegirWeiA: have you tried setting it to deleted?08:01
fdegirWeiA: and then node-delete08:01
WeiAyes08:01
WeiAfdegir, I have tried this before and it doesn't work08:02
*** jaosorior has joined #openstack-ironic08:09
vdrokgood morning ironic!08:10
mvpnitesh<fdegir>: one of deleting it is cleaning the node and deleting the node, if not try to set that node to maintainance mode and then do node delete08:10
vdrokWeiA: what does it say when you do node-delete exactly?08:10
WeiA<vdrok>Failed to delete node test: Can not delete node "176ba5f6-5e29-4944-a0dd-0921f56696b3" while it is in provision state "error". Valid provision states to perform deletion are: "('available', 'manageable', 'enroll', 'adopt failed')" (HTTP 409)08:13
vdrokWeiA: ah, right, error is not the state you can do node-delete. setting maintenance should help as mvpnitesh suggested08:13
vdrokthough I think it should be added to that list08:13
*** skazi has quit IRC08:14
WeiAyou mean it should be set maintenance status, and then delete it ?08:14
*** skazi has joined #openstack-ironic08:15
*** root has joined #openstack-ironic08:19
*** lucas-afk is now known as lucasagomes08:19
lucasagomesmorning all08:19
vdrokWeiA: correct08:19
vdrokmorning lucasagomes !08:20
*** root is now known as Guest5206608:20
*** e0ne has quit IRC08:21
*** root4 has quit IRC08:22
WeiAvdrok: yeah, it works08:23
WeiAvdrok: thanks08:23
vdroknp :)08:23
pas-hamorning Ironic :)08:24
*** vmud213 has joined #openstack-ironic08:25
*** e0ne has joined #openstack-ironic08:26
*** ccamacho has quit IRC08:33
*** racedo has joined #openstack-ironic08:53
*** pmannidi has quit IRC08:57
*** dtantsur|afk is now known as dtantsur09:05
dtantsurmorning ironic09:05
openstackgerritPavlo Shchelokovskyy proposed openstack/ironic master: [install-guide] add section on Glance+Swift config  https://review.openstack.org/37942209:06
vdrokmorning dtantsur !09:09
vmud213morning dtantsur,vdrok and ironic09:15
vdrokmorning vmud21309:16
vmud213dtantsur: I have seen your reply on https://review.openstack.org/#/c/446510/09:16
patchbotpatch 446510 - sushy - Add System Processor/Memory info09:16
vmud213 Isee your point there.09:17
vmud213We have been using it that way and at many places i see .But IMO,09:18
vmud2131. It gives wrong notion that we are trying to refer the class attribute using instance which is fine as long as we just read it (on RHS)09:19
openstackgerritMerged openstack/proliantutils master: Support to return logs for hpsum firmware update  https://review.openstack.org/44587609:19
dtantsurvmud213, I'm going to refactor it eventually anyway, I'd prefer we don't try to overcomplicate the life for ourselves09:20
*** deray has joined #openstack-ironic09:20
deraygood morning Ironic'ers!09:20
vmud213dtantsur: I am OK..Just trying to learn as i may be lacking the real knowledge on it. Is there any other reason for the pattern apart from what i mentioned there. I am just curious to know.09:21
vdrokmorning deray09:21
derayvdrok, o/09:22
vmud213Hey deray o/09:22
dtantsurvmud213, mostly for documenting purposed. it's easy and clean to attach docstring to class attributes. otherwise you have to make the documentation part of the class docstring, using special syntax (which I e.g. never remember)09:22
dtantsuranyway, I want us to move to descriptors instead (see e.g. sqlalchemy or django models)09:23
derayvmud213, o/09:24
vmud213dtantsur: Thanks. Got it.09:25
*** e0ne has quit IRC09:26
*** Serlex has joined #openstack-ironic09:26
*** e0ne has joined #openstack-ironic09:26
*** e0ne has quit IRC09:26
*** e0ne has joined #openstack-ironic09:27
*** e0ne has quit IRC09:27
*** e0ne has joined #openstack-ironic09:27
*** e0ne has quit IRC09:28
*** e0ne has joined #openstack-ironic09:28
*** e0ne has quit IRC09:29
*** e0ne has joined #openstack-ironic09:29
*** e0ne has quit IRC09:30
*** jistr_ is now known as jistr09:30
*** aarefiev_afk is now known as aarefiev09:42
aarefievmorning all!09:42
vdrokmorning aarefiev09:45
aarefievmorning vdrok :)09:46
dtantsurvmud213, if you haven't seen descriptors before: https://docs.python.org/2/howto/descriptor.html09:46
*** SerenaFeng has quit IRC09:46
*** marios_ is now known as marios09:50
*** mvpnitesh has quit IRC09:53
*** mvpnitesh has joined #openstack-ironic09:54
*** mvpnitesh has quit IRC10:02
WeiAin ironic how to configure RAID?10:03
*** mvpnitesh has joined #openstack-ironic10:09
dtantsurWeiA, please check https://docs.openstack.org/developer/ironic/deploy/raid.html10:16
WeiAOK, thanks10:17
*** sambetts|afk is now known as sambetts10:24
sambettsMorning all10:24
sambettsI'm finally back in the europe timezone :D10:25
*** athomas has joined #openstack-ironic10:25
lucasagomessambetts, aarefiev dtantsur vmud213 o/ morning10:27
sambettshey lucasagomes10:27
aarefievmorning lucasagomes, sambetts10:28
dtantsuro/10:28
*** karthiks has joined #openstack-ironic10:29
*** amarao has joined #openstack-ironic10:34
sambettshey dtantsur, aarefiev10:37
*** amarao has quit IRC10:38
*** amarao has joined #openstack-ironic10:41
vdrokmorning sambetts !10:43
openstackgerritAnton Arefiev proposed openstack/python-ironic-inspector-client master: Functional tests: pin *inspector* to HEAD  https://review.openstack.org/46460810:46
aarefievdtantsur: hey, ^ needs your attention10:51
dtantsurwill check, thanks10:53
*** jkilpatr has joined #openstack-ironic10:57
*** gcb has quit IRC11:02
*** mat128 has joined #openstack-ironic11:02
vmud213dtantsur: Thanks. I have some knowledge on that earlier.11:05
vmud213morning lucasagomes :)11:05
*** baoli has joined #openstack-ironic11:12
*** deray has quit IRC11:15
*** mvpnitesh has quit IRC11:18
*** mvpnitesh has joined #openstack-ironic11:19
*** lucasagomes is now known as lucas-hungry11:31
*** shuyingya has quit IRC11:32
*** shuyingy_ has joined #openstack-ironic11:32
*** baoli has quit IRC11:34
*** gema_ is now known as gema11:36
*** gema has quit IRC11:37
*** gema has joined #openstack-ironic11:37
openstackgerritDmitry Tantsur proposed openstack/sushy master: [WIP] Declarative approach to parsing JSON fields  https://review.openstack.org/46461711:39
dtantsurlucas-hungry, vmud213, that's what I meant ^^^11:39
dtantsur(not finished yet)11:39
*** bfournie1 has quit IRC11:43
*** dprince has joined #openstack-ironic11:52
*** mvpnitesh has quit IRC11:52
*** dprince has quit IRC11:56
*** mvpnitesh has joined #openstack-ironic11:56
*** WeiA has quit IRC12:00
openstackgerritAparna proposed openstack/ironic master: Agent driver rescue implementation  https://review.openstack.org/40043712:06
openstackgerritOpenStack Proposal Bot proposed openstack/ironic-python-agent master: Updated from global requirements  https://review.openstack.org/46438712:08
*** rbudden has joined #openstack-ironic12:12
*** bfournie has joined #openstack-ironic12:19
*** lucas-hungry is now known as lucasagomes12:22
*** dprince has joined #openstack-ironic12:30
*** mat128 has quit IRC12:31
*** chas_ has quit IRC12:32
*** chas has joined #openstack-ironic12:32
*** vmud213 has quit IRC12:33
*** baoli has joined #openstack-ironic12:35
TheJuliaGood morning everyone!12:36
TheJuliaI'm declaring messaging bankruptcy from last week, if there is something needed, please ping me again.12:36
*** chas has quit IRC12:37
sambettshey TheJulia, did you travel home ok?12:40
TheJuliasambetts: I did, Not even a delayed flight \o/12:40
TheJuliaYourself?12:40
sambettsYeah, not bad for a tranatlantic12:41
sambettstrans-atlantic*12:42
sambettsalthough I'll never understand why they insist on giving everyone dinner after everyone is settled into sleep :-P12:43
TheJuliaI kind of wondered the same thing flying home from Tokyo12:43
TheJuliaI did like the "mid night snack" on the way there, pizza and ice cream :)12:44
sambettsoh nice :-P we got little ice creams on the way to boston too12:44
TheJuliaAwesome12:45
*** mvpnitesh has quit IRC12:46
*** mvpnitesh has joined #openstack-ironic12:46
*** sasha2 has joined #openstack-ironic12:47
*** srobert has joined #openstack-ironic12:48
bfourniemorning Ironic. TheJulia - great job on the Keynote!  Do you happen to have the deploy-k8s.sh script you ran? Just curious as to the config. thx12:50
sambettsTheJulia: I have a question about https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/ipmitool.py#L129 will that string appear on all errors from ipmitool?12:50
sambettsTheJulia: just trying to work out what errors get retryed by the _exec_ipmitool function12:51
*** trown|outtypewww is now known as trown12:53
TheJuliabfournie: It is on my list to upload sometime tomorrow, I'll make a little GitHub repo with it12:53
TheJuliadoing expenses and such today12:53
sambetts\o/ paper work12:53
bfournieTheJulia: thank you!12:53
TheJuliasambetts: not all errors, i think it is rooted from the BMC, but I don't remember exactly12:54
TheJuliaI remember digging through the code and all then.12:54
*** jcoufal has joined #openstack-ironic12:54
sambettsTheJulia: it just seems like it only checks that one error string, and your comment there seems to imply ipmitool replaces there errors from the BMC with that string12:55
TheJuliasambetts: Yeah, I think it is a specific "I'm too busy right now" message that returns that error, but the purpose of the list was so that we could create a list of "known safe to retry failures"12:56
TheJuliabfournie: it was super simple btw, enumerated through ports, attached them to the network, attached the VIFs in ironic, set instance info, and triggered deploy.12:57
*** nicodemos has joined #openstack-ironic12:57
*** shuyingy_ has quit IRC12:59
*** vikrant has quit IRC13:01
bfournieTheJulia: cool, it looked good13:04
vdrokmorning TheJulia and bfournie13:04
dtantsurmorning TheJulia, bfournie13:05
*** Goneri has joined #openstack-ironic13:08
bfourniemorning vdrok and dtantsur13:09
*** mvpnitesh has quit IRC13:09
*** mvpnitesh has joined #openstack-ironic13:10
dtantsursambetts, hi! does https://bugzilla.redhat.com/show_bug.cgi?id=1450118 ring any bells to you?13:13
openstackbugzilla.redhat.com bug 1450118 in openstack-ironic "[Mix versions] compute node delete does not remover vif_port_id from port.extra" [Unspecified,Assigned] - Assigned to dtantsur13:13
dtantsurit looks like VIFs are not properly cleaned on Ocata for instances created with Newton13:13
*** mgoddard has joined #openstack-ironic13:13
*** pabardina has joined #openstack-ironic13:14
dtantsurgood bot (but why does it take 2 minutes??)13:14
*** jaosorior has quit IRC13:15
sambettsdtantsur: https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/network/common.py#L419 it should if we're getting the vif detach request from the nova side :/13:15
dtantsuryep.. I guess I have to dive into logs13:16
sambettsdtantsur: is it possible you can get the nova-compute and ironic-conductor logs for that report?13:16
dtantsurthere's a sosreport attached, lemme see it13:17
dtantsursambetts, you can find ironic logs in https://bugzilla.redhat.com/attachment.cgi?id=1277914 (/var/log), but nova logs are empty...13:19
dtantsurrbartal, do you know why /var/log/nova shows nothing helpful in your report ^^^?13:19
*** jcoufal_ has joined #openstack-ironic13:23
*** makowals_ has joined #openstack-ironic13:24
*** johnthetubaguy has left #openstack-ironic13:24
*** mvpnitesh has quit IRC13:25
*** makowals_ has quit IRC13:25
*** makowals has quit IRC13:26
*** jcoufal has quit IRC13:26
*** johnthetubaguy has joined #openstack-ironic13:26
*** johnthetubaguy has quit IRC13:27
*** chas has joined #openstack-ironic13:27
*** Serlex has quit IRC13:27
*** makowals has joined #openstack-ironic13:28
*** johnthetubaguy has joined #openstack-ironic13:29
*** chas has quit IRC13:29
*** chas has joined #openstack-ironic13:29
pabardinahello ! I'm trying to use ironic-inspector. In my configuration, I have specify the "keystone_authtoken" section. But in logs, there is few errors like "EndpointNotFound: Could not find requested endpoint in Service Catalog." I don't really understand what is missing. If someone has an idea...13:31
*** johnthetubaguy has quit IRC13:33
dtantsurpabardina, have you filled in [ironic] and [swift] sections too? keystone_authtoken is only used for checking authentication, not for accessing other services13:34
*** xavierr has joined #openstack-ironic13:34
*** johnthetubaguy has joined #openstack-ironic13:34
*** rloo has joined #openstack-ironic13:35
dtantsurlucasagomes, mind checking https://review.openstack.org/#/c/463680/ please? needs 2nd +213:35
patchbotpatch 463680 - sushy - Improve logging and error handling in base code13:35
lucasagomesdtantsur, on a meeting now, I will take a look right after!13:36
*** gcb has joined #openstack-ironic13:36
lucasagomesin*13:36
dtantsurthnx13:36
*** johnthetubaguy has quit IRC13:37
*** jcoufal_ has quit IRC13:37
openstackgerritMark Goddard proposed openstack/ironic-specs master: Update physical network-awareness spec  https://review.openstack.org/46464413:37
*** gcb has quit IRC13:37
*** jcoufal has joined #openstack-ironic13:38
vdrokdtantsur: will also look in a bit13:39
openstackgerritMerged openstack/sushy master: Updated from global requirements  https://review.openstack.org/46449413:39
*** gcb has joined #openstack-ironic13:40
vdrokdtantsur: so here https://review.openstack.org/#/c/464188/1/sushy/tests/unit/test_connector.py if the intent is to use conn as context manager, should we do this in tests?13:45
patchbotpatch 464188 - sushy - Fix working with requests Session object13:45
*** johnthetubaguy has joined #openstack-ironic13:47
*** johnthetubaguy has quit IRC13:48
dtantsurvdrok, not sure about "intent", I rather want this to be just possible13:49
dtantsurI don't have any opinion about using it in tests13:49
vdrokdtantsur: the only reason I ask is, it does not get close()d, but this is a mock session anyway13:50
dtantsuryeah, this is why we don't bother closing it :)13:51
openstackgerritSam Betts proposed openstack/ironic master: Don't retry power status if power action fails  https://review.openstack.org/44945413:54
*** derekh has quit IRC13:54
jlvillalvdrok, Thanks for reviewing the patch I did the accidental +A on!13:55
*** gcb has quit IRC13:55
vdrokjlvillal: heh, you're welcome :) morning!13:55
jlvillalvdrok, :) Trying to wake up now.13:55
*** gcb has joined #openstack-ironic13:56
*** mat128 has joined #openstack-ironic14:00
*** johnthetubaguy has joined #openstack-ironic14:04
*** shuyingya has joined #openstack-ironic14:04
TheJuliaGood morning vdrok, dtantsur14:05
TheJuliaOut of curiosity, anyone use irc cloud and running into getting logged out quite a bit?14:05
*** crushil has joined #openstack-ironic14:05
* dtantsur uses znc + hexchat14:06
*** johnthetubaguy has quit IRC14:07
*** johnthetubaguy has joined #openstack-ironic14:07
*** johnthetubaguy has quit IRC14:08
*** shuyingya has quit IRC14:09
*** johnthetubaguy has joined #openstack-ironic14:10
*** johnthetubaguy has quit IRC14:10
*** johnthetubaguy has joined #openstack-ironic14:10
*** Serlex has joined #openstack-ironic14:17
*** johnthetubaguy has quit IRC14:17
*** johnthetubaguy has joined #openstack-ironic14:17
*** ricardoas has joined #openstack-ironic14:19
openstackgerritMerged openstack/virtualbmc master: Updated from global requirements  https://review.openstack.org/46450314:19
*** jaganathan has quit IRC14:20
*** baoli has quit IRC14:21
*** mgoddard_ has joined #openstack-ironic14:26
*** rbartal has quit IRC14:26
*** mgoddard has quit IRC14:27
sambettsTheJulia: I know robcresswell uses it14:27
*** mgoddard__ has joined #openstack-ironic14:27
dtantsursambetts, another similar issue with VIF: https://bugs.launchpad.net/ironic/+bug/168559214:29
openstackLaunchpad bug 1685592 in Ironic "tenant_vif_port_id is not removed during tear_down" [Undecided,New] - Assigned to Wang KaiFeng (kaifeng)14:29
sambettsdtantsur: that bug report seems to suggest they are deleting the node manually :/14:30
sambettsdtantsur: I'm going to leave a comment to check14:30
dtantsurah, that's a different story then14:30
*** mgoddard_ has quit IRC14:31
robcresswellTheJulia: Not had any logout issues14:31
*** jaypipes has joined #openstack-ironic14:35
*** derekh has joined #openstack-ironic14:36
*** jcoufal_ has joined #openstack-ironic14:37
*** shuyingya has joined #openstack-ironic14:38
*** derekh has quit IRC14:38
*** derekh has joined #openstack-ironic14:39
TheJuliaI'm guessing it is connectivity related14:39
openstackgerritMark Goddard proposed openstack/ironic-specs master: Update physical network-awareness spec  https://review.openstack.org/46464414:39
*** jcoufal has quit IRC14:40
*** Goneri has quit IRC14:41
*** dyasny has quit IRC14:43
openstackgerritMerged openstack/ironic-ui master: Updated from global requirements  https://review.openstack.org/46438814:47
TheJuliaAny chance I could get an ironic-core to do a sanity check review on https://review.openstack.org/#/c/447532/ ?14:47
patchbotpatch 447532 - ironic-ui - Fix Javascript unassignable errors14:47
*** zackf has joined #openstack-ironic14:48
*** MattMan has quit IRC14:50
sambettsrobcresswell: could you glance a quick eye over this for any obvious mistakes ^14:50
*** MattMan has joined #openstack-ironic14:50
openstackgerritMerged openstack/ironic-ui master: Improve strings for translation  https://review.openstack.org/46254614:51
*** jaypipes has quit IRC14:53
openstackgerritMerged openstack/ironic-ui master: Imported Translations from Zanata  https://review.openstack.org/45564014:53
*** dyasny has joined #openstack-ironic14:53
*** jaypipes has joined #openstack-ironic14:53
TheJuliaAlso, any glance at https://review.openstack.org/#/c/437419/11 would be appreciated. :)14:55
patchbotpatch 437419 - ironic-ui - Add support for starting/stopping/accessing the se...14:55
TheJuliasambetts: ++14:55
robcresswellThat first patch looks... interesting14:55
robcresswellhmm14:55
*** dyasny has quit IRC14:58
robcresswellTheJulia: It looks valid, to me, but I'm not entirely certain why its not working as-is14:58
* robcresswell looks at second patch14:58
NobodyCamGood Morning Ironic'ers15:00
TheJuliaI think I swapped that context out of my brain about a month ago :(15:00
TheJuliaGood morning NobodyCam15:00
NobodyCamMorning TheJulia :)15:01
vdrokmorning NobodyCam15:01
sambettsTheJulia, robcresswell: in the starting/stopping/accessing patch, I wonder if we should be using the same form e.g. the ng-click and the <a> seems weird to be mixing and matching but I might be out of context15:01
NobodyCamMorning vdrok :)15:01
openstackgerritDmitry Tantsur proposed openstack/ironic-inspector master: Do not fail rules rollback on bad formatting key  https://review.openstack.org/46466215:02
dtantsurmorning NobodyCam15:02
NobodyCam:) good morning dtantsur :)15:03
robcresswellTheJulia: Left a couple of comments, nothing in depth though (no Ironic running right now)15:03
TheJuliasambetts: because if memory serves a url gets stored with shellinabox15:03
TheJuliabut, style wise it would look different, but consistent for values, just making it click-able if it is a url from shellinabox15:04
*** rcernin has quit IRC15:07
*** dyasny has joined #openstack-ironic15:07
*** dsneddon has joined #openstack-ironic15:08
openstackgerritMerged openstack/bifrost master: scripts: install-deps.sh: Add dnf as supported package manager  https://review.openstack.org/46331315:12
*** dprince has quit IRC15:14
*** Goneri has joined #openstack-ironic15:16
TheJuliadtantsur/rloo: any objection if I put an RFE up on RFE review for today's meeting?15:18
rlooTheJulia: is there contention about the RFE?15:18
dtantsurTheJulia, no objections, as long as it does not require an hour of reading :)15:18
rlooTheJulia: if so, then sure.15:18
TheJuliaI don't think so, just it has not gotten eyes or a yes/no rfe-approved stamp15:18
*** jaypipes has quit IRC15:19
rlooTheJulia: I thought that 'section' was meant to get past conflicting or whatever.15:19
rlooTheJulia: if it is to get eyes on it, isn't that in open discussion?15:19
rlooTheJulia: or is the question 'does it need a spec'?15:20
TheJuliaI doubt it needs a spec, seems strait forward, just has gotten no approval or even appearance of review since it was created15:20
TheJuliatl;dr it has gotten lost in the mix15:21
vdrokyou can just link it here, we'll approve if it is straightforward :)15:21
rlooTheJulia: ok, that's fine then.15:21
TheJuliahttps://bugs.launchpad.net/ironic-python-agent/+bug/163525315:21
openstackLaunchpad bug 1635253 in ironic-python-agent "[RFE] Retrieve NUMA node information during introspection" [Wishlist,In progress] - Assigned to Jaganathan Palanisamy (jaganathanp)15:21
dtantsurTheJulia, I think we have a spec approved for that15:21
dtantsurhttp://specs.openstack.org/openstack/ironic-inspector-specs/specs/NUMA_node_info.html15:21
TheJuliaAhh, then implicitly approved15:22
TheJulianever mind!15:22
* TheJulia goes back to the mine15:23
rlooTheJulia: good that you brought it up. someone shoudl have approved that spec.15:23
*** pcaruana has quit IRC15:25
sambettsI've marked it as rfe-approved15:25
TheJuliain a similar vain, although no spec https://bugs.launchpad.net/ironic-python-agent/+bug/1635351 :)15:26
openstackLaunchpad bug 1635351 in ironic-python-agent "[RFE] Collect biosdevname info " [Wishlist,In progress] - Assigned to Annie Lezil (annie-lezil)15:26
TheJuliaactually15:26
TheJuliayes, there is a spec15:26
TheJuliachanging tag15:26
rlooTheJulia: i approved the previous rfe15:26
rlooTheJulia: yes, feel free to change the tag if the spec was approved. we don't always remember to do that.15:27
TheJuliadone15:27
rlooTheJulia: :)15:27
*** pabardina has quit IRC15:29
*** makowals has quit IRC15:31
*** makowals has joined #openstack-ironic15:34
*** shuyingya has quit IRC15:36
*** jcoufal has joined #openstack-ironic15:38
*** gcb has quit IRC15:39
*** vmud213 has joined #openstack-ironic15:39
*** jcoufal__ has joined #openstack-ironic15:40
*** jcoufal_ has quit IRC15:41
openstackgerritMerged openstack/python-ironicclient master: Updated from global requirements  https://review.openstack.org/46446715:41
*** jcoufal has quit IRC15:42
TheJuliasambetts: If you have a few minutes, I would appreciate it if you took a look at https://review.openstack.org/#/c/396406/57 since it has tinyipa build script changes15:50
patchbotpatch 396406 - ironic-python-agent - Collect NIC name given by BIOS15:50
*** jaosorior has joined #openstack-ironic15:51
*** Goneri has quit IRC15:52
*** jcoufal__ has quit IRC15:53
*** jcoufal has joined #openstack-ironic15:54
sambettsTheJulia: I'll take a look15:55
*** ijw has joined #openstack-ironic16:01
TheJuliasambetts: Thank you16:05
rloojlvillal: thx for the review on https://review.openstack.org/#/c/412397/45. i replied. when you have a chance, would be good to discuss.16:06
patchbotpatch 412397 - ironic - Add version column16:06
*** Goneri has joined #openstack-ironic16:07
jlvillalrloo: Looking16:08
rloojlvillal: my first question. does it seem complicated to you?16:09
jlvillalrloo: Yeah :)16:09
jlvillalrloo: Taking me awhile to understand it.16:09
jlvillalrloo: I don't think I yet fully understand it...16:09
rloojlvillal: sigh. i think the version column actually complicated things.16:10
jlvillalrloo: But that might be me more than the code. I am not that familar with this stuff16:10
rloojlvillal: that's the other problem, the nuances of the way the object versioning works.16:10
*** kromanenko has quit IRC16:11
jlvillalrloo: On that function name. I'm not sure a good name. But the current name is really meh for me.16:12
jlvillalrloo: to me 'do_changes_for_db' doesn't mean much when I read it. Well it almost sounds like it is changing the db. But then again, maybe it is changing something for the db. But changing what?16:13
*** karthiks has quit IRC16:14
rloojlvillal: would 'do_version_changes_for_db' be better?16:14
jlvillalrloo: That sounds better to me.16:14
*** dprince has joined #openstack-ironic16:14
rloojlvillal: ok16:14
rloojlvillal: as far as the base unit tests go -- i agree that it is odd there are no unit tests for those, but it seems outside the scope of this patch, to add them in :-(16:15
*** dtantsur is now known as dtantsur|brb16:15
*** jaganathan has joined #openstack-ironic16:15
jlvillalrloo: Well I would think there should be unit tests for the new functions.16:16
jlvillalrloo: I'm not saying write unit tests for everything. Just the added functions in the patch.16:16
jlvillalrloo: I"m surprised there isn't a unit test file for that code file :(16:16
jlvillalrloo: Or at least I'm not finding it in the obvious ironic/tests/unit/objects/test_base.py location. Where I would expect it.16:17
rloojlvillal: no, i couldn't find it. i think the tests are done via the actual objects that inherit the base.16:17
*** chihhsin_ has quit IRC16:18
rloojlvillal: let me see about adding a separate patch to address it. the problem being that i hate unit tests ;)16:18
jlvillalheh. I know :(16:18
*** mjturek has joined #openstack-ironic16:19
*** chihhsin has joined #openstack-ironic16:19
vdrokjlvillal: right, the base did contain a very basic set of things, like conversion of object to dictionary, they were not directly tested, but used almost everywhere throughout the code.16:19
rloovdrok: ah, so it wasn't deemed useful (at the time) to add unit tests?16:20
rloovdrok: or just laziness? :)16:21
vdrokrloo: I guess, the tests at that point would not be anyhow interesting :) like testing as_dict function that looks like return dict((k, getattr(self, k)) for k in self.fields if hasattr(self, k))16:21
jlvillalvdrok: It is getting more complicated now: https://review.openstack.org/#/c/412397/45/ironic/objects/base.py16:22
patchbotpatch 412397 - ironic - Add version column16:22
vdrokyeah, I know :)16:22
jlvillalrloo: I vote it was laziness :)16:22
rlooha ha16:22
jlvillalAnd I can totally understand why.16:22
vdrok"common sense" is more polite way of saying this :D16:23
vdrokbut yeah, basically laziness16:23
rloowell, really, we are pressed for time too. gotta prioritize what we do.16:23
* vdrok will be back for the meeting16:24
*** crushil has quit IRC16:24
*** jcoufal has quit IRC16:26
*** jcoufal has joined #openstack-ironic16:28
*** e0ne has joined #openstack-ironic16:31
*** mjturek has quit IRC16:32
*** Goneri has quit IRC16:33
openstackgerritMerged openstack/ironic-inspector master: Updated from global requirements  https://review.openstack.org/46438416:33
*** baoli has joined #openstack-ironic16:40
*** harlowja has joined #openstack-ironic16:44
*** deray has joined #openstack-ironic16:44
openstackgerritOpenStack Proposal Bot proposed openstack/bifrost master: Updated from global requirements  https://review.openstack.org/46435816:44
*** lucasagomes is now known as lucas-afk16:45
*** dtantsur|brb is now known as dtantsur16:47
*** chas has quit IRC16:47
*** chas has joined #openstack-ironic16:48
rloojlvillal, vdrok: ugh, i was wrong. the base code is being tested here: https://review.openstack.org/#/c/412397/45/ironic/tests/unit/objects/test_objects.py16:49
patchbotpatch 412397 - ironic - Add version column16:49
*** deray has quit IRC16:50
*** jcoufal_ has joined #openstack-ironic16:50
*** vmud213 has quit IRC16:50
*** deray has joined #openstack-ironic16:50
*** crushil has joined #openstack-ironic16:50
*** vmud213 has joined #openstack-ironic16:51
*** jcoufal__ has joined #openstack-ironic16:52
*** chas has quit IRC16:52
*** trown is now known as trown|lunch16:53
*** jcoufal has quit IRC16:53
*** stendulker has joined #openstack-ironic16:53
*** stendulker has quit IRC16:54
*** stendulker has joined #openstack-ironic16:54
*** vmud213 has quit IRC16:54
*** jcoufal_ has quit IRC16:55
*** vmud213 has joined #openstack-ironic16:55
dtantsurwow, we have a hell of a thunderstorm right now16:58
dtantsurlet's hope I won't get disconnected mid-meeting16:59
dtantsurthis ^^ is a shameless reminder about the coming meeting ;)16:59
*** derekh has quit IRC16:59
*** vmud213 has quit IRC16:59
*** e0ne has quit IRC17:01
*** ijw has quit IRC17:02
*** ChubYann has joined #openstack-ironic17:04
*** mgoddard__ has quit IRC17:05
*** ijw has joined #openstack-ironic17:05
*** Serlex has quit IRC17:08
*** chas has joined #openstack-ironic17:08
*** bcornec has joined #openstack-ironic17:12
*** chas has quit IRC17:13
*** fragatina has joined #openstack-ironic17:23
*** mgoddard__ has joined #openstack-ironic17:24
*** e0ne has joined #openstack-ironic17:25
openstackgerritMichael Turek proposed openstack/ironic master: Remove logging translation calls from ironic.common  https://review.openstack.org/44808917:28
*** ralonsoh has quit IRC17:30
openstackgerritSam Betts proposed openstack/ironic master: Don't retry power status if power action fails  https://review.openstack.org/44945417:32
*** karthiks has joined #openstack-ironic17:36
*** Goneri has joined #openstack-ironic17:37
*** fultonj has joined #openstack-ironic17:38
*** ijw has quit IRC17:40
*** livelace has quit IRC17:41
*** e0ne has quit IRC17:45
*** fragatina has quit IRC17:49
*** Goneri has quit IRC17:50
*** fragatina has joined #openstack-ironic17:54
*** fragatina has quit IRC17:58
*** aarefiev is now known as aarefiev_afk17:59
vdrokrloo: whee, we are not lazy :)17:59
*** deray has quit IRC18:00
vdrokkind of an announcement from me, I'll be working on some downstream nova stuff half-time from now on, so will be a bit less active here18:01
rloovdrok: :)18:01
rloovdrok: boo18:01
rloovdrok: unless it is the placement stuff :D18:02
dtantsurheh18:02
vdrokrloo: I wish it was :) mostly some escalations and stuff like that18:02
TheJuliavdrok: Happens to us all :)18:02
vdrokbugfixing mitaka etc18:02
dtantsurthanks for letting us know18:02
sambettso/ night all18:03
vdrokgood night sambetts and all!18:03
*** sambetts is now known as sambetts|afk18:04
*** trown|lunch is now known as trown18:08
* aNuposic anupn18:12
*** aNuposic is now known as anupn18:12
*** rbartal has joined #openstack-ironic18:17
*** jaganathan has quit IRC18:17
*** marlinc has quit IRC18:18
*** krtaylor has quit IRC18:19
*** stendulker has quit IRC18:24
*** amarao has quit IRC18:25
*** rbartal has quit IRC18:28
*** fragatina has joined #openstack-ironic18:32
*** fragatina has quit IRC18:32
*** fragatina has joined #openstack-ironic18:33
*** bcornec has quit IRC18:34
*** jcoufal__ has quit IRC18:38
*** mgoddard__ has quit IRC18:39
*** jcoufal has joined #openstack-ironic18:39
*** crushil has quit IRC18:42
*** marlinc has joined #openstack-ironic18:42
*** baoli has quit IRC18:58
*** dtantsur is now known as dtantsur|afk18:59
dtantsur|afko/18:59
*** baoli has joined #openstack-ironic18:59
*** karthiks has quit IRC19:04
*** crushil has joined #openstack-ironic19:04
*** jcoufal_ has joined #openstack-ironic19:06
*** zackf has quit IRC19:07
*** jcoufal has quit IRC19:09
*** zackf has joined #openstack-ironic19:10
*** jcoufal has joined #openstack-ironic19:10
*** mgoddard__ has joined #openstack-ironic19:12
*** jcoufal_ has quit IRC19:12
TheJuliadtantsur|afk: ppiela: betherly: fyi, I just sent an email off to the list regarding ironic-ui. Please raise any objections sooner rather than later.19:13
*** chas has joined #openstack-ironic19:14
TheJuliaand betherly! Congrats!19:14
*** zackf has quit IRC19:14
*** Goneri has joined #openstack-ironic19:15
*** devananda has quit IRC19:16
*** crushil has quit IRC19:17
*** crushil has joined #openstack-ironic19:17
*** chas has quit IRC19:18
*** adisky_ has quit IRC19:18
*** zackf has joined #openstack-ironic19:23
*** krtaylor has joined #openstack-ironic19:30
*** karthiks has joined #openstack-ironic19:34
*** chas has joined #openstack-ironic19:34
*** athomas has quit IRC19:39
*** chas has quit IRC19:39
*** mgoddard__ has quit IRC19:40
openstackgerritRamamani Yeleswarapu proposed openstack/ironic-ui master: Add support for editing node's resource_class  https://review.openstack.org/46385219:41
*** athomas has joined #openstack-ironic19:41
ppielaTheJulia: will do19:42
*** jcoufal_ has joined #openstack-ironic19:45
*** jcoufal has quit IRC19:49
*** zackf has quit IRC19:53
*** jcoufal_ has quit IRC19:55
openstackgerritRuby Loo proposed openstack/ironic master: Add version column  https://review.openstack.org/41239719:55
*** jcoufal has joined #openstack-ironic19:55
*** chas has joined #openstack-ironic19:56
*** zackf has joined #openstack-ironic19:56
*** devananda has joined #openstack-ironic19:58
*** chas has quit IRC20:00
*** zackf has quit IRC20:00
*** mjturek has joined #openstack-ironic20:03
*** athomas has quit IRC20:09
*** jcoufal_ has joined #openstack-ironic20:10
*** baoli has quit IRC20:12
*** jcoufal has quit IRC20:12
*** baoli has joined #openstack-ironic20:12
*** baoli has quit IRC20:13
*** baoli has joined #openstack-ironic20:15
*** rnoriega has quit IRC20:17
*** lhinds has quit IRC20:17
*** lhinds has joined #openstack-ironic20:18
*** rnoriega has joined #openstack-ironic20:20
*** jcoufal_ has quit IRC20:23
*** crushil has quit IRC20:24
*** jcoufal has joined #openstack-ironic20:24
*** mat128 has quit IRC20:25
*** rloo has quit IRC20:25
*** rloo has joined #openstack-ironic20:28
*** mjturek has quit IRC20:29
*** chas has joined #openstack-ironic20:37
openstackgerritRamamani Yeleswarapu proposed openstack/ironic-inspector-specs master: Collect Bios, Memory and Processor Info from Dmidecode - follow-up  https://review.openstack.org/46425920:41
*** chas has quit IRC20:42
*** jcoufal_ has joined #openstack-ironic20:52
*** srobert has quit IRC20:52
*** jcoufal has quit IRC20:54
*** zackf has joined #openstack-ironic20:59
*** xavierr has quit IRC21:01
*** Sukhdev has joined #openstack-ironic21:02
*** bfournie has quit IRC21:11
*** Sukhdev_ has joined #openstack-ironic21:11
*** ricardoas is now known as ricardoas-afk21:14
*** chas has joined #openstack-ironic21:19
*** jcoufal_ has quit IRC21:19
*** jcoufal has joined #openstack-ironic21:19
*** rloo has quit IRC21:20
*** rloo has joined #openstack-ironic21:21
*** chas has quit IRC21:24
*** jcoufal_ has joined #openstack-ironic21:24
*** jcoufal has quit IRC21:26
*** zackf has quit IRC21:27
*** baoli has quit IRC21:28
*** jkilpatr has quit IRC21:32
*** zackf has joined #openstack-ironic21:32
*** zackf has quit IRC21:37
*** chas has joined #openstack-ironic21:40
*** chas has quit IRC21:44
*** krtaylor has quit IRC21:48
*** jkilpatr has joined #openstack-ironic22:00
*** chas has joined #openstack-ironic22:01
*** zackf has joined #openstack-ironic22:02
*** ijw has joined #openstack-ironic22:02
*** oanson has quit IRC22:03
*** oanson has joined #openstack-ironic22:03
*** dprince has quit IRC22:04
*** chas has quit IRC22:06
openstackgerritRuby Loo proposed openstack/ironic master: Add new dbsync command with first online data migration  https://review.openstack.org/40855622:12
openstackgerritRuby Loo proposed openstack/ironic master: Unit test for checking cross-version migrations compatibility  https://review.openstack.org/41999322:13
openstackgerritRuby Loo proposed openstack/ironic master: Rolling upgrade procedure documentation  https://review.openstack.org/41656522:13
openstackgerritRuby Loo proposed openstack/ironic master: Rolling upgrades related dev documentation  https://review.openstack.org/41943922:14
openstackgerritRuby Loo proposed openstack/ironic master: [POC|DNM|TEST] Add node.configdrive  https://review.openstack.org/45581122:14
*** jcoufal has joined #openstack-ironic22:18
*** jcoufal_ has quit IRC22:20
*** jcoufal has quit IRC22:29
*** jcoufal has joined #openstack-ironic22:30
*** zackf has quit IRC22:34
openstackgerritMerged openstack/bifrost master: Updated from global requirements  https://review.openstack.org/46435822:35
*** jcoufal has quit IRC22:42
*** chas has joined #openstack-ironic22:42
*** jcoufal_ has joined #openstack-ironic22:43
openstackgerritJohn L. Villalovos proposed openstack/ironic master: Start passing portgroup information to Neutron  https://review.openstack.org/44676322:45
*** chas has quit IRC22:48
*** jcoufal_ has quit IRC22:54
*** jcoufal has joined #openstack-ironic22:55
*** zackf has joined #openstack-ironic23:04
*** pmannidi has joined #openstack-ironic23:07
*** pmannidi has quit IRC23:08
*** pmannidi has joined #openstack-ironic23:08
*** ijw has quit IRC23:09
*** ijw has joined #openstack-ironic23:11
openstackgerritMerged openstack/ironic-python-agent master: Updated from global requirements  https://review.openstack.org/46438723:14
*** ijw has quit IRC23:16
*** Sukhdev has quit IRC23:22
*** jcoufal has quit IRC23:24
openstackgerritOpenStack Proposal Bot proposed openstack/bifrost stable/ocata: Updated from global requirements  https://review.openstack.org/46478223:29
*** pmannidi has quit IRC23:29
*** jcoufal has joined #openstack-ironic23:29
openstackgerritOpenStack Proposal Bot proposed openstack/ironic stable/ocata: Updated from global requirements  https://review.openstack.org/46479823:31
openstackgerritOpenStack Proposal Bot proposed openstack/ironic-inspector stable/ocata: Updated from global requirements  https://review.openstack.org/46479923:31
openstackgerritOpenStack Proposal Bot proposed openstack/ironic-lib stable/ocata: Updated from global requirements  https://review.openstack.org/46480023:31
openstackgerritOpenStack Proposal Bot proposed openstack/ironic-python-agent stable/ocata: Updated from global requirements  https://review.openstack.org/46480223:31
openstackgerritOpenStack Proposal Bot proposed openstack/ironic-ui stable/ocata: Updated from global requirements  https://review.openstack.org/46480323:31
*** zackf has quit IRC23:34
openstackgerritMerged openstack/ironic master: Remove log translations from ironic/drivers Part-1  https://review.openstack.org/45003623:38
openstackgerritOpenStack Proposal Bot proposed openstack/python-ironic-inspector-client stable/ocata: Updated from global requirements  https://review.openstack.org/46486023:38
openstackgerritOpenStack Proposal Bot proposed openstack/python-ironicclient stable/ocata: Updated from global requirements  https://review.openstack.org/46486123:38
*** ijw has joined #openstack-ironic23:42
*** Goneri has quit IRC23:44
*** harlowja has quit IRC23:46
*** pmannidi has joined #openstack-ironic23:47
*** crushil has joined #openstack-ironic23:53
*** hoonetorg has quit IRC23:54

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!