Friday, 2017-04-28

*** ijw has quit IRC00:00
openstackgerritNisha Agarwal proposed openstack/ironic-specs master: Enhance ilo drivers to do inband inspection  https://review.openstack.org/20190400:15
*** ijw has joined #openstack-ironic00:20
*** Nisha_Agarwal has quit IRC00:20
*** ijw has quit IRC00:24
*** g3ek has quit IRC00:37
*** sasha21 has quit IRC00:41
*** g3ek has joined #openstack-ironic00:46
*** crushil has joined #openstack-ironic00:50
*** yee379 has quit IRC00:58
*** yee379 has joined #openstack-ironic00:58
*** tiendc has joined #openstack-ironic01:02
*** hoonetorg has quit IRC01:15
*** hoonetorg has joined #openstack-ironic01:20
*** WeiAA has joined #openstack-ironic01:21
*** tuanluong has joined #openstack-ironic01:31
*** chas has joined #openstack-ironic01:47
*** chas has quit IRC01:51
*** Sukhdev_ has quit IRC01:52
*** mat128 has joined #openstack-ironic01:55
*** yolanda has quit IRC01:55
*** Goneri has quit IRC01:58
*** zhurong has joined #openstack-ironic02:04
*** Nakato has quit IRC02:06
*** Nakato has joined #openstack-ironic02:09
*** jaeman has joined #openstack-ironic02:15
jaemanHi, guys. I am provisioning baremetal nova instance by Ironic with fedora image. The instance's status is ACTIVE but booting does not finish with message "A start job is running for dev-disk..."02:17
jaemanPlease let me know if anyone know how to resolve this issue.02:18
*** yee379 has quit IRC02:31
*** yee37917 has joined #openstack-ironic02:31
*** Nakato has quit IRC02:32
*** Nakato has joined #openstack-ironic02:33
openstackgerritDao Cong Tien proposed openstack/python-ironicclient master: Extends driver-list, driver-show supporting new hardware types  https://review.openstack.org/41927402:42
openstackgerritNgo Quoc Cuong proposed openstack/ironic master: Remove translation of log messages from     + ironic/drivers/modules/drac     + ironic/drivers/modules/ilo     + ironic/drivers/modules/network     + ironic/drivers/modules/oneview  https://review.openstack.org/46036702:47
openstackgerritNgo Quoc Cuong proposed openstack/ironic master: Remove translation of log messages from     + ironic/drivers/modules/drac     + ironic/drivers/modules/network     + ironic/drivers/modules/oneview  https://review.openstack.org/46036702:54
*** hw_wutianwei has quit IRC02:58
*** hoonetorg has quit IRC02:59
openstackgerritRuby Loo proposed openstack/ironic master: Add context to IronicObject._from_db_object()  https://review.openstack.org/46080903:04
*** mat128 has quit IRC03:15
*** hoonetorg has joined #openstack-ironic03:15
*** crushil has quit IRC03:19
*** rbudden has quit IRC03:19
*** aparnav has joined #openstack-ironic03:24
*** zhurong has quit IRC03:38
*** mat128 has joined #openstack-ironic03:47
*** chas has joined #openstack-ironic03:48
*** gkadam has joined #openstack-ironic03:51
*** chas has quit IRC03:52
openstackgerritNgo Quoc Cuong proposed openstack/ironic master: Remove translation of log messages from     + ironic/drivers/modules/drac     + ironic/drivers/modules/network     + ironic/drivers/modules/oneview     + ironic/common     + ironic/tests  https://review.openstack.org/46036703:57
*** pmannidi has joined #openstack-ironic04:03
*** pmannidi has quit IRC04:04
*** pmannidi has joined #openstack-ironic04:04
*** fragatina has quit IRC04:11
*** jcoufal has joined #openstack-ironic04:13
*** amotoki has joined #openstack-ironic04:14
*** phuongnh has joined #openstack-ironic04:15
*** jcoufal has quit IRC04:20
*** adisky_ has joined #openstack-ironic04:23
*** mat128 has quit IRC04:27
*** jaypipes has quit IRC04:29
*** Sukhdev has joined #openstack-ironic04:30
*** udesale has joined #openstack-ironic04:41
*** jaypipes has joined #openstack-ironic04:41
*** gkadam__ has joined #openstack-ironic04:48
*** gkadam has quit IRC04:49
*** gkadam__ is now known as regain04:49
*** regain is now known as gkadam04:49
*** gkadam has quit IRC04:50
*** gkadam has joined #openstack-ironic04:51
*** karthiks has joined #openstack-ironic04:54
*** zhurong has joined #openstack-ironic05:00
*** fragatina has joined #openstack-ironic05:10
*** fragatina has quit IRC05:12
*** fragatina has joined #openstack-ironic05:13
*** Sukhdev has quit IRC05:13
*** l_jacob has joined #openstack-ironic05:17
*** Nisha_Agarwal has joined #openstack-ironic05:25
*** causten has joined #openstack-ironic05:39
*** ChubYann has quit IRC05:42
*** yuanying_ has quit IRC05:57
*** jaeman has quit IRC05:59
*** Lambert has joined #openstack-ironic05:59
*** zhurong has quit IRC06:04
Nisha_Agarwalmorning Ironic :)06:10
*** zhurong has joined #openstack-ironic06:11
*** mvpnitesh has joined #openstack-ironic06:12
*** causten has quit IRC06:13
openstackgerritNgo Quoc Cuong proposed openstack/ironic master: Remove translation of log messages from ironic/drivers/modules/ and ironic/drivers/ (not include sub-folder)  https://review.openstack.org/46084106:13
*** zhurong has quit IRC06:23
*** Lambert has quit IRC06:29
*** phuongnh has quit IRC06:30
*** yuanying has joined #openstack-ironic06:36
*** pcaruana has joined #openstack-ironic06:36
Nisha_Agarwallucas-afk, hi06:39
*** ccamacho has joined #openstack-ironic06:40
*** Lambert has joined #openstack-ironic06:41
*** yuanying_ has joined #openstack-ironic06:42
*** yuanying has quit IRC06:42
*** e0ne has joined #openstack-ironic06:46
*** yuanying_ has quit IRC06:46
*** yuanying has joined #openstack-ironic06:47
*** chas has joined #openstack-ironic07:03
*** tesseract has joined #openstack-ironic07:05
*** e0ne has quit IRC07:19
*** Serlex has joined #openstack-ironic07:23
*** udesale has quit IRC07:30
*** tiendc_ has joined #openstack-ironic07:33
*** tuanluong has quit IRC07:34
*** tiendc has quit IRC07:34
*** g3ek has quit IRC07:38
*** pmannidi has quit IRC07:42
*** mgoddard has joined #openstack-ironic07:42
*** mvpnitesh has quit IRC07:45
*** mvpnitesh has joined #openstack-ironic07:45
openstackgerritThomas Herve proposed openstack/ironic master: Fix oslo.messaging log level  https://review.openstack.org/45791307:46
*** g3ek has joined #openstack-ironic07:46
Nisha_Agarwalsambetts|afk,07:49
Nisha_AgarwalHi07:49
*** Linkmark has joined #openstack-ironic07:53
*** makowals has joined #openstack-ironic07:54
*** zzzeek has quit IRC08:00
*** zzzeek has joined #openstack-ironic08:00
*** aarefiev_afk is now known as aarefiev08:07
aarefievmorning all!08:07
pas-hamorning ironic :)08:09
*** athomas has joined #openstack-ironic08:09
*** dtantsur|afk is now known as dtantsur08:17
dtantsurmorning ironic!08:17
*** lucas-afk is now known as lucasagomes08:17
lucasagomesmorning all08:17
openstackgerritVasyl Saienko proposed openstack/ironic master: [Devstack] Rework VMs connection logic  https://review.openstack.org/45354108:18
*** phuongnh has joined #openstack-ironic08:18
*** mvpnitesh has quit IRC08:23
*** tiendc has joined #openstack-ironic08:27
*** phuongnh has quit IRC08:28
*** tiendc_ has quit IRC08:28
Nisha_Agarwallucasagomes, dtantsur Hi08:29
*** phuongnh has joined #openstack-ironic08:29
Nisha_AgarwalI have the latest ironic and my ironic.conf has "redfish" as the enabled hardware types08:29
Nisha_Agarwalbut my conductor fails with error "DriverNotFoundInEntrypoint: Could not find the following items in the 'ironic.hardware.types' entrypoint: redfish, ipmi."08:30
dtantsurNisha_Agarwal, it does looks like some problem with installation. as you see it cannot even find "ipmi", which was introduced last cycle08:31
Nisha_Agarwali tried installing it using all the steps "sudo pip install .", "sudo pip install -e ." , and "sudo python setup.py install"08:32
Nisha_Agarwalbut the error doesnt go off08:32
*** racedo has joined #openstack-ironic08:32
Nisha_Agarwaldtantsur, yeah but i dont know what08:33
Nisha_Agarwaldtantsur, i just upgraded the sushy library and restarted conductor so that it can use the latest sushy08:34
Nisha_Agarwaland it started failing08:34
dtantsurhmm08:34
Nisha_Agarwalso i have even upgraded ironic and reinstalled it using above commands, but it fails08:34
Nisha_Agarwal:(08:34
Nisha_Agarwali wanted to test redfish driver with redfish hardware08:35
lucasagomesstrange, I mean, the library doesn't do anything with entry points08:35
lucasagomesit seems something with the ironic installation as dtantsur pointed out08:36
Nisha_Agarwallast week when i faced the same issue while bringing up the stack sambetts told me to use "sudo pip install -e ." and that worked that time08:36
dtantsurNisha_Agarwal, `less /usr/lib/python2.7/site-packages/ironic-*.egg-info/entry_points.txt` <- does it list redfish and ipmi?08:36
Nisha_Agarwallucasagomes, yes, but i have done all the correct way of installing the ironci08:36
dtantsurwell, assuming you have the same package layout as my centos..08:36
Nisha_Agarwaldtantsur, no it doesnt list08:39
Nisha_Agarwalhttp://paste.openstack.org/show/608292/08:39
Nisha_Agarwalhow to get that in this08:40
dtantsurNisha_Agarwal, ironic-2015.1.dev18 is OLD :)08:40
dtantsursomething apparently went wrong with pip install. what if you delete/uninstall ironic completely, and then try it again? I think 'sudo pip install -e .' is what you want to use08:40
*** derekh has joined #openstack-ironic08:40
dtantsuroh, I think I now what's wrong08:41
dtantsurversion 2015.1 is higher than 8.0 or whatever we have now08:41
dtantsuryou have to uninstall ironic completely indeed08:41
dtantsurNisha_Agarwal, ^^^08:41
*** makowals has quit IRC08:42
Nisha_Agarwaldtantsur, oh08:43
Nisha_Agarwalif i uninstal and install i dont need to restack, correct?08:43
*** tuanluong has joined #openstack-ironic08:43
Nisha_Agarwalor if i just remove old *.egg directories will resolve the issue08:43
Nisha_Agarwal?08:43
Nisha_Agarwaldtantsur, ^^^08:44
dtantsurNisha_Agarwal, start with 'sudo pip uninstall ironic', then manually remove if anything is left /usr/lib/python2.7/site-packages/08:44
Nisha_Agarwalk08:45
openstackgerritDmitry Tantsur proposed openstack/ironic-specs master: Remove Pike priorities that cannot make it due to recent team changes  https://review.openstack.org/46008608:45
Nisha_Agarwaldtantsur, i dont need to restack?08:45
Nisha_Agarwalcorrect08:45
Nisha_Agarwalits there in 8.0 version but ironic conductor is picking up old one08:46
dtantsurNisha_Agarwal, correct, I think you can avoid that08:46
Nisha_Agarwal:(08:46
Nisha_Agarwalok08:46
Nisha_Agarwaldtantsur, yes it worked...it uninstalled all old versions by itself08:48
Nisha_Agarwaldtantsur, thanks08:48
dtantsurnp08:48
*** jaosorior_away is now known as jaosorior08:49
Nisha_Agarwaldtantsur, milan had one comment on "Boot Management for inband-inspection" spec08:49
Nisha_Agarwali am not the expert in inspector08:50
Nisha_Agarwali need your advice08:50
Nisha_Agarwaldtantsur, could you help in that08:51
Nisha_Agarwalonly one comment outstanding in that spec08:51
*** e0ne has joined #openstack-ironic08:52
dtantsursure08:52
*** milan has joined #openstack-ironic08:56
Nisha_Agarwallucasagomes, when i create ironic node using redfish driver i get error as in http://paste.openstack.org/show/608294/08:57
Nisha_Agarwallucasagomes, any idea08:57
dtantsuroh09:00
dtantsurthis is why we need extensive logging09:00
lucasagomesNisha_Agarwal, hmm not off the top of my head09:00
lucasagomesfeels like programatic error tho09:00
dtantsurit certainly is09:01
dtantsurhuh, I cannot find any use of "find" call in the sushy driver09:02
dtantsurNisha_Agarwal, do you have up-to-date sushy?09:02
*** MattMan has quit IRC09:03
*** MattMan has joined #openstack-ironic09:03
dtantsurlucasagomes, speaking of vbmc, did you have a chance to check it's CI? I think it was down last time I saw it09:04
*** hamzy has joined #openstack-ironic09:04
milanmorning dtantsur, lucasagomes, Nisha_Agarwal! :)09:04
milanand morning Ironic! :)09:04
Nisha_Agarwaldtantsur, yes it is uptodaye09:04
lucasagomesdtantsur, I have not, the last weekes I've been mostly looking into ovn stuff09:04
Nisha_Agarwali tested latest sushy for power on and off it works on python shell09:05
Nisha_Agarwallucasagomes, ^^^09:05
lucasagomesdtantsur, I will take a look, Isee the patch is failing there09:06
dtantsurNisha_Agarwal, I'm afraid I don't have an easy answer then.. you may have to try inserting logs/prints in various parts of the code to see where exactly it dies09:06
Nisha_Agarwaldtantsur, hmmm09:07
Nisha_Agarwaldtantsur, it looks to me something in ironic :(09:07
lucasagomesNisha_Agarwal, what you get when you change the power state manually via ironic's api ?09:08
lucasagomesironic node-set-power-state blah on/off09:08
dtantsurI think so, I just could not find the relevant place by just looking at the code. also ++ to the question ^^^09:09
openstackgerritVasyl Saienko proposed openstack/ironic master: [Grenade]: Do not run ir-api on primary node after upgrade  https://review.openstack.org/45616609:09
Nisha_Agarwallucasagomes, i get 200 status09:09
lucasagomesNisha_Agarwal, so it works ?09:10
Nisha_Agarwalwer state (took 0.02 seconds) from (pid=24289) reserve_node /opt/stack/ironic/ironic/conductor/task_manager.py:27309:10
Nisha_Agarwal2017-04-28 02:37:16.891 DEBUG sushy.connector [req-1cb4d0c7-342d-40ef-8c4c-1d2af59c6af3 None None] Issuing a HTTP GET request at https://15.119.209.114/redfish/v1/ with the headers "{'Content-Type': 'application/json'}" and data "" from (pid=24289) _op /opt/stack/sushy/sushy/connector.py:6709:10
Nisha_Agarwal2017-04-28 02:37:17.535 DEBUG sushy.connector [req-1cb4d0c7-342d-40ef-8c4c-1d2af59c6af3 None None] Response: Status code: 200 from (pid=24289) _op /opt/stack/sushy/sushy/connector.py:7309:10
Nisha_Agarwal2017-04-28 02:37:17.586 DEBUG ironic.conductor.task_manager [req-1cb4d0c7-342d-40ef-8c4c-1d2af59c6af3 None None] Successfully released exclusive lock for changing node power state on node 9bf33085-4e2b-49c7-b48a-a9a4bc1e83c9 (lock was held 0.74 sec) from (pid=24289) release_resources /opt/stack/ironic/ironic/conductor/task_manager.py:35209:10
Nisha_Agarwalbut it fails for "sync_power_state"09:10
Nisha_Agarwalso no power state is registered for the node09:10
Nisha_Agarwallet me see it looks like some constant issue09:10
lucasagomesok, yeah i guess you will have to debug that09:11
Nisha_Agarwalyeah the node.last_error shows this " Failed to change power state to 'power off'. Error: 'int' object has no  attribute 'find'"09:12
lucasagomesyeah i would need to give it a go, I have no env here atm09:13
lucasagomesso I need to build one09:13
lucasagomesI don't see any find() in sushy or in the drivers/modules/redfish in ironic tho09:15
* lucasagomes wonders09:15
openstackgerritMerged openstack/ironic-inspector-specs master: Split service into API and Worker  https://review.openstack.org/43551709:21
dtantsuraarefiev, ^^^ \o/09:22
dtantsurlet's make it happen now :)09:22
aarefiev\o/, thanks09:23
aarefievthere is first patch with service functionality which I need to rebase09:24
*** mvpnitesh has joined #openstack-ironic09:24
dtantsuraarefiev, milan, a small patch we need to avoid getting broken by https://review.openstack.org/#/c/460062/: https://review.openstack.org/#/c/460216/09:24
patchbotpatch 460062 - openstack-dev/devstack - make USE_SCREEN=False imply USE_SYSTEMD=True09:24
patchbotpatch 460216 - ironic-inspector - [devstack] fix working with USE_SYSTEMD=True09:24
*** sambetts|afk is now known as sambetts09:31
*** jtomasek has quit IRC09:34
*** jtomasek has joined #openstack-ironic09:37
*** amarao has joined #openstack-ironic09:43
*** racedo has quit IRC09:52
*** paresh has joined #openstack-ironic09:58
*** udesale has joined #openstack-ironic09:58
* milan checking dtantsur patches09:58
*** jaosorior is now known as jaosorior_away10:00
pareshHi dtantsur10:02
pareshdtantsur Can you look into this patch https://review.openstack.org/#/c/454625/10:03
patchbotpatch 454625 - ironic - Change to avoid building of deploy iso when provided10:03
dtantsurnot now, but added to my list10:04
pareshdtantsur thanks10:04
*** tesseract has quit IRC10:04
*** paresh has quit IRC10:05
*** tesseract has joined #openstack-ironic10:08
openstackgerritDmitry Tantsur proposed openstack/ironic-inspector master: Remove redundant copy operation in pxe_enabled update code  https://review.openstack.org/46091910:14
openstackgerritMerged openstack/python-ironic-inspector-client master: Updated from global requirements  https://review.openstack.org/45913110:16
openstackgerritMilan Kováčik proposed openstack/ironic-inspector master: Allow timeout in active states  https://review.openstack.org/46069010:17
*** chas has quit IRC10:18
*** Fdaisuke has joined #openstack-ironic10:27
*** phuongnh has quit IRC10:31
openstackgerritMilan Kováčik proposed openstack/ironic-inspector master: Bump pydot2 to pydot3  https://review.openstack.org/46093810:39
*** jkilpatr has quit IRC10:42
* milan errands and Monday is a public holiday here; CU guys on Tuesday! Unless you're on hewbrocca 's party tonight! :P10:42
openstackgerritYuriy Zveryanskyy proposed openstack/ironic master: Validate outlet index in SNMP driver  https://review.openstack.org/45271610:42
*** karthiks has quit IRC10:43
*** mat128 has joined #openstack-ironic10:44
*** vmud213 has joined #openstack-ironic10:46
*** paresh has joined #openstack-ironic10:47
*** milan has quit IRC10:47
*** sao_p has joined #openstack-ironic10:50
*** paresh has quit IRC10:50
*** sao_p has quit IRC10:51
*** tuanluong has quit IRC10:52
*** udesale__ has joined #openstack-ironic10:54
*** udesale has quit IRC10:56
openstackgerritVasyl Saienko proposed openstack/ironic master: [Grenade]: Do not run ir-api on primary node after upgrade  https://review.openstack.org/45616610:59
openstackgerritAnton Arefiev proposed openstack/ironic-inspector master: Fix `clean up` error logging formatting  https://review.openstack.org/46098911:07
*** makowals has joined #openstack-ironic11:09
*** makowals has quit IRC11:10
dtantsurlucasagomes, hey! two suggestions for the redfish driver, wdyt about: 1. allowing missing scheme (assume https), 2. allowing separate redfish_port?11:10
dtantsurthis would bring it much closer to other drivers, where xxx_address is a host name or IP11:11
*** jkilpatr has joined #openstack-ironic11:11
lucasagomesdtantsur, I like 1. it's secure by default11:12
lucasagomeswe need to change some validations for that, I think that for now we require one to add the schema as part of the address11:12
dtantsurI can do that, if you don't object11:12
lucasagomes2. hmm it's a little strange based on the format of the address11:12
lucasagomesdtantsur, I'm ok with it, I mean no objections11:13
dtantsurlucasagomes, yeah.. we do accept client_port for ilo11:13
lucasagomesyeah or ipmi/drac as well11:13
*** l_jacob has quit IRC11:13
dtantsurand irmc has it configured in ironic.conf Oo11:13
* dtantsur cries11:13
lucasagomeshah11:14
lucasagomesone thing tho, we should probably look at unifying such crendentials11:14
dtantsurall this would not be a problem if tripleo did not require hardcoding it....11:14
lucasagomesinstead of having them in the namespace of the drivers11:14
lucasagomesthat way we can guarantee some consistency between all driver11:14
lucasagomesdrivers*11:14
lucasagomesdtantsur, *sigh* re OOO11:14
dtantsurok, let me do #1, and #2 can go to tripleo itself11:15
*** makowals has joined #openstack-ironic11:17
lucasagomes++11:19
*** Nisha_Agarwal has quit IRC11:20
*** Nisha_Agarwal has joined #openstack-ironic11:21
*** Lambert has quit IRC11:21
*** avladu has joined #openstack-ironic11:22
sambetts+1000 to standardising the driver properties11:25
jkilpatrd0ugal, those patches ready to test?11:26
jkilpatrumm it might help if I knew how to apply them in my job....11:26
jkilpatrAnyways I have a 30 node ovb test cloud we can apply them to and get feedback at least daily.11:27
dtantsurjkilpatr, wrong channel or am I missing something? :)11:29
*** gkadam has quit IRC11:29
jkilpatrdtantsur, https://review.openstack.org/#/c/439568/11:29
patchbotpatch 439568 - tripleo-common - Run introspection 20 nodes at a time11:29
jkilpatrso I guess that's not a ironic patch exactly?11:30
jkilpatr¯\_(ツ)_/¯11:30
dtantsurjkilpatr, not entirely :) though I'd love some scale testing on it11:31
jkilpatrdtantsur, that's the idea behind this job, daily scale builds, if mainline isn't passing it's a place to test patchsets11:31
jkilpatrrather than "oh well lets wait until we have someone with hardware and spare time"11:32
dtantsurnice11:34
*** chas has joined #openstack-ironic11:40
*** racedo has joined #openstack-ironic11:42
*** chas has quit IRC11:45
*** Serlex has quit IRC11:45
*** xavierr has joined #openstack-ironic11:47
openstackgerritAparna proposed openstack/proliantutils master: Performs IPA erase_devices after Sanitize disk erase  https://review.openstack.org/43645011:49
*** tesseract has quit IRC11:50
*** chas has joined #openstack-ironic11:50
*** mvpnitesh has quit IRC11:51
*** mvpnitesh has joined #openstack-ironic11:54
dtantsurlucasagomes, oh fun. the library we use parse example.com:8080 as scheme example.com and authority 8080 >_<11:55
*** bfournie has quit IRC11:55
*** ccamacho is now known as ccamacho|lunch11:57
openstackgerritMerged openstack/ironic-inspector master: [devstack] fix working with USE_SYSTEMD=True  https://review.openstack.org/46021611:58
*** galyna has left #openstack-ironic11:58
*** Nisha_Agarwal has quit IRC12:02
*** d0ugal_ has joined #openstack-ironic12:02
*** zhenguo has quit IRC12:02
*** xavierr has quit IRC12:03
*** d0ugal has quit IRC12:04
*** tesseract has joined #openstack-ironic12:05
openstackgerritDao Cong Tien proposed openstack/python-ironicclient master: Extends driver-list, driver-show supporting new hardware types  https://review.openstack.org/41927412:06
openstackgerritDmitry Tantsur proposed openstack/ironic master: Bring the redfish driver address parameter closer to one of other drivers  https://review.openstack.org/46100812:07
dtantsurlucasagomes, ^^^12:07
lucasagomesdtantsur, lol12:10
*** g3ek has quit IRC12:10
openstackgerritAparna proposed openstack/ironic master: Support hpsum based `update_firmware` for iLO drivers  https://review.openstack.org/42257212:10
lucasagomesdtantsur, will take a look12:10
lucasagomes /me goes grab some food quickly and then will look at it12:11
*** lucasagomes is now known as lucas-hungry12:11
*** dprince has joined #openstack-ironic12:11
*** tiendc has quit IRC12:12
TheJuliaGood morning everyone12:15
dtantsurmorning TheJulia12:16
jrollmorning TheJulia, dtantsur, everyone else12:16
dtantsurand jroll :)12:16
jroll:)12:16
*** chlong has quit IRC12:21
*** d0ugal_ is now known as d0ugal12:21
d0ugaljkilpatr: I can help test in about an hour if that works for you? sorry, things a bit hectic here.12:21
*** d0ugal is now known as Guest804912:21
*** Guest8049 has quit IRC12:21
jkilpatrd0ugal, don't worry the job only run's once a day anyways, we have all day to set it up.12:22
jkilpatrruns*12:22
*** d0ugal_ has joined #openstack-ironic12:22
d0ugal_jkilpatr: I've not managed to do as much as I'd like this week - had issues with my own setup, but it should be ready to test, in theory :)12:22
d0ugal_back shortly12:22
*** bcornec has joined #openstack-ironic12:24
*** bfournie has joined #openstack-ironic12:25
openstackgerritGalyna Zholtkevych proposed openstack/ironic-ui master: Add node filtering by chassis uuid  https://review.openstack.org/46101512:29
TheJuliamgoddard: Hey, I was looking at https://review.openstack.org/#/c/460005.  Are you planning on putting together an overall documentation update once all of the pieces are together12:31
patchbotpatch 460005 - bifrost - Support storage of introspection data in Nginx12:31
TheJulia(personally, I'd be very +2 on landing defaults to collect introspection data for lldp data....)12:31
dtantsurmgoddard, TheJulia, I'm quite meh on this patch. Why not add an option to store data locally to ironic-inspector instead?12:33
TheJuliaFastest path to functional as opposed to waiting for an inspector release?12:33
TheJuliaand it would be backwards compatible12:34
dtantsurwell.. fast != best :) anyway, not going to -1 it, just a bit sad that's bifrost-specific12:34
TheJuliaNot saying inspector should not have that feature though :)12:34
TheJuliaMore bifrost being attune to the present capabilities/defaults of the world around it.  :)12:35
*** aparnav has quit IRC12:38
*** gcb has quit IRC12:40
*** trown|outtypewww is now known as trown12:40
*** fragatina has quit IRC12:40
*** fragatina has joined #openstack-ironic12:41
*** Nisha_Agarwal has joined #openstack-ironic12:44
*** rbudden has joined #openstack-ironic12:48
mgoddardTheJulia: hi, I can put some docs together for it but currently the bifrost docs don't mention inspector at all so I'd be starting from nothing (related: https://bugs.launchpad.net/bifrost/+bug/1554141)12:52
openstackLaunchpad bug 1554141 in bifrost "Documentation of inspector usage lacking" [High,Confirmed]12:52
mgoddardTheJulia, dtantsur: agree that local inspector storage might be a better option. The nginx route went from an idea to a local implementation so thought I'd share it12:54
TheJuliaIt definitely meets my "Is this useful?" bar :)12:56
mgoddardTheJulia: slight -1 against always collecting LLDP is that it incurs a 30 second timeout each time we check for LLDP data (which seems to be more than once for some reason, but that's a separate issue)12:57
TheJuliaAhh, I didn't know that.  That makes sense then12:57
sambettsmgoddard: I think I worked out why it does it more than once12:58
*** mat128 has quit IRC12:58
TheJuliamgoddard: with regards to docs, That raises a good point.  I guess when I added inspector I thought users just likely already know how to use it and that was a mistake on my part :(12:58
sambettsmgoddard: its because inspector calls the IPA inventory functions in a loop to wait for the interfaces to be up12:58
mgoddarddtantsur: one issue with local storage is that it won't scale to >1 inspector12:59
*** mvpnitesh has quit IRC12:59
sambettsmgoddard: its possible to scale it using an NFS mount to all the hosts running inspector12:59
mgoddardsambetts: true, but you might as well deploy swift at that point :)13:00
TheJuliaheh13:00
*** mat128 has joined #openstack-ironic13:00
dtantsurmgoddard, hmm, does this nginx approach scale?13:00
* dtantsur did not look in depth13:00
*** mvpnitesh has joined #openstack-ironic13:01
mgoddarddtantsur: It scales to >1 inspectors, but not >1 nginx13:01
TheJuliaThere would need to be underlying configuration13:01
TheJuliasuch as an NFS volume supporting /httpboot13:01
dtantsurwell, this does sound like an NFS share + local storage13:01
*** vmud213 has quit IRC13:02
mgoddarddtantsur: I'm not sure it's something you'd do in production anyway as there's no authentication13:02
*** Goneri has joined #openstack-ironic13:04
mgoddardsambetts: I only noticed the multiple LLDP passes because I failed to collect LLDP recently and noticed that it had 2 passes, succeeded once (during wait_for_interface / dhcp / something?) then failed when actually collecting the inventory13:04
openstackgerritVasyl Saienko proposed openstack/ironic master: Test rolling upgrades  https://review.openstack.org/45874813:04
mgoddardsambetts: likely because my ipa lldp collection timeout == switch lldp transmit interval (30 seconds)13:04
*** jcoufal has joined #openstack-ironic13:04
mgoddardsambetts: although that is the default on both sides so may occasionally hit others13:05
sambettsmgoddard: there is glitchy logic in IPA regarding NICs being down etc too I have been slowly putting together a patch for it here https://review.openstack.org/#/c/434385/13:06
patchbotpatch 434385 - ironic-python-agent - [LLDP] Skip NICs that say they are ready but are u...13:06
sambettsmgoddard: but its by no means perfect yet13:07
*** sasha2 has joined #openstack-ironic13:07
*** udesale__ has quit IRC13:07
*** ccamacho|lunch is now known as ccamacho13:07
*** lucas-hungry is now known as lucasagomes13:08
mgoddardsambetts: I'll take a look13:09
*** rpioso has joined #openstack-ironic13:10
* TheJulia wonders where her intel nuc ran off to13:12
mgoddardTheJulia: back to docs, one key thing that's missing is an env-vars file that works for inspector or at least instructions on which environment variables to set. I'm using OS_TOKEN and OS_URL13:14
mgoddardTheJulia: you're right in that it shouldn't duplicate the inspector docs but could at least say how to access it13:15
TheJuliaWell, OS_CLOUD would be easier for most users I think13:16
TheJuliasince we are all moving to the osc cli13:16
*** jaypipes is now known as leakypipes13:16
TheJulialeakypipes: have you tried duct tape?13:17
* TheJulia ducks13:17
leakypipesTheJulia: unfortunately, yes :)13:17
leakypipesTheJulia: it's this DAMN Florida water.13:18
mgoddardTheJulia: perhaps, although I generally don't use it. How does that work in an environment without keystone with multiple endpoints (ironic & inspector)?13:18
leakypipes;)13:18
TheJuliamgoddard: well, essentially the same way that env-vars uses, however osc seems super unfriendly to that path.  using clouds.yaml a user could still define a "cloud" with the individual resources and select the one they want.  Or.... they could re-run install and turn on keystone.13:20
* TheJulia takes the nuc with far too many cables hanging off of it into the back room to build a fresh install.13:22
*** mvpnitesh has quit IRC13:24
mgoddardTheJulia: I see, multiple clouds. I suppose in an keystone-less environment bifrost could generate a clouds.yml as well as/instead of env-vars13:26
*** d0ugal_ has quit IRC13:26
*** d0ugal has joined #openstack-ironic13:27
*** d0ugal has quit IRC13:27
*** d0ugal has joined #openstack-ironic13:27
*** bcornec has quit IRC13:30
*** mvpnitesh has joined #openstack-ironic13:30
TheJuliamgoddard: yup, I think we already have a role for writing the file, I think the pertinent data needs to be passed in13:32
mgoddardTheJulia: oh ok, missed that. I'll take a look13:32
TheJuliamgoddard: locally, I've been using keystone as of recent, but I've been mucking with neutron integration, so otherwise I'd go crazy13:33
*** mvpnitesh has quit IRC13:37
*** xavierr has joined #openstack-ironic13:37
*** mvpnitesh has joined #openstack-ironic13:37
mgoddardTheJulia: makes sense.13:38
*** adisky_ has quit IRC13:39
TheJulias/crazy/more crazy/13:39
*** srobert has joined #openstack-ironic13:43
openstackgerritGalyna Zholtkevych proposed openstack/ironic master: Handle some ironic inspector HTTP 500 errors  https://review.openstack.org/46103613:44
*** mat128 has quit IRC13:45
*** jcoufal_ has joined #openstack-ironic13:48
*** jcoufal has quit IRC13:50
*** l_jacob has joined #openstack-ironic13:50
*** chlong has joined #openstack-ironic13:53
openstackgerritM V P Nitesh proposed openstack/ironic master: Allow setting {provisioning,cleaning}_network in node driver_info  https://review.openstack.org/46056413:53
*** l_jacob has quit IRC13:58
*** mvpnitesh has quit IRC13:58
*** baoli has joined #openstack-ironic13:59
*** makowals has quit IRC14:01
*** crushil has joined #openstack-ironic14:01
*** chlong has quit IRC14:07
*** Serlex has joined #openstack-ironic14:10
*** jaosorior_away has quit IRC14:10
TheJuliaNote to self, never copy huge set of disk images over wifi again :(14:12
sambetts:(14:14
*** baha has joined #openstack-ironic14:18
*** aarefiev is now known as aarefiev_afk14:19
NobodyCamGood Morning Ironic'ers ... and ...14:20
NobodyCamTGIF!14:20
*** chlong has joined #openstack-ironic14:20
*** gcb has joined #openstack-ironic14:24
TheJuliaGood morning NobodyCam14:25
dtantsurmorning NobodyCam14:25
NobodyCamGood Morning TheJulia & dtantsur happy friday.14:25
dtantsurindeed :)14:26
NobodyCam:)14:26
*** causten has joined #openstack-ironic14:43
*** gcb has quit IRC14:48
*** gcb has joined #openstack-ironic14:49
*** dprince has quit IRC14:53
*** amarao has quit IRC14:55
*** bnemec is now known as beekneemech14:59
*** aarefiev_afk has quit IRC14:59
*** dprince has joined #openstack-ironic15:06
lucasagomesdtantsur, +a the redfish patch15:07
dtantsurnice, thanks!15:09
*** dfisher has joined #openstack-ironic15:14
dfishergood morning!  I've been working on getting devstack + Ironic up and running and was hitting all kinds of issues on Oracle Linux 7.3 with just getting the plugin packages installed.  I had to edit ironic/devstack/files/rpms/ironic and change docker-io to docker.io (like in debs/ironic) to get devstack to proceed.15:15
dfisheris this a known issue?15:16
*** openstackgerrit has quit IRC15:17
TheJuliado the package names just differ between Centos/EPEL/Fedora and Oracle Linux?15:18
dfisherI'm honestly unsure how to check :(  I'm actually a solaris guy!15:18
dfisheri know, there's like … 3 of us!15:18
* TheJulia looks it up15:18
JayFDoes anyone know of a good trick to bulk-unsubscribe from gerrit emails? :/15:18
JayFgood morning :)15:19
TheJuliadfisher: docker-io is the package name in fedora, although it looks like it is deprecated/outdated15:20
TheJuliaJayF: Did you change your settings in gerrit?15:20
dfisherTheJulia: where did you search for that (so I can do all the digging on my own next time)15:20
JayFTheJulia: oh, is there a setting to disable emails?15:20
TheJuliaeh, notifiation preferences if memory serves15:20
JayFTheJulia: I'd probably prefer to unsub from all things I'm listed as a reviewer on, so if I post one in the future I'd still get notifies15:20
JayFbut that should qualify as Good Enough(tm)15:21
TheJuliaJayF: *nods*15:21
TheJuliadfisher: https://admin.fedoraproject.org/pkgdb/package/rpms/docker-io/15:21
* TheJulia sighs15:21
dfisherso, it looks like it was simply renamed to 'docker' ?15:21
mariojvdtantsur: hi, i left a comment on https://review.openstack.org/#/c/460086/ - please do feel free to remove my name from priorities15:24
patchbotpatch 460086 - ironic-specs - Remove Pike priorities that cannot make it due to ...15:24
mariojvi will send out an official goodbye to mailing list later today15:24
mariojvhappy to answer any questions about existing work for whomever picks it up though15:24
JayFAs a note: when we get our official ironic bear stickers15:25
JayFsomeone had damn well better mail me a half dozen ;)15:25
dtantsur:)15:26
TheJuliadfisher: so ubuntu has a docker and docker.io, so I'm really not sure what the difference is off-hand15:26
dfisherbut ubuntu/debian stuff is in files/debs/ironic15:26
dfisherright?15:26
TheJuliaJayF: note taken :)15:26
*** pcaruana has quit IRC15:28
TheJuliadfisher: indeed, dependencies are likely expanding.  I'd have to dig into the dependencies and all15:29
dfisherso, i don't think we should worry about debs.15:29
dfisherprobably just need to look at centos/fedora/other rpm things15:29
*** Linkmark has quit IRC15:30
dtantsurmariojv, thanks for update!15:30
dtantsurand good luck :)15:30
TheJuliadfisher: search for docker and docker-io on rpmfind15:31
dfisherFound 154 RPM for docker15:31
dfisherugh.15:31
*** openstackgerrit has joined #openstack-ironic15:31
openstackgerritDmitry Tantsur proposed openstack/ironic-specs master: Remove Pike priorities that cannot make it due to recent team changes  https://review.openstack.org/46008615:31
dtantsurnew update ^^^ please review15:31
dfisher0 for docker.io, 2 for docker-io15:31
dfisherdocker-io is EL 6 only though15:32
*** chlong has quit IRC15:34
openstackgerritGalyna Zholtkevych proposed openstack/ironic master: Handle some ironic inspector HTTP 500 errors  https://review.openstack.org/46103615:35
TheJuliadfisher: yay for inconsistent package naming \o/15:35
dfisheryay!15:36
* TheJulia fires up bifrost's install playbook on the computer normally attached to the TV... for reasons.15:37
*** WeiAA has quit IRC15:38
*** yolanda has joined #openstack-ironic15:43
*** ipukha has quit IRC15:45
*** vinsh has quit IRC15:48
*** g3ek has joined #openstack-ironic16:04
*** avladu has quit IRC16:04
*** trown is now known as trown|lunch16:07
*** racedo has quit IRC16:10
*** athomas has quit IRC16:11
*** derekh has quit IRC16:15
*** chlong has joined #openstack-ironic16:16
*** jcoufal has joined #openstack-ironic16:20
dtantsurremoving 2 cores in one day is a sad feeling :( especially when you know that you have to remove 1 or 2 more soon16:20
dtantsurchanging the PTL did not bring you luck, I need to say16:21
*** jcoufal__ has joined #openstack-ironic16:22
*** jcoufal_ has quit IRC16:22
*** jcoufal has quit IRC16:24
*** baha has quit IRC16:32
*** jcoufal has joined #openstack-ironic16:33
*** jcoufal__ has quit IRC16:34
JayFTheJulia: I couldn't find an option in gerrit to disable notifications16:35
TheJuliaJayF: I thought you could do it on a repo level16:38
JayFIf you watch a repo, yes, but apparently it's not trivial to unsub from the actual patchsets16:39
JayFsee -infra16:39
TheJulia:(16:39
dtantsurNearly beer'o'clock for me. It's a public holiday on Monday, but I may show up for the meeting. If not - please have it anyway :)16:44
dtantsurSee you next week, and have a great weekend!16:44
*** dtantsur is now known as dtantsur|afk16:45
*** tesseract has quit IRC16:45
*** jcoufal_ has joined #openstack-ironic16:47
*** ildikov is now known as coffee_cat16:47
*** jcoufal has quit IRC16:50
openstackgerritMerged openstack/ironic master: Bring the redfish driver address parameter closer to one of other drivers  https://review.openstack.org/46100816:51
*** lucasagomes is now known as lucas-afk16:54
*** ijw has joined #openstack-ironic16:54
jristhey my dudes16:55
jristcan we get some eyes on https://review.openstack.org/#/c/460353/ plz16:55
patchbotpatch 460353 - ironic - Properly allow Ironic headers in REST API16:55
jristit is effecting UI16:55
*** ijw has quit IRC16:56
*** ijw has joined #openstack-ironic16:56
*** baha has joined #openstack-ironic17:01
*** ijw has quit IRC17:01
*** trown|lunch is now known as trown17:02
*** Sukhdev has joined #openstack-ironic17:05
*** harlowja has quit IRC17:06
*** jcoufal has joined #openstack-ironic17:07
*** e0ne has quit IRC17:08
*** jcoufal_ has quit IRC17:09
*** ChubYann has joined #openstack-ironic17:23
*** gcb has quit IRC17:24
*** amotoki has quit IRC17:25
*** persia has quit IRC17:30
*** ijw has joined #openstack-ironic17:37
TheJuliadtantsur|afk: 10-4, Thank you and have a wonderful weekend!17:38
*** ijw has quit IRC17:42
*** sambetts is now known as sambetts|afk17:47
sambetts|afkNight all17:47
TheJuliagoodnight sambetts|afk17:48
anupnHi Ironic'ers, any idea how to access the json data sent in POST request? I am trying to access the data sent in request body using pecan while creating port via POST. Right now we pass "body=Port" and so we are getting the fields exposed in init17:49
TheJuliaanupn: I thought that is only a put in ironic's api17:51
* TheJulia might be totally wrong though17:51
anupnHi TheJulia, no POST also use body=Port17:52
anupnTheJulia, this is wrt my patch https://review.openstack.org/#/c/405586/ in which i want to check if node_name and node_uuid are both passed in the request it should throw error17:53
patchbotpatch 405586 - ironic - Allow logical name in port creation17:53
anupnTheJulia, we get the data in args but for that args need to be passed "body=args"17:54
*** causten has quit IRC17:56
*** e0ne has joined #openstack-ironic17:57
*** causten has joined #openstack-ironic17:58
TheJuliaHmm, yeah, it is a post, for some reason I was thinking it was a put18:01
*** trown is now known as trown|brb18:02
anupnTheJulia, any way you think i can access the data keeping body=Port as is?18:03
Nisha_AgarwalJayF, hi18:03
JayFo/18:04
Nisha_AgarwalJayF, i wanted to know the status of python 3.5 compatibility work18:04
JayFThere was zero done on my end18:04
Nisha_Agarwalmeans from where should i pick it up18:04
Nisha_Agarwalso its not even started?18:04
JayFI was told we have a py35 job running in experimental, but I think there was a concern it wasn't actually running py3518:04
JayFyep, none of that work has begun at all18:04
Nisha_AgarwalOk so ideally we want to get that done for ironic module, correct?18:05
Nisha_Agarwalor its scope is bigger than that?18:05
JayFThe scope of the work is up to the remaining team, but it's an OpenStack priority.18:05
*** ijw has joined #openstack-ironic18:05
Nisha_AgarwalJayF, :)18:05
JayFMy exact goal was a voting dsvm job running py3518:05
JayFwhich would mean the client, and ironic would work18:05
JayFno idea about if we want to include IPA (should just work out of the box) and/or inspector18:05
Nisha_AgarwalJayF, ok18:06
Nisha_Agarwali think we would need to include IPA and ironic-lib atleast18:06
Nisha_Agarwalinspector i am not so sure18:06
*** yolanda has quit IRC18:07
Nisha_Agarwalbut once we start on this, it should be possible to do for inspector also i guess18:07
JayFYeah, like I said, you all get to decide what that means now. I probably would've considered inspector a 'nice to have' item18:07
Nisha_AgarwalJayF, :)18:07
JayFbut it may be as simple as enabling the dsvm job and watching it pass, once the prerequisites for ironic are done18:07
Nisha_Agarwalok. i read in mail you would be still available on IRC. How long is that expected? :)18:08
Nisha_Agarwalactually i am on FTO from May5-May22, so asking in case i need any help later will you be still there after May2218:09
Nisha_AgarwalJayF, i had one query on rescue also18:10
JayFI'm going to be on freenode IRC for either my or freenode's lifetime, I suspect :P18:11
Nisha_Agarwal:)18:11
JayFI have no intentions of leaving here, but won't be available for more than a couple of quick questions occassionally18:11
*** ijw has quit IRC18:11
JayFand the TTL on my memory is pretty awful  as well, haha18:11
Nisha_Agarwal:)18:12
Nisha_AgarwalJayF, how much work is left on rescue side? Is there anything which is not raised yet? As i understand from aparnav all the patches are raised and just review comments need to be addressed18:13
Nisha_Agarwalis my understanding correct?18:13
JayFmariojv would be more up to date on that as I was on vacation before I stopped working on Ironic18:13
Nisha_Agarwal:)18:14
JayFbut AIUI it needed CI completed and workign18:14
JayFand the agent support for static networking is 100% undone18:14
JayFso the part that is working is limited to DHCP networks.18:14
Nisha_Agarwalok agent part was unknown to me18:14
Nisha_AgarwalCi is the target for us also18:14
Nisha_Agarwal:)18:15
Nisha_AgarwalNova side work is started?18:15
anupnNisha_Agarwal, I have some notes collected for static networking for agent, if you want I can update it clean :)18:15
Nisha_Agarwalfor rescue18:15
JayFthe nova patch is pretty close to done18:15
JayFyeah, anupn is a good person to chat with as well18:15
JayFhe knows what's up with rescue too18:15
JayFanupn: you going to continue working on Ironic?18:15
JayFactually I think the nova patch, in order to work "properly"18:16
anupnJayF, :) Yup but not sure how much on rescue18:16
JayFhas to land after the client work is done18:16
*** yolanda has joined #openstack-ironic18:16
JayFwith a bump to the ironicclient version with the rescue support18:16
Nisha_Agarwalanupn, thanks. I would ask aparnav/stendulker to contact you. I am just taking update to understand how much is done and how much is left18:16
JayFIf I were you, I'd focus 100% on the ironic side, including client, until that's done. Then worry about nova.18:16
JayFNova won't land it until all the ironic work is done anyway.18:16
Nisha_AgarwalJayF, :) ok18:17
anupnJayF, if someone is taking up other patches, i can look into tempest patches, I volunteered for that in upstream meeting :)18:18
anupnNisha_Agarwal, sure18:18
JayFanupn: it seems like Nisha_Agarwal is taking it over, she'd probably appreciate the help -- plus you can share some of the etherpad notes we all used to give a good handoff on the rescue work18:18
*** vinsh has joined #openstack-ironic18:18
Nisha_AgarwalJayF, anupn that would be great18:19
*** dprince has quit IRC18:19
anupnNisha_Agarwal, JayF, yeah. Will clean up the etherpad with some detailed steps and hover you Nisha_Agarwal18:19
Nisha_Agarwalanupn, thanks18:20
mariojvyes, tempest still needs to pass18:20
mariojvtests are up but not passing yet18:20
mariojvanupn was working on it, but it seems y'all already know that18:20
anupnNisha_Agarwal, it would be good to check with dtantsur|afk as someone has been signed up for rescue18:20
anupnin virtual meetup that happened18:21
anupnNisha_Agarwal, also if you are gonna take it over may be it can be brought in the priorities18:22
Nisha_Agarwalanupn, wanyen signed up for rescue and now stendulker/aparnav going to take care of it. We all work in single team18:22
anupnNisha_Agarwal, ah i see18:22
anupnNisha_Agarwal, cool18:23
Nisha_Agarwalanupn, :)18:23
Nisha_Agarwalanupn, it would help if you can share the notes for rescue18:23
Nisha_Agarwalwhen you are done with updating them18:24
anupnNisha_Agarwal, yes :)18:25
Nisha_Agarwalanupn, thanks :)18:25
anupnNisha_Agarwal, np18:25
TheJuliaanupn: I might be misunderstanding what your trying to do, but pdict in post() under the port controller seems to be what you want.  FWIW, it seems like the uuid should always take precedence18:26
*** vinsh has quit IRC18:28
*** trown|brb is now known as trown18:29
anupnTheJulia, pdict will give me all that is exposed in init(), that includes both node_name and node_uuid. Is it always that we give uuid a precedence?18:31
TheJuliaanupn: my $0.02 is that we should, although that could also be considered a bug.18:34
anupnTheJulia, :) just concerned as there should not be a conflict and also was asked on my patch set to take care of that, so if uuid is always a priority which I believe should be then i will include that in reno or commit msg18:34
TheJuliaThen it makes sense that you do so18:35
TheJuliaanupn: if the values are there, from init, what if you check to see if the value has a length in the dictionary?18:36
*** harlowja has joined #openstack-ironic18:38
anupnTheJulia, but init() will fetch both corresponding values even if either node_uuid or  node_name are passed because we are appending the fields before calling setattr from init()18:39
anupnTheJulia, https://review.openstack.org/#/c/405586/22/ironic/api/controllers/v1/port.py@19318:40
patchbotpatch 405586 - ironic - Allow logical name in port creation18:40
anupnTheJulia, so length of that field will not be zero18:40
TheJuliathe length of the node_name in the posted dictionary?18:41
TheJuliathe value that is18:42
anupnTheJulia, yes the value of node_name would be correct node name value in the pdict that we get18:42
anupnTheJulia, you meant pdict, if i am not wrong?18:43
TheJuliawell, pdict is a dictionary of post data, so yes :)18:44
anupnTheJulia, haha, sometimes the names get misleading so confirmed :)18:45
anupnTheJulia, I am trying to see if I can make use of pecan.request object but I don't find the method to access the json data sent18:46
TheJuliaSadly no, your going to get the slightly re-parsed data passed in via pecan, hence why I'm thinking just check the length of the data to see if any data was actually posted, since "" could have been sent along.18:49
*** ijw has joined #openstack-ironic18:51
*** rbartal has joined #openstack-ironic18:52
*** causten has quit IRC18:52
anupnTheJulia, I see, but in pdict i get node_uuid, node_name, address and node_id with correct values and no empty value for node_name18:55
TheJuliaso if your not submitting node_name, is the value being populated for you by pecan?18:56
anupnTheJulia, no in request say I passed node_uuid but then a call to "port.as_dict()" will also call setters for all the fields that are added in self.fields and in my init() i am adding node_name as well in self.fields18:58
*** e0ne has quit IRC18:58
*** causten has joined #openstack-ironic18:59
*** xavierr has quit IRC19:02
*** Goneri has quit IRC19:03
TheJuliaSo you'll never know if it is actually sent, but if there is a value perhaps?19:04
anupnyes, and hence want to access data that is actually sent and not use pdict. Atleast to know whether both are sent or not19:05
anupnlike as done for PATCH we are using PortPatchType that gives exact data sent in the request19:06
TheJuliaSo assuming we can't do the exact thing that was asked short of refactoring the entire post logic, what do you see as the shortest path to resolution?19:09
*** rbartal has quit IRC19:10
anupnTheJulia, I think what i can do is pass args to body, body=args and the where we are getting pdict, change it to "pdict=Port.as_dict()"19:13
anupn*and where19:14
TheJuliaIf that works19:15
TheJuliaI'm not sure it is going to work, but I've largely avoided the API code19:16
jrollTheJulia: good decision :P19:19
TheJuliajroll: It was the "There be dragons!" sign19:20
jrollheh19:20
anupnTheJulia, the more shorter is mention in reno that node_uuid will be a priority, lol19:22
* anupn joking19:22
anupnjroll, hehe19:22
TheJuliaanupn: so how might you have the desired behavior when you will always have keys provided to the post method?19:27
*** Nisha_Agarwal has quit IRC19:29
anupnTheJulia, actually i am thinking to make a change in init method, right now setattr inside init() fetch values from kwargs passed to init and kwargs should not have node_name as it is not passed in the POST request body I am digging how kwargs is getting node_name19:31
*** kjw3 has joined #openstack-ironic19:32
*** g3ek has quit IRC19:33
*** chas has quit IRC19:34
*** ijw has quit IRC19:39
*** g3ek has joined #openstack-ironic19:40
*** Serlex has quit IRC19:41
*** ijw has joined #openstack-ironic19:41
*** ijw has quit IRC19:47
*** chas has joined #openstack-ironic19:54
anupnTheJulia, Ah i figured out, in set_node_uuid we are also setting node_name to avoid multiple db access. And hence even if you pass only node_uuid in request we get correct value for node_name in pdict19:57
anupnTheJulia, let me make a change there, and then pdict will not have node_name :)19:58
*** chas has quit IRC19:59
*** jcoufal_ has joined #openstack-ironic20:02
*** jcoufal has quit IRC20:05
jlvillal jroll Do you know the status of the Ironic Neutron meeting? Does it happen anymore?20:10
TheJuliajlvillal: afaik, no20:11
jlvillalTheJulia, That is what I thought.20:11
TheJuliaThe slot, though, is still reserved20:11
jrollit does not20:11
jlvillaljroll, Thanks20:12
jrollnp20:13
*** chas has joined #openstack-ironic20:15
*** kjw3 has quit IRC20:16
*** morgabra has left #openstack-ironic20:17
*** causten has quit IRC20:18
*** causten has joined #openstack-ironic20:18
*** crushil has quit IRC20:18
*** crushil has joined #openstack-ironic20:19
*** chas has quit IRC20:20
*** jcoufal has joined #openstack-ironic20:22
*** causten has quit IRC20:22
*** jcoufal_ has quit IRC20:23
*** bfournie has quit IRC20:27
*** causten has joined #openstack-ironic20:28
*** mgoddard has quit IRC20:36
*** chas has joined #openstack-ironic20:36
*** chas has quit IRC20:41
*** ijw has joined #openstack-ironic20:43
*** causten has quit IRC20:47
*** jcoufal_ has joined #openstack-ironic20:49
*** jcoufal has quit IRC20:50
*** ijw has quit IRC20:51
*** causten has joined #openstack-ironic20:51
*** crushil has quit IRC20:56
*** chas has joined #openstack-ironic20:57
*** rpioso has quit IRC21:00
*** chas has quit IRC21:01
*** Sukhdev has quit IRC21:03
*** jcoufal has joined #openstack-ironic21:04
*** jcoufal_ has quit IRC21:05
*** dfisher has quit IRC21:09
*** ijw has joined #openstack-ironic21:09
*** trown is now known as trown|outtypewww21:10
*** ijw has quit IRC21:10
*** ijw has joined #openstack-ironic21:10
*** crushil has joined #openstack-ironic21:11
*** Goneri has joined #openstack-ironic21:13
*** harlowja has quit IRC21:17
*** harlowja has joined #openstack-ironic21:17
*** chas has joined #openstack-ironic21:18
*** ijw has quit IRC21:20
*** chas has quit IRC21:23
jristthanks TheJulia21:23
*** srobert has quit IRC21:27
*** jlvillal has left #openstack-ironic21:30
*** jlvillal has joined #openstack-ironic21:30
*** baha1 has joined #openstack-ironic21:30
*** crushil has quit IRC21:32
*** baha has quit IRC21:33
*** ijw has joined #openstack-ironic21:34
*** ijw has quit IRC21:34
*** ijw has joined #openstack-ironic21:34
*** baha1 has quit IRC21:35
*** harlowja has quit IRC21:36
*** rpioso has joined #openstack-ironic21:36
*** bfournie has joined #openstack-ironic21:37
*** chlong has quit IRC21:39
*** chas has joined #openstack-ironic21:39
*** fragatin_ has joined #openstack-ironic21:41
*** fragatina has quit IRC21:43
*** chas has quit IRC21:43
*** causten has quit IRC21:43
*** causten has joined #openstack-ironic21:44
*** causten has quit IRC21:46
*** causten has joined #openstack-ironic21:47
*** ijw has quit IRC21:47
*** ijw has joined #openstack-ironic21:48
*** ijw has quit IRC21:48
*** ijw has joined #openstack-ironic21:48
*** baoli has quit IRC21:49
*** jcoufal_ has joined #openstack-ironic21:49
*** jcoufal has quit IRC21:50
*** causten has quit IRC21:54
*** causten has joined #openstack-ironic21:57
*** cmurphy has quit IRC21:59
*** chas has joined #openstack-ironic22:00
*** jcoufal has joined #openstack-ironic22:03
*** cmurphy has joined #openstack-ironic22:04
*** chas has quit IRC22:04
*** jcoufal_ has quit IRC22:05
*** rpioso has quit IRC22:15
*** chas has joined #openstack-ironic22:21
*** jcoufal has quit IRC22:22
*** mgoddard has joined #openstack-ironic22:23
*** chas has quit IRC22:26
*** causten has quit IRC22:27
*** causten has joined #openstack-ironic22:27
*** ijw has quit IRC22:28
*** JayF has quit IRC22:29
*** jkilpatr has quit IRC22:30
*** JayF has joined #openstack-ironic22:37
*** JayF has joined #openstack-ironic22:37
*** mgoddard has quit IRC22:37
*** baoli has joined #openstack-ironic22:45
*** baoli has quit IRC22:45
*** baoli has joined #openstack-ironic22:46
*** crushil has joined #openstack-ironic22:46
*** ijw has joined #openstack-ironic22:51
*** Sukhdev has joined #openstack-ironic22:53
*** ijw has quit IRC22:56
*** rama_y has quit IRC22:58
*** chas has joined #openstack-ironic23:02
*** jralph has quit IRC23:03
*** chas has quit IRC23:07
*** ijw has joined #openstack-ironic23:09
*** jralph has joined #openstack-ironic23:11
*** rama_y has joined #openstack-ironic23:11
*** ijw has quit IRC23:13
*** chas has joined #openstack-ironic23:23
*** chas has quit IRC23:28
*** harlowja has joined #openstack-ironic23:30
*** chas has joined #openstack-ironic23:44
*** chas has quit IRC23:48
*** crushil has quit IRC23:50
*** pmannidi has joined #openstack-ironic23:51
*** harlowja has quit IRC23:55
*** jkilpatr has joined #openstack-ironic23:56
*** slagle has quit IRC23:57
*** harlowja has joined #openstack-ironic23:59

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!