| *** jcoufal has quit IRC | 00:17 | |
| *** rpioso has quit IRC | 00:20 | |
| *** sayantani01 has joined #openstack-ironic | 00:25 | |
| *** rbudden has quit IRC | 00:32 | |
| openstackgerrit | Naohiro Tamura proposed openstack/ironic: iRMC management driver for Inject NMI https://review.openstack.org/348732 | 00:33 |
|---|---|---|
| *** rajinir has quit IRC | 00:36 | |
| *** rbudden has joined #openstack-ironic | 00:38 | |
| *** jkilpatr has joined #openstack-ironic | 00:44 | |
| openstackgerrit | Bob Fournier proposed openstack/ironic-inspector: Add plugin to process basic management LLDP TLVs https://review.openstack.org/406496 | 00:46 |
| *** hoangcx has joined #openstack-ironic | 00:47 | |
| *** phuongnh has joined #openstack-ironic | 00:58 | |
| *** rama_y has quit IRC | 01:01 | |
| openstackgerrit | Naohiro Tamura proposed openstack/ironic: Fix rel note format of the new feature Inject NMI https://review.openstack.org/424396 | 01:01 |
| *** causten has joined #openstack-ironic | 01:02 | |
| *** aNuposic has quit IRC | 01:07 | |
| *** sayantani01 has quit IRC | 01:08 | |
| *** sayantani01 has joined #openstack-ironic | 01:09 | |
| *** sayantan_ has joined #openstack-ironic | 01:11 | |
| *** sayantani01 has quit IRC | 01:13 | |
| *** Syed__ has quit IRC | 01:15 | |
| *** baoli has joined #openstack-ironic | 01:15 | |
| *** causten has quit IRC | 01:15 | |
| *** causten has joined #openstack-ironic | 01:16 | |
| *** sayantan_ has quit IRC | 01:16 | |
| *** baoli has quit IRC | 01:20 | |
| *** causten has quit IRC | 01:20 | |
| *** mtanino has quit IRC | 01:30 | |
| *** rloo has quit IRC | 01:31 | |
| *** mtanino has joined #openstack-ironic | 01:32 | |
| openstackgerrit | Merged openstack/python-ironic-inspector-client: Updated from global requirements https://review.openstack.org/423680 | 01:32 |
| openstackgerrit | Merged openstack/python-ironicclient: Updated from global requirements https://review.openstack.org/423681 | 01:37 |
| *** wrouesnel has quit IRC | 01:37 | |
| *** wrouesnel has joined #openstack-ironic | 01:38 | |
| *** Nisha_Agarwal has joined #openstack-ironic | 01:44 | |
| openstackgerrit | Naohiro Tamura proposed openstack/python-ironicclient: Follow up nits in the patch "ironic node-inject-nmi" https://review.openstack.org/424402 | 01:47 |
| *** Nisha_Agarwal has quit IRC | 01:48 | |
| *** hw_wutianwei has joined #openstack-ironic | 02:00 | |
| *** hw_wutianwei has quit IRC | 02:00 | |
| *** Sukhdev_ has quit IRC | 02:01 | |
| openstackgerrit | Merged openstack/python-ironicclient: Add a new OSC command for Inject NMI https://review.openstack.org/357661 | 02:21 |
| *** lindycoder has joined #openstack-ironic | 02:32 | |
| *** lindycoder has quit IRC | 02:32 | |
| *** mtanino has quit IRC | 02:40 | |
| *** harlowja has quit IRC | 02:44 | |
| openstackgerrit | Zhenguo Niu proposed openstack/ironic: Add nodes tagging support - objs https://review.openstack.org/233357 | 02:49 |
| openstackgerrit | Zhenguo Niu proposed openstack/ironic: Add DB layer support for node tags filter https://review.openstack.org/272624 | 02:49 |
| openstackgerrit | Zhenguo Niu proposed openstack/ironic: Add nodes tagging support - API https://review.openstack.org/250478 | 02:49 |
| *** causten has joined #openstack-ironic | 02:55 | |
| *** tovin07 has quit IRC | 02:56 | |
| openstackgerrit | Merged openstack/python-ironicclient: Fix multiple ports deletion https://review.openstack.org/418445 | 02:58 |
| *** tovin07 has joined #openstack-ironic | 03:07 | |
| openstackgerrit | Bob Fournier proposed openstack/python-ironic-inspector-client: Add new introspection commands for interface data including lldp https://review.openstack.org/419141 | 03:12 |
| *** jralph has quit IRC | 03:22 | |
| openstackgerrit | Zhenguo Niu proposed openstack/ironic: Add nodes tagging support - objs https://review.openstack.org/233357 | 03:26 |
| openstackgerrit | Zhenguo Niu proposed openstack/ironic: Add nodes tagging support - API https://review.openstack.org/250478 | 03:26 |
| openstackgerrit | Zhenguo Niu proposed openstack/ironic: Add DB layer support for node tags filter https://review.openstack.org/272624 | 03:26 |
| *** vikrant has joined #openstack-ironic | 03:36 | |
| *** causten has quit IRC | 03:53 | |
| *** causten has joined #openstack-ironic | 03:53 | |
| *** causten has quit IRC | 03:58 | |
| *** jerrygb_ has quit IRC | 04:02 | |
| *** jerrygb has joined #openstack-ironic | 04:09 | |
| *** jerrygb has quit IRC | 04:10 | |
| *** udesale has joined #openstack-ironic | 04:34 | |
| *** aparnav has joined #openstack-ironic | 04:39 | |
| *** sayantani01 has joined #openstack-ironic | 04:40 | |
| *** pmannidi has quit IRC | 04:40 | |
| *** pmannidi has joined #openstack-ironic | 04:45 | |
| *** jerrygb has joined #openstack-ironic | 05:11 | |
| *** jerrygb has quit IRC | 05:16 | |
| *** makowals_ has quit IRC | 05:29 | |
| *** makowals has joined #openstack-ironic | 05:34 | |
| *** Nisha_Agarwal has joined #openstack-ironic | 05:34 | |
| *** udesale has quit IRC | 05:36 | |
| *** udesale has joined #openstack-ironic | 05:36 | |
| *** nmathew has joined #openstack-ironic | 05:52 | |
| *** SerenaFeng has joined #openstack-ironic | 06:04 | |
| *** moshele has joined #openstack-ironic | 06:04 | |
| *** cfarquhar has quit IRC | 06:06 | |
| openstackgerrit | Nisha Agarwal proposed openstack/proliantutils: snmp inspection for disk size https://review.openstack.org/394858 | 06:20 |
| *** Nisha_ has joined #openstack-ironic | 06:23 | |
| *** Nisha_Agarwal has quit IRC | 06:26 | |
| *** sacharya_ has quit IRC | 06:28 | |
| *** zzzeek has quit IRC | 06:29 | |
| *** harlowja has joined #openstack-ironic | 06:34 | |
| *** mjura has joined #openstack-ironic | 06:36 | |
| *** dsneddon has quit IRC | 06:52 | |
| *** udesale__ has joined #openstack-ironic | 06:53 | |
| *** udesale has quit IRC | 06:56 | |
| openstackgerrit | Naohiro Tamura proposed openstack/ironic: Add Inject NMI to api-ref https://review.openstack.org/423941 | 06:57 |
| *** jerrygb has joined #openstack-ironic | 07:00 | |
| *** udesale has joined #openstack-ironic | 07:01 | |
| tovin07 | JayF, hi | 07:02 |
| tovin07 | Could you re-review this one after rebase, JayF https://review.openstack.org/#/c/358142/ | 07:03 |
| patchbot | patch 358142 - ironic - Enable OSProfiler support in Ironic | 07:03 |
| *** udesale__ has quit IRC | 07:03 | |
| *** udesale has quit IRC | 07:04 | |
| *** jerrygb has quit IRC | 07:06 | |
| *** wrouesnel has quit IRC | 07:11 | |
| *** udesale has joined #openstack-ironic | 07:12 | |
| *** ChubYann has quit IRC | 07:18 | |
| *** harlowja has quit IRC | 07:26 | |
| *** sacharya has joined #openstack-ironic | 07:28 | |
| *** sayantani01 has quit IRC | 07:30 | |
| *** sacharya has quit IRC | 07:33 | |
| *** baoli has joined #openstack-ironic | 07:36 | |
| *** hw_wutianwei has joined #openstack-ironic | 07:36 | |
| *** tesseract has joined #openstack-ironic | 07:37 | |
| *** Sukhdev has joined #openstack-ironic | 07:38 | |
| pas-ha | morning all :) | 07:38 |
| pas-ha | tovin07: I strongly suspect JayF is sleeping now (US) :) | 07:39 |
| *** baoli has quit IRC | 07:40 | |
| *** ralonsoh has joined #openstack-ironic | 07:47 | |
| tovin07 | pas-ha, thanks :D | 07:52 |
| openstackgerrit | Nisha Agarwal proposed openstack/proliantutils: Vendor gpu count https://review.openstack.org/424489 | 07:54 |
| *** ijw has quit IRC | 07:55 | |
| *** udesale__ has joined #openstack-ironic | 07:55 | |
| *** udesale has quit IRC | 07:58 | |
| *** sacharya has joined #openstack-ironic | 07:59 | |
| openstackgerrit | Nisha Agarwal proposed openstack/ironic: SNMP agent support for OOB inspection for iLO Drivers https://review.openstack.org/372428 | 08:01 |
| *** SerenaFeng has quit IRC | 08:02 | |
| *** SerenaFeng has joined #openstack-ironic | 08:02 | |
| *** openstackgerrit has quit IRC | 08:03 | |
| *** sacharya has quit IRC | 08:04 | |
| *** ohamada has joined #openstack-ironic | 08:05 | |
| *** sayantani01 has joined #openstack-ironic | 08:07 | |
| *** sayantani01 has quit IRC | 08:11 | |
| *** ohamada has quit IRC | 08:14 | |
| *** ohamada has joined #openstack-ironic | 08:15 | |
| *** mgoddard has joined #openstack-ironic | 08:21 | |
| *** amotoki has quit IRC | 08:24 | |
| *** udesale__ has quit IRC | 08:30 | |
| *** udesale has joined #openstack-ironic | 08:30 | |
| *** Sukhdev has quit IRC | 08:31 | |
| *** amotoki has joined #openstack-ironic | 08:33 | |
| *** priteau has joined #openstack-ironic | 08:39 | |
| *** openstackgerrit has joined #openstack-ironic | 08:40 | |
| openstackgerrit | Merged openstack/bifrost: Fix "Create SSH directory for ironic user" task https://review.openstack.org/424131 | 08:40 |
| *** amarao has joined #openstack-ironic | 08:43 | |
| *** ohamada has quit IRC | 08:44 | |
| *** pcaruana has joined #openstack-ironic | 08:45 | |
| *** amotoki has quit IRC | 08:53 | |
| vsaienk0 | rloo, sambetts: Just checked https://bugs.launchpad.net/neutron/+bug/1606229. I agree with Sam here, we shouldn't update dvice_owner for ports that were created by nova, or by user directly (tenant ports) | 08:54 |
| openstack | Launchpad bug 1606229 in neutron "vif_port_id of ironic port is not updating after neutron port-delete" [Medium,In progress] - Assigned to Andrey Shestakov (ashestakov) | 08:54 |
| *** makowals has quit IRC | 08:56 | |
| *** makowals_ has joined #openstack-ironic | 08:59 | |
| openstackgerrit | Nisha Agarwal proposed openstack/proliantutils: Add trusted_boot to server capabilities https://review.openstack.org/339119 | 08:59 |
| *** zzzeek has joined #openstack-ironic | 09:00 | |
| *** sayantani01 has joined #openstack-ironic | 09:01 | |
| *** jerrygb has joined #openstack-ironic | 09:02 | |
| *** sayantani01 has quit IRC | 09:05 | |
| openstackgerrit | Andrey Shestakov proposed openstack/bifrost: Fix endpoint service name for inspector https://review.openstack.org/424227 | 09:06 |
| openstackgerrit | Galyna Zholtkevych proposed openstack/ironic: Make _send_sensors_data concurrent https://review.openstack.org/407429 | 09:08 |
| *** jerrygb has quit IRC | 09:08 | |
| openstackgerrit | Merged openstack/bifrost: Fixes to allow install Ironic on remote node https://review.openstack.org/409213 | 09:08 |
| openstackgerrit | Aparna proposed openstack/proliantutils: Add HPSUM firmware update support https://review.openstack.org/422004 | 09:09 |
| openstackgerrit | Sofiia Andriichenko proposed openstack/python-ironicclient: Fixed bug, resources aren't deleted after ironic CLI functional tests were finished https://review.openstack.org/424528 | 09:21 |
| *** ijw has joined #openstack-ironic | 09:23 | |
| *** derekh has joined #openstack-ironic | 09:25 | |
| moshele | vdrok: hi can you review https://review.openstack.org/#/c/264257/ | 09:27 |
| patchbot | patch 264257 - ironic-inspector - Adding InfiniBand Support | 09:27 |
| *** ijw has quit IRC | 09:27 | |
| openstackgerrit | Aparna proposed openstack/proliantutils: Add HPSUM firmware update support https://review.openstack.org/422004 | 09:30 |
| *** lucas-afk is now known as lucasagomes | 09:31 | |
| lucasagomes | morning all! | 09:32 |
| *** e0ne has joined #openstack-ironic | 09:42 | |
| *** mgoddard has quit IRC | 09:43 | |
| *** sambetts|afk is now known as sambetts | 09:47 | |
| sambetts | Morning all | 09:48 |
| *** pester has joined #openstack-ironic | 09:48 | |
| lucasagomes | sambetts, morning | 09:49 |
| openstackgerrit | Sofiia Andriichenko proposed openstack/python-ironicclient: Fixed bug, resources aren't deleted after openstack CLI functional tests had finished https://review.openstack.org/424545 | 09:50 |
| *** rbartal has joined #openstack-ironic | 09:50 | |
| *** athomas has joined #openstack-ironic | 09:52 | |
| sambetts | hey lucasagomes | 09:53 |
| openstackgerrit | Merged openstack/ironic: iRMC management driver for Inject NMI https://review.openstack.org/348732 | 09:54 |
| *** MattMan has quit IRC | 09:54 | |
| *** MattMan has joined #openstack-ironic | 09:54 | |
| *** sayantani01 has joined #openstack-ironic | 09:55 | |
| *** SerenaFeng has quit IRC | 09:56 | |
| *** amotoki has joined #openstack-ironic | 09:57 | |
| vdrok | good morning ironic, pas-ha vsaienk0 moshele lucasagomes and sambetts ! | 09:59 |
| sambetts | o/ vdrok | 09:59 |
| vsaienk0 | morning vdrok, sambetts, dtantsur, aarefiev, lucasagomes and all Ironic'ers! | 09:59 |
| vdrok | moshele: well, I can, but I doubt I'll give a +2 in inspector :) | 09:59 |
| *** sayantani01 has quit IRC | 09:59 | |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: WIP: ironic standalone tests https://review.openstack.org/423556 | 10:01 |
| aarefiev | morning all! | 10:02 |
| vdrok | morning aarefiev | 10:03 |
| openstackgerrit | Merged openstack/proliantutils: snmp inspection for disk size https://review.openstack.org/394858 | 10:05 |
| *** hoangcx has quit IRC | 10:06 | |
| *** strigazi_AFK is now known as strigazi | 10:09 | |
| lucasagomes | o/ | 10:13 |
| lucasagomes | so the client is on feature freeze this week, right ? | 10:13 |
| openstackgerrit | Debayan Ray proposed openstack/proliantutils: Change Log as part of proliantutils 2.2.0 release https://review.openstack.org/424045 | 10:13 |
| *** mgoddard has joined #openstack-ironic | 10:14 | |
| openstackgerrit | Debayan Ray proposed openstack/proliantutils: Change Log as part of proliantutils 2.2.0 release https://review.openstack.org/424045 | 10:20 |
| karthiks | aarefiev, Can you please review the spec, https://review.openstack.org/#/c/396147/ | 10:20 |
| patchbot | patch 396147 - ironic-inspector-specs - Spec for retrieving NUMA node information | 10:20 |
| openstackgerrit | Merged openstack/ironic: Fix rel note format of the new feature Inject NMI https://review.openstack.org/424396 | 10:20 |
| aarefiev | karthiks: I'll take a look today | 10:21 |
| karthiks | aarefiev, Thanks | 10:21 |
| *** udesale has quit IRC | 10:21 | |
| openstackgerrit | Debayan Ray proposed openstack/proliantutils: Change Log as part of proliantutils 2.2.0 release https://review.openstack.org/424045 | 10:25 |
| vsaienk0 | sambetts: have you heard about neutron routed networks? | 10:25 |
| sambetts | vsaienk0: yeah, its interesting | 10:28 |
| openstackgerrit | Merged openstack/proliantutils: Change Log as part of proliantutils 2.2.0 release https://review.openstack.org/424045 | 10:33 |
| vsaienk0 | sambetts: We need to start thinking how to implement it in ironic for provisioning/cleaning https://bugs.launchpad.net/ironic/+bug/1658964. | 10:33 |
| openstack | Launchpad bug 1658964 in Ironic "[RFE] Implement neutron routed networks support in Ironic" [Undecided,New] | 10:33 |
| *** derekh has quit IRC | 10:35 | |
| *** phuongnh has quit IRC | 10:37 | |
| sambetts | vsaienk0: hmm interesting, I don't know if its something we should store in Ironic, surely its down to neutron to be aware of what segments are avaible on each switch and make the judgement of what to configure, and if that is the cases we shouldn't need to change any thing | 10:38 |
| vsaienk0 | sambetts: for nova this information will be stored in resource provider and nova host-aggregates will be used to combine node node with the same segments https://specs.openstack.org/openstack/nova-specs/specs/newton/implemented/neutron-routed-networks.html#proposed-change | 10:44 |
| vsaienk0 | sambetts: I need to dig more, but looks like we need to store node segments mapping in ironic | 10:45 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: WIP: ironic standalone tests https://review.openstack.org/423556 | 10:47 |
| *** nmathew has quit IRC | 10:54 | |
| *** derekh has joined #openstack-ironic | 10:56 | |
| *** yonglihe has quit IRC | 10:57 | |
| *** snecklifter has joined #openstack-ironic | 10:57 | |
| *** ccamacho has joined #openstack-ironic | 10:57 | |
| sambetts | vsaienk0: hmm... that could be interesting | 10:58 |
| openstackgerrit | Milan Kováčik proposed openstack/ironic-inspector: Fix DBDeadlock during clean up https://review.openstack.org/422770 | 10:59 |
| lucasagomes | fyi: Is adding a experimetal job with UEFI: https://review.openstack.org/#/c/424576/ (project-config) | 11:00 |
| patchbot | patch 424576 - openstack-infra/project-config - Add experimental UEFI job for ironic | 11:00 |
| *** priteau has quit IRC | 11:00 | |
| *** e0ne has quit IRC | 11:01 | |
| openstackgerrit | Jim Rollenhagen proposed openstack/ironic: Allow using resource classes https://review.openstack.org/407651 | 11:02 |
| openstackgerrit | Jim Rollenhagen proposed openstack/ironic: DNM: turn on resource classes https://review.openstack.org/423269 | 11:03 |
| *** jerrygb has joined #openstack-ironic | 11:04 | |
| *** ricardoas has quit IRC | 11:05 | |
| *** amotoki has quit IRC | 11:07 | |
| *** jerrygb has quit IRC | 11:09 | |
| *** dtantsur|afk is now known as dtantsur | 11:13 | |
| dtantsur | morning Ironic | 11:13 |
| openstackgerrit | Sofiia Andriichenko proposed openstack/ironic: Added api tests for ironic driver: https://review.openstack.org/408531 | 11:16 |
| openstackgerrit | Merged openstack/ironic: Use context manager for better file handling https://review.openstack.org/423121 | 11:16 |
| openstackgerrit | Sofiia Andriichenko proposed openstack/ironic: This adds a tempest tests for creating a node: https://review.openstack.org/411197 | 11:19 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: WIP: ironic standalone tests https://review.openstack.org/423556 | 11:20 |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Update proliantutils version required for Ocata release https://review.openstack.org/424593 | 11:21 |
| openstackgerrit | Anton Arefiev proposed openstack/ironic-inspector: Change (started|finished)_at column type https://review.openstack.org/397636 | 11:22 |
| *** Nisha_brb has joined #openstack-ironic | 11:22 | |
| vdrok | morning dtantsur | 11:24 |
| dtantsur | o/ | 11:24 |
| aarefiev | morning dtantsur, mind to take a look on trivial fix https://review.openstack.org/#/c/420724/ https://review.openstack.org/#/c/420725/ | 11:25 |
| patchbot | patch 420724 - ironic - Use global vars for storing image deploy path's | 11:25 |
| patchbot | patch 420725 - ironic-inspector - Devstack: don't rely on Ironic local vars | 11:25 |
| *** Nisha_ has quit IRC | 11:25 | |
| dtantsur | will do | 11:27 |
| aarefiev | thanks | 11:28 |
| *** amotoki has joined #openstack-ironic | 11:30 | |
| dtantsur | aarefiev, vsaienk0, please figure out the -1 on https://review.openstack.org/#/c/420725/ first | 11:35 |
| patchbot | patch 420725 - ironic-inspector - Devstack: don't rely on Ironic local vars | 11:35 |
| openstackgerrit | Vladyslav Drok proposed openstack/ironic-specs: Tenant-aware baremetal nodes https://review.openstack.org/415512 | 11:35 |
| aarefiev | dtantsur, vsaienk0, I can update commit message a little bit if it's confusing | 11:36 |
| *** jkilpatr has quit IRC | 11:43 | |
| *** mrtenio has joined #openstack-ironic | 11:44 | |
| openstackgerrit | Anton Arefiev proposed openstack/ironic-inspector: Devstack: don't rely on Ironic local vars https://review.openstack.org/420725 | 11:45 |
| dtantsur | lucasagomes, btw we need the dsvm job finally voting on ironic-staging-drivers :) | 11:46 |
| lucasagomes | dtantsur, true that, lemme put up a patch | 11:47 |
| *** udesale has joined #openstack-ironic | 11:55 | |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: WIP: ironic standalone tests https://review.openstack.org/423556 | 11:58 |
| jroll | morning ironic | 11:58 |
| jroll | dtantsur: so, only the fake driver has the vendor passthru mapping, right? which is the only one our tests use... turns out if you use the fake vendor interface directly things fail everywhere O_o | 11:59 |
| lucasagomes | jroll, morning | 11:59 |
| jroll | morning lucasagomes :) | 11:59 |
| *** athomas has quit IRC | 11:59 | |
| *** athomas has joined #openstack-ironic | 12:00 | |
| openstackgerrit | Galyna Zholtkevych proposed openstack/ironic: [WIP] Migrate to session for glance client https://review.openstack.org/410767 | 12:00 |
| dtantsur | morning jroll | 12:01 |
| dtantsur | wow.. how do things fail? | 12:01 |
| * jroll fetches the error | 12:02 | |
| jroll | it's pretty clearly because it isn't that mixin class, though | 12:02 |
| jroll | dtantsur: oh, maybe not, I guess we have some tests that depend on the mapping | 12:04 |
| jroll | my fault :x | 12:04 |
| dtantsur | heh, things happen :) | 12:06 |
| * jroll shouldn't code at night | 12:06 | |
| jroll | dtantsur: we probably want to keep that mixin around for out of tree stuff, yeah? and deprecate it? | 12:06 |
| jroll | maybe deprecation can wait for the rest of the drivers | 12:06 |
| openstackgerrit | Merged openstack/python-ironicclient: Follow up nits in the patch "ironic node-inject-nmi" https://review.openstack.org/424402 | 12:10 |
| dtantsur | yeah, we just should make it clear (in docs and/or docstrings) that the mixin is not for new-style hardware types | 12:10 |
| lucasagomes | dtantsur, https://review.openstack.org/#/c/424618/ | 12:12 |
| patchbot | patch 424618 - openstack-infra/project-config - Make the ironic-staging-drivers-dsvm job voting | 12:12 |
| dtantsur | thnx | 12:12 |
| dtantsur | lucasagomes or jroll, mind reviewing https://review.openstack.org/#/c/423227/ please? | 12:14 |
| patchbot | patch 423227 - ironic-python-agent - Mock out get_wildcard_address | 12:14 |
| dtantsur | we need it to start unit-testing IPA in RDO again | 12:14 |
| * lucasagomes looks | 12:14 | |
| dtantsur | pas-ha, around? | 12:15 |
| dtantsur | I'd love to see https://review.openstack.org/#/c/404858/ backported, I can try doing it myself ofc | 12:15 |
| patchbot | patch 404858 - ironic - Fix take over for ACTIVE nodes in PXEBoot (MERGED) | 12:15 |
| lucasagomes | looks good, yeah it's better to mock it just in case someone is running w/o ipv6 enabled | 12:15 |
| jroll | +2, I see lucasagomes did +A then -A so I didn't land | 12:16 |
| lucasagomes | (should be rare tho) | 12:16 |
| *** jkilpatr has joined #openstack-ironic | 12:16 | |
| lucasagomes | jroll, I revoked cause the author of the patch is from red hat as well | 12:16 |
| jroll | oh | 12:16 |
| jroll | lucasagomes: that's a pretty trivial patch, I don't worry about that much with things like that | 12:16 |
| jroll | but thanks for keeping it in mind | 12:16 |
| * jroll +A | 12:16 | |
| dtantsur | lucasagomes, RDO builds packages in IPv6-less environment | 12:17 |
| dtantsur | (dunno why) | 12:17 |
| lucasagomes | jroll, yeah, I kinda like that policy (even for simple patches) | 12:17 |
| jroll | fair enough :) | 12:17 |
| lucasagomes | dtantsur, damn, dunno why either >.< | 12:18 |
| lucasagomes | sounds like a silly thing to do tho | 12:18 |
| * lucasagomes goes grab some food | 12:19 | |
| *** lucasagomes is now known as lucas-hungry | 12:19 | |
| openstackgerrit | Merged openstack/ironic-python-agent: Mock out get_wildcard_address https://review.openstack.org/423227 | 12:21 |
| *** awiddersheim has quit IRC | 12:27 | |
| cdaniel | morning all | 12:31 |
| *** udesale has quit IRC | 12:37 | |
| openstackgerrit | Merged openstack/ironic-inspector: Updated from global requirements https://review.openstack.org/423639 | 12:38 |
| openstackgerrit | Jim Rollenhagen proposed openstack/ironic: Add dynamic driver functionality to driver list/show APIs https://review.openstack.org/417970 | 12:40 |
| jroll | it is done! | 12:40 |
| jroll | dtantsur: ^^ that's all of the API work, ready for review | 12:41 |
| jroll | I probably need to check for cruft but it's generally ready to go, I think | 12:41 |
| dtantsur | wow, great job! | 12:41 |
| vdrok | morning jroll and cdaniel | 12:43 |
| *** priteau has joined #openstack-ironic | 12:45 | |
| openstackgerrit | Merged openstack/python-ironicclient: Fix node-inject-nmi to pass an empty body https://review.openstack.org/424293 | 12:45 |
| *** hw_wutianwei has quit IRC | 12:46 | |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: Validate port info before assume we may use it https://review.openstack.org/415881 | 12:51 |
| *** krtaylor has quit IRC | 12:51 | |
| openstackgerrit | Jim Rollenhagen proposed openstack/ironic: Add dynamic driver functionality to REST API https://review.openstack.org/417970 | 12:51 |
| jroll | just a commit message update ^ | 12:52 |
| *** vikrant has quit IRC | 12:53 | |
| bfournie | morning all | 12:54 |
| openstackgerrit | Galyna Zholtkevych proposed openstack/ironic: Make _send_sensors_data concurrent https://review.openstack.org/407429 | 12:54 |
| *** ricardoas has joined #openstack-ironic | 12:56 | |
| openstackgerrit | Noam Angel proposed openstack/ironic-inspector: [devstack] Remove bridge only if it's not OVB_PHYSICAL_BRIDGE https://review.openstack.org/423758 | 12:58 |
| *** ccamacho is now known as ccamacho|lunch | 12:59 | |
| *** mtanino has joined #openstack-ironic | 13:00 | |
| noama | dtantsur aarefiev can you review https://review.openstack.org/#/c/423758/ ? | 13:00 |
| patchbot | patch 423758 - ironic-inspector - [devstack] Remove bridge only if it's not OVB_PHYS... | 13:00 |
| dtantsur | sure, a bit later | 13:00 |
| noama | thanks | 13:00 |
| *** baoli has joined #openstack-ironic | 13:01 | |
| *** baoli has quit IRC | 13:01 | |
| *** baoli has joined #openstack-ironic | 13:02 | |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: Do not change tenant Neutron port device_owner https://review.openstack.org/424650 | 13:02 |
| *** krtaylor has joined #openstack-ironic | 13:04 | |
| *** jerrygb has joined #openstack-ironic | 13:05 | |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic-inspector: Clean up logging related to new state machine https://review.openstack.org/424654 | 13:08 |
| *** jerrygb has quit IRC | 13:10 | |
| *** lucas-hungry is now known as lucasagomes | 13:16 | |
| *** AlexeyAbashkin has joined #openstack-ironic | 13:16 | |
| openstackgerrit | Galyna Zholtkevych proposed openstack/python-ironicclient: Add `latest` to baremetal-api-version https://review.openstack.org/420659 | 13:17 |
| *** ijw has joined #openstack-ironic | 13:23 | |
| *** trown|outtypewww is now known as trown | 13:23 | |
| *** bcornec1 has joined #openstack-ironic | 13:24 | |
| *** e0ne has joined #openstack-ironic | 13:28 | |
| *** ijw has quit IRC | 13:28 | |
| *** aparnav has quit IRC | 13:33 | |
| *** bcornec1 has quit IRC | 13:36 | |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic-inspector: Clean up deprecated configuration options https://review.openstack.org/424659 | 13:38 |
| dtantsur | 37 insertions(+), 418 deletions(-), nice | 13:38 |
| *** hoangcx has joined #openstack-ironic | 13:39 | |
| *** mrtenio has quit IRC | 13:40 | |
| *** causten has joined #openstack-ironic | 13:40 | |
| *** srobert has joined #openstack-ironic | 13:44 | |
| *** causten has quit IRC | 13:44 | |
| openstackgerrit | Galyna Zholtkevych proposed openstack/ironic: Make _send_sensors_data concurrent https://review.openstack.org/407429 | 13:44 |
| openstackgerrit | Galyna Zholtkevych proposed openstack/ironic: Make _send_sensors_data concurrent https://review.openstack.org/407429 | 13:49 |
| *** udesale has joined #openstack-ironic | 13:50 | |
| openstackgerrit | Galyna Zholtkevych proposed openstack/ironic: Make _send_sensors_data concurrent https://review.openstack.org/407429 | 13:52 |
| *** trown is now known as trown|brb | 13:52 | |
| *** ccamacho|lunch is now known as ccamacho | 13:53 | |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic-inspector: Clean up deprecated configuration options https://review.openstack.org/424659 | 13:55 |
| *** cdearborn has joined #openstack-ironic | 13:55 | |
| *** udesale has quit IRC | 13:57 | |
| openstackgerrit | Galyna Zholtkevych proposed openstack/ironic: [WIP] Migrate to session for glance client https://review.openstack.org/410767 | 13:58 |
| *** dprince has joined #openstack-ironic | 13:59 | |
| *** rloo has joined #openstack-ironic | 14:06 | |
| *** mtanino has quit IRC | 14:13 | |
| *** trown|brb is now known as trown | 14:14 | |
| *** jcoufal has joined #openstack-ironic | 14:15 | |
| openstackgerrit | Vladyslav Drok proposed openstack/ironic-specs: Tenant-aware baremetal nodes https://review.openstack.org/415512 | 14:16 |
| *** krtaylor has quit IRC | 14:18 | |
| openstackgerrit | Vladyslav Drok proposed openstack/ironic-specs: Tenant-aware baremetal nodes https://review.openstack.org/415512 | 14:20 |
| openstackgerrit | Milan Kováčik proposed openstack/ironic-inspector: Find a node by multiple attributes https://review.openstack.org/421285 | 14:23 |
| *** dyasny has quit IRC | 14:24 | |
| jroll | why did I think we already exposed *_interface fields for nodes? | 14:24 |
| jroll | :| | 14:24 |
| dtantsur | so did I Oo | 14:25 |
| jroll | welp. more work to do | 14:25 |
| jroll | dtantsur: you want that in the same patch and API version 1.30 or another patch and 1.31? | 14:26 |
| *** Goneri has joined #openstack-ironic | 14:26 | |
| dtantsur | jroll, what's in 1.30 then, driver API? I'm fine with these separate | 14:26 |
| jroll | dtantsur: yeah | 14:27 |
| *** amotoki has quit IRC | 14:29 | |
| vsaienk0 | TheJulia: I've replied here https://review.openstack.org/#/c/422561 could you please check | 14:29 |
| patchbot | patch 422561 - ironic - Do not use user token in neutron client | 14:29 |
| *** krtaylor has joined #openstack-ironic | 14:31 | |
| *** bcornec1 has joined #openstack-ironic | 14:31 | |
| openstackgerrit | Aparna proposed openstack/proliantutils: Add HPSUM firmware update support https://review.openstack.org/422004 | 14:31 |
| *** mjturek has joined #openstack-ironic | 14:32 | |
| *** udesale has joined #openstack-ironic | 14:34 | |
| dtantsur | aarefiev, sambetts, I have a nasty feeling that inspector grenade job is not actually updating inspector code Oo | 14:34 |
| aarefiev | dtantsur: why do think so? | 14:35 |
| dtantsur | aarefiev, not seeing anything new in logs. also this is probably no-op for us: https://github.com/openstack-dev/devstack/blob/dec121114c3ea6f9e515a452700e5015d1e34704/lib/stack#L19 | 14:35 |
| *** amotoki has joined #openstack-ironic | 14:35 | |
| dtantsur | this is the whole installation for us: http://logs.openstack.org/36/397636/8/check/gate-grenade-dsvm-ironic-inspector-ubuntu-xenial/744eb9b/logs/grenade.sh.txt.gz#_2017-01-24_12_30_06_877 | 14:36 |
| *** krtaylor has quit IRC | 14:37 | |
| dtantsur | and for ironic it actually runs something: http://logs.openstack.org/70/417970/16/check/gate-grenade-dsvm-ironic-ubuntu-xenial/1f04952/logs/grenade.sh.txt.gz#_2017-01-24_13_52_46_283 | 14:37 |
| *** vinsh_ has quit IRC | 14:38 | |
| *** dyasny has joined #openstack-ironic | 14:40 | |
| * dtantsur prepares a patch | 14:40 | |
| vsaienk0 | sambetts, vdrok please review https://review.openstack.org/#/c/422561/ | 14:41 |
| patchbot | patch 422561 - ironic - Do not use user token in neutron client | 14:41 |
| *** cdearborn has quit IRC | 14:42 | |
| vdrok | vsaienk0: will do | 14:44 |
| *** jerrygb has joined #openstack-ironic | 14:44 | |
| vsaienk0 | vdrok: thanks! | 14:44 |
| sambetts | vsaienk0: heh I had a very similar patch a while ago but I think it got lost in the firehose and then eventually abandoned, glad to see this coming back | 14:44 |
| sambetts | vsaienk0: my patch was to fix an annoying bug with ironic using a passed token, where that token could expire | 14:45 |
| sambetts | and break a deploy | 14:45 |
| sambetts | I wonder if that bug report is still around :/ | 14:45 |
| *** cdearborn has joined #openstack-ironic | 14:45 | |
| vsaienk0 | sambetts: yeah my patch should fix that bug too | 14:45 |
| jroll | dtantsur: what do you think about vdrok's comments here: https://review.openstack.org/#/c/417970/15/ironic/api/controllers/v1/driver.py@377 | 14:46 |
| patchbot | patch 417970 - ironic - Add dynamic driver functionality to REST API | 14:46 |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic-inspector: Make grenade actually upgrade our source code https://review.openstack.org/424680 | 14:46 |
| dtantsur | aarefiev, sambetts ^^^ | 14:46 |
| sambetts | dtantsur: Oh dear... | 14:46 |
| *** jerrygb_ has joined #openstack-ironic | 14:47 | |
| *** jerrygb__ has joined #openstack-ironic | 14:49 | |
| dtantsur | jroll, which exactly bit? | 14:49 |
| dtantsur | ah, this. well, I don't think we have better options. we can't NOT return working drivers from this API | 14:50 |
| dtantsur | vdrok, ^^^ | 14:50 |
| jroll | dtantsur: well, I replied as well - mostly the inconsistency if on early API version, someone can call /v1/drivers/foo-hw-type, but not /v1/drivers/foo-hw-type/properties | 14:51 |
| dtantsur | aren't we going to fix it soon? | 14:51 |
| jroll | we could allow /properties and /passthru for hw types on any version, but idk | 14:51 |
| *** jerrygb has quit IRC | 14:51 | |
| jroll | fix... what | 14:51 |
| jroll | right now I'm blocking those for <1.30 | 14:51 |
| dtantsur | "we could allow /properties and /passthru for hw types on any version" I thought that was the plan, no? | 14:51 |
| *** jerrygb_ has quit IRC | 14:52 | |
| dtantsur | I think the initial idea was that for <1.30 we treat hardware types as a classic driver with interfaces hardcoded to default implementations | 14:52 |
| jroll | ah, it was unclear from the spec, I wasn't sure | 14:52 |
| jroll | damn, that makes sense though | 14:52 |
| vdrok | yup, that should be OK | 14:52 |
| jroll | so just the new parameters and fields returned are versioned, yes? | 14:52 |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic-inspector: Make grenade actually upgrade our source code https://review.openstack.org/424680 | 14:53 |
| * jroll does it | 14:54 | |
| dtantsur | jroll, yep, I think so | 14:54 |
| openstackgerrit | Galyna Zholtkevych proposed openstack/ironic: [WIP] Migrate to session for glance client https://review.openstack.org/410767 | 14:54 |
| openstackgerrit | Merged openstack/ironic-inspector: Fix DBDeadlock during clean up https://review.openstack.org/422770 | 14:55 |
| TheJulia | vsaienk0: I'll look this morning | 14:56 |
| vsaienk0 | sambetts, TheJulia: thanks! | 14:57 |
| *** amotoki has quit IRC | 14:57 | |
| *** krtaylor has joined #openstack-ironic | 14:58 | |
| *** jerrygb has joined #openstack-ironic | 15:01 | |
| openstackgerrit | Aparna proposed openstack/proliantutils: Add return code for hpsum firmware update https://review.openstack.org/423856 | 15:02 |
| openstackgerrit | Jim Rollenhagen proposed openstack/ironic: Add dynamic driver functionality to REST API https://review.openstack.org/417970 | 15:03 |
| *** dyasny has quit IRC | 15:03 | |
| jroll | dtantsur: vdrok: ^ I think that should be good | 15:03 |
| vdrok | jroll: thanks, will try to take another look today | 15:03 |
| jroll | thank you :) | 15:03 |
| jroll | rloo: can you help review release notes cleanup this afternoon, once I get a patch up? (for the clients) | 15:04 |
| *** dprince has quit IRC | 15:05 | |
| rloo | jroll: i could. but so early? i haven't yet started reviewing the client patches yet. | 15:05 |
| *** jerrygb__ has quit IRC | 15:05 | |
| jroll | rloo: we have two days... | 15:05 |
| rloo | jroll: i'm looking at tags patches. should we decide that it won't make it? | 15:05 |
| jroll | rloo: no, I just need to start cleaning up notes, and you're very helpful with reviewing my cleanups, so I'm wondering if you have time for that today | 15:06 |
| *** hoangcx has quit IRC | 15:06 | |
| rloo | jroll: ok, i can make time for that :) | 15:06 |
| jroll | ok, thanks | 15:06 |
| rloo | jroll: although could we do it starting tomorrow morning. | 15:07 |
| rloo | jroll: i am hopeful (heh) that there will be more to add to the release notes by then | 15:07 |
| jroll | rloo: that's fine, but I want to get it up today | 15:07 |
| jroll | and yes, we can iterate if there are more | 15:07 |
| jroll | or you can ask the final patches to fix them :) | 15:07 |
| rloo | jroll: ok. just easier for me to minimize number of rounds of reviews! | 15:07 |
| rloo | jroll: and that too. | 15:07 |
| *** dyasny has joined #openstack-ironic | 15:10 | |
| *** mtanino has joined #openstack-ironic | 15:13 | |
| *** mtanino has quit IRC | 15:15 | |
| *** mtanino has joined #openstack-ironic | 15:15 | |
| *** vinsh has joined #openstack-ironic | 15:16 | |
| *** bfournie has quit IRC | 15:17 | |
| *** tovin07_ has joined #openstack-ironic | 15:18 | |
| jroll | TheJulia: is it too early to expose node.storage_interface in the api? | 15:19 |
| openstackgerrit | Galyna Zholtkevych proposed openstack/ironic: [WIP] Migrate to session for glance client https://review.openstack.org/410767 | 15:19 |
| *** tovin07_ has left #openstack-ironic | 15:20 | |
| TheJulia | jroll: I think so, if it would be easy to expose once we actually wire the actions in, then ++good | 15:21 |
| *** dyasny has quit IRC | 15:22 | |
| *** amotoki has joined #openstack-ironic | 15:22 | |
| TheJulia | anyone know of any decent coffee shops along market in sf? | 15:22 |
| jroll | TheJulia: right, we'll just need to add the field then, thanks | 15:22 |
| jroll | what crossstreet are you near? | 15:22 |
| jroll | there's a real good one down 7th | 15:22 |
| JayF | TheJulia: if you're at 2nd+Market, the 222 Minna is really good | 15:22 |
| jroll | ^^ that too | 15:22 |
| JayF | 111 Minna, apparently | 15:22 |
| TheJulia | 7th is not that far from me, I'm on o'carrel at the moment | 15:23 |
| JayF | not 222 after googling :) | 15:23 |
| TheJulia | err, o'farrel | 15:23 |
| JayF | o' | 15:23 |
| * TheJulia tosses rocks at autocorrect | 15:23 | |
| JayF | O'Farrell at what? Market? | 15:23 |
| JayF | that's around 4th | 15:23 |
| *** dyasny has joined #openstack-ironic | 15:23 | |
| jroll | I'd honestly yelp if you want closest, SF people are on top of that | 15:23 |
| TheJulia | Where I'm going is on market, so I'm going to walk to market first | 15:23 |
| JayF | I'd go towards 2nd if you didn't have a reason to go the other way. 5th/6th and market is not the best place | 15:23 |
| jroll | there's a blue bottle at the ferry building at the end | 15:23 |
| jroll | true | 15:23 |
| TheJulia | awesome, thanks guys | 15:24 |
| jroll | oh, blue bottle near market and fifth too | 15:24 |
| JayF | 111 minna is super good and very sf-like | 15:24 |
| JayF | it's an art gallery/bar/coffeeshop | 15:24 |
| JayF | lol | 15:24 |
| JayF | the blue bottle stuff is pretty good too, but always a line for just fancy regular coffee | 15:24 |
| jroll | mmmmmmm also philz | 15:24 |
| * jroll misses sf coffee | 15:25 | |
| *** jaosorior has joined #openstack-ironic | 15:25 | |
| *** amotoki has quit IRC | 15:26 | |
| *** amotoki has joined #openstack-ironic | 15:26 | |
| openstackgerrit | Nisha Agarwal proposed openstack/proliantutils: Vendor gpu count https://review.openstack.org/424489 | 15:27 |
| *** amotoki has quit IRC | 15:27 | |
| *** amotoki has joined #openstack-ironic | 15:27 | |
| rloo | vdrok, yuriyz: i have some concerns about tags: https://review.openstack.org/#/c/233357/. am thinking it isn't really ready for getting in this week. did you two really want it in (and/or are my concerns not concerns?) | 15:30 |
| patchbot | patch 233357 - ironic - Add nodes tagging support - objs | 15:30 |
| vdrok | rloo: morning, well, my concerns on that were resolved, but I'm OK if it does not get in :) | 15:30 |
| *** dyasny has quit IRC | 15:30 | |
| vdrok | lemme look at yours then | 15:31 |
| rloo | vdrok: ok, let me know what you think. thx! | 15:31 |
| *** Syed__ has joined #openstack-ironic | 15:33 | |
| rloo | mjturek: are you around / avail to update https://review.openstack.org/#/c/354806/ ? | 15:33 |
| patchbot | patch 354806 - python-ironicclient - Add --wait to OSC provisioning commands | 15:33 |
| mjturek | rloo: yep! | 15:34 |
| mjturek | will do now | 15:34 |
| rloo | mjturek: thank you! | 15:34 |
| rloo | mjturek: would like to land it by tomorrow if possible | 15:34 |
| *** dyasny has joined #openstack-ironic | 15:34 | |
| mjturek | right client freeze is tomorrow? | 15:34 |
| *** sayantani01 has joined #openstack-ironic | 15:35 | |
| *** rpioso has joined #openstack-ironic | 15:35 | |
| *** sayantani01 has quit IRC | 15:35 | |
| rloo | mjturek: well, thurs, but we're aiming for tomorrow | 15:36 |
| mjturek | cool cool, understood | 15:36 |
| *** sayantani01 has joined #openstack-ironic | 15:36 | |
| *** srobert has quit IRC | 15:37 | |
| *** srobert has joined #openstack-ironic | 15:38 | |
| openstackgerrit | Aparna proposed openstack/proliantutils: Add return code for hpsum firmware update https://review.openstack.org/423856 | 15:40 |
| *** amotoki has quit IRC | 15:41 | |
| *** sacharya has joined #openstack-ironic | 15:46 | |
| openstackgerrit | Merged openstack/ironic-python-agent: Enable release notes translation https://review.openstack.org/422396 | 15:47 |
| *** bfournie has joined #openstack-ironic | 15:49 | |
| *** dprince has joined #openstack-ironic | 15:55 | |
| *** rbartal has quit IRC | 15:56 | |
| *** amotoki has joined #openstack-ironic | 15:57 | |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: Validate port info before assume we may use it https://review.openstack.org/415881 | 15:57 |
| * swatson is back (gone 113:11:26) | 15:58 | |
| *** udesale has quit IRC | 15:58 | |
| openstackgerrit | Solio Sarabia proposed openstack/ironic-tempest-plugin: WIP/DNM: Migrate ironic-tempest-plugin to new repo https://review.openstack.org/419602 | 15:58 |
| *** cfarquhar has joined #openstack-ironic | 15:59 | |
| openstackgerrit | Yuriy Zveryanskyy proposed openstack/ironic: Do not send sensors data for nodes in maintenance mode https://review.openstack.org/415173 | 15:59 |
| openstackgerrit | Anton Arefiev proposed openstack/ironic-inspector: Change (started|finished)_at column type https://review.openstack.org/397636 | 16:03 |
| *** vinsh has quit IRC | 16:04 | |
| *** milan has joined #openstack-ironic | 16:05 | |
| milan | morning Ironic! :) | 16:05 |
| *** sayantani01 has quit IRC | 16:05 | |
| *** amoralej|off has quit IRC | 16:06 | |
| *** vinsh has joined #openstack-ironic | 16:06 | |
| *** sayantani01 has joined #openstack-ironic | 16:06 | |
| *** vinsh has quit IRC | 16:06 | |
| *** dmellado has quit IRC | 16:07 | |
| *** vinsh has joined #openstack-ironic | 16:07 | |
| *** jerrygb has quit IRC | 16:08 | |
| *** amarao has quit IRC | 16:09 | |
| pas-ha | mat128|afk: around? | 16:09 |
| mat128|afk | in a meeting, but yes | 16:09 |
| *** mat128|afk is now known as mat128 | 16:09 | |
| *** jerrygb has joined #openstack-ironic | 16:09 | |
| pas-ha | mat128|afk: just wanted to ask what's up with graphical console spec https://review.openstack.org/#/c/306074 | 16:09 |
| patchbot | patch 306074 - ironic-specs - VNC Graphical console | 16:09 |
| openstackgerrit | Jim Rollenhagen proposed openstack/ironic: Add dynamic interfaces fields to nodes API https://review.openstack.org/424720 | 16:10 |
| jroll | dtantsur: ^^ there's the rest | 16:10 |
| mat128 | pas-ha: oh, yeah | 16:10 |
| mat128 | pas-ha: there has been some discussion around enabling multiple types at the same time | 16:10 |
| dtantsur | jroll, ok, I'll get to it once I finish another "interesting" code reading :) | 16:10 |
| jroll | dtantsur: no worries :) | 16:10 |
| mat128 | pas-ha: I wanted to let the driver composition work go ahead and then build on it. | 16:10 |
| mat128 | pas-ha: adding to my list of reviews to update | 16:11 |
| pas-ha | ok, cool :) we're kind of also interested in this feature, so if need any help (apart from reviews obviously :) ) I'd gladly help | 16:14 |
| jroll | hrm, how long does cleaning usually take in CI? 600 seconds apparently isn't long enough? | 16:15 |
| *** pcaruana has quit IRC | 16:16 | |
| *** cfarquhar has quit IRC | 16:16 | |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: Allow to attach/detach VIFs to active ironic nodes https://review.openstack.org/424723 | 16:17 |
| dtantsur | jroll, huh, used to be 2-3 minutes IIRC | 16:17 |
| dtantsur | sambetts, is it possible you check the LLDP patch again today? I haven't spotted anything suspicious, but I don't understand big chunks of it | 16:18 |
| *** ijw has joined #openstack-ironic | 16:18 | |
| jroll | dtantsur: yeah, could be something else wrong, dunno | 16:18 |
| dtantsur | if we manage to land it today/tomorrow morning, then we can land the client change tomorrow afternoon and fit it into the release | 16:18 |
| mat128 | pas-ha: thanks :) | 16:18 |
| * jroll trying to make devstack do the enroll->manage->available thing | 16:18 | |
| dtantsur | I see.. | 16:19 |
| mat128 | jroll: is it actually trying to clean (shred) or that step is skipped? | 16:19 |
| jroll | 2017-01-24 11:41:09.847 | Node 4590db44-79c1-43e2-8e0d-3181dd22833d failed to reach state available in 600 seconds | 16:19 |
| jroll | should be skipped | 16:19 |
| jroll | we always skip that in CI afaik | 16:19 |
| mat128 | jroll: then it's simply booting, heartbeating, shutting down | 16:19 |
| jroll | deploy.erase_devices_priority = 0 | 16:19 |
| jroll | right | 16:19 |
| mat128 | link to logs? | 16:19 |
| jroll | mat128: http://logs.openstack.org/51/407651/7/check/gate-tempest-dsvm-ironic-ipa-wholedisk-agent_ipmitool-tinyipa-ubuntu-xenial/31307d9/logs/devstacklog.txt.gz#_2017-01-24_11_41_09_847 | 16:20 |
| jroll | ironic-bm-logs looks like just a slow node, but every job failed so idk | 16:20 |
| mat128 | jroll: never booted off the network - No bootable device. ........ Connection timed out | 16:20 |
| mat128 | yup | 16:20 |
| jroll | wait, where'd you see that | 16:21 |
| mat128 | http://logs.openstack.org/51/407651/7/check/gate-tempest-dsvm-ironic-ipa-wholedisk-agent_ipmitool-tinyipa-ubuntu-xenial/31307d9/logs/ironic-bm-logs/node-0_console.txt.gz | 16:21 |
| mat128 | you need a terminal interpreter though :) | 16:21 |
| mat128 | I typically just "curl $URL" in a shell | 16:21 |
| jroll | ah right | 16:21 |
| jroll | heh good call, thanks | 16:21 |
| jroll | oh I bet we didn't set up the network yet | 16:21 |
| jroll | this is dumb | 16:21 |
| mat128 | :) | 16:22 |
| jroll | > enroll_nodes > configure_tftpd > configure_iptables | 16:22 |
| jroll | :| :| :| | 16:22 |
| * jroll ignores this for a bit | 16:22 | |
| *** ijw has quit IRC | 16:23 | |
| dtantsur | folks (not necessary inspector cores), could you please review https://review.openstack.org/#/c/424680/ ? | 16:23 |
| patchbot | patch 424680 - ironic-inspector - Make grenade actually upgrade our source code | 16:23 |
| dtantsur | this makes our grenade actually test upgraded service... | 16:23 |
| dtantsur | (fortunately, it seems like we haven't broken it) | 16:23 |
| openstackgerrit | Jim Rollenhagen proposed openstack/ironic: Allow using resource classes https://review.openstack.org/407651 | 16:24 |
| jroll | dtantsur: oops | 16:24 |
| dtantsur | mat128, the devstack function we use just silently ignores wrong service names.. | 16:25 |
| mat128 | :( | 16:25 |
| * mat128 pulls his devstack directory | 16:25 | |
| openstackgerrit | Galyna Zholtkevych proposed openstack/ironic: [WIP] Migrate to session for glance client https://review.openstack.org/410767 | 16:26 |
| jroll | dtantsur: +2, want anyone else to look before I +A? | 16:26 |
| JayF | I just +2'd as well | 16:26 |
| mat128 | https://github.com/openstack-dev/devstack/blob/master/lib/stack#L21 | 16:27 |
| dtantsur | mat128, yes, this | 16:27 |
| dtantsur | if it does not exist (it was wrong in our case), nothing happens | 16:27 |
| mat128 | I wonder why, I'll submit a change for it (make it fail) linking to our experience | 16:28 |
| dtantsur | jroll, no, go ahead | 16:28 |
| dtantsur | mat128, thanks! | 16:28 |
| mat128 | I'll see where that gets us to | 16:28 |
| jroll | dtantsur: done | 16:28 |
| dtantsur | thnx | 16:28 |
| dtantsur | we have a patch which we really should drive through grenade before landing | 16:28 |
| dtantsur | actually, anybody knowing about databases is free to tell us that we're doing a horrible thing in https://review.openstack.org/#/c/397636/9/ironic_inspector/migrations/versions/d00d6e3f38c4_change_created_finished_at_type.py | 16:29 |
| patchbot | patch 397636 - ironic-inspector - Change (started|finished)_at column type | 16:29 |
| *** baoli has quit IRC | 16:29 | |
| dtantsur | :) | 16:29 |
| openstackgerrit | Karthik S proposed openstack/ironic-python-agent: WIP: NUMA-topology collector https://review.openstack.org/424729 | 16:29 |
| jroll | dtantsur: other than possibly taking a very long time? :) | 16:33 |
| jroll | it seems logical, though | 16:33 |
| dtantsur | yeah, I do realize it's going to lock the whole table for noticable time | 16:34 |
| openstackgerrit | Oksana Voshchana proposed openstack/ironic: WIP: TEST GRENADE DEV https://review.openstack.org/397126 | 16:34 |
| *** hamzy has quit IRC | 16:35 | |
| * dtantsur tries to wake up enough to review jroll's API patches | 16:35 | |
| jroll | heh | 16:35 |
| mat128 | dtantsur: https://review.openstack.org/#/c/424735/ and https://launchpad.net/bugs/1659042 | 16:36 |
| openstack | Launchpad bug 1659042 in devstack "stack_install_service silently fails when providing an invalid name" [Undecided,New] | 16:36 |
| patchbot | patch 424735 - openstack-dev/devstack - Ensure valid service names are passed to stack_ins... | 16:36 |
| *** trown is now known as trown|lunch | 16:37 | |
| rpioso | After configuring a cleaning network in /etc/ironic/ironic.conf and restarting the conductor, is there an easy way to confirm that the configuration has been applied? | 16:39 |
| jcook | For Rolling Upgrades, if the data in the database is versioned, how does pinning help? Data in DB is fromVer. Services are mix of fromVer and toVer. Services read data in fromVer. Services pass and save data in fromVer because the data in the db is in fromVer. All services become toVer. Data is then migrated to toVer. Data is now in toVer. Services now save to toVer since data in db is in toVer. Data is read as toVer and sent as toVer. | 16:40 |
| dtantsur | rpioso, for what definition of "applied"? unfortunately, you'll only know for sure when you try cleaning | 16:42 |
| vdrok | jcook: pinning is for rpc api iiuc, fromver/tover is oslo versioned objects | 16:42 |
| vdrok | jcook: rpc pinning ensures you don't call rpc methods with new arguments | 16:42 |
| rpioso | dtantsur: So, there's no config artifact that can be read, say via the CLI? | 16:43 |
| jcook | vdrok rpc api version does not correspond to data version? | 16:43 |
| vdrok | rpioso: I think all the config values are logged on startup, maybe that's only in debug mode tho, not sure | 16:44 |
| vdrok | jcook: nope, see https://review.openstack.org/#/c/407491/30/ironic/common/release_mappings.py :) | 16:44 |
| patchbot | patch 407491 - ironic - Add RPC and object version pinning | 16:44 |
| dtantsur | yes, in debug mode | 16:44 |
| rpioso | vdrok, dtantsur: I'll give that a try. Thank you! | 16:45 |
| vdrok | jcook: 'rpc' is RPC API version, and each object has its own version | 16:45 |
| jcook | vdrok I was trying to understand from the spec, this: "To maintain data consistency, when a ToVer object is retrieved from the DB by a ToVer service, which is still pinned to FromVer, it should ignore the globally configured pin for this instance of the object and use its actual version." | 16:45 |
| jcook | vdrok is the pin not for the outer version, not the inner versions in the mapping you linked, which corresponds to objects, which corresponds to data? | 16:47 |
| * jroll lunches | 16:47 | |
| *** dmellado has joined #openstack-ironic | 16:48 | |
| mariojv | does anyone know how to get IPA logs when running functional tests? | 16:48 |
| vdrok | jcook: I think in this case, it's object version pin, not RPC pin. so, inner dicts. | 16:48 |
| mariojv | i can't seem to get the normal tricks working that are ok in unit tests | 16:48 |
| jcook | vdrok in that case, I think my question still stands. IIUC, the object versions would map to the data versions. How does pinning object / data versions help? | 16:50 |
| openstackgerrit | Moshe Levi proposed openstack/ironic-inspector: Adding InfiniBand Support https://review.openstack.org/264257 | 16:52 |
| vdrok | jcook: I think object version pinning is needed when communicating between different versions of services. serializer uses the pin when sending object over rpc | 16:52 |
| jcook | vdrok that can be ensured by db version | 16:52 |
| moshele | milan: hi can you review https://review.openstack.org/#/c/264257/ ? | 16:53 |
| patchbot | patch 264257 - ironic-inspector - Adding InfiniBand Support | 16:53 |
| jcook | db data version that is | 16:53 |
| *** yibo has quit IRC | 16:53 | |
| milan | moshele, hey, in my todo, most likely tomorrow | 16:53 |
| *** dmellado has quit IRC | 16:53 | |
| jcook | vdrok the spec explicitly ignores the pin when the db version is newer, and as such, I don't understand how a pin helps when the data version is the authoritative source of truth | 16:54 |
| *** e0ne has quit IRC | 16:54 | |
| vdrok | jcook: lemme look at the spec, that sentence you're referring to seems suspicious. | 16:54 |
| *** jkilpatr has quit IRC | 16:54 | |
| *** rajinir has joined #openstack-ironic | 16:55 | |
| openstackgerrit | Merged openstack/ironic: Allow to use no nova installation https://review.openstack.org/420688 | 16:56 |
| *** lucasagomes is now known as lucas-afk | 16:58 | |
| *** dmellado has joined #openstack-ironic | 16:59 | |
| *** mrtenio has joined #openstack-ironic | 17:00 | |
| *** moshele has quit IRC | 17:01 | |
| rloo | jcook, vdrok: i haven't been paying attention (and am in the middle of something) but that may have to do with the situation where all the conductor & api services have upgraded and unpinning, so there are some api services that are still pinned but others that are already unpinned (and conductors are unpinned) -- an unpinned api service could cause an object with new version in db, but a pinned api service could be accessing it? or maybe it | 17:01 |
| rloo | isn't that. i think there are some corner cases... | 17:01 |
| vdrok | jcook: yeah, http://specs.openstack.org/openstack/ironic-specs/specs/not-implemented/support-rolling-upgrade.html#use-actual-versions-when-reading-values-from-db-api-conductor-db | 17:02 |
| jcook | rloo right, I'm wondering how the pin helps? Is not the desired outcome achieved with no pin since the db data version is the authoritative source of truth anyways? | 17:03 |
| dtantsur | Tuesday beer time, see you tomorrow! | 17:03 |
| *** aNuposic has joined #openstack-ironic | 17:03 | |
| rloo | jcook: sorry, i don't want to take time away from what i'm doing to really *think* about rolling upgrades. | 17:03 |
| TheJulia | vsaienk0: I reviewed the patch you asked to be reviewed | 17:03 |
| jcook | rloo no worries | 17:04 |
| vdrok | jcook: during the process of upgrade, while we still have the services of different versions, having tover in the DB should not be possible. When you've upgraded everything and start unpinning, you need to ignore the pin. We calculate what we write to DB by looking at the pin on the first stage | 17:04 |
| openstackgerrit | Mario Villaplana proposed openstack/ironic-python-agent: WIP: IPA rescue extension https://review.openstack.org/423521 | 17:04 |
| vdrok | jcook: I mean, to know what we write to version column | 17:04 |
| vdrok | good night dtantsur | 17:05 |
| *** dtantsur is now known as dtantsur|afk | 17:05 | |
| vdrok | and good morning milan :) | 17:05 |
| jcook | vdrok right, fromVer/null will be in db until we write a newer version. The pin says "use version in db". Unpin says "use newer version and ignore all pins" iiuc | 17:05 |
| *** snecklifter has quit IRC | 17:07 | |
| vdrok | jcook: when you are eg creating a new node during rolling upgrade, you need a pin to determine which value to write as version in DB | 17:07 |
| jcook | vdrok If the the version in the database is used as authoritative source of truth on what to save, read, and send, I don't see how pinning adds anything. | 17:07 |
| jcook | vdrok you write same version that is already in db | 17:07 |
| *** cfarquhar has joined #openstack-ironic | 17:08 | |
| jcook | before data update, the data will all be fromVer, so you write fromVer, after services are updated, data is updated to toVer, and you write toVer | 17:09 |
| milan | morning vdrok! :D | 17:09 |
| vdrok | jcook: by looking at all nodes? Some of them, if were not yet touched during rolling upgrade by online migration script, are not upgraded. you'd have to iterate through all the nodes to find the lowest version | 17:09 |
| *** jkilpatr has joined #openstack-ironic | 17:09 | |
| jcook | vdrok what do you mean by nodes? | 17:09 |
| jcook | vdrok as in api or conductors? | 17:09 |
| vdrok | node records in the DB | 17:10 |
| jcook | vdrok the version is per table or per schema? | 17:11 |
| vdrok | jcook: if you perform some action on the node, it will be upgraded, if not, it will remain on old version. that's the reason of adding this "online migration script" that will process all nodes not touched by any actions, and upgrade them | 17:11 |
| vdrok | per row :) | 17:11 |
| jcook | vdrok if the row is fromVer, write fromVer, if the row is toVer, write toVer | 17:12 |
| jcook | no iteration should be required | 17:12 |
| jcook | the pin says, write fromVer unless there is toVer | 17:13 |
| vdrok | jcook: there still is the case when there is no version in the record, the current situation | 17:13 |
| jcook | instead just write whatever version is there already | 17:13 |
| jcook | vdrok yes the N->O update when version is "null" | 17:13 |
| jcook | "null" == first fromVer | 17:14 |
| jcook | that would be equivalent to reading fromVer | 17:14 |
| jcook | maybe I'm missing something. I don't see how the pin helps. | 17:15 |
| jcook | it says use fromVer unless toVer, which should be equivalent to use version in db | 17:15 |
| *** yibo has joined #openstack-ironic | 17:16 | |
| vdrok | jcook: hmm, ok, I still can not get what to do with newly created nodes then. You need to make sure that the node created can be read by all services. If you don't know if you're pinned or not, how do you do that. | 17:18 |
| JayF | mariojv: heh, I git blamed the functional tests to see who knew about it ... and got your name for like half of it | 17:19 |
| jcook | vdrok ah, good point. I had not considered. I think you read a random row (or first row) and use that version. | 17:19 |
| JayF | lol | 17:19 |
| *** yolanda has quit IRC | 17:19 | |
| mariojv | JayF: that was around a year and a half ago with JoshNang | 17:19 |
| mariojv | so my memory about it is kind of rusty lol | 17:20 |
| mariojv | JayF: i got logging working | 17:20 |
| mariojv | had to modify the internals of agent.py to use the multiprocessing logger instead of oslo | 17:20 |
| JayF | oh, that's gross | 17:20 |
| vdrok | jcook: but you don't know if it was touched by the online migration or not. it may be old, and you'll be saving old format. if it's new, you know you can do new, yeah | 17:20 |
| rpioso | vdrok, dtantsur: That did the trick. Thanks, again. | 17:20 |
| mariojv | yeah, but will help for debugging at least | 17:20 |
| JayF | mariojv: you think there's any way to hook in oslo.log? | 17:20 |
| mariojv | i dunno why we even did that in agent.py | 17:20 |
| JayF | mariojv: so it always works? | 17:20 |
| mariojv | JayF: there's probably some evil way with mocks or something | 17:21 |
| openstackgerrit | Merged openstack/ironic-inspector: Skip brbm-inspector veth if IRONIC_IS_HARDWARE == True https://review.openstack.org/423757 | 17:21 |
| jcook | vdrok yeah, I was just considering that. | 17:21 |
| mariojv | but i'm going to try this out for now, for getting this patch working | 17:21 |
| JayF | awesome, do you just wanna vidyo pair on it then? since you actually have working logging and I don't? | 17:21 |
| mariojv | JayF: sure, give me like 10-15 minutes first to grab lunch ? | 17:21 |
| jcook | vdrok I suppose you would have to get latest version for new writes which could be obtained in a handful of ways | 17:22 |
| JayF | mariojv: absolutely | 17:22 |
| jcook | you don't want to orphan a row on a older version | 17:22 |
| *** yolanda has joined #openstack-ironic | 17:22 | |
| vdrok | yup | 17:22 |
| openstackgerrit | Nisha Agarwal proposed openstack/ironic: SNMP agent support for OOB inspection for iLO Drivers https://review.openstack.org/372428 | 17:22 |
| mariojv | cool - if you want to try it out in the interim, comment out oslo logging and use this http://paste.openstack.org/show/596284/ | 17:23 |
| mariojv | inside agent.py | 17:23 |
| jcook | vdrok although, the case you mention is a bug with pins too? | 17:23 |
| jcook | vdrok toVer service with fromVer pin writes new row during migration to fromVer and it is orphaned | 17:23 |
| jcook | vdrok so you would handle that case the same with or without pin, no? | 17:24 |
| jcook | vdrok which takes me back to how does pin help? | 17:25 |
| openstackgerrit | Nisha Agarwal proposed openstack/ironic: SNMP agent support for OOB inspection for iLO Drivers https://review.openstack.org/372428 | 17:25 |
| vdrok | jcook: kind of, I think you're supposed to run online migrations after the upgrade finishes completely. So this row will get processed by it. In case of not knowing the pin, suppose it gets added the same time the last not-upgraded node gets upgraded by online migration script. then it gets orphaned. | 17:26 |
| vdrok | that is the only thing I could think of right now :) | 17:26 |
| *** yibo has quit IRC | 17:28 | |
| *** yibo has joined #openstack-ironic | 17:28 | |
| vdrok | xek: could you check this discussion when you're around? | 17:31 |
| jcook | vdrok ah, so pin ensures one thing, new rows do not get orphaned on old version when writing during migration. Though could be avoided without pinning by having data migration continue until all rows are upgraded and having new writes depend on either version of a row (i.e. first row) or by an overarching version in the db or some other similar algorithm or construct. | 17:34 |
| *** baoli has joined #openstack-ironic | 17:35 | |
| *** mjura has quit IRC | 17:35 | |
| jcook | I think similar could be achieved with rpc pinning, removing the need to rolling restart services twice. | 17:35 |
| vdrok | jcook: yup, might be worth commenting on that on some of the patches. In case of RPC, you mean looking up RPC version depending on object version? | 17:36 |
| jcook | vdrok I hadn't thought too much about specific mechanism, but essentially the RPC version is obtained from the db and upgraded during db migration phase once all services are upgraded | 17:37 |
| jcook | so yeah, instead of pins, just get info from db | 17:37 |
| vdrok | jcook: RPC version is not stored in API though :) | 17:37 |
| vdrok | err in DB | 17:37 |
| jcook | yeah, it would require it either be stored or inferred | 17:37 |
| jcook | I believe inference is possible, though storing perhaps cleaner | 17:38 |
| vdrok | having services table with that was considered, but dropped at some point | 17:38 |
| *** amotoki has quit IRC | 17:38 | |
| vdrok | jcook: the only thing I find problematic is "continue until all rows are upgraded" with migration, if you get constant race between upgrade and adding new row :) | 17:41 |
| jcook | vdrok lock first row, read version, write new version, unlock | 17:42 |
| jcook | vdrok or something similar | 17:42 |
| jcook | s/write new version/write new row with first row version/ | 17:42 |
| vdrok | yup, the current approach is advertised as "no locking" :) | 17:43 |
| xavierr | sambetts: around? | 17:43 |
| jcook | vdrok seems hacky though, just add data version as a value | 17:43 |
| *** derekh has quit IRC | 17:44 | |
| vdrok | jcook: yup, we were discussing it actually with rloo yesterday as an option to get part of the patches in this cycle | 17:44 |
| jcook | vdrok then when data migration begins, it first updates the current version in db | 17:44 |
| jcook | vdrok and when I say version, I don't mean in the rows, but somewhere else, like in a versions table | 17:44 |
| vdrok | to just add version now, as usual upgrade, and then build up on that | 17:44 |
| jcook | vdrok I better understand how pinning is used now. I don't think it's needed in general when data is versioned though. | 17:46 |
| vdrok | jcook: yup. I see your point now I think. we may revise stuff if people agree on that | 17:46 |
| jcook | vdrok cool, good chat. Thanks for walking me through it | 17:47 |
| vdrok | or maybe I've missed something :) anyway, worth adding comments somewhere on that | 17:47 |
| vdrok | np :) | 17:47 |
| jcook | vdrok I can add a node to spec or in etherpad if helpful | 17:47 |
| jcook | vdrok where is best place? | 17:47 |
| *** ijw has joined #openstack-ironic | 17:48 | |
| vdrok | jcook: as spec is merged, i think it's the actual patches now - https://review.openstack.org/407491 - this one is first in chain | 17:48 |
| patchbot | patch 407491 - ironic - Add RPC and object version pinning | 17:48 |
| *** ijw has quit IRC | 17:48 | |
| openstackgerrit | Merged openstack/ironic-inspector: Make grenade actually upgrade our source code https://review.openstack.org/424680 | 17:48 |
| *** ijw has joined #openstack-ironic | 17:49 | |
| *** aNuposic has quit IRC | 17:50 | |
| *** aNuposic has joined #openstack-ironic | 17:50 | |
| *** Sukhdev has joined #openstack-ironic | 17:52 | |
| *** mgoddard has quit IRC | 17:56 | |
| aNuposic | TheJulia: Hi Julia, thanks for reviewing https://review.openstack.org/#/c/407639/, wrt https://review.openstack.org/#/c/407639/6/ironic/conductor/manager.py@2587 my RFE mentions that this would be "yet another simple way for operators" to talk with radosgw. | 17:57 |
| patchbot | patch 407639 - ironic - Config drive support for Ceph | 17:57 |
| patchbot | patch 407639 - ironic - Config drive support for Ceph | 17:57 |
| openstackgerrit | Pavlo Shchelokovskyy proposed openstack/python-ironicclient: DNM test stable/newton gates https://review.openstack.org/424779 | 17:59 |
| *** athomas has quit IRC | 17:59 | |
| aNuposic | TheJulia: RFE - https://bugs.launchpad.net/ironic/+bug/1642719 | 18:00 |
| openstack | Launchpad bug 1642719 in Ironic "[RFE] RADOSGW authentication mechanism for storing config drive in Ceph" [Wishlist,In progress] - Assigned to Anup (anup-d-navare) | 18:00 |
| *** ralonsoh has quit IRC | 18:02 | |
| *** krtaylor has quit IRC | 18:02 | |
| *** Nisha_brb has quit IRC | 18:02 | |
| aarefiev | milan: hey, around ? | 18:03 |
| *** dprince has quit IRC | 18:04 | |
| *** ijw has quit IRC | 18:04 | |
| *** amotoki has joined #openstack-ironic | 18:04 | |
| *** ijw has joined #openstack-ironic | 18:05 | |
| jcook | vdrok added a comment there, thanks for the helpful conversation | 18:05 |
| *** ijw has quit IRC | 18:05 | |
| *** strigazi is now known as strigazi_AFK | 18:05 | |
| *** ijw has joined #openstack-ironic | 18:05 | |
| vdrok | you're welcome! | 18:06 |
| milan | aarefiev, yup :) | 18:06 |
| *** amotoki has quit IRC | 18:06 | |
| aarefiev | milan: re: https://review.openstack.org/#/c/397636/9/ironic_inspector/test/unit/test_migrations.py | 18:06 |
| patchbot | patch 397636 - ironic-inspector - Change (started|finished)_at column type | 18:06 |
| openstackgerrit | Mario Villaplana proposed openstack/ironic-python-agent: WIP: IPA rescue extension https://review.openstack.org/423521 | 18:07 |
| milan | aarefiev, shoot :) | 18:07 |
| aarefiev | I've posted comment there | 18:07 |
| * milan checks | 18:07 | |
| milan | aarefiev, I completely missed it sorry O:-) | 18:08 |
| milan | aarefiev, LGTM then | 18:08 |
| *** dprince has joined #openstack-ironic | 18:09 | |
| aslezil | aarefiev: sambetts: jayF: jroll: (https://review.openstack.org/#/c/404372/). Could you please review the spec for collecting biosdevname of NIC. Updated spec as suggested. Needs one +2 to land the patch. | 18:10 |
| patchbot | patch 404372 - ironic-inspector-specs - Collect NIC name given by BIOS | 18:10 |
| JayF | aslezil: I'll take a look at it, but generally I don't +2 specs for inspector | 18:10 |
| aarefiev | np, thanks for review, milan, I hope to fix this bug asap, as introspection w/o timeout ... | 18:11 |
| aslezil | thanks jayF: | 18:11 |
| milan | aarefiev, I see | 18:11 |
| milan | yeah | 18:11 |
| milan | I wanted to give it a spin in Devstack too | 18:11 |
| aarefiev | aslezil: sorry late for me, I'll take a look tomorrow | 18:11 |
| milan | but looks OK | 18:11 |
| *** trown|lunch is now known as trown | 18:12 | |
| aslezil | Thanks aarefiev: | 18:12 |
| *** dprince has quit IRC | 18:13 | |
| *** rama_y has joined #openstack-ironic | 18:16 | |
| *** rama_y has left #openstack-ironic | 18:17 | |
| *** rama_y has joined #openstack-ironic | 18:17 | |
| *** aarefiev is now known as aarefiev_afk | 18:18 | |
| *** dprince has joined #openstack-ironic | 18:20 | |
| sambetts | night all o/ | 18:22 |
| openstackgerrit | Merged openstack/ironic-specs: Promote iPXE to separate boot interface https://review.openstack.org/385572 | 18:22 |
| *** sambetts is now known as sambetts|afk | 18:22 | |
| jroll | yay, internet outage | 18:22 |
| *** jkilpatr_ has joined #openstack-ironic | 18:22 | |
| *** jkilpatr has quit IRC | 18:24 | |
| vdrok | good night sambetts|afk | 18:25 |
| *** hamzy has joined #openstack-ironic | 18:27 | |
| *** mgoddard has joined #openstack-ironic | 18:33 | |
| jcook | jroll does that mean your internets now works? | 18:34 |
| jroll | jcook: no, it means I'm tethered | 18:35 |
| jcook | :sadness: | 18:35 |
| jroll | might drop and go do errands/gym instead | 18:35 |
| jcook | +1 | 18:35 |
| vdrok | good night everyone! | 18:37 |
| *** tesseract has quit IRC | 18:39 | |
| *** Sukhdev has quit IRC | 18:43 | |
| openstackgerrit | Michael Turek proposed openstack/python-ironicclient: Add --wait to OSC provisioning commands https://review.openstack.org/354806 | 18:44 |
| *** krtaylor has joined #openstack-ironic | 18:44 | |
| rloo | bye vdrok! | 18:45 |
| *** moshele has joined #openstack-ironic | 18:46 | |
| *** Sukhdev has joined #openstack-ironic | 18:47 | |
| *** moshele has quit IRC | 18:50 | |
| *** Goneri has quit IRC | 18:51 | |
| *** jralph has joined #openstack-ironic | 18:56 | |
| *** cfarquhar has quit IRC | 18:58 | |
| *** Sukhdev has quit IRC | 19:01 | |
| openstackgerrit | Xavier proposed openstack/ironic: Validation before perform node deallocation https://review.openstack.org/386014 | 19:03 |
| openstackgerrit | Michael Turek proposed openstack/python-ironicclient: Add --wait to OSC provisioning commands https://review.openstack.org/354806 | 19:11 |
| openstackgerrit | Ruby Loo proposed openstack/python-ironicclient: Add --no-maintenance to OSC 'baremetal node list' https://review.openstack.org/373096 | 19:11 |
| *** dyasny has quit IRC | 19:11 | |
| *** dyasny has joined #openstack-ironic | 19:11 | |
| openstackgerrit | Jay Faulkner proposed openstack/ironic-python-agent: WIP: IPA rescue extension https://review.openstack.org/423521 | 19:12 |
| JayF | mariojv: ^ | 19:12 |
| *** karts has joined #openstack-ironic | 19:12 | |
| mariojv | looking | 19:12 |
| mariojv | JayF: one thing is that ExecStopPost will make finalize_rescue always run, even if IPA has a non-zero exit | 19:13 |
| JayF | 19:13:41 <@JayF> mariojv: a change I didn't make, that it probably needs, will be a big if at the top of finalize_rescue | 19:14 |
| JayF | 19:13:52 <@JayF> mariojv: that makes it bail if one of the files (like maybe the password file?) for rescue is not in place | 19:14 |
| mariojv | JayF: i thought that could have some bad implications, but it might be safe since we check for hte files in the script | 19:14 |
| JayF | copying from the other channel :) | 19:14 |
| rloo | jlvillal and others: missing feature in osc to review if you'd like: https://review.openstack.org/#/c/373096/ | 19:14 |
| patchbot | patch 373096 - python-ironicclient - Add --no-maintenance to OSC 'baremetal node list' | 19:14 |
| rloo | jlvillal: this was one of the commands that dmitry needed in his troubleshooting instructions | 19:14 |
| mariojv | JayF: there is a check on L30: https://review.openstack.org/#/c/423521/6/imagebuild/coreos/oem/finalize_rescue.sh | 19:15 |
| patchbot | patch 423521 - ironic-python-agent - WIP: IPA rescue extension | 19:15 |
| JayF | mariojv: perfect, except we don't need to dep on configdrive long-term ;P | 19:15 |
| *** karthiks has quit IRC | 19:15 | |
| mariojv | JayF: ah, right, that should be removed | 19:15 |
| JayF | mariojv: either way, good enough to get us a good test for rescue as soon as we have the other image changes pass tempest | 19:15 |
| JayF | mariojv: which is really our target now: getting an environment we can test in | 19:15 |
| mariojv | going to push up 1 more change to remove that configdrive check | 19:16 |
| rloo | JayF, jlvillal, jroll: sorry, I just fixed this based on dmitry's suggestion but the rfe wasn't approved. i could approve it but is it a conflict of interest? https://bugs.launchpad.net/python-ironicclient/+bug/1619090 | 19:17 |
| openstack | Launchpad bug 1619090 in python-ironicclient "[RFE] Extend OSC "node list" to fetch nodes that are NOT in maintenance" [Wishlist,In progress] - Assigned to Ruby Loo (rloo) | 19:17 |
| *** bcornec1 has quit IRC | 19:18 | |
| JayF | I'll look real quick | 19:18 |
| *** alexpilotti has quit IRC | 19:18 | |
| JayF | rloo: commented my agreement with the rfe | 19:19 |
| rloo | JayF: thx! | 19:19 |
| *** alexpilotti has joined #openstack-ironic | 19:19 | |
| openstackgerrit | Mario Villaplana proposed openstack/ironic-python-agent: WIP: IPA rescue extension https://review.openstack.org/423521 | 19:21 |
| openstackgerrit | Merged openstack/ironic: Do not use user token in neutron client https://review.openstack.org/422561 | 19:21 |
| rloo | JayF: here's a similar one that wasn't decided either: https://bugs.launchpad.net/python-ironicclient/+bug/1619091 | 19:21 |
| openstack | Launchpad bug 1619091 in python-ironicclient "[RFE] Extend OSC "node list" command to fetch nodes without instance UUID" [Wishlist,In progress] - Assigned to Ukesh (ukeshkumar) | 19:21 |
| *** alexpilo_ has joined #openstack-ironic | 19:22 | |
| openstackgerrit | Merged openstack/ironic: Update multi-tenancy documentation https://review.openstack.org/378138 | 19:23 |
| JayF | rloo: I wish we didn't already have --associated :( --unassociated/assosicated is much more confusing than instance/no-instance | 19:23 |
| rloo | JayF: I agree. | 19:23 |
| rloo | JayF: but not sure what to do about it now. | 19:23 |
| *** alexpilotti has quit IRC | 19:23 | |
| rloo | JayF: I mean, we could add instance/no-instance. | 19:23 |
| rloo | JayF: and deprecate associated. | 19:24 |
| rloo | JayF: but probably need a few more acks on that. | 19:24 |
| JayF | I mean, here's my current logic: --associated exists | 19:24 |
| JayF | a negative for it should exist | 19:25 |
| JayF | and it's not much tougher to replace --associated/--unassociated as it is to just replace one | 19:25 |
| JayF | so I think I'm OK with adding --unassociated and just improving the UI later if more folks than just me dislike it :) | 19:25 |
| rloo | JayF: ok, as opposed to just deprecating associated and doing the replacement now? | 19:25 |
| JayF | I'm OK with either direction, is what I mean | 19:26 |
| JayF | I think this is a clear incremental progression and don't wanna force a deprecation/replacement cycle on someone who just wants to add a clearly missing feature | 19:26 |
| rloo | JayF: yeah, i know what you mean. i don't like busywork, if we know where we want to go to and it is easy, we should go. | 19:26 |
| rloo | JayF: my bad though. i filed this in last cycle and forgot to follow up. | 19:27 |
| *** alexpilo_ has quit IRC | 19:27 | |
| JayF | I mean, we all miss stuff occassionally | 19:27 |
| rloo | JayF: i'll review the unassociated patch that was submitted and approve for 'unassociated'. | 19:27 |
| JayF | rloo: like after seeing your ping yesterday (sorry for not responding immediately, I was out sick), I gotta go followup on that admin-guid stuff :x | 19:27 |
| rloo | JayF: thx! | 19:27 |
| *** sayantani01 has quit IRC | 19:27 | |
| JayF | *guide | 19:27 |
| rloo | JayF: oh, sorry you were sick. hope you're feeling better today. | 19:27 |
| JayF | I guess dropping an "e" can be a pretty big difference as "GUID" is a thing | 19:27 |
| JayF | lol | 19:28 |
| JayF | it' | 19:28 |
| *** sayantani01 has joined #openstack-ironic | 19:28 | |
| rloo | JayF: yeah, i was wondering if we had opened a bug. hard to remember these things later. | 19:28 |
| rloo | JayF: :D | 19:28 |
| JayF | it's fine, I'm feeling better. Just have a reccuring thing that happens from time to time | 19:28 |
| *** ijw has quit IRC | 19:28 | |
| rloo | JayF: ok. the guide thing probably has a later deadline than the code, so probably don't need to rush. although i guess we need them to approve any changes. | 19:29 |
| JayF | yeah, I don't think it's urgent | 19:29 |
| JayF | just going to make myself a physical note on my monitor so it doesn't get forgotten again | 19:29 |
| rloo | JayF: although i shudder to think about how the docs have diverged... | 19:29 |
| JayF | I have a handful of small docs things I want to take care of after the release starts | 19:29 |
| JayF | it's litearlly one page, in the "official" admin-guide | 19:29 |
| JayF | that appears to have been copy-pasted a year or more ago | 19:29 |
| JayF | I gotta just put a patch up to delete the badness and link back | 19:30 |
| JayF | I'll probably do that right now, in fact... | 19:30 |
| rloo | JayF: +1 | 19:30 |
| *** sayantani01 has quit IRC | 19:32 | |
| *** ChubYann has joined #openstack-ironic | 19:39 | |
| *** harlowja has joined #openstack-ironic | 19:41 | |
| *** Sukhdev has joined #openstack-ironic | 19:49 | |
| *** ijw has joined #openstack-ironic | 19:49 | |
| *** mgoddard has quit IRC | 19:50 | |
| *** ijw has quit IRC | 19:54 | |
| *** mrtenio has quit IRC | 20:01 | |
| *** alexpilotti has joined #openstack-ironic | 20:03 | |
| *** sayantani01 has joined #openstack-ironic | 20:11 | |
| *** Goneri has joined #openstack-ironic | 20:13 | |
| *** noama has quit IRC | 20:17 | |
| *** moshele has joined #openstack-ironic | 20:18 | |
| *** lennyb has quit IRC | 20:18 | |
| *** cdaniel is now known as charlle-afk | 20:18 | |
| openstackgerrit | Andrey Shestakov proposed openstack/bifrost: Add socat package https://review.openstack.org/424255 | 20:20 |
| *** mgoddard has joined #openstack-ironic | 20:21 | |
| openstackgerrit | Andrey Shestakov proposed openstack/bifrost: Fix endpoint service name for inspector https://review.openstack.org/424227 | 20:21 |
| *** aNuposic has quit IRC | 20:25 | |
| *** vsaienko has joined #openstack-ironic | 20:27 | |
| *** dsneddon has joined #openstack-ironic | 20:40 | |
| *** e0ne has joined #openstack-ironic | 20:42 | |
| rloo | mjturek: you around still? this failed pep8: https://review.openstack.org/#/c/354806/ | 20:46 |
| patchbot | patch 354806 - python-ironicclient - Add --wait to OSC provisioning commands | 20:46 |
| mjturek | rloo: yep fixing now | 20:47 |
| mjturek | sorry about that | 20:47 |
| *** ppiela has quit IRC | 20:47 | |
| mjturek | just running pep8 to double check | 20:47 |
| rloo | mjturek: thx, was waiting for jenkins before reviewing :-( | 20:47 |
| openstackgerrit | Michael Turek proposed openstack/python-ironicclient: Add --wait to OSC provisioning commands https://review.openstack.org/354806 | 20:49 |
| mjturek | rloo ^ | 20:49 |
| *** amarao has joined #openstack-ironic | 20:49 | |
| rloo | thx mjturek! | 20:49 |
| mjturek | np! | 20:49 |
| *** aNuposic has joined #openstack-ironic | 20:50 | |
| *** ppiela has joined #openstack-ironic | 20:51 | |
| *** moshele has quit IRC | 20:57 | |
| jroll | that thing where you realize you need to commit your changes for reno to pick them up | 20:57 |
| * jroll just wasted 15 minutes | 20:57 | |
| jlvillal | jroll: :( I've been there. | 21:00 |
| *** gcb has joined #openstack-ironic | 21:01 | |
| *** jerrygb_ has joined #openstack-ironic | 21:01 | |
| jroll | a missing gd backtick | 21:01 |
| openstackgerrit | Jim Rollenhagen proposed openstack/ironic: Add dynamic interfaces fields to nodes API https://review.openstack.org/424720 | 21:01 |
| openstackgerrit | Jim Rollenhagen proposed openstack/ironic: Add dynamic driver functionality to REST API https://review.openstack.org/417970 | 21:01 |
| rloo | jroll: yeah, that is... suboptimal... :-( | 21:02 |
| * jroll is glad he derped out on this before he dove into client reno | 21:03 | |
| *** jerrygb has quit IRC | 21:03 | |
| *** jerrygb_ has quit IRC | 21:04 | |
| *** vsaienko has quit IRC | 21:05 | |
| *** alexpilotti has quit IRC | 21:08 | |
| *** alexpilotti has joined #openstack-ironic | 21:08 | |
| *** ijw has joined #openstack-ironic | 21:10 | |
| openstackgerrit | Mario Villaplana proposed openstack/python-ironicclient: Add support for RESCUE and UNRESCUE provision states https://review.openstack.org/408341 | 21:10 |
| dhellmann | jroll : the new version of reno should pick up staged changes | 21:10 |
| *** dyasny has quit IRC | 21:11 | |
| dhellmann | I'm working on making it pick up unstaged changes, but the underlying lib doesn't recognize those right now | 21:11 |
| jroll | dhellmann: ah, neat, thanks :) | 21:11 |
| JayF | dhellmann: do you highlight on "reno"? | 21:11 |
| JayF | lol | 21:11 |
| *** sacharya has quit IRC | 21:12 | |
| dhellmann | JayF : yes. It's called Beetlejuice-driven Support | 21:12 |
| dhellmann | :-) | 21:13 |
| JayF | nice | 21:13 |
| *** alexpilotti has quit IRC | 21:13 | |
| dhellmann | I do cliff, too, but you'd be surprised how often folks say "over a cliff" | 21:13 |
| openstackgerrit | Markos Chandras proposed openstack/bifrost: roles: bifrost-ironic-install: SUSE/Debian: Add gcc and python-pip packages https://review.openstack.org/424853 | 21:14 |
| *** sacharya has joined #openstack-ironic | 21:14 | |
| *** trown is now known as trown|brb | 21:14 | |
| JayF | dhellmann: I don't even know what cliff is, much less how to fall over it | 21:15 |
| dhellmann | JayF : http://docs.openstack.org/developer/cliff/ | 21:15 |
| dhellmann | the command line framework under openstack-client | 21:15 |
| JayF | I was about to say, that looks familiar | 21:16 |
| JayF | heh | 21:16 |
| JayF | working on ironic client hooks to OSC right now | 21:16 |
| dhellmann | yep, that's the lib | 21:16 |
| openstackgerrit | Annie Lezil proposed openstack/ironic-inspector-specs: Collect NIC name given by BIOS https://review.openstack.org/404372 | 21:19 |
| *** mgoddard has quit IRC | 21:20 | |
| *** vsaienko has joined #openstack-ironic | 21:21 | |
| *** dyasny has joined #openstack-ironic | 21:26 | |
| vinsh | Hey all. I don't see it in scroll back.. is ironic-python-agent busted for disk image builder today? Images built 2 days ago for a deploy image worked fine.. today they fail with "ironic-python-agent UnboundLocalError: local variable "total' referenced before assignment. | 21:28 |
| *** trown|brb is now known as trown | 21:31 | |
| *** jkilpatr_ has quit IRC | 21:31 | |
| *** jcoufal has quit IRC | 21:31 | |
| *** vsaienko has quit IRC | 21:34 | |
| JayF | vinsh: DIB is not officially supported as an IPA image :( I know lots of people use it, but because today we don't test it in the gate we can't guarantee it does/doesn't work | 21:36 |
| vinsh | ah ok! What is supported? | 21:36 |
| JayF | vinsh: that being said; it sounds like you might have a problem that could exist outside of dib | 21:36 |
| JayF | vinsh: well, TinyIPA and CoreOS iamges are tested in the gate, but we do expect DI Bto work | 21:36 |
| JayF | vinsh: it's just not tested so it's very possible it's broken | 21:36 |
| vinsh | Id rather just stick with what you are testing/using most.. good call | 21:37 |
| JayF | TheJulia: ^ do you have any idea? IDK who works with DIB images a lot? | 21:37 |
| JayF | vinsh: fwiw we are workign to get dib images officially supported, it's just a long road | 21:37 |
| vinsh | I bet :) | 21:37 |
| mat128 | JayF: (gotta go but) TripleO uses DIB images IIRC | 21:41 |
| JayF | mat128: yeah, just w/o it in the ipa gate + repo I don't even know where to start with troubleshooting it :) | 21:42 |
| mat128 | 100% with you | 21:42 |
| * JayF also troubleshooting rescue patches in another window | 21:43 | |
| JayF | nothing like it saying it finished the rescue without ever even making so much as an api call to the agent /o\ | 21:43 |
| *** e0ne has quit IRC | 21:45 | |
| *** milan has quit IRC | 21:47 | |
| NobodyCam | Good Morning (afternoon) Ironic'ers | 21:52 |
| *** aNuposic has quit IRC | 21:58 | |
| joanna | morning :) | 22:00 |
| NobodyCam | :) | 22:00 |
| joanna | joking, afternoon :) | 22:00 |
| NobodyCam | http://www.total-knowledge.com/~ilya/mips/ugt.html | 22:01 |
| *** amotoki has joined #openstack-ironic | 22:02 | |
| *** priteau has quit IRC | 22:04 | |
| *** baoli has quit IRC | 22:08 | |
| *** jkilpatr_ has joined #openstack-ironic | 22:09 | |
| *** aNuposic has joined #openstack-ironic | 22:09 | |
| openstackgerrit | Solio Sarabia proposed openstack/ironic: WIP/DNR: Move ironic_tempest_plugin to a new repo https://review.openstack.org/424874 | 22:12 |
| openstackgerrit | Mario Villaplana proposed openstack/ironic-python-agent: WIP: IPA rescue extension https://review.openstack.org/423521 | 22:17 |
| *** baoli has joined #openstack-ironic | 22:19 | |
| openstackgerrit | Solio Sarabia proposed openstack/ironic: WIP/DNR: Move ironic_tempest_plugin to a new repo https://review.openstack.org/424874 | 22:20 |
| *** sayantani01 has quit IRC | 22:22 | |
| *** sayantani01 has joined #openstack-ironic | 22:22 | |
| *** sayantani01 has quit IRC | 22:23 | |
| *** sayantani01 has joined #openstack-ironic | 22:23 | |
| *** amarao has quit IRC | 22:23 | |
| *** baoli has quit IRC | 22:24 | |
| *** sayantani01 has quit IRC | 22:25 | |
| *** rook has quit IRC | 22:25 | |
| *** sayantani01 has joined #openstack-ironic | 22:26 | |
| *** krtaylor has quit IRC | 22:27 | |
| *** alexpilotti has joined #openstack-ironic | 22:27 | |
| openstackgerrit | Joanna Taryma proposed openstack/ironic: WIP host ipxe static assets in devstack on :80 https://review.openstack.org/424374 | 22:28 |
| *** sayantani01 has quit IRC | 22:30 | |
| *** baoli has joined #openstack-ironic | 22:32 | |
| *** alexpilotti has quit IRC | 22:32 | |
| *** rook has joined #openstack-ironic | 22:35 | |
| *** karts has quit IRC | 22:35 | |
| *** rook is now known as Guest7769 | 22:35 | |
| *** baoli has quit IRC | 22:36 | |
| *** dprince has quit IRC | 22:37 | |
| JayF | vinsh: I just got that error locally, doing some other testing | 22:39 |
| JayF | vinsh: in !DIB image | 22:39 |
| mariojv | yeah, in coreos | 22:39 |
| JayF | vinsh: going to investigate | 22:39 |
| *** moshele has joined #openstack-ironic | 22:40 | |
| vinsh | I like using dib for ubuntu/debain for IPA because i'm more familiar with that os.. makes debuging easier. | 22:40 |
| jroll | ok, driver composition API patch is green and afaik ready to merge: https://review.openstack.org/#/c/417970/ | 22:41 |
| patchbot | patch 417970 - ironic - Add dynamic driver functionality to REST API | 22:41 |
| vinsh | I pulled down the pre-build coreOS for now | 22:41 |
| jroll | I'll be doing the client reno cleanup tomorrow, today was kind of a wash :( | 22:41 |
| JayF | jroll: got a sec? | 22:43 |
| JayF | jroll: found an issue and not certain the best way to get around it, realted to the bug vinsh reported | 22:43 |
| jroll | JayF: no, it's nearly 6pm | 22:43 |
| jroll | I have about 5 minutes | 22:43 |
| JayF | okay, it's fine then, go | 22:43 |
| JayF | tl;dr: psutil requirements in IPA != those in global requirements | 22:43 |
| JayF | and that failure seems to now be breaking things | 22:44 |
| jroll | um | 22:44 |
| JayF | in ipa -> psutil<2.0.0,>=1.1.1 # BSD | 22:44 |
| JayF | psutil>=1.2.1 # BSD | 22:44 |
| JayF | in ^ g-r | 22:44 |
| JayF | and u-c is ==5.0.0 | 22:44 |
| jroll | https://github.com/openstack/ironic-python-agent/blob/master/requirements.txt#L17 | 22:45 |
| JayF | and the error we just found looks like it's caused by psutil incompatibility | 22:45 |
| jroll | says >=1.2.1 | 22:45 |
| *** alexpilotti has joined #openstack-ironic | 22:45 | |
| JayF | well wtf commit was I looking at | 22:45 |
| jroll | idk | 22:46 |
| jroll | is it breaking locally or? | 22:46 |
| JayF | it's breaking locally for us | 22:46 |
| JayF | after vinsh reported it | 22:46 |
| JayF | I suspect it's intermittant | 22:46 |
| jroll | looks like gate is happy as of 7 hours ago | 22:46 |
| JayF | but not certain | 22:46 |
| JayF | gate passed on mariojv's patch more recently | 22:46 |
| * vinsh shouldn't have put a curse on it. | 22:47 | |
| JayF | but it failed locally identically to what was posted in here independently | 22:47 |
| JayF | so I know something is screwy | 22:47 |
| * JayF will find it | 22:47 | |
| *** karts has joined #openstack-ironic | 22:47 | |
| jroll | was updated 7 days ago https://review.openstack.org/#/c/420206/ | 22:47 |
| patchbot | patch 420206 - ironic-python-agent - Updated from global requirements (MERGED) | 22:47 |
| JayF | and in g-r they force psutil to 5.0 now | 22:47 |
| JayF | so we took a 4 major version bump | 22:48 |
| JayF | lol | 22:48 |
| JayF | vinsh: did you file a bug about your failure yet? | 22:48 |
| vinsh | I can do that for you now, now that I know its not just user error on my end. | 22:48 |
| vinsh | against ipa? | 22:48 |
| JayF | yes please, and link it to me in here when you're done | 22:48 |
| JayF | I'll add my research to it | 22:48 |
| vinsh | doing so now | 22:49 |
| jroll | JayF: https://review.openstack.org/#/q/project:openstack/requirements+psutil | 22:49 |
| jroll | so yeah jan 16 https://review.openstack.org/#/c/333717/ | 22:49 |
| patchbot | patch 333717 - requirements - Remove upper cap for psutil (MERGED) | 22:49 |
| jroll | and u-c just hit | 22:49 |
| jroll | that's fun | 22:49 |
| JayF | timing wise that fits as to when it broke us | 22:49 |
| *** alexpilotti has quit IRC | 22:49 | |
| jroll | could probably revert that last one or work to fix it | 22:50 |
| jroll | lamesauce, thanks for digging on it | 22:50 |
| * jroll out | 22:50 | |
| *** david-lyle has quit IRC | 22:50 | |
| JayF | vinsh: it's possible even our autogenerated agents are busted | 22:51 |
| JayF | vinsh: since this doesn't appear to consistently break us | 22:51 |
| vinsh | in debian/ubuntu/fedora you endup with the agent unable to find modprobe.. which is silly.. | 22:52 |
| jroll | JayF: u-c just merged like 4 hours ago | 22:52 |
| vinsh | on coreos I think it worked for me. | 22:52 |
| jroll | https://review.openstack.org/#/c/420837/ | 22:52 |
| patchbot | patch 420837 - requirements - Raise psutils uc to 5.0.1 (MERGED) | 22:52 |
| vinsh | but am not sure since I hit another issue on my end. | 22:52 |
| jroll | which is what actually raises it | 22:52 |
| *** david-lyle has joined #openstack-ironic | 22:53 | |
| *** alexpilotti has joined #openstack-ironic | 22:55 | |
| vinsh | JayF: https://bugs.launchpad.net/ironic-python-agent/+bug/1659137 | 22:55 |
| openstack | Launchpad bug 1659137 in ironic-python-agent "DIB builds of IPA issue with psutils versions" [Undecided,New] | 22:55 |
| JayF | thanks vinsh, I think mariojv and I will have a fix patch up shortly | 22:56 |
| *** alexpilotti has quit IRC | 22:56 | |
| vinsh | That's great, thank you! | 22:56 |
| JayF | vinsh: in the meantime, all newly built ironic-python-agents will fail in the same way | 22:56 |
| *** alexpilotti has joined #openstack-ironic | 22:56 | |
| vinsh | consistency is key | 22:56 |
| jlvillal | JayF: Is there a current problem with psutil version? | 22:57 |
| jlvillal | Ah, a DIB issue. | 22:57 |
| JayF | https://github.com/openstack/ironic-python-agent/blob/master/ironic_python_agent/hardware.py#L597 | 22:57 |
| JayF | not just dib | 22:58 |
| JayF | look there | 22:58 |
| JayF | u-c just got bumped to start having psutil 5.0.1 get instaleld | 22:58 |
| JayF | which we completely don't handle | 22:58 |
| JayF | leave total unset | 22:58 |
| JayF | and dump the whole process on line 634 when we try to return an uninitalized var | 22:58 |
| JayF | jlvillal: ^ | 22:58 |
| JayF | mario is writing a patch (we were already pairing on rescue) to fix this and guard against future errors of this type | 22:58 |
| *** alexpilo_ has joined #openstack-ironic | 22:59 | |
| jlvillal | JayF: mariojv Thanks! | 22:59 |
| *** Guest7769 is now known as rook | 22:59 | |
| *** moshele has quit IRC | 22:59 | |
| *** rook is now known as Guest9757 | 23:00 | |
| *** alexpilotti has quit IRC | 23:01 | |
| *** alexpilo_ has quit IRC | 23:03 | |
| *** alexpilotti has joined #openstack-ironic | 23:03 | |
| *** gcb has quit IRC | 23:06 | |
| *** alexpilo_ has joined #openstack-ironic | 23:06 | |
| *** alexpilo_ has quit IRC | 23:06 | |
| *** cdearborn has quit IRC | 23:06 | |
| *** alexpilo_ has joined #openstack-ironic | 23:07 | |
| *** alexpilotti has quit IRC | 23:08 | |
| *** harlowja has quit IRC | 23:08 | |
| openstackgerrit | Mario Villaplana proposed openstack/ironic-python-agent: Support psutil 5.0.1 https://review.openstack.org/424895 | 23:09 |
| JayF | jlvillal: ^ por favor | 23:09 |
| *** aNuposic has quit IRC | 23:09 | |
| JayF | I updated the whiteboard about IPA being broken, if/when someone lands that please update it again | 23:09 |
| *** krtaylor has joined #openstack-ironic | 23:09 | |
| *** aNuposic has joined #openstack-ironic | 23:10 | |
| JayF | vinsh: ^ Mario's patch above should fix, if you're curious to see | 23:10 |
| vinsh | very good :) | 23:10 |
| mariojv | JayF: feel free to add co-authored-by if it needs another revision, since you found the correct 5.0.1 call | 23:10 |
| JayF | meh, idc about credit | 23:11 |
| JayF | I care about it getting fixed | 23:11 |
| *** alexpilo_ has quit IRC | 23:11 | |
| vinsh | I'm fighting with a newton install that is ignoring power_off_after_deploy_failure now, then I'll give that a try locally. | 23:11 |
| *** sacharya has quit IRC | 23:12 | |
| *** jaosorior has quit IRC | 23:12 | |
| JayF | vinsh: are you using it with nova? | 23:14 |
| vinsh | yeah | 23:14 |
| JayF | vinsh: nova deletes instancess after deploys fail :) | 23:14 |
| vinsh | ahhhh-hah | 23:14 |
| JayF | vinsh: if you're troubleshooting, there's suppport for shipping deploy logs to the conductior (and then later on to swift, if you choose) | 23:14 |
| JayF | you might wanna look into that | 23:14 |
| JayF | I'm about to head out for the day, jlvillal TheJulia anyone else ^^ please look at that IPA patch to fix the gate + update whiteboard if it merges | 23:15 |
| vinsh | Yeah. Also I could remove ipmi tool from the conductor and just block it. | 23:15 |
| vinsh | :D | 23:15 |
| *** amotoki has quit IRC | 23:15 | |
| *** rm_work has quit IRC | 23:16 | |
| *** rm_work has joined #openstack-ironic | 23:17 | |
| *** sayantani01 has joined #openstack-ironic | 23:18 | |
| *** srobert has quit IRC | 23:19 | |
| *** amotoki has joined #openstack-ironic | 23:22 | |
| *** sayantani01 has quit IRC | 23:23 | |
| *** SpamapS has quit IRC | 23:27 | |
| *** xhku has quit IRC | 23:28 | |
| *** mtanino_ has joined #openstack-ironic | 23:29 | |
| *** mtanino has quit IRC | 23:30 | |
| *** SpamapS has joined #openstack-ironic | 23:31 | |
| *** xhku has joined #openstack-ironic | 23:32 | |
| *** skazi has quit IRC | 23:41 | |
| *** amotoki has quit IRC | 23:42 | |
| *** Goneri has quit IRC | 23:53 | |
| *** alexpilotti has joined #openstack-ironic | 23:53 | |
| *** skazi has joined #openstack-ironic | 23:54 | |
| *** alexpilotti has quit IRC | 23:57 | |
| *** harlowja has joined #openstack-ironic | 23:58 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!