| *** moshele has joined #openstack-ironic | 00:01 | |
| *** harlowja has quit IRC | 00:09 | |
| *** baoli has quit IRC | 00:12 | |
| *** vdrok has quit IRC | 00:12 | |
| *** Nisha_Agarwal has joined #openstack-ironic | 00:12 | |
| *** afazekas has quit IRC | 00:12 | |
| *** systemdave has quit IRC | 00:13 | |
| *** rbudden has quit IRC | 00:13 | |
| *** ildikov has quit IRC | 00:13 | |
| *** jroll has quit IRC | 00:14 | |
| *** UForgotten has quit IRC | 00:14 | |
| Nisha_Agarwal | TheJulia, hi | 00:15 |
|---|---|---|
| openstackgerrit | OpenStack Proposal Bot proposed openstack/ironic: Updated from global requirements https://review.openstack.org/418629 | 00:17 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/ironic-inspector: Updated from global requirements https://review.openstack.org/418630 | 00:17 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/ironic-python-agent: Updated from global requirements https://review.openstack.org/418632 | 00:17 |
| TheJulia | Hi Nisha_Agarwal | 00:17 |
| *** afazekas has joined #openstack-ironic | 00:17 | |
| *** systemdave has joined #openstack-ironic | 00:19 | |
| *** UForgotten has joined #openstack-ironic | 00:19 | |
| *** Goneri has quit IRC | 00:20 | |
| *** jroll has joined #openstack-ironic | 00:20 | |
| *** ildikov has joined #openstack-ironic | 00:21 | |
| *** vdrok has joined #openstack-ironic | 00:22 | |
| *** siva has quit IRC | 00:23 | |
| *** vdrok has quit IRC | 00:25 | |
| *** vdrok has joined #openstack-ironic | 00:25 | |
| *** harlowja has joined #openstack-ironic | 00:25 | |
| *** siva has joined #openstack-ironic | 00:26 | |
| *** causten has quit IRC | 00:29 | |
| *** aslezil has quit IRC | 00:34 | |
| *** alezil is now known as aslezil | 00:34 | |
| *** siva has quit IRC | 00:36 | |
| *** Nisha_Agarwal has quit IRC | 00:37 | |
| openstackgerrit | Matt Riedemann proposed openstack/ironic: DNM: Test Ironic in Newton with the placement service https://review.openstack.org/416734 | 00:37 |
| *** siva has joined #openstack-ironic | 00:39 | |
| *** awiddersheim has joined #openstack-ironic | 00:39 | |
| *** siva has quit IRC | 00:44 | |
| openstackgerrit | Julia Kreger proposed openstack/ironic: Add Cinder storage driver https://review.openstack.org/366197 | 00:45 |
| openstackgerrit | Julia Kreger proposed openstack/ironic: Add base cinder common interface https://review.openstack.org/355625 | 00:45 |
| *** tuanluong has joined #openstack-ironic | 00:53 | |
| *** siva has joined #openstack-ironic | 00:55 | |
| *** siva has quit IRC | 00:55 | |
| openstackgerrit | Tuan Luong-Anh proposed openstack/ironic: Fix setting persistent boot device does not work https://review.openstack.org/376322 | 00:57 |
| *** phuongnh has joined #openstack-ironic | 01:04 | |
| *** ppiela has quit IRC | 01:04 | |
| *** rloo has quit IRC | 01:11 | |
| *** rpioso has quit IRC | 01:14 | |
| openstackgerrit | Naohiro Tamura proposed openstack/ironic: Ipmitool power driver for soft reboot and soft power off https://review.openstack.org/216738 | 01:22 |
| *** Syed__ has quit IRC | 01:25 | |
| openstackgerrit | Naohiro Tamura proposed openstack/ironic: Ipmitool management driver for Inject NMI https://review.openstack.org/348721 | 01:31 |
| *** aweeks has joined #openstack-ironic | 01:32 | |
| *** cppforlife_ has joined #openstack-ironic | 01:34 | |
| *** Goneri has joined #openstack-ironic | 01:34 | |
| *** shobhar_ has joined #openstack-ironic | 01:39 | |
| *** Goneri has quit IRC | 01:45 | |
| *** zhangjl has joined #openstack-ironic | 01:47 | |
| *** wajdi has joined #openstack-ironic | 01:56 | |
| openstackgerrit | Naohiro Tamura proposed openstack/ironic: iRMC management driver for Inject NMI https://review.openstack.org/348732 | 02:05 |
| *** sacharya has quit IRC | 02:07 | |
| *** rama_y has joined #openstack-ironic | 02:22 | |
| openstackgerrit | Naohiro Tamura proposed openstack/ironic: iRMC power driver for soft reboot and soft power off https://review.openstack.org/216743 | 02:27 |
| *** chlong has quit IRC | 02:32 | |
| *** UForgotten has quit IRC | 02:39 | |
| *** UForgotten has joined #openstack-ironic | 02:39 | |
| *** jcoufal has joined #openstack-ironic | 02:56 | |
| *** deray has joined #openstack-ironic | 03:01 | |
| *** sacharya has joined #openstack-ironic | 03:02 | |
| *** sacharya has quit IRC | 03:07 | |
| deray | Hello g'morning | 03:08 |
| *** moshele has quit IRC | 03:10 | |
| *** rama_y has quit IRC | 03:14 | |
| deray | sambetts|afk, just fyi | 03:15 |
| deray | sambetts|afk, https://review.openstack.org/#/c/418612/ | 03:15 |
| patchbot | patch 418612 - futurist - Allow functions to raise a never again exception t... | 03:15 |
| *** absubram has quit IRC | 03:18 | |
| *** bdeschenes has quit IRC | 03:18 | |
| *** amotoki has quit IRC | 03:21 | |
| *** absubram has joined #openstack-ironic | 03:25 | |
| *** amotoki has joined #openstack-ironic | 03:29 | |
| *** absubram has quit IRC | 03:31 | |
| *** vikrant has joined #openstack-ironic | 03:33 | |
| *** amotoki has quit IRC | 03:33 | |
| openstackgerrit | Tuan Luong-Anh proposed openstack/ironic: Fix setting persistent boot device does not work https://review.openstack.org/376322 | 03:34 |
| *** jcoufal has quit IRC | 03:36 | |
| openstackgerrit | avnish proposed openstack/bifrost: Remove useless paramiko requirements https://review.openstack.org/418664 | 03:43 |
| tuanluong | morning deray | 03:46 |
| deray | sambetts|afk, 'm happy to have this patch .. the result of my insistence to have a stop functionality to the periodic func() | 03:47 |
| *** links has joined #openstack-ironic | 03:47 | |
| deray | tuanluong, hey g'morning | 03:47 |
| *** aparna has joined #openstack-ironic | 03:57 | |
| *** Nisha_Agarwal has joined #openstack-ironic | 04:03 | |
| *** rbudden has joined #openstack-ironic | 04:05 | |
| *** sacharya has joined #openstack-ironic | 04:15 | |
| *** sacharya has quit IRC | 04:20 | |
| *** ijw has quit IRC | 04:34 | |
| *** phuongnh has quit IRC | 04:48 | |
| *** nmathew has joined #openstack-ironic | 04:49 | |
| *** absubram has joined #openstack-ironic | 04:55 | |
| *** aslezil_ has joined #openstack-ironic | 04:58 | |
| *** absubram_ has joined #openstack-ironic | 04:59 | |
| *** absubram has quit IRC | 04:59 | |
| *** absubram_ is now known as absubram | 04:59 | |
| openstackgerrit | Nisha Agarwal proposed openstack/proliantutils: snmp inspection for disk size https://review.openstack.org/394858 | 05:00 |
| *** gcb has quit IRC | 05:13 | |
| *** yibo has joined #openstack-ironic | 05:14 | |
| *** yibo has quit IRC | 05:15 | |
| *** yibo has joined #openstack-ironic | 05:15 | |
| *** rbudden has quit IRC | 05:19 | |
| *** deray has quit IRC | 05:23 | |
| *** yibo has quit IRC | 05:24 | |
| *** yonglihe has quit IRC | 05:27 | |
| *** deray has joined #openstack-ironic | 05:29 | |
| *** shobhar_ has quit IRC | 05:37 | |
| *** aslezil_ has quit IRC | 05:41 | |
| Nisha_Agarwal | Hi TheJulia | 05:59 |
| *** gcb has joined #openstack-ironic | 06:04 | |
| *** dims has quit IRC | 06:13 | |
| *** sacharya has joined #openstack-ironic | 06:16 | |
| *** moshele has joined #openstack-ironic | 06:16 | |
| *** ijw has joined #openstack-ironic | 06:18 | |
| *** sacharya has quit IRC | 06:20 | |
| *** ijw has quit IRC | 06:22 | |
| *** pcaruana has joined #openstack-ironic | 06:25 | |
| *** moshele has quit IRC | 06:33 | |
| *** mjura has joined #openstack-ironic | 06:44 | |
| *** ijw has joined #openstack-ironic | 06:54 | |
| *** Nisha_Agarwal has quit IRC | 06:55 | |
| *** sasha21 has quit IRC | 07:00 | |
| openstackgerrit | Naohiro Tamura proposed openstack/python-ironicclient: Add soft reboot/poweroff power states. https://review.openstack.org/247904 | 07:07 |
| *** tesseract has joined #openstack-ironic | 07:08 | |
| *** ChubYann has quit IRC | 07:15 | |
| *** udesale has joined #openstack-ironic | 07:19 | |
| *** makowals has joined #openstack-ironic | 07:21 | |
| *** amotoki has joined #openstack-ironic | 07:28 | |
| *** Nisha_Agarwal has joined #openstack-ironic | 07:29 | |
| *** lindycoder has joined #openstack-ironic | 07:30 | |
| *** lindycoder has quit IRC | 07:30 | |
| *** hwoarang has quit IRC | 07:35 | |
| *** moshele has joined #openstack-ironic | 07:37 | |
| *** hw_wutianwei has joined #openstack-ironic | 07:38 | |
| *** AlexeyAbashkin has joined #openstack-ironic | 07:42 | |
| *** hwoarang has joined #openstack-ironic | 07:43 | |
| *** rbartal has joined #openstack-ironic | 07:44 | |
| *** ralonsoh has joined #openstack-ironic | 07:48 | |
| *** yonglihe has joined #openstack-ironic | 07:50 | |
| openstackgerrit | yolanda.robla proposed openstack/ironic-lib: Fix retrieval of config-2 existing partition https://review.openstack.org/417022 | 07:53 |
| *** hogepodge has quit IRC | 07:56 | |
| *** ccamacho has joined #openstack-ironic | 07:57 | |
| openstackgerrit | Galyna Zholtkevych proposed openstack/ironic: Keystone session for swift-temp-url generation https://review.openstack.org/410764 | 07:58 |
| *** sacharya has joined #openstack-ironic | 08:00 | |
| openstackgerrit | yolanda.robla proposed openstack/bifrost: Allow deploy-dynamic on remote host https://review.openstack.org/411304 | 08:00 |
| openstackgerrit | Naohiro Tamura proposed openstack/python-ironicclient: Support soft reboot and soft power off with timeout for OSC https://review.openstack.org/357627 | 08:02 |
| *** sacharya has quit IRC | 08:06 | |
| *** strigazi_AFK is now known as strigazi | 08:13 | |
| *** amotoki has quit IRC | 08:16 | |
| *** gcb has quit IRC | 08:19 | |
| *** amoralej|off is now known as amorale | 08:22 | |
| *** gcb has joined #openstack-ironic | 08:33 | |
| openstackgerrit | Merged openstack/bifrost: Correct inspector keystone endpoint name https://review.openstack.org/407245 | 08:37 |
| *** gcb has quit IRC | 08:40 | |
| *** Nisha_Agarwal has quit IRC | 08:42 | |
| openstackgerrit | Aparna proposed openstack/ironic-specs: In-band hpsum firmware update for iLO drivers https://review.openstack.org/410161 | 08:47 |
| *** ijw has quit IRC | 08:52 | |
| openstackgerrit | yolanda.robla proposed openstack/ironic-lib: Fix retrieval of config-2 existing partition https://review.openstack.org/417022 | 08:54 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/ironic-ui: Imported Translations from Zanata https://review.openstack.org/418781 | 08:55 |
| *** amorale is now known as amoralej | 08:58 | |
| *** zzzeek has quit IRC | 09:00 | |
| *** zzzeek has joined #openstack-ironic | 09:00 | |
| vdrok | good morning ironic, deray and tuanluong ! | 09:08 |
| tuanluong | Morning vdrok | 09:09 |
| deray | vdrok, g'morning o/ | 09:12 |
| *** sambetts|afk is now known as sambetts | 09:17 | |
| sambetts | Morning all | 09:17 |
| sambetts | deray: Nice!!! | 09:17 |
| *** fxpester has joined #openstack-ironic | 09:18 | |
| *** zhangjl has left #openstack-ironic | 09:18 | |
| *** amotoki has joined #openstack-ironic | 09:22 | |
| openstackgerrit | Vasyl Saienko proposed openstack/python-ironicclient: Add interface attach/detach support https://review.openstack.org/364420 | 09:23 |
| sambetts | thanks vsaienk0 for keeping on top of those patches! | 09:24 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: TMP: Verify attach/detach https://review.openstack.org/414160 | 09:24 |
| openstackgerrit | Aparna proposed openstack/ironic-specs: Generic way to configure clean step priorites in Automated cleaning https://review.openstack.org/362615 | 09:26 |
| *** makowals_ has joined #openstack-ironic | 09:26 | |
| *** milan has joined #openstack-ironic | 09:28 | |
| *** makowals has quit IRC | 09:28 | |
| vdrok | morning sambetts | 09:29 |
| sambetts | Hi vdrok | 09:29 |
| openstackgerrit | Aparna proposed openstack/ironic-specs: In-band hpsum firmware update for iLO drivers https://review.openstack.org/410161 | 09:30 |
| openstackgerrit | Galyna Zholtkevych proposed openstack/ironic-specs: API Evolution - ETAG identifiers https://review.openstack.org/381991 | 09:34 |
| milan | morning Ironic! :) | 09:34 |
| milan | morning sambetts, vdrok! :) | 09:34 |
| vdrok | good morning milan | 09:35 |
| sambetts | hey milan | 09:36 |
| deray | sambetts, :) | 09:37 |
| *** lucas-afk is now known as lucasagomes | 09:38 | |
| lucasagomes | morning all | 09:38 |
| deray | morning sambetts milan lucasagomes and latter ironicers | 09:38 |
| *** derekh has joined #openstack-ironic | 09:42 | |
| milan | morning deray lucasagomes! :) | 09:42 |
| lucasagomes | o/ | 09:47 |
| vdrok | morning lucasagomes | 09:48 |
| vsaienk0 | Morning lucasagomes, sambetts, vdrok, milan, dtantsur and all Ironic'ers! | 09:49 |
| vsaienk0 | sambetts: I hope we land attach/detach code soon :) | 09:50 |
| sambetts | vsaienk0: yup it looks really close! | 09:50 |
| *** ijw has joined #openstack-ironic | 09:52 | |
| *** Nisha_Agarwal has joined #openstack-ironic | 09:54 | |
| *** ijw has quit IRC | 09:57 | |
| yolanda | hi lucasagomes , around? | 09:59 |
| yolanda | i have failures on my fix for config drive, specifically in whole disk tests | 09:59 |
| yolanda | http://logs.openstack.org/22/417022/5/check/gate-tempest-dsvm-ironic-lib-wholedisk-pxe_ipmitool-ubuntu-xenial/31ca5ce | 09:59 |
| yolanda | but i'm unable to see the problem, if that's related with my patch | 09:59 |
| vdrok | morning vsaienk0 | 10:00 |
| yolanda | i just see timeouts, but don't know the root cause | 10:00 |
| *** ijw has joined #openstack-ironic | 10:00 | |
| *** e0ne has joined #openstack-ironic | 10:02 | |
| sambetts | yolanda: 2017-01-11 09:35:42.205 21598 ERROR ironic.drivers.modules.agent_base_vendor Stderr: u'/usr/local/bin/ironic-rootwrap: Unauthorized command: lsblk -Po name,label /dev/disk/by-path/ip-10.1.0.10:3260-iscsi-iqn.2008-10.org.openstack:7173970f-1805-44dd-b2f2-52ec03144bb4-lun-1 (no filter matched)\n' | 10:03 |
| sambetts | yolanda: http://logs.openstack.org/22/417022/5/check/gate-tempest-dsvm-ironic-lib-wholedisk-pxe_ipmitool-ubuntu-xenial/31ca5ce/logs/screen-ir-cond.txt.gz#_2017-01-11_09_35_42_205 | 10:03 |
| pas-ha | morning all | 10:03 |
| lucasagomes | yolanda, hi there yes, 1 sec | 10:03 |
| lucasagomes | will take a look | 10:03 |
| sambetts | lucasagomes, yolanda: the failure is shown in the ir-cond logs | 10:03 |
| lucasagomes | oh sambetts already found it, hmm seems related to the rootwrap filter | 10:03 |
| yolanda | mm, but i added the lsblk command to the filter | 10:04 |
| yolanda | and worked on my tests | 10:04 |
| yolanda | ah sambetts , thanks for pointing to that screen logs | 10:05 |
| *** ijw has quit IRC | 10:05 | |
| sambetts | yolanda: I don't see the filter being added here: http://logs.openstack.org/22/417022/5/check/gate-tempest-dsvm-ironic-lib-wholedisk-pxe_ipmitool-ubuntu-xenial/31ca5ce/logs/etc/ironic/rootwrap.d/ | 10:05 |
| yolanda | sambetts, do you see my change, where i added that? does it seem ok? | 10:06 |
| yolanda | i just copied the same commadns as on my local deploy | 10:06 |
| yolanda | seems tests are ignoring it :( | 10:07 |
| lucasagomes | yolanda, apparently there's a note there that you also have to update this in ironic :-( | 10:08 |
| yolanda | ouch | 10:09 |
| yolanda | i see | 10:09 |
| lucasagomes | yolanda, https://github.com/openstack/ironic/blob/master/etc/ironic/rootwrap.d/ironic-lib.filters | 10:09 |
| lucasagomes | :-( | 10:09 |
| yolanda | ok let me send that patch first, and depend on it | 10:09 |
| openstackgerrit | Vladyslav Drok proposed openstack/ironic: Allow to attach/detach VIF to portgroup https://review.openstack.org/406915 | 10:12 |
| openstackgerrit | yolanda.robla proposed openstack/ironic: Add lsblk to ironic-lib filters https://review.openstack.org/418814 | 10:13 |
| *** MattMan has quit IRC | 10:14 | |
| *** zackf has quit IRC | 10:14 | |
| *** MattMan has joined #openstack-ironic | 10:14 | |
| openstackgerrit | yolanda.robla proposed openstack/ironic-lib: Fix retrieval of config-2 existing partition https://review.openstack.org/417022 | 10:17 |
| *** udesale has quit IRC | 10:17 | |
| *** Alexey_Abashkin has joined #openstack-ironic | 10:18 | |
| *** AlexeyAbashkin has quit IRC | 10:19 | |
| *** sambetts is now known as sambetts|afk | 10:20 | |
| sambetts|afk | bbiab | 10:20 |
| *** amarao has joined #openstack-ironic | 10:25 | |
| openstackgerrit | yolanda.robla proposed openstack/ironic-lib: Fix retrieval of config-2 existing partition https://review.openstack.org/417022 | 10:26 |
| lucasagomes | apparently the libvirt drivers in ironic-staging-drivers are broken :-( http://paste.openstack.org/show/594524/ | 10:27 |
| *** alexpilotti has quit IRC | 10:27 | |
| *** alexpilotti has joined #openstack-ironic | 10:28 | |
| lucasagomes | oh, version 0.4.0 is broken... Needs another release | 10:28 |
| lucasagomes | installing from source seems fine | 10:28 |
| * lucasagomes will release | 10:29 | |
| openstackgerrit | Galyna Zholtkevych proposed openstack/ironic-specs: API Evolution - ETAG identifiers https://review.openstack.org/381991 | 10:30 |
| *** Alexey_Abashkin has quit IRC | 10:31 | |
| milan | lucasagomes, hey, w/ virtualbmc what is the driverinfo port key? | 10:31 |
| lucasagomes | milan, depend on the driver, for ipmitool it's "ipmi_port" | 10:32 |
| lucasagomes | ipminative I think is the same (/me checks) | 10:32 |
| lucasagomes | milan, hmmmm ipminative seems to not support a non-default port ? | 10:33 |
| milan | lucasagomes, thx, btw does a port make sense for any other drivers? Like iLo or Drac? | 10:33 |
| lucasagomes | milan, I think so, they should be able to configure the BMC to listen in a non-default port | 10:34 |
| lucasagomes | milan, fwiw, drac_port exists already | 10:34 |
| milan | and the key name would most likely be driver dependant | 10:34 |
| milan | I see | 10:35 |
| openstackgerrit | Vladyslav Drok proposed openstack/ironic: Allow to attach/detach VIF to portgroup https://review.openstack.org/406915 | 10:35 |
| milan | lucasagomes, thx | 10:35 |
| lucasagomes | milan, np :-) | 10:35 |
| lucasagomes | vdrok, I'm going to release ironic-staging-drivers, ok ? | 10:36 |
| vdrok | lucasagomes: yeah, sure | 10:37 |
| *** Nisha_Agarwal has quit IRC | 10:42 | |
| *** tuanluong has quit IRC | 10:46 | |
| *** aarefiev has joined #openstack-ironic | 10:47 | |
| aarefiev | morning all! | 10:48 |
| *** aarefiev_afk has quit IRC | 10:50 | |
| lucasagomes | aarefiev, morning | 10:50 |
| milan | morning aarefiev! :) | 10:50 |
| aarefiev | morning lucasagomes, milan :) | 10:50 |
| *** gcb has joined #openstack-ironic | 11:00 | |
| *** ijw has joined #openstack-ironic | 11:02 | |
| *** AlexeyAbashkin has joined #openstack-ironic | 11:02 | |
| *** sacharya has joined #openstack-ironic | 11:02 | |
| *** Alexey_Abashkin has joined #openstack-ironic | 11:06 | |
| *** ijw has quit IRC | 11:07 | |
| *** sacharya has quit IRC | 11:07 | |
| *** AlexeyAbashkin has quit IRC | 11:07 | |
| openstackgerrit | Derek Higgins proposed openstack/ironic-python-agent: Advertise the correct address when using IPv6 https://review.openstack.org/411817 | 11:07 |
| openstackgerrit | Derek Higgins proposed openstack/ironic-python-agent: iscsi: Listen for connections on both IPv4 and IPv6 ports https://review.openstack.org/411819 | 11:07 |
| openstackgerrit | Derek Higgins proposed openstack/ironic-python-agent: Agent: Listen for connections on both IPv4 and IPv6 ports https://review.openstack.org/411818 | 11:07 |
| *** Alexey_Abashkin_ has joined #openstack-ironic | 11:09 | |
| *** nmathew has quit IRC | 11:09 | |
| *** Alexey_Abashkin has quit IRC | 11:11 | |
| *** deray has quit IRC | 11:12 | |
| * milan relocates | 11:16 | |
| *** milan has quit IRC | 11:16 | |
| openstackgerrit | yolanda.robla proposed openstack/ironic-lib: Fix retrieval of config-2 existing partition https://review.openstack.org/417022 | 11:18 |
| *** dtantsur|afk is now known as dtantsur | 11:27 | |
| dtantsur | morning ironic | 11:28 |
| vdrok | morning dtantsur | 11:31 |
| openstackgerrit | Vladyslav Drok proposed openstack/ironic: Fix logging if power interface does not support timeout https://review.openstack.org/418871 | 11:31 |
| sambetts|afk | Morning dtantsur | 11:31 |
| openstackgerrit | Vladyslav Drok proposed openstack/ironic: Fix logging if power interface does not support timeout https://review.openstack.org/418871 | 11:32 |
| lucasagomes | dtantsur, morning | 11:33 |
| *** Nisha_Agarwal has joined #openstack-ironic | 11:34 | |
| *** hw_wutianwei has quit IRC | 11:37 | |
| *** Nisha_Agarwal has quit IRC | 11:38 | |
| *** dims has joined #openstack-ironic | 11:39 | |
| *** jkilpatr has quit IRC | 11:48 | |
| openstackgerrit | Vasyl Saienko proposed openstack/python-ironicclient: Add interface attach/detach support https://review.openstack.org/364420 | 11:57 |
| *** AlexeyAbashkin has joined #openstack-ironic | 11:58 | |
| *** Alexey_Abashkin_ has quit IRC | 11:59 | |
| openstackgerrit | Merged openstack/ironic-inspector: Updated from global requirements https://review.openstack.org/418630 | 12:02 |
| lucasagomes | yolanda, tests are all green, code looks good! +2'd | 12:04 |
| yolanda | yay! | 12:05 |
| yolanda | need another +2 on both changes, call for ironic-cores :) | 12:05 |
| dtantsur | which changes are we talking about btw? | 12:06 |
| * dtantsur cannot approve them anyway though | 12:06 | |
| *** nicodemos has joined #openstack-ironic | 12:08 | |
| nicodemos | good morning. =] | 12:08 |
| patchbot | Error: Spurious "]". You may want to quote your arguments with double quotes in order to prevent extra brackets from being evaluated as nested commands. | 12:08 |
| dtantsur | morning nicodemos :) | 12:08 |
| *** jkilpatr has joined #openstack-ironic | 12:09 | |
| sambetts|afk | bad patchbot... XD | 12:09 |
| *** sambetts|afk is now known as sambetts | 12:09 | |
| nicodemos | heheheh | 12:09 |
| lucasagomes | dtantsur, https://review.openstack.org/417022 | 12:12 |
| patchbot | patch 417022 - ironic-lib - Fix retrieval of config-2 existing partition | 12:12 |
| vdrok | morning nicodemos | 12:12 |
| lucasagomes | and the depends-on in the commit message | 12:12 |
| lucasagomes | nicodemos, good morning! | 12:12 |
| *** mrtenio has joined #openstack-ironic | 12:14 | |
| *** amotoki has quit IRC | 12:14 | |
| *** moshele has quit IRC | 12:16 | |
| *** moshele has joined #openstack-ironic | 12:16 | |
| *** jkilpatr has quit IRC | 12:16 | |
| dtantsur | yolanda, two small issues in the second patch, otherwise looks good | 12:16 |
| yolanda | good, i'll amend it | 12:17 |
| openstackgerrit | yolanda.robla proposed openstack/ironic-lib: Fix retrieval of config-2 existing partition https://review.openstack.org/417022 | 12:19 |
| *** moshele has quit IRC | 12:20 | |
| dtantsur | yolanda, why don't you use "label" argument passed in the function you change? | 12:20 |
| dtantsur | maybe I'm missing something, but I guess it either should be removed or used instead of a constant | 12:20 |
| *** AlexeyAbashkin has quit IRC | 12:20 | |
| openstackgerrit | Vasyl Saienko proposed openstack/python-ironicclient: Extend VIF attach commands https://review.openstack.org/418894 | 12:20 |
| *** moshele has joined #openstack-ironic | 12:23 | |
| *** amotoki has joined #openstack-ironic | 12:26 | |
| *** makowals has joined #openstack-ironic | 12:26 | |
| *** makowals_ has quit IRC | 12:26 | |
| *** jkilpatr has joined #openstack-ironic | 12:29 | |
| openstackgerrit | Merged openstack/ironic: Correct logging of loaded drivers/hardware types/interfaces https://review.openstack.org/418364 | 12:30 |
| openstackgerrit | Merged openstack/ironic-specs: Add spec for OpenBMC driver https://review.openstack.org/388218 | 12:32 |
| *** ccamacho is now known as ccamacho|lunch | 12:32 | |
| openstackgerrit | Anton Arefiev proposed openstack/ironic-inspector: Change (started|finished)_at column type https://review.openstack.org/397636 | 12:34 |
| *** milan has joined #openstack-ironic | 12:41 | |
| *** aparna has quit IRC | 12:41 | |
| *** bdeschenes has joined #openstack-ironic | 12:42 | |
| *** gcb has quit IRC | 12:45 | |
| *** vikrant has quit IRC | 12:46 | |
| openstackgerrit | Vasyl Saienko proposed openstack/python-ironicclient: Extend VIF attach commands https://review.openstack.org/418894 | 12:47 |
| *** vikrant has joined #openstack-ironic | 12:47 | |
| openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic: DNM test enabled dynamic iPXE https://review.openstack.org/391943 | 12:47 |
| *** lucasagomes is now known as lucas-hungry | 12:50 | |
| *** amotoki has quit IRC | 12:50 | |
| *** hw_wutianwei has joined #openstack-ironic | 12:56 | |
| *** vikrant has quit IRC | 12:57 | |
| jroll | morning y'all | 12:58 |
| nicodemos | morning, jroll | 12:58 |
| jroll | sambetts: vdrok: vsaienk0: attach/detach patch LGTM except one thing: https://review.openstack.org/#/c/404240/28/ironic/api/controllers/v1/node.py@1099 | 12:59 |
| patchbot | patch 404240 - ironic - Add Virtual Network Interface REST APIs | 12:59 |
| vdrok | morning jroll | 12:59 |
| jroll | if we fix that up we can approve it | 13:00 |
| *** amotoki has joined #openstack-ironic | 13:00 | |
| jroll | also, multitenant gate looks happy, thanks for that \o/ | 13:00 |
| dtantsur | morning jroll | 13:00 |
| vdrok | me and yuriyz were thinking about this, if the conductor becomes down it makes sense to have 503 there instead of 404/400? | 13:00 |
| jroll | dtantsur: this should be an easy-ish review: https://review.openstack.org/#/c/418573/1 | 13:00 |
| patchbot | patch 418573 - ironic - Expose default interface calculation from driver_f... | 13:00 |
| dtantsur | k looking | 13:00 |
| vdrok | jroll: ^ | 13:01 |
| jroll | vdrok: I think I agree, but everywhere else it's 400 right now, and I'd like it to stay consistent | 13:01 |
| jroll | if we want to change that it should be all at once | 13:01 |
| vdrok | jroll: ok, maybe that's better indeed | 13:01 |
| vdrok | will push updated one shortly | 13:02 |
| jroll | awesome, thanks | 13:02 |
| *** amotoki has quit IRC | 13:02 | |
| *** sacharya has joined #openstack-ironic | 13:03 | |
| *** dprince has joined #openstack-ironic | 13:04 | |
| *** amotoki has joined #openstack-ironic | 13:05 | |
| jroll | dtantsur: I think the WIP API patch above it is mostly ready for review, too. it'll conflict with attach/detach, so isn't landable yet. also still needs the /drivers/name/{properties,vendor_passthru} changes yet, but the rest should be good | 13:06 |
| jroll | the downside... I have us loading hardware types in the api layer :( | 13:06 |
| jroll | I wonder if I should be rpc-ing that instead, but seems heavy | 13:06 |
| dtantsur | jroll, loading hardware types in the API layer may not be possible, if API and conductors are on different machines... this is the main reason why we moved node_create to conductor | 13:07 |
| *** sacharya has quit IRC | 13:08 | |
| *** chlong has joined #openstack-ironic | 13:08 | |
| openstackgerrit | Vladyslav Drok proposed openstack/ironic: Add Virtual Network Interface REST APIs https://review.openstack.org/404240 | 13:08 |
| jroll | dtantsur: well, unless we mandate configs/deps be on api machines as well | 13:08 |
| vdrok | jroll: ^ | 13:08 |
| jroll | thanks vdrok | 13:09 |
| jroll | dtantsur: I'll have to think about the RPC thing, we'll need the hash ring bits and it may need to be multiple RPC calls for /v1/drivers?detail=True | 13:09 |
| dtantsur | jroll, totally unrelated thing before we commit to some API: wdyt about deprecating vendor interface in favor of methods directly on hardware types? | 13:09 |
| jroll | mmmmm | 13:10 |
| jroll | dtantsur: not sure I understand, maybe need more coffee | 13:10 |
| openstackgerrit | Vladyslav Drok proposed openstack/ironic: Allow to attach/detach VIF to portgroup https://review.openstack.org/406915 | 13:10 |
| dtantsur | jroll, it just seems weird to allow users to pick the vendor interface... maybe we can do it later with API deprecation, dunno | 13:11 |
| sambetts | dtantsur: thats really interesting actually, because they are hardware specific functions | 13:11 |
| dtantsur | yeah | 13:11 |
| jroll | dtantsur: ah, I see what you mean | 13:11 |
| jroll | according to the spec we saved 'pick the interface' for later | 13:11 |
| dtantsur | wait, sorry, now I'm confused.. we're going to have node.vendor_interface changeable via API, right? | 13:12 |
| jroll | oh! that | 13:12 |
| dtantsur | I wonder if it's a good thing actually.. maybe we should leave out it from API for now, and think if we even need it this way | 13:13 |
| jroll | I thought you meant specifying a non-default interface in /v1/drivers/passthru | 13:13 |
| jroll | er, /v1/drivers/name/passthru | 13:13 |
| dtantsur | no, this is for later | 13:13 |
| jroll | yeah, it does seem odd | 13:13 |
| dtantsur | if we do deprecate vendor interface, we won't have problems with a non-default interface in /v1/drivers/passthru | 13:13 |
| jroll | right | 13:14 |
| jroll | well, we don't even need to deprecate it | 13:14 |
| jroll | just only allow the default | 13:14 |
| dtantsur | yep. wdyt? | 13:14 |
| jroll | it makes sense to me | 13:15 |
| jroll | I think the only use case it breaks is out of tree vendor interface, but you'd need out of tree hardware type... never mind | 13:15 |
| dtantsur | ok, I'll propose a spec change (sigh) explaining this | 13:15 |
| jroll | yeah I don't expect a hardware type that supports multiple vendor interfaces | 13:15 |
| jroll | we aren't populating the DB field in any way, right? | 13:16 |
| * jroll hates spec changes | 13:16 | |
| dtantsur | we put the default there on creation, I think | 13:16 |
| jroll | do we read that yet? | 13:16 |
| jroll | other than validation | 13:16 |
| dtantsur | well, we load it as usual | 13:16 |
| * jroll trying to comprehend if we can just drop the column or need to do something else | 13:17 | |
| jroll | probably can just drop it, as we don't allow changing it | 13:17 |
| dtantsur | we can drop the column and just calculate the value always | 13:17 |
| jroll | yeah +1 | 13:17 |
| dtantsur | cool. I don't like changing specs too, but I guess it has to be done to avoid confusion.. | 13:18 |
| jroll | yeah, just don't like the concept of it | 13:19 |
| * dtantsur gets some food | 13:19 | |
| *** bfournie has quit IRC | 13:19 | |
| * jroll continues reviewing attach/detach | 13:19 | |
| *** trown|outtypewww is now known as trown | 13:22 | |
| sambetts | thanks jroll :D | 13:26 |
| *** amoralej is now known as amoralej|lunch | 13:28 | |
| *** amotoki has quit IRC | 13:28 | |
| openstackgerrit | yolanda.robla proposed openstack/ironic-lib: Fix retrieval of config-2 existing partition https://review.openstack.org/417022 | 13:29 |
| *** bdeschenes has quit IRC | 13:35 | |
| sambetts | dtantsur, jroll: regarding the /drivers/properties API I have proposed this today https://bugs.launchpad.net/ironic/+bug/1655633 | 13:35 |
| openstack | Launchpad bug 1655633 in Ironic "[RFE] Enhance /drivers/properties API to have machine readable detail view " [Wishlist,New] | 13:35 |
| *** AlexeyAbashkin has joined #openstack-ironic | 13:35 | |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: TMP: Verify attach/detach https://review.openstack.org/414160 | 13:36 |
| jroll | sambetts: cool, that'll need a spec, and I'm going to totally forget about it until ocata is done :) | 13:37 |
| jroll | but it makes sense | 13:37 |
| *** jheroux has joined #openstack-ironic | 13:37 | |
| jroll | I'm also skeptical we shouldn't just always do it | 13:38 |
| sambetts | I'm not sure what you mean | 13:39 |
| *** amotoki has joined #openstack-ironic | 13:39 | |
| jroll | like | 13:39 |
| jroll | just make that change to always happen | 13:39 |
| jroll | instead of adding detail=True | 13:39 |
| sambetts | jroll: ah, yeah, the reason I put it under a ?detail=True was to not break the exist API | 13:40 |
| sambetts | existing* | 13:40 |
| sambetts | but then again microversions | 13:40 |
| jroll | yep | 13:40 |
| * jroll feeds self, animals, bbiab | 13:40 | |
| *** ccamacho|lunch is now known as ccamacho | 13:41 | |
| *** lucas-hungry has quit IRC | 13:41 | |
| *** rook has quit IRC | 13:41 | |
| *** Bico_Fino has joined #openstack-ironic | 13:43 | |
| *** lucasagomes has joined #openstack-ironic | 13:47 | |
| *** rook has joined #openstack-ironic | 13:49 | |
| *** rook is now known as Guest22365 | 13:49 | |
| *** trown is now known as trown|brb | 13:49 | |
| openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic: Move heartbeat processing to separate mixin class https://review.openstack.org/404364 | 13:50 |
| *** AnxiousGarlic has joined #openstack-ironic | 13:51 | |
| *** AnxiousGarlic_ has joined #openstack-ironic | 13:52 | |
| openstackgerrit | Merged openstack/ironic: Updated from global requirements https://review.openstack.org/418629 | 13:53 |
| *** bfournie1 has joined #openstack-ironic | 13:54 | |
| *** david-lyle has quit IRC | 13:56 | |
| *** AlexeyAbashkin has quit IRC | 13:57 | |
| *** sasha2 has joined #openstack-ironic | 13:57 | |
| *** crinkle_ has quit IRC | 13:59 | |
| *** amotoki has quit IRC | 13:59 | |
| *** david-lyle has joined #openstack-ironic | 13:59 | |
| *** AlexeyAbashkin has joined #openstack-ironic | 13:59 | |
| *** crinkle_ has joined #openstack-ironic | 13:59 | |
| *** mat128 has quit IRC | 13:59 | |
| *** baoli has joined #openstack-ironic | 13:59 | |
| *** baoli has quit IRC | 14:00 | |
| *** mat128 has joined #openstack-ironic | 14:00 | |
| *** baoli has joined #openstack-ironic | 14:00 | |
| *** wajdi has quit IRC | 14:00 | |
| *** [1]cdearborn has joined #openstack-ironic | 14:01 | |
| *** athomas has quit IRC | 14:01 | |
| *** links has quit IRC | 14:02 | |
| *** rloo has joined #openstack-ironic | 14:04 | |
| *** trown|brb is now known as trown | 14:04 | |
| *** AnxiousGarlic_ has quit IRC | 14:05 | |
| openstackgerrit | M V P Nitesh proposed openstack/ironic: Removes unnecessary utf-8 encoding https://review.openstack.org/418953 | 14:06 |
| *** athomas has joined #openstack-ironic | 14:09 | |
| *** david-lyle has quit IRC | 14:16 | |
| *** ppiela has joined #openstack-ironic | 14:20 | |
| *** Goneri has joined #openstack-ironic | 14:20 | |
| *** jcoufal has joined #openstack-ironic | 14:21 | |
| yolanda | hi dtantsur , thanks for your review on the ironic custom steps. However my knowledge of that spec is limited, could you or other people more related, amend yourselves? specially the bits about expanding the driver interface changes | 14:22 |
| *** udesale has joined #openstack-ironic | 14:22 | |
| dtantsur | yolanda, maybe mat128 and I can do it, but not in the nearest future, probably closer to the PTG | 14:22 |
| *** causten has joined #openstack-ironic | 14:24 | |
| *** karthiks has quit IRC | 14:26 | |
| rloo | hi and morning all, dtantsur, yolanda | 14:34 |
| *** causten has quit IRC | 14:35 | |
| *** yufei has joined #openstack-ironic | 14:35 | |
| yolanda | hi rloo | 14:35 |
| rloo | jroll: i commented on your BAD_REQUEST vs SERVICE_UNAVAILABLE: https://review.openstack.org/#/c/404240/28/ironic/api/controllers/v1/node.py. We should discuss when you have a chance. | 14:35 |
| patchbot | patch 404240 - ironic - Add Virtual Network Interface REST APIs | 14:35 |
| yolanda | dtantsur, ok, i left a comment on the spec, telling that other people more involved will complete it | 14:35 |
| vdrok | morning rloo | 14:36 |
| rloo | hi vdrok | 14:36 |
| dtantsur | morning rloo | 14:36 |
| *** causten has joined #openstack-ironic | 14:36 | |
| *** chlong has quit IRC | 14:37 | |
| vdrok | rloo: a bit of log http://eavesdrop.openstack.org/irclogs/%23openstack-ironic/%23openstack-ironic.2017-01-11.log.html#t2017-01-11T12:59:27 | 14:37 |
| rloo | vdrok: i'm not convinced that it is true that 'everywhere else it's 400 right now'. Is it true? | 14:38 |
| vdrok | yup | 14:38 |
| jroll | yes | 14:38 |
| jroll | morning rloo :) | 14:38 |
| mat128 | dtantsur: I can/will update it soon, juggling with flaky electricity and kids here :P | 14:39 |
| *** amotoki has joined #openstack-ironic | 14:39 | |
| rloo | jroll, vdrok: for this line, if it fails, don't we raise/return http NOT_FOUND? | 14:40 |
| dtantsur | cool, thanks! | 14:40 |
| rloo | https://github.com/openstack/ironic/blob/master/ironic/api/controllers/v1/node.py#L182 | 14:40 |
| vdrok | rloo: so yeah, this is here and there. | 14:40 |
| vdrok | in some places it's 404 in some it's 400 | 14:40 |
| jroll | erm, yeah, true | 14:40 |
| rloo | vdrok: i don't think we're handling it correctly :-( | 14:41 |
| vdrok | we'll need to make sure this is the same everywhere | 14:41 |
| *** causten has quit IRC | 14:41 | |
| rloo | vdrok, jroll: if we have to choose 404 or 400, i'd go with 404. it isn't a bad request, there is something wrong internally like a ocnductor is down? | 14:41 |
| jroll | rloo: I guess I looked for the exception, and in all cases that we catch it, we return a 400 | 14:41 |
| jroll | don't disagree | 14:41 |
| jroll | I'd love a follow-up patch to make this better | 14:42 |
| rloo | jroll: yeah, that is probably true, that we return 400 in those cases. | 14:42 |
| TheJulia | good morning | 14:42 |
| jroll | but I think this patch is roughly consistent with what we have today | 14:42 |
| jroll | morning, TheJulia | 14:42 |
| rloo | jroll: my concern is how to follow up, change the http status and not be backwards compatible/break users | 14:42 |
| *** Guest22365 is now known as rook | 14:42 | |
| vdrok | rloo: but then we can change it everywhere | 14:43 |
| jroll | rloo: which we need to figure out anyway | 14:43 |
| jroll | but let's not add a third status code to what we return in this case | 14:43 |
| *** rook is now known as Guest43791 | 14:43 | |
| rloo | jroll: i didn't do a thorough look, i only saw one where 400 was returned and that was for maintenance. let me check... | 14:43 |
| jroll | rloo: grep -R NoValidHost ironic/api/ | 14:43 |
| jroll | all of them raise BAD_REQUEST | 14:43 |
| vdrok | rloo: jroll we also do get_topic_for in api/ports, and there we don't handle it at all too | 14:43 |
| jroll | vdrok: right | 14:44 |
| *** makowals has quit IRC | 14:45 | |
| rloo | jroll: so about half of those that raise BAD_REQUEST seem valid, the others were probably copy/paste :-( | 14:46 |
| vdrok | rloo: so it seems like at some point we'll have to add a microversion changing all those places to something more appropriate, or at least consistent, and noone will break | 14:46 |
| *** nicodemos has quit IRC | 14:47 | |
| rloo | jroll, vdrok: i'd rather we just raised exception.NoValidHost, not BAD_REQUEST | 14:47 |
| jroll | rloo: I'd be fine with that too | 14:47 |
| vdrok | rloo: well, if a conductor goes down, this is a service side problem, which is 5xx | 14:47 |
| rloo | jroll, vdrok: ie, not handle it. That seems like the lesser evil. | 14:47 |
| jroll | but not 503 unless we change them all | 14:48 |
| *** hw_wutianwei has quit IRC | 14:48 | |
| rloo | vdrok, jroll: i unfortunately agree that maybe we shouldn't do 503 for just this particular case. | 14:48 |
| *** hw_wutianwei has joined #openstack-ironic | 14:48 | |
| *** amoralej|lunch is now known as amoralej | 14:49 | |
| vdrok | if we want to go with 4xx, I'd do 400 actually, as getting 404 for vif attach if conductor goes down feels strange to me | 14:49 |
| *** xavierr has quit IRC | 14:49 | |
| vdrok | blaming the user that he has missed that driver-list has changed :) | 14:50 |
| rloo | vdrok: the problem is that the node exists, so it can't be the user's problem, can it? | 14:50 |
| vdrok | yes | 14:51 |
| vdrok | but, checking driver list can be made a user problem :) | 14:51 |
| jroll | I'm fine with either 400 or 404, and lean toward 400 | 14:52 |
| rloo | vdrok, jroll: you two seem to lean towards 400, and I lean towards 404, but since the sum of you is heavier than me, i think we've tilted towards 400, so leave it as is | 14:53 |
| jroll | rloo: works for me | 14:53 |
| *** makowals has joined #openstack-ironic | 14:55 | |
| openstackgerrit | Merged openstack/python-ironicclient: Update tox envs list https://review.openstack.org/415250 | 14:58 |
| dtantsur | morning TheJulia! your morning portion of boot-from-volume review comments has arrived :) | 14:59 |
| TheJulia | dtantsur: thank you! | 14:59 |
| TheJulia | just in time for coffee to hit me! | 14:59 |
| *** wajdi has joined #openstack-ironic | 14:59 | |
| TheJulia | yolanda: I'm looking a your ironic-lib fix, shouldn't take long | 15:00 |
| yolanda | thanks | 15:00 |
| openstackgerrit | Jim Rollenhagen proposed openstack/ironic: WIP: API changes for driver-composition https://review.openstack.org/417970 | 15:01 |
| openstackgerrit | Jim Rollenhagen proposed openstack/ironic: Expose default interface calculation from driver_factory https://review.openstack.org/418573 | 15:01 |
| *** mrtenio has quit IRC | 15:04 | |
| *** fxpester has quit IRC | 15:04 | |
| *** sacharya has joined #openstack-ironic | 15:04 | |
| *** causten has joined #openstack-ironic | 15:05 | |
| rloo | vdrok: is the gate still broken (multinode job failing?) | 15:06 |
| *** moshele has quit IRC | 15:07 | |
| jroll | rloo: it is not, afaik | 15:08 |
| *** sacharya has quit IRC | 15:08 | |
| rloo | jroll: ok, i'll update the whiteboard | 15:08 |
| jroll | ah, thanks | 15:08 |
| lucasagomes | rloo, jroll morning | 15:10 |
| lucasagomes | btw folks, this looks good already: https://review.openstack.org/#/c/348191 | 15:10 |
| patchbot | patch 348191 - ironic - Generic management I/F for Inject NMI | 15:10 |
| jroll | \o lucasagomes | 15:10 |
| vdrok | mornign TheJulia | 15:11 |
| jroll | nice | 15:11 |
| vdrok | rloo: yeah, forgot to update it yesterday | 15:11 |
| vdrok | it's fixed | 15:11 |
| rloo | hi lucasagomes | 15:11 |
| rloo | vdrok: thx for confirming! | 15:11 |
| *** rama_y has joined #openstack-ironic | 15:11 | |
| *** jaosorior has joined #openstack-ironic | 15:13 | |
| *** causten has quit IRC | 15:16 | |
| *** david-lyle has joined #openstack-ironic | 15:17 | |
| *** lindycoder has joined #openstack-ironic | 15:17 | |
| *** srobert has joined #openstack-ironic | 15:18 | |
| *** rbudden has joined #openstack-ironic | 15:19 | |
| *** david-lyle has quit IRC | 15:21 | |
| NobodyCam | Good Morning Ironic'ers :) | 15:23 |
| *** sacharya has joined #openstack-ironic | 15:25 | |
| TheJulia | yolanda: sorry, -1'ed that change. It took longer, I had to walk through the entire path and execute it step by step to confirm my concern | 15:25 |
| dtantsur | morning NobodyCam | 15:26 |
| yolanda | just saw that... so you mean it failed? i had a deploy and i even could ssh to the created vm, saw the config-2 partition on place :( | 15:27 |
| NobodyCam | Morning dtantsur, TheJulia , yolanda :) | 15:27 |
| yolanda | so it shall be device + partition? | 15:27 |
| *** causten has joined #openstack-ironic | 15:28 | |
| *** baoli has quit IRC | 15:28 | |
| milan | morning dtantsur jroll NobodyCam rloo TheJulia yolanda! :) | 15:28 |
| jroll | \o | 15:28 |
| *** rpioso has joined #openstack-ironic | 15:29 | |
| * milan didn't pay attention here for a bit ;) | 15:29 | |
| vdrok | morning NobodyCam | 15:30 |
| dtantsur | milan, you've gone to the beach, as I usually suggest, haven't you? | 15:30 |
| yolanda | TheJulia, so the right output is self.dev + labelled_partition? | 15:30 |
| * dtantsur finds it a good choice | 15:30 | |
| milan | lucasagomes, dtantsur, w/r the bmc/ipmi_port, is it reported by IPA during the introspection? | 15:30 |
| dtantsur | milan, I highly suspect it's not | 15:31 |
| milan | dtantsur, sure :D how did you know? | 15:31 |
| milan | dtantsur, ugh | 15:31 |
| rloo | hi milan, NobodyCam, TheJulia | 15:31 |
| lucasagomes | milan, not that I know of | 15:31 |
| lucasagomes | milan, not sure how it would tho... I mean, we need to know it prior to introspection right ? | 15:31 |
| dtantsur | milan, try the ipmitool command on our Dell lab machine | 15:31 |
| lucasagomes | otherwise we can't power the node on/off | 15:31 |
| NobodyCam | Morning milan, vdrok and rloo | 15:32 |
| NobodyCam | M | 15:32 |
| NobodyCam | Morning lucasagomes | 15:32 |
| dtantsur | lucasagomes, yeah, the question is whether we can learn it during introspection to match ip+port against the received data | 15:32 |
| lucasagomes | NobodyCam, morning | 15:32 |
| TheJulia | yolanda: more like "return ('/dev/%(part)s' % {'part': found_partition}) | 15:33 |
| patchbot | Error: No closing quotation | 15:33 |
| milan | lucasagomes, dtantsur, right, I guess in won't be the case with the virtualbmc but some other bmc might report it | 15:33 |
| yolanda | ah, just a /dev prefix? | 15:33 |
| * TheJulia wonders if patchbot is vulnerable to remote code execution | 15:33 | |
| dtantsur | milan, oh, right, in case of virtualbmc all bets are off | 15:33 |
| jroll | :P | 15:33 |
| TheJulia | yolanda: yes, udevadm is smart enough to figure out that it is missing /dev | 15:33 |
| TheJulia | yolanda: but dd is not | 15:33 |
| yolanda | ah that may explain | 15:34 |
| milan | dtantsur, facepalm -> me | 15:34 |
| dtantsur | milan, side note: we should also not store 127.0.0.1 in the cache | 15:34 |
| lucasagomes | milan, dtantsur I see, yeah... I'm not sure, unless we get it via the ipmi device exposed in the OS (assuming we have all drivers in place) | 15:34 |
| yolanda | i just logged into the two nodes i deployed with that | 15:34 |
| milan | dtantsur, lucasagomes so w/ virtualbmc neither the ipmi_address nor the ipmi_port is going to be reported | 15:35 |
| *** yufei has left #openstack-ironic | 15:35 | |
| lucasagomes | milan, right, yeah I don't think we have any way to do it w/ vbmc | 15:36 |
| *** udesale has quit IRC | 15:36 | |
| lucasagomes | it's a complete external thing | 15:36 |
| milan | lucasagomes, ack | 15:36 |
| openstackgerrit | Vladyslav Drok proposed openstack/python-ironicclient: Add interface attach/detach support https://review.openstack.org/364420 | 15:37 |
| lucasagomes | TheJulia, good catch on the configdrive + dd thing | 15:37 |
| milan | dtantsur, maybe I could use a check of 127.0.0.1 == ipmi_address to detect the virtualbmc case? | 15:38 |
| TheJulia | lucasagomes: thank you | 15:38 |
| dtantsur | milan, I think for now we should do 2 things: 1. do not use IPMI address for lookup, if ipmi_port is set, 2. do not use IPMI address for lookup, if it's local | 15:38 |
| openstackgerrit | Vladyslav Drok proposed openstack/python-ironicclient: Add interface attach/detach support https://review.openstack.org/364420 | 15:38 |
| dtantsur | milan, you can use netaddr to detect local addresses (127.0.0.2 is also local) | 15:39 |
| openstackgerrit | yolanda.robla proposed openstack/ironic-lib: Fix retrieval of config-2 existing partition https://review.openstack.org/417022 | 15:39 |
| milan | dtantsur, right | 15:39 |
| dtantsur | milan, example: https://github.com/openstack/ironic-inspector/blob/master/ironic_inspector/plugins/standard.py#L204 | 15:39 |
| milan | yup, saw that one couple of times today :D | 15:40 |
| TheJulia | dtantsur: I'm fine with pulling the code that might make noauth work for cinder out of the patch since it is likely just won't work without some cinder side work | 15:41 |
| milan | dtantsur, although the logic is sort of strange: if ipmi_port in driver_info don't use ipmi_address but meh | 15:41 |
| yolanda | TheJulia, indeed, good catch | 15:43 |
| dtantsur | TheJulia, yep, let's make it a separate patch for now | 15:44 |
| dtantsur | milan, we already have the same with bridging :( | 15:44 |
| *** lucasagomes has quit IRC | 15:44 | |
| TheJulia | dtantsur: I'm thinking of not even posting it, it would be a waste of time I think. I could always post it and then abandon it | 15:44 |
| dtantsur | as you wish | 15:45 |
| milan | dtantsur, I've got a working wip that implements a ipmi_address:ipmi_port lookup but won't solve the issue as I've just realised thru my last facepalm | 15:45 |
| *** lucasagomes has joined #openstack-ironic | 15:46 | |
| TheJulia | Then again, I could just also submit a patch to their client library | 15:46 |
| *** Guest43791 is now known as rook | 15:46 | |
| *** hamzy has joined #openstack-ironic | 15:46 | |
| mat128 | milan, dtantsur: if you ever do anything, dont let "if port in driver_info, skip ipmi_address" find it's way into the code | 15:49 |
| mat128 | lucasagomes: I've seen a BMC implementation that ran next to / within QEMU and provided actual an actual BMC device for the kernel to use | 15:49 |
| milan | mat128, yeah it scares me too | 15:49 |
| *** Sukhdev has joined #openstack-ironic | 15:50 | |
| mat128 | milan: for testing downstream, we run vBMC on a different host + port, so having code like that will break us | 15:50 |
| dtantsur | mat128, inspector does not work with it already | 15:50 |
| dtantsur | it does not work with duplicating IPMI addresses | 15:50 |
| mat128 | indeed as there is nothing to inspect, right? | 15:50 |
| mat128 | oh | 15:50 |
| mat128 | oh, didnt notice that last part :( | 15:51 |
| dtantsur | this is a problem we have with virtualbmc now | 15:51 |
| lucasagomes | mat128, cool, yeah I know qemu started adding support for having an IPMI device, I've seem some patches merged into it | 15:51 |
| lucasagomes | but, idk what status is it now | 15:51 |
| mat128 | lucasagomes: not exactly sure it's ready for prime time, but cant hurt to check | 15:51 |
| lucasagomes | ++ | 15:51 |
| milan | mat128, so even detecting that ipmi_address is local one wouldn't help | 15:51 |
| JayF | so dtantsur, ironic-inspector can't use vBMC b/c you inspect by IP address, right? | 15:51 |
| mat128 | 2 years ago: https://gist.github.com/bot11/a34ff0008cae75bd662d | 15:51 |
| *** aslezil_ has joined #openstack-ironic | 15:51 | |
| JayF | Have we ever tried binding virtualbmc to additional localhost addresses? i.e. node-1 on 127.0.0.1, node-2 on 127.0.0.2, etc | 15:52 |
| lucasagomes | mat128, cool, I've seem the base patched merged in qemu last year | 15:52 |
| dtantsur | JayF, even so, it's going to be quite useful for inspector. it can't look up such nodes. | 15:52 |
| mat128 | JayF: this should work | 15:52 |
| lucasagomes | mat128, I will check it later, see if there's any improvements on it | 15:52 |
| openstackgerrit | Milan Kováčik proposed openstack/ironic-inspector: [WIP] introduce bmc port support https://review.openstack.org/419010 | 15:52 |
| lucasagomes | that would be a great thing to have actually | 15:52 |
| mat128 | we use it similarly with 10/8 ips on a tap vpn for testing | 15:53 |
| milan | dtantsur, ^^^ | 15:53 |
| lucasagomes | folks, if you have few minutes mind taking a look at: https://review.openstack.org/#/c/414227/ ? | 15:54 |
| patchbot | patch 414227 - ironic - Move default image logic from DevStack to Ironic | 15:54 |
| *** AnxiousGarlic has quit IRC | 15:54 | |
| lucasagomes | it's small and I really want to keep it going | 15:54 |
| milan | dtantsur, but I feel like abandoning is inevitable | 15:54 |
| *** Nisha_Agarwal has joined #openstack-ironic | 15:54 | |
| dtantsur | milan, yeah, it does not look like we can get port from inside the machine | 15:56 |
| milan | dtantsur, right | 15:56 |
| *** zackf has joined #openstack-ironic | 15:57 | |
| * milan forgotten to brew coffee before meeting :-/ | 15:58 | |
| jroll | sorry to hear you'll be late for your meeting, milan | 15:58 |
| jroll | (priorities!) | 15:58 |
| JayF | choices of being slow to the meeting or being slow in the meeting | 15:58 |
| JayF | lol | 15:58 |
| mat128 | lucasagomes: https://review.openstack.org/#/c/414227/ sounds reasonable. Is this done so we can pin to a newer CirrOS for vlan-aware? | 15:58 |
| patchbot | patch 414227 - ironic - Move default image logic from DevStack to Ironic | 15:58 |
| NobodyCam | dtantsur: Thank you for the reviews: quick question on https://review.openstack.org/#/c/418115 Did you mean move the block or change the ^^^ to ~~~? | 15:59 |
| patchbot | patch 418115 - ironic-inspector - Add troubleshooting step for virtual box. | 15:59 |
| milan | jroll, JayF exactly :D | 15:59 |
| JayF | mat128: lucasagomes: I have a -1 incoming for that | 15:59 |
| dtantsur | NobodyCam, in the meeting now, so can't check. I think you're right. | 16:00 |
| lucasagomes | mat128, yes, and UEFI as well | 16:00 |
| lucasagomes | mat128, there's another patch in devstack to remove the logic from there | 16:00 |
| lucasagomes | JayF, :-( | 16:00 |
| lucasagomes | heh | 16:00 |
| * lucasagomes goes to a meeting quickly | 16:00 | |
| * mat128 waits impatiently | 16:00 | |
| * milan brews tea and pretends it's working | 16:01 | |
| JayF | lucasagomes: mat128: That review is up now | 16:02 |
| lucasagomes | JayF, awesome, I will take a look in a few (after the meeting) | 16:02 |
| openstackgerrit | Merged openstack/ironic: Fix bashate warning in devstack plugin https://review.openstack.org/412606 | 16:04 |
| rloo | vdrok: sorry, I reviewed an older version of https://review.openstack.org/#/c/364420/ | 16:04 |
| patchbot | patch 364420 - python-ironicclient - Add interface attach/detach support | 16:04 |
| vdrok | rloo: np, will take a look | 16:05 |
| *** nicodemos has joined #openstack-ironic | 16:05 | |
| openstackgerrit | Chris Krelle proposed openstack/ironic-inspector: Add troubleshooting step for virtual box. https://review.openstack.org/418115 | 16:06 |
| *** ijw has joined #openstack-ironic | 16:06 | |
| *** mjura has quit IRC | 16:10 | |
| *** lindycoder has quit IRC | 16:10 | |
| *** chlong has joined #openstack-ironic | 16:11 | |
| *** rook has quit IRC | 16:11 | |
| *** ijw has quit IRC | 16:11 | |
| *** rbartal has quit IRC | 16:13 | |
| *** amarao has quit IRC | 16:13 | |
| *** rook has joined #openstack-ironic | 16:13 | |
| *** rook is now known as Guest93700 | 16:13 | |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic: Document HCTL for root device hints https://review.openstack.org/408051 | 16:14 |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic: Document HCTL for root device hints https://review.openstack.org/408051 | 16:15 |
| *** Syed__ has joined #openstack-ironic | 16:16 | |
| openstackgerrit | Charlle Daniel proposed openstack/ironic: Ensures that OneView nodes are free for use by Ironic https://review.openstack.org/372762 | 16:18 |
| jroll | okay, I've reviewed all the attach/detach/portgroups things \o/ | 16:18 |
| * jroll hopes to do that again this afternoon with +votes everywhere | 16:18 | |
| *** rpioso has quit IRC | 16:25 | |
| openstackgerrit | Anton Arefiev proposed openstack/ironic-specs: Torrent-based provisioning https://review.openstack.org/311091 | 16:27 |
| *** rama_y has quit IRC | 16:27 | |
| *** trown is now known as trown|lunch | 16:28 | |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: TMP: Verify attach/detach https://review.openstack.org/414160 | 16:28 |
| *** Guest93700 is now known as rook-LOLLLLL | 16:29 | |
| *** causten has quit IRC | 16:31 | |
| *** causten has joined #openstack-ironic | 16:32 | |
| *** AlexeyAbashkin has quit IRC | 16:32 | |
| openstackgerrit | Merged openstack/pyghmi: Only complain about Device SDR if no SDRR https://review.openstack.org/417424 | 16:36 |
| jroll | dtantsur: are you planning to do the hardware type hashring changes? if so, soon? :) | 16:37 |
| dtantsur | jroll, I haven't started anything around that | 16:37 |
| jroll | I could try to do that thing | 16:37 |
| dtantsur | if you don't mind - please do | 16:37 |
| * jroll can't remember what it entails | 16:37 | |
| dtantsur | jroll, change https://github.com/openstack/ironic/blob/master/ironic/common/hash_ring.py#L161 | 16:38 |
| jroll | dtantsur: that seems too hard | 16:39 |
| jroll | :P | 16:39 |
| jroll | thanks | 16:39 |
| dtantsur | ;) | 16:39 |
| *** konetzed has quit IRC | 16:40 | |
| *** rook-LOLLLLL is now known as rook | 16:46 | |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic: Do not fail in Inspector.__init__ if [inspector]enabled is False https://review.openstack.org/416232 | 16:46 |
| dtantsur | a driver-comp-related fix ^^^ | 16:46 |
| openstackgerrit | Chris Krelle proposed openstack/ironic-inspector: Add troubleshooting step for virtual box https://review.openstack.org/418115 | 16:46 |
| NobodyCam | Thank you for the review dtantsur. just pushed up the fix for the nit :) | 16:46 |
| dtantsur | k | 16:46 |
| *** moshele has joined #openstack-ironic | 16:48 | |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic: Do not fail in Inspector.__init__ if [inspector]enabled is False https://review.openstack.org/416232 | 16:49 |
| dtantsur | sorry, decided to update the configuration option ^^^ | 16:49 |
| jroll | ++ | 16:49 |
| dtantsur | hmm, what else do we have not covered for the driver composition? IPMI hardware type? | 16:50 |
| jroll | yeah, we'll need one of those | 16:51 |
| dtantsur | I'd prefer https://review.openstack.org/#/c/412631/ to merge first, though. anybody up for reviewing it? | 16:51 |
| patchbot | patch 412631 - ironic - Register/unregister hardware interfaces for conduc... | 16:51 |
| dtantsur | rloo, lucasagomes ^^^? | 16:51 |
| jroll | also converting the other things, but maybe that's for pike | 16:51 |
| rloo | dtantsur: yikes, so many files were touched :) I'll try to look in the next hour... | 16:52 |
| openstackgerrit | Merged openstack/ironic-python-agent: Updated from global requirements https://review.openstack.org/418632 | 16:54 |
| dtantsur | jroll, one of the potential topics for the PTG, I think, is the way forward for drivers, vendors and their 3rdparty CI | 16:54 |
| dtantsur | thanks rloo! | 16:54 |
| jroll | dtantsur: +1, can you put that on the etherpad? | 16:55 |
| dtantsur | I think I did already | 16:55 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: Allow to attach/detach VIF to portgroup https://review.openstack.org/406915 | 16:55 |
| openstackgerrit | Vladyslav Drok proposed openstack/python-ironicclient: Add interface attach/detach support https://review.openstack.org/364420 | 16:55 |
| jroll | cool | 16:56 |
| openstackgerrit | Vladyslav Drok proposed openstack/python-ironicclient: Add interface attach/detach support https://review.openstack.org/364420 | 16:56 |
| dtantsur | jroll, have a link to ptg etherpad handy? my firefox refuses to remember it >_< | 16:57 |
| openstackgerrit | Nisha Agarwal proposed openstack/ironic-specs: Add new capabilities to ironic https://review.openstack.org/338138 | 16:57 |
| Nisha_Agarwal | vdrok ^^^ | 16:57 |
| jroll | dtantsur: https://etherpad.openstack.org/p/ironic-pike-ptg | 16:57 |
| dtantsur | thanks | 16:58 |
| sambetts | woah that etherpad is fuller than it was when I last saw it! | 16:58 |
| openstackgerrit | Merged openstack/ironic-inspector: Add troubleshooting step for virtual box https://review.openstack.org/418115 | 16:59 |
| dtantsur | folks, wdyt about giving https://review.openstack.org/#/q/topic:bug/1646038 some priority? | 17:00 |
| dtantsur | this sounds like a nasty bug | 17:00 |
| rloo | dtantsur, jroll: btw, I added that ptg link to our whiteboard | 17:00 |
| dtantsur | thanks | 17:01 |
| vdrok | dtantsur: I'm all for it, and it's an old one too | 17:01 |
| dtantsur | ugh, the fix is huge >_< | 17:02 |
| *** hw_wutianwei has quit IRC | 17:02 | |
| jroll | rloo: awesome, ty | 17:03 |
| lucasagomes | dtantsur, ty, added to the list | 17:03 |
| *** e0ne has quit IRC | 17:06 | |
| *** dsneddon has joined #openstack-ironic | 17:07 | |
| openstackgerrit | Nisha Agarwal proposed openstack/ironic-specs: Add new capabilities to ironic https://review.openstack.org/338138 | 17:07 |
| *** Sukhdev has quit IRC | 17:08 | |
| *** ijw has joined #openstack-ironic | 17:08 | |
| lucasagomes | JayF, good point on the "," delimiter, I will try to come up with something to prevent the errors there | 17:12 |
| TheJulia | oh cinder, why do your unit tests run in mouth, but your client library insists on having authentication | 17:12 |
| *** ijw has quit IRC | 17:12 | |
| *** pcaruana has quit IRC | 17:12 | |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic: Move default image logic from DevStack to Ironic https://review.openstack.org/414227 | 17:15 |
| *** causten has quit IRC | 17:16 | |
| lucasagomes | JayF, ^ my bash-fu is not great but I think that will do it | 17:16 |
| JayF | I'm sorta... confused as to why we aren't using a bash array there | 17:17 |
| JayF | instead of making a fake comma separated array | 17:17 |
| JayF | http://tldp.org/LDP/Bash-Beginners-Guide/html/sect_10_02.html | 17:17 |
| lucasagomes | JayF, well, I'm just following https://github.com/openstack-dev/devstack/blob/master/stackrc#L647 | 17:18 |
| lucasagomes | JayF, I bet you could have an array, but devstack would need updated to handle it | 17:18 |
| *** causten has joined #openstack-ironic | 17:19 | |
| *** rpioso has joined #openstack-ironic | 17:20 | |
| *** tesseract has quit IRC | 17:20 | |
| *** moshele has quit IRC | 17:21 | |
| JayF | lucasagomes: small suggestion for improvement inline | 17:21 |
| JayF | lucasagomes: basically trying to catch the case of the , already existing | 17:21 |
| lucasagomes | JayF, cool, it should be .. && ! "$IMAGE_URLS" == *"," ] tho, no ? | 17:23 |
| patchbot | Error: Spurious "]". You may want to quote your arguments with double quotes in order to prevent extra brackets from being evaluated as nested commands. | 17:23 |
| lucasagomes | in case it's set but doesn't end up with a comma | 17:24 |
| JayF | lucasagomes: yep, you're right | 17:24 |
| lucasagomes | right on, will fix it | 17:24 |
| * lucasagomes runs pep8 before, just in case | 17:25 | |
| lucasagomes | string manipulation in bash is real masochism | 17:25 |
| JayF | absolutely. | 17:25 |
| JayF | My first openstack experience was "install devstack", and being the type of fellow I am, I tried to read the code first. | 17:26 |
| JayF | Not the best introduction to OpenStack. | 17:26 |
| *** rpioso has quit IRC | 17:26 | |
| JayF | Devstack is amazing but any collection of bash that large is extremely frightening | 17:26 |
| JayF | lol | 17:26 |
| lucasagomes | JayF, lol yeah | 17:26 |
| lucasagomes | I uploaded a new patch-set, apparently openstackgerrit is lazy today | 17:26 |
| lucasagomes | JayF, mine experience was similar. When I joined TripleO was just starting and I was porting diskimage-builder to work on Red Hat stuff (fedora, RHEL, etc...) | 17:27 |
| JayF | dib was one of the other first things I looked at, and the fact it just replaces a real init system with a bash script if it's in ramdisk mode made me very :( | 17:27 |
| lucasagomes | only then I started seeing some python when updating the nova baremetal driver to do the same (before it injected stuff at /etc/network/interfaces, was pretty haunting) | 17:28 |
| *** Bico_Fino has quit IRC | 17:28 | |
| *** rpioso has joined #openstack-ironic | 17:28 | |
| lucasagomes | JayF, oh yeah, PID 1 was a shell script heh | 17:28 |
| *** amoralej is now known as amoralej|off | 17:28 | |
| JayF | That's why we went the route of coreos for the teeth-agent initially | 17:28 |
| *** strigazi is now known as strigazi_AFK | 17:29 | |
| lucasagomes | JayF, right yeah I don't blame you. Having a real PID 1 where services can be properly restarted is fundametal for long running ramdisks | 17:31 |
| JayF | you know what I just realized | 17:32 |
| openstackgerrit | Jim Rollenhagen proposed openstack/ironic: WIP: API changes for driver-composition https://review.openstack.org/417970 | 17:32 |
| openstackgerrit | Jim Rollenhagen proposed openstack/ironic: Add hardware types to the hash ring https://review.openstack.org/419065 | 17:32 |
| JayF | if [[ -n "$IMAGE_URLS" && ! "$IMAGE_URLS" == *"," ]]; then | 17:32 |
| jroll | dtantsur: wooooo hash rings | 17:32 |
| JayF | the -n $IMAGE_URLS is redundant | 17:32 |
| JayF | because it already won't match the second argument | 17:32 |
| * jroll takes a lunch break | 17:32 | |
| JayF | lucasagomes: we can leave it be still if you want, the explicitness isn''t always bad | 17:32 |
| dtantsur | jroll, you rock! | 17:32 |
| lucasagomes | JayF, hmm yeah | 17:32 |
| JayF | lucasagomes: or you can update it to be simpler, your choice, I can +2 either versin ;) | 17:32 |
| lucasagomes | JayF, nah, I got it, lemme change. I have the code open here | 17:32 |
| jroll | dtantsur: most of the work was those dbapi test cases, I needed those anyway :) | 17:32 |
| jroll | bbiab | 17:33 |
| lucasagomes | JayF, the initialization IMAGE_URLS="" seems bogus too | 17:34 |
| lucasagomes | http://paste.openstack.org/show/594601/ | 17:34 |
| JayF | I think bashate may require that | 17:34 |
| * lucasagomes runs it | 17:34 | |
| JayF | the 'initialization' | 17:34 |
| JayF | but imbw | 17:34 |
| JayF | I always find stuff like that ... unneeded | 17:34 |
| *** baoli has joined #openstack-ironic | 17:36 | |
| lucasagomes | bashate seems happy... I will get rid of that, cause I think the logic might be wrong if we leave it too, say the IMAGE_URLS doesn't end with a comma we should not overwrite it with an empty string | 17:36 |
| JayF | cool, yep | 17:36 |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic: Move default image logic from DevStack to Ironic https://review.openstack.org/414227 | 17:37 |
| lucasagomes | there we go! | 17:37 |
| JayF | shit, we're wrong still | 17:37 |
| JayF | lucasagomes: in the case of IMAGE_URLS being unset, we'll always add the , to the beginning of it | 17:38 |
| JayF | so we do need the logic to be "if IMAGE_URLS is not empty AND doesn't end in a comma, add a comma" | 17:38 |
| lucasagomes | lol damn | 17:39 |
| JayF | whereas right now it's "if IMAGE_URLS doesn't end in acomma, add a comma" | 17:39 |
| lucasagomes | yeah the logic was correct two patches ago then | 17:39 |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic: Move default image logic from DevStack to Ironic https://review.openstack.org/414227 | 17:41 |
| lucasagomes | there we go! /me brains not working today anymore | 17:42 |
| JayF | lucasagomes: that's still wrong | 17:42 |
| JayF | lucasagomes: it says "if IMAGE_URLS is not set and doesn't end in acomma, add a comma" | 17:43 |
| lucasagomes | JayF, why ? If the variable is initialized and don't end with a comma | 17:43 |
| JayF | -n is nonzero? | 17:43 |
| JayF | ooooooooh | 17:43 |
| lucasagomes | yeah | 17:43 |
| JayF | I usually writ ethat with -z instead | 17:43 |
| JayF | igi, sorry | 17:43 |
| JayF | my brain not working well either | 17:43 |
| lucasagomes | hah I don't think we can blame ourselfs, I mean, those operators are not user friendly at all | 17:44 |
| lucasagomes | we can do "! -z" as well | 17:44 |
| lucasagomes | JayF, fwiw: http://paste.openstack.org/show/594603/ | 17:45 |
| JayF | I mean, bash was my first language | 17:46 |
| JayF | and I was known as a bash wizard for a while | 17:46 |
| JayF | so it does bug me a bit even if it doesn't bug you | 17:46 |
| lucasagomes | JayF, it bugs me deep inside but then, when I look at a long bash script I think that ignorance is actually a blessing | 17:48 |
| lucasagomes | and feel good again | 17:48 |
| * lucasagomes is mostly kidding | 17:49 | |
| lucasagomes | anyway, I will call it a day | 17:50 |
| NobodyCam | have a good night lucasagomes :) | 17:50 |
| lucasagomes | talk to you later! Have a great evening | 17:50 |
| NobodyCam | have a pint for /me | 17:50 |
| lucasagomes | NobodyCam, hah tomorrow I will (office day)! | 17:50 |
| NobodyCam | :) | 17:50 |
| *** lucasagomes is now known as lucas-afk | 17:50 | |
| * dtantsur goes as well, c u | 17:53 | |
| *** dtantsur is now known as dtantsur|afk | 17:53 | |
| *** aarefiev is now known as aarefiev_afk | 17:54 | |
| NobodyCam | have a great night dtantsur|afk :) | 17:54 |
| *** AlexeyAbashkin has joined #openstack-ironic | 17:55 | |
| *** AlexeyAbashkin has quit IRC | 17:58 | |
| *** AlexeyAbashkin has joined #openstack-ironic | 17:58 | |
| mat128 | JayF, lucas-afk: I think you guys need https://github.com/internap/sbtest :) | 17:59 |
| *** ralonsoh has quit IRC | 18:03 | |
| *** trown|lunch is now known as trown | 18:05 | |
| *** ijw has joined #openstack-ironic | 18:08 | |
| *** ptx0 has quit IRC | 18:10 | |
| *** athomas has quit IRC | 18:10 | |
| *** derekh has quit IRC | 18:10 | |
| *** ijw has quit IRC | 18:13 | |
| *** david-lyle has joined #openstack-ironic | 18:15 | |
| *** david-lyle has quit IRC | 18:16 | |
| *** david-lyle has joined #openstack-ironic | 18:16 | |
| * sambetts -> home | 18:19 | |
| sambetts | night all! | 18:19 |
| *** sambetts is now known as sambetts|afk | 18:19 | |
| *** Alexey_Abashkin has joined #openstack-ironic | 18:21 | |
| *** AlexeyAbashkin has quit IRC | 18:24 | |
| NobodyCam | night sambetts|afk | 18:25 |
| *** rama_y has joined #openstack-ironic | 18:25 | |
| *** amotoki has quit IRC | 18:32 | |
| *** absubram has quit IRC | 18:36 | |
| *** Nisha_Agarwal has quit IRC | 18:38 | |
| *** Nisha_Agarwal has joined #openstack-ironic | 18:38 | |
| *** absubram has joined #openstack-ironic | 18:39 | |
| *** aslezil_ has quit IRC | 18:39 | |
| *** lindycoder has joined #openstack-ironic | 18:43 | |
| *** chlong has quit IRC | 18:46 | |
| *** aslezil_ has joined #openstack-ironic | 18:58 | |
| *** chlong has joined #openstack-ironic | 18:59 | |
| *** causten has quit IRC | 19:00 | |
| *** mtanino has joined #openstack-ironic | 19:02 | |
| *** causten has joined #openstack-ironic | 19:03 | |
| *** Nisha_Agarwal has quit IRC | 19:05 | |
| openstackgerrit | Chris Krelle proposed openstack/ironic-specs: Intel Node Manager sensor collection support https://review.openstack.org/413249 | 19:10 |
| *** gooduone has quit IRC | 19:13 | |
| *** jkilpatr has quit IRC | 19:14 | |
| *** ChubYann has joined #openstack-ironic | 19:16 | |
| jroll | dang, lucas-afk left | 19:16 |
| openstackgerrit | Julia Kreger proposed openstack/ironic: Add Cinder storage driver https://review.openstack.org/366197 | 19:19 |
| openstackgerrit | Julia Kreger proposed openstack/ironic: Add base cinder common interface https://review.openstack.org/355625 | 19:19 |
| openstackgerrit | Chris Krelle proposed openstack/ironic-specs: Intel Node Manager sensor collection support https://review.openstack.org/413249 | 19:22 |
| *** jkilpatr has joined #openstack-ironic | 19:30 | |
| *** amotoki has joined #openstack-ironic | 19:32 | |
| openstackgerrit | Vladyslav Drok proposed openstack/ironic: Allow to attach/detach VIF to portgroup https://review.openstack.org/406915 | 19:36 |
| vdrok | jroll: rloo some scary code added ^^ to ensure the correct relations between portgroups and ports with vifs belonging to them | 19:37 |
| *** krtaylor has quit IRC | 19:37 | |
| * vdrok leaves now | 19:37 | |
| vdrok | will update nova things tomorrow | 19:37 |
| vdrok | good night! | 19:37 |
| jroll | ooo fun | 19:37 |
| rloo | vdrok: scary cuz it is bad, or scary cuz we have to review it? | 19:37 |
| rloo | bye vdrok | 19:37 |
| vdrok | scary cause it's hard to follow, but I added a bunch of comments, hopefully they'll help :) | 19:38 |
| rloo | vdrok: ewwww :) | 19:38 |
| vdrok | I really tried not to add any duplication and unnecessary looping :D | 19:38 |
| rloo | vdrok: ok, will look later today | 19:39 |
| *** jaosorior has quit IRC | 19:46 | |
| *** Alexey_Abashkin has quit IRC | 19:48 | |
| *** AlexeyAbashkin has joined #openstack-ironic | 19:51 | |
| *** causten has quit IRC | 19:53 | |
| *** causten has joined #openstack-ironic | 19:55 | |
| openstackgerrit | Merged openstack/ironic: Document HCTL for root device hints https://review.openstack.org/408051 | 19:56 |
| *** jaosorior has joined #openstack-ironic | 19:56 | |
| *** causten has quit IRC | 19:56 | |
| *** Alexey_Abashkin has joined #openstack-ironic | 19:56 | |
| *** AlexeyAbashkin has quit IRC | 19:57 | |
| *** causten has joined #openstack-ironic | 20:00 | |
| *** moshele has joined #openstack-ironic | 20:10 | |
| *** Alexey_Abashkin_ has joined #openstack-ironic | 20:11 | |
| *** nicodemos has quit IRC | 20:13 | |
| *** nicodemos has joined #openstack-ironic | 20:13 | |
| *** Alexey_Abashkin has quit IRC | 20:13 | |
| *** e0ne has joined #openstack-ironic | 20:14 | |
| *** milan has quit IRC | 20:14 | |
| *** causten has quit IRC | 20:15 | |
| *** Alexey_Abashkin_ has quit IRC | 20:20 | |
| *** causten has joined #openstack-ironic | 20:21 | |
| *** jkilpatr has quit IRC | 20:24 | |
| *** Alexey_Abashkin_ has joined #openstack-ironic | 20:28 | |
| *** jkilpatr has joined #openstack-ironic | 20:29 | |
| *** krtaylor has joined #openstack-ironic | 20:38 | |
| *** jaosorior has quit IRC | 20:39 | |
| *** e0ne has quit IRC | 20:43 | |
| openstackgerrit | Merged openstack/ironic: Add lsblk to ironic-lib filters https://review.openstack.org/418814 | 20:55 |
| *** jjohnson2 has quit IRC | 20:58 | |
| *** causten has quit IRC | 20:59 | |
| *** Alexey_Abashkin_ has quit IRC | 21:00 | |
| mrda | Morning Ironic | 21:01 |
| *** causten has joined #openstack-ironic | 21:02 | |
| *** rama_y has quit IRC | 21:05 | |
| *** rama_y_ has joined #openstack-ironic | 21:05 | |
| openstackgerrit | Merged openstack/ironic-lib: Create configdrive partitions as vfat https://review.openstack.org/418458 | 21:07 |
| rloo | morning mrda! | 21:08 |
| mrda | o/ | 21:08 |
| *** causten has quit IRC | 21:08 | |
| *** trown is now known as trown|mtg | 21:09 | |
| *** causten has joined #openstack-ironic | 21:10 | |
| jroll | hi mrda :) | 21:12 |
| * jroll out for the night, see y'all tomorrow | 21:13 | |
| *** ptx0 has joined #openstack-ironic | 21:13 | |
| NobodyCam | night jroll | 21:14 |
| NobodyCam | morning mrda | 21:15 |
| mrda | o/ | 21:19 |
| *** moshele has quit IRC | 21:19 | |
| NobodyCam | :) | 21:19 |
| openstackgerrit | Milan Kováčik proposed openstack/ironic-inspector: [WIP] introduce bmc port support https://review.openstack.org/419010 | 21:22 |
| openstackgerrit | Bob Fournier proposed openstack/python-ironic-inspector-client: Add new introspection commands for interface data including lldp https://review.openstack.org/419141 | 21:25 |
| *** causten has quit IRC | 21:42 | |
| *** causten has joined #openstack-ironic | 21:42 | |
| *** trown|mtg is now known as trown|outtypewww | 21:42 | |
| *** causten has quit IRC | 21:43 | |
| *** causten has joined #openstack-ironic | 21:43 | |
| *** jaosorior has joined #openstack-ironic | 21:44 | |
| jlvillal | Anyone here an expert on sockets? | 21:45 |
| jlvillal | I'm reviewing: https://review.openstack.org/#/c/411818/6/ironic_python_agent/agent.py | 21:45 |
| patchbot | patch 411818 - ironic-python-agent - Agent: Listen for connections on both IPv4 and IPv... | 21:45 |
| jlvillal | And the author says that it will listen to both IPv4 and IPv6, but it seems like to me it will only listen to IPv6 | 21:46 |
| JayF | I have recently written some python socket code | 21:46 |
| JayF | I saw your comment, the author is 100% right for linux | 21:46 |
| JayF | linux listening on :: will also get you v4 | 21:46 |
| JayF | !linux, listening on :: is v6 only | 21:46 |
| openstack | JayF: Error: "linux," is not a valid command. | 21:46 |
| JayF | unless you set V6_IPV6ONLY explicitly on the socket (in linux) | 21:46 |
| jlvillal | JayF, Ah okay. | 21:46 |
| jlvillal | JayF, And thanks! | 21:47 |
| JayF | np | 21:47 |
| *** causten has quit IRC | 21:48 | |
| *** srobert_ has joined #openstack-ironic | 21:49 | |
| *** srobert has quit IRC | 21:51 | |
| *** krtaylor has quit IRC | 21:54 | |
| *** Goneri has quit IRC | 21:56 | |
| *** ijw has joined #openstack-ironic | 21:57 | |
| *** causten has joined #openstack-ironic | 22:01 | |
| openstackgerrit | Julia Kreger proposed openstack/ironic: Wire in storage interface attach/detach operations https://review.openstack.org/406290 | 22:06 |
| *** causten has quit IRC | 22:07 | |
| *** causten has joined #openstack-ironic | 22:08 | |
| openstackgerrit | Merged openstack/ironic: Add Virtual Network Interface REST APIs https://review.openstack.org/404240 | 22:10 |
| rloo | Yay! ^^ | 22:10 |
| JayF | nice work folks | 22:10 |
| *** causten_ has joined #openstack-ironic | 22:10 | |
| rloo | JayF: it ain't over yet, but getting there... | 22:10 |
| *** causten has quit IRC | 22:12 | |
| *** causten has joined #openstack-ironic | 22:13 | |
| *** bfournie1 has quit IRC | 22:13 | |
| *** causten_ has quit IRC | 22:15 | |
| openstackgerrit | Julia Kreger proposed openstack/ironic: [WIP] iPXE template support for iSCSI https://review.openstack.org/413324 | 22:16 |
| *** causten has quit IRC | 22:17 | |
| *** baoli has quit IRC | 22:30 | |
| *** srobert_ has quit IRC | 22:30 | |
| *** jheroux has quit IRC | 22:38 | |
| openstackgerrit | Julia Kreger proposed openstack/ironic: Add base cinder common interface https://review.openstack.org/355625 | 22:46 |
| *** jkilpatr has quit IRC | 22:47 | |
| openstackgerrit | Mario Villaplana proposed openstack/ironic: Agent driver rescue implementation https://review.openstack.org/400437 | 22:47 |
| openstackgerrit | Mario Villaplana proposed openstack/ironic: Add API and conductor methods for [un]rescue https://review.openstack.org/350831 | 22:47 |
| TheJulia | NobodyCam: ^^^ Did a quick edit, take look and let me know what you think | 22:47 |
| mariojv | ^ jcook: i rebased your patch, was just an api version conflict with the vif apis that just landed | 22:48 |
| *** jcoufal has quit IRC | 22:48 | |
| jlvillal | rloo, JayF, TheJulia : Question on https://review.openstack.org/#/c/417022/ | 22:49 |
| patchbot | patch 417022 - ironic-lib - Fix retrieval of config-2 existing partition | 22:49 |
| jlvillal | So the commit message is sort of mostly wrong on that. | 22:49 |
| jlvillal | It actually got changed to use lsblk. | 22:49 |
| jlvillal | Should I let it go ahead and merge anyway? | 22:49 |
| jlvillal | yolanda, ^^^ | 22:50 |
| rloo | jlvillal: just kill it. edit it. then +A it. | 22:50 |
| jlvillal | rloo, Okay | 22:50 |
| *** jcoufal has joined #openstack-ironic | 22:50 | |
| *** dsneddon is now known as dsneddon_afk | 22:51 | |
| NobodyCam | TheJulia: +1 with a nit :p >_< | 22:52 |
| TheJulia | jlvillal: well, the first line of it is definitely right since even with properly labeled volumes it was not working in some cases :) | 22:54 |
| jlvillal | TheJulia, Right. I'm updating the second part. Almost done. | 22:54 |
| *** jcoufal has quit IRC | 22:54 | |
| TheJulia | okay, awesome :) | 22:54 |
| * TheJulia just pulled it up | 22:54 | |
| *** wajdi has quit IRC | 22:55 | |
| *** chlong has quit IRC | 22:55 | |
| openstackgerrit | John L. Villalovos proposed openstack/ironic-lib: Fix retrieval of config-2 existing partition https://review.openstack.org/417022 | 22:56 |
| jcook | mariojv righteous thanks! | 22:56 |
| jlvillal | TheJulia, Updated. Going to +2 +A it | 22:56 |
| TheJulia | okay, looking at yolanda's update | 22:56 |
| jlvillal | TheJulia, If anything horribly wrong feel free to stop it :) | 22:57 |
| TheJulia | Nope, looks good to me | 22:57 |
| *** lindycoder has quit IRC | 22:57 | |
| *** awiddersheim has quit IRC | 23:01 | |
| *** krtaylor has joined #openstack-ironic | 23:02 | |
| openstackgerrit | Julia Kreger proposed openstack/ironic: Add base cinder common interface https://review.openstack.org/355625 | 23:02 |
| *** jralph has quit IRC | 23:04 | |
| *** jralph has joined #openstack-ironic | 23:04 | |
| *** [1]cdearborn has quit IRC | 23:04 | |
| NobodyCam | :) | 23:05 |
| openstackgerrit | Annie Lezil proposed openstack/ironic-python-agent: Reboot and Poweroff fails with coreos IPA image https://review.openstack.org/412594 | 23:12 |
| *** awiddersheim has joined #openstack-ironic | 23:13 | |
| rloo | NobodyCam, TheJulia, JayF: btw, I always forget if Martin Luther King Day (next Mon) is a US holiday for 'everyone' or just some companies | 23:14 |
| NobodyCam | oh I haven't checked | 23:14 |
| rloo | NobodyCam: I'll be working; just wondering who will/won't. | 23:15 |
| NobodyCam | rloo: it is not listed on my official holiday cal | 23:17 |
| * TheJulia goes and checks | 23:18 | |
| TheJulia | I don't think it is a holiday for me, but regardless I'll likely be working monday | 23:20 |
| *** causten has joined #openstack-ironic | 23:32 | |
| *** rbudden has quit IRC | 23:40 | |
| *** jaosorior has quit IRC | 23:54 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!