| *** soliosg has quit IRC | 00:00 | |
| openstackgerrit | Merged openstack/ironic: Forbid removing portgroup mode https://review.openstack.org/413000 | 00:11 |
|---|---|---|
| openstackgerrit | Merged openstack/ironic: Add API reference for portgroup's mode and properties https://review.openstack.org/413108 | 00:13 |
| openstackgerrit | John L. Villalovos proposed openstack/ironic: WIP/DNM Testing tempest "smoke" 2 https://review.openstack.org/407258 | 00:18 |
| *** palmertime has quit IRC | 00:20 | |
| *** dsneddon_afk is now known as dsneddon_desk | 00:22 | |
| *** UForgotten has quit IRC | 00:23 | |
| *** hw_wutianwei has joined #openstack-ironic | 00:23 | |
| *** mtanino has quit IRC | 00:25 | |
| *** amoralej|off has quit IRC | 00:28 | |
| *** chas has joined #openstack-ironic | 00:29 | |
| *** jschwarz has quit IRC | 00:29 | |
| *** dmellado has quit IRC | 00:29 | |
| *** chas has quit IRC | 00:34 | |
| *** godp1301 has joined #openstack-ironic | 00:36 | |
| *** rloo has quit IRC | 00:38 | |
| *** gmmaharaj has joined #openstack-ironic | 00:40 | |
| *** gmmaha has quit IRC | 00:45 | |
| *** kragniz has quit IRC | 00:45 | |
| *** marlinc has quit IRC | 00:45 | |
| *** gmmaharaj is now known as gmmaha | 00:45 | |
| *** marlinc has joined #openstack-ironic | 00:46 | |
| *** kragniz has joined #openstack-ironic | 00:47 | |
| *** bfournie has joined #openstack-ironic | 00:50 | |
| *** bfournie has quit IRC | 00:51 | |
| *** tuanluong has joined #openstack-ironic | 00:56 | |
| *** Syed__ has quit IRC | 00:57 | |
| *** pas-ha has quit IRC | 00:57 | |
| *** izaakk has quit IRC | 00:57 | |
| *** hoangcx has joined #openstack-ironic | 00:59 | |
| *** chas has joined #openstack-ironic | 01:00 | |
| *** amoralej has joined #openstack-ironic | 01:01 | |
| *** dmellado has joined #openstack-ironic | 01:03 | |
| *** phuongnh has joined #openstack-ironic | 01:05 | |
| *** chas has quit IRC | 01:05 | |
| *** Syed__ has joined #openstack-ironic | 01:07 | |
| *** pas-ha has joined #openstack-ironic | 01:07 | |
| *** izaakk has joined #openstack-ironic | 01:07 | |
| *** godp1301 has quit IRC | 01:09 | |
| *** Syed__ has quit IRC | 01:15 | |
| *** jcoufal has joined #openstack-ironic | 01:16 | |
| *** godp1301 has joined #openstack-ironic | 01:16 | |
| *** mtanino has joined #openstack-ironic | 01:16 | |
| *** amoralej has quit IRC | 01:19 | |
| *** SerenaFeng has joined #openstack-ironic | 01:19 | |
| *** yuanying has joined #openstack-ironic | 01:20 | |
| *** dmellado has quit IRC | 01:21 | |
| *** UForgotten has joined #openstack-ironic | 01:24 | |
| *** lindycoder has quit IRC | 01:25 | |
| *** dmellado has joined #openstack-ironic | 01:30 | |
| *** jschwarz has joined #openstack-ironic | 01:32 | |
| *** amoralej has joined #openstack-ironic | 01:38 | |
| *** yufei has joined #openstack-ironic | 01:48 | |
| *** jcoufal has quit IRC | 02:02 | |
| *** chas has joined #openstack-ironic | 02:03 | |
| *** jkilpatr has joined #openstack-ironic | 02:04 | |
| *** chas has quit IRC | 02:08 | |
| openstackgerrit | Cao Xuan Hoang proposed openstack/ironic-python-agent: Removes unnecessary utf-8 encoding https://review.openstack.org/413866 | 02:37 |
| *** baoli has joined #openstack-ironic | 02:40 | |
| *** jkilpatr has quit IRC | 02:41 | |
| *** yuanying has quit IRC | 02:49 | |
| *** yuanying has joined #openstack-ironic | 02:50 | |
| *** godp1301 has quit IRC | 02:53 | |
| *** yuanying has quit IRC | 02:54 | |
| *** godp1301 has joined #openstack-ironic | 03:03 | |
| *** Goneri has quit IRC | 03:03 | |
| *** baoli has quit IRC | 03:04 | |
| *** chas has joined #openstack-ironic | 03:05 | |
| *** chas has quit IRC | 03:10 | |
| *** mtanino has quit IRC | 03:10 | |
| *** godp1301 has quit IRC | 03:20 | |
| *** soliosg has joined #openstack-ironic | 03:20 | |
| *** wajdi_ has quit IRC | 03:25 | |
| *** shuquan has joined #openstack-ironic | 03:31 | |
| *** amotoki has joined #openstack-ironic | 03:36 | |
| *** links has joined #openstack-ironic | 03:42 | |
| *** SerenaFeng has quit IRC | 03:47 | |
| *** yuanying has joined #openstack-ironic | 03:50 | |
| *** yuanying has quit IRC | 03:50 | |
| *** yuanying_ has joined #openstack-ironic | 03:50 | |
| openstackgerrit | Cao Xuan Hoang proposed openstack/ironic-ui: Removes unnecessary utf-8 encoding https://review.openstack.org/413896 | 03:55 |
| *** frontrunner has quit IRC | 03:58 | |
| *** shuquan_ has joined #openstack-ironic | 04:06 | |
| *** chas has joined #openstack-ironic | 04:07 | |
| *** shuquan has quit IRC | 04:08 | |
| *** chas has quit IRC | 04:13 | |
| *** tuanluong has quit IRC | 04:23 | |
| *** phuongnh has quit IRC | 04:24 | |
| *** phuongnh has joined #openstack-ironic | 04:24 | |
| *** rbudden has quit IRC | 04:34 | |
| *** SerenaFeng has joined #openstack-ironic | 04:40 | |
| *** phuongnh has quit IRC | 04:41 | |
| *** mtreinish has quit IRC | 04:44 | |
| *** mtreinish has joined #openstack-ironic | 04:45 | |
| *** tiendc has joined #openstack-ironic | 05:00 | |
| *** moshele has joined #openstack-ironic | 05:01 | |
| *** tiendc has quit IRC | 05:01 | |
| *** tiendc has joined #openstack-ironic | 05:02 | |
| *** SerenaFeng has quit IRC | 05:07 | |
| *** moshele has quit IRC | 05:08 | |
| *** chas has joined #openstack-ironic | 05:10 | |
| *** yufei has quit IRC | 05:13 | |
| *** chas has quit IRC | 05:15 | |
| openstackgerrit | John L. Villalovos proposed openstack/ironic-python-agent: Fix missing newline at end-of-file in CONTRIBUTING.rst https://review.openstack.org/413912 | 05:19 |
| openstackgerrit | Naohiro Tamura proposed openstack/ironic: Generic power interface for soft reboot and soft power off https://review.openstack.org/216730 | 05:21 |
| *** soliosg has quit IRC | 05:30 | |
| *** amotoki has quit IRC | 05:47 | |
| *** SerenaFeng has joined #openstack-ironic | 05:54 | |
| *** zhangjl has joined #openstack-ironic | 05:55 | |
| *** SerenaFeng has quit IRC | 05:57 | |
| *** SerenaFeng has joined #openstack-ironic | 06:00 | |
| *** SerenaFeng has quit IRC | 06:01 | |
| *** SerenaFeng has joined #openstack-ironic | 06:02 | |
| *** Sukhdev has joined #openstack-ironic | 06:08 | |
| *** chas has joined #openstack-ironic | 06:12 | |
| *** pcaruana has joined #openstack-ironic | 06:17 | |
| *** chas has quit IRC | 06:18 | |
| *** ChubYann has quit IRC | 06:18 | |
| *** tuanluong has joined #openstack-ironic | 06:21 | |
| *** srart has quit IRC | 06:43 | |
| *** Sukhdev has quit IRC | 06:45 | |
| *** ohamada has joined #openstack-ironic | 06:45 | |
| *** ohamada has quit IRC | 06:45 | |
| *** openstackgerrit has quit IRC | 06:48 | |
| *** e0ne has joined #openstack-ironic | 06:52 | |
| *** tesseract has joined #openstack-ironic | 06:58 | |
| *** tesseract has quit IRC | 06:58 | |
| *** tesseract has joined #openstack-ironic | 06:59 | |
| *** tesseract is now known as Guest47337 | 06:59 | |
| *** SerenaFeng has quit IRC | 07:00 | |
| *** SerenaFeng has joined #openstack-ironic | 07:00 | |
| *** hoangcx has quit IRC | 07:02 | |
| *** mjura has joined #openstack-ironic | 07:07 | |
| *** amotoki has joined #openstack-ironic | 07:08 | |
| *** mjura has quit IRC | 07:14 | |
| *** mjura has joined #openstack-ironic | 07:14 | |
| *** chas has joined #openstack-ironic | 07:15 | |
| *** chas has quit IRC | 07:21 | |
| *** amotoki_ has joined #openstack-ironic | 07:26 | |
| *** chas has joined #openstack-ironic | 07:28 | |
| *** fragatina has joined #openstack-ironic | 07:28 | |
| *** amotoki has quit IRC | 07:28 | |
| *** fragatina has quit IRC | 07:28 | |
| *** chas has quit IRC | 07:29 | |
| *** fragatina has joined #openstack-ironic | 07:29 | |
| *** chas has joined #openstack-ironic | 07:29 | |
| *** pc_m has quit IRC | 07:29 | |
| *** chas has quit IRC | 07:30 | |
| *** pc_m has joined #openstack-ironic | 07:31 | |
| *** chas has joined #openstack-ironic | 07:32 | |
| *** openstackgerrit has joined #openstack-ironic | 08:05 | |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: DNM/DNR: testing gate https://review.openstack.org/413545 | 08:05 |
| *** yufei has joined #openstack-ironic | 08:08 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/ironic: Move baremetal tempest config setting from devstack https://review.openstack.org/408404 | 08:08 |
| *** SerenaFeng has quit IRC | 08:10 | |
| *** yufei has quit IRC | 08:12 | |
| pas-ha | morning Ironic :) | 08:15 |
| *** rnoriega has quit IRC | 08:18 | |
| *** lhinds has quit IRC | 08:18 | |
| *** yufei has joined #openstack-ironic | 08:19 | |
| *** marios has quit IRC | 08:19 | |
| *** lhinds has joined #openstack-ironic | 08:21 | |
| *** ccamacho has joined #openstack-ironic | 08:21 | |
| tuanluong | Moring pas-ha | 08:22 |
| *** marios has joined #openstack-ironic | 08:22 | |
| *** rnoriega has joined #openstack-ironic | 08:23 | |
| *** hoangcx has joined #openstack-ironic | 08:27 | |
| *** amotoki_ has quit IRC | 08:30 | |
| *** shuquan has joined #openstack-ironic | 08:32 | |
| *** shuquan_ has quit IRC | 08:34 | |
| *** rnoriega has quit IRC | 08:42 | |
| *** slagle has quit IRC | 08:43 | |
| *** marios has quit IRC | 08:43 | |
| *** rnoriega has joined #openstack-ironic | 08:43 | |
| *** marios has joined #openstack-ironic | 08:44 | |
| *** slagle has joined #openstack-ironic | 08:45 | |
| *** e0ne has quit IRC | 08:45 | |
| *** ricardoas has quit IRC | 08:47 | |
| openstackgerrit | Moshe Levi proposed openstack/ironic-inspector: Adding InfiniBand Support https://review.openstack.org/264257 | 08:52 |
| *** SerenaFeng has joined #openstack-ironic | 08:52 | |
| *** ralonsoh has joined #openstack-ironic | 08:52 | |
| *** SerenaFeng has quit IRC | 08:53 | |
| *** SerenaFeng has joined #openstack-ironic | 08:54 | |
| *** zzzeek has quit IRC | 09:00 | |
| *** ralonsoh_ has joined #openstack-ironic | 09:00 | |
| *** zzzeek has joined #openstack-ironic | 09:00 | |
| *** amotoki has joined #openstack-ironic | 09:02 | |
| *** ralonsoh has quit IRC | 09:02 | |
| *** romcheg has joined #openstack-ironic | 09:08 | |
| *** romcheg has quit IRC | 09:08 | |
| vdrok | morning pas-ha, tuanluong and all! | 09:10 |
| *** Romanenko_K has joined #openstack-ironic | 09:12 | |
| *** amotoki has quit IRC | 09:15 | |
| tuanluong | morning vdrok | 09:20 |
| tuanluong | when will you go to holiday? | 09:20 |
| vdrok | I'll be out only on 2nd and 9th of january | 09:21 |
| openstackgerrit | Galyna Zholtkevych proposed openstack/ironic: Catch unknown exceptions in validate driver ifaces https://review.openstack.org/406157 | 09:22 |
| *** lucas-afk is now known as lucasagomes | 09:23 | |
| lucasagomes | morning all | 09:24 |
| *** ralonsoh_ is now known as ralonsoh | 09:33 | |
| vdrok | morning lucasagomes | 09:40 |
| *** amotoki has joined #openstack-ironic | 09:51 | |
| openstackgerrit | octopuszhang proposed openstack/ironic: Fix wrong exception message when deploy failed https://review.openstack.org/411224 | 09:51 |
| *** e0ne has joined #openstack-ironic | 09:56 | |
| *** jaosorior has joined #openstack-ironic | 09:59 | |
| *** tiendc has quit IRC | 10:01 | |
| *** derekh has joined #openstack-ironic | 10:03 | |
| *** hoangcx has quit IRC | 10:12 | |
| *** amotoki has quit IRC | 10:20 | |
| openstackgerrit | Andrey Shestakov proposed openstack/bifrost: Allow enroll-dynamic on remote host https://review.openstack.org/411299 | 10:22 |
| openstackgerrit | Andrey Shestakov proposed openstack/bifrost: Allow deploy-dynamic on remote host https://review.openstack.org/411304 | 10:25 |
| *** srart has joined #openstack-ironic | 10:26 | |
| *** Shashi has joined #openstack-ironic | 10:27 | |
| Shashi | Hi All, | 10:31 |
| *** hjensas has quit IRC | 10:33 | |
| Shashi | Just wanted to know at the time of provisioning a node to deleted, Why baremetal again has to read deploy_kernel and deploy_ramdisk images? | 10:33 |
| *** zhangjl has left #openstack-ironic | 10:33 | |
| *** sborkows has joined #openstack-ironic | 10:39 | |
| Shashi | please suggest | 10:39 |
| sborkows | morning all | 10:39 |
| Shashi | Happy Morning | 10:46 |
| *** shuquan has quit IRC | 10:54 | |
| sergek | Happy Morning :) | 10:55 |
| lucasagomes | Shashi, after the deletion ? Maybe clean is enabled so that the node will boot the ramdisk again | 10:57 |
| lucasagomes | to perform the cleaning (getting rid of the data from previous tenant) | 10:57 |
| Shashi | lucasgomes: Can I know the how images is helpfull at the time of deletion or to get rid of the data from previous tenant? | 11:01 |
| lucasagomes | Shashi, so, the ramdisk is basically an extension of the ironic code running on the node itself to allow us to access the hardware | 11:02 |
| lucasagomes | Shashi, so for cleaning for example, ironic will shred the data in the disks | 11:03 |
| lucasagomes | s/in/on | 11:03 |
| lucasagomes | Shashi, that said, you can disable it if you want (tho, it's not really recommended to leave data from previous tenants accessible to new ones) | 11:04 |
| *** pmannidi has quit IRC | 11:11 | |
| *** ohamada has joined #openstack-ironic | 11:17 | |
| *** ohamada has quit IRC | 11:17 | |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: DNM/DNR: testing gate https://review.openstack.org/413545 | 11:19 |
| Shashi | lucasagomes: Thanks lucasagomes | 11:26 |
| *** ohamada has joined #openstack-ironic | 11:32 | |
| *** ohamada has quit IRC | 11:33 | |
| vdrok | lucasagomes: regarding that bug with wsme not doing validate but doing frombasetype | 11:40 |
| vdrok | it seems that we'll have to change a bunch of types on ironic side | 11:40 |
| vdrok | like, when doing get_all, type of chassis_uuid should be not uuid, but uuid_or_none | 11:41 |
| vdrok | this will likely break other projects too it seems :( | 11:42 |
| *** chas is now known as _chas | 11:42 | |
| lucasagomes | vdrok, oh noes :-( | 11:43 |
| lucasagomes | ok, so, perhaps we should leave it as-is and create our own type to validate the integers ? | 11:43 |
| vdrok | yup, seems like it | 11:44 |
| lucasagomes | fair enuff | 11:44 |
| vdrok | we have if values is None: return None in a bunch of places in frombasetype | 11:44 |
| *** ricardoas has joined #openstack-ironic | 11:46 | |
| *** _chas_ has joined #openstack-ironic | 11:55 | |
| *** _chas has quit IRC | 11:58 | |
| *** hw_wutianwei has quit IRC | 11:58 | |
| vdrok | lucasagomes: heh, wsme is fun, it gives me this error: "Invalid input for field/attribute timeout. Value: '-1'. unable to convert to integer" without indicating min/max values :) | 12:05 |
| *** tuanluong has quit IRC | 12:05 | |
| vdrok | maybe I'll try to fix that too | 12:06 |
| *** jkilpatr has joined #openstack-ironic | 12:11 | |
| *** fragatina has quit IRC | 12:20 | |
| *** fragatina has joined #openstack-ironic | 12:21 | |
| lucasagomes | vdrok, heh wsme is so far away from being a master-piece | 12:22 |
| *** flaviodsr has joined #openstack-ironic | 12:24 | |
| *** fragatina has quit IRC | 12:27 | |
| *** nicodemos has joined #openstack-ironic | 12:28 | |
| nicodemos | good morning. | 12:32 |
| lucasagomes | nicodemos, morning | 12:34 |
| *** godp1301 has joined #openstack-ironic | 12:34 | |
| vdrok | lucasagomes: https://review.openstack.org/414079 | 12:36 |
| patchbot | patch 414079 - wsme - Print exceptions raised from from_param methods | 12:36 |
| vdrok | morning nicodemos | 12:36 |
| openstackgerrit | Kyrylo Romanenko proposed openstack/python-ironicclient: Add testcases for osc port group comands https://review.openstack.org/385427 | 12:41 |
| *** fragatina has joined #openstack-ironic | 12:41 | |
| lucasagomes | vdrok, will take a look in a few | 12:47 |
| *** lucasagomes is now known as lucas-hungry | 12:47 | |
| vdrok | lucas-hungry: thanks. some issues with tox.ini there, will fix those too | 12:47 |
| *** SerenaFeng has quit IRC | 12:47 | |
| *** derekh has quit IRC | 12:49 | |
| yolanda | hi, question about config drive... | 12:53 |
| yolanda | i'm using ironic with whole disk images, and i see ironic is creating a partition for it at the end of the disk | 12:54 |
| yolanda | is there some way that i can pre-create that partition from my image whhen i build it? labeling it somehow? | 12:54 |
| yolanda | we'd like to have free disk space at the end of the disk, to grow more easily | 12:54 |
| yolanda | so ideally i'd like if that configdrive partition was after my boot one | 12:55 |
| *** frontrunner has joined #openstack-ironic | 12:55 | |
| jroll | yolanda: yeah, I think if you create one with the label 'config-2' it should notice and use it | 12:57 |
| jroll | but idk if anyone has tested that | 12:57 |
| yolanda | i can do it :) | 12:58 |
| *** dprince has joined #openstack-ironic | 12:58 | |
| yolanda | any particular formatting or size needed? i guess 64mb, ext4? | 12:58 |
| vdrok | yolanda: iso9660 usually, or vfat iirc | 12:58 |
| *** godp1301 has quit IRC | 12:58 | |
| yolanda | ah ok | 12:59 |
| vdrok | morning jroll and yolanda | 12:59 |
| yolanda | thx | 12:59 |
| jroll | yeah 64mb max | 12:59 |
| *** MattMan has quit IRC | 13:00 | |
| *** MattMan has joined #openstack-ironic | 13:00 | |
| jroll | vdrok: yolanda: our code makes it ext2, it seems: https://github.com/openstack/ironic-lib/blob/master/ironic_lib/disk_utils.py#L759 | 13:00 |
| jroll | morning vdrok :) | 13:00 |
| vdrok | hm, so it's generated as iso9660 or vfat only on nova side | 13:01 |
| yolanda | ah, why that difference? | 13:01 |
| jroll | yeah dunno | 13:02 |
| jroll | we just dd the iso down | 13:02 |
| yolanda | i'm working in whole disk images for tripleo, i posted some of my progress here http://teknoarticles.blogspot.com.es/2016/12/start-using-whole-disk-images-with.html | 13:02 |
| *** ccamacho is now known as ccamacho|lunch | 13:02 | |
| jroll | suspect creating an iso9660 fs would work fine too | 13:02 |
| yolanda | i don't mind, whatever is better | 13:03 |
| yolanda | jroll, vdrok , and i guess it needs to be a partition, can't be a volume? | 13:04 |
| *** godp1301_ has joined #openstack-ironic | 13:04 | |
| jroll | ummm | 13:04 |
| jroll | using cloud-init I assume? | 13:05 |
| vdrok | yeah, that's on cloud-init or whatever is reading it side | 13:05 |
| yolanda | i'm updating the images using guestfs | 13:05 |
| jroll | I think it may be able to be a volume | 13:06 |
| jroll | just needs to present as a block device or partition | 13:06 |
| jroll | https://github.com/number5/cloud-init/blob/master/cloudinit/sources/DataSourceConfigDrive.py#L219 | 13:06 |
| yolanda | mm, looking at the code, it checks for a blkid | 13:06 |
| yolanda | so it could be a volume labeled properly? | 13:07 |
| *** wajdi has joined #openstack-ironic | 13:07 | |
| jroll | I think so? | 13:08 |
| jroll | disks aren't my strong suit :) | 13:08 |
| yolanda | i try to confirm | 13:08 |
| yolanda | going to build the image with that, and i'll launch | 13:09 |
| *** godp1301_ has quit IRC | 13:15 | |
| *** godp1301 has joined #openstack-ironic | 13:16 | |
| openstackgerrit | Vladyslav Drok proposed openstack/python-ironicclient: Add mode and properties to portgroup https://review.openstack.org/412545 | 13:16 |
| *** links has quit IRC | 13:18 | |
| *** godp1301 has quit IRC | 13:20 | |
| yolanda | hi jroll . I created that spec https://review.openstack.org/412523, based on the one for RAID, i was talking with dtantsur|afk , and the RAID one was referencing deployment steps internally. But should be better to have an isolated one for it | 13:22 |
| patchbot | patch 412523 - ironic-specs - Ironic deployment steps | 13:22 |
| yolanda | i'd need feedback there, as i just know the idea generally | 13:23 |
| *** chlong has joined #openstack-ironic | 13:23 | |
| jroll | yolanda: yeah, that's on my radar, I think it's a good idea. I'm out for the rest of the year though (including today), so I'll review it in january :) | 13:25 |
| yolanda | yep, last day for me as well | 13:25 |
| *** trown|outtypewww is now known as trown | 13:25 | |
| *** lucas-hungry is now known as lucasagomes | 13:26 | |
| *** amoralej is now known as amoralej|lunch | 13:28 | |
| *** yufei has quit IRC | 13:29 | |
| lucasagomes | jroll, yolanda morning folks | 13:32 |
| *** bfournie has joined #openstack-ironic | 13:33 | |
| lucasagomes | jlvillal, around ? It seems we don't need the granade backport for https://review.openstack.org/#/c/412622/ ? | 13:33 |
| patchbot | patch 412622 - ironic (stable/mitaka) - Move CONF.service_available.ironic to our plugin | 13:33 |
| *** lindycoder has joined #openstack-ironic | 13:35 | |
| lucasagomes | btw jroll ^ if you have a time too, I think you are the last of the stable maintainers around :D | 13:35 |
| *** wajdi has quit IRC | 13:36 | |
| jroll | lucasagomes: not really here, today, sorry | 13:36 |
| lucasagomes | no worries | 13:36 |
| jroll | I guess I could land that | 13:36 |
| jroll | but it's WIP | 13:36 |
| jroll | idk, I'll let jlvillal answer, can check back later | 13:37 |
| lucasagomes | jroll, fair enough, yeah no problem | 13:42 |
| *** Shashi has quit IRC | 13:46 | |
| yolanda | hi lucasagomes | 13:52 |
| *** shuquan has joined #openstack-ironic | 13:56 | |
| *** shuquan has quit IRC | 13:57 | |
| *** ccamacho|lunch is now known as ccamacho | 14:02 | |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: Add Virtual Network Interface REST APIs https://review.openstack.org/404240 | 14:06 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: TMP: Verify attach/detach https://review.openstack.org/414160 | 14:06 |
| TheJulia | Good morning | 14:07 |
| *** skazi has quit IRC | 14:07 | |
| vsaienk0 | morning TheJulia | 14:09 |
| vdrok | good morning TheJulia | 14:11 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: DNM/DNR: testing gate Depends-On: I52128756f18d3857963a0687de77f7cdfd11fb3e Depends-On: I62cc4ae3e9fe7dc63ec4373535fe6ae07084a381 Depends-On: I7c603cdf2a51a217d34f2a495423eefca5a892aa Depends-On: I62cc4ae3e9fe7dc63ec4373535fe6ae07084a381 Change-Id: I54a2e https://review.openstack.org/413545 | 14:14 |
| *** baoli has joined #openstack-ironic | 14:15 | |
| *** baoli has quit IRC | 14:15 | |
| *** baoli has joined #openstack-ironic | 14:16 | |
| *** godp1301 has joined #openstack-ironic | 14:17 | |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: Add Virtual Network Interface REST APIs https://review.openstack.org/404240 | 14:19 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: TMP: Verify attach/detach https://review.openstack.org/414160 | 14:19 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: DNM/DNR: testing gate https://review.openstack.org/413545 | 14:19 |
| *** jcoufal has joined #openstack-ironic | 14:21 | |
| *** rloo has joined #openstack-ironic | 14:22 | |
| lucasagomes | TheJulia, morning | 14:30 |
| *** amoralej|lunch is now known as amoralej | 14:38 | |
| openstackgerrit | Kyrylo Romanenko proposed openstack/python-ironicclient: Add testcases for OSC baremetal port group commands https://review.openstack.org/385427 | 14:40 |
| rloo | hi lucasagomes, morning TheJulia | 14:40 |
| *** jheroux has joined #openstack-ironic | 14:41 | |
| lucasagomes | rloo, hello there | 14:42 |
| TheJulia | good morning rloo | 14:42 |
| rloo | is the gate down? gate-tempest-dsvm-ironic-inspector-ubuntu-xenial-nv is failing: http://ci-watch.tintri.com/project?project=ironic&time=7+days | 14:43 |
| rloo | although that is a non-voting job, but still. i see other 'random'? failures too :-( | 14:45 |
| openstackgerrit | Vladyslav Drok proposed openstack/python-ironicclient: Add mode and properties to portgroup OSC plugin https://review.openstack.org/413028 | 14:47 |
| lucasagomes | rloo, looks very flaky indeed | 14:47 |
| vdrok | morning rloo | 14:48 |
| rloo | lucasagomes: yeah. not good, esp with people away :-( | 14:48 |
| lucasagomes | http://logs.openstack.org/46/411446/2/check/gate-tempest-dsvm-ironic-inspector-ubuntu-xenial-nv/02c6771/console.html.gz#_2016-12-16_08_02_05_908564 | 14:48 |
| vdrok | rloo: yeah, the gate is unstable, seems related to nova | 14:48 |
| vdrok | association takes too long, maybe has something to do with some recent scheduler/placement api changes in nova | 14:48 |
| rloo | vdrok: oh. so recheck is the only thing we can do? | 14:49 |
| rloo | vdrok: do we have some wait-time that we can increase, at least short term? | 14:49 |
| vdrok | rloo: vsaienk0 tried to increase association timeout, no luck with that, some jobs still fail | 14:49 |
| rloo | vdrok, vsaienk0: do you know if nova knows about this issue? | 14:50 |
| vsaienk0 | rloo: pas-ha pinged jpipes about it | 14:50 |
| rloo | vdrok, vsaienk0: should we open a bug about it? or put notes about this in our whiteboard? | 14:51 |
| pas-ha | rloo: definitely. | 14:51 |
| vsaienk0 | rloo: I've already opened a bug: https://bugs.launchpad.net/ironic/+bug/1651678 | 14:52 |
| openstack | Launchpad bug 1651678 in Ironic "Slow nodes at the gate leads to ironic tempest timeouts" [Undecided,New] | 14:52 |
| rloo | vsaienk0: good (i should really look at the bugs more often). i'll add to whiteboard | 14:52 |
| *** baoli has quit IRC | 14:58 | |
| *** baoli has joined #openstack-ironic | 14:59 | |
| *** baoli has quit IRC | 14:59 | |
| *** baoli has joined #openstack-ironic | 15:00 | |
| vsaienk0 | rloo: just added more info to the bug, and pinged nova folks in IRC | 15:00 |
| rloo | thx vsaienk0! | 15:00 |
| vsaienk0 | rloo: np! | 15:00 |
| *** marlinc has quit IRC | 15:02 | |
| rloo | jlvillal: is ironic stable/newton grenade still broken? | 15:02 |
| *** mtanino has joined #openstack-ironic | 15:03 | |
| rloo | lucasagomes: that inspector problem seems diff from the timeout one (or it could be the same but appears diff w/o digging into it) | 15:03 |
| *** Fdaisuke has quit IRC | 15:04 | |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: TMP: Verify attach/detach https://review.openstack.org/414160 | 15:05 |
| lucasagomes | rloo, yeah, that seems related to https://review.openstack.org/#/c/412622/ (the patch to master) | 15:06 |
| patchbot | patch 412622 - ironic (stable/mitaka) - Move CONF.service_available.ironic to our plugin | 15:06 |
| openstackgerrit | Julia Kreger proposed openstack/bifrost: Default keystone to uuid tokens https://review.openstack.org/407231 | 15:06 |
| lucasagomes | but I haven't dug either | 15:06 |
| rloo | lucasagomes: should we leave a note in whiteboard, or let inspector folks deal with it? | 15:07 |
| lucasagomes | rloo, ++ for whiteboard | 15:07 |
| *** rbudden has joined #openstack-ironic | 15:07 | |
| lucasagomes | becuase maybe someone wants to take a look/fix it before | 15:08 |
| *** _mbelanger has joined #openstack-ironic | 15:12 | |
| jlvillal | rloo, lucasagomes jroll: I think that ironic stable/newton is still broken. Unless something happened during the night. | 15:12 |
| jlvillal | lucasagomes, I think we still need the grenade backport to land first. The passing tests were with the grenade backport. | 15:12 |
| rloo | jlvillal: ok thx. i need to clean up the whiteboard to indicate there is more than one issue... | 15:12 |
| *** marlinc has joined #openstack-ironic | 15:12 | |
| *** Goneri has joined #openstack-ironic | 15:13 | |
| *** e0ne has quit IRC | 15:14 | |
| rloo | TheJulia, vsaienk0, vdrok: I'm good with +A'ing this, although i think the release note should be updated to address TheJulia's concern. Do we want to update first, or followon ? | 15:15 |
| rloo | https://review.openstack.org/#/c/327046/ | 15:15 |
| patchbot | patch 327046 - ironic - Add Virtual Network Interface Driver APIs | 15:15 |
| lucasagomes | jlvillal, ok, but are we running the granade job for stable/mitaka ? | 15:16 |
| jlvillal | lucasagomes, I didn't test stable/mitaka | 15:17 |
| vdrok | rloo: I'm OK with followup | 15:17 |
| TheJulia | I think follow-up is okay, although there are plenty of us to go ahead and just land it with a quick update to the reno. :) | 15:17 |
| lucasagomes | jlvillal, cause this backport https://review.openstack.org/#/c/412622/ is to mitaka | 15:18 |
| patchbot | patch 412622 - ironic (stable/mitaka) - Move CONF.service_available.ironic to our plugin | 15:18 |
| lucasagomes | apparently there are no grenade job there | 15:18 |
| vdrok | morning jlvillal | 15:18 |
| lucasagomes | so I'm not sure we need the backport for it, I agree with newton tho | 15:18 |
| jlvillal | lucasagomes, Right. But the failure is in stable/newton, which runs the test first on stable/mitaka | 15:18 |
| lucasagomes | jlvillal, oh right | 15:18 |
| jlvillal | lucasagomes, If that makes sense | 15:18 |
| lucasagomes | it tests upgrade from mitaka to newton, in the newton gate | 15:19 |
| lucasagomes | yeah, makes sense | 15:19 |
| rloo | vdrok, TheJulia: +A'd. With the random failures in gate, seemed best to try to just get this in. | 15:19 |
| TheJulia | wfm | 15:19 |
| vsaienk0 | rloo: I will update release note and other nits in follow up | 15:19 |
| rloo | vsaienk0: thx, see my comments too, cuz i don't think we should make some of those suggestions :) | 15:19 |
| *** jheroux has quit IRC | 15:21 | |
| openstackgerrit | Joanna Taryma proposed openstack/ironic-specs: Clean invalid conflict response usages and unneccessary retries https://review.openstack.org/414194 | 15:24 |
| *** fragatina has quit IRC | 15:28 | |
| vsaienk0 | rloo: thanks, sure I will recheck all comments | 15:29 |
| _mbelanger | TheJulia, I sent an email regarding python-ironicclient weird behaviour that we discussed briefly yesterday. It was hard to explain on IRC so I used e-mail instead and would like to discuss about next step regarding my propositions | 15:32 |
| TheJulia | _mbelanger: you realize, changing it at this point is likely a major client version bump? | 15:32 |
| _mbelanger | Yes because it is a behaviour change | 15:33 |
| TheJulia | Ok | 15:34 |
| *** mtan_____ has joined #openstack-ironic | 15:34 | |
| _mbelanger | What would be the best way to approach this. Fixing the issue blindly by returning the first node of the list as it is expected and changing (no breaking) and doing an other separate patch for a version 2 that fix the behaviour? | 15:35 |
| openstackgerrit | Kyrylo Romanenko proposed openstack/python-ironicclient: Functional tests for port groups in ironicclient https://review.openstack.org/297727 | 15:35 |
| *** mtanino has quit IRC | 15:35 | |
| *** jheroux has joined #openstack-ironic | 15:36 | |
| openstackgerrit | Joanna Taryma proposed openstack/ironic-python-agent: Fail IPA startup if no protocol prefix in ironic api address Add regex validation of api_url specified in configuration file. Oslo config will raise exception if no supported protocol prefix is included in Ironic api address in configuration file. Support https://review.openstack.org/413661 | 15:37 |
| _mbelanger | TheJulia I suppose doing a major just for this is not desirable | 15:38 |
| TheJulia | _mbelanger: I've not read your email, but the user of the library can't receive any change in the resulting data structure they receive with the current client major version. I guess I'm trying to say I'm slightly ambivalent, but I expect the community, if it wants it changed, would push for a major version. | 15:38 |
| TheJulia | _mbelanger: yeah :( | 15:38 |
| TheJulia | _mbelanger: I'll get to email in about an hour and I'll read your email then. I think I understand what your saying, but I'll read it in a little bit | 15:39 |
| vsaienk0 | rloo: fyi attach/detach passing CI with Nova change: http://logs.openstack.org/60/414160/3/check/gate-tempest-dsvm-ironic-ipa-partition-pxe_ipmitool-tinyipa-ubuntu-xenial/8a6f1bf/logs/screen-ir-cond.txt.gz#_2016-12-22_15_32_25_557 | 15:40 |
| rloo | vsaienk0: yay! | 15:41 |
| openstackgerrit | Szymon Borkowski proposed openstack/ironic: Add RPC and object version pinning https://review.openstack.org/407491 | 15:45 |
| *** sborkows has quit IRC | 15:49 | |
| openstackgerrit | Andrey Shestakov proposed openstack/bifrost: Fixes to allow install Ironic on remote node https://review.openstack.org/409213 | 15:55 |
| *** galyna has joined #openstack-ironic | 15:55 | |
| xhku | morning o/ | 15:56 |
| *** Sukhdev has joined #openstack-ironic | 15:56 | |
| openstackgerrit | Julia Kreger proposed openstack/bifrost: Support to wait for node deployment to complete https://review.openstack.org/254245 | 15:57 |
| *** Syed__ has joined #openstack-ironic | 15:58 | |
| *** Guest47337 has quit IRC | 16:03 | |
| *** baoli has quit IRC | 16:09 | |
| *** baoli has joined #openstack-ironic | 16:10 | |
| *** awiddersheim has quit IRC | 16:12 | |
| rloo | lucasagomes: ok, finally remembered to update whiteboard with gate failures. I hope folks can understand... | 16:14 |
| lucasagomes | ty! | 16:15 |
| * lucasagomes looks | 16:15 | |
| *** awiddersheim has joined #openstack-ironic | 16:15 | |
| *** mjura has quit IRC | 16:15 | |
| yolanda | hi jroll , so i tested my approach but ironic creates another config drive | 16:18 |
| yolanda | i created a volume like that | 16:18 |
| yolanda | blkid /dev/vg/config | 16:18 |
| rloo | vsaienk0, vdrok, others: I'm here today, then gone until Jan 9. let me know if there is anything you want me to look at today | 16:18 |
| yolanda | /dev/vg/config: LABEL="config-2" UUID="1a78cf37-cfbe-4d44-a659-5bdea9731320" TYPE="ext2" | 16:18 |
| yolanda | but on the deployed image, i see another extra config drive partition created at the end | 16:18 |
| TheJulia | yolanda: jroll is out today | 16:21 |
| yolanda | i was talking with him this morning... so i had to try :) | 16:21 |
| TheJulia | rloo: Have some wonderful time off :) | 16:22 |
| rloo | TheJulia: thx. my wish is that all the patches I reviewed will be merged before I'm back :) | 16:22 |
| TheJulia | yolanda: can you point me to what what partition table is looking like prior to the config drive being written? I'm somewhat familiar with that code | 16:22 |
| TheJulia | rloo: :) | 16:23 |
| yolanda | TheJulia, so i'm using whole disk images for it | 16:23 |
| yolanda | so what i tried to do is create my own config-drive volume | 16:23 |
| yolanda | i just labeled the filesystem with config-2 | 16:23 |
| yolanda | TheJulia, so if i inspect the image i get | 16:24 |
| yolanda | sh 'blkid -L config-2' | 16:24 |
| yolanda | /dev/mapper/vg-config | 16:24 |
| yolanda | that is the config drive i created | 16:24 |
| TheJulia | yolanda: I _think_ it needs to be the volume label | 16:25 |
| TheJulia | so... lvm is wrapped around it? | 16:25 |
| openstackgerrit | Joanna Taryma proposed openstack/ironic-python-agent: Fail IPA startup if no protocol prefix in ironic api address Add regex validation of api_url specified in configuration file. Oslo config will raise exception if no supported protocol prefix is included in Ironic api address in configuration file. Support https://review.openstack.org/413661 | 16:25 |
| yolanda | TheJulia, yes, my POC is using volumes | 16:25 |
| yolanda | i was looking at how glean code reads it for example, and executed | 16:26 |
| yolanda | sh 'blkid -t LABEL="config-2"' | 16:26 |
| yolanda | /dev/mapper/vg-config: LABEL="config-2" UUID="1a78cf37-cfbe-4d44-a659-5bdea9731320" TYPE="ext2" | 16:26 |
| yolanda | glean seems to find it properly | 16:26 |
| openstackgerrit | Joanna Taryma proposed openstack/ironic: Fixed allowing non-uuids as node UUID for port and portgroup. https://review.openstack.org/403910 | 16:26 |
| yolanda | TheJulia, ironic conductor logs may give some clue? | 16:27 |
| yolanda | i see something like | 16:27 |
| yolanda | Running cmd (subprocess): sudo ironic-rootwrap /etc/ironic/rootwrap.conf blkid -o device /dev/disk/by-path/ip-192.168.24.9:3260-iscsi-iqn.2008-10.org.openstack:9223128e-fcf4-4e53-b81e-0af817c21eac-lun-1 -t LABEL=config-2 execute /usr/lib/python2.7/site-packages/oslo_concurrency/processutils.py:349 | 16:27 |
| yolanda | CMD "sudo ironic-rootwrap /etc/ironic/rootwrap.conf blkid -o device /dev/disk/by-path/ip-192.168.24.9:3260-iscsi-iqn.2008-10.org.openstack:9223128e-fcf4-4e53-b81e-0af817c21eac-lun-1 -t LABEL=config-2" returned: 2 in 0.304s execute /usr/lib/python2.7/site-packages/oslo_concurrency/processutils.py:379 | 16:28 |
| TheJulia | so pxe_ipmitool, I would have guessed aent | 16:30 |
| TheJulia | agent | 16:30 |
| vdrok | rloo: I only have a couple of small patches to client :) | 16:30 |
| vdrok | wrt portgroup mode properties | 16:31 |
| rloo | vdrok: ok, will look at those soon | 16:31 |
| *** ralonsoh has quit IRC | 16:31 | |
| *** baoli has quit IRC | 16:34 | |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/ironic: Move default image logic from DevStack to Ironic https://review.openstack.org/414227 | 16:35 |
| TheJulia | yolanda: so if it is inside lvm, as far as I'm aware, ironic doesn't know to scan for and activate volume groups (which is not really a great idea to begin with) | 16:35 |
| yolanda | yep, looking at the logs, i just see it doesn't find it and creates on its own | 16:36 |
| yolanda | so going to move to a partition instead | 16:36 |
| yolanda | TheJulia, so i'm working on that as a base script http://teknoarticles.blogspot.com.es/2016/12/start-using-whole-disk-images-with.html | 16:36 |
| yolanda | but the problem we found on deploying, is that config drive that goes in the end, so we'd prefer to do on the image so we can locate at the start of the disk | 16:37 |
| yolanda | then leave the rest of the disk empty for other partitions or volume growth | 16:37 |
| TheJulia | You could have a hot plug rule perhaps on the conductor, but I'm not sure if the iscsi device appearing would trigger it, and even then, its not exactly a great idea because then it would show as a previously active lvm that was not properly shutdown | 16:37 |
| TheJulia | yolanda: That is actually kind of a neat script :) | 16:38 |
| yolanda | i don't want to make it so complicated, so i'll try with partitions... | 16:41 |
| *** Romanenko_K has quit IRC | 16:50 | |
| lucasagomes | folks, I'm calling it a day | 16:59 |
| lucasagomes | have a great evening all | 16:59 |
| *** lucasagomes is now known as lucas-afk | 16:59 | |
| nicodemos | bye lucas-afk. o/ | 17:00 |
| rloo | bye lucas-afk | 17:01 |
| _mbelanger | Thx TheJulia, will wait for answer before taking any action | 17:01 |
| vdrok | good night lucas-afk | 17:01 |
| *** jaosorior has quit IRC | 17:05 | |
| *** jaosorior has joined #openstack-ironic | 17:05 | |
| *** fragatina has joined #openstack-ironic | 17:12 | |
| vdrok | good night everyone! | 17:13 |
| nicodemos | good night, vdrok. | 17:14 |
| amoralej | dmsimard, about https://review.rdoproject.org/r/#/c/4145/ we have a problem | 17:16 |
| amoralej | our nodepool images in review.r.o include wrong librbd1 | 17:16 |
| amoralej | since the image creation | 17:17 |
| amoralej | which is different that in upstream gates | 17:17 |
| amoralej | i'm now sure who can help me to check how we create images | 17:17 |
| TheJulia | _mbelanger: Well, it is exactly what I thought :\ | 17:18 |
| amoralej | wrong channel :( | 17:19 |
| TheJulia | amoralej: no worries | 17:19 |
| TheJulia | goodnight vdrok | 17:19 |
| _mbelanger | Behaviour change ? | 17:19 |
| TheJulia | _mbelanger: returned data structure. It _feels_ like like we're kind of mixing strings, literal Nones, emtpy values, and the fact that a get on /nodes returns, well.. nodes in a list. | 17:21 |
| _mbelanger | TheJulia Yes, I reproduce it easily with the unit-tests. The execution flow for a get(None) is causing that behaviour. I guess whatever the fix is, it will require a major | 17:23 |
| _mbelanger | To be consistent with the command line, we should return 400 error | 17:24 |
| TheJulia | Well, command line, at least I think it would be, like ironic node-show '', not ironic node-show None | 17:28 |
| TheJulia | I guess we ought to be converting it to a string value for interpretation? | 17:29 |
| TheJulia | I'm not sure that would be breaking. _mbelanger originally, I thought you were focused on the returned data structure, which agreeably is not ideal. Really this is several problems intertwined | 17:31 |
| TheJulia | At least, that is how I'm perceiving it right now. | 17:31 |
| openstackgerrit | Yuriy Zveryanskyy proposed openstack/ironic: Auto-set nullable notification payload fields when needed https://review.openstack.org/413197 | 17:33 |
| *** fragatina has quit IRC | 17:33 | |
| openstackgerrit | Yuriy Zveryanskyy proposed openstack/ironic: Add ironic resources CRUD notifications https://review.openstack.org/356541 | 17:33 |
| openstackgerrit | Yuriy Zveryanskyy proposed openstack/ironic: Add node maintenance notifications https://review.openstack.org/396239 | 17:34 |
| openstackgerrit | Yuriy Zveryanskyy proposed openstack/ironic: Add node console notifications https://review.openstack.org/397812 | 17:34 |
| _mbelanger | TheJulia, no the data structure is not changed at all in what I propose. I was suggesting to just catch the fact that we pass None in get() method so it returns a bad request or an other exception since normally the Bad request should come from the API. Or maybe not catching the None at all and push it through the API /v1/nodes/None and let the APi behave | 17:35 |
| TheJulia | So, I think you could do it as a non-major client change potentially _if_ None is detected in the client and then replaced in the client to an empty string, and then from there do the checking based upon that. | 17:38 |
| TheJulia | The path /v1/nodes/None could actually be a real physical node with the name 'None' too | 17:39 |
| nicodemos | happy holidays and merry christmas to everyone. good night. | 17:41 |
| *** nicodemos has quit IRC | 17:41 | |
| TheJulia | Actually, i'm really quite wrong | 17:42 |
| *** baoli has joined #openstack-ironic | 17:44 | |
| openstackgerrit | Ruby Loo proposed openstack/ironic: Update dev-quickstart: interval value cannot be -1 https://review.openstack.org/414244 | 17:44 |
| TheJulia | setting resource_id=None in python literally means give me all the nodes with the way it is written. | 17:44 |
| TheJulia | _mbelanger: I guess I'm really lacking what your expected behavior is, above and beyond the... first 50 nodes gets pulled down and returned. Perhaps context of some code that your trying to write? | 17:50 |
| *** trown is now known as trown|lunch | 17:51 | |
| _mbelanger | TheJulia, I know that None is python is actually expected and return the list of all not but when you are calling node.list() this works perfectly. But node.get(None) returns and object Node filled with a list of Nodes instead of a python list [] of node | 17:53 |
| jroll | jlvillal: right, so if/when the mitaka backports are ready to be approved, ping me and I'll make sure we do that thing | 17:53 |
| jlvillal | jroll: Will do. Right now blocked as the grenade stable/newton gate is broken :( | 17:53 |
| jroll | jlvillal: gotcha | 17:53 |
| jlvillal | Hopefully they fix it soon... | 17:53 |
| _mbelanger | I found the error by mistake because I accidentally passed None to node.get()... | 17:54 |
| *** soliosg has joined #openstack-ironic | 17:54 | |
| _mbelanger | And this is badly (IMO) handled | 17:54 |
| _mbelanger | I like your suggestion of checking if resource_id=None then replace by empty string (but only for the node.get) it would not impact node.list at all | 17:55 |
| *** jcoufal has quit IRC | 17:57 | |
| _mbelanger | TheJulia: just tested what you proposed and down in the path it doesn't work because of a condition downstream in the code | 17:58 |
| TheJulia | _mbelanger: I think that some change would work if isolated, I do have this feeling I've hit that data structure before somehow, but only on NodeManager.get if node_ident is None. Kind of seems like invalid to call .get(None), at least to me | 17:59 |
| TheJulia | if not node_ident: \ raise Exception ? and see how man things break? :) | 18:04 |
| NobodyCam | Good Morning Ironic'ers | 18:05 |
| jlvillal | TheJulia: if node_ident is None: ??? though I'm wandering into the middle of this conversation. | 18:05 |
| TheJulia | jlvillal: I guess that would be more proper, since it truly is not a boolean, and if someone did .get(True), it could get interesting. | 18:06 |
| jlvillal | TheJulia: I have a strange pet peeve if trying to check if something is None, then check if None, not if it is False, "", 0, None | 18:06 |
| jlvillal | But not sure if in this case are trying to see if it is None or not | 18:07 |
| TheJulia | jlvillal: in this case, if there is a value or not seems like the thing to do | 18:07 |
| TheJulia | but "" is also a fun one, if node_ident in ("", None): :) | 18:08 |
| jlvillal | TheJulia: Okay, if "", {}, [], 0, False, and None are all invalid | 18:08 |
| * TheJulia wonders if the API would accept {} or [] as the name of a node | 18:09 | |
| jlvillal | TheJulia: Well hopefully those would become "{}" or "[]". Strings | 18:09 |
| TheJulia | jlvillal: ;) | 18:09 |
| jlvillal | TheJulia: Mostly a pet peeve of mine in functions where there is a default arg. def foo(some_arg=None) | 18:10 |
| jlvillal | TheJulia: And the check is: if not some_arg: | 18:10 |
| jlvillal | TheJulia: I want. if some_arg is None: | 18:10 |
| TheJulia | jlvillal: or if some_arg in list_of_things_it_should_never_be: | 18:12 |
| jlvillal | Anyone here have friends in the tempest reviewer land? https://review.openstack.org/#/c/406999/ | 18:13 |
| patchbot | patch 406999 - tempest - Multitenancy not restricted by Ironic anymore | 18:13 |
| jlvillal | We (Ironic) need that to get tempest "smoke" tests to pass with multi-tenant networking and Ironic | 18:14 |
| * TheJulia wonders who the tempest reviewers are at this point | 18:16 | |
| TheJulia | jlvillal: Heh, some of them are on my internal team, I'll inquire | 18:17 |
| jlvillal | TheJulia: Thank you! | 18:18 |
| jroll | it doesn't seem like our API is broken... what API call does Node.get(resource_id=None) make? | 18:18 |
| jroll | curl /v1/nodes/None -> {"error_message": "{\"code\": 400, \"description\": \"Expected a logical name or UUID but received None.\", \"title\": \"Bad Request\"}"} | 18:18 |
| _mbelanger | TheJulia: I understand what you mean even if node_ident is now resource_id. And don't get me wrong I was not planning to call NodeManager.get(resource_id=None). I found that problem by mistake and found the behaviour wierd and made our code to crash | 18:19 |
| _mbelanger | jroll I know that this will return 400 | 18:19 |
| _mbelanger | but if you look here : https://github.com/openstack/python-ironicclient/blob/1.8.0/ironicclient/common/base.py#L55 | 18:19 |
| jroll | OH | 18:19 |
| jroll | that's silly | 18:19 |
| _mbelanger | if resource_id=None then /v1/nodes is called not | 18:19 |
| _mbelanger | Yeah :P | 18:19 |
| _mbelanger | But the same method is used for NodeManager.list() which perfectly works | 18:20 |
| jroll | yeah so I'd say NodeManager.get() should check that and error | 18:20 |
| *** srobert has joined #openstack-ironic | 18:20 | |
| _mbelanger | yeah that's what I would expect | 18:21 |
| TheJulia | That is what I'm thinking now that I've wrapped my head around what _mbelanger is actually encountering | 18:21 |
| *** Sukhdev has quit IRC | 18:22 | |
| _mbelanger | What Exception should we return then? | 18:22 |
| _mbelanger | would say BadRequest to match the API and the CLI | 18:22 |
| jroll | I'm thinking ValidationError | 18:24 |
| jroll | """Error in validation on API client side.""" | 18:24 |
| TheJulia | jlvillal: People prodded :) | 18:24 |
| jroll | since we didn't actually make an API request | 18:24 |
| jlvillal | TheJulia: Woot :) | 18:25 |
| jroll | jlvillal: on that tempest patch, why not just set shared_physical_network=False for the job? | 18:26 |
| _mbelanger | jroll: Ok works for me. I will fill a bug for that? | 18:29 |
| jroll | _mbelanger: you already filed a bug, no? | 18:30 |
| _mbelanger | jroll: No not yet I wanted to be sure I was not wrong. | 18:30 |
| _mbelanger | I'll do then | 18:30 |
| jroll | oh, I thought I saw a bug report, maybe was an email though | 18:31 |
| jroll | ah yeah, email | 18:31 |
| _mbelanger | Yeah email only. Open question | 18:31 |
| jroll | +1 for bug | 18:31 |
| _mbelanger | good | 18:31 |
| *** jcoufal has joined #openstack-ironic | 18:31 | |
| jlvillal | jroll: Good idea. Speaking of which: https://review.openstack.org/#/c/406376/ :) | 18:55 |
| patchbot | patch 406376 - ironic - Configure tempest for multitenancy/flat network | 18:55 |
| openstackgerrit | John L. Villalovos proposed openstack/ironic: WIP/DNM Testing tempest "smoke" 2 https://review.openstack.org/407258 | 18:56 |
| *** soliosg is now known as soliosg|afk | 18:57 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/bifrost: Updated from global requirements https://review.openstack.org/414276 | 18:59 |
| *** amoralej is now known as amoralej|off | 19:01 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/ironic: Updated from global requirements https://review.openstack.org/414283 | 19:02 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/ironic-inspector: Updated from global requirements https://review.openstack.org/414284 | 19:02 |
| yolanda | TheJulia, no luck... i created a partition, labeled config-2 but ironic creates a new one | 19:04 |
| yolanda | blkid /dev/vda2 | 19:05 |
| yolanda | /dev/vda2: LABEL="config-2" UUID="d1534873-35d3-4279-beb7-ef9e3cd1deb3" TYPE="ext2" | 19:05 |
| yolanda | and then | 19:05 |
| yolanda | blkid /dev/vda4 | 19:05 |
| yolanda | /dev/vda4: UUID="2016-12-22-20-56-10-00" LABEL="config-2" TYPE="iso9660" | 19:05 |
| openstackgerrit | Maxime Belanger proposed openstack/python-ironicclient: Raise on NodeManager get when invalid resource_id https://review.openstack.org/414301 | 19:09 |
| openstackgerrit | Maxime Belanger proposed openstack/python-ironicclient: Raise on NodeManager get when invalid resource_id https://review.openstack.org/414301 | 19:13 |
| _mbelanger | jroll ^^ | 19:14 |
| jroll | _mbelanger: thanks! | 19:18 |
| *** trown|lunch is now known as trown | 19:19 | |
| _mbelanger | np | 19:19 |
| openstackgerrit | Maxime Belanger proposed openstack/python-ironicclient: Raise on NodeManager get when invalid resource_id https://review.openstack.org/414301 | 19:36 |
| _mbelanger | jroll, jlvillal valid point and addressed ^^ | 19:36 |
| *** rcernin has joined #openstack-ironic | 19:38 | |
| jlvillal | _mbelanger: quick question, any chance any other invalid falsey type value could make it there? for example: {}, [], 0, False. Or would "" and None be the only ones? | 19:38 |
| _mbelanger | jlvillal, well, I guess any falsy value can happen there | 19:39 |
| _mbelanger | So maybe we should change the error message then | 19:39 |
| jlvillal | _mbelanger: Oh :( and yeah. | 19:39 |
| _mbelanger | Ok, safer that way | 19:40 |
| jlvillal | _mbelanger: Thanks | 19:40 |
| *** baoli has quit IRC | 19:46 | |
| *** baoli has joined #openstack-ironic | 19:46 | |
| *** baoli has quit IRC | 19:47 | |
| _mbelanger | jlvillal, trying to find the right word to put as the error message I do not know how to summary falsy values. Do you have a suggestion for the error message? | 19:51 |
| jlvillal | _mbelanger: Maybe just say, "The argument resource_id is invalid. Value provided: {!r}".format(resource_id) | 19:53 |
| _mbelanger | Fair enough | 19:54 |
| jlvillal | >>> resource_id = {} | 19:54 |
| jlvillal | >>> "The argument resource_id is invalid. Value provided: {!r}".format(resource_id) | 19:54 |
| jlvillal | 'The argument resource_id is invalid. Value provided: {}' | 19:54 |
| jlvillal | >>> resource_id = "" | 19:54 |
| jlvillal | >>> "The argument resource_id is invalid. Value provided: {!r}".format(resource_id) | 19:54 |
| jlvillal | "The argument resource_id is invalid. Value provided: ''" | 19:54 |
| *** baoli has joined #openstack-ironic | 19:56 | |
| openstackgerrit | Maxime Belanger proposed openstack/python-ironicclient: Raise on NodeManager get when invalid resource_id https://review.openstack.org/414301 | 20:00 |
| rloo | jlvillal, _mbelanger: I just replied to _mbelanger's email -- someone might want to reply saying that it has moved to a patch/bug? | 20:00 |
| _mbelanger | rloo I can when it i'll receive it | 20:00 |
| rloo | jlvillal, _mbelanger: the CLI checks for the id, see common/utils.py, check_empty_arg. that might help wrt error string | 20:01 |
| _mbelanger | in the meantime jroll, jlvillal, rloo, just made a new proposition https://review.openstack.org/414301 | 20:01 |
| patchbot | patch 414301 - python-ironicclient - Raise on NodeManager get when invalid resource_id | 20:01 |
| rloo | _mbelanger: oh, didn't mean to reply to my reply. but you could. just would be good for folks to know that the 'discussion' seems to have moved to a bug/patch. | 20:01 |
| _mbelanger | rloo that is OK since I opened the bug couple hours ago | 20:02 |
| rloo | jlvillal: if you have some time. i'm not convinced the gate is cooperating with us today but if it is, might be nice to get this done: https://review.openstack.org/#/c/412545/ | 20:03 |
| patchbot | patch 412545 - python-ironicclient - Add mode and properties to portgroup | 20:03 |
| jlvillal | rloo: I will check it out. Yeah I am noticing some gate intermittent issues :( | 20:04 |
| rloo | jlvillal: i updated the whiteboard earlier today. am thinking it is getting worse but hard to tell since i'm only monitoring the patches that i'm interested in :) | 20:04 |
| *** e0ne has joined #openstack-ironic | 20:05 | |
| *** baoli has quit IRC | 20:05 | |
| *** baoli has joined #openstack-ironic | 20:07 | |
| *** ricardoas has left #openstack-ironic | 20:07 | |
| jlvillal | rloo: +2/+A on that one. | 20:07 |
| rloo | thx jlvillal | 20:07 |
| jlvillal | rloo: If you have any free time: https://review.openstack.org/408417 | 20:10 |
| patchbot | patch 408417 - ironic (stable/newton) - Configure tempest for multitenancy/flat network | 20:10 |
| jlvillal | No not that one | 20:10 |
| rloo | good cuz i don't have powers there | 20:10 |
| jlvillal | rloo: This one: https://review.openstack.org/406376 | 20:10 |
| patchbot | patch 406376 - ironic - Configure tempest for multitenancy/flat network | 20:10 |
| *** baoli has quit IRC | 20:10 | |
| rloo | tempest stuff i don't know much about, will look... | 20:10 |
| jlvillal | Thanks | 20:10 |
| jlvillal | rloo: jroll: Would CI changes ever need a spec? Like changing the devstack network layout? | 20:11 |
| jlvillal | Or another way of saying this. Would a spec on how our devstack networking layout is setup be useful? | 20:11 |
| rloo | jlvillal: that's a good question. i would say yes, if it isn't something straightforward. | 20:11 |
| jlvillal | Not sure if specs are only for actual Ironic stuff. | 20:11 |
| jlvillal | That the operator would use. | 20:12 |
| rloo | jlvillal: the way i see specs is -- if there are questions about the design/implementation, a spec is useful/needed. | 20:12 |
| jlvillal | Or does it also encompass our development tools | 20:12 |
| jlvillal | rloo: Well it is for sure not straightforward :) | 20:12 |
| *** snecklifter has quit IRC | 20:12 | |
| rloo | jlvillal: then yes, a spec would be good. and maybe necessary. | 20:12 |
| rloo | jlvillal: we don't have hard/fast rules about what requires a spec. | 20:13 |
| jlvillal | rloo: I think the number of people who really understand how our networking is setup in devstack could be counted on one hand. | 20:13 |
| jlvillal | rloo: Thanks | 20:13 |
| rloo | jlvillal: i hate to say this, but the number of people who really understand how <X> works could be counted on one hand. for some X, not all X. | 20:14 |
| rloo | jlvillal: question about https://review.openstack.org/#/c/406376/9/devstack/lib/ironic | 20:16 |
| patchbot | patch 406376 - ironic - Configure tempest for multitenancy/flat network | 20:16 |
| rloo | you added L1712. so right now, w/o that patch, flat network doesn't work/test properly? | 20:17 |
| *** baoli has joined #openstack-ironic | 20:17 | |
| *** ChubYann has joined #openstack-ironic | 20:19 | |
| *** e0ne has quit IRC | 20:27 | |
| *** e0ne has joined #openstack-ironic | 20:30 | |
| openstackgerrit | Bob Fournier proposed openstack/ironic-inspector: Add plugin to process basic management LLDP TLVs https://review.openstack.org/406496 | 20:31 |
| *** snecklifter has joined #openstack-ironic | 20:34 | |
| *** Sukhdev has joined #openstack-ironic | 20:38 | |
| *** rloo has quit IRC | 20:39 | |
| *** ohamada has joined #openstack-ironic | 20:40 | |
| *** rloo has joined #openstack-ironic | 20:40 | |
| *** e0ne has quit IRC | 20:41 | |
| jlvillal | rloo, Without that patch doing: tempest "smoke" doesn't work. As it expects the fixed_network_name to be set. | 20:43 |
| jlvillal | rloo, So flat network with tempest "smoke" doesn't work. | 20:43 |
| * jlvillal goes back to eating his lunch :) | 20:44 | |
| rloo | jlvillal: thx. i wasn't sure if this was only a 'cleanup' or it was doing something more. | 20:44 |
| *** baoli has quit IRC | 20:46 | |
| *** baoli has joined #openstack-ironic | 20:46 | |
| *** ohamada has quit IRC | 20:47 | |
| *** dsneddon_desk is now known as dsneddon | 20:54 | |
| mrda | Morning Ironic | 21:02 |
| *** mtan_____ has quit IRC | 21:09 | |
| *** jcoufal has quit IRC | 21:09 | |
| *** jaosorior has quit IRC | 21:16 | |
| NobodyCam | morning mrda | 21:31 |
| *** dsneddon is now known as dsneddon_biab | 21:35 | |
| openstackgerrit | Bob Fournier proposed openstack/ironic-inspector: Add plugin to process basic management LLDP TLVs https://review.openstack.org/406496 | 21:41 |
| mrda | NobodyCam: o/ | 21:41 |
| jlvillal | rloo: Have you noticed any keystone failures in the gate? | 21:49 |
| NobodyCam | o/ :) | 21:49 |
| jlvillal | NobodyCam: Is that an indication that you have? | 21:49 |
| rloo | jlvillal: not recently. i think there were some a week or more ago, can't recall now | 21:49 |
| rloo | jlvillal: any particular test? | 21:50 |
| jlvillal | rloo: Okay. I've seen it twice today. For example: http://logs.openstack.org/76/406376/9/gate/gate-tempest-dsvm-ironic-ipa-partition-pxe_ipmitool-tinyipa-ubuntu-xenial/0d67cde/logs/devstacklog.txt.gz#_2016-12-22_20_59_12_678 | 21:50 |
| NobodyCam | not keystone, lots of strange timeouts, and maybe some other random other errors I have not dug in to | 21:50 |
| NobodyCam | s/other errors/errors | 21:51 |
| jlvillal | NobodyCam: Thanks | 21:51 |
| rloo | NobodyCam: see whiteboard. looks like everything is failing now. last successful one was earlier today: http://ci-watch.tintri.com/project?project=ironic&time=7+days | 21:51 |
| rloo | am not convinced a 'recheck' will help any more | 21:51 |
| NobodyCam | yea! | 21:52 |
| *** _mbelanger has quit IRC | 21:52 | |
| jlvillal | Ouch :( | 21:52 |
| jlvillal | rloo: The inspector job is non-voting though | 21:52 |
| rloo | jlvillal: inspector is due to something else. see the whiteboard :) | 21:53 |
| jlvillal | rloo: But yeah, at least one job seems to fail for each run | 21:53 |
| jlvillal | rloo: Yeah the global requirements also has the keystone error | 21:54 |
| rloo | jlvillal: oh. | 21:54 |
| jlvillal | The latest job on that CI watch board. If it goes from newest->oldest | 21:54 |
| *** snecklifter has quit IRC | 21:56 | |
| jlvillal | rloo: I'm asking in keystone channel if this might be a known issue | 21:57 |
| rloo | jlvillal: how do you know it is due to keystone? and that is certainly a diff error than the ones i have been seeing. is it just due to the global requirements change or have you seen it elsewhere? | 21:58 |
| jlvillal | rloo: I've seen the keystone error in at least three gate runs | 21:58 |
| rloo | jlvillal: oh. maybe update the whiteboard :-( | 21:58 |
| *** dprince has quit IRC | 21:59 | |
| jlvillal | rloo: So I thought I'd see if it might be a known issue before we start looking too deeply. | 21:59 |
| *** godp1301 has quit IRC | 22:00 | |
| jlvillal | rloo: Will update whiteboard | 22:00 |
| TheJulia | yolanda: crazy idea.... but I'm wondering if it is one of those fun differences we see sometimes between iscsi vs local disk access. I took a look at the ironic-lib code and nothing is standing out at me as problematic, but it should be finding the first partition. Maybe full debug logs might be helpful. I would try an agent based deploy since your using | 22:02 |
| TheJulia | a whole disk image, that is, if you can | 22:02 |
| openstackgerrit | John L. Villalovos proposed openstack/ironic: WIP/DNM: Testing the gate failures https://review.openstack.org/414339 | 22:05 |
| *** _chas_ has quit IRC | 22:06 | |
| rloo | jlvillal: so what i see, is that the two most recent patches in ci-watch are failing due to keystone. which makes me think we now have 2 issues :-( | 22:06 |
| jlvillal | jlvillal: yeah :( | 22:06 |
| *** _chas has joined #openstack-ironic | 22:07 | |
| jlvillal | rloo: Maybe an openstack client thing? | 22:07 |
| rloo | jlvillal: dunno. but it has to do with keystone. | 22:07 |
| rloo | jlvillal: ironic isn't even started | 22:07 |
| jlvillal | Yeah... | 22:07 |
| *** trown is now known as trown|outtypewww | 22:09 | |
| openstackgerrit | John L. Villalovos proposed openstack/ironic: WIP/DNM: Testing the gate failures https://review.openstack.org/414339 | 22:10 |
| *** lindycoder has quit IRC | 22:10 | |
| *** _chas has quit IRC | 22:11 | |
| *** dsneddon_biab is now known as dsneddon | 22:11 | |
| *** srobert_ has joined #openstack-ironic | 22:15 | |
| *** srobert has quit IRC | 22:18 | |
| *** Sukhdev has quit IRC | 22:19 | |
| *** srobert_ has quit IRC | 22:20 | |
| *** ppiela has quit IRC | 22:22 | |
| *** soliosg|afk is now known as soliosg | 22:27 | |
| *** _chas has joined #openstack-ironic | 22:28 | |
| *** chlong has quit IRC | 22:34 | |
| *** jheroux has quit IRC | 22:40 | |
| *** chlong has joined #openstack-ironic | 22:41 | |
| *** lhinds has quit IRC | 22:44 | |
| *** lhinds has joined #openstack-ironic | 22:47 | |
| *** ElCoyote_ has left #openstack-ironic | 22:53 | |
| jlvillal | rloo: I'm suspecting some sort of infra issue on that keystone error. | 22:56 |
| rloo | jlvillal: :-( is anyone looking? if it is infra, i'd think other projects are also affected | 22:57 |
| jlvillal | rloo: Octavia project says they are affected too | 22:57 |
| rloo | jlvillal: i guess it is nice that ironic isn't alone... (trying to be positive, i'm going to be off soon, yay...) | 23:00 |
| jlvillal | rloo: Yeah. Actually I think having other projects affected is a good thing. Good thing for us that is. | 23:00 |
| rloo | jlvillal: ++. more eyes. more pressure. more urgency. | 23:00 |
| jlvillal | Yep | 23:01 |
| *** Sukhdev has joined #openstack-ironic | 23:04 | |
| *** _chas has quit IRC | 23:10 | |
| *** _chas has joined #openstack-ironic | 23:10 | |
| *** flaviodsr has quit IRC | 23:10 | |
| *** _chas has quit IRC | 23:15 | |
| jlvillal | rloo: I updated WhiteBoard to say it seems to be an OpenStack wide CI issue. Nova is also affected. | 23:17 |
| *** ashestakov has quit IRC | 23:36 | |
| *** ijw has joined #openstack-ironic | 23:38 | |
| *** dsneddon is now known as dsneddon_afk | 23:48 | |
| *** Sukhdev has quit IRC | 23:55 | |
| *** baoli has quit IRC | 23:57 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!