Wednesday, 2016-11-09

*** shobhar_ has joined #openstack-ironic00:12
*** ijw has joined #openstack-ironic00:14
*** portdirect has quit IRC00:16
*** absubram has quit IRC00:18
*** ijw has quit IRC00:19
*** portdirect has joined #openstack-ironic00:19
*** Nisha_away has joined #openstack-ironic00:21
openstackgerritRichard G. Pioso proposed openstack/ironic: DRAC set_bios_config() times out waiting for reply  https://review.openstack.org/39527100:23
*** Nisha_away has quit IRC00:25
*** rpioso has quit IRC00:30
*** moshele has quit IRC00:40
*** chas_ has joined #openstack-ironic00:44
*** hoangcx has joined #openstack-ironic00:48
*** chas_ has quit IRC00:49
*** amotoki has quit IRC00:49
*** chlong has joined #openstack-ironic00:49
*** ijw has joined #openstack-ironic00:55
*** rama_y has quit IRC00:55
*** tuanluong has joined #openstack-ironic00:57
*** rbudden has joined #openstack-ironic01:08
*** hoonetorg has quit IRC01:11
*** shobhar_ has quit IRC01:11
*** syed_ has quit IRC01:15
*** Sukhdev has quit IRC01:23
*** hoonetorg has joined #openstack-ironic01:25
*** godp1301 has joined #openstack-ironic01:42
*** amotoki has joined #openstack-ironic01:43
*** chas_ has joined #openstack-ironic01:45
*** zhangyufei has joined #openstack-ironic01:47
*** amotoki has quit IRC01:48
*** chas_ has quit IRC01:49
openstackgerritNaohiro Tamura proposed openstack/ironic: Generic management I/F for Inject NMI  https://review.openstack.org/34819101:55
*** zhangjl has joined #openstack-ironic01:59
*** ijw has quit IRC02:04
*** godp1301 has quit IRC02:10
openstackgerritJohn L. Villalovos proposed openstack/ironic: Increase verbosity of devstack/lib/ironic  https://review.openstack.org/37049202:17
*** david-lyle has joined #openstack-ironic02:22
*** zhangyufei has quit IRC02:23
*** jcoufal has quit IRC02:23
*** zhangyufei has joined #openstack-ironic02:23
*** zhangyufei has joined #openstack-ironic02:24
*** betherly has quit IRC02:25
openstackgerritMerged openstack/ironic: Update guide section for messaging setup  https://review.openstack.org/39491602:26
*** zhangyufei has quit IRC02:28
*** yibo has joined #openstack-ironic02:33
*** cdearborn has quit IRC02:37
*** chas_ has joined #openstack-ironic02:45
*** zhangyufei has joined #openstack-ironic02:45
*** betherly has joined #openstack-ironic02:46
openstackgerritNaohiro Tamura proposed openstack/ironic: Update the existing APIs due to adding get_supported_power_states  https://review.openstack.org/38219402:47
*** chas_ has quit IRC02:50
*** betherly has quit IRC02:55
*** rloo has quit IRC02:56
*** gcb has quit IRC03:22
*** betherly has joined #openstack-ironic03:34
*** kvcobb has quit IRC03:35
zhangyufeihi, is there any docs about how to configure neutron for ironic multitenants?03:36
*** gcb has joined #openstack-ironic03:38
*** betherly has quit IRC03:40
*** Nisha_away has joined #openstack-ironic03:40
*** portdirect has quit IRC03:44
*** godp1301 has joined #openstack-ironic03:45
*** chas_ has joined #openstack-ironic03:46
*** lindycoder has joined #openstack-ironic03:50
*** chas_ has quit IRC03:51
*** vmud213 has joined #openstack-ironic04:10
*** Romanenko_K has joined #openstack-ironic04:13
openstackgerritOpenStack Proposal Bot proposed openstack/bifrost: Updated from global requirements  https://review.openstack.org/39530504:14
openstackgerritOpenStack Proposal Bot proposed openstack/ironic: Updated from global requirements  https://review.openstack.org/39517404:16
openstackgerritOpenStack Proposal Bot proposed openstack/ironic-inspector: Updated from global requirements  https://review.openstack.org/39517504:16
openstackgerritOpenStack Proposal Bot proposed openstack/ironic-lib: Updated from global requirements  https://review.openstack.org/39531804:16
openstackgerritOpenStack Proposal Bot proposed openstack/ironic-python-agent: Updated from global requirements  https://review.openstack.org/39531904:16
*** Sukhdev has joined #openstack-ironic04:22
*** alex_xu has quit IRC04:23
openstackgerritOpenStack Proposal Bot proposed openstack/python-ironic-inspector-client: Updated from global requirements  https://review.openstack.org/39536304:23
openstackgerritOpenStack Proposal Bot proposed openstack/python-ironicclient: Updated from global requirements  https://review.openstack.org/39536404:23
openstackgerritOpenStack Proposal Bot proposed openstack/python-oneviewclient: Updated from global requirements  https://review.openstack.org/38994204:24
openstackgerritBharath kumar proposed openstack/ironic-python-agent: Moving Reboot bashscript to python  https://review.openstack.org/37247804:25
openstackgerritOpenStack Proposal Bot proposed openstack/virtualbmc: Updated from global requirements  https://review.openstack.org/38995904:26
*** fragatin_ has joined #openstack-ironic04:26
*** hshiina has joined #openstack-ironic04:26
*** bks has joined #openstack-ironic04:28
*** rama_y has joined #openstack-ironic04:28
*** alex_xu has joined #openstack-ironic04:29
*** fragatina has quit IRC04:29
*** fragatin_ has quit IRC04:31
*** links has joined #openstack-ironic04:38
*** godp1301 has quit IRC04:42
*** wajdi_ has quit IRC04:44
*** rbudden has quit IRC04:53
*** pmannidi has quit IRC04:55
*** fragatina has joined #openstack-ironic05:03
*** fragatina has quit IRC05:08
*** pmannidi has joined #openstack-ironic05:08
*** rama_y has quit IRC05:09
*** rama_y has joined #openstack-ironic05:10
openstackgerritHironori Shiina proposed openstack/ironic: Add REST API for volume connector and volume target operation  https://review.openstack.org/21458605:11
*** alex_xu has quit IRC05:17
*** alex_xu has joined #openstack-ironic05:18
*** gcb has quit IRC05:22
*** david-lyle has quit IRC05:22
*** fragatina has joined #openstack-ironic05:22
*** gcb has joined #openstack-ironic05:22
*** david-lyle has joined #openstack-ironic05:23
*** fragatina has quit IRC05:27
*** pmannidi_ has joined #openstack-ironic05:30
*** pmannidi has quit IRC05:32
*** kvcobb has joined #openstack-ironic05:32
*** pmannidi_ is now known as pmannidi05:35
*** gcb has quit IRC05:37
*** gcb has joined #openstack-ironic05:38
*** godp1301 has joined #openstack-ironic05:38
*** godp1301 has quit IRC05:45
*** chas_ has joined #openstack-ironic05:48
*** garthb has joined #openstack-ironic05:48
*** garthb has quit IRC05:48
*** chas_ has quit IRC05:52
*** gcb has quit IRC05:54
*** rbartal has joined #openstack-ironic06:02
*** gcb has joined #openstack-ironic06:06
*** links has quit IRC06:11
*** g3ek has quit IRC06:13
*** g3ek has joined #openstack-ironic06:26
*** moshele has joined #openstack-ironic06:34
*** zhangyufei has quit IRC06:38
*** links has joined #openstack-ironic06:39
*** moshele has quit IRC06:45
*** rama_y has quit IRC06:46
*** betherly has joined #openstack-ironic06:47
*** chas_ has joined #openstack-ironic06:48
*** chas_ has quit IRC06:53
*** rcernin has joined #openstack-ironic06:54
*** jtomasek has quit IRC06:55
hshiinahi ironic07:07
*** tesseract has joined #openstack-ironic07:11
*** tesseract is now known as Guest3903307:11
*** chas_ has joined #openstack-ironic07:19
*** Sukhdev has quit IRC07:28
*** gcb has quit IRC07:35
*** Nisha_away has quit IRC07:38
*** gcb has joined #openstack-ironic07:38
*** moshele has joined #openstack-ironic07:46
pas-hamorning Ironic08:00
*** vsaienko has joined #openstack-ironic08:01
openstackgerritMoshe Levi proposed openstack/ironic-python-agent: [WIP] Add a new Hardware Manager for Mellanox NICs  https://review.openstack.org/33481608:01
*** zhangjl1 has joined #openstack-ironic08:18
*** vsaienko has quit IRC08:21
*** zhangjl has quit IRC08:21
*** zhangjl1 has quit IRC08:22
*** vsaienko has joined #openstack-ironic08:22
*** zhangyufei has joined #openstack-ironic08:22
*** jaosorior has joined #openstack-ironic08:25
tuanluongMorning Ironic08:25
*** ralonsoh has joined #openstack-ironic08:26
*** gcb has quit IRC08:33
*** jpich has joined #openstack-ironic08:46
*** gcb has joined #openstack-ironic08:47
*** openstackgerrit has quit IRC08:48
*** openstackgerrit has joined #openstack-ironic08:48
*** priteau has joined #openstack-ironic08:54
*** hshiina has quit IRC08:59
*** jrist has quit IRC08:59
*** vsaienko has quit IRC08:59
*** zzzeek has quit IRC09:00
*** zzzeek has joined #openstack-ironic09:00
*** jrist has joined #openstack-ironic09:00
*** Nisha_away has joined #openstack-ironic09:02
*** kvcobb has quit IRC09:05
openstackgerritMoshe Levi proposed openstack/ironic-python-agent: [WIP] Add a new Hardware Manager for Mellanox NICs  https://review.openstack.org/33481609:05
*** lucas-afk is now known as lucasagomes09:07
lucasagomesmorning all09:07
*** dtantsur|afk is now known as dtantsur09:15
dtantsurMorning Ironic09:15
*** ohamada has joined #openstack-ironic09:19
*** gcb has quit IRC09:20
openstackgerritVasyl Saienko proposed openstack/ironic-specs: Update ironic-ml2-integration spec  https://review.openstack.org/39366009:21
*** gcb has joined #openstack-ironic09:25
*** zhangyufei has quit IRC09:29
*** derekh has joined #openstack-ironic09:39
*** zhangjl1 has joined #openstack-ironic09:51
*** MattMan has quit IRC09:53
*** MattMan has joined #openstack-ironic09:53
*** bcornec1 has quit IRC09:54
*** bcornec1 has joined #openstack-ironic09:54
*** Nisha_away has quit IRC10:03
*** zhangjl1 has quit IRC10:09
*** tuanluong has quit IRC10:09
*** sborkows has joined #openstack-ironic10:19
vdrokgood morning ironic, pas-ha lucasagomes and dtantsur10:20
dtantsuro/10:20
lucasagomesvdrok, hi there10:20
*** jtomasek has joined #openstack-ironic10:23
*** milan has joined #openstack-ironic10:28
*** gcb has quit IRC10:29
*** gcb has joined #openstack-ironic10:29
*** roeyc has joined #openstack-ironic10:31
milanmorning Ironic! :)10:31
*** roeyc has quit IRC10:35
*** dtantsur is now known as dtantsur|brb10:41
vdrokgood morning milan10:43
milanmorning vdrok! :)10:43
milanvdrok early today ;)10:43
vdrokhah, not really :)10:44
karthiksmilan,  regarding spec for retrieving the numa node information during introspection, what would be the right place for the spec.   ironic inspector specs or  ironic specs10:53
karthiksRFE : https://bugs.launchpad.net/ironic-python-agent/+bug/163525310:54
openstackLaunchpad bug 1635253 in ironic-python-agent "[RFE] Retrieve NUMA node information during introspection" [Undecided,New] - Assigned to Karthik S (ksundara)10:54
milankarthiks, the RFE is against isnpector, right?10:54
milanaaah10:54
milankarthiks, I feel inspector is more appropriate here; worst case scenario we'd have to move it to ironic's repo10:55
karthiksI've moved the RFE from inspecto to IPA.10:55
karthiksmilan,  Ok, I'll add the spec in inspector10:56
*** hw_wutianwei has joined #openstack-ironic10:57
milankarthiks, ack; the IPA and Inspector impact should coexist in a single spec w/r this feature10:57
karthiksmilan, ack10:58
*** amotoki has joined #openstack-ironic10:58
*** hoangcx has quit IRC10:59
*** ChubYann has quit IRC11:03
*** vsaienko has joined #openstack-ironic11:06
*** vsaienko has quit IRC11:07
*** roeyc has joined #openstack-ironic11:07
vsaienk0morning lucasagomes, dtantsur, sambetts, milan, mgould, vdrok and all Ironic'ers!11:09
vdrokmorning vsaienk0 :)11:09
milanmorning vsaienk0! :)11:09
*** livelace has joined #openstack-ironic11:11
vmud213morning vdrok,milan,lucasagomes,dtantsur and everyone else11:15
openstackgerritMerged openstack/ironic: Updated from global requirements  https://review.openstack.org/39517411:16
milanmorning vmud213! :)11:16
*** priteau has quit IRC11:16
openstackgerritMerged openstack/ironic: Update to hacking 0.12.0 and use new checks  https://review.openstack.org/39510211:19
vdrokgood morning vmud21311:20
openstackgerritMerged openstack/python-ironic-inspector-client: Updated from global requirements  https://review.openstack.org/39536311:25
openstackgerritMerged openstack/ironic: DevStack: Support for creating UEFI VMs  https://review.openstack.org/37434611:28
*** hw_wutianwei has quit IRC11:28
*** mgould|afk is now known as mgould11:29
mgouldmorning Ironic!11:29
mgouldmorning milan vdrok dtantsur|brb lucasagomes pas-ha vsaienk0 sambetts|afk vmud213 karthiks11:30
vdrokmorning mgould11:30
pas-hamorning mgould11:30
karthiksmorning mgould11:30
milanmorning mgould pas-ha! :)11:31
* mgould cheers quietly for the UEFI VM patch landing11:31
*** priteau has joined #openstack-ironic11:32
milan\o/ patches landing :)11:36
*** dtantsur|brb is now known as dtantsur11:37
*** portdirect has joined #openstack-ironic11:37
openstackgerritVasyl Saienko proposed openstack/ironic: DNM: Test patch to verify bond  https://review.openstack.org/38866011:38
openstackgerritVasyl Saienko proposed openstack/ironic: Ironic devstack portgroup support  https://review.openstack.org/38174311:38
openstackgerritVasyl Saienko proposed openstack/ironic: Rely on portgroup standalone_ports_supported  https://review.openstack.org/36064711:38
openstackgerritVasyl Saienko proposed openstack/ironic: Tempest tests for portgroups  https://review.openstack.org/38247611:38
openstackgerritVasyl Saienko proposed openstack/ironic: Integrate portgroups with ports to support LAG  https://review.openstack.org/33217711:38
vsaienk0lucasagomes, dtantsur: with kvm enabled it takes near 300 sec to boot and clean instance with ubuntu-cloud-image, bonding tests using it. With cirros and kvm disabled booting and cleaning instance took near 300 sec also. We may consider to using ubuntu-cloud-image for complicated tests like UEFI, BONDING, whatever not supported by cirros. What do you think?  http://logs.openstack.org/60/388660/20/check/gate-tempest-dsvm-ironic-multitenant-netwo11:42
dtantsurvsaienk0, what are the memory requirements? will we fit in 384 MiB (or how much do we have?)?11:43
*** amotoki has quit IRC11:43
jrolland can we guarantee we get hosts with nested kvm enabled?11:43
vsaienk0jroll need to check it with infra11:44
vsaienk0dtantsur: I'm using 1280Mb for ubuntu, but I think it should work with 512 I may try to decrease it.11:44
lucasagomesvsaienk0, nice! We probably will need to decrease the size of this image a little11:45
openstackgerritMerged openstack/python-ironicclient: Updated from global requirements  https://review.openstack.org/39536411:45
dtantsurvsaienk0, even 512 is a regression for us, as I guess we'll fit less VMs..11:45
vmud213Good morning mgould :)11:45
vsaienk0dtantsur: we don't run tests concurrently at the moment. Even if we do it in future, I hope we will do it soon, we may allocate different RAM based on VM purpose11:46
openstackgerritMerged openstack/ironic-lib: Updated from global requirements  https://review.openstack.org/39531811:47
dtantsurvsaienk0, it the near future plan to run tests concurrently11:47
*** jkilpatr has quit IRC11:48
vsaienk0dtantsur: I've almost finish this task :)11:48
vsaienk0dtantsur: hope to upload patch on this week11:48
*** jvgrant_ has joined #openstack-ironic11:50
*** jvgrant__ has quit IRC11:53
*** rbrud has joined #openstack-ironic11:56
vdrokmorning jroll11:57
vdrokyeah, ubuntu cloud image works in 512 ram11:57
*** vsaienko has joined #openstack-ironic11:58
openstackgerritPavlo Shchelokovskyy proposed openstack/ironic-specs: Amend dynamic iPXE configuration spec  https://review.openstack.org/39229011:59
*** moshele has quit IRC12:01
openstackgerritMerged openstack/ironic-inspector: Updated from global requirements  https://review.openstack.org/39517512:04
*** moshele has joined #openstack-ironic12:05
*** jkilpatr has joined #openstack-ironic12:05
openstackgerritPavlo Shchelokovskyy proposed openstack/ironic-specs: Amend dynamic iPXE configuration spec  https://review.openstack.org/39229012:11
*** amotoki has joined #openstack-ironic12:13
openstackgerritMerged openstack/ironic-python-agent: Updated from global requirements  https://review.openstack.org/39531912:17
openstackgerritSzymon Borkowski proposed openstack/ironic-python-agent: Add a new Hardware Manager for X710 network card  https://review.openstack.org/39183612:22
*** karthi has joined #openstack-ironic12:23
karthiHi Ironic folks...12:24
*** sborkows has quit IRC12:26
*** amotoki has quit IRC12:28
mgouldmorning jroll karthi12:32
*** zhangyufei has joined #openstack-ironic12:39
*** betherly has quit IRC12:42
openstackgerritPavlo Shchelokovskyy proposed openstack/ironic: [install-guide] describe service clients auth  https://review.openstack.org/38235812:44
zhangyufeihi, could anyone help tell me that does newton’s ironic and neutron support multi-tenant ? Is there any documents about how to configure it?12:45
openstackgerritDmitry Tantsur proposed openstack/ironic: Simplify base interfaces in ironic.drivers.base  https://review.openstack.org/39384812:45
zhangyufeiI try to configure it with https://github.com/openstack/networking-generic-switch, but failed12:45
*** betherly has joined #openstack-ironic12:46
*** amotoki has joined #openstack-ironic12:46
*** lucasagomes is now known as lucas-hungry12:47
*** d0ugal has quit IRC12:51
*** gcb_ has joined #openstack-ironic12:52
*** gcb has quit IRC12:52
*** baoli has joined #openstack-ironic12:54
*** rbudden has joined #openstack-ironic12:55
openstackgerritVasyl Saienko proposed openstack/ironic: Cleanup hung iscsi session  https://review.openstack.org/38809212:55
*** baoli_ has joined #openstack-ironic12:57
*** baoli has quit IRC12:59
*** d0ugal has joined #openstack-ironic12:59
*** rbartal has quit IRC13:01
jlvillalsambetts|afk, Any chance you could run the QA meeting today? I have to go pick my wife up at the airport, so I won't be able to make it.13:02
*** rama_y has joined #openstack-ironic13:03
*** karthi has quit IRC13:03
*** portdirect has quit IRC13:04
*** gcb_ has quit IRC13:04
openstackgerritDmitry Tantsur proposed openstack/ironic: Create noop interfaces for use with hardware types  https://review.openstack.org/39386713:05
dtantsurjroll, ^^^ and its parent, when you have some time please13:05
dtantsurjroll, also g'morning (if this morning counts as good)13:06
*** vmud213 has quit IRC13:12
*** rbartal has joined #openstack-ironic13:14
*** amotoki has quit IRC13:17
*** priteau has quit IRC13:19
*** krtaylor has joined #openstack-ironic13:20
*** shuquan has joined #openstack-ironic13:20
*** priteau has joined #openstack-ironic13:22
openstackgerritJohn L. Villalovos proposed openstack/python-ironicclient: Update to hacking 0.12.0 and use new checks  https://review.openstack.org/39558813:23
*** zhangyufei has quit IRC13:24
*** jistr is now known as jistr|brb13:26
*** bks has quit IRC13:28
*** baoli_ has quit IRC13:29
*** jcoufal has joined #openstack-ironic13:32
*** baoli has joined #openstack-ironic13:32
*** priteau has quit IRC13:33
*** jheroux has joined #openstack-ironic13:34
jrollmorning dtantsur, vdrok, mgould13:35
jrolldtantsur: will add it to my queue13:37
openstackgerritJohn L. Villalovos proposed openstack/ironic-inspector: Update to hacking 0.12.0 and use new checks  https://review.openstack.org/39559313:37
openstackgerritJohn L. Villalovos proposed openstack/ironic-inspector: Add py35 to tox job list  https://review.openstack.org/39559813:44
*** priteau has joined #openstack-ironic13:46
*** jistr|brb is now known as jistr13:46
*** nicodemos has joined #openstack-ironic13:47
*** rbudden has quit IRC13:48
*** xavierr has joined #openstack-ironic13:50
*** lucas-hungry is now known as lucasagomes13:51
openstackgerritJohn L. Villalovos proposed openstack/ironic: Replace usage of 'repr' with '%r' in string  https://review.openstack.org/39560213:52
*** Goneri has joined #openstack-ironic13:57
*** _mbelanger has joined #openstack-ironic13:58
*** livelace has quit IRC13:58
openstackgerritMilan Kováčik proposed openstack/python-ironic-inspector-client: UUID, started_at, finished_at in the status  https://review.openstack.org/39560913:59
milandtantsur, ^ if you've got some time, is tiny14:00
*** portdirect has joined #openstack-ironic14:00
dtantsursure, after some coffee ;)14:00
milanack :)14:00
*** lennyb has quit IRC14:02
openstackgerritYuriy Zveryanskyy proposed openstack/ironic: Add ironic resources CRUD notifications  https://review.openstack.org/35654114:02
*** rloo has joined #openstack-ironic14:03
openstackgerritDmitry Tantsur proposed openstack/ironic-python-agent: Fix several errors in LLDP handling code  https://review.openstack.org/39563214:04
dtantsursambetts|afk, ^^^14:04
dtantsurmaybe jroll too if you know this code ^^^14:05
*** hw_wutianwei has joined #openstack-ironic14:05
* jroll 301 JoshNang14:05
dtantsuroh, I see14:05
* jroll adds that to his list14:05
jrollI somewhat know it14:06
dtantsurcool, thanks! I was really confused by error handling there14:06
*** rama_y has quit IRC14:07
*** hw_wutianwei has quit IRC14:09
openstackgerritRuby Loo proposed openstack/ironic: [install-guide] describe service clients auth  https://review.openstack.org/38235814:10
*** hw_wutianwei has joined #openstack-ironic14:11
* jlvillal worries about code that makes dtantsur very confused. That is a very bad sign.14:13
*** vsaienko has quit IRC14:13
* jlvillal gets confused all the time, but people shouldn't worry :)14:13
* rloo worries that jlvillal is confused about being confused14:13
rloohi and good morning everyone, especially the Americans14:13
jlvillalMorning rloo :)14:14
jrollmorning rloo, jlvillal14:14
mat128jlvillal: the code's readability is improved quite a bit by dtantsur's patch :D14:14
mat128hi rloo14:14
* jroll runs out for a haircut before diving into reviews14:14
jlvillalmat128, :)14:14
rloojroll, do we have it written down, what deprecated drivers mean? It is ok to fix it if the intent is to make it not deprecated, but otherwise... do we fix only major bugs? eg https://review.openstack.org/#/c/395602/14:15
patchbotpatch 395602 - ironic - Replace usage of 'repr' with '%r' in string14:15
rloo^^ that's the ssh driver that is deprecated. do we continue making changes to it?14:15
* jlvillal hadn't noticed that it was a deprecated driver...14:15
jrollrloo: I would normally say don't bother, but it's a follow up comment from a previous patch, so14:15
jlvillalOr forgot14:15
jrollby itself, it's just noise imo14:16
rloowas there a previous patch that touched the ssh driver?14:16
jrollrloo: see commit message :)14:16
jlvillalrloo, The hacking 0.12.0 update patch14:16
* jroll gotta run, bbiab14:16
rloooh, the hacking thing. sigh.14:16
*** cdaniel has joined #openstack-ironic14:17
mat128rloo: I'd say it's acceptable as this helps us enforce the hacking checks14:17
mat128rloo: in contrast to adding a feature (rfe) to the SNMP driver14:17
jlvillalrloo, I'm happy to abandon it, since it isn't needed. I was following up on dtantsur's comment.14:17
*** jrist has quit IRC14:17
rlooi just looked at the hacking patch -- that was a nit to stuff that was already there so i say don't touch it14:17
jlvillalOkay, I'll abandon it. I don't think dtantsur will object.14:18
rloothx jlvillal14:18
*** hw_wutianwei1 has joined #openstack-ironic14:18
jlvillalrloo, Abandoned14:18
*** lennyb has joined #openstack-ironic14:19
rloojlvillal: not sure if that was faster than reviewing it, but wanted to be reminded of our process :)14:19
*** jrist has joined #openstack-ironic14:20
*** hw_wutianwei has quit IRC14:20
*** hw_wutianwei1 is now known as hw_wutianwei14:20
mariojvJayF: quick question. do you think all of https://review.openstack.org/#/c/389344/ should move to the install guide?14:21
patchbotpatch 389344 - ironic - Add notification documentation to administrator's ...14:21
jlvillalrloo, I think you were correct. Thanks.14:21
mariojvi think the details of individual notifications are best left where they're being put in that patch, and then we have a brief overview in the install guide with a link to there14:21
mariojvalso, good morning all14:22
vdrokmorning jlvillal rloo mat128 and mariojv !14:27
xavierrgood-morning --all14:27
rloomorning mariojv, vdrok, xavierr!14:27
jlvillalGood morning vdrok mariojv xavierr mat128 lucasagomes dtantsur rloo and everyone else :)14:28
lucasagomesjlvillal, hi there14:28
vdrokand morning xavierr14:28
xavierrrloo jlvillal lucasagomes vdrok o/14:28
lucasagomeso/ hi there14:29
*** dprince has joined #openstack-ironic14:29
*** jvgrant__ has joined #openstack-ironic14:31
*** jaosorior has quit IRC14:33
*** cdearborn has joined #openstack-ironic14:33
*** jaosorior has joined #openstack-ironic14:34
*** jvgrant_ has quit IRC14:34
*** nicodemos has quit IRC14:34
*** lindycoder has joined #openstack-ironic14:35
dtantsurmorning jlvillal, rloo, xavierr, mat128 and everyone else14:36
jlvillallucasagomes, dtantsur rloo jroll: FYI: I did the 'check experimental' to make sure the pep8 tests will pass when they make the change.14:36
jlvillalI made a note of what I tested in the WhiteBoard. Line 10414:36
*** Nisha_away has joined #openstack-ironic14:36
jlvillalvdrok, yuriyz ^^14:36
*** cdaniel has quit IRC14:37
jlvillalMailing list thread: http://lists.openstack.org/pipermail/openstack-dev/2016-November/106668.html14:37
rloojlvillal: thx. i saw and ignored that email, glad you didn't :)14:38
*** xavierr has quit IRC14:38
jlvillal:)14:38
openstackgerritMilan Kováčik proposed openstack/python-ironic-inspector-client: UUID, started_at, finished_at in the status  https://review.openstack.org/39560914:38
*** _mbelanger has quit IRC14:38
*** causten has joined #openstack-ironic14:38
mariojvis there anything that could possibly in driver_info that we wouldn't want to send over the message bus for notifications, that wouldn't be masked by oslo utils mask_dict_password?14:39
rloojlvillal: so, wrt the whiteboard... i added 'status' to the subteams, to try to capture the latest status (as of the weekly meeting). cuz sometimes there is 'no update' and i don't know/remember what the 'latest' status is. maybe i should rename it to something other than 'status'?14:39
*** godp1301 has joined #openstack-ironic14:40
openstackgerritMerged openstack/ironic: [install-guide] describe service clients auth  https://review.openstack.org/38235814:40
*** godp1301 has quit IRC14:40
*** baoli has quit IRC14:40
*** baoli has joined #openstack-ironic14:41
*** godp1301 has joined #openstack-ironic14:41
rloojlvillal: so you think the status should be below the 'current' stuff?14:41
jlvillalrloo, Okay. So I moved my pep8 comments up above. Hopefully that is correct.14:41
jlvillalI don't know....14:41
*** snozhka has quit IRC14:41
rloojlvillal: i want to make it easy for folks to update wrt their weekly stuff. thought they'd add to the end. (Others eg have a trello link.)14:41
jlvillalToe-may-toe, to-mah-toe14:41
jlvillalFor me.14:42
rloojlvillal: that looks better, thx. i'm going to change 'status' to something more verbose i think... i'm just experimenting with you all...14:42
jlvillalrloo, moved lower14:42
jlvillalThanks14:42
milanmorning all I've missed since my last patch proposal ;) jlvillal, jroll, lucasagomes, mat128, mariojv, rloo,  xavierr14:43
rloohi milan!14:43
milanhi rloo :)14:44
openstackgerritPavlo Shchelokovskyy proposed openstack/ironic: [install-guide] describe service clients auth  https://review.openstack.org/39564814:44
*** roeyc has quit IRC14:46
*** links has quit IRC14:49
*** baoli has quit IRC14:51
*** baoli has joined #openstack-ironic14:53
*** roeyc has joined #openstack-ironic14:53
*** snozhka has joined #openstack-ironic14:54
*** yufei__ has joined #openstack-ironic14:56
*** vsaienko has joined #openstack-ironic15:00
*** moshele has quit IRC15:01
jrolljlvillal: nice, thanks!15:02
*** moshele has joined #openstack-ironic15:02
jrollmorning milan :)15:02
*** vsaienko has quit IRC15:02
milanjroll o/ :)15:03
*** Nisha_away has quit IRC15:08
*** yufei__ has quit IRC15:11
*** godp1301 has quit IRC15:13
JayFmariojv: no. I think that should go in a sort of admin guide. For now where you have it is fine.15:15
vdrokdtantsur: lucasagomes there are a couple of patches in staging drivers that i think are good to go, and maybe we can do a release sometime soonish?15:17
vdrokmorning JayF15:17
JayFo/15:17
lucasagomesvdrok, ++15:18
lucasagomestho I iwll take a look at it later on15:18
vdrokthanks lucasagomes15:18
jrollI'm going to land the ocata priorities doc, any objections? https://review.openstack.org/#/c/393753/15:19
patchbotpatch 393753 - ironic-specs - Add Ocata priorities15:19
jrolldevananda|away and yuriyz are the only cores without a +2 there15:19
*** dtantsur is now known as dtantsur|brb15:19
yuriyzhi jroll will look15:20
lucasagomesvdrok, thank you for keeping an eye at it15:20
*** zackf has quit IRC15:20
vdroknp :)15:20
*** Nisha_away has joined #openstack-ironic15:20
openstackgerritVasyl Saienko proposed openstack/ironic: Update iptables rules and services IPs for multinode  https://review.openstack.org/36864815:23
openstackgerritVasyl Saienko proposed openstack/ironic: Add devstack setup_vxlan_network()  https://review.openstack.org/36864715:23
openstackgerritVasyl Saienko proposed openstack/ironic: Skip some steps for multinode case  https://review.openstack.org/36864615:23
openstackgerritVasyl Saienko proposed openstack/ironic: Update ironic node names for multinode case  https://review.openstack.org/36864515:23
openstackgerritVasyl Saienko proposed openstack/ironic: Update devstack provision net config for multihost  https://review.openstack.org/36864415:23
openstackgerritVasyl Saienko proposed openstack/ironic: Testing multinode stuff  https://review.openstack.org/36817315:23
mariojvJayF: ok, thanks for the advice. i'll propose a small note in the install guide for now, if that sounds good15:23
*** godp1301 has joined #openstack-ironic15:24
mariojvotherwise we can just leave it out - i'm not sure how much config-related stuff goes in the install guide, have not read a lot of it15:24
*** syed__ has joined #openstack-ironic15:24
*** yufei__ has joined #openstack-ironic15:25
*** zackf has joined #openstack-ironic15:27
*** baoli has quit IRC15:28
Nisha_awayjroll, other ironic members, i have a query. I wanted to understand when does a RFE require a spec.15:29
*** nicodemos has joined #openstack-ironic15:29
*** jschwarz has joined #openstack-ironic15:29
jschwarzhey guys15:29
Nisha_awayI have heard that RFE can be approved without the spec also15:29
vdrokNisha_away: I think it's decided on case by case basis15:30
jschwarzI heard you guys were building some kind of a CirrOS image at the gate as part of ironic-python-agent... where can I find the code that does the creation?15:30
vdrokNisha_away: just file an rfe, if it needs a spec, you eill be told about that in the bug15:30
Nisha_awayvdrok, ok. i wanted to understand it for the existing RFE15:30
jrollNisha_away: yes, what vdrok said. anything that is a bit complex, changes API/RPC, affects upgrades, etc usually needs a spec15:31
jrollNisha_away: then ask about that RFE :)15:31
Nisha_awayvdrok, for instance https://bugs.launchpad.net/ironic/+bug/152638215:31
openstackLaunchpad bug 1526382 in Ironic "[RFE] Enhance ilo drivers to do inband inspection along with OOB inspection" [Wishlist,In progress] - Assigned to Aparna (aparnavtce)15:31
jrolljschwarz: hey there15:31
jschwarzjroll, hey :)15:31
Nisha_awaythis actually requires https://review.openstack.org/305864 to be merged15:31
patchbotpatch 305864 - ironic-specs - Boot management for in-band inspection15:32
jrolljschwarz: we don't build cirros, but ironic-python-agent is designed to run in a ramdisk, so we have a couple image builders in tree: https://github.com/openstack/ironic-python-agent/tree/master/imagebuild15:32
*** _mbelanger has joined #openstack-ironic15:32
jrolljschwarz: we also have a diskimage-builder element for it15:32
jschwarzjroll, awesome, thanks a lot :)15:32
*** vsaienko has joined #openstack-ironic15:32
Nisha_awayand then when inspector start supporting virtual media as boot device, then ilo drivers just use that15:32
Nisha_awayto start supporting inband inspection15:33
Nisha_awayvdrok ^^^15:33
rlooeveryone, esp cores jroll, JayF, sambetts|afk, jlvillal (cuz you looked at this), this has two +2, I'm going to +A later today if no one has objections: https://review.openstack.org/#/c/332177/15:33
patchbotpatch 332177 - ironic - Integrate portgroups with ports to support LAG15:33
*** absubram has joined #openstack-ironic15:33
JayFwoo hoo15:33
JayFI'll review it this morning too :D15:34
jrollrloo: yay! I was planning on reviewing it today, but go on without me if you like :)15:34
rloothx JayF!15:34
*** absubram_ has joined #openstack-ironic15:34
*** shuquan has quit IRC15:35
Nisha_awayjroll ^^^15:35
vdrokNisha_away: soo, the rfe bug you linked has needs-spec tag, which is pretty self-describing :)15:35
jrollNisha_away: to be approved without a spec, the RFE would need more details on the changes... since you already have the spec written I think we should just review that15:35
vdrokyep, it needs the spec15:35
jrollvdrok: I added that because it had a spec, to be honest15:35
vdrokah15:35
jrollor had a spec in review15:35
jlvillalThanks rloo15:35
*** godp1301 has quit IRC15:36
Nisha_awayjroll, vdrok yes it already had a spec in review, but since spec review takes longer time i was thinking if really we need a spec for this RFE15:37
jrollNisha_away: then please add details in the RFE and we can evaluate it15:37
rloojroll: wrt nova blueprints, we have one for portgroups and one for attach/detach. For attach/detach, we have to get ironic's spec approved -- before nova's feature freeze?15:37
Nisha_awayjroll sure15:37
rloofor portgroups -- ??15:37
Nisha_awayjroll thanks...15:37
jrollrloo: my goal for attach/detach is before their spec freeze (the 17th)15:37
jrollrloo: they asked for a spec for portgroups which either sambetts|afk or vdrok was working on15:38
*** absubram has quit IRC15:38
*** absubram_ is now known as absubram15:38
rloojroll: the nova portgroups spec exists: https://review.openstack.org/#/c/387534/15:38
patchbotpatch 387534 - nova-specs - Proposal for ironic static portgroups support15:38
vdrokrloo: yup, that one15:38
jrollrloo: ok, right, their spec freeze is nov 1715:38
rloojroll: do we need more ironic cores to look/+1 that before nova will look at it?15:38
Nisha_awayjroll, vdrok i have same ques on https://bugs.launchpad.net/ironic/+bug/160962215:39
openstackLaunchpad bug 1609622 in Ironic "[RFE] Enhance iLO drivers to use snmp to do OOB inspection for local_gb" [Wishlist,In progress] - Assigned to Nisha Agarwal (agarwalnisha1980)15:39
jrollrloo: can't hurt, but we'll need to ask them15:39
rloojroll: ok, thanks for volunteering to ask them :) (or did i hear wrong?)15:39
jrollNisha_away: needs more details on the changes required15:39
jrollrloo: yeah, I'll review it and bug matt today15:39
Nisha_awayok15:39
rloojroll: thx! :)15:39
Nisha_awayjroll, thx :)15:40
Nisha_awayi will add more details to the RFE now15:40
*** vsaienko has quit IRC15:40
*** yufei__ has quit IRC15:42
*** zackf has quit IRC15:42
jlvillalvdrok, Can you peek at: https://review.openstack.org/#/c/332177/35/ironic/api/controllers/v1/node.py  L1092 ?15:45
patchbotpatch 332177 - ironic - Integrate portgroups with ports to support LAG15:45
vdrokjlvillal: looking15:45
*** rpioso has joined #openstack-ironic15:45
jlvillalthanks15:45
vdrokjlvillal: um, I'm not sure i get the question15:47
*** jkilpatr_ has joined #openstack-ironic15:47
vdrokwe return not found in both cases15:47
jlvillalvdrok, Well what does 'kilroy-was-here' return?15:47
jlvillalvdrok, Then why do we explicity raise not found there?15:47
vdrok404, as there is no such node15:47
jlvillalvdrok, More of a question. Not saying wrong.15:48
vdrokin case of portgroups, we have to distinguish a case of portgroups controller if it is accessed with a lower api version15:48
vdrokjlvillal: sure, I get that :)15:48
jrolljlvillal: https://pecan.readthedocs.io/en/latest/routing.html#routing-to-subcontrollers-with-lookup15:48
jlvillalvdrok, Right, but could it just fall through and not return subcontroller.15:48
jlvillalInstead of raise.15:49
jrollah, I get the question now15:49
jlvillalIn reality it doesn't matter if they both return NOT_FOUND.15:49
*** jkilpatr has quit IRC15:49
*** rajinir has joined #openstack-ironic15:49
jlvillalvdrok, It wasn't clear to me that falling through returned NOT_FOUND since the code was explicityly doing it for portgroups15:50
jlvillalvdrok, Thanks!15:50
vdrokjlvillal: I think we have to explicitly tell what to do there15:50
jlvillalvdrok, Then how come we don't for 'killroy-was-here'?15:51
jlvillalIs that a bug in the prior code?15:51
vdrokahh wait15:51
*** zackf has joined #openstack-ironic15:51
vdrokjlvillal: I misread the endpoint you were refering to15:51
* mgould drops back in15:52
mgouldwait, what, kilroy? The WW2 graffiti artist?15:52
jlvillalvdrok, I notice in that pecan link you posted they either return the subcontroller or abort15:52
jlvillalmgould, Yep :)15:52
jrolljlvillal: so falling through doesn't always return NotFound (it does in that case)15:52
jrollhttps://github.com/pecan/pecan/blob/6ccba2564d0ee0a4322b80d6057e2bd3f13eae05/pecan/routing.py#L14215:52
vdrokjlvillal: we're getting the subcontroller from the dict15:53
vdrokin case of kilroy, we don't have one15:53
rloojlvillal: i think maybe? what you're asking is why not change the code at line 1089 to only call subcontroller(), instead of explicitly calling pecan.abort()?15:53
jrollif there's a routing exception, _lookup() is called, if that returns None it raises the original exception15:53
TheJuliao/15:53
*** Sukhdev has joined #openstack-ironic15:54
jlvillalrloo, Yeah.15:54
jlvillalvdrok, rloo, jroll: Okay, code works. So I think we are good :)15:54
vdrokjlvillal: we'll raise 500 if we'll do None()15:54
jlvillalvdrok, So 'killroy-wa-here' gets 500, but 'portgroups' with lower API gets NOT_FOUND?15:54
jlvillalvdrok, If that is how it should be, works for me. Thanks.15:55
openstackgerritVadim Hmyrov proposed openstack/python-ironicclient: List required arguments in '--help' message in Ironic Client.  https://review.openstack.org/38299915:55
vdrokjlvillal: no, ignore that, there is an if :) I'll just double check now with unittest15:56
jlvillalvdrok, :)15:56
openstackgerritMoshe Levi proposed openstack/ironic-python-agent: [WIP] Add a new Hardware Manager for Mellanox NICs  https://review.openstack.org/33481615:57
*** dtantsur|brb is now known as dtantsur15:57
* jlvillal goes back to interspersing work with preparing house for his wife's return15:57
*** jerrygb has joined #openstack-ironic15:57
*** roeyc has quit IRC15:59
*** jkilpatr_ has quit IRC16:01
openstackgerritPavlo Shchelokovskyy proposed openstack/ironic-specs: Promote iPXE to separate boot interface  https://review.openstack.org/38557216:01
*** roeyc has joined #openstack-ironic16:02
*** e0ne has joined #openstack-ironic16:05
*** moshele has quit IRC16:08
*** rcernin has quit IRC16:13
*** jkilpatr_ has joined #openstack-ironic16:14
vdrokjlvillal: replied in the review16:14
jlvillalvdrok, Thanks. Do you think should make a change? Or is it good?16:16
*** absubram has quit IRC16:17
jlvillalvdrok, Just thinking should it be the same error as would get now without patch.  /v1/nodes/<node>/portgroups and /v1/nodes/<node>/killroy-was-here should return same code now and after patch if using old API.16:18
jlvillalUnsure how critical that is.16:18
vdrokjlvillal: I'm inclined to think that whatever we write after node_ident/... should be treated as a subcontroller. and if there is no subcontroller, better to return 404 instead of 40016:19
jrollsambetts|afk: reviewed attach/detach spec, I think we're close16:21
jlvillalvdrok, makes sense to me.16:21
jrollrloo: ^ wdyt about POST /v1/nodes/ident/vifs/ and DELETE /v1/nodes/ident/vifs/interface_id ?16:21
rloojroll: yeah, that seems good. i'll look at your comments in a sec.16:22
jrollthanks, no rush16:22
jrollseems like sam isn't here today16:22
rloojroll: oh. hopefully he is here tomorrow. if that spec isn't approved by monday, i think we shoudl have some 30 min or 1 hour meeting to get it done.16:23
jlvillalkrtaylor, can you run the QA meeting today? I have to fetch my wife from the airport today.16:23
jrollrloo: yeah, I'm also happy to take it over if needed16:23
rloojroll: ok. sambetts|afk didn't say anything about being away for a long time, so for now, I think we're good :) if you take over, you won't be able to +2.16:24
jrollrloo: indeed16:24
vdrokjlvillal: that's complete fun :D16:24
vsaienk0http://paste.openstack.org/show/588587/16:25
*** Guest39033 has quit IRC16:25
* dtantsur is not feeling well, see you tomorrow16:25
vsaienk0API returns field value when accessing to http://127.0.0.1:6385/v1/nodes/node-0/driver_info16:25
vdroknight dtantsur16:25
jrollgnight dtantsur, feel better16:25
*** dtantsur is now known as dtantsur|afk16:25
rloobye dtantsur|afk, hope you're feeling better tomorrow!16:26
vdrokrloo: jroll: how do you think we should handle that stuff jlvillal commented about?16:26
vdrokif taking into account what vsaienk0 wrote above16:26
vdrokpersonally, I did not know about this possibility16:26
jrollvdrok: oh, interesting16:26
jrollhow... how does that work16:27
* jroll hates pecan/wsme16:27
rloothat is cool!16:27
vdrok /o\16:27
mgoulddtantsur|afk: o/16:27
jlvillalget better dtantsur|afk !16:27
jrollidk what to think about that16:28
jlvillallucasagomes, ^^^   Mr WSME :)16:28
* lucasagomes runs16:28
jrollyes, run16:28
rlooso, there's WSME, and there's REST API -> what's right.16:28
jrollvdrok: so what's the question, then?16:28
vdrokjroll: the question is, if we don't find a subcontroller, like in case of /nodes/node-0/fffuuuuuu, should we do 400 or 404?16:29
jrollvdrok: 404, of course :)16:30
jrollwhy would we do 400?16:30
vdrokright now, we consider fffuuuuuu a field, not a subcontroller16:30
jrollit's a resource that was not found16:30
lucasagomesvdrok, is fuuuuuuu suppose to be a name for the node ?16:30
lucasagomesoh16:30
jrolllucasagomes: node-0 is the name16:30
jlvillallucasagomes, No, a value16:30
lucasagomesignore me16:30
vdrokjroll: and because of that, right now /nodes/node-0/fffuuuuuu returns 40016:30
lucasagomesyeah16:30
jrollvdrok: oh lord16:30
lucasagomes404 seems correct then16:30
jlvillaljroll, currently it is returning 40016:30
jlvillalI think that is why the question.16:31
jrollhttp://www.osnews.com/images/comics/wtfm.jpg16:31
vsaienk0access to /nodes/node-0/fffuuuuuu/booo returns 40416:31
* jlvillal repeats what vdrok already said :(16:31
jrolljlvillal: yep, got it16:31
jrollheh16:31
* jlvillal likes the comic16:31
vdrokI'm overdosed with our api today after reviewing this one :D https://review.openstack.org/#/c/390558/7/ironic/api/controllers/v1/node.py16:32
patchbotpatch 390558 - ironic - Add possibility to remove chassis_uuid from a node16:32
* jroll https://media.giphy.com/media/p8Uw3hzdAE2dO/giphy.gif16:32
vsaienk0it is a fun, I think we should always return 40416:32
*** vmud213 has joined #openstack-ironic16:32
jlvillalThat looks like the guy from Scrubs.16:32
jrollyeah, we should. the question to me is, should we make that change now, given it's been a 400 for a few years now16:32
*** e0ne has quit IRC16:32
vsaienk0when accessing to non existed endpoint we get 404, ie v1/fuuuu16:33
jrollright16:33
*** godp1301 has joined #openstack-ironic16:33
vsaienk0jroll, not sure it makes a big sense to keep 400 for not when accessing to /nodes/node-0/fffuuuuuu/booo returns 40416:34
patchbothttps://review.openstack.org/#/c/400/16:34
jrollvsaienk0: yeah, agree16:34
jrollbut will this break people? (probably not, but need to consider it)16:34
openstackgerritPavlo Shchelokovskyy proposed openstack/ironic-python-agent: Remove old lookup/heartbeat from IPA  https://review.openstack.org/38605216:35
rloowell, user is broken anyway if you know what i mean.16:35
jrollfor example I believe nova would microversion this fix16:35
jrollwhich is... sad16:35
vdrokso what I think is - changing 400 to 404 (or vice versa) does not require a microversion, so we can find all the bugs there, think what to do about them, and fix all together16:35
vdrokjroll: ^^16:35
jrollvdrok: that's my thought as well16:35
JayFjroll: vdrok: I really disagree with that assessment16:35
rloovdrok: yup, file a bug about it with that. then for this particular patch, do the right thing :)16:35
JayFchanging the return code, even if it's in the 4xx series, can break applications for people16:36
jlvillalvdrok, I did -1 the patch as I think it should return the same before the patch for 'portgroups' and after the patch (with an older API) for 'portgroups'16:36
JayFand so not hiding that kind of change behind a microversion seems like a bad idea16:36
Nisha_awayjroll, vdrok i updated the RFEs https://bugs.launchpad.net/ironic/+bug/1609622 and https://bugs.launchpad.net/ironic/+bug/152638216:36
openstackLaunchpad bug 1609622 in Ironic "[RFE] Enhance iLO drivers to use snmp to do OOB inspection for local_gb" [Wishlist,In progress] - Assigned to Nisha Agarwal (agarwalnisha1980)16:36
openstackLaunchpad bug 1526382 in Ironic "[RFE] Enhance ilo drivers to do inband inspection along with OOB inspection" [Wishlist,In progress] - Assigned to Aparna (aparnavtce)16:36
jrollJayF: which is why I think we should consider it further16:36
jrollNisha_away: ok16:36
vdrokJayF: hmm, if it is a bug, I think sdague was telling that it can be done without microversion, if we do 400 -> 40416:37
jlvillalvdrok, I think currently before patch it returns 400, and after the patch (with older API) it returns 404.16:37
jrollvdrok: I believe nova's rule is 500->x is ok, not-500->x needs microversino16:37
rlooi think we agree that it should be 404, right? we just don't know/agree yet on how to fix it?16:37
jlvillal+116:37
jrollrloo: agree16:37
rlooso i think we should open a bug about it.16:37
jrollagree.16:37
JayFvdrok: I don't care what's permitted, or what the policies say can be done. I'm saying that as an operator, it's completely unexpected to have return codes change without a version swap16:37
rlooand for this particular case, we know it should be 40416:37
vdrokJayF: ok, thats fair16:38
JayFvdrok: the the 5xx->4xx case, that doesn't really count, as 5xx says "server error". 4xx is a type of client error, and one that an api client should handle16:38
rlooJayF, vdrok: so that discussion could/should take place in the bug/rfe so it can be captured/recorded for ever.16:39
*** strigazi is now known as strigazi_AFK16:39
JayFWhere is that bug? I couldn't find it in scrollback16:41
vdrokok, so I'm not sure what the decision is, change to 400 now, and fix later?16:41
jrollI don't believe there is a bug yet16:41
jlvillalvdrok, That would be my vote.16:41
vdrokJayF: https://review.openstack.org/#/c/332177/35/ironic/api/controllers/v1/node.py@109216:42
patchbotpatch 332177 - ironic - Integrate portgroups with ports to support LAG16:42
*** fragatina has joined #openstack-ironic16:42
mjturekjlvillal: just confirmed with krtaylor that he can run today's QA meeting16:42
krtaylorjlvillal, sure, np16:42
krtayloroh, yeah, what mjturek said  :)16:43
mjturek:)16:43
vsaienk0if we decide to return 400 on /nodes/node-1/portgroups than we should keep 404 for /nodes/node-1/portgroups/blah16:43
patchbothttps://review.openstack.org/#/c/404/ - openstack-attic/identity-api - Initial commit to create repository for Identity S... (MERGED)16:43
rloovdrok, jlvillal: no, I don't think we should change the code to 400. we've just decided it should be 404. so i'd go with what's right, vs consistency in this case.16:44
*** priteau has quit IRC16:44
rloovdrok or anyone going to open a bug about the 400 -> 404?16:44
*** xavierr has joined #openstack-ironic16:45
jlvillalkrtaylor, mjturek: Thanks :)16:45
vdrokrloo: the problem is, I'm not sure it's a bug. If the things following node_uuid are considered node fields, not subcontrollers16:45
jrollvdrok: at least some of us (me) believe that's a bug :)16:46
rloovdrok: sigh. i thought you all had established it was a bug.16:46
vdrokjroll: rloo ok, will do it then16:46
jrollvdrok: thank you :)16:46
*** priteau has joined #openstack-ironic16:46
jlvillalrloo, vdrok jroll JayF: I'll let you decide if go with consistency vs return the correct thing. Since they conflict.16:47
jlvillalRegarding current patch set.16:47
jrolljlvillal: I agree we should do the right thing16:47
vdrokjlvillal: right now, we bump the microversion anyway, so i think we're safe anyway16:47
JayFI don't have strong opinions or knowledge on what is "right" or "wrong" in API design; I just don't want some large amount of return codes to change without a version notifying it :D16:47
vdroknot in terms of consistency tho :)16:48
rlooJayF: i hear you and yes, we can do that.16:48
rlooI'm looking forward to version 1.100 !16:49
JayFlol16:49
vdrokjroll: rloo JayF in your opinion, we should still consider e.g. /nodes/node-0/driver_info a field, or start treating them all as subcontrollers? or just change the return code to 404?16:50
jrollvdrok: subcontrollers16:50
jrolland 40416:50
vdrokyep, that's what makes the most sense to me16:50
rloovdrok: so from the user's perspective, they aren't thinking 'subcontroller'. What makes sense to them?16:51
vdrokrloo: in case of our api, I'd actually expect them to think subcontroller. we already do /nodes/node-0/ports16:52
* jroll has never seen an API where a part of the URL referred to a field on an object16:52
* jroll agrees with vdrok16:52
*** bnemec has quit IRC16:52
rloovdrok, jroll: i don't have much of an opinion here, am good with what you both say :)16:52
*** bnemec has joined #openstack-ironic16:55
*** vmud213 has quit IRC16:58
jrolllanded the priorities doc17:01
jrollrloo: do you want to update the subteams list or shall I?17:01
rloojroll: i can do it. are you going to use trello?17:01
jrollrloo: yeah, I updated trello last week17:01
jrollopen to something else, but for now17:02
rloojroll: ok, just wanted to make sure the trello links existed before updating the subteams. will do it today.17:02
jrollthanks!17:02
*** rbartal has quit IRC17:03
krtaylorreminder: ironic_qa meeting now in #openstack-meeting17:03
openstackgerritMerged openstack/ironic-specs: Add Ocata priorities  https://review.openstack.org/39375317:04
vdrokjroll: https://bugs.launchpad.net/ironic/+bug/1640546, made it an rfe17:05
openstackLaunchpad bug 1640546 in Ironic "Sub-endpoints of ironic resources should be considered subcontrollers, not fields of the resource" [Wishlist,New] - Assigned to Vladyslav Drok (vdrok)17:05
jrollvdrok: thanks17:05
jrollJayF: ^ there's the bug you were looking for17:05
*** rbrud has quit IRC17:07
*** chlong has quit IRC17:08
openstackgerritJohn L. Villalovos proposed openstack/ironic-lib: WIP/DNM: Initial skeleton support for mypy static type checking  https://review.openstack.org/38689217:08
*** roeyc has quit IRC17:09
Nisha_awayjroll, regarding new out-of-band properties which we want to introduce/add via https://bugs.launchpad.net/ironic/+bug/1599425 ....coming back to same ques again on it...why do ilo drivers team need to do investigation for inband discovery of these new attribute17:09
openstackLaunchpad bug 1599425 in Ironic "[RFE]: Add few more capabilities to ilo drivers oob inspection" [Wishlist,Confirmed]17:09
*** ricardoas has joined #openstack-ironic17:10
vdrokrloo: https://review.openstack.org/#/c/390558/7 is rebased on top of the portgroups subcontrollers patch, no need to -2 it :)17:10
patchbotpatch 390558 - ironic - Add possibility to remove chassis_uuid from a node17:10
jrollNisha_away: we don't require the ilo team does that investigation, but we want to standardize these across drivers, so *someone* needs to do that investigation, right?17:10
*** zackf has quit IRC17:11
Nisha_awayjroll, correct17:11
jrollNisha_away: so who do you suggest does that work?17:11
Nisha_awayjroll, :) i am not the one who can answer that17:11
jrollNisha_away: should it be the people who want to make progress on this feature, or should it be the people already full of work making progress on the rest of the project?17:11
jrollNisha_away: now you see my dillema :)17:12
Nisha_awayi can help to investigate but frankly speaking even i dont know how to discover them inband17:12
jrollNisha_away: we need that work to be done, I don't care who does it17:12
jrollneither do I17:12
rloovdrok: ? it shows that it conflicts with 'Integrate portgroups with ports...'17:13
jrollbut there's a whole internet full of resources about how to do things like this17:13
Nisha_awayjroll, but the spec doesnt require to say that they will be implemented inband or oob?17:13
mariojvjlvillal: wrt to https://review.openstack.org/#/c/395588 and the related patch sets - why is assertIs(Not)None bad again? i remember having a discussion about this with someone, but i don't remember the fine points17:13
patchbotpatch 395588 - python-ironicclient - Update to hacking 0.12.0 and use new checks17:13
vdrokrloo: no idea why. if you look in related changes, you'll see portgroups patch in the bottom17:13
Nisha_awayjroll, do we need to say that17:13
Nisha_awaywe can standardize the properties names17:13
jrollNisha_away: well, dtantsur|afk asked for this, not me, so I'm not sure what exactly he wanted17:14
*** roeyc has joined #openstack-ironic17:14
*** causten has quit IRC17:14
*** roeyc has quit IRC17:15
*** causten has joined #openstack-ironic17:15
rloovdrok: i don't want to spend the time trying to figure it out. better for me to actually review that patch  etc.17:15
*** zackf has joined #openstack-ironic17:16
*** causten has quit IRC17:17
*** causten has joined #openstack-ironic17:17
*** chlong has joined #openstack-ironic17:17
rloovdrok: i think the conflict is due to the portgroups patch was updated, so this patch needs to be rebased again.17:19
jlvillalmariojv, running out the door. But AssertIsNone is good, not bad.17:21
*** Romanenko_K has quit IRC17:21
jlvillalmariojv, Supposed to prefer that over AssertEqual(None, blah)17:21
mariojvjlvillal: ah, i misunderstood H203 to mean the opposite. thanks17:21
*** roeyc has joined #openstack-ironic17:22
*** hw_wutianwei has quit IRC17:24
*** baoli has joined #openstack-ironic17:28
mariojvfor releases, is ironic 6.2.0-273 going to become ironic 6.3.0?17:31
*** Sukhdev has quit IRC17:31
mariojvi.e. is that just a tag for release notes hanging on master without a release #?17:31
mariojv"that" being the -27317:31
mariojvi'm curious because i'm writing install guide docs, and i want to reference notifications as being available after a certain release17:31
mariojvthe base merged for it before newton release, but power state notifications (the first ones) didn't merge until 6.2.0-27317:32
JayFmariojv: you don't know if the next one will be 6.3 or 7.017:32
JayFmariojv: it depends on if we merge breaking changes between now and then17:32
mariojvok; maybe it's best to reference when the base was included, then17:33
JayFmariojv: once the portgroup stuff lands, you could maybe bug jroll for a release, but we should probably wait until that whole chain is in17:33
jrollagree17:33
mariojvor i could just say "in the release following the 6.2.0 release"17:33
mariojvnot sure which is better17:33
jrollmariojv: that means 273 commits since last release17:33
*** jpich has quit IRC17:33
jrollit will be 6.3.0 or 7.0.0, depending if we drop deprecated things17:33
mariojvok, thx17:34
jrollmariojv: install guide is versioned, though, so no need to mention which release17:36
JayFoh, good point17:36
mariojvah, nice17:36
* milan gone, night Ironic! :)17:37
*** milan has quit IRC17:37
*** aNuposic has joined #openstack-ironic17:37
*** baoli has quit IRC17:39
xavierrhow to configure ironic to do insecure communication to swift?17:39
*** baoli has joined #openstack-ironic17:39
xavierrto skip certificate validation etc.17:40
xavierris that possible?17:40
JayFI don't believe we have that ability currently17:42
JayFsorta an antifeature but I could see why someone would want it :D17:42
xavierrJayF: haha yeah. we are starting a new cloud env for internal tests17:43
JayFxavierr: certbot + letsencrypt is a good thing :D17:43
xavierrwe cant use certificates to it17:43
*** Nisha_away has quit IRC17:43
xavierrJayF: oh17:43
JayFxavierr: and a lot easier of a fix than adding the ability to not verify certificates to ironic17:43
*** godp1301 has quit IRC17:44
xavierrJayF: great! I will tell guys here to add to they evil plans17:45
xavierrty JayF17:45
* jroll -> lunch17:45
*** ionutbalutoiu has quit IRC17:48
*** betherly has quit IRC17:54
*** derekh has quit IRC17:57
*** jtomasek has quit IRC17:58
*** baoli has quit IRC18:00
*** baoli has joined #openstack-ironic18:00
*** ralonsoh has quit IRC18:02
*** jcoufal_ has joined #openstack-ironic18:02
*** fragatin_ has joined #openstack-ironic18:04
*** rama_y has joined #openstack-ironic18:04
*** jcoufal has quit IRC18:05
*** fragatina has quit IRC18:07
*** lucasagomes is now known as lucas-afk18:07
*** bnemec has quit IRC18:11
JayFjroll: dtantsur|afk: tonyb: https://review.openstack.org/#/c/395648/ should be merged into stable/newton asap please -- apparently our install guide docs are broken w/r/t configuring service user access18:12
patchbotpatch 395648 - ironic (stable/newton) - [install-guide] describe service clients auth18:12
*** mgould is now known as mgould|afk18:12
*** ionutbalutoiu has joined #openstack-ironic18:13
*** bnemec has joined #openstack-ironic18:13
*** rbudden has joined #openstack-ironic18:16
JayFrama_y: aslezil: I wonder if https://review.openstack.org/#/c/369245/ overlaps with any of the work you're doing -- in terms of desired outcome, if not being identical information18:18
patchbotpatch 369245 - ironic-python-agent - Get numa_node info when collecting pci devices info18:18
*** baoli has quit IRC18:21
*** baoli has joined #openstack-ironic18:22
*** portdirect is now known as portdirect_away18:22
*** ohamada has quit IRC18:23
*** bdeschenes has joined #openstack-ironic18:26
*** jaosorior has quit IRC18:26
*** roeyc has quit IRC18:29
rama_yHi JayF, aslezil: this patch is collecting additional info in IPA - that part is similar. But, it is not identical information.18:34
JayFrama_y: I know you all were working on things related to specific scheduling; I didn't know how much of that related to numa18:36
jrollJayF: done18:41
openstackgerritMerged openstack/ironic-python-agent: Update to hacking 0.12.0 and use new checks  https://review.openstack.org/39512318:42
*** baoli has quit IRC18:42
*** baoli has joined #openstack-ironic18:43
rloojroll: i updated the subteams wrt the bigger priorities. was not going to add teams for the smaller things.  wdyt?18:43
*** godp1301 has joined #openstack-ironic18:44
jrollrloo: last cycle we decided to add teams for the smaller things18:44
jrollI'm a bit indifferent18:44
jrollbut might be nice to see progress there18:45
rloojroll: oh. ok, in that case, i'll add. no contacts/leads for those though.18:45
jrollrloo: yeah, I think that's okay18:45
rloojroll: i'm already tired, thinking of the stuff to be done for high priorities :)18:45
jrollrloo: indeed, lots of work to do18:46
*** fragatin_ has quit IRC18:47
rloojroll: some of those smaller things are just 'specs for ...'. forget about that, i say we get the entire feature done!18:47
*** fragatina has joined #openstack-ironic18:48
jrollrloo: so much to do already. those specs will take quite a bit of work already18:48
rloojroll: aim HIGH! :D18:48
*** baoli has quit IRC18:49
jroll:)18:49
jrollI won't be mad if we do it18:49
*** baoli has joined #openstack-ironic18:50
rlooJayF, mat128: I removed the subteam for install guide migration. The bulk of work was done.18:51
rloolucas-afk: I'm going to remove the subteam for 'Enhanced root device hints'; there's just the docs that need reviewing.18:52
JayFrloo: that's fine; thanks!18:52
*** amotoki has joined #openstack-ironic18:55
*** wajdi has joined #openstack-ironic18:55
*** rcernin has joined #openstack-ironic18:59
*** harlowja has quit IRC18:59
*** ChubYann has joined #openstack-ironic18:59
*** amotoki has quit IRC18:59
*** baoli has quit IRC19:00
*** dprince has quit IRC19:00
*** Sukhdev has joined #openstack-ironic19:00
*** baoli has joined #openstack-ironic19:01
*** ijw has joined #openstack-ironic19:02
openstackgerritMerged openstack/ironic: DevStack: Fix standard PXE on Ubuntu Xenial  https://review.openstack.org/39335319:03
openstackgerritMerged openstack/ironic: [install-guide] describe service clients auth  https://review.openstack.org/39564819:05
rlooJayF: were you going to work on this: https://trello.com/c/sYafFLBy/36-specific-fault-support19:06
JayFrloo: yes; I have a very draft spec up and I'm going to drive that to design-completion this cycle19:07
JayFrloo: I added myself to the card19:07
rlooJayF: ok thx. I'll put you down as the lead.19:07
*** godp1301 has quit IRC19:11
*** ijw has quit IRC19:11
rloomat128: were you planning on working/leading the effort on https://trello.com/c/M7PueRS0/35-deploy-steps?19:14
*** sabeen has joined #openstack-ironic19:18
*** amotoki has joined #openstack-ironic19:21
*** ijw has joined #openstack-ironic19:22
*** baoli has quit IRC19:22
*** amotoki has quit IRC19:25
*** baoli_ has joined #openstack-ironic19:28
*** baoli__ has joined #openstack-ironic19:29
*** baoli_ has quit IRC19:32
*** chas_ has quit IRC19:33
zer0c00lSo we have approximately ~5000+ nodes in one ironic cluster. An 'ironic node-set-maintenance <uuid> on' takes ~60 secs. ironic node-create takes 2 mins.19:40
zer0c00lAny idea on how to improve performance of this?19:40
zer0c00lHas any one had same kind of performance issues before?19:40
*** siva has joined #openstack-ironic19:41
JayFzer0c00l: how scaled out is your api cluster, and what deploy driver are you using?19:41
zer0c00lWe have 3 API nodes running ironic api19:42
zer0c00l2 conductuctor19:42
zer0c00l2 conductors19:42
JayFI'd strongly suggest scaling out more, especially if you're using the agent driver.19:42
zer0c00lWe have a custom deploy driver pxe_ipmitool (does some special stuff)19:42
JayFYeah; I'd strongly suggest scaling out further19:42
zer0c00lWe are not using agent driver19:42
JayFWe had more conductors and api servers for that with fewer servers in OnMetal19:42
JayFobviously, I'm assuming you'19:43
*** vsaienko has joined #openstack-ironic19:43
zer0c00lAdding more ironic conductor could help?19:43
JayF*you've checked basic, dependant services, (i.e. you know mysql db server is not ill performant)19:43
JayFzer0c00l: node-create specifically does /not/ touch the conductors at all, I don't think19:43
JayFzer0c00l: so I'm suspecting you need API servers19:43
JayFzer0c00l: but going to doublecheck the code19:43
zer0c00lyeah that's what i thought19:43
zer0c00lOne thing to note is our code is from juno :(, did we have any peformance related changes?19:45
JayFheh19:45
*** ppiela has quit IRC19:45
JayFIronic in Juno and Ironic today are ... probably barely the same piece of software19:45
zer0c00lagree19:46
zer0c00lWe did backport some stuff .19:46
*** clenimar has joined #openstack-ironic19:46
openstackgerritVasyl Saienko proposed openstack/ironic: Update ironic node names for multinode case  https://review.openstack.org/36864519:46
zer0c00lDid we have any specific changes related improve DB query peformance?19:46
JayFzer0c00l: I honestly don't know; Juno is so long ago that was before I worked full time on upstream Ironic.19:46
JayFzer0c00l: you're talking literally years old code that's completely unsupported upstream now19:47
JayFzer0c00l: my only suggestion is to strongly suggest you upgrade to a more recent ironic, and if you can't do that, throw conductors/api servers at the problem19:47
*** ppiela has joined #openstack-ironic19:48
*** ijw has quit IRC19:49
*** aarefiev has joined #openstack-ironic19:50
*** vsaienko has quit IRC19:51
*** godp1301 has joined #openstack-ironic19:51
*** jkilpatr_ has quit IRC19:52
rloozer0c00l: you're still on juno? i thought someone did perf at your company using that version19:52
*** clenimar has quit IRC19:52
*** vsaienko has joined #openstack-ironic19:54
rloozer0c00l: might be this issue: https://bugs.launchpad.net/ironic/+bug/154713919:54
openstackLaunchpad bug 1547139 in Ironic "API does two DB accesses when getting node, port" [Medium,Triaged]19:54
zer0c00lrloo: yes unfortunately19:55
zer0c00lstill in juno19:55
*** rcernin has quit IRC19:55
rloozer0c00l: i remember that bug being an issue, but i don't know if that is what you're encountering in this case -- someone at y! wrote up something about it though19:56
rloozer0c00l: and i don't know if the bug has been addressed19:56
zer0c00lThanks rloo , will investigate19:57
*** aNuposic has quit IRC19:57
zer0c00lrloo: jroll seems to have abandoned that change20:01
zer0c00ldoesn't say why it was abandoned20:01
jrollzer0c00l: was waiting for some other stuff to land that conflicted, took too long20:03
*** jkilpatr has joined #openstack-ironic20:04
*** jkilpatr has quit IRC20:05
*** priteau has quit IRC20:07
zer0c00lokay20:08
*** vsaienko has quit IRC20:10
*** vsaienko has joined #openstack-ironic20:13
*** jkilpatr has joined #openstack-ironic20:13
rloojroll: it strikes me that portgroup uuids in ports will make thing worse wrt ^^. 3 db calls...20:14
*** ijw has joined #openstack-ironic20:15
*** ijw has quit IRC20:17
mrdaMorning Ironic20:18
nicodemosmorning, mrda20:19
*** vsaienko has quit IRC20:20
jrollrloo: probably20:20
*** jkilpatr has quit IRC20:20
*** priteau has joined #openstack-ironic20:20
jrollwell20:21
jrollyeah, yeah it will20:21
jrollwhomp, we need some joins20:22
jroll(this is fairly easy to do, though, if someone wants to pick it up20:22
jroll)20:22
openstackgerritMario Villaplana proposed openstack/ironic: Add notification documentation to administrator's guide  https://review.openstack.org/38934420:23
openstackgerritMario Villaplana proposed openstack/ironic: Add notification documentation to install guide  https://review.openstack.org/39578720:23
*** ijw has joined #openstack-ironic20:25
openstackgerritMerged openstack/ironic-inspector: Update to hacking 0.12.0 and use new checks  https://review.openstack.org/39559320:28
openstackgerritMerged openstack/ironic-inspector: Add py35 to tox job list  https://review.openstack.org/39559820:28
*** ijw has quit IRC20:30
openstackgerritMerged openstack/ironic: Integrate portgroups with ports to support LAG  https://review.openstack.org/33217720:30
*** ijw has joined #openstack-ironic20:31
*** vsaienko has joined #openstack-ironic20:33
*** chas_ has joined #openstack-ironic20:34
*** jkilpatr has joined #openstack-ironic20:34
mat128rloo: yes, my understanding is that we are splitting the deploy steps from the RAID work?20:36
*** ijw has quit IRC20:36
rloomat128: yup. the deploy steps would be the framework for the RAID work.20:37
rloomat128: the hard part is getting the nova bit to work; there was talk about it, nothing concrete. although i think jay pipes said he would propose something. (can't recall, see the etherpad from the design session).20:37
mat128rloo: but in any case we need Ironic to "apply" a RAID config on it's own, right?20:38
*** vsaienko has quit IRC20:38
rloomat128: right. i think that's the easy part, ironic already knows how to apply a config. but how to get the config is the question.20:38
*** chas_ has quit IRC20:39
rlooso applying the raid config during deployment would be eg one deploy step.20:39
mat128rloo: yup, is this last part not a priority for the sprint?20:41
mat128s/sprint/cycle20:41
rloomat128: for ocata, i think jroll will be very happy if we have an approved spec or close-to-approved spec: http://specs.openstack.org/openstack/ironic-specs/priorities/ocata-priorities.html20:42
rloomat128: at bottom, 'spec for deploy steps' :)20:42
mat128my concern is "spec for deploy steps" vs "spec for RAID during deployment"20:42
rloomat128: the deploy steps needs to be done, to able to add raid as one of those steps.20:42
mat128I presume having (not only the spec but the impl too) RAID during deployment will need to be done for nova to accept to send anything raid-specific20:43
mat128rloo: yes, deploy steps are a prerequisite for raid during deploy20:43
rloomat128: yes, for the actual code changes. but we need from nova, some ack wrt the 'right' way for a user to get that config info down via nova to ironic20:43
*** bdeschenes has quit IRC20:44
mat128rloo: I thought the hard part was the user <> nova interaction20:44
rloomat128: the deploy steps in ironic can be done separately from that other nova part though.20:44
rlooyes, that's the hard part.20:44
mat128rloo: not the nova <> ironic, because nova can simply call "set-target-raid-config" stuff20:44
rlooyup20:45
mat128as I said, I was hoping the "ironic configures RAID during deployment" (including the deploy-steps framework + an actual raid config deploy step) would be prioritized20:46
mat128but we have to start with the deploy steps, thats right20:47
*** baoli__ has quit IRC20:47
rloomat128: well, the spec part was prioritized. of the deploy steps. one thing at a time. if the spec + code gets done in ocata that'd be great. the raid part would be easy after that.20:47
*** hamzy has quit IRC20:48
rloomat128: ocata isn't that long. lots of stuff in our list of priorities; what can we cut out?20:48
mat128rloo: yeah I understand20:48
mat128rloo: nah thats fine :)20:48
mat128it's all about priorities :)20:49
*** baoli has joined #openstack-ironic20:49
rloomat128: unfortunately. if i was super-something and could get it all done, it wouldn't be a problem!20:49
mat128we need more super-engineers :)20:50
rloomat128: yes!!!20:50
mat128alright then, to answer your original question: yes I will be leading this work20:50
*** baoli_ has joined #openstack-ironic20:50
rloomat128: thx! I'll put you down for that then.20:51
mat128yay!20:51
mat128thx20:51
*** baoli__ has joined #openstack-ironic20:51
*** baoli has quit IRC20:54
*** baoli_ has quit IRC20:55
*** priteau has quit IRC20:56
*** marios has quit IRC20:57
*** slagle has quit IRC20:57
jrollrloo: mat128: thanks :)21:04
*** baoli__ has quit IRC21:07
*** baoli has joined #openstack-ironic21:08
*** jrcloud has joined #openstack-ironic21:12
*** zackf has quit IRC21:13
*** priteau has joined #openstack-ironic21:14
*** mjturek1 has joined #openstack-ironic21:22
*** mjturek1 has quit IRC21:23
*** mjturek1 has joined #openstack-ironic21:23
*** mjturek has quit IRC21:25
*** Goneri has quit IRC21:26
*** marios has joined #openstack-ironic21:31
*** slagle has joined #openstack-ironic21:31
*** _mbelanger has quit IRC21:31
*** jkilpatr has quit IRC21:34
*** godp1301_ has joined #openstack-ironic21:35
*** godp1301_ has quit IRC21:35
*** godp1301 has quit IRC21:35
*** chas_ has joined #openstack-ironic21:35
*** godp1301 has joined #openstack-ironic21:36
*** mjturek1 has quit IRC21:36
*** priteau has quit IRC21:38
rloojroll: were you planning on reviewing https://review.openstack.org/#/c/395632/? Otherwise, I'll +A. Oh, it can wait til tomorrow, was only submitted today.21:39
patchbotpatch 395632 - ironic-python-agent - Fix several errors in LLDP handling code21:39
*** chas_ has quit IRC21:40
jrollrloo: I'm looking right now21:40
jrollhardest review I've done in a while :)21:41
jrollif you're +2 I'll likely +A21:41
rloojroll: you need to get back into the swing of things. i'll find a hard review for you if you'd like :)21:41
jrollrloo: well, this one is hard in a different way than most :)21:41
rloojroll: true21:41
*** godp1301 has quit IRC21:44
*** hamzy has joined #openstack-ironic21:44
JayFjroll: yeah, I looked back at the history of that code to make sure it wasn't readding the endless-lldp-loop bug back21:46
*** ijw has joined #openstack-ironic21:48
rloojroll, JayF: have you seen this RFE? I think we can approve it? https://bugs.launchpad.net/ironic/+bug/163933821:48
openstackLaunchpad bug 1639338 in Ironic "[RFE] Add support for DBDeadlock handling." [Undecided,In progress] - Assigned to Grzegorz Grasza (xek)21:48
*** harlowja has joined #openstack-ironic21:49
JayFrloo: sounds like a good idea to me21:50
jrollugh, galera21:50
*** amotoki has joined #openstack-ironic21:50
jrollyeah, I'm alright with that21:50
rloook, am going to put your +1s on that and approve it then :)21:50
jrollthanks21:50
*** mjturek has joined #openstack-ironic21:51
*** amotoki has quit IRC21:53
*** aNuposic has joined #openstack-ironic21:54
*** ijw has quit IRC21:56
*** jkilpatr has joined #openstack-ironic21:58
*** rama_y has quit IRC21:59
*** rama_y has joined #openstack-ironic22:00
openstackgerritFélix Bouliane proposed openstack/ironic: WIP- Add virtualpdu to ironic devstack plugin  https://review.openstack.org/38815422:00
openstackgerritFélix Bouliane proposed openstack/ironic: DONOTMERGE-change IRONIC_DEPLOY_DRIVER to pxe_snmp  https://review.openstack.org/38816822:00
*** ijw has joined #openstack-ironic22:02
*** jcoufal_ has quit IRC22:02
*** jheroux has quit IRC22:04
*** ijw has quit IRC22:07
*** baoli has quit IRC22:09
*** ppiela has quit IRC22:09
*** aNuposic has quit IRC22:15
jlvillalJayF, I'm asking over on infra about: https://review.openstack.org/#/c/374147/22:16
patchbotpatch 374147 - ironic-python-agent - Add bash scripts style checking for IPA (SUBMITTED)22:16
jlvillalSeems stuck. Not sure why.22:16
*** baoli has joined #openstack-ironic22:18
jlvillalI'm going to rebase it.22:18
openstackgerritJohn L. Villalovos proposed openstack/ironic-python-agent: Add bash scripts style checking for IPA  https://review.openstack.org/37414722:22
*** baoli has quit IRC22:24
*** baoli has joined #openstack-ironic22:26
*** baoli has quit IRC22:26
*** rbudden has quit IRC22:26
openstackgerritMerged openstack/ironic-python-agent: Fix several errors in LLDP handling code  https://review.openstack.org/39563222:33
*** chas_ has joined #openstack-ironic22:36
*** priteau has joined #openstack-ironic22:37
*** priteau has quit IRC22:40
*** chas_ has quit IRC22:41
*** cdearborn has quit IRC22:42
*** chlong has quit IRC22:47
*** ijw has joined #openstack-ironic22:53
*** e0ne has joined #openstack-ironic22:53
jlvillaljroll, I think I answered your question: https://review.openstack.org/#/c/395632/1/ironic_python_agent/tests/unit/test_netutils.py@26022:55
patchbotpatch 395632 - ironic-python-agent - Fix several errors in LLDP handling code (MERGED)22:55
jlvillalBut yeah the wording is a bit confusing.22:56
jrolljlvillal: ah, you're right, thanks22:57
*** ijw has quit IRC22:57
*** ijw has joined #openstack-ironic22:59
*** causten has quit IRC22:59
openstackgerritJohn L. Villalovos proposed openstack/ironic-python-agent: Clarify test comment to minimize confusion  https://review.openstack.org/39586323:01
jrollnice, +223:01
jlvillaljroll, ^^^  heh :)23:01
jroll:D23:01
jlvillalI couldn't stop myself23:01
jrollyeah, I hear ya23:01
*** lindycoder has quit IRC23:02
*** ijw has quit IRC23:03
* jroll turns into a pumpkin for the night23:04
*** e0ne has quit IRC23:04
jrollsee y'all tomorrow23:04
rloociao jroll23:05
jlvillaljroll, Good night.23:06
* JayF helps jlvillal pump up his commit stats by landing that23:08
jlvillalheh :)23:08
JayFjlvillal: you just forgot the rule: your git commit message first line must only be "TrivialFix"23:08
* JayF ducks23:08
jlvillalJayF, Oh yeah, I saw that email thread from Kolla23:08
*** harlowja_ has joined #openstack-ironic23:08
JayFjlvillal: I was more talking about the ... infestation of barely-useful commits into our repos, but it applies there too :p23:09
jlvillalIf we have that rule, I don't know about it. Thankfully23:09
jlvillalJayF, Oh yeah. Those!23:09
openstackgerritMerged openstack/ironic-python-agent: Clarify test comment to minimize confusion  https://review.openstack.org/39586323:10
*** aNuposic has joined #openstack-ironic23:11
*** harlowja has quit IRC23:12
*** patchbot has quit IRC23:13
*** patchbot has joined #openstack-ironic23:13
*** patchbot has quit IRC23:15
*** patchbot has joined #openstack-ironic23:16
*** aNuposic has quit IRC23:16
*** jerrygb has quit IRC23:16
*** aNuposic has joined #openstack-ironic23:16
*** ijw has joined #openstack-ironic23:20
*** ppiela has joined #openstack-ironic23:21
*** jerrygb has joined #openstack-ironic23:23
*** rama_y has quit IRC23:31
*** Nisha_away has joined #openstack-ironic23:40
*** wajdi has quit IRC23:41
*** Nisha_away has quit IRC23:44
*** cdearborn has joined #openstack-ironic23:48
*** siva has quit IRC23:50
*** sabeen has quit IRC23:50
JayFmariojv: I just picked a nit on 395787 (install guide + notifications), if you wanna fix it real quick I can flip my vote23:53
*** siva has joined #openstack-ironic23:53
*** hw_wutianwei has joined #openstack-ironic23:54
*** chas_ has joined #openstack-ironic23:56

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!