Tuesday, 2016-11-01

*** clsacramento has quit IRC00:12
*** bdeschenes has quit IRC00:13
*** dims_ has quit IRC00:20
*** jrist has quit IRC00:21
*** jrist has joined #openstack-ironic00:22
*** dims has joined #openstack-ironic00:31
*** g3ek has quit IRC00:44
*** g3ek has joined #openstack-ironic00:54
*** syed_ has quit IRC00:55
*** hoangcx has joined #openstack-ironic00:55
*** causten_ has quit IRC00:56
*** phuongnh has joined #openstack-ironic01:06
*** MattMan has quit IRC01:09
*** chlong has quit IRC01:09
*** MattMan has joined #openstack-ironic01:09
*** mtanino has quit IRC01:17
*** rloo has quit IRC01:19
*** bfournie1 has left #openstack-ironic01:44
*** bfournie has joined #openstack-ironic01:49
*** mtanino has joined #openstack-ironic02:05
*** zhangjl has joined #openstack-ironic02:14
*** rama_y has joined #openstack-ironic02:32
openstackgerritTuan Luong-Anh proposed openstack/ironic: Fix setting persistent boot device does not work  https://review.openstack.org/37632202:39
openstackgerritMerged openstack/ironic-specs: Changed the home-page of Ironic-specs in setup.cfg  https://review.openstack.org/39009102:44
*** yuanying has quit IRC02:47
*** yuanying has joined #openstack-ironic02:48
*** tuanluong has joined #openstack-ironic02:51
*** yuanying has quit IRC02:52
*** gcb has joined #openstack-ironic03:01
*** amotoki has quit IRC03:01
*** mtanino has quit IRC03:22
*** vikrant has joined #openstack-ironic03:40
*** vinsh has quit IRC03:43
*** links has joined #openstack-ironic03:52
*** mtanino has joined #openstack-ironic04:12
*** hshiina has joined #openstack-ironic04:16
*** rama_y has quit IRC04:38
*** rama_y has joined #openstack-ironic04:38
*** yuanying has joined #openstack-ironic04:42
*** sabeen has quit IRC04:45
*** rama_y has quit IRC04:55
*** rama_y has joined #openstack-ironic04:56
*** yuanying has quit IRC04:57
*** yuanying has joined #openstack-ironic04:58
*** yuanying has quit IRC05:08
*** yuanying has joined #openstack-ironic05:12
*** vinsh has joined #openstack-ironic05:14
*** g3ek has quit IRC05:15
*** g3ek has joined #openstack-ironic05:18
*** evgenyzhurko has joined #openstack-ironic05:19
*** vinsh has quit IRC05:19
*** yuanying has quit IRC05:28
*** yuanying has joined #openstack-ironic05:32
*** yuanying has quit IRC05:36
*** yuanying has joined #openstack-ironic05:36
*** anush has joined #openstack-ironic05:38
openstackgerritTuan Luong-Anh proposed openstack/ironic: Fix setting persistent boot device does not work  https://review.openstack.org/37632205:40
*** zackf has joined #openstack-ironic05:56
*** mtanino has quit IRC05:56
openstackgerritTuan Luong-Anh proposed openstack/ironic: Fix setting persistent boot device does not work  https://review.openstack.org/37632205:57
*** zackf has quit IRC06:01
*** yuanying has quit IRC06:11
*** mtanino has joined #openstack-ironic06:15
*** yuanying has joined #openstack-ironic06:19
*** mtanino has quit IRC06:19
*** rcernin has joined #openstack-ironic06:29
*** hw_wutianwei has joined #openstack-ironic06:39
*** yuanying has quit IRC06:40
*** yuanying has joined #openstack-ironic06:57
*** fxpester has joined #openstack-ironic06:58
*** rbartal has joined #openstack-ironic07:00
*** yuanying has quit IRC07:02
*** fxpester|2 has joined #openstack-ironic07:13
*** fxpester has quit IRC07:14
*** vinsh has joined #openstack-ironic07:15
*** jtomasek_ has joined #openstack-ironic07:16
*** AlexeyAbashkin has quit IRC07:20
*** vinsh has quit IRC07:20
*** tesseract has joined #openstack-ironic07:21
*** tesseract is now known as Guest1438107:21
*** yuanying has joined #openstack-ironic07:29
*** AlexeyAbashkin has joined #openstack-ironic07:33
*** jtomasek_ has quit IRC07:36
*** zhangyufei has joined #openstack-ironic07:40
*** yuanying has quit IRC07:48
*** yuanying has joined #openstack-ironic07:50
*** zhangyufei has quit IRC07:55
*** yuanying has quit IRC07:57
*** ohamada has joined #openstack-ironic07:59
*** zzzeek has quit IRC08:00
*** yuanying has joined #openstack-ironic08:00
*** ohamada has quit IRC08:00
*** zzzeek has joined #openstack-ironic08:01
*** zhangyufei has joined #openstack-ironic08:02
*** zhangyufei has quit IRC08:05
*** yuanying_ has joined #openstack-ironic08:07
*** yuanying has quit IRC08:08
*** zhangyufei has joined #openstack-ironic08:09
openstackgerritNguyen Hung Phuong proposed openstack/ironic: TrivialFix: Fix typo in config file  https://review.openstack.org/37730708:11
openstackgerritNguyen Hung Phuong proposed openstack/ironic: TrivialFix: Fix typo in config file  https://review.openstack.org/37730708:16
*** ccamacho has quit IRC08:24
openstackgerrityolanda.robla proposed openstack/bifrost: Enable upper requirements on bifrost  https://review.openstack.org/39182808:28
*** ohamada has joined #openstack-ironic08:28
*** jtomasek_ has joined #openstack-ironic08:34
*** lucas-afk is now known as lucasagomes08:40
lucasagomesmorning all08:40
openstackgerrityolanda.robla proposed openstack/bifrost: Enable upper requirements on bifrost  https://review.openstack.org/39182808:45
*** moshele has joined #openstack-ironic08:47
tuanluongmorning ironic08:48
tuanluongHello lucasagomes, please take a look https://review.openstack.org/#/c/391415/08:49
patchbotpatch 391415 - nova - Fix hypervisor-stats show invalid information abou...08:49
pas-hamorning Ironic08:50
tuanluongmorning pas-ha08:50
openstackgerrityolanda.robla proposed openstack/bifrost: Enable upper requirements on bifrost  https://review.openstack.org/39182808:54
*** athomas has joined #openstack-ironic08:59
*** ohamada has quit IRC08:59
openstackgerrityolanda.robla proposed openstack/bifrost: Enable upper requirements on bifrost  https://review.openstack.org/39182809:00
*** mgoddard has joined #openstack-ironic09:14
*** zhangyufei has quit IRC09:14
*** zhangyufei has joined #openstack-ironic09:15
*** jaosorior has joined #openstack-ironic09:15
*** vinsh has joined #openstack-ironic09:17
*** jpich has joined #openstack-ironic09:18
alinebmorning all09:20
*** vinsh has quit IRC09:22
*** dtantsur|afk is now known as dtantsur09:26
dtantsurMorning Ironic09:26
dtantsurhey lucasagomes, how was your trip back?09:26
*** milan has joined #openstack-ironic09:28
*** galyna has joined #openstack-ironic09:28
*** portdirect has quit IRC09:31
lucasagomesdtantsur, it was pretty good, short flight this time :-)09:31
lucasagomesdtantsur, yours ?09:31
*** hshiina has quit IRC09:31
*** portdirect_ has joined #openstack-ironic09:31
dtantsuralso fine, yeah09:31
*** portdirect_ is now known as portdirect09:32
*** derekh has joined #openstack-ironic09:35
*** e0ne has joined #openstack-ironic09:38
tuanluongMorning ironic09:40
*** g3ek has quit IRC09:41
milanmorning Ironic! :)09:43
*** g3ek has joined #openstack-ironic09:43
milanmorning aarefiev dtantsur lucasagomes tuanluong ! :)09:43
lucasagomeso/09:43
*** yuanying_ has quit IRC09:44
*** yuanying has joined #openstack-ironic09:44
tuanluongmorming milan09:44
*** portdirect has quit IRC09:45
dtantsurhey milan, you're early this time ;)09:47
milanas always :D09:47
milanhow's going?09:47
* milan merges conflicts 09:48
*** jaosorior has quit IRC09:48
*** jaosorior has joined #openstack-ironic09:48
openstackgerritLucas Alvares Gomes proposed openstack/ironic: Docs: Document using operators with root device hints  https://review.openstack.org/38671409:57
*** portdirect has joined #openstack-ironic09:58
dtantsurmilan, still somewhat sick from the conference, otherwise ok :)09:59
*** dootniz is now known as kragniz09:59
*** tuanluong has quit IRC10:00
milanI guess plenty laid down with the manflu, sucks... have had mine a week before the summit10:02
milandtantsur, get better soon! :)10:03
lucasagomesdtantsur, that sucks yeah :-/10:04
*** hoangcx has quit IRC10:05
*** mgould|afk is now known as mgould10:05
mgouldmorning lucasagomes pas-ha alineb milan aarefiev dtantsur10:05
mgoulddtantsur: get well soon!10:05
dtantsurhey mgould!10:05
milanmorning mgould! :)10:06
pas-hamorning mgould :)10:06
dtantsurlucasagomes, fyi this does not seem to work: https://github.com/openstack/python-ironicclient/commit/eeb327b590b489a7f6b0e2176b288f7201de6aa9 :(10:06
mgouldmilan: clearly you're the one who infected everyone else :-)10:06
milanmgould, Oops O:-)10:07
* mgould was also feeling subpar the week before summit, so maybe it was me :-/10:10
*** sambetts|afk is now known as sambetts10:12
sambettsMorning al10:13
sambettsall10:13
dtantsurmorning sambetts10:13
mgouldmorning sambetts10:17
*** zhangyufei has quit IRC10:20
milanmorning sambetts! :)10:21
lucasagomesdtantsur, checking10:25
dtantsurlucasagomes, see https://bugzilla.redhat.com/show_bug.cgi?id=1346089 for details. in ironicclient we don't use the code you've patched...10:26
openstackbugzilla.redhat.com bug 1346089 in python-keystoneauth1 "Secrets are not filtered when logging requests in the session code" [Low,Assigned] - Assigned to derekh10:26
lucasagomesdtantsur, oh keystone logs it10:28
dtantsuryep10:28
lucasagomes*sigh*10:28
mgouldfiltering out secrets at the logging stage sounds... fragile... but I guess it's too late to change that architecture now10:30
*** phuongnh has quit IRC10:31
dtantsurhaving two independent places we do HTTP is also not so robust..10:31
dtantsurI guess we have to get rid of our implementation eventually...10:31
*** zhangjl has quit IRC10:34
*** hshiina has joined #openstack-ironic10:35
dtantsurlucasagomes, re https://review.openstack.org/#/c/387559: I'm worried to allow infiniband in e.g. network separation code.. does it work there?10:39
patchbotpatch 387559 - ironic - Account for Infiniband GID when validating an address10:39
dtantsur(maybe it does, dunno)10:40
lucasagomesdtantsur, I assume yes, but I haven't tested it10:40
*** mmedvede has quit IRC10:41
dtantsurlucasagomes, what if we first only fix the lookup? e.g. I'm not sure it's a great idea to blow up on malformed MACs at all10:41
mgoulddtantsur: what assumptions do we make about the mechanism being used to achieve separation?10:41
dtantsurmgould, it's called Neutron and nobody knows how it works :)10:41
mgouldlooks like Infiniband supports something very similar to VLANs: https://community.mellanox.com/docs/DOC-146310:41
mgouldaaaaah10:42
lucasagomesdtantsur, like, ignore the malformed ones ?10:42
dtantsurlucasagomes, I suggest just logging and ignoring invalid MACs, yes10:42
lucasagomesthat's not a bad idea10:42
dtantsurlucasagomes, we don't filter input to lookup on IPA side too much..10:42
lucasagomesdtantsur, lemme add a patch for it10:42
lucasagomesdtantsur, yeah, we shouldn't actually fail like that on lookup cause it totally breaks the deployment in the middle10:42
dtantsurlucasagomes, cool! and then we can discuss the bigger infiniband patch, with involving people understanding neutron better10:42
lucasagomesand don't shut down the node or anything10:43
lucasagomesdtantsur, right10:43
mgouldhmmm, looks like Neutron only supports Infiniband via a third-party plugin: https://wiki.openstack.org/wiki/Mellanox-Neutron-Liberty-InfiniBand10:45
sambettsmgould: that means that the neutron data structures must support it10:48
sambettsmgould: just it'll only ever get bound if you have enabled that driver and have one of their devices10:48
mgouldah, OK10:48
dtantsurok, so lucasagomes' patch still makes sense, but it's at the border of a feature, so we need a lighter fix first10:50
sambettsdoes our DB structure support infiniband right now?10:52
sambettsI'm sure there was a whole bunch of other infinband patches for inspector and ironic10:52
dtantsurdunno. the first thing I care about is the deployment to not fail when an infiniband card is merely present :)10:53
sambettsYeah we already merged this https://review.openstack.org/#/c/264263/10:53
patchbotpatch 264263 - ironic - Adding InfiniBand Support (MERGED)10:53
lucasagomesdtantsur, yeah working on it10:54
lucasagomesmakes me sad that the whole validation goes in a decorator, trying to think of another way10:55
dtantsurlucasagomes, replace the type with list of strings and do validation later?10:55
*** yuanying has quit IRC10:56
lucasagomesdtantsur, that's the plan10:56
*** dprince has joined #openstack-ironic10:56
*** chlong has joined #openstack-ironic10:57
*** jkilpatr has quit IRC10:57
sambettslucasagomes, dtantsur: Going back to the infiniband spec, we decided we weren't going to store the GID in ironic, https://specs.openstack.org/openstack/ironic-specs/specs/not-implemented/add-infiniband-support.html#proposed-change11:00
dtantsurcool, yeah11:01
dtantsurI think the plan is to eventually provide translation to MACs, but it's vendor specific and is not implemented yet11:01
sambetts++11:01
lucasagomessambetts, right on, will take a look11:03
*** evgenyzhurko has quit IRC11:11
openstackgerritDmitry Tantsur proposed openstack/ironic-specs: Revise driver composition reform defaults  https://review.openstack.org/35726211:13
mat128morning Ironic11:16
mgouldmorning mat12811:16
mgoulddtantsur: does it make sense to translate GIDs to MACs? GIDs are longer, so we can't do it losslessly unless I'm missing something11:17
dtantsurmgould, well, some vendors have procedures for that.. dunno how much sense it makes11:18
sambettsmgould: its part of the infiniband spec for doing PXE over infiniband as I understand11:18
sambettsethernet over inifiband11:18
mgouldah, OK11:18
mgouldtunnel all the things11:18
sambetts;)11:18
mgouldbrb meeting11:19
*** MattMan has quit IRC11:19
*** vinsh has joined #openstack-ironic11:19
*** MattMan has joined #openstack-ironic11:21
moshelelucasagomes, sambetts, dtantsur: yes so infinibnad support I have the ironic-inspctor patch https://review.openstack.org/#/c/264257/ I need to address the comments and the IPA patch https://review.openstack.org/#/c/334816/ which I need to remove the vendor code to different Hardware class11:22
patchbotpatch 264257 - ironic-inspector - Adding InfiniBand Support11:22
patchbotpatch 334816 - ironic-python-agent - InfiniBand Support for IPA11:22
*** vinsh has quit IRC11:23
jrollmorning y'all11:26
sambettso/ jroll11:26
dtantsurmorning jroll11:26
dtantsurthe snmp driver is still deprecated, right? so we should reject both https://bugs.launchpad.net/ironic/+bug/1635644 and https://review.openstack.org/#/c/389736/11:30
openstackLaunchpad bug 1635644 in Ironic "[RFE] SNMP driver auto-discovery" [Undecided,In progress] - Assigned to Philippe Godin (godp1301)11:30
patchbotpatch 389736 - ironic - Adds snmp driver auto discovery for APC and baytech11:30
dtantsurjroll, ^^^11:30
*** ohamada has joined #openstack-ironic11:32
*** mmedvede has joined #openstack-ironic11:34
*** jkilpatr has joined #openstack-ironic11:34
openstackgerritLucas Alvares Gomes proposed openstack/ironic: API: lookup() ignore malformed MAC addresses  https://review.openstack.org/39211411:43
lucasagomesdtantsur, ^11:43
lucasagomesjroll, hi there11:43
dtantsurlucasagomes, thanks, will look after lunch11:43
lucasagomesyeah no worries11:44
*** evgenyzhurko has joined #openstack-ironic11:46
*** amotoki has joined #openstack-ironic11:47
*** rbrud has joined #openstack-ironic11:47
jrolldtantsur: let's check that bug with mat128, I think they might be depending on that to do the virtualpdu thing11:56
* mat128 reads11:56
jrollohai :D11:56
mat128dtantsur, jroll: thats correct, the guys made improvements to the snmp drivers but they are on hold pending the VirtualPDU work landing11:57
mat128which is also in progress11:57
mat128s/drivers/driver11:57
mat128hey :)11:57
mat128iirc xhku proposed the initial changes for virtualPDU11:57
mat128yup: https://review.openstack.org/#/c/388154/11:58
patchbotpatch 388154 - ironic - WIP- Add virtualpdu to ironic devstack plugin11:58
jrollok cool, so that's required to do CI for that driver11:58
jrollchicken/egg, I think let's do the work11:58
mat128jroll: thats correct11:58
mat128well11:58
mat128the auto-discovery and the baytech support are real RFEs11:58
mat128not required for virtualPDU to work11:59
jrollahhh11:59
mat128but adding features requires the driver to be non-deprecated11:59
jrollright11:59
mat128which is additional pushing for virtualPDU to be prioritized11:59
mat128if you know what I mean11:59
jrollmat128: yeah, so given we plan to provide CI for snmp driver, we should just put the rfe on hold until that point in time12:00
mat128jroll: correct12:00
mat128I agree with this :)12:00
jrollcool :)12:00
*** e0ne has quit IRC12:00
* jroll comments in the bug12:01
openstackgerritSam Betts proposed openstack/ironic: Allow to use FLAT network setup  https://review.openstack.org/33438212:10
*** portdirect has quit IRC12:15
*** lucasagomes is now known as lucas-hungry12:16
*** portdirect has joined #openstack-ironic12:18
*** vinsh has joined #openstack-ironic12:20
*** jkilpatr_ has joined #openstack-ironic12:23
*** jkilpatr has quit IRC12:24
*** vinsh has quit IRC12:25
*** rbartal has left #openstack-ironic12:29
dtantsurmat128, glad to hear it! I guess it has to be done by end of ocata to avoid the driver from getting kicked out..12:30
dtantsurspeaking of which, jroll, do we have a decided plan on when and how we can start removing drivers?12:30
*** rbartal has joined #openstack-ironic12:30
jrolldtantsur: 3 months from when the deprecation landed, I guess?12:31
jrollthough, that will be close to ocata FF, maybe we just remove in pike12:31
dtantsurjroll, well, we can do it before FF.. I'm not sure I feel like maintaining unsupported drivers for one more cycle12:32
dtantsurwe can make exceptions for drivers like SNMP with a CI being worked on, of course12:32
jrollsure, I'm fine with that12:32
dtantsuralso, we should finally switch to pxe_ipmitool now... lucas-hungry has a patch for it iirc, not sure about the state12:34
jrollyeah, +112:34
*** fxpester|2 has quit IRC12:36
*** fxpester has joined #openstack-ironic12:36
*** jcoufal has joined #openstack-ironic12:36
jrollsorry, still not feeling well today, brain is foggy :/12:37
*** jerrygb_ has quit IRC12:38
*** vikrant has quit IRC12:40
*** moshele has quit IRC12:46
openstackgerritYuriy Zveryanskyy proposed openstack/ironic: TEST: do not review  https://review.openstack.org/39213812:49
*** moshele has joined #openstack-ironic12:50
*** jerrygb has joined #openstack-ironic12:52
*** hw_wutianwei has quit IRC12:52
*** jheroux has joined #openstack-ironic12:53
* jroll steps away for a while12:54
*** amotoki has quit IRC12:54
*** derekh has quit IRC12:56
*** amotoki has joined #openstack-ironic12:57
*** vishwanathj has quit IRC13:03
*** links has quit IRC13:14
*** lucas-hungry is now known as lucasagomes13:18
*** vinsh has joined #openstack-ironic13:21
*** fxpester has quit IRC13:21
*** e0ne has joined #openstack-ironic13:23
*** vinsh has quit IRC13:26
*** baoli has joined #openstack-ironic13:30
*** wajdi has joined #openstack-ironic13:31
*** fxpester has joined #openstack-ironic13:31
lucasagomesyuriyz, dtantsur re: changing the list_of_mac_addresses type. I don't think it will be consistent with other types to change the validation there. All other types will raise an exception in case a value fails to validate13:32
*** fragatina has joined #openstack-ironic13:32
*** yuanying has joined #openstack-ironic13:32
*** fragatina has quit IRC13:32
*** fragatina has joined #openstack-ironic13:33
lucasagomesI would rather delete that list_of_macs... type if it's not used anymore than making it inconsistent with the rest, because I think it will be misleading if we decide to use it in another places13:33
*** amotoki has quit IRC13:35
*** absubram has joined #openstack-ironic13:36
dtantsurlucasagomes, I'm fine with deleting it too13:36
lucasagomesdtantsur, right, delete in the same patch or another one to facilitate the backport ?13:36
* lucasagomes is good with either13:36
dtantsurlucasagomes, in the same patch IMO, as it's the only place where it's used13:37
lucasagomesack13:38
rbartalHI all, I have HP 380/360 Gen9 computer and  while downloading inspector.ipxe it get connection reset. The problem is it ignore the kernel --timeout option we added in the ipxe scrip13:39
dtantsurrbartal, wait, does it reset on downloading the kernel or inspector.ipxe? in the latter case there is no --timeout13:39
rbartaldtantsur, it reset on inspector.ipxe13:42
dtantsurok, so timeout is irrelevant here..13:42
dtantsurrbartal, two questions then: 1. what's the size of your inspector.ipxe, 2. what does tcpdump show for port 8088 (or whichever we use)?13:43
*** hshiina has quit IRC13:44
openstackgerritLucas Alvares Gomes proposed openstack/ironic: API: lookup() ignore malformed MAC addresses  https://review.openstack.org/39211413:44
rbartaldtantsur, OK, so  --timeout will work for agent and kernel download. I will ask for the file side and some tcpdump files13:45
mariojvmorning ironic o/13:45
dtantsurmorning mariojv13:46
*** rloo has joined #openstack-ironic13:46
*** fragatina has quit IRC13:48
*** causten has joined #openstack-ironic13:50
*** g3ek has quit IRC13:51
*** amotoki has joined #openstack-ironic13:51
*** fxpester|2 has joined #openstack-ironic13:53
*** cdearborn has joined #openstack-ironic13:55
*** fxpester has quit IRC13:56
*** g3ek has joined #openstack-ironic13:56
*** derekh has joined #openstack-ironic13:57
*** jerrygb_ has joined #openstack-ironic14:00
*** yuanying has quit IRC14:01
*** amotoki has quit IRC14:02
*** jerrygb has quit IRC14:02
*** hamzy has quit IRC14:09
*** mtanino has joined #openstack-ironic14:13
*** vinsh has joined #openstack-ironic14:19
*** MattMan has quit IRC14:20
*** rpioso has joined #openstack-ironic14:26
*** yufei has joined #openstack-ironic14:29
*** awiddersheim has quit IRC14:30
*** e0ne has quit IRC14:30
*** jkilpatr_ has quit IRC14:31
*** jerrygb has joined #openstack-ironic14:31
NobodyCamGood Morning Ironic'ers :)14:31
*** awiddersheim has joined #openstack-ironic14:33
dtantsurmorning NobodyCam14:33
*** jerrygb_ has quit IRC14:33
NobodyCamhey hey dtantsur :) did you have a good Halloween?14:34
dtantsurwell, this time we didn't have energy or mood for Halloween..14:34
dtantsurand you?14:34
NobodyCamWe are in the RV because of some house remodeling going on and as a result no kids at all :p ended up having pizza with some friends :)14:35
dtantsur:)14:36
NobodyCam:)14:37
lucasagomesNobodyCam, morning14:38
NobodyCamGood Morning lucasagomes :)14:39
NobodyCamHow are you today :)14:39
*** jkilpatr has joined #openstack-ironic14:40
*** e0ne has joined #openstack-ironic14:42
lucasagomesgood good, loads of emails and non-fun things to sort out today tho14:43
NobodyCam:(14:44
*** MattMan has joined #openstack-ironic14:46
lucasagomesNobodyCam, it's all good :-)14:47
* dtantsur still has to do expense reports when he gets to the office...14:48
*** vishwanathj has joined #openstack-ironic14:51
*** ipukha has quit IRC14:53
NobodyCamhehehe :)14:54
*** yufei__ has joined #openstack-ironic14:57
dtantsurjroll, oslo libs seem to add reno support (looking at futurist patch now). should we do the same with ironic-lib now?14:58
*** agordeev has quit IRC14:59
*** amotoki has joined #openstack-ironic14:59
*** yufei has quit IRC14:59
*** yufei__ is now known as yufei14:59
*** jerrygb_ has joined #openstack-ironic15:00
lucasagomesdtantsur, did the "it's not a user facing library" motto changed ?15:02
dtantsurapparently?15:02
*** jerrygb has quit IRC15:03
lucasagomesso it did change to ... ?15:03
* lucasagomes looks15:03
dtantsurdunno, I was not in their sessions too much15:05
*** sabeen has joined #openstack-ironic15:09
*** syed_ has joined #openstack-ironic15:14
*** vdefeo has joined #openstack-ironic15:16
mgouldmorning NobodyCam15:18
*** fxpester|2 has quit IRC15:18
NobodyCamMorning mgould. :)15:18
*** wajdi has quit IRC15:22
*** athomas has quit IRC15:22
*** hj-hpe has joined #openstack-ironic15:24
*** hj-hpe has quit IRC15:24
*** hj-hpe has joined #openstack-ironic15:25
*** milan has quit IRC15:28
*** wajdi has joined #openstack-ironic15:28
*** athomas has joined #openstack-ironic15:29
*** absubram has quit IRC15:31
*** vdefeo has quit IRC15:33
*** hpe-hj has joined #openstack-ironic15:35
*** absubram has joined #openstack-ironic15:36
*** hj-hpe has quit IRC15:37
*** pcaruana has joined #openstack-ironic15:44
*** Guest14381 has quit IRC15:51
*** rbrud has quit IRC15:59
openstackgerritGalyna Zholtkevych proposed openstack/ironic: ETAG supporting to enhance API evolution  https://review.openstack.org/39221316:00
*** rama_y has quit IRC16:03
*** rama_y has joined #openstack-ironic16:03
*** hamzy has joined #openstack-ironic16:04
*** rcernin has quit IRC16:06
*** milan has joined #openstack-ironic16:07
*** pcaruana has quit IRC16:07
*** mat128_ has quit IRC16:08
*** tdurakov has quit IRC16:09
*** mat128_ has joined #openstack-ironic16:10
*** tdurakov has joined #openstack-ironic16:11
mgouldhuh, that was quick16:11
mgouldnice work, gzholtkevych16:12
mgouldah, still WIP :-)16:12
galynaYeap, this is just a first patch :) nothing special yet16:16
*** ipukha has joined #openstack-ironic16:16
*** jaosorior has quit IRC16:17
*** yufei has quit IRC16:21
*** rpioso has quit IRC16:23
*** zackf has joined #openstack-ironic16:25
*** sabeen has quit IRC16:26
jrolldtantsur: dunno, I don't think it's useful until we want non-ironic projects to use it16:26
dtantsurmakes sense16:27
rloodtantsur: I +2'd https://review.openstack.org/#/c/357262. Can you +2 too, even though you revised it?16:31
patchbotpatch 357262 - ironic-specs - Revise driver composition reform defaults16:31
JayFI'm reviewing that right now as well16:32
dtantsurrloo, me? well, I can +1 it, I've rewritten it too much :)16:32
rlooJayF: ok, will wait for your approval :)16:32
rloodtantsur: oh, didn't realize you did two revisions on it.16:33
dtantsuryep16:33
JayFrloo: land it with my +2?16:33
rlooJayF: yes please!16:33
rlooJayF: or you can +2, fix that nit i found, then +A16:34
JayFpatch 357262 cleared for landing, runway 33R16:34
patchbothttps://review.openstack.org/#/c/357262/ - ironic-specs - Revise driver composition reform defaults16:34
dtantsur\o/16:34
JayFrloo: I mean, it's one character? Meh about us spending time to fix it :D16:34
rlooJayF: exactly. i wouldn't want a followup to that, but edit'ing is easy.16:34
JayFrloo: I'm sure someone will come around and trivialfix it :P16:34
rlooJayF: NOOOOOO16:35
*** zackf has quit IRC16:35
dtantsurLOL16:35
*** jrcloud has joined #openstack-ironic16:35
openstackgerritMerged openstack/ironic-specs: Revise driver composition reform defaults  https://review.openstack.org/35726216:36
mgouldyay!16:36
*** jrcloud is now known as zackf16:37
*** rpioso has joined #openstack-ironic16:38
rloodtantsur, JayF: question for you. why would the home page be ironic-specs? I'd think it would be developer/ironic. what does 'home page' mean? https://review.openstack.org/#/c/390091/16:39
patchbotpatch 390091 - ironic-specs - Changed the home-page of Ironic-specs in setup.cfg (MERGED)16:39
JayFrloo: it's what would be listed in pypi if we published a package there. It's pointed to our devdocs for Ironic.16:39
*** aNuposic has joined #openstack-ironic16:39
JayFrloo: IMO it doesn't matter since we don't publish that to pypi, and the link to the generated specs is 10x more accurate than just a pointer to openstack.org16:39
rlooJayF: so if i were looking for info about a py package, i'd want the home page to be where i could find out info about that package, eg how to file bugs, who to contact, ...??16:40
rlooJayF: ironic-specs just has our specs...16:40
JayFuh16:40
JayFour pypi page for ironic looks screwed up16:41
mgouldrloo: how to use the package, most importantly16:41
JayFhttps://pypi.python.org/pypi/ironic/0.016:41
* dtantsur does not care much about home page link for specs16:41
*** jerrygb has joined #openstack-ironic16:41
dtantsurJayF, yeah, it's been like that for loooong time16:41
sambettsJayF: openstack services don't publish to pypi16:41
JayFHas anyone mentioned it to jroll or the releases team?16:41
dtantsur... except for ironic-inspector and a few other ;)16:41
JayFsambetts: seriously/ Why not/16:41
sambettsJayF: no idea16:42
* rloo sorry she asked16:42
rlooJayF: maybe open a bug then about the ironic one16:42
JayFwe even publish IPA to pypi16:42
sambettsi thought it was weird too, but none of neutron/nova/glance etc publish on there for some reason16:42
JayFrloo: https://pypi.python.org/pypi/ironic-inspector/4.2.0 the "Home Page:" there under the files is what that would be used for16:42
*** jerrygb_ has quit IRC16:43
rlooJayF: that looks nice, good job dtantsur :)16:43
*** jerrygb_ has joined #openstack-ironic16:44
*** moshele has quit IRC16:45
*** jerrygb has quit IRC16:46
JayFIt's completely acceptable to land the small typo fixes with only one +2, correct?16:46
dtantsurIMO yes16:47
rlooJayF: yes. we have that documented somewhere16:47
rlooJayF: https://wiki.openstack.org/wiki/Ironic/CoreTeam#Other_notes16:48
*** sabeen has joined #openstack-ironic16:48
JayFThat's what I thought, but haven't done it yet since being core16:48
JayFI also commented that we prefer more substantive changes to typo-only fixes16:49
rlooJayF: i just ignore those patches unless i recognize that person as having contributed something more 'useful'16:51
jkilpatrdtantsur, thoughts on exposing introspection delay as a command line flag and adding a retires flag? That would satisfy the reliability RFE I think. I'm willing to implement.16:52
JayFIf it conflicts with nothing, it's hard for me to not land it because it is /better/... if I have it open in my review anyway16:52
dtantsurjkilpatr, which command are you referring to right now, normal or bulk? :)16:52
jkilpatrdtantsur, normal, talked to the tripleo guys and they don't seem interested in doing the business logic on their end.16:54
*** e0ne has quit IRC16:54
dtantsurjkilpatr, "delay" is present in ironic-inspector and makes no sense for our single-node introspection command16:54
jkilpatrone the other hand, delay makes no sense as a single command option.16:54
dtantsurjkilpatr, maybe the biggest win is to make the delay bigger for tripleo and cover all drivers?16:54
dtantsurjkilpatr, i.e. expose this options in puppet (if they're not already) https://github.com/openstack/ironic-inspector/blob/master/example.conf#L58-L63 and change them in instack-undercloud?16:55
jkilpatrdtantsur, that would do it, even a few seconds would be fine. You just need to prevent 50+ nodes all deciding to pxe at exactly the same second.16:55
dtantsuractually, I think https://github.com/openstack/ironic-inspector/blob/master/example.conf#L63 should be changed to .* as we're moving away from pxe_ssh drivers16:55
dtantsurjkilpatr, maybe you can try doing ^^^ locally, and propose it upstream if it fixes your problem?16:56
openstackgerritPrudhvi Rao Shedimbi proposed openstack/ironic: Making IronicException to subclass from ironic_lib  https://review.openstack.org/38770316:57
jkilpatrdtantsur, that's the plan. Just wanted to know I was hacking at the right level, there are a lot of different levels to potentially drop this in.16:57
*** e0ne has joined #openstack-ironic16:59
*** mgoddard_ has joined #openstack-ironic16:59
dtantsurjkilpatr, if changing the default value for this option works for you, I'm inclined to just do it16:59
jkilpatrdtantsur, while a default delay will help (probably a good bit) it's not going to solve everything, previous iterations of my own introspection script demonstrated that, which is why I still want to add a retry option.17:00
dtantsurjkilpatr, I'm not sure we're going to implement retries in ironic-inspector itself... needs broader discussion, probably mailing list17:01
*** jpich has quit IRC17:01
*** mgoddard has quit IRC17:02
jkilpatrdtantsur, I figured as much. I guess I'll start collecting some hard data to present my case. What scale do you guys normally test at? It works perfectly at ~10 nodes and ok up to about ~20 once you get much beyond that you have to start writing scripts to organize it and do retires.17:03
*** e0ne has quit IRC17:03
dtantsurjkilpatr, I guess answer "1-2 nodes" will disappoint you then :)17:04
jkilpatrdtantsur, I have 24 for personal testing, serious tests get 200+, right now getting a couple hundred node deployment takes a lot of fighting with ironic/tripleo which isn't any good to actually get customers to use, they frequently have or want deployments that big.17:07
dtantsurI wish our team had something like that... right now we (at least the RH ironic team) can only rely on your feedback17:08
JayFjkilpatr: I'm curious what actually is the bottleneck17:08
JayFjkilpatr: just getting them pxe booted? or actually getting the inspection completed?17:08
*** e0ne has joined #openstack-ironic17:09
jkilpatrdtantsur, the lab we are using takes schedule requests from anyone, if your team wants to set some time aside and schedule a slot they could have 200 nodes for testing for a week or so.17:09
jkilpatrJayF, getting them pxe booted, once they boot it tends to go well, although I've seen nodes that boot successfully and never return, it's hard to keep track because the issues are infrequent but always showstoppers when they happen.17:10
JayFMakes sense.17:10
JayFI'm not that familiar with how inspection works, to be honest17:10
jkilpatrhttp://scalelab.redhat.com/17:10
JayFi.e. if inspector handles the pxe booting or if Ironic does17:10
sambettsJayF: just like cleaning17:10
JayFperfect17:10
jkilpatrJayF, neither am I, but it's a major problem for my team, so I'm going to learn.17:10
sambettsJayF: although we have our own DHCP server17:11
JayFso then have you tried with the options enabled to use ipxe pulling directly from swift?17:11
JayFIME pxe booting bottlenecks are rarely the dhcp server, more often TFTP or image downloads17:11
*** harlowja has joined #openstack-ironic17:11
* jkilpatr goes looking for the swift performance metrics he saw on the perf mailing list a few days ago17:11
JayFif you're not using ipxe, try enabling it -- if you're already using ipxe, try enabling the settings for pulling the images directly from swift over http17:11
sambettsdtantsur: did we get iPXE working for inspection yet?17:12
dtantsursambetts, for looooong time17:12
dtantsurit's the default in tripleo17:12
sambettsoh awesome :D17:12
jkilpatrok so I'm already using that good.17:12
dtantsursambetts, JayF, not that even iPXE uses TFTP to bootstrap.. and DHCP can be a bottleneck too17:13
*** rbartal has quit IRC17:13
sambettsjkilpatr: do you have native iPXE on your hardware or are chain loading it17:13
JayFdtantsur: IME with OnMetal, we rarely saw DHCP itself be the bottleneck. We supported hundreds of nodes pxe booting simultaneously with one isc dhcp server17:13
JayFdtantsur: we /did/ see slow TFTP and slow HTTP as a culprit17:13
jkilpatrsambetts, how would I tell?17:13
JayFdtantsur: particularly at one point when we had our http and tftp servers co-located on the same box. The http sessions would choke out tftp at high scale17:14
dtantsuroh interesting17:14
dtantsurJayF, we do have everything co-located on one box in tripleo17:14
sambettsgood question :-P dtantsur do you know how to tell if your using native iPXE or not?17:14
JayFdtantsur: bingo17:14
JayFdtantsur: I got $20 that says if you move http and tftp to different boxes (tftp can colocate with dhcp, but not http), you scale up 10x higher without issue17:15
dtantsursambetts, jkilpatr, either by looking at xinet.d logs or by looking at the screen17:15
dtantsurjkilpatr, see JayF comment ^^^17:15
jkilpatrJayF, that's useful, but undercloud.17:15
dtantsurjkilpatr, well, we can start splitting undercloud........17:15
JayFdtantsur: obviously all this knowledge is from our static setup with dhcp_provider=None, but the issues match ours related to performance17:16
* dtantsur imagines tripleo folks' reaction17:16
jkilpatrbe careful that's how you start a riot.17:16
JayFjkilpatr: I don't use or really like tripleo tbh, I'm just giving general systems+ironic advice :D17:16
jkilpatrJayF, thanks for the info, it's very valuable. Those of us stuck with tripleo just need to figure this issue out.17:16
dtantsurjkilpatr, you may want to talk to dsneddon about his routed networks work.. maybe he'll think about separating ironic nodes per network or something17:17
*** baoli has quit IRC17:17
JayFSeriously though, colocating TFTP and HTTP is a scaling nightmare17:18
jkilpatrdtantsur, I guess by the time we get to dozens or hundreds of nodes more than one node for an undercloud isn't such a hard sell, but at 20-30 nodes even blowing 1 on an undercloud can be difficult to stomach.17:18
JayFbecause TCP connections from the HTTP server choke out TFTP and break PXE booting17:18
JayFa single overloaded HTTP server just makes all of them equally slow to boot, but they get there17:18
JayFand overloaded server running TFTP leads to full timeouts and failures17:18
*** derekh has quit IRC17:18
jkilpatrright now I'll settle for just making it possible to rate limit these things and get the job done.17:19
jkilpatrwhich I guess is an option already, so I'm off to test that17:19
jkilpatrtalk to you all a few hundred introspections from now.17:19
jkilpatrthanks a lot for the help.17:19
dtantsurgood luck :)17:20
JayFeven the numbers match fwiw as well17:20
JayFwe saw cleaning max out at about 10-20 machines at a time until we split tftp and http servers17:20
*** evgenyzhurko has quit IRC17:21
*** intr1nsic has joined #openstack-ironic17:21
dtantsuroh, interesting!17:22
dtantsurthat's why it's so awesome to have real operators on the team :)17:23
*** priteau has joined #openstack-ironic17:23
sambetts\o/17:23
JayFI think it was jroll who figured this one out17:23
JayFway back, many months >1y ago17:23
JayFjroll is more pr0 at operating software than he lets on, don't let him fool you17:23
JayFlol17:23
dtantsur:D17:23
*** sabeen has quit IRC17:24
*** jerrygb has joined #openstack-ironic17:25
*** intr1nsic is now known as matt_welch17:27
*** jerrygb_ has quit IRC17:28
*** ralonsoh has joined #openstack-ironic17:30
*** rpioso has quit IRC17:33
*** e0ne has quit IRC17:34
* TheJulia walks in and grumbles about BCN StackPlague17:36
NobodyCam:(17:36
*** Goneri has joined #openstack-ironic17:36
JayFTheJulia: I got the flu without even having to go to the summit17:36
JayFTheJulia: it's transferred through irc, apparently17:36
TheJuliaJayF: \o/17:36
*** rpioso has joined #openstack-ironic17:39
mgouldTheJulia: o/17:39
TheJuliaWe like need... a wave but somehow also indicating a hazmat suit is in use or something17:42
JayF[o]/17:42
TheJuliaperfect!17:43
mgould[o]/17:43
NobodyCamlol17:43
mariojv[⚠ ]/17:43
*** zackf has quit IRC17:44
NobodyCam[+][+][+]17:44
TheJuliaNow we just need to convert pixie boots to ascii art!17:45
mgould#pixiesay I scorn your limited 7-bit character sets17:50
mgoulddammit17:51
*** hpe-hj has quit IRC17:51
NobodyCamTheJulia: http://paste.openstack.org/show/HpFcZEWMj5fHnblcTXBs/17:51
mgoulddid pixiebot's host go away again?17:51
*** krtaylor has quit IRC17:52
openstackgerritMerged openstack/ironic: TrivialFix: Fix typo in config file  https://review.openstack.org/37730717:52
*** jtomasek_ has quit IRC17:53
*** zackf has joined #openstack-ironic17:54
lucasagomesmgould, it did :-( It was in an internal vm before17:56
lucasagomeswhich is now dead17:56
*** vishwanathj has quit IRC17:56
lucasagomeswe should find a new home for it17:56
*** mgoddard_ has quit IRC17:57
mgouldthis whole "cloud computing" thing is far too unreliable, it'll never catch on17:58
sambettshaha you need to turn pixebot into cattle ;)17:58
lucasagomes++17:58
sambettsits not a pet17:59
sambetts:-P17:59
lucasagomesfor users it's happy land but for people working on the cloud it's a nightmare17:59
mgouldhighly-available IRC bots as a service17:59
mgouldwith service discovery and failover and leader-election17:59
lucasagomesusers should learn how to play a guitar, talk to friends, socialize in general when they can't access their email17:59
lucasagomesso ppl like us could live happier17:59
lucasagomes:-)17:59
mgouldand on that note, /me -> home :-)18:00
mgouldgood night, everyone!18:00
*** mgould is now known as mgould|afk18:00
NobodyCamnight mgould18:00
lucasagomesmgould, g'night18:00
*** [1]rpioso has joined #openstack-ironic18:00
*** ralonsoh has quit IRC18:00
*** rpioso has quit IRC18:01
*** athomas has quit IRC18:02
TheJuliaIRC bots + leader election could get challenging, what if multiple bots decide they are the leaders?18:02
dtantsursounds like fun, let's do it!18:03
TheJuliaAnd if they are the leaders! are they more than puppets?18:03
TheJulia(since, most irc bots are scripted puppets... of sorts)18:04
TheJuliaNobodyCam: \o/ for ascii pixie botos18:04
NobodyCamhehehehe :p18:04
*** dougs1 has quit IRC18:06
*** jjohnson2 has joined #openstack-ironic18:07
JayFTheJulia: leader election via irc is easy18:07
JayFTheJulia: whoever has the nickname wins18:07
TheJuliayes, but what if there are multiple splits...18:08
JayFTheJulia: and they can join a dummy channel while waiting. if the nickname goes away, whoever wins the race is the new bot and joins all the channels18:08
TheJuliaand desynced clocks on irc servers18:08
JayFTheJulia: there's no state. it doesn't matter. You'd have maximum bot service on both sides of the split18:08
JayFwhen the split resolves and one bot is forced to change name, it's not the leader anymore and parts all channels except the coordination one18:08
TheJuliaeh, true18:08
*** lucasagomes is now known as lucas-afk18:09
TheJuliawell, I thought on desync conditions or returning from a split, the youngest session to the ircd gets kicked18:09
TheJuliato resolve the conflict18:09
JayFI mean, how it's resolved doesn't matter, as long as the IRC server end state is "exactly one bot with the nickname"18:10
TheJuliaIRC server operators would hate us :)  This sounds like a grand idea!18:11
JayFlol "it looks like you're running a botnet"18:11
JayFwell, I am, but you know, the good kind!18:11
TheJulialol18:12
dtantsur:D18:13
dtantsurok, I'm calling it a day. g'night!18:13
*** dtantsur is now known as dtantsur|afk18:13
NobodyCamnight dtantsur|afk18:22
*** baoli has joined #openstack-ironic18:23
*** baoli_ has joined #openstack-ironic18:24
*** baoli has quit IRC18:29
*** baoli_ has quit IRC18:29
*** zackf has quit IRC18:31
*** baoli has joined #openstack-ironic18:35
* sambetts -> home 18:35
*** sambetts is now known as sambetts|afk18:35
NobodyCamnight sambetts :)18:35
sambetts|afko/ NobodyCam18:35
*** zackf has joined #openstack-ironic18:37
*** rama_y has quit IRC18:41
openstackgerritMerged openstack/ironic-specs: Boot from Volume - Reference Drivers  https://review.openstack.org/29499518:43
JayFTheJulia: ^ congrats18:44
NobodyCamnice :)18:45
*** krtaylor has joined #openstack-ironic18:49
*** rbrud has joined #openstack-ironic18:55
*** aNuposic has quit IRC18:56
*** madorn has joined #openstack-ironic18:57
*** sabeen has joined #openstack-ironic18:57
openstackgerritMerged openstack/ironic: Use kvm for ironic VMs when possible  https://review.openstack.org/38910918:59
*** rama_y has joined #openstack-ironic19:00
*** Goneri has quit IRC19:06
*** strigazi is now known as strigazi_AFK19:09
*** Administrator__ has joined #openstack-ironic19:11
*** zhugaoxiao has quit IRC19:15
*** MattMan has quit IRC19:19
*** portdirect is now known as harbor_log19:24
*** bnemec has joined #openstack-ironic19:28
*** zackf has quit IRC19:31
*** clsacramento has joined #openstack-ironic19:33
*** ohamada has quit IRC19:33
*** zackf has joined #openstack-ironic19:34
*** causten has quit IRC19:34
rloohey, is the IPA gate still down?19:34
*** rama_y has quit IRC19:35
*** matt_welch has quit IRC19:37
openstackgerritPavlo Shchelokovskyy proposed openstack/ironic-specs: Add a 'preview' tox target  https://review.openstack.org/39228519:39
*** causten has joined #openstack-ironic19:40
*** mtreinish has quit IRC19:40
*** rcernin has joined #openstack-ironic19:41
*** mtreinish has joined #openstack-ironic19:43
*** moshele has joined #openstack-ironic19:44
openstackgerritMilan Kováčik proposed openstack/ironic-inspector: Add API for listing all introspection statuses  https://review.openstack.org/34492119:44
*** dougs has joined #openstack-ironic19:45
rlooJayF, jroll: ^^ IronicWhiteBoard shows IPA gate as down. Is that true?19:47
*** dougs1 has joined #openstack-ironic19:47
*** baoli has quit IRC19:47
*** baoli_ has joined #openstack-ironic19:47
jrollrloo: no, this fixed it, sorry https://github.com/openstack-infra/project-config/commit/a044716224a00e174bf7f4faede7d6e57011f68a19:48
rloojroll: thx19:48
jrollrloo: updated whiteboard19:49
jrollsorry, signed off before verifying yesterday19:49
rloojroll: no worries19:49
*** dougs1 has quit IRC19:49
*** dougs has quit IRC19:50
openstackgerritPavlo Shchelokovskyy proposed openstack/ironic-specs: Amend dynamic iPXE configuration spec  https://review.openstack.org/39229019:50
openstackgerritMilan Kováčik proposed openstack/ironic-inspector: Add API for listing all introspection statuses  https://review.openstack.org/34492119:50
*** dougs has joined #openstack-ironic19:50
*** dougs1 has joined #openstack-ironic19:51
*** baoli has joined #openstack-ironic19:51
*** baoli_ has quit IRC19:52
openstackgerritPavlo Shchelokovskyy proposed openstack/ironic-specs: Add a 'preview' tox target  https://review.openstack.org/39228519:52
*** dougs has quit IRC19:55
rlooJayF, jroll: an easy one. has been +A'd several times19:56
*** Goneri has joined #openstack-ironic19:57
milannight Ironic! :)19:57
jrollrloo: which one?19:58
rloojroll: oops, https://review.openstack.org/33811719:58
patchbotpatch 338117 - ironic - Add IRONIC_TEST_NETWORK_NAME devstack plugin var19:58
*** mmedvede has quit IRC19:58
* rloo still trying to get back into the swing of things...19:58
jrollso many conflicts on that :/19:59
* jroll lands it anyway19:59
jrolloh, that depends on https://review.openstack.org/#/c/334382/20:00
patchbotpatch 334382 - ironic - Allow to use FLAT network setup20:00
* jroll not sure if up to review that right now20:01
rloojroll: ugh. missed that. and yeah, not sure i feel like reviewing that today20:01
*** baoli has quit IRC20:04
*** baoli has joined #openstack-ironic20:05
*** zackf has quit IRC20:10
openstackgerritMario Villaplana proposed openstack/ironic: Add ability to time out on individual clean steps  https://review.openstack.org/39155420:11
JayFmariojv: I am almost certain you can't use actual signals for that20:12
*** dprince has quit IRC20:12
JayFmariojv: because a single given conductor could be handling multiple nodes simultaneously20:12
JayFright?20:12
mariojvJayF: the signal's only used for sync clean steps20:12
JayF.o(there are sync clean steps?)20:13
JayFeven still, doesn't my comment still apply? the conductor could be running a step on multiple nodes, so a single unix signal would effect them all, right/20:13
*** rama_y has joined #openstack-ironic20:14
mariojvmy understanding was that a sync clean step was a blocking operation20:14
*** zackf has joined #openstack-ironic20:14
JayFbut the conductor uses worker threads for stuff like that20:14
JayFbut I think signals are process-wide, not thread specific20:15
mariojvah, yeah, and the signals are per-... yup20:15
JayFalso what would happen if a user just did a kill -ALRM `pidof conductor`20:15
* mariojv pokes around looking at docs20:15
JayFI really dislike use of actual unix signals for this for that reason if none other; that someone could send the signal outside of the process and cause that to happen20:16
jrolleven with syncronous clean steps, the greenthreads could yield, those aren't completely blocking20:16
rloomariojv: I haven't looked -- but we shouldn't have long-running sync clean steps?20:20
*** baoli has quit IRC20:20
*** baoli has joined #openstack-ironic20:21
mariojvi'm not sure if they're actually used, but there is logic in the conductor manager to handle them20:21
mariojvi'm having a hard time coming up with a way to time those out other than messing with the internals of the task manager though20:23
*** dougs1 has quit IRC20:23
mariojvi'm not sure that would be possible without overloading the worker pool either, 1 greenthread per clean step might not be a good idea20:29
JayFchange the goalposts, at least for the initial patch, and only support async steps?20:29
*** baoli has quit IRC20:30
*** baoli_ has joined #openstack-ironic20:30
mariojvi can do that. one downside to that is it makes it difficult for creators of clean steps to see that sync steps won't support it, other than documenting well20:30
mariojvthe only difference codified in code between sync vs. async that i can tell is that async returns CLEANWAIT20:31
mariojvmeaning you can't error out if someone tries to make a sync clean step with a timeout; it'll just not work20:31
mariojv(not work, meaning the timeout won't work)20:32
JayFI'm suspicious20:33
JayFthat asyncc vs sync20:33
JayFis more in-band vs oob20:33
JayFbecause for in band cleaning steps I can't imagine why we'd ever put the node in cleanwait20:33
*** priteau has quit IRC20:34
*** priteau has joined #openstack-ironic20:35
mariojvyou mean for OOB, right?20:35
JayFyeah20:36
mariojvwould there be anything wrong with using this? http://eventlet.net/doc/modules/timeout.html i think that'd work since the exception would be raised in the current greenthread20:38
*** baoli has joined #openstack-ironic20:39
*** priteau has quit IRC20:39
JayFI'm not familiar enough with eventlet to have an educated opinion on that20:40
*** baoli_ has quit IRC20:40
*** jkilpatr has quit IRC20:41
JayFmariojv: re-reading it, it seems sane because it'll happen in the same greenthread20:42
*** baoli has quit IRC20:43
*** zackf has quit IRC20:51
*** aNuposic has joined #openstack-ironic20:52
*** baoli has joined #openstack-ironic20:53
*** zackf has joined #openstack-ironic20:53
*** baoli_ has joined #openstack-ironic20:54
*** e0ne has joined #openstack-ironic20:55
*** baoli has quit IRC20:58
*** priteau has joined #openstack-ironic20:59
*** mmedvede has joined #openstack-ironic21:03
*** absubram has quit IRC21:12
*** Goneri has quit IRC21:14
TheJuliaJayF: Awesome! *happy dance*21:19
* TheJulia goes and finds more sudafed21:20
*** e0ne_ has joined #openstack-ironic21:25
*** e0ne has quit IRC21:27
*** zackf has quit IRC21:34
*** e0ne_ has quit IRC21:34
*** jheroux has quit IRC21:35
*** zackf has joined #openstack-ironic21:35
*** krtaylor has quit IRC21:37
*** sabeen has quit IRC21:37
*** maratoid_ has joined #openstack-ironic21:38
*** maratoid_ has quit IRC21:40
openstackgerritMerged openstack/python-ironicclient: Updated from global requirements  https://review.openstack.org/38835121:40
*** maratoid_ has joined #openstack-ironic21:41
*** sabeen has joined #openstack-ironic21:46
*** jerrygb has quit IRC21:46
*** jcoufal has quit IRC21:52
openstackgerritMario Villaplana proposed openstack/ironic: Add ability to time out on individual clean steps  https://review.openstack.org/39155421:53
mariojvJayF: switched that to use the eventlet method ^21:53
JayFcool :D21:54
*** zackf has quit IRC21:54
*** jkilpatr has joined #openstack-ironic21:55
*** jerrygb has joined #openstack-ironic22:04
*** sabeen has quit IRC22:05
*** galyna has quit IRC22:06
*** jerrygb has quit IRC22:06
*** priteau has quit IRC22:06
*** zackf has joined #openstack-ironic22:10
JayFjroll: https://review.openstack.org/#/c/392114/2 do you think smoething like this needs a microversion bump?22:11
patchbotpatch 392114 - ironic - API: lookup() ignore malformed MAC addresses22:11
*** zackf has quit IRC22:13
*** zackf has joined #openstack-ironic22:18
openstackgerritMerged openstack/ironic-python-agent: Remove duplicated logging in configdrive creation  https://review.openstack.org/39015822:18
*** zackf has quit IRC22:19
*** baoli_ has quit IRC22:24
openstackgerritMerged openstack/ironic: Correct log the node UUID on failure  https://review.openstack.org/39103122:25
*** baoli has joined #openstack-ironic22:25
*** rbrud has quit IRC22:25
*** g3ek has quit IRC22:30
*** rcernin has quit IRC22:31
*** baoli has quit IRC22:33
*** baoli has joined #openstack-ironic22:33
*** g3ek has joined #openstack-ironic22:40
*** jkilpatr has quit IRC22:40
*** jkilpatr has joined #openstack-ironic22:40
*** wajdi has quit IRC22:47
*** [1]cdearborn has joined #openstack-ironic22:50
*** baoli_ has joined #openstack-ironic22:53
*** baoli has quit IRC22:56
*** shobhar_ has joined #openstack-ironic23:00
*** causten has quit IRC23:00
*** causten has joined #openstack-ironic23:00
*** ElCoyote_ has quit IRC23:00
*** baoli has joined #openstack-ironic23:01
*** baoli_ has quit IRC23:01
*** cdearborn has quit IRC23:03
*** causten has quit IRC23:05
*** baoli has quit IRC23:07
*** zackf has joined #openstack-ironic23:16
*** zackf has quit IRC23:19
*** yuanying has joined #openstack-ironic23:37
*** aNuposic has quit IRC23:45
*** rama_y has quit IRC23:48
*** [1]rpioso has quit IRC23:52
*** moshele has quit IRC23:58

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!