Friday, 2016-09-23

*** zackf has quit IRC00:00
*** ijw has joined #openstack-ironic00:01
rloozer0c00l: max i believe is 1000. unless someone fixed it, it won't go higher even if you specify it00:03
*** rajinir has quit IRC00:05
openstackgerritJohn L. Villalovos proposed openstack/ironic-lib: Remove unneeded disk_utils.mkfs() function  https://review.openstack.org/37516600:06
jlvillalzer0c00l: rloo: https://github.com/openstack/ironic/blob/96d78401098c3f2474c9bfe6d30869266f07852d/ironic/conf/api.py#L28-L3100:08
jlvillalI think that is where the 1000 limit comes from.00:08
rloojlvillal: that's the default. you can override it, but if i recall correctly, if you try to get more than 1000, it'll clamp it to 1000. unless it was fixed but i seem to recall someone had some reason for clamping it at 1000. (it was awhile ago)00:10
rloojlvillal: might have had something to do with the max size of the BODY of the response. can't recall now00:10
*** rbrud has quit IRC00:11
jlvillalrloo: Looking at the code it looks you can override it with a config change. But I haven't tested it.00:14
*** wajdi has joined #openstack-ironic00:14
rloojlvillal: i don't remember :)00:15
*** rpioso has quit IRC00:16
* jlvillal just read that dtantsur|afk is now a core in puppet-ironic. Congrats dtantsur|afk :)00:17
*** tuanla has joined #openstack-ironic00:23
*** syed_ has quit IRC00:33
*** phuongnh has joined #openstack-ironic00:47
openstackgerritJohn L. Villalovos proposed openstack/ironic-lib: Remove unneeded disk_utils.mkfs() function  https://review.openstack.org/37516600:50
*** mtanin___ has joined #openstack-ironic00:52
*** moshele has joined #openstack-ironic00:52
*** mtanino has quit IRC00:53
*** ijw has quit IRC00:57
zer0c00lrloo, jlvillal thanks00:59
zer0c00lTo get all the nodes  i did '--limit 0'00:59
*** hoangcx has joined #openstack-ironic01:00
rloozer0c00l: sweet, so we did put in a way to do it...01:01
tuanlaHello ironic team01:09
*** ijw has joined #openstack-ironic01:14
*** dprince has joined #openstack-ironic01:22
*** dprince has quit IRC01:22
openstackgerritCao Xuan Hoang proposed openstack/ironic-ui: TrivialFix: Remove logging import unused  https://review.openstack.org/36590901:25
openstackgerritCao Xuan Hoang proposed openstack/ironic-ui: Clean imports in code  https://review.openstack.org/36591101:26
*** ijw has quit IRC01:28
*** rloo has quit IRC01:32
*** Sukhdev has joined #openstack-ironic01:37
*** wajdi has quit IRC01:47
*** wajdi has joined #openstack-ironic01:47
*** wajdi_ has joined #openstack-ironic01:49
*** wajdi has quit IRC01:52
*** bfournie has joined #openstack-ironic01:55
openstackgerritgengchc2 proposed openstack/ironic: Fix a typo in helper.py  https://review.openstack.org/37519301:58
*** joprovost has quit IRC01:59
*** mtanino has joined #openstack-ironic02:16
*** mtanin___ has quit IRC02:17
*** Sukhdev has quit IRC02:19
*** mtanino has quit IRC02:22
*** Sukhdev has joined #openstack-ironic02:28
*** thrash is now known as thrash|g0ne02:35
*** Sukhdev has quit IRC02:38
*** amotoki has quit IRC02:41
*** rama_y has quit IRC02:48
*** amotoki has joined #openstack-ironic02:53
*** rajinir has joined #openstack-ironic02:56
*** wajdi_ has quit IRC02:58
*** david-lyle has quit IRC03:04
*** amotoki has quit IRC03:09
*** moshele has quit IRC03:11
*** amotoki has joined #openstack-ironic03:19
*** mtanino has joined #openstack-ironic03:26
*** rama_y has joined #openstack-ironic03:32
*** vikrant has joined #openstack-ironic03:38
*** amotoki has quit IRC03:39
*** mtanino has quit IRC03:41
*** Sukhdev has joined #openstack-ironic03:46
*** amotoki has joined #openstack-ironic03:49
*** baoli_ has joined #openstack-ironic03:54
*** ijw has joined #openstack-ironic03:56
*** baoli has quit IRC03:58
*** vmud213 has joined #openstack-ironic03:58
*** jrist has joined #openstack-ironic03:59
*** ijw has quit IRC04:01
*** sdake has quit IRC04:02
*** baoli has joined #openstack-ironic04:14
*** baoli_ has quit IRC04:17
*** ijw has joined #openstack-ironic04:17
*** ijw has quit IRC04:19
*** baoli has quit IRC04:29
*** bks has joined #openstack-ironic04:46
*** rajinir has quit IRC05:05
*** appu103_ has joined #openstack-ironic05:09
*** appu103_ is now known as aparnav05:09
*** syed_ has joined #openstack-ironic05:09
*** jaosorior has joined #openstack-ironic05:10
*** sabeen has quit IRC05:22
*** zackf has joined #openstack-ironic05:22
*** zackf has quit IRC05:27
*** vmud213 has quit IRC05:37
*** vmud213 has joined #openstack-ironic05:37
*** absubram has quit IRC05:47
*** mjura has joined #openstack-ironic05:52
openstackgerritHimanshu Kumar proposed openstack/python-ironicclient: Fixed to list all nodes which are in no-maintenance mode  https://review.openstack.org/37309605:56
*** mjura has quit IRC05:59
*** mjura has joined #openstack-ironic06:00
openstackgerritHimanshu Kumar proposed openstack/python-ironicclient: Fixed to list all nodes which are in no-maintenance mode  https://review.openstack.org/37309606:01
*** ianw is now known as ianw_pto06:02
*** rcernin has joined #openstack-ironic06:15
pas-hamorning Ironic. TGIF :)06:17
*** aswadr_ has joined #openstack-ironic06:25
*** phuongnh has quit IRC06:29
*** phuongnh has joined #openstack-ironic06:29
openstackgerritMilan Kováčik proposed openstack/ironic-inspector-specs: Endpoint to list introspection statuses  https://review.openstack.org/37504506:46
*** hoangcx_ has joined #openstack-ironic06:55
*** vsaienko has joined #openstack-ironic06:56
*** hoangcx has quit IRC06:57
*** phuongnh has quit IRC06:58
*** phuongnh has joined #openstack-ironic06:58
openstackgerritMilan Kováčik proposed openstack/ironic-inspector-specs: Endpoint to list introspection statuses  https://review.openstack.org/37504507:00
*** vsaienko has quit IRC07:00
*** vsaienko has joined #openstack-ironic07:01
*** Sukhdev has quit IRC07:11
*** vsaienko has quit IRC07:11
*** vsaienko has joined #openstack-ironic07:12
openstackgerritGalyna Zholtkevych proposed openstack/ironic: Migrate to keystone session for generating temp_url  https://review.openstack.org/35228907:13
*** syed_ has quit IRC07:23
*** jpich has joined #openstack-ironic07:37
*** hoangcx_ has quit IRC07:38
*** hoangcx has joined #openstack-ironic07:39
*** vsaienko has quit IRC07:42
openstackgerritTuan Luong-Anh proposed openstack/ironic: Remove six.moves module  https://review.openstack.org/37529707:47
*** ohamada has joined #openstack-ironic07:47
*** athomas has quit IRC07:55
*** makowals_ has joined #openstack-ironic07:55
*** vsaienko has joined #openstack-ironic07:57
*** makowals_ has quit IRC07:58
*** makowals has quit IRC07:58
*** makowals has joined #openstack-ironic07:59
*** zzzeek has quit IRC08:00
*** zzzeek has joined #openstack-ironic08:00
*** amotoki_ has joined #openstack-ironic08:00
*** athomas has joined #openstack-ironic08:01
*** makowals has quit IRC08:01
*** amotoki has quit IRC08:03
*** vsaienko has quit IRC08:19
*** amotoki_ is now known as amotoki08:24
*** Romanenko_K has joined #openstack-ironic08:24
*** absubram has joined #openstack-ironic08:30
*** absubram_ has joined #openstack-ironic08:32
*** absubram has quit IRC08:34
*** absubram_ is now known as absubram08:34
*** absubram has quit IRC08:34
*** derekh has joined #openstack-ironic08:44
*** vnogin has left #openstack-ironic08:44
*** dtantsur|afk is now known as dtantsur08:45
dtantsurgood (so called) morning, Ironic08:45
* dtantsur stares at the monitor in a desperate attempt to wake up08:45
dtantsurthanks jlvillal :)08:45
vdrokmorning dtantsur :)08:46
openstackgerritDmitry Tantsur proposed openstack/ironic-lib: Fix check for GPT partioned device  https://review.openstack.org/37532008:49
dtantsurjlvillal, we need to backport all the fixes to newton ^^^ also thanks for spotting it08:50
dtantsurhey vdrok08:50
openstackgerritMerged openstack/ironic-lib: Add py35 to tox environments  https://review.openstack.org/37500008:56
tuanlamorning ironic09:02
tuanlaI have done deploy window image using ironic09:03
*** openstackgerrit has quit IRC09:03
tuanlabut it have some problems relate to ipmi_tool Do you have free time d09:04
*** openstackgerrit has joined #openstack-ironic09:04
tuanlaMy problem because when i set pxe boot using ipmi bootdev, it not just set pxe is hightest priority but it also delete other option in boot priority.09:06
*** pmannidi has quit IRC09:06
*** makowals has joined #openstack-ironic09:07
tuanlahello dtantsur,09:07
dtantsuro/09:07
tuanlahello sambetts|pto09:08
vsaienk0Morning dtantsur, tuanla, lucasagomes, sambetts, milan, vdrok, pas-ha and all Ironic'ers!09:08
dtantsurhey vsaienk0!09:08
tuanlaDo you guide remember my bugs "Not locate configuration file or MBR signature"09:08
tuanlaHello vsaienk0,09:09
vdrokmorning vsaienk009:09
dtantsurvsaienk0, btw, will you have time to check the xenial job today?09:09
vsaienk0dtantsur: the patch was merged yesterday, I've launched tests and xenial job passed09:09
dtantsurwow, awesome09:09
dtantsurvsaienk0, link handy to the test run?09:10
vsaienk0dtantsur: https://review.openstack.org/#/c/369021/  gate-tempest-dsvm-ironic-pxe_ipa-postgres-ubuntu-xenial-nv09:10
patchbotpatch 369021 - ironic - WIP: Ironic multitest initial commit09:10
dtantsurfantastic! thanks vsaienk009:10
vsaienk0dtantsur: I'm going to upload patch to switch all IPXE -nv jobs to xenial today09:11
dtantsurvsaienk0, yes, this is the next step. thanks for tracking it. please add me as a reviewer.09:11
vsaienk0dtantsur: sure09:12
*** bcornec1 has quit IRC09:19
openstackgerritGalyna Zholtkevych proposed openstack/ironic: Migrate to keystone session for generating temp_url  https://review.openstack.org/35228909:24
dtantsurmandre, hi! how is your deployment going?09:24
openstackgerritMarkos Chandras proposed openstack/bifrost: Ignore Ansible retry files in .gitignore  https://review.openstack.org/37535009:25
mandredtantsur: very well ironic-wise :)09:27
dtantsurcool, that's a relief09:28
mandreyeah! was this function new code? I don't recall it failing for me before09:30
*** pester has quit IRC09:32
*** amotoki has quit IRC09:32
dtantsurmandre, yes, we just received support for configdrive when deploying whole disk images with pxe_* drivers09:32
dtantsurpreviously a config drive won't be created09:32
*** milan has joined #openstack-ironic09:33
milanmorning Ironic! :) TGIF!09:33
dtantsuroh yeah, TGIF09:33
mandredtantsur: well... I'm glad I exercised this code :)09:34
dtantsurthanks for that :) now we have some gate coverage for this case too, but I'm still not sure we use config drive..09:34
dtantsurvdrok or jroll (when you're here): are you sure / do you know if we are using config drive in the CI?09:35
dtantsurI can't find any traces of it, at least not in the whole disk job09:35
milanaarefiev, dtantsur FYI: the spec of the list introspections endpoint: https://review.openstack.org/#/c/375045/09:35
patchbotpatch 375045 - ironic-inspector-specs - Endpoint to list introspection statuses09:35
dtantsurcool09:35
milanbike shedding time! :D09:35
dtantsur\o/09:35
*** AlexeyAbashkin has quit IRC09:40
dtantsurI see FORCE_CONFIG_DRIVE=False in our localrc, so I guess I can assume we don't test it...09:43
openstackgerritDmitry Tantsur proposed openstack/ironic: DO NOT MERGE: testing config drive  https://review.openstack.org/37536209:49
*** amotoki has joined #openstack-ironic09:54
*** amotoki has quit IRC09:55
openstackgerritZhou Ya proposed openstack/ironic-python-agent: Get numa_node info when collecting pci devices info  https://review.openstack.org/36924510:01
openstackgerritVadim Hmyrov proposed openstack/python-ironicclient: Fix display of chassis UUID field if empty  https://review.openstack.org/37076410:06
*** thrash|g0ne is now known as thrash10:07
vdrokmorning milan10:13
vdrokdtantsur: let me check10:13
milanmorning vdrok! :)10:13
aarefievmilan: nice, I'll take a look10:13
milanaarefiev, thanks! :)10:13
aarefievthank you10:14
*** tuanla has quit IRC10:15
vdrokdtantsur: hm, yeah, in the wholedisk pxe_ssh job I see Checking for configdrive device (None) on node 29a15c7f-7b10-4740-a0d6-559c983668e0. work_on_disk10:19
openstackgerritXu Ao proposed openstack/ironic: Make ironic console supporting the nokeepalive mode  https://review.openstack.org/37283010:19
dtantsurvdrok, I've posted https://review.openstack.org/375362 to test forcing config drive10:19
vdrokit's in the log of the change when the support was added10:19
patchbotpatch 375362 - ironic - DO NOT MERGE: testing config drive10:19
dtantsurmorning aarefiev10:19
aarefievmorning dtantsur10:20
vdrokdtantsur: hm, I'm not sure it will work, there is no config_drive param handling in any of tempest functions called10:30
vdrokcompute feature config drive enabled is true by default10:30
dtantsurI'm not sure compute feature has any relationship to it.. config_drive is passed directly to API10:32
*** phuongnh has quit IRC10:33
dtantsurI think the compute feature changes what their tempest tests are testing10:33
dtantsurbut let's see, I'm not sure in anything :)10:33
*** dtantsur is now known as dtantsur|bbl10:34
openstackgerritVadim Hmyrov proposed openstack/python-ironicclient: Fix display of chassis UUID field if empty  https://review.openstack.org/37076410:35
vdrokoh, right, I see where it comes from, yeah, might work10:38
*** dprince has joined #openstack-ironic10:58
*** mgould|afk is now known as mgould10:59
mgouldmorning Ironic!10:59
openstackgerritGalyna Zholtkevych proposed openstack/ironic: Migrate to keystone session for generating temp_url  https://review.openstack.org/35228911:00
openstackgerritGalyna Zholtkevych proposed openstack/ironic: Migrate to keystone session for generating temp_url  https://review.openstack.org/35228911:03
*** lucas-afk is now known as lucasagomes11:05
lucasagomesmorning all11:05
tangchenmorning guys. :)11:05
mgouldmorning lucasagomes tangchen vdrok aarefiev milan11:07
vsaienk0I'm wondered if sambetts is around?11:08
tangchenmorning mgould11:08
aarefievvsaienk0: he is on pto till monday11:09
aarefievmorning mgould  tangchen11:10
tangchenmorning aarefiev11:11
*** ccamacho|afk is now known as ccamacho11:11
lucasagomeshi there :D11:13
*** dtantsur|bbl is now known as dtantsur11:20
dtantsurmorning lucasagomes, mgould11:20
lucasagomesmorning11:20
dtantsurvdrok, jroll, https://review.openstack.org/#/c/375362/ shows expected breakage with old ironic-lib now, so yeah, we are not testing config drive in CI yet11:20
patchbotpatch 375362 - ironic - DO NOT MERGE: testing config drive11:20
vdrokdtantsur: ++ just seen that11:21
dtantsurnow I wonder if we need to just merge this patch, or do we need a new set of gates (omg!) to test config drive?11:21
vdrokMorning lucasagomes and mgould !11:21
vdrokIf rather merge this one11:21
vdrok*I'd11:22
*** aswadr_ has quit IRC11:22
dtantsurthen we'll stop testing metadata service... I wonder if it's important11:22
*** hoangcx has quit IRC11:23
dtantsurlet's wait for jroll to chat about it11:23
dtantsuralso lucasagomes, wdyt about switching our CI to testing config drive?11:23
* dtantsur fixes commit message for the patch11:24
lucasagomesdtantsur, I'm bit out of context... if we use pxe_ssh + whole disk image it won't use the config drive?11:24
vdrokMetadata should be tested in other places right? And config drive is the thing that affects deployment directly...11:25
lucasagomes(I know it's not failing due that ironic-lib error shown by 375362)11:25
dtantsurlucasagomes, our CI does not cover config drive, that's the problem11:25
dtantsurfor no combinations of drivers and images iiuc11:26
dtantsurvdrok, I'm also inclined to think that testing config drive is more important than testing essentially neutron11:26
vdrokYup11:27
lucasagomesdtantsur, oh right, so ++ we should def test it11:27
openstackgerritDmitry Tantsur proposed openstack/ironic: Test building config drive in ironic_tempest_plugin  https://review.openstack.org/37536211:27
dtantsurwith updated commit message ^^^11:27
lucasagomesI agree configdrive > metadata in importance for us11:27
dtantsurok, so the patch is ready, please vote :)11:30
openstackgerritMerged openstack/ironic-ui: update homepage with developer documentation page  https://review.openstack.org/37312511:30
* dtantsur writes to the ML11:32
lucasagomesdtantsur, ++ exactly, better for consensus there11:32
openstackgerritMerged openstack/ironic-ui: Clean imports in code  https://review.openstack.org/36591111:34
openstackgerritMerged openstack/ironic-ui: TrivialFix: Remove logging import unused  https://review.openstack.org/36590911:34
openstackgerritMerged openstack/ironic-ui: Minor state-machine fixes/updates  https://review.openstack.org/37497411:34
*** amotoki has joined #openstack-ironic11:38
tangchenlucasagomes, dtantsur, vdrok, milan: Hi guys, please help to check this simple fix when you have time. https://review.openstack.org/#/c/357639/11:39
patchbotpatch 357639 - python-ironicclient - Support i18n for osc plugin help msg11:39
tangchenthanks very much11:39
openstackgerritMerged openstack/ironic-python-agent: Add py35 to tox environments  https://review.openstack.org/37504611:43
lucasagomestangchen, commented11:44
lucasagomestangchen, it's missing i18n in some bits there11:44
lucasagomessee commit message comment as well11:44
lucasagomesother than that it LGTM, thanks!11:44
tangchenlucasagomes: Thanks, will follow that11:45
openstackgerritVadim Hmyrov proposed openstack/python-ironicclient: Support for nested properties with unicode for ironic node  https://review.openstack.org/24918611:45
TheJuliaGood morning11:46
mgouldmorning TheJulia11:50
TheJuliao/11:50
dtantsurmorning TheJulia11:51
mat128o/11:52
mgouldmorning mat12811:52
lucasagomesTheJulia, morning11:52
lucasagomessomeone has seem Nisha around ?11:53
*** jrist has quit IRC11:56
dtantsurI haven't for quite some time11:56
openstackgerritMerged openstack/bifrost: Update reno for Newton  https://review.openstack.org/37491211:57
openstackgerritVadim Hmyrov proposed openstack/ironic-python-agent: Add bash scripts style checking for IPA  https://review.openstack.org/37414712:01
*** ccamacho is now known as ccamacho|lunch12:02
lucasagomesdtantsur, right, there's an odd check added which prevents whole disk image + uefi unless we use local boot. Which seems bogus because if it's a whole disk image we already assumes it's going to boot from the disk12:02
lucasagomeshttps://github.com/openstack/ironic/blob/master/ironic/drivers/modules/agent.py#L338-L34112:02
lucasagomesjroll, ^ around. You use whole disk image right? Do you set "boot_option:local" as a capability ?12:03
lucasagomesassume*12:03
dtantsurlucasagomes, how does it prevent UEFI?12:04
lucasagomesdtantsur, it's another check, this one: https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/pxe.py#L220-L22912:05
lucasagomeswhich is called at validate()12:05
lucasagomesdtantsur, for bios mode you can use whole disk image w/o needing to set "boot_option:local" but for UEFI you can't12:05
dtantsurweird12:06
lucasagomesyeah12:06
dtantsurwhich reminds me, I should start working on switching to local boot by default12:06
openstackgerritTang Chen proposed openstack/ironic: Prepare for functional tests  https://review.openstack.org/34942112:06
dtantsurwow, this is even worse: https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/pxe.py#L243-L24412:06
dtantsurwe should really, really think about feature parity between our different code paths'12:07
lucasagomesdtantsur, heh yeah I have never tested trusted boot12:07
dtantsure.g. this means that trusted boot won't work for tripleo, as we use local boot there...12:08
lucasagomesbut for uefi it really seems bogus, I've commented out that check and just deployed a whole disk image w/o setting local boot and it works12:08
lucasagomesbecuase whole disk already assumes local boot AFAICT12:08
dtantsurlucasagomes, then remove it; we just have to make sure netboot was not explicitly requested, but such check should go elsewhere (and apply for both BIOS and UEFI)12:08
*** jrist has joined #openstack-ironic12:08
*** catintheroof has quit IRC12:08
lucasagomesdtantsur, yeah should be a different check for it12:09
* lucasagomes cooks a patch12:09
* dtantsur undigs his local boot RFE12:09
TheJulialucasagomes: Nisha has been on leave, but I think she should have been back by now12:09
lucasagomesTheJulia, a-ha, thanks for the info12:10
dtantsurlucasagomes, there is something strange about iLO: https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/ilo/deploy.py#L338-L34612:13
dtantsurI wonder if it's really intended.. if so, we can move the check to the ilo driver12:13
lucasagomesdtantsur, I think that would be the best idea, that's why I wanted to ask the iLO folks12:14
*** vikrant has quit IRC12:17
openstackgerritVadim Hmyrov proposed openstack/python-ironicclient: Fix display of chassis UUID field if empty  https://review.openstack.org/37076412:25
xavierrgood morning Ironic12:37
xavierrmorning TheJulia mgould mat128 lucasagomes dtantsur12:37
TheJuliagood morning xavierr12:37
lucasagomesxavierr, good morning12:38
*** rcernin has quit IRC12:38
*** daemontool has joined #openstack-ironic12:40
openstackgerritVadim Hmyrov proposed openstack/python-ironicclient: Support for nested properties with unicode for ironic node  https://review.openstack.org/24918612:41
milanmorning lucasagomes mgould tangchen TheJulia xavierr! :)12:44
*** pcaruana|afk| has joined #openstack-ironic12:44
lucasagomeshi there12:44
vdrokmorning TheJulia mat128 and xavierr12:46
*** sdake has joined #openstack-ironic12:48
dtantsurmorning xavierr, milan12:48
milandtantsur, morning :)12:49
mat128morning xavierr, vdrok and everyone else :)12:49
milanmorning mat128 :)12:49
dtantsurhey mat12812:49
vdrokdtantsur: lucasagomes aha - https://github.com/openstack-dev/devstack/commit/7682ea88a6ab8693b215646f16748dbbc2476cc412:51
lucasagomesvdrok, damn hah12:51
*** vmud213 has quit IRC12:51
lucasagomesvdrok, dtantsur perhaps we could just enable it for the ironic tests then ?12:52
xavierrmorning milan and vdrok o/12:52
dtantsurlucasagomes, yes, this is another option12:52
dtantsurlucasagomes, vdrok, feel free to propose a patch12:53
*** david-lyle has joined #openstack-ironic12:56
*** aparnav has quit IRC12:57
openstackgerritDmitry Tantsur proposed openstack/ironic: [WIP] Introduce default_boot_option configuration option  https://review.openstack.org/37545812:58
openstackgerritVadim Hmyrov proposed openstack/ironic-python-agent: Add bash scripts style checking for IPA  https://review.openstack.org/37414712:59
*** pcaruana|afk| has quit IRC13:00
*** pcaruana has quit IRC13:01
*** pcaruana has joined #openstack-ironic13:02
*** vsaienko has joined #openstack-ironic13:02
*** mjura has quit IRC13:03
*** rcernin has joined #openstack-ironic13:06
mgouldmorning xavierr13:07
xavierrvdrok: I did a refactor in inspection patch but not sure you'll like hehehe13:07
openstackgerritSergii Turivnyi proposed openstack/python-ironicclient: Add tests for testing node-delete command  https://review.openstack.org/25145813:07
openstackgerritSergii Turivnyi proposed openstack/python-ironicclient: Negative tests for testing actions with port.  https://review.openstack.org/25935413:07
openstackgerritSergii Turivnyi proposed openstack/python-ironicclient: Tests for testing chassis-create command  https://review.openstack.org/29363413:07
openstackgerritSergii Turivnyi proposed openstack/python-ironicclient: Negative tests for testing actions with node-get command  https://review.openstack.org/34206013:07
vdrokxavierr: well, let's see what others think if you don't like how things look after refactor13:08
openstackgerritSergii Turivnyi proposed openstack/python-ironicclient: Negative tests for testing actions with Chassis.  https://review.openstack.org/34379613:08
vdrokmaybe that's fine as is13:08
openstackgerritSergii Turivnyi proposed openstack/python-ironicclient: Negative tests for testing actions with node-port-list.  https://review.openstack.org/36063613:08
xavierrvdrok: sure :)13:08
*** alaski is now known as lascii13:09
*** e0ne has joined #openstack-ironic13:11
*** jaosorior has quit IRC13:13
*** e0ne has quit IRC13:14
*** jaosorior has joined #openstack-ironic13:14
*** cdearborn has joined #openstack-ironic13:14
mat128rloo (not online?)13:15
mat128rloo: if you ever see this, I will update my reviews with your latest comments13:16
openstackgerritDmitry Tantsur proposed openstack/ironic: Introduce default_boot_option configuration option  https://review.openstack.org/37545813:17
openstackgerritCharlle Daniel Da Silva Vieira Dias proposed openstack/ironic: Implements the validation to verify if the node is free or in use by  https://review.openstack.org/37276213:19
openstackgerritVadim Hmyrov proposed openstack/python-ironicclient: Support for nested properties with unicode for ironic node  https://review.openstack.org/24918613:19
*** mtanino has joined #openstack-ironic13:19
vdrokdtantsur: lucasagomes https://review.openstack.org/37546713:20
patchbotpatch 375467 - openstack-dev/devstack - Force config drive when using ironic virt driver13:20
mat128vdrok: ^ agreed, is there any test that ran with configdrive=False?13:22
mat128if so, im not sure how they worked13:22
*** e0ne has joined #openstack-ironic13:22
vdrokmat128: force_config_drive was true by default for all hypervisors before https://github.com/openstack-dev/devstack/commit/7682ea88a6ab8693b215646f16748dbbc2476cc413:22
dtantsurvdrok, please update the ML thread with your patch13:23
vdrokso we can either add config_drive=True for all tempest tests that do create_server or set it globally in nova conf13:23
vdrokdtantsur: yup, will do now13:23
mat128vdrok, dtantsur: if there any way to have Ironic work without the configdrive?13:24
mat128s/if/is13:24
vdrokyes, it just won't be written :)13:24
mat128unless you route 169.254.169.254 somewhere, your baremetal will never be able to talk to the md server13:24
dtantsurmat128, yes, route is somewhere :)13:24
mat128hmm13:25
dtantsurit's not impossible, but I guess using config drives is more reliable13:25
* mat128 keeps thinking of baremetal network as real vlans and routers13:25
mat128but there are other options13:25
mat128forgive me :)13:25
dtantsurmat128, note that in our CI we use VMs, so Neutron probably does the right thing wrt MD server13:25
*** rcernin has quit IRC13:26
mat128but our CI is simulating a real scenario, so we should always have a test that does not rely on the MD server being "reachable"13:26
mat128anyway, the patch is about making configdrive mandatory for Ironic, so I shouldn't be concerned13:26
*** rbudden has joined #openstack-ironic13:26
mat128s/for Ironic/for Ironic in CI/13:26
openstackgerritCharlle Daniel Da Silva Vieira Dias proposed openstack/ironic: Implements the verification if the node is free or in use by Ironic  https://review.openstack.org/37276213:32
openstackgerritLucas Alvares Gomes proposed openstack/ironic: Move check for UEFI + Whole disk images  https://review.openstack.org/37548113:33
openstackgerritKyrylo Romanenko proposed openstack/ironic: Test ML2 Fail-Fast feature  https://review.openstack.org/37001613:33
openstackgerritBob Fournier proposed openstack/ironic-inspector-specs: Display LLDP information via new commands  https://review.openstack.org/37438113:33
*** vsaienko has quit IRC13:33
*** Goneri has joined #openstack-ironic13:34
openstackgerritPavlo Shchelokovskyy proposed openstack/ironic: Remove unneeded try..except in heartbeat  https://review.openstack.org/37548213:34
*** ekarlso_ has joined #openstack-ironic13:37
*** vsaienko has joined #openstack-ironic13:41
*** baoli has joined #openstack-ironic13:45
*** baoli_ has joined #openstack-ironic13:46
*** kragniz has quit IRC13:48
*** kragniz has joined #openstack-ironic13:48
*** baoli has quit IRC13:49
openstackgerritBob Fournier proposed openstack/ironic-inspector-specs: Display LLDP information via new commands  https://review.openstack.org/37438113:49
*** rbudden has quit IRC13:51
*** rcernin has joined #openstack-ironic13:52
*** hshiina has joined #openstack-ironic13:53
*** e0ne has quit IRC13:53
*** dansmith is now known as superdan13:55
*** syed_ has joined #openstack-ironic13:56
*** srobert has joined #openstack-ironic13:57
openstackgerritVladyslav Drok proposed openstack/ironic: Remove unnecessary option from plugin settings  https://review.openstack.org/37550113:57
*** sabeen has joined #openstack-ironic13:59
*** jjohnson2 has quit IRC14:01
*** jheroux has joined #openstack-ironic14:02
*** joprovost has joined #openstack-ironic14:03
*** rbrud has joined #openstack-ironic14:08
*** rbudden has joined #openstack-ironic14:09
*** vsaienko has quit IRC14:10
*** daemontool has quit IRC14:12
*** daemontool_ has joined #openstack-ironic14:12
jlvillaldtantsur, Thanks for back-porting the GPT patch14:13
*** daemontool__ has joined #openstack-ironic14:13
dtantsuryou're welcome! (also good morning and happy Friday)14:13
jlvillaldtantsur, Thanks :)14:13
jlvillaldtantsur, When it is time, I hope you have a great weekend too :)14:13
dtantsursoooooon, veeeeeryyy sooooooon!14:14
jlvillalnice14:14
* dtantsur has something like this in his mind: http://cdn.acidcow.com/pics/20120224/soon_06.jpg14:14
vdrokgood morning jlvillal14:15
*** vsaienko has joined #openstack-ironic14:16
jlvillalGood morning vdrok :)14:16
jlvillaldtantsur, heh14:16
mgould:-)14:17
*** daemontool_ has quit IRC14:17
*** Goneri has quit IRC14:17
dtantsurbfournie, milan, speaking of the LLDP commands, I'd prefer not to commit to any API with them14:19
dtantsurso I was thinking that just extending CLI is better.. I'm open to other ideas14:19
*** ccamacho|lunch is now known as ccamacho14:20
milandtantsur, bfournie I wanted to see whether a short-status listing command might want to include any more information14:20
milanif that's not the case, maybe the lldp command should be different from statuses subcommand14:21
milanmy 2C ;)14:21
dtantsurI'd prefer not to create commands just for the sake of having more commands14:21
dtantsurbuilding a good CLI is not fun (or rather type 2 fun as mgould would put it) on its own already14:21
milanit's not for that sake :)14:21
dtantsurthen what for?14:21
dtantsurit's essentially two commands with listing of all nodes14:21
milannot to have unrelated bits sharing same subcommand14:22
dtantsurin what way are they "unrelated"?14:22
milanbecause the point of the first one is to give a brief info14:22
milanwhereas if you wan to use more details you'd better use equivalent of a show14:22
milan"show"14:22
milannope?14:22
dtantsurI'm not totally against it, but all OSC "list" commands have --long variant which shows ALL fields14:23
dtantsur(usually that looks insane, try it)14:23
milanincluding data from plugins?14:23
dtantsurso it's not necessary brief with all possible options. it will still be the same by default14:23
dtantsurwell, I'm afraid for ironic it will include driver_info and driver_internal_info, but I need to check it14:24
dtantsur(also LLDP data does not come from a plugin, it's just optional <- my bad)14:24
dtantsurtested: openstack baremetal node list --long looks super unreadable14:25
dtantsurit does include driver_info on every line14:25
milanOK, if it's a precedence, what can we do about it14:26
milan#pixiesay -meh14:26
dtantsurpixie?14:26
milanoh, that thing is gone?14:27
dtantsur:(14:27
dtantsurmilan, actually the Interfaces column is an easy win: it does not require LLDP data, we can derive it from inventory14:27
dtantsurfor those who wonder what we're discussing: https://review.openstack.org/#/c/374381/14:28
patchbotpatch 374381 - ironic-inspector-specs - Display LLDP information via new commands14:28
*** sabeen1 has joined #openstack-ironic14:28
bfourniedtantsur: yes the interfaces is always there independent of lldp data14:29
milanyeah, interfaces sound OK14:29
*** vsaienko has quit IRC14:30
dtantsurand that's the only place where we're reusing an existing command, right?14:30
bfourniedtantsur: yes14:30
dtantsurcool!14:31
*** sabeen has quit IRC14:31
openstackgerritGalyna Zholtkevych proposed openstack/ironic: Migrate to keystone session for generating temp_url  https://review.openstack.org/35228914:32
dtantsurbfournie, the spec still does not quite render, see http://docs-draft.openstack.org/81/374381/7/check/gate-ironic-inspector-specs-docs-ubuntu-xenial/eadc8ff//doc/build/html/specs/lldp-reporting.html14:36
dtantsurbfournie, you can test with `tox -edocs` locally, then opening doc/build/html/index.html14:36
bfourniedtantsur: hmm, OK, will try that and fix, thanks14:37
*** wajdi has joined #openstack-ironic14:39
*** joprovost1 has joined #openstack-ironic14:42
*** joprovost has quit IRC14:44
*** joprovost1 is now known as joprovost14:44
*** causten has joined #openstack-ironic14:47
*** causten has quit IRC14:48
openstackgerritKyrylo Romanenko proposed openstack/ironic: Test ML2 Fail-Fast feature  https://review.openstack.org/37001614:54
openstackgerritGalyna Zholtkevych proposed openstack/ironic: Migrate to keystone session for generating temp_url  https://review.openstack.org/35228914:55
*** amotoki has quit IRC14:58
milanGood night Ironic15:00
* milan be gone :P15:00
*** milan has quit IRC15:01
*** xavierr is now known as xavierr|lunch15:03
openstackgerritCharlle Daniel Da Silva Vieira Dias proposed openstack/ironic: Ensures that OneView nodes are free for use by Ironic  https://review.openstack.org/37276215:03
mgouldmilan: good night!15:03
*** jistr is now known as jistr|call15:03
*** vishwanathj has joined #openstack-ironic15:05
*** wajdi_ has joined #openstack-ironic15:06
*** helloworld42 has joined #openstack-ironic15:07
*** mat128 has quit IRC15:08
*** wajdi has quit IRC15:08
*** mat128 has joined #openstack-ironic15:08
*** ijw has joined #openstack-ironic15:11
*** helloworld42 has quit IRC15:11
openstackgerritTuan Luong-Anh proposed openstack/ironic: Use six.StringIO instead of six.moves.StringIO  https://review.openstack.org/37529715:13
*** jheroux has quit IRC15:14
*** tuan_luong has joined #openstack-ironic15:14
*** amotoki has joined #openstack-ironic15:14
tuan_luongHello jroll d15:14
tuan_luonghi sambetts|pto15:14
*** ijw has quit IRC15:16
*** ijw has joined #openstack-ironic15:16
*** rpioso has joined #openstack-ironic15:17
*** amotoki has quit IRC15:17
*** tuan_luong has quit IRC15:19
*** jheroux has joined #openstack-ironic15:19
*** rcernin has quit IRC15:19
*** lucasagomes is now known as lucas-hungry15:20
openstackgerritMichael Turek proposed openstack/python-ironicclient: Refactor provision state so all actions can use inherited take_action  https://review.openstack.org/36455215:21
*** tuan_luong has joined #openstack-ironic15:22
openstackgerritKyrylo Romanenko proposed openstack/ironic: Fix tempest plugin to update port connectivity data  https://review.openstack.org/37557015:22
*** srobert has quit IRC15:23
openstackgerritMichael Turek proposed openstack/python-ironicclient: Add --wait to OSC provisioning commands  https://review.openstack.org/35480615:24
*** jistr|call is now known as jistr15:26
*** jistr is now known as jistr|biab15:28
*** rajinir has joined #openstack-ironic15:32
rajinirmjturek: MI, do you release the node in post_hook?15:33
rajinirmjturek: In post_test_hook15:33
*** jistr|biab is now known as jistr15:36
*** bks has quit IRC15:39
openstackgerritVadim Hmyrov proposed openstack/python-ironicclient: Fix output of "ironic node-list --detail" ironic client command  https://review.openstack.org/37557915:42
*** zackf has joined #openstack-ironic15:44
*** ss7pro has joined #openstack-ironic15:45
*** ss7pro has quit IRC15:47
*** ss7pro has joined #openstack-ironic15:47
*** absubram has joined #openstack-ironic15:48
openstackgerritVadim Hmyrov proposed openstack/python-ironicclient: Fix output of "ironic node-list --detail" ironic client command  https://review.openstack.org/37557915:50
*** MattMan has quit IRC15:50
*** MattMan has joined #openstack-ironic15:50
dtantsurcalling it a day, see you and have a nice weekend!15:50
mgoulddtantsur: good night!15:50
*** dtantsur is now known as dtantsur|afk15:50
*** lukl has quit IRC15:51
*** rama_y has quit IRC15:52
jlvillaldtantsur|afk: Dos ve dos!15:54
openstackgerritKyrylo Romanenko proposed openstack/ironic: Test ML2 Fail-Fast feature  https://review.openstack.org/37001615:56
* jlvillal thinks we need to backport the DB patch to stable/mitaka http://logs.openstack.org/77/365977/1/gate/gate-ironic-python27-db-ubuntu-trusty/bb07cca/console.html15:56
*** lukl has joined #openstack-ironic15:56
* jlvillal looks into it...15:57
*** bnemec is now known as beekneemech15:58
*** Goneri has joined #openstack-ironic15:58
openstackgerritJohn L. Villalovos proposed openstack/ironic: Increase timeout for migration-related tests  https://review.openstack.org/37558516:03
*** dprince has quit IRC16:05
openstackgerritJohn L. Villalovos proposed openstack/ironic: Increase timeout for migration-related tests  https://review.openstack.org/37559016:10
openstackgerritMerged openstack/ironic: Fix a typo in helper.py  https://review.openstack.org/37519316:11
openstackgerritMerged openstack/ironic: Fixes wrong steps to perform migration of nodes  https://review.openstack.org/37484116:13
jlvillalvdrok: I assume you still want to get this one in?  https://review.openstack.org/#/c/306010/16:14
patchbotpatch 306010 - nova - Update instance node on rebuild only when it is re...16:14
vdrokjlvillal: yup16:15
*** ohamada has quit IRC16:15
vdrokgood night dtantsur|afk16:15
*** aries_ is now known as ariesyous16:16
jlvillalvdrok: I'll review it. Maybe having it move to the top of the date list will help :)16:16
vdrokjlvillal: tho I'm not sure if it is still relevant, as we have hash ring in nova now, need to check16:17
jlvillalOh16:17
*** jistr is now known as jistr|afk16:18
* jlvillal thinks nova's manager.py could maybe use some refactoring at almost 7000 lines...16:18
openstackgerritMerged openstack/ironic: Add i18n _() to string  https://review.openstack.org/37490516:19
openstackgerritMerged openstack/ironic: Remove unneeded try..except in heartbeat  https://review.openstack.org/37548216:19
openstackgerritMerged openstack/ironic: [api-ref] Correcting type of r_addresses parameter  https://review.openstack.org/36555116:19
jlvillalvdrok: On https://review.openstack.org/#/c/306010/6//COMMIT_MSG  Line 11.  Should that be "instance RECREATE"?16:20
patchbotpatch 306010 - nova - Update instance node on rebuild only when it is re...16:20
*** jaosorior has quit IRC16:21
vdrokjlvillal: CLI command is nova rebuild16:21
vdrokironic does not support recreate iirc16:21
vdrokrebuild is called both during nova rebuild and during instance migration to another host,node which is recreate, if i understood this correctly16:23
vdrokrebuild_instance is called...16:23
jlvillalvdrok: I guess I'm confused by the commit message because the function is called 'rebuild_instance' so I was just thinking we are always doing a rebuild in this function.16:24
jlvillalvdrok: I'm reading the code more to understand better :)16:24
vdrokyeah, that is confusing, just grep rebuild_instance, it's called not only during rebuild :)16:24
*** Romanenko_K has quit IRC16:24
jlvillalvdrok: And since there is a test on 'recreate' is why I thought maybe it should say 'recreate' in the commit message.16:24
jlvillalvdrok: Ah16:24
* jlvillal knows very little Nova code16:25
*** hshiina has quit IRC16:25
vdrokjlvillal: ah, so there is a small explanation in param migration docstring - the two ways to get here are 'rebuild' and 'evacuate'16:26
vdrokand recreate is in the commit message as the parameter that is used to decide whether it is rebuild or evacuate is called recreate16:27
jlvillalvdrok: Thanks. I did a +1, but I'll admit I don't understand all of it. Hopefully some Nova cores will look at it :)16:28
*** lucas-hungry is now known as lucasagomes16:29
NobodyCamGood Morning Ironic'ers and .....16:29
jlvillalvdrok: FYI: I backported the DB migration timeout patch to stable/newton and stable/mitaka16:29
NobodyCamTGIF!16:29
jlvillalNobodyCam: Good morning :)16:29
vdrokthank you jlvillal, I'm looking at the code too, it seems that the bug still valid - https://github.com/openstack/nova/blob/master/nova/virt/ironic/driver.py#L116916:30
vdrokthe driver will try to PATCH instance.node, so it has to be a correct one16:31
vdrokmorning NobodyCam, TGIF indeed :)16:31
NobodyCammorning vdrok16:32
*** rama_y has joined #openstack-ironic16:32
NobodyCam:)16:32
NobodyCammorning jlvillal :)16:32
openstackgerritMerged openstack/ironic: DevStack: Use Jinja2 for templating when creating new VMs  https://review.openstack.org/37434516:33
*** makowals has quit IRC16:36
*** causten has joined #openstack-ironic16:44
*** causten has quit IRC16:49
*** ccamacho is now known as ccamacho|out16:49
mgouldmorning NobodyCam16:50
*** zackf has quit IRC16:51
NobodyCammorning mgould... happy Friday16:52
openstackgerritLucas Alvares Gomes proposed openstack/ironic: DevStack: Configure nodes/environment to boot in UEFI mode  https://review.openstack.org/37498816:54
lucasagomesNobodyCam, morning TGIF16:55
NobodyCamgood morning lucasagomes ... Happy friday to you :)16:55
lucasagomes:D16:55
*** derekh has quit IRC16:56
openstackgerritMerged openstack/bifrost: Allow user to get iPXE files  https://review.openstack.org/36763516:58
openstackgerritMerged openstack/bifrost: Refactor env-setup.sh  https://review.openstack.org/37188316:58
openstackgerritMerged openstack/bifrost: Workaround openSUSE ansible_os_family issue  https://review.openstack.org/37108216:58
openstackgerritMerged openstack/bifrost: Install process SuSE support  https://review.openstack.org/36763716:58
openstackgerritMerged openstack/bifrost: SuSE support for VM node creation  https://review.openstack.org/37038516:58
*** jistr|afk is now known as jistr16:59
NobodyCam:)16:59
*** makowals has joined #openstack-ironic17:00
*** vsaienko has joined #openstack-ironic17:03
*** ccamacho|out has quit IRC17:05
*** trown is now known as trown|lunch17:06
*** makowals has quit IRC17:07
*** tuan_luong has quit IRC17:08
*** catintheroof has joined #openstack-ironic17:09
openstackgerritRicardo Araújo Santos proposed openstack/ironic: Fixes parameters validation in SSH power manager.  https://review.openstack.org/36615017:10
*** adu has joined #openstack-ironic17:12
mjturekhey rajinir yes!17:20
mjturekrajinir: let me get you a paste of that too17:20
*** daemontool__ has quit IRC17:21
*** athomas has quit IRC17:22
mjturekrajinir: http://paste.openstack.org/show/582798/17:24
openstackgerritLucas Alvares Gomes proposed openstack/ironic: DevStack: Support for creating UEFI VMs  https://review.openstack.org/37434617:26
openstackgerritLucas Alvares Gomes proposed openstack/ironic: DevStack: Configure nodes/environment to boot in UEFI mode  https://review.openstack.org/37498817:26
*** zackf has joined #openstack-ironic17:28
*** zackf has joined #openstack-ironic17:28
openstackgerritMario Villaplana proposed openstack/ironic: Add power state change notifications  https://review.openstack.org/32186517:28
*** jpich has quit IRC17:29
*** xavierr|lunch is now known as xavierr17:31
mariojvyuriyz: i took out driver_info and driver_internal_info from the notification payload there ^ and i asked searchlight what fields they'd find useful to keep in17:38
*** ariesyous has left #openstack-ironic17:38
mariojvi'm not totally sure, but i think that they just want us to expose fields that an operator would find useful to search on17:38
mariojvso for example, if i wanted to find all nodes that have a particular driver and see what notifications have been emitted in the past hour for them, having the "driver" field would be necessary17:39
mariojvdriver_info and driver_internal_info are probably less important; i doubt anyone would ever search on driver_internal_info17:40
mariojvbut i've never spoken to any people who use searchlight with another project, so i'm not 100% on what all the use cases for an operator who uses searchlight with ironic would be17:41
mariojvmy initial feeling is we should probably lean towards including more fields than we think are necessary rather than less17:42
mariojvwe can always change the fields later if someone requests it, too17:42
openstackgerritCharlle Daniel Da Silva Vieira Dias proposed openstack/ironic: Clarify when oneview node can be managed by ironic  https://review.openstack.org/37273517:47
vdroklucasagomes: hm, so in https://review.openstack.org/375481 that check is only needed for ilo servers that boot via pxe?17:51
patchbotpatch 375481 - ironic - Move check for UEFI + Whole disk images17:51
lucasagomesvdrok, yeah I left it for iLO because I don't really understand why they perform that check17:52
vdroklooking at the comment there, it says nothing specific about ilo hardware, seems like it was added as a kind of additional caution17:52
lucasagomesvdrok, I can deploy whole disk image + uefi with no problem17:52
vdrokyep, might be better for some ilo folks to have a look17:53
lucasagomesvdrok, rigth yeah, do you think we should remove it all ?17:53
vdrokI cannot say that, I have not tried :)17:53
lucasagomesvdrok, yeah. perhaps I should add 'em in the review. Lemme do it17:53
vdrokyup, thanks17:53
lucasagomesadded Nisha there17:53
vdroklucasagomes: I've also added stendulker and myself, other than that piece it lgtm :)17:54
lucasagomesvdrok, thank you!17:55
openstackgerritClark Boylan proposed openstack/ironic: Support https swift in devstack plugin  https://review.openstack.org/37564917:59
*** krtaylor has quit IRC18:01
*** rpioso has quit IRC18:05
*** trown|lunch is now known as trown18:06
vdrokgood night everyone, see you on monday :)18:09
jrolllucasagomes: we don't set boot_option:local, but also don't believe we use UEFI18:10
jrolldtantsur|afk: sorry, was traveling this morning, will reply to your thread18:10
lucasagomesjroll, thanks. Which is fine because that's the inconsistency: w/o uefi you don't need to set it to local but with uefi you have to18:11
mariojvis every node attribute returnable via api shown via the node detail call? i can find out but curious if someone has a quick answer18:12
jrolllucasagomes: I woke up at 4am to get on a plane this morning, I don't have the brainpower to think about that, but it does seem wrong :)18:12
mariojvsearchlight has said they only find attributes returned via API useful in notifications, so i want to try to narrow down any unneeded ones that my notifications patch might be sending out18:12
lucasagomesjroll, heh yeah, no worries18:13
jrolleasy review to unblock a devstack thing, btw https://review.openstack.org/#/c/375649/118:13
patchbotpatch 375649 - ironic - Support https swift in devstack plugin18:13
jrollour job here will test it https://review.openstack.org/#/c/372374/18:13
patchbotpatch 372374 - openstack-dev/devstack - Turn on tls proxy by default for testing18:13
lucasagomesjroll, +2 revoked the +a until it's tested18:16
jrolllucasagomes: cool, ty18:16
lucasagomesI ill keep an eye on it18:16
mariojvvar name is correct https://github.com/openstack-dev/devstack/blob/master/lib/swift#L3518:17
jrolllucasagomes: also just sent an email (and pavlo mentioned the history as well) about the configdrive thing, I'm +2 on that change18:22
lucasagomesjroll, great!18:23
*** adu has quit IRC18:25
* jroll goes back to not working, have a good weekend y'all18:26
*** adu has joined #openstack-ironic18:26
jrolloh, now that I look, this does belong in devstack18:27
*** e0ne has joined #openstack-ironic18:29
*** rpioso has joined #openstack-ironic18:29
*** aNuposic has joined #openstack-ironic18:34
*** praneshp has joined #openstack-ironic18:35
aNuposicHi Folks, I am trying to create a node using ironic node-create but want to know what shall i give as the address to this command if I am running devstack?18:36
aNuposicshould it be 127.0.0.1?18:36
*** vsaienko has quit IRC18:41
lucasagomesaNuposic, yup18:41
lucasagomesaNuposic, are you using *_ipmitool driver? If so just pay attention to the port18:42
lucasagomeswhich should match with the virtualbmc port18:42
lucasagomes(see vbmc list)18:42
aNuposiclucasagomes: I am using fake driver18:42
lucasagomesaNuposic, ah right... so I guess you don't even need an addres18:43
lucasagomesaddress*18:43
*** e0ne has quit IRC18:43
aNuposiclucasgomes:oh is it18:44
aNuposicjust username and password?18:44
aNuposiclucasgomes: or not required that too? When are these options used then?18:45
*** zackf has quit IRC18:45
aNuposiclucasgomes: I guess i need an ipmi address pointing to 127.0.0.118:46
lucasagomesaNuposic, I don't think you need anything for the fake driver18:46
* lucasagomes checks18:46
*** e0ne has joined #openstack-ironic18:47
lucasagomesaNuposic, btw, try to run "ironic driver-properties <driver name>"18:49
lucasagomesand it tells you what is required and what's not18:49
aNuposiclucasgomes:ah i see18:51
aNuposiclucasgomes: what is A1 A2, B1 and B2?18:51
aNuposicnot getting18:51
lucasagomesaNuposic, well that's the fake driver, it's used for unittests only18:52
lucasagomesso all information / properties are mocked18:52
lucasagomesit's not a real driver (as the name points out)18:52
aNuposiclucasgomes: ah hmm.18:53
openstackgerritClark Boylan proposed openstack/ironic: Support https in devstack plugin  https://review.openstack.org/37564918:53
aNuposiclucasgomes: so no address required?18:54
aNuposiclucasgomes: i was not clear from the driver-properties18:54
devananda|lunchinteresting. I'm looking at the context object on the conductor, and it does not seem to be inheriting the "user" attribute from the API service, even for commands like node-update18:56
*** devananda|lunch is now known as devananda18:56
lucasagomesaNuposic, yeah you don't need anything18:56
lucasagomesaNuposic, out of curiosity, why fake?18:56
*** mkam has joined #openstack-ironic18:56
aNuposiclucasgomes: i am just trying to test one feature18:57
aNuposiclucasgomes: but let me double check18:57
aNuposiclucasgomes: if just fake is required18:57
aNuposiclucasgomes: oops i was mistaken other nodes are using agent_ipmitool and so will use the same driver for the node i am creating18:58
aNuposiclucasgomes: my bad18:58
lucasagomesno worries18:59
openstackgerritLucas Alvares Gomes proposed openstack/ironic: DevStack: Support for creating UEFI VMs  https://review.openstack.org/37434619:00
openstackgerritLucas Alvares Gomes proposed openstack/ironic: DevStack: Configure nodes/environment to boot in UEFI mode  https://review.openstack.org/37498819:00
aNuposiclucasgomes: so now ipmi_address seems required from properties and so that would be pointing to 127.0.0.119:01
aNuposiclucasgomes: i will make sure about the port19:02
lucasagomesaNuposic, you can't use the already created nodes ? Cause adding more by hand requires a bit more things than invoking "ironic node-create"19:03
lucasagomesyou need a VM, a virtual BMC to control that VM and so on19:04
lucasagomescreate the bridge as well19:04
lucasagomes(see devstack/tools/script/create-node.sh script)19:04
lucasagomesI mean ironic/devstack/...19:04
aNuposiclucasgomes: I can use but then I need to run node-update command but with that I am not getting what type of image (qcow2,vmlinuz) are compatible with already created node19:06
aNuposiclucasgomes: hmm I see. Seems creating a node is a lengthy process19:07
lucasagomesaNuposic, right... not sure if I follow the "type of image" bits there tho19:08
aNuposiclucasgomes: i can see these details of node already created http://pastebin.com/9QZmDsi519:08
devanandathis definitely looks odd to me: http://paste.openstack.org/raw/582813/19:08
mrteniorelease19:09
devanandalucasagomes: any idea why our context is losing the "user" and "tenant" values when it goes over RPC ?19:09
lucasagomesdevananda, hmmmm def odd, no idea off the top of my head19:09
mrtenioSorry, I was trying to search for release :P19:09
devanandak. /me keeps digging19:09
aNuposiclucasgomes: I mean i need to run disk-image-create command to build the image like this "disk-image-create ubuntu baremetal localboot dhcp-all-interfaces local-config -o my-image"19:10
*** david-lyle_ has joined #openstack-ironic19:10
aNuposiclucasgomes: this gives me qcow2,vmlinux and initrd images19:11
aNuposiclucasgomes: I am just not sure are they compatible with the node already created? Do I have to care about that?19:11
lucasagomesaNuposic, tl;dr yes. But see, the .qcow is the image of the root filesystem, the .vmlinuz is the kernel and the .initrd is the initramfs19:12
lucasagomesaNuposic, take a look here: http://docs.openstack.org/developer/ironic/deploy/install-guide.html#image-requirements19:12
devanandait preserves other attributes, like "roles" , not just admin. http://paste.openstack.org/raw/582814/19:13
lucasagomesit will make more sense19:13
*** david-lyle has quit IRC19:13
lucasagomesdevananda, very odd seems everything is preserved but user & tenant, lemme take a look at the code see if I can spot something19:16
*** e0ne_ has joined #openstack-ironic19:16
*** e0ne has quit IRC19:17
devanandalucasagomes: found it19:17
devanandalucasagomes: common/context.py def from_dict19:17
devanandawe actually strip them out -- but there's no explanation why19:17
*** e0ne_ has quit IRC19:17
lucasagomesoh two pop's there19:17
lucasagomeshmm19:17
*** catintheroof has quit IRC19:17
lucasagomesdevananda, seems I've added that when porting to oslo.messaging19:18
devananda:)19:18
lucasagomesit's been a while heh 201419:18
* lucasagomes thinks19:18
*** e0ne has joined #openstack-ironic19:18
*** e0ne has quit IRC19:19
lucasagomeshttps://review.openstack.org/#/c/88307/19:19
*** e0ne_ has joined #openstack-ironic19:19
patchbotpatch 88307 - ironic - Port to oslo.messaging (MERGED)19:19
*** e0ne_ has quit IRC19:19
aNuposiclucasgomes: ah hmm. Cool so I see that the command I am running would be good with the image.19:19
devanandawow, yea, looong time ago19:20
*** e0ne has joined #openstack-ironic19:20
*** e0ne has quit IRC19:21
aNuposiclucasgomes: And add that to the image service19:21
devanandaremoving those two pops causes these tests to fail: ironic.tests.unit.common.test_context.RequestContextTestCase.test_from_dict and ironic.tests.unit.common.test_rpc.TestRequestContextSerializer.test_deserialize_context19:22
lucasagomesdevananda, i'm trying to look where I got it from, cause I remember I based the work on Nova I think19:25
lucasagomesdevananda, worth testing removing it and fixing the tests19:25
devanandayah. posting that shortly19:25
lucasagomesI don't see why anything else would break19:25
devanandaI would like to have access to that information in the conductor :)19:25
devanandaas we are adding multi-user things, knowing what user requestedthe action that the conductor is taking is ... well, important19:26
devanandawe have the token, but I can't think of any reason to _fetch_ this from keystone when we already have it19:26
devanandamariojv: I believe we should actually hide driver_internal_info from most (if not all) users19:31
lucasagomesdevananda, very important and cheap to have that information there (since we already have it at the api level)19:34
lucasagomesI don't see why not to remove those pop's at the top of my head19:34
mariojvthanks devananda, i agree, or else it's not really "internal" info and should go somewhere else imo19:37
mariojvi'm still debating myself for whether we should include sanitized driver_info in node notifications19:38
mariojv(sanitized meaning strip out sensitive credentials)19:38
lucasagomesmariojv, IMO sounds like we should remove sensitive data like passwords from the notifications19:40
mariojvsearchlight generally wants fields that are exposed via API in notifications, but i can't think of a really good use case for searching based on driver_info19:40
mariojvlucasagomes: agreed, we definitely want to sanitize things like ipmi_password before the notification goes on the wire19:41
mariojvwe may even want to remove instance_info from the notification, or at least pieces of it19:41
*** absubram has quit IRC19:41
mariojvincluding a large base64 configdrive in there seems like a very large waste19:42
openstackgerritBob Fournier proposed openstack/ironic-inspector-specs: Display LLDP information via new commands  https://review.openstack.org/37438119:42
lucasagomesmariojv, yes! We have a bug about it, I hope the configdrive will disappear from the instance_info this cycle!19:44
mariojvoh, nice19:44
lucasagomesbut yeah we should def remove it (it might contain the root password for the image, so it's a security concern as well)19:44
openstackgerritDevananda van der Veen proposed openstack/ironic: Include user and tenant in serialized context  https://review.openstack.org/37568919:44
devanandagotta run to a dr's appt -- back in a few hours19:44
*** devananda is now known as devananda|bbl19:44
mariojvok, i'll remove instance_info, too19:45
devananda|bblmariojv: "search for nodes where driver_info.ipmi_address is on the 10.200.*.* network"19:45
mariojvyeah that could be useful ^19:45
devananda|bblmariojv: "search for nodes where instance_info does not contain a config drive"19:45
devananda|bblif you give people data, they will find a use for it ;)19:46
* devananda|bbl really goes now19:46
mariojvthere's an oslo lib we use for sanitizing really sensitive fields before sending anything over the api right?19:46
* mariojv looks19:46
devananda|bblmariojv: yep19:47
lucasagomesmariojv, mask_dict_password19:47
mariojvperfect, thanks19:47
*** mkam has quit IRC19:51
*** [1]rpioso has joined #openstack-ironic19:55
*** absubram has joined #openstack-ironic19:56
*** rpioso has quit IRC19:56
*** absubram_ has joined #openstack-ironic19:57
*** joprovost has quit IRC19:59
*** sdake has quit IRC20:00
*** krtaylor has joined #openstack-ironic20:00
*** absubram has quit IRC20:01
*** absubram_ is now known as absubram20:01
vdroklucasagomes: devananda|bbl ++ those two pops seem unnecessary. I also have this one, will revive it https://review.openstack.org/29537120:02
patchbotpatch 295371 - ironic - Add user and project domains to ironic context20:02
*** ijw has quit IRC20:02
vdrokWas working OK the last time I tested20:03
devananda|bblvdrok: I see. first glance that looks good. I think I changed the way we handle show_password though, so you may want to check that that still works as you expect20:04
vdrokdevananda|bbl: yup, will check tomorrow :)20:05
lucasagomesvdrok, ++20:05
*** david-lyle_ is now known as david-lyle20:06
lucasagomesok, I'm calling it a day20:08
openstackgerritClark Boylan proposed openstack/ironic: Support https in devstack plugin  https://review.openstack.org/37564920:09
lucasagomeshave a good evening all, enjoy the weekend20:09
lucasagomestalk soon :-)20:09
*** lucasagomes is now known as lucas-afk20:09
*** absubram has quit IRC20:10
*** ijw has joined #openstack-ironic20:10
vdrokGood night lucas-afk20:10
*** ijw has quit IRC20:14
*** rajinir has quit IRC20:15
*** praneshp has quit IRC20:22
*** clenimar has quit IRC20:26
*** adu has quit IRC20:36
*** lascii is now known as alaski20:41
*** jheroux has quit IRC20:45
*** krtaylor has quit IRC20:47
*** praneshp has joined #openstack-ironic20:56
*** wajdi_ has quit IRC21:05
jlvillalRegarding: https://review.openstack.org/#/c/375467/21:07
patchbotpatch 375467 - openstack-dev/devstack - Force config drive when using ironic virt driver21:07
jlvillalAre we worried at all if that lands right now it would break the gate?21:07
*** trown is now known as trown|outtypewww21:09
openstackgerritJohn L. Villalovos proposed openstack/ironic: See if force config drive breaks the gate  https://review.openstack.org/37573221:09
aNuposiclucasgomes: I updated the node with ramdisk and kernel21:09
aNuposiclucasgomes: it was much easier21:10
jlvillalvdrok: ^^^21:10
openstackgerritClark Boylan proposed openstack/ironic: Support https in devstack plugin  https://review.openstack.org/37564921:10
jlvillalaNuposic: Isn't that what I suggested earlier? ;)21:10
jlvillalaNuposic: I think lucas-afk is gone gone gone for the weekend.21:10
jlvillalaNuposic: Glad you got it working!21:11
aNuposicjlvillal: Yeah actually. But we thought to first go with creating a new node cause I was not sure if the image I create would be compatible with the node already created21:11
aNuposici mean with the deploy kernel and deploy ramdisk21:12
jlvillalaNuposic: Okay. Well hopefully you have it all working now21:12
aNuposicjlvillal: But yeah as you both suggested it was very length process21:12
jlvillalaNuposic: Yeah :(21:12
aNuposicand so did node-uodate21:12
aNuposicjlvillal: What is the way to check node is up and running? I mean my node-validate is showing http://pastebin.com/pAi6RPtL21:13
aNuposicalso I don't see the hostname or IP to ssh into and check21:13
jlvillalaNuposic: ironic node-show   should show it21:13
jlvillalaNuposic: Looks like you need to fix the deploy info21:14
aNuposicjlvillal: hmmm it shows checksum should also be provided21:14
jlvillalaNuposic: That's what I mean21:15
aNuposicjlvillal: but not sure where to get it from21:15
aNuposic;)21:15
vdrokjlvillal: it does basically the same as dtantsur|afk patch, and it passed. But never hurts to checj21:15
jlvillalvdrok: Okay. Because dtantsur|afk's patch didn't pass.21:15
jlvillalvdrok: I thought that was because we are waiting for a fix to land.21:15
jlvillalvdrok: ironic-lib release???  I'm not sure21:15
jlvillalvdrok: Ah I see. Only the non-voting job fails.21:16
jlvillalwholedisk21:16
vdrok? I remember it did pass.. one job failed but it's non voting and the fail was expected as ironic-lib was not released yet21:16
jlvillalaNuposic: I'm not sure off the top of my head. I forget how the checksum gets generated.21:16
jlvillalvdrok: right21:17
jlvillalaNuposic: Let me take a look21:17
vdrokYeah, I'm from phone so a bit slow :)21:17
jlvillalvdrok: You should go enjoy your weekend :)21:19
*** praneshp has quit IRC21:21
*** thrash is now known as thrash|g0ne21:21
vdrokjlvillal: btw thanks for bringing up the Nova fix, it's on the way to merge already21:21
jlvillalvdrok: Yeah. Woo hoo! :)21:21
jlvillalvdrok: Thanks for fixing it!21:21
vdrok:)21:21
jlvillalaNuposic: Look here: http://docs.openstack.org/developer/ironic/deploy/install-guide.html   And search for 'checksum'21:23
aNuposicjlvillal: Ok let me have a look at it.21:24
*** praneshp has joined #openstack-ironic21:28
*** rbudden has quit IRC21:28
aNuposicjlvillal: cool i got alpha numeric hash21:28
aNuposicjlvillal: will add that to the instance_info21:29
aNuposicjlvillal: now deploy seems to be true. :) console is false, that's just fine i guess21:31
jlvillalaNuposic: I think so. You aren't using the console.21:31
aNuposicjlvillal: I am not.21:31
*** joprovost has joined #openstack-ironic21:31
aNuposicjlvillal: I should ssh login to the node after the deployment is that right?21:32
jlvillalaNuposic: I don't know. Depends on what you are trying to do.21:32
aNuposicjlvillal: ok. actually no need of ssh login. That I was going to do earlier to see if node is up and running21:38
aNuposicjlvillal: Now ready to run node-set-provision with config drive21:40
*** joprovost has quit IRC21:42
*** cdearborn has quit IRC21:45
xavierrhave a good night all22:05
xavierrsee you all on monday :)22:05
*** xavierr is now known as xavierr|afk22:05
*** rpioso has joined #openstack-ironic22:08
*** jrist has quit IRC22:08
*** [1]rpioso has quit IRC22:14
*** zackf has joined #openstack-ironic22:19
*** zackf has quit IRC22:24
jlvillalxavierr|afk: Good night22:48
*** ppiela has quit IRC23:00
*** jrist has joined #openstack-ironic23:00
*** jrist has quit IRC23:03
*** jrist has joined #openstack-ironic23:04
*** vishwanathj has quit IRC23:05
openstackgerritJohn L. Villalovos proposed openstack/ironic: See if force config drive breaks the gate  https://review.openstack.org/37573223:06
openstackgerritlinbing proposed openstack/ironic-python-agent: * Force LANGUAGE=en_US in test runs * Force the value of LC_ALL to be en_US.UTF-8  https://review.openstack.org/37576523:07
*** sdake has joined #openstack-ironic23:17
*** rama_y has quit IRC23:38
*** ijw has joined #openstack-ironic23:39
*** aNuposic has quit IRC23:39
*** rpioso has quit IRC23:43
*** ijw has quit IRC23:49
*** rbudden has joined #openstack-ironic23:58
*** rbudden has quit IRC23:58

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!