| *** yushiro has joined #openstack-ironic | 00:01 | |
| mrda | hey NobodyCam | 00:20 |
|---|---|---|
| *** amotoki has joined #openstack-ironic | 00:24 | |
| openstackgerrit | qinchunhua proposed openstack/python-ironicclient: Use ConfigParser instead of SafeConfigParser https://review.openstack.org/369838 | 00:24 |
| openstackgerrit | qinchunhua proposed openstack/python-ironicclient: Use ConfigParser instead of SafeConfigParser https://review.openstack.org/369838 | 00:25 |
| openstackgerrit | qinchunhua proposed openstack/python-ironicclient: Use ConfigParser instead of SafeConfigParser https://review.openstack.org/369838 | 00:26 |
| *** BadCub has quit IRC | 00:30 | |
| *** rloo has quit IRC | 00:32 | |
| *** hoangcx has joined #openstack-ironic | 00:46 | |
| openstackgerrit | qinchunhua proposed openstack/python-ironicclient: Use ConfigParser instead of SafeConfigParser https://review.openstack.org/369838 | 00:46 |
| *** hoangcx_ has joined #openstack-ironic | 00:48 | |
| *** hoangcx_ has quit IRC | 00:56 | |
| *** hoangcx has quit IRC | 00:56 | |
| *** hoangcx has joined #openstack-ironic | 00:58 | |
| *** phuongnh has joined #openstack-ironic | 01:05 | |
| openstackgerrit | Merged openstack/ironic: Adds a missing space in a help string https://review.openstack.org/372784 | 01:06 |
| *** ijw has quit IRC | 01:28 | |
| *** rbudden has joined #openstack-ironic | 01:37 | |
| *** syed_ has quit IRC | 01:43 | |
| *** ijw has joined #openstack-ironic | 01:45 | |
| *** rbudden has quit IRC | 01:45 | |
| *** aNuposic has joined #openstack-ironic | 01:53 | |
| *** thrash is now known as thrash|g0ne | 01:55 | |
| *** tuanla_ has joined #openstack-ironic | 01:58 | |
| *** baoli has joined #openstack-ironic | 01:58 | |
| *** tuanla_ has quit IRC | 01:58 | |
| openstackgerrit | Xu Ao proposed openstack/ironic: Make ironic console supporting the nokeepalive mode https://review.openstack.org/372830 | 01:58 |
| openstackgerrit | qinchunhua proposed openstack/python-ironicclient: Use ConfigParser instead of SafeConfigParser https://review.openstack.org/369838 | 01:59 |
| *** tuanla has joined #openstack-ironic | 01:59 | |
| openstackgerrit | qinchunhua proposed openstack/python-ironicclient: Use ConfigParser instead of SafeConfigParser https://review.openstack.org/369838 | 02:00 |
| *** Sukhdev has joined #openstack-ironic | 02:02 | |
| openstackgerrit | qinchunhua proposed openstack/python-ironicclient: Use ConfigParser instead of SafeConfigParser https://review.openstack.org/369838 | 02:02 |
| openstackgerrit | Xu Ao proposed openstack/ironic: Make ironic console supporting the nokeepalive mode https://review.openstack.org/372830 | 02:03 |
| *** Sukhdev has quit IRC | 02:04 | |
| *** sdake has quit IRC | 02:06 | |
| *** sdake has joined #openstack-ironic | 02:06 | |
| *** ChrisAusten has joined #openstack-ironic | 02:17 | |
| *** sdake has quit IRC | 02:18 | |
| *** ijw has quit IRC | 02:28 | |
| *** BadCub has joined #openstack-ironic | 02:32 | |
| *** ijw has joined #openstack-ironic | 02:37 | |
| *** ChrisAusten has quit IRC | 02:37 | |
| *** Sukhdev has joined #openstack-ironic | 02:38 | |
| *** baoli has quit IRC | 02:38 | |
| *** hpe-hj has quit IRC | 02:38 | |
| *** baoli has joined #openstack-ironic | 02:39 | |
| *** ijw has quit IRC | 02:41 | |
| *** BadCub has quit IRC | 02:44 | |
| openstackgerrit | qinchunhua proposed openstack/python-ironicclient: Use ConfigParser instead of SafeConfigParser https://review.openstack.org/369838 | 03:03 |
| *** david-lyle has quit IRC | 03:03 | |
| *** baoli has quit IRC | 03:04 | |
| *** yushiro has quit IRC | 03:25 | |
| *** syed_ has joined #openstack-ironic | 03:37 | |
| *** vikrant has joined #openstack-ironic | 03:38 | |
| openstackgerrit | John L. Villalovos proposed openstack/python-ironicclient: Use ConfigParser instead of SafeConfigParser in Python 3 https://review.openstack.org/369838 | 03:40 |
| *** aNuposic has quit IRC | 03:47 | |
| *** appu103_ has joined #openstack-ironic | 04:01 | |
| *** appu103_ is now known as aparnav | 04:01 | |
| *** BadCub has joined #openstack-ironic | 04:05 | |
| *** jcoufal has quit IRC | 04:12 | |
| *** amotoki has quit IRC | 04:21 | |
| *** BadCub has quit IRC | 04:23 | |
| *** amotoki has joined #openstack-ironic | 04:30 | |
| *** amotoki has quit IRC | 04:44 | |
| *** sdake has joined #openstack-ironic | 04:46 | |
| *** ChubYann has quit IRC | 04:47 | |
| *** jaosorior has joined #openstack-ironic | 04:55 | |
| *** ChubYann has joined #openstack-ironic | 05:02 | |
| *** vsaienko has joined #openstack-ironic | 05:08 | |
| *** jroll has quit IRC | 05:09 | |
| *** jroll has joined #openstack-ironic | 05:09 | |
| *** jroll has quit IRC | 05:09 | |
| *** jroll has joined #openstack-ironic | 05:09 | |
| *** jaosorior has quit IRC | 05:09 | |
| *** moshele has joined #openstack-ironic | 05:09 | |
| *** jaosorior has joined #openstack-ironic | 05:10 | |
| *** amotoki has joined #openstack-ironic | 05:14 | |
| *** Sukhdev has quit IRC | 05:22 | |
| *** bnemec has joined #openstack-ironic | 05:27 | |
| *** aswadr_ has joined #openstack-ironic | 05:29 | |
| openstackgerrit | Aparna proposed openstack/ironic-specs: Generic way to configure clean step priorites in Automated cleaning https://review.openstack.org/362615 | 05:31 |
| *** ChubYann has quit IRC | 05:32 | |
| *** tuanla_ has joined #openstack-ironic | 05:36 | |
| *** hoangcx_ has joined #openstack-ironic | 05:36 | |
| *** phuongnh has quit IRC | 05:37 | |
| *** hoangcx has quit IRC | 05:38 | |
| *** tuanla has quit IRC | 05:38 | |
| *** phuongnh has joined #openstack-ironic | 05:38 | |
| *** hshiina has joined #openstack-ironic | 05:43 | |
| *** mjura has joined #openstack-ironic | 05:47 | |
| *** amotoki_ has joined #openstack-ironic | 05:51 | |
| *** mjura has quit IRC | 05:54 | |
| *** mjura has joined #openstack-ironic | 05:54 | |
| *** amotoki has quit IRC | 05:54 | |
| *** ccamacho has quit IRC | 06:07 | |
| *** amotoki has joined #openstack-ironic | 06:10 | |
| *** amotoki_ has quit IRC | 06:13 | |
| pas-ha | morning Ironic | 06:15 |
| *** rbartal has joined #openstack-ironic | 06:20 | |
| *** hoangcx_ has quit IRC | 06:22 | |
| *** hoangcx has joined #openstack-ironic | 06:22 | |
| *** ccamacho has joined #openstack-ironic | 06:24 | |
| openstackgerrit | zhufl proposed openstack/ironic: Remove unnecessary setUp https://review.openstack.org/372928 | 06:26 |
| *** ppiela has quit IRC | 06:27 | |
| *** amotoki has quit IRC | 06:31 | |
| *** amotoki has joined #openstack-ironic | 06:35 | |
| *** ppiela has joined #openstack-ironic | 06:45 | |
| *** pcaruana has joined #openstack-ironic | 06:50 | |
| *** hshiina has quit IRC | 06:59 | |
| *** makowals has quit IRC | 07:06 | |
| *** makowals has joined #openstack-ironic | 07:07 | |
| *** makowals has quit IRC | 07:14 | |
| *** chlong has quit IRC | 07:14 | |
| *** rcernin has joined #openstack-ironic | 07:19 | |
| openstackgerrit | Himanshu Kumar proposed openstack/python-ironicclient: Changes in osc-plugin-ff0d897d8441a9e1.yaml for maintenance node Closes-Bug: #1619087 https://review.openstack.org/372973 | 07:23 |
| openstack | bug 1619087 in python-ironicclient "Revisit 'openstack baremetal node maintenance set|unset'" [Low,New] https://launchpad.net/bugs/1619087 - Assigned to Himanshu Kumar (singh5himanshu) | 07:23 |
| *** Romanenko_K has joined #openstack-ironic | 07:27 | |
| *** jpich has joined #openstack-ironic | 07:33 | |
| *** ohamada has joined #openstack-ironic | 07:34 | |
| *** makowals has joined #openstack-ironic | 07:38 | |
| openstackgerrit | zhangyanxian proposed openstack/ironic: Fix a typo in helper.py https://review.openstack.org/372994 | 07:39 |
| openstackgerrit | zhangyanxian proposed openstack/ironic: Fix a typo in helper.py https://review.openstack.org/372994 | 07:40 |
| openstackgerrit | Galyna Zholtkevych proposed openstack/ironic: Catch error when wrong temp_url were generated https://review.openstack.org/370875 | 07:41 |
| openstackgerrit | avnish proposed openstack/ironic-inspector: modify the home-page info with the developer documentation https://review.openstack.org/372997 | 07:41 |
| openstackgerrit | Tang Chen proposed openstack/ironic: Prepare for functional tests https://review.openstack.org/349421 | 07:47 |
| *** milan has joined #openstack-ironic | 07:58 | |
| *** zzzeek has quit IRC | 08:00 | |
| *** athomas has joined #openstack-ironic | 08:00 | |
| *** zzzeek has joined #openstack-ironic | 08:00 | |
| *** vsaienko has quit IRC | 08:05 | |
| *** vsaienko has joined #openstack-ironic | 08:10 | |
| *** pmannidi has quit IRC | 08:15 | |
| *** vsaienko has quit IRC | 08:25 | |
| *** vsaienko has joined #openstack-ironic | 08:30 | |
| milan | morning Ironic! :) | 08:32 |
| *** bradjones has quit IRC | 08:33 | |
| *** derekh has joined #openstack-ironic | 08:34 | |
| *** bradjones has joined #openstack-ironic | 08:36 | |
| *** bradjones has quit IRC | 08:36 | |
| *** bradjones has joined #openstack-ironic | 08:36 | |
| *** sambetts|afk is now known as sambetts | 08:40 | |
| sambetts | Morning all | 08:40 |
| *** Seb__ has joined #openstack-ironic | 08:42 | |
| *** Seb__ has left #openstack-ironic | 08:42 | |
| milan | morning sambetts! :) | 08:43 |
| *** seb31 has joined #openstack-ironic | 08:43 | |
| sambetts | o/ milan | 08:46 |
| *** vsaienko has quit IRC | 08:51 | |
| *** hoangcx has quit IRC | 08:52 | |
| *** hoangcx has joined #openstack-ironic | 08:52 | |
| *** electrofelix has joined #openstack-ironic | 08:52 | |
| openstackgerrit | avnish proposed openstack/bifrost: Update home page link in cfg file https://review.openstack.org/373057 | 08:55 |
| *** mgould|afk is now known as mgould | 08:59 | |
| mgould | morning Ironic! | 08:59 |
| mgould | morning sambetts milan pas-ha | 09:00 |
| milan | morning mgould! :) | 09:00 |
| openstackgerrit | Nisha Agarwal proposed openstack/ironic: SNMP agent support for OOB inspection for iLO Drivers https://review.openstack.org/372428 | 09:00 |
| *** e0ne has joined #openstack-ironic | 09:04 | |
| openstackgerrit | avnish proposed openstack/ironic-python-agent: Update home page link in cfg file https://review.openstack.org/373076 | 09:12 |
| openstackgerrit | Nisha Agarwal proposed openstack/ironic: SNMP agent support for OOB inspection for iLO Drivers https://review.openstack.org/372428 | 09:18 |
| *** syed_ has quit IRC | 09:23 | |
| *** amotoki has quit IRC | 09:24 | |
| openstackgerrit | Himanshu Kumar proposed openstack/python-ironicclient: Changes in baremetal_node.py to list all node which are in no-maintenance mode Closes-Bug: #1619090 https://review.openstack.org/373096 | 09:37 |
| openstack | bug 1619090 in python-ironicclient "[RFE] Extend OSC "node list" to fetch nodes that are NOT in maintenance" [Wishlist,Confirmed] https://launchpad.net/bugs/1619090 - Assigned to Himanshu Kumar (singh5himanshu) | 09:37 |
| *** stendulker has joined #openstack-ironic | 09:38 | |
| openstackgerrit | Merged openstack/ironic: Notification event types have status 'error' https://review.openstack.org/372578 | 09:59 |
| openstackgerrit | Lucky samadhiya proposed openstack/ironic-ui: update homepage with developer documentation page https://review.openstack.org/373125 | 10:04 |
| *** phuongnh has quit IRC | 10:05 | |
| *** amotoki has joined #openstack-ironic | 10:09 | |
| *** hoangcx has quit IRC | 10:11 | |
| *** jvgrant__ has joined #openstack-ironic | 10:13 | |
| *** jvgrant_ has quit IRC | 10:14 | |
| tangchen | morning all :) | 10:15 |
| tangchen | milan: Hi, Milan, please help to review this patch when you have time. I think I have fixed all your comments. :) https://review.openstack.org/#/c/349421 | 10:16 |
| patchbot | patch 349421 - ironic - Prepare for functional tests | 10:16 |
| tangchen | milan: Thank you very much. :) | 10:16 |
| *** amotoki has quit IRC | 10:21 | |
| *** jaosorior is now known as jaosorior_lunch | 10:37 | |
| vdrok | morning pas-ha milan sambetts mgould and tangchen ! | 10:41 |
| *** amotoki has joined #openstack-ironic | 10:42 | |
| tangchen | morning vdrok. :) | 10:44 |
| *** amotoki has quit IRC | 10:57 | |
| *** jaosorior_lunch is now known as jaosorior | 11:03 | |
| *** makowals has quit IRC | 11:05 | |
| *** thrash|g0ne is now known as thrash | 11:05 | |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Fix iLO drivers to not clear local_gb if its not detected https://review.openstack.org/341752 | 11:10 |
| mgould | morning tangchen vdrok | 11:10 |
| tangchen | morning mgould | 11:11 |
| tangchen | vdork: Hi Vladyslav, would you please help to review this patch when you have time ? https://review.openstack.org/#/c/349421/ | 11:14 |
| patchbot | patch 349421 - ironic - Prepare for functional tests | 11:14 |
| tangchen | vdrok: Thank you very much | 11:15 |
| *** stendulker has quit IRC | 11:16 | |
| openstackgerrit | Merged openstack/ironic: Grub2 by default for PXE + UEFI https://review.openstack.org/367306 | 11:20 |
| openstackgerrit | Merged openstack/ironic: Remove unnecessary setUp https://review.openstack.org/372928 | 11:20 |
| milan | tangchen, hi, on my todo list ;) | 11:23 |
| milan | morning vdrok! :) | 11:23 |
| mat128 | morning ironic | 11:24 |
| mgould | morning mat128 | 11:24 |
| milan | morning mat128! :) | 11:25 |
| tangchen | milan: Thanks. :) | 11:27 |
| openstackgerrit | Om Kumar proposed openstack/ironic: Add 10s sleep for iPXE boot. https://review.openstack.org/373194 | 11:30 |
| jroll | good morning from boston \o/ | 11:36 |
| jroll | jlvillal: rloo isn't here but I'm also +1 on just moving the install guide content first and then making it better :) | 11:37 |
| *** dprince has joined #openstack-ironic | 11:41 | |
| sambetts | o/ jroll | 11:43 |
| sambetts | jroll: I had a qq, what is the poll service you use for getting when people are and aren't free? | 11:43 |
| *** lucas-afk is now known as lucasagomes | 11:44 | |
| lucasagomes | morning all :-) | 11:44 |
| sambetts | hey lucasagomes | 11:44 |
| mgould | morning lucasagomes | 11:44 |
| jroll | sambetts: doodle | 11:44 |
| jroll | .com | 11:44 |
| sambetts | jroll: thanks! :D | 11:45 |
| jroll | np :) | 11:45 |
| *** amotoki has joined #openstack-ironic | 11:47 | |
| aparnav | hey lucasgomes, jroll. Please help me review this patch (https://review.openstack.org/#/c/370572) . It has minor requirement changes. | 11:48 |
| patchbot | patch 370572 - ironic - Update proliantutils version required for Newton r... | 11:48 |
| *** bfournie has quit IRC | 11:51 | |
| jroll | aparnav: +2, sambetts wanna land that? | 11:51 |
| *** trown|outtypewww is now known as trown | 11:52 | |
| sambetts | aparnav, jroll: is there HP CI that I should be looking at for this? | 11:52 |
| jroll | sambetts: good question, I think it's in maintenance | 11:52 |
| * jroll needs to ask about that again | 11:52 | |
| *** bfournie has joined #openstack-ironic | 11:55 | |
| vdrok | morning jroll and lucasagomes | 11:58 |
| vdrok | tangchen: will do today | 11:58 |
| jroll | hey vdrok :) | 11:58 |
| tangchen | vdork: Thanks. :) | 12:00 |
| aparnav | sambetts, jroll, since it is the minor requirement changess should HP CI should be checked for? | 12:00 |
| jroll | aparnav: it's got a bunch of +1 from ilo folks, and the CI is in maintenance | 12:01 |
| jroll | I think it's fine | 12:01 |
| aparnav | jroll, thank you :) | 12:01 |
| *** ccamacho is now known as ccamacho|lunch | 12:04 | |
| *** rbudden has joined #openstack-ironic | 12:04 | |
| *** tuanla_ has quit IRC | 12:07 | |
| *** amotoki has quit IRC | 12:08 | |
| *** amotoki has joined #openstack-ironic | 12:09 | |
| *** baoli has joined #openstack-ironic | 12:10 | |
| *** baoli_ has joined #openstack-ironic | 12:11 | |
| *** baoli has quit IRC | 12:15 | |
| *** xavierr|afk is now known as xavierr | 12:15 | |
| xavierr | good morning Ironic | 12:16 |
| xavierr | morning lucasagomes sambetts mgould aparnav jroll vdrok :D | 12:16 |
| *** hshiina has joined #openstack-ironic | 12:16 | |
| vdrok | morning xavierr | 12:17 |
| lucasagomes | xavierr, vdrok hi there | 12:17 |
| *** jcoufal has joined #openstack-ironic | 12:18 | |
| openstackgerrit | Galyna Zholtkevych proposed openstack/ironic: Catch error when wrong temp_url were generated https://review.openstack.org/370875 | 12:21 |
| jroll | \o xavierr | 12:21 |
| lucasagomes | apparently the UEFI support for cirros was added in 21/07/2016 https://code.launchpad.net/~hrw/cirros/add-uefi-grub-support/+merge/299185 | 12:23 |
| lucasagomes | but the images we use is from may 2015 (version 0.3.4) | 12:24 |
| lucasagomes | I mean in gate | 12:24 |
| mat128 | you can always set CIRROS_VERSION | 12:24 |
| mat128 | in devstack | 12:25 |
| lucasagomes | yeah, but apparently they didn't release any version with that support included http://download.cirros-cloud.net/ | 12:25 |
| lucasagomes | it's in the daily/<date> folder tho | 12:25 |
| lucasagomes | http://download.cirros-cloud.net/daily/20160721/ should support UEFI | 12:25 |
| jroll | probably time to ask scott moser for a release :) | 12:25 |
| lucasagomes | I will test it, I'm rebuilding my ubuntu xenial env | 12:25 |
| lucasagomes | jroll, yeah totally | 12:25 |
| * mat128 checks cirros bug tracker, sees "bonding module is missed on cirros-0.3.4-x86_64-disk.img" | 12:27 | |
| mat128 | very interested, only to find out it has been opened by vsaienk0 :P | 12:27 |
| mat128 | it's a small world, really | 12:27 |
| *** bfournie has joined #openstack-ironic | 12:27 | |
| *** bfournie has quit IRC | 12:27 | |
| lucasagomes | :D | 12:27 |
| jroll | oops, almost forgot about this https://review.openstack.org/#/c/352991/4 | 12:31 |
| patchbot | patch 352991 - ironic - Deprecate ClusteredComputeManager | 12:31 |
| jroll | let's merge that before we release :) | 12:31 |
| lucasagomes | jroll, burn it with fire! | 12:32 |
| lucasagomes | +2 :-) | 12:32 |
| jroll | :D | 12:32 |
| *** bfournie has joined #openstack-ironic | 12:33 | |
| *** bfournie has quit IRC | 12:33 | |
| *** vsaienko has joined #openstack-ironic | 12:34 | |
| *** krtaylor has joined #openstack-ironic | 12:36 | |
| lucasagomes | https://bugs.launchpad.net/ironic/+bug/1625616 | 12:38 |
| openstack | Launchpad bug 1625616 in Ironic "[RFE] Support for UEFI deployment in DevStack / Gate tests for UEFI deployments" [Wishlist,New] - Assigned to Lucas Alvares Gomes (lucasagomes) | 12:38 |
| lucasagomes | jroll, ^ not sure if it's needed, but there you go | 12:38 |
| jroll | lucasagomes: thanks, can't hurt. approved | 12:42 |
| openstackgerrit | Charlle Daniel Da Silva Vieira Dias proposed openstack/ironic: Adds to the documentation a note about the state changing of a node by Ironic https://review.openstack.org/372735 | 12:42 |
| lucasagomes | cheers | 12:42 |
| openstackgerrit | Jim Rollenhagen proposed openstack/ironic: Add docs for node.resource_class and flavor creation https://review.openstack.org/345081 | 12:45 |
| *** rloo has joined #openstack-ironic | 12:48 | |
| openstackgerrit | Jim Rollenhagen proposed openstack/ironic: Add a note about security groups in install guide https://review.openstack.org/369385 | 12:50 |
| rloo | hi and morning! | 12:53 |
| *** Goneri has joined #openstack-ironic | 12:53 | |
| rloo | jroll: why 'anticipate...' ? cuz newton hasn't been cut yet? https://review.openstack.org/#/c/352991/4/releasenotes/notes/deprecate-clustered-compute-manager-3dd68557446bcc5c.yaml | 12:53 |
| patchbot | patch 352991 - ironic - Deprecate ClusteredComputeManager | 12:53 |
| jroll | rloo: yes | 12:53 |
| jroll | deva and I already went back and forth on that :) | 12:53 |
| *** aparnav has quit IRC | 12:54 | |
| rloo | jroll: it reads funny, but we can always change it again before our release. | 12:54 |
| jroll | rloo: well, our release is this week, newton final for nova is next week | 12:54 |
| *** ccamacho|lunch is now known as ccamacho | 12:56 | |
| openstackgerrit | Charlle Daniel Da Silva Vieira Dias proposed openstack/ironic: Implement the validation to verify if the node is free or in use by Ironic https://review.openstack.org/372762 | 12:56 |
| *** david-lyle has joined #openstack-ironic | 12:56 | |
| *** vishwanathj has joined #openstack-ironic | 12:57 | |
| rloo | jroll: i thought nova had a rc1 out. | 12:57 |
| rloo | jroll: anyway, +2 +a'd | 12:57 |
| jroll | rloo: they do have an rc1, but not a final :) | 12:57 |
| jroll | so now my confidence is 99.9% | 12:57 |
| jroll | but still can't predict the future | 12:58 |
| jroll | thanks for the +A :) | 12:58 |
| rloo | jroll: exactly. actually, 99.99! | 12:58 |
| rloo | jroll: we can always backport/update the release notes? | 12:58 |
| jroll | rloo: I guess / think so | 12:58 |
| jroll | I think it's fine as-is | 12:58 |
| *** ricardoas has joined #openstack-ironic | 12:58 | |
| jroll | someone interested will see it in the nova rel notes | 12:58 |
| rloo | jroll: i don't really care that much, just worried that it might be confusing. i mean, there/we ought to be able to coordinate things with other projects better than this. | 12:59 |
| jroll | rloo: check patch set 1, I agree :) | 12:59 |
| jroll | er, ps3 | 12:59 |
| jroll | deva's comment, specifically | 13:00 |
| *** vikrant has quit IRC | 13:00 | |
| rloo | jroll: so did deva want you to change the help string too? it is only in the release notes that it says that; the help string indicates that it is in there. | 13:01 |
| rloo | jroll: anyway, i disagree with deva there. I mean, even with our release notes, *nothing* has been released yet but we write them as if the feature is in. | 13:02 |
| rloo | jroll: regardless, we can discuss later or not. i see other patches from you :) | 13:02 |
| jroll | rloo: idk, maybe he did, I also would rather put "is released" | 13:03 |
| jroll | can change quickly | 13:03 |
| rloo | jroll: nay, you're going to have to review all the release notes anyway, can do it then. | 13:03 |
| vdrok | morning rloo and mat128 | 13:03 |
| jroll | ooo. good point :( | 13:04 |
| jroll | I should start on that | 13:04 |
| rloo | hi vdrok | 13:04 |
| *** cdearborn has joined #openstack-ironic | 13:08 | |
| *** jaosorior has quit IRC | 13:09 | |
| *** jaosorior has joined #openstack-ironic | 13:10 | |
| *** mgoddard__ has joined #openstack-ironic | 13:13 | |
| *** mkam has joined #openstack-ironic | 13:15 | |
| openstackgerrit | Michael Turek proposed openstack/ironic: Enable POWER systems to use pxe-ipmi driver https://review.openstack.org/185987 | 13:16 |
| *** mgoddard_ has quit IRC | 13:17 | |
| *** sdake has quit IRC | 13:17 | |
| *** mkam has quit IRC | 13:20 | |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: Add IRONIC_TEST_NETWORK_NAME devstack plugin var https://review.openstack.org/338117 | 13:26 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: Switch to Neutron Flat network. https://review.openstack.org/340695 | 13:26 |
| *** sambetts is now known as Tehsmash | 13:32 | |
| *** Tehsmash is now known as sambetts | 13:32 | |
| *** mkam has joined #openstack-ironic | 13:33 | |
| *** baoli_ has quit IRC | 13:34 | |
| openstackgerrit | Vladyslav Drok proposed openstack/ironic: Change the logic of selecting image for tests https://review.openstack.org/329625 | 13:35 |
| xavierr | jroll: our final newton release will be this week or the RC? | 13:35 |
| *** openstackstatus has joined #openstack-ironic | 13:36 | |
| *** ChanServ sets mode: +v openstackstatus | 13:36 | |
| JayF | xavierr: we don't do RCs | 13:36 |
| JayF | xavierr: we'll release 6.2.0 hopefully this week, and if needed, do a 6.2.1/6.2.2/6.2.3 etc | 13:36 |
| jroll | ^ | 13:36 |
| xavierr | oh, thanks JayF | 13:36 |
| openstackgerrit | Kyrylo Romanenko proposed openstack/ironic: [WIP] Test ML2 Fail-Fast feature https://review.openstack.org/370016 | 13:36 |
| *** r-daneel has joined #openstack-ironic | 13:38 | |
| *** joprovost has joined #openstack-ironic | 13:40 | |
| -openstackstatus- NOTICE: OpenStack Infra now has a Twitter bot, follow it at https://twitter.com/openstackinfra | 13:43 | |
| *** appu103_ has joined #openstack-ironic | 13:45 | |
| vdrok | morning JayF | 13:46 |
| *** hamzy has quit IRC | 13:47 | |
| JayF | o/ | 13:47 |
| *** sdake has joined #openstack-ironic | 13:49 | |
| *** rajinir has joined #openstack-ironic | 13:54 | |
| openstackgerrit | Hugo Nicodemos proposed openstack/python-oneviewclient: Add URL of the resource in exception message https://review.openstack.org/373347 | 13:55 |
| *** mgoddard__ has quit IRC | 13:56 | |
| *** mgoddard has joined #openstack-ironic | 13:57 | |
| *** amotoki has quit IRC | 14:03 | |
| openstackgerrit | Vladyslav Drok proposed openstack/ironic: Change the logic of selecting image for tests https://review.openstack.org/329625 | 14:03 |
| openstackgerrit | Jim Rollenhagen proposed openstack/ironic: Clean up release notes for 6.2.0 https://review.openstack.org/373357 | 14:06 |
| jroll | wheeeeee | 14:06 |
| * jroll marks wip to wait for a couple other things | 14:07 | |
| openstackgerrit | Xavier proposed openstack/ironic: OneView driver docs explaining hardware inspection https://review.openstack.org/369737 | 14:08 |
| xavierr | ^^ thank you rloo :) | 14:08 |
| rloo | jroll: wrt https://review.openstack.org/#/c/345081/, do you know if the resource class read/store stuff got done in nova for newton? | 14:09 |
| patchbot | patch 345081 - ironic - Add docs for node.resource_class and flavor creation | 14:09 |
| *** sdake_ has joined #openstack-ironic | 14:09 | |
| rloo | xavierr: yw, will look after jenkins | 14:09 |
| xavierr | o/ | 14:10 |
| JayF | rloo: https://github.com/openstack/nova/blob/master/nova/virt/ironic/driver.py#L329 | 14:10 |
| JayF | rloo: looks like it | 14:10 |
| JayF | rloo: which matches my memory | 14:10 |
| *** sdake has quit IRC | 14:11 | |
| rloo | JayF: thx! | 14:11 |
| jroll | we still need to make sure the resource tracker does something with that, but I think it did get done | 14:12 |
| jroll | hm, maybe it did not? | 14:13 |
| jroll | rloo: I guess it did not | 14:15 |
| rloo | jroll: it doesn't matter does it? I mean, wrt your doc. it just sez 'It's expected that the Newton release... will read and store information about this field'... | 14:16 |
| rloo | jroll: which is what that code snippet presumably does. You wanted the info to be in nova's db, right? | 14:16 |
| jroll | rloo: it isn't stored in nova's db in newton | 14:17 |
| rloo | jroll: it isn't? crap. | 14:17 |
| jroll | rloo: ya, I'll figure things out | 14:17 |
| rloo | jroll: if it isn't, then I don't think we should mention resource classes yet. | 14:17 |
| jroll | rloo: I think we should mention it, maybe hedge on the timeline a bit | 14:18 |
| jroll | rloo: need to work it out with nova folks exactly what that means | 14:18 |
| rloo | i don't think so. people may think if they specify the resource class, it'll get saved in nova's db. | 14:18 |
| jroll | rloo: well... we might need to change wording and such here | 14:19 |
| *** rloo has quit IRC | 14:19 | |
| *** rloo has joined #openstack-ironic | 14:20 | |
| rloo | jroll: i mean, you have 'it is expected blah blah' but if they aren't saving it, they could also not do anything wrt resource classes. | 14:20 |
| *** bfournie has joined #openstack-ironic | 14:20 | |
| rloo | jroll: we can't predict the future. so why talk about something we aren't sure will actually happen. | 14:20 |
| jroll | rloo: right, I need to talk with nova folks more and figure out how we document this | 14:20 |
| jroll | it *is* happening | 14:20 |
| jroll | need to step away, bbiab | 14:21 |
| rloo | jroll: ok | 14:21 |
| xavierr | vdrok: could you look at this patch when you have some time free? https://review.openstack.org/#/c/367065/ | 14:24 |
| patchbot | patch 367065 - ironic - Add inspection feature for the OneView drivers | 14:24 |
| xavierr | :) | 14:24 |
| vdrok | xavierr: yup, will do in a bit | 14:24 |
| xavierr | ty!! | 14:25 |
| *** moshele has quit IRC | 14:25 | |
| openstackgerrit | Merged openstack/ironic: Deprecate ClusteredComputeManager https://review.openstack.org/352991 | 14:30 |
| *** hj-hpe has joined #openstack-ironic | 14:31 | |
| *** hamzy has joined #openstack-ironic | 14:33 | |
| lucasagomes | confirmed the latest (not released) cirros image works with EFI http://paste.openstack.org/show/582250/ | 14:35 |
| lucasagomes | mat128, ^ | 14:35 |
| lucasagomes | bumped into some problems tho, apprently the virtio disk controller does not work, I had to change to IDE | 14:35 |
| lucasagomes | and then it booted | 14:35 |
| *** baoli has joined #openstack-ironic | 14:36 | |
| mat128 | nice | 14:40 |
| xavierr | hey mat128 o/ | 14:40 |
| mat128 | lucasagomes: weird about the virtio disk controller | 14:40 |
| *** syed_ has joined #openstack-ironic | 14:40 | |
| mat128 | lucasagomes: I would report it before smoser releases | 14:40 |
| mat128 | o/ xavierr | 14:41 |
| lucasagomes | mat128, yeah, https://lime-technology.com/forum/index.php?topic=39493.0 | 14:41 |
| lucasagomes | mat128, tho I found it by testing locally, now I'm googling to see if someone is talking about it | 14:41 |
| lucasagomes | mat128, I don't think it's an image problem | 14:41 |
| mat128 | lucasagomes: oh, that seems more like a QEMU bug than CirrOS | 14:41 |
| lucasagomes | I think it's the edk2 | 14:41 |
| mat128 | yeah | 14:41 |
| mat128 | lucasagomes: Not sure if it booted, but look at this guy's command line: https://gist.github.com/Manouchehri/2b1b523eed834f295915 | 14:42 |
| rloo | lucasagomes: wrt https://review.openstack.org/#/c/346896/. doesn't that fix a bug? the 'timing' option for vendorpassthru? does it need a bug/release note? | 14:43 |
| patchbot | patch 346896 - ironic - Refactor common checks when instantiating the ipmi... | 14:43 |
| mat128 | lucasagomes: did you have to install edk2 manually? https://fedoraproject.org/wiki/Using_UEFI_with_QEMU | 14:43 |
| lucasagomes | mat128, will take a look, in our case I'm modifying the libvirt XML for our domains | 14:43 |
| rloo | lucasagomes: good news about cirros :) | 14:44 |
| lucasagomes | mat128, no fedora 24 and ubuntu xenial have it packaged | 14:44 |
| lucasagomes | mat128, sudo dnf install edk2-ovmf / sudo apt-get install ovmf | 14:44 |
| lucasagomes | rloo, hmm maybe ? It was more like a refactor so I didn't open a bug | 14:44 |
| lucasagomes | rloo, it just gets rid of duplicated code | 14:45 |
| rloo | lucasagomes: that thing about vendorpassthru, timing though. do we think that will cause a change in behaviour for existing clusters? | 14:45 |
| rloo | lucasagomes: probably not? | 14:45 |
| lucasagomes | rloo, I don't think it will, cause fortunately we uses the ipmitool vendor passthru interface when the "power" interface is also ipmitool | 14:47 |
| lucasagomes | rloo, so the timing check will be performed by the power interface | 14:47 |
| rloo | lucasagomes: ok, then it is fine. | 14:47 |
| lucasagomes | rloo, but if needed I can open a quick bug | 14:48 |
| openstackgerrit | Kyrylo Romanenko proposed openstack/ironic: 'updated_at' field value after node is updated https://review.openstack.org/371605 | 14:51 |
| jroll | rloo: so sounds like the resource class thing is still the plan - it will fall back to old scheduling methods until the (code landing in ocata) populates the database | 14:56 |
| rloo | jroll: so in newton, *nothing* is done with the resource_class. | 14:57 |
| rloo | jroll: but you want to document this as part of newton, to have operators start populating resource_class, so that when (ocata?) nova 1. saves the info and 2. uses the info, it'll be available. | 14:58 |
| jroll | rloo: right, yep | 14:59 |
| rloo | and we are now hoping that 1 & 2 are in ocata. | 14:59 |
| jroll | yes | 14:59 |
| rloo | big sigh. | 14:59 |
| *** mgoddard has quit IRC | 15:01 | |
| *** mgoddard has joined #openstack-ironic | 15:02 | |
| *** mjura has quit IRC | 15:02 | |
| *** appu103_ has quit IRC | 15:04 | |
| *** appu103_ has joined #openstack-ironic | 15:05 | |
| openstackgerrit | Kyrylo Romanenko proposed openstack/python-ironicclient: Add basic tests for OSC plugin baremetal driver commands https://review.openstack.org/367359 | 15:10 |
| openstackgerrit | Merged openstack/ironic-inspector: modify the home-page info with the developer documentation https://review.openstack.org/372997 | 15:13 |
| *** rama_y has joined #openstack-ironic | 15:15 | |
| *** bdeschenes has joined #openstack-ironic | 15:17 | |
| *** appu103_ has quit IRC | 15:18 | |
| *** moshele has joined #openstack-ironic | 15:18 | |
| *** lucasagomes is now known as lucas-hungry | 15:21 | |
| *** aNuposic has joined #openstack-ironic | 15:22 | |
| openstackgerrit | Mathieu Mitchell proposed openstack/ironic: [install-guide] Import "Local boot with partition images" https://review.openstack.org/369776 | 15:22 |
| openstackgerrit | Mathieu Mitchell proposed openstack/ironic: [install-guide] Import "Flavor creation" https://review.openstack.org/369761 | 15:22 |
| openstackgerrit | Mathieu Mitchell proposed openstack/ironic: [install-guide] Import "Enrollment" and "Troubleshooting" sections https://review.openstack.org/369777 | 15:22 |
| openstackgerrit | Mathieu Mitchell proposed openstack/ironic: Add link to new guide in old install guide https://review.openstack.org/369802 | 15:22 |
| openstackgerrit | Mathieu Mitchell proposed openstack/ironic: [install-guide] Import Install and configure sections https://review.openstack.org/367988 | 15:22 |
| openstackgerrit | Mathieu Mitchell proposed openstack/ironic: [install-guide] Import "Building or downloading a deploy ramdisk image" https://review.openstack.org/369800 | 15:22 |
| openstackgerrit | Mathieu Mitchell proposed openstack/ironic: [install-guide] Import "Trusted boot with partition image" https://review.openstack.org/369801 | 15:22 |
| openstackgerrit | Mathieu Mitchell proposed openstack/ironic: [install-guide] Import "Bare Metal service overview" https://review.openstack.org/366329 | 15:22 |
| openstackgerrit | Mathieu Mitchell proposed openstack/ironic: [install-guide] Import configdrive https://review.openstack.org/369798 | 15:22 |
| openstackgerrit | Mathieu Mitchell proposed openstack/ironic: [install-guide] Import "Image requirements" https://review.openstack.org/369754 | 15:22 |
| openstackgerrit | Mathieu Mitchell proposed openstack/ironic: [install-guide] Import "Appending kernel parameters to boot instances" https://review.openstack.org/369799 | 15:22 |
| openstackgerrit | Mathieu Mitchell proposed openstack/ironic: [install-guide] Import "integration with other OpenStack components" https://review.openstack.org/369510 | 15:22 |
| openstackgerrit | Mathieu Mitchell proposed openstack/ironic: [install-guide] Import HTTPS, standalone and root device hints https://review.openstack.org/369797 | 15:22 |
| *** ChubYann has joined #openstack-ironic | 15:22 | |
| openstackgerrit | Vladyslav Drok proposed openstack/ironic: Change the logic of selecting image for tests https://review.openstack.org/329625 | 15:24 |
| mat128 | rloo, jlvillal: ^ fixed, and adjusted the following commits for the same "has been moved" wording | 15:24 |
| rloo | mat128: thx! let's see how many we can land today :) | 15:25 |
| mat128 | :D | 15:25 |
| vdrok | oh wow, I'll take a look at those too. | 15:26 |
| rloo | jroll: is there an api meeting today? | 15:27 |
| jroll | rloo: yeah, we planned to | 15:29 |
| jroll | I'm happy to push that off but I think devananda had some stuff done for it | 15:29 |
| rloo | jroll: ok, i'll plan on it then. | 15:30 |
| mariojv | rloo: for L247 here: https://review.openstack.org/#/c/321865/30/doc/source/dev/notifications.rst what would you think about something like "power_state_changed" to indicate if ironic updated the node in the DB based off the baremetal node's power state? | 15:32 |
| patchbot | patch 321865 - ironic - Add power state change notifications | 15:32 |
| mariojv | as a boolean | 15:32 |
| mariojv | instead of the current "power_updated" name | 15:33 |
| rloo | mariojv: oh, i forgot to think about it. there are 3? different cases, right? | 15:33 |
| mariojv | rloo: only 2? the power either changed on the baremetal node or it didn't | 15:34 |
| rloo | mariojv: look at my comments in notification_utils.py | 15:34 |
| rloo | mariojv: no, not that file. sec. | 15:34 |
| rloo | mariojv: manager.py | 15:34 |
| rloo | mariojv: https://review.openstack.org/#/c/321865/30/ironic/conductor/manager.py | 15:34 |
| patchbot | patch 321865 - ironic - Add power state change notifications | 15:35 |
| mariojv | rloo: you mean the comment about when an action is actually taken against the node to change its power? | 15:35 |
| rloo | mariojv: line 2567 | 15:35 |
| mariojv | yeah, so that will emit a series of baremetal.node.power_set notifications | 15:35 |
| mariojv | in utils.node_power_action | 15:35 |
| rloo | mariojv: even though it is being sync'd... | 15:35 |
| mariojv | right | 15:36 |
| rloo | mariojv: maybe we need to define with 'sync' means | 15:36 |
| mariojv | so syncing the baremetal power state with ironic's model of the node is a separate operation from setting the power | 15:36 |
| mariojv | i chose "sync" originally b/c this happens during that operation, but maybe a different name would be better | 15:37 |
| rloo | mariojv: it is just that the notification 'sync' is a diff sync from the conductor's 'sync'. | 15:37 |
| rloo | mariojv: and it would be easy for people to think it is the same thing. which is what i thought. | 15:38 |
| mariojv | what if we called it baremetal.node.power_state_updated? | 15:38 |
| rloo | mariojv: that might be better. give me a few minutes to swap context so i can recall this stuff... | 15:38 |
| mariojv | then i think it'd also make sense to put it in that other place you found during the node verify where ironic detects the power state changed on the node | 15:39 |
| openstackgerrit | Michael Turek proposed openstack/ironic: Enable POWER systems to use pxe-ipmi driver https://review.openstack.org/185987 | 15:39 |
| mariojv | cool, thanks | 15:39 |
| *** BadCub has joined #openstack-ironic | 15:40 | |
| *** krtaylor has quit IRC | 15:40 | |
| *** fxpester has quit IRC | 15:40 | |
| *** jaosorior has quit IRC | 15:40 | |
| *** dprince has quit IRC | 15:42 | |
| rloo | mariojv: so those notifications are to indicate that the HW power_state is diff from what the node thinks and that we just did 1. node None->hw power state or 2. node power state1 -> hw power state. | 15:45 |
| JayF | mat128: can you fix the thing real quick in 366329 that vdrok pointed out? If so I'll +2 it (once I finish rendering it and make sure it looks good in my vm) | 15:45 |
| mat128 | JayF: I'll do it right now, btw, the gate builds the docs now | 15:46 |
| rloo | mariojv: so 'sync' would work if we say we are setting/sync'ing the node's power state to the actual power state on the hw. | 15:46 |
| mat128 | ahh, not done | 15:46 |
| mat128 | got it | 15:46 |
| mariojv | rloo: right | 15:46 |
| rloo | mariojv: the other verbs might be 'reset' (set it to hw power state), or 'adjust' but not so keen on 'adjust' | 15:46 |
| rloo | mariojv: i don't think 'update' is good. too general. | 15:46 |
| mariojv | hm | 15:47 |
| *** rbartal has quit IRC | 15:47 | |
| rloo | mariojv: and then in the notification itself, i think we want to provide info so they know if it went from None -> power state, or powerstate1 -> powerstate? | 15:47 |
| mariojv | ok, so let's keep "sync" for the actual power state sync. not sure what to name it for the verify update | 15:47 |
| openstackgerrit | Mathieu Mitchell proposed openstack/ironic: [install-guide] Import "Local boot with partition images" https://review.openstack.org/369776 | 15:47 |
| openstackgerrit | Mathieu Mitchell proposed openstack/ironic: [install-guide] Import "Flavor creation" https://review.openstack.org/369761 | 15:47 |
| openstackgerrit | Mathieu Mitchell proposed openstack/ironic: [install-guide] Import "Enrollment" and "Troubleshooting" sections https://review.openstack.org/369777 | 15:47 |
| openstackgerrit | Mathieu Mitchell proposed openstack/ironic: Add link to new guide in old install guide https://review.openstack.org/369802 | 15:47 |
| openstackgerrit | Mathieu Mitchell proposed openstack/ironic: [install-guide] Import Install and configure sections https://review.openstack.org/367988 | 15:47 |
| openstackgerrit | Mathieu Mitchell proposed openstack/ironic: [install-guide] Import "Building or downloading a deploy ramdisk image" https://review.openstack.org/369800 | 15:47 |
| openstackgerrit | Mathieu Mitchell proposed openstack/ironic: [install-guide] Import "Trusted boot with partition image" https://review.openstack.org/369801 | 15:47 |
| openstackgerrit | Mathieu Mitchell proposed openstack/ironic: [install-guide] Import "Bare Metal service overview" https://review.openstack.org/366329 | 15:47 |
| openstackgerrit | Mathieu Mitchell proposed openstack/ironic: [install-guide] Import configdrive https://review.openstack.org/369798 | 15:47 |
| openstackgerrit | Mathieu Mitchell proposed openstack/ironic: [install-guide] Import "Image requirements" https://review.openstack.org/369754 | 15:47 |
| openstackgerrit | Mathieu Mitchell proposed openstack/ironic: [install-guide] Import "Appending kernel parameters to boot instances" https://review.openstack.org/369799 | 15:47 |
| openstackgerrit | Mathieu Mitchell proposed openstack/ironic: [install-guide] Import "integration with other OpenStack components" https://review.openstack.org/369510 | 15:47 |
| openstackgerrit | Mathieu Mitchell proposed openstack/ironic: [install-guide] Import HTTPS, standalone and root device hints https://review.openstack.org/369797 | 15:47 |
| mat128 | JayF, vdrok^done | 15:47 |
| rloo | mariojv: what verify update? | 15:47 |
| mariojv | rloo: yeah, maybe we have "previous_power_state" in there indicating whatever was in the DB? | 15:47 |
| mariojv | 1 sec | 15:48 |
| mariojv | rloo: L970 on patch set 28 here: https://review.openstack.org/#/c/321865/28..30/ironic/conductor/manager.py | 15:48 |
| patchbot | patch 321865 - ironic - Add power state change notifications | 15:48 |
| *** derekh has quit IRC | 15:49 | |
| mariojv | there's a potential power state change on the node there | 15:49 |
| *** MattMan has quit IRC | 15:49 | |
| *** MattMan has joined #openstack-ironic | 15:49 | |
| rloo | mariojv: i forgot about that. need to look at code to remember what is going on. | 15:50 |
| rloo | mariojv: that is a sync | 15:50 |
| rloo | mariojv: although i think it would be (the code i mean) more accurate if it checked whether the power states were the same before setting it. | 15:52 |
| mariojv | ok, cool | 15:52 |
| mariojv | so, keep the notification in some form, but send it iff the node power state changed? | 15:53 |
| rloo | mariojv: in that case, you only want to emit the sync if the power state changed. (most likely from None -> hw power state but...) | 15:53 |
| rloo | mariojv: yup | 15:53 |
| mariojv | sure | 15:53 |
| mariojv | ok, and if getting the power fails, i think we should also send .error | 15:53 |
| rloo | mariojv: if the payload has the node info, do we need to add another field that has the target power? or is the original power state sufficient? | 15:54 |
| rloo | mariojv: no, i don't think we should send .error in that case. | 15:54 |
| rloo | mariojv: cuz it is trying to validate that it can talk to the node. | 15:54 |
| mariojv | i'm fine with that | 15:54 |
| mariojv | so for the target_power_state, that's going to change w/ my next update a bit because i'm having these notifications subclass from a NodePayload that has pretty much all the fields on the node except a couple | 15:55 |
| rloo | mariojv: if you look at the sync code, you'll see that if it cannot talk to the node, it just stops trying to sync. | 15:55 |
| mariojv | so adding previous_power_state on top of that to the sync notification will include enough info to reconstruct how the nod changed | 15:55 |
| mariojv | rloo: oh, ok. might be useful in some other fashion, but not for tracking the power state at that point | 15:56 |
| mariojv | rloo: but for target_power_state when you're setting power, it's a bit weird | 15:56 |
| rloo | mariojv: right. what i'm not sure of, is whether one adds relevant info related to the notificaiton, on top of the node's basic info, even if it is the same. i'm guessing it isn't worth doing. | 15:56 |
| mariojv | we send out the notification before the target_power_state is actually set on the node object, so it's useful to send a separate field indicating what target_power_state will be set to | 15:56 |
| rloo | mariojv: so if the notification is emitted *after* the node is updated, then only the original power state is useful. | 15:57 |
| mariojv | right, so we can just have nullable fields wherever | 15:57 |
| rloo | mariojv: oh, we're talking about power_set now? | 15:57 |
| *** dprince has joined #openstack-ironic | 15:58 | |
| mariojv | sorry, on bad wifi so keep getting dc'ed from bouncer | 15:59 |
| mariojv | rloo: so for power_sync, no additional fields except what's in NodePayload are needed, since the power state is already set on the node when we would send it | 15:59 |
| mariojv | https://review.openstack.org/#/c/321865/28..30/ironic/conductor/manager.py | 15:59 |
| patchbot | patch 321865 - ironic - Add power state change notifications | 15:59 |
| mariojv | see L2585 on patch set 30 there. the power state was already updated on the node, so it'll automatically be in the notification | 15:59 |
| rloo | mariojv: but the payload object is the same for .start, .end, .error, right? | 16:00 |
| rloo | mariojv: so maybe just to be safe, we should emit from_power, to_power in all cases? | 16:00 |
| mariojv | rloo: but for power_set, the baremetal.node.power_set.start notification is sent *prior* to setting the target state https://review.openstack.org/#/c/321865/30/ironic/conductor/utils.py | 16:00 |
| patchbot | patch 321865 - ironic - Add power state change notifications | 16:00 |
| mariojv | because it can fail out while getting the power state to see what change is necessary, if any | 16:01 |
| mariojv | rloo: i like "to_power", that's a good name | 16:01 |
| mariojv | rloo: i don't think "from_power" is really needed for baremetal.node.power_set.start | 16:01 |
| mariojv | "from_power" would just be the node's current power state | 16:02 |
| *** jheroux has joined #openstack-ironic | 16:02 | |
| mariojv | which will be filled in automatically, once we're having a NodePayload with all the node fields on it | 16:02 |
| rloo | mariojv: the only time from_power won't be avail is in the .end I think? | 16:02 |
| mariojv | rloo: we can make it available, just keep it in a var somewhere | 16:03 |
| rloo | mariojv: but since it is in .start, it is OK for whatever is getting the notifications to keep track/get it from the .start? | 16:03 |
| mariojv | rloo: right, you can't have .end w/o .start | 16:03 |
| mariojv | i just thought it'd be kind of redundant in .start, with the new NodePayload | 16:03 |
| rloo | mariojv: so it might be ok not to have from _power. if someone complains, we can add it later i guess and up the payload version or whatever. | 16:03 |
| mariojv | sure, sounds good | 16:03 |
| rloo | mariojv: please note, i have no usecase myself for notifications :) | 16:04 |
| *** jcoufal_ has joined #openstack-ironic | 16:04 | |
| mariojv | no worries, i think these are all good improvements | 16:04 |
| *** rbrud has joined #openstack-ironic | 16:05 | |
| *** aNuposic has quit IRC | 16:06 | |
| *** jcoufal has quit IRC | 16:08 | |
| mariojv | rloo: so i ought to: only send out baremetal.node.power_sync.success when the baremetal power change is detected and we update the node, and add a "to_power" field to the power_set | 16:09 |
| openstackgerrit | Merged openstack/ironic-python-agent: Update home page link in cfg file https://review.openstack.org/373076 | 16:09 |
| mariojv | did i miss something or is that about it ? ^ | 16:10 |
| mariojv | getting rid of power_sync.error too | 16:10 |
| mariojv | perhaps from_power in the sync too | 16:10 |
| rloo | mariojv: for the sync -- that is emitted after the node is actually updated/sync'd right? so from_power is what is missing. | 16:10 |
| rloo | mariojv: i think you might be right and power_sync.error may not be needed. i'll have to think about it when i review your patch again (in the middle of somethign else now and don't want to swap context) | 16:11 |
| mariojv | no worries, i'll have a patch set up soonish w/ the changes. yeah from_power should be in the sync too | 16:11 |
| mariojv | thanks | 16:12 |
| *** rama_y has quit IRC | 16:13 | |
| *** rpioso has joined #openstack-ironic | 16:15 | |
| *** ohamada has quit IRC | 16:16 | |
| *** krtaylor has joined #openstack-ironic | 16:21 | |
| *** lucas-hungry is now known as lucasagomes | 16:22 | |
| rloo | mat128: sorry, i downgraded your +2 on https://review.openstack.org/#/c/366329/ | 16:23 |
| patchbot | patch 366329 - ironic - [install-guide] Import "Bare Metal service overview" | 16:23 |
| openstackgerrit | Merged openstack/ironic: Refactor common checks when instantiating the ipmitool classes https://review.openstack.org/346896 | 16:25 |
| NobodyCam | Good Morning Ironicers | 16:30 |
| rloo | mat128, JayF: wrt the install guide, the final patch? in the series has stuff pointing to ../draft/...??? https://review.openstack.org/#/c/369802/9/doc/source/deploy/install-guide.rst | 16:30 |
| patchbot | patch 369802 - ironic - Add link to new guide in old install guide | 16:30 |
| rloo | mat128, JayF: if that is the *final* outcome of the install guide (for Newton), then I don't want to change the install guide until ocata. we can't have links to ../draft/... | 16:31 |
| openstackgerrit | Stephanie Miller proposed openstack/bifrost: Workaround openSUSE ansible_os_family issue https://review.openstack.org/371082 | 16:31 |
| rloo | morning NobodyCam. (reminds me, lunch time!) | 16:32 |
| NobodyCam | heheh Morning rloo :) | 16:32 |
| *** mtanino has joined #openstack-ironic | 16:34 | |
| openstackgerrit | Stephanie Miller proposed openstack/bifrost: Install process SuSE support https://review.openstack.org/367637 | 16:35 |
| *** trown is now known as trown|lunch | 16:35 | |
| *** moshele has quit IRC | 16:40 | |
| *** aNuposic has joined #openstack-ironic | 16:42 | |
| vdrok | morning NobodyCam ! | 16:43 |
| NobodyCam | morning vdrok :) | 16:44 |
| openstackgerrit | Stephanie Miller proposed openstack/bifrost: Workaround openSUSE ansible_os_family issue https://review.openstack.org/371082 | 16:44 |
| vdrok | and good night everyone! | 16:46 |
| openstackgerrit | Stephanie Miller proposed openstack/bifrost: Install process SuSE support https://review.openstack.org/367637 | 16:46 |
| openstackgerrit | Stephanie Miller proposed openstack/bifrost: SuSE support for VM node creation https://review.openstack.org/370385 | 16:47 |
| *** jpich has quit IRC | 16:48 | |
| NobodyCam | night vdrok :) | 16:50 |
| *** jvgrant__ has quit IRC | 16:50 | |
| *** jvgrant__ has joined #openstack-ironic | 16:51 | |
| *** baoli_ has joined #openstack-ironic | 16:55 | |
| *** baoli has quit IRC | 16:55 | |
| *** rcernin has quit IRC | 16:55 | |
| openstackgerrit | Kyrylo Romanenko proposed openstack/ironic: [WIP] Test ML2 Fail-Fast feature https://review.openstack.org/370016 | 16:55 |
| *** mgoddard has quit IRC | 16:56 | |
| *** mgoddard_ has joined #openstack-ironic | 16:56 | |
| *** strigazi is now known as strigazi_AFK | 16:59 | |
| *** strigazi_AFK is now known as strigazi | 16:59 | |
| *** strigazi is now known as strigazi_AFK | 16:59 | |
| *** tuan_luong has joined #openstack-ironic | 17:01 | |
| tuan_luong | Hello ironic team | 17:02 |
| *** anush__ has quit IRC | 17:07 | |
| *** tuan_luong has quit IRC | 17:07 | |
| *** sai is now known as sai|mtg | 17:08 | |
| sambetts | jroll, lucasagomes: I'm no PTO from tomorrow until the end of the week, so I won't be around until Monday | 17:11 |
| *** rama_y has joined #openstack-ironic | 17:11 | |
| sambetts | on* | 17:11 |
| rloo | sambetts: enjoy! | 17:11 |
| NobodyCam | have a great time sambetts | 17:11 |
| sambetts | rloo, NobodyCam: thanks guys :D | 17:11 |
| NobodyCam | :) | 17:12 |
| *** rama_y has quit IRC | 17:12 | |
| * sambetts -> home, and pto | 17:12 | |
| lucasagomes | sambetts, enjoy your time off! | 17:12 |
| *** sambetts is now known as sambetts|pto | 17:13 | |
| *** rama_y has joined #openstack-ironic | 17:13 | |
| sambetts|pto | lucasagomes: thanks! | 17:13 |
| *** pcaruana has quit IRC | 17:14 | |
| *** Romanenko_K has quit IRC | 17:15 | |
| *** milan has quit IRC | 17:17 | |
| *** hshiina has quit IRC | 17:24 | |
| *** e0ne has quit IRC | 17:24 | |
| openstackgerrit | Merged openstack/bifrost: Update home page link in cfg file https://review.openstack.org/373057 | 17:25 |
| jroll | sambetts|pto: cheers, enjoy :) | 17:32 |
| openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic: Serve iPXE configs from Ironic API https://review.openstack.org/369438 | 17:38 |
| openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic: Refactor _test_build_pxe_config_options tests https://review.openstack.org/367142 | 17:38 |
| openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic: iPXE allow skip caching in standalone mode https://review.openstack.org/367321 | 17:38 |
| *** trown|lunch is now known as trown | 17:49 | |
| *** anush has joined #openstack-ironic | 17:50 | |
| mat128 | rloo: our current install guide in developer docs were always published from master, we even tell people to look for older versions when they run a previous version of Ironic. That's why I linked to /draft, because draft is essentially master | 17:50 |
| mat128 | s/were/was | 17:51 |
| *** causten has quit IRC | 17:52 | |
| mat128 | the manual will be branched with the main repo | 17:52 |
| mat128 | so whatever master states when we create stable/newton, this is what is going to be published under the newton directory | 17:53 |
| rloo | mat128: but it has 'draft' in the url. | 17:54 |
| mat128 | draft is where master is published | 17:54 |
| rloo | mat128: is it always going to have draft? | 17:54 |
| mat128 | yes | 17:54 |
| rloo | you have to be kidding | 17:54 |
| mat128 | master = draft, stable/newton is newton, etc. | 17:54 |
| mat128 | let me see | 17:55 |
| patchbot | (let <variable> = <value> in <command>) -- Defines <variable> to be equal to <value> in the <command> and runs the <command>. '=' and 'in' can be omitted. | 17:55 |
| rloo | so IF these patches get merged in ironic master, the install guide links in doc/developer/.. will point to draft. | 17:55 |
| rloo | mat128: and then when we create the stable/newton branch, the install guide from developer/newton will point to ../draft..? | 17:55 |
| mat128 | yes. everything but the "draft" name makes sense, previous docs were built from our master branch | 17:55 |
| mat128 | the install guide from our developer docs will point to draft | 17:56 |
| mat128 | the new URL has to be the new one | 17:56 |
| mat128 | at some point we should delete the old stuff | 17:56 |
| rloo | mat128: do you know where the *final* docs for the new install guides, will be located? | 17:56 |
| mat128 | http://docs.openstack.org/contributor-guide/project-install-guide.html | 17:56 |
| mat128 | for them, draft = unreleased | 17:56 |
| JayF | rloo: /draft/ is "master" of install-guide at all points | 17:57 |
| *** sai|mtg is now known as sai | 17:57 | |
| rloo | mat128: where are the released ones? | 17:57 |
| JayF | rloo: they build /releasename/ out of stable/releasename trees | 17:57 |
| mat128 | rloo: /newton | 17:57 |
| JayF | rloo: so master docs should point to master docs | 17:57 |
| mat128 | rloo: http://specs.openstack.org/openstack/docs-specs/specs/newton/project-specific-installguides.html#publishing | 17:58 |
| mat128 | "For publishing from master, the RELEASE should be draft." | 17:58 |
| rloo | JayF, mat128: I *think* we want the links from the old install (developer/...) to point to new install/newton/... | 17:58 |
| mat128 | rloo: I have 2 concerns with this: a) it doesnt exist yet, b) we're going to have to change this every time we change something | 17:58 |
| mat128 | the old way was, a commit introduces something in docs/source/deploy/install.rst, it was (almost) instantly available at docs.openstack.org | 17:59 |
| JayF | rloo: I disagree; dev docs are always built on "master", so they should point to "master" of install guide docs | 17:59 |
| mat128 | right now, it would have to wait for a release | 17:59 |
| rloo | mat128: i think we can make that change as a backport patch to stable/newton | 17:59 |
| JayF | rloo: question: if it was /master/ instead of /draft/, would you still feel the same way? | 17:59 |
| JayF | rloo: .o(unless we do have versioned dev docs?) | 17:59 |
| mat128 | rloo: I would commit in stable/newton to point to /newton | 17:59 |
| rloo | JayF: yes, i'd feel the same way. i'm trying to understand the *final* thing. | 17:59 |
| mat128 | if those were published | 17:59 |
| jroll | JayF: we do | 17:59 |
| rloo | mat128, JayF: docs in stable/newton need to point to docs in newton, not master | 18:00 |
| mat128 | rloo: I would do that once stable/newton is cut | 18:00 |
| JayF | if we have versioned dev docs, I am +1 to landing /draft/, and pushing a patch to stable/* when cut to point to that branch | 18:00 |
| * JayF == mat128 | 18:00 | |
| JayF | and then completely remove those sections from devdocs after some period of time, so we don't have to update them foreve | 18:00 |
| mat128 | :D | 18:00 |
| mat128 | JayF: exactly | 18:00 |
| mat128 | jroll: where are they published? I can only find http://docs.openstack.org/developer/ironic/ | 18:00 |
| mat128 | our current install guide even states "Users of releases may encounter differences and are encouraged to look at earlier versions of this document for guidance." | 18:01 |
| jroll | mat128: http://docs.openstack.org/developer/ironic/mitaka/ | 18:01 |
| mat128 | doh | 18:01 |
| JayF | til | 18:01 |
| mat128 | improvement: link those somewhere | 18:01 |
| jroll | there may be a way to enable links to those in the sidebar | 18:01 |
| JayF | as the docs liason I should know that, lol | 18:01 |
| devananda | rloo: would you like to discuss API things today? | 18:01 |
| mat128 | so one more point to put that in the stable/ branch | 18:01 |
| rloo | devananda: oh, jroll said you wanted to | 18:01 |
| mat128 | fix the /draft link for the just-released branch | 18:02 |
| mat128 | but master should have /draft | 18:02 |
| mat128 | do you agree rloo? | 18:02 |
| rloo | jroll, devananda: shall we meet? | 18:02 |
| jroll | rloo: we are :) | 18:02 |
| jroll | rloo: -meeting-3 | 18:02 |
| rloo | mat128: will get back to you later but i think yes :) | 18:03 |
| mat128 | ok good, poke me when you're ready | 18:03 |
| *** rama_y has quit IRC | 18:04 | |
| *** rama_y has joined #openstack-ironic | 18:05 | |
| *** nicodemos has quit IRC | 18:06 | |
| *** nicodemos has joined #openstack-ironic | 18:12 | |
| *** athomas has quit IRC | 18:14 | |
| *** anush has quit IRC | 18:17 | |
| *** ElCoyote_ has joined #openstack-ironic | 18:21 | |
| *** aswadr_ has quit IRC | 18:22 | |
| *** baoli_ has quit IRC | 18:25 | |
| *** baoli has joined #openstack-ironic | 18:25 | |
| *** mjturek has quit IRC | 18:29 | |
| *** e0ne has joined #openstack-ironic | 18:30 | |
| *** mjturek has joined #openstack-ironic | 18:39 | |
| *** jabroney has joined #openstack-ironic | 18:44 | |
| *** mjturek has quit IRC | 18:48 | |
| *** mjturek has joined #openstack-ironic | 18:49 | |
| *** sdake_ is now known as sdake | 18:50 | |
| rloo | mat128: ok, i guess we use /draft. fwiw -- master does NOT mean draft, but I know, you didn't decide that. | 18:53 |
| mat128 | rloo: if that was my choice, it would have been /latest or something like that. I'm a believer that every commit is a "release" | 18:54 |
| rloo | mat128: exactly. anyway, out of our control. | 18:55 |
| mat128 | or plain old /master, but that isnt as clear to newcomers | 18:55 |
| mat128 | yup | 18:55 |
| rloo | mat128: i'll look at the second patch in your series soon. | 18:55 |
| *** mjturek has quit IRC | 18:56 | |
| rloo | mat128: if you could update the first patch (see my comment) and if JayF is around, we could land that one today. | 18:57 |
| JayF | I'm around | 18:57 |
| JayF | all the rackers on onmetal are in boston this week having a meeting | 18:57 |
| JayF | so we're aroundish on irc but not as much as usual | 18:57 |
| rloo | JayF: oh right. I can ping you. | 18:58 |
| JayF | I'm also EST so it's 3pm :P | 18:58 |
| rloo | JayF: are we OK landing some of these patches before the release? | 18:58 |
| JayF | Absolutely! We got permission from jroll to backport the rest when they land to newton | 18:58 |
| rloo | JayF: okey dokey | 18:59 |
| jroll | JayF: only after some had already landed >.> | 19:07 |
| *** aNuposic has quit IRC | 19:09 | |
| *** mjturek has joined #openstack-ironic | 19:11 | |
| *** jabroney has quit IRC | 19:13 | |
| openstackgerrit | Sai Kiran proposed openstack/python-ironicclient: Use ConfigParser instead of SafeConfigParser https://review.openstack.org/373511 | 19:26 |
| *** electrofelix has quit IRC | 19:29 | |
| *** aNuposic has joined #openstack-ironic | 19:35 | |
| *** baoli has quit IRC | 19:37 | |
| *** baoli has joined #openstack-ironic | 19:38 | |
| *** mjturek1 has joined #openstack-ironic | 19:56 | |
| *** mjturek has quit IRC | 19:57 | |
| *** baoli has quit IRC | 19:59 | |
| *** baoli has joined #openstack-ironic | 19:59 | |
| *** joprovost has quit IRC | 20:08 | |
| *** jcoufal_ has quit IRC | 20:09 | |
| *** mjturek has joined #openstack-ironic | 20:13 | |
| lucasagomes | folks I'm calling it a day | 20:15 |
| lucasagomes | have a great night all | 20:15 |
| *** lucasagomes is now known as lucas-afk | 20:15 | |
| *** mjturek1 has quit IRC | 20:17 | |
| *** Goneri has quit IRC | 20:18 | |
| *** ayoung has joined #openstack-ironic | 20:26 | |
| ayoung | I think the policy generation for Ironic needs a registered entrypoint. Has anywone been able to run it? | 20:26 |
| ayoung | sudo oslopolicy-policy-generator --namespace ironic --output-file /tmp/policy/etc/ironic/policy.json | 20:26 |
| ayoung | WARNING:stevedore.named:Could not load ironic | 20:26 |
| jroll | ayoung: tox -e genpolicy seems to work for me | 20:34 |
| ayoung | jroll, let me try | 20:35 |
| * jroll double checks a thing | 20:35 | |
| jroll | yeah, works as expected | 20:35 |
| jroll | genpolicy runtests: commands[0] | oslopolicy-sample-generator --namespace=ironic.api --output-file=etc/ironic/policy.json.sample | 20:35 |
| jroll | --namespace=ironic.api | 20:35 |
| ayoung | jroll, I tried running that | 20:36 |
| ayoung | exactly that command line...klet's see... | 20:36 |
| jroll | I see "--namespace ironic" in your pasted example | 20:36 |
| ayoung | jroll, I tried a few things | 20:36 |
| ayoung | including sudo oslopolicy-policy-generator --namespace ironic.api --output-file /tmp/policy/etc/ironic/policy.json | 20:37 |
| jroll | oh, and s/oslopolicy-policy-generator/oslopolicy-sample-generator/ | 20:37 |
| ayoung | jroll, hmm. we need consistant tooling. Nova is publishing the other | 20:37 |
| jroll | oslopolicy-sample-generator --namespace ironic.api --output-file /tmp/policy/etc/ironic/policy.json | 20:37 |
| jroll | works for me outside of tox | 20:37 |
| ayoung | OK, I can use that | 20:37 |
| jroll | curious what the difference is between the two commands | 20:38 |
| ayoung | No clue | 20:38 |
| *** jabroney has joined #openstack-ironic | 20:38 | |
| ayoung | I just tripped over this empty file thing today | 20:38 |
| jroll | well, we have a sample file in our repo :) | 20:39 |
| *** vsaienko has quit IRC | 20:40 | |
| ayoung | jroll, thanks. and it looks like Ironic might be doing something interesting in policy | 20:40 |
| jroll | interesting how? | 20:40 |
| ayoung | rule:is_observer | 20:40 |
| ayoung | "is_member": "tenant:demo or tenant:baremetal" | 20:40 |
| ayoung | that looks wonky | 20:41 |
| JayF | ayoung: to prevent breaking devstack | 20:41 |
| JayF | ayoung: devstack tenant is "demo" | 20:41 |
| ayoung | won't work with V3 toknes | 20:41 |
| jroll | because tenant vs project? | 20:41 |
| JayF | I know devananda tested all this w/keystone v3, so I'm skeptical? | 20:41 |
| jroll | yeah, ditto | 20:41 |
| jroll | and it can be overridden :) | 20:42 |
| JayF | devananda: devananda devananda ^ | 20:42 |
| *** makowals has joined #openstack-ironic | 20:42 | |
| ayoung | I think we grandfather in tenant somehow | 20:44 |
| jroll | yeah, that's what I assumed | 20:44 |
| *** mjturek1 has joined #openstack-ironic | 20:44 | |
| ayoung | but assuming a specific tenant name is also very devstack specific | 20:45 |
| * ayoung checks to see if undercloud even has those... | 20:45 | |
| jroll | yes, it's a bit of a crutch | 20:45 |
| *** mjturek has quit IRC | 20:45 | |
| ayoung | | 02cdbfd151934af2a5a36ad3110d929d | service | | 20:46 |
| ayoung | | 27cdd20e74f74e07a6f78cfd70a6abbb | admin | 20:46 |
| ayoung | and one where the name is a uuid | 20:46 |
| jroll | sure | 20:46 |
| ayoung | jroll, I wonder if that is why it is useing sample.... | 20:47 |
| jroll | why what is using sample? | 20:48 |
| ayoung | oslopolicy-sample-generator might be doing something different from oslopolicy-policy-generator | 20:48 |
| jroll | I have no idea | 20:48 |
| ayoung | I was looking to see how many distinct policy rules there are in openstack projects (overcloud) and did not expect any new ones from Ironic. Instead, Ironic has 5 distinct rules that none of the other projects have | 20:49 |
| ayoung | very interesting | 20:49 |
| *** dprince has quit IRC | 20:49 | |
| jroll | yeah, we finally implemented real policy support | 20:50 |
| jroll | and decided to roughly follow dolph/jamie's cross-project spec that outlined this sort of thing | 20:50 |
| *** mjturek1 has quit IRC | 20:55 | |
| rloo | jroll: isn't this done? https://bugs.launchpad.net/ironic/+bug/1526401 | 20:57 |
| openstack | Launchpad bug 1526401 in Ironic "[RFE] Pluggable network providers" [Wishlist,In progress] - Assigned to Jim Rollenhagen (jim-rollenhagen) | 20:57 |
| jroll | rloo: yes | 20:57 |
| jroll | rloo: I haven't gone through and closed RFEs / move blueprints yet | 20:57 |
| jroll | plan to do that friday or monday | 20:57 |
| rloo | jroll: oh, thought you did it during the bug smash. ok, i'll ignore then. | 20:57 |
| jroll | rloo: didn't go through the approved ones, no :( | 20:58 |
| *** priteau has joined #openstack-ironic | 20:58 | |
| jroll | see y'all tomorrow | 21:03 |
| xavierr | see you jroll | 21:05 |
| *** ccamacho has quit IRC | 21:06 | |
| *** krtaylor has quit IRC | 21:11 | |
| *** ijw has joined #openstack-ironic | 21:16 | |
| *** ijw has quit IRC | 21:16 | |
| *** ijw has joined #openstack-ironic | 21:16 | |
| mrda | Morning Ironic | 21:17 |
| *** jheroux has quit IRC | 21:20 | |
| xavierr | morning mrda :) | 21:20 |
| mrda | Morning xavierr | 21:27 |
| jlvillal | I see the Ops meetup in Barcelona has some people who want to talk about bare-metal deploy: https://etherpad.openstack.org/p/BCN-ops-meetup | 21:30 |
| *** adu has joined #openstack-ironic | 21:47 | |
| *** wznoinsk has quit IRC | 21:50 | |
| *** e0ne has quit IRC | 21:59 | |
| *** ijw_ has joined #openstack-ironic | 22:01 | |
| *** wznoinsk has joined #openstack-ironic | 22:02 | |
| *** ijw has quit IRC | 22:03 | |
| *** joprovost has joined #openstack-ironic | 22:06 | |
| *** bfournie has quit IRC | 22:09 | |
| *** joprovost1 has joined #openstack-ironic | 22:09 | |
| *** joprovost has quit IRC | 22:10 | |
| *** joprovost1 is now known as joprovost | 22:10 | |
| *** mkam has quit IRC | 22:12 | |
| *** praneshp has joined #openstack-ironic | 22:17 | |
| *** cdearborn has quit IRC | 22:21 | |
| *** hoonetorg has quit IRC | 22:24 | |
| NobodyCam | morning mrda | 22:30 |
| mrda | hey NobodyCam | 22:30 |
| NobodyCam | :) | 22:31 |
| *** bdeschenes has quit IRC | 22:33 | |
| *** r-daneel has quit IRC | 22:34 | |
| *** rama_y has quit IRC | 22:37 | |
| xavierr | NobodyCam, mrda: I think we could be a team | 22:41 |
| NobodyCam | lol :) | 22:41 |
| xavierr | we are in the channel at the same time every single day | 22:41 |
| xavierr | :D | 22:41 |
| mrda | :) | 22:43 |
| *** jabroney has quit IRC | 22:50 | |
| *** baoli has quit IRC | 22:52 | |
| *** priteau has quit IRC | 22:53 | |
| *** hoonetorg has joined #openstack-ironic | 22:56 | |
| *** rpioso has quit IRC | 22:59 | |
| *** hoonetorg has quit IRC | 23:02 | |
| *** rama_y has joined #openstack-ironic | 23:03 | |
| *** adu has quit IRC | 23:05 | |
| *** pmannidi has joined #openstack-ironic | 23:09 | |
| devananda | ayoung, jroll: I think oslopolicy-policy-generator builds the things to start from, rather than building the sample file as output from code, but I also did not get the former to work enough that I cared | 23:10 |
| ayoung | devananda, they seem to do the same thing, but I'll get an answer. Anyway, I suspect that the two tools should be merged if they are so similar | 23:12 |
| ayoung | But I've got enough to go off for now. | 23:12 |
| devananda | JayF, ayoung: interesting, I didn't realize we needed to replace (or duplicate) the "tenant:" rule statement with a "project:" statement | 23:12 |
| devananda | ayoung: yea - if they are *supposed* to do the same thing, they ought to be merged. I don't care about the name, and was just following the docs I had found :) | 23:13 |
| ayoung | devananda, The goal was to standardize the language. I really don't care which we decided to settle on, but long ago, we started pushing everything to project, and that is what V3 is based on. It might be possible that there is logic in there to make it work for both, though. I suspect that there is | 23:13 |
| devananda | ayoung: that makes sense | 23:13 |
| devananda | I did some things to retain compatibility with existing deployments that, by themselves, wouldn't be necessary | 23:14 |
| ayoung | devananda, my goal is to be able to finally close bug 968696 and that means enforcing policy for admin actions that are not project/tenant specific ones on Is_admin_project | 23:14 |
| openstack | bug 968696 in Glance ""admin"-ness not properly scoped" [High,In progress] https://launchpad.net/bugs/968696 - Assigned to Sharat Sharma (sharat-sharma) | 23:14 |
| devananda | I have not read that bug before | 23:14 |
| devananda | ironic was, up until now, admin-only | 23:14 |
| ayoung | this has been a slog, with changes needed at Keystone server, and then oslo context, and now in each of the projects enforcing policy | 23:14 |
| devananda | relatedly, this may be of interest to you - https://review.openstack.org/325672 | 23:15 |
| patchbot | patch 325672 - openstack-dev/devstack - [WIP] Adjust keystone permissions for ironic hyper... | 23:15 |
| ayoung | well, if that is the case, each API should be enforcing is_admin_project, then, as otherwise, we have the case where someone can get admin on some randome project and then they have admin everywhere | 23:15 |
| devananda | ayoung: ahhh - I have read the bug and now understand | 23:16 |
| devananda | I thought there was an admin tenant | 23:16 |
| ayoung | yeah, that is what we need to enforce | 23:16 |
| ayoung | the idea is that cloud admin is "admin role on admin tenant" | 23:16 |
| ayoung | but policy was just enforcing "admin role is in the token" and ignoreing the scope | 23:17 |
| devananda | hah | 23:17 |
| devananda | yea, that's terrifying | 23:17 |
| devananda | I recall asking/wondering about this a while ago (like, two years back) | 23:17 |
| devananda | and thinking there was some black magic in how the "admin_api" rule got checked | 23:17 |
| ayoung | I've been chasing this bug at least that long | 23:17 |
| devananda | now I am sad | 23:17 |
| devananda | on the other hand, it should be technically easy to fix in ironic now | 23:18 |
| ayoung | devananda, I' | 23:18 |
| devananda | it's just going to, possibly, break the world when we land it | 23:18 |
| ayoung | ll check. there is something about how policy is enforce using oslo context. jamielennox was chasingt that in other projects, but I'll take a look at Ironic,m and submit the patch if needed | 23:18 |
| ayoung | dinner time | 23:19 |
| devananda | https://github.com/openstack/ironic/blob/master/ironic/common/policy.py#L62 | 23:19 |
| devananda | ayoung: yea, I just refactored / ripped out a lot of that legacy code from Ironic | 23:19 |
| *** hoonetorg has joined #openstack-ironic | 23:19 | |
| devananda | ayoung: enjoy dinner! I'm glad you're digging into this, and happy to help as I'm pretty comfortable in all this code at the moment | 23:20 |
| devananda | message for when you're back ... | 23:20 |
| devananda | look at the git history around this line, and see what I changed during Newton | 23:21 |
| devananda | https://github.com/openstack/ironic/blob/master/ironic/api/hooks.py#L83 | 23:21 |
| devananda | I removed most of the old checks for is_admin stuff in the token, and now just call policy.enforce | 23:21 |
| devananda | so I *think* the only further change we need to make is to the policy.RuleDefault('is_admin'... line in ironic/common/policy.py | 23:22 |
| *** hoonetorg has quit IRC | 23:29 | |
| *** ijw_ has quit IRC | 23:30 | |
| *** hoonetorg has joined #openstack-ironic | 23:31 | |
| *** rbrud has quit IRC | 23:32 | |
| *** Goneri has joined #openstack-ironic | 23:33 | |
| *** devananda is now known as devananda|dinner | 23:33 | |
| *** ijw has joined #openstack-ironic | 23:33 | |
| *** bdeschenes has joined #openstack-ironic | 23:37 | |
| *** Alexey_Abashkin_ has joined #openstack-ironic | 23:45 | |
| *** rbrud has joined #openstack-ironic | 23:46 | |
| ayoung | devananda|dinner, yes, that line should be "id_admin" : "role:admin and is_admin_project" or similar | 23:46 |
| *** Alexey_Abashkin has quit IRC | 23:46 | |
| praneshp | hello ironic. I noticed that when a nova boot fails at any stage (scheduler looking for a node, spawning timed out), the error is always NoValidHost (instead of showing the actual reason for failure). | 23:52 |
| praneshp | Im on release 4.2.3 | 23:52 |
| *** BadCub has quit IRC | 23:52 | |
| praneshp | is this expected/known? | 23:52 |
| praneshp | @rloo ^^ | 23:52 |
| *** Goneri has quit IRC | 23:52 | |
| *** rajinir has quit IRC | 23:55 | |
| TheJulia | praneshp: that sounds like the scheduler is unable to schedule the requested node on to a baremetal node | 23:56 |
| praneshp | @TheJulia but I see the ironic node state change to wait call-back, and conductor try to check state 60 times or so, ramdisk getting downloaded on the target node’s console, etc etc | 23:57 |
| praneshp | ie, def well beyond the scheduler phase | 23:57 |
| praneshp | the nova instance goes to spawning, then to ERROR and NoValidHost | 23:57 |
| TheJulia | praneshp: essentially any failure percieved by nova can send it back into scheduling | 23:58 |
| praneshp | I see, nova is trying to re-schedule, on any other node, and fails because it didnt find anything? | 23:58 |
| TheJulia | Anything in the compute service logs? | 23:58 |
| TheJulia | praneshp: basically, yes | 23:58 |
| praneshp | @TheJulia compute service logs just say timed out waiting for state to change from wait call-back. The actual reason the timeout happens is known to me, I’m just concerned that the error is NoValidHost instead of some form of actually what happened | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!