Friday, 2016-07-29

*** lujinluo has joined #openstack-ironic00:04
*** rloo has quit IRC00:09
*** rama_y has quit IRC00:09
*** jcoufal has quit IRC00:19
*** hshiina has joined #openstack-ironic00:19
*** jcoufal has joined #openstack-ironic00:20
*** adu has joined #openstack-ironic00:21
*** sdake has quit IRC00:23
*** hwcomcn has joined #openstack-ironic00:24
openstackgerritMerged openstack/ironic: Log full config only once in conductor  https://review.openstack.org/34845900:26
*** jcoufal has quit IRC00:28
*** adu has quit IRC00:37
*** jcoufal has joined #openstack-ironic00:39
*** hoangcx has joined #openstack-ironic00:44
*** hwcomcn has quit IRC00:55
*** hshiina has quit IRC00:56
*** hoangcx2 has quit IRC00:58
*** jaybeale has joined #openstack-ironic01:01
*** lujinluo has quit IRC01:06
*** lujinluo has joined #openstack-ironic01:06
*** jcoufal has quit IRC01:06
*** jcoufal has joined #openstack-ironic01:08
*** jaybeale has quit IRC01:12
*** sdake has joined #openstack-ironic01:13
*** sdake has quit IRC01:13
*** sdake has joined #openstack-ironic01:13
*** sdake_ has joined #openstack-ironic01:15
*** sdake has quit IRC01:18
*** jcoufal has quit IRC01:20
*** jcoufal has joined #openstack-ironic01:20
*** harshs has quit IRC01:26
*** bvandewa has quit IRC01:28
*** harshs has joined #openstack-ironic01:28
*** yibo has joined #openstack-ironic01:31
*** yibo has quit IRC01:35
*** yibo has joined #openstack-ironic01:35
*** yibo has quit IRC01:35
*** yibo has joined #openstack-ironic01:38
*** harshs has quit IRC01:49
*** jcoufal has quit IRC01:51
*** jcoufal has joined #openstack-ironic01:52
*** lujinluo has quit IRC02:11
*** lujinluo has joined #openstack-ironic02:11
*** jcoufal has quit IRC02:12
*** PollyZ has joined #openstack-ironic02:12
*** PollyZ has quit IRC02:18
*** sdake_ has quit IRC02:19
*** PollyZ has joined #openstack-ironic02:26
*** joprovost has quit IRC02:28
*** PollyZ has quit IRC02:31
openstackgerritOpenStack Proposal Bot proposed openstack/python-ironic-inspector-client: Updated from global requirements  https://review.openstack.org/34867202:34
openstackgerritOpenStack Proposal Bot proposed openstack/python-ironicclient: Updated from global requirements  https://review.openstack.org/34867302:34
*** yibo has quit IRC02:38
*** yibo has joined #openstack-ironic02:38
*** PollyZ has joined #openstack-ironic02:40
*** PollyZ has quit IRC02:44
*** harshs has joined #openstack-ironic02:48
*** PollyZ has joined #openstack-ironic02:53
*** sabeen1 has quit IRC02:55
*** yuanying_ has quit IRC02:57
*** sabeen has joined #openstack-ironic02:58
*** PollyZ has quit IRC02:58
*** thrash is now known as thrash|g0ne03:00
*** PollyZ has joined #openstack-ironic03:07
*** PollyZ has quit IRC03:11
*** joprovost has joined #openstack-ironic03:14
*** PollyZ has joined #openstack-ironic03:20
*** chihhsin has quit IRC03:25
*** lujinluo has quit IRC03:25
*** PollyZ has quit IRC03:25
*** harshs has quit IRC03:32
*** PollyZ has joined #openstack-ironic03:34
*** chihhsin has joined #openstack-ironic03:37
*** PollyZ has quit IRC03:39
*** Sukhdev has joined #openstack-ironic03:40
*** PollyZ has joined #openstack-ironic03:48
*** appu103_ has joined #openstack-ironic03:49
*** yuanying has joined #openstack-ironic03:51
*** PollyZ has quit IRC03:52
*** lujinluo has joined #openstack-ironic03:59
*** chihhsin has quit IRC03:59
*** chihhsin has joined #openstack-ironic04:00
*** PollyZ has joined #openstack-ironic04:01
*** PollyZ has quit IRC04:06
openstackgerritNisha Agarwal proposed openstack/proliantutils: Discover Storage details  https://review.openstack.org/34137004:08
*** vmud213 has joined #openstack-ironic04:12
*** links has joined #openstack-ironic04:13
openstackgerritNaohiro Tamura proposed openstack/ironic: Ipmitool management driver for Inject NMI  https://review.openstack.org/34872104:14
*** PollyZ has joined #openstack-ironic04:15
*** joprovost has quit IRC04:18
*** joprovost has joined #openstack-ironic04:19
*** PollyZ has quit IRC04:20
*** Sukhdev has quit IRC04:24
*** Sukhdev has joined #openstack-ironic04:25
*** PollyZ has joined #openstack-ironic04:28
*** vmud213 has quit IRC04:29
*** Sukhdev has quit IRC04:29
*** vmud213 has joined #openstack-ironic04:29
*** PollyZ has quit IRC04:34
*** krtaylor has joined #openstack-ironic04:35
*** livelace has joined #openstack-ironic04:54
*** PollyZ has joined #openstack-ironic05:09
*** PollyZ has quit IRC05:14
*** amitkqed has quit IRC05:19
*** amitkqed has joined #openstack-ironic05:20
openstackgerritNaohiro Tamura proposed openstack/ironic: iRMC management driver for Inject NMI  https://review.openstack.org/34873205:21
*** PollyZ has joined #openstack-ironic05:36
*** PollyZ has quit IRC05:41
*** amotoki has joined #openstack-ironic05:46
openstackgerritSwapnil Kulkarni (coolsvap) proposed openstack/ironic: [WIP] Testing latest u-c  https://review.openstack.org/31844005:49
*** PollyZ has joined #openstack-ironic05:50
*** Fdaisuke has joined #openstack-ironic05:52
*** _Fdaisuke_ has quit IRC05:54
*** PollyZ has quit IRC05:55
openstackgerritTeng Fei proposed openstack/ironic-inspector: Modify the SQL's string from double quote to single quote.  https://review.openstack.org/34779505:58
*** harlowja_at_home has joined #openstack-ironic05:59
*** PollyZ has joined #openstack-ironic06:04
*** PollyZ has quit IRC06:09
*** e0ne has joined #openstack-ironic06:12
*** PollyZ has joined #openstack-ironic06:17
*** harlowja_at_home has quit IRC06:20
*** mjura has joined #openstack-ironic06:22
*** PollyZ has quit IRC06:22
*** mjura has quit IRC06:29
*** mjura has joined #openstack-ironic06:29
*** wlfightup has joined #openstack-ironic06:30
*** PollyZ has joined #openstack-ironic06:31
wlfightupHello everybody, I'm from Hong Kong. Nice to meet you06:33
wlfightupI am pleased to learn with you. I hope you will take care of me06:33
*** loki_ has joined #openstack-ironic06:36
*** PollyZ has quit IRC06:36
*** tesseract- has joined #openstack-ironic06:37
*** hoangcx has quit IRC06:42
*** PollyZ has joined #openstack-ironic06:44
*** pcaruana has joined #openstack-ironic06:45
*** PollyZ has quit IRC06:50
*** hoangcx has joined #openstack-ironic06:55
openstackgerritDavid Lenwell proposed openstack/ironic: Add REST API for volume connector operation  https://review.openstack.org/21458606:57
*** Fdaisuke has quit IRC06:59
*** ccamacho has joined #openstack-ironic06:59
*** Fdaisuke has joined #openstack-ironic07:00
*** appu103_ is now known as aparnav07:01
openstackgerritDavid Lenwell proposed openstack/ironic: Add REST API for volume connector operation  https://review.openstack.org/21458607:02
*** zhenguo has joined #openstack-ironic07:04
*** bvandewa has joined #openstack-ironic07:16
*** Fdaisuke has quit IRC07:17
*** Fdaisuke has joined #openstack-ironic07:17
*** vishwanathj has quit IRC07:21
*** davidlenwell has quit IRC07:22
*** PollyZ has joined #openstack-ironic07:25
*** mkrai_ has joined #openstack-ironic07:27
*** PollyZ has quit IRC07:30
*** ccamacho is now known as ccamacho|afk07:33
*** davidlenwell has joined #openstack-ironic07:34
*** PollyZ has joined #openstack-ironic07:39
*** PollyZ has quit IRC07:43
*** bvandewa has quit IRC07:45
*** hoangcx has quit IRC07:48
*** hoangcx has joined #openstack-ironic07:50
*** ccamacho|afk is now known as ccamacho07:51
*** jpich has joined #openstack-ironic07:55
*** zzzeek has quit IRC08:00
*** zzzeek has joined #openstack-ironic08:00
*** e0ne has quit IRC08:00
openstackgerritDavid Lenwell proposed openstack/ironic: Add REST API for volume connector operation  https://review.openstack.org/21458608:01
*** jralph_ has joined #openstack-ironic08:01
*** jralph has quit IRC08:04
lucasagomesmorning all08:05
tangchenHi, Lucas08:06
tangchenmorning08:06
*** PollyZ has joined #openstack-ironic08:06
tangchenlucasagomes: About the functional test issue, I have a question if you have time.08:07
lucasagomestangchen, sure, if I know the answer :-)08:07
*** fragatina has quit IRC08:09
*** derekh has joined #openstack-ironic08:09
tangchenlucasagomes: When I was trying to add some basic classes and functions for functional test, I found that in the api unit test, it actually started a server using pecan.08:09
tangchenlucasagomes: And it actually sent the api requests to the server and got the responses.08:10
lucasagomesright08:11
tangchenlucasagomes: So it looks more like functional tests. Am I right ?08:11
*** PollyZ has quit IRC08:11
lucasagomestrue, unittests should probably mock everything08:11
tangchenlucasagomes: OK, if so, then what shall we expect the real functional tests do ? Or shall we move the unit test part to the functional dir ?08:12
lucasagomesbut still it's kinda flaky to actually guarantee that we can run it all with py3, no? I was thinking on running the tempest suit against it08:12
lucasagomestangchen, we could fix those unittests to mock stuff instead of start an api server, but that would be a different problem IMO08:13
*** electrofelix has joined #openstack-ironic08:13
lucasagomesI was more thinking in the line of having jobs like pxe_{ipa, ssh} etc... running on python 308:13
tangchenlucasagomes: Yes. That is different. What I am thinking is that maybe we need to split the unit and functional tests first. They are now mixed.08:15
lucasagomestangchen, that would be nice, but I would look at it as a different problem08:15
lucasagomesboth can be done in parallel if needed08:15
lucasagomesand both needs fixing yeah08:16
tangchenlucasagomes: OK. So, I'll report another bug and link them together. :)08:16
lucasagomestangchen, cool, thanks a lot!08:16
tangchenlucasagomes: Thanks for the info. :)08:16
lucasagomesyw08:16
tangchenlucasagomes: BTW, I modified the description of the functional test REF. https://bugs.launchpad.net/ironic/+bug/149167008:19
openstackLaunchpad bug 1491670 in Ironic "[RFE] Ironic functional tests and hacking checks" [Wishlist,In progress] - Assigned to Tang Chen (tangchen)08:19
tangchenlucasagomes: Please help to review if you have any comments on it. :)08:19
lucasagomestangchen, a-ha will do08:19
tangchenThx08:19
*** PollyZ has joined #openstack-ironic08:20
*** PollyZ has quit IRC08:25
tangchenlucasagomes: Done. https://bugs.launchpad.net/ironic/+bug/1607679 :)08:30
openstackLaunchpad bug 1607679 in Ironic "[REF] Split unit and functional tests" [Undecided,New] - Assigned to Tang Chen (tangchen)08:30
lucasagomeso/ cheers08:30
*** mkrai_ has quit IRC08:31
*** bvandewa has joined #openstack-ironic08:32
*** PollyZ has joined #openstack-ironic08:33
openstackgerritGalyna Zholtkevych proposed openstack/ironic: Updated tests for db migration scripts  https://review.openstack.org/34424608:34
*** PollyZ has quit IRC08:38
*** daemontool has joined #openstack-ironic08:44
*** PollyZ has joined #openstack-ironic08:47
*** PollyZ has quit IRC08:52
*** e0ne has joined #openstack-ironic08:52
*** amotoki has quit IRC08:56
*** amotoki has joined #openstack-ironic09:00
*** PollyZ has joined #openstack-ironic09:00
*** PollyZ has quit IRC09:05
openstackgerritYuriy Zveryanskyy proposed openstack/ironic: Add node provision state change notification  https://review.openstack.org/34843709:05
*** e0ne has quit IRC09:05
*** mgould|afk is now known as mgould09:11
mgouldmorning Ironic!09:11
openstackgerritNaohiro Tamura proposed openstack/ironic: Generic power I/F for soft reboot and soft power off  https://review.openstack.org/21673009:15
*** mbound has joined #openstack-ironic09:17
*** bvandewa has quit IRC09:27
*** PollyZ has joined #openstack-ironic09:28
*** vmud213 has quit IRC09:30
*** vmud213 has joined #openstack-ironic09:30
*** PollyZ has quit IRC09:32
openstackgerritNaohiro Tamura proposed openstack/ironic: Ipmitool power driver for soft reboot and soft power off  https://review.openstack.org/21673809:37
*** fragatina has joined #openstack-ironic09:38
*** PollyZ has joined #openstack-ironic09:41
openstackgerritDavid Lenwell proposed openstack/ironic: Add REST API for volume connector operation  https://review.openstack.org/21458609:44
*** PollyZ has quit IRC09:46
openstackgerritNaohiro Tamura proposed openstack/ironic: iRMC power driver for soft reboot and soft power off  https://review.openstack.org/21674309:50
*** PollyZ has joined #openstack-ironic09:55
*** Romanenko_K has joined #openstack-ironic09:56
*** sambetts|afk is now known as sambetts09:58
sambettsMorning all09:58
*** PollyZ has quit IRC10:00
*** e0ne has joined #openstack-ironic10:01
mgouldmorning sambetts10:06
*** e0ne has quit IRC10:12
*** milan has quit IRC10:16
mgouldis it possible to stop Gerrit from emailing me every time someone comments on a review I've commented on?10:19
*** milan has joined #openstack-ironic10:25
*** sdake has joined #openstack-ironic10:25
*** mbound has quit IRC10:31
*** hoangcx has quit IRC10:33
*** hoangcx has joined #openstack-ironic10:34
jrollmgould: heavy filtering :D10:37
jrollmorning y'all10:37
sambettsmgould, jroll: morning10:37
mgouldmorning jroll!10:37
* jroll looks at folders... Gerrit (47446)10:38
mgouldalso: dammit!10:38
mgouldwon't anyone think of the poor SMTP servers?10:38
jrolllol10:38
sambettsLooks like your not the only one that wants it https://bugs.chromium.org/p/gerrit/issues/detail?id=989'10:39
sambettshttps://bugs.chromium.org/p/gerrit/issues/detail?id=98910:39
mgouldopen since 2014 :-(10:40
*** sabeen has quit IRC10:45
*** PollyZ has joined #openstack-ironic10:49
*** loki_ has quit IRC10:52
*** PollyZ has quit IRC10:54
*** vsaienk0 has quit IRC10:55
*** lujinluo has quit IRC10:56
*** e0ne has joined #openstack-ironic10:58
*** vsaienk0 has joined #openstack-ironic10:58
*** fragatina has quit IRC11:00
openstackgerritDavid Lenwell proposed openstack/ironic: Add REST API for volume target operation  https://review.openstack.org/28522111:01
*** e0ne has quit IRC11:01
openstackgerritDavid Lenwell proposed openstack/ironic: Add REST API for volume connector operation  https://review.openstack.org/21458611:04
openstackgerritDavid Lenwell proposed openstack/ironic: Add REST API for volume target operation  https://review.openstack.org/28522111:05
openstackgerritDavid Lenwell proposed openstack/ironic: Add REST API for volume connector operation  https://review.openstack.org/21458611:08
*** hoangcx2 has joined #openstack-ironic11:09
*** yuriyz has quit IRC11:10
*** Romanenko_K has quit IRC11:10
openstackgerritDavid Lenwell proposed openstack/ironic: Add REST API for volume target operation  https://review.openstack.org/28522111:10
*** hoangcx has quit IRC11:13
*** lucasagomes is now known as lucas-hungry11:14
*** Romanenko_K has joined #openstack-ironic11:24
*** sdake has quit IRC11:27
*** ijw has joined #openstack-ironic11:28
*** PollyZ has joined #openstack-ironic11:30
*** ijw has quit IRC11:30
*** ijw has joined #openstack-ironic11:31
openstackgerritDavid Lenwell proposed openstack/ironic: Add REST API for volume target operation  https://review.openstack.org/28522111:31
*** mbound has joined #openstack-ironic11:32
*** yuriyz has joined #openstack-ironic11:32
*** PollyZ has quit IRC11:35
openstackgerritDavid Lenwell proposed openstack/ironic: Add REST API for volume target operation  https://review.openstack.org/28522111:36
*** mbound has quit IRC11:36
*** ijw has quit IRC11:37
*** tangchen has quit IRC11:40
*** tangchen_ has quit IRC11:40
*** thrash|g0ne is now known as thrash11:41
*** tangchen_ has joined #openstack-ironic11:42
*** tangchen has joined #openstack-ironic11:42
*** PollyZ has joined #openstack-ironic11:43
Romanenko_KHi, Ironic team! )11:46
Romanenko_KThanks for +2s and Workflow for patch about tests for provision state commands. This patch depends on following patch, which should be merged first, because  baremetal_node_create() method is defined in it: https://review.openstack.org/#/c/301687/11:48
*** PollyZ has quit IRC11:48
*** e0ne has joined #openstack-ironic11:51
*** tangchen has quit IRC11:58
*** tangchen_ has quit IRC11:58
TheJuliaGood morning12:03
*** hwcomcn has joined #openstack-ironic12:05
*** hwcomcn has quit IRC12:07
*** hwcomcn has joined #openstack-ironic12:07
*** hwcomcn has quit IRC12:09
*** jjohnson2 has joined #openstack-ironic12:09
*** hwcomcn has joined #openstack-ironic12:10
*** PollyZ has joined #openstack-ironic12:11
*** hwcomcn has quit IRC12:11
*** hwcomcn has joined #openstack-ironic12:12
*** hwcomcn has quit IRC12:13
*** trown|outtypewww is now known as trown12:13
sambettsMorning TheJulia12:13
*** hwcomcn has joined #openstack-ironic12:14
*** ijw has joined #openstack-ironic12:16
*** PollyZ has quit IRC12:16
*** MattMan has quit IRC12:17
*** MattMan has joined #openstack-ironic12:17
*** lucas-hungry is now known as lucasagomes12:20
lucasagomessambetts, TheJulia jroll morning12:20
sambettsHey lucasagomes12:20
jrollmorning lucasagomes :)12:21
* TheJulia makes a sad frowny face as all the volume connector info stuff needs a rebasing.12:24
*** PollyZ has joined #openstack-ironic12:24
sambettsjroll: I hope my refactor of the project-config stuff didn't break the multitenant job12:25
sambettsjroll: I saw your conversation in the backscroll, did it turn out to be a problem there?12:25
jrollsambetts: I think I got distracted, I couldn't find a problem in the code though... PROJECTS=ironic is in devstack-virtual-ironic which that job inherits from12:26
openstackgerritSam Betts proposed openstack/ironic: DO NOT MERGE Testing Multitenant Job  https://review.openstack.org/34885912:27
*** ccamacho is now known as ccamacho|lunch12:28
sambetts:/ jroll ^ we can use this for debugging12:28
*** PollyZ has quit IRC12:29
*** appu1034 has joined #openstack-ironic12:37
*** aparnav has quit IRC12:37
*** PollyZ has joined #openstack-ironic12:38
*** thiagop has joined #openstack-ironic12:38
openstackgerritKyrylo Romanenko proposed openstack/python-ironicclient: Add baremetal port set command to OSC plugin  https://review.openstack.org/34728712:39
*** PollyZ has quit IRC12:43
*** ijw has quit IRC12:47
*** ijw has joined #openstack-ironic12:48
openstackgerritKyrylo Romanenko proposed openstack/python-ironicclient: Add baremetal port unset command to OSC plugin  https://review.openstack.org/34740212:52
openstackgerritKyrylo Romanenko proposed openstack/python-ironicclient: Add baremetal port set command to OSC plugin  https://review.openstack.org/34728712:52
vdroksambetts: I think multitenant job won't run on that test change12:53
thiagopgood morning, Ironicers12:53
thiagopTGIF12:53
vdroksambetts: because of https://github.com/openstack-infra/project-config/blob/master/zuul/layout.yaml#L119112:53
vdrokmorning thaig12:53
sambettsvdrok: I thought it was running on all changes now? or is it an experimental?12:53
vdrokugh, morning thiagop :)12:53
thiagopvdrok: o/12:53
sambettsvdrok: ooooooh12:53
sambettsvdrok: I see12:54
vdroksambetts: yup12:54
vdrokyou just need to change a line in some code file12:54
openstackgerritSam Betts proposed openstack/ironic: DO NOT MERGE Testing Multitenant Job  https://review.openstack.org/34885912:54
sambettsvdrok: updated ^12:54
vdrok+2 :D12:55
thiagopspeaking of it vdrok, should the ironic filter be filtering test-only patches?12:55
thiagopI find it awkward...12:56
thiagopL119512:56
vdrokthiagop: hm, why? if changes are only to unittests, only unittest/pep8 jobs are run12:57
vdrokand we don't have functional tests yet12:57
*** vmud213 has quit IRC12:57
*** fumie has quit IRC12:57
thiagopvdrok: aw, right. Because our functional tests are inside the tempest plugin12:57
thiagopgotcha12:57
*** vmud213 has joined #openstack-ironic12:57
*** jcoufal has joined #openstack-ironic12:58
vdrokbtw, small project-config change - https://review.openstack.org/#/c/345521/13:04
vdrokbrb13:04
openstackgerritJulia Kreger proposed openstack/ironic: Introduce VolumeConnector object  https://review.openstack.org/21458413:04
openstackgerritJulia Kreger proposed openstack/ironic: Introduce new RPCs to support volume connector operation  https://review.openstack.org/21458513:04
openstackgerritJulia Kreger proposed openstack/ironic: Introduce new RPCs to support volume target operations  https://review.openstack.org/28522013:04
openstackgerritJulia Kreger proposed openstack/ironic: Introduce VolumeTarget object  https://review.openstack.org/28521913:04
openstackgerritJulia Kreger proposed openstack/ironic: Add volume_targets table to save target information  https://review.openstack.org/28521813:04
openstackgerritJulia Kreger proposed openstack/ironic: Add volume_connector table to save connector information  https://review.openstack.org/20098313:04
*** links has quit IRC13:07
*** ccamacho|lunch is now known as ccamacho13:08
*** ianw has quit IRC13:10
*** ianw has joined #openstack-ironic13:10
*** ijw has quit IRC13:10
xavierrgood morning ironic :)13:16
xavierrit's friday again o/13:16
TheJuliagood morning xavierr13:17
mgouldmorning xavierr thiagop!13:17
*** rbudden has joined #openstack-ironic13:18
thiagopmgould: o/13:18
*** PollyZ has joined #openstack-ironic13:19
xavierrmgould TheJulia :D13:19
*** mjura has quit IRC13:23
*** PollyZ has quit IRC13:23
mgouldmorning TheJulia13:25
TheJuliagood morning mgould13:26
*** appu1034 has quit IRC13:31
*** PollyZ has joined #openstack-ironic13:32
*** joprovost has quit IRC13:35
*** mbound has joined #openstack-ironic13:36
*** PollyZ has quit IRC13:37
*** catintheroof has quit IRC13:42
*** mgoddard__ has joined #openstack-ironic13:45
vdrokmorning xavierr TheJulia and mgould13:48
*** mgoddard_ has quit IRC13:49
*** dansmith is now known as superdan13:49
xavierrvdrok: hi there \o13:50
*** amotoki has quit IRC13:58
lucasagomesxavierr, morning14:01
openstackgerritSam Betts proposed openstack/ironic-inspector: Add GenericLocalLinkConnectionHook processing hook  https://review.openstack.org/32108214:05
xavierrhey lucasagomes ;)14:05
*** hwcomcn has quit IRC14:16
*** joprovost has joined #openstack-ironic14:20
*** anush_ has joined #openstack-ironic14:23
*** causten has joined #openstack-ironic14:24
*** skelso has joined #openstack-ironic14:24
*** joprovost1 has joined #openstack-ironic14:25
*** joprovost has quit IRC14:25
*** joprovost1 is now known as joprovost14:25
*** PollyZ has joined #openstack-ironic14:29
*** wajdi has joined #openstack-ironic14:30
*** mgoddard__ has quit IRC14:31
*** mgoddard has joined #openstack-ironic14:31
openstackgerritMichael Turek proposed openstack/ironic: Prevent URL collisions with sub-controllers: nodes/ports  https://review.openstack.org/31451414:33
openstackgerritMichael Turek proposed openstack/ironic: Add classes for Portgroups API enablement  https://review.openstack.org/34754914:33
TheJuliacinder makes my head hurt14:33
mgouldTheJulia: :-(14:33
thiagopTheJulia: don't forget that today is international beer day14:34
TheJuliathiagop: wait?!? what?!?!14:34
*** harshs has joined #openstack-ironic14:34
* mgould googles14:34
thiagop(every friday is international beer day)14:34
mgouldAug 7, sadly14:34
* mgould wonders if we can celebrate Orthodox International Beer Day14:34
mgouldit is International Tiger Day: http://tigerday.org/14:35
* mgould wonders if anywhere around here serves Tiger beer14:35
thiagopI saw a notice that a tiger killed a woman in china this week...14:35
mgould:-(14:35
mgouldthey are huge ferocious predators, when all's said and done14:36
mgouldpredators gonna predate14:36
thiagopIt was in a safari like zoo, another woman got off the vehicle probably having an argue with his husband, the tiger got her and the other went to help, but the tiger attacked her mother instead14:36
vdrokalso System Administrator Appreciation Day14:36
thiagoppretty shocking video...14:37
* mgould congratulates the office sysadmin14:37
TheJuliait is also apparently crazy kitten day14:37
* TheJulia senses she will need to take the signifigant other out to lunch14:37
mgouldTheJulia: there's are non-crazy kittens?14:37
thiagoplol14:38
mgouldthiagop: that's pretty awful, but she really shouldn't have got out of the car14:39
thiagopmgould: yeah...14:39
TheJuliamgould: my first cat was not as crazy as the kitten we have now as well14:41
*** david-lyle has joined #openstack-ironic14:42
* mgould has only had one pair of cats, and they were both pretty crazy when they were kittens14:43
mgouldthough I suppose Haggis was generally more excitable than Josie14:43
*** jcoufal_ has joined #openstack-ironic14:44
*** jcoufal has quit IRC14:47
*** david-lyle has quit IRC14:47
*** harshs has quit IRC14:47
*** harshs has joined #openstack-ironic14:53
*** anush_ has quit IRC15:01
sambettsjroll, vdrok: I can see whats going wrong with the multitenant job15:05
jrolloh?15:05
sambettsfor some reason this  line: export PROJECTS="openstack/networking-generic-switch $PROJECTS" isn't working right, so PROJECTS is ending up with only networking-generic-switch in it...15:06
vdrokhuh15:06
sambettse.g. the $PROJECTS part isn't populating the rest of it for some reason15:06
vdrokthat's a separate builder now?15:07
sambettsright, but the separate builder populates a bash file with this then sourced in the main builder15:07
sambettsI wonder if we change it to be export PROJECTS+="..." instead if it'll work, because that seems to be working for the rest of it :/15:08
openstackgerritAkilan Pughazhendi proposed openstack/ironic: Updating dev quickstart to include compatiblity for newest distros  https://review.openstack.org/34689415:09
thiagopsambetts: I think I saw something on the devstack-gate scripts that made me conclude that editting PROJECTS is a bad idea15:10
*** jistr is now known as jistr|call15:10
thiagopsambetts: that's why I use DEVSTACK_GATE_PROJECTS_OVERRIDE15:11
sambettsvdrok: really not sure why its not working the same logic locally is working fine :/15:11
vdroksambetts: yeah, that's strange15:11
sambettsthiagop: oh? perhaps we need to look into that15:11
vdrokinspector job does the same15:11
*** jcoufal_ has quit IRC15:11
thiagopsambetts: you're running locally with devstack-gate or without?15:12
*** jcoufal has joined #openstack-ironic15:12
*** harshs has quit IRC15:13
*** harshs has joined #openstack-ironic15:13
vdrokthiagop: heh, 'add <project> to $PROJECTS' is what the logs say when failure happens :)15:13
vdrokpretty bad joke if we should not do that :)15:13
*** e0ne has quit IRC15:14
thiagopvdrok: https://github.com/openstack-infra/devstack-gate/blob/master/devstack-vm-gate-wrap.sh#L4415:14
thiagopvdrok: I think you'll need to +=15:14
sambettsthiagop: not using devstack-gate locally, and when i mean locally I mean just the same code path in bash15:14
sambettsand like vdrok says it works fine in the ironic-inspector tempest jobs15:15
thiagopvdrok: do you have a link handy for the multitenant job config?15:15
thiagopsambetts: ^15:15
sambettshttps://github.com/openstack-infra/project-config/blob/master/jenkins/jobs/ironic.yaml15:16
vdrokthiagop: it's in every run - http://logs.openstack.org/18/285218/10/check/gate-tempest-dsvm-ironic-multitenant-network-nv/67947f3/logs/localrc.txt.gz15:16
*** anush_ has joined #openstack-ironic15:16
vdrokor if you mean jenkins config it's what sambetts said15:17
*** jistr|call is now known as jistr15:17
thiagopuhh, I think I know what's happening15:18
*** PollyZ has quit IRC15:18
thiagoplemme check15:19
*** harshs has quit IRC15:19
*** skelso has quit IRC15:21
*** PollyZ has joined #openstack-ironic15:21
*** ayoung has joined #openstack-ironic15:22
vdrokmaybe devstack-virtual-ironic should be moved higher than ironic-multitenant builder?15:22
vdrokdoesn't seem so...15:23
thiagopvdrok: I think the problem isn't that the PROJECTS is empty, but that ironic isn't within it15:23
*** david-lyle has joined #openstack-ironic15:23
sambettsvdrok: then devstack-virtual-ironic would be run before ironic-multitenant has populated the extra-vars file15:23
sambettsthiagop: we know that, the problem is for some reason our job builder scripts are behaving weird15:24
sambettsthiagop: they aren't doing what we expect them to do15:24
sambettsso PROJECTS is ending up missing a bunch of things from it15:24
sambettsThe way the JJB jobs work for Ironic now, is that we have a main shell script, that does the actual devstack-gate run, and that shell script sources a file we create dynamically by using other smaller builders15:26
sambettswe do this so that we can enable specifc features on the fly without bloating the main shell script15:27
*** PollyZ has quit IRC15:27
thiagopsambetts:  http://logs.openstack.org/18/285218/10/check/gate-tempest-dsvm-ironic-multitenant-network-nv/67947f3/console.html#_2016-07-29_13_57_00_94582115:27
sambettsin the main shell script we export PROJECTS with all the projects we need, the multitenant builder puts this line in the extra-vars file that is sourced export PROJECTS="...genric-network-switch $PROJECTS"15:28
sambettsfor some reason the PROJECT variable exported in the main script isn't being picked up15:28
sambettseven though it should be15:28
*** PollyZ has joined #openstack-ironic15:30
*** ijw has joined #openstack-ironic15:30
*** mgoddard_ has joined #openstack-ironic15:30
thiagopsambetts: theory: the devstack-virtual-ironic script is calling bash on the first line15:30
thiagopsambetts: would that end up cleaning the exported variables?15:30
*** harshs has joined #openstack-ironic15:31
sambettsdevstack-virtual-ironic sources the extra-vars-file https://github.com/openstack-infra/project-config/blob/master/jenkins/jobs/ironic.yaml#L19515:31
*** harshs has quit IRC15:32
thiagopuhmm15:32
sambettstry this locally http://paste.openstack.org/show/543919/15:33
sambettsthis is what its effectvly doing15:33
*** causten has quit IRC15:34
sambettsbut for some reason in the gate its not populating the $EGGS in the sourced file even though it should15:34
*** mgoddard has quit IRC15:34
*** causten has joined #openstack-ironic15:34
*** bfournie has joined #openstack-ironic15:36
vdrokaha https://github.com/openstack-infra/project-config/blob/master/jenkins/jobs/ironic.yaml#L81115:36
vdrokthis job fails too on inspector15:36
vdrokwith the same symptoms15:37
sambetts:/ seems like something to do with the way sourcing a file is working on the version of bash in the gate...15:37
vdrokmaybe source is somehow run under different user?15:38
*** causten has quit IRC15:38
*** sdake has joined #openstack-ironic15:39
sambettsthat doesn't make any sense, why aren't exported vars making it through to the sourced file...15:40
*** ijw has quit IRC15:40
sambettsthat just seems wrong in all accounts, unless they've somehow turned of environment variables passing to sub-shells15:40
openstackgerritJulia Kreger proposed openstack/ironic: Add volume_connector table to save connector information  https://review.openstack.org/20098315:40
devanandag'morning, all15:41
sambettsHey devananda15:41
vdrokmorning devananda15:41
thiagopmorning devananda15:41
devanandaJayF: it turns out, oslo.policy doesn't allow there to _not_ be a policy file. it's an open bug in the project ...15:41
*** PollyZ has quit IRC15:41
JayFdevananda: ...that's a pretty terrible bug15:41
openstackgerritJulia Kreger proposed openstack/ironic: Introduce VolumeConnector object  https://review.openstack.org/21458415:42
openstackgerritJulia Kreger proposed openstack/ironic: Introduce new RPCs to support volume connector operation  https://review.openstack.org/21458515:42
*** PollyZ has joined #openstack-ironic15:43
openstackgerritJulia Kreger proposed openstack/ironic: Add volume_targets table to save target information  https://review.openstack.org/28521815:43
openstackgerritJulia Kreger proposed openstack/ironic: Introduce VolumeTarget object  https://review.openstack.org/28521915:43
openstackgerritJulia Kreger proposed openstack/ironic: Introduce new RPCs to support volume target operations  https://review.openstack.org/28522015:43
devanandahttps://bugs.launchpad.net/oslo.policy/+bug/160332915:44
openstackLaunchpad bug 1603329 in oslo.policy "Allow policy file to not exist" [Undecided,Confirmed] - Assigned to Kseniya Tychkova (ktychkova)15:44
sambettsvdrok: the logic works locally in bash :'( http://paste.openstack.org/show/543922/15:48
vdrokyeah that works for me too15:50
sambettsvdrok: looks like the addition DEVSTACK_LOCAL_CONFIGS aren't getting through either :'(15:51
sambettsseriously... why isn't sourcing a file in bash working period in the gate...15:53
openstackgerritKyrylo Romanenko proposed openstack/python-ironicclient: Add tests for openstackclient plugin  https://review.openstack.org/30168715:53
*** skelso has joined #openstack-ironic15:56
openstackgerritDevananda van der Veen proposed openstack/ironic: Add keystone policy support to Ironic  https://review.openstack.org/32559915:56
openstackgerritMilan Kováčik proposed openstack/ironic-inspector: Introducing node introspection state management  https://review.openstack.org/34894315:56
*** vishwanathj has joined #openstack-ironic15:57
*** jcoufal has quit IRC15:59
*** jcoufal has joined #openstack-ironic15:59
*** pcaruana has quit IRC16:01
sambettsvdrok: asking in infra now16:01
*** mgoddard has joined #openstack-ironic16:01
*** mgoddard_ has quit IRC16:01
vdrokheh, separate shell for every builder16:02
sambettsvdrok: yeah, thats why I have to write it to a file16:07
sambettsvdrok: and then source it16:07
sambettsvdrok: if they were all run in one shell there would be no need for the sourcing magic16:07
*** rama_y has joined #openstack-ironic16:10
*** vmud213 has quit IRC16:10
*** vmud213 has joined #openstack-ironic16:10
*** harshs has joined #openstack-ironic16:10
*** skelso has quit IRC16:11
openstackgerritDevananda van der Veen proposed openstack/ironic: Update documentation for keystone policy support  https://review.openstack.org/34555616:12
openstackgerritDevananda van der Veen proposed openstack/ironic: Mask configdrive contents in API responses  https://review.openstack.org/32676816:12
openstackgerritDevananda van der Veen proposed openstack/ironic: Add keystone policy support to Ironic  https://review.openstack.org/32559916:12
*** jcoufal has quit IRC16:13
*** jcoufal has joined #openstack-ironic16:14
*** bvandewa has joined #openstack-ironic16:14
*** bvandewa has quit IRC16:15
milansambetts, hi :)16:17
milansambetts, I could use some early feedback on an inspector patch16:17
openstackgerritLucas Alvares Gomes proposed openstack/ironic-lib: Extend parse_root_device_hints to support operators  https://review.openstack.org/34895316:17
sambettsvdrok, jroll: Worked out what the problem was16:18
milansambetts,  mostly whether it isn't a complete piece of ... ;) https://review.openstack.org/#/c/348943/116:18
sambettsmilan: sure I'll add it to my list for Monday, I'll be heading out soon16:18
milansambetts, thanks16:18
milansame here actually ;)16:18
sambettsvdrok, jroll: https://review.openstack.org/#/c/348949/16:19
vdroksambetts: huh, cool!16:19
jrollsambetts: O_O16:20
sambettsvdrok: basically it was trying to substitute the variable at the point it wrote the code into ironic-extra-vars, instead of processing it when we sourced the file16:20
sambettsadding the quotes onto the EOF prevents any processing of the code, until we source the script in ironic-virtual-devstack late16:21
sambettslater*16:21
sambettsso my bash logic was sound, its just the pre-processing of the script screwing with everything16:22
sambettsvdrok: also I was wrong, the DEVSTACK_LOCAL_CONFIGs we were +=ing worked fine16:22
sambettsso it was just the substitutions that busted things16:23
vdrokgreat finding, thanks!16:24
sambettswell with the size of my refactor 2 jobs breaking out of however many jobs we have isn't bad :)16:24
vdrokyeah, not bad at all!16:24
*** trown is now known as trown|lunch16:25
sambettsstill need to update few of the other jobs to fit into the new naming scheme though16:25
* sambetts -> home 16:26
sambettsnight all16:26
*** jpich has quit IRC16:26
*** sambetts is now known as sambetts|afk16:27
vdrokgood night sambetts|afk16:28
*** tesseract- has quit IRC16:30
openstackgerritKyrylo Romanenko proposed openstack/python-ironicclient: Verify JSON response of driver commands  https://review.openstack.org/33660016:34
lucasagomesfolks I'm calling it a day here16:36
lucasagomeshave a great evening, enjoy the weekend16:36
lucasagomesmonday is national holiday here, I will try to make it to the meeting16:36
TheJuliagoodnight lucasagomes16:39
lucasagomessee ya :-)16:40
*** lucasagomes is now known as lucas-dinner16:41
jrollI believe the multi-compute stuff is ready to review, if anyone's interested16:41
jrollhttps://review.openstack.org/#/c/348443/16:41
jrollcame out much nicer than I thought it would16:41
*** e0ne has joined #openstack-ironic16:45
*** e0ne has quit IRC16:46
openstackgerritKyrylo Romanenko proposed openstack/python-ironicclient: Add tests for openstackclient plugin  https://review.openstack.org/34896216:48
openstackgerritKyrylo Romanenko proposed openstack/python-ironicclient: Add tests for openstackclient plugin  https://review.openstack.org/30168716:54
openstackgerritTang Chen proposed openstack/ironic: [WIP] Split API root unit and functional tests  https://review.openstack.org/34896516:55
*** thrash is now known as thrash|biab16:56
*** tangchen has joined #openstack-ironic16:56
*** tangchen_ has joined #openstack-ironic16:56
*** PollyZ has quit IRC16:56
*** derekh has quit IRC16:57
*** tangchen_ has quit IRC17:01
*** tangchen has quit IRC17:01
*** wajdi_ has joined #openstack-ironic17:01
*** ijw has joined #openstack-ironic17:02
*** wajdi_ has quit IRC17:02
openstackgerritKyrylo Romanenko proposed openstack/python-ironicclient: Add tests for openstackclient plugin  https://review.openstack.org/30168717:02
*** vmud213 has quit IRC17:02
*** wajdi_ has joined #openstack-ironic17:02
NobodyCamMorning ironic'ers... says the man on the road17:03
thiagopgood finding sambetts|afk , have a nice weekend17:04
*** wajdi has quit IRC17:05
thiagopmorning NobodyCam17:06
vdrokgood morning NobodyCam !17:06
*** wajdi has joined #openstack-ironic17:07
Romanenko_KHello, NobodyCam )17:07
*** skelso has joined #openstack-ironic17:08
*** wajdi_ has quit IRC17:10
openstackgerritRamamani Yeleswarapu proposed openstack/ironic: Centralize config options - [pxe]  https://review.openstack.org/30961217:11
*** ChrisMead has quit IRC17:12
*** skelso has quit IRC17:14
*** ccamacho has quit IRC17:15
openstackgerritRamamani Yeleswarapu proposed openstack/ironic: Centralize config options - [pxe]  https://review.openstack.org/30961217:15
*** harshs has quit IRC17:17
*** milan has quit IRC17:17
*** ijw has quit IRC17:18
*** harshs has joined #openstack-ironic17:21
openstackgerritNisha Agarwal proposed openstack/ironic-specs: Add new out-of-band properties to ilo drivers  https://review.openstack.org/33813817:22
xavierrmorning NobodyCam o/17:22
openstackgerritThiago Paiva Brito proposed openstack/ironic: Onetime boot when set_boot_device isn't persistent  https://review.openstack.org/34059617:23
thiagoptwo line "too much easy" review for you folks to take a look ^^17:23
*** loki_ has joined #openstack-ironic17:24
thiagopAnd if you have a quarter of hour more, please review our child: https://review.openstack.org/#/c/286192/17:25
*** skelso has joined #openstack-ironic17:28
*** harshs has quit IRC17:30
loki_review please https://review.openstack.org/#/c/272658/17:30
*** loki__ has joined #openstack-ironic17:33
*** loki_ has quit IRC17:35
*** skelso has quit IRC17:37
*** loki__ has quit IRC17:38
openstackgerritMichael Turek proposed openstack/ironic: Add classes for Portgroups API enablement  https://review.openstack.org/34754917:38
*** trown|lunch is now known as trown17:39
*** loki_ has joined #openstack-ironic17:39
*** Romanenko_K has quit IRC17:41
* mgould -> home; good night!17:44
*** mgould is now known as mgould|afk17:44
thiagopgood night mgould|afk17:46
openstackgerritNisha Agarwal proposed openstack/ironic-specs: Enhance ilo drivers to do inband inspection  https://review.openstack.org/20190417:48
*** harshs has joined #openstack-ironic17:49
*** e0ne has joined #openstack-ironic17:50
openstackgerritVladyslav Drok proposed openstack/ironic: Cleanup internal_info if auto cleaning is disabled  https://review.openstack.org/34898317:51
* vdrok leaves too17:53
vdrokhave a great weekend!17:53
*** links has joined #openstack-ironic17:54
*** mjturek1 has quit IRC17:57
*** livelace has quit IRC17:59
*** harshs has quit IRC18:00
*** harshs has joined #openstack-ironic18:00
*** joprovost1 has joined #openstack-ironic18:01
thiagophave a nice weekend vdrok18:02
*** joprovost has quit IRC18:03
*** joprovost1 is now known as joprovost18:03
*** mjturek1 has joined #openstack-ironic18:04
JayFdevananda: https://review.openstack.org/#/c/325599 has my +2 with nits; but still am curious about what we're going to do with policy.json.sample; it's not valid JSON so it seems a little weird to have it in the repo18:06
JayFdevananda: it feels like you meant to only have one of policy.json.sample || policy.yaml.sample committed18:07
thiagopI'd vote for a valid json too, but with the comments if possible18:07
JayFno such thing as valid json with comments :)18:07
JayFJSON standard doesn't allow for comments18:08
thiagopJayF: so, move it into the docs page (with some formatting, of course)?18:08
*** sabeen has joined #openstack-ironic18:08
JayFI mean, I don't care that much beyond it being clear (my preference is to just use the yaml), but whatever we include needs to be generated by that tox target18:09
JayFand I don't think the policy generator makes valid json so...18:09
JayFand I'm -1 to putting it in docs b/c like the sample config, it'll change frequently as we add new features, so it should be managed like that sample config18:09
thiagopMy fear is that I understand the policy and the endpoints, but new operators may not18:09
JayFsure; but a policy.yaml.sample explains it just as well as something else18:11
JayFthe docs (which I'm about to start reviewing now) should generically cover policy; but because the default applied policy is "living", it needs to be managed outside of docs18:11
*** PollyZ has joined #openstack-ironic18:12
*** skelso has joined #openstack-ironic18:12
*** ijw has joined #openstack-ironic18:13
JayFif a specs core could look at and land this: https://review.openstack.org/#/c/345039/ it'd be helpful, since the keystone code following those changes is about to land soon :)18:14
*** mtanino has joined #openstack-ironic18:14
*** mjturek1 has quit IRC18:18
*** loki_ has quit IRC18:18
*** anush_ has quit IRC18:18
*** anush_ has joined #openstack-ironic18:19
*** ijw has quit IRC18:20
thiagopFolks, I'm kinda sick so I'm calling it a day earlier18:23
thiagopHave a nice weekend18:23
*** thiagop has quit IRC18:23
NobodyCamMorning thiagop xavierr vdrok :)18:24
*** loki__ has joined #openstack-ironic18:25
JayFo/ feel better18:26
natoriouswhy isn't the image deploy process part of the agent hardware managers?18:26
*** electrofelix has quit IRC18:28
openstackgerritNisha Agarwal proposed openstack/ironic: Enhance ilo drivers to do inband-inspection This fix allow ilo drivers to do inband inspection using ironic-inspector when `oob_inspection_only` config is set to False.  https://review.openstack.org/34357718:28
natoriousbeen trying to think beyond legacy boot18:29
JayFI think, generally, that the deploy process (including how the image is written) is generally driven by the deploy driver18:31
JayFso maybe the right place to change that process would be via a different conductor deploy driver18:32
JayFbut I'm curious what you wanna do18:32
natoriousI'd like to be able to trigger deploy steps similarly to how you can clean steps18:32
natoriousfor easier rapid itteration18:33
JayFdo you have a solid example so I can understand better?18:33
JayFWe have talked about the idea of "deploy steps" with prepare_image and write_configdrive being implied as final two steps in any case18:34
JayFbut I don't think it's been codified in a spec or gone beyond "hallway conversations"18:34
natorioussure, so say your deving on uefi and want to just run one part of that say like write uefi part18:34
*** thrash|biab is now known as thrash18:34
JayFSo you're wanting to break up the deploy into smaller pieces18:35
natoriousor just want to write the image to a raid set and then check to make sure its how it should be18:35
natoriousyeah18:35
JayFso like using standalone mode it's easier to develop on a given piece18:35
JayFI think the idea of deploy steps, like clean steps, would permit that somewhat18:35
JayFand would be interesting to pursue18:35
JayFI'd def. review that spec if you put it up as an idea :)18:35
natoriousnoted :)18:36
*** rbudden has quit IRC18:41
JayFjroll: is https://review.openstack.org/#/c/204641/ still valid at all with the new scheduling stuff? I'm thinking no?18:42
*** jcoufal has quit IRC18:43
*** jcoufal has joined #openstack-ironic18:44
*** rama_y has quit IRC18:45
*** harshs has quit IRC18:46
*** skelso has quit IRC18:47
*** loki__ has quit IRC18:47
*** sdake has quit IRC18:47
*** skelso has joined #openstack-ironic18:52
*** rama_y has joined #openstack-ironic18:53
*** achanda has joined #openstack-ironic18:55
*** hoonetorg has quit IRC18:56
openstackgerritStephanie Miller proposed openstack/python-ironicclient: Add volume_connector support  https://review.openstack.org/21478618:57
*** ijw has joined #openstack-ironic18:57
openstackgerritStephanie Miller proposed openstack/python-ironicclient: Add volume_target support  https://review.openstack.org/28523318:57
*** PollyZ has quit IRC19:02
*** bks has joined #openstack-ironic19:02
*** ijw has quit IRC19:03
*** bnemec is now known as beekneemech19:12
*** skelso has quit IRC19:12
*** penick has joined #openstack-ironic19:14
*** ijw has joined #openstack-ironic19:15
*** joprovost has quit IRC19:19
*** joprovost has joined #openstack-ironic19:19
*** links has quit IRC19:20
*** bvandewa has joined #openstack-ironic19:22
*** PollyZ has joined #openstack-ironic19:24
*** ijw has quit IRC19:25
*** skelso has joined #openstack-ironic19:33
*** sdake has joined #openstack-ironic19:35
*** bvandewa has quit IRC19:35
*** skelso has quit IRC19:39
*** joprovost1 has joined #openstack-ironic19:44
*** joprovost has quit IRC19:47
*** joprovost1 is now known as joprovost19:47
TheJuliadevananda: I've been thinking about 325599, would it be awful to bump the microversion as well just to signify "Hey, policy support was inserted, although is API wide regardless of version any pending API changes might need it too"19:51
JayFTheJulia: We didn't change the api.19:51
JayFTheJulia: unless we were going to not enforce policy for earlier microversions that doesn't make sense.19:52
*** krtaylor has quit IRC19:52
TheJuliaWell, technically we have, we're changing the policy handling, it is just not self-apparent nor negotiable.  I'm thinking of a force people to encounter a merge conflict on any api changes such that visibility is raised19:55
* TheJulia might just be a horrible person though19:55
TheJulias/have/are/19:55
openstackgerritXavier proposed openstack/python-oneviewclient: Add auditing instrumentation for python-oneviewclient  https://review.openstack.org/33728119:56
*** skelso has joined #openstack-ironic19:58
JayFTheJulia: should microversion be used for a developer signal? I don't think so; I think it's intended to signal API changes to clients19:58
*** ijw has joined #openstack-ironic19:58
*** sdake has quit IRC19:59
*** e0ne has quit IRC20:04
TheJuliaOr just edit the line before or after, we don't actually have to bump the version.  I guess my only concern is that it is a bit of a major change that breaks the convention that we've built via microversions thus far.  Each change breaks the next change in line until it is fixed.  It might be in release notes, but that doesn't mean awarness may be raised unless someone actively encounters a bloc20:05
TheJuliak that has to be navigated around.  I guess it is that or a checklist, or a test that actively hunts for any missing policy definitions in the code (which actually might be a better idea now that I think about it).20:05
devanandaTheJulia: I do not think changing the api version is a reasonable to thing to do with the policy change20:06
TheJuliaok20:07
devanandaTheJulia: because it presents a false contract: if we claim that >= v1.21 there is policy support, it implies that a client can ask for v<1.21 and bypass all the policy20:07
JayFTheJulia: I suspect the more prudent path is for us (you, me, whoever) as cores to dig through API changes, and tag them with a -1 support policy if they don't20:07
*** ijw has quit IRC20:07
devanandaTheJulia: and it's not a change in the semantics of any API request at all20:07
devanandathe same admin user that could do $things before can still do exactly the same $things20:08
devanandawe're enabling the operator to adjust when ironic throws a NotAuthorized error -- not changing what exceptions can be returned, or how the REST API itself works20:08
TheJuliaJayF: Agreed, although at the same time we likely need testing for it anyway20:08
devanandaI've been thinking about ways to enforce that every API endpoint has a policy applied to it20:09
devanandabut haven't written up a test for that yet20:09
devanandaI suppose that would be really useful, eh?20:09
TheJuliayeah, a nice red flag that there is a major problem potentially20:09
devanandaJayF: to your question about policy.json.sample - that file is YAML and, unsurprisingly, works fine20:10
JayFdevananda: then we should probably nuke the policy.yaml.sample also in that patchset20:10
devanandaoh. doh.20:10
JayFdevananda: my concern was more that we provided both, and only generated one20:10
devanandaI thought I had deleted that20:10
devananda(merge error)20:10
JayFdevananda: although I'd prefer it to say yaml if it is yaml *shrug* otherwise20:10
devanandawell, I would too, except oslo20:10
JayFdevananda: you wanna fix the couple other small nits and I'll give it a clean +@?20:11
*** baoli has quit IRC20:11
JayF*+220:11
devanandaoslo.policy documents *everywhere* that it's a .json file20:11
JayFyeah, I know, that's ... annoying20:11
devanandaeven though it's not20:11
*** rbudden has joined #openstack-ironic20:11
* devananda looks to see what other nits are there20:11
*** bvandewa has joined #openstack-ironic20:12
devanandaJayF: anything else besides commit message typo?20:12
JayFdevananda: whitespace in the tox20:13
JayFand the thing in the release notes is now irreleveant20:13
devanandawhat is?20:13
*** joprovost has quit IRC20:13
JayFcommands = # in your tox.init that oyu added has trailing whitespace20:14
JayFthe release note comment was continued yaml vs json confusion20:14
openstackgerritAkilan Pughazhendi proposed openstack/ironic: Updating dev quickstart to include compatiblity for newest distros  https://review.openstack.org/34689420:15
*** ijw has joined #openstack-ironic20:21
*** rama_y has quit IRC20:21
*** ijw has quit IRC20:27
JayFdevananda: did you mean to push a patch set up and didn't? /me itching to +2 it, lol20:29
JayFI'm excited about policy landing20:29
*** rama_y has joined #openstack-ironic20:31
*** achanda has quit IRC20:34
devanandaJayF: I have it ready, then started working on a new test case20:34
devanandaI can do that in a follow on20:34
openstackgerritDevananda van der Veen proposed openstack/ironic: Update documentation for keystone policy support  https://review.openstack.org/34555620:34
openstackgerritDevananda van der Veen proposed openstack/ironic: Mask configdrive contents in API responses  https://review.openstack.org/32676820:34
openstackgerritDevananda van der Veen proposed openstack/ironic: Add keystone policy support to Ironic  https://review.openstack.org/32559920:34
openstackgerritDevananda van der Veen proposed openstack/ironic: [WIP] Hide driver[_internal]_info from observer role  https://review.openstack.org/34507620:34
JayFeither way is fine :) I'm just excited and that makes me impatient20:34
JayFlol20:34
devanandatadaa!20:35
*** wajdi has quit IRC20:42
*** wajdi has joined #openstack-ironic20:42
JayFTheJulia: https://review.openstack.org/#/c/325599 I think we should land this, unless there's a good reason not to. Had Multiple +2s, and the only things fixed were minor nits20:46
*** wajdi has quit IRC20:49
*** jjohnson2 has quit IRC20:58
*** trown is now known as trown|outtypewww20:59
*** bvandewa has quit IRC21:04
*** sabeen has quit IRC21:23
*** skelso has quit IRC21:27
*** ppiela has quit IRC21:28
*** aNupoisc has joined #openstack-ironic21:30
*** adnavare has joined #openstack-ironic21:30
*** adnavare has quit IRC21:33
*** aNupoisc has quit IRC21:33
*** aNupoisc has joined #openstack-ironic21:33
*** bvandewa has joined #openstack-ironic21:35
*** daemontool has quit IRC21:41
jrollJayF: 204641 probably isn't needed, no. I need to take some time to go back and clean up all the old artifacts of this stuff21:42
JayFjroll: that's what I thought; I skipped reviewing it21:42
jrollcool21:42
JayFjroll: you should totally land policy while you're here21:42
JayFjroll: all the nits are fixed, I have a clean +2 on it21:42
jrollJayF: I just -1d it :)21:42
jrollit's still a yaml file21:43
jrollin the sample21:43
JayFbut it's rendered fine by oslo policy21:43
jrollhuh?21:43
JayFimo making that file be valid json is a bug in the config generator oslo provides21:43
jrollhttps://review.openstack.org/#/c/325599/20/etc/ironic/policy.json.sample21:43
jrollis not json21:43
JayFyep, oslo policy takes yaml input too21:43
jrollI understand21:43
JayFand the only reason we don't name it yaml is all the oslo policy docs say json all over21:43
jrollbut we shouldn't call it .json imo21:43
JayFand default to json21:43
jroll-.-21:44
JayFyep, exactly21:44
JayFI don't love it either, but the bugs are oslo.policy's, not ours21:44
*** dims_ has quit IRC21:44
jrollI'm seeing this in scrollback now but I hadn't read that far21:44
*** ayoung has quit IRC21:44
jrollcan we at least drop a todo or bug ref or something?21:44
JayFdrop it where?21:44
JayFnot in that generated config file21:44
jrollidk, tox.ini?21:45
jrollor maybe even in that sample21:45
JayFI guess we could? I honestly wouldn't consider it a good reason to hold it up, but if you do you can -1 it :(21:45
JayFnot in the sample21:45
JayFbecause that's generated21:45
jrollwhy?21:45
jrollugh21:45
JayFyeah, that's why I'm like, lets make sure there's a bug against the config generator21:45
JayFand move on21:45
*** dims has joined #openstack-ironic21:46
jrolloslopolicy-sample-generator --namespace=ironic.api --output-file=etc/ironic/policy.json.sample && echo "# this isn't actually json, sorry\n $(cat policy.json.sample)" > policy.json.sample21:46
jroll:)21:46
jrollis there a bug against the generator?21:46
JayFI'll make sure there is right meow21:47
jrollk21:47
JayFthere's another bug, you can't run oslo policy stuff w/o a config file at all21:47
JayFso even in a clean ironic install you need the file there21:47
JayFor it breaks21:47
JayFthat bug is filed, and is very unsavory21:47
jrollunsavory why?21:48
jrollas in, annoying for ops?21:48
JayFyes.21:48
JayFan empty config file being required is silly21:48
jrollyeah21:48
JayFjroll: https://bugs.launchpad.net/oslo.policy/+bug/160796821:51
openstackLaunchpad bug 1607968 in oslo.policy "oslopolicy-sample-generator does not output json, but docs always reference json" [Undecided,New]21:51
jrollok thanks21:51
jrolllet me re-review21:51
*** rbudden has quit IRC21:51
*** PollyZ has quit IRC21:51
openstackgerritMerged openstack/ironic-specs: Update the keystone-policy spec  https://review.openstack.org/34503921:52
*** bvandewa has quit IRC21:57
jrollwoo, policy approved21:57
bkshttps://review.openstack.org/#/c/32523022:01
*** superdan has quit IRC22:07
*** PollyZ has joined #openstack-ironic22:08
*** bks has quit IRC22:08
*** achanda has joined #openstack-ironic22:13
*** ijw has joined #openstack-ironic22:14
*** PollyZ has quit IRC22:16
*** ijw has quit IRC22:24
devanandawoot!22:28
*** jcoufal_ has joined #openstack-ironic22:33
*** jcoufal has quit IRC22:34
JayFOur grenade job is apparently building tinyipa from source22:36
JayFhttp://logs.openstack.org/24/348624/1/gate/gate-grenade-dsvm-ironic/0f6c6d8/logs/grenade.sh.txt.gz#_2016-07-29_22_19_59_33022:37
JayFand it just caused a job to fail (the linked one022:37
JayFthe default in stable/mitaka is apparently to build the ramdisk https://github.com/openstack/ironic/blob/stable/mitaka/devstack/lib/ironic#L9722:38
JayFand we don't change that in the grenade job22:39
JayFhttps://github.com/openstack/ironic/blob/master/devstack/lib/ironic#L13422:39
JayFwe apparently default it to true at master as well22:39
JayFhttp://logs.openstack.org/24/348624/1/check/gate-tempest-dsvm-ironic-ipa-wholedisk-agent_ssh-tinyipa/0187ac8/logs/devstacklog.txt.gz#_2016-07-29_03_15_25_48922:40
JayFand we're building tinyipa in the non -src jobs too22:40
JayFaye carumba!22:40
devananda:-/22:42
JayFI'm going to find an old patchset to see if this was introduced by the refactoring just landing22:43
JayFdevananda: wdyt about just changing that devstack default?22:43
*** jcoufal_ has quit IRC22:43
JayFa job run Jul 20 had the option set to False in localrc http://logs.openstack.org/68/344668/2/check/gate-tempest-dsvm-ironic-agent_ssh/27e9b20/logs/localrc.txt.gz22:44
devanandaas an aside, the project-config refactor seems to have also added a lot of new job runs to each patch22:45
devanandaJayF: if we change the default in devstack on master, it won't fix the issue on stable/mitaka22:45
devanandaI think it's reasonable for devstack to default to download the image rather than build it every time, fwiw22:46
*** rama_y has quit IRC22:46
JayFI'm going to put that change up22:46
*** rama_y has joined #openstack-ironic22:46
JayFand file a bug about the change in behavior22:46
JayFdo you have an example list of jobs before/after you can add as a comment to it?22:46
devanandanot off hand -- I'd just look at any patch set from a few weeks ago vs. now22:47
JayFsambetts wrote that refactor, right?22:48
JayFgoing to assign that bug to him when I file it since he might have an idea what's up22:48
*** Guest41489 has joined #openstack-ironic22:49
openstackgerritMerged openstack/python-ironicclient: Add internal_info field to port  https://review.openstack.org/34155222:49
*** harshs has joined #openstack-ironic22:54
*** harshs has quit IRC22:54
JayFdevananda: I believe the "more jobs" problem is xenial22:58
*** harshs has joined #openstack-ironic23:00
*** Guest41489 has quit IRC23:02
openstackgerritJay Faulkner proposed openstack/ironic: Devstack should use a prebuilt ramdisk by default  https://review.openstack.org/34911223:05
JayFdevananda: ^23:05
*** harshs has quit IRC23:06
*** jcoufal has joined #openstack-ironic23:07
JayFnevermind, that can't merge until the project-config bit is set23:08
JayFor else the -src jobs on IPA will behave wrongly23:08
JayFI think that's a bug I'm going to leave for the morning :(23:08
JayFs/the/monday/23:08
*** harshs has joined #openstack-ironic23:15
*** achanda has quit IRC23:17
*** Guest39119 has joined #openstack-ironic23:26
*** thrash is now known as thrash|wknd23:32
*** daemontool has joined #openstack-ironic23:34
*** anush_ has quit IRC23:46
*** jcoufal_ has joined #openstack-ironic23:48
*** jcoufal has quit IRC23:49
*** vishwanathj has quit IRC23:52
*** Guest39119 is now known as dansmith23:52
*** achanda has joined #openstack-ironic23:58

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!