Tuesday, 2016-06-28

*** [1]cdearborn has joined #openstack-ironic00:06
*** rama_y has quit IRC00:09
*** piet has quit IRC00:09
openstackgerritMichael Davies proposed openstack/python-ironicclient: Add env var for version cache timeout  https://review.openstack.org/33438700:12
*** sdake has quit IRC00:15
*** jaybeale has quit IRC00:33
*** jaybeale has joined #openstack-ironic00:35
*** aNupoisc has quit IRC00:42
*** klindgren_ has quit IRC00:42
openstackgerritMerged openstack/ironic: Centralize config options - [ilo]  https://review.openstack.org/30194700:43
openstackgerritMerged openstack/ironic: Centralize config options - [inspector]  https://review.openstack.org/30195500:44
openstackgerritMerged openstack/ironic: Remove unnecessary calls to dict.keys()  https://review.openstack.org/33447600:45
*** jaybeale has quit IRC00:45
*** jaybeale has joined #openstack-ironic00:45
*** Sukhdev has joined #openstack-ironic00:50
*** jaybeale has quit IRC00:50
*** jaybeale has joined #openstack-ironic00:56
openstackgerritMerged openstack/ironic: Fix parameter create-node.sh  https://review.openstack.org/32573200:57
openstackgerritMerged openstack/ironic: Fail early if ramdisk type is dib, and not building  https://review.openstack.org/32824600:57
openstackgerritMerged openstack/ironic: Fix releasenotes formatting error  https://review.openstack.org/33471200:58
*** joprovost has joined #openstack-ironic01:00
*** baoli has joined #openstack-ironic01:01
*** baoli has quit IRC01:01
*** baoli has joined #openstack-ironic01:02
openstackgerritMichael Davies proposed openstack/python-ironicclient: Add env var for version cache timeout  https://review.openstack.org/33438701:04
*** joprovost1 has joined #openstack-ironic01:05
*** joprovost has quit IRC01:06
*** joprovost1 is now known as joprovost01:06
*** piet has joined #openstack-ironic01:08
*** yibo has joined #openstack-ironic01:10
*** rcernin has quit IRC01:11
*** baoli has quit IRC01:15
openstackgerritMichael Davies proposed openstack/python-ironicclient: Add env var for version cache timeout  https://review.openstack.org/33438701:15
*** stendulker has joined #openstack-ironic01:17
*** baoli has joined #openstack-ironic01:19
*** baoli_ has joined #openstack-ironic01:21
*** yuanying has quit IRC01:22
*** piet has quit IRC01:22
*** baoli has quit IRC01:24
*** yuanying has joined #openstack-ironic01:25
*** sabeen has quit IRC01:33
*** jaybeale has quit IRC01:36
*** PollyZ has joined #openstack-ironic01:40
*** amotoki has joined #openstack-ironic01:42
*** amotoki has quit IRC01:46
openstackgerritYibo Cai proposed openstack/ironic: Support multi arch deployment  https://review.openstack.org/32263201:49
*** Sukhdev has quit IRC01:52
*** piet has joined #openstack-ironic01:56
*** sacharya has joined #openstack-ironic01:59
openstackgerritYuiko Takada Mori proposed openstack/ironic: Follow-up patch of 9a1aeb76da2ed53e042a94ead8640af9374a10bf  https://review.openstack.org/33473102:16
*** fragatina has joined #openstack-ironic02:18
*** fragatina has quit IRC02:18
*** fragatina has joined #openstack-ironic02:19
*** sacharya_ has joined #openstack-ironic02:24
*** rbudden has quit IRC02:27
openstackgerritRuby Loo proposed openstack/python-ironicclient: Simplify use of config_drive arg in osc  https://review.openstack.org/33473502:27
*** sacharya has quit IRC02:27
*** stendulker has quit IRC02:28
*** jaybeale has joined #openstack-ironic02:30
openstackgerritMichael Davies proposed openstack/python-ironicclient: Add env var for version cache timeout  https://review.openstack.org/33438702:31
*** mtreinish has quit IRC02:36
*** mtreinish has joined #openstack-ironic02:36
*** jaybeale has quit IRC02:36
*** chlong has quit IRC02:37
*** PollyZ has quit IRC02:37
*** jaybeale has joined #openstack-ironic02:38
*** PollyZ has joined #openstack-ironic02:39
*** rloo has quit IRC02:39
*** sdake has joined #openstack-ironic02:40
*** PollyZ_ has joined #openstack-ironic02:44
*** PollyZ has quit IRC02:44
*** hoangcx has joined #openstack-ironic02:44
*** jaybeale has quit IRC02:48
*** jaybeale has joined #openstack-ironic02:49
*** chlong has joined #openstack-ironic02:50
*** yuanying has quit IRC02:50
*** sdake has quit IRC02:56
*** joprovost has quit IRC02:58
*** jaybeale has quit IRC03:05
*** sdake has joined #openstack-ironic03:08
*** [1]cdearborn has quit IRC03:11
*** sabeen has joined #openstack-ironic03:19
*** PollyZ_ has quit IRC03:27
*** sdake has quit IRC03:27
openstackgerritMerged openstack/ironic: Centralize config options - [ipmi]  https://review.openstack.org/30196703:31
openstackgerritMerged openstack/ironic: Centralize config options - [irmc]  https://review.openstack.org/30247603:31
*** PollyZ has joined #openstack-ironic03:32
*** amotoki has joined #openstack-ironic03:32
*** MattMan has quit IRC03:40
*** MattMan has joined #openstack-ironic03:41
*** PollyZ has quit IRC03:44
openstackgerritDao Cong Tien proposed openstack/ironic: Nova-compatible serial console: socat console_utils  https://review.openstack.org/32816803:46
*** praneshp has joined #openstack-ironic03:47
*** yuanying has joined #openstack-ironic03:48
*** jjohnson2 has quit IRC03:48
*** PollyZ has joined #openstack-ironic03:48
*** persia has quit IRC03:49
*** sabeen has joined #openstack-ironic03:49
*** links has joined #openstack-ironic03:50
*** persia has joined #openstack-ironic03:56
*** yuanying has quit IRC04:00
*** yuanying has joined #openstack-ironic04:01
*** PollyZ has quit IRC04:02
*** appu103_ has joined #openstack-ironic04:07
*** appu103_ is now known as aparnav04:07
*** baoli_ has quit IRC04:10
*** PollyZ has joined #openstack-ironic04:13
*** rama_y has joined #openstack-ironic04:15
*** sabeen has quit IRC04:20
*** sabeen has joined #openstack-ironic04:21
*** jtomasek_ has joined #openstack-ironic04:32
*** PollyZ has quit IRC04:36
*** amotoki has quit IRC04:37
*** fragatina has quit IRC04:39
*** PollyZ has joined #openstack-ironic04:41
*** sabeen has quit IRC04:44
*** sabeen has joined #openstack-ironic04:45
*** rama_y has quit IRC04:46
*** rcernin has joined #openstack-ironic04:47
*** yuanying has quit IRC04:49
*** rama_y has joined #openstack-ironic04:49
*** PollyZ has quit IRC04:52
*** amotoki has joined #openstack-ironic04:54
*** PollyZ has joined #openstack-ironic05:05
openstackgerritShivanand Tendulker proposed openstack/ironic: Add validation of 'ilo_deploy_iso' in deploy.validate()  https://review.openstack.org/33477405:12
*** jtomasek_ has quit IRC05:12
*** itamarl has joined #openstack-ironic05:13
*** M00nr41n has quit IRC05:13
*** ayoung has quit IRC05:14
*** fragatina has joined #openstack-ironic05:20
*** yibo has quit IRC05:27
*** ChubYann has quit IRC05:27
*** yogi has joined #openstack-ironic05:29
*** yibo has joined #openstack-ironic05:29
*** amotoki has quit IRC05:31
*** yogi_ has joined #openstack-ironic05:34
*** yogi_ has quit IRC05:34
*** piet has quit IRC05:35
*** yogi_ has joined #openstack-ironic05:36
*** rcernin has quit IRC05:37
*** rama_y has quit IRC05:37
*** moshele has joined #openstack-ironic05:39
*** amotoki has joined #openstack-ironic05:42
*** skramaja has joined #openstack-ironic05:42
*** rajinir has quit IRC05:44
*** praneshp has quit IRC05:47
*** jtomasek has quit IRC05:55
*** amotoki has quit IRC05:58
vdroksambetts|afk: http://logs.openstack.org/93/303093/9/check/gate-grenade-dsvm-ironic/1d65948/logs/grenade.sh.txt.gz not sure if it's some network glitch or not06:01
* vdrok is afk today06:02
*** Sukhdev has joined #openstack-ironic06:02
*** praneshp has joined #openstack-ironic06:04
*** yuanying has joined #openstack-ironic06:05
*** amotoki has joined #openstack-ironic06:05
openstackgerritTan Lin proposed openstack/ironic: Throwing an exception when creating a node with tags  https://review.openstack.org/32368006:05
*** M00nr41n has joined #openstack-ironic06:07
*** rcernin has joined #openstack-ironic06:09
*** yuanying has quit IRC06:11
*** jaybeale has joined #openstack-ironic06:11
*** yuanying has joined #openstack-ironic06:12
*** jaybeale has quit IRC06:12
*** PollyZ has quit IRC06:13
*** jaybeale has joined #openstack-ironic06:14
*** mjura has joined #openstack-ironic06:15
*** _vsaienko has joined #openstack-ironic06:16
openstackgerritTan Lin proposed openstack/ironic: Improve the readability of configuration drive doc part  https://review.openstack.org/32367506:17
*** Sukhdev has quit IRC06:19
*** jaybeale has quit IRC06:19
openstackgerritTan Lin proposed openstack/ironic: Improve the readability of configuration drive doc part  https://review.openstack.org/32367506:19
openstackgerritNaohiro Tamura proposed openstack/ironic-specs: Enhance Driver Interface for Soft Power Off and Inject NMI  https://review.openstack.org/18670006:22
*** jaybeale has joined #openstack-ironic06:23
*** jaybeale has quit IRC06:24
*** davidlenwell has quit IRC06:30
*** hshiina has joined #openstack-ironic06:30
*** _vsaienko has quit IRC06:32
*** derekh has joined #openstack-ironic06:35
*** davidlenwell has joined #openstack-ironic06:40
*** derekh has quit IRC06:43
openstackgerritGerard Braad proposed openstack/ironic-webclient: Add install instructions to README  https://review.openstack.org/33375406:43
*** pcaruana has joined #openstack-ironic06:46
*** rbartal has joined #openstack-ironic06:49
*** livelace has joined #openstack-ironic06:56
*** tesseract- has joined #openstack-ironic06:59
*** daemontool has joined #openstack-ironic07:04
*** praneshp has quit IRC07:12
openstackgerritTang Chen proposed openstack/python-ironicclient: Use osc_lib instead of cliff  https://review.openstack.org/33480307:15
*** yogi_ has quit IRC07:19
*** yogi has quit IRC07:20
*** athomas has joined #openstack-ironic07:30
*** ifarkas has joined #openstack-ironic07:31
*** yuanying has quit IRC07:34
*** yuanying has joined #openstack-ironic07:34
*** yuanying has quit IRC07:35
*** yuanying has joined #openstack-ironic07:36
openstackgerritMoshe Levi proposed openstack/ironic-python-agent: WIP Infiniband Support  https://review.openstack.org/33481607:47
openstackgerritTang Chen proposed openstack/python-ironicclient: Use osc_lib instead of cliff  https://review.openstack.org/33480307:50
*** zzzeek has quit IRC08:00
*** zzzeek has joined #openstack-ironic08:01
*** sacharya_ has quit IRC08:01
*** dmk0202 has joined #openstack-ironic08:06
alinebmorning all!08:07
milanmorning alineb08:10
milan#pixiesay morning Ironic -m flexing08:10
PixieBootsᕙʕ⇀ᴥ⇀ʔᕗ: morning Ironic08:10
ifarkasmorning milan alineb and all08:13
alinebo/ milan ifarkas08:13
*** _milan_ has joined #openstack-ironic08:14
*** dtantsur|afk is now known as dtantsur08:15
dtantsurMorning Ironic, morning alineb, milan, ifarkas08:15
*** milan has quit IRC08:17
_milan_morning dtantsur :)08:27
_milan_dtantsur, I've just checked your comment08:27
mosheledtantsur: morning, I updated the IPA patch for vendor and product idshttps://review.openstack.org/#/c/279940/  also can you review the infiniband spec https://review.openstack.org/#/c/265635/08:27
_milan_dtantsur, the bad thing is smoke tests run before upgrade and then no more after08:28
_milan_dtantsur, I'm not sure how to label our tempest test to be executed and where to put it08:28
dtantsurmoshele, will check today08:30
mgouldmorning Ironic!08:30
dtantsur_milan_, mmm, good question, probably jlvillal or vdrok know that...08:30
mgouldmorning alineb _milan_ dtantsur ifarkas08:30
mgouldmorning moshele08:30
dtantsurmorning mgould08:30
moshelemorning mgould08:31
dtantsur_milan_, the grenade job is merged \o/08:31
_milan_dtantsur, yeah :D08:31
_milan_\o/ merged experimental grenade for inspector08:31
mgould\o/08:31
alinebmorning mgould dtantsur08:32
_milan_dtantsur, ack, I'll lift the WIP embargo  from the grenade plugin and add the devstack and grenade patches it depends on08:32
_milan_i'll update the qe ether pad for discussion on Wednesday QE meeting so people can elaborate on it08:33
_milan_* discuss  how to make the best use of inspector grenade & inspector tempest08:33
*** jtomasek_ has joined #openstack-ironic08:34
_milan_dtantsur, another possibility is merge the plug-in and patch it as necessary if/once we decide about the test case selection08:34
*** yogi has joined #openstack-ironic08:36
*** daemontool has quit IRC08:40
lucasagomesmorning all08:40
dtantsurmorning lucasagomes08:40
_milan_morning lucasagomes :)08:40
_milan_oh, and morning mgould :)08:41
dtantsur_milan_, well, I'd prefer we at least try inspection after the upgrade :) but I'm fine with merging it and iterating further08:41
_milan_dtantsur, yeah08:41
*** mbound has joined #openstack-ironic08:42
dtantsur_milan_, hmm https://github.com/openstack/ironic/commit/ac7f9cea9c312e7a2dfb9e1f23bfee0658bf192608:42
_milan_dtantsur, interesting08:43
dtantsurvdrok, lol, awesome user pic https://github.com/openvdro :D08:43
* dtantsur gets the joke, but people not speaking Russian probably won't08:44
dtantsur_milan_, maybe that's a difference between a local environment and the gate?08:45
*** vmud213 has joined #openstack-ironic08:46
_milan_dtantsur, could be, some things get set in the config of the plugin some in the job template, it's a bit difficult for me to figure out what to put where08:46
dtantsur_milan_, this should take care of it: https://github.com/openstack-infra/devstack-gate/blob/3ef48cec70c771242d743467768f22d1ecb55ecb/devstack-vm-gate.sh#L748-L79108:47
dtantsurlets try in the gate, the new job should be available soon08:47
_milan_yeah, I'm a bit more inclined to spec this in the job template cause it's not up to the plugin to say what tests a gate job should run imho08:48
_milan_I mean if we need some tempest regex or other VARs set08:49
dtantsuryep08:49
_milan_dtantsur, cool, so lemme lift the WIP and add the depends-on things in the plug-in08:50
_milan_check experimental should then run through the grenade08:50
dtantsuryep08:52
openstackgerritMilan Kováčik proposed openstack/ironic-inspector: Introducing Inspector Grenade testing  https://review.openstack.org/32766708:53
dtantsur_milan_, don't we need to also enable ironic devstack plugin?08:57
_milan_dtantsur, I've discussed that with vdrok and jlvillal on Friday and we concluded it should be part of the job template (it is now)08:57
_milan_otherwise inspector would have to micro-manage ironic stuff :-/08:58
_milan_(me ran into that issue on Friday)08:58
dtantsurokie08:58
* _milan_ checks experimental && fingers-cross08:58
dtantsurthat's awesome, thanks for working on it09:00
_milan_dtantsur, thanks :)09:03
*** jistr is now known as jistr|mtg09:04
*** yogi has quit IRC09:06
*** mjura_ has joined #openstack-ironic09:09
dtantsurlucasagomes, re soft power off: we should probably start thinking how these parameters are to be used09:10
lucasagomesdtantsur, right09:11
dtantsurlucasagomes, I don't see point in setting timeout per boot request. it's something bound to an instance (or rather image)09:11
dtantsurfallback or not may be set per request on the other hand09:11
lucasagomesdtantsur, exactly09:11
lucasagomesdtantsur, that's why I think it's hard to have it in the driver_info09:11
dtantsurinstance_info then? :)09:11
lucasagomeshoenstly, it may be related to the user usage of the image09:11
lucasagomesbecause it may take a longer time depending on how many process it has running, fs mounted etc09:12
dtantsuryeah, so I think the timeout is an instance property09:12
*** mjura has quit IRC09:12
lucasagomesdtantsur, still, I think the user using the CLI don't want to update neither instance_info or driver_info before invoking soft power off09:13
dtantsurI'm not that decided about the "fallback" thing09:13
lucasagomesyeah, that on a per-node basis seems pretty incosistent to me (the fallback)09:13
dtantsurlucasagomes, yes, but as I said, this is not something that should be set per request, it's an instance property for real09:13
dtantsurlike, our deploy API does not set instance_info/disk_gb09:13
gbraaddtantsur: had some time again to look into my ironic/bifrost issue from yesterday: seems there is no agent-ipmitool09:14
lucasagomesdtantsur, but how that gets passed to the instance_info?09:14
dtantsurlucasagomes, node-update, like everything else there09:14
gbraadthanks again for the pointers. but it seems the markup is as used by openstack-infra/shade09:14
dtantsurI see09:14
lucasagomesdtantsur, well, the tenant should not update it right? it's more like an operator thing09:14
lucasagomesI can't assume someone has operator credentials to actually be able to issue a soft power off09:15
dtantsurlucasagomes, all our API is admin-only currently09:15
dtantsurso yes, you can09:15
lucasagomesdtantsur, we agreed on policies09:15
lucasagomeslemme see also if nova allows soft pwoer off09:15
dtantsurthen we'll have to reconsider updating as well, because a lot of things depend on values in our magic JSONs09:15
dtantsurand I agree that's bad09:15
dtantsurlucasagomes, my second thought on the previous patchset was: if we allow timeout, it should be for all power actions, not only soft power off09:16
dtantsurso e.g. it should work for hard power off too09:16
lucasagomesdtantsur, I tend to agree with that09:17
lucasagomes--timeout seems geenric enough that could be coded for all operations09:17
dtantsurI'm fine with this option too. I just don't feel comfortable adding parameters only working for soft power off09:17
lucasagomesbut it's outside the scope of the patch per-si09:17
lucasagomesperhaps, what if09:17
lucasagomesin that spec, let's have it all as ironic.conf options09:17
lucasagomesafter that we can work on timeout being overriden for both hard and soft options09:18
dtantsurI'm fine with that, I'm not sure who requested user-settable options09:18
lucasagomesdtantsur, I think devananda 2 patch-sets before09:18
dtantsurhmm09:19
openstackgerritTan Lin proposed openstack/ironic-specs: Support rolling upgrades  https://review.openstack.org/29924509:19
lucasagomesdtantsur, https://review.openstack.org/#/c/186700/29/specs/approved/enhance-power-interface-for-soft-reboot-and-nmi.rst09:21
lucasagomesL16709:21
dtantsurlucasagomes, so I think we can 1. have a common "timeout" option, 2. Do not fall back to hard power off for now. WDYT?09:22
lucasagomesdtantsur, seems fine...09:23
lucasagomesI'm not against fall back but I think it should be an ironic.conf thing09:23
lucasagomesso it's consistent across all nodes09:23
dtantsurto be honest, I'm not sure fall back is a good thing.. users can always request a hard power off if they want09:23
dtantsuron the other hand, hard fall back can destroy data09:24
lucasagomesyeah09:24
lucasagomesit's not a big deal to issue a hard power off if needed09:24
dtantsur++09:25
dtantsurlucasagomes, wanna summarize this discussion on the spec?09:25
*** yuanying has quit IRC09:26
*** Nisha_away has joined #openstack-ironic09:26
lucasagomesdtantsur, could be, do you mind doing it ? (Maybe just c&p the conversation!?09:27
lucasagomes)09:27
Nisha_awaydtantsur, need some help on inspector....09:27
*** amotoki has quit IRC09:27
dtantsurlucasagomes, I can, but I'm on meeting right now09:29
dtantsurNisha_away, ditto, I can try helping, but I have a lot of meeting ahead09:30
Nisha_awaydtantsur, basically the server is not able to recv dhcp requests09:30
Nisha_awaydtantsur, i have br-inspector, the inspector dhcp service and ironic dhcp server in same range09:31
*** jistr|mtg is now known as jistr09:31
Nisha_awaydtantsur, pxe deploy works in the same env perfectly fine09:32
*** derekh has joined #openstack-ironic09:33
Nisha_awayinspector is not able to boot up the ramdisk as dhcp is not reaching server09:33
dtantsurNisha_away, probably DHCP misconfiguration, check http://docs.openstack.org/developer/ironic-inspector/install.html#configuration we've updated it recently09:35
Nisha_awaydtantsur, thanks let me check09:39
lucasagomesyuriyz, around? I think I don't get the suggestion here https://review.openstack.org/#/c/327642/3/ironic/conductor/utils.py ?09:39
lucasagomesyuriyz, setting target_power_state to NOSTATE at the db api level for cleaning? But wouldn't that be outside of the patch scope?09:41
lucasagomescan be done, but I don't think we should change it in that patch. What you think?09:41
*** david-lyle has quit IRC09:44
*** david-lyle has joined #openstack-ironic09:46
*** yogi has joined #openstack-ironic09:53
*** _vsaienko has joined #openstack-ironic09:54
openstackgerritDmitry Tantsur proposed openstack/ironic: [WIP] Implement new heartbeat for AgentDeploy  https://review.openstack.org/33396410:00
openstackgerritDmitry Tantsur proposed openstack/ironic: Promote agent vendor passthru to core API  https://review.openstack.org/33001810:00
openstackgerritDmitry Tantsur proposed openstack/ironic-python-agent: [WIP] Use new agent API if available  https://review.openstack.org/33452310:01
Nisha_awaydtantsur, br-inspector ip has some settings for inspector?10:01
dtantsurNisha_away, sorry, I don't get the question10:02
Nisha_awaydtantsur, earlier (long back) when i had tried inspector i had manually done following: 1. create neutron port for br-inspector's mac with in the same dhcp ramge as of ironic 2. and then assigned the ip address to the br-inspector.10:03
Nisha_awaydtantsur, now same is not working,10:04
dtantsurno neutron ports please, it's not needed10:04
dtantsurplease follow the documentation or see our devstack plugin10:04
dtantsurhttps://github.com/openstack/ironic-inspector/blob/master/devstack/plugin.sh10:04
Nisha_awaydtantsur, ok. thanks10:04
Nisha_awaydtantsur, one more ques, we dont require neutron port to define the dhcp range at all?10:05
Nisha_awaymeans like we do for ironic?10:05
*** hoangcx has quit IRC10:06
dtantsurNisha_away, no, inspector does not interact with or require neutron10:06
Nisha_awayohk. thanks10:06
Nisha_awayi will then refer the plugin10:06
Nisha_awaythat shud help me for configuration10:06
*** baoli has joined #openstack-ironic10:09
openstackgerritLucas Alvares Gomes proposed openstack/ironic: Add power_transition_started_at to the nodes table  https://review.openstack.org/32764210:10
*** baoli_ has joined #openstack-ironic10:11
sambetts|afkMorning all10:14
*** sambetts|afk is now known as sambetts10:14
*** baoli has quit IRC10:14
* sambetts is zombie mode today and mostly focused downstream because of deadlines :'( 10:14
dtantsurmorning sambetts10:16
dtantsur#pixiesay deadlines.. -m sad10:16
PixieBootsʕ•͡ᴥ•ʔ: deadlines..10:16
dtantsuroh, we don't have sad emotion, do we?10:16
dtantsur #pixiesay deadlines.. -m dead10:17
dtantsur#pixiesay deadlines.. -m dead10:17
PixieBootsʕxᴥxʔ: deadlines..10:17
*** amotoki has joined #openstack-ironic10:17
sambettsheh10:17
* dtantsur is not the smartest person ever today10:17
openstackgerritDmitry Tantsur proposed openstack/ironic: [WIP] Implement new heartbeat for AgentDeploy  https://review.openstack.org/33396410:20
openstackgerritDmitry Tantsur proposed openstack/ironic: Promote agent vendor passthru to core API  https://review.openstack.org/33001810:20
* _milan_ relocates10:21
*** _milan_ has quit IRC10:22
openstackgerritAline Bousquet proposed openstack/ironic-lib: Add support for metrics  https://review.openstack.org/30152610:25
lucasagomeshi folks, if you have some time... mind taking a look at https://review.openstack.org/#/c/248832/ ?10:28
lucasagomescheers10:28
*** amotoki has quit IRC10:30
openstackgerritDmitry Tantsur proposed openstack/ironic: [WIP] Implement new heartbeat for AgentDeploy  https://review.openstack.org/33396410:30
openstackgerritDmitry Tantsur proposed openstack/ironic: Promote agent vendor passthru to core API  https://review.openstack.org/33001810:30
*** amotoki has joined #openstack-ironic10:35
*** yogi__ has joined #openstack-ironic10:36
*** yogi__ has quit IRC10:40
openstackgerritDmitry Tantsur proposed openstack/ironic: [WIP] Implement new heartbeat for AgentDeploy  https://review.openstack.org/33396410:41
openstackgerritDmitry Tantsur proposed openstack/ironic: Promote agent vendor passthru to core API  https://review.openstack.org/33001810:41
*** Nisha_away has quit IRC10:41
openstackgerritDmitry Tantsur proposed openstack/ironic-python-agent: [WIP] Use new agent API if available  https://review.openstack.org/33452310:44
dtantsurthis is getting closer ^^^10:44
*** yuanying has joined #openstack-ironic10:47
*** dtantsur is now known as dtantsur|lunch10:48
*** daemontool has joined #openstack-ironic10:48
*** amotoki has quit IRC10:50
*** jcoufal has joined #openstack-ironic10:54
*** vmud213 has quit IRC11:03
*** fragatin_ has joined #openstack-ironic11:22
*** moshele has quit IRC11:22
*** fragatina has quit IRC11:22
*** thrash|g0ne is now known as thrash11:25
*** vmud213 has joined #openstack-ironic11:27
*** fragatin_ has quit IRC11:30
*** milan has joined #openstack-ironic11:35
*** lucasagomes is now known as lucas-hungry11:42
*** krtaylor has joined #openstack-ironic11:42
*** appu103_ has joined #openstack-ironic11:48
*** aparnav has quit IRC11:50
*** amotoki has joined #openstack-ironic11:52
*** appu103_ has quit IRC11:52
*** raildo-afk is now known as raildo11:53
*** fragatina has joined #openstack-ironic11:54
*** sdake has joined #openstack-ironic11:58
*** sdake_ has joined #openstack-ironic12:00
*** piet has joined #openstack-ironic12:02
openstackgerritDavid Edery proposed openstack/ironic: Fix non-deployed nodes due to short nodes.instance_info  https://review.openstack.org/33496712:02
*** sdake has quit IRC12:03
*** moshele has joined #openstack-ironic12:05
*** krtaylor has quit IRC12:05
openstackgerritZhenguo Niu proposed openstack/ironic: Follow up patch of I2293e03c05e13c716f78533680d128ba45ccda02  https://review.openstack.org/33496912:06
*** dtantsur|lunch is now known as dtantsur12:12
*** vmud213 has quit IRC12:13
*** yogi has quit IRC12:15
*** trown|outtypewww is now known as trown12:15
*** athomas has quit IRC12:18
TheJuliaGood morning12:19
*** [1]cdearborn has joined #openstack-ironic12:20
milanmorning TheJulia12:21
*** moshele has quit IRC12:22
*** athomas has joined #openstack-ironic12:23
dtantsurmorning TheJulia12:24
*** e0ne has joined #openstack-ironic12:26
*** daemontool has quit IRC12:28
mat128morning TheJulia, milan and dtantsur12:29
milanmat128, morning12:29
*** yogi has joined #openstack-ironic12:30
dtantsurmorning mat12812:31
*** baoli_ has quit IRC12:31
*** baoli has joined #openstack-ironic12:32
openstackgerritCaio Oliveira proposed openstack/python-oneviewclient: [WIP] Creating certificate manager for OneView  https://review.openstack.org/33499212:34
openstackgerritZhenguo Niu proposed openstack/ironic: Follow up patch of d52077f4fe8c668b258702e8298a4beaa19476d8  https://review.openstack.org/33496912:35
*** yuikotakadamori has joined #openstack-ironic12:36
*** daemontool has joined #openstack-ironic12:36
*** yuikotakadamori has quit IRC12:37
*** baoli has quit IRC12:37
openstackgerritAline Bousquet proposed openstack/ironic-lib: Add support for metrics  https://review.openstack.org/30152612:38
*** moshele has joined #openstack-ironic12:38
*** cdearborn has joined #openstack-ironic12:38
*** links has quit IRC12:40
*** yuikotakadamori has joined #openstack-ironic12:40
*** Nisha_away has joined #openstack-ironic12:43
*** wajdi has quit IRC12:51
*** links has joined #openstack-ironic12:53
TheJuliagood morning mat128, milan, daemontool12:53
*** [1]cdearborn has quit IRC12:53
thiagopGood morning, Ironicers12:54
TheJuliagood morning thiagop12:56
thiagopTheJulia: o/12:56
*** moshele has quit IRC12:56
*** daemontool has quit IRC12:57
mat128o/ thiagop12:57
*** _vsaienko has quit IRC12:57
thiagophey mat12812:57
*** rloo has joined #openstack-ironic12:57
gbraadTheJulia, thanks for the email. I'll try some ofthe suggestions later and move to the conversation to the mailinglist12:58
gbraadat the moment I have to look after my kid. ;-)12:58
gbraadand yes, I added the spacing to the output (makes it slightly more readable)12:59
TheJuliagbraad: not exactly a fan of the mailing list, IRC is more preferable for troubleshooting issues13:00
openstackgerritZhenguo Niu proposed openstack/ironic: Add missing translation marker to clear_node_target_power_state  https://review.openstack.org/33496913:01
TheJuliaGood to know about the spacing, that had me a little worried13:01
*** jjohnson2 has joined #openstack-ironic13:02
gbraadenterless strings can be hard to read.13:02
gbraadsure, but I am in a bad timezone for you I guess. China13:03
TheJuliaahh13:03
TheJuliaThat is quite a timezone difference13:03
TheJuliawhat time are you typically online in the morning?13:04
gbraad8:3013:05
*** M00nr41n has quit IRC13:05
openstackgerritJulia Kreger proposed openstack/bifrost: Do Not Merge: another test for ironic networking  https://review.openstack.org/33021013:06
TheJuliaUTC?13:06
*** Nisha_away has quit IRC13:06
gbraadBeijing time... but I'll get back to you about this.13:07
TheJuliaok13:07
gbraadAnyways I might try this later tonight and let you know13:07
TheJuliaOkay, otherwise have a good evening13:07
gbraadThank you13:08
*** lucas-hungry is now known as lucasagomes13:09
*** yuikotakadamori has quit IRC13:12
*** daemontool has joined #openstack-ironic13:13
*** baoli has joined #openstack-ironic13:14
*** rbudden has joined #openstack-ironic13:16
dtantsurlucasagomes, mind reviewing one more agent API promotion patch https://review.openstack.org/#/c/332890/ please?13:17
lucasagomesdtantsur, will do in a sec13:17
dtantsurthnx13:17
*** sdake_ has quit IRC13:23
*** sdake has joined #openstack-ironic13:24
*** daemontool has quit IRC13:25
*** rama_y has joined #openstack-ironic13:28
*** yuikotakadamori has joined #openstack-ironic13:28
*** snecklifter has quit IRC13:28
sean-k-mooneyhi everyone QQ re bifrost. do ye technically support Ubuntu 14.04 currently?13:28
sean-k-mooneyi say some default overrides for 15.04+ but none for 14.0413:29
*** wajdi has joined #openstack-ironic13:31
rookJayF would it be trivial to add a timing metric to this function? https://github.com/openstack/ironic-python-agent/blob/stable/mitaka/ironic_python_agent/extensions/standby.py#L6613:32
rookJayF If I remember correctly, you are adding some metric gathering to ironic, right?13:32
rookrloo ^'13:39
dtantsuralineb, ^^^13:40
rloorook: I believe JayF is away for the next few days or more (I forgot how long). He said he would pop into irc but not frequently.13:40
rloorook, yeah, alineb should be able to help you13:40
rookrloo ok... reviewing 301923 i don't get the sense this patch applies to what I am looking for.13:40
*** daemontool has joined #openstack-ironic13:41
rookhowever, maybe there are pieces that could be reused?13:41
rookrloo I am not too in-tune with how ipa writes the image -- I am guessing the function i posted above would be it.13:41
rookrloo - however, I think it would be a good metric for ipa to return to ironic when the disk writing has completed.13:41
rloorook: possibly. i didn't look to see how they were adding metrics to ipa13:41
rookhttps://review.openstack.org/#/c/119981/13:42
rloorook: hopefully aline could help you. I didn't look and am in the middle of something, so don't want to look.13:43
rloorook: you could also add a comment to that patch, with your question. if no one gets back to you.13:44
openstackgerritSam Betts proposed openstack/ironic: Fix invalid chassis/nodes/chassis_uuid API url  https://review.openstack.org/31614913:44
openstackgerritSam Betts proposed openstack/ironic: Fix all possible node subresources routing collisions  https://review.openstack.org/31576613:44
openstackgerritSam Betts proposed openstack/ironic: Prevent URL collisions with sub-controllers: nodes/ports  https://review.openstack.org/31451413:44
*** krtaylor has joined #openstack-ironic13:45
*** hkominos has quit IRC13:46
TheJuliasean-k-mooney: 14.04 is supported and should work out of the box13:46
*** hkominos has joined #openstack-ironic13:47
alinebrook: yes, i think it should be possible, for instance with a context like it's done in https://review.openstack.org/#/c/119981/28/ironic_python_agent/extensions/standby.py13:48
hkominosHello  ironicers (and hopefully fuel-ironicers). I have a quick question. After a node is enrolled in the conductor does that mean that the conductor will manage its power settings? Cause i am having a weird behaviour of manually powering on the node and then the node is powered of automatically13:48
*** piet has quit IRC13:49
dtantsurhkominos, that's right, ironic will enforce the power state13:49
*** xhku_ has joined #openstack-ironic13:50
rookalineb: yeah, i am going through that commit now... looking at why jenkins is still throwing up13:50
*** ayoung has joined #openstack-ironic13:52
alinebrook: the patch depends on a another one in ironic-lib, so i don't think the tests will pass until the one in ironic-lib is merged13:53
rookhm, i thought I looked at that patch and it was...13:53
*** xhku has quit IRC13:53
rookahh, no it wasn't13:54
rookalright alineb makes sense.13:54
*** krtaylor has quit IRC13:54
jlvillalmilan, dtantsur: Regarding smoke tests and Grenade. In Ironic devstack-gate will run the tempest tests after the upgrade. Basically if you say grenade then devstack-gate should always run the tempest tests after the upgrade. Those results will be in the console log and not the grenade log13:55
*** rama_y has quit IRC13:55
dtantsurjlvillal, could you please check our job definitions (I think milan has a link) to see if we do run them?13:55
jlvillaldtantsur, If it tells devstack-gate that it is a grenade job then I think it must.13:56
*** moshele has joined #openstack-ironic13:56
dtantsurI see, I'll check it13:56
*** ametts has joined #openstack-ironic13:57
alinebrook: also, the patch in IPA will need some changes, but it will still tell you how we plan to call the context manages13:57
*** moshele has quit IRC13:58
*** moshele has joined #openstack-ironic13:58
dtantsurmilan, it seems like we fail to shutdown inspector: http://logs.openstack.org/67/327667/15/experimental/gate-grenade-dsvm-ironic-inspector-nv/93eef2b/logs/grenade.sh.txt.gz#_2016-06-28_09_51_03_90114:00
milandtantsur, yeah, it's the setsid issue14:00
milanthe pid file for inspector contains pid instead of pgid14:00
milandtantsur, see the depends on14:01
dtantsuraha, I see14:01
*** PollyZ has joined #openstack-ironic14:01
dtantsurmilan, we don't the other projects have the same problem?14:02
dtantsurhow are we special?14:02
*** baoli has quit IRC14:03
milandtantsur, somehow we use stack_it that boils down to _old_run_process in devstack/functions-common (if I'm not mistaken)14:03
milandtantsur, in stack_it in inspector/devstack/plugin.sh that is14:04
dtantsurmilan, is it possible we just use the same as ironic?14:04
openstackgerritSaravanan KR proposed openstack/ironic-python-agent: Set the kernel args to the nodes at bootloader instal  https://review.openstack.org/33505214:04
milanwe could update the plugin.sh, yeah, depends on how attractive my patches are for devstack guys14:05
* milan didn't get much feedback on that though14:06
*** e0ne has quit IRC14:06
lucasagomesdtantsur, re db lock for the heartbeat()14:07
lucasagomesdtantsur, it's writing to the node at driver_internal_info14:07
lucasagomesI wonder if we may introduce a race there, heartbeat vs some other node writting14:08
*** PollyZ has quit IRC14:08
lucasagomesvery unlikely, maybe I'm over concerned, but I wanted to check first14:08
dtantsurlucasagomes, maybe; we can work around it by having a special db call to change last heartbeat. Also I can easily imagine a driver not doing anything in its heartbeat when no actions are expected14:09
milanjlvillal, dtantsur the job template: https://github.com/openstack-infra/project-config/blob/master/jenkins/jobs/devstack-gate.yaml#L2152-L220414:09
milanI've just spotted some export DEVSTACK_LOCAL_CONFIG+=$'\n'"TEMPEST_PLUGINS+=' /opt/stack/new/ironic-inspector'" it might be missing14:09
dtantsurmilan, I think we should fix the plugin to match how ironic does it. landing patches to devstack can take serious time14:09
milanhmmm yeah14:10
*** PollyZ has joined #openstack-ironic14:11
dtantsurmilan, yeah, I think we should switch to run_process14:11
milandtantsur, https://github.com/openstack/ironic/blob/master/devstack/lib/ironic#L663 Ironic uses run process14:12
milandtantsur, ack14:12
dtantsurthnx! would be awesome to get it passing soon :)14:13
milandtantsur, the grenade patch for checking is_service_running can be worked around saying dnsmasq instead of ironic-inspector-dhcp14:13
dtantsurmilan, or we can put "enable_service ironic-inspector-dhcp" to our setting14:13
dtantsuractually we do, hmm: https://github.com/openstack/ironic-inspector/blob/master/devstack/settings14:14
milandtantsur, it is there already14:14
milanyeah14:14
dtantsurthen what's the problem?14:14
milanright14:14
milaninspector/devstack/upgrade.sh does check that the services are up14:14
milanin the end14:14
milanafter the upgrade14:14
milanas a sanity assertion14:14
milanit works for inspector but doesn't for -inspector-dhcp14:15
NobodyCamGood morning Ironicers14:15
milanwe can check dnsmasq through is_service_running in there instead14:15
*** mjura_ has quit IRC14:15
*** piet has joined #openstack-ironic14:15
*** PollyZ has quit IRC14:15
* milan just sad that patches that might fix it for other people will be worked around14:16
milanbut yeah14:16
milan#pixiesay nothing's ever ideal -m meh14:16
PixieBoots¯\_(ツ)_/¯: nothing's ever ideal14:16
milanmorning NobodyCam :)14:16
NobodyCammorning milan14:16
NobodyCam:)14:16
dtantsurmilan, why doesn't is_service_running work for us?14:17
dtantsurmorning NobodyCam14:17
NobodyCammorning dtantsur :)14:17
milandtantsur, is_service_running uses ps | grep <service name>14:17
dtantsurmilan, then how does it work for ir-api? the process is called ironic-api14:17
milandtantsur, we don't match ironic-inspector-dhcp because it is dnsmasq14:17
dtantsurand ir-api is ironic-api. do you know how it works?14:18
*** rook_ has quit IRC14:18
milanit does lot of grep magic O:-)14:18
* milan looks14:18
openstackgerritJulia Kreger proposed openstack/bifrost: Disable flat network driver  https://review.openstack.org/33506014:18
milandtantsur, it's workaround in ironic: https://github.com/openstack/ironic/blob/master/devstack/upgrade/upgrade.sh#L12314:20
*** rook_ has joined #openstack-ironic14:20
*** rook_ has quit IRC14:21
dtantsurmilan, can we avoid using ensure_service_started for dnsmasq and use our own grep?14:21
milandtantsur, we can do pretty much anything :D14:21
dtantsurso lets do it :)14:21
dtantsurif your patches get merged we can always remove our hacks14:22
*** PollyZ has joined #openstack-ironic14:22
milanyeah, a bit pragmatic14:22
dtantsurbut I don't want to wait a couple of weeks to hear "don't do that"14:22
milandtantsur, right, that could happen indeed.14:22
milandtantsur, maybe if people gave those 2 tiny patches a review ;)14:23
*** joprovost has joined #openstack-ironic14:23
*** baoli has joined #openstack-ironic14:24
dtantsurwelll... nobody here is core on grenade, I guess14:24
*** baoli has quit IRC14:25
milandtantsur, right, +1 better than none still ;)14:25
* milan hacks 14:25
*** baoli has joined #openstack-ironic14:25
*** rajinir has joined #openstack-ironic14:25
dtantsurwill do ofc, but it does not help too much usually14:25
*** jvgrant has joined #openstack-ironic14:26
*** itamarl has quit IRC14:26
*** M00nr41n has joined #openstack-ironic14:27
*** rbartal has quit IRC14:28
NobodyCamjlvillal: happen to be around yet?14:28
jlvillalNobodyCam, I am but about to leave for 25 minutes14:29
dtantsurlucasagomes, fyi not requiring exclusive lock was requested by jroll on https://review.openstack.org/#/c/306418/11/specs/approved/agent-api.rst@194 and that's why it's on the spec14:29
lucasagomesdtantsur, a-ha, fair enough14:30
*** rook_ has joined #openstack-ironic14:30
*** jvgrant has quit IRC14:30
milanjlvillal, dtantsur wdyt about export DEVSTACK_LOCAL_CONFIG+=$'\n'"TEMPEST_PLUGINS+=' /opt/stack/new/ironic-inspector'" in the experimental inspector job template?14:31
milanit's missing in there now14:31
lucasagomesdtantsur, +2'd14:31
dtantsurthnx!14:31
dtantsurmilan, I don't see it in ironic job definition though..14:31
lucasagomessince it has been discussed in the spec already, we should keep going with it14:31
dtantsurlucasagomes, no necessary, if you strongly object, we can amend the spec14:31
lucasagomesdtantsur, sorry for the confusion, I thought it would worth asking anyway14:31
lucasagomesdtantsur, sure, I don't strongly object to it14:31
lucasagomesthat's why I've voted mostly to ask about it14:32
openstackgerritJulia Kreger proposed openstack/bifrost: Do Not Merge: Canery test for ironic networking changes  https://review.openstack.org/33013814:32
dtantsurcool, thanks lucasagomes14:32
openstackgerritMilan Kováčik proposed openstack/ironic-inspector: Introducing Inspector Grenade testing  https://review.openstack.org/32766714:32
milandtantsur, ^14:33
dtantsurmilan, please update the commit message with your changes14:33
milandtantsur, wdym?14:33
dtantsurmilan, mention that you're fixing the plugin.sh (no rush, only if you create another patchset)14:33
NobodyCamhey hey Morning jlvillal14:34
milandtantsur, aah14:34
milanOK14:34
NobodyCamjust a quick question about https://review.openstack.org/#/c/272658 what are you seeing with the release note?14:35
*** vgadiraj has joined #openstack-ironic14:38
*** links has quit IRC14:38
openstackgerritMilan Kováčik proposed openstack/ironic-inspector: Introducing Inspector Grenade testing  https://review.openstack.org/32766714:38
dtantsurthnx14:39
*** rook_ has quit IRC14:39
*** rbudden has quit IRC14:41
*** rook_ has joined #openstack-ironic14:41
openstackgerritLucas Alvares Gomes proposed openstack/ironic: Stop passing root device hints via kernel cmdline  https://review.openstack.org/33507014:41
*** e0ne has joined #openstack-ironic14:42
*** yuikotakadamori has quit IRC14:46
dtantsurlucasagomes, will it break mitaka ^^?14:47
lucasagomesdtantsur, yeah, wondering if we should put it on hold for now14:48
*** krotscheck_dcm is now known as krotscheck14:48
lucasagomesdtantsur, another way to do it would be to, pass root device hints _only_ if there's no operators on it :-/14:48
dtantsurlucasagomes, I think we can only do it in Ocata :( grenade is using mitaka IPA14:48
dtantsurlucasagomes, I think it's a possible compromise, yes14:49
dtantsurdeclare that operators only work with newton IPA14:49
*** mgould is now known as mgould|brb14:49
lucasagomesyeah, that would be the case14:49
*** e0ne has quit IRC14:50
*** xhku_ has quit IRC14:51
*** moshele has quit IRC14:52
jlvillalNobodyCam, I thought I said nevermind on the release notes :)14:54
jlvillalNobodyCam, It wasn't your patch. I fixed it here: https://review.openstack.org/33471214:54
JayFrook: rloo: Sure, we can metric things. If you want to get more metrics stuff in, the #1 thing to do to help is review alineb's ironic-lib patch to add metrics. Once that is in choosting to metric individual items will be trivial.14:57
NobodyCamjlvillal: :)14:57
NobodyCamack just wanted to check14:57
NobodyCammorning lucasagomes JayF14:57
lucasagomesNobodyCam, JayF morning14:58
NobodyCam:)14:58
JayFgm14:59
NobodyCam:)14:59
JayFlast day I'll be online working for probably a couple of weeks (reality is I'll probably work one day next week, but don't count on it), so if you need something from me speak now :)15:00
NobodyCamomg :) moving?15:00
*** vgadiraj has quit IRC15:01
*** xhku has joined #openstack-ironic15:02
JayFyes15:02
NobodyCam:) be safe15:02
*** baoli has quit IRC15:03
JayFThat's what I'll be trying for, lol15:03
*** baoli has joined #openstack-ironic15:03
*** [1]cdearborn has joined #openstack-ironic15:04
NobodyCamlol15:04
*** baoli has quit IRC15:04
*** rloo has quit IRC15:04
*** sabeen has joined #openstack-ironic15:04
*** rloo has joined #openstack-ironic15:04
*** baoli has joined #openstack-ironic15:05
*** amotoki has quit IRC15:07
*** rbudden has joined #openstack-ironic15:08
*** M00nr41n has quit IRC15:08
*** praneshp has joined #openstack-ironic15:09
*** sacharya has joined #openstack-ironic15:09
*** baoli has quit IRC15:09
*** M00nr41n has joined #openstack-ironic15:10
*** sacharya_ has joined #openstack-ironic15:12
*** jistr is now known as jistr|mtg15:13
* milan relocates15:13
*** milan has quit IRC15:13
*** M00nr41n has quit IRC15:14
*** sacharya has quit IRC15:14
*** baoli has joined #openstack-ironic15:17
*** cdearborn has quit IRC15:17
*** baoli has quit IRC15:18
*** baoli has joined #openstack-ironic15:18
openstackgerritZhenguo Niu proposed openstack/ironic: Add missing translation marker to clear_node_target_power_state  https://review.openstack.org/33496915:19
*** mgould|brb is now known as mgould15:20
*** M00nr41n has joined #openstack-ironic15:20
*** jtomasek_ has quit IRC15:20
*** jaybeale has joined #openstack-ironic15:23
dtantsurfolks, do we really have a compelling use case for setting network drivers per node rather than per deployment?15:23
dtantsurit would simplify the network patches substantially15:23
dtantsurrloo, TheJulia, JayF, sambetts, maybe you remember?15:23
rloodtantsur: is this via the new node.network_interface?15:24
dtantsuryeah.. do we really need it?15:24
*** M00nr41n has quit IRC15:24
dtantsurlike, do we expect half of nodes to have network separation, half - no?15:24
JayFI don't know one way or the other. I suspect real-world means it'd be not useful15:24
dtantsurhow will nova distinguish between such nodes?15:25
JayFbut I know we have folks with crazier use cases and environments than I have ever been able to imagine :)15:25
dtantsurbecause then a user will want to request a node with or without separation15:25
*** baoli has quit IRC15:25
* dtantsur will probably write to a ML15:25
rloodtantsur: if we don't add the network interface now, we should at least make sure that we can add it later if it turns out that people want it.15:26
dtantsurrloo, it's easier to add than to remove ;)15:26
rloodtantsur: we rarely remove. we haven't even removed chassis :)15:27
rloodtantsur: worth asking though. it seems like we have it cuz someone asked. but it would mean going back and looking at comments in previous revisions in who-knows-which-patch.15:28
*** PollyZ has quit IRC15:28
rlooand who knows, maybe i asked to make it more flexible. i cannot recall now. although i doubt that i would have asked for a NetworkInterface.15:28
*** M00nr41n has joined #openstack-ironic15:29
NobodyCamgood morning rloo :)15:30
rloodtantsur: according to this spec (I'm assuming we changed 'network_provider' to 'network_interface', it is per node: http://specs.openstack.org/openstack/ironic-specs/specs/approved/network-provider.html15:31
rloomorning NobodyCam!15:31
NobodyCam:)15:31
mgouldmorning NobodyCam rloo15:31
NobodyCammorning mgould :)15:32
dtantsurthanks rloo, but it's still unclear to me. I'm writing to the ML15:32
*** PollyZ has joined #openstack-ironic15:32
*** jistr|mtg is now known as jistr15:32
*** Nisha_away has joined #openstack-ironic15:32
rloodtantsur: ok. that spec seems ... out of date... i'm not sure how much of that is going to be true.15:33
dtantsurhttp://lists.openstack.org/pipermail/openstack-dev/2016-June/098361.html15:33
rloodtantsur: just wondering. what if you imported a bunch of nodes ('adopted' I guess) into ironic/openstack, and they haven't been migrated yet (whatever that entails) to use neutron.15:36
dtantsurrloo, this sounds troublesome, I agree. still I think "migrate asap" is an answer here15:37
dtantsurwith "migrate" only meaning providing port information, I guess15:37
rloodtantsur: need operator input I guess. I'm so useless...15:37
dtantsurno more than I am..15:38
rloodtantsur: so jroll wrote that spec, so i'd assume he knew of a usecase or he wouldn't have proposed per node. but i know, i shouldn't assume.15:39
rloodtantsur: now i wonder if i should bother reviewing the patches until this is answered.15:40
dtantsuryeah, lets ask around. sometimes I also overdo with flexibility and then someone is like "but who would use that"? :)15:40
*** alex_xu has quit IRC15:40
dtantsurI won't; I need to understand "why" before "how"15:40
rloodtantsur: i like flexibility.15:40
rloodtantsur: cuz you never know peoples' use cases.15:40
dtantsurme too but not at expense of e.g. upgrade problems15:41
dtantsurand I don't quite understand how we define the default value in this case15:41
dtantsurlike, do we need a configuration option as well?15:42
*** dmk0202 has quit IRC15:42
rloodtantsur: i assumed it would become clear as i went through the patches. really, the spec should describe it but ... :-(15:42
dtantsurmaybe we should not proceed with the spec so outdated15:43
TheJuliadtantsur: I know of several users who use ironic for users and managing their pool of hardware, so concievably some may want none, others may want flat, or neutron  per node in that case15:43
rloodtantsur: maybe it was part of the previous mid-cycle, where they changed this.15:43
*** alex_xu has joined #openstack-ironic15:44
dtantsurTheJulia, all 3 in one cluster? so they have neutron with and without separation, and also their own DHCP server?15:44
TheJuliaI can see it, I know some tht use their own dhcp server but want the capability for isolation if they have configured the network as such15:45
TheJuliaflat, maybe not so much in that scenario15:45
sean-k-mooneyTheJulia: hi. looking at the bifrost readme it support ubuntu 14.04 but i noticed it does not create initv service files for ironic* services. is 14.04 still tested?15:45
TheJuliaNobodyCam: your thoughts?15:46
TheJuliasean-k-mooney: we test 14.04 in the gate, but we write upstart configs15:46
dtantsurTheJulia, I wonder how well neutron works with another dhcp. we had some fun making inspector work with neutron..15:46
cineramasean-k-mooney, i also use 14.04 to do my general purpose testing15:46
* NobodyCam reads15:47
TheJuliadtantsur: I would think of it as different distinct pools of hardware.  I might have some conductors wired into multiple network fabrics15:47
JayFI mean, the question not only needs to be "do people want us to support this" but also "does it make sense to support this"15:47
TheJuliaJayF: ++15:47
sean-k-mooneycinerama: TheJulia are the upstart configs only created when you run in testing mode or should they always be created15:47
JayFI share dtantsur's concern that having such a core difference per node without having it be schedulable in nova is very ill advised15:47
TheJuliasean-k-mooney: always from what I remember15:47
TheJuliaI think we have two distinct users, those that use ironic directly that want to assert something, and then via nova, from nova, I do agree, it is problematic although I could still see a deployments wanting to offer both for any number of reasons15:48
mat128JayF, dtantsur: I know I would be fine having that multitenancy yes/no per ironic installation rather than per node15:48
sean-k-mooneyok im working on the kolla intergration and the ironic services are not being started as part of the bifrost ironic install playbooks on 14.04. on centos it works fine but that uses systemd15:49
TheJuliathen that forces separate installations if I have an HPC compute cluster in one corner that I don't want to involve neutron in the networking for15:49
mat128TheJulia: you can always use a driver that does not involve neutron15:49
mat128a node driver15:49
TheJuliamat128: but the discussion seems to be removal of that15:49
TheJuliaunless I'm on another planet, which is always a possibility15:50
mat128removal of node drivers? hell no :)15:50
mat128oh15:50
TheJuliasean-k-mooney: it should always create them, but I don't have the code in front of me at the moment15:50
NobodyCamI have seen this configuration, it was basically a pre production env15:50
dtantsurmat128, removal of proposed node.network_interface and replacing it with configuration only15:50
cineramasean-k-mooney, hmm, that is weird. so do you get the upstart files?15:50
mat128the removal of the "network driver" part?15:50
dtantsuryep15:50
rloomat128: yeah, so all have to use the same configurable setting.15:50
TheJuliaI think that is asking for people complaining15:50
rlooseems too restrictive to me but I don't have a use case myself.15:50
JayFfrom jim by proxy: "The main thing is it needs to be discoverable via api because nova needs to know15:51
dtantsurJayF, then ask him how nova interprets value of "None" which is valid per driver composition spec15:52
dtantsurTheJulia, do people already complain?15:52
TheJuliadtantsur: yes :)15:52
dtantsurinteresting15:52
dtantsurlucasagomes, fwiw my fedora has iptables15:53
TheJuliaI know of several internal deployments that essentially need the flexibility since they use ironic to manage their hardware pools in general15:53
lucasagomesdtantsur, you can install it, but it doesn't come installed by default AFAICT15:53
lucasagomesat least for the workstation image15:53
dtantsurI don't remember installing it, but maybe something pulled it15:53
JayFdtantsur: tl;dr for repsonse to that; take it to the ml15:53
lucasagomes(it comes with firewalld instead)15:53
rloodtantsur: it seems to me that if TheJulia knows of some cases, then it is needed/can be useful.15:53
lucasagomesdtantsur, or maybe something changed... I'm still on f22 :-)15:54
mat128dtantsur, TheJulia, rloo, JayF: Forget my comment, I did not correctly understand the question.15:54
dtantsurrloo, TheJulia, interesting. I won't block the patches based on this alone, but the default should be figured out. especially the handling of None/NULL15:54
mat128network_interface is for the flat/lacp/active-backup choice, right?15:54
*** sdake_ has joined #openstack-ironic15:54
dtantsurmat128, no problem. I think so, I don't know what lacp means15:55
*** hshiina has quit IRC15:55
TheJuliadtantsur: yes, agree that a site default might be a useful thing as well, defaulting to none just seems to ask for headaches, although if we tested that, it could expose more issues15:55
mat128dtantsur: bonding?15:56
dtantsurTheJulia, I mean Python None, not the "none" string15:56
dtantsuror database NULL if you want15:56
mat128ok, just as a reference standpoint15:56
*** tesseract- has quit IRC15:56
dtantsurmat128, then no, it's about who manages network for the node: "nobody", "neutron, flat network", "neutron, tenant separation"15:56
mat128oooh15:57
*** sdake has quit IRC15:57
mat128that should belong to the node I believe15:57
mat128example use case for it15:57
TheJuliadtantsur: yes, that :)15:57
*** ifarkas has quit IRC15:58
mat128I have a bunch of servers using latest and greatest ToR which I have neutron ML2 support for15:58
mat128these nodes use the "neutron-*" modes15:58
mat128but I could also have a bunch of nodes that are on dumb switches, or manually configured switches outside of Openstack's control15:58
mat128these nodes should be on the "nobody" mode15:58
mat128all of these nodes could live happily in the same Ironic installation15:58
mat128s/could/should15:58
sean-k-mooneycinerama: am where would i check for the upstart files? should they be in /etc/init.d/ or somewhere else?15:59
dtantsurmat128, TheJulia, thanks, please put your considerations on the ML thread, so that we're sure all folks are in sync15:59
mat128as Jim pointed out via JayF proxy, Nova should be able to discover/know, because it might have implications (maybe integrated network is a nice feature we want to expose through a flavor), or maybe the configdrive needs to be configured differently15:59
mat128writing a reply :)15:59
dtantsurmat128, yeah, but it's unclear what nova does on seeing None there..16:00
*** sukhdev has joined #openstack-ironic16:00
*** daemontool_ has joined #openstack-ironic16:00
dtantsurwhich means "use the default"16:00
mat128dtantsur: maybe it doesnt have to anything to do16:00
mat128in a normal use case, what would nova do differently?16:00
dtantsurI'm not sure, that's what jroll said :)16:00
mat128Unless there is something I don't see, nova doesnt need to do anything differently when the network is managed by nobody, neutron flat or neutron tenant separated16:01
mat128nova interacts with neutron for the VIF parts16:01
mat128nova will be impacted with vlan-aware instances and future work, but not with the simple network_interafce choice16:01
*** xhku has quit IRC16:02
*** vishwanathj has joined #openstack-ironic16:02
openstackgerritLucas Alvares Gomes proposed openstack/ironic-python-agent: Add a log extension  https://review.openstack.org/24883216:03
*** daemontool has quit IRC16:03
*** Sukhdev_ has joined #openstack-ironic16:04
rloohi lucasagomes, wrt https://review.openstack.org/#/c/334431/, do you know what the oslo patch is? i want to find out what the delay might be16:05
lucasagomesrloo, https://review.openstack.org/#/c/308398/ (i've added it to the comment in the code)16:05
lucasagomesperhaps should put in the commit message too16:05
rloolucasagomes: thx. I didn't actually look at the code change; just read the commit msg :)16:05
lucasagomesrloo, no worries :-)16:06
*** xhku has joined #openstack-ironic16:06
*** gfhellma has joined #openstack-ironic16:09
*** xhku has quit IRC16:11
openstackgerritMario Villaplana proposed openstack/ironic: Add power state change notifications  https://review.openstack.org/32186516:14
openstackgerritMario Villaplana proposed openstack/ironic: Add notification base classes and docs  https://review.openstack.org/29846116:14
sean-k-mooneycinerama: looking at the code the upstart files are added to /etc/init which does contain the files.16:14
*** klindgren has joined #openstack-ironic16:15
lucasagomesrloo, so, I don't know if/when it's going to land in oslo16:16
rloolucasagomes: right. esp since they seem to think that no one wants it.16:16
*** appu103_ has joined #openstack-ironic16:16
openstackgerritChris Krelle proposed openstack/ironic: Add support for the audit middleware  https://review.openstack.org/27265816:17
rloolucasagomes: replied and will try to track down harlowja16:17
*** apughazh has joined #openstack-ironic16:17
lucasagomesrloo, thanks16:17
*** rama_y has joined #openstack-ironic16:18
rloolucasagomes: it is delaying you though but you have lots of other things to do in the meantime?16:18
cineramasean-k-mooney, what happens if you try to manually start the services?16:18
sean-k-mooneycinerama: if i use service or start the service is not found16:18
openstackgerritYossi Ovadia proposed openstack/ironic-python-agent: Handle diskless hardware connected to remote iscsi  https://review.openstack.org/32780716:18
lucasagomesrloo, right yeah... currently also working on the logs for IPA and a high prio bug about nodes getting stuck on power state transitions16:18
sean-k-mooneycinerama: for example service --status-all dose not show the service16:19
lucasagomesrloo, https://bugs.launchpad.net/ironic/+bug/158890116:19
openstackLaunchpad bug 1588901 in Ironic "Nodes stuck on power state transitions" [High,In progress] - Assigned to Lucas Alvares Gomes (lucasagomes)16:19
lucasagomesI've added a plumbing patch for it, few reviews so far tho16:19
rloolucasagomes: ok, lets see what happens first. will try to find out this week.16:19
sean-k-mooney service ironic-conductor start16:19
sean-k-mooneyironic-conductor: unrecognized service16:19
lucasagomesrloo, thanks16:19
openstackgerritJulia Kreger proposed openstack/bifrost: Do Not Merge: another test for ironic networking  https://review.openstack.org/33021016:20
rloolucasagomes: that reminds me. i was thinking it would be good to go through all high-priority bugs.  [I just want to code...]16:20
lucasagomesrloo, if you want to take a look at the first patch https://review.openstack.org/#/c/327642/ :-)16:20
lucasagomessean-k-mooney, openstack-ironic-conductor?16:20
lucasagomesdepends on the distros packages (or if you manually installed ironic tho)16:21
TheJuliasean-k-mooney: upstart in a container?16:21
rloolucasagomes: nope. i need to space out my reviewing. oh geez, i looked. dont' you have to add an rfe if the db is being modified?16:21
sean-k-mooneyTheJulia: yes16:21
sean-k-mooney()[root@bifrost playbooks]# service openstack-ironic-conductor status16:21
sean-k-mooneyopenstack-ironic-conductor: unrecognized service16:21
TheJuliasean-k-mooney: is it the special base "upstart is modified to work" container image?16:21
lucasagomesrloo, well, I could... tho I can only have a timeout for transition if we record the time the transition started16:21
lucasagomesso I thought that having only the bug was fine/obivous for that16:22
sean-k-mooneyTheJulia: upstart is other wise working fine, e.g. it works for mysql and rabbitmq16:22
lucasagomeswe do the same for inspection_started_at or provision_updated_at thing16:22
rloolucasagomes: i wonder if we can add '[rfe]' to that bug.16:22
cineramasean-k-mooney, on ubuntu the service name is different16:22
TheJuliasean-k-mooney: mysql and rabbit ship with sysv init scripts if memory serves16:22
sean-k-mooneyTheJulia: yes they do16:22
lucasagomesrloo, we can yeah16:22
* lucasagomes guess16:22
rloolucasagomes: you're adding a new feature, right? to fix that?16:23
sean-k-mooneycinerama: when i do a service list there are not openstakc or ironic services listed16:23
cineramasean-k-mooney: how about "service ironic-conductor status"?16:23
lucasagomesrloo, I think you can look at it that way yes16:23
TheJuliasean-k-mooney: so, I guess it is just that we're lacking sysv init scripts for you in a container scenario16:23
lucasagomesat the end it's a bug, because we do not timeout power state transitions16:23
lucasagomesso it potentially can get stuck16:24
lucasagomesbut yeah, adding a timeout may also count as a feature I guess16:24
sean-k-mooneywell i am runing /sbin/init and if i do /sbin/init --version it is upstart16:24
TheJuliasean-k-mooney: hmmm... I wonder which wins use order wise16:24
cineramainterestingly, my startup scripts work but i do not see the ironic services in service --status-all16:25
*** sabeen has quit IRC16:25
sean-k-mooneythis might help  http://paste.openstack.org/show/523805/16:25
lucasagomesrloo, if you prefer having it as an RFE, I'm OK with that too16:25
rloolucasagomes: so with that spec proposing soft power & nmi, this change will also apply to the soft * stuff too, right? but not the nmi?16:26
sean-k-mooneyTheJulia: i think initV scripts will be used if they are present and then upstart but in either case as long as only one version of the script exists the order "should" not matter16:27
rloolucasagomes: so this is adding a new config option too?16:27
lucasagomesrloo, right, soft reboot does have a timeout tho I have to take a look at how it's implemented16:27
lucasagomesit would be good to keep it in sync16:27
rloolucasagomes: yeah, i think it is an 'rfe' then :)16:27
lucasagomesrloo, yup16:28
lucasagomesrloo, ack, I will change it16:28
cineramaoh interesting, so i think service --status-all is using /etc/init.d?16:28
rloolucasagomes: thx. i guess we are rockin' cuz we have lots of stuff we want to do / implement. But sigh, so many to review...16:28
lucasagomesyeah16:28
sean-k-mooneycinerama: yeah it looks like it is16:28
cineramaif i do a service ironic-api status though it looks OK16:29
*** Jabadia has joined #openstack-ironic16:29
TheJuliacinerama: but are you in a container at the moment?16:30
rloolucasagomes: so I don't know if you should add a new rfe and keep the existing as a real bug, or combine. Personally, I don't care.16:30
cineramasean-k-mooney, how about "initctl list"?16:30
*** Nisha_away has quit IRC16:30
sean-k-mooneycinerama: its empthy16:30
lucasagomesrloo, I think it's a mix of both16:30
*** Nisha_away has joined #openstack-ironic16:30
lucasagomesperhaps add the rfe tag but make sure people see that it's a bug as well16:30
*** derekh has quit IRC16:31
JabadiaWhere is the right place to ask questions about about the 'overcloud-full.initrd' and images in general ? I need to add driver/module to initramfs of overcloud16:31
sean-k-mooneys/empthy/empty16:31
rloolucasagomes: right, you need that feature to work to address the bug. i've seen in the past, where there has been an rfe that also ended up addressing a bug. again, i don't particularly care :)16:31
lucasagomesrloo, will check it and also talk to naohiro about how thye are planning to do it for soft p off16:31
rloolucasagomes: good. thx.16:31
lucasagomesrloo, yeah same here, as long as it's fixed16:31
lucasagomesI don't care either :-)16:31
lucasagomesand I will have to call it a day16:32
rloociao lucasagomes!16:32
lucasagomescame to the office today for some presentation thingy16:32
lucasagomesand gotta run to catch my train back home16:32
lucasagomesrloo, thanks a lot16:32
lucasagomessee you, have a great evening all16:32
*** apughazh has quit IRC16:32
NobodyCamnight lucasagomes16:34
cineramasean-k-mooney: heh. i think i will need to get a container going etc to help more16:34
*** daemontool_ has quit IRC16:35
sean-k-mooneycinerama: i think its just somthing to do with the service file not being linking in to the right place or something along those lines16:35
sean-k-mooneyi was trying some of the suggestions here http://askubuntu.com/questions/299371/correct-way-to-install-a-custom-upstart-service16:35
sean-k-mooneybut they did not work16:35
cineramasean-k-mooney: if you can give me some pointers on how i can duplicate your setup i can have a play16:37
sean-k-mooneyim currently working off of https://review.openstack.org/#/c/319703/1/doc/bifrost.rst but the simplet thing to do would be to run a vanilla ubuntu container with /sbin/init as the application16:39
sean-k-mooneycinerama: let me get a command for you16:39
*** yogi has quit IRC16:40
cineramasean-k-mooney, cool, thanks. this should make for a fun afternoon :)16:40
sean-k-mooneycinerama: docker run -it --net=host -v /dev:/dev -d --privileged --name bifrost ubuntu:14.04 /sbin/init16:40
sean-k-mooneycinerama: that will create a privalaged container with the network namesapce disabled from the ubuntu base image16:41
sean-k-mooneycinerama: you should then be able to run the bifrost install script normally16:41
*** sabeen has joined #openstack-ironic16:41
sean-k-mooneycinerama: well playbook16:41
sean-k-mooneycinerama: if you already have ironic/bifrost running then it will fail because of the --net=host16:42
sean-k-mooneyso if you dont want to acctully clean down some machinces when you are done you can leave that out16:42
sean-k-mooneycinerama: kolla will be moving to ubuntu 16.04 with systemd this cycle so if i cant get it working it upstart it wont be an issue but as we currently use 14.04 for ubuntu im testing with it16:44
cineramasean-k-mooney, well it probably won't be too hard to fix if i can poke at it a bit16:45
*** xhku has joined #openstack-ironic16:45
TheJuliasean-k-mooney: have you seen https://github.com/docker/docker/issues/2276 ?16:46
*** apughazh has joined #openstack-ironic16:46
sean-k-mooneyTheJulia: no lets see how broken upstart is in a container.16:47
*** Sukhdev_ has quit IRC16:47
*** apughazh has quit IRC16:47
*** Sukhdev_ has joined #openstack-ironic16:48
sean-k-mooneyi do know that there uses to be a special ubuntu-upstart docker file maybe i need to dig into it a little more16:48
sean-k-mooneyhaving said that i may have found the issue16:49
TheJuliaI seem to remember bcornec ran into it trying to containerize bifrost a long while back16:49
sean-k-mooney()[root@bifrost playbooks]# init-checkconf /etc/init/ironic-conductor.conf16:49
sean-k-mooneyERROR: version of /sbin/initctl too old16:49
TheJulia\o16:49
TheJuliaerr16:49
TheJulia \o/16:49
*** dulek has quit IRC16:49
*** pcaruana has quit IRC16:49
sean-k-mooneyTheJulia: so the first time i tried to contaieries bifrost i use the ubuntu-upstart container with no issues16:50
sean-k-mooneyi gues i need to look at what is different between ubuntu-upstart:14.04 and ubuntu:14.0416:50
*** rcernin has quit IRC16:51
sean-k-mooneycinerama: rather then wasing your time on what might be an issue with the base container let me poke around and see if i change figure out what the difference is16:52
sean-k-mooneycinerama: if im still stuck tomorow ill let ye know.16:53
*** baoli has joined #openstack-ironic16:53
*** baoli has quit IRC16:54
cineramasean-k-mooney, sounds good. a quick search turned up some possible issues with vanilla ubuntu containers but you're probably more aware of those than i am16:54
*** baoli has joined #openstack-ironic16:54
sean-k-mooneycinerama: ya looks like i need to add this to my docker image to fix the vanila ubuntu container https://github.com/tianon/dockerfiles/blob/4d24a12b54b75b3e0904d8a285900d88d3326361/sbin-init/ubuntu/upstart/14.04/Dockerfile#L12-L3616:54
*** klindgren has quit IRC16:55
openstackgerritMilan Kováčik proposed openstack/ironic-inspector: Introducing Inspector Grenade testing  https://review.openstack.org/32766716:59
*** vishwanathj has quit IRC17:02
*** klindgren has joined #openstack-ironic17:02
*** caldw__ has joined #openstack-ironic17:03
*** ChubYann has joined #openstack-ironic17:04
*** aparnav has joined #openstack-ironic17:06
*** appu103_ has quit IRC17:06
*** baoli has quit IRC17:07
*** aparnav has quit IRC17:13
*** aparnav has joined #openstack-ironic17:13
*** praneshp has quit IRC17:16
openstackgerritRuby Loo proposed openstack/ironic-lib: Use autospec in mocked objects  https://review.openstack.org/33513617:17
*** mbound has quit IRC17:17
harlowjarloo whats up17:18
harlowjai didn't do it17:18
harlowjalol17:18
rlooharlowja: oh. the oslo.utils patch. sec, let me find it.17:18
rlooharlowja: https://review.openstack.org/#/c/30839817:18
rlooharlowja: nova extra_specs_ops. i see there are two patches, and some uncertainty as to whether to even put it in oslo.utils.17:19
rlooharlowja: ironic does want it. and lucasagomes has a patch to put it in ironic-libs cuz he doesn't know whether it will get into oslo.utils.17:19
*** hoonetorg has quit IRC17:19
rlooharlowja: i'd rather it just get put in oslo.utils.17:19
rlooharlowja: it seems like you or alexis doesn't want the actual nova code cuz it is ugly?17:20
harlowjaya, i don't like the ugly being in oslo17:20
harlowjaoslo != uglystepson17:20
harlowjalol17:20
harlowjaor is it uglycousin17:20
harlowjaidk17:20
rlooharlowja: is there a way to put the ugly first, then your beautiful, or do you prefer only the beautiful?17:20
harlowjaso i was under the impression that jroll said neither were needed17:21
harlowja:-P17:21
*** baoli has joined #openstack-ironic17:21
rlooharlowja: dunno where you got that impression, but i suspect for a period of time, it wasn't needed. but now it is needed again.17:21
*** baoli has quit IRC17:21
rlooharlowja: needed for a different reason i believe. but we want to use similar syntax to nova (unfortunately but they started the precedent)17:22
*** xhku has quit IRC17:22
*** PollyZ has quit IRC17:22
*** cdearborn has joined #openstack-ironic17:22
*** baoli has joined #openstack-ironic17:22
*** klindgren has quit IRC17:23
*** gfhellma1 has joined #openstack-ironic17:23
harlowjaya, i forget somewhere along the line i think jroll was like i'll just do it in sqlcode17:23
rlooharlowja: so, given that ironic wants it. should we just copy nova's version into our ironic-lib for ironic's internal use?17:24
*** aNupoisc has joined #openstack-ironic17:24
*** gfhellma has quit IRC17:24
rlooharlowja: or do you think it is worth putting something in oslo.utils? maybe premature to put in oslo.utils?17:24
harlowjawhat was wrong with https://review.openstack.org/#/c/313699/ :-P17:26
*** xhku has joined #openstack-ironic17:26
harlowjait at least formalized it somewhat17:26
harlowjathat was the less ugly one17:26
*** xhku has quit IRC17:26
*** klindgren has joined #openstack-ironic17:26
rlooharlowja: nothing (I think, I actually haven't looked at any of the patches).17:26
rlooharlowja: the concern is whether your version works with nova. so we wanted to take a cautious approach. i think. (shouldn't say 'we')17:27
*** xhku has joined #openstack-ironic17:27
rlooharlowja: i suspect that if there were enough unit tests to test it out, it would be fine.17:27
harlowjaya, i think we built up enough knowledge while making that 313699 that we know where the diffs are (there is a tiny one)17:27
rlooharlowja: and i thought your patch relied on the first patch, which is why alexis or someone said to squash them?17:27
harlowjanah second patch ummm sorta just rewrote the first one, lol17:28
rlooharlowja: so i like having the original there, so you can see the history.17:28
rlooharlowja: but i don't know how oslo/libraries do things.17:28
rlooharlowja: eg, if it had been in that incubator dir, you'd see the original + changes to that.17:28
harlowjai'd be ok with that, merging the original and then replacing it17:29
harlowjafor history reasons17:29
*** caldw__ has quit IRC17:29
harlowjajust the whole theory of 'nova has scary code --> oslo' scares me17:29
rlooharlowja: ok, so basically, we need to make sure it works and there are sufficient unit tests.17:29
harlowjadon't like oslo being a dump17:29
harlowjayup17:29
harlowjait has a bunch17:29
rlooharlowja: c'mon, let's keep scary code around. so ccccooool.17:29
harlowja:(17:29
harlowjacool if u like working in a dump17:30
rlooha ha17:30
rloogeez. now i wonder if i have to review those patches.17:30
rlooharlowja: so i guess you're going to say that you think your patch is complete?17:30
* dtantsur wants to gently remind that ugly working code is still better than beautiful non-working17:31
*** Jabadia has quit IRC17:31
harlowjahey the new stuff works :-P17:32
harlowjapasses all the same unit tests ;)17:32
rloodtantsur: yup. that's why i want to make sure there are sufficient unit tests!17:32
harlowjaits stricter than the old stuff, but imho that's ok17:32
harlowjathats the diff, this new one is strict, not letting random crap in, lol17:32
rlooharlowja: if it is stricter, it is possible it won't work for nova.17:32
rlooharlowja: in case random crap already got in, in nova...17:33
dtantsurharlowja, my definitions of works for libraries usually include "merged" ;)17:33
harlowjarloo ya, the nova people ... no comment, lol17:33
harlowjadtantsur oh17:33
harlowjawhy u have so high of expections17:33
dtantsurlol17:33
harlowjaexpectations17:33
rlooharlowja: i think we are fine with a stricter version, as long as the nova operators work similar to what nova expects.17:33
harlowjaafaik it should17:33
dtantsuryeah, when I just propose a patch it's usually brilliant, then people make ugly sh*t of it with their reviews..17:34
* dtantsur is kidding of course :D17:34
harlowjaya i know that feeling17:34
harlowjai'm not kidding17:34
harlowjalol17:34
harlowjadamn humans17:34
harlowjalike rloo17:34
harlowjalol17:34
rlooharlowja: really? why would you take sh*t from folks?17:34
harlowjalol17:34
harlowjasometimes the shit is convered in gol17:34
harlowja*gold17:34
* dtantsur checks if it's Friday already17:34
harlowjaso u don't realize its shit till after the fact17:34
harlowjawhen u get around to dusting it , then u realize its not gold17:35
harlowjalol17:35
* rloo worries that this is rapidly going downhill or down the sewer or something...17:35
harlowjalol17:35
harlowjaso ya, just review those things17:35
harlowja:-P17:35
rlooharlowja: ok thx. i'll add a comment to that effect. and try to review them this week.17:35
harlowjathx boss17:36
* rloo is glad that harlowja knows who is boss17:36
harlowjai'm not stupid17:37
harlowjau don't mess with the ruby17:37
harlowjalol17:37
* dtantsur is pretty sure it's Friday now17:37
harlowjalol17:37
*** [1]cdearborn has quit IRC17:37
*** d0ugal has quit IRC17:37
TheJulialol17:37
*** d0ugal has joined #openstack-ironic17:37
*** d0ugal has quit IRC17:37
*** d0ugal has joined #openstack-ironic17:37
* rloo is going to copy what harlowja says, for whatever performance thing i might need.17:38
harlowjaperformance thing?17:38
harlowjalol17:38
rlooharlowja: who knows. these companies all make you do performance things. this is going to be "rloo's influence upstream".17:38
rlooharlowja: performance review. sorry, not performance of hw/sw :)17:39
harlowjawfm17:39
harlowjabb17:39
rloothx larsks17:40
rloooops, larsks, that was a mistake. please ignore.17:40
rloothx harlowja17:40
*** moshele has joined #openstack-ironic17:41
*** d0ugal has quit IRC17:41
*** d0ugal has joined #openstack-ironic17:42
*** d0ugal has quit IRC17:42
*** d0ugal has joined #openstack-ironic17:42
*** sabeen has quit IRC17:42
*** gfhellma1 has quit IRC17:42
*** sabeen has joined #openstack-ironic17:43
*** sabeen has quit IRC17:43
*** praneshp has joined #openstack-ironic17:43
*** e0ne has joined #openstack-ironic17:44
*** PollyZ has joined #openstack-ironic17:44
*** rcernin has joined #openstack-ironic17:45
*** aparnav has quit IRC17:46
*** appu103_ has joined #openstack-ironic17:48
*** PollyZ has quit IRC17:50
*** trown is now known as trown|lunch17:50
*** dtantsur is now known as dtantsur|afk17:51
*** piet has quit IRC17:52
*** gfhellma has joined #openstack-ironic17:55
*** fragatin_ has joined #openstack-ironic17:55
*** fragatina has quit IRC17:55
harlowjanp17:55
sean-k-mooneycinerama: TheJulia: just as an fyi when i rebuild the container with the changes from the ubunut-upstart container everything works fine.17:55
JayFdtantsur|afk: re: my vote on that about not landing things with broken dpes17:56
JayFdtantsur|afk: I really don't want us to start playing the ipa-ramdisk-feature-matrix game17:56
*** e0ne has quit IRC17:56
*** Goneri has joined #openstack-ironic17:57
sean-k-mooneycinerama: TheJulia: the ironic service still dont show up in service --status-all but there in initctl list just as cinerama saw out side of a container17:57
cineramasean-k-mooney, that's probably okay - status-all only works with sysvinit (it says so in the man page)18:02
*** electrofelix is now known as electrofelix|afk18:03
*** sukhdev has quit IRC18:03
sean-k-mooneycinerama: yep well all the service seam to be working. im going to try and enroll the vms i create with the create vms script and check if it can deploy18:04
sean-k-mooneyim failly sure everything is now working correctly.18:05
sambettsdtantsur|afk: the reasoning behind having network interfaces per node is because different nodes have different capabilties in regards to networking, for example my hardware can do things that others can't, and a big ask of customers is to support mixed hardare environments but not be limited to the feature set of the node with the least features18:05
sambettsdtantsur|afk: at least thats my use case for having them18:06
cineramasean-k-mooney: great, i'm glad things are working now18:06
*** sambetts is now known as sambetts|afk18:06
*** Sukhdev_ has quit IRC18:09
*** apughazh has joined #openstack-ironic18:14
openstackgerritStephanie Miller proposed openstack/bifrost: Unify test playbooks  https://review.openstack.org/32791218:15
openstackgerritMilan Kováčik proposed openstack/ironic-inspector: Introducing Inspector Grenade testing  https://review.openstack.org/32766718:16
*** mbound has joined #openstack-ironic18:18
*** mbound has quit IRC18:24
*** pcaruana has joined #openstack-ironic18:25
*** PollyZ has joined #openstack-ironic18:25
*** sabeen has joined #openstack-ironic18:30
*** PollyZ has quit IRC18:30
*** PollyZ has joined #openstack-ironic18:35
*** baoli has quit IRC18:40
*** baoli has joined #openstack-ironic18:40
*** Sukhdev has joined #openstack-ironic18:40
*** athomas has quit IRC18:41
openstackgerritJulia Kreger proposed openstack/bifrost: Disable flat network driver  https://review.openstack.org/33506018:41
*** baoli has quit IRC18:41
*** baoli has joined #openstack-ironic18:42
*** davidlenwell has quit IRC18:42
*** gfhellma has quit IRC18:43
*** rbudden has quit IRC18:43
*** Nisha_away has quit IRC18:48
*** davidlenwell has joined #openstack-ironic18:52
*** baoli has quit IRC18:55
*** trown|lunch is now known as trown18:56
*** baoli has joined #openstack-ironic19:00
*** baoli has quit IRC19:01
*** sdake has joined #openstack-ironic19:02
*** sdake_ has quit IRC19:03
*** baoli has joined #openstack-ironic19:03
*** rook_ has quit IRC19:03
openstackgerritJulia Kreger proposed openstack/bifrost: Do Not Merge: another test for ironic networking  https://review.openstack.org/33021019:07
*** klindgren has quit IRC19:08
*** rook_ has joined #openstack-ironic19:11
*** jcoufal has quit IRC19:12
*** baoli has quit IRC19:12
*** appu103_ has quit IRC19:13
*** baoli has joined #openstack-ironic19:13
*** baoli has quit IRC19:13
*** jaybeale has quit IRC19:14
*** baoli has joined #openstack-ironic19:14
*** fellypefca has joined #openstack-ironic19:15
*** sdake_ has joined #openstack-ironic19:16
*** terje has quit IRC19:17
*** baoli has quit IRC19:18
*** athomas has joined #openstack-ironic19:19
*** sdake has quit IRC19:20
*** _vsaienko has joined #openstack-ironic19:21
PollyZI have a question, if I would like to get a list of headers, what the argument would be, I tried "flask.request.headers()", "flask.request.headers.get()" and something else, but none of these works19:22
*** baoli has joined #openstack-ironic19:28
*** baoli has quit IRC19:28
*** baoli has joined #openstack-ironic19:29
*** aNupoisc has quit IRC19:30
*** moshele has quit IRC19:32
*** ayoung has quit IRC19:35
*** fragatin_ has quit IRC19:36
*** moshele has joined #openstack-ironic19:37
*** ametts has quit IRC19:40
openstackgerritRuby Loo proposed openstack/ironic-lib: Add reno to test-requirements  https://review.openstack.org/33520519:42
*** [2]cdearborn has joined #openstack-ironic19:43
*** xhku has quit IRC19:44
*** fragatina has joined #openstack-ironic19:48
*** moshele has quit IRC19:49
*** klindgren has joined #openstack-ironic19:53
*** hoonetorg has joined #openstack-ironic19:54
*** ametts has joined #openstack-ironic19:56
openstackgerritRuby Loo proposed openstack/ironic-lib: Use autospec in mocked objects  https://review.openstack.org/33513619:57
*** cdearborn has quit IRC19:57
*** gfhellma has joined #openstack-ironic19:58
*** athomas has quit IRC20:02
mariojvPollyZ: http://stackoverflow.com/questions/29386995/how-to-get-http-headers-in-flask might help20:03
*** PollyZ_ has joined #openstack-ironic20:05
openstackgerritRuby Loo proposed openstack/ironic-lib: Add keyword arg 'log_stdout' to utils.execute()  https://review.openstack.org/33521120:07
*** PollyZ has quit IRC20:07
*** _vsaienko has quit IRC20:08
*** rook_ has quit IRC20:17
openstackgerritRuby Loo proposed openstack/ironic-lib: Add reno to test-requirements  https://review.openstack.org/33520520:18
*** makowals has joined #openstack-ironic20:18
*** makowals has quit IRC20:18
*** jcoufal has joined #openstack-ironic20:21
*** livelace has quit IRC20:22
*** caldw__ has joined #openstack-ironic20:23
openstackgerritRuby Loo proposed openstack/ironic-lib: Add keyword arg 'log_stdout' to utils.execute()  https://review.openstack.org/33521120:23
*** ayoung has joined #openstack-ironic20:29
*** jcoufal has quit IRC20:30
*** rbudden has joined #openstack-ironic20:30
*** fellypefca has quit IRC20:38
*** jcoufal has joined #openstack-ironic20:38
*** caldw__ has quit IRC20:40
*** jtomasek_ has joined #openstack-ironic20:41
*** jjohnson2 has quit IRC20:43
*** e0ne has joined #openstack-ironic20:45
openstackgerritPradeep Chandrasekar proposed openstack/ironic: Fix typo in inspection.rst  https://review.openstack.org/33521920:45
*** ametts has quit IRC20:49
openstackgerritJay Faulkner proposed openstack/ironic-specs: Implement Keystone Policy Support  https://review.openstack.org/32743720:52
*** Goneri has quit IRC20:53
*** gfhellma1 has joined #openstack-ironic20:54
*** fragatina has quit IRC20:54
*** fragatina has joined #openstack-ironic20:54
*** aNupoisc has joined #openstack-ironic20:55
*** gfhellma has quit IRC20:55
*** sdake has joined #openstack-ironic21:01
JayFsomeone who knows a thing or three about spec formatting mind helping  me try and suss out why I'm getting bad parsing on that Ironic spec? http://docs-draft.openstack.org/37/327437/5/check/gate-ironic-specs-docs/66d07b3//doc/build/html/specs/not-implemented/keystone-policy-support.html21:02
JayFfrom https://review.openstack.org/32743721:03
JayFmy syntax matches every rst doc I found21:03
JayFand I can't find a working example in ironic history21:03
*** sdake_ has quit IRC21:04
*** blakec has joined #openstack-ironic21:05
*** trown is now known as trown|outtypewww21:08
*** dmk0202 has joined #openstack-ironic21:11
*** e0ne has quit IRC21:12
*** blakec1 has joined #openstack-ironic21:14
JayFaha finally got it21:16
JayFtl;dr blah[0]_ doesn't render, blah [0]_ does21:16
*** blakec has quit IRC21:17
*** harlowja has quit IRC21:19
openstackgerritJay Faulkner proposed openstack/ironic-specs: Implement Keystone Policy Support  https://review.openstack.org/32743721:19
*** piet has joined #openstack-ironic21:21
*** blakec has joined #openstack-ironic21:22
*** blakec1 has quit IRC21:25
*** baoli has quit IRC21:30
*** baoli has joined #openstack-ironic21:33
*** baoli has quit IRC21:34
*** baoli has joined #openstack-ironic21:34
openstackgerritJay Faulkner proposed openstack/ironic-specs: Implement rescue mode  https://review.openstack.org/17187821:39
*** sdake has quit IRC21:39
*** dmk0202 has quit IRC21:42
*** piet has quit IRC21:48
*** piet has joined #openstack-ironic21:48
*** thiagop has quit IRC21:53
*** jtomasek_ has quit IRC21:56
*** blakec has quit IRC22:01
*** davidlenwell has quit IRC22:02
*** piet has quit IRC22:03
*** baoli has quit IRC22:08
*** gfhellma1 has quit IRC22:10
*** davidlenwell has joined #openstack-ironic22:11
*** aNupoisc has quit IRC22:15
*** harlowja has joined #openstack-ironic22:16
*** harlowja has quit IRC22:23
*** [2]cdearborn has quit IRC22:27
*** wajdi_ has joined #openstack-ironic22:28
*** wajdi__ has joined #openstack-ironic22:29
*** wajdi_ has quit IRC22:29
openstackgerritJay Faulkner proposed openstack/ironic-specs: Implement Keystone Policy Support  https://review.openstack.org/32743722:31
*** wajdi has quit IRC22:31
JayFmariojv: ^ thanks, fixed the typos22:31
JayFmariojv: and responded to the other comment22:32
*** mbound_ has joined #openstack-ironic22:33
*** wajdi has joined #openstack-ironic22:34
*** aNupoisc has joined #openstack-ironic22:35
*** rama_y has quit IRC22:35
mariojvJayF: thanks, still lgtm22:36
mariojvthe more granular operations against nodes thing would certainly be interesting22:37
*** wajdi__ has quit IRC22:37
JayFyeah; IDK if it's a technical thing or a "take bite sized pieces" that is why we're not limiting it22:38
mariojvpotentially lots of use cases; it might make it easier for someone to run a control plane on top of ironic or something22:38
JayFI think it gets a lot more expensive to decide things other than based on endpoint22:38
JayFit's def something for us to look at when splitting the v2 api, to make/allow for saner policies22:38
*** PollyZ_ has quit IRC22:38
mariojvmaybe, probably depends on how big the deployment and what you're filtering on22:39
mariojvif tags are used and indexed in the db or something, not that expensive, but idk22:39
JayFI mean, think about it this way:22:39
JayFif in routes you block based on policy, DoS attack requires a lot more hits22:39
*** wajdi has quit IRC22:39
JayFthan if you get down to parsing the body, looking up the tags on a node, etc etc22:39
JayFnot saying we should never do it, just that it's not as much of a slam dunk as all the other pieces are22:39
mariojvfor sure, it would be more complicated22:40
mrdaMorning all22:41
openstackgerritJay Faulkner proposed openstack/ironic: Make agent driver always PXE before cleaning  https://review.openstack.org/26384222:47
*** Sukhdev has quit IRC22:47
*** Sukhdev has joined #openstack-ironic22:55
*** baoli_ has joined #openstack-ironic22:57
*** rcernin has quit IRC23:03
openstackgerritJay Faulkner proposed openstack/ironic: Make agent driver always PXE before cleaning  https://review.openstack.org/26384223:05
*** praneshp has quit IRC23:05
*** harlowja has joined #openstack-ironic23:12
*** klindgren has quit IRC23:25
*** gfhellma has joined #openstack-ironic23:25
*** [2]cdearborn has joined #openstack-ironic23:25
*** sabeen has quit IRC23:28
*** cdearborn has joined #openstack-ironic23:31
openstackgerritJay Faulkner proposed openstack/ironic-python-agent: Use latest CoreOS stable when building  https://review.openstack.org/32789123:40
*** mbound_ has quit IRC23:44
*** adn has joined #openstack-ironic23:44
*** aNupoisc has quit IRC23:45
*** aNupoisc has joined #openstack-ironic23:46
*** [2]cdearborn has quit IRC23:48
*** piet has joined #openstack-ironic23:48
*** adn has quit IRC23:49
*** cdearborn has quit IRC23:51
*** aNupoisc has quit IRC23:57

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!