Wednesday, 2016-06-15

*** piet_ has quit IRC00:00
*** mbound has quit IRC00:00
*** hoangcx_ has joined #openstack-ironic00:07
*** rbudden has quit IRC00:07
*** hoangcx has quit IRC00:10
*** hoangcx_ is now known as hoangcx00:10
*** garthb_ has quit IRC00:14
*** rcernin has joined #openstack-ironic00:17
*** sdake has quit IRC00:18
*** rama_y has quit IRC00:18
rlooNobodyCam: maybe. or maybe not. Let me see...00:19
*** rcernin has quit IRC00:22
*** sacharya_ has quit IRC00:23
NobodyCam:)00:23
*** jaybeale has joined #openstack-ironic00:25
*** mtanino has quit IRC00:41
*** Sukhdev has joined #openstack-ironic00:44
*** Sukhdev has quit IRC00:45
*** rcernin has joined #openstack-ironic00:48
*** rcernin has quit IRC00:53
*** mbound has joined #openstack-ironic01:01
*** rcernin has joined #openstack-ironic01:06
*** mbound has quit IRC01:06
*** hoangcx_ has joined #openstack-ironic01:07
*** ijw_ has quit IRC01:07
*** rcernin has quit IRC01:10
*** hoangcx_ has quit IRC01:11
*** hoangcx_ has joined #openstack-ironic01:13
*** jaybeale has quit IRC01:14
*** hoangcx_ has quit IRC01:15
rlooNobodyCam: not sure if it is your lucky day or not, but I looked at it :)01:21
*** rloo has quit IRC01:21
NobodyCamThank you rloo :-)01:23
*** sdake has joined #openstack-ironic01:28
*** jaybeale has joined #openstack-ironic01:30
*** sdake has quit IRC01:32
*** wajdi has quit IRC01:39
*** wajdi has joined #openstack-ironic01:39
*** baoli has joined #openstack-ironic01:41
*** wajdi has quit IRC01:45
*** links has joined #openstack-ironic01:54
*** sacharya has joined #openstack-ironic01:55
*** jrist has quit IRC01:56
*** sacharya_ has joined #openstack-ironic01:57
*** sacharya has quit IRC02:00
*** jrist has joined #openstack-ironic02:03
*** PollyZ has joined #openstack-ironic02:20
*** PollyZ has quit IRC02:25
*** hoangcx_ has joined #openstack-ironic02:30
*** hoangcx_ has quit IRC02:30
*** abcxyz has joined #openstack-ironic02:31
*** baoli has quit IRC02:32
*** garthb has joined #openstack-ironic02:40
*** PollyZ has joined #openstack-ironic02:42
*** jaybeale has quit IRC02:45
*** yuanying has quit IRC02:50
*** yuanying has joined #openstack-ironic02:53
*** PollyZ has quit IRC02:55
*** PollyZ has joined #openstack-ironic02:55
*** links has quit IRC02:56
*** PollyZ has quit IRC02:58
*** kalpase has joined #openstack-ironic03:00
*** ijw has joined #openstack-ironic03:19
*** fragatina has quit IRC03:22
openstackgerritDevananda van der Veen proposed openstack/ironic: [WIP] Add keystone policy support to Ironic  https://review.openstack.org/32559903:22
*** PollyZ has joined #openstack-ironic03:30
*** linuxgeek has quit IRC03:39
*** PollyZ has quit IRC03:41
*** jaybeale has joined #openstack-ironic03:43
*** vmud213 has joined #openstack-ironic03:43
*** yuanying_ has joined #openstack-ironic03:48
*** yuanying has quit IRC03:49
*** moshele has joined #openstack-ironic03:49
*** linuxgeek has joined #openstack-ironic03:50
*** Sukhdev has joined #openstack-ironic03:50
*** abcxyz has quit IRC03:57
*** abcxyz has joined #openstack-ironic03:57
*** jaybeale has quit IRC04:05
*** links has joined #openstack-ironic04:05
*** ijw has quit IRC04:15
*** PollyZ has joined #openstack-ironic04:19
*** vishwanathj has joined #openstack-ironic04:27
*** skramaja has quit IRC04:29
*** sacharya_ has quit IRC04:33
*** PollyZ has quit IRC04:35
*** vmud213 has quit IRC04:36
*** vishwanathj has quit IRC04:36
*** vmud213 has joined #openstack-ironic04:39
*** skramaja has joined #openstack-ironic04:45
*** wajdi has joined #openstack-ironic04:46
*** vmud213 has quit IRC04:48
*** fragatina has joined #openstack-ironic04:52
*** fragatina has quit IRC04:53
*** fragatina has joined #openstack-ironic04:53
*** garthb has quit IRC04:55
openstackgerritNisha Agarwal proposed openstack/proliantutils: Fix the logic for fetching the gpu device count  https://review.openstack.org/31540205:03
*** abcxyz has quit IRC05:05
*** abcxyz has joined #openstack-ironic05:05
*** rama_y has joined #openstack-ironic05:10
*** bcornec1 has quit IRC05:12
*** abcxyz has quit IRC05:17
*** bcornec1 has joined #openstack-ironic05:24
*** abcxyz has joined #openstack-ironic05:26
*** abcxyz has quit IRC05:37
*** appu103_ has joined #openstack-ironic05:41
*** abcxyz has joined #openstack-ironic05:42
*** rama_y has quit IRC05:44
*** appu103_ is now known as aparnav05:44
*** ChubYann has quit IRC05:51
*** moshele has quit IRC05:53
*** mbound has joined #openstack-ironic05:55
*** mbound has quit IRC06:00
*** yuanying has joined #openstack-ironic06:03
openstackgerritYuiko Takada Mori proposed openstack/ironic-specs: Nova compatible serial console support  https://review.openstack.org/31950506:04
*** yuanying_ has quit IRC06:05
*** flwang has quit IRC06:05
*** aparnav has quit IRC06:05
*** appu103_ has joined #openstack-ironic06:06
*** bcornec1 has quit IRC06:07
*** yolanda has joined #openstack-ironic06:13
*** rbartal has joined #openstack-ironic06:13
*** yolanda_ has joined #openstack-ironic06:13
*** yolanda_ has quit IRC06:14
*** itamarl has joined #openstack-ironic06:15
*** openstackgerrit has quit IRC06:18
*** openstackgerrit has joined #openstack-ironic06:18
*** yuanying has quit IRC06:21
*** bcornec1 has joined #openstack-ironic06:23
*** yuanying has joined #openstack-ironic06:28
*** bcornec2 has joined #openstack-ironic06:29
*** rcernin has joined #openstack-ironic06:29
*** flwang has joined #openstack-ironic06:30
*** abcxyz has quit IRC06:33
*** appu103_ has quit IRC06:45
*** appu103_ has joined #openstack-ironic06:45
openstackgerritlokesh s proposed openstack/ironic: Add support for the audit middleware  https://review.openstack.org/27265806:45
*** ifarkas has joined #openstack-ironic06:49
openstackgerritMilan Kováčik proposed openstack/ironic-inspector: [WIP]Introducing Inspector Grenade testing  https://review.openstack.org/32766706:50
milan#pixiesay morning Ironic! -m flexing06:51
PixieBootsᕙʕ⇀ᴥ⇀ʔᕗ: morning Ironic!06:51
*** e0ne has joined #openstack-ironic06:51
*** athomas has joined #openstack-ironic06:56
openstackgerritlokesh s proposed openstack/ironic: Add support for the audit middleware  https://review.openstack.org/27265806:57
openstackgerritVasyl Saienko proposed openstack/ironic: Move tempest configuration to test-config phase  https://review.openstack.org/32977907:03
*** tesseract has joined #openstack-ironic07:03
*** rcernin has quit IRC07:04
*** rcernin has joined #openstack-ironic07:04
*** yuanying has quit IRC07:05
*** yuanying has joined #openstack-ironic07:08
*** milan has quit IRC07:17
*** dhellmann has quit IRC07:20
*** dhellmann has joined #openstack-ironic07:20
*** abcxyz has joined #openstack-ironic07:27
*** Sukhdev has quit IRC07:29
*** openstackgerrit has quit IRC07:33
*** openstackgerrit has joined #openstack-ironic07:33
openstackgerritAparna proposed openstack/proliantutils: Sort values of raid_config for 'share_physical_disks'  https://review.openstack.org/32631907:36
*** kalpase has quit IRC07:38
openstackgerritVasyl Saienko proposed openstack/ironic: Add test to verify ironic multitenancy  https://review.openstack.org/26915707:38
openstackgerritVasyl Saienko proposed openstack/ironic: DO NOT REVIEW  https://review.openstack.org/29643207:38
*** links has quit IRC07:39
openstackgerritPavlo Shchelokovskyy proposed openstack/ironic: Warn on legacy auth options on conductor start  https://review.openstack.org/32666007:49
openstackgerritPavlo Shchelokovskyy proposed openstack/ironic: Update devstack plugin with new auth options  https://review.openstack.org/29731207:49
openstackgerritPavlo Shchelokovskyy proposed openstack/ironic: Migrate to using keystoneauth Sessions  https://review.openstack.org/23698207:49
*** dtantsur|afk is now known as dtantsur07:50
dtantsurMorning Ironic07:50
dtantsurJayF, oh, I didn't tell you? yeah, I've researched the hw manager examples, it was very helpful07:51
dtantsurJayF, I wonder how we could make them a part of our documentation07:51
*** jtomasek_ has joined #openstack-ironic07:53
*** links has joined #openstack-ironic07:56
*** ccamacho has joined #openstack-ironic07:56
*** zzzeek has quit IRC08:00
*** zzzeek has joined #openstack-ironic08:03
*** milan has joined #openstack-ironic08:06
*** kalpase has joined #openstack-ironic08:10
*** kalpase has quit IRC08:10
openstackgerritDavanum Srinivas (dims) proposed openstack/ironic: [WIP] Testing latest u-c  https://review.openstack.org/31844008:10
*** jtomasek_ has quit IRC08:10
alinebmorning all08:12
*** ohamada has joined #openstack-ironic08:16
*** Romanenko_K has joined #openstack-ironic08:16
*** kromanenko__ has joined #openstack-ironic08:16
*** kromanenko_ has joined #openstack-ironic08:16
*** bcornec1 has quit IRC08:19
*** dmk0202 has joined #openstack-ironic08:22
*** stendulker has joined #openstack-ironic08:28
*** hkominos has joined #openstack-ironic08:32
*** bcornec1 has joined #openstack-ironic08:33
*** abcxyz has quit IRC08:34
hkominoshello openstackers. Quick question . In order to create an image for Ironic, is it possible to use the same .img images which are used for VMs? (for example the ubuntu cloud images)08:34
*** abcxyz has joined #openstack-ironic08:35
dtantsurhkominos, iirc yes08:36
dtantsurmorning alineb08:36
alinebo/ dtantsur08:38
*** bcornec1 has quit IRC08:39
hkominosthank you08:41
*** derekh has joined #openstack-ironic08:45
*** bcornec1 has joined #openstack-ironic08:46
openstackgerritlokesh s proposed openstack/ironic: Add support for the audit middleware  https://review.openstack.org/27265808:49
*** mbound has joined #openstack-ironic08:52
*** abcxyz has quit IRC08:57
*** abcxyz has joined #openstack-ironic08:57
*** electrofelix has joined #openstack-ironic08:59
*** bcornec2 has quit IRC09:00
*** wagiel has joined #openstack-ironic09:00
vdrokmorning ironic, milan dtantsur and alineb09:02
wagielHi, can you help me get the local.conf for the devstack with real hardware involved instead of vms?09:02
dtantsurmorning vdrok09:03
openstackgerritShivanand Tendulker proposed openstack/ironic: Add validation of 'ilo_deploy_iso' in deploy.validate()  https://review.openstack.org/32983709:03
* dtantsur never used devstack with hardware09:03
milanmorning vdrok dtantsur alineb wagiel  and all the Ironicers :)09:04
dtantsurhey milan09:04
alinebmorning vdrok, milan :)09:04
vdrokwagiel: I did not try that myself too, but take a look here - https://github.com/openstack/ironic/blob/master/devstack/lib/ironic#L83909:06
vdrokyou basically need to set IRONIC_IS_HARDWARE to true in local conf and deploy driver to be eg agent_ipmitool instead of agent_ssh09:07
vdrokthe deploy driver you should use depends on your hardware of course09:07
*** jtomasek_ has joined #openstack-ironic09:08
wagielyes ive read all that already hoping that someone tried that already and have working example09:08
vdrokwagiel: then all the nodes should be described in hwinfo file, its format is described here - https://github.com/openstack/ironic/blob/master/devstack/lib/ironic#L66-L9009:08
vdrokwagiel: I think sambetts|afk has it, you might want to wait while he's online then :)09:09
wagielperfect i will try myself and wait09:10
*** mgould|afk is now known as mgould09:10
mgouldmorning dtantsur hkominos alineb vdrok milan wagiel and everyone else!09:10
vdrokgood morning mgould09:11
milanmorning mgould :)09:11
dtantsurhey mgould09:11
alinebmorning mgould09:11
*** jtomasek_ has quit IRC09:13
openstackgerritDmitry Tantsur proposed openstack/python-ironicclient: Add --wait flag for provision actions and wait_for_provision_state function  https://review.openstack.org/32819109:13
*** abcxyz has quit IRC09:14
*** abcxyz has joined #openstack-ironic09:15
sambetts|afkMorning all09:16
*** sambetts|afk is now known as sambetts09:16
dtantsurmorning sambetts09:16
sambettswagiel: this is the local.conf I use for deploying real hardware in a devstack09:19
sambettswagiel: http://paste.openstack.org/show/516174/09:19
milanmorning sambetts :)09:19
wagielyes!!! thank you, appreciate it09:19
*** abcxyz has quit IRC09:20
*** abcxyz has joined #openstack-ironic09:20
sambettswagiel: there are parts that are specific to my setup like the IMAGE_URLS etc but the big thing is getting the networking setup right so that its talking on a flat neutron network etc09:21
wagielyes09:22
wagielsure i will take that into account09:22
openstackgerritVasyl Saienko proposed openstack/ironic: Add test to verify ironic multitenancy  https://review.openstack.org/26915709:24
openstackgerritVasyl Saienko proposed openstack/ironic: DO NOT REVIEW  https://review.openstack.org/29643209:24
openstackgerritDmitry Tantsur proposed openstack/python-ironicclient: Add --wait flag for provision actions and wait_for_provision_state function  https://review.openstack.org/32819109:25
openstackgerritDmitry Tantsur proposed openstack/python-ironicclient: Add --wait flag for provision actions and wait_for_provision_state function  https://review.openstack.org/32819109:30
openstackgerritDmitry Tantsur proposed openstack/python-ironicclient: Add --wait flag for provision actions and wait_for_provision_state function  https://review.openstack.org/32819109:33
*** ohamada_ has joined #openstack-ironic09:34
*** ohamada has quit IRC09:34
*** athomas has quit IRC09:45
*** bcornec1 has quit IRC09:47
*** bcornec1 has joined #openstack-ironic09:47
*** athomas has joined #openstack-ironic09:50
*** cinerama has quit IRC09:51
hkominosnever used devstack : (09:53
*** cinerama has joined #openstack-ironic09:55
*** bcornec1 has quit IRC09:57
*** moshele has joined #openstack-ironic10:03
*** bcornec1 has joined #openstack-ironic10:08
*** hoangcx has quit IRC10:24
hkominoshello again openstackers. I am reading the manual and something is not clear. In the manual it is stated that the MAC address of the target host must be provided ( I have fuel with 2 NICS + IMPI ). Which mac does it require. The one in which the private Baremetal network is ?10:27
sambettshkominos: You need the mac address of the NIC that the node will be PXE booted on10:28
hkominos!. ok that makes more sense. thx10:29
openstackhkominos: Error: "." is not a valid command.10:29
hkominos! ok that makes more sense. thx10:29
openstackhkominos: Error: "ok" is not a valid command.10:29
dtantsur#pixiesay "ok" is a valid command10:30
PixieBootsʕ•͡ᴥ•ʔ: "ok" is a valid command10:30
hkominosok that makes more sense. I assume10:30
sambettshaha10:30
hkominoshahah10:30
*** abcxyz has quit IRC10:30
hkominosThere is not a lof of documentation and tutorials going around for ironic10:30
hkominosthis is becoming a frustration10:31
*** hoangcx has joined #openstack-ironic10:31
*** bcornec1 has quit IRC10:36
openstackgerritxiexs proposed openstack/ironic: Trivial comments fix  https://review.openstack.org/32987010:39
openstackgerritAline Bousquet proposed openstack/python-ironicclient: Fix error returned by ironic --json node-validate  https://review.openstack.org/30396410:57
*** bcornec1 has joined #openstack-ironic10:58
*** vmud213 has joined #openstack-ironic11:00
*** abcxyz has joined #openstack-ironic11:03
*** hoangcx has quit IRC11:04
*** bcornec1 has quit IRC11:04
*** baoli has joined #openstack-ironic11:05
*** baoli has quit IRC11:06
mat128good morning group!11:13
sambettsMorning mat128 :)11:14
*** dprince has joined #openstack-ironic11:14
*** ccamacho is now known as ccamacho|lunch11:16
*** hparekh has quit IRC11:16
*** stendulker has quit IRC11:16
*** thrash|g0ne is now known as thrash11:19
*** hparekh has joined #openstack-ironic11:19
*** hparekh_ has joined #openstack-ironic11:19
*** hparekh_ has quit IRC11:20
*** bcornec1 has joined #openstack-ironic11:23
sambettsdtantsur: Re: rloo's comments here, which do you think? https://review.openstack.org/#/c/320584/10/ironic_python_agent/hardware.py should I clear the cache if there's an exception or not?11:23
sambettsdtantsur: I can't decided if it should or no11:23
dtantsurhmmm11:23
mat128sambetts: what kind of exceptions can get_lldp_info raise?11:25
openstackgerritSam Betts proposed openstack/ironic-python-agent: Support LLDP data as part of interfaces in inventory  https://review.openstack.org/32058411:25
mat128oic11:26
sambettsmat128: any error related to opening and reading data from sockets11:26
mat128yeah11:26
mat128this is analogous to HTTP proxies IMO11:27
mat128is the cache invalidated because the origin cannot be reached?11:27
sambettsright11:27
sambettsnot sure :/11:27
mat128sambetts: it's not, cache is valid until TTL expires11:27
mat128we dont have such ttl for lldp_data11:28
sambettsmy orignal attitude, was only replace the existing data if we have some data to replace it with11:28
sambettsbut then I thought that I have no indication in that function that the function has has failed to refresh the cache, so you might be operating on old data11:29
mat128I'd be curious if there is caching/cache where it's already used11:30
mat128https://github.com/openstack/ironic-python-agent/commit/15aaa03833208bb8ed8a5e164c164b9e073a476911:30
mat128This brought the module and it's tests, with no usage11:30
mat128:P11:30
sambettsyup :) I'm adding the usage ;)11:30
sambettsI wonder if I should have it return True if successful and False if the function fails, and make it log to say Failed to refresh the cache so expect None or Old lldp data11:31
mat128sambetts: the thing I see with this approach is that it's fine from a code point of view11:34
mat128sambetts: but lets say you are using this in the field, having it return false and log that it was expired "so you got nothing" doesnt help you profile a machine11:34
mat128you need the data11:34
mat128sambetts: could we distinguish between "timeout waiting for lldp data" vs "generic socket error" ?11:34
mat128sambetts: given how this is lldp data and it's main purpose is to identify the machine's peers, I would say any data is good data, it's not like an operator will change cabling during inspection11:37
mat128if you identified your ToR and the ports you are on, this is exactly the required info11:37
*** mgoddard has joined #openstack-ironic11:38
sambettsright, so a timeout waiting for lldp isn't considered a failure, in that case it returns an empty list for the port, with attidude of LLDP must not be running on this interface that why I've not received any packets on this interface11:38
sambettsso I think the failures we'd see in my new function would be something failed to open socket because reason11:39
sambettsor failed to read data from socket for reason11:39
*** bcornec1 has quit IRC11:41
mat128sambetts: I know timeout is configureable, lets say this is below what you have configured in your switch, you might end up not getting any data11:42
mat128sambetts: remember this isn't like lldpd where it runs in the background and always listens11:42
sambettsmat128: exactly, so in that case it logs that it failed to get any LLDP data for certain port, and then sets that ports list of TLVs to []11:43
mat128sambetts: what if we previously had lldp data11:43
mat128sambetts: is it invalidated? (I think thats rloo's point)11:44
mat128Given how this is LLDP data, I would say no11:44
mat128Physical topology shouldnt change *during* inspection/profiling11:44
jrollif LLDP info is changing while the agent is running, you have bigger problems :P11:44
jrollmat128++11:44
mat128yup :)11:45
sambettsyeah, so my orignal thoughts is I don't think it should be, I say we only replace data if we have data to replace it with11:45
mat128sambetts: I think that's right. I will provide the explanation in your review so everyone can see it11:45
sambettsthanks mat128 :D11:45
sambettsI need to fix one part of the code anyway, to make that work because right now if it gets any data it'll wipe the whole cache, I'll make it so that it replaces per interface instead of the whole cache11:46
*** bcornec1 has joined #openstack-ironic11:48
mat128jroll: can you share why lldpd was not used instead? I know you can query it in a machine parsable format and it would take care of all of that on it's own.11:49
jrollmat128: history!11:49
jrollso11:49
mat128one reason I see is adding a new dependency and bloating the filesystem, but thats it :P11:49
vdrokmorning mat128 and jroll11:50
mat128o/ vdrok11:50
jrollwe run IPA in a systemd-nspawn container, as a single process, no init system there11:50
mat128ahhh yes11:50
jrollso adding lldpd would need an init system11:50
mat128yeah, got it11:50
jrollalso it was quite the fun little thing to figure out :P11:50
mat128supervisord ;)11:51
mat128yeah11:51
jrollikr11:51
mat128I mean, I'm impressed its contained in 2-3 pages tops11:51
mat128thought it was much more elaborate than this11:51
jrollI'm not opposed to someone making lldpd work in all the images, but we already have the code, so meh11:51
jrollheh, yeah I was too11:51
sambettstinyipa has an init system, because its not all Yo Dawg I heard you like containers11:52
sambetts;)11:52
jrollhey we use chroots now :)11:52
mat128jroll++11:52
mat128exactly what I was about to say11:53
jrollbut, the coreos+container thing honestly was focused on making the builder easy and customizable11:53
mat128we could do it now, but as you said, we already have the code and it works11:53
sambettsthe existing solution is pretty elegant really11:53
sambettscertainly going to be smaller than including another dep too11:53
jrollJayF is the linux systems guru and he was like, let's make this not terrible11:53
openstackgerritSam Betts proposed openstack/ironic-python-agent: Support LLDP data as part of interfaces in inventory  https://review.openstack.org/32058411:54
mat128haha11:54
*** abcxyz has quit IRC11:54
sambettshaha not terrible is a good thing :P11:54
jrollalso, fun fact for your future irc log grepping, lldp via tcpdump: tcpdump -i p9p2 -nn -vvvv ether proto 0x88cc11:54
jrollbecause the first time you deploy this and it doesn't work, you'll want that ;)11:54
jrollbecause you know someone will forget to enable lldp on that one switchport11:55
*** moshele has quit IRC11:55
jroll(make your life easy and do that in the ML2 driver)11:55
*** moshele has joined #openstack-ironic11:55
* jroll stops resurrecting nightmares now11:55
sambettshahahaha :-P that solution I've put up is actually based on sucessfully using it with inspector to populate local link info11:56
jroll++11:56
sambettsthe existing one was stagnating so I was like eh I'm just going to push my working solution11:56
sambettsit also didn't have the flexiblity we needed11:56
mat128jroll: good old "switch not being configured as expected"11:57
jroll:D11:57
mat128I would add "after we told you to change the template 10 times and change that setting" we still have to write code to do it for you11:57
mat128lessons learned: manual steps are bound to fail11:57
sambettsheh, inspection in the new world is a giant chicken and egg problem11:57
sambettsbecause we need lldp data to program the switch, but we need the switch programmed to do inspection to get lldp data11:58
mat128at some point you decided node X would be plugged in power outlet A, switch port B and C11:59
jrollsambetts: yeah, that initial kick step is hard11:59
*** jcoufal has joined #openstack-ironic11:59
mat128and if you preconfigure all switch ports for lldp until they are used by a tenant11:59
jrollsambetts: if only ironic could deploy switches and their initial config... :)11:59
sambettsright, so we basically added a step to our guide at that point that says you have to manually put the switch port into the inspection network12:00
mat128jroll: we seriously discussed deploying toasters12:00
jrollmat128: well, switches seem more productive :D12:00
jrollmat128: NobodyCam wrote a coffeepot driver once12:00
mat128sambetts: why not have your network plugin make that switch?12:00
mat128jroll: I wish it was still in-tree with provisioning and cleaning =)12:00
jrollheh12:01
*** e0ne has quit IRC12:01
sambettsmat128: the network plugin doesn't know that switch port is plugged into a BM until we pass the local link info when Ironic does a port create for provisioning12:02
*** e0ne has joined #openstack-ironic12:02
jrollsambetts: seriously though, ironic should be able to do the initial wipe-and-config for a switch. roll in a rack, power it up, give ironic switch info, it resets the switch and lays down initial config (inspector mode) and then inspector goes and finds all the things12:02
mat128this++12:03
mat128Ironic as the bare-metal manager for your datacenter12:03
mat128:D12:03
jrolland/or ironic resets the switch and tells neutron about it, neutron does the config, don't care12:03
jrollmat128++12:03
mat128manages all things baremetal12:03
mat128jroll: its the same12:03
mat128ironic "makes it happen"12:03
sambettsjroll: yeah that works if that switch is used for just BM, and at that point we don't need to use the LLDP inspection to know what plugged into what either12:03
*** appu103_ has quit IRC12:04
jrollsambetts: in an ideal world ironic owns the dc12:04
* jroll side note we need a cmdb, urgh12:04
sambettsjroll: works for an undercloud where everything is BM I guess :-p12:04
*** nico-afk is now known as nicodemos12:05
*** mgoddard_ has joined #openstack-ironic12:05
nicodemosgood morning12:05
dtantsurspec related: https://review.openstack.org/32000312:05
dtantsurmorning nicodemos12:05
jrollsambetts: it's metal turtles all the way down12:05
sambettsmmm metal turtle soup12:05
*** hoangcx has joined #openstack-ironic12:06
mat128sambetts: almost http://render.fineartamerica.com/images/rendered/medium/throw-pillow/images-medium/turtle-soup-dale-moses.jpg12:07
openstackgerritMiles Gould proposed openstack/ironic: Document testing an in-review patch with devstack  https://review.openstack.org/32989812:07
sambettshaha12:07
*** mgoddard has quit IRC12:08
*** ccamacho|lunch is now known as ccamacho12:10
*** jjohnson2_ has joined #openstack-ironic12:12
mgouldsambetts: I literally didn't know that was possible until we paired on the TinyIPA stuff, I think it's a good thing for new devs to know :-)12:12
mat128mgould: what you were working on will be forever in the docs ;)12:13
TheJuliaGood morning12:13
mat128mgould: 295946/1512:13
mat128o/ TheJulia12:13
mgouldmat128: not my patch :-)12:14
sambettsmgould: sorry, which bit? my brain is a jubbled mess at the moment12:14
mgouldsambetts: using devstack to check out an in-progress patch12:14
*** mbound has quit IRC12:15
sambettsmgould: ooh right12:15
*** mbound has joined #openstack-ironic12:15
*** daemontool has joined #openstack-ironic12:16
sambettsmgould: yeah I used to do it manually for ages, e.g. run devstack, cd /opt/stack/X, git fetch and checkout, screen -x, ctrl-c, restart12:16
mat128sambetts: any idea on testing the lldp stuff in devstack?12:16
mgouldyeah, I did that a few times too12:16
mat128sambetts, mgould: you guys know you can do git review -d 329898, right?12:16
mat128saves copying the full line from gerrit12:16
sambettsmat128: yup, that works if your devstck machine is configured to use git review :-P12:17
sambettsmat128: I've never tried to use LLDP with virtual BM only on a real test bed12:17
mgouldmat128: I do now :-)12:17
* sambetts is sad that he can't test his patches properly right now because his testbed is being borrowed because downstream deadlines 12:18
mat128sambetts: we have simulated LLDP in the past (different product =) by running lldpd on the "host"12:18
mgouldmat128: actually, I dimly recall seeing that somewhere, but now can't find the page I saw it on :-(12:18
*** baoli has joined #openstack-ironic12:19
mat128mgould: lldp or git review? the former was an internal project here so I would be surprised :)12:19
sambettsmat128: our VMs in devstck for virtual BM are plugged into OVS so I wonder if that supports it12:19
mgouldmat128: git review12:20
*** baoli has quit IRC12:20
mat128sambetts: yeah right.. I wouldnt know12:20
*** baoli has joined #openstack-ironic12:20
mat128mgould: ah ok :)12:20
sambettssomething we should look into I guess12:20
mat128mgould: theres always this: http://docs.openstack.org/infra/git-review/usage.html12:20
mgouldif I had seen your internal project docs, I wouldn't admit to it in a public logged channel :-)12:21
sambettshahaha12:21
mat128mgould: lmao12:21
mat128tbh, the test suite was more impressive than the product itself12:21
mat128we would release new versions with barely trying it on metal hardware12:22
mgouldmat128: ah, so it's "./stack.sh; cd /opt/stack/$project; git review -d $change; [manual test steps]"?12:22
*** baoli_ has joined #openstack-ironic12:22
mat128mgould: yes, as long as you have git-review installed on your devstack box12:22
mat128as Sam pointed out12:22
mat128sambetts: there's hope: http://openvswitch.org/pipermail/discuss/2015-May/017659.html12:22
mgouldawesome, I'll do that after lunch12:22
mgouldmat128: effective CI is a thing of beauty and a joy forever12:23
mgouldflaky CI is awful :-(12:23
*** trown|outtypewww is now known as trown12:23
mat128yup12:23
mgouldbrb12:24
sambettsflaky CI just leads to distrust in the results, and in OpenStack results in people rechecking over and over again without even checking the results, because they assume it was a transiant failure12:25
*** baoli has quit IRC12:25
*** Goneri has joined #openstack-ironic12:26
*** rbudden has joined #openstack-ironic12:27
mat128sambetts: the tooling is pretty good here, with elastic-recheck and everything12:28
jrollhey, can some folks review the infiniband spec soon? I'd love sambetts review especially https://review.openstack.org/#/c/265635/12:28
sambettsjroll: sure I'll take a look12:29
jrollthanks12:29
sambettsmat128: it gets better every day :)12:29
jrollTheJulia: NobodyCam: if you could re-review as well please :) ^12:29
*** mgoddard_ has quit IRC12:30
*** mgoddard has joined #openstack-ironic12:30
*** ionutbalutoiu has joined #openstack-ironic12:31
*** frontrunner has joined #openstack-ironic12:31
mgouldmat128: Elastic Recheck feels like a solution to a problem we shouldn't have :-(12:34
mat128mgould: unless we control all variables we will always have such issues12:34
mat128mgould: we rely on external pip packages, apt-get mirrors running correctly, and even more12:34
mgouldyeah, I suppose so12:35
mgould"a heavy solution to a problem that shouldn't be so severe", perhaps12:35
mat128agreed12:35
mat128if only we could gate public package uploads to pypi =)12:35
vsaienkoMorning Ironic'ers!12:37
vdrok\o/12:38
TheJuliajroll: will do12:38
*** wagiel has quit IRC12:38
*** mbound has quit IRC12:40
jrollTheJulia: thanks :)12:41
mat128o/ vsaienko12:43
vsaienkodo we have a bug about apache restart failures at the ironic gates?12:45
jrollvsaienko: yes, let me find it12:46
jrollvsaienko: https://bugs.launchpad.net/ironic/+bug/159013912:46
openstackLaunchpad bug 1590139 in Ironic "gate job fails when unable to start apache service during horizon setup" [Undecided,New]12:46
sambettsjroll: I was about to leave a comment about adding vendor_id as a new column saying that port.extra should be used instead because its an implementation specific field, but looking back at past comments I see that it was switched to its own field based on comments from you to avoid json fields, I'm not sure if I agree or not12:46
jrollvsaienko: and the elastic recheck patch https://review.openstack.org/#/c/326739/12:47
jrollsambetts: I didn't ask for it to be its own field, to be clear :) I asked why it wasn't part of the address, and that somehow devolved into it being its own field12:48
jrollsambetts: port.extra makes sense, I didn't get a chance to respond and say so12:48
sambettsjroll: ah right :-P12:49
*** bcornec1 has quit IRC12:50
sambettsjroll: I think that we're going to have to have a list of supported vendor_ids, because the GUID to mac conversion is vendor specific12:51
jrollsambetts: indeed12:51
*** bcornec1 has joined #openstack-ironic12:51
sambettsjroll: vendor_id plugin system?12:51
jrolloh god no pls12:52
sambetts;)12:52
dtantsurmorning jroll, mat128, vsaienko, TheJulia and whoever I didn't say good morning yet :)12:54
jrollmorning dtantsur :)12:55
TheJuliaRegarding bug 1590139, I think this is our culprit "+ lib/apache:restart_apache_server:190     :   sleep 3" <-- not enough time for the kernel to close out sockets in wait state which can prevent the port being rebound.12:55
openstackbug 1590139 in Ironic "gate job fails when unable to start apache service during horizon setup" [Undecided,New] https://launchpad.net/bugs/159013912:55
dtantsurjroll, please review https://review.openstack.org/#/c/306418/ I'm going to hack on it really soon, it blocks the driver composition12:56
dtantsur(the spec to promote agent API)12:56
*** lindycoder has joined #openstack-ironic12:58
*** itamarl has quit IRC12:58
jrolldtantsur: sure, driver comp is also on my hotlist12:59
vsaienkojroll please have look https://review.openstack.org/32990812:59
*** lindycod_ has joined #openstack-ironic12:59
jrollvsaienko: cool13:00
*** bcornec1 has quit IRC13:00
vsaienkoI remember we had the same problem in mos when switched to keystone on wsgi13:01
vsaienkohttps://github.com/openstack/fuel-library/commit/ff2274e44ab732d943976d1b21c8997dc90a7d9413:01
NobodyCamGood Morning Ironicers13:01
NobodyCamjroll: will have a look after I get some coffee going13:01
dtantsurmorning NobodyCam13:01
NobodyCammorning dtantsur :)13:01
*** dprince has quit IRC13:02
vdrokmorning TheJulia and NobodyCam13:03
*** lindycoder has quit IRC13:03
NobodyCamgood morning vdrok :)13:03
*** bcornec1 has joined #openstack-ironic13:03
*** jcoufal has quit IRC13:04
jrollNobodyCam: morning, thanks :)13:05
NobodyCam:)13:07
*** jvgrant_ has joined #openstack-ironic13:09
*** rloo has joined #openstack-ironic13:09
*** bcornec1 has quit IRC13:10
*** rcernin has quit IRC13:14
NobodyCamThank you rloo :)13:14
rlooNobodyCam: yw :)13:15
NobodyCamand Good morning :) lol :)13:15
sambettsjroll: left some comments, hopefully I'm not being mad :-P13:15
NobodyCammorning sambetts13:15
sambettsHey NobodyCam \o/13:15
rlooNobodyCam: Gooooood morning to you too! And to sambetts, jroll, TheJulia and everyone else!13:15
*** bcornec1 has joined #openstack-ironic13:16
sambettsHi rloo!13:16
NobodyCam\o/13:16
dtantsurrloo, morning13:16
vsaienkomorning rloo13:19
NobodyCammorning vsaienko13:19
rloohi dtantsur, vsaienko13:19
vsaienkoo/ NobodyCam13:19
NobodyCam:)13:19
*** bcornec1 has quit IRC13:22
*** xavierr-afk is now known as xavierr13:23
xavierrmorning Ironic :)13:23
xavierrmorning NobodyCam rloo sambetts dtantsur vsaienko13:24
NobodyCammorning xavierr13:24
rloomorning xavierr13:24
*** bcornec1 has joined #openstack-ironic13:25
mgouldmorning rloo NobodyCam TheJulia jroll13:26
NobodyCammorning mgould13:27
rloohi mgould13:28
*** rcernin has joined #openstack-ironic13:28
*** sdake has joined #openstack-ironic13:29
*** bcornec1 has quit IRC13:30
*** moshele has quit IRC13:32
*** moshele has joined #openstack-ironic13:33
vsaienkoIronic'ers just a notice, who don't know multitenancy patches passed grenade and multitenancy gate tests https://review.openstack.org/#/c/296432/. I'm kindly asking to review them as it is highest priority for community :). Thanks in advance!13:34
jroll++13:34
*** jjohnson2_ has quit IRC13:34
*** joprovost has joined #openstack-ironic13:34
NobodyCamw00t13:35
sambetts\o/13:35
*** wajdi has quit IRC13:35
NobodyCamvsaienko: the title is "DO NOT REVIEW"13:38
NobodyCamlol13:38
jrollNobodyCam: that's the patch to collect all the things and test...13:38
NobodyCam:p13:39
*** jcoufal has joined #openstack-ironic13:39
*** mbound has joined #openstack-ironic13:41
*** jcoufal_ has joined #openstack-ironic13:41
*** sdake_ has joined #openstack-ironic13:42
*** jcoufal has quit IRC13:45
*** sdake has quit IRC13:45
hkominosIs there any documentation in which i can see the Nic-Network configuration for an ironic slave?13:45
*** mbound has quit IRC13:46
*** PollyZ has joined #openstack-ironic13:47
*** sacharya has joined #openstack-ironic13:49
*** bcornec1 has joined #openstack-ironic13:51
vdrokmorning rloo and xavierr13:51
rloohi vdrok13:51
*** sacharya_ has joined #openstack-ironic13:53
*** rcernin has quit IRC13:54
*** bcornec1 has quit IRC13:55
*** sacharya has quit IRC13:56
*** links has quit IRC13:56
*** bcornec1 has joined #openstack-ironic13:58
*** sacharya_ has quit IRC13:59
*** sacharya has joined #openstack-ironic13:59
*** dprince has joined #openstack-ironic13:59
*** joprovost1 has joined #openstack-ironic14:00
*** jvgrant_ has quit IRC14:00
*** joprovost has quit IRC14:01
*** joprovost1 is now known as joprovost14:01
*** bcornec2 has joined #openstack-ironic14:01
*** jaybeale has joined #openstack-ironic14:02
*** cdearborn has joined #openstack-ironic14:02
openstackgerritSam Betts proposed openstack/ironic-specs: Add spec for interface attach and detach API  https://review.openstack.org/31763614:06
*** mtanino has joined #openstack-ironic14:06
*** jvgrant_ has joined #openstack-ironic14:07
*** rcernin has joined #openstack-ironic14:09
jlvillalvsaienko, That is great on the multi-tenancy work :) Thanks for that!14:11
*** bcornec2 has quit IRC14:13
*** hoangcx has quit IRC14:13
*** jvgrant_ has quit IRC14:14
*** rcernin has quit IRC14:18
*** trown is now known as trown|mtg14:18
PollyZGood morning for this one https://bugs.launchpad.net/wsme/+bug/1256042, does anyone know if it has been fixed or no14:21
openstackLaunchpad bug 1256042 in WSME "Pecan's on_error() hook never gets trigged when used with WSME" [High,Confirmed] - Assigned to Jianing Yang (jianingy)14:21
jrollPollyZ: doesn't appear so, from the status14:22
*** moshele has quit IRC14:22
*** moshele has joined #openstack-ironic14:23
*** jrist has quit IRC14:23
PollyZjroll: And I couldn't reach to the person who is responible for this14:24
*** moshele has quit IRC14:24
rloovsaienko, jroll: wrt the multitenancy work -- maybe send an email out to devlist?14:24
jrollPollyZ: they assigned themselves two years ago, I would go ahead and work on it if you want to14:25
jrollrloo: ++14:25
*** dprince has quit IRC14:25
*** joprovost1 has joined #openstack-ironic14:28
*** bcornec2 has joined #openstack-ironic14:28
*** vmud213 has quit IRC14:28
openstackgerritMiles Gould proposed openstack/ironic: Document testing an in-review patch with devstack  https://review.openstack.org/32989814:29
*** joprovost has quit IRC14:29
xavierrhey vdrok o/14:29
*** rcernin has joined #openstack-ironic14:31
*** joprovost1 has quit IRC14:32
*** catintheroof has joined #openstack-ironic14:32
vsaienkorloo +114:32
PollyZjroll: Thank you :)14:33
*** jrist has joined #openstack-ironic14:37
*** joprovost has joined #openstack-ironic14:39
*** jaybeale has quit IRC14:40
*** bcornec2 has quit IRC14:40
*** wajdi has joined #openstack-ironic14:40
openstackgerritMiles Gould proposed openstack/ironic: Document testing an in-review patch with devstack  https://review.openstack.org/32989814:42
*** wajdi has quit IRC14:43
*** wajdi has joined #openstack-ironic14:44
*** bcornec2 has joined #openstack-ironic14:44
*** jvgrant_ has joined #openstack-ironic14:45
*** tloeb has joined #openstack-ironic14:47
*** hoangcx has joined #openstack-ironic14:48
dtantsurjroll, I started hacking on the agent API thing. do you think we should move the find-node-by-macs thing to objects.Node?14:55
dtantsurmy concern is that it also accesses objects.Port14:55
jrolldtantsur: I'm good with that, select from nodes and join on the port14:56
jrollthat's been a todo forever14:56
dtantsurcool14:57
*** rbartal has quit IRC15:04
openstackgerritZhenguo Niu proposed openstack/ironic: Replace vif_portgroup_id with vif_port_id  https://review.openstack.org/32519715:06
openstackgerritCorey Bryant proposed openstack/ironic: Use assert_called_once_with in test_cleanup_cleanwait_timeout  https://review.openstack.org/33000115:08
*** catintheroof has quit IRC15:08
*** sdake_ has quit IRC15:08
JayFDo we have a doc on how to build a dib image for fedora?15:08
JayFhmm. There's a patch up to add devstack support for doing it, maybe I can learn from there...15:09
*** tobias_fiberdata has quit IRC15:09
sambettsJayF: you should just be able to replace ubuntu with fedora15:09
JayFSee you're starting from "knows how to build a dib image at all"15:09
JayFlol15:09
sambetts:-P15:10
*** sdake has joined #openstack-ironic15:10
sambettsah, is the image for tenant image or IPA image?15:10
JayFipa image15:10
JayFjust wanted to play around some with the other ramdisks since I only use coreos much15:10
sambettsdisk-image-create ironic-agent fedora -o ironic-agent15:11
sambettsJayF: ^15:11
openstackgerritPavlo Shchelokovskyy proposed openstack/ironic: Deny some driver_info updates when console is on  https://review.openstack.org/33000315:11
*** sdake has quit IRC15:11
JayFthat seems super easy15:11
sambettsJayF: we document it in the inspector docs :)15:12
* JayF suspicious of anything that seems easy15:12
sambettsheh15:12
TheJuliaJayF: it truly is rather easy :)15:12
*** garthb has joined #openstack-ironic15:12
JayFand, apparently, supported in devstack now15:13
sambettsrloo: thanks for being on top of reviewing my lldp patch :D15:13
JayFI don't get why we don't have these publishing too, and testing against IPA?15:13
JayFEven if we don't want to publish the image, it looks like we're just project-config away from actually testing dib images in ipa gate15:13
JayFI guess we wanted to figure out the dep stuff before doing that though, eh15:13
rloosambetts: yw. i think i reviewed too many things yesterday; i seem to have a bunch that i need to re-review etc today :-(15:13
*** bcornec2 has quit IRC15:14
sambetts:(15:15
rlooJayF: do you mean http://docs.openstack.org/developer/ironic/deploy/install-guide.html#buildingdibbaseddeployramdisk15:15
*** SiRiuS__ has joined #openstack-ironic15:15
*** bcornec2 has joined #openstack-ironic15:20
*** rloo has quit IRC15:23
*** rloo has joined #openstack-ironic15:23
*** ifarkas has quit IRC15:23
*** bcornec2 has quit IRC15:27
*** bcornec2 has joined #openstack-ironic15:28
*** ChrisAusten has joined #openstack-ironic15:30
openstackgerritDmitry Tantsur proposed openstack/ironic: [WIP] [REALLY WIP] Promote agent vendor passthru to core API  https://review.openstack.org/33001815:31
*** jaybeale has joined #openstack-ironic15:32
*** rama_y has joined #openstack-ironic15:32
openstackgerritVladyslav Drok proposed openstack/ironic: Replace vif_portgroup_id with vif_port_id  https://review.openstack.org/32519715:34
vdrokdtantsur: re https://review.openstack.org/325197 I think there is no need for a release note as there is no API for portgroups15:35
*** moshele has joined #openstack-ironic15:35
dtantsurvdrok, I'd still create a release note for people who already expect us to use the old name once we get to the API15:36
dtantsuror even: if we had API already, that would probably be a breaking change. now I only ask for a release note :)15:36
vdrokhm, I think I did see a comments on another zhenguo's patch that was doing a similar thing from rloo or yuriyz15:36
rloovdrok: you called? :)15:37
vdrokyep, https://review.openstack.org/325197 :)15:37
vdrokrloo: release note when there is no API yet15:37
rloovdrok: how would someone be using this code?15:37
vdroksee dtantsur's messages :) ^^15:38
rloodtantsur: who would be expecting us to use this in the API? people that are pulling down unmerged patches?15:39
dtantsurrloo, writing their code for future API for example?15:39
dtantsurrloo, yes. there are a lot of them already15:39
vdrokdtantsur: rloo I thought release notes are mostly for operators?15:39
rloovdrok: that's what i thought too15:40
*** sabeen has joined #openstack-ironic15:40
rloovdrok: but i think dtantsur thinks this could break someone's deployment.15:41
dtantsur1. I don't agree with that; 2. the difference is subtle15:41
sambettsif we add a release note it would look really weird in the compiled release notes right? i.e. we'll have a release note saying its adding it followed by a release note saying its changing it15:41
dtantsurif release notes are only for operators, does it mean we should not make release notes for changes in the driver interface? I don't think so.15:41
dtantsursambetts, that's sad, but we're doing it all the time15:42
jrollwe could fix the existing release note...15:42
sambettsalso I don't think things in the port.extra field are part of our offical API15:42
vdroksambetts: there is not reno saying it was added I think15:42
rloovdrok, dtantsur, sambetts: so I just looked at our existing release notes, i don't see any reference to vif_portgroup_id: http://docs.openstack.org/releasenotes/ironic/mitaka.html15:42
vdrok++15:42
JayFsambetts: did you see the comment yesterday; someone said IPA partitition images work in coreos but not tinyipa15:42
JayFsambetts: you know anything about that?15:42
vdrokJayF: it was me, and it seems it's not the case anymore15:43
JayFah wonderful!15:43
rlooso i think it would be confusing to mention this change in the release notes. also, it is in .extra and it wasn't documented anywhere.15:43
vdrokJayF: sambetts see https://review.openstack.org/329625 partition image job, it failed, but it's not something with binary dependencies15:43
sambettsthings in .extra are part of the offical API its driver specific (now)15:43
*** tobias_fiberdata has joined #openstack-ironic15:44
sambettsaren't*15:44
jrollI don't think a release note is needed here, honestly15:44
rloovdrok, dtantsur, sambetts: I don't think we should put a reno for that15:44
sambettsI agree15:44
vdrokwe just need to convince dtantsur :)15:45
rlooit is only going to confuse people i think.15:45
* rloo gives dtantsur a beer15:45
sambettswe'd be adding a release note fixing something for an incomplete feature15:45
sambettstbh I think its weird that it was created as its own bug15:45
rloosambetts: i think the problem is in us not knowing how to really handle LONG features15:46
sambetts++15:46
dtantsursambetts, " things in .extra aren't part of the offical API" <-- wrong15:46
sambetts*cough* feature branch *cough*15:46
dtantsurit should not, but it is15:46
dtantsur* they15:47
sambettsdtantsur: its not though, its just a weird contract we have between ironic and the nova driver15:47
vdrokdtantsur: ok, but still there is no way to set it now, just by using code on review15:47
mat128reno example of a feature that got introduced and modified: http://docs.openstack.org/releasenotes/ironic-python-agent/current-series.html15:47
mat128has_carrier15:47
rloosambetts: yup, in hindsight, that should have been on a feature branch. but in liberty cycle, who would have thought it wouldn't get in til newton or beyond?15:47
mat128The “has_carrier” flag was added [...] and Stop checking the “has_carrier” field when [...]15:47
sambettsrloo: v.true15:47
dtantsursambetts, weird contract between ironic and nova is definitely something we have to consider API :)15:47
jrolldtantsur: things in .extra are not *officially supported* parts of our API15:48
jrollthey are not subject to backward compat, etc15:48
sambettsdtantsur: trying to fix that https://review.openstack.org/#/c/327046/15:48
dtantsurjroll, we don't officially support nova or what?15:48
openstackgerritMerged openstack/ironic: Trivial comments fix  https://review.openstack.org/32987015:48
dtantsurit's part of our contract with nova and essentially everyone following the same15:48
dtantsursambetts++15:48
jrolldtantsur: that's a different thing IMO, but nova doesn't use vif_portgroup_id today15:48
dtantsurjroll, yeah, I agree about portgroup, but lets face the truth that the port vif is a part of our API right now..15:49
vdrokand noone using code from master can use it15:49
jrolldtantsur: it's part of our contract between nova and ironic, but is not part of our officially supported API15:49
dtantsurvdrok, I've removed -1 fwiw15:49
jrolldtantsur: that said, we can't just break that one because we'll break the nova contract15:49
dtantsurright. that's what "supported" means to me15:50
vdrokdtantsur: thanks :)15:50
dtantsurand I clearly expect people using ironic+neutron without nova to do the same15:50
*** pcaruana has quit IRC15:50
jrolldtantsur: let me rephrase, port.extra['vif_port_id'] is supported (which is a bug to me), the rest of .extra is not15:50
jrollsambetts is fixing that bug so three cheers for him15:50
dtantsurgood :) btw found that I used it as well: https://github.com/dtantsur/metalsmith/blob/master/metalsmith/deploy.py#L8215:50
jrollya15:51
sambettsand vif_port_id is soon going to network driver specifc, just like ipmi_password etc15:51
sambettsare for power15:51
jrollsay wha?15:51
sambetts so port.extra should be seen the same as driver_info15:51
sambettsbut for network drivers15:52
dtantsur>_<15:52
*** jrist has quit IRC15:52
*** trown|mtg is now known as trown15:52
*** dmk0202 has quit IRC15:52
sambettsjroll: neutron network driver requires it, None driver does not, one of my experimental network drivers also does not15:53
*** rcernin has quit IRC15:53
jrollsambetts: :/15:53
*** Sukhdev has joined #openstack-ironic15:53
sambettshence why we need an attach and detach interface API that should call into network driver15:53
sambettsbecause different driver handle that part differently15:54
*** jaybeale has quit IRC15:54
jrollyep15:55
*** SiRiuS__ has quit IRC15:55
sambettsJayF, vdrok: So agent driver + partition images + tinyIPA is working now?15:55
openstackgerritDmitry Tantsur proposed openstack/ironic: [WIP] [REALLY WIP] Promote agent vendor passthru to core API  https://review.openstack.org/33001815:55
dtantsurthings become more and more complex pretty quickly15:55
sambettsdtantsur: ooooh yes :-P15:55
*** tesseract has quit IRC15:55
* mgould lols at [REALLY WIP]15:56
vdroksambetts: I've referenced https://review.openstack.org/329625 it adds all the bits necessary to run a job properly, see the result of gate-tempest-dsvm-ironic-agent_ssh-partition-image-nv15:56
vdrokit is on tinyipa15:56
dtantsurmgould, :)15:56
mgouldsambetts, mat128: my devstack VM now has git-review set up - thanks!15:56
sambettsmgould: awesome15:56
* mgould hastily takes a snapshot15:56
*** SiRiuS__ has joined #openstack-ironic15:57
*** ohamada_ has quit IRC15:59
*** garthb has quit IRC16:00
sambettsvdrok: so http://logs.openstack.org/25/329625/2/check/gate-tempest-dsvm-ironic-agent_ssh-partition-image-nv/e7115a3/logs/ironic-bm-logs/ the image is totally deploying and booting, I'm really confused whats causing that errro16:00
vdroksambetts: http://logs.openstack.org/25/329625/2/check/gate-tempest-dsvm-ironic-agent_ssh-partition-image-nv/e7115a3/logs/ironic-bm-logs/node-0_console_14-06-2016-20:28:43.txt.gz#_2016-06-14_20_28_05_38716:01
vdrokephemeral_mb None16:01
*** ijw has joined #openstack-ironic16:01
*** tloeb has quit IRC16:01
vdrokit depends on a devstack-gate patch setting ephemeral size tho16:01
*** jcoufal has joined #openstack-ironic16:01
sambettsvdrok: sounds like an error on the Ironic side then right?16:02
vdrokyeah, either or devstack gate, or devstack plugin :)16:02
vdrokI'll take a closer look now16:02
*** jcoufal_ has quit IRC16:03
sambettsvdrok: I'm not sure you can depends-on a devstack-gate patch, have you had that work before16:03
sambetts?16:03
sambettsvdrok: oh maybe you can :/16:04
vdroksambetts: idk really, I now that project-config does not work this way, but not sure about devstack-gate, it should work the same way as devstack16:04
openstackgerritMiles Gould proposed openstack/ironic: Document testing an in-review patch with devstack  https://review.openstack.org/32989816:05
*** sdake has joined #openstack-ironic16:05
sambettshttp://logs.openstack.org/25/329625/2/check/gate-tempest-dsvm-ironic-agent_ssh-partition-image-nv/e7115a3/console.html#_2016-06-14_19_57_54_266 that doesn't == https://review.openstack.org/#/c/326061/216:05
vdroksambetts: it works, passed from devstack-gate http://logs.openstack.org/25/329625/2/check/gate-tempest-dsvm-ironic-agent_ssh-partition-image-nv/e7115a3/logs/devstacklog.txt.gz#_2016-06-14_20_22_39_94216:05
*** athomas has quit IRC16:05
vdrokotherwise it would be 0-16:05
vdrokhmm16:06
*** appu103_ has joined #openstack-ironic16:06
sambettswhere does DEVSTACK_GATE_IRONIC_EPHEMERAL come from, do we already have that in our Jenkins job?16:06
*** bcornec2 has quit IRC16:07
sambettsoh yeah I see it in the exported vars16:07
vdroksambetts: correct, it was merged already16:07
vdrokdunno why commit hash is different16:07
sambettsno :/16:07
sambettslooking at the tempest test logs I see its been set on the node correctly16:08
*** krotscheck is now known as krotscheck_dcm16:09
*** thiagop has joined #openstack-ironic16:10
*** [1]cdearborn has joined #openstack-ironic16:10
sambettsvdrok: Looking at the agent driver, I can see its looking for ephemeral_mb not ephemeral_gb16:11
*** tobias_fiberdata has quit IRC16:11
vdroksambetts: yeah I noticed it too16:11
sambettsvdrok: which is why its appearing to be None16:12
sambettsvdrok: because ephemeral_gb is set on the node, and then it does a instance_info.get(ephemeral_mb)16:12
openstackgerritMilan Kováčik proposed openstack/ironic-inspector: [WIP]Introducing Inspector Grenade testing  https://review.openstack.org/32766716:13
sambettsvdrok: I'm thinking it might have always been broken16:14
*** bcornec2 has joined #openstack-ironic16:14
sambettsbut we've never tested it properly16:14
thiagopGood morning, Ironic16:15
*** tobias_fiberdata has joined #openstack-ironic16:15
vdroksambetts: yeah. nova is setting it to instance_info, so the s/mb/gb should be the only change needed16:15
vdrokmorning thiagop16:16
*** milan has quit IRC16:16
vdroksambetts: heh https://github.com/openstack/ironic-python-agent/blob/3cf5369cb6285fe32c310fba7c712c690feb4ea4/ironic_python_agent/extensions/standby.py#L9216:17
vdrokipa expects mb too16:17
*** piet has joined #openstack-ironic16:17
sambetts-,- oh dear...16:17
vdrokand ironic-lib too16:18
sambettsvdrok: take a look at ironic/drivers/modules/iscsi_deploy.py L21216:18
sambettsvdrok: thats what we should be doing in that driver16:18
dtantsurooops16:18
vdrok+++16:19
sambettswe are missing a ephemeral_mb = 1024 * int(i_info['ephemeral_gb']16:19
sambetts)16:19
vdroksambetts: same for root_mb16:20
NobodyCammorning thiagop16:20
sambettsvdrok: yeah, and swap16:20
vdroksambetts: ah, missed this one - https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/deploy_utils.py#L113916:21
vdrokso everything is ok except ephemeral16:21
*** derekh has quit IRC16:22
vdrokswap_mb is mb already from the beginning16:22
sambettsvdrok: we should add a line into that function adding ephemeral_mb to i_info16:23
vdroksambetts: yep, will file a bug and a patch now16:23
sambettsSweet \o/ yay for CI catching stuff!16:23
sambettsJayF: ^ if you didn't follow the conversation16:23
sambettsJayF: basically agent driver is passing ephemeral_gb instead of ephemeral_mb as IPA expects16:24
*** bcornec2 has quit IRC16:25
*** cdearborn has quit IRC16:25
*** kromanenko__ has quit IRC16:26
*** kromanenko_ has quit IRC16:26
*** Romanenko_K has quit IRC16:26
openstackgerritNisha Agarwal proposed openstack/proliantutils: Fix the logic for fetching the gpu device count  https://review.openstack.org/31540216:30
*** dprince has joined #openstack-ironic16:31
*** piet has quit IRC16:32
*** piet has joined #openstack-ironic16:33
*** tobias_fiberdata has quit IRC16:34
*** piet has quit IRC16:36
*** piet has joined #openstack-ironic16:37
*** trown is now known as trown|lunch16:39
*** mgould is now known as mgould|afk16:40
*** abcxyz has joined #openstack-ironic16:41
*** sdake has quit IRC16:42
*** mbound has joined #openstack-ironic16:43
*** hoangcx has quit IRC16:43
*** bcornec2 has joined #openstack-ironic16:44
*** cdearborn has joined #openstack-ironic16:44
*** yolanda has quit IRC16:46
*** [2]cdearborn has joined #openstack-ironic16:50
JayFsambetts: so that means partition images are broken for all of IPA right now, right?16:50
JayFsambetts: we gotta test that in the gate :(16:50
*** jvgrant_ has quit IRC16:50
sambettsJayF: I would assume so yes, and thats what the job that caught this is for right? I guess we need to move away from the whole instantly blame TinyIPA stigma16:51
*** mtanin___ has joined #openstack-ironic16:54
*** mtanino has quit IRC16:55
JayFsambetts: I don't see those jobs failing? I'm confused16:55
JayFsambetts: was it just one patch breaking something vs all ci being broken?16:56
sambettsJayF: so right now that job still boots whole disk images16:56
*** milan has joined #openstack-ironic16:56
vdrokugh, we have a broken unittest in master\16:56
sambettsJayF: vdroks patch fixes that16:56
*** rpioso has joined #openstack-ironic16:57
thiagopjlvillal: QA meeting in 2m?16:57
krtaylorjroll, the stackalytics column in the thrid party test systems table is now currrent  ->  https://wiki.openstack.org/wiki/Ironic/Drivers#3rd_Party_CI_required_implementation_status16:57
jrollkrtaylor: amazing, I was going to ask you about that in 3 minutes :)16:57
sambetts\o/16:57
JayFsambetts: I'm wondering if we need jobs to do both? I don't want whole disk support missed in ci either (especially since I run it, haha)16:58
krtaylorjroll, yep, I remembered my action this morning  :)16:58
jrollheh16:58
*** [1]cdearborn has quit IRC16:58
jlvillalthiagop: sim senhor!16:58
krtaylorjroll, but we still need to remind everyone to fulfill their infra requirements for third party test systems16:58
krtaylorbut we can discuss in meeting...16:59
sambettsJayF: there will be, https://review.openstack.org/#/c/329625/ there are 2 agent_ssh jobs16:59
thiagopjlvillal: oh, not "senhor". I have enought white hair already16:59
*** NobodyCam has quit IRC16:59
*** mgkwill has quit IRC16:59
jrollkrtaylor: indeed16:59
sambettsJayF: one whole disk and one partition16:59
JayFoh beautiful!16:59
* jroll slides over to meeting room16:59
JayFThanks for linking me to that patch16:59
*** dtantsur is now known as dtantsur|afk17:00
sambettsJayF: thats where vdrok saw the error17:00
JayFthat links all the pieces together17:00
JayFthats what I get for being too busy to read all the scrollback :( sorry for making you repeat it all17:00
*** NobodyCam has joined #openstack-ironic17:00
*** mgkwill has joined #openstack-ironic17:00
sambetts:D thats ok17:01
openstackgerritVladyslav Drok proposed openstack/ironic: Fix broken conductor unittest  https://review.openstack.org/33008717:01
*** mtanino has joined #openstack-ironic17:01
openstackgerritVladyslav Drok proposed openstack/ironic: Properly set ephemeral size in agent drivers  https://review.openstack.org/33008917:01
*** bcornec2 has quit IRC17:01
*** mtanin___ has quit IRC17:03
jrollvdrok: hrm, how does that suddenly break? :/17:04
vdrokjroll: it gives me attribute error17:04
jrollhrm, new mock version maybe?17:05
* jroll checks17:05
vdroki see only assert_called_with and assert_called_once_with17:05
*** cdearborn has quit IRC17:06
rloovdrok: https://bugs.launchpad.net/ironic/+bug/159285217:06
openstackLaunchpad bug 1592852 in Ironic "test_cleanup_cleanwait_timeout AttributeError: assert_called_once" [Undecided,In progress] - Assigned to Corey Bryant (corey.bryant)17:06
jrollyeah, that does look wrong, just curious why it's suddenly broken17:06
rlooi'm also curious as to why it suddenly broke.17:06
*** cdearborn has joined #openstack-ironic17:07
*** PollyZ_ has joined #openstack-ironic17:07
vdrokheh, yep, 2.0.0. mock has this method :)17:07
vdrokrloo: jroll ^^17:07
vdroki'll abandon17:07
jrollhrm, tox -repy27 passes on master for me17:07
rloovdrok: check your dev env. you should be using mock 2.0.0, it is in test-requirements.txt17:09
vdrokyes, thanks rloo, false alarm :)17:09
rloovdrok: phew!17:09
vdrokneed to recreate it more often17:09
jrollthough I wonder if it isn't in python 3.5 or something17:10
jrollidk17:10
*** PollyZ has quit IRC17:10
*** sacharya has quit IRC17:11
*** sacharya has joined #openstack-ironic17:12
*** bcornec2 has joined #openstack-ironic17:13
openstackgerritVladyslav Drok proposed openstack/ironic: Properly set ephemeral size in agent drivers  https://review.openstack.org/33008917:16
openstackgerritVladyslav Drok proposed openstack/ironic: Change the logic of selecting image for tests  https://review.openstack.org/32962517:16
jlvillalJayF: http://ci-watch.tintri.com/project?project=ironic&time=7+days looks pretty good. The link from krtaylor17:18
JayFnice17:18
JayFI can't see any situations where grenade failed that something else did17:18
JayFsambetts: vdrok: We need to add that partition image job to IPA as a -src job too, one each for coreos and tinyipa17:19
JayFsambetts: vdrok: before it can vote on ironic imo17:19
sambettsTotally17:19
openstackgerritSam Betts proposed openstack/ironic-inspector: Add generic LLDP processing hook  https://review.openstack.org/32108217:20
*** PollyZ has joined #openstack-ironic17:21
*** [2]cdearborn has quit IRC17:21
*** pcaruana has joined #openstack-ironic17:21
vdrokJayF: agree17:22
jlvillalTheJulia: Would you mind looking at: https://review.openstack.org/#/c/330001/  Thanks in advance :)17:23
jlvillalJayF: Yes. Failures seem to map close to other failures. I did see one of the 'apache restart' failures. But that isn't the Grenade job's issue17:23
*** PollyZ_ has quit IRC17:24
JayFYeah; I mean I almost want to say I think that's compelling enough to make it voting17:24
JayFthe only thing I'd be curious about would be a negative test17:24
JayFshould we make sure something that does break upgrades fails grenade?17:24
jrollJayF: ++17:26
*** Sukhdev has quit IRC17:26
*** piet has quit IRC17:29
*** fragatina has quit IRC17:29
*** appu103_ has quit IRC17:30
*** aparnav has joined #openstack-ironic17:30
*** moshele has quit IRC17:33
*** aparnav has quit IRC17:34
*** electrofelix has quit IRC17:34
*** appu103_ has joined #openstack-ironic17:35
*** sacharya_ has joined #openstack-ironic17:40
*** sacharya has quit IRC17:43
TheJuliajlvillal: sure17:44
jlvillalTheJulia: Thanks. vdrok pointed out that it was correct because of the version of mock we use. I guess that call is new in mock.17:45
jlvillalTheJulia: The existing code is correct, that is.17:45
TheJuliajlvillal: done17:46
jlvillal:)17:47
TheJuliaYeah, I glanced at the bug report and immediately thought something is odd, but it is all good17:47
*** bcornec2 has quit IRC17:47
*** mtanino has quit IRC17:48
krtaylorthiagop, sambetts - I removed the duplicate driver wiki table entries - sorry about that, I was searching on the driver name from stackalytics17:51
*** trown|lunch is now known as trown17:51
thiagopkrtaylor: thanks for that17:52
*** bcornec2 has joined #openstack-ironic17:52
vdroksambetts: success \o/ http://logs.openstack.org/25/329625/3/check/gate-tempest-dsvm-ironic-agent_ssh-partition-image-nv/68cbcd0/console.html17:54
sambettsvdrok: \o/17:55
vdrokgood night everyone!17:55
sambettsnight vdrok!17:55
jlvillalvdrok: Ciao17:55
*** bcornec1 has quit IRC17:55
vdrokjlvillal: paka-paka :D17:55
NobodyCamnight vdrok17:55
jlvillalvdrok: I can't help but think mock would have been better if they had done it as:  mock.assert.what_we_want_to_assert()17:55
jlvillalvdrok: Dos ve dos17:55
* jlvillal has no idea if that would have been easily done or not. Too late now.17:56
*** bcornec2 has quit IRC17:57
*** PollyZ has quit IRC17:57
*** daemontool has quit IRC17:59
*** PollyZ has joined #openstack-ironic18:02
*** jvgrant_ has joined #openstack-ironic18:02
*** appu103_ has quit IRC18:02
*** mtanino has joined #openstack-ironic18:02
*** mbound has quit IRC18:06
*** ccamacho is now known as ccamacho|out18:08
*** fragatina has joined #openstack-ironic18:08
*** jvgrant_ has quit IRC18:09
*** bcornec1 has joined #openstack-ironic18:12
*** ChubYann has joined #openstack-ironic18:15
devanandahah! figured out why https://review.openstack.org/#/c/325599/ is failing some tests and not others18:16
* jroll curious18:16
devanandain gate-tempest-dsvm-ironic-pxe_ipa Nova is creating a neutron port and then Ironic is tyring to update it18:16
devanandaand fails with PortNotFound, because I changed the service tenant18:16
devanandawhy is this NOT a problem for gate-tempest-dsvm-ironic-agent_ssh ???18:17
jrollO_o18:18
jrollit should be18:18
devanandayea - it's not18:18
devanandahttp://logs.openstack.org/99/325599/6/check/gate-tempest-dsvm-ironic-agent_ssh/698df48/logs/screen-ir-cond.txt.gz isn't updating hte neutron port18:19
devanandacreated here - http://logs.openstack.org/99/325599/6/check/gate-tempest-dsvm-ironic-agent_ssh/698df48/logs/screen-n-cpu.txt.gz#_2016-06-15_03_51_35_56318:19
devanandabut it's never invoked from ironic18:19
devanandawtf?18:19
devanandahere's the error in the pxe_ipa job: http://logs.openstack.org/99/325599/6/check/gate-tempest-dsvm-ironic-pxe_ipa/dbe5abc/logs/screen-ir-cond.txt.gz?#_2016-06-15_03_53_17_36618:20
devanandahere's the matching port create in the pxe_ipa job: http://logs.openstack.org/99/325599/6/check/gate-tempest-dsvm-ironic-pxe_ipa/dbe5abc/logs/screen-n-cpu.txt.gz#_2016-06-15_03_51_35_22718:20
JayFwhat do the *_ipmitool jobs do?18:21
* JayF looks18:21
JayFit looks like pxe_* driver vs agent_* driver is the difference, at a glance the pxe_ipmitool driver fails too and the agent_ipmitool job passes18:21
jrollwhat is going on here18:22
jrollthis is weird18:22
jrolllike, we can't pxe if we don't update the port18:22
devanandaJayF: yes18:22
devanandapassing job uses agent, failing job uses pxe. passing job downloads image in IPA, failing job writes image successfully over iscsi18:23
JayFhttps://review.openstack.org/gitweb?p=openstack/ironic.git;a=blob;f=devstack/lib/ironic;h=5df3e09b6a1c9938d9f53772719b2c95e0b1404b;hb=ff0150dec26741756640c884b9a8c25dd25fb131#l51318:23
JayFcould that locally set tenant_id be leaking? but i don't think that explains the behavior18:23
JayFthat's just the only place I could see devstack changing behavior based on driver18:24
JayFso I guess this has to be a bug in actual ironic code?18:24
*** bcornec1 has quit IRC18:25
jrollit just never plugs the vifs18:26
jrollhere's where it gets into _plug_vifs http://logs.openstack.org/99/325599/6/check/gate-tempest-dsvm-ironic-agent_ssh/698df48/logs/screen-n-cpu.txt.gz#_2016-06-15_03_51_35_84118:26
jrollhttps://github.com/openstack/nova/blob/master/nova/virt/ironic/driver.py#L99218:26
jrollbut it just doesn't do the rest?18:26
openstackgerritJulia Kreger proposed openstack/bifrost: Do Not Merge: Canery test for ironic networking changes  https://review.openstack.org/33013818:27
jrollor maybe it does, hard to tell18:27
devanandacontext here is this change in my patch: https://review.openstack.org/#/c/325599/6/devstack/lib/ironic18:28
devanandaI *think* that has exposed a difference in the behavior of these drivers?18:29
jrollI'm not going that far yet, something is weird18:30
jrollhow did the agent pxe boot if we didn't pass dhcp opts to neutron?18:30
devanandain both jobs, nova creates the port18:30
*** e0ne has quit IRC18:30
jrollI think it is running _plug_vifs fine, I see lots of PATCH /v1/ports/foo in that timeframe18:30
*** bcornec1 has joined #openstack-ironic18:31
* sambetts -> home 18:31
sambettsNight all18:31
jrollerm18:31
jrolllook at this: http://logs.openstack.org/99/325599/6/check/gate-tempest-dsvm-ironic-agent_ssh/698df48/logs/screen-ir-cond.txt.gz#_2016-06-15_03_51_12_70118:31
jrolldown to http://logs.openstack.org/99/325599/6/check/gate-tempest-dsvm-ironic-agent_ssh/698df48/logs/screen-ir-cond.txt.gz#_2016-06-15_03_51_12_75218:32
jrollclearly not a real deploy18:32
*** sambetts is now known as sambetts|afk18:32
jrollunless we also test that api in tempest with fake driver18:32
jrolland this is the wrong deploy18:32
*** bcornec2 has joined #openstack-ironic18:33
thiagopnight sambetts|afk18:33
jrollthis should be raising errors correctly if things are wacky (e.g. no port info) https://github.com/openstack/ironic/blob/master/ironic/dhcp/neutron.py#L14618:33
* jroll is super confused here18:35
jrolldevananda: hrm, it did get dhcp opts somewhere somehow http://logs.openstack.org/99/325599/6/check/gate-tempest-dsvm-ironic-agent_ssh/698df48/logs/screen-q-svc.txt.gz#_2016-06-15_03_51_36_74918:37
jrolldevananda: I wonder if one of two things are happening here18:37
jroll1) the token expired and we re-auth'd with the neutron creds in ironic.conf18:38
openstackgerritJulia Kreger proposed openstack/bifrost: Do Not Merge: Canery test for ironic networking changes  https://review.openstack.org/33013818:38
devananda2016-06-15 03:53:17.364 12227 INFO neutron.wsgi [req-67765959-cc23-4507-8066-e7c3dd140d73 ironic -] 104.130.211.184 - - [15/Jun/2016 03:53:17] "PUT /v2.0/ports/8f9297de-3929-424e-9538-5ea20cf902de.json HTTP/1.1" 404 338 0.02882918:38
devanandaI think that's the problem18:38
*** PollyZ_ has joined #openstack-ironic18:38
jroll2) somehow we're using different neutron tokens/creds in agent vs pxe18:38
jrollwell18:38
jrollsee my link?18:38
jrolltimeline lines up correctly on my link too18:38
jroll2016-06-15 03:51:36.749 12426 DEBUG neutron.api.v2.base [req-bff773b1-b506-4f0b-8e4b-5426fb6c9546 admin -] Request body: {u'port': {u'extra_dhcp_opts': [{u'opt_value': u'undionly.kpxe',18:39
jroll2016-06-15 03:51:37.158 22480 DEBUG ironic.dhcp.neutron [req-d6ce37da-3cfb-460f-b58f-83a947b37e94 - - - - -] Waiting 15 seconds for Neutron. update_dhcp_opts /opt/stack/new/ironic/ironic/dhcp/neutron.py:21518:39
*** PollyZ has quit IRC18:39
jroll(or is yours the pxe driver, mine is agent)18:39
jrollyeah, yours must be from the failure18:40
*** joprovost1 has joined #openstack-ironic18:40
jrollright, so that is the problem, question is if 404 is because it's actually not there, or because it belongs to another user18:40
devanandathe 404 error is clearly coming from a request made by the 'ironic' user18:41
devanandawhereas the port was created by the 'admin' user18:41
jrollwhy was the port created by the admin user?18:41
jrollit should be created by the 'demo' user18:42
devanandaso, two problems I see18:42
*** joprovost has quit IRC18:42
*** joprovost1 is now known as joprovost18:42
jrollyou're right thuogh, my port update came from admin user18:42
devananda1. in the agent driver, there's only one PUT request to Neutron, which I believe is coming from Nova, not Ironic18:42
devananda2. in the pxe driver, both Nova and Ironic need to be able to see and update the same neutron port (and my patch has run afoul of this)18:43
jroll1. no, these both use the PxeBoot interface. it follows this code path: https://github.com/openstack/ironic/blob/master/ironic/dhcp/neutron.py#L14618:44
jrollhowever18:45
jrollthe neutron client will transparently re-authenticate if needed, using the creds defined in ironic.conf18:45
jrollalso for 2. I'd clarify that to "ironic needs to be able to update ports on behalf of the user"18:45
jrollin both drivers18:45
devanandayea, well, it seems to do that as the admin user, on behalf of the end user, which is perhaps the problem18:46
devanandaI need to run out for a bit ... this is going to be fun to unwind :-/18:46
devanandawish I could stay and keep working on it, but I'll bbl18:46
jrollyeah, we update ports on behalf of the user, it's kinda required18:46
jrollunless we can pass that context all the way down, we'll need to be admin18:47
jrollsee ya18:47
devanandahttps://github.com/openstack/ironic/blob/master/ironic/dhcp/neutron.py#L8718:50
devanandahttps://review.openstack.org/#/c/325599/6/devstack/lib/ironic18:50
devanandaI moved the ironic user from 'admin' to 'service'18:51
devanandabut why DIDN"T that break all the drivers?18:51
devanandathat's what I don't get18:51
devanandaanyhow... bbl18:51
jrollneutron re-auths if it gets 40118:51
jrollI assume you got lucky and the token expired just in case18:51
jrollbut I'm not 100% sure what all is going on here18:51
*** bcornec1 has quit IRC18:52
jrolloh, I see now18:52
jrollwtf18:52
devanandahow could ironic have had a valid admin-tenant token?18:53
jrollyeah I have nfi18:54
jrolloh you know what18:54
*** SiRiuS__ has quit IRC18:54
jrollI bet there's magic here https://github.com/openstack/ironic/blob/master/ironic/common/context.py#L4718:55
jrollmaybe not, ugh18:55
*** Sukhdev has joined #openstack-ironic19:02
openstackgerritRamamani Yeleswarapu proposed openstack/ironic: Centralize Config Options - patch merge, cleanup  https://review.openstack.org/33016019:04
*** piet has joined #openstack-ironic19:05
*** mbound has joined #openstack-ironic19:06
*** mbound has quit IRC19:11
*** bcornec1 has joined #openstack-ironic19:15
*** dprince has quit IRC19:21
*** skramaja has quit IRC19:24
*** jvgrant_ has joined #openstack-ironic19:25
*** piet has quit IRC19:25
*** piet has joined #openstack-ironic19:26
openstackgerritRamamani Yeleswarapu proposed openstack/ironic: Add Ironic specs process to the code contribution guide  https://review.openstack.org/33016719:31
*** MattMan has quit IRC19:32
*** MattMan has joined #openstack-ironic19:32
*** openstackgerrit has quit IRC19:33
*** openstackgerrit has joined #openstack-ironic19:33
*** piet has quit IRC19:33
*** sdake has joined #openstack-ironic19:36
*** skramaja has joined #openstack-ironic19:36
*** bcornec1 has quit IRC19:37
*** bcornec1 has joined #openstack-ironic19:40
*** mrda has quit IRC19:40
*** sdake_ has joined #openstack-ironic19:40
openstackgerritMerged openstack/ironic: Use assert_called_once_with in test_cleanup_cleanwait_timeout  https://review.openstack.org/33000119:41
*** sdake has quit IRC19:42
*** mrda has joined #openstack-ironic19:42
*** SiRiuS__ has joined #openstack-ironic19:46
*** e0ne has joined #openstack-ironic19:48
*** bcornec1 has quit IRC19:51
*** abcxyz has quit IRC19:53
*** hoangcx has joined #openstack-ironic19:54
*** bcornec1 has joined #openstack-ironic19:58
*** jcoufal_ has joined #openstack-ironic19:59
*** krotscheck_dcm is now known as krotscheck20:00
*** jcoufal has quit IRC20:02
*** Sukhdev has quit IRC20:02
*** jvgrant_ has quit IRC20:02
*** joprovost has quit IRC20:03
*** dprince has joined #openstack-ironic20:07
*** sdake_ has quit IRC20:07
*** krsacme has joined #openstack-ironic20:07
*** sdake has joined #openstack-ironic20:07
jlvillalDid keystone client break python-ironicclient stable/liberty?  http://logs.openstack.org/51/234451/1/gate/gate-python-ironicclient-python27/c6c6b5b/console.html#_2016-06-14_20_06_51_97220:09
*** skramaja has quit IRC20:11
*** sdake_ has joined #openstack-ironic20:11
*** sdake has quit IRC20:12
*** jvgrant_ has joined #openstack-ironic20:17
jrolljlvillal: looks like it, but a rebase should fix: https://review.openstack.org/#/c/237251/5/requirements.txt20:21
jrollthat merged yesterday20:21
jlvillaljroll: Thanks.20:22
jrollnp20:22
jlvillaljroll: The recheck worked, zuul is showing me.20:23
*** bcornec1 has quit IRC20:23
*** ijw has quit IRC20:26
*** sdake_ has quit IRC20:27
*** mtanino has quit IRC20:43
rloojroll or anyone else. wrt the network patches, I don't think I was paying attention. This seems to be the start of the chain now, right? https://review.openstack.org/#/c/317390/20:51
jrollrloo: yes, and the devstack code for it is a separate chain20:52
rlooand the next patch: https://review.openstack.org/#/c/206244/ portgroups API stuff, still has the -2 so we don't merge anything more until some number (the rest?) of the patches are good?20:52
jrollwe should reconsider that -2 imo20:53
rloojroll: we meaning deva et al. i think deva was against putting in the portgroup API if the rest doesn't work.20:53
rloojroll: and we're ok with this chain getting merged, before the devstack code, or can the devstack chain be reviewed/merged in parallel or before this chain?20:54
jrollrloo: I'd say in parallel, the devstack code is an easier review so probably easy to land first20:54
rloojroll: thx20:55
jrollnp20:55
openstackgerritJulia Kreger proposed openstack/bifrost: Do Not Merge: Canery test for ironic networking changes  https://review.openstack.org/33013820:59
*** jvgrant_ has quit IRC20:59
krtaylorcdearborn, do you want me to add DRAC to stackalytics?21:00
openstackgerritJulia Kreger proposed openstack/bifrost: Do Not Merge: another test for ironic networking  https://review.openstack.org/33021021:02
jlvillalSo two +2s on the Adopt state patch: https://review.openstack.org/#/c/275766/    I'm too scared to +A it without more reviews :)21:03
krtaylorcdearborn, I went ahead and added the DRAC record, feel free to review the patch for any corrections needed, patch getting close21:04
TheJuliaI think 206244 may be fine, but I'm rather concerned regarding 285852 at the moemnt... hence the two test jobs I have spinning against bifrost at the moment pulling in patches on that change set for testing21:04
jrollTheJulia: https://review.openstack.org/#/c/285852/54/ironic/drivers/modules/network/none.py21:06
jrollI think that is what standalone folks are meant to use, right?21:06
jrolland then 'flat' covers the existing neutron use case21:07
TheJuliayeah, except if they use an older client, or the current client defaults... they can never ever create the node21:07
TheJuliaat least on that specific patch and the database patch21:07
jrollhrm21:07
* jroll looks21:07
jrollwhy you gotta nerd snipe me when I'm about to leave :P21:07
*** spandhe has joined #openstack-ironic21:08
TheJuliaI've spent the last two or so hours looking at it, so you might be looking for a while21:08
TheJuliajroll: look tomorrow!21:08
NobodyCamlol21:08
jrollTheJulia: heh21:08
jrollso21:08
jrollhttps://review.openstack.org/#/c/317391/6/ironic/objects/node.py21:08
jrolllooks like it defaults to none?21:08
jrollI should stop talking without reading it all21:08
jrollah I see it21:09
jrollTheJulia: I agree, default to 'none' if not using neutron dhcp21:09
TheJuliaheh :)21:10
TheJuliago enjoy your evening21:10
jroll'enjoy'21:10
* jroll has car work to do21:10
TheJuliaokay, go get a beer, and work on the car then ;)21:11
jrollnot the fun kind either, stripped bolts21:11
jrollhehe21:11
jrollhave a good night :)21:11
TheJuliaouch :(21:11
TheJuliawell, hopefully it goes well then ;)21:11
NobodyCamjroll: the new Audi?21:11
*** nicodemos is now known as nico-afk21:11
*** hoangcx has quit IRC21:11
jrollshould be fine, buddy has every tool imaginable21:11
jrollNobodyCam: no, chevy cruze, oil drain plug is rounded off :/21:12
NobodyCamoh21:12
* NobodyCam offers two beers21:12
jrollI also have audi work to do but that's part swapping for fun and horsepower :P21:12
NobodyCamlol21:12
TheJuliaheh21:12
*** dprince has quit IRC21:13
jrollsee y'all tomorrow \o21:13
TheJuliagoodnight21:13
*** nico-afk has quit IRC21:14
*** e0ne has quit IRC21:14
*** trown is now known as trown|outtypewww21:15
*** spandhe has quit IRC21:16
*** spandhe has joined #openstack-ironic21:16
rloojlvillal: no guts no glory. should be safe to +A the adopt one, it had two +2's before I intervened.21:16
TheJuliaheh21:17
*** joprovost has joined #openstack-ironic21:17
NobodyCamANC?21:17
TheJuliayup21:19
*** Sukhdev has joined #openstack-ironic21:22
*** joprovost has quit IRC21:27
*** Sukhdev has quit IRC21:32
*** bcornec1 has joined #openstack-ironic21:32
*** ccamacho|out has quit IRC21:33
*** Sukhdev has joined #openstack-ironic21:33
*** Sukhdev has quit IRC21:36
*** bcornec1 has quit IRC21:37
openstackgerritThiago Paiva Brito proposed openstack/ironic: [WIP] Using Oneview drivers w/ IRONIC_IS_HARDWARE  https://review.openstack.org/32845121:40
*** cdearborn has quit IRC21:47
*** PollyZ_ has quit IRC21:48
*** bcornec1 has joined #openstack-ironic21:49
*** lindycod_ has quit IRC21:53
*** openstackgerrit has quit IRC22:02
*** catintheroof has joined #openstack-ironic22:04
*** openstackgerrit has joined #openstack-ironic22:06
*** moshele has joined #openstack-ironic22:07
*** jcoufal_ has quit IRC22:09
*** Sukhdev has joined #openstack-ironic22:09
*** Sukhdev has quit IRC22:09
*** Sukhdev has joined #openstack-ironic22:10
*** mbound has joined #openstack-ironic22:10
*** bcornec1 has quit IRC22:11
*** thiagop has quit IRC22:12
*** Sukhdev has quit IRC22:15
*** bcornec1 has joined #openstack-ironic22:22
*** _vsaienko has quit IRC22:24
*** hoangcx has joined #openstack-ironic22:27
*** frontrunner has quit IRC22:31
JayFSo I'm fairly certain at this point the DIB image build support in devstack that's recently merged is broken.22:31
JayFI've had it break multiple different ways, most recently with 2016-06-15 22:30:57.541 | /opt/stack/ironic/devstack/lib/ironic: line 1058: disk-image-create: command not found22:32
JayFthis is from a fresh install, with the config as listed in documentation + IRONIC_BUILD_DEPLOY_RAMDISK=True IRONIC_RAMDISK_TYPE=dib IRONIC_DIB_RAMDISK_OPTIONS=fedora22:32
*** rpioso has quit IRC22:34
JayFhttps://bugs.launchpad.net/ironic/+bug/1593005 filed22:38
openstackLaunchpad bug 1593005 in Ironic "DIB Image building in Devstack nonworking" [Undecided,New]22:38
*** catintheroof has quit IRC22:41
*** Sukhdev has joined #openstack-ironic22:42
cineramaweird22:44
*** Sukhdev has quit IRC22:44
*** Sukhdev has joined #openstack-ironic22:46
JayFI put what I believe is the cause in the bug22:47
JayFfor an ironic-only devstack configured stock, doesn't look like dib is ever pulled in22:48
*** Sukhdev has quit IRC22:53
*** jcoufal has joined #openstack-ironic22:55
*** sacharya_ has quit IRC22:56
*** sacharya has joined #openstack-ironic23:00
*** rbudden has quit IRC23:01
*** sacharya_ has joined #openstack-ironic23:02

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!