| *** bcornec1 has quit IRC | 00:00 | |
| *** baoli has joined #openstack-ironic | 00:01 | |
| *** Sukhdev has joined #openstack-ironic | 00:07 | |
| *** rcernin has quit IRC | 00:13 | |
| *** baoli has quit IRC | 00:13 | |
| *** baoli has joined #openstack-ironic | 00:23 | |
| *** bcornec1 has joined #openstack-ironic | 00:27 | |
| *** baoli has quit IRC | 00:28 | |
| *** hoangcx has joined #openstack-ironic | 00:30 | |
| *** chlong has joined #openstack-ironic | 00:36 | |
| *** bcornec1 has quit IRC | 00:53 | |
| *** bcornec1 has joined #openstack-ironic | 00:56 | |
| *** bcornec1 has quit IRC | 01:12 | |
| *** bcornec1 has joined #openstack-ironic | 01:12 | |
| *** cfarquhar has quit IRC | 01:24 | |
| *** hoangcx_ has joined #openstack-ironic | 01:27 | |
| *** hoangcx has quit IRC | 01:28 | |
| *** cfarquhar has joined #openstack-ironic | 01:29 | |
| *** cfarquhar has quit IRC | 01:29 | |
| *** cfarquhar has joined #openstack-ironic | 01:29 | |
| *** praneshp has joined #openstack-ironic | 01:30 | |
| *** hoangcx has joined #openstack-ironic | 01:33 | |
| *** hoangcx_ has quit IRC | 01:33 | |
| *** david-lyle has quit IRC | 01:34 | |
| *** hoangcx_ has joined #openstack-ironic | 01:36 | |
| *** hoangcx__ has joined #openstack-ironic | 01:38 | |
| *** baoli has joined #openstack-ironic | 01:38 | |
| *** hoangcx has quit IRC | 01:39 | |
| *** baoli has quit IRC | 01:40 | |
| *** hoangcx_ has quit IRC | 01:41 | |
| *** hoangcx__ has quit IRC | 01:51 | |
| *** PollyZ has joined #openstack-ironic | 01:51 | |
| *** hoangcx has joined #openstack-ironic | 01:55 | |
| *** baoli has joined #openstack-ironic | 01:58 | |
| *** baoli has quit IRC | 01:59 | |
| *** PollyZ_ has joined #openstack-ironic | 02:00 | |
| *** PollyZ has quit IRC | 02:00 | |
| *** spandhe has quit IRC | 02:07 | |
| *** PollyZ has joined #openstack-ironic | 02:14 | |
| *** PollyZ_ has quit IRC | 02:14 | |
| *** hoangcx_ has joined #openstack-ironic | 02:15 | |
| *** bcornec1 has quit IRC | 02:15 | |
| *** bcornec1 has joined #openstack-ironic | 02:16 | |
| *** praneshp has quit IRC | 02:18 | |
| *** hoangcx has quit IRC | 02:18 | |
| *** sacharya has joined #openstack-ironic | 02:27 | |
| *** PollyZ has quit IRC | 02:29 | |
| *** PollyZ has joined #openstack-ironic | 02:32 | |
| *** vishwanathj has joined #openstack-ironic | 02:32 | |
| *** PollyZ has quit IRC | 02:46 | |
| *** ayoung has quit IRC | 02:48 | |
| *** PollyZ has joined #openstack-ironic | 02:49 | |
| *** bcornec1 has quit IRC | 03:20 | |
| *** kalpase has joined #openstack-ironic | 03:20 | |
| *** bcornec1 has joined #openstack-ironic | 03:24 | |
| *** hoangcx has joined #openstack-ironic | 03:32 | |
| *** PollyZ has quit IRC | 03:32 | |
| *** PollyZ has joined #openstack-ironic | 03:33 | |
| *** hoangcx_ has quit IRC | 03:33 | |
| *** PollyZ has quit IRC | 03:42 | |
| *** PollyZ has joined #openstack-ironic | 03:54 | |
| *** PollyZ has quit IRC | 03:58 | |
| *** Sukhdev has quit IRC | 04:02 | |
| *** vishwanathj has quit IRC | 04:06 | |
| *** sacharya has quit IRC | 04:10 | |
| *** Sukhdev has joined #openstack-ironic | 04:10 | |
| *** PollyZ has joined #openstack-ironic | 04:15 | |
| *** vishwanathj has joined #openstack-ironic | 04:21 | |
| *** bcornec1 has quit IRC | 04:22 | |
| *** PollyZ has quit IRC | 04:23 | |
| *** vishwanathj has quit IRC | 04:25 | |
| *** links has joined #openstack-ironic | 04:26 | |
| *** bcornec1 has joined #openstack-ironic | 04:29 | |
| *** vishwanathj has joined #openstack-ironic | 04:42 | |
| *** vishwanathj has quit IRC | 05:09 | |
| *** vishwanathj has joined #openstack-ironic | 05:10 | |
| openstackgerrit | Zhenguo Niu proposed openstack/ironic-lib: Include wipefs --force option https://review.openstack.org/319918 | 05:28 |
|---|---|---|
| *** moshele has joined #openstack-ironic | 05:48 | |
| *** bcornec1 has quit IRC | 05:58 | |
| *** bcornec1 has joined #openstack-ironic | 06:01 | |
| *** chlong has quit IRC | 06:03 | |
| *** rbartal has joined #openstack-ironic | 06:05 | |
| *** rcernin has joined #openstack-ironic | 06:14 | |
| *** chlong has joined #openstack-ironic | 06:15 | |
| *** ccamacho has joined #openstack-ironic | 06:16 | |
| *** sabeen has quit IRC | 06:18 | |
| *** rcernin has quit IRC | 06:18 | |
| *** rcernin has joined #openstack-ironic | 06:19 | |
| *** lennyb has joined #openstack-ironic | 06:21 | |
| *** spandhe has joined #openstack-ironic | 06:23 | |
| *** yolanda has joined #openstack-ironic | 06:24 | |
| *** bcornec1 has quit IRC | 06:24 | |
| *** bcornec1 has joined #openstack-ironic | 06:29 | |
| *** bcornec1 has quit IRC | 06:37 | |
| *** itamarl has joined #openstack-ironic | 06:40 | |
| *** e0ne has joined #openstack-ironic | 06:53 | |
| pas-ha | morning Ironic | 06:54 |
| *** amotoki has joined #openstack-ironic | 07:00 | |
| *** tesseract has joined #openstack-ironic | 07:00 | |
| *** yolanda has quit IRC | 07:15 | |
| *** chlong has quit IRC | 07:15 | |
| *** spandhe has quit IRC | 07:17 | |
| *** yolanda has joined #openstack-ironic | 07:22 | |
| *** athomas has joined #openstack-ironic | 07:25 | |
| *** vishwanathj has quit IRC | 07:27 | |
| *** Sukhdev has quit IRC | 07:27 | |
| *** vishwanathj has joined #openstack-ironic | 07:27 | |
| vsaienko | morning pas-ha, and all Ironic'ers | 07:27 |
| *** yolanda has quit IRC | 07:31 | |
| *** yolanda has joined #openstack-ironic | 07:32 | |
| *** e0ne has quit IRC | 07:37 | |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: Move create-node.sh to create_vms function https://review.openstack.org/322850 | 07:39 |
| *** dtantsur|afk is now known as dtantsur | 07:43 | |
| dtantsur | Morning Ironic | 07:44 |
| rbartal | good morning dtantsur | 07:46 |
| dtantsur | hey rbartal | 07:47 |
| *** yolanda has quit IRC | 07:48 | |
| pas-ha | morning dtantsur | 07:49 |
| dtantsur | o/ | 07:49 |
| vsaienko | morning dtantsur | 07:50 |
| *** e0ne has joined #openstack-ironic | 07:55 | |
| *** e0ne has quit IRC | 07:59 | |
| *** zzzeek has quit IRC | 08:00 | |
| *** zzzeek has joined #openstack-ironic | 08:00 | |
| *** ifarkas has joined #openstack-ironic | 08:03 | |
| *** aarefiev_ has joined #openstack-ironic | 08:03 | |
| vdrok | morning ironic! | 08:05 |
| *** electrofelix has joined #openstack-ironic | 08:06 | |
| *** Romanenko_K has joined #openstack-ironic | 08:07 | |
| *** kromanenko__ has joined #openstack-ironic | 08:07 | |
| *** kromanenko_ has joined #openstack-ironic | 08:07 | |
| dtantsur | hey vdrok, vsaienko | 08:09 |
| openstackgerrit | Yuiko Takada Mori proposed openstack/ironic-specs: Nova compatible serial console support https://review.openstack.org/319505 | 08:09 |
| vdrok | good morning dtantsur | 08:09 |
| vsaienko | morning vdrok | 08:10 |
| vdrok | o/ :) | 08:10 |
| alineb | morning all! | 08:11 |
| dtantsur | morning alineb | 08:11 |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic-specs: Promote agent vendor passthru to core API https://review.openstack.org/306418 | 08:11 |
| *** jtomasek_ has joined #openstack-ironic | 08:13 | |
| alineb | morning dtantsur | 08:13 |
| *** ohamada has joined #openstack-ironic | 08:14 | |
| *** jtomasek_ has quit IRC | 08:19 | |
| *** milan has joined #openstack-ironic | 08:21 | |
| ccamacho | hey dtantsur good morning!, did you had time to check the screencasts at the end of https://review.openstack.org/#/c/327773/?? I worked on trying to reproduce it on mitaka/master and I wasn't able to do it.. Do you think it might be a fixed bug not backported to liberty? | 08:24 |
| dtantsur | ccamacho, morning. No, sorry. Is it only liberty? | 08:24 |
| openstackgerrit | Merged openstack/ironic: Imported Translations from Zanata https://review.openstack.org/328600 | 08:27 |
| *** vmud213 has joined #openstack-ironic | 08:28 | |
| *** yolanda has joined #openstack-ironic | 08:29 | |
| ccamacho | dtantsur, from my tests yes, it was reported as a CI failure, but If you follow the steps in https://bugs.launchpad.net/tripleo/+bug/1590755 you will be able to reproduce it without issues.. | 08:29 |
| openstack | Launchpad bug 1590755 in tripleo "TripleO deployment fails using Centos7 + stable/liberty" [Undecided,Fix released] - Assigned to Carlos Camacho (ccamacho) | 08:29 |
| dtantsur | thanks, I'll check what we didn't backport to liberty, though the list is probably big.. | 08:30 |
| vmud213 | morning everyone | 08:33 |
| milan | morning Ironic | 08:36 |
| milan | morning vmud213 | 08:36 |
| vmud213 | morning milan | 08:37 |
| *** derekh has joined #openstack-ironic | 08:38 | |
| ccamacho | dtantsur thanks! | 08:40 |
| openstackgerrit | kesper proposed openstack/proliantutils: Changed exception parameter for InvalidInputError. https://review.openstack.org/328904 | 08:43 |
| *** dmk0202 has joined #openstack-ironic | 08:44 | |
| openstackgerrit | kesper proposed openstack/proliantutils: Changed exception parameter for InvalidInputError. https://review.openstack.org/328904 | 08:45 |
| *** PollyZ has joined #openstack-ironic | 08:52 | |
| *** fragatin_ has quit IRC | 08:52 | |
| *** PollyZ has quit IRC | 08:57 | |
| *** ishant|away is now known as ishant | 09:04 | |
| *** SiRiuS__ has joined #openstack-ironic | 09:12 | |
| sambetts | Morning all | 09:17 |
| *** hoangcx has quit IRC | 09:20 | |
| sambetts | dtantsur: Re:326891 API Version bump required? if someone has derped and has response.code == 400 this change will break them right | 09:22 |
| *** e0ne has joined #openstack-ironic | 09:22 | |
| *** pcaruana has joined #openstack-ironic | 09:27 | |
| dtantsur | sambetts, I don't think so. both 400 and 500 are already returned from this endpoint | 09:28 |
| openstackgerrit | Merged openstack/ironic-inspector: Add config fixture to functional tests https://review.openstack.org/327130 | 09:28 |
| dtantsur | sambetts, also returning or not returning 500 is never something to rely on, that's the nature of this error | 09:28 |
| dtantsur | also morning sambetts | 09:28 |
| sambetts | dtantsur: cool, just wanted to make sure after our discussions about the 200 vs 201 codes last week :) | 09:29 |
| sambetts | dtantsur: also morning :) | 09:29 |
| dtantsur | 200 vs 201 is pretty different, cause we change a successful code to one we never returned before | 09:30 |
| *** amotoki has quit IRC | 09:31 | |
| dtantsur | so yeah, people using code == 200 are broken in this case | 09:31 |
| dtantsur | people using code == 400 are not broken in 326891, unless they expect all 500s to be returned as 400s, which is already not the case | 09:31 |
| sambetts | dtantsur: right, :) | 09:32 |
| sambetts | dtantsur: I think its all good then | 09:32 |
| dtantsur | cool | 09:32 |
| sambetts | dtantsur: my concern was that all 500 were being translated to 400s and if someone was relying on that then a. they are being a silly person, b. we would break them | 09:33 |
| sambetts | dtantsur: but if thats not the case then big thumbs up | 09:33 |
| dtantsur | every API can return error 500 at any moment, no matter how hard we try to replace them with 400 :) | 09:34 |
| sambetts | true :-P | 09:34 |
| * sambetts cleaning up the inspector review backlog :-P | 09:35 | |
| dtantsur | :) | 09:36 |
| sambetts | I like inspector changes, they are normally pretty straight forward to review | 09:36 |
| dtantsur | heh, yeah | 09:38 |
| vdrok | morning alineb milan and sambetts | 09:47 |
| openstackgerrit | Zhenguo Niu proposed openstack/ironic-lib: Ignore .idea folder https://review.openstack.org/328928 | 09:47 |
| milan | morning vdrok dtantsur alineb sambetts :) | 09:48 |
| dtantsur | hey milan | 09:48 |
| alineb | o/ vdrok, milan | 09:49 |
| * milan debugging why the heck does his grenade node switch /etc/resolv.conf to name server localhost | 09:49 | |
| milan | could it be dnsmasq package installation that does it? | 09:49 |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic: Remove workaround for nova removing instance_uuid during cleaning https://review.openstack.org/328929 | 09:49 |
| sambetts | milan: if its Ubuntu its always like that as far as I know, and it gets reset to it on reboot too, even if you change it to point at something else | 09:51 |
| milan | sambetts, yeah it's ubuntu | 09:51 |
| dtantsur | I think we even have a documentation on it | 09:51 |
| sambetts | http://www.stgraber.org/2012/02/24/dns-in-ubuntu-12-04/ | 09:51 |
| milan | sambetts, thx, me reads | 09:51 |
| dtantsur | milan, http://docs.openstack.org/developer/ironic-inspector/troubleshooting.html#ubuntu-dns | 09:52 |
| milan | dtantsur, txh | 09:52 |
| openstackgerrit | Aline Bousquet proposed openstack/python-ironicclient: Fix error returned by ironic --json node-validate https://review.openstack.org/303964 | 09:52 |
| sambetts | milan: To turn off dnsmasq in Network Manager, you need to edit /etc/NetworkManager/NetworkManager.conf and comment the “dns=dnsmasq” line (put a # in front of it) then do a “sudo restart network-manager”. | 09:53 |
| sambetts | milan: maybe this would help ^ although on an ubuntu server instance I didn't think it had networkmanager :/ | 09:53 |
| milan | sambetts, yeah, will try that | 09:53 |
| milan | so is it the dnsmasq installation that triggers this resolution to point to localhost? | 09:54 |
| * milan still feels missing some pieces here | 09:54 | |
| milan | aah seems like that indeed (based on dtantsur's hint to docs) | 09:56 |
| milan | btw how comes this oddity is not an issue for my Ironic grenade is a bit of a mystery to me | 09:57 |
| sambetts | milan, dtantsur: this guy is having the same issue: http://www.philandstuff.com/2013/11/07/dnsmasq-resolvconf.html read the Problem sectio | 09:57 |
| sambetts | milan, dtantsur: Apprently its the dnsmasq init.d script that does it | 09:57 |
| milan | ouch :-/ | 09:57 |
| milan | my stack.sh fails because name resolution stops working having installed dnsmasq | 09:58 |
| milan | strange thing, all would have worked if only the dnsmasq service got started | 09:58 |
| * milan reads | 09:58 | |
| sambetts | milan: the way I have around that is to manually overwrite resolve.conf and then stack again | 09:59 |
| milan | I guess that's not an option for grenade :-/ | 09:59 |
| sambetts | milan: hmm yeah :/, I'm trying to work out how to disable it | 10:00 |
| sambetts | Now DNS queries will be resolved first with dnsmasq, only checking external servers if dnsmasq cannot resolve the query. dhcpcd, unfortunately, tends to overwrite /etc/resolv.conf by default, so if you use DHCP it is a good idea to protect /etc/resolv.conf. To do this, append nohook resolv.conf to the dhcpcd config file: | 10:01 |
| sambetts | ... | 10:01 |
| sambetts | nohook resolv.conf | 10:01 |
| sambetts | dtantsur, milan: ^^ | 10:01 |
| openstackgerrit | Vasyl Saienko proposed openstack/ironic: Move create-node.sh to create_vms function https://review.openstack.org/322850 | 10:02 |
| milan | sambetts, interesting | 10:02 |
| sambetts | milan, dtantsur: We could even run: chattr +i /etc/resolv.conf | 10:03 |
| sambetts | which makes that file completely readonly | 10:03 |
| milan | sambetts, dtantsur do you guys feel this should go to inspector's devstack plug-in, in install dnsmasq particularly? | 10:03 |
| dtantsur | probably? | 10:04 |
| sambetts | milan: I think it needs to go in the inspector dnsmasq config file right | 10:04 |
| sambetts | milan: we don't use inspectors dnsmasq for DNS only dhcp so I think disabling that hook should be the default | 10:05 |
| * milan wonders how possible no-one else facing this; feels like a classic between-the-chair-and-the-keyboard issue | 10:05 | |
| sambetts | milan: I have faced it in the past, but I never put much effort into debugging/fixing it | 10:06 |
| milan | but I mean there's the devstack gate running and works OK | 10:06 |
| sambetts | milan: hmm good point, maybe the devstack gate nodes are running dnsmasq for custom DNS for being inside the gate, not sure /me could never work it out :( | 10:08 |
| milan | I wonder how comes I've not seen this with the ironic only grenade | 10:08 |
| milan | cause there's dnsmasq in that setup too, isn't it? | 10:09 |
| sambetts | milan: because we don't install/start dnsmasq? | 10:09 |
| milan | aaaah | 10:09 |
| milan | OK | 10:09 |
| milan | makes sense then | 10:09 |
| milan | btw this my error: http://paste.openstack.org/show/514135/ | 10:09 |
| milan | and of course service dnsmasq start solves it :) | 10:10 |
| * milan considers a pull request for the suggested workaround | 10:10 | |
| sambetts | milan: yeah, thats pretty much what I got, depending on when the resolve hook kicked in it either broken there or when it tried to download things from poypi | 10:10 |
| *** athomas has quit IRC | 10:10 | |
| milan | sambetts, dtantsur I'll try hacking the workaround in here: https://github.com/openstack/ironic-inspector/blob/master/devstack/plugin.sh#L60 as it feels the most appropriate place to do so | 10:12 |
| milan | thanks for help | 10:12 |
| sambetts | milan: +1, I'm interested to know if its installing it, or starting it that breaks everything | 10:14 |
| milan | yeah | 10:14 |
| sambetts | if its starting it, then we just need to fix the configuration file | 10:15 |
| sambetts | if its installing it then thats harder | 10:15 |
| *** athomas has joined #openstack-ironic | 10:17 | |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic-inspector: [WIP] Add manage_boot parameter to introspection API https://review.openstack.org/316801 | 10:19 |
| *** amotoki has joined #openstack-ironic | 10:19 | |
| openstackgerrit | Merged openstack/ironic-inspector: Return HTTP 500 from /v1/continue on unexpected exceptions https://review.openstack.org/326891 | 10:20 |
| openstackgerrit | Merged openstack/ironic-inspector: Update terribly outdated installation instructions https://review.openstack.org/327187 | 10:20 |
| openstackgerrit | Dmitry Tantsur proposed openstack/ironic-inspector: [WIP] Add manage_boot parameter to introspection API https://review.openstack.org/316801 | 10:31 |
| openstackgerrit | Shivanand Tendulker proposed openstack/ironic: Support configdrive in iscsi deploy for whole disk images https://review.openstack.org/225115 | 10:42 |
| vmud213 | dtantsur,rloo: Can you take a quick look at https://review.openstack.org/#/c/303503/.I have uploaded new patch addressing the comments. | 11:00 |
| openstackgerrit | Kyrylo Romanenko proposed openstack/python-ironicclient: Functional tests for portgroups in ironicclient https://review.openstack.org/297727 | 11:19 |
| openstackgerrit | Vladyslav Drok proposed openstack/python-ironicclient: Add create command to ironic client https://review.openstack.org/328955 | 11:19 |
| vsaienko | dtantsur, could you please have look at https://review.openstack.org/#/c/328245/ once have a time. | 11:23 |
| *** ccamacho is now known as ccamacho|lunch | 11:26 | |
| *** baoli has joined #openstack-ironic | 11:47 | |
| *** baoli_ has joined #openstack-ironic | 11:48 | |
| *** amotoki has quit IRC | 11:49 | |
| *** baoli has quit IRC | 11:52 | |
| jroll | morning everyone :) | 11:53 |
| milan | jroll, o/ | 11:57 |
| vsaienko | morning jroll | 11:59 |
| dtantsur | morning jroll | 12:04 |
| *** nico-afk is now known as nicodemos | 12:07 | |
| nicodemos | morning ironic | 12:07 |
| nicodemos | morning jroll | 12:07 |
| jroll | .v 3' | 12:08 |
| jroll | oops | 12:08 |
| *** ipukha has joined #openstack-ironic | 12:11 | |
| *** mtanino has joined #openstack-ironic | 12:11 | |
| *** jjohnson2 has joined #openstack-ironic | 12:11 | |
| *** e0ne has quit IRC | 12:15 | |
| *** e0ne has joined #openstack-ironic | 12:15 | |
| *** amotoki has joined #openstack-ironic | 12:16 | |
| sambetts | Morning vsaienko, nicodemos, jroll | 12:20 |
| TheJulia | Good morning | 12:20 |
| sambetts | o/ TheJulia | 12:20 |
| TheJulia | \o | 12:21 |
| vsaienko | hello sambetts, TheJulia | 12:21 |
| *** zhenguo_ has quit IRC | 12:21 | |
| *** jcoufal has joined #openstack-ironic | 12:32 | |
| *** kalpase has left #openstack-ironic | 12:33 | |
| *** hoangcx has joined #openstack-ironic | 12:34 | |
| openstackgerrit | Merged openstack/bifrost: Add redeploy-dynamic playbook https://review.openstack.org/325379 | 12:35 |
| vdrok | morning jroll and TheJulia ! | 12:37 |
| *** amotoki_ has joined #openstack-ironic | 12:38 | |
| openstackgerrit | Michael Turek proposed openstack/ironic: Allow user to specify a url for Ironic deploy images https://review.openstack.org/263706 | 12:39 |
| *** amotoki has quit IRC | 12:41 | |
| nicodemos | hey sambetts, TheJulia | 12:45 |
| *** hoangcx_ has joined #openstack-ironic | 12:46 | |
| *** caiobo has joined #openstack-ironic | 12:47 | |
| *** amotoki_ has quit IRC | 12:48 | |
| *** e0ne has quit IRC | 12:48 | |
| *** yolanda has quit IRC | 12:49 | |
| *** e0ne has joined #openstack-ironic | 12:49 | |
| *** hoangcx_ has quit IRC | 12:50 | |
| *** ccamacho|lunch is now known as ccamacho | 12:50 | |
| *** hoangcx has quit IRC | 12:51 | |
| *** hoangcx has joined #openstack-ironic | 12:52 | |
| *** caiobo has quit IRC | 12:53 | |
| *** yolanda has joined #openstack-ironic | 12:54 | |
| *** PollyZ has joined #openstack-ironic | 12:54 | |
| openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic: Warn on legacy auth options on conductor start https://review.openstack.org/326660 | 12:56 |
| openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic: Update ironic.conf.sample https://review.openstack.org/326682 | 12:56 |
| openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic: Update devstack plugin with new auth options https://review.openstack.org/297312 | 12:56 |
| openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic: Migrate to using keystoneauth Sessions https://review.openstack.org/236982 | 12:56 |
| sambetts | vdrok: haha we left basically the same comment | 12:58 |
| *** chlong has joined #openstack-ironic | 12:58 | |
| vdrok | sambetts: yep, just saw yours :) | 12:58 |
| *** hoangcx has quit IRC | 13:00 | |
| *** hoangcx has joined #openstack-ironic | 13:01 | |
| *** ccarmack has joined #openstack-ironic | 13:03 | |
| * jroll runs some errands quick | 13:06 | |
| *** lindycoder has joined #openstack-ironic | 13:06 | |
| *** ayoung has joined #openstack-ironic | 13:09 | |
| *** jcoufal has quit IRC | 13:14 | |
| *** mgould has joined #openstack-ironic | 13:15 | |
| NobodyCam | Morning Ironicers | 13:17 |
| sambetts | o/ NobodyCam | 13:17 |
| NobodyCam | o/ sambetts :) | 13:18 |
| xavierr | self.good_morning_ironic() | 13:18 |
| NobodyCam | lol ... morning xavierr | 13:18 |
| *** rloo has joined #openstack-ironic | 13:18 | |
| mgould | morning Ironic | 13:18 |
| TheJulia | good morning NobodyCam rloo | 13:18 |
| rloo | hi mgould, good morning TheJulia, NobodyCam | 13:19 |
| xavierr | morning NobodyCam sambetts vdrok mgould rloo TheJulia | 13:19 |
| NobodyCam | Morning mgould TheJulia rloo :) | 13:19 |
| vdrok | morning NobodyCam xavierr mgould and rloo ! | 13:19 |
| NobodyCam | hey hey vdrok | 13:19 |
| nicodemos | morning xavierr | 13:19 |
| NobodyCam | good morning | 13:19 |
| NobodyCam | morning nicodemos | 13:19 |
| nicodemos | hey NobodyCam | 13:20 |
| nicodemos | o/ | 13:20 |
| NobodyCam | :) | 13:20 |
| dtantsur | morning NobodyCam, xavierr, rloo, TheJulia, mgould | 13:22 |
| rloo | hi xavierr, vdrok, dtantsur, nicodemos and everyone else! :) | 13:23 |
| NobodyCam | morning dtantsur :) | 13:23 |
| *** vmud213 has quit IRC | 13:23 | |
| sambetts | Hi rloo | 13:27 |
| nicodemos | Hi rloo | 13:30 |
| nicodemos | [= | 13:30 |
| rloo | hi sambetts | 13:30 |
| *** jvgrant_ has joined #openstack-ironic | 13:30 | |
| *** caiobo has joined #openstack-ironic | 13:32 | |
| caiobo | good morning ironic :) | 13:34 |
| xavierr | morning caiobo o/ | 13:35 |
| openstackgerrit | Moshe Levi proposed openstack/ironic-python-agent: Add vendor id and vendor name to interface information https://review.openstack.org/279940 | 13:35 |
| openstackgerrit | Moshe Levi proposed openstack/ironic-python-agent: tinyipa: Fix git clone tags when 1.6.5 <= git < 1.7.10 https://review.openstack.org/327825 | 13:35 |
| NobodyCam | morning caiobo | 13:35 |
| caiobo | morning xavierr and NobodyCam o/ | 13:36 |
| NobodyCam | :) | 13:36 |
| *** wajdi has joined #openstack-ironic | 13:37 | |
| *** jcoufal has joined #openstack-ironic | 13:39 | |
| *** wajdi_ has joined #openstack-ironic | 13:39 | |
| *** wajdi has quit IRC | 13:42 | |
| *** thrash|wknd is now known as thrash | 13:45 | |
| vdrok | morning caiobo :) | 13:47 |
| caiobo | morning vdrok :D | 13:48 |
| *** dtantsur is now known as dtantsur|brb | 13:48 | |
| nicodemos | hey caiobo | 13:49 |
| caiobo | hello nicodemos | 13:54 |
| *** links has quit IRC | 13:54 | |
| sambetts | Can anyone remember what the URL structure is for looking at post job logs?? | 13:55 |
| sambetts | jroll: ^ | 13:55 |
| *** ppiela has joined #openstack-ironic | 14:00 | |
| *** jjohnson2_ has joined #openstack-ironic | 14:00 | |
| *** ElCoyote_ has quit IRC | 14:00 | |
| *** SiRiuS__ has quit IRC | 14:03 | |
| *** SiRiuS__ has joined #openstack-ironic | 14:04 | |
| *** lindycoder has quit IRC | 14:04 | |
| *** jjohnson2 has quit IRC | 14:04 | |
| *** e0ne has quit IRC | 14:04 | |
| *** ElCoyote_ has joined #openstack-ironic | 14:05 | |
| *** r-daneel has joined #openstack-ironic | 14:05 | |
| *** e0ne has joined #openstack-ironic | 14:05 | |
| *** ishant is now known as ishant|away | 14:08 | |
| *** krtaylor has quit IRC | 14:09 | |
| *** PollyZ has quit IRC | 14:11 | |
| NobodyCam | anyone have a quick minute to review: https://review.openstack.org/#/c/272658/ :) | 14:12 |
| *** jjohnson2_ has quit IRC | 14:16 | |
| *** PollyZ has joined #openstack-ironic | 14:16 | |
| *** Goneri has joined #openstack-ironic | 14:21 | |
| *** Goneri has quit IRC | 14:21 | |
| *** vishwanathj has quit IRC | 14:22 | |
| *** yolanda has quit IRC | 14:23 | |
| *** yolanda has joined #openstack-ironic | 14:27 | |
| openstackgerrit | Kyrylo Romanenko proposed openstack/python-ironicclient: Add tests for openstackclient plugin https://review.openstack.org/301687 | 14:28 |
| *** vishwanathj has joined #openstack-ironic | 14:30 | |
| *** snizar_ has joined #openstack-ironic | 14:31 | |
| *** snizar has joined #openstack-ironic | 14:31 | |
| *** ChrisAusten has quit IRC | 14:31 | |
| *** snizar has quit IRC | 14:32 | |
| *** snizar_ has quit IRC | 14:32 | |
| caiobo | Done NobodyCam, I was already looking it and I could not find anything to point it out, lgtm :) | 14:36 |
| *** vishwanathj has quit IRC | 14:36 | |
| *** itamarl has quit IRC | 14:37 | |
| jroll | sambetts: I doc'd it here last time someone asked this http://docs.openstack.org/infra/manual/developers.html#automated-testing | 14:38 |
| * jroll down with tribal knowledge | 14:38 | |
| *** spandhe has joined #openstack-ironic | 14:38 | |
| milan | sambetts, having spent couple of hours staring into my stack.sh logs, the culprit for the dnsmasq down is here: https://github.com/openstack-dev/devstack/blob/master/stack.sh#L1107 stack.sh doesn't finish post-config steps of the plugins of the old/base env :-/ | 14:39 |
| NobodyCam | caiobo: awesome Thank you :) | 14:40 |
| NobodyCam | morning jroll and milan | 14:40 |
| milan | morning NobodyCam :) | 14:40 |
| caiobo | NobodyCam: np | 14:40 |
| NobodyCam | :) | 14:40 |
| *** sabeen has joined #openstack-ironic | 14:41 | |
| jroll | hey NobodyCam :) | 14:42 |
| mgould | morning NobodyCam | 14:42 |
| natorious | morning | 14:43 |
| milan | sambetts, seems a workaround for Ubuntu might be to install NetworkManager together with dnsmasq for the inspector, wdyt? | 14:43 |
| * milan unsure | 14:43 | |
| milan | hey mgould natorious :) | 14:43 |
| milan | actually, dtantsur|brb too ^ ;) | 14:44 |
| mgould | hi milan | 14:46 |
| * milan hates when packagers predestine a generic service configuration to a single purpose, promoting single use case | 14:47 | |
| NobodyCam | morning natorious | 14:47 |
| natorious | :) | 14:47 |
| *** Goneri has joined #openstack-ironic | 14:47 | |
| *** sacharya has joined #openstack-ironic | 14:47 | |
| *** amotoki has joined #openstack-ironic | 14:51 | |
| openstackgerrit | Thiago Paiva Brito proposed openstack/ironic: [WIP] Using Oneview drivers w/ IRONIC_IS_HARDWARE https://review.openstack.org/328451 | 14:52 |
| openstackgerrit | Vladyslav Drok proposed openstack/python-ironicclient: Add create command to ironic client https://review.openstack.org/328955 | 14:52 |
| milan | sambetts, actually, never mind me, it's between the chair and the keyboard :D I need to explicitly disable n-net q-dhcp in my gate script | 14:53 |
| NobodyCam | I see a couple nits on 272658 I can toss up a follow up.. as I don't want to loose the positive votes it has? | 14:53 |
| TheJulia | NobodyCam: personally I'm okay with that, I know some others typically are not okay with doing that until after the revision has landed :\ | 14:56 |
| NobodyCam | I can wait :) | 14:57 |
| rloo | NobodyCam, TheJulia: I haven't looked, but if the people indicated they are nits, then that shouldn't hold up the patch. | 14:57 |
| TheJulia | NobodyCam: I was going to say, just post your nits and we can go from there | 14:57 |
| NobodyCam | rloo: ya couple of type-ohs | 14:58 |
| rloo | NobodyCam: unless it is in a config or something 'important', those seem to be nits to me :) | 14:59 |
| *** jaybeale has joined #openstack-ironic | 14:59 | |
| *** rbartal has quit IRC | 14:59 | |
| sambetts | milan: disable q-dhcp ? Doesn't that break Ironic? | 15:01 |
| milan | sambetts, yeah, I've just realised the same :-/ | 15:01 |
| sambetts | milan: definately you need n-net disabled though | 15:01 |
| *** lindycoder has joined #openstack-ironic | 15:02 | |
| *** jvgrant_ has quit IRC | 15:06 | |
| *** jvgrant_ has joined #openstack-ironic | 15:06 | |
| milan | sambetts, it has to be an installation-time workaround then for ubuntu | 15:08 |
| milan | or d | 15:08 |
| milan | fix the stack.sh | 15:09 |
| *** ChrisAusten has joined #openstack-ironic | 15:09 | |
| sambetts | milan: did you try setting the line to disable the hook in the config file? | 15:09 |
| *** xavierr is now known as xavierr_afk | 15:11 | |
| *** fragatina has joined #openstack-ironic | 15:11 | |
| JayF | lucas-afk: dtantsur|brb: curious if my email to the list re: hardware managers was enlightening | 15:13 |
| *** piet has joined #openstack-ironic | 15:14 | |
| *** jjohnson2_ has joined #openstack-ironic | 15:15 | |
| *** krtaylor has joined #openstack-ironic | 15:17 | |
| milan | sambetts, not yet, will do | 15:18 |
| *** dtantsur|brb is now known as dtantsur | 15:21 | |
| jlvillal | sambetts: In https://review.openstack.org/277853 (VLAN Aware Bare-Metal) Is there a way to mark particular network as native vlan for a specific tenant / instance? | 15:21 |
| jlvillal | sambetts: A question from a colleague of mine | 15:21 |
| dtantsur | JayF, didn't have a chance to get to it yet, sorry | 15:22 |
| dtantsur | also morning jlvillal, JayF, natorious | 15:22 |
| *** lennyb has quit IRC | 15:22 | |
| jlvillal | Good morning dtantsur milan JayF sambetts rloo NobodyCam TheJulia natorious jroll vdrok vsaienko and anyone I missed. | 15:23 |
| JayF | gm | 15:23 |
| TheJulia | good morning jlvillal | 15:23 |
| milan | jlvillal, morning :) | 15:23 |
| vsaienko | good morning jlvillal | 15:23 |
| NobodyCam | morning jlvillal | 15:23 |
| jlvillal | :) | 15:23 |
| * dtantsur reads the said email | 15:24 | |
| sambetts | jlvillal: if you create the neutron trunk yourself via neutron and then pass that into nova then you can have that level of controller over it, but just doing net/port ids on nova boot they are just processed in order as far as I can tell, so therefore the first one will become the native, for the first nic, but after that it depends on how many nics your BM has, e.g. if it has 4 nics then 4 of | 15:25 |
| sambetts | the networks you've requested will become native VLANs etc | 15:25 |
| dtantsur | JayF, I don't think I understand why people should not inherit GenericHardwareManager if they share most of the code with it.. | 15:25 |
| jlvillal | sambetts: Thanks! | 15:25 |
| openstackgerrit | Kyrylo Romanenko proposed openstack/python-ironicclient: Add test for ironic node-list command https://review.openstack.org/329056 | 15:25 |
| JayF | dtantsur: I just personally couldn't think of any examples where subclassing GHM is better than making a new hwm, unless you also removed the entrypoint for the ghm | 15:26 |
| JayF | dtantsur: I was trying real hard to think of an example case for a monolithic hardware manager, and every case I came up with, it was easier to do with a smaller manager | 15:26 |
| *** rama_y has joined #openstack-ironic | 15:27 | |
| *** jjohnson2_ has quit IRC | 15:27 | |
| vdrok | morning JayF and jlvillal | 15:27 |
| *** spandhe_ has joined #openstack-ironic | 15:27 | |
| JayF | gm | 15:27 |
| *** mtanino has quit IRC | 15:28 | |
| dtantsur | JayF, maybe I'm making things up, but what about the same logic as GHM, but with different initialization? or, for example, slightly different code to detect hard drives (e.g. accounting for a super enterprise RAID controller) | 15:28 |
| *** spandhe has quit IRC | 15:28 | |
| *** spandhe_ is now known as spandhe | 15:28 | |
| sambetts | dtantsur: I love that when we use the word enterprise we really mean slow and badly written drivers | 15:29 |
| JayF | dtantsur: I'd add a single hardware manager that implemented evaluate_hardware_support() and get_os_install_device() | 15:29 |
| dtantsur | sambetts, I didn't say that :) at least not this time | 15:29 |
| JayF | dtantsur: one thing I did see, that we probably want to change but would be an API break | 15:29 |
| JayF | dtantsur: we don't dispatch to managers any of the inventory stuff | 15:29 |
| JayF | dtantsur: so one of my "monolithic manager use cases" was going to be expanding the inventory, but today in the code you can't do thjat | 15:29 |
| dtantsur | JayF, you mean, calls inside list_hardware_info? true | 15:30 |
| *** garthb has joined #openstack-ironic | 15:30 | |
| dtantsur | but yeah, if you need to extend inventory right now, you have to copy-paste or inherit all existing methods (if they more or less match) | 15:31 |
| dtantsur | JayF, otherwise great examples, thanks | 15:31 |
| JayF | you can't do any of that actually | 15:31 |
| JayF | that's what I'm saying | 15:31 |
| sambetts | JayF, dtantsur: this goes back to mine and dtantsur our conversations about having an enabled_hw_managers:generic,... if hw managers could change the inventory like that then we could replace collectors with hw managers | 15:31 |
| JayF | even list_hardware_info() doesn't go through dispatch_to_managers | 15:32 |
| dtantsur | wut?? | 15:32 |
| dtantsur | well, for inspection it does | 15:32 |
| JayF | yeah, stuff I discovered on Friday when doing these examples | 15:32 |
| JayF | we should change it, but it would change behavior for existing downstream hardware managers | 15:32 |
| JayF | I think it likely changes it to expected behavior | 15:32 |
| dtantsur | if you mean this: https://github.com/openstack/ironic-python-agent/blob/master/ironic_python_agent/inspector.py#L290 | 15:32 |
| JayF | whereas now the behavior is a little wtf | 15:33 |
| JayF | oh yep list_hardware_info is dispatched to inth eagent as well | 15:33 |
| JayF | just not the methods inside it | 15:33 |
| JayF | we should change all the methods inside it to be dispatched out | 15:33 |
| JayF | just like erase_block_devices() does | 15:34 |
| *** moshele has quit IRC | 15:34 | |
| *** harlowja_at_home has joined #openstack-ironic | 15:35 | |
| *** moshele has joined #openstack-ironic | 15:36 | |
| *** moshele has quit IRC | 15:38 | |
| *** tesseract has quit IRC | 15:39 | |
| *** hshiina has joined #openstack-ironic | 15:39 | |
| *** jjohnson2_ has joined #openstack-ironic | 15:41 | |
| openstackgerrit | Merged openstack/ironic: Add restrictions for changing portgroup-node association https://review.openstack.org/281169 | 15:43 |
| *** gmmaha has quit IRC | 15:44 | |
| dtantsur | JayF, +1 | 15:45 |
| dtantsur | I guess it's not too hard or breaking, so maybe we can Just Do It.. | 15:45 |
| *** gmmaha has joined #openstack-ironic | 15:45 | |
| milan | sambetts, http://paste.openstack.org/show/515757/ so setting the nohook in dhclient.conf doesn't prevent the dnsmasq tampering :-/ | 15:46 |
| *** gmmaha has quit IRC | 15:46 | |
| dtantsur | milan, can't you use fedora for greater good? :) | 15:46 |
| sambetts | dtantsur: not in the gate :/ | 15:47 |
| milan | dtantsur, it's for the gate ;) | 15:47 |
| dtantsur | sambetts, milan, well, the gate somehow works already | 15:47 |
| openstackgerrit | Bharath kumar proposed openstack/ironic: adding back the inspect_ports as an optional parameter https://review.openstack.org/325230 | 15:47 |
| *** gmmaha has joined #openstack-ironic | 15:47 | |
| *** ChrisAusten has quit IRC | 15:47 | |
| dtantsur | is it so different with grenade? | 15:47 |
| *** causten_ has joined #openstack-ironic | 15:47 | |
| milan | dtantsur, that's why I feel the whole day I'm missing something | 15:47 |
| milan | dtantsur, do you know by chance the gate applies some workaround for name resolution? | 15:48 |
| dtantsur | milan, I don't think we have network manager in gate... | 15:48 |
| milan | dtantsur, as soon as one installs dnsmasq on ubuntu, ubuntu sets resolve.conf to localhost | 15:49 |
| milan | they call it a feature | 15:49 |
| milan | #pixiesay feature! -m dead | 15:49 |
| PixieBoots | ʕxᴥxʔ: feature! | 15:49 |
| sambetts | milan: run "chattr +i /etc/resolv.conf" before installing dnsmasq | 15:49 |
| dtantsur | milan, worth asking on #openstack-infra | 15:49 |
| milan | dtantsur, yeah | 15:50 |
| milan | seems like that | 15:50 |
| milan | sambetts, +1 going to try | 15:50 |
| openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic: Warn on legacy auth options on conductor start https://review.openstack.org/326660 | 15:50 |
| openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic: Update ironic.conf.sample https://review.openstack.org/326682 | 15:50 |
| openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic: Update devstack plugin with new auth options https://review.openstack.org/297312 | 15:50 |
| openstackgerrit | Pavlo Shchelokovskyy proposed openstack/ironic: Migrate to using keystoneauth Sessions https://review.openstack.org/236982 | 15:50 |
| sambetts | milan: it'll make resolv.conf untouchable by anyone even root ;-P | 15:50 |
| * milan ansibles this, give him 5min ;) | 15:50 | |
| *** dmk0202 has quit IRC | 15:51 | |
| *** piet has quit IRC | 15:52 | |
| openstackgerrit | Kyrylo Romanenko proposed openstack/python-ironicclient: Add test for ironic port-list command https://review.openstack.org/329068 | 15:52 |
| *** piet has joined #openstack-ironic | 15:52 | |
| *** bcornec1 has joined #openstack-ironic | 15:53 | |
| *** Sukhdev has joined #openstack-ironic | 15:54 | |
| *** sacharya_ has joined #openstack-ironic | 15:55 | |
| dtantsur | rloo, re RFE about --wait: I've put up a patch https://review.openstack.org/328191 maybe it's a bit clearer than my English :) | 15:56 |
| *** derekh has quit IRC | 15:56 | |
| devananda | morning, all | 15:56 |
| sambetts | o/ devananda | 15:57 |
| dtantsur | morning devananda | 15:57 |
| JayF | dtantsur: oslo has a nifty thing just for exactly that | 15:58 |
| *** sacharya has quit IRC | 15:58 | |
| JayF | dtantsur: oslo.service loopingcall | 15:58 |
| JayF | dtantsur: IDK if it's suitable for a client though, now that I see it's in oslo.service | 15:59 |
| *** rcernin has quit IRC | 15:59 | |
| dtantsur | JayF, to be honest, I've never found the loopingcall thing easier to read or write than a plain loop, but maybe it's only me.. | 15:59 |
| JayF | dtantsur: we use it in a couple of places in our downstream managers, so I'm familiar with it somewhat. Just didn't know if you kn=ew it existed | 16:00 |
| dtantsur | thnx | 16:00 |
| dtantsur | maybe I should look into it, but yeah, I don't think we need to start depending on oslo.service | 16:01 |
| *** aarefiev_ has quit IRC | 16:01 | |
| JayF | I mean, no value judgements one way or the other | 16:02 |
| JayF | I just know it exists and works :) | 16:02 |
| jroll | I find the loopingcall classes nice when you need more than just while: sleep(x) | 16:04 |
| *** ayoung has quit IRC | 16:04 | |
| jroll | like exponential backoff, jitter, etc | 16:04 |
| *** lindycoder has quit IRC | 16:04 | |
| dtantsur | true | 16:04 |
| rloo | dtantsur: ok, so it is a 'set and wait' function | 16:06 |
| dtantsur | sorry, what do you mean by "set and wait"? | 16:06 |
| *** jvgrant_ has quit IRC | 16:10 | |
| rloo | dtantsur: i mean, i didn't understand if your proposed ironic API was *only* wait-til-node-reaches-this-state, or set-and-wait-til-node-reaches-state | 16:10 |
| dtantsur | rloo, got it. this is not an API, just a client helper, and it's only wait. | 16:11 |
| *** electrofelix has quit IRC | 16:11 | |
| rloo | dtantsur: guess i'm confused. it isn't just a client helper, it is in the api, isn't it? | 16:12 |
| rloo | dtantsur: in the client api. | 16:12 |
| dtantsur | rloo, right, but you said ironic API. we're not adding it to HTTP API. | 16:13 |
| rloo | dtantsur: sorry, i missed it. ok, it is just wait, you are calling set first, then wait. | 16:13 |
| *** mtanino has joined #openstack-ironic | 16:13 | |
| dtantsur | rloo, yeah, it's up for a caller to call set | 16:13 |
| *** spandhe has quit IRC | 16:15 | |
| *** ayoung has joined #openstack-ironic | 16:19 | |
| rloo | dtantsur: ok, I'm good with the RFE! | 16:19 |
| dtantsur | thanks | 16:20 |
| *** PollyZ_ has joined #openstack-ironic | 16:28 | |
| *** e0ne has quit IRC | 16:29 | |
| *** moshele has joined #openstack-ironic | 16:30 | |
| *** PollyZ has quit IRC | 16:30 | |
| *** rcernin has joined #openstack-ironic | 16:31 | |
| *** PollyZ has joined #openstack-ironic | 16:33 | |
| *** PollyZ_ has quit IRC | 16:34 | |
| *** rcernin has quit IRC | 16:35 | |
| *** trown is now known as trown|lunch | 16:35 | |
| milan | dtantsur, sambetts so infra installs another local resolver pointing at google to workaround possibly broken cloud dns so even with the ubuntu's feature and an killall dnsmasq the ubound thing will keep resolving :-/ | 16:36 |
| *** rcernin has joined #openstack-ironic | 16:36 | |
| dtantsur | milan, so the gate is fine, but your local machine is not, right? | 16:36 |
| milan | dtantsur, ack, the gate is fine by a crude hack :D | 16:36 |
| milan | yet another resolver | 16:37 |
| *** bcornec1 has quit IRC | 16:37 | |
| milan | dtantsur, I can of course apply the same trick | 16:37 |
| milan | but it feels odd | 16:37 |
| *** lindycoder has joined #openstack-ironic | 16:38 | |
| dtantsur | #pixiesay Ubuntu.. -m meh | 16:38 |
| PixieBoots | ¯\_(ツ)_/¯: Ubuntu.. | 16:38 |
| *** pcaruana has quit IRC | 16:38 | |
| milan | sure :D | 16:38 |
| * milan hacks workarounds | 16:39 | |
| *** bcornec1 has joined #openstack-ironic | 16:39 | |
| *** athomas has quit IRC | 16:43 | |
| *** jaybeale has quit IRC | 16:46 | |
| *** rpioso has joined #openstack-ironic | 16:54 | |
| *** early has quit IRC | 16:54 | |
| *** Romanenko_K has quit IRC | 16:57 | |
| *** kromanenko_ has quit IRC | 16:57 | |
| *** kromanenko__ has quit IRC | 16:58 | |
| openstackgerrit | sean mooney proposed openstack/bifrost: split ironic install role into install,bootstrap,start phases https://review.openstack.org/318423 | 16:58 |
| *** harlowja_at_home has quit IRC | 16:59 | |
| *** moshele has quit IRC | 16:59 | |
| JayF | meeting in #openstack-meeting-3 in 1m jfyi | 17:00 |
| *** ayoung has quit IRC | 17:04 | |
| *** fragatina has quit IRC | 17:06 | |
| *** xavierr_afk is now known as xavierr | 17:06 | |
| *** fragatina has joined #openstack-ironic | 17:06 | |
| *** wajdi_ is now known as wajdi | 17:07 | |
| *** jxiaobin has joined #openstack-ironic | 17:07 | |
| *** ifarkas has quit IRC | 17:09 | |
| *** PollyZ has quit IRC | 17:10 | |
| *** sacharya has joined #openstack-ironic | 17:13 | |
| *** sacharya_ has quit IRC | 17:13 | |
| *** PollyZ has joined #openstack-ironic | 17:14 | |
| *** sacharya_ has joined #openstack-ironic | 17:16 | |
| *** PollyZ has quit IRC | 17:16 | |
| *** thiagop has joined #openstack-ironic | 17:17 | |
| *** ayoung has joined #openstack-ironic | 17:17 | |
| *** sacharya has quit IRC | 17:19 | |
| *** PollyZ has joined #openstack-ironic | 17:31 | |
| JayF | I didn't want to derail the meeting with this; but is there a reason we run a nonvoting postgres job? If the job is important, it should vote, if not, we shouldn't run it .... right? | 17:31 |
| *** clenimar has joined #openstack-ironic | 17:31 | |
| *** PollyZ has quit IRC | 17:36 | |
| *** ohamada has quit IRC | 17:38 | |
| *** pcaruana has joined #openstack-ironic | 17:39 | |
| jroll | JayF: we've had other projects (neutron) break that job quite a bit | 17:40 |
| jroll | and then fix it | 17:40 |
| jroll | so, look at it on db-heavy patches? | 17:40 |
| JayF | so we do care about postgres, then? | 17:40 |
| jroll | devananda: JayF: also, I feels like ELK only indexes gate checks, not queue | 17:40 |
| jroll | yes, or so we say | 17:40 |
| JayF | well the 'or so we say' is more what I was worried about | 17:40 |
| jroll | I mean, I can't speak for everyone | 17:41 |
| jroll | but historically we've decided we care | 17:41 |
| NobodyCam | good meeting .. thank you all | 17:41 |
| JayF | I just thought, like, philosophically -nv jobs are supposed to be transatory | 17:41 |
| JayF | otherwise we can just break them indefinately | 17:41 |
| dtantsur | well, I'd say we should watch -nv jobs | 17:42 |
| dtantsur | but not on every kind of a patch they has to be rechecked | 17:42 |
| devananda | JayF: -nv jobs can be something we're working through and collecting data, or something that other projects control, which we want to monitor, but not wholly depend on | 17:42 |
| devananda | JayF: eg, the way we have an -nv job on nova | 17:42 |
| dtantsur | like, I'd appreciate if people don't ignore the inspector job on critical patches :) | 17:42 |
| * sambetts -> home | 17:42 | |
| dtantsur | sambetts, o/ | 17:42 |
| JayF | dtantsur: I was going to ask you why that wasn't voting :) | 17:42 |
| devananda | sambetts: ciao! | 17:42 |
| *** sambetts is now known as sambetts|afk | 17:42 | |
| sambetts|afk | Night all o/ | 17:42 |
| dtantsur | JayF, well, we have little chances of breaking it, but the job itself suffers from the same transient problems as the main ironic job | 17:44 |
| JayF | Do we have as much of a transient failures problem with tinyipa+ipxe? | 17:44 |
| JayF | afaict our jobs have been way more reliable lately | 17:44 |
| JayF | When I get to the bottom of my todo list, going to make a useful graphite dashboard so I can prove ^ things like that | 17:45 |
| *** mtanino has quit IRC | 17:47 | |
| devananda | JayF: +1 | 17:49 |
| devananda | JayF: also, how do you ever get to the bottom of your todo list? | 17:49 |
| devananda | mine just keeps growing | 17:49 |
| JayF | that's the point | 17:49 |
| JayF | :) | 17:49 |
| *** piet has quit IRC | 17:49 | |
| *** clenimar has quit IRC | 17:49 | |
| sambetts|afk | JayF: in case you didn't know http://status.openstack.org/openstack-health/#/?searchProject=ironic | 17:49 |
| JayF | that's exactly what I wanted | 17:51 |
| JayF | thanks! | 17:51 |
| *** mgould is now known as mgould|afk | 17:52 | |
| *** early has joined #openstack-ironic | 17:52 | |
| *** Sukhdev has quit IRC | 17:52 | |
| *** Sukhdev has joined #openstack-ironic | 17:52 | |
| *** Sukhdev has quit IRC | 17:52 | |
| *** fragatina has quit IRC | 17:53 | |
| rloo | jroll: forgot to ask. next week is midcycle, so no weekly meeting, right? | 17:54 |
| jroll | rloo: ah, yeah | 17:54 |
| jroll | I'll send a reminder this week | 17:54 |
| rloo | jroll: thx. | 17:54 |
| *** mbound has joined #openstack-ironic | 17:55 | |
| *** PollyZ has joined #openstack-ironic | 17:55 | |
| jroll | np | 17:55 |
| *** ijw has joined #openstack-ironic | 17:56 | |
| *** hshiina has quit IRC | 17:56 | |
| *** ijw has quit IRC | 17:57 | |
| *** ijw has joined #openstack-ironic | 17:57 | |
| *** rbudden has joined #openstack-ironic | 17:57 | |
| *** fragatina has joined #openstack-ironic | 18:00 | |
| *** trown|lunch is now known as trown | 18:01 | |
| *** mtanino has joined #openstack-ironic | 18:05 | |
| *** fragatina has quit IRC | 18:06 | |
| openstackgerrit | Vladyslav Drok proposed openstack/python-ironicclient: Add create command to ironic client https://review.openstack.org/328955 | 18:07 |
| thiagop | JayF: https://review.openstack.org/#/c/329132/ | 18:07 |
| jroll | ... we don't use cinder yet either, right? | 18:09 |
| openstackgerrit | Vladyslav Drok proposed openstack/python-ironicclient: Add create command to ironic client https://review.openstack.org/328955 | 18:09 |
| thiagop | jroll: according to this features file, no | 18:10 |
| thiagop | jroll: but it can be overwritten on the job using OVERRIDE_ENABLED_SERVICES | 18:11 |
| dtantsur | see you tomorrow | 18:11 |
| *** dtantsur is now known as dtantsur|afk | 18:11 | |
| thiagop | see ya dtantsur|afk | 18:11 |
| vdrok | good night dtantsur|afk | 18:11 |
| jroll | thiagop: I'd say we could drop it, will speed things up a tad | 18:12 |
| vdrok | jroll: could you add me to the trello board? my handle there is drokvlad | 18:12 |
| thiagop | jroll: sorry, drop what exactly? | 18:12 |
| jroll | thiagop: drop cinder from that file? | 18:14 |
| jroll | vdrok: done | 18:14 |
| vdrok | thx! | 18:14 |
| * vdrok leaves too | 18:15 | |
| thiagop | jroll: not sure I understood your point, but the option I changed is to remove the service. | 18:15 |
| thiagop | jroll: cinder is already there | 18:15 |
| vdrok | good night everyone! | 18:16 |
| jroll | thiagop: OH | 18:16 |
| thiagop | night vdrok | 18:16 |
| jroll | it makes sense now | 18:16 |
| * jroll had it backwards | 18:16 | |
| jroll | thanks | 18:16 |
| *** clenimar has joined #openstack-ironic | 18:16 | |
| thiagop | jroll: np :) | 18:16 |
| * jroll +1 | 18:16 | |
| thiagop | jroll: thanks. I hope that the gates won't become crazy with this one... | 18:18 |
| jroll | :) | 18:19 |
| * jroll steps away for a bit | 18:19 | |
| *** mbound has quit IRC | 18:19 | |
| NobodyCam | night vdrok | 18:20 |
| *** mbound has joined #openstack-ironic | 18:22 | |
| *** sdake_ has joined #openstack-ironic | 18:23 | |
| rloo | jlvillal: question about grenade work. Do we still want that big 'grenade whiteboard' link in our etherpad? | 18:25 |
| *** mbound has quit IRC | 18:25 | |
| jlvillal | rloo: I'm leaning towards no. Especially big | 18:25 |
| *** mbound has joined #openstack-ironic | 18:26 | |
| rloo | jlvillal: ok. i'm going to remove it. | 18:26 |
| jlvillal | Thanks | 18:26 |
| *** thiagop has left #openstack-ironic | 18:26 | |
| rloo | jlvillal: other question. the trello card for grenade work doesn't mention grenade partial job. | 18:26 |
| *** thiagop has joined #openstack-ironic | 18:26 | |
| rloo | jlvillal: or if it does, the card has been moved to 'done'. | 18:27 |
| jlvillal | rloo: Oh yeah. I need to add that. Or create one. | 18:27 |
| rloo | jlvillal: maybe create another card then. is that a high priority too? | 18:27 |
| jlvillal | rloo: I believe so. I'm not sure it is blocking other things. But I think it is a high priority | 18:27 |
| rloo | jlvillal: ok | 18:28 |
| jroll | rloo: I've filed 'grenade partial' under 'rolling upgrades' in my mind | 18:29 |
| jroll | that's how we plan to test it | 18:29 |
| jlvillal | rloo: jroll: I created a card in the ToDo section. | 18:29 |
| jroll | ok | 18:29 |
| rloo | jlvillal: so you can get the hooks in to do it, but that grenade test will continue to fail until rolling upgrades works? | 18:29 |
| jlvillal | rloo: No. The test is currently working. It needs to be modified somewhat. | 18:30 |
| jlvillal | rloo: Currently it upgrades both Ironic API and Ironic Conductor. | 18:30 |
| rloo | jlvillal: does the current grenade test non-rolling upgrades? | 18:30 |
| rloo | jlvillal: i mean, stop api/conductor; do migrations or whatever, start new api/conductor. | 18:31 |
| jlvillal | rloo: We want the partial job to only upgrade Conductor | 18:31 |
| jlvillal | rloo: Current job is a cold upgrade of everything | 18:31 |
| jlvillal | rloo: Partial will be a cold upgrade, but only of Conductor. | 18:31 |
| jlvillal | rloo: Is the plan | 18:31 |
| rloo | jlvillal: ok; so ironic can now apply to get tagged with cold upgrade? | 18:31 |
| rloo | jlvillal: oh, sorry, only after you make changes to do cold upgrade with only conductor? | 18:32 |
| jlvillal | rloo: Well soon, once it becomes a voting job. If there is a "cold upgrade" tag. | 18:32 |
| rloo | jlvillal: there is. sec, let me find it... | 18:32 |
| * jlvillal is unsure about that | 18:32 | |
| rloo | jlvillal: https://governance.openstack.org/reference/tags/assert_supports-upgrade.html | 18:33 |
| rloo | jlvillal: they don't use 'cold' there :) | 18:33 |
| rloo | jlvillal: oh, wait, i see 'cold'. | 18:33 |
| jlvillal | rloo: yes I saw cold | 18:33 |
| jlvillal | rloo: So yes. I think once Grenade becomes a voting job, we could apply for that tag. I would think. | 18:34 |
| rloo | jroll: ^^ ? | 18:34 |
| rloo | jlvillal: so the grenade partial job isn't needed to show that cold upgrades work? | 18:34 |
| jlvillal | rloo: No. That is for getting us to rolling/live upgrades | 18:35 |
| rloo | jlvillal: ok. | 18:35 |
| rloo | jlvillal: what exactly do you mean by upgrading only conductors then? | 18:36 |
| jlvillal | rloo: So for the 'partial' Grenade job. We only want to upgrade Ironic conductor | 18:36 |
| rloo | jlvillal: and for the api -- keep running the (older) api? | 18:36 |
| jlvillal | Make sure that an old version of everything else will work, if we upgrade the Conductor | 18:37 |
| jlvillal | rloo: Yes | 18:37 |
| jlvillal | rloo: Current 'partial' job upgrades both Conductor and API. | 18:37 |
| rloo | what about after upgrading the conductor; will we then upgrade the API? | 18:37 |
| rloo | cuz if we don't, then we're only testing part of the rolling upgrades | 18:37 |
| rloo | jlvillal: will there be two api and two conductors running? | 18:38 |
| jlvillal | rloo: No, we only do the conductor. That is the current plan. Not sure what we need to do, to also do API. | 18:38 |
| jlvillal | rloo: I think only one of each. | 18:38 |
| *** hecliunyx has quit IRC | 18:39 | |
| rloo | jlvillal: ok. will need to remember this, cuz it won't fully test the rolling upgrades. | 18:39 |
| *** fragatina has joined #openstack-ironic | 18:39 | |
| *** cdearborn has joined #openstack-ironic | 18:44 | |
| *** cdearborn has quit IRC | 18:45 | |
| *** cdearborn has joined #openstack-ironic | 18:45 | |
| rloo | JayF: are you the contact/point person for rescue mode? https://trello.com/c/PwH1pexJ/23-rescue-mode | 18:51 |
| rloo | jlvillal: if we combine grenade-partial with rolling upgrades, should I delete the "Upgrade (aka Grenade) testing" subteam? I've added a subteam for rolling upgrades etc. | 18:52 |
| jlvillal | rloo: That works for me. | 18:52 |
| rloo | jlvillal: ok, done. | 18:52 |
| jlvillal | rloo: Thanks for keeping things organized! :) | 18:53 |
| rloo | jlvillal: yw! | 18:53 |
| jroll | rloo: yes, voting grenade job allows us to assert supports-upgrade | 18:54 |
| JayF | rloo: yes; but I'm almost constantly blocked on reviews there | 18:54 |
| * JayF has had a spec up that hasn't had any reviews recently other than from jroll | 18:54 | |
| rloo | jroll: awesome. I assume you'll do the needful :) | 18:54 |
| jroll | rloo: indeed! | 18:54 |
| rloo | JayF: oh, I don't care about that. Just want to know who the contact person is :) | 18:55 |
| rloo | JayF: just answer their questions so you aren't blocked :) | 18:55 |
| *** bcornec1 has quit IRC | 18:55 | |
| *** jcoufal_ has joined #openstack-ironic | 18:56 | |
| JayF | ...answer whose questions? | 18:56 |
| rloo | JayF: Oh, sorry, i didn't read it. you're blocked cuz you aren't getting reviews. i initially thought it was blocked *due* to the reviews. | 18:58 |
| JayF | exactly | 18:58 |
| *** jcoufal has quit IRC | 18:59 | |
| *** bcornec1 has joined #openstack-ironic | 19:08 | |
| *** rama_y has quit IRC | 19:10 | |
| *** e0ne has joined #openstack-ironic | 19:11 | |
| *** bcornec1 has quit IRC | 19:15 | |
| *** bcornec1 has joined #openstack-ironic | 19:16 | |
| *** joprovost has joined #openstack-ironic | 19:17 | |
| *** PollyZ has quit IRC | 19:22 | |
| *** baoli_ has quit IRC | 19:22 | |
| *** PollyZ has joined #openstack-ironic | 19:28 | |
| *** joprovost has quit IRC | 19:29 | |
| *** bcornec1 has quit IRC | 19:30 | |
| *** MattMan has quit IRC | 19:32 | |
| *** MattMan has joined #openstack-ironic | 19:32 | |
| *** joprovost has joined #openstack-ironic | 19:32 | |
| *** PollyZ has quit IRC | 19:33 | |
| NobodyCam | hum: No meeting on June 13 since the midcycle is happening that day/week. June 20th ??? | 19:35 |
| * NobodyCam edits | 19:35 | |
| *** Sukhdev has joined #openstack-ironic | 19:36 | |
| jroll | NobodyCam: today is june 13 already :) | 19:40 |
| jroll | but yeah, no meeting on the 20th, 27th will be next | 19:40 |
| *** PollyZ has joined #openstack-ironic | 19:41 | |
| NobodyCam | yep | 19:42 |
| *** baoli has joined #openstack-ironic | 19:42 | |
| NobodyCam | lol I changes to the 20th | 19:42 |
| *** baoli has quit IRC | 19:43 | |
| *** baoli has joined #openstack-ironic | 19:43 | |
| rloo | NobodyCam: ? didn't I already change it to 27th? | 19:44 |
| NobodyCam | changed even | 19:44 |
| rloo | NobodyCam: or maybe I didn't get around to doing that yet or forgot... | 19:44 |
| *** bcornec1 has joined #openstack-ironic | 19:44 | |
| NobodyCam | the line above said no meeting on the 13th | 19:44 |
| rloo | NobodyCam: OH. thx for catching that! | 19:44 |
| NobodyCam | :p | 19:44 |
| *** hoangcx has quit IRC | 19:46 | |
| *** hoangcx has joined #openstack-ironic | 19:47 | |
| *** hoangcx has quit IRC | 19:47 | |
| *** hecliunyx has joined #openstack-ironic | 19:48 | |
| *** e0ne has quit IRC | 19:48 | |
| *** hoangcx has joined #openstack-ironic | 19:49 | |
| *** hoangcx has quit IRC | 19:49 | |
| *** hoangcx has joined #openstack-ironic | 19:50 | |
| *** hoangcx has quit IRC | 19:57 | |
| *** hoangcx has joined #openstack-ironic | 19:59 | |
| *** hecliunyx has quit IRC | 19:59 | |
| *** jvgrant_ has joined #openstack-ironic | 20:01 | |
| jroll | devananda: great example of why we should have a script for ops to fail things outside of the state machine | 20:01 |
| jroll | https://bugs.launchpad.net/ironic/+bug/1590146 | 20:01 |
| openstack | Launchpad bug 1590146 in Ironic "A timed out cleaning cannot be retried successfully" [High,In progress] - Assigned to Julia Kreger (juliaashleykreger) | 20:01 |
| TheJulia | provide external chaos? :) | 20:03 |
| jroll | TheJulia: question there. so with this patch, if cleaning times out, the clean_step will be cleared at timeout time, right? | 20:03 |
| jroll | I feel like we should clear that on the transition to CLEANING instead | 20:04 |
| jroll | otherwise you lose information about what step was running when it timed out | 20:04 |
| TheJulia | basically yes, it calls the cleaning failure handler via a new intermediate task | 20:04 |
| *** baoli has quit IRC | 20:04 | |
| *** baoli has joined #openstack-ironic | 20:05 | |
| jroll | TheJulia: any arguments against doing it during the transition to cleaning instead? | 20:05 |
| jroll | JayF: ^^ your opinion very welcome here | 20:05 |
| *** baoli has quit IRC | 20:05 | |
| *** baoli has joined #openstack-ironic | 20:06 | |
| *** sdake_ is now known as sdake | 20:06 | |
| TheJulia | jroll: my immediate thought is that we would need to turn around and re-tool all of the cleaning failure handling if we do that when failure in any other case just calls conductor utils cleaning_error_handler, and truthfully I think we would want it, I think we really need to somehow log, or append to the error what the last step was, which is not currently present. | 20:07 |
| *** jcoufal_ has quit IRC | 20:09 | |
| jroll | TheJulia: no, I mean clear it when we restart cleaning, rather than when it fails | 20:09 |
| jroll | (which I thought we did already) | 20:09 |
| JayF | I mean, if we put the step in last_error | 20:09 |
| JayF | it doesn't matter either way | 20:09 |
| JayF | so we should make sure the error includes clean step OR only clear when entering cleaning | 20:09 |
| *** jaybeale has joined #openstack-ironic | 20:10 | |
| jroll | yeah, that's fair | 20:10 |
| TheJulia | jroll: only upon failure does it get cleaned. It's presence prevents the steps from being updated, so the front end of going into cleaning may also need changes too | 20:10 |
| jroll | we do clear it when we start cleaning: https://github.com/openstack/ironic/blob/master/ironic/conductor/manager.py#L870 | 20:11 |
| jroll | er no | 20:11 |
| jroll | wow, I can't read | 20:11 |
| *** chlong has quit IRC | 20:12 | |
| TheJulia | I think leaving it present is less ideal because it possibly leaves bad info hanging around. I think appending to last_error would be ideal, and if we just do that by default, then we would actually have more detail upon any failure | 20:12 |
| JayF | I like last_error better ++ | 20:14 |
| jroll | ok yeah, I think I'm convinced | 20:14 |
| JayF | it's where the error is supposed to be anyway, right? | 20:14 |
| JayF | easier than writing "if cleanign fails, look at step and last error" in a tshooting doc | 20:15 |
| jroll | TheJulia: ok, reviewed with "add to last_error" as a comment :) | 20:15 |
| TheJulia | JayF: yup, just upon timeout it was hard coded previously :) | 20:15 |
| TheJulia | ok | 20:15 |
| * TheJulia wonders if anywhere else logs the clean_step that was failed upon | 20:16 | |
| jroll | I'd like it somewhere fetchable from the api, anyway | 20:17 |
| JayF | logs get more useless as size of environment increases :) | 20:17 |
| TheJulia | s/logs/records/ | 20:18 |
| *** baoli has quit IRC | 20:19 | |
| TheJulia | mid-step failures appear to be logged, so yeah, in the helper task should perfectly then | 20:21 |
| *** jvgrant_ has quit IRC | 20:23 | |
| *** wajdi has quit IRC | 20:23 | |
| *** joprovost has quit IRC | 20:34 | |
| *** baoli has joined #openstack-ironic | 20:35 | |
| gmmaha | TheJulia: cinerama: i started working on fixing the rest of the bug 1589672 and hitting an interesting issue. the change looks for env variable ANSIBLE_INSTALL_ROOT inside defaults/main.yml and that always returns null during the bifrost vagrant VM provisioning step.. jlvillal helped me to confirm that 'become: yes' in the playbook nulls all env variable | 20:52 |
| openstack | bug 1589672 in bifrost "Install location is not configurable" [Medium,New] https://launchpad.net/bugs/1589672 | 20:52 |
| *** thrash is now known as thrash|g0ne | 20:53 | |
| gmmaha | have you run across this issue before? Any tips on solving this would be awesome.. | 20:53 |
| gmmaha | i can pass the value to the install.yml step in the provisioning script and check for it inside the playbook | 20:53 |
| *** cfarquhar has quit IRC | 20:53 | |
| *** clenimar has quit IRC | 20:55 | |
| *** Goneri has quit IRC | 20:58 | |
| *** jvgrant_ has joined #openstack-ironic | 21:01 | |
| openstackgerrit | Julia Kreger proposed openstack/ironic: Add cleanwait timeout cleanup process https://review.openstack.org/327403 | 21:03 |
| jlvillal | gmmaha: It nulls most variables. A few special ones get to go through. | 21:03 |
| TheJulia | gmmaha: could you update the item and detail that along with what you found, including steps to reproduce what you found? | 21:04 |
| * jroll see y'all tomorrow | 21:04 | |
| TheJulia | goodnight jroll | 21:05 |
| gmmaha | TheJulia: for sure. I can send up the patch also along with it | 21:05 |
| TheJulia | jlvillal: you snuck some comments in i see | 21:05 |
| *** trown is now known as trown|outtypewww | 21:06 | |
| cinerama | gmmaha, did you pass environment: to the task? | 21:08 |
| gmmaha | cinerama: well, its thrown up as an env variable inside the VM | 21:09 |
| gmmaha | and yes the task will do a lookup for env variable | 21:09 |
| TheJulia | jlvillal: regarding assertNotIn, that seems like something that should be globally standardized upon since it is performed differently in various tests | 21:10 |
| *** jjohnson2_ has quit IRC | 21:11 | |
| jlvillal | TheJulia: Probably true. It makes failure cases slightly better. More informative. | 21:11 |
| jlvillal | TheJulia: Would not prevent me from approving the patch though! | 21:12 |
| cinerama | gmmaha: i haven't tried passing stuff using ansible's "environment" keyword plus become in the vagrant playbook but i know it works in our regular playbooks | 21:12 |
| *** jvgrant_ has quit IRC | 21:12 | |
| jlvillal | TheJulia: I did say "nit". maybe I should say "style" :) | 21:12 |
| openstackgerrit | Ganesh Maharaj Mahalingam proposed openstack/bifrost: Make bifrost installation location configurable. https://review.openstack.org/329191 | 21:13 |
| jlvillal | TheJulia: Oh and yeah I did sneak some comments in :) I had started the review before lunch... | 21:13 |
| jlvillal | It took me longer than I expected. | 21:13 |
| TheJulia | jlvillal: I know :) No worries though. I think having a consensus on style is a good thing fwiw, I was just trying to go with the way the other tests were written around it | 21:13 |
| gmmaha | cinerama: right, when i ssh into the Vm and then run the playbook its able to read the env variable just fine and seems to work good | 21:14 |
| jlvillal | TheJulia: Oh that's a good idea. /me didn't look around the code to see :( | 21:14 |
| gmmaha | Its the vagrant VM setup that fails | 21:14 |
| cinerama | gmmaha, okay, well i will have a look at your change but i have a couple other things i need to do first so you may not get immediate feedback | 21:15 |
| gmmaha | cinerama: no rush at all.. thanks for checking on it for me | 21:15 |
| openstackgerrit | Julia Kreger proposed openstack/ironic: Add cleanwait timeout cleanup process https://review.openstack.org/327403 | 21:16 |
| TheJulia | Done! | 21:17 |
| *** lindycoder has quit IRC | 21:23 | |
| jlvillal | TheJulia: +2 :) | 21:25 |
| jlvillal | And thanks | 21:25 |
| TheJulia | No problem :) | 21:28 |
| *** cfarquhar has joined #openstack-ironic | 21:40 | |
| *** cfarquhar has quit IRC | 21:40 | |
| *** cfarquhar has joined #openstack-ironic | 21:40 | |
| mrda | Morning ironic | 21:46 |
| *** rpioso has quit IRC | 21:46 | |
| *** bcornec1 has quit IRC | 21:47 | |
| *** dmk0202 has joined #openstack-ironic | 21:47 | |
| *** rcernin has quit IRC | 21:48 | |
| *** bcornec1 has joined #openstack-ironic | 21:49 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/ironic: Updated from global requirements https://review.openstack.org/328746 | 21:50 |
| *** cdearborn has quit IRC | 21:51 | |
| thiagop | morning mrda | 21:51 |
| mrda | o/ | 21:54 |
| *** nicodemos is now known as nico-afk | 22:01 | |
| *** rbudden has quit IRC | 22:02 | |
| *** SiRiuS__ has quit IRC | 22:03 | |
| *** causten_ has quit IRC | 22:04 | |
| *** bcornec1 has quit IRC | 22:04 | |
| *** hoonetorg has quit IRC | 22:05 | |
| *** thiagop has quit IRC | 22:05 | |
| *** hoonetorg has joined #openstack-ironic | 22:08 | |
| *** bcornec1 has joined #openstack-ironic | 22:10 | |
| openstackgerrit | Merged openstack/ironic-python-agent: tinyipa: Fix git clone tags when 1.6.5 <= git < 1.7.10 https://review.openstack.org/327825 | 22:16 |
| *** amotoki has quit IRC | 22:17 | |
| jlvillal | Hi mrda | 22:18 |
| *** chlong has joined #openstack-ironic | 22:21 | |
| *** bcornec1 has quit IRC | 22:24 | |
| *** rama_y has joined #openstack-ironic | 22:24 | |
| *** ayoung has quit IRC | 22:27 | |
| *** bcornec1 has joined #openstack-ironic | 22:30 | |
| *** bcornec1 has quit IRC | 22:34 | |
| *** Jabadia has joined #openstack-ironic | 22:36 | |
| Jabadia | I'm so close. I have a comment from Dmitry Tantsur, to "mock a new function here to fix unit tests" | 22:37 |
| Jabadia | in https://review.openstack.org/#/c/327807/5/ironic_python_agent/tests/unit/test_hardware.py | 22:37 |
| Jabadia | I dont know how to fix it :( | 22:37 |
| mrda | hey jlvillal | 22:38 |
| *** bcornec1 has joined #openstack-ironic | 22:40 | |
| jlvillal | Jabadia: I think you need to explore why the tests are failing. | 22:43 |
| jlvillal | Jabadia: http://logs.openstack.org/07/327807/5/check/gate-ironic-python-agent-python27/59b7d5d/console.html.gz#_2016-06-10_20_22_02_239 | 22:43 |
| *** dmk0202 has quit IRC | 22:52 | |
| *** bcornec1 has quit IRC | 22:53 | |
| *** bcornec1 has joined #openstack-ironic | 22:53 | |
| Sukhdev | jroll : Ping | 22:56 |
| *** PollyZ_ has joined #openstack-ironic | 22:58 | |
| *** bcornec1 has quit IRC | 22:58 | |
| *** PollyZ has quit IRC | 23:01 | |
| *** PollyZ_ has quit IRC | 23:02 | |
| jroll | Sukhdev: hi, what's up | 23:09 |
| * jroll not here much longer fyi | 23:09 | |
| Sukhdev | jroll : I picked up from the meeting this morning about Ironic mid-cycle | 23:10 |
| jroll | mhm? | 23:10 |
| Sukhdev | jroll : when and where is it? | 23:10 |
| jroll | Sukhdev: I've emailed the dev mailing list numerous times on this, you should read it :) | 23:11 |
| jroll | Sukhdev: it's virtual, here's the info https://wiki.openstack.org/wiki/VirtualSprints#Ironic_Virtual_Newton_Midcycle | 23:11 |
| Sukhdev | jroll : sorry - my stupid filters only pick up ML2 and Neutron - sorry | 23:11 |
| jroll | Sukhdev: there's been mailing list posts that discuss the multitenant networking work with only the ironic tags, if I'm not mistaken, so you should add ironic | 23:12 |
| Sukhdev | jroll: I will update my filters - thanks for pointing out - | 23:13 |
| jroll | no problem | 23:13 |
| Sukhdev | jroll : want to make sure I attend this one - and get those patches merged - the ones we discussed this morning | 23:13 |
| jroll | sure | 23:13 |
| *** mbound has quit IRC | 23:23 | |
| openstackgerrit | Yossi Ovadia proposed openstack/ironic-python-agent: Handle diskless hardware connected to remote iscsi. https://review.openstack.org/327807 | 23:24 |
| Jabadia | Ask Dmitry for help on implementing the mock. couldnt figure it out. | 23:24 |
| Jabadia | asked * | 23:24 |
| jlvillal | Jabadia: Did you figure out the unit test errors? | 23:27 |
| Jabadia | no :( | 23:27 |
| Jabadia | I asked Dmitry for help | 23:27 |
| Jabadia | Gave up after ~2 hours | 23:27 |
| Jabadia | if trying to figure out what to do | 23:27 |
| Jabadia | I only pushed his other comments | 23:28 |
| jlvillal | Jabadia: So it looks like the code is adding the check to all calls | 23:28 |
| jlvillal | Jabadia: _check_for_iscsi() | 23:28 |
| openstackgerrit | Stephanie Miller proposed openstack/ironic-specs: Boot from Volume - Reference Drivers https://review.openstack.org/294995 | 23:28 |
| Jabadia | ( listening ) | 23:28 |
| jlvillal | Jabadia: So if don't mock the execution of the 'iscsistart' calls then they will get executed for real during the unit tests. Which is not a good thing. | 23:28 |
| jlvillal | Jabadia: So probably should mock the call to: _check_for_iscsi() for most callers. | 23:29 |
| *** jaybeale has quit IRC | 23:29 | |
| jlvillal | Jabadia: And then have an individual unit test (which I think is there) to check _check_for_iscsi() | 23:29 |
| jlvillal | Jabadia: Hopefully that makes sense | 23:30 |
| Jabadia | yeah , that I have. | 23:30 |
| Jabadia | so I need to just mock the call where it relevant ? | 23:30 |
| Jabadia | ( tried it in specific one ) | 23:30 |
| Jabadia | I suspect I need to implement the return ( simulate the way disks looks like ) and this is where I failed | 23:31 |
| jlvillal | Jabadia: Actually I think the reason for failure is that 'utils.execute' is mocked | 23:31 |
| jlvillal | Jabadia: AND the tests are making sure that utils.execute is not called | 23:31 |
| jlvillal | Jabadia: But the new code DOES call utils.execute. So the test fails. | 23:32 |
| *** bcornec1 has joined #openstack-ironic | 23:32 | |
| Jabadia | hmm , shall I try to remove the mock ? ( execute ) | 23:32 |
| jlvillal | Jabadia: It fails: self.assertFalse(mock_exec.called) | 23:32 |
| jlvillal | Jabadia: Heck no | 23:32 |
| Jabadia | dammit :) | 23:32 |
| *** r-daneel has quit IRC | 23:33 | |
| *** ayoung has joined #openstack-ironic | 23:33 | |
| Jabadia | so, how to I get out of this loop ? | 23:35 |
| Jabadia | move test__check_for_iscsi outside TestModuleFunctions ? | 23:35 |
| jlvillal | Jabadia Are you running the unit tests locally? | 23:36 |
| *** bcornec1 has quit IRC | 23:36 | |
| Jabadia | yes, got the same fail | 23:37 |
| Jabadia | e.g "AssertionError: Expected 'sleep' to be called once. Called 2 times." | 23:37 |
| Jabadia | which I still dont understand how it's related to me | 23:37 |
| Jabadia | Assume I'm missing a basic knowledge about mocks | 23:38 |
| Jabadia | and its probably related to what you said about "code is adding the check to all calls" | 23:38 |
| *** bcornec1 has joined #openstack-ironic | 23:39 | |
| jlvillal | Jabadia: So the added code gets called from a fair number of unit tests. | 23:42 |
| jlvillal | Jabadia: One suggest for the safety of the tests, maybe change the new function to raise an error: "raise ValueError('foo'))" | 23:42 |
| jlvillal | To figure out all the unit tests that will be calling the new function | 23:42 |
| jlvillal | That might help you figure out why the code is causing unit tests to fail. | 23:43 |
| jlvillal | I'm unsure why sleep count went from 1 to 2. | 23:44 |
| Jabadia | on one of them, once i added (test_evaluate_hw_waits_for_disks) mock to check_for_scsci , it faled on "errors.DeviceNotFound('boom')," | 23:45 |
| *** joprovost has joined #openstack-ironic | 23:45 | |
| *** amotoki has joined #openstack-ironic | 23:46 | |
| *** wajdi has joined #openstack-ironic | 23:46 | |
| Jabadia | just because I added the mock that's what i was unable to figure out. how to fix that | 23:46 |
| Jabadia | its like i need to add a mock output return_value ( which I failed to figure out how to ) | 23:47 |
| JayF | there are lots of good examples of that in the existing tests | 23:47 |
| JayF | I know, for instance, it's used in the tests for list_hardware_info | 23:47 |
| JayF | you should see @mock.patch(blah) at the top | 23:47 |
| *** wajdi_ has joined #openstack-ironic | 23:48 | |
| JayF | that's passed into the method as a mock object | 23:48 |
| JayF | then you'll see that blah_mock.return_value = something | 23:48 |
| Jabadia | :) ok, exactly what I did, let me do it again an pasteit | 23:48 |
| JayF | I don't really have time to explicitly help you with that; was just hoping the pointer would help :( | 23:48 |
| *** wajdi has quit IRC | 23:50 | |
| *** amotoki has quit IRC | 23:50 | |
| jlvillal | Jabadia: http://paste.openstack.org/show/515858/ | 23:53 |
| jlvillal | So this is showing me that not all the 'execute' calls are getting caught. | 23:53 |
| jlvillal | I mean mocked, not caught | 23:53 |
| Jabadia | ok .. | 23:54 |
| jlvillal | Jabadia: http://paste.openstack.org/show/515859/ | 23:54 |
| jlvillal | Jabadia: So those need to be fixed. As we can't have the unit tests actually execing stuff. | 23:54 |
| Jabadia | ( reading the paste ) | 23:55 |
| Jabadia | this is the code I'm trying - http://paste.openstack.org/show/515860/ | 23:57 |
| Jabadia | ( i'm still reading your paste ) | 23:57 |
| *** joprovost has quit IRC | 23:58 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!