Tuesday, 2016-04-05

*** alexpilotti has quit IRC00:00
*** rbudden has quit IRC00:04
*** alexpilotti has joined #openstack-ironic00:08
*** alexpilotti has quit IRC00:12
*** garthb has quit IRC00:14
betherlyjroll: come online to look at pings lol. Will look properly when I'm up tomorrow00:16
*** keedya has joined #openstack-ironic00:17
*** jaypipes has quit IRC00:21
*** harshs has quit IRC00:27
*** harshs has joined #openstack-ironic00:28
*** suro-patz has joined #openstack-ironic00:30
devanandajroll: bug in the FlatNetwork class. __init__ is not called at proces start time now, but rather when ever a node is instantiated -- meaning that if the config is wrong, it becomes impossible to use the driver, but the conductor starts anyway00:31
*** thrash is now known as thrash|g0ne00:33
*** hoangcx has joined #openstack-ironic00:39
*** smoriya_ has joined #openstack-ironic00:41
*** suro-patz has quit IRC00:54
*** cdearborn has quit IRC00:59
*** baoli has joined #openstack-ironic00:59
*** suro-patz has joined #openstack-ironic01:00
*** Sukhdev has quit IRC01:13
*** cfarquhar has quit IRC01:18
*** spandhe has quit IRC01:20
*** cfarquhar has joined #openstack-ironic01:21
*** cfarquhar has quit IRC01:21
*** cfarquhar has joined #openstack-ironic01:21
*** baoli has quit IRC01:23
*** baoli has joined #openstack-ironic01:28
*** harshs has quit IRC01:36
*** suro-patz has quit IRC01:41
*** praneshp__ has quit IRC01:43
*** jaybeale has quit IRC01:51
*** JieLi has joined #openstack-ironic02:02
*** JieLi has quit IRC02:03
*** Marga_ has quit IRC02:11
*** baoli has quit IRC02:11
*** baoli has joined #openstack-ironic02:12
*** alex_xu has quit IRC02:13
*** smoriya_ has quit IRC02:14
*** alex_xu has joined #openstack-ironic02:16
*** achanda has joined #openstack-ironic02:21
*** baoli has quit IRC02:22
*** suro-patz has joined #openstack-ironic02:35
*** suro-patz has quit IRC02:39
*** mfisch has joined #openstack-ironic02:45
*** spandhe has joined #openstack-ironic02:53
*** Marga_ has joined #openstack-ironic03:01
*** Marga_ has quit IRC03:06
*** sekrit has joined #openstack-ironic03:17
*** alex_xu has quit IRC03:18
*** Marga_ has joined #openstack-ironic03:19
*** alex_xu has joined #openstack-ironic03:20
*** jaybeale has joined #openstack-ironic03:20
*** spandhe_ has joined #openstack-ironic03:30
*** spandhe has quit IRC03:31
*** spandhe_ is now known as spandhe03:31
*** links has joined #openstack-ironic03:39
mrdaSo, just a quick question, how do you get ironic's properties for disk size to align with nova's flavors?  I would have thought that setting the ironic node's properties/disk to 250 and the flavor disk to 250 would have sufficed, but no :-(03:40
*** Nisha has joined #openstack-ironic03:45
*** jaybeale has quit IRC03:47
*** Nisha has quit IRC03:51
*** alex_xu has quit IRC03:58
*** alex_xu has joined #openstack-ironic04:01
*** Nisha has joined #openstack-ironic04:04
*** vmud213 has joined #openstack-ironic04:05
*** garthb has joined #openstack-ironic04:09
*** moshele has joined #openstack-ironic04:15
*** keedya has quit IRC04:20
*** alexpilotti has joined #openstack-ironic04:32
Nishamorning ironic04:33
openstackgerritNisha Agarwal proposed openstack/ironic-specs: Enhance ilo drivers to do inband inspection  https://review.openstack.org/20190404:35
*** alexpilotti has quit IRC04:37
*** kalpase has joined #openstack-ironic04:38
*** smoriya_ has joined #openstack-ironic04:38
*** spandhe has quit IRC04:41
*** spandhe has joined #openstack-ironic04:42
*** kalpase has quit IRC04:43
*** ChubYann has quit IRC04:43
*** hoangcx has quit IRC04:46
*** garthb has quit IRC04:46
*** Sukhdev has joined #openstack-ironic04:50
*** hoangcx_ has joined #openstack-ironic04:52
*** hoangcx__ has joined #openstack-ironic04:52
*** hoangcx_ is now known as hoangcx04:52
openstackgerritZhenguo Niu proposed openstack/ironic: Correct api version check conditional for node.name  https://review.openstack.org/29926404:53
*** mtanino has quit IRC04:53
*** hoangcx__ has quit IRC04:53
*** hoangcx has quit IRC04:54
*** moshele has quit IRC04:54
*** hoangcx has joined #openstack-ironic04:54
*** hoangcx has quit IRC04:57
*** hoangcx has joined #openstack-ironic04:58
*** Sukhdev has quit IRC05:06
*** alexpilotti has joined #openstack-ironic05:06
*** Sukhdev has joined #openstack-ironic05:06
*** alexpilotti has quit IRC05:11
*** Nisha_away has joined #openstack-ironic05:21
*** Nisha has quit IRC05:24
*** praneshp_ has joined #openstack-ironic05:26
*** Nisha_away is now known as Nisha05:28
*** jcoufal has joined #openstack-ironic05:45
*** rcernin has joined #openstack-ironic05:51
*** Sukhdev has quit IRC05:51
*** dougs has quit IRC05:57
*** praneshp_ has quit IRC06:00
*** kalpase has joined #openstack-ironic06:01
*** alexpilotti has joined #openstack-ironic06:07
*** alexpilotti has quit IRC06:12
*** spandhe has quit IRC06:12
*** JieLi has joined #openstack-ironic06:15
*** achanda has quit IRC06:40
*** moshele has joined #openstack-ironic07:02
*** suro-patz has joined #openstack-ironic07:03
openstackgerritSofiia Andriichenko proposed openstack/python-ironicclient: Add test for 'chassis-show --field' command  https://review.openstack.org/30147907:05
*** JieLi has quit IRC07:08
*** karimb has joined #openstack-ironic07:13
*** suro-patz has quit IRC07:25
*** ndipanov has joined #openstack-ironic07:27
*** Marga_ has quit IRC07:29
*** pcaruana has joined #openstack-ironic07:37
*** Nisha has quit IRC07:40
*** achanda has joined #openstack-ironic07:40
Haomenglucasagomes: would you help to review my spec if you have time today - https://review.openstack.org/#/c/266688/ , got 1x+2, thanks, nice day!07:44
*** ifarkas has joined #openstack-ironic07:44
*** jistr has joined #openstack-ironic07:44
*** achanda has quit IRC07:44
*** mgoddard has joined #openstack-ironic07:45
*** JieLi has joined #openstack-ironic07:46
*** Nisha has joined #openstack-ironic07:48
*** dtantsur|afk is now known as dtantsur07:49
dtantsurMorning Ironic07:49
Haomengdtantsur: morning:)07:50
dtantsurmrda, you meant properties/local_gb?07:50
*** mbound has joined #openstack-ironic07:54
*** ohamada has joined #openstack-ironic07:54
mrdadtantsur: yes07:54
dtantsurthen it should work..07:55
mrdaWorked it out, it was reserved_host_disk_mb that was causing me grief07:55
openstackgerritHaomeng,Wang proposed openstack/ironic-specs: Cloning bare metal disk  https://review.openstack.org/30149807:55
mrdaby default, set to 2, causing a misalignment between flavor and the node's properties07:55
* dtantsur has never heard about it07:56
mrdaHard to find, easy to correct :)07:56
openstackgerritHaomeng,Wang proposed openstack/ironic-specs: WIP: Cloning bare metal disk  https://review.openstack.org/30149807:56
mrdabut thankyou dtantsur for answering!07:56
dtantsur:)07:56
* mrda now fights swift_tmp_urls :)07:57
* mrda leaves that fight until tomorrow.07:58
*** mbound has quit IRC08:00
*** jistr has quit IRC08:01
*** jistr has joined #openstack-ironic08:01
*** alexpilotti has joined #openstack-ironic08:02
*** mbound has joined #openstack-ironic08:06
openstackgerritAnton Arefiev proposed openstack/ironic-inspector: Tempest plugin initial commit  https://review.openstack.org/29392508:15
openstackgerritAnton Arefiev proposed openstack/ironic-inspector: Move unit tests to "unit" directory  https://review.openstack.org/30150708:15
dtantsuraarefiev, zaqar has zaqar.tests.tempest_plugin: https://github.com/openstack/zaqar/tree/master/zaqar/tests/tempest_plugin08:19
dtantsurmaybe we should do something like that as well...08:19
openstackgerritHaomeng,Wang proposed openstack/ironic-specs: WIP: Cloning bare metal disk  https://review.openstack.org/30149808:19
dtantsuralso g'morning aarefiev :)08:19
*** dkehn has quit IRC08:20
alinebMorning all08:22
aarefievdtantsur: morning, yeah tempest_plugin is fine, I don't like it because test will be like tempest_plugin.tests.scenario.basic_test08:22
aarefievbut maybe it's fine08:23
*** dkehn has joined #openstack-ironic08:27
dtantsuraarefiev, so, does tempest strip the prefix ironic_inspector.test?08:27
* dtantsur has no clues how it works08:27
dtantsurmorning alineb08:27
aarefievdtantsur: no, in your example path was test.tempest.*, so it will try to import module tempest08:29
*** Marga_ has joined #openstack-ironic08:29
aarefievtest.tempest_plugin.* will work08:29
*** kromanenko has joined #openstack-ironic08:30
*** kromanenko_ has joined #openstack-ironic08:30
*** daemontool has joined #openstack-ironic08:31
aarefievnames overlap, no more08:31
dtantsuraarefiev, so has does the import work there? do they use kind of a relative import08:33
dtantsurI wonder how ironic_inspector.test.tempest may overlap with just tempest08:33
*** Marga_ has quit IRC08:34
*** chlong has quit IRC08:35
aarefievdtantsur: I guess they import plugin module itself, which is tempest in this case. I have tried this case few patches ago08:36
*** e0ne has joined #openstack-ironic08:37
aarefievor as path for plugin: tempest.plugin08:37
*** derekh has joined #openstack-ironic08:39
*** dkehn has quit IRC08:40
dtantsurmeh....08:40
*** electrofelix has joined #openstack-ironic08:40
aarefievdtantsur: yeah, so you vote for tempest_plugin?08:41
dtantsuraarefiev, ok, feel free to leave it as it is then. I don't want to spend weeks on naming :)08:41
dtantsurwhatever, I'm fine with inspector_tempest_plugin then08:41
aarefievdtantsur: ok, lets keep, looks like it would not big problem to rename, it affect only plugin code08:42
*** dkehn has joined #openstack-ironic08:46
aarefievlooks like it is possible conflicts between plugins08:46
*** dtantsur is now known as dtantsur|brb08:49
*** Marga_ has joined #openstack-ironic08:56
*** JieLi has quit IRC09:04
*** Marga_ has quit IRC09:12
openstackgerritAline Bousquet proposed openstack/ironic-lib: Add support for metrics  https://review.openstack.org/30152609:12
*** achanda has joined #openstack-ironic09:13
*** mkovacik has joined #openstack-ironic09:16
*** achanda has quit IRC09:18
*** kromanenko_ has quit IRC09:21
*** kromanenko has quit IRC09:22
*** smoriya_ has quit IRC09:24
sambetts|afkMorning all09:33
*** sambetts|afk is now known as sambetts09:34
*** Lisa_ has joined #openstack-ironic09:53
Lisa_Ironic conductor is not started in devstack environment09:55
Lisa_DriverNotFound: Could not find the following driver(s): flat.09:56
openstackgerritZhenguo Niu proposed openstack/ironic: Add nodes tagging support - objs  https://review.openstack.org/23335709:57
openstackgerritZhenguo Niu proposed openstack/ironic: Add nodes tagging support - API  https://review.openstack.org/25047809:57
openstackgerritZhenguo Niu proposed openstack/ironic: Joined 'tags' column while getting node  https://review.openstack.org/25306509:57
openstackgerritZhenguo Niu proposed openstack/ironic: Add DB layer support for node tags filter  https://review.openstack.org/27262409:57
openstackgerritSofiia Andriichenko proposed openstack/python-ironicclient: Add test for 'node-show --field' command  https://review.openstack.org/30006409:57
sambettsLisa_: are you testing the Ironic neutron intergration ?09:58
Lisa_yes. i am new bie to ironic.09:58
Lisa_gonna test ironic intergaration with neutron09:59
sambettsLisa_: have you downloaded the latest in the intergration tree? https://review.openstack.org/#/c/26915710:00
Lisa_let me check, sam10:01
sambettsLisa_: also once you've downloaded the intergration code did you make sure that you reinstalled Ironic so that the changes are all picked up10:01
*** mgould has joined #openstack-ironic10:01
Lisa_i install a week back10:04
mgouldmorning Ironicers!10:04
Lisa_so pulled all the changes using git pull from the link https://blueprints.launchpad.net/ironic/+spec/ironic-ml2-integration10:04
sambettsohai mgould10:04
mgouldhi sambetts10:04
sambettsLisa_: then you reinstalled the package, e.g. pip install --upgrade /opt/stack/ironic10:05
*** karimb has quit IRC10:11
*** karimb_ has joined #openstack-ironic10:11
Lisa_thanks sam. reinstall the package and come back10:12
*** electrofelix has quit IRC10:14
*** electrofelix has joined #openstack-ironic10:14
mkovaciksambetts, hi, could you please review the reapply patch on inspector if you have some spare time? https://review.openstack.org/#/c/267637/ thanks!10:15
dtantsur|brbsambetts, Lisa_, better use -e flag with pip install10:15
sambettsmkovacik: I'll add to my list :)10:15
dtantsur|brbthen you won't have to reinstall it each time10:16
dtantsur|brbofc don't forget to restart ironic10:16
*** dtantsur|brb is now known as dtantsur10:16
mkovaciksambetts, ok cool10:16
sambettsdtantsur|brb: new setup.cfg endpoints don't get detected by -e :(10:16
dtantsursambetts, yep. still it's better to reinstall with -e flag10:16
dtantsurcause code changes are detected10:17
sambetts++10:17
*** hoangcx has quit IRC10:18
*** hoangcx has joined #openstack-ironic10:19
vdrokmorning ironic, Haomeng dtantsur sambetts and mkovacik10:21
dtantsuro/10:21
sambettsmorning vdrok10:21
mkovacikvdrok, o/10:21
mgouldmorning mkovacik dtantsur vdrok Lisa_10:23
mkovacikmgould, o/10:23
vdrokmorning mgould10:23
mkovacikmorning all! :)10:23
* mgould is confused about the logic of Depends-On10:27
mgouldneither https://review.openstack.org/#/c/301140/ nor https://review.openstack.org/#/c/272206/ will pass CI without the other, AFAICT10:27
mgouldcan I make them both Depend-On each other?10:28
sambettsmgould: No the depends-on is a one way relationship, and in the gate it will test them together10:29
mgouldOK10:29
mgouldso currently I have a D-O relationship from 301140 -> 27220610:30
sambettsyup10:30
mgoulddoes that mean that when testing 272206 the gate won't check out 301140, but when testing 301140 it will check out 272206?10:30
sambettsI believe so10:30
dtantsurmgould, it's just a bug in one of the patches, lemme leave a comment :)10:31
mgouldoh, excellent10:31
*** karimb_ has quit IRC10:32
*** arturas has joined #openstack-ironic10:34
dtantsurmgould, commented10:34
vmud213morning ironicers10:34
sambettsMorning vmud21310:37
*** cameron_C has quit IRC10:37
vmud213sambetts o/10:38
*** cameron_C has joined #openstack-ironic10:39
mgoulddtantsur, thanks10:41
openstackgerritMerged openstack/ironic: Fix NamedTemporaryFile() OSError Exception  https://review.openstack.org/29376210:41
mgouldmorning vmud21310:41
*** karimb has joined #openstack-ironic10:41
*** electrofelix has quit IRC10:42
openstackgerritSergii Turivnyi proposed openstack/python-ironicclient: Tests for testing chassis-create command  https://review.openstack.org/29363410:42
vmud213morning mgould10:43
*** wagiel has joined #openstack-ironic10:45
wagielHello I have been googling around but could not find the right path trying to automate ESXi deployment with ironic10:46
wagielis it possible?10:46
*** electrofelix has joined #openstack-ironic10:47
sambettswagiel: Ironic is for baremetal provisioning of whole baremetal servers, OpenStack Nova is for virtual machines10:47
wagielI'd like to deploy ESXi on baremetal10:47
sambettswagiel: Ohh got it, Ironic works more or less the same as deploying a virtual machine, you need to create an image containing the required software then nova boot it10:49
sambettsSee http://docs.openstack.org/developer/ironic/deploy/install-guide.html for how to install Ironic into an OpenStack environment10:50
wagielI have the Ironic up and running, have successfully deployed some images already10:51
wagielnow wondering how to get to the ESXi hypervisor10:51
wagieli have the iso image of course10:51
wagielI can surely extract iso image and have it boot it the standard iPXE way, but this is all manual work, now how to automate that with Ironic10:53
wagielmaybe some dummy drivers or something10:53
sambettswagiel: So one way is to create an image of an already installed ESXi, one way you can do this is to use something like virtualbox to boot the iso and install it, then you need to take that virtual machine image you've created and upload it to glance then nova boot using that image10:55
wagielthat is the theory :) I was googling for the ESXi qcow2 or whatever image couldnt find anything interesting10:56
wagielwondering if this is possible10:57
sambettswagiel: I'm guessing people can't share them if they've made them for license reasons perhaps, I found this though https://www.linkedin.com/pulse/install-vmware-esxi-oracle-virtualbox-learn-chase-hammock10:58
wagieland also I would rather deploy ESXi iso with iPXE with kickstart and then adjust the config with ansible if needed10:58
sambettswagiel: unfortunatly thats not how Ironic operates10:59
wagielinstalling ESXi on virtualbox seems little crazy to me but maybe I am mistaken10:59
wagielOk at least now I now this patch is closed10:59
wagielOk so I need image11:00
wagielwould that image be customizable during the deployment?11:00
wagielsimple-init11:00
wagielcloud-init11:01
dtantsurwagiel, iirc tripleo is using puppet triggered by cloud-init to install everything11:01
sambettsYes, ironic supports the normal nova cloud-init customisation through the config-drive11:01
dtantsuryeah. and cloud-init can work without config drive, if you have a metadata server running (both heat and nova provide one iirc)11:03
sambettswagiel: virtualbox is just one way to create the image, there are other ways you could do it, such as deploying it on a real machine then DDing the harddrive to a image file e.g. dd if=/dev/sda of=/path/to/images/sda.img bs=102411:05
wagielOk i will try that11:09
wagielthanks for sharing11:09
sambetts:)11:09
*** Marga_ has joined #openstack-ironic11:12
*** achanda has joined #openstack-ironic11:13
TheJuliagood morning!11:13
sambettsMoring TheJulia11:13
sambettsMorning*11:13
vdrokgood morning TheJulia11:14
*** achanda has quit IRC11:15
mgouldmorning TheJulia11:16
*** Marga_ has quit IRC11:17
vmud213morning TheJulia11:19
openstackgerritVladyslav Drok proposed openstack/ironic: Forbid to remove node name for api versions < 1.5  https://review.openstack.org/30098311:21
*** b_bezak has joined #openstack-ironic11:22
*** mbound has quit IRC11:24
openstackgerritJulia Kreger proposed openstack/ironic: Don't power off non-deploying iLO nodes in takeover  https://review.openstack.org/29957311:26
NishaHi All, I reproposed the spec https://review.openstack.org/201904 to Newton. however i am not sure how i can make docs gate to pass11:30
mgoulddtantsur, just fixed the things you commented on (modulo one point of disagreement, detailed in comments)11:32
jrolldevananda: I don't think the 'links' stuff is terribly useful, but I don't think it's extraneous either. re: FlatNetwork, this is with the latest code? it should be loaded at startup... https://review.openstack.org/#/c/285852/31/ironic/common/driver_factory.py11:33
jrollmorning everyone11:33
TheJuliavdrok: your aise a very good question on popping the ilo_boot_iso var from instance info, but I don't think it should even be there in the first place...11:33
TheJuliagood morning jroll11:33
vdrokmorning jroll11:33
mgouldmorning jroll11:34
vdrokTheJulia: but what if a node is being migrated from another ironic deployment?11:34
TheJuliavdrok: I would think of it as driver_info11:34
TheJuliavdrok: the prepare_instance() call which I'm not touching bases everything on what the configured glance image has, not a user definable variable11:35
*** trown|outtypewww is now known as trown11:35
TheJuliavdrok: granted, it mgiht be good to move it down to after that, it would at least one extra guard when it comes to adoption because if configuration is not right, *kaboom*11:35
vdrokI mean that deployment constructed ilo_boot_iso from glance images, stored it on conductor and written that to instance_info11:35
*** thrash|g0ne is now known as thrash11:36
vdrokand then the node is being adopted11:36
jrollTheJulia: are you doing bifrost 1.0.1 or do you want me to handle it quickly? (http://lists.openstack.org/pipermail/openstack-dev/2016-April/091241.html)11:36
vdrokilo_boot_iso is still present, node tries to boot and fails11:36
TheJuliavdrok: ahh, and what I'm saying is that is disregarded _when_ the other path that would be valid is taken11:36
TheJuliajroll: if you have it up in front of you, please, if not I can brian context switchin about 15 minutes11:37
jrollyeah np11:37
TheJuliavdrok: I'll move it, just seems like extranious data to me :)11:38
*** mbound has joined #openstack-ironic11:39
vdrokTheJulia: I think I didn't get what you meant by "and what I'm saying is that is disregarded _when_ the other path that would be valid is taken" :)11:39
*** mbound has quit IRC11:39
*** mbound has joined #openstack-ironic11:40
*** mbound has quit IRC11:40
jrollTheJulia: fyi https://review.openstack.org/30159611:40
TheJuliajroll: thank you, i went looking for a reply on Sunday and didn't see it :(  Maybe it is time I start using a real email client instead of the gmail web interface for the mailing list :(11:40
jrollheh, np11:41
vdrokTheJulia: I was referring to this possibility - https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/ilo/boot.py#L148-L192, it is a case when user image is in glance and has kernel and ramdisk, but not boot_iso properties. then it is constructed, stored on conductor and writtern to instance_info IIRC11:47
TheJuliavdrok: so, popping it would be bad then, since the path into that is prepare_instance not prepare_ramdisk, but both ultimately call it11:51
TheJuliaat least I think11:51
* TheJulia goes and pulls the bug up11:51
*** raildo-afk is now known as raildo11:54
TheJuliaso non agent drivers in non-active state will call prepare_ramdisk11:54
*** dprince has joined #openstack-ironic11:57
*** jaypipes has joined #openstack-ironic11:58
dtantsurmorning jroll, TheJulia11:58
jrollmorning dtantsur \o12:00
* jroll just found https://github.com/guyzmo/vim-etherpad12:00
vdrokTheJulia: right now looking at the code, it is popped out only when image_source is from glance, meaning that ilo_boot_iso either contains the value from boot_iso image property, or constructed one from kernel and ramdisk, which seems to be ok, but I might be missing something. I'll try to dig into this in a bit :)12:02
TheJuliavdrok: please, Ideally, in my mind, we don't want to do anything that modifies a running instance when it does not make sense, including records of12:04
*** kalpase has left #openstack-ironic12:04
TheJuliavdrok: in the case of prepare_instance, that kind of makes sense to leave it as-is... as much as I don't like it... because in both the ilo and irmc drivers, they expect that a user will be booting via virtual media if local boot is not defined12:04
*** electrofelix has quit IRC12:08
*** baoli has joined #openstack-ironic12:09
*** mbound has joined #openstack-ironic12:11
*** cfarquhar has quit IRC12:30
*** cfarquhar has joined #openstack-ironic12:30
*** cfarquhar has quit IRC12:30
*** cfarquhar has joined #openstack-ironic12:30
*** mvpnitesh has joined #openstack-ironic12:31
mvpniteshHi All12:31
mvpniteshGood evening12:31
TheJuliagood morning12:32
jrollis there anything written up on what we want to do in the future in terms of hardware metrics? I feel like there was but can't find it12:33
jrolldtantsur: ^12:33
sambettsjroll: as in reading hw sensors etc?12:34
* dtantsur does not remember12:34
*** mtanino has joined #openstack-ironic12:34
mvpniteshI've a query. I've provisioned a bare metal machine using ironic. The image with which we booted the bare meatal  will be the /var/lib/ironic/master_images/ .When can be it deleted12:34
jrollsambetts: yeah, thought we were doing some general work there, I may be wrong12:34
jrollmvpnitesh: ironic will clean it up when it's no longer in use, I believe12:34
sambettsjroll: there is a spec somewhere12:35
mvpnitesh@jroll Thanks.I've a doubt should will the image still exist after delete the node?12:36
sambettsjroll: ironic-specs/specs/backlog/support-per-driver-sensor-meters.rst12:37
jrollmvpnitesh: yes, it will exist for some time, I believe it is a periodic task that will clean it up, but it may be based on free disk space, don't remember right away12:37
dtantsurit based on both time and free space12:38
jrollsambetts: nice, thank you12:38
dtantsurwe do cache images for some time, cause deployment is likely to reuse the same images pretty often12:38
dtantsure.g. the whole tripleo uses only the same deploy and the same instance image for everything12:38
dtantsurthis cache can be tweaked via the configuration file though12:38
dtantsurmvpnitesh, ^^12:38
mvpniteshdtantsur: Thanks for clarifying my query12:39
*** thiagop has joined #openstack-ironic12:39
thiagopGood morning, Ironic12:39
mgouldthiagop, morning!12:39
TheJuliagood morning thiagop12:40
*** baoli_ has joined #openstack-ironic12:40
openstackgerritVladyslav Drok proposed openstack/ironic: Forbid to remove node name for api versions < 1.5  https://review.openstack.org/30098312:41
vdrokmorning thiagop12:42
*** baoli has quit IRC12:43
thiagopdtantsur: around?12:45
dtantsurthiagop, morning, I am12:45
thiagopdtantsur: hiya, I have a quick question about the futurist implementation. The decorator of periodic tasks deprecated that 'periodic_interval' value on the ironic.conf. Are supposed to create a variable for spacing on periodic tasks for each specific (group of) tasks or it should be a global parameter?12:47
thiagopdtantsur: Context: I saw that inspector have a spacing of its own. We are creating some tasks for the OneView driver and I would know if I'm supposed to create a configuration option inside [oneview] section12:49
dtantsurthiagop, each task should have its own spacing, so yeah, you need your option12:50
*** wagiel has quit IRC12:50
thiagopdtantsur: nice, ty12:50
openstackgerritThiago Paiva Brito proposed openstack/ironic-specs: Dynamic allocation of nodes on OneView drivers  https://review.openstack.org/27572612:53
*** mat128 has joined #openstack-ironic12:55
thiagopFeedbacks on ^^^ would be most welcome :)12:55
*** cdearborn has joined #openstack-ironic12:57
mat128thiagop: doesnt it overlaps with https://bugs.launchpad.net/ironic/+bug/1563694 ?12:59
openstackLaunchpad bug 1563694 in Ironic "Can create/update node with name "" in any api version" [High,In progress] - Assigned to Zhenguo Niu (niu-zglinux)12:59
*** Lisa_ has quit IRC12:59
thiagopmat128: don't see how. Do you see any problem?13:00
*** igordcard has joined #openstack-ironic13:01
*** igordcard has quit IRC13:02
mat128first is "delete is possible while it shouldnt" and second is add/update13:02
*** igordcard has joined #openstack-ironic13:03
mat128maybe we could kill two birds with one stone?13:03
mat128in any case I dont disagree, just pointing out similarities13:03
*** b_bezak has left #openstack-ironic13:03
*** b_bezak_ has joined #openstack-ironic13:03
*** moshele has quit IRC13:03
thiagopmat128: are you talking about the Dynamic allocation spec or vdrok's patch?13:04
mat128Completely messed up on the reviews :)13:04
mat128the latter, sorry for the noise13:04
*** moshele has joined #openstack-ironic13:04
openstackgerritDmitry Tantsur proposed openstack/ironic-python-agent: Wait for the interfaces to get IP addresses before inspection  https://review.openstack.org/30054813:05
dtantsurjroll, reworked ^^^13:05
thiagopmat128: no problem, it happens. But it's just tuesday, get some coffee13:05
thiagop:D13:05
*** Nisha has quit IRC13:05
jrolldtantsur: +213:09
jroll(with nits)13:09
jrollcurious why u no loopingcall, but /shrug13:09
dtantsurprobably I just don't know it too well :) does it have any benefits over just looping?13:10
dtantsuralso thanks for review, will fix the nits, as it's part of release notes13:10
*** wendar_ has joined #openstack-ironic13:14
*** b_bezak_ is now known as b_bezak13:15
*** b_bezak has quit IRC13:19
*** dutsmoc has joined #openstack-ironic13:20
*** mgagne_ has joined #openstack-ironic13:20
*** cfarquhar has quit IRC13:21
*** arturas has quit IRC13:21
*** krtaylor has quit IRC13:21
*** zzzeek has quit IRC13:21
*** chihhsin has quit IRC13:21
*** mgagne has quit IRC13:21
*** wendar has quit IRC13:21
*** comstud has quit IRC13:21
*** eglute has quit IRC13:21
*** mtanino has quit IRC13:21
*** karimb has quit IRC13:21
*** jcoufal has quit IRC13:21
*** zer0c00l has quit IRC13:21
*** marios has quit IRC13:21
*** adreznec has quit IRC13:21
*** pleia2 has quit IRC13:21
*** rbradfor has quit IRC13:21
*** bcornec has quit IRC13:21
*** hparekh has quit IRC13:21
*** afaranha has quit IRC13:21
*** shu-mutou has quit IRC13:21
*** igordcard has quit IRC13:21
*** daemontool has quit IRC13:21
*** jayc has quit IRC13:21
*** amit213 has quit IRC13:21
*** mtreinish has quit IRC13:21
*** yuanying has quit IRC13:21
*** marlinc has quit IRC13:21
*** mkoderer has quit IRC13:21
*** NobodyCam has quit IRC13:21
*** persia has quit IRC13:21
*** alaski has quit IRC13:21
*** yuriyz has quit IRC13:21
*** sirushti has quit IRC13:21
*** mbound has quit IRC13:21
*** alexpilotti has quit IRC13:21
*** ohamada has quit IRC13:21
*** ifarkas has quit IRC13:21
*** rcernin has quit IRC13:21
*** vishwanathj has quit IRC13:21
*** harlowja has quit IRC13:21
*** thrash has quit IRC13:21
*** raginbajin has quit IRC13:21
*** sturivnyi has quit IRC13:21
*** odyssey4me has quit IRC13:21
*** smoriya has quit IRC13:21
*** tonyb has quit IRC13:21
*** konetzed has quit IRC13:21
*** moshele has quit IRC13:21
*** e0ne has quit IRC13:21
*** vsaienko has quit IRC13:21
*** sergek has quit IRC13:21
*** BadCub has quit IRC13:21
*** romcheg has quit IRC13:21
*** alineb has quit IRC13:21
*** mariojv has quit IRC13:21
*** yarkot has quit IRC13:21
*** mikal has quit IRC13:21
*** zhenguo_ has quit IRC13:21
*** bradjones has quit IRC13:21
*** johnthetubaguy has quit IRC13:21
*** jroll has quit IRC13:21
*** trown has quit IRC13:21
*** TheJulia has quit IRC13:21
*** EmilienM has quit IRC13:21
*** agordeev has quit IRC13:21
*** sylwesterB has quit IRC13:21
*** cppforlife_ has quit IRC13:21
*** clif_h has quit IRC13:21
*** mgoddard has quit IRC13:21
*** lintan has quit IRC13:21
*** ptx0 has quit IRC13:21
*** jtomasek has quit IRC13:21
*** bapalm has quit IRC13:21
*** maurosr has quit IRC13:21
*** logan- has quit IRC13:21
*** kbyrne has quit IRC13:21
*** krotscheck has quit IRC13:21
*** adam_g has quit IRC13:21
*** phschwartz has quit IRC13:21
*** Nakato has quit IRC13:21
*** kozhukalov has quit IRC13:21
*** intr1nsic has quit IRC13:21
*** mrda has quit IRC13:21
*** izaakk has quit IRC13:21
*** _fortis has quit IRC13:21
*** jmccrory has quit IRC13:21
*** natorious has quit IRC13:21
*** mvpnitesh has quit IRC13:21
*** dprince has quit IRC13:21
*** pcaruana has quit IRC13:21
*** ppiela has quit IRC13:21
*** sinval-afk has quit IRC13:21
*** openstackgerrit has quit IRC13:21
*** alex_xu has quit IRC13:21
*** Fdaisuke has quit IRC13:21
*** yolanda has quit IRC13:21
*** dims has quit IRC13:21
*** early has quit IRC13:21
*** sivarama- has quit IRC13:21
*** lazy_prince has quit IRC13:21
*** keekz has quit IRC13:21
*** mag009_ has quit IRC13:21
*** mordred has quit IRC13:21
*** dansmith has quit IRC13:21
*** kwazar has quit IRC13:21
*** HenryG has quit IRC13:21
*** cdearborn has quit IRC13:21
*** ndipanov has quit IRC13:21
*** mkoderer__ has quit IRC13:21
*** raildo has quit IRC13:21
*** stevebaker has quit IRC13:21
*** SpamapS has quit IRC13:21
*** aarefiev has quit IRC13:21
*** zigo has quit IRC13:21
*** purp has quit IRC13:21
*** sekrit has quit IRC13:21
*** baoli_ has quit IRC13:21
*** mgould has quit IRC13:21
*** mkovacik has quit IRC13:21
*** david-lyle has quit IRC13:21
*** lifeless has quit IRC13:22
*** lynxman has quit IRC13:22
*** gabriel-bezerra has quit IRC13:22
*** leifmadsen has quit IRC13:22
*** stevemar has quit IRC13:22
*** serverascode has quit IRC13:22
*** JoshNang has quit IRC13:22
*** Madasi has quit IRC13:22
*** yhvh has quit IRC13:22
*** fyxim_ has quit IRC13:22
*** ChrisMead has quit IRC13:22
*** jasondotstar has quit IRC13:22
*** mfisch has quit IRC13:22
*** dtantsur has quit IRC13:22
*** JayF has quit IRC13:22
*** vdrok has quit IRC13:22
*** joemonk has quit IRC13:22
*** boris-42 has quit IRC13:22
*** anush has quit IRC13:22
*** lekha has quit IRC13:22
*** cinerama has quit IRC13:22
*** jistr has quit IRC13:22
*** gmmaha has quit IRC13:22
*** lucasagomes has quit IRC13:22
*** bnemec has quit IRC13:22
*** m3m0 has quit IRC13:22
*** anteaya has quit IRC13:22
*** lennyb has quit IRC13:22
*** crinkle has quit IRC13:22
*** ionutbalutoiu has quit IRC13:22
*** morgan has quit IRC13:22
*** morgabra has quit IRC13:22
*** aignatov has quit IRC13:22
*** pshige______ has quit IRC13:22
*** robcresswell has quit IRC13:22
*** jaypipes has quit IRC13:22
*** hoangcx has quit IRC13:22
*** Goneri has quit IRC13:22
*** davideagnello has quit IRC13:22
*** greghaynes has quit IRC13:22
*** athomas has quit IRC13:22
*** bigjools has quit IRC13:22
*** xek has quit IRC13:22
*** devananda has quit IRC13:22
*** sinh has quit IRC13:22
*** sambetts has quit IRC13:22
*** slagle has quit IRC13:22
*** thiagop has quit IRC13:22
*** cameron_C has quit IRC13:22
*** dkehn has quit IRC13:22
*** derekh has quit IRC13:22
*** vmud213 has quit IRC13:22
*** jrist has quit IRC13:22
*** Haomeng has quit IRC13:22
*** jlvillal has quit IRC13:22
*** jcook has quit IRC13:22
*** ekarlso- has quit IRC13:22
*** kragniz has quit IRC13:22
*** eglute has joined #openstack-ironic13:23
*** cfarquhar_ has joined #openstack-ironic13:24
*** zzzeek_ has joined #openstack-ironic13:24
*** rbudden has joined #openstack-ironic13:24
*** chihhsin_ has joined #openstack-ironic13:24
*** arturas_ has joined #openstack-ironic13:24
*** Marga_ has joined #openstack-ironic13:24
*** moshele has joined #openstack-ironic13:24
*** igordcard has joined #openstack-ironic13:24
*** cdearborn has joined #openstack-ironic13:24
*** baoli_ has joined #openstack-ironic13:24
*** thiagop has joined #openstack-ironic13:24
*** mvpnitesh has joined #openstack-ironic13:24
*** mbound has joined #openstack-ironic13:24
*** jaypipes has joined #openstack-ironic13:24
*** dprince has joined #openstack-ironic13:24
*** karimb has joined #openstack-ironic13:24
*** cameron_C has joined #openstack-ironic13:24
*** hoangcx has joined #openstack-ironic13:24
*** mgould has joined #openstack-ironic13:24
*** mkovacik has joined #openstack-ironic13:24
*** dkehn has joined #openstack-ironic13:24
*** derekh has joined #openstack-ironic13:24
*** e0ne has joined #openstack-ironic13:24
*** daemontool has joined #openstack-ironic13:24
*** alexpilotti has joined #openstack-ironic13:24
*** jistr has joined #openstack-ironic13:24
*** ohamada has joined #openstack-ironic13:24
*** mgoddard has joined #openstack-ironic13:24
*** ifarkas has joined #openstack-ironic13:24
*** pcaruana has joined #openstack-ironic13:24
*** ndipanov has joined #openstack-ironic13:24
*** rcernin has joined #openstack-ironic13:24
*** jcoufal has joined #openstack-ironic13:24
*** vmud213 has joined #openstack-ironic13:24
*** alex_xu has joined #openstack-ironic13:24
*** sekrit has joined #openstack-ironic13:24
*** mfisch has joined #openstack-ironic13:24
*** david-lyle has joined #openstack-ironic13:24
*** Goneri has joined #openstack-ironic13:24
*** jayc has joined #openstack-ironic13:24
*** lintan has joined #openstack-ironic13:24
*** ptx0 has joined #openstack-ironic13:24
*** zer0c00l has joined #openstack-ironic13:24
*** davideagnello has joined #openstack-ironic13:24
*** afaranha has joined #openstack-ironic13:24
*** greghaynes has joined #openstack-ironic13:24
*** anush has joined #openstack-ironic13:24
*** vishwanathj has joined #openstack-ironic13:24
*** ppiela has joined #openstack-ironic13:24
*** sinval-afk has joined #openstack-ironic13:24
*** openstackgerrit has joined #openstack-ironic13:24
*** marios has joined #openstack-ironic13:24
*** athomas has joined #openstack-ironic13:24
*** vsaienko has joined #openstack-ironic13:24
*** bigjools has joined #openstack-ironic13:24
*** adreznec has joined #openstack-ironic13:24
*** jtomasek has joined #openstack-ironic13:24
*** xek has joined #openstack-ironic13:24
*** shu-mutou has joined #openstack-ironic13:24
*** bapalm has joined #openstack-ironic13:24
*** Fdaisuke has joined #openstack-ironic13:24
*** amit213 has joined #openstack-ironic13:24
*** yolanda has joined #openstack-ironic13:24
*** stevemar has joined #openstack-ironic13:24
*** maurosr has joined #openstack-ironic13:24
*** jrist has joined #openstack-ironic13:24
*** logan- has joined #openstack-ironic13:24
*** morgan has joined #openstack-ironic13:24
*** harlowja has joined #openstack-ironic13:24
*** devananda has joined #openstack-ironic13:24
*** dims has joined #openstack-ironic13:24
*** kbyrne has joined #openstack-ironic13:24
*** thrash has joined #openstack-ironic13:24
*** mtreinish has joined #openstack-ironic13:24
*** yuanying has joined #openstack-ironic13:24
*** gmmaha has joined #openstack-ironic13:24
*** early has joined #openstack-ironic13:24
*** Haomeng has joined #openstack-ironic13:24
*** jlvillal has joined #openstack-ironic13:24
*** stevebaker has joined #openstack-ironic13:24
*** sivarama- has joined #openstack-ironic13:24
*** lazy_prince has joined #openstack-ironic13:24
*** serverascode has joined #openstack-ironic13:24
*** sergek has joined #openstack-ironic13:24
*** JoshNang has joined #openstack-ironic13:24
*** BadCub has joined #openstack-ironic13:24
*** krotscheck has joined #openstack-ironic13:24
*** keekz has joined #openstack-ironic13:24
*** marlinc has joined #openstack-ironic13:24
*** pleia2 has joined #openstack-ironic13:24
*** Madasi has joined #openstack-ironic13:24
*** lucasagomes has joined #openstack-ironic13:24
*** mkoderer__ has joined #openstack-ironic13:24
*** raginbajin has joined #openstack-ironic13:24
*** yhvh has joined #openstack-ironic13:24
*** fyxim_ has joined #openstack-ironic13:24
*** ChrisMead has joined #openstack-ironic13:24
*** romcheg has joined #openstack-ironic13:24
*** alineb has joined #openstack-ironic13:24
*** jasondotstar has joined #openstack-ironic13:24
*** rbradfor has joined #openstack-ironic13:24
*** sturivnyi has joined #openstack-ironic13:24
*** adam_g has joined #openstack-ironic13:24
*** sinh has joined #openstack-ironic13:24
*** phschwartz has joined #openstack-ironic13:24
*** Nakato has joined #openstack-ironic13:24
*** kozhukalov has joined #openstack-ironic13:24
*** sambetts has joined #openstack-ironic13:24
*** lifeless has joined #openstack-ironic13:24
*** mkoderer has joined #openstack-ironic13:24
*** NobodyCam has joined #openstack-ironic13:24
*** intr1nsic has joined #openstack-ironic13:24
*** bcornec has joined #openstack-ironic13:24
*** dtantsur has joined #openstack-ironic13:24
*** lynxman has joined #openstack-ironic13:24
*** persia has joined #openstack-ironic13:24
*** hparekh has joined #openstack-ironic13:24
*** mrda has joined #openstack-ironic13:24
*** odyssey4me has joined #openstack-ironic13:24
*** mag009_ has joined #openstack-ironic13:24
*** mariojv has joined #openstack-ironic13:24
*** alaski has joined #openstack-ironic13:24
*** JayF has joined #openstack-ironic13:24
*** vdrok has joined #openstack-ironic13:24
*** gabriel-bezerra has joined #openstack-ironic13:24
*** yuriyz has joined #openstack-ironic13:24
*** izaakk has joined #openstack-ironic13:24
*** mordred has joined #openstack-ironic13:24
*** jcook has joined #openstack-ironic13:24
*** dansmith has joined #openstack-ironic13:24
*** joemonk has joined #openstack-ironic13:24
*** m3m0 has joined #openstack-ironic13:24
*** ekarlso- has joined #openstack-ironic13:24
*** boris-42 has joined #openstack-ironic13:24
*** bnemec has joined #openstack-ironic13:24
*** yarkot has joined #openstack-ironic13:24
*** _fortis has joined #openstack-ironic13:24
*** jmccrory has joined #openstack-ironic13:24
*** mikal has joined #openstack-ironic13:24
*** zhenguo_ has joined #openstack-ironic13:24
*** raildo has joined #openstack-ironic13:24
*** bradjones has joined #openstack-ironic13:24
*** anteaya has joined #openstack-ironic13:24
*** johnthetubaguy has joined #openstack-ironic13:24
*** jroll has joined #openstack-ironic13:24
*** trown has joined #openstack-ironic13:24
*** TheJulia has joined #openstack-ironic13:24
*** sirushti has joined #openstack-ironic13:24
*** EmilienM has joined #openstack-ironic13:24
*** natorious has joined #openstack-ironic13:24
*** agordeev has joined #openstack-ironic13:24
*** sylwesterB has joined #openstack-ironic13:24
*** cppforlife_ has joined #openstack-ironic13:24
*** kragniz has joined #openstack-ironic13:24
*** kwazar has joined #openstack-ironic13:24
*** lekha has joined #openstack-ironic13:24
*** smoriya has joined #openstack-ironic13:24
*** slagle has joined #openstack-ironic13:24
*** HenryG has joined #openstack-ironic13:24
*** tonyb has joined #openstack-ironic13:24
*** lennyb has joined #openstack-ironic13:24
*** leifmadsen has joined #openstack-ironic13:24
*** konetzed has joined #openstack-ironic13:24
*** clif_h has joined #openstack-ironic13:24
*** SpamapS has joined #openstack-ironic13:24
*** aarefiev has joined #openstack-ironic13:24
*** crinkle has joined #openstack-ironic13:24
*** ionutbalutoiu has joined #openstack-ironic13:24
*** zigo has joined #openstack-ironic13:24
*** morgabra has joined #openstack-ironic13:24
*** aignatov has joined #openstack-ironic13:24
*** purp has joined #openstack-ironic13:24
*** pshige______ has joined #openstack-ironic13:24
*** cinerama has joined #openstack-ironic13:24
*** robcresswell has joined #openstack-ironic13:24
*** openstackstatus has quit IRC13:24
*** mgagne_ has quit IRC13:24
*** mgagne_ has joined #openstack-ironic13:24
openstackgerritZhenguo Niu proposed openstack/ironic-specs: Add Port and Chassis logical name  https://review.openstack.org/29508213:24
*** openstackstatus has joined #openstack-ironic13:26
*** ChanServ sets mode: +v openstackstatus13:26
*** krtaylor has joined #openstack-ironic13:28
*** xavierr has joined #openstack-ironic13:28
*** mgould has quit IRC13:29
*** xavierr has left #openstack-ironic13:30
openstackgerritBrad P. Crochet proposed openstack/python-ironicclient: Implementation of baremetal power state commands  https://review.openstack.org/17251713:31
openstackgerritBrad P. Crochet proposed openstack/python-ironicclient: Add maintenance mode commands  https://review.openstack.org/21672713:31
openstackgerritBrad P. Crochet proposed openstack/python-ironicclient: Implementation of baremetal port create  https://review.openstack.org/17246113:31
openstackgerritBrad P. Crochet proposed openstack/python-ironicclient: Bring OSC plugin inline with approved spec  https://review.openstack.org/28416013:31
openstackgerritBrad P. Crochet proposed openstack/python-ironicclient: Add provision state commands  https://review.openstack.org/20611913:31
*** mgould has joined #openstack-ironic13:32
openstackgerritZhenguo Niu proposed openstack/ironic-specs: Add Port and Chassis logical name  https://review.openstack.org/29508213:33
*** links has quit IRC13:35
*** xavierr has joined #openstack-ironic13:35
xavierrgood morning13:37
openstackgerritOpenStack Proposal Bot proposed openstack/ironic: Updated from global requirements  https://review.openstack.org/30165713:37
*** ametts has joined #openstack-ironic13:42
thiagopmorning again xavierr13:42
openstackgerritGabriel Bezerra proposed openstack/ironic-specs: Dynamic allocation of nodes on OneView drivers  https://review.openstack.org/27572613:43
*** mgoddard_ has joined #openstack-ironic13:45
xavierrthiagop, morning13:47
xavierrguys, I'm implementing a periodic task for a driver, but I'm not sure the right place to put the periodic task13:48
*** mgoddard has quit IRC13:48
TheJuliaxavierr: Could you elaborate a little more?13:49
xavierrI'm thinking the code could be on the driver implementation (that implements base.BaseDriver) but I think it could fit on some interface implementation like vendor interface13:49
TheJuliaoh, there you go :) lag13:49
xavierrTheJulia, :)13:49
sambettsxavierr: they are normally places into which ever interface they align most with13:49
openstackgerritMichael Krotscheck proposed openstack/ironic-webclient: Added maintenance and power filter dropdowns to node list  https://review.openstack.org/30167913:50
sambettsxavierr: An example is the inspector periodic https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/inspector.py#L12513:52
openstackgerritMichael Krotscheck proposed openstack/ironic-webclient: Added selection hover state to node list  https://review.openstack.org/30168113:53
openstackgerritYuriy Zveryanskyy proposed openstack/ironic: Remove backward compatibility code with old Nova drivers  https://review.openstack.org/30168213:54
*** mbound has quit IRC13:55
*** krtaylor has quit IRC13:56
*** mgoddard_ has quit IRC13:56
*** b_bezak has joined #openstack-ironic13:56
*** mgoddard has joined #openstack-ironic13:57
openstackgerritKyrylo Romanenko proposed openstack/python-ironicclient: Add tests for baremetal subcommands in openstackclient  https://review.openstack.org/30168713:57
xavierrsambetts, but in my case is really specific for the oneview driver13:59
openstackgerritZhenguo Niu proposed openstack/ironic: Correct api version check conditional for node.name  https://review.openstack.org/29926413:59
sambettsxavierr: right, so it needs to live in one of the interfaces you implement, and you need to decide which it fits into best, power, management, boot, deploy or vendor passthru14:01
NobodyCamgood morning Ironicers :)14:01
sambettsMorning NobodyCam14:01
NobodyCamhey there sambetts :)14:02
xavierrsambetts, what about common.py, would be nice to all those who needs to run the periodic?!14:02
*** mgoddard_ has joined #openstack-ironic14:02
openstackgerritZhenguo Niu proposed openstack/ironic: Forbid to remove node name for api versions < 1.5  https://review.openstack.org/30098314:02
xavierrNobodyCam, morning14:03
NobodyCammorning xavierr :)14:03
NobodyCammoving slow this morning :)14:04
*** mgoddard has quit IRC14:06
openstackgerritVasyl Saienko proposed openstack/ironic: Update resources only for specific node during deletion.  https://review.openstack.org/28749814:07
* thiagop hands NobodyCam a double espresso14:09
NobodyCamthiagop: Thank you :)14:10
sambettsxavierr: I think you may be able to do that now we're using the futurist periodics module14:11
*** mbound has joined #openstack-ironic14:15
xavierrsambetts, yes I'm going to use de periodic module, even I had some bad experiences with futurist for threading some weeks ago :)14:16
xavierrsambetts, I you give futurist a second chance14:16
xavierrsambetts, will*14:16
jrollxavierr: sambetts: seems like the task at hand fits in the deploy driver, as we don't need the task if ironic isn't deploying oneview machines, right? :)14:18
*** arturas_ has quit IRC14:19
*** rbrud has joined #openstack-ironic14:19
sambettsjroll: I think they meant their oneview common.py which would only get loaded if their driver is loaded right?14:20
*** Marga_ has quit IRC14:20
jrollsambetts: right, I guess I'm wondering if there's an e.g. oneview power + ilo deploy driver or something14:23
jrollin which case it probably isn't needed14:23
openstackgerritMarcellin Fom Tchassem proposed openstack/ironic-inspector: Make tox respect upper-constraints.txt  https://review.openstack.org/30170014:24
*** mtanino has joined #openstack-ironic14:25
jrollthen again, probably nobody would ever use such a thing, so /shrug14:26
NobodyCammorning jroll JayF jlvillal sambetts mgould sinval-afk dtantsur lucasagomes thiagop TheJulia devananda vdrok mat128 and all others not listed here14:26
jrollgood morning PingCam14:27
jroll:P14:27
thiagopgood morning NobodyCam14:27
thiagoplol14:27
NobodyCamlol14:27
dtantsurmorning NobodyCam14:27
NobodyCam:)14:27
TheJuliagood morning NobodyCam14:27
sambettsjroll: when do function decorators get processed when they are inside a class? On first class use or the module load?14:28
jrollwow, product WG has us high priority for newton http://lists.openstack.org/pipermail/product-wg/2016-April/001064.html14:29
*** achanda has joined #openstack-ironic14:29
jrollsambetts: fairly certain decorators run at import time, but not 100% sure, easy to test :)14:29
NobodyCamjroll: what part of us?14:30
jrollNobodyCam: this, apparently: https://review.openstack.org/#/c/289627/14:30
sambettsjroll: thats what I thought too14:30
jrollI guess this is what the product WG wants out of a baremetal service14:31
jrollaaaaaaaand we're working on all but one of those :)14:31
jrollthe first one being the exception, I think14:31
jrollbut maybe not, it isn't clear to me14:31
*** vmud213 has quit IRC14:31
sambettsjroll: sounds like the fuzzy flavor matching stuff I've talked about in the past14:32
jrollmaybe?14:32
* jroll asks for clarification14:32
sambettsI'd still like to see flavors be able to configure BM to meeting flavor requirements/specs14:33
NobodyCamnot sure I get the continue my operation immediately one14:33
dtantsurjroll, we have a spec for infiniband, other things might involve inspection14:33
jrollNobodyCam: which one?14:34
NobodyCamline 70/7114:34
sambettsNobodyCam: I think that means they want live migraation14:34
NobodyCamahh14:34
NobodyCamso I see two then the backup and migration ones14:35
jrolloh yeah, I guess I was looking at the section above14:35
NobodyCambrb more coffee required14:35
*** mvpnitesh has quit IRC14:35
jroll++14:36
sambettsbackup one == snapshoting14:36
xavierrjroll, sambetts, thanks, I test with the periodic on deploy driver :)14:36
jrollyep14:36
thiagopThis WG is starting this work from now? It's good to see some governance...14:36
TheJuliajroll: I recognize Carol's name, some of the UX/UI interactions have involved people that afaik report up to Carol, so I think that may be mainly from a user interaction with the service14:36
thiagopThis tends to set direction14:36
dtantsurhonestly I have no clues what this workgroup is about :)14:36
dtantsurthiagop, well, in ideal world... in more practical world our priorities are also set by our employers14:37
dtantsurand the degree to which an employer decided it varies highly between companies14:37
jrollTheJulia: it's from a "people that want to sell ironic deployments and/or bare metal cloud" perspective, afaik14:38
jrollmost of the people in this group are product people from our employers14:38
thiagopdtantsur: right you are, but I think that without some direction, we tend to deliver incomplete things. Mostly things that need cross-project effort.14:38
dtantsurcompleting things is about discipline, not about management :)14:39
*** achanda has quit IRC14:39
TheJuliajroll: yeah, looking at what they are tyring to list as the user story now14:39
dtantsurnobody here can be explicitly told what to do by any wg. we can only be convinced, which is hopefully what these folks plan to do14:39
jrolldtantsur: yep14:39
thiagopdtantsur: I disagree with that, but it's a long out of context talk...14:39
dtantsurit might be different for us :)14:40
jrollI for one welcome the PWG, as we've struggled to get useful feedback from ops/users in the past14:40
dtantsurjroll++14:40
jrollthiagop: fwiw, this workgroup does not have any sort of method to make us do things or whatever, they're simply meant to feed in input from people outside of the dev community14:40
* jroll runs to a meeting14:40
TheJuliafwiw, some of what is on there is... just.. not possible short of laying down a thin hypervisor and calling it baremetal, which kind of defeats the prupose14:41
TheJuliaat least, not easilly with ease and performance14:41
jrollright :P14:41
thiagopjroll I well aware of it, but as dtantsur said, it's good to have an overview of what users might want14:41
jrollthere needs to be some education/syncup14:41
TheJuliaindeed14:41
jrollthiagop: yeah, totally, I welcome that :)14:41
* jroll wonders if we have summit session room for a "what do you need from ironic" thing14:42
dtantsurjroll, we used to have such sessions during the ops summit14:42
thiagopthey can indeed convince us (and nova, and cinder, and horizon) that some things need to be completely worked on to deliver value to OS users14:42
jrolldtantsur: right, and they weren't very useful14:42
dtantsurnot too much feedback unfortunately14:42
dtantsuryep, exactly this :)14:42
jrollhowever, folks want to meet up apparently http://lists.openstack.org/pipermail/product-wg/2016-April/001067.html14:42
jrollnot sure if worth a session though14:42
dtantsurhmm, I'd love these folks to involve us *before* they settle on user stories14:43
dtantsurI understand we can't provide them, but we can always say "well, that's barely possible"14:44
jrollyeah, there's a disconnect14:44
jrollI may go talk with them before summit14:44
dtantsur++14:44
TheJuliasounds like the best thing that we can do14:44
*** spandhe has joined #openstack-ironic14:45
thiagopI think that's what they want us to do reviewing these US's. Sanity check + align expectations from other vendors14:46
*** rebase has joined #openstack-ironic14:46
* thiagop tends to look at this with good eyes14:46
*** mgoddard has joined #openstack-ironic14:47
*** mgoddard_ has quit IRC14:47
*** b_bezak has quit IRC14:48
JayFHow does it work when things depend on ironic-lib? Like say I have a new widget in ironic-lib and I want to use it in an IPA patch; is setting depends-on enough to use the new ironic-lib code/14:50
JayFcc: alineb ^14:50
vdrokmorning NobodyCam and JayF :)14:50
JayFI'm 99.99% certain we install that from pip directly, don't we ;(14:50
TheJuliaJayF: afaik we do14:53
jrollJayF: yeah, we do install it from pip14:53
TheJuliaJayF: and as such, depends-on doesn't help :(14:53
JayFSo is there any trick to doing testing like that then? Assuming would probably have to be some kind of devstack patch in the mix14:53
jrollJayF: you can hack it to install from a given patchset, lemme find an example14:53
JayFperfect, thanks jroll14:53
*** mgould has quit IRC14:53
jrollI've thought about putting ironic-lib/client src tests in the experimental queue for this reason though14:53
jrollJayF: https://review.openstack.org/#/c/296432/24/devstack/lib/ironic14:54
jrollsomething like that in the chain14:54
JayFwell just annoying b/c who wants to write the lib, wait a week or two for it to merge, before then using it again14:54
jrollsure, I get it14:54
jrollalso a release in the middle14:55
jlvillalGood morning Ironic :)14:56
*** mgould has joined #openstack-ironic14:56
jrollJayF: feel free to propose a project-config patch to add the -src job to the experimental queue, if you'd prefer that route14:56
jrollthen it's just "check experimental" to change it14:56
JayFjroll: that's not actually going to work either14:56
jrolls/change/test/14:56
JayFjroll: for an *IPA* patch14:56
jrollwhy14:56
* jlvillal imagining jroll driving 65 MPH down the Interstate in the passenger seat while on IRC :)14:56
jrollJayF: ironic-lib -> ironic patch to adjust the source -> ipa patch14:57
JayFjroll: because IPA builds check out shit without any deference whatseover to upper-constraints or anything else14:57
thiagopgood morning jlvillal14:57
jrolljlvillal: I'm not on the road14:57
JayFjroll: ipa doesn't build out of devstack git dirs14:57
* TheJulia wonders who doesn't irc while going down the highway at 65mph in the passenger seat....14:57
jrollJayF: ooooo fun14:57
JayFyeah, exactly14:57
jrollJayF: git+https://git.o.o/openstack/ironic-lib@refs/....14:57
jrollin reqs.txt14:57
JayFyeah, that's whow I do it14:58
JayFwhere do you get the full ref link in new gerrit?14:58
dtantsurJayF, "download" link in the right corner14:58
*** derekh is now known as derekh_brb14:59
openstackgerritJay Faulkner proposed openstack/ironic: DoNotMerge: Use ironic-lib w/metrics for devstack  https://review.openstack.org/30174015:00
*** ametts has quit IRC15:00
openstackgerritJay Faulkner proposed openstack/ironic: DoNotMerge: Use ironic-lib w/metrics for devstack  https://review.openstack.org/30174015:01
*** mkoderer__ has quit IRC15:02
*** dtantsur is now known as dtantsur|brb15:03
JayFjroll: any idea how to build that link properly? clone https://git.openstack.org/openstack/ironic-lib + git checkout refs/changes/26/301256/1 throws an error15:06
*** pcaruana has quit IRC15:06
jrollJayF: origin/refs/...?15:06
jrollor as the download link says, git fetch ironic-lib refs/... && git checkout refs...15:06
*** derekh_brb is now known as derekh15:06
JayFit wants me to fetch via review.openstack15:07
JayFwith creds15:07
jrollJayF: alineb: we should probably configure devstack to use this stuff15:07
jrollwell15:07
jrollOH15:07
jrollyeah git.o.o probably won't have that15:07
jrollbut https://review.o.o should work anonymously15:07
jrollgit fetch https://git.openstack.org/openstack/ironic-lib refs/changes/26/301526/1 && git checkout FETCH_HEAD15:07
jrollshould work without creds15:07
*** garthb has joined #openstack-ironic15:08
JayFaha perfect15:08
jrollstraight from the download link :P15:08
jrollso that said15:08
jrollrequirements.txt: git+https://git.openstack.org/openstack/ironic-lib@refs/changes/26/301526/1 should work for IPA15:09
jrollI've gotta bounce for now, movers coming soon15:09
jrollmay or may not be back this afternoon, if not have a good day y'all15:09
JayFjroll: that does not appear to work locally15:10
NobodyCamdrave safe jroll15:10
JayFjroll: I can'15:10
JayFI can't clone that then checkout that branch15:10
NobodyCamdrive even15:10
sambettsthe problem is with gerrit that 'branch' doesn't really exist15:10
jrollJayF: clone, then fetch, then checkout15:11
jrolllike15:11
jrollin an existing clone: run the git fetch ... && git checkout15:11
sambettsDoesn't work in requirements.txt though ;( I've hit that so many times15:12
jrolljust confirmed the fetch/checkout command works for me in an existing clone.15:12
*** ametts has joined #openstack-ironic15:13
*** links has joined #openstack-ironic15:14
*** ChubYann has joined #openstack-ironic15:15
openstackgerritJay Faulkner proposed openstack/ironic-python-agent: Add command metrics to IPA API  https://review.openstack.org/11998115:15
*** mkoderer__ has joined #openstack-ironic15:16
*** harshs has joined #openstack-ironic15:17
*** krtaylor has joined #openstack-ironic15:17
*** jaybeale has joined #openstack-ironic15:19
*** mdorman has joined #openstack-ironic15:23
openstackgerritSergii Turivnyi proposed openstack/python-ironicclient: Negative tests for testing actions with Chassis  https://review.openstack.org/30175715:24
*** links has quit IRC15:25
*** mkovacik has quit IRC15:26
openstackgerritJay Faulkner proposed openstack/ironic-python-agent: Add metrics support to IPA  https://review.openstack.org/11998115:30
*** alexpilotti has quit IRC15:34
JayF  Could not find a tag or branch 'refs/changes/26/301526/1', assuming commit.15:35
JayFerror: pathspec 'refs/changes/26/301526/1' did not match any file(s) known to git.15:35
JayFgiving that git path to ipa did /not/ work :(15:35
openstackgerritKyrylo Romanenko proposed openstack/python-ironicclient: Add tests for baremetal subcommands in openstackclient  https://review.openstack.org/30168715:35
sambettsJayF: are you still trying with requirements.txt?15:36
JayFyep15:37
JayFSo I can run tests sanely on the IPA metrics patch alineb and I are working on15:37
sambettsYeah gerrit doesn't work with requirements.txt because the gerrit ref isn't a "real" branch15:37
*** Marga_ has joined #openstack-ironic15:38
JayFThere's no way to make that ref fetchable from somewhere?15:38
*** Marga_ has quit IRC15:38
JayFUnless like, I push it to my own fork or something?15:38
*** Marga_ has joined #openstack-ironic15:38
*** Marga_ has quit IRC15:39
*** Marga_ has joined #openstack-ironic15:39
*** dtantsur|brb is now known as dtantsur15:39
sambettswhat I've done before is add the git.openstack.org for ironic-lib to the requirements.txt then once the .tox environment is setup doing (source .tox/toxenv/bin/activate && cd .tox/toxenv/src/ironic-lib && git fetch .... && git checkout FETCH_HEAD && pip install -e .)15:40
JayFyeah, I'm hoping for something more automated15:40
JayFlol15:40
JayFasking in -infra15:40
JayFyou can help by reviewing https://review.openstack.org/#/c/301526/ "{15:41
JayF:P15:41
TheJuliaseems like we need something that groks $ZUUL_REFS15:41
TheJuliaor is it ZUUL_CHANGES15:41
* TheJulia doesn't remember15:41
sambettsSounds like we need something like what I have in networking-cisco for neutron client and neutron15:42
sambettshttp://git.openstack.org/cgit/openstack/networking-cisco/tree/tools/tox_install.sh15:42
sambettsJayF: ^15:42
*** moshele has quit IRC15:42
sambettsexcept of course you can replace the logic with the right pip install + git fetch + pip install again logic15:43
sambettsand for it to work upstream and understand the zuul refs environment variables you need to use the zuul cloner application15:43
TheJuliazuul_cloner is supposed to stage everything on disk based on current state15:44
TheJuliaso basically pip install from /opt/git/blah/blah/blah15:44
*** moshele has joined #openstack-ironic15:44
TheJuliabut zuul cloner has to explicitly run the checkout15:45
*** daemontool has quit IRC15:45
TheJuliakrotscheck: are the npm jobs okay?15:50
krotscheckTheJulia: Eh?15:50
* krotscheck checks15:50
TheJuliajust noticed on two separate projects the jobs have failed in rather awesomely not good ways15:51
*** spandhe has quit IRC15:52
jlvillalJayF: Did you get it figured out?15:52
JayFjlvillal: tl;dr: the only Right(tm) way to do it is like jroll said, an experimental job that builds all the reqs from source15:52
jlvillalI don't think you can do the fetch from git.openstack.org. I thought it had to be from review.openstack.org. I could be wrong of course.15:52
jlvillalFor patches, that is.15:53
JayFjlvillal: I've heard 0 reports of anyone saying what I'm doing is possible, except jroll's suggestion which didn't work15:53
JayFso I'm open for additional suggestions, but for now I mostly have given up15:53
JayFthe Best Fix(tm) is to get https://review.openstack.org/#/c/301526/ reviewed, merged, and relased ASAP15:53
jlvillalJayF: Okay.15:53
JayFand I bet alineb would appreciate the reviews15:53
*** praneshp_ has joined #openstack-ironic15:54
krotscheckTheJulia: Looks like the registry is a bit borked at the moment.15:55
TheJuliakrotscheck: ok15:55
jlvillalJayF: alineb I posted some initial nits15:56
JayFjlvillal: your style nits ... if pep8 is passing I thought we didn't vote on style stuff?15:56
JayFjlvillal: sounds like pep is misconfigured in that repo though, if it's letting that stuff through15:56
jlvillalI don't believe so. flake8 doesn't know which libraries are built-in, 3rd party, or intree15:57
alinebjlvillal: thanks, i will change that15:57
JayFhm, okay. I've def gotten pep8 failures from that, but it seems like the sort of thing that'd be iffy in the gate15:58
JayFso they probably turned it off sometime ago and I just never noticed, lol15:58
jlvillalJayF: It will complain about sorting and spacing.15:58
JayFaha15:58
JayFthe sorting is what I've been ding'd for15:58
jlvillalalineb: JayF So when it says adding support for Metrics.15:58
jlvillalDoes it actually use metrics?15:58
JayFWhat do you mean, does it actually use metrics?15:58
jlvillalOr is it just adding metric support so that it can be used by projects15:59
JayFit's adding support to be used by IPA and Ironic15:59
jlvillalBasically if it was completely broken and merged would anything break?15:59
jlvillal:)15:59
JayFwe have the Ironic side patches incoming, and the IPA patch is up (but depends on an Ironic patch that's not up yet)15:59
JayFjlvillal: heh, no, nothing would break15:59
openstackgerritMerged openstack/ironic-inspector: Move unit tests to "unit" directory  https://review.openstack.org/30150716:00
*** harshs has quit IRC16:01
openstackgerritAline Bousquet proposed openstack/ironic-lib: Add support for metrics  https://review.openstack.org/30152616:01
alinebjlvillal: just submitted a new patch set16:01
openstackgerritJay Faulkner proposed openstack/ironic-python-agent: Add metrics support to IPA  https://review.openstack.org/11998116:01
JayFalineb: https://review.openstack.org/#/c/119981 I just W-1'd this one, as it depends on the Ironic patch to send over the configs ;)16:02
*** alexpilotti has joined #openstack-ironic16:03
openstackgerritDmitry Tantsur proposed openstack/ironic-python-agent: [WIP] Wait for the interfaces to get IP addresses before inspection  https://review.openstack.org/30054816:04
JayFdtantsur: ^ you willing to consider an alternative approach to that?16:04
dtantsureasily :)16:04
JayFdtantsur: we have downstream code that waits in coreos to start IPA until the network is up16:04
JayFdtantsur: but I guess that wouldn't support the other images, so is probably not good enough for you16:05
dtantsurJayF, coreos image doesn't have this problem afaik :) so it's more about weird DIB DHCP magic...16:05
JayFwell, CoreOS image has systemd. If IPA dies coming up b/c no network, it just relaunches it 30s later :)16:05
JayFbut IDK if it even dies on startup in the inspectino case16:05
JayFin the provisioning-agent case, if it starts with no network and can't lookup, it does16:06
dtantsurJayF, now, it does not, it fails the inspection16:06
dtantsurthat's the problem here16:06
JayFah16:06
sambettsJayF: theoretically the systemd service file we define for the DIB image for IPA should prevent it from starting before the network is ready for it, however the dhcp-all-interfaces element means that the network ready target isn't reliable16:07
dtantsuryep :(16:07
JayFwell the prbolem is16:07
JayFwhen dhcping16:07
JayFsystemd reports network-online.target when dhcp client daemon is /started/16:07
JayFnot when it gets a lease16:07
dtantsurdaaaaaaaamn16:07
* dtantsur didn't know that16:08
JayFI spent like a week with a CoreOS dev working on getting the OnMetal image for CoreOS working, back before we launched originally16:08
JayFlearned lots of black magic about systemd then16:08
sambettswell we need this logic anyways then I guess16:08
JayFdtantsur: I see it's WIP'd, you want a review anyway?16:08
JayFif not now, lmk when you do and I will :)16:09
dtantsurJayF, yes please. it's wip because of missing unit tests for one part16:09
dtantsurthe code itself should be ready16:09
JayFWhy did you decide to make wait_for_ip_addresses a HWM method?16:10
openstackgerritMerged openstack/bifrost: Explicitly set language for DIB builds  https://review.openstack.org/29878416:10
dtantsurJayF, instead of...?16:10
openstackgerritMerged openstack/bifrost: Fix DIB conditionals for CLI override  https://review.openstack.org/29878516:10
JayFwell, things in hardwaremanager are generally for thigns other folks would want to change16:10
JayFimo at least16:10
dtantsurpreviously it was in inspector.py and someone asked it to be more generic16:10
JayFwell, I was thinking more like utils.py16:10
dtantsurI think jroll said he like it16:10
JayFand make the whole damn IPA block on has_carrier, since it's a provisioning agent problem too16:11
dtantsurJayF, utils.py does not depends on hardware.py (actually, the opposite)16:11
dtantsuranyway, feel free to leave a review16:11
JayFIt's fine to be in the hwm, but you'll have to refactor it a little16:11
JayFI'll commentin the patch16:11
dtantsursure, will fix (tomorrow, I guess)16:11
JayFdtantsur: put those comments on for ya16:13
*** moshele has quit IRC16:13
*** jcoufal has quit IRC16:17
jlvillalalineb: I left a few more comments.16:17
*** derekh has quit IRC16:19
*** jayc has quit IRC16:20
mat128anyone down for a review of https://review.openstack.org/#/c/264767/ ?16:28
*** spandhe has joined #openstack-ironic16:28
alinebjlvillal: thanks! i will look at them16:29
* sambetts is calling it a day 16:29
sambettsSee everyone tomorrow!16:29
*** sambetts is now known as sambetts|afk16:29
JayFmat128: landing it16:29
JayFmat128: ty for the patch16:29
mat128:D16:29
sambetts|afk:d16:29
sambetts|afk:D16:29
mat128Built a black box test downstream to prove resolution works, still need to find a way to contribute this back16:30
mat128Where would you place such a test?16:30
mat128It launches qemu with the kernel and ramdisk16:30
JayFI mean, that's essentailly what devstack does16:30
JayFjust you did it with a need for dns resolution16:30
JayFwhereas devstack plays in all IPs16:30
JayFI'm not sure something environmental like this is the best place for a test -- like for instance, we still have 2 other ramdisks (tinyipa, dib) that may still or may not still have this problem16:31
mat128tinyipa works oob16:31
mat128found that out because it instantly passed my test16:31
mat128do we have tests in devstack around the ipa images themselves?16:31
JayFWe have a couple, I can show you16:31
*** jayc has joined #openstack-ironic16:32
mag009_hey guys16:32
*** piet has joined #openstack-ironic16:33
JayFmat128: I can't find it, but the thing to look for is -src on ajob in an ipa review16:33
mat128ok, I'll find it16:33
mat128thanks for your help16:33
JayFmat128: those -src jobs build a new ramdisk from source as part of the test. Today gates all run with the CoreOS image, but we have that tinyipa image about to take it over in the gate16:33
mat128brb 30m16:33
JayFfor obvious reasons (it's tiny, lol)16:33
mat128yeah16:33
mat128are we building it with BUILD_AND_INSTALL_TINYIPA on?16:34
mat128(makes it even smaller)16:34
JayFthe tinyipa + src job does16:34
JayFwhich is non voting today16:34
*** mat128 is now known as mat128|afk16:35
mat128|afkok, I'll look around the jobs and the tests we have and try to submit a review for something similar to what I did here :)16:36
JayFI mean, you can, but I'm telling you I'm not sure that's a case we care deeply enough about to have a specific job for :)16:36
openstackgerritRamamani Yeleswarapu proposed openstack/ironic: Centralize config options - [database]  https://review.openstack.org/30181516:37
*** suro-patz has joined #openstack-ironic16:38
*** Nisha_away has joined #openstack-ironic16:41
*** trown is now known as trown|lunch16:43
*** jayc has quit IRC16:44
*** wendar_ is now known as wendar16:45
*** mbound has quit IRC16:48
openstackgerritVladyslav Drok proposed openstack/ironic: Add user and project domains to ironic context  https://review.openstack.org/29537116:50
openstackgerritVladyslav Drok proposed openstack/ironic: Use get_admin_context() to create the context object  https://review.openstack.org/24603616:50
*** jayc has joined #openstack-ironic16:56
*** ifarkas has quit IRC17:00
openstackgerritRamamani Yeleswarapu proposed openstack/ironic: Centralize config options - [dhcp]  https://review.openstack.org/30183017:08
*** alexpilotti has quit IRC17:09
dtantsurJayF, thanks!17:13
*** harshs has joined #openstack-ironic17:16
dtantsurJayF, utils.py won't work, as it will create a mutual dependency between hardware.py and utils.py. I can put it to hardware.py as a function, wdyt?17:16
JayFLet me put it this way:17:17
JayFI care less about the filesystem location17:17
JayFand more about it being either being done "right" in the hardware manager (i.e. with a stub on HardwareManager + the real implementaiton on GHM) or it being out of the hardware manager classes altogether17:17
JayFdtantsur: actally found something else, going to comment17:18
JayFdtantsur: tl;dr you wait on all interfaces, is that intended vs just waiting for a single IP?17:18
dtantsurJayF, yes! cause we never know which interface we really need17:18
dtantsurthat's the tricky part of this whole patch17:19
JayFdtantsur: Hmm. In our case, we have 2 interfaces, 1 will never dhcp17:19
dtantsurand that's why I was somewhat unsure about doing it unconditionally on start up17:19
dtantsurJayF, I understand it, that's the price to pay for not knowing anything before inspection...17:19
JayFmaybe make it an option on the method? On every boot, you could look for any IP17:19
JayFfor inspection17:20
dtantsurJayF, sorry, I don't quite get it.. what should be optional?17:20
JayFand for startup, look for any ip at all17:20
JayFHmm. This is interesting, right17:20
JayFso here's my question:17:20
JayFIs your use case "my agent need to have eth0 and eth1 up because eth0 goes to ironic and eth1 goes to swift" or something similar17:21
*** mgould has quit IRC17:21
*** morgan is now known as notnotmyname17:21
*** notnotmyname is now known as morgan17:21
JayFor is it "I want all possible IPs up so that the inspector returns the maximum amount of valid information"17:21
mat128|afkFrom our previous discussions, it's the latter17:21
dtantsurJayF, the latter17:21
*** mat128|afk is now known as mat12817:21
JayFso what I'm saying is17:22
*** Marga_ has quit IRC17:22
JayFyou can add an option to wait_for_ip_addresses17:22
JayFthat either waits for ANY ip17:22
JayFor waits for ALL potential ips17:22
JayFand make IPA wait on startup for ANY ip if in provisioning mode17:22
dtantsurJayF, what's the use case for waiting for any IP?17:22
dtantsurah17:22
JayFand make inspector wait for all17:22
dtantsurJayF, well, we already wait for a route to ironic, isn't it enough?17:22
dtantsur(I mean, for generic case)17:22
JayFI think you just exposed a knowledge gap I gained from not working upstream enough17:23
JayFbecause I didn't know that existed, lol17:23
JayFnevermind me then! Wheee... :(17:23
dtantsurJayF, I mean this: https://github.com/openstack/ironic-python-agent/commit/6829d34c150fa1cd41064786e76d41dfccef3ef317:23
dtantsurit has a retry logic17:24
JayFYep, and I didn't know/remember that existed17:24
JayFwhich completely handles any case I was worrying about17:24
openstackgerritMerged openstack/ironic-python-agent: Provide /etc/resolv.conf to chroot  https://review.openstack.org/26476717:24
dtantsurit's a recent thing, nevermind :)17:24
dtantsurso17:24
*** jistr has quit IRC17:24
dtantsurJayF, I think I'll just move the function back to inspector.py.. objections?17:25
*** moshele has joined #openstack-ironic17:25
JayFnone17:25
JayFI just think of HardwareManager as kinda a driver interface17:25
* dtantsur hacks17:25
JayFso if you put things in there I might push back if they aren't something folks would want to plug in their own implementation of :)17:25
*** arturas has joined #openstack-ironic17:28
JayFTheJulia: around? wanted to talk about https://review.openstack.org/#/c/270902 since it's basically done except for me and you disagreeing over the default :)17:36
*** davidlenwell has quit IRC17:42
mat128JayF: would it be acceptable for you to default to not erase drives at all or just not using shred by default?17:45
JayFI put my comment in the gerrit; basically I'm against defaulting to fallback to shred IF the drive supports ATA erase17:45
JayFbecause the tenant can perform actions (like a security lock via hdparm) that the deployer could be 100% unaware of17:45
JayFand cause the machine to shred everytime, without so much as the deployer even knowing17:46
mat128so if we rephrase it, if a drive supports ATA erase and is unlocked, use that without any fallback17:46
mat128if it doesnt, dont even bother and use other means?17:46
JayFLet me state it this way:17:46
JayFA deployer should have to explicitly opt-in to having SHRED run on a disk that supports instant secure erase.17:47
mat128Ooh17:47
JayFThat patch, as it is, makes it where the deployer has to opt-out17:47
mat128yes17:47
JayFand given it's a scenario that a tenant can cause -- even a non-malicious tenant -- it's important to have a safe default17:47
*** garthb has quit IRC17:47
JayFand shredding ssds is not safe, it's like shredding dollar bills in terms of what it does to the life of the drive17:47
mat128agreed17:48
mat128so opt-in to the unsafe (wrt the drive) behavior17:48
mat128but safer from a data leak perspective17:48
JayFI had some drives in production that advertised ISE but just did a shred under the hood. Hence my passion about this specific problem :P17:48
JayFI think it should go to clean failed in that case17:48
mat128we've had problems getting the drive to unlock, having to request custom BIOSes all the time17:48
JayFwhich is what it does today17:48
JayFmat128: same, we have custom firmwares for our drives / bios that prevents locking the drive unless you know the right tool/password/etc17:49
*** davidlenwell has joined #openstack-ironic17:49
mat128JayF: that would be a dream here :)17:49
JayFheh, I mean, you probably don't run a public bare metal cloud.17:50
mat128ordering a custom bios meant we probably lost bios upgrades in the future, and we had to request those for the plethora of different boards we have to support :(17:50
JayFFor us things like that are must-haves not nice-to-haves17:50
mat128fyi: http://www.internap.com/bare-metal/17:50
mat128we just end up shredding dollar bills, to use that analogy :(17:51
JayFwelcome to the public ironic cloud club17:52
JayFI would wish you luck, but, I like getting paid too :P17:52
JayFmay the person who commits the most upstream win, lol17:52
mat128been a while now, but thanks :)17:52
mat128it's all about upstream work IMO17:52
JayFhow long have you all been using Ironic with that?17:52
*** moshele has quit IRC17:53
*** Marga_ has joined #openstack-ironic17:53
*** mkovacik has joined #openstack-ironic17:54
mat128we launched a beta during the Vancouver summit (iirc may 2015), full launch october 201517:54
JayFDo you all have network switching support implemented downstream as well?17:55
mat128yup17:55
mat128we currently support both flat and lacp17:55
mat128network attach/detach17:55
JayFAh, do you not share Ironic installations across tenants?17:56
mat128what do you mean by Ironic installations?17:56
mat128instances of Ironic?17:56
*** arturas has quit IRC17:59
mat128JayF: we run one ironic installation per region18:00
JayFwas just curious how you had multiple customers on the same ironic install w/flat network18:00
mat128each tenant has their own networks18:00
*** Mr_T has joined #openstack-ironic18:01
JayFHm, okay.18:01
mat128my bad, must be the "flat" that confused you18:01
mat128by flat network model I mean WAN on one NIC, LAN on the other18:01
JayFYeah, so you probably have a similar downstream patch to us18:01
JayFto make the networks flip on provision/deprovision18:01
mat128yeah, essentially18:02
mat128now with the latest reviews coming in, we will be able to simply extend that to do what we want and remove part of our downstream patches18:02
*** trown|lunch is now known as trown18:02
*** ohamada has quit IRC18:03
JayFYep, same here. The upstream support, once the remaining patches get merged, we should be able to switch over to that18:03
*** mgoddard_ has joined #openstack-ironic18:03
*** arturas has joined #openstack-ironic18:04
JayFmat128: back to the original issue at hand; to be crystal clear: IMO inability to ISE a drive that supports it should default cleanfail, but I'm OK with it optionally shredding and continuing. I'd never +1 and probably would -2 a patch that would skip erasing the drives altogether if it couldn't ISE :)18:04
mat128JayF: I'm fine with that behavior, would +118:05
mat128Maybe we can summarize this for TheJulia in the review?18:05
JayFI think I did, and we've talked about it in IRC before as well :)18:06
JayFthe thing is, before her most recent patchset, IPA could do this to itself18:06
JayFlock the drive because the first step of the ISE (locking the drive) would work, but the second step (erasing it) failed for $reasons18:06
JayFbut now IPA tries to unlock it itself if it's locked, which makes sense18:07
TheJuliaJayF: w/r/t https://review.openstack.org/#/c/270902, you want default disabled? which would actually be the same behavior now right?18:07
*** mgoddard has quit IRC18:07
JayFTheJulia: yep, exactly18:07
TheJuliaJayF: honestly, I think the only thing that would really be left is to wire an info pass-through from the configuration to allow operators to toggle it, I guess18:07
openstackgerritDmitry Tantsur proposed openstack/ironic-python-agent: Wait for the interfaces to get IP addresses before inspection  https://review.openstack.org/30054818:07
JayFTheJulia: and mat128 and I have been talking about this for like 30m or so :)18:07
dtantsurJayF, this should be it ^^^18:07
TheJuliaJayF: sorry for the delay, been on a call for a while18:07
JayFTheJulia: nbd, yeah and I agree re: config passthrough18:08
JayFTheJulia: in fact, we're using a pattern kinda like that for metrics18:08
JayFTheJulia: on lookup, conductor ships back some configs to the agent, agent applies it and uses it for metrics18:08
dtantsurand as my internet provider hates me, I have to call it a day (hopefully nobody pinged me while my connection was dropping)18:08
JayFTheJulia: you could probably use the same pattern if you wanted18:08
TheJuliaJayF: okay, works for me18:08
*** dtantsur is now known as dtantsur|afk18:08
mat128dtantsur|afk: didnt see anything18:09
*** keedya has joined #openstack-ironic18:09
keedyaHi All 0/18:09
*** Nisha_brb has joined #openstack-ironic18:09
mat128TheJulia: ping me once your changes are in18:10
*** e0ne has quit IRC18:10
JayFalineb: I'm going to upstream the ironic metrics patch today so I can show that pattern to TheJulia, but feel free to update it if it has comments and I'm not around18:10
TheJuliamat128: w/r/t what I was just talking to jayf about?18:10
TheJuliasorry, too much context switching :)18:10
keedya@here how can I enable nde_not_found hook in inspector?18:10
mat128TheJulia: yes, JayF and I were talking about it while you were away18:11
mat128seems like all of us agree now18:11
JayFmat128: you can add yourself as a reviewer, just hit "Add..." beside reviewers, and you'll get an email when it updates18:11
TheJuliaahh, cool18:11
mat128JayF: good idea18:11
mat128thx18:11
mat128Just noticed I already am :)18:11
JayFheh, perfect18:11
TheJuliamat128: likely will be one of the things I do first thing in the morning, or later tonight if I my signifigant other lets me have more coffee :)18:11
openstackgerritNisha Agarwal proposed openstack/ironic: Add support for building ISO for deploy ramdisk  https://review.openstack.org/26459018:12
*** Nisha_away has quit IRC18:13
*** Sukhdev has joined #openstack-ironic18:13
openstackgerritRamamani Yeleswarapu proposed openstack/ironic: Centralize config options - [iboot]  https://review.openstack.org/30185618:13
keedyaiS example plugin in Ironic-inspector enabled by default?18:14
*** Nisha_away has joined #openstack-ironic18:16
*** Nisha_brb has quit IRC18:19
*** piet has quit IRC18:21
keedyanvm got it!!18:23
*** piet has joined #openstack-ironic18:27
*** arturas has quit IRC18:30
*** Sukhdev has quit IRC18:31
*** rebase has quit IRC18:40
*** rcernin has quit IRC18:41
*** rebase has joined #openstack-ironic18:41
*** e0ne has joined #openstack-ironic18:55
openstackgerritAndre Aranha proposed openstack/python-oneviewclient: Add connections to Server Profile  https://review.openstack.org/29957918:58
*** jaybeale has quit IRC19:03
*** alexpilotti has joined #openstack-ironic19:04
*** e0ne has quit IRC19:05
*** alexpilotti has quit IRC19:05
*** Sukhdev has joined #openstack-ironic19:06
*** mgoddard_ has quit IRC19:10
*** ametts has quit IRC19:17
*** e0ne has joined #openstack-ironic19:18
openstackgerritJulia Kreger proposed openstack/ironic: Follow-up to I244c3f31d0ad26194887cfb9b79f96b5111296c6  https://review.openstack.org/30187619:26
openstackgerritAndre Aranha proposed openstack/python-oneviewclient: Added functions to translate between uuid and uri  https://review.openstack.org/30187719:30
*** alexpilotti has joined #openstack-ironic19:31
*** ametts has joined #openstack-ironic19:31
*** Goneri has quit IRC19:35
*** e0ne has quit IRC19:35
*** alexpilotti has quit IRC19:36
openstackgerritMerged openstack/ironic-lib: Clean up test-requirements  https://review.openstack.org/28929419:37
*** Nisha_away has quit IRC19:41
openstackgerritVasyl Saienko proposed openstack/ironic: Allow to set neutron port timeout from config  https://review.openstack.org/29387619:44
openstackgerritMerged openstack/ironic: Updated from global requirements  https://review.openstack.org/30165719:45
openstackgerritMerged openstack/ironic: Don't power off non-deploying iLO nodes in takeover  https://review.openstack.org/29957319:46
openstackgerritMarcellin Fom Tchassem proposed openstack/ironic-inspector: Make tox respect upper-constraints.txt  https://review.openstack.org/30170019:49
*** jaybeale has joined #openstack-ironic19:49
*** Goneri has joined #openstack-ironic19:55
*** dprince has quit IRC19:57
*** MattMan has joined #openstack-ironic20:05
*** MattMan has quit IRC20:08
*** MattMan has joined #openstack-ironic20:12
openstackgerritAndre Aranha proposed openstack/python-oneviewclient: Refactor of unit Tests  https://review.openstack.org/30189520:15
*** Sukhdev has quit IRC20:25
JayFSo have a general question re: metrics spec. http://specs.openstack.org/openstack/ironic-specs/specs/not-implemented/add-pluggable-metrics-backend-for-ironic-and-ipa.html20:28
JayFwe have that currently setup that all the metrics config is under [metrics], including IPA-specific metrics20:28
*** moshele has joined #openstack-ironic20:28
JayFIf we do it that way, that means all those config vars shuold be declared in ironic-lib, right?20:28
*** david-lyle_ has joined #openstack-ironic20:28
JayFAnd I was toying with the idea that maybe the agent metrics configs should be under [agent], but I think I've convinced myself against that since more than just agent deploy driver can use agents + metrics20:29
*** david-lyle has quit IRC20:29
*** david-lyle_ is now known as david-lyle20:29
*** rolfb_ has joined #openstack-ironic20:32
TheJuliaJayF: I can agree with everything you've stated, and I think I'm starting to get a headache20:34
TheJuliaI think the question really shouldn't be agent deploy driver as much as it is use of the agent in general, and the deployment method used, since we're trying to get rid of the bash ramdisk, eventually....20:35
JayFyep20:36
*** moshele has quit IRC20:36
*** Sukhdev has joined #openstack-ironic20:36
TheJuliaJayF: then the headache begins to set in, and yoda saying something about paint and corners20:37
JayFgo lie down if you've got that bad of a headache :/20:37
TheJulia:)20:38
openstackgerritJulia Kreger proposed openstack/ironic: Active Node Creation via adopt state  https://review.openstack.org/27576620:45
openstackgerritThiago Paiva Brito proposed openstack/python-oneviewclient: OneView client with managers  https://review.openstack.org/28680320:47
*** Goneri has quit IRC20:48
*** rolfb_ has quit IRC20:48
*** rolfb_ has joined #openstack-ironic20:48
*** baoli_ has quit IRC20:51
*** karimb has quit IRC20:51
mrdaMorning Ironic20:53
*** raildo is now known as raildo-afk20:54
*** trown is now known as trown|outtypewww20:59
*** rolfb_ has quit IRC21:03
*** rolfb_ has joined #openstack-ironic21:04
openstackgerritJay Faulkner proposed openstack/ironic: Pass agent metrics config via conductor  https://review.openstack.org/30191921:06
*** rcrit has joined #openstack-ironic21:07
openstackgerritJay Faulkner proposed openstack/ironic: Pass agent metrics config via conductor  https://review.openstack.org/30191921:07
rcritI'm trying to trace how ssh keys are injected into instances. I can see where it is done in libvirt. In ironic does a key get into /root/.ssh directly or only via the config drive?21:09
JayFOnly via the configdrive / metadata service.21:11
rcritok thanks, I didn't want to assume21:12
JayFno problem, smart move :)21:12
openstackgerritJay Faulkner proposed openstack/ironic: Metric chassis, driver, node, and port API calls  https://review.openstack.org/30192321:13
JayFpeople who assume get instances without ssh keys21:13
JayFlol21:13
rcritheh21:13
rcritJayF, so followup. Does the image need to do anything special to mount the config drive and access the keys?21:13
* rcrit is fine with RTFM21:13
JayFwell in that case ...21:13
JayFgoogle://cloud-init21:13
JayF:P21:14
rcritheh21:14
JayFMost people use cloud-init to provision instances21:14
rcritsure ok21:14
JayFthere are newer things which do less, and I think infra uses it21:14
JayFbut I don't recall the name of it21:14
rcritso nothing special is needed inside the image, I can use same image for both h/w and virt, that's what I was going for21:14
*** rbrud has quit IRC21:14
rcritjsut cloud-init would be different to mount the drive and pull out what is needed21:14
JayFoh yeah absolutely21:14
*** rbrud has joined #openstack-ironic21:14
JayFconfigdrive layout is an api21:15
JayFsame with metadata service21:15
*** jaypipes has quit IRC21:15
JayFand it's date-versioned and such as well21:15
rcrityeah, I've seen those21:15
JayFIronic doesn't even build the configdrive; nova does21:15
rcritbut libvirt, for example, automagically sticks the key into authorized_keys21:15
JayFoh yeah, no craziness like that here. In fact if you use whole disk images, we never even mount your FS21:15
rcritok21:15
* JayF just got confirmation from $bosspeoples that he's dedicated to upstream Ironic, at least until I'm not21:16
*** rbrud has quit IRC21:16
JayF\o/21:16
*** rolfb_ is now known as rbrud21:16
rcritwoo?21:16
JayFI'm quite thrilled about it :)21:16
*** rolfb_ has joined #openstack-ironic21:17
cineramayay JayF21:17
*** piet has quit IRC21:17
*** cppforlife_ has quit IRC21:19
*** alexpilotti has joined #openstack-ironic21:19
*** baoli has joined #openstack-ironic21:21
*** cppforlife_ has joined #openstack-ironic21:21
*** baoli_ has joined #openstack-ironic21:23
*** alexpilotti has quit IRC21:23
openstackgerritChris Krelle proposed openstack/ironic: Add support for the audit middleware  https://review.openstack.org/27265821:26
*** baoli has quit IRC21:27
NobodyCamJayF: awesome21:27
NobodyCamwant to see if I addressed you concerns on ^^^^21:27
NobodyCamlol21:27
* NobodyCam *ducks*21:27
JayFI had a vote on that?21:28
* JayF looks suspiciously at NobodyCam21:28
JayFNobodyCam: you know my vote in ironic-proper won't get you anywhere :P21:28
NobodyCam-1 Jay Faulkner21:28
NobodyCamlol21:28
*** rbrud has quit IRC21:30
*** rbrud has joined #openstack-ironic21:31
*** keedya has quit IRC21:33
JayFNobodyCam: +1'd21:34
NobodyCamw00t :) lol tuff part was getting past the pep8 tests21:35
JayFI looked to try and solicit a payback review from you, but everything up that I care about is already -1'd for something21:35
JayFlol21:35
NobodyCamlol... I'm sure I owd you at least one drink at summit21:36
NobodyCamowe even21:36
JayFhah, I'll take reviews over drinks21:36
JayFI can buy my own drinks, I can't buy reviews :P21:36
NobodyCamlol21:36
JayF...or can I?21:36
NobodyCamlol21:38
openstackgerritJay Faulkner proposed openstack/ironic-python-agent: Add metrics support to IPA  https://review.openstack.org/11998121:39
rcritfunny, I work on a different IPA21:41
JayFI mean, our acronym was even overloaded by our own company once IPA as Ironic Python Agent was a thing21:41
JayF /topic for an internal channel says something like "IPA will always mean beer and the agent"21:41
rcritit is also an identity management server21:42
NobodyCamsee and I thought IPA stood for: International Phonetic Alphabet21:43
* rcrit prefers the beer21:43
NobodyCam:)21:44
* NobodyCam steps afk for a bit21:44
openstackgerritJay Faulkner proposed openstack/ironic: Metric chassis, driver, node, and port API calls  https://review.openstack.org/30192321:45
*** hparekh has quit IRC21:48
*** adreznec has quit IRC21:48
*** hparekh has joined #openstack-ironic21:52
*** adreznec has joined #openstack-ironic21:52
*** rebase_ has joined #openstack-ironic21:54
*** harshs has quit IRC21:55
*** harshs has joined #openstack-ironic21:56
*** rebase has quit IRC21:57
*** harshs has quit IRC21:58
*** harshs has joined #openstack-ironic21:59
*** harshs has quit IRC22:00
*** ndipanov has quit IRC22:05
openstackgerritRamamani Yeleswarapu proposed openstack/ironic: Centralize config options - [ilo]  https://review.openstack.org/30194722:10
*** rebase_ has quit IRC22:21
*** baoli_ has quit IRC22:22
*** rebase has joined #openstack-ironic22:22
JayFDeva suggested on one of my patches that I use a modulevar for a deprecation message so that it only prints once per call. Any idea where I can find an example of this pattern?22:23
JayFI think I got it, but we'll see what folks think about it on review :)22:35
devanandaJayF: ironic/db/api.py22:36
JayFI don't see anything like that in there22:36
JayFhttps://gist.github.com/jayofdoom/2f40498b78e158281aa3f8514091e7f5 is what I did22:37
*** saripurigopi has joined #openstack-ironic22:37
JayFbut it certainly seems clunky so I'm welcome to better suggestions22:37
*** cdearborn has quit IRC22:37
openstackgerritRamamani Yeleswarapu proposed openstack/ironic: Centralize config options - [inspector]  https://review.openstack.org/30195522:38
JayFI will make that bool an array of drivers that I've printed the warning for22:40
openstackgerritMario Villaplana proposed openstack/ironic: [WIP] Add notification base and example to ironic  https://review.openstack.org/29846122:54
*** ametts has quit IRC22:58
*** jayc has quit IRC22:59
*** Sukhdev has quit IRC23:00
openstackgerritRamamani Yeleswarapu proposed openstack/ironic: Centralize config options - [ipmi]  https://review.openstack.org/30196723:12
*** mdorman has quit IRC23:14
*** Marga__ has joined #openstack-ironic23:15
*** Marga__ has quit IRC23:15
*** garthb has joined #openstack-ironic23:18
*** Marga_ has quit IRC23:18
*** Marga_ has joined #openstack-ironic23:25
*** Sukhdev has joined #openstack-ironic23:25
*** rebase has quit IRC23:25
*** Goneri has joined #openstack-ironic23:36
*** Marga_ has quit IRC23:37
*** Marga_ has joined #openstack-ironic23:44
*** davideagnello has quit IRC23:46
*** Marga_ has quit IRC23:46
*** Marga_ has joined #openstack-ironic23:46
*** Marga_ has quit IRC23:50
*** Marga_ has joined #openstack-ironic23:51
*** Marga_ has quit IRC23:56
*** smoriya_ has joined #openstack-ironic23:58

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!