Tuesday, 2016-03-15

*** davideagnello has quit IRC00:02
*** Sukhdev has quit IRC00:05
*** Sukhdev has joined #openstack-ironic00:05
*** Sukhdev has quit IRC00:06
*** maurosr has joined #openstack-ironic00:07
*** Sukhdev has joined #openstack-ironic00:07
*** cdearborn has quit IRC00:13
*** zhuangl_ has joined #openstack-ironic00:14
*** davideagnello has joined #openstack-ironic00:14
*** zhuangl_ has quit IRC00:18
*** garthb_ has quit IRC00:22
*** dims has joined #openstack-ironic00:23
*** Marga__ has quit IRC00:27
*** Marga_ has joined #openstack-ironic00:28
*** mordred has quit IRC00:31
*** phschwartz has quit IRC00:31
*** phschwartz has joined #openstack-ironic00:32
*** dims has quit IRC00:32
*** mordred has joined #openstack-ironic00:32
*** buttercup_ has quit IRC00:33
*** rbrud_ has left #openstack-ironic00:43
*** rbrud_ has joined #openstack-ironic00:48
*** rbrud has quit IRC00:51
*** rbrud_ is now known as rbrud00:51
*** rbrud_ has joined #openstack-ironic00:52
*** rbrud has quit IRC00:53
*** rbrud_ is now known as rbrud00:53
*** dims has joined #openstack-ironic00:56
*** praneshp_ has quit IRC00:57
*** hoangcx has joined #openstack-ironic00:57
*** shu-mutou-AFK is now known as shu-mutou01:00
openstackgerritxiexs proposed openstack/python-ironicclient: Trivial: Fix incorrect comments in test_baremetal.py  https://review.openstack.org/29153301:12
*** rbrud_ has joined #openstack-ironic01:14
*** rloo has quit IRC01:14
*** suro-patz1 has quit IRC01:16
*** Sukhdev has quit IRC01:17
*** stendulker has joined #openstack-ironic01:17
*** buttercup_ has joined #openstack-ironic01:18
*** rbrud has quit IRC01:23
*** rbrud has joined #openstack-ironic01:23
*** rbrud_ has quit IRC01:23
*** yarkot_ has joined #openstack-ironic01:24
*** rolfb_ has joined #openstack-ironic01:25
*** chlong has quit IRC01:26
*** rolfb_ has quit IRC01:29
*** rolfb_ has joined #openstack-ironic01:31
*** rbrud has quit IRC01:32
*** rolfb_ is now known as rbrud01:32
*** rbrud_ has joined #openstack-ironic01:32
*** yarkot_ has quit IRC01:33
*** rbrud has quit IRC01:34
*** rbrud_ is now known as rbrud01:34
*** rolfb_ has joined #openstack-ironic01:34
*** rolfb_ has quit IRC01:35
*** harshs has quit IRC01:42
*** rolfb_ has joined #openstack-ironic01:44
*** rolfb_ is now known as help01:47
*** help is now known as Guest4528701:48
*** buttercup_ has quit IRC01:50
*** Guest45287 has quit IRC01:54
*** rolfb_ has joined #openstack-ironic01:55
*** rolfb_ has quit IRC01:56
*** rolfb_ has joined #openstack-ironic01:57
*** rolfb__ has joined #openstack-ironic01:57
*** rolfb__ has quit IRC01:57
*** rolfb_ has quit IRC01:57
*** rolfb_ has joined #openstack-ironic01:59
*** rolfb__ has joined #openstack-ironic01:59
*** rolfb_ has quit IRC01:59
*** rolfb_ has joined #openstack-ironic02:00
*** rbrud has quit IRC02:00
*** rolfb_ is now known as rbrud02:01
*** piet has joined #openstack-ironic02:01
*** rbrud_ has joined #openstack-ironic02:01
*** rbrud has quit IRC02:02
*** rbrud_ is now known as rbrud02:02
*** buttercup_ has joined #openstack-ironic02:04
*** piet has quit IRC02:06
*** piet has joined #openstack-ironic02:06
*** stendulker has quit IRC02:15
*** praneshp_ has joined #openstack-ironic02:19
openstackgerritjxiaobin proposed openstack/ironic: Pass region_name to SwiftAPI  https://review.openstack.org/29106302:24
*** buttercup_ has quit IRC02:27
openstackgerritxiexs proposed openstack/python-ironicclient: Trivial: Fix incorrect comments in test_baremetal.py  https://review.openstack.org/29153302:34
openstackgerritZhenguo Niu proposed openstack/ironic: Remove mock called of ironic-lib inner methods  https://review.openstack.org/28900802:34
*** dims has quit IRC02:38
*** buttercup_ has joined #openstack-ironic02:40
*** kan_ has joined #openstack-ironic02:46
*** jaybeale has quit IRC02:51
*** praneshp_ has quit IRC02:52
*** buttercup_ has quit IRC02:55
*** baoli_ has joined #openstack-ironic02:57
openstackgerritZhenguo Niu proposed openstack/ironic: Remove mock of not directly called ironic-lib methods  https://review.openstack.org/28900803:10
*** mtanino has quit IRC03:17
*** Haomeng|2 has joined #openstack-ironic03:20
*** yuanying has quit IRC03:22
openstackgerritZhenguo Niu proposed openstack/ironic: Add restrictions for changing portgroup-node association  https://review.openstack.org/28116903:22
*** kan_ has quit IRC03:23
*** Haomeng has quit IRC03:23
*** Haomeng has joined #openstack-ironic03:25
*** kan_ has joined #openstack-ironic03:25
*** Haomeng|2 has quit IRC03:28
*** chlong has joined #openstack-ironic03:30
*** stendulker has joined #openstack-ironic03:35
*** phuongnh has joined #openstack-ironic03:37
*** links has joined #openstack-ironic03:38
*** jaybeale has joined #openstack-ironic03:38
*** yuanying has joined #openstack-ironic03:38
*** shu-mutou is now known as shu-mutou-AFK03:43
*** aswadr_ has joined #openstack-ironic03:44
*** yuanying has quit IRC03:45
*** Marga_ has quit IRC03:59
*** Marga_ has joined #openstack-ironic04:00
*** Marga_ has quit IRC04:00
*** stendulker_ has joined #openstack-ironic04:04
*** stendulker has quit IRC04:04
*** keedya has quit IRC04:05
*** yuanying has joined #openstack-ironic04:06
*** stendulker has joined #openstack-ironic04:07
*** praneshp_ has joined #openstack-ironic04:10
*** stendulker_ has quit IRC04:10
*** stendulker_ has joined #openstack-ironic04:15
*** stendulker has quit IRC04:16
*** stendulker has joined #openstack-ironic04:16
*** amotoki has joined #openstack-ironic04:17
*** piet has quit IRC04:19
*** piet has joined #openstack-ironic04:19
*** stendulker_ has quit IRC04:20
*** Marga_ has joined #openstack-ironic04:21
*** Marga_ has quit IRC04:25
*** piet has quit IRC04:30
*** piet has joined #openstack-ironic04:31
*** Marga_ has joined #openstack-ironic04:33
*** Marga_ has quit IRC04:34
*** Marga_ has joined #openstack-ironic04:34
*** piet has quit IRC04:44
*** Sukhdev has joined #openstack-ironic04:45
*** baoli_ has quit IRC04:50
*** piet has joined #openstack-ironic04:53
*** vinm213 has joined #openstack-ironic05:08
*** appu103_ has joined #openstack-ironic05:13
*** kalpase has joined #openstack-ironic05:17
*** kalpase has quit IRC05:20
vinm213morning all05:20
*** amotoki has quit IRC05:21
vinm213A quick question05:21
zer0c00lyep05:21
vinm213When the node is in available state, in a multi-conductor environment if the active conducor fails, should the backup take care of the enrolled node?05:22
*** kalpase has joined #openstack-ironic05:23
vinm213any idea?05:26
*** linuxgeek has joined #openstack-ironic05:27
*** Haomeng has quit IRC05:27
*** Haomeng has joined #openstack-ironic05:27
*** amotoki has joined #openstack-ironic05:31
*** amotoki has quit IRC05:35
*** praneshp_ has quit IRC05:40
*** getvasanth has joined #openstack-ironic05:43
*** Sukhdev has quit IRC05:43
*** piet has quit IRC05:44
*** ChrisAusten has quit IRC05:45
*** amotoki has joined #openstack-ironic05:47
*** suro-patz has joined #openstack-ironic05:49
*** zzzeek has quit IRC05:49
*** ndipanov has quit IRC05:49
*** zzzeek has joined #openstack-ironic05:50
*** amotoki has quit IRC05:55
*** Nisha has joined #openstack-ironic06:07
*** hoangcx has quit IRC06:11
*** getvasanth_ has joined #openstack-ironic06:12
*** hoangcx has joined #openstack-ironic06:15
*** getvasanth has quit IRC06:16
*** ChubYann has quit IRC06:20
*** EntropyWorks has quit IRC06:35
*** ishant has joined #openstack-ironic06:41
openstackgerritVaishnavi proposed openstack/ironic: [IRONIC] Config variable to configure [glance] section  https://review.openstack.org/26680306:44
*** vaishnavi has joined #openstack-ironic06:46
*** jaybeale has quit IRC06:49
openstackgerritShivanand Tendulker proposed openstack/ironic-specs: EFI iSCSI boot for ProLiant hardware  https://review.openstack.org/20733707:00
*** baoli has joined #openstack-ironic07:02
*** suro-patz has quit IRC07:05
*** vishwana_ has joined #openstack-ironic07:07
*** baoli has quit IRC07:07
*** vishwanathj_away has quit IRC07:10
*** tesseract has joined #openstack-ironic07:13
*** tesseract is now known as Guest9751907:13
*** vishwana_ has quit IRC07:16
pas-hamorning Ironic07:17
*** vinm213 has quit IRC07:36
*** athomas has joined #openstack-ironic07:54
*** Guest97519 has quit IRC08:00
*** tesseract has joined #openstack-ironic08:05
*** tesseract is now known as Guest9179408:06
*** ohamada has joined #openstack-ironic08:19
openstackgerritVaishnavi proposed openstack/ironic: Add support for building ISO for deploy ramdisk  https://review.openstack.org/26459008:25
*** pece has joined #openstack-ironic08:28
*** chlong has quit IRC08:32
*** mannidi has joined #openstack-ironic08:37
*** Guest91794 has quit IRC08:45
*** ndipanov has joined #openstack-ironic08:47
*** mkovacik has joined #openstack-ironic08:49
*** _degorenko|afk is now known as degorenko08:54
*** mbound has joined #openstack-ironic08:56
*** e0ne has joined #openstack-ironic08:57
*** Guest91794 has joined #openstack-ironic09:00
*** phuongnh has quit IRC09:04
openstackgerritZhenguo Niu proposed openstack/ironic: Remove unneeded 'wait=False' to be more clean and consistent  https://review.openstack.org/29277009:07
*** vaishnavi has quit IRC09:07
*** vaishnavi has joined #openstack-ironic09:08
*** vinm213 has joined #openstack-ironic09:10
*** mkovacik has quit IRC09:18
*** jistr has joined #openstack-ironic09:20
*** deray has joined #openstack-ironic09:20
derayg'morning Ironicers!09:22
alinebmorning all!09:30
*** rcernin has joined #openstack-ironic09:31
*** lucas-dinner is now known as lucasagomes09:33
lucasagomesmorning all09:35
*** derekh has joined #openstack-ironic09:47
*** ishant_ has joined #openstack-ironic09:48
*** stendulker_ has joined #openstack-ironic09:48
*** ishant has quit IRC09:49
*** mgould has joined #openstack-ironic09:50
*** stendulker has quit IRC09:50
mgouldmorning Ironic!09:58
vinm213morning all10:02
*** Nisha has quit IRC10:02
lucasagomesmgould, vinm213 alineb pas-ha zer0c00l good morning10:03
lucasagomesvinm213, just saw ur question there... So, if the second conductor have the driver to control the node enabled10:03
lucasagomesyes it will take it over10:03
lucasagomesvinm213, the conductors have a heartbeat method where they write to the database to say they are alive10:04
vinm213good morning lucasagomes10:04
vinm213thanks10:04
lucasagomesif they die and the time expires. The hash ring will be rebalanced so all the requests to that node will now be forward to the 2nd conductor10:04
vinm213https://github.com/openstack/ironic/blob/master/ironic/conductor/manager.py#L1412-#L141710:06
vinm213But from the above it appears to be filtring the nodes based on their states10:06
*** e0ne has quit IRC10:08
vinm213i was trying to understand conductor failover and once i enrolled the node after adding the deploy, instance images i have terminated the active conductor10:08
vinm213But the backup conductor is not taking over10:08
*** e0ne has joined #openstack-ironic10:08
lucasagomesvinm213, yeah, because we just need to sync state when the nodes are active. By "state" we mean PXE configuration, DHCP configurtion etc10:09
vinm213How do i make sure, i have configured multi-conductor setup?10:09
lucasagomesvinm213, the conductor<->nodes when the node is not active doesn't have a hard bond, the hash ring is generated on the flight10:10
*** jcoufal has joined #openstack-ironic10:10
lucasagomesfly*10:10
lucasagomesvinm213, so you deployed the node and then you killed one of the conductors ? (the one marked in the reservation field of the node)10:11
vinm213ok..here is what i did10:11
vinm213on one conductor, set the hostname, and mysql address10:11
vinm213on the second conductor, changed the mysql, rabbitmq, ironic-api to point to the first one10:12
vinm213even the glance, swift and keystone url's10:12
vinm213and terminated ironic-api on the second conductor(as i have configured it to point to first one)10:13
vinm213ironic driver-list shows both conductors10:13
vinm213once enrolled the node and added relevent things i have terminated the active conductor10:14
*** mkovacik has joined #openstack-ironic10:14
vinm213Now it won't allow me to change any image_info saying "no conductor service is registered for the node"10:15
sambetts|afkMorning all10:15
*** sambetts|afk is now known as sambetts10:15
lucasagomesvinm213, both conductors have the same drivers enabled?10:15
vinm213yes.. they have... http://paste.openstack.org/show/490465/10:16
vinm213oh...ok10:17
mgouldlucasagomes sambetts vinm213 alineb pas-ha zer0c00l morning!10:17
lucasagomesvinm213, oh some drivers yes... what driver is the node using?10:17
sambettso/ mgould10:17
vinm213morning mgould10:17
lucasagomesmgould, good mroning10:17
lucasagomesvinm213, so pxe_ipmitool, fake and agent_ipmitool is enabled in only 1 of the conductors. Is the node using one of these drivers?10:18
*** mannidi_ has joined #openstack-ironic10:19
vinm213yes, lucas.. it's pxe_ipmitool that i am using..10:20
lucasagomesvinm213, so that explains it10:20
vinm213but i just changes it..let me verify it again10:20
*** mannidi_ has quit IRC10:20
vinm213thanks10:20
vinm213wil check it one more time10:20
lucasagomesvinm213, if you look at the hash ring code, you will see that we have a ring for each driver10:20
*** mannidi_ has joined #openstack-ironic10:21
lucasagomesvinm213, ok, lemme know if it works10:21
*** hoangcx has quit IRC10:21
*** electrofelix has joined #openstack-ironic10:21
vinm213ok, thanks lucas..will go throug the code and recheck that10:21
*** mannidi_ has quit IRC10:21
lucasagomesvinm213, np!10:21
*** mannidi has quit IRC10:23
*** athomas has quit IRC10:25
*** athomas has joined #openstack-ironic10:31
openstackgerritShivanand Tendulker proposed openstack/ironic-specs: Baremetal provisioning in UEFI secure boot mode  https://review.openstack.org/23027410:40
*** ishant_ has quit IRC10:44
*** moshele has joined #openstack-ironic10:47
lucasagomesJayF, fyi https://bugs.launchpad.net/ironic-python-agent/+bug/155745010:53
openstackLaunchpad bug 1557450 in ironic-python-agent "Replace SYSRQ commands" [Medium,New] - Assigned to Lucas Alvares Gomes (lucasagomes)10:53
*** vaishnavi has quit IRC10:55
sambettslucasagomes: Do you know how to fix a stuck target provision state in Ironic without having to manually mysql ??11:01
lucasagomessambetts, hmm it's in the middle of an action?11:01
*** stendulker has joined #openstack-ironic11:01
lucasagomessambetts, other I think you can restart the conductor, but you remember how did you get stuck there?11:01
lucasagomesit would be a serious bug :-/11:02
sambettslucasagomes: no, the node was in clean wait, and moved to managable, and the target provision state has stayed as avaliable11:02
lucasagomessambetts, hmm strange, so now you can't go from manageable to available?11:03
*** vaishnavi has joined #openstack-ironic11:03
sambettslucasagomes: I want to update the node, and I get the error, "Can't update node while state transistion in progress"11:03
lucasagomessambetts, :-( yeah seems like a bug then... I wonder how it moved from wait clean to manageable11:04
lucasagomessambetts, did you abort it first ?11:04
*** stendulker_ has quit IRC11:04
lucasagomescause "clean wait" -> "manageable" should not be a valid transition11:05
sambettsoooh, sorry it was clean failed to managable11:05
lucasagomessambetts, oh right11:06
lucasagomesok, so it should have cleaned the target I suspect, if not it's bug11:06
*** stendulker has quit IRC11:06
lucasagomessambetts, spawning one instance here, lemme try11:07
*** vaishnavi_r has joined #openstack-ironic11:09
vinm213lucasagomes, yes it works. I have retested it. So no issues :)11:09
lucasagomesvinm213, cool, good to know!11:10
lucasagomesthanks for trying11:10
*** vaishnavi_r has quit IRC11:10
*** thrash|g0ne is now known as thrash11:11
*** vaishnavi_r has joined #openstack-ironic11:11
*** vaishnavi has quit IRC11:11
*** dims has joined #openstack-ironic11:12
*** kan_ has quit IRC11:12
-openstackstatus- NOTICE: Gerrit is going to be restarted11:13
*** dims has quit IRC11:20
openstackgerritLucas Alvares Gomes proposed openstack/ironic-python-agent: Replace SYSRQ commands  https://review.openstack.org/29282811:21
*** dims has joined #openstack-ironic11:21
*** dims has quit IRC11:21
*** dims has joined #openstack-ironic11:21
*** kalpase has quit IRC11:22
lucasagomessambetts, :-(11:23
lucasagomessambetts, I can confirm ur findings I will file a bug about it (/me got the logs handy here)11:23
TheJuliagood morning11:29
*** smoriya_ has quit IRC11:29
lucasagomessambetts, although I can move it from manageable back to available by calling set-provision-state with "provide"11:29
lucasagomesTheJulia, hello there, good morning11:30
sambettslucasagomes: but if cleaning is failed because I need to update the node, then I can never update the node11:32
sambettso/ TheJulia11:32
lucasagomessambetts, yeah11:32
lucasagomesfilling a bug about it11:32
sambettslucasagomes: great :D thanks, glad to know I'm not going insane11:33
-openstackstatus- NOTICE: Gerrit had to be restarted because was not responsive. As a consequence, some of the test results have been lost, from 08:30 UTC to 10:30 UTC approximately. Please recheck any affected jobs by this problem.11:33
lucasagomessambetts, not at all!11:33
openstackgerritDebayan Ray proposed openstack/ironic: Add 'GET /nodes/<node>/cleaning/steps' API request  https://review.openstack.org/27856611:35
-openstackstatus- NOTICE: Gerrit had to be restarted because was not responsive. As a consequence, some of the test results have been lost, from 09:30 UTC to 11:30 UTC approximately. Please recheck any affected jobs by this problem.11:35
*** fellypefca has joined #openstack-ironic11:36
TheJuliayay gerrit11:36
lucasagomes:-(11:37
fellypefcaHello, everyone. Does anyone knows, during the deploy and delete, where Nova adds the Tenant Network and where Ironic delete the Provisiong Network?11:37
sambettsfellypefca: Is this with the neutron intergration patches?11:38
derayhello vinm213 lucasagomes sambetts alineb mgould pas-ha zer0c00l TheJulia and everyone else11:38
fellypefcasambetts Yes!11:38
*** vaishnavi_r has quit IRC11:38
vinm213o/ deray11:38
derayvinm213, hey there11:39
deraypossible to have a look at: https://review.openstack.org/#/c/278566 ? (Add 'GET /nodes/<node>/cleaning/steps' API request)11:39
lucasagomesderay, morning :-)11:40
deraylucasagomes, o/11:40
fellypefcasambetts I am bulding a sequence diagram of deploy and delete process, and i find where Ironic unconfigure the tenant, but i cant find where Nova create this tenant11:41
fellypefcaAnd i also find where ironic add the provisionig network, but i cant find where ironic deletes the provisioning11:42
sambettsfellypefca: So nova creates ports in the tenant network outside of the Ironic virt driver, in the compute manager, see nova/compute/manager.py def _build_networks_for_instance11:43
deraylucasagomes, Add 'GET /nodes/<node>/cleaning/steps' API request .. it should come as patch for Manual Cleaning [RFE] https://launchpad.net/bugs/152629011:44
openstackLaunchpad bug 1526290 in Ironic "[RFE] Manual cleaning" [Wishlist,In progress] - Assigned to deray (debayan-ray)11:44
sambettsfellypefca: Where Ironic deletes the provisioning network ports in is the network interface in remove_provisioning_network11:45
fellypefcasambetts Nice, i will check that. Thank you!11:45
sambettsfellypefca: where that function is called from in down to the driver11:45
mgouldderay TheJulia fellypefca morning!11:45
sambettsis down to the driver*11:45
lucasagomesderay, oh, I will take a look11:45
deraymgould, o/11:46
deraylucasagomes, thx :-)11:46
mkovacikmorning guys!11:46
sambettslucasagomes: I think I know what the error is to do with the state transition bug11:46
fellypefcasambetts Ok! Thanks again :)11:46
fellypefcamgould morning! :)11:46
lucasagomessambetts, not sure if I get it11:47
* lucasagomes reads the scrollback11:47
sambettslucasagomes: https://github.com/openstack/ironic/blob/master/ironic/common/states.py#L234 this should have target state manageable not avalible11:47
sambettslucasagomes: and I think DEPLOYFAIL properbly should to right?11:48
sambettsprobably*11:48
lucasagomessambetts, hmm I thought that was because you could restart cleaning?11:49
sambettslucasagomes: It has 2 possbile target states then?11:49
lucasagomessambetts, worth taking a look yeah, I thought you could either: Move to manageable and fix stuff if needed11:49
lucasagomesor restart cleaning if it was a transient failure11:50
lucasagomessambetts, yes, that's my understand but I may be wrong11:50
sambettslucasagomes: might need to talk to devananda or jroll about this one :/11:51
lucasagomesyeah11:51
lucasagomesbigger problem is that the spec didn't cover error states AFAIR11:51
sambettslucasagomes: I wonder if a state like clean fail should be one of the "stable" states11:52
lucasagomesso I'm sure there's a consensus on that11:52
sambettsso has no target11:52
lucasagomesright and it would require a manual API call to move it to another state11:53
lucasagomeswhich kinda makes sense IMO11:53
sambettsyeah, states like deploy fail and inspect fail too11:53
sambettsshould require a manual poke from the API11:54
lucasagomesdeploy fail not really right?11:56
lucasagomescause it should move to cleaning directly and try to get the machine back to the pool11:57
*** caiobo has joined #openstack-ironic11:57
sambettsdeploy failed target state right now is Active so I don't know if making it a stable state would really affect that logic11:58
sambettsand having deploy fail target state as Active doesn't seem to make sense ...11:59
*** trown has joined #openstack-ironic12:00
lucasagomessambetts, I believe that's because on error states we want to keep the target provision from the state it error'd out12:01
lucasagomessambetts, so we know what was the attempted transition12:01
* lucasagomes thinks that's the reasons why he wanted a FSM for ironic12:01
sambettslucasagomes: surely that should just be stored in a separate place, ie. I'm now in this state because I was attempting to go to this state12:02
sambettslucasagomes: but now I'm not attempting it anymore because I've failed12:02
lucasagomessambetts, right, yeah maybe store in another place would be a way of doing it12:04
sambettshave a field like last_target_provision_state or something maybe/12:05
lucasagomeswe probably need to discuss error states more for the current machine state12:05
lucasagomesbecause I'm not sure we have put a lot of thought into it since it was left from the spec12:05
lucasagomessambetts, :-/ yeah maybe12:05
lucasagomessambetts, I know it was a decision and the community decided to not have a real FSM in ironic, but that's just consequences of such IMHO12:06
lucasagomescause you don't have visibility of what's going on12:06
* lucasagomes knows it's water under the bridge12:06
sambettsYeah needs conversation I guess :)12:08
lucasagomesI agree12:08
lucasagomesmaybe we should add a topic to the meeting, or start a ML thread about error states in the ironic state machine12:09
sambettsI wonder if we need a session at the summit?12:09
lucasagomessambetts, that's a possibility too, let's add it to that etherpad that Jim just emailed12:11
* lucasagomes finds the link12:11
lucasagomessambetts, https://etherpad.openstack.org/p/ironic-newton-summit12:11
sambettslucasagomes: did you file a bug?12:13
lucasagomessambetts, oh almost, I just had to stop and looking at something else12:14
lucasagomeslemme finish12:14
*** thiagop has joined #openstack-ironic12:16
*** raildo-afk is now known as raildo12:16
thiagopGood morning, Ironic12:16
lucasagomessambetts, https://bugs.launchpad.net/ironic/+bug/155749712:18
openstackLaunchpad bug 1557497 in Ironic "Can not update node after aborting cleaning ("clean wait" state)" [Undecided,New]12:18
sambettslucasagomes: thanks :)12:18
sambettslucasagomes: I've written up a small entry on that etherpad12:22
lucasagomessambetts, thanks a lot!12:22
*** dims has quit IRC12:25
*** dims has joined #openstack-ironic12:26
*** piet has joined #openstack-ironic12:29
*** baoli has joined #openstack-ironic12:32
*** baoli_ has joined #openstack-ironic12:33
*** baoli has quit IRC12:37
*** trown has quit IRC12:43
*** lucasagomes is now known as lucas-hungry12:45
*** Nisha has joined #openstack-ironic12:48
*** fellypefca has quit IRC12:49
*** dprince has joined #openstack-ironic12:52
*** trown has joined #openstack-ironic12:53
*** deray has quit IRC12:53
*** Goneri has quit IRC12:54
openstackgerritCaio Oliveira proposed openstack/ironic:  Updating driver docs with DL hardwares requirements  https://review.openstack.org/29286512:54
*** afaranha has joined #openstack-ironic12:56
*** mgoddard_ has joined #openstack-ironic12:57
*** mgoddard_ has quit IRC12:59
*** mgoddard__ has joined #openstack-ironic12:59
*** mgoddard has quit IRC13:00
*** trown is now known as trown|ooobootcam13:02
*** deray has joined #openstack-ironic13:02
*** caiobo has quit IRC13:05
*** vinm213 has quit IRC13:14
*** ig0r__ has joined #openstack-ironic13:19
*** piet has quit IRC13:20
*** ig0r_ has quit IRC13:22
*** greghaynes has quit IRC13:22
*** aparnav has joined #openstack-ironic13:23
*** aparnav has quit IRC13:23
*** appu103_ has quit IRC13:23
*** chlong has joined #openstack-ironic13:25
*** mgoddard_ has joined #openstack-ironic13:32
*** cdearborn has joined #openstack-ironic13:32
openstackgerritWilliam Stevenson proposed openstack/python-ironicclient: Updates supporting ironic-neutron integration  https://review.openstack.org/20614413:32
*** piet has joined #openstack-ironic13:34
*** piet has quit IRC13:34
*** mgoddard__ has quit IRC13:35
*** greghaynes has joined #openstack-ironic13:37
*** rbudden has joined #openstack-ironic13:43
*** Goneri has joined #openstack-ironic13:43
*** lucas-hungry is now known as lucasagomes13:48
openstackgerritDebayan Ray proposed openstack/ironic: Add documentation for firmware update(iLO) as manual clean step  https://review.openstack.org/27676513:51
jrollsambetts: lucasagomes: funnnn.13:52
jrollmornin'13:52
lucasagomesjroll, morning (-:13:52
jrolllucasagomes: looking at https://review.openstack.org/#/c/292828/1/ironic_python_agent/shell/shutdown.sh13:52
jrollshould we just move this to python at this point?13:52
TheJuliagood morning jroll13:52
*** Nisha has quit IRC13:53
jrollI don't want to add extra work to land this patch though13:53
jrollheya TheJulia :)13:53
derayjroll, g'morning13:53
*** Nisha has joined #openstack-ironic13:53
jroll\o13:53
derayTheJulia, mind looking at: https://review.openstack.org/#/c/276765/13:53
sambettsjroll: yeah, certainly is :)13:54
lucasagomesjroll, could be, I just maintained the way it is now to not have to change much13:55
*** fellypefca has joined #openstack-ironic13:55
lucasagomesjroll, but yeah, I believe we can move it to python. If we do I may have to change another patch I have to introduce the sync command13:55
lucasagomesI also used a script for that13:55
jrolllucasagomes: yeah it's fine, I'll file a bug13:56
lucasagomesjroll, thanks13:56
lucasagomesjroll, if we do that, we may want to do for other scripts as well13:56
lucasagomeslike the one copying the image13:56
jrollI'd like to get rid of the bash stuff, write_image could move to ironic-lib13:56
jrollyeah13:56
lucasagomesjroll, indeed13:56
jrollthough there's some optimizations there, not sure if they're in ironic-lib13:56
TheJuliaderay: sure, just finishing up writing some internal doc, so give me about a half hour13:57
lucasagomesjroll, yeah, I think that as part of the work we should include the optmizations to ironic-lib13:57
derayTheJulia, sure. tyt please :)13:57
*** keedya has joined #openstack-ironic13:58
jrolllucasagomes: yep, agree13:58
fellypefcaDoes anyone knows where bash_finish_deploy is called by the driver?13:59
derayjroll, can u have a look at: https://review.openstack.org/#/c/278566/ when u have time? related to 'GET /nodes/<node>/cleaning/steps' API request13:59
jrollsurely it's different with iscsi vs direct writes but hey13:59
jrollderay: I will try13:59
sambettsfellypefca: in the iscsi vendor passthry13:59
derayjroll, okay thx :)13:59
sambettspassthru *13:59
lucasagomesjroll, fwiw I've tested the patch replacing sysrq and it works fine with the upstream coreos image13:59
* lucasagomes checks gate tests14:00
jrolllucasagomes: btw https://bugs.launchpad.net/ironic-python-agent/+bug/155754214:00
openstackLaunchpad bug 1557542 in ironic-python-agent "Move bash scripts to python" [Undecided,New]14:00
lucasagomesyeah seems good14:00
jrollcool14:00
lucasagomesjroll, thanks14:00
jrolllucasagomes: any particular reason for --no-wall? I don't think it would hurt either way, just curious14:01
lucasagomesjroll, I don't expect we have multiple users logged in the ramdisk to have to write to the wall?14:01
lucasagomeswall == a message to all users14:01
lucasagomessince it runs in the ramdisk, I just thought it would be extra work for non-reason... Wouldn't hurt to let it enabled tho14:01
jrolllucasagomes: usually not, someone could be shelled in14:02
jrollit's fine though14:02
lucasagomesjroll, I can update the patch, 1 sec14:02
* jroll +214:02
jrolloh14:02
jrollheh14:02
*** genevieve has joined #openstack-ironic14:03
*** Guest41345 has quit IRC14:03
openstackgerritLucas Alvares Gomes proposed openstack/ironic-python-agent: Replace SYSRQ commands  https://review.openstack.org/29282814:03
lucasagomesjroll, ^14:03
lucasagomesoh sorry I overwrote ur vote then ...14:04
jrollnit: systemctl shutdown ...14:04
jroll:P14:04
jroll+214:04
lucasagomesoh hah14:04
jrollit's fine, thanks for the patch man14:05
lucasagomescool, thank u for reviewing it14:05
fellypefcasambetts How does the vendor  passthru works? When the physical machines boots the image it calls the vendor?14:05
sambettsfellypefca: yup14:06
fellypefcasambetts thanks again!14:06
*** ChrisAusten has joined #openstack-ironic14:06
*** piet has joined #openstack-ironic14:08
openstackgerritSergii Turivnyi proposed openstack/python-ironicclient: Tests for testing port-create command  https://review.openstack.org/29180214:08
*** Marga_ has quit IRC14:08
genevievehey guys I'm wondering if someone here can help me with something?  I am trying to get ironic working using the ucs_pxe agent... I did an RDO packstack install for ironic just to test basics, but I keep having a strange problem where the dhcp port on the flat network I created shows as vif_type binding_failed in the neutron logs (from ml2 plugin).. baremetal provisioning obviously fails because my ucs blade & ironic serve14:09
genevievemaybe this isn't the right place to ask but I figured I had to start somewhere :)14:09
jrollgenevieve: looks like you got cut off after "ucs blade & ironic serve"14:11
lucasagomesyuriyz, good idea about having the oob power off per node14:11
lucasagomesI will try to rework that patch14:12
sambettsHi genevieve, if its the dhcp port thats failing do you see any more indepth errors in the q-svc or q-dhcp logs?14:12
genevieveoh, ok jroll, the rest of that was:  "...ucs blade & ironic server can't talk if that port can't go up. :("14:12
jrollright right14:13
jrollbut yeah check out neutron logs14:13
genevieveHi Sambetts - I do see in the logs that it seems like it's failing to execute a command, almost seems like its missing an option?  maybe bad config?  I'll paste, one second14:13
genevieveit's basically trying to do this, paraphrasing the logs until I can copy paste direct; "ovs-vsctl --timeout=10 --oneline --format=json -- --column=type list Interface int-br-ex"14:13
genevievebut noting those two -- in there, they don't make much sense.14:14
sambettsgenevieve: -- without an option are often used as a separator between options to be passed into different parts of the command being run14:15
genevieveOK, so maybe not the real problem?  let me find that darn error again, one moment14:15
genevieveOK, sorry for being a little spammy here -14:18
sambettsgenevieve: thats ok :)14:18
genevieve2016-03-14 16:21:23.249 30109 INFO neutron.plugins.ml2.drivers.openvswitch.agent.ovs_neutron_agent [req-8630e406-601a-4b27-8c96-58ffc6f4b948 - - - - -] Mapping physical network physnet1 to bridge br-ex14:18
genevieve2016-03-14 16:21:23.273 30109 ERROR neutron.agent.ovsdb.impl_vsctl [req-8630e406-601a-4b27-8c96-58ffc6f4b948 - - - - -] Unable to execute ['ovs-vsctl', '--timeout=10', '--oneline', '--format=json', '--', '--columns=type', 'list', 'Interface', 'int-br-ex'].14:18
genevieve2016-03-14 16:21:23.273 30109 ERROR neutron.agent.ovsdb.impl_vsctl Traceback (most recent call last):14:18
genevieve2016-03-14 16:21:23.273 30109 ERROR neutron.agent.ovsdb.impl_vsctl   File "/usr/lib/python2.7/site-packages/neutron/agent/ovsdb/impl_vsctl.py", line 63, in run_vsctl14:18
jrolloh noooo14:18
genevieve2016-03-14 16:21:23.273 30109 ERROR neutron.agent.ovsdb.impl_vsctl     log_fail_as_error=False).rstrip()14:18
jrollgenevieve: in the future use paste.openstack.org14:18
genevieveOh14:18
jrollplease :)14:18
genevieveOkay sorry one second =)14:18
sambetts:)14:18
sambettssorry about that I should have said14:19
genevievehttp://paste.openstack.org/show/490515/14:19
genevievesorry I'm new at this :(14:19
genevievegive a gal a break :D14:19
jrollno worries14:19
sambetts:D14:19
genevievethat's from the openvswitch log, I think it's why the dhcp port won't go up but I could be mistaken14:20
genevievebut seems like the culprit?14:20
*** ChrisAusten has quit IRC14:21
sambettsgenevieve: I would expect whats causing the issue, if you try running that command manaully on the server where q-dhcp is running you might get a better idea of why its happening as the logs don't show the output of the command14:21
genevievewell I did that and when I remove those extraneous -- it works, when I add them it fails.. which is why I had thought they were the culprit, maybe I had a missing option in a config or something.  I couldn't really tell.14:22
genevievehttp://paste.openstack.org/show/490516/14:23
sambettsgenevieve: interesting, I wonder if something is sneaking in there :/14:23
genevieveI pasted with and without above so you can see both outputs.14:25
openstackgerritVladyslav Drok proposed openstack/python-ironicclient: Pass region_name to SessionClient  https://review.openstack.org/29255214:25
mkovacikguys, we could use some additional review in inspector here: https://review.openstack.org/#/c/276107/36 (already has a +2)14:27
openstackgerritVladyslav Drok proposed openstack/python-ironicclient: Set endpoint_override while doing session.request  https://review.openstack.org/29255214:30
*** Guest91794 has quit IRC14:31
*** miles has joined #openstack-ironic14:32
sambettsgenevieve: I wonder if its a ovs version issue, looking at the neutron code it would appear that include the -- is expected14:32
genevievesambetts: ovs-vsctl show says ovs_version: "2.4.0"   if that helps?14:33
*** mgould has quit IRC14:34
sambettsgenevieve: in my environment where it is working my ovs_version is 2.0.214:35
*** buttercup_ has joined #openstack-ironic14:36
genevievesambetts: So when you manually run a similar ovs-vsctl list command like I'm erroring out on with the extra --, it works on 2.0.2?14:37
sambettsgenevieve: I'm just trying it14:37
sambettsgenevieve: I'm seeing the same error, if I run that command14:38
sambettsso its not a version issue :(14:38
genevieveHmmmm strange I wonder why mine is getting formatted this way. :(14:38
genevieveI still suspect maybe I have a misconfigured option in a config file somewhere, like it's supposed to be appending something after -- but it's getting null because it's not in config... something like that?  That's my only real "going theory" :(14:39
*** fellypefca has quit IRC14:40
sambettshmm if you change column to columns its successful on mine14:40
genevieveOhhhhhhhh nice catch! Same here!!14:41
sambettsgenevieve: I think you might have made a mistake in your manual run, the logs say its running --columns14:41
TheJuliaderay: looks good, some nits though, putting them in now :)14:41
*** mtanino has joined #openstack-ironic14:41
genevievesambetts:  Shoot, you're right... typo on my part.  I didn't see that :(14:41
sambettsgenevieve: running it manually worked?14:42
genevieveovs-vsctl --timeout=10 --oneline --format=json -- --columns=type list Interface int-br-ex                                     {"data":[["patch"]],"headings":["type"]}14:42
genevieve^ seems like it!14:42
lennybHi Ironic, Is it possible to run ironic-tempest-plugin for a specific IRONIC_API_VERSION?14:43
derayTheJulia, okay14:43
sambettsgenevieve: did you have to run it as root? It could be that your q-dhcp root wrap configures aren't quite right, because the openstack services all run unprivoledged unless they go through the root wrap14:43
genevievesambetts: Yes I am running as root, what user would this be run as?  I can su and test unprivileged.14:44
*** keedya has quit IRC14:44
sambettsgenevieve: I'm not sure how pack stack sets up the users, I would look for a user called neutron14:45
sambettsunless it runs it all under 1 user in which case I would look for a user called stack or something similar14:46
openstackgerritDebayan Ray proposed openstack/ironic: Follow-up of firmware update(iLO) as manual cleaning step  https://review.openstack.org/29106914:46
*** Nisha has quit IRC14:47
*** Nisha has joined #openstack-ironic14:48
sambettsvsaienko: ping14:49
sambettsvdrok, vsaienko, jlvillal: I'm trying to get tempest basic ops to work, I've set the DEFAULT_INSTANCE_TYPE to baremetal but its not populating the tempest config with the right flavor ref14:52
sambettsany ideas?14:52
derayTheJulia, leaving now. will go thru your review comments t'morrow14:52
derayTheJulia, thanks :-)14:52
*** deray has quit IRC14:54
TheJulia:)14:56
-openstackstatus- NOTICE: Launchpad OpenID SSO is currently experiencing issues preventing login. The Launchpad team is working on the issue14:57
*** ChanServ changes topic to "Launchpad OpenID SSO is currently experiencing issues preventing login. The Launchpad team is working on the issue"14:57
*** links has quit IRC14:59
*** mgoddard_ has quit IRC14:59
*** Nisha has quit IRC14:59
*** mgoddard has joined #openstack-ironic14:59
vsaienkosambetts: hello15:00
*** izaakk has joined #openstack-ironic15:00
sambettsvsaienko: any ideas why my DEFAULT_INSTANCE_TYPE isn't being set up right for tempest?15:02
genevievesambetts: Looks like the processes are running as the neutron user, but I think no shell set so can't su -c a one-off command.  Can change that to test though.15:06
*** tesseract has joined #openstack-ironic15:06
*** harshs has joined #openstack-ironic15:07
*** tesseract is now known as Guest7146715:07
genevieveSambetts:   As neutron user:    "ovs-vsctl: unix:/var/run/openvswitch/db.sock: database connection failed (Permission denied)"15:08
jlvillalsambetts: https://github.com/JohnVillalovos/devstack-gate-test15:10
jlvillalsambetts: In particular: https://github.com/JohnVillalovos/devstack-gate-test/blob/master/ansible/roles/devstack-gate/files/update-projects.sh15:10
jlvillalsambetts: Maybe that will be of help15:11
*** krtaylor has quit IRC15:13
sambettsgenevieve: yeah, so the openstack services use a thing called root wrap to give the unprivoledged user root access to certain commands, try adding  "/usr/bin/neutron-rootwrap /etc/neutron/rootwrap.conf " to the beginning of your command15:13
openstackgerritLucas Alvares Gomes proposed openstack/ironic: Agent: Out-of-band power off on deploy  https://review.openstack.org/29182915:15
openstackgerritSergii Turivnyi proposed openstack/python-ironicclient: Add sanity tests for testing actions with Port  https://review.openstack.org/24094415:15
genevievesambetts: Unless I am running the one-liner wrong, it seems like rootwrap still gives me same end result. :|15:18
vsaienkosambetts: hm...15:18
sambettsgenevieve: it gives you the permission denied?15:19
genevieveCorrect!15:19
*** piet has quit IRC15:20
* lucasagomes approves the RAID docs15:22
*** miles is now known as mgould15:23
*** krtaylor has joined #openstack-ironic15:25
*** ChrisAusten has joined #openstack-ironic15:27
openstackgerritMerged openstack/ironic: Add documentation for RAID  https://review.openstack.org/22633015:29
*** harshs has quit IRC15:29
*** ChanServ changes topic to "Bare Metal Provisioning | Status: http://bit.ly/ironic-whiteboard | Docs: http://docs.openstack.org/developer/ironic/ | Bugs: https://bugs.launchpad.net/ironic"15:30
-openstackstatus- NOTICE: Launchpad SSO is back to normal - happy hacking15:30
*** chlong has quit IRC15:33
vsaienkosambets: configuration of ironic (VM creation, flavor creation) is done after tempest configuration15:35
sambettsvsaienko: thats what I assumed, do you know any way to force the order? I've tried arranging them in the local.conf file and it doesn't seem to make a difference15:37
*** getvasanth_ has quit IRC15:40
openstackgerritVladyslav Drok proposed openstack/python-ironicclient: Set endpoint_override while doing session.request  https://review.openstack.org/29255215:43
*** vishwanathj has joined #openstack-ironic15:43
*** absubram has joined #openstack-ironic15:50
vsaienkosambetts: since tempest is not pluginized yet, it is executed before any other plugin https://github.com/openstack-dev/devstack/blob/082399ef18106bc3820848b6fc352604f0fcf97a/functions-common#L185915:51
*** daemontool has joined #openstack-ironic15:51
vsaienkosambetts: L1859 - run tempest, L1870 run plugins15:52
*** rbudden has quit IRC15:54
NobodyCamGood Morning Ironic :)15:55
sambettso/ NobodyCam15:56
NobodyCam:)15:56
NobodyCamlast day of vacation here15:56
mgouldmorning NobodyCam15:56
NobodyCamwill be back at yee old grind stone tomorrow :)15:56
NobodyCam:)15:56
*** links has joined #openstack-ironic15:58
TheJuliashould that be "ye olde grind stone"15:59
TheJuliaerr, shouldn't15:59
*** suro-patz has joined #openstack-ironic16:03
lucasagomesNobodyCam, TheJulia morning16:03
NobodyCamTheJulia: ahh yes it should16:03
NobodyCammorning lucasagomes16:03
BadCubmorning ironicville16:03
sambettsvsaienko: this fix doesn't work then right? https://review.openstack.org/#/c/289376/16:04
sambettsvsaienko: tempest still fails because the flavor isn't configured in tempest.conf16:04
TheJuliaNobodyCam: :)16:06
NobodyCam:)16:07
openstackgerritVasyl Saienko proposed openstack/ironic: Update tempest configuration from devstack plugin  https://review.openstack.org/29302016:08
*** jaybeale has joined #openstack-ironic16:08
vsaienkosambets: it will should work with https://review.openstack.org/#/c/293020/16:10
sambettsvsaienko: I like it ^ although I wonder if we should be doing it that way :/16:10
sambettsvsaienko: I'll see if it makes my CI pass :D16:10
vsaienko:)16:11
sambettsvsaienko: should proably have an is service enabled tempest if statement in there too16:11
sambettsvsaienko: in case someone disables it16:12
*** vishwana_ has joined #openstack-ironic16:13
*** vishwanathj has quit IRC16:16
openstackgerritVasyl Saienko proposed openstack/ironic: Update tempest configuration from devstack plugin  https://review.openstack.org/29302016:17
sambettsvsaienko: tbh I wonder if that needs to be changed in devstack, so that the extra part runs right at the end like its suppose it16:17
sambettsvsaienko: i.e. plugins first then extra.d16:17
sambettsvsaienko: According to the devstack configuration anything in the extra phase should be exectued before any files in extra.d are processed16:20
*** vishwana_ is now known as vishwanathj16:20
sambettsvsaienko: So I think that should be true whether we're a plugin or not16:20
*** garthb has joined #openstack-ironic16:21
*** permalac has joined #openstack-ironic16:22
*** permalac has quit IRC16:22
*** mbound has quit IRC16:23
*** permalac has joined #openstack-ironic16:23
*** permalac has quit IRC16:23
vsaienkosambetts: I think you are right, we should update the order. Also as for me it makes sense to have some script in ironic_tempest_plugin that perform tempest configuration.16:23
*** thrash is now known as thrash|lunch16:27
sambettsvsaienko: I think once liberty EOLs we'll need to add a section to the Ironic devstack plugin to handle configuring the tempest ironic specifc configs, and I think it would make sense if that was in something like ironic/devstack/extras.d/81_ironic_tempest.sh16:28
sambettsthen it works just like the existing devstack stuff and you can gurantee that it runs after the main devstack/extras.d/80-tempest.sh script16:29
*** ohamada has quit IRC16:31
*** permalac_ has joined #openstack-ironic16:31
*** permalac_ has quit IRC16:31
*** Nisha has joined #openstack-ironic16:35
*** Marga_ has joined #openstack-ironic16:35
*** rcernin has quit IRC16:35
*** Guest71467 has quit IRC16:42
*** harshs has joined #openstack-ironic16:43
*** piet has joined #openstack-ironic16:43
*** rbudden has joined #openstack-ironic16:46
*** links has quit IRC16:47
*** suro-patz has quit IRC16:50
*** suro-patz has joined #openstack-ironic16:52
openstackgerritVasyl Saienko proposed openstack/ironic: Update tempest configuration from devstack plugin  https://review.openstack.org/29302016:52
*** rbudden has quit IRC16:54
*** dprince has quit IRC16:54
*** mbound has joined #openstack-ironic16:55
*** rbudden has joined #openstack-ironic16:58
*** e0ne has quit IRC16:58
*** suro-patz has quit IRC17:00
openstackgerritMerged openstack/ironic-python-agent: Stop trying to log stdout when fetching logs during inspection  https://review.openstack.org/28993917:01
openstackgerritMerged openstack/ironic-python-agent: Document hardware inventory sent to lookup and inspection  https://review.openstack.org/27527217:04
*** thrash|lunch is now known as thrash17:09
* sambetts is calling it a day 17:12
thiagopnight sambetts17:12
sambettsCya tomorrow everyone17:12
sambettso/ thiagop17:12
*** sambetts is now known as sambetts|afk17:12
jlvillalsambetts|afk: Ciao!17:13
*** openstackgerrit has quit IRC17:14
*** openstackgerrit_ is now known as openstackgerrit17:14
*** openstackgerrit has quit IRC17:15
*** openstackgerrit_ has joined #openstack-ironic17:15
*** openstackgerrit_ is now known as openstackgerrit17:16
*** genevieve has quit IRC17:16
*** openstackgerrit_ has joined #openstack-ironic17:17
lucasagomessambetts|afk, see ya17:18
*** MattMan has quit IRC17:18
*** MattMan has joined #openstack-ironic17:18
*** suro-patz has joined #openstack-ironic17:24
*** pcaruana has quit IRC17:24
*** caiobo has joined #openstack-ironic17:26
*** dprince has joined #openstack-ironic17:33
*** Sukhdev has joined #openstack-ironic17:34
*** mannidi_ has joined #openstack-ironic17:35
*** pcaruana has joined #openstack-ironic17:36
openstackgerritLucas Alvares Gomes proposed openstack/ironic: Agent: Out-of-band power off on deploy  https://review.openstack.org/29182917:42
JayFlooking lucasagomes17:42
* JayF always feels bad when he has exactly one nit/docs thing with each patchset17:42
lucasagomesJayF, oh that's quick... Thank you17:43
lucasagomesJayF, nah, it's actually more than a nit, it's quite bad to have those undocumented options in Ironic17:43
lucasagomesthanks for the review17:43
JayF+1'd17:43
JayFI try to be really quick to re-review on a nit, if I see it come across IRC17:43
JayFif you wanna make sure I see something, add me to reviewers because my first "review queue" are changes I get emaield about :)17:44
lucasagomesJayF, a-ha will do17:44
openstackgerritRamamani Yeleswarapu proposed openstack/ironic: Add comments to generator.py  https://review.openstack.org/28395417:44
lucasagomesJayF, btw you may want to take a look at the patch that this one depends-on for IPA17:44
lucasagomesJayF, I also put a tiny patch replacing the SYSRQ stuff with the shutdown command and tested it locally17:45
lucasagomesworks fine with the chroot'd coreos image17:45
lucasagomeswhen you have time ofc, no rush17:45
JayFyou have a link? I'll look right now17:45
JayFwe released a product last week :) I'm back to having time for upstream again, lol17:45
*** ChubYann has joined #openstack-ironic17:46
lucasagomesJayF, yup, sysrq patch: https://review.openstack.org/#/c/292828/  and sync() patch: https://review.openstack.org/#/c/29173217:46
JayFnatorious: https://review.openstack.org/#/c/292828/ I know you wanted to do this; if you wanna take a look17:47
JayFlucasagomes: on the sync() patch, you're doing an echo 3 > /proc...drop_caches17:48
JayFlucasagomes: that's not going to block, is it?17:48
JayFlucasagomes: which makes me think at the least you may wanna do it before the sync or sleep or anything at all, otherwise IPA will get shutoff by the BMC within <1s of that getting returned most likely :)17:49
lucasagomesJayF, nop, honestly I'm don't even think that's required I just added to be a good citzen and make sure we dropped all caches after sync (which is blocking)17:49
*** derekh has quit IRC17:49
JayFhmm. okay then, I guess17:50
JayFjust generally would prefer do something and make sure it took effect17:50
*** aswadr_ has quit IRC17:50
JayFvs doing it opportunistically when it's not really needed17:50
openstackgerritRamamani Yeleswarapu proposed openstack/ironic: Add comments to generator.py  https://review.openstack.org/28395417:50
lucasagomesJayF, usually you run it after the sync to minimize the no of dirty objects17:50
JayFbecause option #2 can cause intermittant problems :)17:50
JayFyeah, I mean I'm not opposed to it, just... hm17:50
lucasagomesJayF, yeah, sounds fair17:50
lucasagomesJayF, I will revert the order there17:51
lucasagomesinvert*17:51
JayFI mean, I just +2'd it17:51
lucasagomesJayF, ack, jroll also filled a bug today to replace all the shell scripts to python code17:52
JayFyeah, with ironic-lib that code should start unifying17:52
JayFMy problem was more with it being a script just for the extra command17:53
JayFvs running sync from python17:53
JayFmoreso than anything else17:53
lucasagomesright, yeah... it's very flexible to have it in a script17:53
lucasagomesif we keep it simple enough17:53
JayFlucasagomes: one comment on the sysrq thing: tl;dr we used to force a sync, now we don't, but we probably still should17:56
lucasagomesJayF, hmm I removed that because since we do a soft shutdown we will hcange the run level to 0 (halt) or 6 (reboot) and it should umnount all filesystems etc17:57
lucasagomesthe sync will be implicit, but I'm not against adding a explicit one there either17:58
* lucasagomes does it17:58
JayFI mean, my thought is generally17:58
JayFonce we write the image and configdrive17:58
JayFif we sync17:58
JayFnot much else matters after that in most cases17:58
JayFso it makes the failure case not nearly as bad17:59
*** causten_ has joined #openstack-ironic17:59
*** Sukhdev has quit IRC18:00
openstackgerritLucas Alvares Gomes proposed openstack/ironic-python-agent: Replace SYSRQ commands  https://review.openstack.org/29282818:01
lucasagomesJayF, ++ updated it ^18:01
*** ChrisAusten has quit IRC18:01
lucasagomesthanks for the reviews man! Very useful18:02
JayFlucasagomes: I'm also going to try and get the power-off-after-failure patch split up this week, want to get all those things in-flight that stalled back to a good state18:02
JayFnp at all, I hate when I see folks waiting on reviews so I try to hit when I can and when it's something I understand18:02
lucasagomesJayF, oh yeah +1, that's very wanted18:02
lucasagomesJayF, btw, you guys do something on the nova side for that change?18:03
*** dims_ has joined #openstack-ironic18:03
lucasagomescause I think nova will power the node off independent of the ironic conf (it's an unrelated problem that can't be addressed in that patch)18:03
*** dims has quit IRC18:03
lucasagomesjust wondering if you guys have something downstream for preventing that tho18:04
*** rbrud has quit IRC18:04
openstackgerritMilan Kováčik proposed openstack/ironic-inspector-specs: High Availability for Ironic Inspector  https://review.openstack.org/25367518:05
JayFlucasagomes: no we don't, honestly the only part of that patch we really care about is the leaving nodes on after cleaning18:05
JayFlucasagomes: oooh, that's also  a vestige from when decom would go through that code too, so no power off on deploy failure also kept nodes in deecom from being powered off when they failed18:06
JayFwhich I think was more of our use case for that18:06
lucasagomesJayF, fair enough. Yeah cleaning should work fine because nova is hands-off when cleaning is happening18:06
JayFbut now folks use bifrost and all that so it's useful again18:06
JayFwell even cleaning-proper does the right thing now without the setting, I think18:07
lucasagomes++ yeah18:07
JayFbut I'm talking about old school hacked in decom :)18:07
JayFfrom before it was upstream18:07
lucasagomesonce that's merged I may take a look at the nova side see what can be done there, perhaps an extra config to not issue the power off for the failed nodes on their side would be the right way to do it18:08
lucasagomesI think I will call it a day, have a great evening all!18:09
lucasagomessee you all tomorrow18:09
*** lucasagomes is now known as lucas-dinner18:10
thiagopbye lucas-dinner18:10
lucas-dinnersee ya18:10
*** mannidi_ has quit IRC18:15
*** jistr has quit IRC18:15
*** ijw has joined #openstack-ironic18:18
*** brud has joined #openstack-ironic18:25
*** brud has left #openstack-ironic18:25
*** AJaeger has joined #openstack-ironic18:25
*** rbrud has joined #openstack-ironic18:25
*** rbrud has quit IRC18:25
AJaegerHi, could some ironic-ui core please +A https://review.openstack.org/#/c/292074/ to fix translation setup? Alterntaive: betherly, could you remove your +A and add it again? The job was approved but no event received due to the CI problems we had.18:26
*** rbrud has joined #openstack-ironic18:26
JayFkrotscheck: ^ is the only core I'm aware of for that outside of betherly18:27
krotscheckohai18:27
krotschecklooking18:27
*** daemontool has quit IRC18:27
*** baoli_ has quit IRC18:27
betherlyThanks krotscheck!18:27
*** piet has quit IRC18:28
betherlyLet me know if you want me to deal with it :)18:28
krotscheckAJaeger: ltgm, but I'm hardly an expert18:28
krotscheckYou probably know that better.18:28
*** e0ne has joined #openstack-ironic18:28
*** piet has joined #openstack-ironic18:28
*** dims_ has quit IRC18:29
AJaegerkrotscheck: I tested locally and consider myself an expert here ;)18:29
AJaegerthanks, krotscheck18:29
krotscheckAJaeger: It works on your machine stamp of approval?18:29
AJaegerYep ;)18:29
krotscheckI prefer the What Could Possibly Go Wrong badge myself ;)18:30
AJaegerbetherly: do you want to enable the translation setup again? Meaning syncing to our translation server so that it can be translated? ironic-ui is now ready for this...18:30
AJaegernote that translators are busy but we can setup the infrastructure18:31
AJaegerkrotscheck: nothing could go wrong, unless you enable translation infrastructure setup ;)18:32
*** pece has quit IRC18:32
openstackgerritNisha Agarwal proposed openstack/ironic-python-agent: Add support for partition images in agent driver  https://review.openstack.org/16022418:34
*** degorenko is now known as _degorenko|afk18:34
*** mgould has quit IRC18:35
*** mkovacik has quit IRC18:40
*** e0ne_ has joined #openstack-ironic18:50
*** e0ne has quit IRC18:51
openstackgerritVladyslav Drok proposed openstack/ironic: [devstack] Do not die if neutron is disabled  https://review.openstack.org/29308818:51
*** electrofelix has quit IRC18:53
openstackgerritVladyslav Drok proposed openstack/python-ironicclient: Do not merge  https://review.openstack.org/29309318:56
*** jaybeale has quit IRC18:56
*** praneshp_ has joined #openstack-ironic19:01
*** bnemec has quit IRC19:03
*** dims has joined #openstack-ironic19:12
*** Nisha has quit IRC19:13
*** Nisha_away has joined #openstack-ironic19:13
*** ijw has quit IRC19:13
*** bnemec has joined #openstack-ironic19:13
*** krotscheck is now known as kro_death_by_sin19:14
*** kro_death_by_sin is now known as kro_sinus_hell19:14
*** rbudden has quit IRC19:16
*** bnemec has quit IRC19:16
*** dprince has quit IRC19:18
*** bnemec has joined #openstack-ironic19:18
*** dims has quit IRC19:18
*** e0ne_ has quit IRC19:19
*** dims has joined #openstack-ironic19:26
*** dprince has joined #openstack-ironic19:31
*** athomas has quit IRC19:32
*** harshs has quit IRC19:32
JayFso morgabra and I just found a really nasty bug in ironicclient: if you return it parsable json, it happily takes it regardless of the return codes19:33
JayFhttps://github.com/openstack/python-ironicclient/blob/master/ironicclient/common/base.py#L7019:33
JayFwhich means if you return properly formatted json as error pages, None starts getting passed around a lot as we hit the except on line #8319:33
JayFhttps://github.com/openstack/python-ironicclient/blob/cf70f20943f5d6757df6e2e94891d60fe735a69b/ironicclient/common/http.py#L506 apparently there is a blacklist of codes, but it's certainly not comprehensive19:34
*** jaybeale has joined #openstack-ironic19:35
*** gabriel-bezerra has quit IRC19:37
*** athomas has joined #openstack-ironic19:40
JayFapparently I missed the catchall :( not a bug, although that's really unfortunate given it would've perfectly explained my issue19:40
jlvillalJayF: Hopefully you figure out the real cause of your issue.19:42
JayFI know the root cause, like what actually caused the underlying failure19:43
JayFbut nova in our environment doesn't seem to be handling ironic-api 503s properly19:43
JayFso we're delving in19:43
jlvillalGood luck!19:45
*** dims has quit IRC19:45
*** AJaeger has left #openstack-ironic19:47
*** dprince has quit IRC19:48
*** gabriel-bezerra has joined #openstack-ironic19:53
*** Goneri has quit IRC19:57
openstackgerritVasyl Saienko proposed openstack/ironic: Update tempest configuration from devstack plugin  https://review.openstack.org/29302020:00
*** igordcar1_ has quit IRC20:01
*** igordcard_ has joined #openstack-ironic20:01
*** ig0r_ has joined #openstack-ironic20:04
openstackgerritNisha Agarwal proposed openstack/ironic: Add support for partition images in agent drivers  https://review.openstack.org/16200820:06
*** caiobo has quit IRC20:06
Nisha_awayjroll, JayF jlvillal vdrok i have updated the patch sets for IPA and ironic for partition image support. in Ironic patch there are outstanding comments on test cases and some test cases need to be added. Will add that in follow up patch tomorrow20:06
*** ig0r__ has quit IRC20:06
jrollNisha_away: thanks20:06
Nisha_awayjroll, please review and add any comments20:07
Nisha_awayi will addrss all of them tomorrow20:07
Nisha_awaySorry i am not keeping well from 3 days so was not able to push the patch in the day time20:07
*** caiobo has joined #openstack-ironic20:08
Nisha_awayi will love to have the comments on the current patch so that i can address in next patch set20:08
*** dims has joined #openstack-ironic20:11
*** ijw has joined #openstack-ironic20:13
*** ijw has quit IRC20:14
*** Nisha_away has quit IRC20:15
*** caiobo has quit IRC20:17
*** Marga_ has quit IRC20:19
openstackgerritRamamani Yeleswarapu proposed openstack/ironic: Add unit tests for 'ironic/common/config_generator/generator.py'  https://review.openstack.org/28393720:27
openstackgerritRamamani Yeleswarapu proposed openstack/ironic: generator.py: Add comments & remove unused param  https://review.openstack.org/28395420:27
*** piet has quit IRC20:30
*** spandhe has joined #openstack-ironic20:30
*** piet has joined #openstack-ironic20:30
*** keedya has joined #openstack-ironic20:31
*** keedya has quit IRC20:32
*** e0ne has joined #openstack-ironic20:37
*** baoli has joined #openstack-ironic20:41
openstackgerritLucas Alvares Gomes proposed openstack/ironic: Agent: Out-of-band power off on deploy  https://review.openstack.org/29182920:41
* lucas-dinner fix pep8 issues ^ and goes afk again20:41
*** harshs has joined #openstack-ironic20:55
*** keedya has joined #openstack-ironic20:56
*** baoli has quit IRC20:58
*** baoli has joined #openstack-ironic20:59
*** keedya has quit IRC21:05
*** raildo is now known as raildo-afk21:05
*** keedya has joined #openstack-ironic21:11
*** baoli has quit IRC21:13
*** baoli has joined #openstack-ironic21:13
*** aNupoisc has joined #openstack-ironic21:14
*** vishwanathj has quit IRC21:14
*** aNupoisc has quit IRC21:15
*** aNupoisc has joined #openstack-ironic21:15
*** jtomasek has quit IRC21:16
*** moshele has quit IRC21:17
*** jtomasek has joined #openstack-ironic21:18
*** rbrud has quit IRC21:20
*** keedya has quit IRC21:23
*** vishwanathj has joined #openstack-ironic21:26
*** baoli has quit IRC21:27
*** baoli has joined #openstack-ironic21:27
*** trown|ooobootcam has quit IRC21:27
*** jtomasek has quit IRC21:28
*** baoli has quit IRC21:32
*** pcaruana has quit IRC21:38
*** keedya has joined #openstack-ironic21:38
*** e0ne has quit IRC21:40
*** aNupoisc has quit IRC21:42
*** baoli has joined #openstack-ironic21:43
*** baoli has quit IRC21:45
*** baoli has joined #openstack-ironic21:46
*** aNupoisc has joined #openstack-ironic21:47
*** pcaruana has joined #openstack-ironic21:52
*** moshele has joined #openstack-ironic21:56
*** Marga_ has joined #openstack-ironic21:56
*** baoli has quit IRC21:59
*** harlowja has joined #openstack-ironic22:01
*** kbyrne has quit IRC22:01
*** baoli has joined #openstack-ironic22:02
*** vishwanathj has quit IRC22:02
*** raildo-afk is now known as raildo22:02
*** spandhe_ has joined #openstack-ironic22:05
*** raildo is now known as raildo-afk22:06
*** spandhe has quit IRC22:06
*** spandhe has joined #openstack-ironic22:07
*** spandhe_ has quit IRC22:09
*** baoli has quit IRC22:10
*** baoli has joined #openstack-ironic22:10
*** dims_ has joined #openstack-ironic22:11
*** david-lyle has quit IRC22:13
*** dims has quit IRC22:14
*** piet has quit IRC22:16
*** dims has joined #openstack-ironic22:16
*** dims_ has quit IRC22:17
thiagopcalling it a day22:21
thiagopsee ya22:21
*** absubram has quit IRC22:21
TheJuliagoodnight thiagop22:22
*** keedya has quit IRC22:22
*** thiagop has quit IRC22:23
*** moshele has quit IRC22:25
*** aNupoisc has quit IRC22:27
*** cdearborn has quit IRC22:28
*** piet has joined #openstack-ironic22:29
*** shakamunyi has joined #openstack-ironic22:32
mrdaMorning Ironic22:34
*** baoli has quit IRC22:44
*** mbound has quit IRC22:50
*** piet has quit IRC22:56
*** aNupoisc has joined #openstack-ironic22:58
*** jaybeale has quit IRC23:02
* jlvillal wishes he knew more to know if this is cool or not: http://northboundnetworks.com/collections/zodiac-fx/products/zodiac-fx23:03
jlvillalmrda: Morning23:03
*** dims has quit IRC23:06
*** Goneri has joined #openstack-ironic23:09
JayFjlvillal: if it doesn't support ONIE, pffffffffft23:14
*** chlong has joined #openstack-ironic23:28
*** praneshp_ has quit IRC23:40
*** linuxgeek has quit IRC23:44
*** harlowja has quit IRC23:47
*** buttercup_ has quit IRC23:51
*** causten_ has quit IRC23:51
*** mbound has joined #openstack-ironic23:51
*** mbound has quit IRC23:56

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!