Tuesday, 2016-03-01

*** Sukhdev has quit IRC00:22
NobodyCamthiagop: awesome!!!!00:33
*** boris-42 has quit IRC00:34
thiagopnow, after 2hs filling the DS-160, I'll call it a day00:38
*** Sukhdev has joined #openstack-ironic00:38
thiagopsee you tomorrow folks00:38
*** thiagop has quit IRC00:38
*** hoangcx has joined #openstack-ironic00:42
*** aNupoisc has joined #openstack-ironic00:43
* jlvillal remembers filing out the DS-160 for his wife. It is a long long form :(00:45
jlvillals/filing/filling/00:45
jlvillalNobodyCam: Are you recovered from being sick? I hope so!00:46
*** baoli has joined #openstack-ironic00:52
*** Sukhdev has quit IRC00:52
*** suro-patz has quit IRC00:56
aNupoiscHI John00:57
*** baoli has quit IRC00:58
jlvillalaNupoisc: Hey there.01:00
jlvillalWelcome to the Ironic channel :)01:00
aNupoiscThank you. Great we are connected now01:00
*** amotoki has joined #openstack-ironic01:01
aNupoiscjlvillal: How are you doing today01:01
aNupoisc<jlvillal>: Hope you had a fine day01:02
jlvillalaNupoisc: Doing well. Thanks. Just trying to get the miscellaneous work things done today...01:02
*** garthb has quit IRC01:03
aNupoisc jlvilla: Nice. I am upgrading the system bcoz scheduler wasn't working and the reason was no VT-x01:05
*** [1]rpioso has quit IRC01:06
*** penick has quit IRC01:08
*** suro-patz has joined #openstack-ironic01:13
*** suro-patz has quit IRC01:26
*** kan_ has joined #openstack-ironic01:48
*** mtanino has quit IRC01:55
*** aNupoisc has quit IRC01:55
*** rloo has quit IRC01:57
*** suro-patz has joined #openstack-ironic02:01
*** ChrisAusten has joined #openstack-ironic02:02
*** dims has quit IRC02:04
*** Sukhdev has joined #openstack-ironic02:08
*** dims has joined #openstack-ironic02:08
*** baoli has joined #openstack-ironic02:11
openstackgerritZhenguo Niu proposed openstack/ironic: Add support for console ports allocation/de-allocation  https://review.openstack.org/25778902:11
*** dims has quit IRC02:13
*** Sukhdev has quit IRC02:14
*** Marga__ has joined #openstack-ironic02:16
*** dims has joined #openstack-ironic02:17
*** baoli has quit IRC02:18
*** baoli has joined #openstack-ironic02:18
*** Marga_ has quit IRC02:19
*** hemna_ has joined #openstack-ironic02:19
*** baoli has quit IRC02:22
*** baoli has joined #openstack-ironic02:23
*** suro-patz has quit IRC02:31
openstackgerritHaomeng,Wang proposed openstack/ironic-python-agent: add new portal_port argument into iscsi.start_iscsi_target api  https://review.openstack.org/27242002:34
openstackgerritHaomeng,Wang proposed openstack/ironic-python-agent: add new portal_port argument into iscsi.start_iscsi_target api  https://review.openstack.org/27242002:37
*** jaybeale has quit IRC02:42
*** deray has joined #openstack-ironic02:43
*** ijw has quit IRC02:43
openstackgerritZhenguo Niu proposed openstack/ironic: Follow up nits of I57bf7cebfb6db805b6c521bacfef2993b16ce1ee  https://review.openstack.org/28636402:54
*** hemna_ has quit IRC02:57
NobodyCamjlvillal: getting better may even try and make it to my desk tomorrow :)02:57
jlvillalNobodyCam, Glad to hear you are getting better02:57
* jlvillal just watched a music video on tieing a know...02:57
NobodyCamtieing a know?02:59
NobodyCamknot?02:59
*** Nisha_brb has joined #openstack-ironic03:00
jlvillalNobodyCam, A knot03:00
*** baoli has quit IRC03:00
NobodyCam:)03:00
jlvillalNobodyCam, https://www.youtube.com/watch?v=TUHgGK-tImY   Norwegian band or swedish???03:01
jlvillalLOL03:01
NobodyCamoh cool :)03:01
jlvillalJust dumb enough to be entertaining.03:01
NobodyCamyou ever watch the euro star stuff03:01
jlvillalNobodyCam, I have not.03:02
jlvillalAnd the video within the video: https://www.youtube.com/watch?v=UEXcVvxmV3s03:02
* jlvillal is pretty sure the guy is wearing a toupee03:04
NobodyCamhttps://www.youtube.com/watch?v=WKNRGc71hjc03:05
NobodyCameuro visoin not euro star later is a train03:06
jlvillalNobodyCam, Thanks03:06
cineramais eurovision on in the US??? need to watch03:06
jlvillalcinerama, That's usvision that's on in the US :P03:06
*** spandhe has quit IRC03:07
jlvillalNobodyCam, I'll have to ask my wife about that particular Eurovision entry :)03:11
*** dims has quit IRC03:19
NobodyCamjlvillal: that a few years old now :)03:20
NobodyCambutI still like it03:20
*** yuanying has joined #openstack-ironic03:21
*** yuanying_ has quit IRC03:23
*** baoli has joined #openstack-ironic03:25
*** Marga__ has quit IRC03:26
*** yuanying has quit IRC03:27
*** Marga_ has joined #openstack-ironic03:30
*** Nakato has quit IRC03:31
*** Marga_ has quit IRC03:35
openstackgerritKan proposed openstack/ironic: API to list nodes using the same driver  https://review.openstack.org/26400503:36
*** Marga_ has joined #openstack-ironic03:43
*** harshs has quit IRC03:45
*** Nakato has joined #openstack-ironic03:45
*** Marga_ has quit IRC03:47
*** baoli has quit IRC03:49
*** links has joined #openstack-ironic03:49
*** appu103_ has joined #openstack-ironic03:53
*** chlong_ has quit IRC04:03
openstackgerritDebayan Ray proposed openstack/ironic: Add clean step in iLO drivers to activate iLO license  https://review.openstack.org/25992104:04
openstackgerritKan proposed openstack/ironic: API to list nodes using the same driver  https://review.openstack.org/26400504:06
*** yuanying has joined #openstack-ironic04:10
*** Marga_ has joined #openstack-ironic04:16
*** Marga_ has quit IRC04:16
*** Marga_ has joined #openstack-ironic04:17
*** danimal has quit IRC04:30
*** deray has quit IRC04:41
*** deray has joined #openstack-ironic04:41
*** vaishnavi has joined #openstack-ironic04:41
*** jaybeale has joined #openstack-ironic04:45
derayGood morning all my Ironicers!04:47
*** kalpase has joined #openstack-ironic04:48
*** jaybeale has quit IRC04:51
*** phuongnh has joined #openstack-ironic04:56
vaishnavigood morning deray !04:56
derayvaishnavi, o/04:57
*** suro-patz has joined #openstack-ironic04:57
*** Haomeng has quit IRC05:16
*** Marga_ has quit IRC05:20
*** spandhe has joined #openstack-ironic05:25
openstackgerritvinay kumar muddu proposed openstack/ironic: Updated iLO driver documentation to recommend ipmitool version  https://review.openstack.org/27454705:25
*** suro-patz has quit IRC05:29
*** vinm213 has joined #openstack-ironic05:29
*** Marga_ has joined #openstack-ironic05:30
*** Haomeng|2 has joined #openstack-ironic05:34
openstackgerritKan proposed openstack/ironic: API to list nodes using the same driver  https://review.openstack.org/26400505:41
*** ChrisAusten has quit IRC05:42
*** Sukhdev has joined #openstack-ironic05:55
*** lucasagomes has quit IRC06:02
*** lucasagomes has joined #openstack-ironic06:02
*** spandhe_ has joined #openstack-ironic06:06
*** spandhe has quit IRC06:08
*** spandhe_ is now known as spandhe06:08
*** rcernin has joined #openstack-ironic06:09
*** shu-mutou-AWAY is now known as shu-mutou06:10
openstackgerritZhenguo Niu proposed openstack/ironic: Follow up nits of I57bf7cebfb6db805b6c521bacfef2993b16ce1ee  https://review.openstack.org/28636406:18
*** suro-patz has joined #openstack-ironic06:20
*** e0ne has joined #openstack-ironic06:23
*** hoangcx has quit IRC06:24
*** lucasagomes has quit IRC06:24
*** lucasagomes has joined #openstack-ironic06:27
*** e0ne has quit IRC06:31
*** thrash|g0ne has quit IRC06:33
*** e0ne has joined #openstack-ironic06:33
*** e0ne has quit IRC06:34
*** trown|outtypewww has quit IRC06:34
*** trown has joined #openstack-ironic06:35
*** suro-patz has quit IRC06:43
*** Sukhdev has quit IRC06:45
*** harlowja_at_home has quit IRC06:49
*** ishant has joined #openstack-ironic06:53
openstackgerritMerged openstack/ironic: [Devstack]Add ability to enable ironic node pty console  https://review.openstack.org/25627206:56
*** Marga_ has quit IRC06:57
*** achanda has quit IRC06:58
*** pas-ha has joined #openstack-ironic06:58
*** suro-patz has joined #openstack-ironic07:07
*** hoangcx has joined #openstack-ironic07:11
*** spandhe has quit IRC07:15
*** achanda has joined #openstack-ironic07:15
*** hoangcx has quit IRC07:26
*** suro-patz has quit IRC07:26
pas-hamorning Ironic07:28
*** bnemec has quit IRC07:36
*** bnemec has joined #openstack-ironic07:39
*** achanda_ has joined #openstack-ironic08:02
*** achanda has quit IRC08:04
*** achanda_ has quit IRC08:04
*** slagle has quit IRC08:06
*** achanda has joined #openstack-ironic08:08
*** pcaruana has joined #openstack-ironic08:09
openstackgerritZhenguo Niu proposed openstack/ironic-specs: Move ssh-console-support spec to 4.3  https://review.openstack.org/28643208:09
*** amotoki has quit IRC08:18
*** amotoki has joined #openstack-ironic08:19
*** achanda has quit IRC08:27
*** ifarkas has joined #openstack-ironic08:30
*** vaishnavi_r has joined #openstack-ironic08:32
*** vaishnavi has quit IRC08:32
*** ohamada has joined #openstack-ironic08:35
*** daemontool__ has joined #openstack-ironic08:38
*** daemontool_ has quit IRC08:41
*** ndipanov has joined #openstack-ironic08:44
openstackgerritRui Chen proposed openstack/python-ironicclient: Fix Resource.__eq__ mismatch semantics of object equal  https://review.openstack.org/25183608:47
*** openstackgerrit has quit IRC08:48
*** openstackgerrit has joined #openstack-ironic08:48
aarefievmorning all!08:55
*** athomas has joined #openstack-ironic09:01
*** _degorenko|afk is now known as degorenko09:02
*** mbound has joined #openstack-ironic09:06
*** jcoufal has joined #openstack-ironic09:10
*** ndipanov has quit IRC09:11
openstackgerritMerged openstack/ironic: Set node last_error in TaskManager  https://review.openstack.org/27399209:12
*** amotoki has quit IRC09:14
*** jistr has joined #openstack-ironic09:14
*** amotoki has joined #openstack-ironic09:19
lucasagomesmorning all :-)09:21
*** e0ne has joined #openstack-ironic09:28
*** keedya has quit IRC09:29
openstackgerritMerged openstack/ironic: Add db api layer for CRUD operations on node tags  https://review.openstack.org/23259809:32
*** dtantsur|afk is now known as dtantsur09:33
dtantsurMorning Ironic09:33
aarefievlucasagomes, dtantsur g'morning09:34
lucasagomesaarefiev, o/09:35
openstackgerritDmitry Tantsur proposed openstack/ironic: [devstack] set ipa-debug=1 for greater debugability  https://review.openstack.org/28601509:35
aarefievdtantsur: hey, will you against logging conf options at startup in inspector?09:37
aarefievas it does for ironic, it helps sometimes09:37
dtantsuraarefiev, not at all (provided they're logged on DEBUG level just as with Ironic)09:37
dtantsurfeel free to propose the patch09:37
aarefievdtantsur: cool, yep only on DEBUG, no options :)09:38
*** alineb_ has joined #openstack-ironic09:38
*** e0ne has quit IRC09:38
*** derekh has joined #openstack-ironic09:39
*** hoangcx has joined #openstack-ironic09:40
*** mkovacik has joined #openstack-ironic09:42
openstackgerritAnton Arefiev proposed openstack/ironic-inspector: Logging configuration options at startup  https://review.openstack.org/28647209:45
dtantsurthat was fast :)09:45
openstackgerritMoshe Levi proposed openstack/ironic: Adding InfiniBand Support  https://review.openstack.org/26426309:47
*** mgould has joined #openstack-ironic09:47
*** aarefiev has quit IRC09:48
*** aarefiev has joined #openstack-ironic09:49
aarefievit adds only 2 short lines  :)09:51
openstackgerritAnton Arefiev proposed openstack/ironic-inspector: Logging configuration options at startup  https://review.openstack.org/28647209:56
lucasagomesis it only here or gerrit is very slow today?09:57
aarefievlucasagomes: yeah, it's very slow  from yesterday09:59
lucasagomes:-(09:59
openstackgerritKan proposed openstack/ironic: API to list nodes using the same driver  https://review.openstack.org/26400510:00
mgouldmorning Ironic!10:05
dtantsurlucasagomes, very slow, I'd say10:06
openstackgerritDmitry Tantsur proposed openstack/ironic-inspector: Split ironic-related functions from utils to separate common.ironic module  https://review.openstack.org/28618410:07
*** ifarkas has left #openstack-ironic10:08
*** ifarkas has joined #openstack-ironic10:09
*** e0ne has joined #openstack-ironic10:11
lucasagomes:-(10:15
openstackgerritVaishnavi proposed openstack/ironic: Add support for dib based agent ramdisk in lib/ironic  https://review.openstack.org/26457910:25
sambetts|afkMorning all o/10:26
*** sambetts|afk is now known as sambetts10:26
dtantsurmorning sambetts10:26
*** ishant has quit IRC10:28
*** ndipanov has joined #openstack-ironic10:29
sambettsOh wow gerrit is being super slow today :(10:30
*** lucasagomes has quit IRC10:30
*** alineb_ has quit IRC10:31
*** alineb has joined #openstack-ironic10:31
*** lucasagomes has joined #openstack-ironic10:31
*** lucasagomes has quit IRC10:32
*** lucasagomes has joined #openstack-ironic10:32
-openstackstatus- NOTICE: Gerrit is going to be restarted due to poor performance10:36
*** ChanServ changes topic to "Gerrit is going to be restarted due to poor performance"10:36
sambetts++10:36
*** daemontool has joined #openstack-ironic10:36
*** lucasagomes has quit IRC10:37
*** lucasagomes has joined #openstack-ironic10:37
*** daemontool__ has quit IRC10:40
*** lucasagomes has quit IRC10:41
*** ChanServ changes topic to "Bare Metal Provisioning | Status: http://bit.ly/ironic-whiteboard | Docs: http://docs.openstack.org/developer/ironic/ | Bugs: https://bugs.launchpad.net/ironic"10:42
-openstackstatus- NOTICE: gerrit finished restartign10:42
*** lucasagomes has joined #openstack-ironic10:43
*** phuongnh has quit IRC10:45
openstackgerritBéla Vancsics proposed openstack/ironic: Use assertEqual/Greater/Less/IsNone  https://review.openstack.org/28649410:54
*** vaishnavi_r has quit IRC10:55
*** chlong_ has joined #openstack-ironic11:02
*** dims has joined #openstack-ironic11:03
*** hoangcx has quit IRC11:06
*** amotoki has quit IRC11:06
*** caiobo has quit IRC11:09
openstackgerritPavlo Shchelokovskyy proposed openstack/ironic-inspector: Use keystoneauth for Ironic client  https://review.openstack.org/28651011:22
aarefievsambetts: morning11:24
aarefievdtantsur, sambetts, guys, what do you think about set up new ipmi cred during discovery(via rules?)11:25
dtantsuraarefiev, I thought about it, would be good probably to have a separate spec, as it might have interesting consequences11:26
aarefievdtantsur: yeah, a lot of question here, I'll try to gather some thoughts in spec11:29
sambettsIts an interesting idea, I'd be a bit wary if we started making rules be able to take actions on the node itself :/11:31
aarefievsambetts: not necessary do this from rules11:34
openstackgerritPavlo Shchelokovskyy proposed openstack/ironic-inspector: Do not manage power on nodes in 'enroll' state  https://review.openstack.org/28651411:34
openstackgerritPavlo Shchelokovskyy proposed openstack/ironic-inspector: Add CMDB support  https://review.openstack.org/28651511:34
openstackgerritSergii Turivnyi proposed openstack/python-ironicclient: Add sanity tests for testing actions with Port  https://review.openstack.org/24094411:35
dtantsurpas-ha, any plans to update the CMDB spec btw? https://review.openstack.org/25305411:37
pas-hayeah, just going back to it now11:37
openstackgerritSergii Turivnyi proposed openstack/python-ironicclient: Add sanity tests for testing actions with Port  https://review.openstack.org/24094411:38
dtantsurifarkas, sambetts, hey guys, there are quite a few inspector patches up, some with 1x +2 already, could you please help cleaning the review queue? :) https://review.openstack.org/#/q/project:openstack/ironic-inspector+status:open11:41
dtantsurwe should finish the whole feature work this week11:41
sambettsSure, I'll run through them in just a moment :)11:41
ifarkasdtantsur, I was looking at them but a few had a +2 and an unanswered comment11:44
ifarkaseg https://review.openstack.org/#/c/279135/11:44
dtantsurifarkas, I can follow-up with nit-fixing11:44
ifarkasdtantsur, works for me11:45
vinm213lucasagomes, regarding https://review.openstack.org/#/c/24603611:54
vinm213i have seen you comments11:54
*** shu-mutou is now known as shu-mutou-AFK11:54
openstackgerritZhenguo Niu proposed openstack/ironic: Follow up nits of 3429e3824c060071e59a117c19c95659c78e4c8b  https://review.openstack.org/28636411:55
lucasagomesvinm213, hi there, yes?11:55
vinm213But my doubt here is, we actually want to create the RequestContext object for user='admin' and tenant='admin'11:55
vinm213where as get_admin_context() creates them with None, None11:56
vinm213I don't have much understanding into what oslo's context does.11:57
lucasagomesvinm213, ok that's fine, but I don't see any explanation in the patch or bug why the user has to be "admin" ?11:57
lucasagomesvinm213, me neither :-/11:57
lucasagomesit even surprises me, how did that code worked before? And the tests didn't fail11:57
vinm213hmm...11:58
*** amotoki has joined #openstack-ironic11:58
lucasagomesvinm213, so I'm not against having the "admin" but we need to iron out the why's11:59
vinm213ok..so it's ok to have an object with default parameters.11:59
openstackgerritAnton Arefiev proposed openstack/ironic-inspector: Add discover nodes exercise  https://review.openstack.org/27610711:59
openstackgerritAnton Arefiev proposed openstack/ironic-inspector: Add enroll_node_not_found hook  https://review.openstack.org/28131211:59
openstackgerritSergii Turivnyi proposed openstack/python-ironicclient: Negative tests for testing actions with port.  https://review.openstack.org/25935412:00
openstackgerritAnton Arefiev proposed openstack/ironic-inspector: Add discover nodes exercise  https://review.openstack.org/27610712:00
openstackgerritAnton Arefiev proposed openstack/ironic-inspector: Add enroll_node_not_found hook  https://review.openstack.org/28131212:00
lucasagomesJayF, we haven't merged a patch of yours that prevented the node to be powered off if the deployment failed? Or I made that up in my head?12:03
sinvalmorning Ironicers12:04
lucasagomessinh, morning12:04
lucasagomesops... sinval ^12:06
sinvallucasagomes, o/12:06
*** daemontool_ has joined #openstack-ironic12:07
*** amotoki has quit IRC12:07
*** daemontool has quit IRC12:10
*** raildo-afk is now known as raildo12:18
*** vinm213 has quit IRC12:24
openstackgerritMerged openstack/ironic-inspector: Logging configuration options at startup  https://review.openstack.org/28647212:25
openstackgerritMerged openstack/ironic-inspector: Stop storing ramdisk logs with the introspection data  https://review.openstack.org/27913512:28
*** daemontool__ has joined #openstack-ironic12:34
derayg'morning all :)12:36
sinvalmorning deray12:37
*** daemontool_ has quit IRC12:37
deraysinval, o/12:37
TheJuliaGood morning12:38
derayTheJulia, g'morning12:38
sambettso/ TheJulia12:39
sinvalmorning TheJulia sambetts12:39
* deray feels there's less chance of firmware update (manual cleaning step) to get in this release12:42
openstackgerrityolanda.robla proposed openstack/bifrost: Add script and playbook to test dhcp  https://review.openstack.org/27617712:45
openstackgerritDmitry Tantsur proposed openstack/ironic-inspector: Clarify that we don't maintain compatibility for stored data  https://review.openstack.org/28655612:46
dtantsurderay, I'm afraid so :( we have too many things to finish this week12:46
dtantsurand morning sinval, deray, TheJulia12:47
sinvalo/ dtantsur12:47
deraydtantsur, g'morning..12:47
derayIs this (https://review.openstack.org/#/c/278566) one of the items which requires immediate attention?12:48
dtantsuraarefiev, +A on discovery patch :)12:49
dtantsur(provided that tests pass, heh :)12:49
dtantsurderay, yep12:49
deraydtantsur, yeah.. i agree12:49
openstackgerritMerged openstack/ironic: Use assertEqual/Greater/Less/IsNone  https://review.openstack.org/28649412:51
openstackgerritMerged openstack/ironic-inspector: Add invert option to rule conditions  https://review.openstack.org/28060312:51
sambetts\o/ all the mergy merges!12:51
*** amotoki has joined #openstack-ironic12:52
*** baoli has joined #openstack-ironic12:54
aarefievYippee!12:55
aarefiev:)12:55
deraydtantsur, will try then to close in on that..12:56
openstackgerritAnton Arefiev proposed openstack/ironic-inspector-specs: Sync auto-discovery spec with impl  https://review.openstack.org/28656712:57
aarefievsambetts: could you go over https://review.openstack.org/#/c/286567 when have time12:59
sinvalhey sambetts, check this out  https://review.openstack.org/286192 dynalloc for OneView drivers12:59
* sambetts is popular 12:59
aarefievtoday sambetts is popular13:00
aarefiev:)13:00
sambettsI'll add them to my list :D13:00
TheJuliasambetts: just remember that it is okay hide from people too :)13:00
*** kalpase has left #openstack-ironic13:00
sambetts:-P13:00
TheJuliaas in "I need to get some work done"13:00
sambettsTheJulia: haha yes :-P these give me something to do while I'll waiting for devstack13:00
sambettss/I'll/I'm/13:01
TheJulia:)13:01
*** dims has quit IRC13:02
*** mgoddard_ has joined #openstack-ironic13:04
openstackgerritAnton Arefiev proposed openstack/ironic-inspector: Add db migrations tests  https://review.openstack.org/28479213:05
*** ndipanov_ has joined #openstack-ironic13:05
openstackgerritDmitry Tantsur proposed openstack/ironic-inspector: [devstack] Improve virtual machines logs  https://review.openstack.org/28541213:06
dtantsursambetts, should work ^^ but lets see13:06
*** ndipanov has quit IRC13:06
sambettsdtantsur: thanks :D13:07
*** mgoddard has quit IRC13:07
*** links has quit IRC13:07
*** dims has joined #openstack-ironic13:08
*** smoriya_ has quit IRC13:11
*** lucasagomes is now known as lucas-hungry13:15
*** appu103_ has quit IRC13:19
*** dprince has joined #openstack-ironic13:25
*** mgoddard_ has quit IRC13:26
*** mgoddard_ has joined #openstack-ironic13:27
trowndtantsur: do the failures here look related to the patch? https://review.openstack.org/#/c/286069/13:27
trowndtantsur: I just see a timeout when trying to power on a node in one tempest test13:27
* dtantsur checks13:28
dtantsurtrown, I suspect something wrong with Liberty gate, another patch also fails all the jobs13:29
*** mjturek1 has quit IRC13:30
trowndtantsur: ok, I will come back to those patches later13:30
openstackgerritMoshe Levi proposed openstack/ironic-inspector: Adding InfiniBand Support  https://review.openstack.org/26425713:31
*** slagle has joined #openstack-ironic13:33
*** mjturek1 has joined #openstack-ironic13:35
*** ndipanov_ is now known as ndipanov13:37
aarefievdtantsur: is it possible to merge auto-discovery job before exercise script?13:39
*** baoli has quit IRC13:40
aarefievsambetts: thanks for review13:40
dtantsuraarefiev, if it's non-voting - yes (at least no objections from me)13:40
*** baoli has joined #openstack-ironic13:40
aarefievdtantsur: ok, lets try, I'll rebase infra patch13:41
*** baoli has quit IRC13:43
*** baoli has joined #openstack-ironic13:43
*** Marga_ has joined #openstack-ironic13:46
*** Marga_ has quit IRC13:50
*** sinval has quit IRC13:53
*** mbound has quit IRC13:56
*** sinval has joined #openstack-ironic14:00
*** derekh is now known as ndipanov_14:04
*** ndipanov_ is now known as derekh14:04
*** cdearborn has joined #openstack-ironic14:06
openstackgerritVladyslav Drok proposed openstack/python-ironicclient: Use keystoneauth instead of keystoneclient  https://review.openstack.org/27572214:07
sambettsaarefiev, dtantsur: it would be good to get the nv job merged before the actual exercise so we can see if it works :)14:07
dtantsuryeah14:07
aarefievsambetts: yeah, it's my plan14:08
sambetts:D coolio14:08
*** baoli has quit IRC14:08
openstackgerritMerged openstack/ironic-inspector: Add enroll_node_not_found hook  https://review.openstack.org/28131214:09
*** lucas-hungry is now known as lucasagomes14:09
dtantsur\o/14:09
sambetts\o/ !!14:09
*** baoli has joined #openstack-ironic14:12
derayvdrok_, yuriyz got a chance to look at the new patch set of https://review.openstack.org/#/c/211019/14:13
*** thiagop has joined #openstack-ironic14:14
thiagopGood morning, Ironic14:14
mkovacikdtantsur, w/r the --dhcp-sequential-ip I've not yet tested that, though14:14
yuriyzderay ok will try to look today14:14
dtantsurmkovacik, let the gate test :D14:14
derayyuriyz, sure.. tyt14:14
*** baoli has quit IRC14:15
mkovacikdtantsur, sounds like broken gate :D14:15
*** mbound has joined #openstack-ironic14:15
* mkovacik hopes dnsmasq rotates the IP eventually14:17
*** baoli has joined #openstack-ironic14:22
*** baoli has quit IRC14:23
*** baoli has joined #openstack-ironic14:25
*** jroll has quit IRC14:29
*** jroll has joined #openstack-ironic14:30
*** jroll has quit IRC14:30
*** jroll has joined #openstack-ironic14:30
*** mbound has quit IRC14:30
openstackgerritPavlo Shchelokovskyy proposed openstack/ironic-inspector-specs: CMDB integration  https://review.openstack.org/25305414:33
*** mbound has joined #openstack-ironic14:34
*** mgould has quit IRC14:35
*** baoli has quit IRC14:39
*** d0ugal has quit IRC14:39
*** d0ugal has joined #openstack-ironic14:40
*** d0ugal has quit IRC14:40
*** d0ugal has joined #openstack-ironic14:41
*** baoli has joined #openstack-ironic14:41
*** mgould has joined #openstack-ironic14:50
*** sinval is now known as sinval-afk14:50
derayjroll, dtantsur lucasagomes there is also a small patch related to ilo license activation as a amanual cleaning step..14:52
derayif possible can you have a look? https://review.openstack.org/#/c/25992114:53
*** daemontool_ has joined #openstack-ironic14:53
*** harshs has joined #openstack-ironic14:55
*** daemontool__ has quit IRC14:56
*** kan_ has quit IRC14:56
*** e0ne has quit IRC14:56
derayokay .. g'day ahead folks14:56
*** deray has quit IRC14:57
*** [1]cdearborn has joined #openstack-ironic14:57
lucasagomesdera...15:01
*** harshs has quit IRC15:02
*** spandhe has joined #openstack-ironic15:03
*** spandhe has quit IRC15:03
*** rbudden has joined #openstack-ironic15:04
*** jaybeale has joined #openstack-ironic15:06
*** Goneri has joined #openstack-ironic15:10
*** cdearborn has quit IRC15:11
openstackgerritDmitry Tantsur proposed openstack/ironic-inspector: Split ironic-related functions from utils to separate common.ironic module  https://review.openstack.org/28618415:13
openstackgerritSam Betts proposed openstack/ironic-inspector: [devstack] Improve virtual machines logs  https://review.openstack.org/28541215:15
sambettsdtantsur: I had to rebase that ^ , I derped a +W'd it15:16
openstackgerritGonéri Le Bouder proposed openstack/ironic-lib: use wipefs to erase FS meta information  https://review.openstack.org/28628315:16
* jlvillal is happy that after about a total of 6-8 hours (including time over the weekend) he finally figured out how to get VLANs working on his Mikrotik Cloud Router Switch15:16
dtantsursambetts, it's usually enough to just remove +A :) anyway I hope ifarkas will +A it for us ;)15:17
sambettsdtantsur: ah, i thought only a rebase would stop it after a +A15:17
jlvillalNote to others, only create ONE master port if you want VLANs. Mikrotik needs to work on making their stuff easier to use!!!15:17
sambettsjlvillal: ?15:17
ifarkassambetts, dtantsur, sure thing, looks good ;-)15:18
jlvillalsambetts, They probably make Cisco look easy to use :P15:18
dtantsurlol15:19
jlvillalsambetts, It is a cool device for the money.  24 port L2 switch with some L3 routing capabilities possible (but performance for the L3 stuff is not great). Cost was $179.15:19
sambettsjlvillal: haha, I've only ever used dumb switches outside of work, although I've been thinking about upgrading my home network15:21
jlvillalsambetts, Yeah that is what this is for. I want to setup a guest wireless on a separate VLAN and isolate it from my home network. Mostly for fun.15:21
* jlvillal has a strange idea of fun15:21
* thiagop agrees15:22
sambettsjlvillal: its not that strange I love tinkering that stuff at home too :-P15:22
jlvillalI was thinking, why does my WiFi enabled scale need to be on my main home WiFi network. Or my Nest Thermostat or various other things.15:22
jlvillalsambetts, It was very frustrating when it didn't work. But it did make it much sweeter when I finally figured it out :)15:23
jlvillalthiagop, Did you finish your DS-160. I remember doing it with my wife and it was a LONG form!!15:23
thiagopjlvillal: yes, I did. I'm only waiting for the invitation letter of the OSF to schedule my visa interview15:24
*** daemontool__ has joined #openstack-ironic15:24
sambettsjlvillal: it always is :-P I ran into annoying issues with my 5Ghz wifi recently and that took ages to work out15:24
jlvillalthiagop, Sweet!15:24
*** jaybeale has quit IRC15:24
thiagopjlvillal: painful, but very funny too15:24
jlvillalsambetts, But you felt good when you solved it!15:24
dtantsurthiagop, oh yeah, a lot of fun :)15:25
dtantsurwill you need an interview?15:25
*** raddaoui has joined #openstack-ironic15:25
jlvillalthiagop, The history questions were tough. Trying to figure every place my wife had lived since age 16 :(15:25
thiagopdtantsur: yes, we brazillians need15:26
dtantsurjlvillal, remembering school etc...15:26
thiagopjlvillal: tough was to discover the date I started my undergrad. I don't have it in any documents... haha15:27
*** mtanino has joined #openstack-ironic15:27
jlvillaldtantsur, My wife has moved a fair amount over the last 20+ years. I know that would be tough for me to figure out.15:27
jlvillalA lot easier if you are in your 20s...15:28
*** daemontool_ has quit IRC15:28
thiagopbut those questions about organs traffic made me laugh 10min15:28
dtantsurthiagop++15:28
sambettsman... the benefits of being a UK citizen are insane when it comes to travel...15:29
dtantsuryep :(15:30
dtantsurwell, US, EU and UK probably only need a visa to Russia and North Korea :D15:30
jlvillalsambetts, Yep US and UK citizens have it nice for the most part in not needing visas for many countries.15:31
sambettsjlvillal: although I have to have a travel visa thingy for the US :-P15:32
sambettsjlvillal: but its literally 1 web form15:32
jlvillalReally? I thought it was the Visa Waiver Program15:33
jlvillalAh, so a sort of pre-screen thing.15:33
sambettsjlvillal: its called an ESTA whatever that stands for15:33
jlvillalsambetts, Electronic System for Travel Authorization15:34
sambettsyeah that :-P15:34
jlvillalThat is a lot easier than a visa.15:34
sambettsyup15:35
* jlvillal needs to go get ready to go into work...15:35
sambettsI had to go through a full visa application for the US a couple of years ago when I lived in san jose for a year15:35
*** mbound has quit IRC15:40
*** mbound has joined #openstack-ironic15:40
lucasagomessambetts, ++ for ESTA15:40
*** keedya has joined #openstack-ironic15:40
keedyaGood morning All!!!15:41
TheJuliagood morning15:41
lucasagomesthe questions are quite funny/straight forward tho, e.g: "Are you a terrorist? (Yes/No)"15:41
sambettslucasagomes: ahaha yes15:41
lucasagomeskeedya, TheJulia morning15:45
*** amotoki has quit IRC15:46
thiagopmorning keedya TheJulia15:46
keedya0/15:47
thiagoplucasagomes: there was one that made me think15:47
openstackgerritMilan Kováčik proposed openstack/ironic-inspector: Allow rerunning introspection on stored data  https://review.openstack.org/26763715:47
krotscheckAnyone here super crazy familiar with how ironic does configgen?15:47
thiagopit versed about "extrajudicial killing".15:47
devanandamorning, all15:48
NobodyCamGood morning Ironicers15:48
thiagopmorning devananda NobodyCam15:48
lucasagomesthiagop, ouch15:48
lucasagomesdevananda, NobodyCam morning15:48
NobodyCammorning :)15:48
thiagoplucasagomes: that's weird. If I'm authorized to kill by a judge, is it ok then?!15:48
sambettso/ devananda15:48
lucasagomesthiagop, heh I guess if you work to the government in some cases that may be applicable15:49
lucasagomese.g, death penalty15:50
lucasagomeswork for*15:50
thiagopjuditially ok, but humanly it is kinda ugly15:51
*** jaybeale has joined #openstack-ironic15:51
lucasagomesagree, not very ethical15:51
devanandadtantsur: china, brazil, india (up until this year). not many, just a few big ones ;)15:51
dtantsur:)15:52
devanandakrotscheck: you mean tools/config/generate_sample.py ?15:52
dtantsurmorning devananda, keedya, NobodyCam15:52
NobodyCammorning dtantsur15:52
krotscheckdevananda: Yep15:53
krotscheckdevananda: oslo.config's generate-config just added the ability to override default values for the output config, and... well, it seems like Ironic's not using it at all.15:53
devanandakrotscheck: then yes :)15:53
NobodyCamsorry was reading all the emails I have, didn't do the full good morning today15:53
devanandakrotscheck: oh, interesting. I wasn't aware of that. you're probably right - we probably raen't using that15:53
krotscheckI have a mitaka blocker bug that may force me to shave that yak.15:54
krotscheckIf it's something the team wants.15:54
devanandadtantsur: are there any CLI's that I can use to talk to ironic-inspector besides openstackclient?15:54
dtantsurdevananda, nope.. we don't have a dedicated CLI like ironic15:55
devanandadtantsur: hrmm... ok. I'm having difficulty using openstackclient *without* keystone15:55
devanandasince I want to use inspector inside of a bifrost env, there is no keystone15:56
dtantsurdevananda, I thought it's possible, to be honest, but not sure how15:56
* dtantsur researches15:56
dtantsurdevananda, openstack --os-auth-type token_endpoint --os-token fake --os-url http://127.0.0.1:505015:58
dtantsurmaybe something like that?15:58
devanandadtantsur: I've tried that, but osc is failing. maybe a bug? I dunno.15:58
krotscheckdevananda: Is there any reason why I cannot make that switch?15:58
devanandakrotscheck: I am unclear on exactly what you're proposing to change16:00
dtantsurdevananda, weird, it works for now, but crashes for inspector-client.. I'll take a look16:00
krotscheckdevananda: Get rid of generate_sample.py, use oslo's generator instead?16:00
devanandakrotscheck: oh! nope, we tried that. it's terrible16:01
devanandakrotscheck: more specifically, it makes assumptions about things that are not valid for Ironic16:02
krotscheckdevananda: Such as?16:02
devanandakrotscheck: we decided not to refactor dozens of files and change where and how we define config options16:02
devanandajust because oslo introduced a new way to do it16:02
devanandalucasagomes: IIRC< I believe you did the prototyping work on ^ before we agreed not to go that path?16:02
devanandadtantsur: thanks!16:03
krotscheckdevananda: Ok, so, the snowflake argument.16:03
devanandakrotscheck: no, the "it works fine the way it is" argument16:03
* lucasagomes reads16:03
devanandakrotscheck: is there a compelling reason for us to go through all that work?16:03
lucasagomesdevananda, krotscheck oh yes we did that before16:04
lucasagomesdevananda, krotscheck the reason we didn't like it was because we had to put _all_ options in a file, and keep maintaing it every time a new option was added16:04
lucasagomesAFAIR16:04
krotscheckdevananda: I have a mitaka-blocker bug that says that I need to A) make sure that no cors headers be hardcoded, B) that those same headers need to be set as the config defaults via oslo's new config override, and c) that those same default headers be expressed in the generated config.16:04
krotscheckC) is handled by the new genconfig hooks in oslo.16:05
jlvillalsambetts, dtantsur Funny I open up cnn.com and see this :)  http://www.cnn.com/2016/03/01/travel/worlds-best-worst-passports/index.html16:05
krotscheckB) Is handled via set_dfaults, which I already have working.16:05
krotscheckA) is just deleting a few lines from app.py16:05
sambettsjlvillal: haha16:06
krotscheckI simply do not have the time to backport the necessary code from oslo configgen into ironic's generator.16:06
devanandakrotscheck: is it possible for C to be done without deleting generate_sample.py16:06
*** suro-patz has joined #openstack-ironic16:06
krotscheckdevananda: I have 23 patches to get working.16:06
krotscheckAnything is possible. Not in my timeframe.16:06
devanandakrotscheck: removing generate_sample.py and using oslo's configgen will take a lot of work on our side, too16:07
devanandait's not just "start using configgen"16:07
dimsdevananda : there's a set of reasons for doing what we did, here it is - https://specs.openstack.org/openstack/oslo-specs/specs/juno/oslo-config-generator.html16:07
krotscheckdevananda: So what's the best solution?16:07
devanandaand it will introduce ongoing maintenance burden on our reviewers and devs16:07
lucasagomeskrotscheck, devananda https://review.openstack.org/#/c/247331/16:08
lucasagomestanlin also had a patch for oslo.config generation16:08
lucasagomesand this was the original one: https://review.openstack.org/#/c/137447/16:08
lucasagomesit's huge and messy16:09
lucasagomesIMHO, I dunno why oslo.config generation was created the way it currently is16:09
dimslucasagomes : see spec above16:09
lucasagomessome people pointed that it's because you can split in more than one sample file16:09
lucasagomesdims, lemme read that16:10
devanandadims: I understand the reasoning, but it would require a significant refactoring of our code, and either A) change the way (where and how) we define config options or B) require listing dozens of entry points16:10
dimslucasagomes : that's not the only reason, the old one did not work in many situations16:10
*** chlong_ has quit IRC16:10
openstackgerritMonty Taylor proposed openstack/python-ironicclient: Do not pass endpoint to constructor in OSC  https://review.openstack.org/28668116:10
dimsdevananda : that's fair, please don't say "just because oslo introduced a new way to do it "16:10
dimsdevananda : not trying to create work here16:11
dimstrying to fix problems we see16:11
krotscheckdevananda: Most of the other projects have adopted it without too much of a dev overhead or gnashing of teeth. I don't think your argument has teeth.16:11
* dims back in a bit16:12
*** max_lobur has quit IRC16:12
lucasagomesdims, interesting... The thing that annoys me was that we had the script to generate the sample for a long time in the incubator16:12
lucasagomesbut once it graduated it was completely redesigned16:13
lucasagomesI mean, why incubate something for so long and then just rewrite it at graduation time?16:13
krotschecklucasagomes: Seems like that's water under the bridge now, no?16:13
devanandadims: full context there was that we looked at what oslo did, it didn't work for us, and "oslo introduced a new way to do X" isn't (in the absence of a compelling reason in Ironic, and in the presense of significant work) a compelling reason16:13
lucasagomesbut yeah, reading the spec I understand it better16:13
*** e0ne has joined #openstack-ironic16:13
lucasagomeskrotscheck, seems like the wrong way of doing it16:13
lucasagomesand we haven't adopted the new way because of that16:14
devanandalucasagomes: I agree, it's strange that it changed when it graduated. not the way oslo libs have been handled in general16:14
krotschecklucasagomes: I don't disagree. But that's what happened.16:14
lucasagomesit's bad architected16:14
*** jaypipes has joined #openstack-ironic16:14
devanandakrotscheck: I'm not sure what you mean by "it's water under the bridge"16:14
krotschecklucasagomes: I'm sure the port of seattle would like to extract the billion dollar tunnel boring machine that's stuck under the city too, but fact is the thing can only move forward.16:15
devanandakrotscheck: that argument does not apply here. this is code, not a billion dollar physical machine that can't go in reverse16:15
keedyamorning dtanstur 0/16:15
krotscheckdevananda: I'm saying that an argument about "This was handled poorly in the past" is not really an argument. The argument is about the present.16:15
lucasagomeskrotscheck, I mean the script we have *works* for us so far... now you discover a problem with it16:16
krotscheckdevananda: Ok, so, revert the config things in oslo? Or go back in time so things didn't happen the way you don't like it to happen?16:16
devanandakrotscheck: and in the present, Ironic has a working config generator. and oslo decided to take an approach that, when we last looked at it, didn't fit16:16
lucasagomesand we have to deal with it, so we can argue either fixing the current script or moving to the new oslo.config16:16
devanandakrotscheck: I'm saying, what's WRONG with what we are doing now?16:16
devanandait works FOR US16:16
lucasagomesI'm just saying the oslo.config one is disruptive and IMHO not very well designed16:16
krotscheckdevananda: Does it work IN CAPS?16:17
dtantsurdevananda, good news for you: we do have a bug and its fixed in master16:17
devanandakrotscheck: totally :)16:17
dtantsurdevananda, mind trying python-ironic-inspector-client from git master?16:17
devanandadtantsur: oh? great - I'll test16:17
krotscheckOk, so, I don't have time for this argument, I have 22 other projects to deal with.16:17
keedyadtanstur: Back to our conversation yesterday, where do you think i can start?16:17
krotscheckI will file a mitaka-blocker bug against ironic and let y'all figure it out.16:17
lucasagomeskrotscheck, fair enough, I think the bug is the way to go yes16:18
devanandakrotscheck: ok. in that bug, please explain why our config generator is unable to do what you need. because I do not understand it yet16:18
devanandathe only reason I heard from you was "i dont have time"16:18
devanandabut I don't know what you dont have time to do16:18
lucasagomesbut we need to discuss it with time and make the right decisions16:18
lucasagomesbecause your time != time for the project16:18
devanandaif there is a compelling reason for Ironic to use oslo configgen -- ok, we'll discuss what that means for us. I just haven't seen it yet16:19
dtantsurit's pretty convenient, but it probably does not justify the whole refactoring..16:22
*** mmedvede has joined #openstack-ironic16:22
*** garthb has joined #openstack-ironic16:23
keedyadtantsur: Back to our conversation yesterday, u mentionned integrating with CMDB.16:24
keedyais that in ironic inspector?16:24
sambettsthat is something we are working towards in inspector16:24
dtantsurkeedya, we're discussing it right now in https://review.openstack.org/25305416:25
dtantsurwould be great to have your input as well16:25
dtantsuryuriyz, anything preventing you from W+1 on https://review.openstack.org/#/c/286015/ ?16:26
*** danimal has joined #openstack-ironic16:26
dimsdevananda : it's funny, you do use the the good things made possible by oslo-config-generator (https://github.com/openstack/ironic/blob/master/ironic/common/config_generator/generator.py#L124)16:27
*** danimal has quit IRC16:30
openstackgerritGonéri Le Bouder proposed openstack/ironic: ipxe: add --timeout parameter to kernel and initrd  https://review.openstack.org/28389316:31
openstackgerritDevananda van der Veen proposed openstack/python-ironicclient: Do not pass endpoint to constructor in OSC  https://review.openstack.org/28668116:32
lucasagomesdims, (-: yeah, ironic have been maintain that script, adding new things etc...16:32
*** absubram has joined #openstack-ironic16:32
dimslucasagomes : best of luck is all i can say :)16:33
*** absubram_ has joined #openstack-ironic16:33
lucasagomesdims, heh right16:34
krotscheckdevananda: I need the generated configuration to include default overrides.16:35
krotscheckdevananda: I've included a reference patch in the bug.16:36
krotscheckdevananda: Good luck maintaining your own config script!16:36
*** suro-patz has quit IRC16:37
*** absubram has quit IRC16:37
*** absubram_ is now known as absubram16:37
*** suro-patz has joined #openstack-ironic16:37
*** e0ne has quit IRC16:38
devanandadtantsur: confirmed the version in git works. current release does not.16:39
dtantsurdevananda, I hope the git master will become the current release tonight :)16:40
devanandadtantsur: :)16:40
*** e0ne has joined #openstack-ironic16:40
*** mgoddard_ has quit IRC16:40
*** mgoddard has joined #openstack-ironic16:40
*** vinm213 has joined #openstack-ironic16:41
*** rbradfor has joined #openstack-ironic16:42
openstackgerritGonéri Le Bouder proposed openstack/ironic-python-agent: iscsi: wipe part table before starting the target  https://review.openstack.org/28434716:42
dtantsurdevananda, left you some debugging hints on https://bugs.launchpad.net/python-ironicclient/+bug/155183716:46
openstackLaunchpad bug 1551837 in python-ironicclient "openstackclient generates traceback with AUTH=token_keystone" [Low,In progress] - Assigned to Devananda van der Veen (devananda)16:46
openstackgerritOpenStack Proposal Bot proposed openstack/ironic: Updated from global requirements  https://review.openstack.org/28398316:51
*** rcernin has quit IRC16:55
JayFlucasagomes: that patch is sitting with a moldy -1. I hope to be able to refocus on upstream stuff in the next week or two and that'll be on the top of my list.16:55
*** trevor___ has joined #openstack-ironic16:55
lucasagomesJayF, oh right, no worries... It's because I had an item in my todo list to give it a go16:55
lucasagomesJayF, so I was setting up the env but couldn't find the configuration option16:55
lucasagomesI thought it was merged already16:55
devanandaTheJulia: is there a flag to bifrost to tell it to install everything from git (instead of pip) ?16:56
trevor___Hi everyone, I have a bug fix proposed in IPA but it needs the workflow approved. It hasn't been updated in 6 days, is there something I can do to get it looked at?16:57
trevor___https://review.openstack.org/#/c/280970/16:57
dtantsurJayF, ^^16:57
lucasagomestrevor___, what you just did :-) yeah point it to us here in the channel16:57
lucasagomesit helps it to get attention16:57
trevor___I thought so, thanks!16:58
* lucasagomes looks at the patch16:58
lucasagomestrevor___, np, sometimes we need to be reminded to do the review job (-:16:58
* JayF +2a16:58
*** mgoddard_ has joined #openstack-ironic16:58
*** rloo has joined #openstack-ironic16:59
openstackgerritGonéri Le Bouder proposed openstack/ironic-lib: use wipefs to erase FS meta information  https://review.openstack.org/28628317:00
*** mbound has quit IRC17:01
*** mgoddard has quit IRC17:01
*** ifarkas has quit IRC17:05
*** jistr has quit IRC17:05
*** pcaruana has quit IRC17:07
Gonerihttp://logs.openstack.org/83/286283/2/check/gate-tempest-dsvm-ironic-lib-src/3e05852/logs/screen-ir-cond.txt.gz17:10
GoneriI added a wipefs call in https://review.openstack.org/28628317:10
*** achanda has joined #openstack-ironic17:10
mkovacikaarefiev, dtantsur, guys, do you prefer not saving the logs in the incoming data w/r introspection reapply patch?17:11
mkovacikin swift I mean17:11
Gonerishould I also patch ironic itself to add wipefs in ironic-lib.filters17:11
dtantsurmkovacik, good call, we should store them in a file on receiving anyway17:11
GoneriI guess, it's a yes.17:12
jrollGoneri: I guess so, that's odd though17:12
jrollor maybe s/odd/sad/17:12
jrollyou know about depends-on btw?17:12
*** stendulker has joined #openstack-ironic17:13
mkovacikdtantsur, so you want the logs or not in the swift -incoming? ;) sorry, English parser overflow ;)17:13
mkovacikaarefiev doesn't17:13
mkovacikI'd keep17:13
Gonerijroll, yep I do. thanks17:13
jrollcool17:13
dtantsurmkovacik, kill them with fire :D actually, maybe we should just remove them in the ramdisk_error plugin right after saving17:13
mkovacikdtantsur, OK :D17:14
*** MattMan has quit IRC17:14
*** trevor___ has quit IRC17:14
*** MattMan has joined #openstack-ironic17:14
lucasagomesGoneri, very odd... you may have uncovered a bug there17:15
lucasagomeswhy the filters not being applied :-/17:15
dtantsurdevananda, python-ironic-inspector-client 1.5.0 released17:17
*** dims_ has joined #openstack-ironic17:17
Gonerilucasagomes, https://github.com/openstack/ironic/blob/053584c982d8f47862824f191e6e4e7663b132de/etc/ironic/rootwrap.d/ironic-lib.filters17:17
lucasagomesGoneri, yes, that shouldn't be there IMHO17:17
Gonerilucasagomes, this file is a copy/past of the same ironic-lib.filters from ironic-lib17:18
*** raddaoui has quit IRC17:18
lucasagomesGoneri, yeah... apparently devstack is not copying the ironic-lib one to the right place17:18
Gonerilucasagomes, the error message is confusing too. it says the call comes from ironic.drivers.modules.deploy_utils17:18
*** dims has quit IRC17:19
Goneribut it's actually in ironic_lib.disk_utils17:19
openstackgerritJim Rollenhagen proposed openstack/ironic: Clean up driver loading in init_host  https://review.openstack.org/28585017:19
*** raddaoui has joined #openstack-ironic17:19
openstackgerritlokesh s proposed openstack/ironic: Add support for the audit  middleware  https://review.openstack.org/27265817:19
lucasagomesGoneri, yeah, something fishy there, these filters should exist in only one place17:19
keedyadtantsur: I read through the proposal and about the IPMI credentials. Is it possible to use the abstraction layer(CMDB) to run all the ipmi cmds?17:20
lucasagomesjroll, what do you think? Should we delete the one in ironic-lib and all the rootwrap filters in Ironic?17:20
*** athomas has quit IRC17:21
lucasagomesthat way we don't break ppl, because if we get rid of the ironic one the ironic-lib will need to be copied to the right place too17:21
dtantsurkeedya, depending on what exactly you want to do, I guess? inspector needs to boot the machine, so it needs the credentials in advance17:21
jrolllucasagomes: rloo was involved a bit in the rootwrap move stuff, maybe she knows why?17:22
lucasagomesjroll, right, yeah let's wait for her see if she has any thoughts about it17:22
keedyawhat if u excecute an API request to boot, set pxeboot, get power status ?17:22
rloojroll, lucasagomes: what's the question?17:22
lucasagomesrloo, we now have 2 rootwrap filters for ironic-lib17:22
lucasagomesrloo, one living in the ironic tree the other one in the ironic-lib tree17:23
lucasagomesapparently, devstack only cares about the one in the ironic tree17:23
lucasagomeshttps://github.com/openstack/ironic/blob/master/devstack/lib/ironic#L35217:23
rloolucasagomes: there are diff filter files, right?17:23
dtantsurkeedya, that's what ironic is responsible for, not inspector.. we only call ironic API's for that17:23
lucasagomesrloo, they are the same right now17:23
* lucasagomes rechecks17:24
keedyadtantsur: ok got it!!17:24
rloolucasagomes: they are? sec, let me look. it has been awhile.17:24
lucasagomesrloo, https://github.com/openstack/ironic-lib/blob/master/etc/rootwrap.d/ironic-lib.filters and https://github.com/openstack/ironic/blob/053584c982d8f47862824f191e6e4e7663b132de/etc/ironic/rootwrap.d/ironic-lib.filters17:24
lucasagomesyeah same17:24
*** raddaoui has quit IRC17:25
rloooh. i think we have to copy the ironic-lib.filters from ironic-lib, to ironic tree.17:25
rloolucasagomes: that is why it is the same.17:25
lucasagomesrloo, yeah, that's because devstack is currently ignoring the one in ironic-lib17:25
*** ohamada has quit IRC17:26
*** athomas has joined #openstack-ironic17:26
lucasagomesrloo, I wonder how we can fix it tho... if we decide to remove the one from ironic and keep it only in ironic-lib we have to update devstack17:26
rloolucasagomes: i think it was the easiest way i could figure out, to have things 'set up' to get access to that filter file.17:26
lucasagomesbut this may also break other ppl I guess17:26
lucasagomesrloo, I think that for now we should remove the ironic-lib one and only use it in Ironic, this ofc will need to have the dependnecies set correctly when creating a patch in ironic-lib that depends on tools that are not in the filter17:27
rloolucasagomes: is there a way to tell the rootwrap script where to get the filters? Or can we only give it the directory that contains all the filters?17:27
openstackgerritMerged openstack/ironic-lib: Add support for choosing the disk label  https://review.openstack.org/28353217:28
lucasagomesrloo, not sure, lemme look... I think we need to point it to a dir with the filters17:28
openstackgerritLilia Sampaio proposed openstack/python-oneviewclient: Adding server profile application and removal operations  https://review.openstack.org/25869917:28
openstackgerritNisha Agarwal proposed openstack/ironic: Add support for partition images in agent drivers  https://review.openstack.org/16200817:28
Gonerifilters_path=/etc/ironic/rootwrap.d,/usr/share/ironic/rootwrap17:28
Gonerirloo, yes you can17:28
lucasagomesrloo, actually we can specificy multiples17:28
lucasagomesfilters_path=/etc/ironic/rootwrap.d,/usr/share/ironic/rootwrap17:28
lucasagomesyup17:28
dtantsurgoing now, see you tomorrow17:29
*** dtantsur is now known as dtantsur|afk17:29
Goneriso we just need to add something like /usr/share/ironic_lib/rootwrap in the path17:29
rloolucasagomes: the ironic-lib.filters belongs with ironic-lib, cuz that's where those calls are being made.17:29
lucasagomesdtantsur|afk, see you17:29
lucasagomesrloo, yeah17:29
Gonerirloo, lucasagomes I can do this patch since it blocks me.17:30
rloolucasagomes: but if we only leave it in ironic-lib and not in ironic, upgrading will break folks cuz filters_path will be wrong.17:30
lucasagomesrloo, that's my fear17:30
Gonerigood point17:31
rlooi didn't read far enough back. what's the problem?17:31
*** degorenko is now known as _degorenko|afk17:31
lucasagomesrloo, Goneri has a patch updating the filters in ironic-lib, but it's failing because that filter is ignored by devstack17:31
rloolucasagomes: OH. presumably ironic is using the code in ironic lib that needs the filter.17:32
* lucasagomes w00t disk label was merged!!17:32
lucasagomesrloo, yeah, we thought it were17:33
lucasagomesrloo, but look https://github.com/openstack/ironic/blob/master/devstack/lib/ironic#L35217:33
lucasagomesdevstack is not copying the ironic-lib filters anywhere17:33
mkovacikaarefiev, looking at your comment in https://review.openstack.org/#/c/267637/10/ironic_inspector/process.py line #32417:33
rlooright, i think we need to copy ironic-lib filter to ironic. i wonder if i left any notes anywhere about it.17:34
mkovacikaarefiev, I think to merge the two exceptions, cause the only think different is the log message, wdyt?17:34
lucasagomesrloo, yeah, but when? As part of the installation of the ironic-lib? Or devstack should manually copy it?17:34
lucasagomescause I'm afraid we may break ppl if we remove the ironic-lib.filters from ironic now17:34
rloolucasagomes: i think for now, just copy17:35
lucasagomesrloo, hmm... right17:35
lucasagomesI have to think about it17:36
Gonerirloo, ok, so I patch ironic-lib.filters file from ironic to add my new dep, and add a big fat warning to explain it's a copy of the one from ironic-lib17:36
lucasagomesrloo, cause if we change devstack to copy it that's fine for gate... but won't upgrading ironic-lib won't do that17:36
lucasagomesso it will break them17:36
rloolucasagomes: oh. so it could get out of sync.17:37
lucasagomesrloo, yeah17:37
*** trown is now known as trown|lunch17:37
rloocopy in ironic should only be modified if the requirements change for the new ironic-lib17:37
jlvillalmgould: You around?17:38
lucasagomesrloo, I think we should remove the one from ironic-lib and use only ironic for now17:39
openstackgerritMerged openstack/ironic-python-agent: Reduced restriction of parsing for dmidecode output  https://review.openstack.org/28097017:39
lucasagomesbecause that's how it's being used17:39
lucasagomesrloo, then later ironic-lib should have it's own rootwrap17:39
lucasagomesironic-lib-rootwrap, with it's own filters17:39
lucasagomesand then we can remove the ironic one17:39
rloolucasagomes: the problem with removing the one from ironic-lib, is that it is a lib meant to be used by not only ironic.17:39
rloolucasagomes: how is some other user of ironic-lib meant to know which filters to use if we remove it.17:39
lucasagomesrloo, right, but that's a intermediate step17:40
Gonerican we rename the ironic version of the file17:40
rloolucasagomes: or we could change/comment it.17:40
Gonerithis will make the situation more clear for the packages17:40
rloolucasagomes: i mean, in ironic-lib, put a readme or something saying if you use it, you may want these filters for rootwrap.17:40
rloolucasagomes: i think that's what the intent was when we put ironic-lib.filters in ironic-lib and copied it in ironic.17:40
rloolucasagomes: but we didn't document it properly.17:41
lucasagomesrloo, right... I understand that's the ultimate go17:42
lucasagomesrloo, but I think that for that, ironic-lib will need it's own rootwrap?17:42
rlooGoneri: so yeah, maybe a comment in ironic's ironic-lib.filters17:42
lucasagomesother than ppl copying stuff around, because ironic-lib is a requirement for ironic17:42
lucasagomesrloo, https://github.com/openstack/ironic/blob/master/setup.cfg#L2917:42
lucasagomesgoal*17:43
*** derekh has quit IRC17:43
Gonerirloo, I will patch both17:43
lucasagomesGoneri, ty17:43
rloolucasagomes: i think i might have looked into the lib having its own rootwrap but it seems to me there was some hitch to it that i don't recall.17:44
rloolucasagomes: or maybe i didn't want to go to too much effort. i was just trying to get the ironic-lib stuff working at the time i think.17:44
lucasagomesrloo, which is fair enough!17:44
lucasagomeswe have options to fix that, so it's a good thing :-)17:44
*** stendulker has quit IRC17:45
*** harlowja_at_home has joined #openstack-ironic17:45
rloolucasagomes: and 'trying to get' == reviews on someone else's patches :)17:45
lucasagomesrloo, heh17:45
rloolucasagomes: i think we were supposed to deprecate some config too that i don't think got done.17:45
lucasagomesrloo, right, it's ok. We will fix it as we start using ironic-lib more17:47
lucasagomesright now only ironic's using it, Goneri is adding it to IPA too17:47
lucasagomesand so on...17:47
rloogood. thx Goneri.17:47
*** [1]cdearborn has quit IRC17:48
Gonerirloo, my pleasure :)17:48
*** absubram has quit IRC17:48
rlooGoneri: it has to do with this root_helper config in ironic-lib: https://github.com/openstack/ironic-lib/blob/master/ironic_lib/utils.py#L3517:49
openstackgerritMerged openstack/ironic-inspector: [devstack] Improve virtual machines logs  https://review.openstack.org/28541217:49
openstackgerritThiago Paiva Brito proposed openstack/python-oneviewclient: [WIP] Architectural changes + MAC address from iLO  https://review.openstack.org/27670317:49
*** rloo has quit IRC17:52
*** piet has joined #openstack-ironic17:54
*** baoli has quit IRC17:58
*** harshs has joined #openstack-ironic18:00
*** krtaylor has quit IRC18:00
openstackgerritGonéri Le Bouder proposed openstack/ironic: add wipefs to ironic-lib.filters  https://review.openstack.org/28675018:02
openstackgerritGonéri Le Bouder proposed openstack/ironic-lib: use wipefs to erase FS meta information  https://review.openstack.org/28628318:05
*** penick has joined #openstack-ironic18:05
Gonerilucasagomes ^18:05
*** ndipanov has quit IRC18:05
lucasagomesGoneri, just reviewed, it's pointing to the wrong patch in the commit message18:06
*** rloo has joined #openstack-ironic18:06
lucasagomesGoneri, other than that it lgtm18:06
lucasagomesGoneri, I left the change id of the wipefs patch in the commit message18:06
*** vinm213 has quit IRC18:06
lucasagomesI mean in the comment*18:07
GoneriOops18:07
* lucasagomes english is going down18:07
*** baoli has joined #openstack-ironic18:07
openstackgerritGonéri Le Bouder proposed openstack/ironic: add wipefs to ironic-lib.filters  https://review.openstack.org/28675018:08
Gonerilucasagomes, Here it is^18:08
*** e0ne has quit IRC18:08
lucasagomesGoneri, cool +2 :-)18:08
Gonerilucasagomes, thanks dude :)18:10
lucasagomesGoneri, np, thank you for fixing it18:10
*** nathanh has quit IRC18:13
*** baoli has quit IRC18:14
*** openstackgerrit has quit IRC18:18
*** spandhe has joined #openstack-ironic18:18
*** openstackgerrit has joined #openstack-ironic18:18
mgouldjlvillal, just saw your message18:19
mgouldI'm around for about another 10 minutes18:19
openstackgerritMerged openstack/python-ironicclient: Log SHA1 hash of X-Auth-Token value  https://review.openstack.org/27895118:20
lucasagomesI will call it a day18:21
lucasagomeshave a great evening all, see you tomorrow18:21
thiagopnight lucasagomes18:21
lucasagomessee ya18:22
*** raddaoui has joined #openstack-ironic18:22
*** lucasagomes is now known as lucas-dinner18:22
openstackgerritPavlo Shchelokovskyy proposed openstack/ironic-inspector: Use keystoneauth for Ironic and Swift clients  https://review.openstack.org/28651018:24
*** serverascode has quit IRC18:26
*** BadCub has quit IRC18:27
*** BadCub has joined #openstack-ironic18:27
*** serverascode has joined #openstack-ironic18:28
openstackgerritMilan Kováčik proposed openstack/ironic-inspector: Allow rerunning introspection on stored data  https://review.openstack.org/26763718:30
openstackgerritVladyslav Drok proposed openstack/python-ironicclient: Use keystoneauth instead of keystoneclient  https://review.openstack.org/27572218:30
*** permalac has quit IRC18:31
*** evgenyl_ has joined #openstack-ironic18:31
* mgould has to go; see you all tomorrow!18:32
*** mgould has quit IRC18:32
*** suro-patz has quit IRC18:32
sambettso/ see ya mgould18:33
sambettso/ everyone else too, I'm off18:33
*** sambetts is now known as sambetts|afk18:33
*** lekha_ has joined #openstack-ironic18:33
thiagopnight mgould sambetts|afk18:33
*** permalac has joined #openstack-ironic18:34
*** permalac has quit IRC18:34
*** trown|lunch is now known as trown18:35
sinval-afknight sambetts|afk18:36
*** sinval-afk is now known as sinval18:36
*** lekha has quit IRC18:37
*** evgenyl has quit IRC18:37
*** evgenyl_ is now known as evgenyl18:37
*** lekha_ is now known as lekha18:38
*** ijw has joined #openstack-ironic18:42
*** krtaylor has joined #openstack-ironic18:43
openstackgerritStephanie Miller proposed openstack/bifrost: Install python if it's not there  https://review.openstack.org/28378318:45
*** dims has joined #openstack-ironic18:45
*** dims_ has quit IRC18:52
*** pas-ha has quit IRC18:52
openstackgerritStephanie Miller proposed openstack/bifrost: Install python if it's not there  https://review.openstack.org/28378318:52
*** pas-ha has joined #openstack-ironic18:52
*** SpamapS has quit IRC18:54
*** openstack has joined #openstack-ironic19:16
*** openstackstatus has joined #openstack-ironic19:17
*** ChanServ sets mode: +v openstackstatus19:17
*** openstackgerrit has joined #openstack-ironic19:20
openstackgerritGonéri Le Bouder proposed openstack/ironic: ipxe: add --timeout parameter to kernel and initrd  https://review.openstack.org/28389319:22
*** cppforlife_ has quit IRC19:25
*** clif_h has quit IRC19:25
*** alaski has quit IRC19:25
*** ChrisMead has quit IRC19:25
*** zsmithnyc has quit IRC19:25
*** johnthetubaguy has quit IRC19:25
*** pas-ha has quit IRC19:30
*** cppforlife_ has joined #openstack-ironic19:31
*** clif_h has joined #openstack-ironic19:31
*** alaski has joined #openstack-ironic19:31
*** ChrisMead has joined #openstack-ironic19:31
*** zsmithnyc has joined #openstack-ironic19:31
*** johnthetubaguy has joined #openstack-ironic19:31
*** jrist has quit IRC19:31
openstackgerritNisha Agarwal proposed openstack/ironic-python-agent: Add support for partition images in agent driver  https://review.openstack.org/16022419:36
*** suro-patz has joined #openstack-ironic19:37
openstackgerritThiago Paiva Brito proposed openstack/python-oneviewclient: Classifying tests into functional and unit  https://review.openstack.org/28679719:41
*** Sukhdev has joined #openstack-ironic19:43
openstackgerritThiago Paiva Brito proposed openstack/python-oneviewclient: Facility to get mac address from iLO on DL class  https://review.openstack.org/28680119:45
*** spandhe has quit IRC19:50
openstackgerritThiago Paiva Brito proposed openstack/python-oneviewclient: [WIP] OneView client with managers  https://review.openstack.org/28680319:50
*** spandhe has joined #openstack-ironic19:52
*** raddaoui has joined #openstack-ironic19:55
*** jrist has joined #openstack-ironic19:55
openstackgerritNisha Agarwal proposed openstack/ironic: Add documentation for RAID  https://review.openstack.org/22633019:57
*** david-lyle has quit IRC19:59
*** raddaoui has quit IRC19:59
*** daemontool__ has joined #openstack-ironic20:05
openstackgerritThiago Paiva Brito proposed openstack/python-oneviewclient: Facility to get mac address from iLO on DL class  https://review.openstack.org/28680120:06
*** ijw has quit IRC20:07
*** jcoufal_ has quit IRC20:08
*** daemontool_ has quit IRC20:09
*** david-lyle has joined #openstack-ironic20:09
Nisha_brbjroll, there?20:10
*** Nisha_brb is now known as Nisha20:11
*** piet has quit IRC20:13
*** raddaoui has joined #openstack-ironic20:18
openstackgerritThiago Paiva Brito proposed openstack/python-oneviewclient: Classifying tests into functional and unit  https://review.openstack.org/28679720:22
openstackgerritJarrod Johnson proposed openstack/pyghmi: Fix 'uptime' time correction attempt  https://review.openstack.org/28618120:26
openstackgerritThiago Paiva Brito proposed openstack/python-oneviewclient: Facility to get mac address from iLO on DL class  https://review.openstack.org/28680120:27
*** suro-patz has quit IRC20:30
*** ChrisAusten has joined #openstack-ironic20:33
JayFTheJulia: around? have a systems question I'd like to run by you20:33
TheJuliaJayF: somewhat around :)20:35
TheJuliawhats up?20:35
JayFTheJulia: I have a haproxy in front of a collection of ironic apis20:35
JayFwhen it throws a 4xx 5xx style error, ironic gets angry because it's a typical html/text style error page20:36
JayFwondering if you've played around at all with sending json docs back to ironic in that case20:36
TheJuliaI have not... but I guess your in http mode with haproxy and doing cookie injection for session tracking/stickiness ?20:37
*** e0ne has joined #openstack-ironic20:38
*** penick has quit IRC20:38
JayFwe're not doing any session tracking20:40
JayFironic is not sessioned in that way20:40
TheJuliayeah, maybe tcp mode so haproxy is operating about it agnostically?20:41
*** Nisha has quit IRC20:41
JayFI mean, this isn't a problem20:43
JayFit's just trying to make my logs not explode when one api takes a long time to respond :)20:43
*** pcaruana has joined #openstack-ironic20:44
TheJuliaoh... ahh20:44
JayFyeah, I think I'm going to do it, with these: http://cialis.oldos.org/~jay/json_error_pages/20:45
JayFI wanted to look at openstack errors in particular and try to perfectly mimic them, but that's much better than html and exploding json.parse()20:45
TheJuliaokay, now I understand :)20:46
TheJulia++20:46
*** e0ne has quit IRC20:47
openstackgerritMerged openstack/python-oneviewclient:  Fixing URL of index variable and refactoring  https://review.openstack.org/28540220:54
*** piet has joined #openstack-ironic20:55
*** e0ne has joined #openstack-ironic20:55
*** e0ne has quit IRC20:59
*** raddaoui_ has joined #openstack-ironic21:00
*** raddaoui has quit IRC21:00
mrdaMorning Ironic21:07
*** raildo is now known as raildo-afk21:07
*** david-lyle has quit IRC21:08
TheJuliagood morning mrda21:10
mrdaHi TheJulia21:11
*** jaybeale has quit IRC21:12
*** david-lyle has joined #openstack-ironic21:17
NobodyCammorning mrda21:20
*** raddaoui_ has quit IRC21:29
*** dims_ has joined #openstack-ironic21:31
*** dims has quit IRC21:33
openstackgerritMerged openstack/pyghmi: Fix 'uptime' time correction attempt  https://review.openstack.org/28618121:40
*** derekh has joined #openstack-ironic21:41
*** Sukhdev has quit IRC21:43
*** baoli has joined #openstack-ironic21:43
*** baoli_ has joined #openstack-ironic21:44
mrdahey NobodyCam21:47
NobodyCam:)21:47
*** baoli has quit IRC21:48
*** xavier_ has joined #openstack-ironic21:49
*** raddaoui_ has joined #openstack-ironic21:49
*** trown is now known as trown|outtypewww21:59
*** causten_ has joined #openstack-ironic22:00
*** pcaruana has quit IRC22:01
*** dims_ has quit IRC22:02
*** ChrisAusten has quit IRC22:03
*** Sukhdev has joined #openstack-ironic22:04
*** dprince has quit IRC22:08
*** ijw has joined #openstack-ironic22:09
*** dims has joined #openstack-ironic22:10
*** penick has joined #openstack-ironic22:16
*** Sukhdev has quit IRC22:19
*** keedya has quit IRC22:21
*** raddaoui_ has quit IRC22:21
*** suro-patz has joined #openstack-ironic22:22
*** achanda has quit IRC22:23
*** krtaylor has quit IRC22:27
*** david-lyle has quit IRC22:29
openstackgerritMerged openstack/ironic: Updated from global requirements  https://review.openstack.org/28398322:30
*** achanda has joined #openstack-ironic22:36
*** raddaoui_ has joined #openstack-ironic22:36
*** cdearborn has joined #openstack-ironic22:39
*** cdearborn has quit IRC22:41
*** piet has quit IRC22:43
*** baoli_ has quit IRC22:54
*** baoli has joined #openstack-ironic22:54
*** [1]cdearborn has quit IRC22:55
*** raddaoui_ has quit IRC22:55
*** jaybeale has joined #openstack-ironic22:55
*** dims has quit IRC22:55
*** baoli has quit IRC22:58
*** baoli has joined #openstack-ironic22:59
*** rbudden has quit IRC22:59
*** harlowja_at_home has quit IRC23:00
*** baoli has quit IRC23:00
*** david-lyle has joined #openstack-ironic23:00
*** dims has joined #openstack-ironic23:00
*** baoli has joined #openstack-ironic23:01
*** ianw has quit IRC23:07
*** intr1nsic has quit IRC23:08
*** baoli has quit IRC23:11
*** chlong_ has joined #openstack-ironic23:13
*** krtaylor has joined #openstack-ironic23:16
*** Sukhdev has joined #openstack-ironic23:18
*** harshs has quit IRC23:26
*** spandhe has quit IRC23:30
*** intr1nsic has joined #openstack-ironic23:32
*** spandhe has joined #openstack-ironic23:33
*** harshs has joined #openstack-ironic23:37
openstackgerritJim Rollenhagen proposed openstack/ironic: Clean up driver loading in init_host  https://review.openstack.org/28585023:40
openstackgerritJim Rollenhagen proposed openstack/ironic: Refactor driver loading to load a driver instance per node  https://review.openstack.org/28585123:41
*** david-lyle has quit IRC23:41
jlvillaljroll: I'm kind of concerned about this: http://logs.openstack.org/51/285851/5/check/gate-ironic-python27/52cbcfd/console.html#_2016-02-29_17_58_31_82223:47
jlvillaljroll: I think the code in this patch is touching the error case: https://review.openstack.org/#/c/285850/23:47
jlvillaljroll: I also saw that error occur locally, but then stopped happening...23:48
jlvillalBut I'm not sure why the error happens... :(23:48
jlvillalMaybe it is some kind of race condition23:49
jrolljlvillal: yeah, I think it's related to dmitry's comment here https://review.openstack.org/#/c/285850/3/ironic/tests/unit/common/test_driver_factory.py23:49
jrollwhich I've since fixed, and just rebased on23:49
jlvillaljroll: ah :)23:50
jlvillaljroll: I will wait for it to be pushed. Thanks!23:51
*** smoriya_ has joined #openstack-ironic23:51
jrolljlvillal: it is pushed already, see bot messages from 13 minutes ago23:53
jlvillaljroll: I only saw change to docstring in from 4 to 523:53
jrolljlvillal: oh, that was fixed in 3-423:54
jrollbut I didn't rebase til now23:54
jlvillaljroll: Ah. Thanks, makes sense.23:54
jlvillaljroll: And that makes sense why I saw it locally because I had checked out the top patch in the series.23:55
jlvillalRefactor driver loading to load a driver instance per node  https://review.openstack.org/28585123:55
jrollya23:55
* jlvillal is brave and votes ahead of Jenkins :)23:56
*** rloo has quit IRC23:57
*** harshs has left #openstack-ironic23:59

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!