| *** links has joined #openstack-ironic | 00:23 | |
| jroll | devananda: on that joinedload() review, what happens if other attributes down the road are not loaded via joinedload() but rather subquery() or something else entirely? another parameter? | 00:28 |
|---|---|---|
| devananda | jroll: hm, fair point | 00:31 |
| devananda | if other attributes are loaded via other means, will they present the same object interface? | 00:31 |
| devananda | *same interface through o.vo ? | 00:32 |
| devananda | jroll: btw, i got the neutron integration patch stack working locally today in devstack | 00:32 |
| devananda | trying to figure out how to validate the network isolation right now | 00:32 |
| jroll | yes, it would still be expected_attrs | 00:34 |
| jroll | in the objects layer | 00:34 |
| devananda | so the difference would be only in the db/api layer? | 00:34 |
| jroll | and then I'd have _build_port_query do something like if col == node: joinedload() elif col == foo: subquery() | 00:35 |
| devananda | yea, so in that case, I could see using a differently named parameter | 00:35 |
| jroll | I could, but OTOH I wish the objects layer didn't have to know how the db layer builds a query | 00:36 |
| * devananda rereads the review | 00:36 | |
| devananda | yea, i see your point | 00:37 |
| devananda | still it's not loading a column | 00:37 |
| jroll | yeah | 00:37 |
| jroll | relationships_to_load is long but makes the most sense imo | 00:37 |
| jroll | I was also thinking extra_attrs or something | 00:37 |
| devananda | this approach only works for N:[0,1] relationships | 00:38 |
| devananda | or rather, think of how weird the interface would be if it was get_node_by_id(node_id, columns_to_join=['port']) | 00:39 |
| devananda | then you'd have node.port be a list of result objects | 00:39 |
| jroll | well, we'd make it 'ports' | 00:39 |
| jroll | these are defined on the model | 00:39 |
| devananda | right - this is useful, but awkward | 00:40 |
| jroll | things_to_conjur | 00:40 |
| devananda | ports.uuid is a scalar. ports.node is an object. nodes.uuid is a scalar. nodes.ports is a list of objects | 00:40 |
| devananda | eh - it's super useful. I'm talking myself into liking it :) | 00:41 |
| jroll | heh | 00:41 |
| devananda | I like extra_attrs | 00:41 |
| jroll | I still like things_to_conjur | 00:41 |
| devananda | that, at least, says "hey this isn't actually part of the THING, it's extra" | 00:42 |
| jroll | but I'll run with extra_attrs | 00:42 |
| devananda | well, I also like things_to_conjur :) | 00:42 |
| jroll | :P | 00:42 |
| jroll | thanks | 00:42 |
| devananda | np | 00:42 |
| devananda | for the neutron integration, have you done any testing with the OVS/devstack support? | 00:43 |
| jroll | I haven't, I've been meaning to | 00:44 |
| jroll | I started playing with the claims stuff, needed that magic registry thing to do what I wanted, saw nastiness in ports api, and I've been shaving that yak for a couple days now | 00:44 |
| devananda | I hear yak butter has a strong flavor | 00:47 |
| jroll | heh | 00:48 |
| * jroll tries milking rather than shaving | 00:48 | |
| jroll | oh, but as to your isolation question, I think the devstack code is supposed to handle that | 00:49 |
| devananda | at first glance, it looks like it is separating provisioning from tenant networks | 00:49 |
| devananda | but not tenants from each other | 00:50 |
| * devananda may also be doing something wrong | 00:50 | |
| jroll | oh | 00:50 |
| jroll | I could see that | 00:50 |
| devananda | like, maybe I (as admin) need to create multiple private nets and assign each one to a tenant? | 00:51 |
| jroll | devananda: looks like that's intended? https://review.openstack.org/#/c/256366/6/devstack/tools/ironic/scripts/create-node.sh | 00:51 |
| devananda | right now, there's only one private net, one public net, and one "ironic-provision" net | 00:52 |
| jroll | oh no, there's a bridge for each vm | 00:52 |
| jroll | hrm | 00:52 |
| devananda | yea | 00:52 |
| jroll | so the first two are probably provider networks | 00:53 |
| devananda | i've got 3 tenants, but they're all getting IPs from the same "private" network | 00:53 |
| jroll | can you make a network with one tenant and nova boot --net whatever? | 00:53 |
| jroll | and see if it's isolated from the other | 00:53 |
| *** _zouyee has joined #openstack-ironic | 01:07 | |
| *** shuquan has joined #openstack-ironic | 01:17 | |
| devananda | jroll: hm, so, that seems to also require me to use ovs on the host to attach to that network | 01:21 |
| devananda | which sort of makes sense -- but I had expected neutron to do that | 01:21 |
| devananda | when I run neutron net-create ...; neutron subnet-create ....; as far as I can tell, it isn't linking those to the host | 01:22 |
| devananda | I see the dhcpreqest from the VM, and subsequent dhcpoffer for the IP on the new subnet - but that's the end of it | 01:30 |
| *** yolanda has quit IRC | 01:48 | |
| *** jaypipes has quit IRC | 01:53 | |
| *** shuquan has quit IRC | 01:59 | |
| *** dims has quit IRC | 02:08 | |
| *** dims has joined #openstack-ironic | 02:39 | |
| *** dims has quit IRC | 02:39 | |
| *** jaybeale has quit IRC | 03:02 | |
| *** yarkot has quit IRC | 03:02 | |
| *** harshs has quit IRC | 03:14 | |
| *** MattMan has quit IRC | 03:17 | |
| *** MattMan has joined #openstack-ironic | 03:17 | |
| *** baoli has quit IRC | 03:33 | |
| *** baoli has joined #openstack-ironic | 03:33 | |
| *** shuquan has joined #openstack-ironic | 03:34 | |
| *** yarkot has joined #openstack-ironic | 03:47 | |
| *** shuquan_ has joined #openstack-ironic | 03:56 | |
| *** shuquan has quit IRC | 03:56 | |
| *** shuquan_ is now known as shuquan | 03:56 | |
| *** shuquan has quit IRC | 04:01 | |
| *** shuquan has joined #openstack-ironic | 05:35 | |
| *** shuquan has quit IRC | 05:44 | |
| *** baoli has quit IRC | 05:49 | |
| *** baoli has joined #openstack-ironic | 05:53 | |
| *** coolsvap|away is now known as coolsvap | 06:02 | |
| *** jaybeale has joined #openstack-ironic | 06:14 | |
| *** jaybeale has quit IRC | 06:50 | |
| *** jaybeale has joined #openstack-ironic | 06:52 | |
| *** jaybeale has quit IRC | 06:53 | |
| *** baoli has quit IRC | 07:13 | |
| *** shuquan has joined #openstack-ironic | 07:14 | |
| *** baoli has joined #openstack-ironic | 07:29 | |
| *** baoli has quit IRC | 07:33 | |
| *** ukalifon has joined #openstack-ironic | 07:34 | |
| *** baoli has joined #openstack-ironic | 07:41 | |
| *** shuquan has quit IRC | 07:41 | |
| *** coolsvap is now known as coolsvap|away | 07:45 | |
| *** baoli has quit IRC | 07:45 | |
| *** ndipanov has joined #openstack-ironic | 07:47 | |
| *** shuquan has joined #openstack-ironic | 07:48 | |
| *** david-lyle has quit IRC | 07:50 | |
| *** rcernin has joined #openstack-ironic | 07:52 | |
| *** baoli has joined #openstack-ironic | 07:52 | |
| *** shuquan has quit IRC | 07:53 | |
| *** baoli has quit IRC | 07:57 | |
| *** shuquan has joined #openstack-ironic | 07:57 | |
| *** moshele has joined #openstack-ironic | 08:00 | |
| *** shuquan_ has joined #openstack-ironic | 08:02 | |
| *** shuquan has quit IRC | 08:02 | |
| *** shuquan_ is now known as shuquan | 08:02 | |
| *** shuquan has quit IRC | 08:08 | |
| *** baoli has joined #openstack-ironic | 08:11 | |
| *** yolanda has joined #openstack-ironic | 08:15 | |
| *** baoli has quit IRC | 08:16 | |
| *** pas-ha has joined #openstack-ironic | 08:17 | |
| pas-ha | morning Ironic :) and Happy New Year to everyone! | 08:17 |
| *** baoli has joined #openstack-ironic | 08:23 | |
| *** boris-42 has joined #openstack-ironic | 08:23 | |
| *** baoli has quit IRC | 08:28 | |
| *** ChubYann has quit IRC | 08:33 | |
| *** baoli has joined #openstack-ironic | 08:34 | |
| *** baoli has quit IRC | 08:39 | |
| *** baoli has joined #openstack-ironic | 08:46 | |
| *** david-lyle has joined #openstack-ironic | 08:50 | |
| *** baoli has quit IRC | 08:51 | |
| *** baoli has joined #openstack-ironic | 08:58 | |
| zhenguo | Haomeng: hello, are you around? | 08:58 |
| Haomeng | zhenguo: yes, hello ZhengGuo | 08:59 |
| Haomeng | pas-ha: happy new year | 08:59 |
| zhenguo | Haomeng: I'm interested in https://blueprints.launchpad.net/ironic/+spec/backup-disk-to-image, are you still working on that? | 08:59 |
| Haomeng | zhenguo: yes, | 08:59 |
| Haomeng | zhenguo: will propose bp these days | 09:00 |
| zhenguo | Haomeng: cool | 09:00 |
| zhenguo | Haomeng: we can poweroff the node and copy the image out | 09:00 |
| Haomeng | zhenguo: want to leverage cinder as storage, and will restore via 'boot from volume' | 09:01 |
| Haomeng | zhenguo: yes, it is offline snapshot | 09:01 |
| *** Marga_ has joined #openstack-ironic | 09:01 | |
| zhenguo | Haomeng: is that like nova snapshot? | 09:01 |
| *** _zouyee has quit IRC | 09:02 | |
| Haomeng | zhenguo: yes, but does not support multi-lays fs such as qcow2 | 09:02 |
| *** baoli has quit IRC | 09:03 | |
| zhenguo | Haomeng: and does we need to upload the image to glance? | 09:03 |
| *** moshele has quit IRC | 09:09 | |
| *** baoli has joined #openstack-ironic | 09:10 | |
| Haomeng | zhenguo: before 'boot from cinder volume' is ready, it need to be uploaded to glance | 09:11 |
| zhenguo | Haomeng: got it, thanks. | 09:13 |
| *** baoli has quit IRC | 09:14 | |
| *** Marga_ has quit IRC | 09:20 | |
| *** baoli has joined #openstack-ironic | 09:21 | |
| *** baoli has quit IRC | 09:26 | |
| *** baoli has joined #openstack-ironic | 09:32 | |
| *** baoli has quit IRC | 09:37 | |
| vdrok | morning ironic | 09:40 |
| openstackgerrit | Zhenguo Niu proposed openstack/ironic: tox: make it possible to run pep8 on current patch only https://review.openstack.org/261011 | 09:42 |
| zhenguo | morning vdrok | 09:43 |
| vdrok | good morning zhenguo | 09:43 |
| *** baoli has joined #openstack-ironic | 09:44 | |
| *** moshele has joined #openstack-ironic | 10:00 | |
| *** zhenguo has quit IRC | 10:03 | |
| *** e0ne has joined #openstack-ironic | 10:18 | |
| *** yolanda has quit IRC | 10:55 | |
| *** yolanda has joined #openstack-ironic | 10:55 | |
| *** mbound has joined #openstack-ironic | 11:11 | |
| *** Marga_ has joined #openstack-ironic | 11:21 | |
| *** Marga_ has quit IRC | 11:26 | |
| *** links has quit IRC | 11:32 | |
| *** boris-42 has quit IRC | 11:33 | |
| *** vsaienko has joined #openstack-ironic | 11:52 | |
| sergek | Happy New Year, Ironicers! | 12:15 |
| *** _degorenko is now known as degorenko | 12:26 | |
| *** ndipanov has quit IRC | 12:40 | |
| *** Marga_ has joined #openstack-ironic | 12:44 | |
| *** Marga_ has quit IRC | 12:49 | |
| *** ndipanov has joined #openstack-ironic | 12:59 | |
| openstackgerrit | Merged openstack/ironic: Change assertTrue(isinstance()) by optimal assert https://review.openstack.org/262527 | 13:01 |
| *** ndipanov has quit IRC | 13:35 | |
| *** baoli has quit IRC | 13:38 | |
| *** e0ne has quit IRC | 13:40 | |
| *** mbound has quit IRC | 13:42 | |
| *** baoli has joined #openstack-ironic | 13:46 | |
| *** baoli has quit IRC | 13:51 | |
| *** moshele has quit IRC | 13:56 | |
| *** baoli has joined #openstack-ironic | 13:58 | |
| *** baoli has quit IRC | 14:02 | |
| *** vdrok has quit IRC | 14:06 | |
| *** vdrok has joined #openstack-ironic | 14:08 | |
| vdrok | happy new year everyone, see you next year! :) | 14:09 |
| *** baoli has joined #openstack-ironic | 14:11 | |
| *** degorenko has quit IRC | 14:13 | |
| *** baoli has quit IRC | 14:16 | |
| *** pas-ha has quit IRC | 14:16 | |
| *** mbound has joined #openstack-ironic | 14:19 | |
| openstackgerrit | Sergii Turivnyi proposed openstack/python-ironicclient: Add tests for testing node-delete command https://review.openstack.org/251458 | 14:21 |
| *** baoli has joined #openstack-ironic | 14:22 | |
| *** baoli has quit IRC | 14:27 | |
| *** Marga_ has joined #openstack-ironic | 14:35 | |
| *** Marga_ has quit IRC | 14:36 | |
| *** Marga_ has joined #openstack-ironic | 14:37 | |
| *** Marga_ has quit IRC | 14:45 | |
| *** Marga_ has joined #openstack-ironic | 14:45 | |
| *** e0ne has joined #openstack-ironic | 14:47 | |
| *** e0ne has quit IRC | 14:53 | |
| *** mbound has quit IRC | 14:54 | |
| *** mbound has joined #openstack-ironic | 14:55 | |
| openstackgerrit | Kyrylo Romanenko proposed openstack/python-ironicclient: Tests for CLI help messages https://review.openstack.org/262273 | 14:59 |
| *** mbound has quit IRC | 15:08 | |
| *** intr1nsic has quit IRC | 15:39 | |
| *** intr1nsic has joined #openstack-ironic | 15:46 | |
| *** e0ne has joined #openstack-ironic | 15:47 | |
| *** rcernin has quit IRC | 16:16 | |
| *** david-lyle has quit IRC | 16:25 | |
| *** jaybeale has joined #openstack-ironic | 16:29 | |
| *** Marga_ has quit IRC | 16:32 | |
| *** e0ne has quit IRC | 16:40 | |
| *** rcernin has joined #openstack-ironic | 16:54 | |
| *** e0ne has joined #openstack-ironic | 17:01 | |
| *** harshs has joined #openstack-ironic | 17:09 | |
| *** e0ne has quit IRC | 17:18 | |
| *** david-lyle has joined #openstack-ironic | 17:25 | |
| *** ukalifon has quit IRC | 17:34 | |
| *** david-lyle has quit IRC | 17:42 | |
| *** david-lyle has joined #openstack-ironic | 17:42 | |
| *** ChubYann has joined #openstack-ironic | 17:54 | |
| *** jaybeale has quit IRC | 18:00 | |
| *** rcernin has quit IRC | 18:09 | |
| *** harshs has quit IRC | 18:18 | |
| *** harshs has joined #openstack-ironic | 18:36 | |
| *** Marga_ has joined #openstack-ironic | 18:41 | |
| openstackgerrit | Jay Faulkner proposed openstack/ironic: Support reboot_requested bool on agent clean_steps https://review.openstack.org/259135 | 18:47 |
| JayF | vdrok: jroll: ^ added reno and tests as requested | 18:47 |
| JayF | mariojv: ^ the tests I was asking you about in the other channel are in that review, if you wanna take a look | 18:49 |
| mariojv | cool, i'll look in a few mins | 18:50 |
| *** yolanda has quit IRC | 19:00 | |
| *** Marga_ has quit IRC | 19:49 | |
| *** pas-ha has joined #openstack-ironic | 19:51 | |
| *** Marga_ has joined #openstack-ironic | 19:55 | |
| *** pas-ha has quit IRC | 19:57 | |
| mariojv | JayF: looks fine but the reno tests are failing | 19:57 |
| *** harshs has quit IRC | 20:10 | |
| *** e0ne has joined #openstack-ironic | 20:24 | |
| *** Marga_ has quit IRC | 20:31 | |
| *** openstackgerrit has quit IRC | 20:32 | |
| *** openstackgerrit has joined #openstack-ironic | 20:32 | |
| JayF | ^ I can't seem to figure out the reno stuff, after working on it locally for a bit | 20:54 |
| JayF | are there any documented guidelines? | 20:54 |
| openstackgerrit | Jay Faulkner proposed openstack/ironic: Support reboot_requested bool on agent clean_steps https://review.openstack.org/259135 | 21:04 |
| openstackgerrit | Jay Faulkner proposed openstack/ironic: Support reboot_requested bool on agent clean_steps https://review.openstack.org/259135 | 21:10 |
| JayF | mariojv: ^ reno is happy now | 21:10 |
| JayF | well, now ^ lol | 21:10 |
| *** Marga_ has joined #openstack-ironic | 22:42 | |
| *** e0ne has quit IRC | 22:45 | |
| *** harshs has joined #openstack-ironic | 22:54 | |
| *** e0ne has joined #openstack-ironic | 23:04 | |
| *** harshs has quit IRC | 23:09 | |
| *** harshs has joined #openstack-ironic | 23:24 | |
| *** Marga_ has quit IRC | 23:24 | |
| *** e0ne has quit IRC | 23:46 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!