*** alexpilotti has joined #openstack-ironic | 00:06 | |
*** alexpilotti has quit IRC | 00:10 | |
*** [1]rpioso has quit IRC | 00:13 | |
openstackgerrit | Michael Krotscheck proposed openstack/ironic-webclient: $$configuration mock https://review.openstack.org/247126 | 00:22 |
---|---|---|
sinvalv | jlvillal, are you there? | 00:23 |
jlvillal | sinvalv, I am | 00:23 |
jlvillal | Sorry for putting you in a tug-of-war ;) | 00:23 |
jlvillal | sinvalv, Are my comments crazy? Or do they make sense? | 00:23 |
sinvalv | jlvillal, hahaha you're funny | 00:24 |
jlvillal | :) | 00:24 |
sinvalv | jlvillal, actually I agree with you on every comment, they make a lot of sense | 00:24 |
jlvillal | sinvalv, Now we just need to convince vdrok :) | 00:24 |
sinvalv | jlvillal, I'll try to handle them ASAP | 00:25 |
jlvillal | sinvalv, I would be good to get other opinions too. | 00:25 |
sinvalv | jlvillal, agree, I'll change the implementation and ping you guys | 00:26 |
jlvillal | Thanks! | 00:26 |
sinvalv | jlvillal, you asked about unit tests for those base.Manager methods | 00:26 |
*** trown is now known as trown|outttypeww | 00:26 | |
jlvillal | sinvalv, Yes. I didn't see any added in the patch set. | 00:26 |
jlvillal | So I was wondering if they existed. | 00:26 |
sinvalv | jlvillal, I don't think that they exist for the base.Manager, but for the heirs I do think that are a couple of tests, I'll take a look what kind of scenarios I could add to them | 00:27 |
jlvillal | sinvalv, Should create tests for the base class. | 00:27 |
jlvillal | Well should test the base class directly if possible. | 00:28 |
jlvillal | If you make it abstract then maybe difficult! | 00:28 |
sinvalv | jlvillal, hahaha, you answered my next question | 00:28 |
sinvalv | jlvillal, no problem, will do | 00:28 |
jlvillal | Thank you. | 00:28 |
sinvalv | jlvillal, thanks for your support with this o/ | 00:28 |
jlvillal | My pleasure. I appreciate the patch. | 00:29 |
sinvalv | jlvillal, actually I have other topics to discuss with you, about functional testing | 00:29 |
jlvillal | sinvalv, I'll see if I can help. My brain is a little tired right now after all day of training. | 00:29 |
sinvalv | I saw that you have some patches to deal with functional testing for Ironic | 00:29 |
jlvillal | sinvalv, I have some WIP code up. Not sure if I am on the right track there. | 00:30 |
sinvalv | jlvillal, ok, we can start this conversation later, maybe tomorrow o/ | 00:30 |
jlvillal | sinvalv, vdrok had some good comments that I need to update the patch with. | 00:30 |
jlvillal | sinvalv, I'm in training the rest of the week. | 00:30 |
jlvillal | sinvalv, But next week I get a break. Thought Thursday and Friday of next week are a holiday here. | 00:31 |
sinvalv | jlvillal, I see, maybe next week haha | 00:31 |
jlvillal | s/Thought/Though/ | 00:31 |
sinvalv | jlvillal, nice I'll take a rest for now, I'll update the patch ASAP, bye | 00:32 |
jlvillal | sinvalv, Ciao | 00:32 |
*** rebase has quit IRC | 00:32 | |
*** alexpilotti has joined #openstack-ironic | 00:37 | |
*** alexpilotti has quit IRC | 00:42 | |
*** Piet has joined #openstack-ironic | 00:49 | |
*** rebase has joined #openstack-ironic | 00:59 | |
*** alexpilotti has joined #openstack-ironic | 01:19 | |
*** ijw has quit IRC | 01:21 | |
*** alexpilotti has quit IRC | 01:23 | |
openstackgerrit | Zhenguo Niu proposed openstack/ironic: Validate all tcp/udp port numbers https://review.openstack.org/244713 | 01:26 |
*** cui has joined #openstack-ironic | 01:27 | |
lintan_ | morning Ironic | 01:30 |
*** zhenguo has joined #openstack-ironic | 01:32 | |
openstackgerrit | Haozhi Cui proposed openstack/python-ironicclient: replace LOG.warn with LOG.warning https://review.openstack.org/247255 | 01:33 |
*** Sukhdev has quit IRC | 01:35 | |
*** alexpilotti has joined #openstack-ironic | 01:36 | |
*** alexpilotti has quit IRC | 01:41 | |
sinvalv | good morning lintan_ | 01:42 |
*** Sukhdev has joined #openstack-ironic | 01:43 | |
lintan_ | hi sinvalv :) | 01:44 |
Haomeng | morning sinvalv, lintan , jlvillal :) | 01:49 |
sinvalv | hey Haomeng o/ | 01:49 |
Haomeng | sinvalv: :) | 01:49 |
jlvillal | Hello Haomeng lintan_ | 01:50 |
Haomeng | jlvillal: :) | 01:51 |
lintan_ | morning jlvillal and Haomeng | 01:57 |
Haomeng | lintan_: :) | 02:00 |
*** Sukhdev has quit IRC | 02:05 | |
*** alexpilotti has joined #openstack-ironic | 02:08 | |
*** dims has joined #openstack-ironic | 02:09 | |
openstackgerrit | Lilia Sampaio proposed openstack/ironic: Only mention IPA in the quick start and user guides for DevStack https://review.openstack.org/235907 | 02:11 |
*** alexpilotti has quit IRC | 02:12 | |
*** dims_ has quit IRC | 02:13 | |
openstackgerrit | Lilia Sampaio proposed openstack/ironic: Only mention IPA in the quick start and user guides for DevStack https://review.openstack.org/235907 | 02:13 |
*** MattMan has quit IRC | 02:18 | |
*** MattMan has joined #openstack-ironic | 02:18 | |
*** openstack has joined #openstack-ironic | 02:27 | |
openstackgerrit | Haozhi Cui proposed openstack/python-ironicclient: replace LOG.warn with LOG.warning https://review.openstack.org/247255 | 02:29 |
*** absubram has quit IRC | 02:30 | |
*** alexpilotti has joined #openstack-ironic | 02:36 | |
*** HimanshuGarg has quit IRC | 02:36 | |
*** Sukhdev has joined #openstack-ironic | 02:39 | |
*** achanda has joined #openstack-ironic | 02:40 | |
*** alexpilotti has quit IRC | 02:41 | |
*** Sukhdev has quit IRC | 02:44 | |
*** lazy_prince has joined #openstack-ironic | 02:50 | |
openstackgerrit | Zhenguo Niu proposed openstack/ironic: Add Tag, TagList objects and a new tags field to Node https://review.openstack.org/233357 | 02:56 |
openstackgerrit | Sinval Vieira Mendes Neto proposed openstack/python-ironicclient: Refactoring and removing duplicate code of "base.Manager" heirs https://review.openstack.org/246692 | 02:57 |
openstackgerrit | Naohiro Tamura proposed openstack/ironic-specs: Enhance Power Interface for Soft Power Off and Inject NMI https://review.openstack.org/186700 | 02:59 |
openstackgerrit | Ruby Loo proposed openstack/ironic: Support arguments for clean step methods https://review.openstack.org/247201 | 03:03 |
*** rebase has quit IRC | 03:14 | |
*** bapalm has quit IRC | 03:15 | |
*** lazy_prince has quit IRC | 03:16 | |
*** Haomeng|2 has quit IRC | 03:18 | |
*** bapalm has joined #openstack-ironic | 03:21 | |
*** baoli_ has quit IRC | 03:23 | |
*** harshs has quit IRC | 03:27 | |
*** dims has quit IRC | 03:32 | |
*** achanda has quit IRC | 03:34 | |
*** achanda has joined #openstack-ironic | 03:34 | |
*** jerrygb has quit IRC | 03:35 | |
*** achanda has quit IRC | 03:37 | |
*** jamielennox is now known as jamielennox|away | 03:45 | |
openstackgerrit | Ruby Loo proposed openstack/ironic: Conductor handles manual cleaning https://review.openstack.org/247285 | 03:48 |
*** rloo has quit IRC | 03:54 | |
*** jamielennox|away is now known as jamielennox | 03:57 | |
*** sacharya has joined #openstack-ironic | 04:05 | |
*** cui has quit IRC | 04:05 | |
*** yushiro has joined #openstack-ironic | 04:08 | |
*** yushiro has left #openstack-ironic | 04:08 | |
*** jerrygb has joined #openstack-ironic | 04:14 | |
*** sinvalv has quit IRC | 04:16 | |
*** wuhg has joined #openstack-ironic | 04:21 | |
*** alexpilotti has joined #openstack-ironic | 04:25 | |
*** Marga_ has quit IRC | 04:27 | |
*** alexpilotti has quit IRC | 04:29 | |
*** achanda has joined #openstack-ironic | 04:37 | |
*** kalpase has joined #openstack-ironic | 04:43 | |
*** sacharya has quit IRC | 04:52 | |
*** lazy_prince has joined #openstack-ironic | 05:13 | |
*** sacharya has joined #openstack-ironic | 05:19 | |
*** sacharya has quit IRC | 05:20 | |
*** smoriya has quit IRC | 05:22 | |
openstackgerrit | chenglch proposed openstack/ironic: set-console-mode should validate terminal command https://review.openstack.org/235159 | 05:36 |
*** greghaynes has quit IRC | 05:38 | |
*** greghaynes has joined #openstack-ironic | 05:48 | |
openstackgerrit | Syed Ismail Faizan Barmawer proposed openstack/ironic-lib: Replace rootwrap_config and rootwrap_helper_cmd with root_helper https://review.openstack.org/245741 | 05:53 |
*** zz_smoriya has joined #openstack-ironic | 05:53 | |
*** zz_smoriya is now known as smoriya | 05:53 | |
*** greghaynes has quit IRC | 05:54 | |
*** greghaynes has joined #openstack-ironic | 06:01 | |
*** achanda has quit IRC | 06:15 | |
*** killer_prince has joined #openstack-ironic | 06:17 | |
*** lazy_prince has quit IRC | 06:18 | |
*** subscope has joined #openstack-ironic | 06:21 | |
*** kalpase has left #openstack-ironic | 06:22 | |
*** kalpase has joined #openstack-ironic | 06:22 | |
*** rcernin has joined #openstack-ironic | 06:23 | |
*** yonglihe has quit IRC | 06:52 | |
*** greghaynes has quit IRC | 06:56 | |
*** greghaynes has joined #openstack-ironic | 06:58 | |
*** cui has joined #openstack-ironic | 07:03 | |
*** yolanda has quit IRC | 07:16 | |
*** yolanda has joined #openstack-ironic | 07:20 | |
*** yolanda has quit IRC | 07:23 | |
*** yolanda has joined #openstack-ironic | 07:24 | |
*** killer_prince has quit IRC | 07:35 | |
*** killer_prince has joined #openstack-ironic | 07:36 | |
openstackgerrit | Tan Lin proposed openstack/ironic: Make use of oslo-config-generator https://review.openstack.org/247331 | 07:36 |
*** jerrygb has quit IRC | 07:40 | |
*** jerrygb has joined #openstack-ironic | 07:40 | |
*** jerrygb has quit IRC | 07:44 | |
*** Haomeng has joined #openstack-ironic | 07:45 | |
openstackgerrit | Yuiko Takada proposed openstack/ironic: [WIP]Use Tempest plugin interface https://review.openstack.org/246161 | 07:46 |
openstackgerrit | Tan Lin proposed openstack/ironic: Make use of oslo-config-generator https://review.openstack.org/247331 | 07:52 |
*** e0ne has joined #openstack-ironic | 07:54 | |
*** amotoki has joined #openstack-ironic | 07:56 | |
*** alexpilotti has joined #openstack-ironic | 08:01 | |
*** achanda has joined #openstack-ironic | 08:02 | |
*** alexpilotti has quit IRC | 08:06 | |
*** achanda has quit IRC | 08:08 | |
*** ifarkas has joined #openstack-ironic | 08:08 | |
*** cui has quit IRC | 08:18 | |
*** cui has joined #openstack-ironic | 08:25 | |
openstackgerrit | Rico Lin proposed openstack/python-ironicclient: improve readme contents https://review.openstack.org/235228 | 08:29 |
*** alexpilotti has joined #openstack-ironic | 08:32 | |
*** cccc has joined #openstack-ironic | 08:34 | |
*** phschwartz_ has joined #openstack-ironic | 08:34 | |
*** cui has quit IRC | 08:34 | |
*** phschwartz has quit IRC | 08:35 | |
*** alexpilotti has quit IRC | 08:36 | |
*** cui has joined #openstack-ironic | 08:36 | |
*** alexpilotti has joined #openstack-ironic | 08:37 | |
*** cccc has quit IRC | 08:38 | |
*** jerrygb has joined #openstack-ironic | 08:41 | |
*** alexpilotti has quit IRC | 08:41 | |
*** jerrygb has quit IRC | 08:46 | |
*** athomas has joined #openstack-ironic | 08:50 | |
openstackgerrit | Sergii Turivnyi proposed openstack/python-ironicclient: Add sanity tests for testing actions with Node https://review.openstack.org/239506 | 08:51 |
*** afaranha has quit IRC | 08:51 | |
*** afaranha has joined #openstack-ironic | 08:52 | |
openstackgerrit | Zhenguo Niu proposed openstack/ironic: Take over console session if enabled https://review.openstack.org/247353 | 08:52 |
*** mbound has joined #openstack-ironic | 08:55 | |
*** mbound has quit IRC | 08:57 | |
openstackgerrit | Haozhi Cui proposed openstack/python-ironicclient: update node shell help info https://review.openstack.org/246899 | 08:59 |
*** ndipanov has joined #openstack-ironic | 08:59 | |
*** achanda has joined #openstack-ironic | 09:03 | |
*** mkovacik has joined #openstack-ironic | 09:04 | |
betherly | Morning! | 09:08 |
*** alexpilotti has joined #openstack-ironic | 09:08 | |
*** romainh has joined #openstack-ironic | 09:08 | |
*** alexpilotti has quit IRC | 09:13 | |
*** ionutbalutoiu has joined #openstack-ironic | 09:18 | |
*** e0ne has quit IRC | 09:18 | |
*** kozhukalov_ has joined #openstack-ironic | 09:21 | |
*** yuikotakada has joined #openstack-ironic | 09:22 | |
*** romainh has left #openstack-ironic | 09:23 | |
openstackgerrit | Shuquan Huang proposed openstack/ironic: Add troubleshooting docs for "no valid host found" https://review.openstack.org/239206 | 09:25 |
*** zer0c00l_ has joined #openstack-ironic | 09:26 | |
*** zer0c00l_ has quit IRC | 09:28 | |
*** cui has quit IRC | 09:28 | |
*** cui has joined #openstack-ironic | 09:29 | |
*** achanda has quit IRC | 09:30 | |
openstackgerrit | Anton Arefiev proposed openstack/python-ironicclient: Add missing translation markers https://review.openstack.org/246875 | 09:30 |
*** jistr has joined #openstack-ironic | 09:35 | |
*** alexpilotti has joined #openstack-ironic | 09:36 | |
*** pas-ha has joined #openstack-ironic | 09:38 | |
*** zer0c00l_ has joined #openstack-ironic | 09:38 | |
*** dtantsur|afk is now known as dtantsur | 09:39 | |
dtantsur | Morning Ironic | 09:39 |
* dtantsur tries to wake up | 09:39 | |
*** mbound has joined #openstack-ironic | 09:40 | |
*** PradeepV has joined #openstack-ironic | 09:40 | |
*** alexpilotti has quit IRC | 09:41 | |
*** daemontool has joined #openstack-ironic | 09:42 | |
*** kromanenko has joined #openstack-ironic | 09:43 | |
*** daemontool has quit IRC | 09:47 | |
*** daemontool has joined #openstack-ironic | 09:48 | |
*** mbound has quit IRC | 09:49 | |
*** mbound has joined #openstack-ironic | 09:50 | |
openstackgerrit | Yuriy Zveryanskyy proposed openstack/ironic-specs: Add System Event Log support to management interface https://review.openstack.org/246965 | 09:51 |
*** amotoki has quit IRC | 09:53 | |
*** amotoki has joined #openstack-ironic | 09:53 | |
*** mbound has quit IRC | 09:54 | |
*** amotoki has quit IRC | 09:54 | |
*** naohirot_ has quit IRC | 09:57 | |
yuriyz | morning Ironic dtantsur | 09:58 |
*** _degorenko is now known as degorenko | 09:58 | |
*** lucas-dinner is now known as lucasagomes | 09:59 | |
dtantsur | yuriyz, o/ | 09:59 |
openstackgerrit | Anton Arefiev proposed openstack/python-ironicclient: Add missing translation markers https://review.openstack.org/246875 | 09:59 |
*** pas-ha has quit IRC | 10:01 | |
*** openstackgerrit has quit IRC | 10:01 | |
*** openstackgerrit has joined #openstack-ironic | 10:02 | |
*** subscope has quit IRC | 10:07 | |
*** zhenguo has quit IRC | 10:07 | |
*** subscope has joined #openstack-ironic | 10:08 | |
*** alexpilotti has joined #openstack-ironic | 10:08 | |
*** subscope has quit IRC | 10:08 | |
*** jcoufal has joined #openstack-ironic | 10:11 | |
*** alexpilotti has quit IRC | 10:12 | |
lintan_ | morning yuriyz and dtantsur :) | 10:13 |
dtantsur | o/ | 10:13 |
*** mbound has joined #openstack-ironic | 10:18 | |
*** openstack has joined #openstack-ironic | 10:20 | |
*** e0ne has joined #openstack-ironic | 10:20 | |
dtantsur | morning aarefiev | 10:21 |
*** pas-ha has joined #openstack-ironic | 10:22 | |
*** mbound has quit IRC | 10:22 | |
*** mgould has joined #openstack-ironic | 10:23 | |
*** subscope has joined #openstack-ironic | 10:25 | |
*** achanda has joined #openstack-ironic | 10:27 | |
*** alexpilotti has joined #openstack-ironic | 10:29 | |
*** cui has quit IRC | 10:35 | |
*** jerrygb has joined #openstack-ironic | 10:42 | |
*** dims has joined #openstack-ironic | 10:45 | |
*** jerrygb has quit IRC | 10:47 | |
openstackgerrit | Ionut-Madalin Balutoiu proposed openstack/ironic: Add clean up method for the DHCP factory https://review.openstack.org/247423 | 10:53 |
*** jcoufal_ has joined #openstack-ironic | 10:54 | |
*** jcoufal has quit IRC | 10:55 | |
vdrok | morning dtantsur lintan_ and ironic | 10:56 |
sambetts | Morning all o/ | 10:57 |
vdrok | morning sambetts :) | 11:00 |
*** phschwartz has joined #openstack-ironic | 11:00 | |
*** logan2 has quit IRC | 11:01 | |
*** phschwartz_ has quit IRC | 11:01 | |
*** logan2 has joined #openstack-ironic | 11:01 | |
*** ekarlso has quit IRC | 11:05 | |
mgould | morning all | 11:06 |
lucasagomes | mgould, vdrok sambetts dtantsur lintan_ aarefiev morning all | 11:09 |
vdrok | morning mgould and lucasagomes | 11:09 |
sambetts | devananda: Its a difficult one, the issue I had with 'include' was that it didn't feel like an opposite action to ignore, but is it better or worse than acknowledge I'm not sure about that either, what about 'restore' or 'recognise'? | 11:12 |
sambetts | o/ lucasagomes vdrok | 11:12 |
sambetts | hi mgould | 11:12 |
betherly | hi all! there are a few reviews on Ironic webclient sitting around for a over a month now. Need at least 1 more +1 on them before merging if anyones up for doing a bit of JS review? | 11:13 |
betherly | https://review.openstack.org/#/c/228571/ | 11:14 |
*** Haomeng has quit IRC | 11:14 | |
sambetts | betherly: I'll take a look :) | 11:14 |
betherly | https://review.openstack.org/#/c/231642/ | 11:14 |
*** Haomeng has joined #openstack-ironic | 11:14 | |
betherly | https://review.openstack.org/#/c/231641/ | 11:14 |
betherly | https://review.openstack.org/#/c/241799/ | 11:14 |
betherly | thanks so much sambetts :D | 11:14 |
mgould | sambetts, maybe "notice"? | 11:14 |
sambetts | mgould, devananda: ^ yeah, thats another idea | 11:15 |
*** jamielennox is now known as jamielennox|away | 11:22 | |
*** ionutbalutoiu has quit IRC | 11:24 | |
*** ionutbalutoiu has joined #openstack-ironic | 11:26 | |
openstackgerrit | Merged openstack/ironic-inspector: Updated from global requirements https://review.openstack.org/247112 | 11:28 |
openstackgerrit | Merged openstack/ironic-inspector: Issue a warning when add_ports=pxe and not PXE NIC address is provided https://review.openstack.org/245936 | 11:28 |
openstackgerrit | Merged openstack/ironic-python-agent: Refactor the image download and checksum computation bits https://review.openstack.org/234338 | 11:28 |
openstackgerrit | Merged openstack/python-ironicclient: replace LOG.warn with LOG.warning https://review.openstack.org/247255 | 11:29 |
*** Haomeng has quit IRC | 11:29 | |
*** Haomeng has joined #openstack-ironic | 11:29 | |
openstackgerrit | Merged openstack/python-ironicclient: update node shell help info https://review.openstack.org/246899 | 11:29 |
openstackgerrit | Merged openstack/python-ironicclient: Updated from global requirements https://review.openstack.org/247153 | 11:29 |
*** ekarlso has joined #openstack-ironic | 11:30 | |
sinval | good morning folks | 11:31 |
openstackgerrit | Merged openstack/python-ironicclient: Add documentation on how to run tests https://review.openstack.org/240866 | 11:31 |
sambetts | Morning sinval | 11:32 |
mgould | morning sinval | 11:33 |
*** sacharya has joined #openstack-ironic | 11:37 | |
*** subscope has quit IRC | 11:39 | |
*** subscope has joined #openstack-ironic | 11:40 | |
*** subscope has quit IRC | 11:40 | |
*** sacharya has quit IRC | 11:41 | |
*** mgould has quit IRC | 11:42 | |
*** mgould has joined #openstack-ironic | 11:42 | |
*** alexpilotti has quit IRC | 11:49 | |
*** alexpilotti has joined #openstack-ironic | 11:53 | |
dtantsur | morning mgould, sinval, sambetts, lucasagomes, vdrok, betherly | 11:59 |
dtantsur | cool to see so many people in our timezone \o/ | 11:59 |
betherly | Morning dtantsur :) | 11:59 |
lucasagomes | indeed, this TZ is getting more and more active with time | 12:01 |
*** Haomeng has quit IRC | 12:01 | |
betherly | :) | 12:02 |
*** Haomeng has joined #openstack-ironic | 12:02 | |
sambetts | \o/ woop | 12:03 |
sinval | hahaha dtantsur | 12:03 |
sinval | morning all | 12:03 |
*** dims has quit IRC | 12:16 | |
*** trown|outttypeww is now known as trown | 12:19 | |
*** e0ne has quit IRC | 12:30 | |
openstackgerrit | Yuiko Takada proposed openstack/ironic-specs: Add allowed transitions to API https://review.openstack.org/224022 | 12:39 |
*** e0ne has joined #openstack-ironic | 12:40 | |
*** jerrygb has joined #openstack-ironic | 12:43 | |
*** yuikotakada has quit IRC | 12:43 | |
*** jerrygb has quit IRC | 12:49 | |
*** achanda has quit IRC | 12:52 | |
*** baoli has joined #openstack-ironic | 12:56 | |
*** kalpase has left #openstack-ironic | 12:56 | |
*** subscope has joined #openstack-ironic | 12:57 | |
*** athomas has quit IRC | 13:06 | |
sturivnyi | Haomeng, dtantsur: Thanks for review =) | 13:08 |
dtantsur | yvw :) | 13:09 |
*** kalpase has joined #openstack-ironic | 13:11 | |
openstackgerrit | Sergii Turivnyi proposed openstack/python-ironicclient: Add sanity tests for testing actions with Node https://review.openstack.org/239506 | 13:11 |
*** kalpase has left #openstack-ironic | 13:14 | |
openstackgerrit | Sergii Turivnyi proposed openstack/python-ironicclient: Add sanity tests for testing actions with Node https://review.openstack.org/239506 | 13:15 |
*** athomas has joined #openstack-ironic | 13:19 | |
*** dprince has joined #openstack-ironic | 13:22 | |
*** achanda has joined #openstack-ironic | 13:29 | |
sambetts | dtantsur: https://review.openstack.org/#/c/247027/ | 13:31 |
dtantsur | oh wow! | 13:31 |
sambetts | dtantsur: its the spec for the neutron dhcp work | 13:31 |
dtantsur | super! | 13:31 |
*** openstackstatus has joined #openstack-ironic | 13:34 | |
*** ChanServ sets mode: +v openstackstatus | 13:34 | |
thiagop | Good morning Ironicers | 13:34 |
dtantsur | morning thiagop | 13:37 |
thiagop | dtantsur: o/ | 13:38 |
jroll | goooood morning <all the names because not enough coffee yet> | 13:39 |
dtantsur | morning jroll! | 13:40 |
thiagop | good morning jroll (speaking of coffee...) | 13:40 |
*** sacharya has joined #openstack-ironic | 13:44 | |
sambetts | o/ jroll thiagop | 13:46 |
openstackgerrit | Dmitry Tantsur proposed openstack/ironic-python-agent: Fix "logs" inspection collector when logs contain non-ascii symbols https://review.openstack.org/247514 | 13:48 |
*** sacharya has quit IRC | 13:48 | |
vdrok | morning jroll and thiagop | 13:49 |
*** jerrygb has joined #openstack-ironic | 14:00 | |
openstackgerrit | Sergii Turivnyi proposed openstack/python-ironicclient: Add sanity tests for testing actions with Chassis https://review.openstack.org/240562 | 14:02 |
openstackgerrit | Sergii Turivnyi proposed openstack/python-ironicclient: Add sanity tests for testing actions with Chassis https://review.openstack.org/240562 | 14:03 |
*** smoriya_ has quit IRC | 14:04 | |
*** jerrygb has quit IRC | 14:05 | |
*** baoli has quit IRC | 14:07 | |
*** daemontool_ has joined #openstack-ironic | 14:08 | |
*** daemontool has quit IRC | 14:09 | |
liliars | good morning everyone :) | 14:14 |
*** jerrygb has joined #openstack-ironic | 14:14 | |
*** rloo has joined #openstack-ironic | 14:14 | |
sambetts | hey o/ | 14:14 |
*** baoli has joined #openstack-ironic | 14:15 | |
*** daemontool_ has quit IRC | 14:16 | |
dtantsur | morning liliars | 14:17 |
dtantsur | lucasagomes, how to create an encrypted password for that dynamic-login element? | 14:17 |
*** daemontool_ has joined #openstack-ironic | 14:17 | |
lucasagomes | dtantsur, perl -e 'print crypt("YourPasswd", "salt"),"\n"' | 14:18 |
* lucasagomes was the only way I found | 14:18 | |
liliars | question: in a change involving our dev-guide, someone pointed that we have pxe_ssh as the default deploy driver in the local.conf sample of that page. as we are moving to default agent, is it reasonable to change pxe_ssh to e.g. agent_ssh there? | 14:18 |
lucasagomes | dtantsur, if that gets merged I will document in Ironic how to do it | 14:18 |
liliars | hi sambetts, dtantsur o/ | 14:18 |
sambetts | liliars: I don't think so | 14:18 |
sambetts | liliars: that driver should be call pxe_iscsi_ssh, we suppport iscsi and agent deploy with IPA | 14:19 |
liliars | yeah, that was the suggestion (agent_ssh one) but I had mixed feelings | 14:20 |
dtantsur | liliars, we now use pxe_ssh with agent, so no | 14:21 |
liliars | exactly, I guess it was the naming that confused folks | 14:22 |
*** achanda has quit IRC | 14:22 | |
liliars | but I agree, was just making sure | 14:22 |
liliars | thanks sambetts dtantsur :) | 14:22 |
openstackgerrit | Brad P. Crochet proposed openstack/ironic-specs: OpenStackClient plugin spec https://review.openstack.org/247539 | 14:23 |
openstackgerrit | Ruby Loo proposed openstack/ironic-lib: Replace rootwrap_config and rootwrap_helper_cmd with root_helper https://review.openstack.org/245741 | 14:26 |
*** dims has joined #openstack-ironic | 14:27 | |
rloo | hi liliars, sambetts, lucasagomes, dtantsur | 14:27 |
mgould | lucasagomes, if you'd rather generate the password hash from python then you can use the crypt module: https://docs.python.org/2/library/crypt.html | 14:27 |
lucasagomes | rloo, morning | 14:27 |
rloo | and mgould :) | 14:27 |
aarefiev | sambetts: hi, do you have plans on autodiscovery spec ? | 14:28 |
aarefiev | rloo: hi) | 14:28 |
lucasagomes | mgould, ++ that is just for this patch here https://review.openstack.org/#/c/245082/ | 14:28 |
rloo | dtantsur and others. wrt ironic-lib, Syed replaced rootwrap_config & rootwrap_helper config with root_helper config. Do we need to deprecate them first? no one should be using the library yet. | 14:28 |
*** PradeepV has quit IRC | 14:28 | |
rloo | dtantsur: https://review.openstack.org/#/c/245741/ | 14:28 |
lucasagomes | so it's kinda of a manual thing | 14:28 |
rloo | hi aarefiev | 14:28 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/ironic-python-agent: Updated from global requirements https://review.openstack.org/247131 | 14:29 |
*** killer_prince has quit IRC | 14:30 | |
*** mgoddard_ has joined #openstack-ironic | 14:31 | |
dtantsur | morning rloo. I don't think anyone realistically uses ironic-lib right now.. | 14:31 |
dtantsur | lucasagomes, I remember you had some problems with using {mac} in iPXE. what was it? | 14:31 |
rloo | dtantsur: good. if some core has time to review/+A 24574, i think we can do a release and try to get ironic using the library. | 14:31 |
lucasagomes | dtantsur, it's an old bug in iPXE (2013, but we only package old ROMs) that the micro {mac} had no guarantee to be the mac address of the last opened NIC | 14:32 |
lucasagomes | so we could be booting from NIC A, and {mac} would be the address of NIC B | 14:32 |
dtantsur | lucasagomes, so I can't rely on it as a booting MAC? damn.. | 14:32 |
lucasagomes | it was bug, fixed long time ago | 14:33 |
lucasagomes | dtantsur, the problem was that in Ironic we only have one port registered | 14:33 |
lucasagomes | so {mac} from B wouldn't have a pxe config file | 14:33 |
lucasagomes | and boot would fail | 14:33 |
dtantsur | yeah, and now I need to set BOOTIF for inspection. not sure how it used to work before move to IPA, but now it apparently does not | 14:33 |
*** mgoddard has quit IRC | 14:34 | |
lucasagomes | right BOOTIF will happen after all this iPXE stuff | 14:34 |
lucasagomes | dtantsur, it's fixed in Ironic btw... what I do is to loop on the NICs and try to find the first one that has a pxe configuration in Ironic | 14:34 |
dtantsur | lucasagomes, well, it's not the case for inspector.. but probably it should not be | 14:35 |
dtantsur | lucasagomes, look what we used to have: https://github.com/rdo-management/instack-undercloud/blob/master/elements/ironic-discoverd/os-apply-config/httpboot/discoverd.ipxe | 14:35 |
lucasagomes | dtantsur, oh right yeah... | 14:35 |
lucasagomes | dtantsur, but for inspector you don't need to care | 14:35 |
lucasagomes | do you? cause you always boot a default config | 14:35 |
lucasagomes | independent of the mac | 14:35 |
lucasagomes | oh BOOTIF | 14:36 |
lucasagomes | I see there | 14:36 |
lucasagomes | urgh... | 14:36 |
dtantsur | lucasagomes, I need a proper BOOTIF to create a MAC for PXE-booting port | 14:36 |
* lucasagomes thinks | 14:37 | |
dtantsur | lucasagomes, probably the only answer is "update the damned iPXE firmware" | 14:38 |
lucasagomes | dtantsur, yes | 14:38 |
lucasagomes | that's the right thing to do | 14:38 |
lucasagomes | dtantsur btw the fix is this one http://git.ipxe.org/ipxe.git/commitdiff/66ea458 | 14:40 |
lucasagomes | Sat, 13 Jul 2013 13:06:20 | 14:40 |
*** krtaylor has quit IRC | 14:42 | |
*** linggao has joined #openstack-ironic | 14:43 | |
sambetts | aarefiev: I havn't begun to draw one up yet if thats what you mean, we don't actually have a spec process (yet) for inspector | 14:44 |
*** alexpilotti has quit IRC | 14:45 | |
dtantsur | sambetts, btw see my email about spec process | 14:45 |
*** jasonamyers has quit IRC | 14:46 | |
*** betherly has quit IRC | 14:46 | |
*** agordeev has quit IRC | 14:46 | |
sambetts | dtantsur: Yes, I just read it hence the "(yet)" hehe | 14:46 |
*** JoshNang has quit IRC | 14:46 | |
aarefiev | sambetts: ok, dtantsur ahead of me | 14:46 |
*** kozhukalov has quit IRC | 14:46 | |
aarefiev | sambetts: it would be nice to continue discussion in spec | 14:47 |
*** romcheg has quit IRC | 14:47 | |
sambetts | aarefiev: I agree, I always lose stuff in the mailer | 14:47 |
sambetts | lucasagomes, dtantsur: have you ever seen a baremetal node power up, pxe request, download the kernel and ramdisk, then just sit forever at "Booting Kernel." ' | 14:49 |
aarefiev | sambetts, dtantsur: maybe we could start from ironic-specs, wdyt? | 14:50 |
lucasagomes | sambetts, not at the top of my head... you sure it's stuck? Or is the console logs being redirected somewhere else so you actually don't see it ? | 14:51 |
sambetts | lucasagomes: not sure, but I'm never seeing the heartbeat from the agent | 14:51 |
lucasagomes | the only thing I can think of is the pxe/ipxe image to be old and not able to work with the rootfs from the initram | 14:51 |
lucasagomes | but that;s very unlikely | 14:52 |
lucasagomes | sambetts, right, can you try to ping it? | 14:52 |
openstackgerrit | Sergii Turivnyi proposed openstack/python-ironicclient: Add sanity tests for testing actions with Node https://review.openstack.org/239506 | 14:53 |
sambetts | lucasagomes: I'll give it a go | 14:53 |
openstackgerrit | Sergii Turivnyi proposed openstack/python-ironicclient: Add sanity tests for testing actions with Chassis https://review.openstack.org/240562 | 14:53 |
openstackgerrit | Ionut-Madalin Balutoiu proposed openstack/ironic: Add clean up method for the DHCP factory https://review.openstack.org/245911 | 14:53 |
lucasagomes | sambetts, acl | 14:53 |
lucasagomes | ack* | 14:53 |
dtantsur | aarefiev, maybe, depending on what jroll and other folks think about it :) | 14:53 |
dtantsur | (that's about where to put inspector specs) | 14:54 |
*** JoshNang has joined #openstack-ironic | 14:54 | |
openstackgerrit | Brad P. Crochet proposed openstack/ironic-specs: OpenStackClient plugin spec https://review.openstack.org/247539 | 14:55 |
*** krtaylor has joined #openstack-ironic | 14:55 | |
*** kozhukalov has joined #openstack-ironic | 14:56 | |
*** agordeev has joined #openstack-ironic | 14:58 | |
*** betherly has joined #openstack-ironic | 14:58 | |
openstackgerrit | Jim Rollenhagen proposed openstack/ironic: Firmware update as part of iLO manual cleaning process https://review.openstack.org/211019 | 15:02 |
jroll | rloo: ^ I approved a spec-less blueprint for that, could you remove the -2? | 15:02 |
jroll | dtantsur: so much meh | 15:02 |
*** rcernin has quit IRC | 15:03 | |
rloo | jroll: done | 15:03 |
jroll | thanks | 15:03 |
rloo | is that our first spec-less blueprint since we started specs? :) | 15:03 |
jroll | maybe! | 15:03 |
jroll | wait, no, I approved one for multiple nodes in client commands | 15:04 |
*** jasonamyers has joined #openstack-ironic | 15:04 | |
*** romcheg has joined #openstack-ironic | 15:06 | |
sambetts | lucasagomes: nope no ping :( | 15:11 |
openstackgerrit | Merged openstack/ironic-lib: Updated from global requirements https://review.openstack.org/247130 | 15:11 |
lucasagomes | sambetts, hmm... so odd | 15:11 |
lucasagomes | sambetts, are you using iPXE or standard PXE ? | 15:11 |
sambetts | standard PXE | 15:11 |
lucasagomes | right, that's harder cause you can't script hmmm | 15:11 |
* lucasagomes thinkins | 15:11 | |
sambetts | and its the downloaded CoreOS ramdisk and kernel | 15:11 |
* lucasagomes thinks* | 15:11 | |
lucasagomes | sambetts, the arch of that machine and the kernel ur booting is fine right? | 15:14 |
sambetts | 64bit Intel CPUs so it should be fine I hope | 15:15 |
vdrok | jroll, this seems to be completed, could you change the status of it? https://blueprints.launchpad.net/ironic/+spec/radosgw-temp-url | 15:22 |
vdrok | and morning rloo :) | 15:22 |
lucasagomes | sambetts, maybe add debug to the kernel cmdline just to see if the kernel is at least being loaded | 15:22 |
*** yonglihe has joined #openstack-ironic | 15:22 | |
jroll | vdrok: wow, so quick | 15:22 |
jroll | vdrok: done, thanks for the ping on that | 15:23 |
vdrok | jroll, thanks :) | 15:23 |
rloo | hi vdrok ;) | 15:24 |
*** Piet has joined #openstack-ironic | 15:25 | |
vdrok | rloo, as for patch with pillow, as I understand it is installed as dependency of some other pip packages | 15:26 |
vdrok | rloo, and here is the patch to devstack about it - https://review.openstack.org/#/c/237348/4 | 15:26 |
thiagop | Folks, I'm having a little non-deterministic problem here, maybe you passed for something similar... | 15:27 |
jroll | rloo: vdrok: what's up with pillow? I was involved with adding that to fix a gate break but I think we might be able to remove it | 15:27 |
sambetts | lucasagomes: giving it a go | 15:27 |
rloo | vdrok: honestly, i don't understand it. | 15:27 |
rloo | jroll: i think when we removed pillow from our test-requirements, it broke our dev environment | 15:28 |
thiagop | I'm using fake_oneview to tests some stuff. I add a node with no problem, but when I try to delete it, it fails saying that no driver fake_oneview found | 15:28 |
thiagop | but when I try delete form a few times it suddenly works | 15:28 |
rloo | jroll: vdrok has a patch to our dev-start doc to install a package cuz of this i think. | 15:28 |
jroll | rloo: "our" being "ironic"? hmm | 15:28 |
vdrok | jroll, here it is https://review.openstack.org/#/c/245989/ | 15:29 |
rloo | jroll: yeah, that patch ^^. I was puzzled by it all, why not just put pillow back in test-requirements then. | 15:29 |
rloo | jroll, vdrok: and yes, I confirmed that it broke my dev environment too, until i added pillow again | 15:30 |
jroll | rloo: oh. yeah. we need libjpeg-dev. the pillow in test-requirements pinned pillow to a version that doesn't need libjpeg-dev. | 15:30 |
rloo | jroll: OH. that explains it then. | 15:31 |
jroll | :) | 15:31 |
*** lazy_prince has joined #openstack-ironic | 15:31 | |
* jroll +2's that patch | 15:31 | |
vdrok | jroll, thanks for clarifying :) | 15:31 |
jroll | actually | 15:31 |
jroll | not sure why we need rpm-config or whatever? | 15:32 |
vdrok | yes, I'm not sure about it too, lucasagomes dtantsur could you look at https://review.openstack.org/#/c/245989/1 | 15:32 |
lucasagomes | will do | 15:33 |
lucasagomes | sambetts, ack | 15:33 |
jroll | vdrok: I'm going to -1 for now | 15:33 |
vdrok | jroll, ok | 15:33 |
jroll | with comments | 15:34 |
jroll | thanks for the patch though :D | 15:34 |
lucasagomes | libjpeg hmmmmmmm | 15:35 |
vdrok | will update when it will be clear whether the other package is needed :) | 15:35 |
*** mgoddard has joined #openstack-ironic | 15:35 | |
*** mgoddard_ has quit IRC | 15:35 | |
lucasagomes | vdrok, yeah not sure about redhat-rpm-config... seems that it's not needed | 15:39 |
vdrok | lucasagomes, jroll also looking here - https://review.openstack.org/#/c/237348/4/files/rpms/general it has this package | 15:40 |
*** stendulker has joined #openstack-ironic | 15:40 | |
openstackgerrit | Anton Arefiev proposed openstack/python-ironicclient: Add missing translation markers https://review.openstack.org/246875 | 15:40 |
jroll | vdrok: well, we don't need everything devstack installs :) | 15:40 |
vdrok | ok, I'll double check on a clean vm then and update, just to be sure | 15:42 |
rloo | vdrok: i just installed the lib, and it is working so the rpm* isn't needed. | 15:42 |
vdrok | rloo, oh, great, then will update now :) | 15:42 |
rloo | vdrok: at least in RHEL7 | 15:42 |
*** mkovacik has quit IRC | 15:44 | |
*** achanda has joined #openstack-ironic | 15:45 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/ironic: Updated from global requirements https://review.openstack.org/247111 | 15:46 |
stendulker | rloo: Hi | 15:46 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/ironic-lib: Updated from global requirements https://review.openstack.org/247602 | 15:46 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/ironic-python-agent: Updated from global requirements https://review.openstack.org/247131 | 15:46 |
rloo | hi stendulker | 15:46 |
stendulker | rloo: This is regarding my review comment | 15:46 |
*** harshs has joined #openstack-ironic | 15:47 | |
stendulker | rloo: There was a bit of issue in my testcase.. | 15:48 |
stendulker | rloo: Can you pls check thsi testcase and let me know if its incorrect http://paste.openstack.org/show/479439/ | 15:48 |
rloo | stendulker: sorry, i could, but i'm in the middle of something. don't want to switch gears. | 15:49 |
stendulker | stendulker: Have corrected few things.. Wanted to know what should be target_state of fsm | 15:49 |
stendulker | rloo: ok. | 15:49 |
sambetts | lucasagomes: I had to change the console= from ttyS0 to tty0 to see any output, it seems to load to a random point and then just freeze :/ | 15:50 |
lucasagomes | sambetts, a-ha ok so console was being redirected | 15:51 |
lucasagomes | hmm... any pointers where it does hangs? | 15:51 |
openstackgerrit | Anton Arefiev proposed openstack/python-ironicclient: Use requests lib in HTTPClient https://review.openstack.org/229286 | 15:51 |
lucasagomes | is it a kernel panic or something? | 15:51 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/python-ironicclient: Updated from global requirements https://review.openstack.org/247641 | 15:52 |
sambetts | lucasagomes: thats what I'm trying to work out now, the last 2 times its done it frooze, have been in different places it seems | 15:52 |
openstackgerrit | Brad P. Crochet proposed openstack/ironic-specs: OpenStackClient plugin spec https://review.openstack.org/247539 | 15:53 |
lucasagomes | sambetts, try to set console=tty0 console=ttyS0,9600n8 | 15:53 |
lucasagomes | on the kernel cmdline as well | 15:53 |
sambetts | 9600n8? | 15:53 |
sambetts | ooooo I got an error!!! | 15:53 |
lucasagomes | yeah... oh right, which error? | 15:54 |
sambetts | lucasagomes: Specified switch root path /sysroot does not seem to be an OS tree, /etc/os-release is missing | 15:54 |
lucasagomes | sambetts, it's the root= from ur kernel cmdline | 15:55 |
lucasagomes | are you pointing it to a partition UUID ? | 15:55 |
*** mgould has quit IRC | 15:56 | |
sambetts | I don't see a root= but I see a disk= | 15:56 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/ironic: Updated from global requirements https://review.openstack.org/247111 | 15:56 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/ironic-inspector: Updated from global requirements https://review.openstack.org/247662 | 15:56 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/ironic-lib: Updated from global requirements https://review.openstack.org/247602 | 15:56 |
lucasagomes | for ostree you will also have a ostree= param in the cmdline | 15:56 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/ironic-python-agent: Updated from global requirements https://review.openstack.org/247131 | 15:56 |
lucasagomes | something like | 15:56 |
* lucasagomes grabs an example | 15:56 | |
lucasagomes | sambetts, root=/dev/mapper/atomicos-root ostree=/ostree/boot.0/fedora-atomic/a002a2c2e44240db614e09e82c7822322253bfcaad0226f3ff9befb9f96d315f/0 | 15:56 |
sambetts | lucasagomes: thats not there either | 15:56 |
lucasagomes | but odd... which ramdisk your trying to boot there? | 15:57 |
lucasagomes | is it the coreos one? not sure they use ostree tho | 15:57 |
sambetts | lucasagomes: its the CoreOS one, downloaded from the tarballs or it should be unless something weird has happend | 15:57 |
lucasagomes | sambetts, it's not the IPA ramdisk with coreos is it? | 15:58 |
sambetts | lucasagomes: yup | 15:58 |
lucasagomes | right that wouldn't be needed at all.. odd | 15:58 |
sambetts | lucasagomes: thats what I thought because I've never had to add that in any of my other setups | 15:58 |
lucasagomes | sambetts, yeha | 16:00 |
sambetts | hmmm ... I might try redowloading the tarballs, and reuploading them to glance just to be sure | 16:00 |
lucasagomes | try to remove all that disk= root= etc... from the cmdline | 16:00 |
dtantsur | lucasagomes, this dynamic-login thing does not let me in... which user should I use? | 16:01 |
lucasagomes | dtantsur, root | 16:01 |
dtantsur | oh sorry, wait, it might be my fault | 16:01 |
lucasagomes | dtantsur, did you log in? | 16:01 |
dtantsur | not yet, but I may be using a wrong ramdisk now | 16:02 |
lucasagomes | oh | 16:02 |
lucasagomes | you can just replace it in the httpboot and restart the vm/machine | 16:02 |
dtantsur | lucasagomes, no, no luch | 16:04 |
dtantsur | * luck | 16:04 |
lucasagomes | dtantsur, 1 sec I will try it out | 16:04 |
dtantsur | lucasagomes, if your password is not super secret, could you send me both encrypted and plain text thing which work for you? | 16:04 |
lucasagomes | dtantsur, sure... thing is you can set any password | 16:05 |
lucasagomes | salSp1wOPp6fk | 16:06 |
lucasagomes | test | 16:06 |
lucasagomes | dtantsur, so add rootpwd=salSp1wOPp6fk to the kernel cmdline | 16:06 |
lucasagomes | and then try to log as root:test | 16:06 |
* lucasagomes will test it in a min | 16:07 | |
*** dprince has quit IRC | 16:07 | |
*** tideline has joined #openstack-ironic | 16:10 | |
*** tideline has left #openstack-ironic | 16:11 | |
dtantsur | lucasagomes, does not work for me.. | 16:14 |
lucasagomes | dtantsur, :-( | 16:14 |
lucasagomes | I haven't tested the encrypted since I changed it cause its just a -e to the command | 16:14 |
lucasagomes | dtantsur, one sec I will give it a go | 16:14 |
dtantsur | lucasagomes, maybe we had to prepend salt | 16:14 |
lucasagomes | could be | 16:14 |
* lucasagomes checks | 16:15 | |
*** mgould has joined #openstack-ironic | 16:15 | |
openstackgerrit | Vladyslav Drok proposed openstack/ironic: Add proxy related parameters in agent driver https://review.openstack.org/235493 | 16:22 |
dtantsur | lucasagomes, I've copied hash+salt from my /etc/shadow - still no luck.. I dunno | 16:23 |
*** subscope has quit IRC | 16:24 | |
lucasagomes | dtantsur, can you try to generate it with "openssl passwd -1" ? | 16:24 |
*** subscope has joined #openstack-ironic | 16:24 | |
openstackgerrit | Vladyslav Drok proposed openstack/ironic: Add proxy related parameters in agent driver https://review.openstack.org/235493 | 16:25 |
*** subscope has quit IRC | 16:25 | |
dtantsur | lucasagomes, does it work for you btw? | 16:26 |
lucasagomes | dtantsur, I haven't tested cause I'm running something else right now | 16:26 |
lucasagomes | almost finished | 16:26 |
dtantsur | no luck | 16:27 |
lucasagomes | dtantsur, maybe we should fallback to non ecnrypted? | 16:28 |
* lucasagomes tho wants to test encrypted first | 16:28 | |
dtantsur | lucasagomes, well, no. it was trivial: you require "" around the encrypted password | 16:29 |
dtantsur | lucasagomes, but now I get /bin/bash: Permission denied | 16:29 |
lucasagomes | dtantsur, oh yeah you have to "" | 16:31 |
*** alexpilotti has joined #openstack-ironic | 16:32 | |
*** harshs has quit IRC | 16:33 | |
*** stendulker has quit IRC | 16:33 | |
dtantsur | lucasagomes, people say selinux may be to blame, let's see | 16:33 |
*** deray has joined #openstack-ironic | 16:34 | |
*** sergek has joined #openstack-ironic | 16:34 | |
*** subscope has joined #openstack-ironic | 16:35 | |
dtantsur | lucasagomes, woohoo, selinux=0 rules :) | 16:35 |
lucasagomes | dtantsur, lol | 16:35 |
lucasagomes | ok... and how did you generate the password? | 16:35 |
lucasagomes | using the perl thing? or openssl | 16:36 |
dtantsur | lucasagomes, openssl | 16:36 |
dtantsur | I suspect perl thing won't work | 16:36 |
deray | hello all | 16:36 |
lucasagomes | dtantsur, openssl passwd -1 ? | 16:36 |
dtantsur | lucasagomes, yep | 16:37 |
dtantsur | left comments on your patch | 16:37 |
dtantsur | deray, hello | 16:37 |
lucasagomes | dtantsur, thanks | 16:37 |
deray | dtantsur: hi | 16:38 |
lucasagomes | re selinux... not sure, maybe we should put a dependency on the selinux-permissive package | 16:38 |
lucasagomes | element* | 16:38 |
*** kozhukalov_ has quit IRC | 16:38 | |
dtantsur | lucasagomes, whatever works :) | 16:39 |
*** tideline has joined #openstack-ironic | 16:39 | |
*** kozhukalov_ has joined #openstack-ironic | 16:39 | |
deray | had a bad day today :( .. got to know the repercussions of running devstack/clean.sh file | 16:39 |
sambetts | deray: did it delete your home directory? | 16:39 |
deray | had lots of local data in /op/stack (hoem directory) and got deleted | 16:39 |
lucasagomes | deray, I hope ur running devstack in a vm tho | 16:40 |
deray | sambetts: ys you got it right | 16:40 |
deray | lucasagomes: ys | 16:40 |
sambetts | deray: I think it has something to do with the location that your storing the devstack logs | 16:40 |
sambetts | make sure that directroy is not your home directory | 16:40 |
deray | sambetts: yeah it was .. /opt/stack/logs .. | 16:41 |
deray | and /opt/stack beign my hoem directory | 16:41 |
sambetts | ooh :( | 16:41 |
deray | lucasagomes: ye I was running devstack on a vm .. but did the mistake of savign soem personal projects there itself | 16:42 |
lucasagomes | ouch | 16:42 |
lucasagomes | dtantsur, which baseos did you use for generating the image? fedora? | 16:43 |
lucasagomes | or centos/rhel? | 16:43 |
dtantsur | lucasagomes, rhel7 | 16:43 |
lucasagomes | dtantsur, right | 16:43 |
deray | I ususally keep pushing them (many of them) off to my git repo .. but some were still lying on the local git branches | 16:44 |
sambetts | : ( | 16:44 |
*** subscope has quit IRC | 16:46 | |
*** tideline has quit IRC | 16:46 | |
deray | sambetts: thx for being sympathetic.. did it occur to you as well any time? | 16:47 |
deray | hope not | 16:47 |
thiagop | lucasagomes: do you have a slot to take a look on 237122 before going -dinner? | 16:49 |
lucasagomes | thiagop, lol, yeah I will try just give me some mins | 16:49 |
lucasagomes | finishing up some tests | 16:49 |
*** e0ne has quit IRC | 16:49 | |
thiagop | lucasagomes: awsome, thank you! | 16:49 |
*** tideline has joined #openstack-ironic | 16:52 | |
sambetts | lucasagomes: redownloaded the images from tarballs.openstack.org, and got the same failure, /etc/os-release is missing, leading to Fail to start Switch Root | 16:54 |
lucasagomes | sambetts, right hmm... are you trying to boot it on baremetal or vm? | 16:56 |
sambetts | lucasagomes: baremetal | 16:56 |
sambetts | lucasagomes: this time it fell into the emergency shell, so I can run some commands if it helps | 16:57 |
lucasagomes | sambetts, right... yeah I googled it, everything seems related to the amount of ram | 16:57 |
lucasagomes | but its baremetal so, you should have plenty | 16:57 |
sambetts | lucasagomes: yeah its got 65536mb of it ... | 16:58 |
openstackgerrit | Sergii Turivnyi proposed openstack/python-ironicclient: Add sanity tests for testing actions with Chassis https://review.openstack.org/240562 | 16:58 |
lucasagomes | sambetts, can you add rootflags=subvol=root to the kernel cmdline ? | 16:58 |
sambetts | lucasagomes: I can give it a go, what does that do? | 16:59 |
lucasagomes | try to mount the root subvolume from brts, which seems something that coreos use (is googling that up) | 17:00 |
dtantsur | I wonder if it's related to the problem I see with ipa-inspector gate.. | 17:00 |
*** mgoddard has quit IRC | 17:00 | |
*** sacharya has joined #openstack-ironic | 17:00 | |
*** mgoddard has joined #openstack-ironic | 17:01 | |
sambetts | dtantsur: I wonder too :/ | 17:01 |
*** wuhg has quit IRC | 17:01 | |
sambetts | dtantsur: can you view the logs from the vms from the inspector ipa gate run? | 17:03 |
lucasagomes | thiagop, +2 | 17:03 |
dtantsur | sambetts, nope, not there. but locally it also something weird, something like it can't exec systemd from the root | 17:04 |
sambetts | dtantsur: oh weird... | 17:05 |
thiagop | lucasagomes: thanks! | 17:05 |
dtantsur | calling it a day, see you tomorrow | 17:05 |
sambetts | cya tomorrow dtantsur | 17:05 |
thiagop | dtantsur: have a good night | 17:05 |
lucasagomes | dtantsur, night | 17:05 |
lucasagomes | dtantsur, I will probably test the dynamic-login element and update the patch tomorrow | 17:06 |
*** achanda has quit IRC | 17:06 | |
lucasagomes | dtantsur, thakns for testing anyway... I need to enhance that README indeed | 17:06 |
* lucasagomes is happy the patch mostly works tho | 17:06 | |
sambetts | lucasagomes: adding that to the kerel didn't help :( | 17:06 |
lucasagomes | sambetts, :-( | 17:06 |
dtantsur | lucasagomes, cool yeah. I'll need this image tomorrow morning, as I'll be helping debugging introspection :) | 17:06 |
lucasagomes | no idea | 17:06 |
dtantsur | so it was great timing | 17:06 |
dtantsur | we'll see how helpful it actually is (my guess: a lot) | 17:07 |
lucasagomes | dtantsur, right, you still can use the image right? | 17:07 |
lucasagomes | passing selinux=0 | 17:07 |
dtantsur | lucasagomes, yeah, I have it prebuilt and working | 17:07 |
lucasagomes | ok cool | 17:07 |
lucasagomes | thanks | 17:07 |
*** masterbound is now known as mbound | 17:08 | |
*** achanda has joined #openstack-ironic | 17:08 | |
*** dtantsur is now known as dtantsur|afk | 17:09 | |
*** achanda has quit IRC | 17:09 | |
lucasagomes | sambetts, I've no idea to be honest | 17:09 |
lucasagomes | sambetts, can you use another image maybe? ipa built with DIB | 17:09 |
*** kozhukalov_ has quit IRC | 17:09 | |
lucasagomes | or you have to use the coreos one? | 17:09 |
*** dprince has joined #openstack-ironic | 17:10 | |
deray | yuriyz: hi | 17:10 |
lucasagomes | sambetts, after it fails you get an emergency shell right? | 17:11 |
*** ndipanov has quit IRC | 17:11 | |
lucasagomes | sambetts, there's anything there? if you do a "ls" you don't see any /etc/ right? | 17:11 |
sambetts | lucasagomes: Yeah, I'm just going through the journal to see if there is any other issues I've missed | 17:11 |
lucasagomes | right | 17:12 |
lucasagomes | sambetts, the ls shows you something relevant? | 17:12 |
sambetts | I see directories | 17:12 |
deray | yuriyz: I was referrng to https://review.openstack.org/#/c/209612/ .. wasn't it related to firmware interface earlier? | 17:12 |
*** jistr has quit IRC | 17:14 | |
lucasagomes | sambetts, which ones? | 17:15 |
sambetts | sysroot usr var tmp sys sbin root lib etc bin dev | 17:15 |
sambetts | and a couple of others | 17:15 |
lucasagomes | right, and /etc/ has the os-release file that is missing? | 17:16 |
*** ionutbalutoiu has quit IRC | 17:16 | |
lucasagomes | that the error say it's missing* | 17:16 |
*** ionutbalutoiu has joined #openstack-ironic | 17:17 | |
sambetts | yeah that file is there | 17:17 |
*** mmnelemane_ has quit IRC | 17:17 | |
lucasagomes | odd | 17:18 |
lucasagomes | sambetts, no idea :-/ | 17:18 |
sambetts | lucasagomes: :'( really stumped ... tomorrow I might try with a different baremetal and see if that one gets the same | 17:19 |
lucasagomes | yeah | 17:19 |
sambetts | lucasagomes: I may also try with tinyipa | 17:19 |
lucasagomes | ++ | 17:19 |
*** lazy_prince has quit IRC | 17:20 | |
lucasagomes | dtantsur|afk, just a FYI, with fedora I didn't need selinux=0 | 17:21 |
lucasagomes | perhaps we can just document that on the README | 17:21 |
lucasagomes | anyway I will call it a day | 17:21 |
openstackgerrit | Ruby Loo proposed openstack/ironic: Agent vendor handles manual cleaning https://review.openstack.org/247695 | 17:22 |
thiagop | good night lucasagomes, thanks again | 17:22 |
sambetts | same, calling it a night | 17:22 |
lucasagomes | np | 17:22 |
sambetts | see everyone tomorrow o/ | 17:22 |
lucasagomes | have a great night everyone | 17:22 |
lucasagomes | talk soon | 17:22 |
*** lucasagomes is now known as lucas-dinner | 17:22 | |
thiagop | sambetts: good night too! | 17:23 |
*** sambetts is now known as sambetts-afk | 17:23 | |
openstackgerrit | Vladyslav Drok proposed openstack/ironic: Add missing packages to dev-quickstart https://review.openstack.org/245989 | 17:23 |
*** tideline has quit IRC | 17:24 | |
openstackgerrit | Sergii Turivnyi proposed openstack/python-ironicclient: Add sanity tests for testing actions with Port https://review.openstack.org/240944 | 17:25 |
vdrok | good night everyone! | 17:25 |
mgould | vdrok, good night! | 17:26 |
thiagop | vdrok: you too! See ya. | 17:26 |
*** caiobo has joined #openstack-ironic | 17:27 | |
*** krtaylor has quit IRC | 17:32 | |
*** kromanenko has quit IRC | 17:34 | |
*** degorenko is now known as _degorenko | 17:36 | |
*** dims has quit IRC | 17:36 | |
openstackgerrit | Ruby Loo proposed openstack/ironic: Replace config 'clean_nodes' with 'automated_clean' https://review.openstack.org/247701 | 17:42 |
*** daemontool_ has quit IRC | 17:44 | |
*** daemontool_ has joined #openstack-ironic | 17:44 | |
*** pas-ha has quit IRC | 17:51 | |
*** Sukhdev has joined #openstack-ironic | 17:57 | |
*** garthb has joined #openstack-ironic | 17:58 | |
*** yonglihe has quit IRC | 18:00 | |
*** agordeev has quit IRC | 18:01 | |
openstackgerrit | Michael Krotscheck proposed openstack/ironic-webclient: Configuration Resource https://review.openstack.org/229055 | 18:03 |
*** mbound has quit IRC | 18:03 | |
*** sergek has quit IRC | 18:04 | |
*** dims has joined #openstack-ironic | 18:06 | |
*** betherly has quit IRC | 18:07 | |
*** JoshNang has quit IRC | 18:07 | |
*** jasonamyers has quit IRC | 18:07 | |
*** romcheg has quit IRC | 18:07 | |
*** kozhukalov has quit IRC | 18:07 | |
mgould | good night everyone! | 18:07 |
*** mgould has quit IRC | 18:08 | |
*** jamielennox|away is now known as jamielennox | 18:09 | |
*** harshs has joined #openstack-ironic | 18:09 | |
*** betherly has joined #openstack-ironic | 18:12 | |
deray | good night! | 18:16 |
*** agordeev has joined #openstack-ironic | 18:17 | |
*** kozhukalov has joined #openstack-ironic | 18:17 | |
*** ionutbalutoiu has quit IRC | 18:17 | |
openstackgerrit | Michael Krotscheck proposed openstack/ironic-webclient: Added Ironic API result transformation. https://review.openstack.org/241799 | 18:18 |
openstackgerrit | Michael Krotscheck proposed openstack/ironic-webclient: $$configuration mock https://review.openstack.org/247126 | 18:18 |
openstackgerrit | Michael Krotscheck proposed openstack/ironic-webclient: Upgraded eslint https://review.openstack.org/247223 | 18:18 |
openstackgerrit | Michael Krotscheck proposed openstack/ironic-webclient: Removed ports https://review.openstack.org/246578 | 18:18 |
openstackgerrit | Michael Krotscheck proposed openstack/ironic-webclient: Dynamically reconfiguring resources https://review.openstack.org/228571 | 18:18 |
openstackgerrit | Michael Krotscheck proposed openstack/ironic-webclient: Moved node list to default application state https://review.openstack.org/231642 | 18:18 |
openstackgerrit | Michael Krotscheck proposed openstack/ironic-webclient: Introduced Root State https://review.openstack.org/231641 | 18:18 |
openstackgerrit | Michael Krotscheck proposed openstack/ironic-webclient: Added IronicDriverProperties resource https://review.openstack.org/247171 | 18:18 |
*** deray has quit IRC | 18:19 | |
*** tideline has joined #openstack-ironic | 18:20 | |
*** athomas has quit IRC | 18:20 | |
*** Sukhdev has quit IRC | 18:22 | |
*** ijw has joined #openstack-ironic | 18:25 | |
*** dims has quit IRC | 18:26 | |
*** tideline has quit IRC | 18:27 | |
*** JoshNang has joined #openstack-ironic | 18:27 | |
*** jasonamyers has joined #openstack-ironic | 18:27 | |
*** Sukhdev has joined #openstack-ironic | 18:29 | |
*** romcheg has joined #openstack-ironic | 18:30 | |
*** ijw has quit IRC | 18:30 | |
openstackgerrit | Michael Krotscheck proposed openstack/ironic-webclient: $$selectedConfiguration Mock https://review.openstack.org/247726 | 18:30 |
*** penick has joined #openstack-ironic | 18:31 | |
*** penick has quit IRC | 18:31 | |
*** ijw has joined #openstack-ironic | 18:33 | |
*** tideline has joined #openstack-ironic | 18:35 | |
*** tideline has quit IRC | 18:39 | |
*** yonglihe has joined #openstack-ironic | 18:39 | |
*** david-lyle has quit IRC | 18:48 | |
krotscheck | Could I have some reviews on https://review.openstack.org/#/q/project:openstack/ironic-webclient++topic:mvp,n,z ? betherly usually only +A's things if there's at least another +1. | 18:49 |
*** ionutbalutoiu has joined #openstack-ironic | 18:49 | |
*** sergek has joined #openstack-ironic | 18:49 | |
*** jrist has quit IRC | 18:49 | |
*** tideline has joined #openstack-ironic | 18:52 | |
*** tideline has quit IRC | 18:52 | |
*** dims has joined #openstack-ironic | 18:52 | |
*** tideline has joined #openstack-ironic | 18:53 | |
openstackgerrit | Merged openstack/bifrost: Use sudo -H -E when running pip https://review.openstack.org/230827 | 18:55 |
*** meghal has joined #openstack-ironic | 18:56 | |
*** achanda has joined #openstack-ironic | 18:58 | |
*** ijw has quit IRC | 18:59 | |
*** ijw has joined #openstack-ironic | 19:00 | |
*** sacharya has quit IRC | 19:01 | |
*** meghal has quit IRC | 19:02 | |
*** meghal has joined #openstack-ironic | 19:02 | |
*** e0ne has joined #openstack-ironic | 19:04 | |
*** Sukhdev has quit IRC | 19:04 | |
liliars | sambetts-afk: you're not here but just to let you know, I'm having the same issue with "booting the kernel" and then freezes forever. also using coreos images from tarballs. if I have any news I'll ping you tomorrow. | 19:09 |
*** ijw has quit IRC | 19:10 | |
rloo | jroll: when you get a chance, would you set this to approved (spec was approved): https://blueprints.launchpad.net/ironic/+spec/manual-cleaning | 19:12 |
jroll | rloo: yep, thanks | 19:12 |
rloo | jroll: unless we've decided not to use LP :) | 19:12 |
jroll | rloo: not yet :( | 19:12 |
jroll | rloo: is there code yet? | 19:12 |
rloo | jroll: yup. the main stuff is there. | 19:12 |
jroll | oh looky there | 19:12 |
jroll | \o/ | 19:12 |
*** penick has joined #openstack-ironic | 19:13 | |
rloo | jroll: https://review.openstack.org/#/q/status:open+project:openstack/ironic+branch:master+topic:bp/manual-cleaning,n,z | 19:13 |
* jroll marks needs code review | 19:13 | |
jroll | yeah, saw that. thanks! | 19:13 |
rloo | jroll: not the API stuff yet. and docs. | 19:13 |
jroll | ah | 19:14 |
jroll | cool | 19:14 |
zer0c00l_ | Morning everyone | 19:14 |
thiagop | zer0c00l: morning! | 19:14 |
*** meghal has quit IRC | 19:16 | |
rloo | jroll: if you or other cores have time for a quick review in ironic-lib: https://review.openstack.org/#/c/245741/ | 19:16 |
*** jamielennox is now known as jamielennox|away | 19:16 | |
*** meghal has joined #openstack-ironic | 19:16 | |
rloo | jroll: i think once that is in and we do a release dance, ironic will be able to use the lib. | 19:16 |
jroll | rloo: I'll give it a shot, idk about rootwrap | 19:16 |
jroll | oh, perfect | 19:16 |
*** meghal has quit IRC | 19:17 | |
*** jrist has joined #openstack-ironic | 19:18 | |
*** jrist has quit IRC | 19:18 | |
*** jrist has joined #openstack-ironic | 19:18 | |
jroll | rloo: +A | 19:19 |
rloo | jroll: thx. Do you know how to get a release of that? then we need to up the version in global requirements and something in devstack/tempest? | 19:20 |
*** Sukhdev has joined #openstack-ironic | 19:20 | |
jroll | rloo: I do, you need to add a thing here: https://github.com/openstack/releases/blob/master/deliverables/mitaka/ironic-lib.yaml | 19:21 |
*** mkovacik has joined #openstack-ironic | 19:21 | |
jroll | rloo: and then a patch that depends on that one to change upper-constraints.txt in global-requirements | 19:21 |
jroll | rloo: and that's it - one caveat, some people are on vacation this week so doug said action on releases repo may be slow | 19:22 |
jroll | make sense? | 19:22 |
*** meghal has joined #openstack-ironic | 19:22 | |
rloo | jroll: ok thx I think :) i guess it means you aren't volunteering to do it. | 19:22 |
jroll | (also you'll need my +1 on the releases patch so let me know) | 19:22 |
rloo | jroll: :D | 19:22 |
jroll | heh | 19:22 |
jroll | I can if I need to | 19:22 |
jroll | gotta wait for that patch to merge to make sure we have the right SHA | 19:22 |
* jroll files expense reports while that happens | 19:23 | |
rloo | jroll: you don't need to. | 19:23 |
jroll | rloo: I don't mind, if you have better things to do | 19:23 |
jroll | 'tis what I'm here for anyway | 19:23 |
*** kozhukalov_ has joined #openstack-ironic | 19:24 | |
rloo | jroll: oh like do reviews? is that better use of my time? | 19:24 |
openstackgerrit | Merged openstack/ironic-lib: Replace rootwrap_config and rootwrap_helper_cmd with root_helper https://review.openstack.org/245741 | 19:24 |
jroll | rloo: dunno, maybe :D | 19:24 |
jroll | wow, that was quick | 19:24 |
rloo | wow, that was fast. | 19:24 |
jroll | oh, tempest is non-voting there | 19:25 |
jroll | anyway | 19:25 |
jroll | rloo: I'll do the release thing, and link you the patches so you can see what's going on | 19:25 |
rloo | jroll: ok thx. in case i have to ever do that myself :) | 19:25 |
jroll | yep :) | 19:26 |
*** ifarkas has quit IRC | 19:28 | |
jroll | rloo: easy peasy https://review.openstack.org/#/q/status:open++branch:master+topic:ironic-lib-0.4.0,n,z | 19:29 |
*** electrofelix has quit IRC | 19:29 | |
openstackgerrit | Michael Krotscheck proposed openstack/ironic-webclient: $$selectedConfiguration Mock https://review.openstack.org/247726 | 19:29 |
openstackgerrit | Michael Krotscheck proposed openstack/ironic-webclient: Enroll Node https://review.openstack.org/243353 | 19:29 |
openstackgerrit | Michael Krotscheck proposed openstack/ironic-webclient: Added Ironic API result transformation. https://review.openstack.org/241799 | 19:29 |
openstackgerrit | Michael Krotscheck proposed openstack/ironic-webclient: $$configuration mock https://review.openstack.org/247126 | 19:29 |
openstackgerrit | Michael Krotscheck proposed openstack/ironic-webclient: Upgraded eslint https://review.openstack.org/247223 | 19:29 |
openstackgerrit | Michael Krotscheck proposed openstack/ironic-webclient: Removed ports https://review.openstack.org/246578 | 19:29 |
openstackgerrit | Michael Krotscheck proposed openstack/ironic-webclient: Added IronicDriverProperties resource https://review.openstack.org/247171 | 19:29 |
*** zer0c00l has quit IRC | 19:29 | |
*** zer0c00l_ is now known as zer0c00l | 19:30 | |
*** Piet has quit IRC | 19:31 | |
rloo | jroll: is there something that needs to be modified in tempest? patches using the lib were failing tests until "something" was done. but i don't remember what that "something" was. maybe it was just this stuff. | 19:32 |
jroll | rloo: not that I know of, it was probably just waiting for the release | 19:32 |
jroll | also some tempest jobs use upper-constraints, so maybe that was the thing | 19:32 |
rloo | jroll: ok, will see. dtantsur|afk will know cuz he mentioned it last time. | 19:33 |
jroll | ok | 19:34 |
*** meghal has quit IRC | 19:34 | |
*** meghal1 has joined #openstack-ironic | 19:34 | |
openstackgerrit | Merged openstack/python-ironicclient: A minor change for driver_shell test https://review.openstack.org/246784 | 19:35 |
*** sacharya has joined #openstack-ironic | 19:35 | |
*** dims has quit IRC | 19:36 | |
*** achanda has quit IRC | 19:38 | |
*** david-lyle has joined #openstack-ironic | 19:43 | |
*** e0ne has quit IRC | 19:46 | |
*** openstackgerrit has quit IRC | 19:46 | |
*** openstackgerrit has joined #openstack-ironic | 19:47 | |
*** achanda has joined #openstack-ironic | 19:52 | |
*** achanda has quit IRC | 19:53 | |
*** ijw has joined #openstack-ironic | 19:59 | |
*** ijw has joined #openstack-ironic | 19:59 | |
betherly | Just a quick note on krotscheck's earlier message re the reviews in https://review.openstack.org/#/q/project:openstack/ironic-webclient++topic:mvp,n,z - I would love to see other people's opinions on the code before +A'ing it but they have been there over a month now. I will leave them until Monday but if still no further +1s I will merge them unless anyone | 20:15 |
betherly | has objection to that. Thanks all! :) | 20:15 |
*** kromanenko has joined #openstack-ironic | 20:16 | |
devananda | betherly: doo eet :) | 20:16 |
betherly | :) thanks devananda! | 20:16 |
*** Piet has joined #openstack-ironic | 20:17 | |
*** jcoufal_ has quit IRC | 20:23 | |
*** Piet has quit IRC | 20:24 | |
*** rebase has joined #openstack-ironic | 20:29 | |
*** rebase has quit IRC | 20:31 | |
*** meghal1 has quit IRC | 20:39 | |
*** harshs has quit IRC | 20:43 | |
*** meghal has joined #openstack-ironic | 20:45 | |
*** Sukhdev has quit IRC | 20:45 | |
*** jerrygb has quit IRC | 20:48 | |
*** jerrygb has joined #openstack-ironic | 20:49 | |
*** jerrygb has quit IRC | 20:49 | |
*** jerrygb has joined #openstack-ironic | 20:50 | |
*** alexpilotti has quit IRC | 20:50 | |
*** alexpilotti has joined #openstack-ironic | 20:50 | |
*** meghal has quit IRC | 20:51 | |
*** harshs has joined #openstack-ironic | 20:51 | |
*** meghal has joined #openstack-ironic | 20:51 | |
*** tideline has left #openstack-ironic | 20:51 | |
*** meghal has quit IRC | 20:52 | |
*** meghal has joined #openstack-ironic | 20:52 | |
*** alexpilotti has quit IRC | 20:53 | |
*** meghal has quit IRC | 20:53 | |
*** krtaylor has joined #openstack-ironic | 20:55 | |
*** alexpilotti has joined #openstack-ironic | 20:56 | |
*** kozhukalov_ has quit IRC | 20:57 | |
*** sinval has quit IRC | 20:58 | |
*** e0ne has joined #openstack-ironic | 21:08 | |
*** baoli has quit IRC | 21:08 | |
*** Piet has joined #openstack-ironic | 21:13 | |
mariojv | hi ironic - i have a patch set up i'd like some advice on, if anyone's interested in taking a look. | 21:17 |
mariojv | https://review.openstack.org/#/c/226058 allows node vendor passthru methods to use a shared task instead of requiring a lock on a node for every operation | 21:18 |
JayF | Hello there mister Mario, I will gladly take a review-time at your patchsets. | 21:19 |
mariojv | unfortunately, with the example i implemented (make agent heartbeat async), there's a race condition that seems really difficult to get around | 21:19 |
mariojv | so my questions would be these: 1) are there other node vendor passthru methods that would be good candidates?, and 2) would it be worth it to make that example a separate patch set? | 21:19 |
mariojv | thanks JayF | 21:19 |
JayF | I would split the change to enable being able to do that | 21:20 |
JayF | with the first change that actually uses that | 21:20 |
mariojv | good. the race condition is in yuriyz's comment here, line 334, patch set 9: https://review.openstack.org/#/c/226058/9..11/ironic/drivers/modules/agent_base_vendor.py | 21:21 |
*** jerrygb has quit IRC | 21:21 | |
*** krtaylor has quit IRC | 21:22 | |
thiagop | Hey guys, calling it a day | 21:29 |
thiagop | see you tomorrow | 21:29 |
thiagop | have a good night | 21:29 |
*** thiagop has quit IRC | 21:29 | |
*** e0ne has quit IRC | 21:30 | |
*** jerrygb has joined #openstack-ironic | 21:35 | |
*** jerrygb has quit IRC | 21:35 | |
*** caiobo has quit IRC | 21:35 | |
*** willsama has joined #openstack-ironic | 21:40 | |
*** willsama has quit IRC | 21:40 | |
*** daemontool_ has quit IRC | 21:41 | |
*** kozhukalov_ has joined #openstack-ironic | 21:42 | |
*** daemontool_ has joined #openstack-ironic | 21:42 | |
*** tideline has joined #openstack-ironic | 21:43 | |
*** tideline has quit IRC | 21:44 | |
*** jlvillal has quit IRC | 21:46 | |
*** jlvillal has joined #openstack-ironic | 21:48 | |
*** Sukhdev has joined #openstack-ironic | 21:48 | |
*** meghal has joined #openstack-ironic | 21:50 | |
*** meghal has quit IRC | 21:52 | |
*** meghal has joined #openstack-ironic | 21:52 | |
ionutbalutoiu | Hello, guys! I would like some review on a small patch for a bug fix, in case anybody has time for it. https://review.openstack.org/#/c/245911/ | 21:53 |
*** tideline has joined #openstack-ironic | 21:53 | |
*** harshs has quit IRC | 21:54 | |
*** mkovacik has quit IRC | 21:54 | |
*** harshs has joined #openstack-ironic | 22:00 | |
*** dims has joined #openstack-ironic | 22:02 | |
*** caiobo has joined #openstack-ironic | 22:04 | |
*** thrash is now known as thrash|g0ne | 22:06 | |
*** trown is now known as trown|outttypeww | 22:06 | |
*** ijw has quit IRC | 22:11 | |
*** dprince has quit IRC | 22:17 | |
*** mjturek2 has quit IRC | 22:19 | |
*** baoli_ has joined #openstack-ironic | 22:22 | |
*** harshs has quit IRC | 22:28 | |
*** liliars_ has joined #openstack-ironic | 22:29 | |
*** liliars_ has quit IRC | 22:29 | |
*** penick has quit IRC | 22:30 | |
*** tideline has quit IRC | 22:32 | |
openstackgerrit | Michael Krotscheck proposed openstack/ironic-webclient: $$selectedConfiguration Mock https://review.openstack.org/247726 | 22:34 |
openstackgerrit | Michael Krotscheck proposed openstack/ironic-webclient: Enroll Node https://review.openstack.org/243353 | 22:34 |
zer0c00l | I just got an email on 'https://review.openstack.org/191505' saying This change depends on a change that failed to merge. | 22:35 |
zer0c00l | Does that mean i need to rebase https://review.openstack.org/#/c/246718/ ? | 22:35 |
*** jerrygb has joined #openstack-ironic | 22:36 | |
*** harshs has joined #openstack-ironic | 22:36 | |
SpamapS | jroll: hey, was there ever an official spec made out of ironic's possible use of tooz? | 22:37 |
*** ijw has joined #openstack-ironic | 22:37 | |
*** baoli_ has quit IRC | 22:37 | |
*** baoli has joined #openstack-ironic | 22:38 | |
krotscheck | zer0c00l: I'm guessing so, yes. Jenkins will tell you when a patch in your dependency chain fails to merge. | 22:38 |
zer0c00l | krotscheck: i see, so i did rebase few mins earlier. Do i need another 'recheck' ? | 22:39 |
*** ijw has quit IRC | 22:39 | |
krotscheck | zer0c00l: That I don't know. The experts who know that answer are in #openstack-infra | 22:40 |
zer0c00l | i will do another recheck anyway and see what happens :) | 22:40 |
zer0c00l | Thanks | 22:40 |
*** jerrygb has quit IRC | 22:41 | |
openstackgerrit | Michael Krotscheck proposed openstack/ironic-webclient: Removed Drivers https://review.openstack.org/247822 | 22:43 |
krotscheck | zer0c00l: np | 22:45 |
*** sacharya has quit IRC | 22:47 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/ironic: Updated from global requirements https://review.openstack.org/247111 | 22:53 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/ironic-lib: Updated from global requirements https://review.openstack.org/247602 | 22:53 |
*** baoli has quit IRC | 22:53 | |
*** baoli has joined #openstack-ironic | 22:54 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/python-ironicclient: Updated from global requirements https://review.openstack.org/247641 | 22:58 |
*** meghal has quit IRC | 23:00 | |
*** jerrygb has joined #openstack-ironic | 23:01 | |
*** penick has joined #openstack-ironic | 23:03 | |
*** baoli has quit IRC | 23:07 | |
*** penick has quit IRC | 23:08 | |
*** baoli has joined #openstack-ironic | 23:09 | |
*** logan2 has quit IRC | 23:10 | |
*** logan2 has joined #openstack-ironic | 23:10 | |
*** toabctl has quit IRC | 23:11 | |
*** toabctl has joined #openstack-ironic | 23:13 | |
*** ionutbalutoiu has quit IRC | 23:13 | |
*** aginwala has joined #openstack-ironic | 23:14 | |
*** ionutbalutoiu has joined #openstack-ironic | 23:14 | |
*** ijw has joined #openstack-ironic | 23:15 | |
jroll | SpamapS: I don't believe so, yet, devananda was going to play with that but low priority right now | 23:16 |
*** baoli has quit IRC | 23:17 | |
*** ijw has quit IRC | 23:17 | |
*** baoli has joined #openstack-ironic | 23:17 | |
SpamapS | jroll: k. tooz dev is picking up steam, but nobody's really biting yet | 23:18 |
jroll | SpamapS: we will do it, just other things to get done first | 23:18 |
*** ijw has joined #openstack-ironic | 23:18 | |
*** dims_ has joined #openstack-ironic | 23:22 | |
*** kozhukalov_ has quit IRC | 23:24 | |
*** dims has quit IRC | 23:24 | |
*** baoli has quit IRC | 23:27 | |
*** baoli has joined #openstack-ironic | 23:28 | |
*** tideline has joined #openstack-ironic | 23:33 | |
*** tideline has quit IRC | 23:37 | |
*** alexpilotti has quit IRC | 23:38 | |
*** ionutbalutoiu has quit IRC | 23:38 | |
openstackgerrit | Mario Villaplana proposed openstack/ironic: Allow vendor drivers to acquire shared tasks https://review.openstack.org/226058 | 23:39 |
mariojv | jlvillal: I ended up taking the agent heartbeat change out of that patch ^ | 23:41 |
jlvillal | mariojv, Ah interesting. Locking can be difficult :( | 23:42 |
mariojv | i think having the feature available and finding a good place to use it can be separated out, and that will now be easier to review | 23:43 |
jlvillal | mariojv, Agreed! | 23:44 |
*** meghal has joined #openstack-ironic | 23:45 | |
*** sinval has joined #openstack-ironic | 23:50 | |
*** smoriya_ has joined #openstack-ironic | 23:53 | |
*** tideline has joined #openstack-ironic | 23:58 | |
*** baoli has quit IRC | 23:58 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!