Wednesday, 2015-10-14

*** Sukhdev has quit IRC00:09
*** naohirot has joined #openstack-ironic00:11
*** chlong has joined #openstack-ironic00:12
*** garthb has quit IRC00:20
*** shadower has quit IRC00:23
*** shadower has joined #openstack-ironic00:23
*** spandhe has joined #openstack-ironic00:27
openstackgerritJim Rollenhagen proposed openstack/ironic: Fix RPC API compat for 1.29 upgrade  https://review.openstack.org/23445000:29
jroll^ that should be good to go, I think00:29
jrollwould like to backport that to liberty as well00:30
*** sdake has joined #openstack-ironic00:43
*** baoli has joined #openstack-ironic00:43
*** baoli_ has joined #openstack-ironic00:46
*** baoli has quit IRC00:49
*** baoli_ has quit IRC00:52
*** links has joined #openstack-ironic00:53
*** lazy_prince has joined #openstack-ironic00:58
*** sdake has quit IRC00:58
*** baoli has joined #openstack-ironic01:00
*** Sukhdev_ has quit IRC01:00
*** jcoufal_ has quit IRC01:01
*** sdake has joined #openstack-ironic01:03
*** zhenguo has joined #openstack-ironic01:15
*** baoli has quit IRC01:15
*** praneshp has quit IRC01:15
*** baoli has joined #openstack-ironic01:18
rloojroll: awesome about the ironic versioned documentation. is it automatic now (ie it just happens, i don't have to know how)01:24
rloojroll: wrt the rpc fix, i'll try to look tonight or tomorrow morning01:24
jrollrloo: yes, it's automatic, always has been apparently01:25
jrolland thanks.01:25
*** Nisha has joined #openstack-ironic01:26
*** mmedvede has quit IRC01:26
rloojroll: cool. now to figure out how to document where the documentation is :D01:26
jrollhahaha01:26
*** Nisha has quit IRC01:30
*** lazy_prince has quit IRC01:31
*** lazy_prince has joined #openstack-ironic01:32
*** chenglch has joined #openstack-ironic01:32
*** stendulker has joined #openstack-ironic01:32
*** killer_prince has joined #openstack-ironic01:33
*** dims has quit IRC01:33
*** dims has joined #openstack-ironic01:34
*** baoli has quit IRC01:34
*** baoli has joined #openstack-ironic01:35
*** lazy_prince has quit IRC01:37
rloojroll: it seems to me that you were going to update the documentation for liberty, but i don't recall what/why. was it the release notes or upgrade stuff?01:40
jrollrloo: both? :)01:40
jrollrloo: 4.2.1 release notes, and some stuff about the out-of-tree driver breakage01:41
rloojroll: I mean, after the stable/liberty branch was cut. i have such a short memory.01:41
rloojroll: good, you remember!01:41
*** ijw has quit IRC01:41
jrollrloo: well, that's what I remember, I'm not sure that's accurate :)01:41
rloojroll: i was thinking that now i know there's a doc ../ironic/4.2.1 url, we could go to town on our install guide etc, but NO, not going to do that.01:42
jrollrloo: hah01:44
*** baoli has quit IRC01:49
*** baoli has joined #openstack-ironic01:50
*** baoli has quit IRC02:00
*** baoli has joined #openstack-ironic02:00
*** alex_xu has joined #openstack-ironic02:02
*** spandhe has quit IRC02:02
*** baoli has quit IRC02:05
*** sdake has quit IRC02:06
*** chlong has quit IRC02:06
*** stendulker has quit IRC02:09
*** harshs has quit IRC02:18
*** mtanino has quit IRC02:20
openstackgerritNaohiro Tamura proposed openstack/ironic-python-agent: Add param docstring into the normalize func  https://review.openstack.org/23451902:22
*** chlong has joined #openstack-ironic02:23
*** boris-42 has quit IRC02:28
*** baoli has joined #openstack-ironic02:31
*** killer_prince has quit IRC02:40
*** killer_prince has joined #openstack-ironic02:40
*** Haomeng|2 has joined #openstack-ironic02:45
*** killer_prince has quit IRC02:48
*** lazy_prince has joined #openstack-ironic02:48
*** Haomeng has quit IRC02:48
*** penick has joined #openstack-ironic02:50
*** lazy_prince has quit IRC02:53
*** lazy_prince has joined #openstack-ironic02:54
*** achanda has joined #openstack-ironic02:57
*** lazy_prince has quit IRC03:05
*** amotoki has joined #openstack-ironic03:14
*** getvasanth_ has joined #openstack-ironic03:19
*** penick has quit IRC03:19
*** getvasanth has quit IRC03:22
*** chlong has quit IRC03:29
*** amotoki has quit IRC03:30
openstackgerritMerged openstack/ironic: Move FakeOneViewDriver to the fake.py module  https://review.openstack.org/23375303:32
*** rameshg87 has joined #openstack-ironic03:35
*** penick has joined #openstack-ironic03:35
*** Nisha has joined #openstack-ironic03:40
*** amotoki has joined #openstack-ironic03:41
*** purp_too is now known as purp03:45
*** chlong has joined #openstack-ironic03:45
*** baoli has quit IRC03:46
*** amotoki has quit IRC03:50
*** harshs has joined #openstack-ironic03:54
*** stendulker has joined #openstack-ironic03:54
*** amotoki has joined #openstack-ironic03:55
*** david-lyle has quit IRC04:01
*** stendulker_ has joined #openstack-ironic04:02
*** stendulker has quit IRC04:02
*** rloo has quit IRC04:03
*** MattMan has quit IRC04:10
*** MattMan has joined #openstack-ironic04:10
*** stendulker has joined #openstack-ironic04:13
*** stendulker_ has quit IRC04:13
*** praneshp has joined #openstack-ironic04:14
*** amotoki has quit IRC04:18
*** garthb has joined #openstack-ironic04:25
*** spandhe has joined #openstack-ironic04:25
*** amotoki has joined #openstack-ironic04:26
*** garthb has quit IRC04:28
*** Sukhdev has joined #openstack-ironic04:28
*** garthb has joined #openstack-ironic04:28
*** ijw has joined #openstack-ironic04:40
*** praneshp_ has joined #openstack-ironic04:42
*** praneshp has quit IRC04:43
*** praneshp_ is now known as praneshp04:43
*** harshs has quit IRC04:44
*** puranamr has joined #openstack-ironic04:46
*** chlong has quit IRC04:49
*** penick has quit IRC04:57
*** pradipta has joined #openstack-ironic05:04
*** kozhukalov_ has joined #openstack-ironic05:13
*** Sukhdev has quit IRC05:20
*** lazy_prince has joined #openstack-ironic05:22
*** boris-42 has joined #openstack-ironic05:22
*** VikasC has joined #openstack-ironic05:25
*** mrmoje has joined #openstack-ironic05:28
*** lintan_ has joined #openstack-ironic05:30
*** BharatK has joined #openstack-ironic05:34
*** ijw has quit IRC05:45
*** puranamr has quit IRC05:53
*** kozhukalov_ has quit IRC05:56
*** smoriya has quit IRC05:59
*** VikasC_ has joined #openstack-ironic06:02
*** VikasC has quit IRC06:05
*** spandhe has quit IRC06:10
*** chlong has joined #openstack-ironic06:20
*** meghal has joined #openstack-ironic06:22
meghalhello…had a quick question on hash ring implementation in ironic-conductor…currently, at various points the mapping function is called to check if a node belongs to a particular conductor…how frequently is this mapping updated ? is it only during sync_local_states when the hash ring is reset ?06:25
meghaljroll:  devananda ^ ?06:25
*** ukalifon1 has joined #openstack-ironic06:27
*** chlong has quit IRC06:27
*** harshs has joined #openstack-ironic06:27
*** meghal has quit IRC06:29
*** meghal has joined #openstack-ironic06:30
*** Marga_ has quit IRC06:42
*** harshs has quit IRC06:47
*** yog_ has joined #openstack-ironic06:48
*** garthb has quit IRC06:55
*** romainh has joined #openstack-ironic07:00
*** yog_ has quit IRC07:00
Haomeng|2meghal: I think so, need other to confirm:)07:01
*** openstackgerrit has quit IRC07:01
*** openstackgerrit has joined #openstack-ironic07:02
*** Nisha has quit IRC07:02
*** Nisha has joined #openstack-ironic07:08
meghalHaomeng|2:  ok…will wait for others to confirm07:11
*** Marga_ has joined #openstack-ironic07:11
Haomeng|2meghal: k, welcome:)07:11
meghalwas wondering if everybody runs sync_local_state periodic job, because if I am not interested in preparing the pxe config env on take over (update of conductor affinity) then sync_local_state is not needed07:12
meghalbut I do not want to affect the hash ring calculation07:12
*** yog_ has joined #openstack-ironic07:13
*** Marga_ has quit IRC07:14
*** Marga_ has joined #openstack-ironic07:14
Haomeng|2meghal: I understand the periodic job is auto-run, so no need to manually run it07:14
meghalHaomeng|2:  I meant that if there was an option to disable the auto-run07:16
Haomeng|2meghal: let me check code, looks like there is no such option07:16
meghalbecause if a particular use case does not need it, then I can avoid the run of those periodic workers07:16
meghalHaomeng|2:  such an option does not exist07:16
Haomeng|2meghal: yes07:16
Haomeng|2meghal: so you mean that that should be useful if there it is07:17
meghalwhat I want to understand is the implications of not running sync_local_state on hash ring07:17
meghaland if there are none, then I would like to have an option to disable the auto run07:17
meghaland we can discuss more on that07:17
meghalbut first lets try to get an answer on this07:17
*** dtantsur|afk is now known as dtantsur07:20
dtantsurMorning Ironic07:20
*** mrmoje has quit IRC07:21
*** mrmoje has joined #openstack-ironic07:24
Haomeng|2dtantsur: morning:)07:24
Haomeng|2meghal: ok07:24
*** Haomeng|2 is now known as Haomeng07:24
*** achanda has quit IRC07:26
*** achanda has joined #openstack-ironic07:27
openstackgerritchenglch proposed openstack/ironic: Add iscsi_opc and agent_opc to manage the OpenPOWER servers  https://review.openstack.org/20982407:29
*** ifarkas has joined #openstack-ironic07:32
*** achanda has quit IRC07:33
*** mkovacik has joined #openstack-ironic07:33
*** ijw has joined #openstack-ironic07:37
*** getvasanth has joined #openstack-ironic07:38
*** getvasanth_ has quit IRC07:39
*** meghal1 has joined #openstack-ironic07:40
*** Nisha has quit IRC07:40
*** mkovacik has quit IRC07:40
*** meghal has quit IRC07:41
dtantsurjroll, something we might want to get fixed soon (maybe also in L): https://bugs.launchpad.net/ironic-python-agent/+bug/150592307:50
openstackLaunchpad bug 1505923 in ironic-python-agent "Does not works with the latest tgt default socket name" [High,Triaged]07:50
*** marzif has quit IRC07:52
*** david-lyle has joined #openstack-ironic07:57
*** jcoufal has joined #openstack-ironic07:59
*** Marga_ has quit IRC08:01
*** ijw has quit IRC08:01
*** ijw has joined #openstack-ironic08:03
*** marzif has joined #openstack-ironic08:06
*** ijw has quit IRC08:07
*** athomas has joined #openstack-ironic08:08
*** mgoddard has joined #openstack-ironic08:10
*** mbound has joined #openstack-ironic08:15
*** pradipta has quit IRC08:17
*** jistr has joined #openstack-ironic08:18
*** bapalm has quit IRC08:23
*** Cameron_C_ has quit IRC08:25
*** bapalm has joined #openstack-ironic08:26
*** ndipanov has joined #openstack-ironic08:27
getvasanthWhy there is only one ironic-conductor running on a 4 core box, where has the heat-engine runs 5 engines (1 Parent, 4 forks), do we have any config like num_engine_worker(HEAT) in Ironic too?08:28
*** marzif has quit IRC08:38
*** marzif has joined #openstack-ironic08:39
Haomenggetvasanth: no, conductor will not run per-core I think08:39
*** meghal1 has quit IRC08:39
Haomenggetvasanth: we have no such workers configuration for conductor08:40
*** jamielennox is now known as jamielennox|away08:40
*** lucasagomes has joined #openstack-ironic08:41
*** mkovacik has joined #openstack-ironic08:41
*** lucasagomes_ has joined #openstack-ironic08:42
*** Nisha has joined #openstack-ironic08:42
*** lucasagomes has quit IRC08:46
*** derekh has joined #openstack-ironic08:50
*** mrmoje has quit IRC08:53
*** subscope has joined #openstack-ironic08:54
*** lucasagomes has joined #openstack-ironic08:58
*** subscope has quit IRC09:01
*** subscope has joined #openstack-ironic09:01
*** ijw has joined #openstack-ironic09:03
*** athomas has quit IRC09:05
*** lucasagomes has quit IRC09:07
*** lucasagomes_ is now known as lucasagomes09:08
lucasagomeso/ streamed raw images in IPA works09:08
* lucasagomes writes tests now09:08
*** ijw has quit IRC09:09
*** athomas has joined #openstack-ironic09:14
*** pelix has joined #openstack-ironic09:14
*** lintan has joined #openstack-ironic09:15
*** lintan_ has quit IRC09:16
*** dims_ has joined #openstack-ironic09:17
*** marzif has quit IRC09:19
*** marzif has joined #openstack-ironic09:19
*** dims has quit IRC09:20
dtantsurlucasagomes, awesome!09:22
*** links has quit IRC09:22
*** dtantsur is now known as dtantsur|brb09:24
zhenguohi ironic, does somebody knows why ListType return set() here https://github.com/openstack/ironic/blob/master/ironic/api/controllers/v1/types.py#L20409:28
openstackgerritOpenStack Proposal Bot proposed openstack/ironic: Updated from global requirements  https://review.openstack.org/23466409:29
zhenguoI find the comments said set() to remove duplicated items, but why not use list(set()) to convert back to list?09:29
*** mmnelemane has joined #openstack-ironic09:29
openstackgerritMerged openstack/ironic-python-agent: Add param docstring into the normalize func  https://review.openstack.org/23451909:36
lucasagomeszhenguo, yes I think it's just to remove the duplicates09:38
lucasagomeszhenguo, good point, it could do that too09:39
*** subscope has quit IRC09:39
zhenguolucasagomes: so it's ok that I push a patch to update that09:39
lucasagomeszhenguo, right it's fine yes09:39
lucasagomeszhenguo, tho, what are the gains with it? (Perhaps it's more intuite to be a list... not sure)09:39
zhenguolucasagomes: as I need to use Listtype as a response, but set() is not json serializable09:40
lucasagomeszhenguo, alright yeah ++09:41
zhenguolucasagomes: ok, thanks09:41
sambettso/ Morning all09:45
*** sambetts has quit IRC09:56
*** sambetts has joined #openstack-ironic09:57
openstackgerritZhenguo Niu proposed openstack/ironic: Convert set() to list in ListType  https://review.openstack.org/23469709:57
*** naohirot has quit IRC09:57
zhenguolucasagomes, dtantsur: can you help to approve https://review.openstack.org/#/c/192576/ , already got two +2s.10:02
lucasagomeszhenguo, comment on the list type, just update the test to check for the type please10:03
lucasagomeswill take a look10:03
zhenguolucasagomes: thanks, will update soon :)10:03
lucasagomescool thank YOU for finding the problem10:04
*** ijw has joined #openstack-ironic10:04
*** athomas has quit IRC10:05
*** chenglch has quit IRC10:08
*** ijw has quit IRC10:09
*** ionutbalutoiu has joined #openstack-ironic10:11
*** romainh has quit IRC10:11
openstackgerritZhenguo Niu proposed openstack/ironic: Convert set() to list in ListType  https://review.openstack.org/23469710:13
* zhenguo goes home10:13
*** zhenguo has quit IRC10:13
*** chlong has joined #openstack-ironic10:14
*** kozhukalov_ has joined #openstack-ironic10:14
*** marzif has quit IRC10:20
*** marzif has joined #openstack-ironic10:20
*** subscope has joined #openstack-ironic10:22
*** ionutbalutoiu has quit IRC10:24
*** ionutbalutoiu has joined #openstack-ironic10:27
*** ionutbalutoiu has quit IRC10:27
*** ionutbalutoiu has joined #openstack-ironic10:27
*** kozhukalov_ has quit IRC10:32
*** dtantsur|brb is now known as dtantsur10:34
dtantsurmorning sambetts10:35
sambettsMorning dtantsur10:41
*** kozhukalov_ has joined #openstack-ironic10:44
* sambetts needs coffee10:47
*** mrmoje has joined #openstack-ironic10:49
*** marzif has quit IRC10:50
openstackgerritNisha Agarwal proposed openstack/ironic: Documentation for Swift-less iLO Virtual Media deploy  https://review.openstack.org/22802010:52
*** Marga_ has joined #openstack-ironic10:52
*** marzif has joined #openstack-ironic10:53
*** e0ne has joined #openstack-ironic10:56
*** mrmoje has quit IRC10:57
*** ijw has joined #openstack-ironic11:05
* rameshg87 goes home11:06
*** rameshg87 has quit IRC11:06
*** Nisha has quit IRC11:09
ifarkasdtantsur, hi, could you please review https://review.openstack.org/#/c/214160/ and https://review.openstack.org/#/c/230445/ ?11:10
*** ijw has quit IRC11:11
*** marzif has quit IRC11:12
*** ionutbalutoiu has quit IRC11:13
*** marzif has joined #openstack-ironic11:13
*** ionutbalutoiu has joined #openstack-ironic11:16
dtantsurifarkas, sure11:18
ifarkasdtantsur, thanks!11:21
*** e0ne has quit IRC11:23
*** stendulker has quit IRC11:27
dtantsurifarkas, reviewer, hope you don't regret making me a core already :D11:30
dtantsur* reviewed11:30
openstackgerritLucas Alvares Gomes proposed openstack/ironic-python-agent: Add support for streaming raw images directly onto the disk  https://review.openstack.org/23433911:30
ifarkasdtantsur, lol, no worries, thank for the reviews :D11:31
ifarkasI will fix them11:31
lucasagomesionutbalutoiu, ^ you may want to look at it to stream ur windows image11:31
*** bmpbike has joined #openstack-ironic11:32
ionutbalutoiulucasagomes, nice work :)11:33
lucasagomesionutbalutoiu, :-) lemme know if that works for you, you will need to patch IPA and regenerate the ramdisk11:33
*** BharatK has quit IRC11:35
ionutbalutoiuSure, not sure if I can give it a shot today, but I'll let you know as soon as I tested it. Thanks for the patch!11:36
*** mrmoje has joined #openstack-ironic11:41
*** baoli has joined #openstack-ironic11:48
*** BharatK has joined #openstack-ironic11:48
*** baoli_ has joined #openstack-ironic11:49
*** ionutbalutoiu has quit IRC11:50
*** ionutbalutoiu has joined #openstack-ironic11:51
*** baoli has quit IRC11:52
*** subscope has quit IRC11:54
*** subscope has joined #openstack-ironic11:57
lucasagomesionutbalutoiu, no bothers :-) thanks11:59
*** baoli_ has quit IRC12:00
*** persia has quit IRC12:02
*** bizarrochristy has joined #openstack-ironic12:03
*** cemason has quit IRC12:03
*** ijw has joined #openstack-ironic12:03
*** persia has joined #openstack-ironic12:03
*** lucasagomes is now known as lucas-hungry12:03
*** ijw has quit IRC12:07
*** subscope has quit IRC12:07
getvasanthHaomeng: thanks for the info, but on a 4 core box i see only one conductor running12:08
*** bizarrochristy has quit IRC12:12
*** thrash|g0ne is now known as thrash12:13
*** achanda has joined #openstack-ironic12:16
*** achanda has quit IRC12:17
*** achanda has joined #openstack-ironic12:18
*** achanda has quit IRC12:22
*** cemason has joined #openstack-ironic12:25
*** priteau has joined #openstack-ironic12:27
*** cemason has quit IRC12:30
*** marzif has quit IRC12:31
*** marzif has joined #openstack-ironic12:31
openstackgerritJulia Kreger proposed openstack/bifrost: Initial support for installation of ironic-inspector  https://review.openstack.org/22993012:31
*** cemason has joined #openstack-ironic12:33
*** dprince has joined #openstack-ironic12:34
*** athomas has joined #openstack-ironic12:34
TheJuliaNobodyCam: cinerama: please review https://review.openstack.org/#/c/216372/6 when you have a chance12:34
*** trown|outttypeww is now known as trown12:35
TheJuliayay, just get started and a hard power outage12:35
*** cemason has quit IRC12:37
*** baoli has joined #openstack-ironic12:37
*** subscope has joined #openstack-ironic12:43
*** sinval has quit IRC12:44
*** puranamr has joined #openstack-ironic12:45
*** ionutbalutoiu has quit IRC12:49
jrollmorning all12:51
jrollbusy busy day12:51
dtantsurmorning jroll, TheJulia12:51
jrolldtantsur: do we support building IPA with anything this latest tgt is packaged with? https://bugs.launchpad.net/ironic-python-agent/+bug/150592312:52
openstackLaunchpad bug 1505923 in ironic-python-agent "Does not works with the latest tgt default socket name" [High,Triaged]12:52
dtantsurjroll, probably not now, at least I personally haven't hit it12:53
jrolldtantsur: yeah, not sure we need to backport it12:53
*** puranamr has quit IRC12:54
*** BharatK has quit IRC12:54
dtantsurjroll, I'd ask afazekas how he figured it out12:54
*** puranamr has joined #openstack-ironic12:54
* dtantsur asks on #openstack-qa12:56
*** rloo has joined #openstack-ironic12:56
TheJuliajroll: there is the ironic-agent element that someone use12:57
dtantsurseems like all supported distributions have old enough tgt12:58
dtantsurjroll, I'm much more worried about https://bugs.launchpad.net/ironic-python-agent/+bug/150456212:59
openstackLaunchpad bug 1504562 in ironic-python-agent "Please support Linux-IO in extensions/iscsi in addition to tgtd" [Medium,Triaged]12:59
sambettsI hit this the other day when working with tinyipa12:59
jrollyeah, that's a thing that needs to happen13:00
sambettsdebian packages v1.0.51 of tgt and I initally installed the most recent version of tgt and it blew up13:00
jrollso yeah, I don't think we need to backport either of those. let's get them fixed and make a release. upstream builders work fine right now.13:01
*** amotoki has quit IRC13:02
dtantsurjroll, I'm trying to understand this Linux-IO thing... so few docs and examples13:02
jrolldtantsur: yeah, I'm ignoring that until we're done with liberty :)13:03
TheJuliasambetts: the patch mentioned in th ebug is not listed in the changes for the debian package, fwiw13:03
*** mgoddard has quit IRC13:03
sambettsTheJulia: That what I meant the copy in the debian repo is the older version before this change13:05
TheJuliaahh13:05
sambettsThe tinycore version was newer and so blew up, sorry it made sense in my head haha13:06
jrollxek: if we fix this RPC version bug thing, can you truly do a rolling upgrade?13:06
jrollxek: or is it still broken even if we fix this (I hope not, but I think it might be)13:06
TheJuliasambetts: Stable, but unstable has it :)13:06
openstackgerritJulia Kreger proposed openstack/bifrost: Initial support for installation of ironic-inspector  https://review.openstack.org/22993013:07
rloojroll: i would think it is still broken. I thought our versioned objects stuff was broken and we fixed things in liberty so we could do rolling upgrades from liberty->future.13:07
sambettsTheJulia: does testing? I think thats the version we pull for IPA13:07
jrollrloo: that's what I'm thinking, but our objects might be "close enough" to deal with it...13:07
xekrloo, you are right13:08
jrollrloo: if we drop this patch we can release 4.2.1 today, the rest of the backports are coming down13:08
rloojroll: my understanding from what dan mentioned, is that it isn't.13:08
jrollugh, so what's the use in backporting this13:08
* jroll sighs and abandons his patch13:08
rloojroll: that's what/why i asked you yesterday.13:08
openstackgerritJulia Kreger proposed openstack/bifrost: Initial support for installation of ironic-inspector  https://review.openstack.org/22993013:08
xekjroll, the commit I cited was just an example, we need to have some test to address similar bugs in the future13:08
jrollrloo: yeah, I'm a hopeful person13:08
rloojroll: sorry, maybe i should have been clearer.13:08
jrollxek: agree13:08
TheJuliasambetts: testing has it13:08
rloojroll: hope is good. and if the patch was 'good enough' but ...13:08
jrollxek: needs moar grenade-partial13:09
xekjroll, yep13:09
rloojroll: sorry to ask, but do we want to get this doc into liberty: https://review.openstack.org/22802013:09
sambettsTheJulia: :/ hmmm, not sure then13:10
dtantsurrloo, morning. last time I checked we didn't publish docs for releases13:10
rloojroll: and did we decide to punt on the patch for AgentDeploy/boot interface13:10
jrollrloo: I'm not concerned about it. as long as it's out there for people to use, I'm happy13:10
jrolldtantsur: we found out yesterday we do \o/13:10
rloodtantsur: turns out we have been. jroll mentioned it yesterday!13:10
dtantsurORLY?? Oo13:10
dtantsurany links at hand?13:10
jrollrloo: yep, both have breakage, without the 'fix' the break is easier to understand and fix downstream13:10
jrolldtantsur: sec13:10
rloodtantsur: http://docs.openstack.org/developer/ironic/4.2.0/13:10
jrolldtantsur: http://docs.openstack.org/developer/ironic/2015.1.2/13:11
jrollevery tag gets a subtree13:11
*** subscope has quit IRC13:11
dtantsurdear god, why didn't I know about it??13:11
rloodtantsur: why didn't any of us know about it?!!13:11
*** lucas-hungry is now known as lucasagomes13:12
jroll++13:13
dtantsursuch surprise very docs wow publish13:13
*** BharatK has joined #openstack-ironic13:13
dtantsurwow wow13:13
rloojroll: so i will assume unless you ping us that you don't need anything reviewed for stable/liberty (except doc/release notes updates)13:13
jrollhehe13:13
*** marzif has quit IRC13:13
jrollrloo: yeah, we'll need release notes and that should be it13:13
*** romainh has joined #openstack-ironic13:14
*** amotoki has joined #openstack-ironic13:15
dtantsurrloo, if you're interesting in helping with futurist change, please review https://review.openstack.org/#/c/232517 (a preliminary refactor)13:15
rloodtantsur: ok.13:16
*** marzif has joined #openstack-ironic13:16
rloodtantsur: but i was thinking i should look at the ironic patch that uses ironic-lib. is it ready to be reviewed?13:16
dtantsurrloo, IIRC not yet; and we still don't have ironic-lib bumped in g-r..13:17
rloodtantsur: I *hope* this ironic-lib will prove to be useful...13:17
rloodtantsur: sigh. ok, will look at your patch then :)13:17
jrollI've filed https://blueprints.launchpad.net/ironic/+spec/online-upgrade-support13:18
jrollwe need to do this stuff this cycle.13:18
dtantsur++13:18
rloojroll: do we have a priorities list started anywhere?13:18
jrollwe can review the ironic-lib changeover without the g-r bump :P13:18
jrollrloo: nothing updated in some time, no13:18
jrollI've kinda started sketching one out locally but nothing solid13:19
* dtantsur dives into Linux-IO and iSCSI, which him the best of luck13:19
*** puranamr has quit IRC13:19
dtantsurs/which/wish/13:19
rloojroll: as long as after the summit (or during) we have a good idea of the priorities13:19
rloodtantsur: good luck13:19
jrollrloo +113:19
*** subscope has joined #openstack-ironic13:19
sambettsdtantsur: if you want any help ping me :)13:20
dtantsurcool, thanks :)13:20
dtantsurrtslib is AGPLv3, can't decide if wow or not wow13:24
openstackgerritLucas Alvares Gomes proposed openstack/ironic: Fix an annoying detail in the developer quick-start  https://review.openstack.org/23478313:25
lucasagomesmorning jroll rloo TheJulia13:26
rloodtantsur: qq wrt 232517. Are you splitting it up cuz you want separate classes, or splitting it up cuz you don't want it all in one file?13:26
rloohi lucasagomes (and everyone else!)13:27
jrollheya lucasagomes :)13:27
dtantsurrloo, cuz I hate editing this huge file and this huge class :)13:27
rloodtantsur: so both then.13:27
dtantsuryep13:27
*** subscope has quit IRC13:28
jrollwe fixed a whole one bug on 4.2.1 \o/ :|13:31
jrollhttps://launchpad.net/ironic/+milestone/4.2.113:31
*** amotoki has quit IRC13:32
rloojroll: that should really have been two bugs :)13:33
*** cdearborn has joined #openstack-ironic13:33
jrollI know.13:33
* jroll not happy about that but realized it too late13:33
jrollI still don't know how someone successfully tested the first bug fix13:33
rloojroll: if i had known you'd care, i would have said something.13:34
jrolllet's just run our CI in every locale linux supports so we don't have to do this again13:34
jrollrloo: it's fine, it is what it is13:34
*** caiobo has joined #openstack-ironic13:35
rloojroll: my guess/thought was that it only became an issue if the command failed and spewed stuff in stderr.13:35
jrollrloo: oh, that's a good point13:36
rloojroll: i think that's why we already have some commands coded using standard locale; they are fixed when someone encounters the problem.13:37
*** marzif has quit IRC13:37
jrollyeah.13:37
jlvillalGood morning Ironic13:38
jrollhey jlvillal13:38
*** subscope has joined #openstack-ironic13:39
jlvillaljroll, Hey there.13:39
*** amotoki has joined #openstack-ironic13:40
*** subscope has quit IRC13:44
*** subscope has joined #openstack-ironic13:44
*** amotoki has quit IRC13:47
*** puranamr has joined #openstack-ironic13:47
*** kkoski has joined #openstack-ironic13:49
lucasagomesjroll, :-/13:49
lucasagomesprobably the bugs are just not tagged correctly? /me not sure13:49
lucasagomesjlvillal, morning!13:50
jrolllucasagomes: no, the bug was reused for the second bug fix13:51
jrollI looked through everything13:51
lucasagomesoh, alright cool13:51
openstackgerritJulia Kreger proposed openstack/bifrost: Initial support for installation of ironic-inspector  https://review.openstack.org/22993013:54
*** jistr is now known as jistr|mtg13:56
*** puranamr has quit IRC13:58
*** dims_ has quit IRC14:01
TheJuliadtantsur: w/r/t that database error on friday, it is because utf8 and the engine default on CI nodes is likely no innodb where as my laptop is.  https://dev.mysql.com/doc/refman/5.0/en/innodb-foreign-key-constraints.html14:01
*** dims has joined #openstack-ironic14:01
*** amotoki has joined #openstack-ironic14:02
krtaylormorning ironic14:05
*** marzif has joined #openstack-ironic14:09
jlvillallucasagomes, Good morning :)14:09
jlvillalkrtaylor, Good morning14:09
TheJuliadtantsur: yup, set my engine to MyISAM and kaboom :(14:10
*** [1]cdearborn has joined #openstack-ironic14:16
rloodtantsur: maybe this is a dumb question, but wrt 232517, if it is wrt futurist, did you think of moving the periodic tasks into a separate file/class?14:19
NobodyCamgood morning Ironicers :)14:22
NobodyCamhappy hump day!14:22
rloomorning NobodyCam, jlvillal, krtaylor14:22
NobodyCammorning jroll rloo dtantsur devananda jlvillal sambetts TheJulia lucasagomes krtaylor vdrok14:23
NobodyCammorning rloo :)14:23
lucasagomesNobodyCam, morning14:23
NobodyCam:)14:23
*** cemason has joined #openstack-ironic14:26
*** cdearborn has quit IRC14:27
openstackgerritStephanie Miller proposed openstack/bifrost: ironic-inspector install doc polish  https://review.openstack.org/23481014:29
TheJuliagood morning NobodyCam14:29
*** kozhukalov_ has quit IRC14:30
openstackgerritJulia Kreger proposed openstack/bifrost: Initial support for installation of ironic-inspector  https://review.openstack.org/22993014:33
jrollmorning NobodyCam :)14:33
NobodyCam:) morning :)14:34
openstackgerritMerged openstack/bifrost: Generate network_info json using a module  https://review.openstack.org/21637214:34
openstackgerritMerged openstack/bifrost: Support setting vlan in config drive  https://review.openstack.org/21643114:34
jlvillalGood morning NobodyCam rloo14:39
*** cemason has quit IRC14:45
*** kozhukalov_ has joined #openstack-ironic14:45
sambettso/ jlvillal14:46
sambettso/ NobodyCam14:46
openstackgerritZhenguo Niu proposed openstack/ironic: Convert set() to list in ListType  https://review.openstack.org/23469714:46
jlvillalsambetts, \o14:47
*** caiobo has quit IRC14:47
*** baoli has quit IRC14:48
*** baoli_ has joined #openstack-ironic14:48
*** cemason has joined #openstack-ironic14:50
*** thrash is now known as thrash|biab14:51
*** puranamr has joined #openstack-ironic14:59
NobodyCam:)15:00
rloojroll, devananda: are we abandoning this AgentDeploy fix? https://review.openstack.org/#/c/231215/15:01
dtantsursorry, I'm in the middle of meetings15:01
*** cemason has quit IRC15:01
dtantsurrloo, I hoped that manager.py will contain everything futurist-related from now on15:02
*** jistr|mtg is now known as jistr15:02
dtantsurTheJulia, oh... do we need to support MyISAM at all?15:02
*** wshao has joined #openstack-ironic15:02
*** baoli_ has quit IRC15:02
rloodtantsur: it just seemed to me that the periodic tasks could be subclassed instead of the other stuff :-) Anyway, I commented in your patch.15:02
*** cemason has joined #openstack-ironic15:03
*** puranamr has quit IRC15:03
*** garthb has joined #openstack-ironic15:04
TheJuliadtantsur: don't know, I just find it weird that the bare bones trusty nodes bifrost uses for CI have a different db config.  I've updated the mode setting to set the engine to innodb in my config, waiting on CI run15:05
*** cemason has quit IRC15:07
*** VikasC_ has quit IRC15:07
jrollrloo: yeah, we are15:08
lucasagomesrloo, jroll oh we don't want that fix anymore?15:09
rloojroll: ok, will you abandon it then. I don't feel right doing that :)15:09
jrollrloo: I'll let devananda do it when he sends the email / release notes patch about it15:09
jrolllucasagomes: no, we decided either way it breaks something, and without the patch the breakage is easy to see and easy to fix15:10
dtantsurrloo, not sure... it was annoying enough to do this change :D15:10
lucasagomesjroll, right, yeah it's set it to the driver definition15:10
rloojroll: but I don't want folks spending time on that patch.15:10
lucasagomesok seems good15:10
rloojroll: just in case someone was going to spend time on it ;)15:11
jrollrloo: I -2'd15:11
rloodtantsur: yeah, i can imagine. Just that it seems easier/clearer to have a periodic tasks file/class, than have to deal with how to separate/name the other classes :)15:11
rloojroll: thx, that'll work too15:11
dtantsurrloo, if we don't split API bits, it's still going to be huge, so dunno... let's wait for what jroll says15:12
jrollsays about what15:12
dtantsurjroll, about conductor split. rloo suggests to split it in a different way, but I'm so lazy to redo it :)15:12
rloodtantsur: i thought you'd only then need to edit the periodic tasks file and leave manager.py alone :)15:12
rloodtantsur: we should do what is 'right', whatever that is :)15:13
jrolldtantsur: I'm not opinionated, y'all can work it out15:13
rloojroll: and that wasn't an opinion of yours15:13
dtantsurok, I'll give it one more thought tomorrows with fresh mind15:13
dtantsur(fresh mind in the morning, lol)15:14
rloodtantsur: no worries. it isn't that urgent.15:14
*** jcoufal has quit IRC15:19
*** david-lyle has quit IRC15:25
openstackgerritLilia Sampaio proposed openstack/ironic: Add OneView driver documentation  https://review.openstack.org/23439615:26
*** mgoddard has joined #openstack-ironic15:26
*** david-lyle has joined #openstack-ironic15:27
*** e0ne has joined #openstack-ironic15:27
*** mbound has quit IRC15:27
*** Nisha has joined #openstack-ironic15:29
*** cemason has joined #openstack-ironic15:31
*** getvasanth has quit IRC15:31
*** thiagop has joined #openstack-ironic15:33
thiagopGood morning, Ironic15:33
*** kkoski has quit IRC15:33
*** kozhukalov_ has quit IRC15:35
*** bizarrochristy has joined #openstack-ironic15:36
*** cemason has quit IRC15:39
*** cemason_ has joined #openstack-ironic15:39
*** marzif has quit IRC15:39
jlvillalthiagop, Good morning15:41
thiagophey jlvillal, have you taken a look at the docs?15:41
*** BharatK has quit IRC15:42
thiagop(or maybe "did you take a look"...)15:42
jlvillalthiagop, A quick glance. But I've been mostly head down on functional testing. Looking at multiple projects to see how they do it. And figuring out what I want to copy to use for us.15:43
TheJuliadtantsur: http://lists.openstack.org/pipermail/openstack-dev/2014-July/040773.html15:43
*** bizarrochristy has quit IRC15:43
*** kkoski has joined #openstack-ironic15:43
thiagopjlvillal: np. Just askin' since you talked about yesterday15:43
jlvillalthiagop, thanks15:44
dtantsurTheJulia, oh wut? so what do they expect people to do?15:44
* devananda has the plague today :(15:44
*** mgoddard_ has joined #openstack-ironic15:45
jlvillaldevananda, Sorry to hear that. Get better!15:45
jrolldevananda: :(15:45
devanandamaking tea then going back to bed to write the release notes update15:46
*** david-ly_ has joined #openstack-ironic15:46
TheJuliadtantsur: explicitly set their engine of choice it looks like.  :(15:47
*** david-lyle has quit IRC15:47
thiagopdtantsur: Hi! Saw your comments on that patch to filter the version of oneviewclient. I'd like your (experienced) input about that15:47
*** kozhukalov_ has joined #openstack-ironic15:47
dtantsurTheJulia, how do I do it in an engine-independent way? Oo15:47
*** mgoddard has quit IRC15:48
thiagopdtantsur: we plan to release the 2.1.X version only when OneView comes to the 2.1 version. But also, we are constantly trying to improve the oneviewclient to be the central point of communication between the driver (and other tools) and OneView15:48
dtantsurok, why don't you want mitaka to use 2.1.x?15:48
thiagopI don't think they have an expectation to change version soon, then no.15:49
TheJuliadtantsur: good question, I have a suspicion with my config, going to toss it up to the gate and see if it works since I'm struggling to reproduce locally :(15:50
*** meghal has joined #openstack-ironic15:51
openstackgerritJulia Kreger proposed openstack/bifrost: Initial support for installation of ironic-inspector  https://review.openstack.org/22993015:51
thiagopdtantsur: I'm thinking about pinning the version, but with all this improvement work ongoing, we may release again soon. And I wouldn't like to piss the cores off every time a new release is tagged for python-oneviewclient...15:51
dtantsurthiagop, that's why you should NOT put an upper constraint, right? otherwise we'll need a new patch each time you release a minor version15:52
thiagopdtantsur: <2.1 is just a failsafe for a long term future, but if you think it's unappropriate, I can remove that, yes15:52
*** ijw has joined #openstack-ironic15:53
thiagopwe'll keep releasing 2.0.X until HP comes with a new version of OneView, that's far from happening15:53
dtantsurthiagop, if you follow the semver practice, then 2.1 must not break users of 2.0, so "<2.1" looks suspicious to me15:53
dtantsurthiagop, if you want to put "<3" it would be understandable15:53
*** david-ly_ is now known as david-lyle15:54
thiagopdtantsur: I think I got it. I need to plan these releases a little better.15:55
* thiagop is in a brave new world15:55
dtantsur:)15:55
dtantsurthanks15:56
meghaljroll:  I had a question on how frequently is the hash ring reset right now ? Is it done during the sync_local_state periodic task ?15:56
jrollrloo: devananda: dtantsur: whoever else cares... jfyi, in the interest of release management free time, we're going to release 4.2.0 as liberty final, and release 4.2.1 on tuesday with the japanese translations and bugfixes15:56
jrollmeghal: iirc, it's in that periodic task and also when a conductor joins or leaves the cluster15:57
dtantsurack15:57
devanandajroll: ++15:58
rloojroll: i'm not sure what 'release management free time' means. would prefer if 4.2.1 was liberty final but whatever15:58
jrollrloo: "we're a bit late with these patches and thierry/doug/the gate are really %^&*ing busy", it would be a heroic effort to get 4.2.1 in15:59
jrollrloo: the last patches won't land until very late tonight, and the release will be completing around the same time15:59
*** mgoddard_ has quit IRC15:59
rloojroll: oh. yeah, thierry seems tired based on his emails. ok. sad that it takes 12 hours or more to land a patch.16:00
jrollrloo: yeah, release week always means slow gate16:00
rloojroll: i thought thurs was deadline and i don't see why it can't be pushed to the following week but whatever. i don't really care, just wondering!16:01
jrollthursday 1000 utc or so appears to be the deadline16:01
jrollreally 4.2.0 works great16:01
jrollunless your system is japanese16:02
rloodevananda should just go to bed and forget the release notes til later this week.16:02
rloojroll: yup.16:02
jrollI think as long as we get 4.2.1 out before summit, I'm happy16:02
jrollI can handle release notes and such today.16:02
*** jcoufal has joined #openstack-ironic16:02
openstackgerritDmitry Tantsur proposed openstack/ironic-python-agent: [WIP] Support Linux-IO in addition to tgtd  https://review.openstack.org/23486116:03
dtantsurjroll, if we have a "known issues" section, we can document problem with locales there16:04
*** mgoddard has joined #openstack-ironic16:05
*** jistr has quit IRC16:06
dtantsurok, calling it a day. see you tomorrow16:06
*** dtantsur is now known as dtantsur|afk16:06
openstackgerritThiago Paiva Brito proposed openstack/ironic: Update python-oneviewclient version  https://review.openstack.org/23442816:07
thiagopgood night dtantsur|afk16:07
NobodyCamnight dtantsur|afk :)16:07
*** thrash|biab is now known as thrash16:07
*** yog_ has quit IRC16:09
*** subscope has quit IRC16:09
*** baoli has joined #openstack-ironic16:10
*** cemason_ has quit IRC16:10
meghaljroll:  currently, I see reset being called over here only - https://github.com/openstack/ironic/blob/master/ironic/conductor/manager.py#L1408 is it called some place else as well ? reason I am asking is because the take_over method during sync_local_state calls deploy on the driver and build the pxe config again, which is something we do not want to do for active instances…because if someone reboots an active instance they16:11
*** testing has joined #openstack-ironic16:11
meghalshouldn't the logic in takeover be left to the deploy driver16:11
meghaland let it decide whether to call prepare16:11
*** testing is now known as Guest8114616:11
meghalam talking about this logic here - https://github.com/openstack/ironic/blob/master/ironic/conductor/manager.py#L136516:11
*** cemason has joined #openstack-ironic16:12
meghalthis could be something our deployment specific logic does, but we clean up the pxe configuration once an instance becomes active…so that next time node reboots, it boots from local disk which has the new image16:13
jrollmeghal: your long message got cut off, but I don't see why the logic that exists today doesn't work...16:13
jrolloh16:13
meghalso we do not want to build the pxe config on take over16:13
jrollmeghal: booting from local disk is an option, and shouldn't generate a pxe config for the instance image16:14
meghaljroll:  yeah so different deploy drivers will have different requirements16:14
meghalso it should be upto takeover method of the deploy driver to control that logic16:14
jrollmeghal: so, you have your own driver or are using one in tree16:14
meghaland conductor/manager should just call takeover16:14
meghaljroll:  we are using pxe driver from juno branch16:15
meghaljroll:  https://github.com/openstack/ironic/blob/stable/juno/ironic/drivers/modules/pxe.py#L41616:15
jrollmeghal: oh, I don't think juno supported booting from local disk16:15
jrollthis is fully supported now (since kilo iirc)16:16
jrolland prepare/take_over doesn't break things booting from disk16:16
*** penick has joined #openstack-ironic16:16
meghaljroll:  is that a config option ? let me take a look16:17
jrollmeghal: it's a node thing16:17
jrolllemme dig it up16:17
jrollmeghal: http://docs.openstack.org/developer/ironic/deploy/install-guide.html#local-boot-with-partition-images16:18
*** romainh has left #openstack-ironic16:19
*** wshao has quit IRC16:19
*** lintan has quit IRC16:23
meghaljroll:  thanks for the link…so it is part of the node capabilities and the driver would read those…but idea is that on a first time deployment we need the pxe config but do not need it for subsequent take over or reboots (after node becomes active), looking over here - https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/pxe.py#L594 , it just cleans up pxe config, but then who will build it in first place16:23
*** lintan has joined #openstack-ironic16:24
jrollmeghal: prepare_instance() will clean up pxe configs there so that the node will boot from disk, not pxe16:24
jrollmeghal: this does the setup for the deploy ramdisk https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/pxe.py#L46316:25
*** kkoski has quit IRC16:26
*** kozhukalov_ has quit IRC16:26
meghaljroll:  ahh ok…and who calls that because I do not see prepare_ramdisk being called from conductor/maanger.py ? pardon my ignorance because I am still familiar with juno code16:26
jrollmeghal: pxe_ipmitool now refers to https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/iscsi_deploy.py#L64616:27
jrollmeghal: that PXEBoot class you're looking at just handles boot things, ISCSIDeploy handles the actual deployment16:27
jrollwe split the DeployInterface into Deploy and Boot this cycle16:27
*** r-daneel has joined #openstack-ironic16:28
jrollso now prepare() will do the right thing there16:28
meghaljroll:  ahh ok…gives more clarity now16:28
jroll:)16:28
meghaljroll:  right…so conductor/manager will call prepare during takeover but this guy here https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/iscsi_deploy.py#L715 will just call prepare instance which cleans up pxe config for local boot cases16:29
meghaljroll:  cool…thanks16:29
jrollmeghal: right :)16:29
meghaljroll:  so for certain drivers take over could be a noop kind of a thing then sync local state would not help much (except for periodic hash ring reset) and I was wondering if there should be an option to disable the periodic task and free up those periodic workers…and hash ring reset could be done in periodic power sync or so16:34
meghalwhat do you think ?16:34
jrollmeghal: something like https://github.com/openstack/ironic/blob/master/ironic/conductor/manager.py#L158-L159 ?16:36
jroll:D16:36
*** Guest81146 has quit IRC16:37
*** testing_ has joined #openstack-ironic16:37
meghaljroll:  ahha…did not know about that…that is exactly what I was wondering16:37
meghaljroll:  but will this affect the mapping calls in any way ?16:37
meghalbecause the hash ring might not be reset periodically and always return stale values16:37
meghalor that will not be the case ?16:38
*** cemason has quit IRC16:38
meghaltalking about the logic here - https://github.com/openstack/ironic/blob/master/ironic/conductor/manager.py#L144316:38
jrollmeghal: yeah, that's what I'm wondering now16:39
*** jasondotstar_ has joined #openstack-ironic16:39
openstackgerritMerged openstack/bifrost: Add static DHCP for dynamic inventory  https://review.openstack.org/21737416:40
*** bigjools_ has joined #openstack-ironic16:40
jrollmeghal: I think there are dragons there. hrm.16:40
* jroll wishes the conductor just didn't have local state16:41
meghalhmm16:42
jrollmeghal: that is to say, I think the ring would get out of date16:43
meghalyeah…periodic reset of hash ring needs to be taken care of in the mapping call itself like calculating the cache age or something16:43
meghaland we can continue to have sync local state explicitly resetting it16:43
jrollobligatory https://github.com/openstack/ironic/blob/master/ironic/conductor/rpcapi.py#L9916:43
jroll:)16:44
meghaljroll:  hah :)16:44
meghalbrb16:45
* jroll also wants to benchmark the hash ring reset16:46
jrollmeghal: mind filing a bug for this?16:46
*** garthb has quit IRC16:47
*** UForgotten_ has joined #openstack-ironic16:48
*** e0ne_ has joined #openstack-ironic16:49
*** e0ne has quit IRC16:50
*** jaypipes has quit IRC16:50
*** sbadia has quit IRC16:50
*** gabriel has quit IRC16:50
*** bigjools has quit IRC16:50
*** UForgotten has quit IRC16:50
*** jasondotstar has quit IRC16:50
*** pshige_ has quit IRC16:50
*** bapalm has quit IRC16:50
*** praneshp has quit IRC16:50
*** lifeless has quit IRC16:50
*** mtreinish has quit IRC16:50
*** degorenko is now known as _degorenko16:51
meghaljroll:  will do16:53
jrollthanks much16:53
*** phschwartz is now known as phschwartz_aw16:54
*** baoli_ has joined #openstack-ironic16:54
*** e0ne_ is now known as e0ne16:55
*** cemason has joined #openstack-ironic16:56
*** bapalm has joined #openstack-ironic17:00
*** lifeless has joined #openstack-ironic17:00
*** mtreinish has joined #openstack-ironic17:00
*** kkoski has joined #openstack-ironic17:02
*** mrmoje has quit IRC17:03
*** mrmoje has joined #openstack-ironic17:04
*** Nisha_away has joined #openstack-ironic17:06
*** Nisha has quit IRC17:06
*** gabriel has joined #openstack-ironic17:06
*** bapalm has quit IRC17:07
*** lifeless has quit IRC17:07
*** mtreinish has quit IRC17:07
*** spandhe has joined #openstack-ironic17:07
*** jaypipes has joined #openstack-ironic17:07
*** kozhukalov_ has joined #openstack-ironic17:07
*** pshige_ has joined #openstack-ironic17:07
*** cemason has quit IRC17:08
*** derekh has quit IRC17:08
*** sbadia has joined #openstack-ironic17:10
*** bapalm has joined #openstack-ironic17:10
*** lifeless has joined #openstack-ironic17:10
*** mtreinish has joined #openstack-ironic17:10
*** ijw has quit IRC17:11
*** harshs has joined #openstack-ironic17:14
lucasagomesfolks I'm calling it a day17:14
lucasagomeshave a great night everyone17:14
*** lucasagomes is now known as lucas-dinner17:14
openstackgerritSam Betts proposed openstack/ironic-python-agent: Add tinyipa to IPA imagebuild directory  https://review.openstack.org/23490217:14
*** harshs has quit IRC17:15
jrollnight lucas-dinner \o17:15
sambettso/ lucas-dinner17:15
*** jcoufal has quit IRC17:15
*** baoli has quit IRC17:15
*** athomas has quit IRC17:16
*** achanda has joined #openstack-ironic17:17
*** garthb has joined #openstack-ironic17:18
*** dolphm has left #openstack-ironic17:18
*** cemason has joined #openstack-ironic17:23
*** phschwartz_aw is now known as phschwartz17:23
*** harshs has joined #openstack-ironic17:25
*** meghal has quit IRC17:27
*** baoli has joined #openstack-ironic17:28
jrolldevananda: rloo: do either of you have thoughts on which sessions should be fishbowls?17:29
rloojroll: fishbowl == biggest rooms? No, but i can think about it now.17:30
*** lazy_prince has quit IRC17:30
jrollrloo: correct, I'm looking into it now as well17:30
*** meghal has joined #openstack-ironic17:30
jrollworkrooms are ~30, fishbowls are ~100 iirc17:30
jrollnova is locked into a fishbowl, so we have three of those left17:30
*** bmpbike has quit IRC17:31
jrollthinking for fishbowl: third party CI, driver API, group management?17:31
NobodyCamnight lucas-dinner17:31
jrollthose seem like things operators / vendors will care most about17:31
*** meghal has quit IRC17:31
rloojroll: yeah17:31
jrollif that makes sense to you, I'll just do it17:31
NobodyCamthat seems good17:31
NobodyCam:)17:31
jrolland then it's just checking for conflicts with other teams or talks17:32
rloojroll: driver composition may affect operators/vendors too17:32
*** baoli has joined #openstack-ironic17:32
*** meghal has joined #openstack-ironic17:32
*** cemason has quit IRC17:32
jrollrloo: oh, true17:32
rloojroll: having said that, i need to finish reading/grokking that spec17:32
*** trown is now known as trown|lunch17:32
testing_117:34
*** baoli_ has quit IRC17:35
rloojroll: we had discussed driver composition at the last summit. i don't recall a huge crowd then. i guess it depends what we do/how controversial/hard/whatever for operators to understand.17:35
jrollrloo: I can't remember if that was the focus of that session, though, or if it derailed to composition17:35
*** meghal has quit IRC17:36
jrollrloo: I do think vendor things will draw more people than ops things17:36
rloojroll: even a 30-person room is large so i'm not too concerned. as long as we don't do a neutron thing. An army showed up then.17:37
jrollrloo: yeah, exactly17:37
*** Marga_ has quit IRC17:38
*** Marga_ has joined #openstack-ironic17:38
rloojroll: the nova one is about the nova/ironic driver right?17:38
rloojroll: #3?17:38
jrollrloo: yes, correct17:38
jrollnova folks will also be there for the most part17:38
*** testing_ has quit IRC17:39
rloojroll: ok, annotated on the etherpad.17:39
*** testing has joined #openstack-ironic17:39
*** jasondotstar_ is now known as jasondotstar17:39
*** testing is now known as Guest3984617:39
*** meghal has joined #openstack-ironic17:39
jrollthanks17:40
*** Guest39846 has quit IRC17:40
TheJuliadtantsur|afk: http://docs.sqlalchemy.org/en/rel_1_0/dialects/mysql.html?highlight=charset#create-table-arguments-including-storage-engines17:41
jrollrloo: thinking driver composition in a workroom, I'd like to mostly talk about the internals there17:42
jrollit will affect ops/vendors but we have to get through the technical bits first17:42
jrollso beyond that... I know naohirot has a talk, not sure who else does17:43
jrolland ops conflicts with our wednesday sessions17:43
*** mkovacik has quit IRC17:43
rloojroll: that is fine to do driver composition in a workroom.17:43
rloojroll: yeah, those ops conflicts mean we won't have many ops folks.17:44
*** praneshp has joined #openstack-ironic17:44
*** Marga_ has quit IRC17:44
jrollrloo: yeah, so I'm going to put the driver API thing on thursday, under the assumption that operators may have a tendency to write a downstream driver17:45
jrollas opposed to group management / third party CI, those will be vendor-heavy if anything17:45
*** pelix has quit IRC17:45
jrollops may care about group management, but in the sense that they want to do it, not that they care about how it works under the hood17:45
rloojroll: i would think vendors want to write downstream drivers, not operators. but i don't know.17:48
rloojroll: well, vendors want upstream drivers too.17:48
jrollrloo: operators may have some to implement hacks :)17:49
jrollit's more that, operators will probably care about downstream drivers more than group management or third party CI17:49
jrollbut maybe that's wrong17:49
jrollmeghal: penick: ^ thoughts?17:49
penick*backscroll*17:50
rloojroll: well, i am the wrong person to comment on that!17:50
jrollpenick: summit sessions on "driver API for downstream drivers" vs "group management of nodes" vs "third party CI" - which would you rather be in?17:50
jrollcontext is conflicts with ops sessions17:50
penickOne of the first two for sure. Probably the driver one. What does group management of nodes mean?17:51
jrollrloo: me too, given I don't care about group management at all with my ops hat on, that's what for loops are for17:51
jrollpenick: ironic node-update --tag rack-f4-21 blablabla; or manage all things in a blade maybe.17:51
*** Sukhdev has joined #openstack-ironic17:51
rloopenick: here's the etherpad: https://etherpad.openstack.org/p/mitaka-ironic-design-summit-ideas17:52
jrollpenick: the first is managing multiple nodes by tags, not adding tags17:52
jrollbut I suspect that session is going to be about vendor-specific grouping things :(17:52
*** Sukhdev has quit IRC17:52
penickWell, admittedly the group thing does have some value to us. We’re trying to come up with a flow to handle hardware as it comes in to the DC, or as one of our tenants needs to manage a large number of hosts at once. The ability to say “let me reimage these (40-1500) hosts right now” is a use case we do hit. But if I have t pick between the driver API and the grouping thing, i’ll go to the driver thing17:54
penickI’ll send one of our other ops folks to the grouping thing17:55
jrollpenick: yeah, the grouping thing is well-understood for "normal" hardware, I think. use tags. coming soon (TM)17:56
jrollmaybe that isn't sufficient, idk17:57
*** Sukhdev has joined #openstack-ironic17:57
jrollalright, I'll do driver API on thursday17:58
MadasiI would use tags, makes it easier than having to pull an inventory list from somewhere to figure out which servers/node ids correspond to a given rack/upstream router/etc17:58
jrollnow I just need to talk to wanyen and naohirot17:59
jrollMadasi: yeah, vendors want to use other things like larger chassis and CMDBs, I suspect17:59
Madasiyeah, pluggable source of truth makes sense17:59
jroll"larger chassis" meaning blades, or the groupings like our OCP stuff has18:00
*** kkoski has quit IRC18:00
*** baoli has quit IRC18:00
*** Marga_ has joined #openstack-ironic18:00
*** sinval has joined #openstack-ironic18:00
Madasibut they are wanting to do so through something other than freeform tags?18:00
Madasilike dedicated fields for that type of thing?18:01
Madasithat would get messy18:01
openstackgerritJulia Kreger proposed openstack/bifrost: Initial support for installation of ironic-inspector  https://review.openstack.org/22993018:01
jrollMadasi: line 66 https://etherpad.openstack.org/p/mitaka-ironic-design-summit-ideas18:01
jrollmaybe not special fields, dunno18:01
jrollrloo: so now, driver composition before or after driver API :)18:02
jrollre-worded, early morning or late afternoon18:03
openstackgerritJulia Kreger proposed openstack/bifrost: Initial addition of an inspection module  https://review.openstack.org/23274518:03
rloojroll: hmm. both bad times.18:03
jrollhehe18:03
jrollI vote 9:50 I think18:03
openstackgerritJulia Kreger proposed openstack/bifrost: WIP: Additional inspection role and adding role to NV job script  https://review.openstack.org/23274618:04
rloojroll: i think driver composition before. i don't think we'll be able to do detailed stuff wrt driver api so that can wait til the aft when i'm tired.18:04
jrollrloo: ok, that's what I did. my proposed schedule is on the pad if you want to take a look18:05
rlooi don't think we can have group management if it conflicts with wanyen's talk18:05
rloojroll: i thought wanyen was going to propose a spec for group management18:06
jrolloh yeah, meant to switch those two18:06
jrollyep18:06
jrolljust switched them18:06
rloojroll: what is naohirot talking about?18:06
jrollrloo: making ironic truly open and reliable18:07
jrollhttps://openstacksummitoctober2015tokyo.sched.org/event/92e6d1c440398cbe3898e009023a416c18:07
Madasithat spec is so vague, and different from the talk in the etherpad18:07
jrollMadasi: the group management thing? yeah, that one is a *third* proposal on how to do it18:07
jrollMadasi: HP is going to put up a spec for hw-specific group management stuff18:08
Madasithe part about hardware support in place of tags makes some sense, as source of truth, but has some pitfalls as well if you plan on having more than one hardware type in your fleet18:08
jrollyeah, totally18:09
Madasii'll wait until you get something more solid after the summit, before I start meddling :)18:10
jrollheh18:10
Madasibut I'd totally go to that session18:10
jrollI suspect we will do tags + vendor stuff18:10
rloojroll: the schedule seems fine. i was wondering what naohirot might want to attend, but that's the only non-ops time for the driver API.18:12
rloojroll: and anyway, naohirot's driver is upstream.18:12
jrollrloo: yeah, not much we can do there18:12
*** ijw has joined #openstack-ironic18:14
*** e0ne has quit IRC18:15
*** ukalifon1 has quit IRC18:17
*** ijw_ has joined #openstack-ironic18:18
*** ifarkas has quit IRC18:18
*** ijw has quit IRC18:19
*** ukalifon has joined #openstack-ironic18:19
*** e0ne has joined #openstack-ironic18:20
*** achanda has quit IRC18:25
sambettsNight all o/18:27
*** ukalifon has quit IRC18:27
NobodyCamnight sambetts18:28
*** trown|lunch is now known as trown18:28
*** linggao has joined #openstack-ironic18:29
*** mehip has joined #openstack-ironic18:34
linggaoHi ironic, what are the best docs to use to install vanilla openstack and ironic (not devstack)?  Start with http://docs.openstack.org/kilo/install-guide/install/apt/content/ and then do http://docs.openstack.org/developer/ironic/deploy/install-guide.html ?18:35
*** david-lyle has quit IRC18:35
jrolllinggao: I'm not 100% sure, but yes that sounds like a good start18:36
*** mehip has quit IRC18:38
linggaook, it seems quite long :-).18:38
jrollit's a complex system :)18:38
linggaoyes. true.18:39
*** david-lyle has joined #openstack-ironic18:39
*** mehip has joined #openstack-ironic18:39
*** harshs has quit IRC18:40
*** mehip has quit IRC18:40
*** david-ly_ has joined #openstack-ironic18:40
openstackgerritMerged openstack/ironic: Fixes logging of failure in deletion of swift temporary object  https://review.openstack.org/23244018:41
*** mehip has joined #openstack-ironic18:41
NobodyCamlinggao: would love to review a doc patch on whats required to get things set up (/shameless plug)18:41
linggaoNobodyCam,  really wish installation of openstack is easy. :-)18:43
*** david-ly_ has quit IRC18:43
NobodyCam:)18:43
*** kkoski has joined #openstack-ironic18:44
*** david-ly_ has joined #openstack-ironic18:44
*** david-lyle has quit IRC18:44
*** lucas-dinner has quit IRC18:44
*** david-ly_ is now known as david-lyle18:45
*** david-lyle has quit IRC18:45
*** david-lyle has joined #openstack-ironic18:47
*** trown is now known as trown|mtg18:48
openstackgerritAllan Vidal proposed stackforge/pyghmi: Fix TS inventory parsing bugs (DIMM, PSU).  https://review.openstack.org/23493018:50
openstackgerritAllan Vidal proposed stackforge/pyghmi: Add support for event ack timeout setting.  https://review.openstack.org/23493118:50
praneshplinggao: you can try  https://github.com/stackforge/anvil if you are using rpm based installs, there is an irc room at #openstack-anvil18:54
linggaopraneshp, I will take a look. thanks!18:56
*** harshs has joined #openstack-ironic18:56
*** Nisha_away has quit IRC18:56
jrollwheeeeeeeeeeeeeeee. https://etherpad.openstack.org/p/summit-mitaka-ironic18:57
jrollall things summit.18:57
*** Nisha_away has joined #openstack-ironic18:57
jrollsched.org also has descriptions and etherpads for everything18:57
*** mehip has quit IRC18:57
*** penick has quit IRC18:58
*** david-lyle has quit IRC19:00
NobodyCamjroll: awesome!!!!!19:03
jroll:)19:04
* jroll afks a while19:06
*** david-lyle has joined #openstack-ironic19:08
*** achanda has joined #openstack-ironic19:09
*** hongbin has joined #openstack-ironic19:11
*** vilobhmm11 has joined #openstack-ironic19:12
*** penick has joined #openstack-ironic19:25
*** david-lyle has quit IRC19:25
*** david-ly_ has joined #openstack-ironic19:25
*** mehip has joined #openstack-ironic19:29
*** Marga_ has quit IRC19:33
*** david-ly_ has quit IRC19:38
*** david-lyle has joined #openstack-ironic19:38
*** david-lyle has quit IRC19:39
*** david-lyle has joined #openstack-ironic19:41
*** trown|mtg is now known as trown19:43
*** priteau has quit IRC19:43
*** e0ne has quit IRC19:49
*** dprince has quit IRC19:51
openstackgerritMerged openstack/ironic: Updated from global requirements  https://review.openstack.org/23466419:54
openstackgerritMerged openstack/ironic: Fix an annoying detail in the developer quick-start  https://review.openstack.org/23478319:54
openstackgerritMerged openstack/bifrost: Fix boot.ipxe config behavior to ensure proper use  https://review.openstack.org/23303919:54
*** david-lyle has quit IRC19:56
openstackgerritAllan Vidal proposed stackforge/pyghmi: Fix TS inventory parsing bugs (DIMM, PSU)  https://review.openstack.org/23495319:56
jlvillalTheJulia: This made me think of Bifrost: https://openstacksummitoctober2015tokyo.sched.org/event/8cdc4e5a816f22bf2978e8869173de2719:58
*** david-lyle has joined #openstack-ironic19:58
*** achanda has quit IRC20:00
*** meghal has quit IRC20:00
*** david-ly_ has joined #openstack-ironic20:01
*** david-lyle has quit IRC20:03
*** david-ly_ is now known as david-lyle__20:03
*** david-lyle__ is now known as david-lyle___20:03
*** meghal has joined #openstack-ironic20:03
*** Marga_ has joined #openstack-ironic20:03
*** hongbin has left #openstack-ironic20:04
*** Nisha_away has quit IRC20:05
*** david-lyle has joined #openstack-ironic20:06
*** david-lyle___ has quit IRC20:06
*** Sukhdev has quit IRC20:07
*** Marga_ has quit IRC20:09
*** meghal has left #openstack-ironic20:10
openstackgerritThiago Paiva Brito proposed openstack/ironic: [WIP] Power off the machine before set_boot_devic  https://review.openstack.org/23218620:13
openstackgerritAllan Vidal proposed stackforge/pyghmi: Change acknowledgement_timeout to acknowledge_timeout  https://review.openstack.org/23496220:13
mrdaMorning Ironic20:15
thiagopmorning mrda20:16
*** ionutbalutoiu has joined #openstack-ironic20:16
*** sambetts has quit IRC20:17
mrdao/20:17
*** sambetts has joined #openstack-ironic20:18
NobodyCammornign mrda20:22
thiagopGuys, quick question:20:23
thiagopI'm validating a node that has "deploy_kernel" and "deploy_ramdisk" on driver_info20:24
thiagopthe validation says that the node should have "kernel", "ramdisk" and "image_source"20:25
thiagopby the installation guide, it shouldn't be happening when I have deploy_kernel/deploy_ramdisk. Right?20:26
mrdathiagop: so you can get incorrect error messages if an exception gets thrown in validation20:29
mrdaif you expect that deploy_kernel and deploy_ramdisk is all you need, verify that the paths for these are correct with right permissions20:30
*** baoli has joined #openstack-ironic20:32
*** Sukhdev has joined #openstack-ironic20:33
thiagopmrda: looking at pxe code now, I think it shouldn't be calling both _parse_driver_info and _parse_instance_info this way20:33
*** baoli_ has joined #openstack-ironic20:33
thiagopit'll never validate the node if it's not on a deploy process...20:34
*** ijw_ has quit IRC20:36
*** baoli has quit IRC20:37
*** achanda has joined #openstack-ironic20:41
*** achanda has quit IRC20:41
*** achanda has joined #openstack-ironic20:44
*** afaranha has quit IRC20:45
openstackgerritChris Krelle proposed openstack/bifrost: Follow up to 233039  https://review.openstack.org/23497720:46
spandheHi folks, have a question about nova/virt/ironic/driver20:51
*** Marga_ has joined #openstack-ironic20:51
spandheif deploy fails due to timeout, we call detroy: https://github.com/openstack/nova/blob/master/nova/virt/ironic/driver.py#L83620:51
spandheany reason why need to do that in the driver? nova/compute/manager can call _shutdown_instance on seeing RescheduleException, which can trigger destroy.20:52
spandhehttps://github.com/openstack/nova/blob/master/nova/compute/manager.py#L2186-L219020:53
spandherloo: ^ any idea about this?20:54
*** Marga_ has quit IRC20:55
openstackgerritMonty Taylor proposed openstack/python-ironicclient: Remove lxml requirement  https://review.openstack.org/23497920:56
*** achanda has quit IRC20:56
*** harshs has quit IRC20:57
*** mehip has quit IRC20:57
openstackgerritSean Dague proposed openstack/ironic: remove lxml requirement  https://review.openstack.org/23498120:57
rloospandhe: I don't know, although it seems to make sense to me that if the driver if checking for timeout, that it destroys.20:57
rloospandhe: why do you think the nova/compute/manager should handle it?20:58
*** kozhukalov_ has quit IRC20:58
spandherloo: https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L2186-L219020:59
*** mehip has joined #openstack-ironic20:59
rloospandhe: I don't know enough about nova and the interface between nova and the driver, to know which/where that should be done. do other drivers let nova/compute/manager handle it?21:01
spandherloo: checking that now. but basically destroy will be called multiple times due to save_and_reraise21:02
rloospandhe: which could be the case of 'if you ain't sure it will be called up the stack, call it now, cuz at least it'll be called once instead of being missed'?21:02
jrollcan I get a core to land this silly patch please? :) https://review.openstack.org/#/c/234979/21:03
spandherloo: thats what I am trying to understand.. is there a case where nova compute wont call destroy?21:03
rloospandhe: i dunno. maybe ask the nova folks?21:04
jrollspandhe: that's a good question, hm21:05
*** mrmoje has quit IRC21:07
spandherloo: jroll I will ask nova folks.. was just trying to see if anyone already knows why destroy was being called over there21:07
*** harshs has joined #openstack-ironic21:08
jrollspandhe: I know it's called, I'm not sure as to why :)21:08
*** trown is now known as trown|outttypeww21:08
rloospandhe: my quick look seems to indicate that they are two different 'reasons'. i mean, it seems to make sense to destroy in both those cases.21:09
*** praneshp_ has joined #openstack-ironic21:09
spandherloo: nova compute is going to raise  RescheduleException for all ironic driver exceptions/21:10
spandherloo: and RescheduleException is always going to trigger _shutdown_instance21:10
*** ionutbalutoiu has quit IRC21:10
rloospandhe: i go back to the 'agreement' or whatever between nova and the drivers.21:10
*** praneshp has quit IRC21:10
jrollspandhe: my best guess is that it's there to make darn sure we clean up if something goes wrong, as nova does a whole bunch of stuff in _shutdown_instance() before calling destroy(). but IMBW21:11
openstackgerritMerged stackforge/pyghmi: Change acknowledgement_timeout to acknowledge_timeout  https://review.openstack.org/23496221:12
*** praneshp has joined #openstack-ironic21:12
*** achanda has joined #openstack-ironic21:12
*** praneshp_ has quit IRC21:13
spandhejroll: ok.. let me dig a bit more into this. Ill get back. My problem is, I have patched shutdown_instance to deallocate network first and then call destroy. But when the driver triggers destroy on its own, my patch gets skipped and the network stays..21:15
jrollspandhe: we re-raise the exception, so shutdown_instance should still get called, right?21:16
jrolloh, it isn't a rescheduledException21:16
jrollbla21:16
spandhejroll: we reraise in virt driver. nova compute catches that and raises rescheduleException21:17
jrollspandhe: then it should still call shutdown_instance, right?21:17
*** hblixt has joined #openstack-ironic21:18
spandhejroll: so nova compute does call shutdown_instance. but destroy has already happened21:18
spandheonce21:18
spandheand it will happen again with shutdown_instance21:18
jrollyeah, something is wrong here21:19
jrollthis does totally work21:19
jrollbut now I don't know why :/21:19
*** linggao has quit IRC21:20
*** mrmoje has joined #openstack-ironic21:23
spandhejroll: ill find out :)21:24
jrollspandhe: please do file a bug though, this needs to be cleaned up. file it in nova with an ironic tag21:25
spandhejroll: ok.. will do.. thanks!21:25
jrollthank you for pointing this out :)21:25
jrollrloo: one more :P https://review.openstack.org/#/c/234981/21:26
rloojroll: i was wondering when that one would appear :)21:27
jrollhah21:27
jrollI got distracted21:27
*** penick has quit IRC21:31
*** penick has joined #openstack-ironic21:31
*** mehip has quit IRC21:31
thiagopguys, I'm calling it a day21:31
thiagopsee you tomorrow21:32
*** penick has quit IRC21:32
*** thiagop has quit IRC21:32
*** penick has joined #openstack-ironic21:34
*** harshs has quit IRC21:34
*** Marga_ has joined #openstack-ironic21:36
mrdayay for removing unneeded requirements!21:37
NobodyCamboo for gate failures21:41
mrda:(21:41
*** praneshp has quit IRC21:41
* jroll rechecks21:43
*** harshs has joined #openstack-ironic21:43
* jroll needs to figure out what that intermittent bug is21:43
*** penick has quit IRC21:43
Madasispandhe: it looks like the place you indicated in the compute manager calls _shutdown_instance only in a very small window of build time, does anything call it in https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L2023-L2070 where other build exceptions are caught?21:44
*** praneshp has joined #openstack-ironic21:45
openstackgerritStephanie Miller proposed openstack/bifrost: Initial support for installation of ironic-inspector  https://review.openstack.org/22993021:46
*** thrash is now known as thrash|g0ne21:48
*** achanda has quit IRC21:48
jrolljlvillal: hey, is it cool if I mark you QA liasion here? https://wiki.openstack.org/wiki/CrossProjectLiaisons#QA21:49
*** praneshp has quit IRC21:49
jlvillaljroll: Sounds reasonable to me. Thanks.21:50
jrollthank YOU21:50
*** vilobhmm11 has left #openstack-ironic21:51
*** bigjools_ is now known as bigjools21:52
*** bigjools has quit IRC21:52
*** bigjools has joined #openstack-ironic21:52
rloospandhe: is this useful: https://review.openstack.org/#/c/99519/21:52
spandherloo: it does. Thanks!21:54
rloospandhe: i sometimes wonder if we should add more comments in the code but anyway.21:54
jrolloh wow, I touched that21:55
* jroll runs away21:55
jroll(that bug anyway)21:56
rloojroll: you can run, but you cannot hide...21:56
jrollyes I can21:57
*** jroll has left #openstack-ironic21:57
*** jroll has joined #openstack-ironic21:57
jrollsee.21:57
rloojroll: yup, i see you :)21:59
*** baoli_ has quit IRC21:59
*** baoli has joined #openstack-ironic22:00
*** baoli has quit IRC22:00
*** baoli has joined #openstack-ironic22:01
*** [1]cdearborn has quit IRC22:02
openstackgerritMerged openstack/ironic: ucs_hostname changed to ucs_address  https://review.openstack.org/23283422:03
openstackgerritMerged openstack/ironic: Remove functions: _cleanse_dict & format_message  https://review.openstack.org/23371822:03
spandheMadasi: are any of those exception raised by ironic driver?22:03
*** meghal1 has joined #openstack-ironic22:07
*** jamielennox|away is now known as jamielennox22:07
spandherloo: jroll , in that review, I think shutdown_instance was not happening because we were not catching exception. maybe nova code was fixed after that to catch all exceptions, call _shutdown_instance and reraise22:09
rloospandhe: would need to go through history/whatever to see what happened.22:10
rloospandhe: oh, i have to take off now. later.22:10
spandherloo: ok.. talk to you tomorrow!22:10
jrollyeah, I have no clue myself :)22:10
openstackgerritMerged openstack/python-ironicclient: Remove lxml requirement  https://review.openstack.org/23497922:10
NobodyCamhave a good night rloo :)22:10
spandhejroll: ill open a bug.. I see that till Icehouse, nova-compute was not calling shutdown_instance https://github.com/openstack/nova/blob/2014.1.5/nova/compute/manager.py#L2116-L211822:14
spandhejroll: seems like this needs some discussion22:14
jrollspandhe: agree, thanks22:14
*** achanda has joined #openstack-ironic22:15
* jlvillal wishes he could have days without meetings....22:24
* jlvillal thinks five hours is too much for one day.22:25
Madasispandhe: a few.22:25
Madasihttps://github.com/openstack/nova/blob/master/nova/virt/ironic/driver.py#L823-L827 calls _wait_for_active which can raise InstanceDeployFailure https://github.com/openstack/nova/blob/master/nova/virt/ironic/driver.py#L43622:26
spandheMadasi: ok.. ironic virt driver calls destroy beforehand only in one case - callback timeout.22:26
Madasiwhich would be caught and trigger driver's destroy, then reraised22:27
spandheMadasi: right.22:27
Madasihmm, that isn't the one I thought it was :(22:27
Madasiwait, this was it22:28
spandheMadasi: yes :) The exception tha you pointed out, gets handled in nova compute: https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L2173-L219122:28
jrollspandhe: are you sure? it looks like ironic driver calls it on any exception22:28
Madasi_wait_for_Active can also throw InstanceNotFound - https://github.com/openstack/nova/blob/master/nova/virt/ironic/driver.py#L449-L45422:28
Madasithat one is caught and just creates a create.end notification - https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L202322:29
*** harshs has quit IRC22:29
spandhejroll: any exception that happens during deployment: https://github.com/openstack/nova/blob/master/nova/virt/ironic/driver.py#L826-L836 but thats because the deployment has already started by then.22:29
*** Sukhdev has quit IRC22:30
Madasiyes, that's the only time driver calls destroy22:30
jrollspandhe: any of these https://github.com/openstack/nova/blob/master/nova/virt/ironic/driver.py#L431-L46222:30
spandheMadasi: ok.. lets take the scenario youmentioned.22:30
spandheInstanceNotFound22:30
jrollInstanceDeployFailure, InstanceNotFound, I assume connection failures may be raised, etc22:30
Madasispandhe: it gets caught there, in the resources yield, but what about later like https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L201622:31
spandhejroll: right.. all of these will be caught in yield22:32
spandhehttps://github.com/openstack/nova/blob/master/nova/compute/manager.py#L2173-L219122:32
*** harshs has joined #openstack-ironic22:32
spandheMadasi: when it gets caught in resouces yield, shutdown_instance gets called22:32
spandheMadasi: right? So shutdown happened. which means destroy also happened..22:33
Madasispandhe: don't think so22:33
Madasithat yield exception catching is part of _build_resources22:33
spandheMadasi: jroll my point is, because of https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L2173 , all the exceptions now get caught and shutdown instance always gets called22:33
jrollah, you may be right22:34
jrollok I'd agree it is a bug22:34
Madasihttps://github.com/openstack/nova/blob/master/nova/compute/manager.py#L2001 is the call to spawn, and isn't using resources, only what was already retrieved from it22:34
Madasiand the wait_for_active is part of spawn22:34
jrollbuild_and_run_instance calls spawn() within the _build_resources context manager though22:35
Madasihmm, true22:36
jrollso yeah, I agree this is a bug22:36
* jroll got confused with all the indirection22:36
Madasiso, why the long except block at https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L2023-L207022:36
Madasiseems weird then22:36
spandhejroll: It is very confusing..22:36
jroll:)22:37
spandheMadasi: I am guessing for other drivers?22:37
spandheMadasi: exceptions like InstanceNotFound will still be reraised, right? Even thought shutdown n all happened?22:38
spandheAnd looks like thats the only places that closes the create loop with notification: end/error etc22:39
Madasiwill it?22:41
Madasii mean it will, but changed to a BuildAbortException, right? https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L2191-L219522:42
spandheMadasi: I think so.. because yield resouces will reraise the exception after shutdown_instance.. right?22:42
spandheMadasi: that is if shutdown_instance also fails22:42
Madasiwait, yeah22:42
Madasiso yes22:42
spandheMadasi: thats another problem actually.. so if shutdown_instance also fails, original exception gets masked22:43
Madasiyou are correctm b/c initial handling is with save_and_reraise22:43
Madasispandhe: not just masked, also aborts build attempt22:43
Madasihence the not reschedulign message22:43
Madasiwhich is why it is changing the exception type i'm sure22:44
spandheMadasi: but the problem is, we dont find out why original deployment failed in the first place.. that can be annoying if you are booting hundreds of node concurrently22:45
spandhewhen looking at logs is not an option22:45
*** achanda has quit IRC22:45
* jroll wonders out loud to Madasi about what makes this work properly in our production (getting the actual exception and such)22:46
*** openstackgerrit has quit IRC22:46
*** openstackgerrit has joined #openstack-ironic22:47
*** achanda has joined #openstack-ironic22:47
*** achanda has quit IRC22:47
Madasijroll: it probably doesn't22:47
jrollMadasi: we do get the exception ironic through back22:47
Madasithat's probably the second error we see when someone deletes while building22:47
jrollthrew*22:47
jrollomg. it all makes sense.22:47
jrollso yeah, the second delete would trigger "can't delete node while in cleaning" and such.22:48
Madasithis is why node cleanup failures are fatal to the build probably, and 99% of the ones we see are delete while building22:50
jrollyeah22:51
Madasiguess I know the next section of ironic/nova code I should try to make sense of22:52
Madasispandhe: nice find22:54
spandheMadasi: thanks :) Will create a bug for destroy issue.. Should I also create a nova bug for exception issue?22:56
*** baoli has quit IRC22:57
jrollcreate a bug for everything you think should be fixed :)22:58
Madasiyeah, I imagine the exception one might get some debate, since the exception changing is probably deliberate22:59
Madasibut doesn't mean it shouldn't be filed22:59
*** jobewan has joined #openstack-ironic23:00
*** Sukhdev has joined #openstack-ironic23:01
spandhejroll: Madasi ok :) Created https://bugs.launchpad.net/nova-hyper/+bug/150623423:04
openstackLaunchpad bug 1506234 in nova-hyper "Ironic virt driver in Nova calls destroy unnecessarily if spawn fails" [Undecided,New]23:04
openstackgerritStephanie Miller proposed openstack/bifrost: Initial support for installation of ironic-inspector  https://review.openstack.org/22993023:05
*** achanda has joined #openstack-ironic23:09
jrollspandhe: nova-hyper?23:12
spandhejroll:  changed that to Nova :)23:12
jrollheh, cool23:12
jrollthanks!23:12
spandhejroll: does Ironic team look after the driver or nova team? Who will be reviewing the patchset for this?23:14
jrollspandhe: some of both; only nova team can approve it but we'll also review it23:14
jrollwe have ironic folks that watch over nova bugs etc, it will get on our radar23:15
spandhejroll: ok.. good to know.. thanks!23:15
jrollwelcome :)23:15
*** hblixt has quit IRC23:15
*** dims_ has joined #openstack-ironic23:19
*** dims has quit IRC23:22
*** [1]cdearborn has joined #openstack-ironic23:34
*** priteau has joined #openstack-ironic23:44
*** harshs has quit IRC23:47
*** harshs has joined #openstack-ironic23:48
*** priteau has quit IRC23:48
*** harshs has quit IRC23:48
*** penick has joined #openstack-ironic23:56
*** smoriya has joined #openstack-ironic23:57
*** mgoddard_ has joined #openstack-ironic23:57
*** mgoddard has quit IRC23:57
*** jobewan has quit IRC23:58
*** Haomeng|2 has joined #openstack-ironic23:58
*** praneshp has joined #openstack-ironic23:59

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!